/b-gtk/fix-viz

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/b-gtk/fix-viz

« back to all changes in this revision

Viewing changes to branch.py

  • Committer: Adrian Wilkins
  • Date: 2008-04-24 15:26:14 UTC
  • mto: This revision was merged to the branch mainline in revision 470.
  • Revision ID: adrian.wilkins@gmail.com-20080424152614-2rnnljbro6vzqvf7
Detect the reserved null: revision in appropriate places. 

This removes a huge shower of stack traces that get dumped to console when 
you look at the bottom of a log.

Show diffs side-by-side

added added

removed removed

Lines of Context:
27
27
from errors import show_bzr_error
28
28
 
29
29
from bzrlib.branch import Branch
30
 
from bzrlib.config import GlobalConfig
31
30
import bzrlib.errors as errors
32
31
 
33
32
from dialog import error_dialog, info_dialog
34
33
 
35
 
from history import UrlHistory
36
 
from olive import Preferences
 
34
from branchbox import BranchSelectionBox
37
35
 
38
36
class BranchDialog(gtk.Dialog):
39
37
    """ New implementation of the Branch dialog. """
50
48
        
51
49
        # Create the widgets
52
50
        self._button_branch = gtk.Button(_("_Branch"), use_underline=True)
 
51
        self._remote_branch = BranchSelectionBox()
53
52
        self._button_revision = gtk.Button('')
54
 
        self._image_browse = gtk.Image()
55
 
        self._filechooser = gtk.FileChooserButton(_("Please select a folder"))
56
 
        self._combo = gtk.ComboBoxEntry()
57
53
        self._label_location = gtk.Label(_("Branch location:"))
 
54
        self._label_location.set_alignment(0, 0.5)
58
55
        self._label_destination = gtk.Label(_("Destination:"))
59
56
        self._label_nick = gtk.Label(_("Branck nick:"))
60
57
        self._label_revision = gtk.Label(_("Revision:"))
 
58
        self._filechooser = gtk.FileChooserButton(_("Please select a folder"))
 
59
        self._filechooser.set_action(gtk.FILE_CHOOSER_ACTION_SELECT_FOLDER)
61
60
        self._hbox_revision = gtk.HBox()
62
61
        self._entry_revision = gtk.Entry()
63
62
        self._entry_nick = gtk.Entry()
65
64
        # Set callbacks
66
65
        self._button_branch.connect('clicked', self._on_branch_clicked)
67
66
        self._button_revision.connect('clicked', self._on_revision_clicked)
68
 
        self._combo.child.connect('focus-out-event', self._on_combo_changed)
69
 
        
 
67
        self._remote_branch.connect('branch-changed', self._on_branch_changed)
 
68
 
70
69
        # Create the table and pack the widgets into it
71
70
        self._table = gtk.Table(rows=3, columns=2)
72
71
        self._table.attach(self._label_location, 0, 1, 0, 1)
 
72
        self._table.attach(self._remote_branch, 1, 2, 0, 1)
73
73
        self._table.attach(self._label_destination, 0, 1, 1, 2)
74
74
        self._table.attach(self._label_nick, 0, 1, 2, 3)
75
75
        self._table.attach(self._label_revision, 0, 1, 3, 4)
76
 
        self._table.attach(self._combo, 1, 2, 0, 1)
77
76
        self._table.attach(self._filechooser, 1, 2, 1, 2)
78
77
        self._table.attach(self._entry_nick, 1, 2, 2, 3)
79
78
        self._table.attach(self._hbox_revision, 1, 2, 3, 4)
80
79
        
81
80
        # Set properties
 
81
        self._image_browse = gtk.Image()
82
82
        self._image_browse.set_from_stock(gtk.STOCK_OPEN, gtk.ICON_SIZE_BUTTON)
83
83
        self._button_revision.set_image(self._image_browse)
84
84
        self._button_revision.set_sensitive(False)
85
 
        self._filechooser.set_action(gtk.FILE_CHOOSER_ACTION_SELECT_FOLDER)
86
 
        self._label_location.set_alignment(0, 0.5)
87
85
        self._label_destination.set_alignment(0, 0.5)
88
86
        self._label_nick.set_alignment(0, 0.5)
89
87
        self._label_revision.set_alignment(0, 0.5)
90
88
        self._table.set_row_spacings(3)
91
89
        self._table.set_col_spacings(3)
92
90
        self.vbox.set_spacing(3)
 
91
        if remote_path is not None:
 
92
            self._remote_branch.set_url(remote_path)
93
93
        if self.path is not None:
94
94
            self._filechooser.set_filename(self.path)
95
 
        if remote_path is not None:
96
 
            self._combo.child.set_text(remote_path)
97
95
        
98
96
        # Pack some widgets
99
97
        self._hbox_revision.pack_start(self._entry_revision, True, True)
103
101
        
104
102
        # Show the dialog
105
103
        self.vbox.show_all()
106
 
        
107
 
        # Build branch history
108
 
        self._history = UrlHistory(GlobalConfig(), 'branch_history')
109
 
        self._build_history()
110
 
    
111
 
    def _build_history(self):
112
 
        """ Build up the branch history. """
113
 
        self._combo_model = gtk.ListStore(str)
114
 
        
115
 
        for item in self._history.get_entries():
116
 
            self._combo_model.append([ item ])
117
 
        
118
 
        pref = Preferences()
119
 
        for item in pref.get_bookmarks():
120
 
            self._combo_model.append([ item ])
121
 
        
122
 
        self._combo.set_model(self._combo_model)
123
 
        self._combo.set_text_column(0)
124
104
    
125
105
    def _get_last_revno(self):
126
106
        """ Get the revno of the last revision (if any). """
127
 
        location = self._combo.get_child().get_text()
128
107
        try:
129
 
            br = Branch.open(location)
130
 
        except:
131
 
            return None
132
 
        else:
 
108
            br = self._remote_branch.get_branch()
133
109
            return br.revno()
 
110
        except:
 
111
            pass
134
112
    
135
113
    def _on_revision_clicked(self, button):
136
114
        """ Browse for revision button clicked handler. """
137
115
        from revbrowser import RevisionBrowser
138
116
        
139
 
        location = self._combo.get_child().get_text()
140
117
        
141
118
        try:
142
 
            br = Branch.open(location)
 
119
            br = self._remote_branch.get_branch()
143
120
        except:
144
121
            return
145
 
        else:
146
 
            revb = RevisionBrowser(br, self)
147
 
            response = revb.run()
148
 
            if response != gtk.RESPONSE_NONE:
149
 
                revb.hide()
 
122
        revb = RevisionBrowser(br, self)
 
123
        response = revb.run()
 
124
        if response != gtk.RESPONSE_NONE:
 
125
            revb.hide()
 
126
    
 
127
            if response == gtk.RESPONSE_OK:
 
128
                if revb.selected_revno is not None:
 
129
                    self._entry_revision.set_text(revb.selected_revno)
150
130
        
151
 
                if response == gtk.RESPONSE_OK:
152
 
                    if revb.selected_revno is not None:
153
 
                        self._entry_revision.set_text(revb.selected_revno)
154
 
            
155
 
                revb.destroy()
 
131
            revb.destroy()
156
132
    
157
133
    @show_bzr_error
158
134
    def _on_branch_clicked(self, button):
159
135
        """ Branch button clicked handler. """
160
 
        location = self._combo.get_child().get_text()
 
136
        location = self._remote_branch.get_url()
161
137
        if location is '':
162
138
            error_dialog(_('Missing branch location'),
163
139
                         _('You must specify a branch location.'))
201
177
        finally:
202
178
            br_from.unlock()
203
179
                
204
 
        self._history.add_entry(location)
205
180
        info_dialog(_('Branching successful'),
206
181
                    _('%d revision(s) branched.') % revs)
207
182
        
208
183
        self.response(gtk.RESPONSE_OK)
209
184
    
210
 
    def _on_combo_changed(self, widget, event):
 
185
    def _on_branch_changed(self, widget, event):
211
186
        """ We try to get the last revision if focus lost. """
212
187
        rev = self._get_last_revno()
213
188
        if rev is None:
217
192
            self._entry_revision.set_text(str(rev))
218
193
            self._button_revision.set_sensitive(True)
219
194
            if self._entry_nick.get_text() == '':
220
 
                self._entry_nick.set_text(os.path.basename(self._combo.get_child().get_text().rstrip("/\\")))
 
195
                self._entry_nick.set_text(os.path.basename(self._remote_branch.get_url().rstrip("/\\")))