/b-gtk/fix-viz

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/b-gtk/fix-viz

« back to all changes in this revision

Viewing changes to revisionview.py

  • Committer: Jelmer Vernooij
  • Date: 2008-05-04 18:28:46 UTC
  • Revision ID: jelmer@samba.org-20080504182846-z98bsigxxnly8b6n
Disable signature tab until we actually start verifying the testament.

Show diffs side-by-side

added added

removed removed

Lines of Context:
15
15
# along with this program; if not, write to the Free Software
16
16
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
17
17
 
18
 
from gi.repository import Gtk
19
 
from gi.repository import Pango
20
 
from gi.repository import GObject
21
 
import webbrowser
 
18
import pygtk
 
19
pygtk.require("2.0")
 
20
import gtk
 
21
import pango
 
22
import gobject
 
23
import subprocess
22
24
 
23
 
from bzrlib import trace
 
25
from bzrlib.plugins.gtk import icon_path
24
26
from bzrlib.osutils import format_date
25
 
from bzrlib.bencode import bdecode
26
 
from bzrlib.testament import Testament
27
 
 
28
 
from bzrlib.plugins.gtk import icon_path
29
 
 
30
 
from bzrlib.plugins.gtk.avatarsbox import AvatarsBox
 
27
from bzrlib.util.bencode import bdecode
31
28
 
32
29
try:
33
30
    from bzrlib.plugins.gtk import seahorse
41
38
PAGE_SIGNATURE = 2
42
39
PAGE_BUGS = 3
43
40
 
44
 
 
45
41
def _open_link(widget, uri):
46
 
    for cmd in ['sensible-browser', 'xdg-open']:
47
 
        if webbrowser._iscommand(cmd):
48
 
            webbrowser._tryorder.insert(0, '%s "%%s"' % cmd)
49
 
    webbrowser.open(uri)
50
 
 
51
 
 
52
 
class BugsTab(Gtk.VBox):
 
42
    subprocess.Popen(['sensible-browser', uri], close_fds=True)
 
43
 
 
44
gtk.link_button_set_uri_hook(_open_link)
 
45
 
 
46
class BugsTab(gtk.VBox):
53
47
 
54
48
    def __init__(self):
55
 
        super(BugsTab, self).__init__(homogeneous=False, spacing=6)
56
 
 
57
 
        table = Gtk.Table(rows=2, columns=2)
 
49
        super(BugsTab, self).__init__(False, 6)
 
50
    
 
51
        table = gtk.Table(rows=2, columns=2)
58
52
 
59
53
        table.set_row_spacings(6)
60
54
        table.set_col_spacing(0, 16)
61
55
 
62
 
        image = Gtk.Image()
 
56
        image = gtk.Image()
63
57
        image.set_from_file(icon_path("bug.png"))
64
 
        table.attach(image, 0, 1, 0, 1, Gtk.AttachOptions.FILL)
 
58
        table.attach(image, 0, 1, 0, 1, gtk.FILL)
65
59
 
66
 
        align = Gtk.Alignment.new(0.0, 0.1, 0, 0)
67
 
        self.label = Gtk.Label()
 
60
        align = gtk.Alignment(0.0, 0.1)
 
61
        self.label = gtk.Label()
68
62
        align.add(self.label)
69
 
        table.attach(align, 1, 2, 0, 1, Gtk.AttachOptions.FILL)
 
63
        table.attach(align, 1, 2, 0, 1, gtk.FILL)
70
64
 
71
65
        treeview = self.construct_treeview()
72
 
        table.attach(treeview, 1, 2, 1, 2, Gtk.AttachOptions.FILL | Gtk.AttachOptions.EXPAND)
 
66
        table.attach(treeview, 1, 2, 1, 2, gtk.FILL | gtk.EXPAND)
73
67
 
74
68
        self.set_border_width(6)
75
 
        self.pack_start(table, False, True, 0)
 
69
        self.pack_start(table, expand=False)
76
70
 
77
71
        self.clear()
78
72
        self.show_all()
87
81
                (url, status) = bugline.split(" ")
88
82
                if status == "fixed":
89
83
                    self.add_bug(url, status)
90
 
 
 
84
        
91
85
        if self.num_bugs == 0:
92
86
            return
93
87
        elif self.num_bugs == 1:
100
94
                              "%d %s." % (self.num_bugs, label))
101
95
 
102
96
    def construct_treeview(self):
103
 
        self.bugs = Gtk.ListStore(GObject.TYPE_STRING, GObject.TYPE_STRING)
104
 
        self.treeview = Gtk.TreeView(model=self.bugs)
 
97
        self.bugs = gtk.ListStore(gobject.TYPE_STRING, gobject.TYPE_STRING)
 
98
        self.treeview = gtk.TreeView(self.bugs)
105
99
        self.treeview.set_headers_visible(False)
106
100
 
107
 
        uri_column = Gtk.TreeViewColumn('Bug URI', Gtk.CellRendererText(), text=0)
 
101
        uri_column = gtk.TreeViewColumn('Bug URI', gtk.CellRendererText(), text=0)
108
102
        self.treeview.append_column(uri_column)
109
103
 
110
104
        self.treeview.connect('row-activated', self.on_row_activated)
111
105
 
112
 
        win = Gtk.ScrolledWindow()
113
 
        win.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
114
 
        win.set_shadow_type(Gtk.ShadowType.IN)
 
106
        win = gtk.ScrolledWindow()
 
107
        win.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
 
108
        win.set_shadow_type(gtk.SHADOW_IN)
115
109
        win.add(self.treeview)
116
110
 
117
111
        return win
136
130
        _open_link(self, uri)
137
131
 
138
132
 
139
 
class SignatureTab(Gtk.VBox):
 
133
class SignatureTab(gtk.VBox):
140
134
 
141
135
    def __init__(self, repository):
142
136
        self.key = None
143
137
        self.revision = None
144
138
        self.repository = repository
145
139
 
146
 
        super(SignatureTab, self).__init__(homogeneous=False, spacing=6)
147
 
        signature_box = Gtk.Table(rows=3, columns=3)
 
140
        super(SignatureTab, self).__init__(False, 6)
 
141
        signature_box = gtk.Table(rows=3, columns=3)
148
142
        signature_box.set_col_spacing(0, 16)
149
143
        signature_box.set_col_spacing(1, 12)
150
144
        signature_box.set_row_spacings(6)
151
145
 
152
 
        self.signature_image = Gtk.Image()
153
 
        signature_box.attach(self.signature_image, 0, 1, 0, 1, Gtk.AttachOptions.FILL)
 
146
        self.signature_image = gtk.Image()
 
147
        signature_box.attach(self.signature_image, 0, 1, 0, 1, gtk.FILL)
154
148
 
155
 
        align = Gtk.Alignment.new(0.0, 0.1, 0.0, 0.0)
156
 
        self.signature_label = Gtk.Label()
 
149
        align = gtk.Alignment(0.0, 0.1)
 
150
        self.signature_label = gtk.Label()
157
151
        align.add(self.signature_label)
158
 
        signature_box.attach(align, 1, 3, 0, 1, Gtk.AttachOptions.FILL)
 
152
        signature_box.attach(align, 1, 3, 0, 1, gtk.FILL)
159
153
 
160
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
161
 
        self.signature_key_id_label = Gtk.Label()
 
154
        align = gtk.Alignment(0.0, 0.5)
 
155
        self.signature_key_id_label = gtk.Label()
162
156
        self.signature_key_id_label.set_markup("<b>Key Id:</b>")
163
157
        align.add(self.signature_key_id_label)
164
 
        signature_box.attach(align, 1, 2, 1, 2, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
158
        signature_box.attach(align, 1, 2, 1, 2, gtk.FILL, gtk.FILL)
165
159
 
166
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
167
 
        self.signature_key_id = Gtk.Label()
 
160
        align = gtk.Alignment(0.0, 0.5)
 
161
        self.signature_key_id = gtk.Label()
168
162
        self.signature_key_id.set_selectable(True)
169
163
        align.add(self.signature_key_id)
170
 
        signature_box.attach(align, 2, 3, 1, 2, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
164
        signature_box.attach(align, 2, 3, 1, 2, gtk.EXPAND | gtk.FILL, gtk.FILL)
171
165
 
172
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
173
 
        self.signature_fingerprint_label = Gtk.Label()
 
166
        align = gtk.Alignment(0.0, 0.5)
 
167
        self.signature_fingerprint_label = gtk.Label()
174
168
        self.signature_fingerprint_label.set_markup("<b>Fingerprint:</b>")
175
169
        align.add(self.signature_fingerprint_label)
176
 
        signature_box.attach(align, 1, 2, 2, 3, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
170
        signature_box.attach(align, 1, 2, 2, 3, gtk.FILL, gtk.FILL)
177
171
 
178
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
179
 
        self.signature_fingerprint = Gtk.Label()
 
172
        align = gtk.Alignment(0.0, 0.5)
 
173
        self.signature_fingerprint = gtk.Label()
180
174
        self.signature_fingerprint.set_selectable(True)
181
175
        align.add(self.signature_fingerprint)
182
 
        signature_box.attach(align, 2, 3, 2, 3, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
176
        signature_box.attach(align, 2, 3, 2, 3, gtk.EXPAND | gtk.FILL, gtk.FILL)
183
177
 
184
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
185
 
        self.signature_trust_label = Gtk.Label()
 
178
        align = gtk.Alignment(0.0, 0.5)
 
179
        self.signature_trust_label = gtk.Label()
186
180
        self.signature_trust_label.set_markup("<b>Trust:</b>")
187
181
        align.add(self.signature_trust_label)
188
 
        signature_box.attach(align, 1, 2, 3, 4, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
182
        signature_box.attach(align, 1, 2, 3, 4, gtk.FILL, gtk.FILL)
189
183
 
190
 
        align = Gtk.Alignment.new(0.0, 0.5, 0.0, 0.0)
191
 
        self.signature_trust = Gtk.Label()
 
184
        align = gtk.Alignment(0.0, 0.5)
 
185
        self.signature_trust = gtk.Label()
192
186
        self.signature_trust.set_selectable(True)
193
187
        align.add(self.signature_trust)
194
 
        signature_box.attach(align, 2, 3, 3, 4, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
188
        signature_box.attach(align, 2, 3, 3, 4, gtk.EXPAND | gtk.FILL, gtk.FILL)
195
189
 
196
190
        self.set_border_width(6)
197
 
        self.pack_start(signature_box, False, True, 0)
 
191
        self.pack_start(signature_box, expand=False)
198
192
        self.show_all()
199
193
 
200
194
    def set_revision(self, revision):
222
216
                                        "This revision has not been signed.")
223
217
 
224
218
    def show_signature(self, crypttext):
225
 
        (cleartext, key) = seahorse.verify(crypttext)
226
 
 
227
 
        assert cleartext is not None
228
 
 
229
 
        inv = self.repository.get_inventory(self.revision.revision_id)
230
 
        expected_testament = Testament(self.revision, inv).as_short_text()
231
 
        if expected_testament != cleartext:
232
 
            self.signature_image.set_from_file(icon_path("sign-bad.png"))
233
 
            self.signature_label.set_markup("<b>Signature does not match repository data</b>\n" +
234
 
                        "The signature plaintext is different from the expected testament plaintext.")
235
 
            return
 
219
        key = seahorse.verify(crypttext)
236
220
 
237
221
        if key and key.is_available():
238
222
            if key.is_trusted():
284
268
        self.signature_trust.set_text('This key is ' + trust_text)
285
269
 
286
270
 
287
 
class RevisionView(Gtk.Notebook):
 
271
class RevisionView(gtk.Notebook):
288
272
    """ Custom widget for commit log details.
289
273
 
290
274
    A variety of bzr tools may need to implement such a thing. This is a
293
277
 
294
278
    __gproperties__ = {
295
279
        'branch': (
296
 
            GObject.TYPE_PYOBJECT,
 
280
            gobject.TYPE_PYOBJECT,
297
281
            'Branch',
298
282
            'The branch holding the revision being displayed',
299
 
            GObject.PARAM_CONSTRUCT_ONLY | GObject.PARAM_WRITABLE
 
283
            gobject.PARAM_CONSTRUCT_ONLY | gobject.PARAM_WRITABLE
300
284
        ),
301
285
 
302
286
        'revision': (
303
 
            GObject.TYPE_PYOBJECT,
 
287
            gobject.TYPE_PYOBJECT,
304
288
            'Revision',
305
289
            'The revision being displayed',
306
 
            GObject.PARAM_READWRITE
 
290
            gobject.PARAM_READWRITE
307
291
        ),
308
292
 
309
293
        'children': (
310
 
            GObject.TYPE_PYOBJECT,
 
294
            gobject.TYPE_PYOBJECT,
311
295
            'Children',
312
296
            'Child revisions',
313
 
            GObject.PARAM_READWRITE
 
297
            gobject.PARAM_READWRITE
314
298
        ),
315
299
 
316
300
        'file-id': (
317
 
            GObject.TYPE_PYOBJECT,
 
301
            gobject.TYPE_PYOBJECT,
318
302
            'File Id',
319
303
            'The file id',
320
 
            GObject.PARAM_READWRITE
 
304
            gobject.PARAM_READWRITE
321
305
        )
322
306
    }
323
307
 
324
308
    def __init__(self, branch=None, repository=None):
325
 
        super(RevisionView, self).__init__()
 
309
        gtk.Notebook.__init__(self)
326
310
 
327
311
        self._revision = None
328
312
        self._branch = branch
330
314
            self._repository = branch.repository
331
315
        else:
332
316
            self._repository = repository
333
 
        self.signature_table = None
334
317
 
335
318
        self._create_general()
336
319
        self._create_relations()
337
320
        # Disabled because testaments aren't verified yet:
338
 
        if has_seahorse:
339
 
            self._create_signature()
 
321
        # if has_seahorse:
 
322
        #    self._create_signature()
340
323
        self._create_file_info_view()
341
324
        self._create_bugs()
342
325
 
397
380
 
398
381
    def _set_revision(self, revision):
399
382
        if revision is None: return
400
 
        
401
 
        self.avatarsbox.reset()
402
 
        
 
383
 
403
384
        self._revision = revision
404
385
        if revision.committer is not None:
405
386
            self.committer.set_text(revision.committer)
406
 
            self.avatarsbox.add(revision.committer, "committer")
407
387
        else:
408
388
            self.committer.set_text("")
409
 
            self.avatarsbox.hide()
410
389
        author = revision.properties.get('author', '')
411
 
        self.avatarsbox.merge(revision.get_apparent_authors(), "author")
412
390
        if author != '':
413
391
            self.author.set_text(author)
414
392
            self.author.show()
421
399
            self.timestamp.set_text(format_date(revision.timestamp,
422
400
                                                revision.timezone))
423
401
        try:
424
 
            self.branchnick.show()
425
 
            self.branchnick_label.show()
426
 
            self.branchnick.set_text(revision.properties['branch-nick'])
 
402
            self.branchnick_label.set_text(revision.properties['branch-nick'])
427
403
        except KeyError:
428
 
            self.branchnick.hide()
429
 
            self.branchnick_label.hide()
 
404
            self.branchnick_label.set_text("")
430
405
 
431
406
        self._add_parents_or_children(revision.parent_ids,
432
407
                                      self.parents_widgets,
433
408
                                      self.parents_table)
434
 
 
 
409
        
435
410
        file_info = revision.properties.get('file-info', None)
436
411
        if file_info is not None:
437
 
            try:
438
 
                file_info = bdecode(file_info.encode('UTF-8'))
439
 
            except ValueError:
440
 
                trace.note('Invalid per-file info for revision:%s, value: %r',
441
 
                           revision.revision_id, file_info)
442
 
                file_info = None
 
412
            file_info = bdecode(file_info.encode('UTF-8'))
443
413
 
444
414
        if file_info:
445
415
            if self._file_id is None:
470
440
        self._add_tags()
471
441
 
472
442
    def _update_signature(self, widget, param):
473
 
        if not has_seahorse:
474
 
            return
475
443
        if self.get_current_page() == PAGE_SIGNATURE:
476
444
            self.signature_table.set_revision(self._revision)
477
445
 
486
454
                                      self.children_table)
487
455
 
488
456
    def _switch_page_cb(self, notebook, page, page_num):
489
 
        if not has_seahorse:
490
 
            return
491
457
        if page_num == PAGE_SIGNATURE:
492
458
            self.signature_table.set_revision(self._revision)
493
459
 
527
493
        table.resize(max(len(revids), 1), 2)
528
494
 
529
495
        for idx, revid in enumerate(revids):
530
 
            align = Gtk.Alignment.new(0.0, 0.0, 1, 1)
 
496
            align = gtk.Alignment(0.0, 0.0)
531
497
            widgets.append(align)
532
498
            table.attach(align, 1, 2, idx, idx + 1,
533
 
                                      Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
499
                                      gtk.EXPAND | gtk.FILL, gtk.FILL)
534
500
            align.show()
535
501
 
536
 
            hbox = Gtk.HBox(homogeneous=False, spacing=6)
 
502
            hbox = gtk.HBox(False, spacing=6)
537
503
            align.add(hbox)
538
504
            hbox.show()
539
505
 
540
 
            image = Gtk.Image()
 
506
            image = gtk.Image()
541
507
            image.set_from_stock(
542
 
                Gtk.STOCK_FIND, Gtk.IconSize.SMALL_TOOLBAR)
 
508
                gtk.STOCK_FIND, gtk.ICON_SIZE_SMALL_TOOLBAR)
543
509
            image.show()
544
510
 
545
511
            if self._show_callback is not None:
546
 
                button = Gtk.Button()
 
512
                button = gtk.Button()
547
513
                button.add(image)
548
514
                button.connect("clicked", self._show_clicked_cb,
549
515
                               self._revision.revision_id, revid)
550
 
                hbox.pack_start(button, False, True, 0)
 
516
                hbox.pack_start(button, expand=False, fill=True)
551
517
                button.show()
552
518
 
553
 
            button = Gtk.Button()
554
 
            revid_label = Gtk.Label(label=str(revid))
555
 
            revid_label.set_ellipsize(Pango.EllipsizeMode.MIDDLE)
556
 
            revid_label.set_alignment(0.0, 0.5)
557
 
            button.add(revid_label)
 
519
            button = gtk.Button(revid)
558
520
            button.connect("clicked",
559
 
                    lambda w, r: self.set_revision(
560
 
                        self._repository.get_revision(r)), revid)
 
521
                    lambda w, r: self.set_revision(self._repository.get_revision(r)), revid)
561
522
            button.set_use_underline(False)
562
 
            hbox.pack_start(button, True, True, 0)
563
 
            button.show_all()
 
523
            hbox.pack_start(button, expand=False, fill=True)
 
524
            button.show()
564
525
 
565
526
    def _create_general(self):
566
 
        vbox = Gtk.VBox(homogeneous=False, spacing=6)
 
527
        vbox = gtk.VBox(False, 6)
567
528
        vbox.set_border_width(6)
568
 
        vbox.pack_start(self._create_headers(), False, True, 0)
569
 
        vbox.pack_start(self._create_message_view(), True, True, 0)
570
 
        self.append_page(vbox, Gtk.Label(label="General"))
 
529
        vbox.pack_start(self._create_headers(), expand=False, fill=True)
 
530
        vbox.pack_start(self._create_message_view())
 
531
        self.append_page(vbox, tab_label=gtk.Label("General"))
571
532
        vbox.show()
572
533
 
573
534
    def _create_relations(self):
574
 
        vbox = Gtk.VBox(homogeneous=False, spacing=6)
 
535
        vbox = gtk.VBox(False, 6)
575
536
        vbox.set_border_width(6)
576
 
        vbox.pack_start(self._create_parents(), False, True, 0)
577
 
        vbox.pack_start(self._create_children(), False, True, 0)
578
 
        self.append_page(vbox, Gtk.Label(label="Relations"))
 
537
        vbox.pack_start(self._create_parents(), expand=False, fill=True)
 
538
        vbox.pack_start(self._create_children(), expand=False, fill=True)
 
539
        self.append_page(vbox, tab_label=gtk.Label("Relations"))
579
540
        vbox.show()
580
541
 
581
542
    def _create_signature(self):
582
543
        self.signature_table = SignatureTab(self._repository)
583
 
        self.append_page(
584
 
            self.signature_table, Gtk.Label(label='Signature'))
 
544
        self.append_page(self.signature_table, tab_label=gtk.Label('Signature'))
585
545
        self.connect_after('notify::revision', self._update_signature)
586
546
 
587
547
    def _create_headers(self):
588
 
        self.avatarsbox = AvatarsBox()
589
 
        
590
 
        self.table = Gtk.Table(rows=5, columns=2)
 
548
        self.table = gtk.Table(rows=5, columns=2)
591
549
        self.table.set_row_spacings(6)
592
550
        self.table.set_col_spacings(6)
593
551
        self.table.show()
594
 
        
595
 
        self.avatarsbox.pack_start(self.table, True, True, 0)
596
 
        self.avatarsbox.show()
597
 
 
598
 
        row = 0
599
 
 
600
 
        label = Gtk.Label()
601
 
        label.set_alignment(1.0, 0.5)
 
552
 
 
553
        align = gtk.Alignment(1.0, 0.5)
 
554
        label = gtk.Label()
602
555
        label.set_markup("<b>Revision Id:</b>")
603
 
        self.table.attach(label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
556
        align.add(label)
 
557
        self.table.attach(align, 0, 1, 0, 1, gtk.FILL, gtk.FILL)
 
558
        align.show()
604
559
        label.show()
605
560
 
606
 
        revision_id = Gtk.Label()
607
 
        revision_id.set_ellipsize(Pango.EllipsizeMode.MIDDLE)
608
 
        revision_id.set_alignment(0.0, 0.5)
 
561
        align = gtk.Alignment(0.0, 0.5)
 
562
        revision_id = gtk.Label()
609
563
        revision_id.set_selectable(True)
610
564
        self.connect('notify::revision', 
611
565
                lambda w, p: revision_id.set_text(self._revision.revision_id))
612
 
        self.table.attach(revision_id, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
566
        align.add(revision_id)
 
567
        self.table.attach(align, 1, 2, 0, 1, gtk.EXPAND | gtk.FILL, gtk.FILL)
 
568
        align.show()
613
569
        revision_id.show()
614
570
 
615
 
        row += 1
616
 
        self.author_label = Gtk.Label()
617
 
        self.author_label.set_alignment(1.0, 0.5)
 
571
        align = gtk.Alignment(1.0, 0.5)
 
572
        self.author_label = gtk.Label()
618
573
        self.author_label.set_markup("<b>Author:</b>")
619
 
        self.table.attach(self.author_label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
574
        align.add(self.author_label)
 
575
        self.table.attach(align, 0, 1, 1, 2, gtk.FILL, gtk.FILL)
 
576
        align.show()
620
577
        self.author_label.show()
621
578
 
622
 
        self.author = Gtk.Label()
623
 
        self.author.set_ellipsize(Pango.EllipsizeMode.END)
624
 
        self.author.set_alignment(0.0, 0.5)
 
579
        align = gtk.Alignment(0.0, 0.5)
 
580
        self.author = gtk.Label()
625
581
        self.author.set_selectable(True)
626
 
        self.table.attach(self.author, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
582
        align.add(self.author)
 
583
        self.table.attach(align, 1, 2, 1, 2, gtk.EXPAND | gtk.FILL, gtk.FILL)
 
584
        align.show()
627
585
        self.author.show()
628
586
        self.author.hide()
629
587
 
630
 
        row += 1
631
 
        label = Gtk.Label()
632
 
        label.set_alignment(1.0, 0.5)
 
588
        align = gtk.Alignment(1.0, 0.5)
 
589
        label = gtk.Label()
633
590
        label.set_markup("<b>Committer:</b>")
634
 
        self.table.attach(label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
591
        align.add(label)
 
592
        self.table.attach(align, 0, 1, 2, 3, gtk.FILL, gtk.FILL)
 
593
        align.show()
635
594
        label.show()
636
595
 
637
 
        self.committer = Gtk.Label()
638
 
        self.committer.set_ellipsize(Pango.EllipsizeMode.END)
639
 
        self.committer.set_alignment(0.0, 0.5)
 
596
        align = gtk.Alignment(0.0, 0.5)
 
597
        self.committer = gtk.Label()
640
598
        self.committer.set_selectable(True)
641
 
        self.table.attach(self.committer, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
599
        align.add(self.committer)
 
600
        self.table.attach(align, 1, 2, 2, 3, gtk.EXPAND | gtk.FILL, gtk.FILL)
 
601
        align.show()
642
602
        self.committer.show()
643
603
 
644
 
        row += 1
645
 
        self.branchnick_label = Gtk.Label()
646
 
        self.branchnick_label.set_alignment(1.0, 0.5)
647
 
        self.branchnick_label.set_markup("<b>Branch nick:</b>")
648
 
        self.table.attach(self.branchnick_label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
604
        align = gtk.Alignment(0.0, 0.5)
 
605
        label = gtk.Label()
 
606
        label.set_markup("<b>Branch nick:</b>")
 
607
        align.add(label)
 
608
        self.table.attach(align, 0, 1, 3, 4, gtk.FILL, gtk.FILL)
 
609
        label.show()
 
610
        align.show()
 
611
 
 
612
        align = gtk.Alignment(0.0, 0.5)
 
613
        self.branchnick_label = gtk.Label()
 
614
        self.branchnick_label.set_selectable(True)
 
615
        align.add(self.branchnick_label)
 
616
        self.table.attach(align, 1, 2, 3, 4, gtk.EXPAND | gtk.FILL, gtk.FILL)
649
617
        self.branchnick_label.show()
650
 
 
651
 
        self.branchnick = Gtk.Label()
652
 
        self.branchnick.set_ellipsize(Pango.EllipsizeMode.MIDDLE)
653
 
        self.branchnick.set_alignment(0.0, 0.5)
654
 
        self.branchnick.set_selectable(True)
655
 
        self.table.attach(self.branchnick, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
656
 
        self.branchnick.show()
657
 
 
658
 
        row += 1
659
 
        label = Gtk.Label()
660
 
        label.set_alignment(1.0, 0.5)
 
618
        align.show()
 
619
 
 
620
        align = gtk.Alignment(1.0, 0.5)
 
621
        label = gtk.Label()
661
622
        label.set_markup("<b>Timestamp:</b>")
662
 
        self.table.attach(label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
623
        align.add(label)
 
624
        self.table.attach(align, 0, 1, 4, 5, gtk.FILL, gtk.FILL)
 
625
        align.show()
663
626
        label.show()
664
627
 
665
 
        self.timestamp = Gtk.Label()
666
 
        self.timestamp.set_ellipsize(Pango.EllipsizeMode.END)
667
 
        self.timestamp.set_alignment(0.0, 0.5)
 
628
        align = gtk.Alignment(0.0, 0.5)
 
629
        self.timestamp = gtk.Label()
668
630
        self.timestamp.set_selectable(True)
669
 
        self.table.attach(self.timestamp, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
631
        align.add(self.timestamp)
 
632
        self.table.attach(align, 1, 2, 4, 5, gtk.EXPAND | gtk.FILL, gtk.FILL)
 
633
        align.show()
670
634
        self.timestamp.show()
671
635
 
672
 
        row += 1
673
 
        self.tags_label = Gtk.Label()
674
 
        self.tags_label.set_alignment(1.0, 0.5)
 
636
        align = gtk.Alignment(1.0, 0.5)
 
637
        self.tags_label = gtk.Label()
675
638
        self.tags_label.set_markup("<b>Tags:</b>")
676
 
        self.table.attach(self.tags_label, 0, 1, row, row+1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
639
        align.add(self.tags_label)
 
640
        align.show()
 
641
        self.table.attach(align, 0, 1, 5, 6, gtk.FILL, gtk.FILL)
677
642
        self.tags_label.show()
678
643
 
679
 
        self.tags_list = Gtk.Label()
680
 
        self.tags_list.set_ellipsize(Pango.EllipsizeMode.MIDDLE)
681
 
        self.tags_list.set_alignment(0.0, 0.5)
682
 
        self.table.attach(self.tags_list, 1, 2, row, row+1, Gtk.AttachOptions.EXPAND | Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
644
        align = gtk.Alignment(0.0, 0.5)
 
645
        self.tags_list = gtk.Label()
 
646
        align.add(self.tags_list)
 
647
        self.table.attach(align, 1, 2, 5, 6, gtk.EXPAND | gtk.FILL, gtk.FILL)
 
648
        align.show()
683
649
        self.tags_list.show()
684
650
 
685
651
        self.connect('notify::revision', self._add_tags)
686
652
 
687
 
        return self.avatarsbox
 
653
        return self.table
688
654
    
689
655
    def _create_parents(self):
690
 
        hbox = Gtk.HBox(homogeneous=True, spacing=3)
 
656
        hbox = gtk.HBox(True, 3)
691
657
        
692
658
        self.parents_table = self._create_parents_or_children_table(
693
659
            "<b>Parents:</b>")
694
660
        self.parents_widgets = []
695
 
        hbox.pack_start(self.parents_table, True, True, 0)
 
661
        hbox.pack_start(self.parents_table)
696
662
 
697
663
        hbox.show()
698
664
        return hbox
699
665
 
700
666
    def _create_children(self):
701
 
        hbox = Gtk.HBox(homogeneous=True, spacing=3)
 
667
        hbox = gtk.HBox(True, 3)
702
668
        self.children_table = self._create_parents_or_children_table(
703
669
            "<b>Children:</b>")
704
670
        self.children_widgets = []
705
 
        hbox.pack_start(self.children_table, True, True, 0)
 
671
        hbox.pack_start(self.children_table)
706
672
        hbox.show()
707
673
        return hbox
708
674
        
709
675
    def _create_parents_or_children_table(self, text):
710
 
        table = Gtk.Table(rows=1, columns=2)
 
676
        table = gtk.Table(rows=1, columns=2)
711
677
        table.set_row_spacings(3)
712
678
        table.set_col_spacings(6)
713
679
        table.show()
714
680
 
715
 
        label = Gtk.Label()
 
681
        label = gtk.Label()
716
682
        label.set_markup(text)
717
 
        align = Gtk.Alignment.new(0.0, 0.5, 0, 0)
 
683
        align = gtk.Alignment(0.0, 0.5)
718
684
        align.add(label)
719
 
        table.attach(align, 0, 1, 0, 1, Gtk.AttachOptions.FILL, Gtk.AttachOptions.FILL)
 
685
        table.attach(align, 0, 1, 0, 1, gtk.FILL, gtk.FILL)
720
686
        label.show()
721
687
        align.show()
722
688
 
723
689
        return table
724
690
 
725
691
    def _create_message_view(self):
726
 
        msg_buffer = Gtk.TextBuffer()
 
692
        msg_buffer = gtk.TextBuffer()
727
693
        self.connect('notify::revision',
728
694
                lambda w, p: msg_buffer.set_text(self._revision.message))
729
 
        window = Gtk.ScrolledWindow()
730
 
        window.set_policy(Gtk.PolicyType.NEVER, Gtk.PolicyType.AUTOMATIC)
731
 
        window.set_shadow_type(Gtk.ShadowType.IN)
732
 
        tv = Gtk.TextView(buffer=msg_buffer)
 
695
        window = gtk.ScrolledWindow()
 
696
        window.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)
 
697
        window.set_shadow_type(gtk.SHADOW_IN)
 
698
        tv = gtk.TextView(msg_buffer)
733
699
        tv.set_editable(False)
734
 
        tv.set_wrap_mode(Gtk.WrapMode.WORD)
 
700
        tv.set_wrap_mode(gtk.WRAP_WORD)
735
701
 
736
 
        tv.modify_font(Pango.FontDescription("Monospace"))
 
702
        tv.modify_font(pango.FontDescription("Monospace"))
737
703
        tv.show()
738
704
        window.add(tv)
739
705
        window.show()
742
708
    def _create_bugs(self):
743
709
        self.bugs_page = BugsTab()
744
710
        self.connect_after('notify::revision', self._update_bugs) 
745
 
        self.append_page(self.bugs_page, Gtk.Label(label='Bugs'))
 
711
        self.append_page(self.bugs_page, tab_label=gtk.Label('Bugs'))
746
712
 
747
713
    def _create_file_info_view(self):
748
 
        self.file_info_box = Gtk.VBox(homogeneous=False, spacing=6)
 
714
        self.file_info_box = gtk.VBox(False, 6)
749
715
        self.file_info_box.set_border_width(6)
750
 
        self.file_info_buffer = Gtk.TextBuffer()
751
 
        window = Gtk.ScrolledWindow()
752
 
        window.set_policy(Gtk.PolicyType.NEVER, Gtk.PolicyType.AUTOMATIC)
753
 
        window.set_shadow_type(Gtk.ShadowType.IN)
754
 
        tv = Gtk.TextView(buffer=self.file_info_buffer)
 
716
        self.file_info_buffer = gtk.TextBuffer()
 
717
        window = gtk.ScrolledWindow()
 
718
        window.set_policy(gtk.POLICY_NEVER, gtk.POLICY_AUTOMATIC)
 
719
        window.set_shadow_type(gtk.SHADOW_IN)
 
720
        tv = gtk.TextView(self.file_info_buffer)
755
721
        tv.set_editable(False)
756
 
        tv.set_wrap_mode(Gtk.WrapMode.WORD)
757
 
        tv.modify_font(Pango.FontDescription("Monospace"))
 
722
        tv.set_wrap_mode(gtk.WRAP_WORD)
 
723
        tv.modify_font(pango.FontDescription("Monospace"))
758
724
        tv.show()
759
725
        window.add(tv)
760
726
        window.show()
761
 
        self.file_info_box.pack_start(window, True, True, 0)
 
727
        self.file_info_box.pack_start(window)
762
728
        self.file_info_box.hide() # Only shown when there are per-file messages
763
 
        self.append_page(self.file_info_box, Gtk.Label(label='Per-file'))
 
729
        self.append_page(self.file_info_box, tab_label=gtk.Label('Per-file'))
764
730