/b-gtk/fix-viz

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/b-gtk/fix-viz

« back to all changes in this revision

Viewing changes to errors.py

  • Committer: Vincent Ladeuil
  • Date: 2009-05-07 11:48:03 UTC
  • Revision ID: v.ladeuil+lp@free.fr-20090507114803-sxykmkuzrkdj2pr3
Fix bug #373157 by properly setting the default values.

* tests/test_annotate_config.py:
(TestConfig.test_create_initial_config): Urgh, remove pdb breakpoint.

* annotate/config.py:
(gannotate_configspec): Deleted, can't be used for default values
and not used for validation: useless.
(gannotate_config_filename): Turned into a function so that tests
get proper isolated result (evaluating the path at load time
forbids the test framework overriding).
(GAnnotateConfig.__init__): Add default values *only* if the
'window' section doesn't exist. Assigning them unconditionally
defeats the config file purpose... Also delete the 'spans' section
since nobody use it.
(GAnnotateConfig.apply): Coerce config values when we use them.
(Gannotateconfig._save_custom_spans): Deleted (dead code).

Show diffs side-by-side

added added

removed removed

Lines of Context:
errors.py
16
16
 
17
17
import bzrlib.errors as errors
18
18
from bzrlib.plugins.gtk import _i18n
19
 
from dialog import error_dialog
 
19
from dialog import error_dialog, info_dialog, warning_dialog
20
20
 
21
21
 
22
22
def show_bzr_error(unbound):
33
33
        except errors.PointlessCommit:
34
34
            error_dialog(_i18n('No changes to commit'),
35
35
                         _i18n('Try force commit if you want to commit anyway.'))
 
36
        except errors.PointlessMerge:
 
37
            info_dialog(_i18n('No changes to merge'),
 
38
                         _i18n('Merge location is already fully merged in working tree.'))
36
39
        except errors.ConflictsInTree:
37
40
            error_dialog(_i18n('Conflicts in tree'),
38
41
                         _i18n('You need to resolve the conflicts before committing.'))