/b-gtk/fix-viz

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/b-gtk/fix-viz

« back to all changes in this revision

Viewing changes to viz/branchwin.py

  • Committer: Mikkel Kamstrup Erlandsen
  • Date: 2011-09-28 07:45:39 UTC
  • mto: This revision was merged to the branch mainline in revision 740.
  • Revision ID: mikkel.kamstrup@gmail.com-20110928074539-qxl1yn1bkjel6ir0
https://launchpad.net/bugs/861201
Add X-GNOME-Autostart-Delay=30 to bzr-notify.desktop

Show diffs side-by-side

added added

removed removed

Lines of Context:
viz/branchwin.py
8
8
__author__    = "Scott James Remnant <scott@ubuntu.com>"
9
9
 
10
10
 
11
 
from gi.repository import Gdk
12
 
from gi.repository import Gtk
 
11
import gtk
13
12
 
14
13
from bzrlib.plugins.gtk import icon_path
15
14
from bzrlib.plugins.gtk.branchview import TreeView
38
37
                       None for no limit.
39
38
        """
40
39
 
41
 
        super(BranchWindow, self).__init__(parent=parent)
 
40
        Window.__init__(self, parent=parent)
42
41
        self.set_border_width(0)
43
42
 
44
43
        self.branch      = branch
68
67
        self._save_size_on_destroy(self, 'viz-window-size')
69
68
 
70
69
        # FIXME AndyFitz!
71
 
        icon = self.render_icon_pixbuf(Gtk.STOCK_INDEX, Gtk.IconSize.BUTTON)
 
70
        icon = self.render_icon(gtk.STOCK_INDEX, gtk.ICON_SIZE_BUTTON)
72
71
        self.set_icon(icon)
73
72
 
74
 
        Gtk.AccelMap.add_entry("<viz>/Go/Next Revision", Gdk.KEY_Up, Gdk.ModifierType.MOD1_MASK)
75
 
        Gtk.AccelMap.add_entry("<viz>/Go/Previous Revision", Gdk.KEY_Down, Gdk.ModifierType.MOD1_MASK)
76
 
        Gtk.AccelMap.add_entry("<viz>/View/Refresh", Gdk.KEY_F5, 0)
 
73
        gtk.accel_map_add_entry("<viz>/Go/Next Revision", gtk.keysyms.Up, gtk.gdk.MOD1_MASK)
 
74
        gtk.accel_map_add_entry("<viz>/Go/Previous Revision", gtk.keysyms.Down, gtk.gdk.MOD1_MASK)
 
75
        gtk.accel_map_add_entry("<viz>/View/Refresh", gtk.keysyms.F5, 0)
77
76
 
78
 
        self.accel_group = Gtk.AccelGroup()
 
77
        self.accel_group = gtk.AccelGroup()
79
78
        self.add_accel_group(self.accel_group)
80
79
 
81
 
        self.prev_rev_action = Gtk.Action("prev-rev", "_Previous Revision", "Go to the previous revision", Gtk.STOCK_GO_DOWN)
 
80
        if getattr(gtk.Action, 'set_tool_item_type', None) is not None:
 
81
            # Not available before PyGtk-2.10
 
82
            gtk.Action.set_tool_item_type(gtk.MenuToolButton)
 
83
 
 
84
        self.prev_rev_action = gtk.Action("prev-rev", "_Previous Revision", "Go to the previous revision", gtk.STOCK_GO_DOWN)
82
85
        self.prev_rev_action.set_accel_path("<viz>/Go/Previous Revision")
83
86
        self.prev_rev_action.set_accel_group(self.accel_group)
84
87
        self.prev_rev_action.connect("activate", self._back_clicked_cb)
85
88
        self.prev_rev_action.connect_accelerator()
86
89
 
87
 
        self.next_rev_action = Gtk.Action("next-rev", "_Next Revision", "Go to the next revision", Gtk.STOCK_GO_UP)
 
90
        self.next_rev_action = gtk.Action("next-rev", "_Next Revision", "Go to the next revision", gtk.STOCK_GO_UP)
88
91
        self.next_rev_action.set_accel_path("<viz>/Go/Next Revision")
89
92
        self.next_rev_action.set_accel_group(self.accel_group)
90
93
        self.next_rev_action.connect("activate", self._fwd_clicked_cb)
91
94
        self.next_rev_action.connect_accelerator()
92
95
 
93
 
        self.refresh_action = Gtk.Action("refresh", "_Refresh", "Refresh view", Gtk.STOCK_REFRESH)
 
96
        self.refresh_action = gtk.Action("refresh", "_Refresh", "Refresh view", gtk.STOCK_REFRESH)
94
97
        self.refresh_action.set_accel_path("<viz>/View/Refresh")
95
98
        self.refresh_action.set_accel_group(self.accel_group)
96
99
        self.refresh_action.connect("activate", self._refresh_clicked)
102
105
        """Creates a hook that saves the size of widget to config option 
103
106
           config_name when the window is destroyed/closed."""
104
107
        def save_size(src):
105
 
            allocation = widget.get_allocation()
106
 
            width, height = allocation.width, allocation.height
 
108
            width, height = widget.allocation.width, widget.allocation.height
107
109
            value = '%sx%s' % (width, height)
108
110
            self.config.set_user_option(config_name, value)
109
111
        self.connect("destroy", save_size)
113
115
 
114
116
    def construct(self):
115
117
        """Construct the window contents."""
116
 
        vbox = Gtk.VBox(spacing=0)
 
118
        vbox = gtk.VBox(spacing=0)
117
119
        self.add(vbox)
118
120
 
119
121
        # order is important here
121
123
        nav = self.construct_navigation()
122
124
        menubar = self.construct_menubar()
123
125
 
124
 
        vbox.pack_start(menubar, False, True, 0)
125
 
        vbox.pack_start(nav, False, True, 0)
126
 
        vbox.pack_start(paned, True, True, 0)
 
126
        vbox.pack_start(menubar, expand=False, fill=True)
 
127
        vbox.pack_start(nav, expand=False, fill=True)
 
128
        vbox.pack_start(paned, expand=True, fill=True)
127
129
        vbox.set_focus_child(paned)
128
130
 
129
131
 
134
136
    def construct_paned(self):
135
137
        """Construct the main HPaned/VPaned contents."""
136
138
        if self.config.get_user_option('viz-vertical') == 'True':
137
 
            self.paned = Gtk.Paned.new(Gtk.Orientation.HORIZONTAL)
 
139
            self.paned = gtk.HPaned()
138
140
        else:
139
 
            self.paned = Gtk.Paned.new(Gtk.Orientation.VERTICAL)
 
141
            self.paned = gtk.VPaned()
140
142
 
141
143
        self.paned.pack1(self.construct_top(), resize=False, shrink=True)
142
144
        self.paned.pack2(self.construct_bottom(), resize=True, shrink=False)
145
147
        return self.paned
146
148
 
147
149
    def construct_menubar(self):
148
 
        menubar = Gtk.MenuBar()
 
150
        menubar = gtk.MenuBar()
149
151
 
150
 
        file_menu = Gtk.Menu()
151
 
        file_menuitem = Gtk.MenuItem.new_with_mnemonic("_File")
 
152
        file_menu = gtk.Menu()
 
153
        file_menuitem = gtk.MenuItem("_File")
152
154
        file_menuitem.set_submenu(file_menu)
153
155
 
154
 
        file_menu_close = Gtk.ImageMenuItem.new_from_stock(
155
 
            Gtk.STOCK_CLOSE, self.accel_group)
 
156
        file_menu_close = gtk.ImageMenuItem(gtk.STOCK_CLOSE, self.accel_group)
156
157
        file_menu_close.connect('activate', lambda x: self.destroy())
157
158
 
158
 
        file_menu_quit = Gtk.ImageMenuItem.new_from_stock(
159
 
            Gtk.STOCK_QUIT, self.accel_group)
160
 
        file_menu_quit.connect('activate', lambda x: Gtk.main_quit())
 
159
        file_menu_quit = gtk.ImageMenuItem(gtk.STOCK_QUIT, self.accel_group)
 
160
        file_menu_quit.connect('activate', lambda x: gtk.main_quit())
161
161
 
162
162
        if self._parent is not None:
163
163
            file_menu.add(file_menu_close)
164
164
        file_menu.add(file_menu_quit)
165
165
 
166
 
        edit_menu = Gtk.Menu()
167
 
        edit_menuitem = Gtk.MenuItem.new_with_mnemonic("_Edit")
 
166
        edit_menu = gtk.Menu()
 
167
        edit_menuitem = gtk.MenuItem("_Edit")
168
168
        edit_menuitem.set_submenu(edit_menu)
169
169
 
170
 
        edit_menu_branchopts = Gtk.MenuItem(label="Branch Settings")
 
170
        edit_menu_branchopts = gtk.MenuItem("Branch Settings")
171
171
        edit_menu_branchopts.connect('activate', lambda x: PreferencesWindow(self.branch.get_config()).show())
172
172
 
173
 
        edit_menu_globopts = Gtk.MenuItem(label="Global Settings")
 
173
        edit_menu_globopts = gtk.MenuItem("Global Settings")
174
174
        edit_menu_globopts.connect('activate', lambda x: PreferencesWindow().show())
175
175
 
176
176
        edit_menu.add(edit_menu_branchopts)
177
177
        edit_menu.add(edit_menu_globopts)
178
178
 
179
 
        view_menu = Gtk.Menu()
180
 
        view_menuitem = Gtk.MenuItem.new_with_mnemonic("_View")
 
179
        view_menu = gtk.Menu()
 
180
        view_menuitem = gtk.MenuItem("_View")
181
181
        view_menuitem.set_submenu(view_menu)
182
182
 
183
183
        view_menu_refresh = self.refresh_action.create_menu_item()
184
184
        view_menu_refresh.connect('activate', self._refresh_clicked)
185
185
 
186
186
        view_menu.add(view_menu_refresh)
187
 
        view_menu.add(Gtk.SeparatorMenuItem())
 
187
        view_menu.add(gtk.SeparatorMenuItem())
188
188
 
189
 
        view_menu_toolbar = Gtk.CheckMenuItem(label="Show Toolbar")
 
189
        view_menu_toolbar = gtk.CheckMenuItem("Show Toolbar")
190
190
        view_menu_toolbar.set_active(True)
191
191
        if self.config.get_user_option('viz-toolbar-visible') == 'False':
192
192
            view_menu_toolbar.set_active(False)
193
193
            self.toolbar.hide()
194
194
        view_menu_toolbar.connect('toggled', self._toolbar_visibility_changed)
195
195
 
196
 
        view_menu_compact = Gtk.CheckMenuItem(label="Show Compact Graph")
 
196
        view_menu_compact = gtk.CheckMenuItem("Show Compact Graph")
197
197
        view_menu_compact.set_active(self.compact_view)
198
198
        view_menu_compact.connect('activate', self._brokenlines_toggled_cb)
199
199
 
200
 
        view_menu_vertical = Gtk.CheckMenuItem(label="Side-by-side Layout")
 
200
        view_menu_vertical = gtk.CheckMenuItem("Side-by-side Layout")
201
201
        view_menu_vertical.set_active(False)
202
202
        if self.config.get_user_option('viz-vertical') == 'True':
203
203
            view_menu_vertical.set_active(True)
204
204
        view_menu_vertical.connect('toggled', self._vertical_layout)
205
205
 
206
 
        view_menu_diffs = Gtk.CheckMenuItem(label="Show Diffs")
 
206
        view_menu_diffs = gtk.CheckMenuItem("Show Diffs")
207
207
        view_menu_diffs.set_active(False)
208
208
        if self.config.get_user_option('viz-show-diffs') == 'True':
209
209
            view_menu_diffs.set_active(True)
210
210
        view_menu_diffs.connect('toggled', self._diff_visibility_changed)
211
211
 
212
 
        view_menu_wide_diffs = Gtk.CheckMenuItem(label="Wide Diffs")
 
212
        view_menu_wide_diffs = gtk.CheckMenuItem("Wide Diffs")
213
213
        view_menu_wide_diffs.set_active(False)
214
214
        if self.config.get_user_option('viz-wide-diffs') == 'True':
215
215
            view_menu_wide_diffs.set_active(True)
216
216
        view_menu_wide_diffs.connect('toggled', self._diff_placement_changed)
217
217
 
218
 
        view_menu_wrap_diffs = Gtk.CheckMenuItem.new_with_mnemonic(
219
 
            "Wrap _Long Lines in Diffs")
 
218
        view_menu_wrap_diffs = gtk.CheckMenuItem("Wrap _Long Lines in Diffs")
220
219
        view_menu_wrap_diffs.set_active(False)
221
220
        if self.config.get_user_option('viz-wrap-diffs') == 'True':
222
221
            view_menu_wrap_diffs.set_active(True)
225
224
        view_menu.add(view_menu_toolbar)
226
225
        view_menu.add(view_menu_compact)
227
226
        view_menu.add(view_menu_vertical)
228
 
        view_menu.add(Gtk.SeparatorMenuItem())
 
227
        view_menu.add(gtk.SeparatorMenuItem())
229
228
        view_menu.add(view_menu_diffs)
230
229
        view_menu.add(view_menu_wide_diffs)
231
230
        view_menu.add(view_menu_wrap_diffs)
232
 
        view_menu.add(Gtk.SeparatorMenuItem())
 
231
        view_menu.add(gtk.SeparatorMenuItem())
233
232
 
234
 
        self.mnu_show_revno_column = Gtk.CheckMenuItem.new_with_mnemonic(
235
 
            "Show Revision _Number Column")
236
 
        self.mnu_show_date_column = Gtk.CheckMenuItem.new_with_mnemonic(
237
 
            "Show _Date Column")
 
233
        self.mnu_show_revno_column = gtk.CheckMenuItem("Show Revision _Number Column")
 
234
        self.mnu_show_date_column = gtk.CheckMenuItem("Show _Date Column")
238
235
 
239
236
        # Revision numbers are pointless if there are multiple branches
240
237
        if len(self.start_revs) > 1:
247
244
            col.connect('toggled', self._col_visibility_changed, name)
248
245
            view_menu.add(col)
249
246
 
250
 
        go_menu = Gtk.Menu()
 
247
        go_menu = gtk.Menu()
251
248
        go_menu.set_accel_group(self.accel_group)
252
 
        go_menuitem = Gtk.MenuItem.new_with_mnemonic("_Go")
 
249
        go_menuitem = gtk.MenuItem("_Go")
253
250
        go_menuitem.set_submenu(go_menu)
254
251
 
255
252
        go_menu_next = self.next_rev_action.create_menu_item()
256
253
        go_menu_prev = self.prev_rev_action.create_menu_item()
257
254
 
258
 
        tag_image = Gtk.Image()
 
255
        tag_image = gtk.Image()
259
256
        tag_image.set_from_file(icon_path("tag-16.png"))
260
 
        self.go_menu_tags = Gtk.ImageMenuItem.new_with_mnemonic("_Tags")
 
257
        self.go_menu_tags = gtk.ImageMenuItem("_Tags")
261
258
        self.go_menu_tags.set_image(tag_image)
262
259
        self.treeview.connect('refreshed', lambda w: self._update_tags())
263
260
 
264
261
        go_menu.add(go_menu_next)
265
262
        go_menu.add(go_menu_prev)
266
 
        go_menu.add(Gtk.SeparatorMenuItem())
 
263
        go_menu.add(gtk.SeparatorMenuItem())
267
264
        go_menu.add(self.go_menu_tags)
268
265
 
269
266
        self.revision_menu = RevisionMenu(self.branch.repository, [],
270
267
            self.branch, parent=self)
271
 
        revision_menuitem = Gtk.MenuItem.new_with_mnemonic("_Revision")
 
268
        revision_menuitem = gtk.MenuItem("_Revision")
272
269
        revision_menuitem.set_submenu(self.revision_menu)
273
270
 
274
 
        branch_menu = Gtk.Menu()
275
 
        branch_menuitem = Gtk.MenuItem.new_with_mnemonic("_Branch")
 
271
        branch_menu = gtk.Menu()
 
272
        branch_menuitem = gtk.MenuItem("_Branch")
276
273
        branch_menuitem.set_submenu(branch_menu)
277
274
 
278
 
        branch_menu.add(Gtk.MenuItem.new_with_mnemonic("Pu_ll Revisions"))
279
 
        branch_menu.add(Gtk.MenuItem.new_with_mnemonic("Pu_sh Revisions"))
 
275
        branch_menu.add(gtk.MenuItem("Pu_ll Revisions"))
 
276
        branch_menu.add(gtk.MenuItem("Pu_sh Revisions"))
280
277
 
281
278
        try:
282
279
            from bzrlib.plugins import search
283
280
        except ImportError:
284
281
            mutter("Didn't find search plugin")
285
282
        else:
286
 
            branch_menu.add(Gtk.SeparatorMenuItem())
 
283
            branch_menu.add(gtk.SeparatorMenuItem())
287
284
 
288
 
            branch_index_menuitem = Gtk.MenuItem.new_with_mnemonic("_Index")
 
285
            branch_index_menuitem = gtk.MenuItem("_Index")
289
286
            branch_index_menuitem.connect('activate', self._branch_index_cb)
290
287
            branch_menu.add(branch_index_menuitem)
291
288
 
292
 
            branch_search_menuitem = Gtk.MenuItem.new_with_mnemonic("_Search")
 
289
            branch_search_menuitem = gtk.MenuItem("_Search")
293
290
            branch_search_menuitem.connect('activate', self._branch_search_cb)
294
291
            branch_menu.add(branch_search_menuitem)
295
292
 
296
 
        help_menu = Gtk.Menu()
297
 
        help_menuitem = Gtk.MenuItem.new_with_mnemonic("_Help")
 
293
        help_menu = gtk.Menu()
 
294
        help_menuitem = gtk.MenuItem("_Help")
298
295
        help_menuitem.set_submenu(help_menu)
299
296
 
300
 
        help_about_menuitem = Gtk.ImageMenuItem.new_from_stock(
301
 
            Gtk.STOCK_ABOUT, self.accel_group)
 
297
        help_about_menuitem = gtk.ImageMenuItem(gtk.STOCK_ABOUT,
 
298
            self.accel_group)
302
299
        help_about_menuitem.connect('activate', self._about_dialog_cb)
303
300
 
304
301
        help_menu.add(help_about_menuitem)
331
328
 
332
329
        self.treeview.show()
333
330
 
334
 
        align = Gtk.Alignment.new(0.0, 0.0, 1.0, 1.0)
 
331
        align = gtk.Alignment(0.0, 0.0, 1.0, 1.0)
335
332
        align.set_padding(5, 0, 0, 0)
336
333
        align.add(self.treeview)
337
334
        # user-configured size
349
346
 
350
347
    def construct_navigation(self):
351
348
        """Construct the navigation buttons."""
352
 
        self.toolbar = Gtk.Toolbar()
353
 
        self.toolbar.set_style(Gtk.ToolbarStyle.BOTH_HORIZ)
 
349
        self.toolbar = gtk.Toolbar()
 
350
        self.toolbar.set_style(gtk.TOOLBAR_BOTH_HORIZ)
354
351
 
355
352
        self.prev_button = self.prev_rev_action.create_tool_item()
356
353
        self.toolbar.insert(self.prev_button, -1)
358
355
        self.next_button = self.next_rev_action.create_tool_item()
359
356
        self.toolbar.insert(self.next_button, -1)
360
357
 
361
 
        self.toolbar.insert(Gtk.SeparatorToolItem(), -1)
 
358
        self.toolbar.insert(gtk.SeparatorToolItem(), -1)
362
359
 
363
 
        refresh_button = Gtk.ToolButton.new_from_stock(Gtk.STOCK_REFRESH)
 
360
        refresh_button = gtk.ToolButton(gtk.STOCK_REFRESH)
364
361
        refresh_button.connect('clicked', self._refresh_clicked)
365
362
        self.toolbar.insert(refresh_button, -1)
366
363
 
371
368
    def construct_bottom(self):
372
369
        """Construct the bottom half of the window."""
373
370
        if self.config.get_user_option('viz-wide-diffs') == 'True':
374
 
            self.diff_paned = Gtk.Paned.new(Gtk.Orientation.VERTICAL)
 
371
            self.diff_paned = gtk.VPaned()
375
372
        else:
376
 
            self.diff_paned = Gtk.Paned.new(Gtk.Orientation.HORIZONTAL)
 
373
            self.diff_paned = gtk.HPaned()
377
374
        (width, height) = self.get_size()
378
375
        self.diff_paned.set_size_request(20, 20) # shrinkable
379
376
 
418
415
 
419
416
        if revision and revision.revision_id != NULL_REVISION:
420
417
            self.revision_menu.set_revision_ids([revision.revision_id])
421
 
            prev_menu = Gtk.Menu()
 
418
            prev_menu = gtk.Menu()
422
419
            if len(parents) > 0:
423
420
                self.prev_rev_action.set_sensitive(True)
424
421
                for parent_id in parents:
429
426
                        except KeyError:
430
427
                            str = ""
431
428
 
432
 
                        item = Gtk.MenuItem(
433
 
                            label=parent.message.split("\n")[0] + str)
 
429
                        item = gtk.MenuItem(parent.message.split("\n")[0] + str)
434
430
                        item.connect('activate', self._set_revision_cb, parent_id)
435
431
                        prev_menu.add(item)
436
432
                prev_menu.show_all()
441
437
            if getattr(self.prev_button, 'set_menu', None) is not None:
442
438
                self.prev_button.set_menu(prev_menu)
443
439
 
444
 
            next_menu = Gtk.Menu()
 
440
            next_menu = gtk.Menu()
445
441
            if len(children) > 0:
446
442
                self.next_rev_action.set_sensitive(True)
447
443
                for child_id in children:
451
447
                    except KeyError:
452
448
                        str = ""
453
449
 
454
 
                    item = Gtk.MenuItem(
455
 
                        label=child.message.split("\n")[0] + str)
 
450
                    item = gtk.MenuItem(child.message.split("\n")[0] + str)
456
451
                    item.connect('activate', self._set_revision_cb, child_id)
457
452
                    next_menu.add(item)
458
453
                next_menu.show_all()
478
473
        else:
479
474
            parent_id = parents[0]
480
475
 
481
 
        if revision is not None:
482
 
            self.show_diff(revision.revision_id, parent_id)
483
 
        else:
484
 
            self.show_diff(NULL_REVISION)
 
476
        self.show_diff(revision.revision_id, parent_id)
485
477
        self.treeview.grab_focus()
486
478
 
487
479
    def _back_clicked_cb(self, *args):
531
523
        try:
532
524
            index = _mod_index.open_index_url(self.branch.base)
533
525
        except search_errors.NoSearchIndex:
534
 
            dialog = Gtk.MessageDialog(self, type=Gtk.MessageType.QUESTION, 
535
 
                buttons=Gtk.ButtonsType.OK_CANCEL, 
 
526
            dialog = gtk.MessageDialog(self, type=gtk.MESSAGE_QUESTION, 
 
527
                buttons=gtk.BUTTONS_OK_CANCEL, 
536
528
                message_format="This branch has not been indexed yet. "
537
529
                               "Index now?")
538
 
            if dialog.run() == Gtk.ResponseType.OK:
 
530
            if dialog.run() == gtk.RESPONSE_OK:
539
531
                dialog.destroy()
540
532
                index = _mod_index.index_url(self.branch.base)
541
533
            else:
544
536
 
545
537
        dialog = SearchDialog(index)
546
538
 
547
 
        if dialog.run() == Gtk.ResponseType.OK:
548
 
            revid = dialog.get_revision()
549
 
            if revid is not None:
550
 
                self.set_revision(revid)
 
539
        if dialog.run() == gtk.RESPONSE_OK:
 
540
            self.set_revision(dialog.get_revision())
551
541
 
552
542
        dialog.destroy()
553
543
 
572
562
 
573
563
        old = self.paned
574
564
        self.vbox.remove(old)
575
 
        self.vbox.pack_start(
576
 
            self.construct_paned(), True, True, 0)
 
565
        self.vbox.pack_start(self.construct_paned(), expand=True, fill=True)
577
566
        self._make_diff_paned_nonzero_size()
578
567
        self._make_diff_nonzero_size()
579
568
 
623
612
        self.treeview.refresh()
624
613
 
625
614
    def _update_tags(self):
626
 
        menu = Gtk.Menu()
 
615
        menu = gtk.Menu()
627
616
 
628
617
        if self.branch.supports_tags():
629
618
            tags = self.branch.tags.get_tag_dict().items()
630
619
            tags.sort(reverse=True)
631
620
            for tag, revid in tags:
632
 
                tag_image = Gtk.Image()
 
621
                tag_image = gtk.Image()
633
622
                tag_image.set_from_file(icon_path('tag-16.png'))
634
 
                tag_item = Gtk.ImageMenuItem.new_with_mnemonic(
635
 
                    tag.replace('_', '__'))
 
623
                tag_item = gtk.ImageMenuItem(tag.replace('_', '__'))
636
624
                tag_item.set_image(tag_image)
637
625
                tag_item.connect('activate', self._tag_selected_cb, revid)
638
626
                tag_item.set_sensitive(self.treeview.has_revision_id(revid))
657
645
            return width, height
658
646
        return None
659
647
 
660
 
    def show_diff(self, revid, parentid=NULL_REVISION):
 
648
    def show_diff(self, revid=None, parentid=NULL_REVISION):
661
649
        """Open a new window to show a diff between the given revisions."""
662
650
        from bzrlib.plugins.gtk.diff import DiffWindow
663
651
        window = DiffWindow(parent=self)