14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
19
from gi.repository import Gdk
20
from gi.repository import Gtk
21
from gi.repository import GObject
22
from gi.repository import Pango
30
24
from bzrlib import (
28
revision as _mod_revision,
37
from bzrlib import bencode
39
from bzrlib.util import bencode
41
from bzrlib.plugins.gtk import _i18n
42
32
from bzrlib.plugins.gtk.dialog import question_dialog
43
33
from bzrlib.plugins.gtk.errors import show_bzr_error
34
from bzrlib.plugins.gtk.i18n import _i18n
35
from bzrlib.plugins.gtk.commitmsgs import SavedCommitMessagesManager
45
def _get_sorted_revisions(tip_revision, revision_ids, parent_map):
46
"""Get an iterator which will return the revisions in merge sorted order.
48
This will build up a list of all nodes, such that only nodes in the list
49
are referenced. It then uses MergeSorter to return them in 'merge-sorted'
52
:param revision_ids: A set of revision_ids
53
:param parent_map: The parent information for each node. Revisions which
54
are considered ghosts should not be present in the map.
55
:return: iterator from MergeSorter.iter_topo_order()
57
# MergeSorter requires that all nodes be present in the graph, so get rid
58
# of any references pointing outside of this graph.
60
for revision_id in revision_ids:
61
if revision_id not in parent_map: # ghost
62
parent_graph[revision_id] = []
64
# Only include parents which are in this sub-graph
65
parent_graph[revision_id] = [p for p in parent_map[revision_id]
67
sorter = tsort.MergeSorter(parent_graph, tip_revision)
68
return sorter.iter_topo_order()
53
71
def pending_revisions(wt):
54
72
"""Return a list of pending merges or None if there are none of them.
69
87
last_revision = parents[0]
71
if last_revision is not None:
73
ignore = set(branch.repository.get_ancestry(last_revision,
75
except errors.NoSuchRevision:
76
# the last revision is a ghost : assume everything is new
78
ignore = set([None, last_revision])
89
graph = branch.repository.get_graph()
90
other_revisions = [last_revision]
83
93
for merge in pending:
86
rev = branch.repository.get_revision(merge)
88
pm.append((rev, children))
90
# This does need to be topo sorted, so we search backwards
91
inner_merges = branch.repository.get_ancestry(merge)
92
assert inner_merges[0] is None
94
for mmerge in reversed(inner_merges):
97
rev = branch.repository.get_revision(mmerge)
101
except errors.NoSuchRevision:
102
print "DEBUG: NoSuchRevision:", merge
95
merge_rev = branch.repository.get_revision(merge)
96
except errors.NoSuchRevision:
97
# If we are missing a revision, just print out the revision id
98
trace.mutter("ghost: %r", merge)
99
other_revisions.append(merge)
102
# Find all of the revisions in the merge source, which are not in the
103
# last committed revision.
104
merge_extra = graph.find_unique_ancestors(merge, other_revisions)
105
other_revisions.append(merge)
106
merge_extra.discard(_mod_revision.NULL_REVISION)
108
# Get a handle to all of the revisions we will need
110
revisions = dict((rev.revision_id, rev) for rev in
111
branch.repository.get_revisions(merge_extra))
112
except errors.NoSuchRevision:
113
# One of the sub nodes is a ghost, check each one
115
for revision_id in merge_extra:
117
rev = branch.repository.get_revisions([revision_id])[0]
118
except errors.NoSuchRevision:
119
revisions[revision_id] = None
121
revisions[revision_id] = rev
123
# Display the revisions brought in by this merge.
124
rev_id_iterator = _get_sorted_revisions(merge, merge_extra,
125
branch.repository.get_parent_map(merge_extra))
126
# Skip the first node
127
num, first, depth, eom = rev_id_iterator.next()
129
raise AssertionError('Somehow we misunderstood how'
130
' iter_topo_order works %s != %s' % (first, merge))
132
for num, sub_merge, depth, eom in rev_id_iterator:
133
rev = revisions[sub_merge]
135
trace.warning("ghost: %r", sub_merge)
138
yield (merge_rev, children)
107
141
_newline_variants_re = re.compile(r'\r\n?')
108
142
def _sanitize_and_decode_message(utf8_message):
109
143
"""Turn a utf-8 message into a sanitized Unicode message."""
110
144
fixed_newline = _newline_variants_re.sub('\n', utf8_message)
111
return fixed_newline.decode('utf-8')
114
class CommitDialog(gtk.Dialog):
145
return osutils.safe_unicode(fixed_newline)
148
class CommitDialog(Gtk.Dialog):
115
149
"""Implementation of Commit."""
117
151
def __init__(self, wt, selected=None, parent=None):
118
gtk.Dialog.__init__(self, title="Commit to %s" % wt.basedir,
119
parent=parent, flags=0,)
152
super(CommitDialog, self).__init__(
153
title="Commit to %s" % wt.basedir, parent=parent, flags=0)
120
154
self.connect('delete-event', self._on_delete_window)
121
155
self._question_dialog = question_dialog
123
self.set_type_hint(gtk.gdk.WINDOW_TYPE_HINT_NORMAL)
157
self.set_type_hint(Gdk.WindowTypeHint.NORMAL)
126
160
# TODO: Do something with this value, it is used by Olive
319
359
self._hpane.set_position(300)
321
361
def _construct_accelerators(self):
322
group = gtk.AccelGroup()
323
group.connect_group(gtk.gdk.keyval_from_name('N'),
324
gtk.gdk.CONTROL_MASK, 0, self._on_accel_next)
362
group = Gtk.AccelGroup()
363
group.connect(Gdk.keyval_from_name('N'),
364
Gdk.ModifierType.CONTROL_MASK, 0, self._on_accel_next)
325
365
self.add_accel_group(group)
327
367
# ignore the escape key (avoid closing the window)
328
368
self.connect_object('close', self.emit_stop_by_name, 'close')
330
370
def _construct_left_pane(self):
331
self._left_pane_box = gtk.VBox(homogeneous=False, spacing=5)
371
self._left_pane_box = Gtk.VBox(homogeneous=False, spacing=5)
332
372
self._construct_file_list()
333
373
self._construct_pending_list()
335
self._check_local = gtk.CheckButton(_i18n("_Only commit locally"),
375
self._check_local = Gtk.CheckButton(_i18n("_Only commit locally"),
336
376
use_underline=True)
337
self._left_pane_box.pack_end(self._check_local, False, False)
377
self._left_pane_box.pack_end(self._check_local, False, False, 0)
338
378
self._check_local.set_active(False)
340
380
self._hpane.pack1(self._left_pane_box, resize=False, shrink=False)
359
399
self._hpane.pack2(self._right_pane_table, resize=True, shrink=True)
361
401
def _construct_action_pane(self):
362
self._button_cancel = gtk.Button(stock=gtk.STOCK_CANCEL)
402
self._button_cancel = Gtk.Button(stock=Gtk.STOCK_CANCEL)
363
403
self._button_cancel.connect('clicked', self._on_cancel_clicked)
364
404
self._button_cancel.show()
365
self.action_area.pack_end(self._button_cancel)
366
self._button_commit = gtk.Button(_i18n("Comm_it"), use_underline=True)
405
self.get_action_area().pack_end(
406
self._button_cancel, True, True, 0)
407
self._button_commit = Gtk.Button(_i18n("Comm_it"), use_underline=True)
367
408
self._button_commit.connect('clicked', self._on_commit_clicked)
368
self._button_commit.set_flags(gtk.CAN_DEFAULT)
409
self._button_commit.set_can_default(True)
369
410
self._button_commit.show()
370
self.action_area.pack_end(self._button_commit)
411
self.get_action_area().pack_end(
412
self._button_commit, True, True, 0)
371
413
self._button_commit.grab_default()
373
415
def _add_to_right_table(self, widget, weight, expanding=False):
388
430
self._right_pane_table_row = end_row
390
432
def _construct_file_list(self):
391
self._files_box = gtk.VBox(homogeneous=False, spacing=0)
392
file_label = gtk.Label(_i18n('Files'))
433
self._files_box = Gtk.VBox(homogeneous=False, spacing=0)
434
file_label = Gtk.Label(label=_i18n('Files'))
393
435
# file_label.show()
394
self._files_box.pack_start(file_label, expand=False)
436
self._files_box.pack_start(file_label, False, True, 0)
396
self._commit_all_files_radio = gtk.RadioButton(
438
self._commit_all_files_radio = Gtk.RadioButton.new_with_label(
397
439
None, _i18n("Commit all changes"))
398
self._files_box.pack_start(self._commit_all_files_radio, expand=False)
440
self._files_box.pack_start(self._commit_all_files_radio, False, True, 0)
399
441
self._commit_all_files_radio.show()
400
442
self._commit_all_files_radio.connect('toggled',
401
443
self._toggle_commit_selection)
402
self._commit_selected_radio = gtk.RadioButton(
444
self._commit_selected_radio = Gtk.RadioButton.new_with_label_from_widget(
403
445
self._commit_all_files_radio, _i18n("Only commit selected changes"))
404
self._files_box.pack_start(self._commit_selected_radio, expand=False)
446
self._files_box.pack_start(self._commit_selected_radio, False, True, 0)
405
447
self._commit_selected_radio.show()
406
448
self._commit_selected_radio.connect('toggled',
407
449
self._toggle_commit_selection)
410
452
self._commit_all_files_radio.set_sensitive(False)
411
453
self._commit_selected_radio.set_sensitive(False)
413
scroller = gtk.ScrolledWindow()
414
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
415
self._treeview_files = gtk.TreeView()
455
scroller = Gtk.ScrolledWindow()
456
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
457
self._treeview_files = Gtk.TreeView()
416
458
self._treeview_files.show()
417
459
scroller.add(self._treeview_files)
418
scroller.set_shadow_type(gtk.SHADOW_IN)
460
scroller.set_shadow_type(Gtk.ShadowType.IN)
420
self._files_box.pack_start(scroller,
421
expand=True, fill=True)
462
self._files_box.pack_start(scroller, True, True, 0)
422
463
self._files_box.show()
423
self._left_pane_box.pack_start(self._files_box)
464
self._left_pane_box.pack_start(self._files_box, True, True, 0)
425
466
# Keep note that all strings stored in a ListStore must be UTF-8
426
467
# strings. GTK does not support directly setting and restoring Unicode
428
liststore = gtk.ListStore(
429
gobject.TYPE_STRING, # [0] file_id
430
gobject.TYPE_STRING, # [1] real path
431
gobject.TYPE_BOOLEAN, # [2] checkbox
432
gobject.TYPE_STRING, # [3] display path
433
gobject.TYPE_STRING, # [4] changes type
434
gobject.TYPE_STRING, # [5] commit message
469
liststore = Gtk.ListStore(
470
GObject.TYPE_STRING, # [0] file_id
471
GObject.TYPE_STRING, # [1] real path
472
GObject.TYPE_BOOLEAN, # [2] checkbox
473
GObject.TYPE_STRING, # [3] display path
474
GObject.TYPE_STRING, # [4] changes type
475
GObject.TYPE_STRING, # [5] commit message
436
477
self._files_store = liststore
437
478
self._treeview_files.set_model(liststore)
438
crt = gtk.CellRendererToggle()
479
crt = Gtk.CellRendererToggle()
439
480
crt.set_property('activatable', not bool(self._pending))
440
481
crt.connect("toggled", self._toggle_commit, self._files_store)
441
482
if self._pending:
442
483
name = _i18n('Commit*')
444
485
name = _i18n('Commit')
445
commit_col = gtk.TreeViewColumn(name, crt, active=2)
486
commit_col = Gtk.TreeViewColumn(name, crt, active=2)
446
487
commit_col.set_visible(False)
447
488
self._treeview_files.append_column(commit_col)
448
self._treeview_files.append_column(gtk.TreeViewColumn(_i18n('Path'),
449
gtk.CellRendererText(), text=3))
450
self._treeview_files.append_column(gtk.TreeViewColumn(_i18n('Type'),
451
gtk.CellRendererText(), text=4))
489
self._treeview_files.append_column(Gtk.TreeViewColumn(_i18n('Path'),
490
Gtk.CellRendererText(), text=3))
491
self._treeview_files.append_column(Gtk.TreeViewColumn(_i18n('Type'),
492
Gtk.CellRendererText(), text=4))
452
493
self._treeview_files.connect('cursor-changed',
453
494
self._on_treeview_files_cursor_changed)
455
496
def _toggle_commit(self, cell, path, model):
456
if model[path][0] is None: # No file_id means 'All Files'
497
if model[path][0] == "": # No file_id means 'All Files'
457
498
new_val = not model[path][2]
458
499
for node in model:
459
500
node[2] = new_val
469
510
checked_col.set_visible(False)
471
512
checked_col.set_visible(True)
472
renderer = checked_col.get_cell_renderers()[0]
513
renderer = checked_col.get_cells()[0]
473
514
renderer.set_property('activatable', not all_files)
475
516
def _construct_pending_list(self):
476
517
# Pending information defaults to hidden, we put it all in 1 box, so
477
518
# that we can show/hide all of them at once
478
self._pending_box = gtk.VBox()
519
self._pending_box = Gtk.VBox()
479
520
self._pending_box.hide()
481
pending_message = gtk.Label()
522
pending_message = Gtk.Label()
482
523
pending_message.set_markup(
483
524
_i18n('<i>* Cannot select specific files when merging</i>'))
484
self._pending_box.pack_start(pending_message, expand=False, padding=5)
525
self._pending_box.pack_start(pending_message, False, True, 5)
485
526
pending_message.show()
487
pending_label = gtk.Label(_i18n('Pending Revisions'))
488
self._pending_box.pack_start(pending_label, expand=False, padding=0)
528
pending_label = Gtk.Label(label=_i18n('Pending Revisions'))
529
self._pending_box.pack_start(pending_label, False, True, 0)
489
530
pending_label.show()
491
scroller = gtk.ScrolledWindow()
492
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
493
self._treeview_pending = gtk.TreeView()
532
scroller = Gtk.ScrolledWindow()
533
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
534
self._treeview_pending = Gtk.TreeView()
494
535
scroller.add(self._treeview_pending)
495
scroller.set_shadow_type(gtk.SHADOW_IN)
536
scroller.set_shadow_type(Gtk.ShadowType.IN)
497
self._pending_box.pack_start(scroller,
498
expand=True, fill=True, padding=5)
538
self._pending_box.pack_start(scroller, True, True, 5)
499
539
self._treeview_pending.show()
500
self._left_pane_box.pack_start(self._pending_box)
540
self._left_pane_box.pack_start(self._pending_box, True, True, 0)
502
liststore = gtk.ListStore(gobject.TYPE_STRING, # revision_id
503
gobject.TYPE_STRING, # date
504
gobject.TYPE_STRING, # committer
505
gobject.TYPE_STRING, # summary
542
liststore = Gtk.ListStore(GObject.TYPE_STRING, # revision_id
543
GObject.TYPE_STRING, # date
544
GObject.TYPE_STRING, # committer
545
GObject.TYPE_STRING, # summary
507
547
self._pending_store = liststore
508
548
self._treeview_pending.set_model(liststore)
509
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Date'),
510
gtk.CellRendererText(), text=1))
511
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Committer'),
512
gtk.CellRendererText(), text=2))
513
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Summary'),
514
gtk.CellRendererText(), text=3))
549
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Date'),
550
Gtk.CellRendererText(), text=1))
551
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Committer'),
552
Gtk.CellRendererText(), text=2))
553
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Summary'),
554
Gtk.CellRendererText(), text=3))
516
556
def _construct_diff_view(self):
517
from diff import DiffView
557
from bzrlib.plugins.gtk.diff import DiffView
519
559
# TODO: jam 2007-10-30 The diff label is currently disabled. If we
520
560
# decide that we really don't ever want to display it, we should
521
561
# actually remove it, and other references to it, along with the
522
562
# tests that it is set properly.
523
self._diff_label = gtk.Label(_i18n('Diff for whole tree'))
563
self._diff_label = Gtk.Label(label=_i18n('Diff for whole tree'))
524
564
self._diff_label.set_alignment(0, 0)
525
565
self._right_pane_table.set_row_spacing(self._right_pane_table_row, 0)
526
566
self._add_to_right_table(self._diff_label, 1, False)
531
571
self._diff_view.show()
533
573
def _construct_file_message(self):
534
scroller = gtk.ScrolledWindow()
535
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
574
scroller = Gtk.ScrolledWindow()
575
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
537
self._file_message_text_view = gtk.TextView()
577
self._file_message_text_view = Gtk.TextView()
538
578
scroller.add(self._file_message_text_view)
539
scroller.set_shadow_type(gtk.SHADOW_IN)
579
scroller.set_shadow_type(Gtk.ShadowType.IN)
542
self._file_message_text_view.modify_font(pango.FontDescription("Monospace"))
543
self._file_message_text_view.set_wrap_mode(gtk.WRAP_WORD)
582
self._file_message_text_view.modify_font(Pango.FontDescription("Monospace"))
583
self._file_message_text_view.set_wrap_mode(Gtk.WrapMode.WORD)
544
584
self._file_message_text_view.set_accepts_tab(False)
545
585
self._file_message_text_view.show()
547
self._file_message_expander = gtk.Expander(_i18n('File commit message'))
587
self._file_message_expander = Gtk.Expander(
588
label=_i18n('File commit message'))
548
589
self._file_message_expander.set_expanded(True)
549
590
self._file_message_expander.add(scroller)
550
591
self._add_to_right_table(self._file_message_expander, 1, False)
551
592
self._file_message_expander.show()
553
594
def _construct_global_message(self):
554
self._global_message_label = gtk.Label(_i18n('Global Commit Message'))
595
self._global_message_label = Gtk.Label(label=_i18n('Global Commit Message'))
555
596
self._global_message_label.set_markup(
556
597
_i18n('<b>Global Commit Message</b>'))
557
598
self._global_message_label.set_alignment(0, 0)
560
601
# Can we remove the spacing between the label and the box?
561
602
self._global_message_label.show()
563
scroller = gtk.ScrolledWindow()
564
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
604
scroller = Gtk.ScrolledWindow()
605
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
566
self._global_message_text_view = gtk.TextView()
607
self._global_message_text_view = Gtk.TextView()
567
608
self._set_global_commit_message(self._saved_commit_messages_manager.get()[0])
568
self._global_message_text_view.modify_font(pango.FontDescription("Monospace"))
609
self._global_message_text_view.modify_font(Pango.FontDescription("Monospace"))
569
610
scroller.add(self._global_message_text_view)
570
scroller.set_shadow_type(gtk.SHADOW_IN)
611
scroller.set_shadow_type(Gtk.ShadowType.IN)
572
613
self._add_to_right_table(scroller, 2, True)
573
self._file_message_text_view.set_wrap_mode(gtk.WRAP_WORD)
614
self._file_message_text_view.set_wrap_mode(Gtk.WrapMode.WORD)
574
615
self._file_message_text_view.set_accepts_tab(False)
575
616
self._global_message_text_view.show()
577
618
def _on_treeview_files_cursor_changed(self, treeview):
578
619
treeselection = treeview.get_selection()
620
if treeselection is None:
621
# The treeview was probably destroyed as the dialog closes.
579
623
(model, selection) = treeselection.get_selected()
581
625
if selection is not None:
582
626
path, display_path = model.get(selection, 1, 3)
583
627
self._diff_label.set_text(_i18n('Diff for ') + display_path)
585
629
self._diff_view.show_diff(None)
587
self._diff_view.show_diff([path.decode('UTF-8')])
631
self._diff_view.show_diff([osutils.safe_unicode(path)])
588
632
self._update_per_file_info(selection)
590
634
def _on_accel_next(self, accel_group, window, keyval, modifier):
601
645
# We have either made it to the end of the list, or nothing was
602
646
# selected. Either way, select All Files, and jump to the global
603
647
# commit message.
604
self._treeview_files.set_cursor((0,))
648
self._treeview_files.set_cursor(
649
Gtk.TreePath(path=0), "", False)
605
650
self._global_message_text_view.grab_focus()
607
652
# Set the cursor to this entry, and jump to the per-file commit
609
self._treeview_files.set_cursor(model.get_path(next))
654
self._treeview_files.set_cursor(model.get_path(next), None, False)
610
655
self._file_message_text_view.grab_focus()
612
657
def _save_current_file_message(self):
797
842
rev_dict['revision_id'] = rev.revision_id
801
class SavedCommitMessagesManager:
802
"""Save glogal and per-file commit messages.
804
Saves global commit message and utf-8 file_id->message dictionary
805
of per-file commit messages on disk. Re-reads them later for re-using.
808
def __init__(self, tree=None, branch=None):
809
"""If branch is None, builds empty messages, otherwise reads them
810
from branch's disk storage. 'tree' argument is for the future."""
812
self.global_message = u''
813
self.file_messages = {}
815
config = branch.get_config()._get_branch_data_config()
816
self.global_message = config.get_user_option(
817
'gtk_global_commit_message')
818
if self.global_message is None:
819
self.global_message = u''
820
file_messages = config.get_user_option('gtk_file_commit_messages')
821
if file_messages: # unicode and B-encoded:
822
self.file_messages = bencode.bdecode(
823
file_messages.encode('UTF-8'))
825
self.file_messages = {}
828
return self.global_message, self.file_messages
830
def is_not_empty(self):
831
return bool(self.global_message or self.file_messages)
833
def insert(self, global_message, file_info):
834
"""Formats per-file commit messages (list of dictionaries, one per file)
835
into one utf-8 file_id->message dictionary and merges this with
836
previously existing dictionary. Merges global commit message too."""
839
file_message = fi['message']
841
file_messages[fi['file_id']] = file_message # utf-8 strings
842
for k,v in file_messages.iteritems():
844
self.file_messages[k] = v + '\n******\n' + self.file_messages[k]
846
self.file_messages[k] = v
847
if self.global_message:
848
self.global_message = global_message + '\n******\n' \
849
+ self.global_message
851
self.global_message = global_message
853
def save(self, tree, branch):
854
# We store in branch's config, which can be a problem if two gcommit
855
# are done in two checkouts of one single branch (comments overwrite
856
# each other). Ideally should be in working tree. But uncommit does
857
# not always have a working tree, though it always has a branch.
858
# 'tree' argument is for the future
859
config = branch.get_config()
860
# should it be named "gtk_" or some more neutral name ("gui_" ?) to
861
# be compatible with qbzr in the future?
862
config.set_user_option('gtk_global_commit_message', self.global_message)
863
# bencode() does not know unicode objects but set_user_option()
865
config.set_user_option(
866
'gtk_file_commit_messages',
867
bencode.bencode(self.file_messages).decode('UTF-8'))
870
def save_commit_messages(local, master, old_revno, old_revid,
871
new_revno, new_revid):
875
mgr = SavedCommitMessagesManager(None, b)
876
revid_iterator = b.repository.iter_reverse_revision_history(old_revid)
877
cur_revno = old_revno
878
new_revision_id = old_revid
879
graph = b.repository.get_graph()
880
for rev_id in revid_iterator:
881
if cur_revno == new_revno:
884
rev = b.repository.get_revision(rev_id)
885
file_info = rev.properties.get('file-info', None)
886
if file_info is None:
889
file_info = bencode.bdecode(file_info.encode('UTF-8'))
890
global_message = osutils.safe_unicode(rev.message)
891
# Concatenate comment of the uncommitted revision
892
mgr.insert(global_message, file_info)
894
parents = graph.get_parent_map([rev_id]).get(rev_id, None)