14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
30
from bzrlib import errors, osutils
31
from bzrlib.trace import mutter
32
from bzrlib.util import bencode
19
from gi.repository import Gdk
20
from gi.repository import Gtk
21
from gi.repository import GObject
22
from gi.repository import Pango
34
from bzrlib.plugins.gtk import _i18n
35
from dialog import error_dialog, question_dialog
36
from errors import show_bzr_error
28
revision as _mod_revision,
32
from bzrlib.plugins.gtk.dialog import question_dialog
33
from bzrlib.plugins.gtk.diff import DiffView
34
from bzrlib.plugins.gtk.errors import show_bzr_error
35
from bzrlib.plugins.gtk.i18n import _i18n
36
from bzrlib.plugins.gtk.commitmsgs import SavedCommitMessagesManager
46
def _get_sorted_revisions(tip_revision, revision_ids, parent_map):
47
"""Get an iterator which will return the revisions in merge sorted order.
49
This will build up a list of all nodes, such that only nodes in the list
50
are referenced. It then uses MergeSorter to return them in 'merge-sorted'
53
:param revision_ids: A set of revision_ids
54
:param parent_map: The parent information for each node. Revisions which
55
are considered ghosts should not be present in the map.
56
:return: iterator from MergeSorter.iter_topo_order()
58
# MergeSorter requires that all nodes be present in the graph, so get rid
59
# of any references pointing outside of this graph.
61
for revision_id in revision_ids:
62
if revision_id not in parent_map: # ghost
63
parent_graph[revision_id] = []
65
# Only include parents which are in this sub-graph
66
parent_graph[revision_id] = [p for p in parent_map[revision_id]
68
sorter = tsort.MergeSorter(parent_graph, tip_revision)
69
return sorter.iter_topo_order()
46
72
def pending_revisions(wt):
47
73
"""Return a list of pending merges or None if there are none of them.
62
88
last_revision = parents[0]
64
if last_revision is not None:
66
ignore = set(branch.repository.get_ancestry(last_revision,
68
except errors.NoSuchRevision:
69
# the last revision is a ghost : assume everything is new
71
ignore = set([None, last_revision])
90
graph = branch.repository.get_graph()
91
other_revisions = [last_revision]
76
94
for merge in pending:
79
rev = branch.repository.get_revision(merge)
81
pm.append((rev, children))
83
# This does need to be topo sorted, so we search backwards
84
inner_merges = branch.repository.get_ancestry(merge)
85
assert inner_merges[0] is None
87
for mmerge in reversed(inner_merges):
90
rev = branch.repository.get_revision(mmerge)
94
except errors.NoSuchRevision:
95
print "DEBUG: NoSuchRevision:", merge
100
class CommitDialog(gtk.Dialog):
96
merge_rev = branch.repository.get_revision(merge)
97
except errors.NoSuchRevision:
98
# If we are missing a revision, just print out the revision id
99
trace.mutter("ghost: %r", merge)
100
other_revisions.append(merge)
103
# Find all of the revisions in the merge source, which are not in the
104
# last committed revision.
105
merge_extra = graph.find_unique_ancestors(merge, other_revisions)
106
other_revisions.append(merge)
107
merge_extra.discard(_mod_revision.NULL_REVISION)
109
# Get a handle to all of the revisions we will need
111
revisions = dict((rev.revision_id, rev) for rev in
112
branch.repository.get_revisions(merge_extra))
113
except errors.NoSuchRevision:
114
# One of the sub nodes is a ghost, check each one
116
for revision_id in merge_extra:
118
rev = branch.repository.get_revisions([revision_id])[0]
119
except errors.NoSuchRevision:
120
revisions[revision_id] = None
122
revisions[revision_id] = rev
124
# Display the revisions brought in by this merge.
125
rev_id_iterator = _get_sorted_revisions(merge, merge_extra,
126
branch.repository.get_parent_map(merge_extra))
127
# Skip the first node
128
num, first, depth, eom = rev_id_iterator.next()
130
raise AssertionError('Somehow we misunderstood how'
131
' iter_topo_order works %s != %s' % (first, merge))
133
for num, sub_merge, depth, eom in rev_id_iterator:
134
rev = revisions[sub_merge]
136
trace.warning("ghost: %r", sub_merge)
139
yield (merge_rev, children)
142
_newline_variants_re = re.compile(r'\r\n?')
143
def _sanitize_and_decode_message(utf8_message):
144
"""Turn a utf-8 message into a sanitized Unicode message."""
145
fixed_newline = _newline_variants_re.sub('\n', utf8_message)
146
return osutils.safe_unicode(fixed_newline)
149
class CommitDialog(Gtk.Dialog):
101
150
"""Implementation of Commit."""
103
152
def __init__(self, wt, selected=None, parent=None):
104
gtk.Dialog.__init__(self, title="Commit - Olive",
107
buttons=(gtk.STOCK_CANCEL, gtk.RESPONSE_CANCEL))
153
super(CommitDialog, self).__init__(
154
title="Commit to %s" % wt.basedir, parent=parent, flags=0)
155
self.connect('delete-event', self._on_delete_window)
108
156
self._question_dialog = question_dialog
158
self.set_type_hint(Gdk.WindowTypeHint.NORMAL)
111
161
# TODO: Do something with this value, it is used by Olive
112
162
# It used to set all changes but this one to False
182
239
all_enabled = (self._selected is None)
183
240
# The first entry is always the 'whole tree'
184
all_iter = store.append([None, None, all_enabled, 'All Files', '', ''])
241
all_iter = store.append(["", "", all_enabled, 'All Files', '', ''])
185
242
initial_cursor = store.get_path(all_iter)
186
243
# should we pass specific_files?
187
244
self._wt.lock_read()
188
245
self._basis_tree.lock_read()
190
247
from diff import iter_changes_to_status
248
saved_file_messages = self._saved_commit_messages_manager.get()[1]
191
249
for (file_id, real_path, change_type, display_path
192
250
) in iter_changes_to_status(self._basis_tree, self._wt):
193
251
if self._selected and real_path != self._selected:
256
default_message = saved_file_messages[file_id]
197
259
item_iter = store.append([
199
261
real_path.encode('UTF-8'),
201
263
display_path.encode('UTF-8'),
203
'', # Initial comment
265
default_message, # Initial comment
205
267
if self._selected and enabled:
206
268
initial_cursor = store.get_path(item_iter)
298
365
self._hpane.set_position(300)
300
367
def _construct_accelerators(self):
301
group = gtk.AccelGroup()
302
group.connect_group(gtk.gdk.keyval_from_name('N'),
303
gtk.gdk.CONTROL_MASK, 0, self._on_accel_next)
368
group = Gtk.AccelGroup()
369
group.connect(Gdk.keyval_from_name('N'),
370
Gdk.ModifierType.CONTROL_MASK, 0, self._on_accel_next)
304
371
self.add_accel_group(group)
373
# ignore the escape key (avoid closing the window)
374
self.connect_object('close', self.emit_stop_by_name, 'close')
306
376
def _construct_left_pane(self):
307
self._left_pane_box = gtk.VBox(homogeneous=False, spacing=5)
377
self._left_pane_box = Gtk.VBox(homogeneous=False, spacing=5)
308
378
self._construct_file_list()
309
379
self._construct_pending_list()
311
self._check_local = gtk.CheckButton(_i18n("_Only commit locally"),
381
self._check_local = Gtk.CheckButton(_i18n("_Only commit locally"),
312
382
use_underline=True)
313
self._left_pane_box.pack_end(self._check_local, False, False)
383
self._left_pane_box.pack_end(self._check_local, False, False, 0)
314
384
self._check_local.set_active(False)
316
386
self._hpane.pack1(self._left_pane_box, resize=False, shrink=False)
335
405
self._hpane.pack2(self._right_pane_table, resize=True, shrink=True)
337
407
def _construct_action_pane(self):
338
self._button_commit = gtk.Button(_i18n("Comm_it"), use_underline=True)
408
self._button_cancel = Gtk.Button(stock=Gtk.STOCK_CANCEL)
409
self._button_cancel.connect('clicked', self._on_cancel_clicked)
410
self._button_cancel.show()
411
self.get_action_area().pack_end(
412
self._button_cancel, True, True, 0)
413
self._button_commit = Gtk.Button(_i18n("Comm_it"), use_underline=True)
339
414
self._button_commit.connect('clicked', self._on_commit_clicked)
340
self._button_commit.set_flags(gtk.CAN_DEFAULT)
415
self._button_commit.set_can_default(True)
341
416
self._button_commit.show()
342
self.action_area.pack_end(self._button_commit)
417
self.get_action_area().pack_end(
418
self._button_commit, True, True, 0)
343
419
self._button_commit.grab_default()
345
421
def _add_to_right_table(self, widget, weight, expanding=False):
360
436
self._right_pane_table_row = end_row
362
438
def _construct_file_list(self):
363
self._files_box = gtk.VBox(homogeneous=False, spacing=0)
364
file_label = gtk.Label(_i18n('Files'))
439
self._files_box = Gtk.VBox(homogeneous=False, spacing=0)
440
file_label = Gtk.Label(label=_i18n('Files'))
365
441
# file_label.show()
366
self._files_box.pack_start(file_label, expand=False)
442
self._files_box.pack_start(file_label, False, True, 0)
368
self._commit_all_files_radio = gtk.RadioButton(
444
self._commit_all_files_radio = Gtk.RadioButton.new_with_label(
369
445
None, _i18n("Commit all changes"))
370
self._files_box.pack_start(self._commit_all_files_radio, expand=False)
446
self._files_box.pack_start(self._commit_all_files_radio, False, True, 0)
371
447
self._commit_all_files_radio.show()
372
448
self._commit_all_files_radio.connect('toggled',
373
449
self._toggle_commit_selection)
374
self._commit_selected_radio = gtk.RadioButton(
450
self._commit_selected_radio = Gtk.RadioButton.new_with_label_from_widget(
375
451
self._commit_all_files_radio, _i18n("Only commit selected changes"))
376
self._files_box.pack_start(self._commit_selected_radio, expand=False)
452
self._files_box.pack_start(self._commit_selected_radio, False, True, 0)
377
453
self._commit_selected_radio.show()
378
454
self._commit_selected_radio.connect('toggled',
379
455
self._toggle_commit_selection)
382
458
self._commit_all_files_radio.set_sensitive(False)
383
459
self._commit_selected_radio.set_sensitive(False)
385
scroller = gtk.ScrolledWindow()
386
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
387
self._treeview_files = gtk.TreeView()
461
scroller = Gtk.ScrolledWindow()
462
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
463
self._treeview_files = Gtk.TreeView()
388
464
self._treeview_files.show()
389
465
scroller.add(self._treeview_files)
390
scroller.set_shadow_type(gtk.SHADOW_IN)
466
scroller.set_shadow_type(Gtk.ShadowType.IN)
392
self._files_box.pack_start(scroller,
393
expand=True, fill=True)
468
self._files_box.pack_start(scroller, True, True, 0)
394
469
self._files_box.show()
395
self._left_pane_box.pack_start(self._files_box)
470
self._left_pane_box.pack_start(self._files_box, True, True, 0)
397
472
# Keep note that all strings stored in a ListStore must be UTF-8
398
473
# strings. GTK does not support directly setting and restoring Unicode
400
liststore = gtk.ListStore(
401
gobject.TYPE_STRING, # [0] file_id
402
gobject.TYPE_STRING, # [1] real path
403
gobject.TYPE_BOOLEAN, # [2] checkbox
404
gobject.TYPE_STRING, # [3] display path
405
gobject.TYPE_STRING, # [4] changes type
406
gobject.TYPE_STRING, # [5] commit message
475
liststore = Gtk.ListStore(
476
GObject.TYPE_STRING, # [0] file_id
477
GObject.TYPE_STRING, # [1] real path
478
GObject.TYPE_BOOLEAN, # [2] checkbox
479
GObject.TYPE_STRING, # [3] display path
480
GObject.TYPE_STRING, # [4] changes type
481
GObject.TYPE_STRING, # [5] commit message
408
483
self._files_store = liststore
409
484
self._treeview_files.set_model(liststore)
410
crt = gtk.CellRendererToggle()
485
crt = Gtk.CellRendererToggle()
411
486
crt.set_property('activatable', not bool(self._pending))
412
487
crt.connect("toggled", self._toggle_commit, self._files_store)
413
488
if self._pending:
414
489
name = _i18n('Commit*')
416
491
name = _i18n('Commit')
417
commit_col = gtk.TreeViewColumn(name, crt, active=2)
492
commit_col = Gtk.TreeViewColumn(name, crt, active=2)
418
493
commit_col.set_visible(False)
419
494
self._treeview_files.append_column(commit_col)
420
self._treeview_files.append_column(gtk.TreeViewColumn(_i18n('Path'),
421
gtk.CellRendererText(), text=3))
422
self._treeview_files.append_column(gtk.TreeViewColumn(_i18n('Type'),
423
gtk.CellRendererText(), text=4))
495
self._treeview_files.append_column(Gtk.TreeViewColumn(_i18n('Path'),
496
Gtk.CellRendererText(), text=3))
497
self._treeview_files.append_column(Gtk.TreeViewColumn(_i18n('Type'),
498
Gtk.CellRendererText(), text=4))
424
499
self._treeview_files.connect('cursor-changed',
425
500
self._on_treeview_files_cursor_changed)
427
502
def _toggle_commit(self, cell, path, model):
428
if model[path][0] is None: # No file_id means 'All Files'
503
if model[path][0] == "": # No file_id means 'All Files'
429
504
new_val = not model[path][2]
430
505
for node in model:
431
506
node[2] = new_val
441
516
checked_col.set_visible(False)
443
518
checked_col.set_visible(True)
444
renderer = checked_col.get_cell_renderers()[0]
519
renderer = checked_col.get_cells()[0]
445
520
renderer.set_property('activatable', not all_files)
447
522
def _construct_pending_list(self):
448
523
# Pending information defaults to hidden, we put it all in 1 box, so
449
524
# that we can show/hide all of them at once
450
self._pending_box = gtk.VBox()
525
self._pending_box = Gtk.VBox()
451
526
self._pending_box.hide()
453
pending_message = gtk.Label()
528
pending_message = Gtk.Label()
454
529
pending_message.set_markup(
455
530
_i18n('<i>* Cannot select specific files when merging</i>'))
456
self._pending_box.pack_start(pending_message, expand=False, padding=5)
531
self._pending_box.pack_start(pending_message, False, True, 5)
457
532
pending_message.show()
459
pending_label = gtk.Label(_i18n('Pending Revisions'))
460
self._pending_box.pack_start(pending_label, expand=False, padding=0)
534
pending_label = Gtk.Label(label=_i18n('Pending Revisions'))
535
self._pending_box.pack_start(pending_label, False, True, 0)
461
536
pending_label.show()
463
scroller = gtk.ScrolledWindow()
464
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
465
self._treeview_pending = gtk.TreeView()
538
scroller = Gtk.ScrolledWindow()
539
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
540
self._treeview_pending = Gtk.TreeView()
466
541
scroller.add(self._treeview_pending)
467
scroller.set_shadow_type(gtk.SHADOW_IN)
542
scroller.set_shadow_type(Gtk.ShadowType.IN)
469
self._pending_box.pack_start(scroller,
470
expand=True, fill=True, padding=5)
544
self._pending_box.pack_start(scroller, True, True, 5)
471
545
self._treeview_pending.show()
472
self._left_pane_box.pack_start(self._pending_box)
546
self._left_pane_box.pack_start(self._pending_box, True, True, 0)
474
liststore = gtk.ListStore(gobject.TYPE_STRING, # revision_id
475
gobject.TYPE_STRING, # date
476
gobject.TYPE_STRING, # committer
477
gobject.TYPE_STRING, # summary
548
liststore = Gtk.ListStore(GObject.TYPE_STRING, # revision_id
549
GObject.TYPE_STRING, # date
550
GObject.TYPE_STRING, # committer
551
GObject.TYPE_STRING, # summary
479
553
self._pending_store = liststore
480
554
self._treeview_pending.set_model(liststore)
481
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Date'),
482
gtk.CellRendererText(), text=1))
483
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Committer'),
484
gtk.CellRendererText(), text=2))
485
self._treeview_pending.append_column(gtk.TreeViewColumn(_i18n('Summary'),
486
gtk.CellRendererText(), text=3))
555
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Date'),
556
Gtk.CellRendererText(), text=1))
557
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Committer'),
558
Gtk.CellRendererText(), text=2))
559
self._treeview_pending.append_column(Gtk.TreeViewColumn(_i18n('Summary'),
560
Gtk.CellRendererText(), text=3))
488
562
def _construct_diff_view(self):
489
from diff import DiffView
491
563
# TODO: jam 2007-10-30 The diff label is currently disabled. If we
492
564
# decide that we really don't ever want to display it, we should
493
565
# actually remove it, and other references to it, along with the
494
566
# tests that it is set properly.
495
self._diff_label = gtk.Label(_i18n('Diff for whole tree'))
567
self._diff_label = Gtk.Label(label=_i18n('Diff for whole tree'))
496
568
self._diff_label.set_alignment(0, 0)
497
569
self._right_pane_table.set_row_spacing(self._right_pane_table_row, 0)
498
570
self._add_to_right_table(self._diff_label, 1, False)
502
574
self._add_to_right_table(self._diff_view, 4, True)
503
575
self._diff_view.show()
578
def get_line_height(widget):
579
pango_layout = widget.create_pango_layout("X");
580
ink_rectangle, logical_rectangle = pango_layout.get_pixel_extents()
581
return logical_rectangle.height
505
583
def _construct_file_message(self):
506
scroller = gtk.ScrolledWindow()
507
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
584
scroller = Gtk.ScrolledWindow()
585
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
509
self._file_message_text_view = gtk.TextView()
587
self._file_message_text_view = Gtk.TextView()
510
588
scroller.add(self._file_message_text_view)
511
scroller.set_shadow_type(gtk.SHADOW_IN)
589
scroller.set_shadow_type(Gtk.ShadowType.IN)
514
self._file_message_text_view.modify_font(pango.FontDescription("Monospace"))
515
self._file_message_text_view.set_wrap_mode(gtk.WRAP_WORD)
592
self._file_message_text_view.modify_font(Pango.FontDescription("Monospace"))
593
self._file_message_text_view.set_wrap_mode(Gtk.WrapMode.WORD)
516
594
self._file_message_text_view.set_accepts_tab(False)
595
line_height = self.get_line_height(self._file_message_text_view)
596
self._file_message_text_view.set_size_request(-1, line_height * 2)
517
597
self._file_message_text_view.show()
519
self._file_message_expander = gtk.Expander(_i18n('File commit message'))
599
self._file_message_expander = Gtk.Expander(
600
label=_i18n('File commit message'))
520
601
self._file_message_expander.set_expanded(True)
521
602
self._file_message_expander.add(scroller)
522
603
self._add_to_right_table(self._file_message_expander, 1, False)
523
604
self._file_message_expander.show()
525
606
def _construct_global_message(self):
526
self._global_message_label = gtk.Label(_i18n('Global Commit Message'))
607
self._global_message_label = Gtk.Label(label=_i18n('Global Commit Message'))
527
608
self._global_message_label.set_markup(
528
609
_i18n('<b>Global Commit Message</b>'))
529
610
self._global_message_label.set_alignment(0, 0)
532
613
# Can we remove the spacing between the label and the box?
533
614
self._global_message_label.show()
535
scroller = gtk.ScrolledWindow()
536
scroller.set_policy(gtk.POLICY_AUTOMATIC, gtk.POLICY_AUTOMATIC)
616
scroller = Gtk.ScrolledWindow()
617
scroller.set_policy(Gtk.PolicyType.AUTOMATIC, Gtk.PolicyType.AUTOMATIC)
538
self._global_message_text_view = gtk.TextView()
539
self._global_message_text_view.modify_font(pango.FontDescription("Monospace"))
619
self._global_message_text_view = Gtk.TextView()
620
self._set_global_commit_message(self._saved_commit_messages_manager.get()[0])
621
self._global_message_text_view.modify_font(Pango.FontDescription("Monospace"))
540
622
scroller.add(self._global_message_text_view)
541
scroller.set_shadow_type(gtk.SHADOW_IN)
623
scroller.set_shadow_type(Gtk.ShadowType.IN)
543
625
self._add_to_right_table(scroller, 2, True)
544
self._file_message_text_view.set_wrap_mode(gtk.WRAP_WORD)
626
self._file_message_text_view.set_wrap_mode(Gtk.WrapMode.WORD)
545
627
self._file_message_text_view.set_accepts_tab(False)
546
628
self._global_message_text_view.show()
548
630
def _on_treeview_files_cursor_changed(self, treeview):
549
631
treeselection = treeview.get_selection()
632
if treeselection is None:
633
# The treeview was probably destroyed as the dialog closes.
550
635
(model, selection) = treeselection.get_selected()
552
637
if selection is not None:
553
638
path, display_path = model.get(selection, 1, 3)
554
639
self._diff_label.set_text(_i18n('Diff for ') + display_path)
556
641
self._diff_view.show_diff(None)
558
self._diff_view.show_diff([path.decode('UTF-8')])
643
self._diff_view.show_diff([osutils.safe_unicode(path)])
559
644
self._update_per_file_info(selection)
561
646
def _on_accel_next(self, accel_group, window, keyval, modifier):
572
657
# We have either made it to the end of the list, or nothing was
573
658
# selected. Either way, select All Files, and jump to the global
574
659
# commit message.
575
self._treeview_files.set_cursor((0,))
660
self._treeview_files.set_cursor(
661
Gtk.TreePath(path=0), "", False)
576
662
self._global_message_text_view.grab_focus()
578
664
# Set the cursor to this entry, and jump to the per-file commit
580
self._treeview_files.set_cursor(model.get_path(next))
666
self._treeview_files.set_cursor(model.get_path(next), None, False)
581
667
self._file_message_text_view.grab_focus()
583
669
def _save_current_file_message(self):
621
707
records = iter(self._files_store)
622
708
rec = records.next() # Skip the All Files record
623
assert rec[0] is None, "Are we skipping the wrong record?"
709
assert rec[0] == "", "Are we skipping the wrong record?"
626
712
for record in records:
627
713
if self._commit_all_changes or record[2]:# [2] checkbox
628
file_id = record[0] # [0] file_id
629
path = record[1] # [1] real path
630
file_message = record[5] # [5] commit message
714
file_id = osutils.safe_utf8(record[0]) # [0] file_id
715
path = osutils.safe_utf8(record[1]) # [1] real path
717
file_message = _sanitize_and_decode_message(record[5])
631
718
files.append(path.decode('UTF-8'))
632
719
if self._enable_per_file_commits and file_message:
633
720
# All of this needs to be utf-8 information
721
file_message = file_message.encode('UTF-8')
634
722
file_info.append({'path':path, 'file_id':file_id,
635
723
'message':file_message})
636
724
file_info.sort(key=lambda x:(x['path'], x['file_id']))
731
def _on_cancel_clicked(self, button):
732
""" Cancel button clicked handler. """
736
def _on_delete_window(self, source, event):
737
""" Delete window handler. """
740
def _do_cancel(self):
741
"""If requested, saves commit messages when cancelling gcommit; they are re-used by a next gcommit"""
742
mgr = SavedCommitMessagesManager()
743
self._saved_commit_messages_manager = mgr
744
mgr.insert(self._get_global_commit_message(),
745
self._get_specific_files()[1])
746
if mgr.is_not_empty(): # maybe worth saving
747
response = self._question_dialog(
748
_i18n('Commit cancelled'),
749
_i18n('Do you want to save your commit messages ?'),
751
if response == Gtk.ResponseType.NO:
752
# save nothing and destroy old comments if any
753
mgr = SavedCommitMessagesManager()
754
mgr.save(self._wt, self._wt.branch)
755
self.response(Gtk.ResponseType.CANCEL) # close window
643
758
def _on_commit_clicked(self, button):
644
759
""" Commit button clicked handler. """
645
760
self._do_commit()
699
818
specific_files=specific_files,
700
819
revprops=revprops)
701
820
self.committed_revision_id = rev_id
702
self.response(gtk.RESPONSE_OK)
821
# destroy old comments if any
822
SavedCommitMessagesManager().save(self._wt, self._wt.branch)
823
self.response(Gtk.ResponseType.OK)
704
825
def _get_global_commit_message(self):
705
826
buf = self._global_message_text_view.get_buffer()
706
827
start, end = buf.get_bounds()
707
return buf.get_text(start, end).decode('utf-8')
828
text = buf.get_text(start, end, True)
829
return _sanitize_and_decode_message(text)
709
831
def _set_global_commit_message(self, message):
710
832
"""Just a helper for the test suite."""