/b-gtk/fix-viz

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/b-gtk/fix-viz

« back to all changes in this revision

Viewing changes to branchview/treeview.py

  • Committer: Jelmer Vernooij
  • Date: 2012-03-29 13:15:14 UTC
  • mfrom: (786.1.1 register-lazy)
  • Revision ID: jelmer@samba.org-20120329131514-knrl1w2wzntx89rv
Use lazy registration.

Show diffs side-by-side

added added

removed removed

Lines of Context:
branchview/treeview.py
6
6
__copyright__ = "Copyright © 2005 Canonical Ltd."
7
7
__author__    = "Daniel Schierbeck <daniel.schierbeck@gmail.com>"
8
8
 
9
 
import sys
10
 
import string
11
 
import gtk
12
 
import gobject
13
 
import pango
14
 
import re
15
 
import treemodel
 
9
from gi.repository import Gtk
 
10
from gi.repository import GObject
 
11
from gi.repository import Pango
 
12
 
16
13
from bzrlib import ui
17
 
 
18
 
from bzrlib.plugins.gtk import _i18n
19
 
from bzrlib.plugins.gtk.ui import GtkProgressBar, ProgressPanel
20
 
from linegraph import linegraph, same_branch
21
 
from graphcell import CellRendererGraph
22
 
from treemodel import TreeModel
23
14
from bzrlib.revision import NULL_REVISION
24
15
 
25
 
 
26
 
class TreeView(gtk.VBox):
 
16
from bzrlib.plugins.gtk import lock
 
17
from bzrlib.plugins.gtk.ui import ProgressPanel
 
18
from bzrlib.plugins.gtk.branchview import treemodel
 
19
from bzrlib.plugins.gtk.branchview.linegraph import linegraph, same_branch
 
20
from bzrlib.plugins.gtk.branchview.graphcell import CellRendererGraph
 
21
 
 
22
 
 
23
class TreeView(Gtk.VBox):
27
24
 
28
25
    __gproperties__ = {
29
 
        'branch': (gobject.TYPE_PYOBJECT,
 
26
        'branch': (GObject.TYPE_PYOBJECT,
30
27
                   'Branch',
31
28
                   'The Bazaar branch being visualized',
32
 
                   gobject.PARAM_CONSTRUCT_ONLY | gobject.PARAM_WRITABLE),
 
29
                   GObject.PARAM_CONSTRUCT_ONLY | GObject.PARAM_WRITABLE),
33
30
 
34
 
        'revision': (gobject.TYPE_PYOBJECT,
 
31
        'revision': (GObject.TYPE_PYOBJECT,
35
32
                     'Revision',
36
33
                     'The currently selected revision',
37
 
                     gobject.PARAM_READWRITE),
 
34
                     GObject.PARAM_READWRITE),
38
35
 
39
 
        'revision-number': (gobject.TYPE_STRING,
 
36
        'revision-number': (GObject.TYPE_STRING,
40
37
                            'Revision number',
41
38
                            'The number of the selected revision',
42
39
                            '',
43
 
                            gobject.PARAM_READABLE),
 
40
                            GObject.PARAM_READABLE),
44
41
 
45
 
        'children': (gobject.TYPE_PYOBJECT,
 
42
        'children': (GObject.TYPE_PYOBJECT,
46
43
                     'Child revisions',
47
44
                     'Children of the currently selected revision',
48
 
                     gobject.PARAM_READABLE),
 
45
                     GObject.PARAM_READABLE),
49
46
 
50
 
        'parents': (gobject.TYPE_PYOBJECT,
 
47
        'parents': (GObject.TYPE_PYOBJECT,
51
48
                    'Parent revisions',
52
49
                    'Parents to the currently selected revision',
53
 
                    gobject.PARAM_READABLE),
 
50
                    GObject.PARAM_READABLE),
54
51
 
55
 
        'revno-column-visible': (gobject.TYPE_BOOLEAN,
 
52
        'revno-column-visible': (GObject.TYPE_BOOLEAN,
56
53
                                 'Revision number column',
57
54
                                 'Show revision number column',
58
55
                                 True,
59
 
                                 gobject.PARAM_READWRITE),
 
56
                                 GObject.PARAM_READWRITE),
60
57
 
61
 
        'graph-column-visible': (gobject.TYPE_BOOLEAN,
 
58
        'graph-column-visible': (GObject.TYPE_BOOLEAN,
62
59
                                 'Graph column',
63
60
                                 'Show graph column',
64
61
                                 True,
65
 
                                 gobject.PARAM_READWRITE),
 
62
                                 GObject.PARAM_READWRITE),
66
63
 
67
 
        'date-column-visible': (gobject.TYPE_BOOLEAN,
 
64
        'date-column-visible': (GObject.TYPE_BOOLEAN,
68
65
                                 'Date',
69
66
                                 'Show date column',
70
67
                                 False,
71
 
                                 gobject.PARAM_READWRITE),
 
68
                                 GObject.PARAM_READWRITE),
72
69
 
73
 
        'compact': (gobject.TYPE_BOOLEAN,
 
70
        'compact': (GObject.TYPE_BOOLEAN,
74
71
                    'Compact view',
75
72
                    'Break ancestry lines to save space',
76
73
                    True,
77
 
                    gobject.PARAM_CONSTRUCT | gobject.PARAM_READWRITE),
 
74
                    GObject.PARAM_CONSTRUCT | GObject.PARAM_READWRITE),
78
75
 
79
 
        'mainline-only': (gobject.TYPE_BOOLEAN,
 
76
        'mainline-only': (GObject.TYPE_BOOLEAN,
80
77
                    'Mainline only',
81
78
                    'Only show the mainline history.',
82
79
                    False,
83
 
                    gobject.PARAM_CONSTRUCT | gobject.PARAM_READWRITE),
 
80
                    GObject.PARAM_CONSTRUCT | GObject.PARAM_READWRITE),
84
81
 
85
82
    }
86
83
 
87
84
    __gsignals__ = {
88
 
        'revision-selected': (gobject.SIGNAL_RUN_FIRST,
89
 
                              gobject.TYPE_NONE,
 
85
        'revision-selected': (GObject.SignalFlags.RUN_FIRST,
 
86
                              None,
90
87
                              ()),
91
 
        'revision-activated': (gobject.SIGNAL_RUN_FIRST,
92
 
                              gobject.TYPE_NONE,
93
 
                              (gobject.TYPE_PYOBJECT, gobject.TYPE_PYOBJECT)),
94
 
        'tag-added': (gobject.SIGNAL_RUN_FIRST,
95
 
                              gobject.TYPE_NONE,
96
 
                              (gobject.TYPE_STRING, gobject.TYPE_STRING))
 
88
        'revision-activated': (GObject.SignalFlags.RUN_FIRST,
 
89
                              None,
 
90
                              (GObject.TYPE_PYOBJECT, GObject.TYPE_PYOBJECT)),
 
91
        'tag-added': (GObject.SignalFlags.RUN_FIRST,
 
92
                              None,
 
93
                              (GObject.TYPE_STRING, GObject.TYPE_STRING)),
 
94
        'refreshed': (GObject.SignalFlags.RUN_FIRST, None,
 
95
                              ())
97
96
    }
98
97
 
99
98
    def __init__(self, branch, start, maxnum, compact=True):
106
105
        :param broken_line_length: After how much lines to break 
107
106
                                   branches.
108
107
        """
109
 
        gtk.VBox.__init__(self, spacing=0)
110
 
 
111
 
        loading_msg_widget = ProgressPanel()
112
 
        ui.ui_factory.set_nested_progress_bar_widget(loading_msg_widget.get_progress_bar)
113
 
        self.pack_start(loading_msg_widget, expand=False, fill=True)
114
 
 
115
 
        self.scrolled_window = gtk.ScrolledWindow()
116
 
        self.scrolled_window.set_policy(gtk.POLICY_AUTOMATIC,
117
 
                                        gtk.POLICY_AUTOMATIC)
118
 
        self.scrolled_window.set_shadow_type(gtk.SHADOW_IN)
 
108
        super(TreeView, self).__init__(homogeneous=False, spacing=0)
 
109
 
 
110
        self.progress_widget = ProgressPanel()
 
111
        self.pack_start(self.progress_widget, False, True, 0)
 
112
        if getattr(ui.ui_factory, "set_progress_bar_widget", None) is not None:
 
113
            # We'are using our own ui, let's tell it to use our widget.
 
114
            ui.ui_factory.set_progress_bar_widget(self.progress_widget)
 
115
 
 
116
        self.scrolled_window = Gtk.ScrolledWindow()
 
117
        self.scrolled_window.set_policy(Gtk.PolicyType.AUTOMATIC,
 
118
                                        Gtk.PolicyType.AUTOMATIC)
 
119
        self.scrolled_window.set_shadow_type(Gtk.ShadowType.IN)
119
120
        self.scrolled_window.show()
120
 
        self.pack_start(self.scrolled_window, expand=True, fill=True)
 
121
        self.pack_start(self.scrolled_window, True, True, 0)
121
122
 
122
123
        self.scrolled_window.add(self.construct_treeview())
123
124
 
124
 
        self.iter = None
 
125
        self.path = None
125
126
        self.branch = branch
126
127
        self.revision = None
 
128
        self.index = {}
127
129
 
128
130
        self.start = start
129
131
        self.maxnum = maxnum
130
132
        self.compact = compact
131
133
 
132
 
        gobject.idle_add(self.populate)
133
 
 
134
 
        self.connect("destroy", lambda x: self.branch.unlock())
 
134
        self.model = treemodel.BranchTreeModel(self.branch, [])
 
135
        GObject.idle_add(self.populate)
 
136
 
 
137
        self.connect("destroy", self._on_destroy)
 
138
 
 
139
    def _on_destroy(self, *ignored):
 
140
        self.branch.unlock()
 
141
        if getattr(ui.ui_factory, "set_progress_bar_widget", None) is not None:
 
142
            # We'are using our own ui, let's tell it to stop using our widget.
 
143
            ui.ui_factory.set_progress_bar_widget(None)
135
144
 
136
145
    def do_get_property(self, property):
137
146
        if property.name == 'revno-column-visible':
147
156
        elif property.name == 'branch':
148
157
            return self.branch
149
158
        elif property.name == 'revision':
150
 
            return self.model.get_value(self.iter, treemodel.REVISION)
 
159
            if self.path is None:
 
160
                return None
 
161
            return self.model.get_value(self.model.get_iter(self.path),
 
162
                                        treemodel.REVISION)
151
163
        elif property.name == 'revision-number':
152
 
            return self.model.get_value(self.iter, treemodel.REVNO)
 
164
            if self.path is None:
 
165
                return None
 
166
            return self.model.get_value(self.model.get_iter(self.path),
 
167
                                        treemodel.REVNO)
153
168
        elif property.name == 'children':
154
 
            return self.model.get_value(self.iter, treemodel.CHILDREN)
 
169
            if self.path is None:
 
170
                return None
 
171
            return self.model.get_value(self.model.get_iter(self.path),
 
172
                                        treemodel.CHILDREN)
155
173
        elif property.name == 'parents':
156
 
            return self.model.get_value(self.iter, treemodel.PARENTS)
 
174
            if self.path is None:
 
175
                return None
 
176
            return self.model.get_value(self.model.get_iter(self.path),
 
177
                                        treemodel.PARENTS)
157
178
        else:
158
179
            raise AttributeError, 'unknown property %s' % property.name
159
180
 
179
200
        """Return revision id of currently selected revision, or None."""
180
201
        return self.get_property('revision')
181
202
 
 
203
    def has_revision_id(self, revision_id):
 
204
        return (revision_id in self.index)
 
205
 
182
206
    def set_revision(self, revision):
183
207
        self.set_property('revision', revision)
184
208
 
187
211
 
188
212
        :param revid: Revision id of revision to display.
189
213
        """
190
 
        self.treeview.set_cursor(self.index[revid])
 
214
        self.treeview.set_cursor(
 
215
            Gtk.TreePath(path=self.index[revid]), None, False)
191
216
        self.treeview.grab_focus()
192
217
 
193
218
    def get_children(self):
207
232
    def add_tag(self, tag, revid=None):
208
233
        if revid is None: revid = self.revision.revision_id
209
234
 
210
 
        try:
211
 
            self.branch.unlock()
212
 
 
 
235
        if lock.release(self.branch):
213
236
            try:
214
 
                self.branch.lock_write()
 
237
                lock.acquire(self.branch, lock.WRITE)
215
238
                self.model.add_tag(tag, revid)
216
239
            finally:
217
 
                self.branch.unlock()
218
 
 
219
 
        finally:
220
 
            self.branch.lock_read()
221
 
 
222
 
        self.emit('tag-added', tag, revid)
223
 
        
 
240
                lock.release(self.branch)
 
241
 
 
242
            lock.acquire(self.branch, lock.READ)
 
243
 
 
244
            self.emit('tag-added', tag, revid)
 
245
 
224
246
    def refresh(self):
225
 
        gobject.idle_add(self.populate, self.get_revision())
 
247
        GObject.idle_add(self.populate, self.get_revision())
226
248
 
227
249
    def update(self):
228
250
        try:
238
260
    def back(self):
239
261
        """Signal handler for the Back button."""
240
262
        parents = self.get_parents()
241
 
        if not len(parents):
 
263
        if not parents:
242
264
            return
243
265
 
244
266
        for parent_id in parents:
253
275
    def forward(self):
254
276
        """Signal handler for the Forward button."""
255
277
        children = self.get_children()
256
 
        if not len(children):
 
278
        if not children:
257
279
            return
258
280
 
259
281
        for child_id in children:
275
297
                       should be broken.
276
298
        """
277
299
 
 
300
        if getattr(ui.ui_factory, "set_progress_bar_widget", None) is not None:
 
301
            # We'are using our own ui, let's tell it to use our widget.
 
302
            ui.ui_factory.set_progress_bar_widget(self.progress_widget)
278
303
        self.progress_bar = ui.ui_factory.nested_progress_bar()
279
 
        self.progress_bar.update(msg="Loading ancestry graph", total_cnt=5)
 
304
        self.progress_bar.update("Loading ancestry graph", 0, 5)
280
305
 
281
306
        try:
282
307
            if self.compact:
283
308
                broken_line_length = 32
284
309
            else:
285
310
                broken_line_length = None
286
 
            
 
311
 
287
312
            show_graph = self.graph_column.get_visible()
288
313
 
289
314
            self.branch.lock_read()
290
 
            (linegraphdata, index, columns_len) = linegraph(self.branch.repository.get_graph(),
291
 
                                                            self.start,
292
 
                                                            self.maxnum, 
293
 
                                                            broken_line_length,
294
 
                                                            show_graph,
295
 
                                                            self.mainline_only,
296
 
                                                            self.progress_bar)
 
315
            (linegraphdata, index, columns_len) = linegraph(
 
316
                self.branch.repository.get_graph(),
 
317
                self.start,
 
318
                self.maxnum, 
 
319
                broken_line_length,
 
320
                show_graph,
 
321
                self.mainline_only,
 
322
                self.progress_bar)
297
323
 
298
 
            self.model = TreeModel(self.branch, linegraphdata)
 
324
            self.model.set_line_graph_data(linegraphdata)
299
325
            self.graph_cell.columns_len = columns_len
300
 
            width = self.graph_cell.get_size(self.treeview)[2]
 
326
            width = self.graph_cell.get_preferred_width(self.treeview)[1]
301
327
            if width > 500:
302
328
                width = 500
 
329
            elif width == 0:
 
330
                # The get_preferred_width() call got an insane value.
 
331
                width = 200
303
332
            self.graph_column.set_fixed_width(width)
304
333
            self.graph_column.set_max_width(width)
305
334
            self.index = index
306
335
            self.treeview.set_model(self.model)
307
336
 
308
337
            if not revision or revision == NULL_REVISION:
309
 
                self.treeview.set_cursor(0)
 
338
                self.treeview.set_cursor(Gtk.TreePath(path=0), None, False)
310
339
            else:
311
340
                self.set_revision(revision)
312
341
 
 
342
            self.emit('refreshed')
313
343
            return False
314
344
        finally:
315
345
            self.progress_bar.finished()
316
346
 
317
347
    def construct_treeview(self):
318
 
        self.treeview = gtk.TreeView()
 
348
        self.treeview = Gtk.TreeView()
319
349
 
320
350
        self.treeview.set_rules_hint(True)
321
 
        self.treeview.set_search_column(treemodel.REVNO)
322
 
        
323
 
        # Fix old PyGTK bug - by JAM
324
 
        set_tooltip = getattr(self.treeview, 'set_tooltip_column', None)
325
 
        if set_tooltip is not None:
326
 
            set_tooltip(treemodel.MESSAGE)
327
 
 
 
351
        # combined revno/summary interactive search
 
352
        #
 
353
        # the row in a treemodel is considered "matched" if a REVNO *starts*
 
354
        # from the key (that is the key is found in a REVNO at the offset 0)
 
355
        # or if a MESSAGE *contains* the key anywhere (that is, the key is
 
356
        # found case insensitively in a MESSAGE at any offset)
 
357
        def search_equal_func(model, column, key, iter, ignored):
 
358
            return (model.get_value(iter, treemodel.REVNO).find(key) != 0
 
359
                and model.get_value(iter, treemodel.MESSAGE).lower().find(key.lower()) == -1)
 
360
 
 
361
        self.treeview.set_search_equal_func(search_equal_func, None)
 
362
        self.treeview.set_enable_search(True)
 
363
 
 
364
        self.treeview.set_tooltip_column(treemodel.MESSAGE)
 
365
        self.treeview.set_headers_visible(True)
 
366
 
 
367
        self._prev_cursor_path = None
328
368
        self.treeview.connect("cursor-changed",
329
369
                self._on_selection_changed)
330
370
 
338
378
 
339
379
        self.treeview.show()
340
380
 
341
 
        cell = gtk.CellRendererText()
 
381
        cell = Gtk.CellRendererText()
342
382
        cell.set_property("width-chars", 15)
343
 
        cell.set_property("ellipsize", pango.ELLIPSIZE_END)
344
 
        self.revno_column = gtk.TreeViewColumn("Revision No")
345
 
        self.revno_column.set_resizable(False)
346
 
        self.revno_column.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
347
 
        self.revno_column.set_fixed_width(cell.get_size(self.treeview)[2])
348
 
        self.revno_column.pack_start(cell, expand=True)
 
383
        cell.set_property("ellipsize", Pango.EllipsizeMode.END)
 
384
        self.revno_column = Gtk.TreeViewColumn("Revision No")
 
385
        self.revno_column.set_resizable(True)
 
386
        self.revno_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
 
387
        self.revno_column.set_fixed_width(
 
388
            cell.get_preferred_width(self.treeview)[1])
 
389
        self.revno_column.pack_start(cell, True)
349
390
        self.revno_column.add_attribute(cell, "text", treemodel.REVNO)
350
391
        self.treeview.append_column(self.revno_column)
351
392
 
352
393
        self.graph_cell = CellRendererGraph()
353
 
        self.graph_column = gtk.TreeViewColumn()
354
 
        self.graph_column.set_resizable(False)
355
 
        self.graph_column.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
356
 
        self.graph_column.pack_start(self.graph_cell, expand=True)
357
 
        self.graph_column.add_attribute(self.graph_cell, "node", treemodel.NODE)
358
 
        self.graph_column.add_attribute(self.graph_cell, "tags", treemodel.TAGS)
359
 
        self.graph_column.add_attribute(self.graph_cell, "in-lines", treemodel.LAST_LINES)
360
 
        self.graph_column.add_attribute(self.graph_cell, "out-lines", treemodel.LINES)
 
394
        self.graph_column = Gtk.TreeViewColumn()
 
395
        self.graph_column.set_resizable(True)
 
396
        self.graph_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
 
397
        self.graph_column.pack_start(self.graph_cell, True)
 
398
        self.graph_column.add_attribute(
 
399
            self.graph_cell, "node", treemodel.NODE)
 
400
        self.graph_column.add_attribute(
 
401
            self.graph_cell, "tags", treemodel.TAGS)
 
402
        self.graph_column.add_attribute(
 
403
            self.graph_cell, "in-lines", treemodel.LAST_LINES)
 
404
        self.graph_column.add_attribute(
 
405
            self.graph_cell, "out-lines", treemodel.LINES)
361
406
        self.treeview.append_column(self.graph_column)
362
407
 
363
 
        cell = gtk.CellRendererText()
 
408
        cell = Gtk.CellRendererText()
364
409
        cell.set_property("width-chars", 65)
365
 
        cell.set_property("ellipsize", pango.ELLIPSIZE_END)
366
 
        self.summary_column = gtk.TreeViewColumn("Summary")
367
 
        self.summary_column.set_resizable(False)
 
410
        cell.set_property("ellipsize", Pango.EllipsizeMode.END)
 
411
        self.summary_column = Gtk.TreeViewColumn("Summary")
 
412
        self.summary_column.set_resizable(True)
368
413
        self.summary_column.set_expand(True)
369
 
        self.summary_column.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
370
 
        self.summary_column.set_fixed_width(cell.get_size(self.treeview)[2])
371
 
        self.summary_column.pack_start(cell, expand=True)
 
414
        self.summary_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
 
415
        self.summary_column.set_fixed_width(
 
416
            cell.get_preferred_width(self.treeview)[1])
 
417
        self.summary_column.pack_start(cell, True)
372
418
        self.summary_column.add_attribute(cell, "markup", treemodel.SUMMARY)
373
419
        self.treeview.append_column(self.summary_column)
374
420
 
375
 
        cell = gtk.CellRendererText()
 
421
        cell = Gtk.CellRendererText()
376
422
        cell.set_property("width-chars", 15)
377
 
        cell.set_property("ellipsize", pango.ELLIPSIZE_END)
378
 
        self.committer_column = gtk.TreeViewColumn("Committer")
379
 
        self.committer_column.set_resizable(False)
380
 
        self.committer_column.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
381
 
        self.committer_column.set_fixed_width(200)
382
 
        self.committer_column.pack_start(cell, expand=True)
383
 
        self.committer_column.add_attribute(cell, "text", treemodel.COMMITTER)
384
 
        self.treeview.append_column(self.committer_column)
 
423
        cell.set_property("ellipsize", Pango.EllipsizeMode.END)
 
424
        self.authors_column = Gtk.TreeViewColumn("Author(s)")
 
425
        self.authors_column.set_resizable(False)
 
426
        self.authors_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
 
427
        self.authors_column.set_fixed_width(200)
 
428
        self.authors_column.pack_start(cell, True)
 
429
        self.authors_column.add_attribute(cell, "text", treemodel.AUTHORS)
 
430
        self.treeview.append_column(self.authors_column)
385
431
 
386
 
        cell = gtk.CellRendererText()
 
432
        cell = Gtk.CellRendererText()
387
433
        cell.set_property("width-chars", 20)
388
 
        cell.set_property("ellipsize", pango.ELLIPSIZE_END)
389
 
        self.date_column = gtk.TreeViewColumn("Date")
 
434
        cell.set_property("ellipsize", Pango.EllipsizeMode.END)
 
435
        self.date_column = Gtk.TreeViewColumn("Date")
390
436
        self.date_column.set_visible(False)
391
 
        self.date_column.set_resizable(False)
392
 
        self.date_column.set_sizing(gtk.TREE_VIEW_COLUMN_FIXED)
 
437
        self.date_column.set_resizable(True)
 
438
        self.date_column.set_sizing(Gtk.TreeViewColumnSizing.FIXED)
393
439
        self.date_column.set_fixed_width(130)
394
 
        self.date_column.pack_start(cell, expand=True)
 
440
        self.date_column.pack_start(cell, True)
395
441
        self.date_column.add_attribute(cell, "text", treemodel.TIMESTAMP)
396
442
        self.treeview.append_column(self.date_column)
397
 
        
 
443
 
398
444
        return self.treeview
399
 
    
 
445
 
400
446
    def _on_selection_changed(self, treeview):
401
447
        """callback for when the treeview changes."""
402
448
        (path, focus) = treeview.get_cursor()
403
 
        if path is not None:
404
 
            self.iter = self.model.get_iter(path)
 
449
        if (path is not None) and (path != self._prev_cursor_path):
 
450
            self._prev_cursor_path = path # avoid emitting twice per click
 
451
            self.path = path
405
452
            self.emit('revision-selected')
406
453
 
407
454
    def _on_revision_selected(self, widget, event):
408
 
        from bzrlib.plugins.gtk.revisionmenu import RevisionPopupMenu
 
455
        from bzrlib.plugins.gtk.revisionmenu import RevisionMenu
409
456
        if event.button == 3:
410
 
            menu = RevisionPopupMenu(self.branch.repository, 
411
 
                [self.get_revision().revision_id],
412
 
                self.branch)
 
457
            revs = []
 
458
            rev = self.get_revision()
 
459
            if rev is not None:
 
460
                revs.append(rev.revision_id)
 
461
            menu = RevisionMenu(self.branch.repository, revs, self.branch)
413
462
            menu.connect('tag-added', lambda w, t, r: self.add_tag(t, r))
414
 
            menu.popup(None, None, None, event.button, event.get_time())
 
463
            menu.popup(None, None, None, None, event.button, event.get_time())
415
464
 
416
465
    def _on_revision_activated(self, widget, path, col):
417
466
        self.emit('revision-activated', path, col)