/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
59
1189 by Martin Pool
- BROKEN: partial support for commit into weave
60
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
61
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
62
import sys
1188 by Martin Pool
- clean up imports in commit code
63
import time
1248 by Martin Pool
- new weave based cleanup [broken]
64
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1188 by Martin Pool
- clean up imports in commit code
66
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
67
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
68
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
69
from bzrlib.osutils import (local_time_offset,
70
                            rand_bytes, compact_date,
1188 by Martin Pool
- clean up imports in commit code
71
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
72
                            sha_string, sha_strings, sha_file, isdir, isfile,
73
                            split_lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
74
from bzrlib.branch import gen_file_id
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
75
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
76
from bzrlib.errors import (BzrError, PointlessCommit,
77
                           HistoryMissing,
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
78
                           ConflictsInTree
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
                           )
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
80
from bzrlib.revision import Revision
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
81
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
82
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
83
from bzrlib.inventory import Inventory, ROOT_ID
1189 by Martin Pool
- BROKEN: partial support for commit into weave
84
from bzrlib.weave import Weave
85
from bzrlib.weavefile import read_weave, write_weave_v5
86
from bzrlib.atomicfile import AtomicFile
87
88
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
89
def commit(*args, **kwargs):
90
    """Commit a new revision to a branch.
91
92
    Function-style interface for convenience of old callers.
93
94
    New code should use the Commit class instead.
95
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
96
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
97
    Commit().commit(*args, **kwargs)
98
99
1189 by Martin Pool
- BROKEN: partial support for commit into weave
100
class NullCommitReporter(object):
101
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
102
103
    def snapshot_change(self, change, path):
104
        pass
105
106
    def completed(self, revno, rev_id):
107
        pass
108
109
    def deleted(self, file_id):
110
        pass
111
112
    def escaped(self, escape_count, message):
113
        pass
114
115
    def missing(self, path):
116
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
117
118
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
119
120
    def snapshot_change(self, change, path):
121
        note("%s %s", change, path)
122
123
    def completed(self, revno, rev_id):
124
        note('committed r%d {%s}', revno, rev_id)
125
    
126
    def deleted(self, file_id):
127
        note('deleted %s', file_id)
128
129
    def escaped(self, escape_count, message):
130
        note("replaced %d control characters in message", escape_count)
131
132
    def missing(self, path):
133
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
134
135
class Commit(object):
136
    """Task of committing a new revision.
137
138
    This is a MethodObject: it accumulates state as the commit is
139
    prepared, and then it is discarded.  It doesn't represent
140
    historical revisions, just the act of recording a new one.
141
142
            missing_ids
143
            Modified to hold a list of files that have been deleted from
144
            the working directory; these should be removed from the
145
            working inventory.
485 by Martin Pool
- move commit code into its own module
146
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
    def __init__(self,
148
                 reporter=None):
149
        if reporter is not None:
150
            self.reporter = reporter
151
        else:
152
            self.reporter = NullCommitReporter()
153
154
        
155
    def commit(self,
156
               branch, message,
157
               timestamp=None,
158
               timezone=None,
159
               committer=None,
160
               specific_files=None,
161
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
162
               allow_pointless=True,
1185.16.35 by Martin Pool
- stub for revision properties
163
               verbose=False,
164
               revprops=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
165
        """Commit working copy as a new revision.
166
167
        timestamp -- if not None, seconds-since-epoch for a
168
             postdated/predated commit.
169
1253 by Martin Pool
- test that pointless commits are trapped
170
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
171
1253 by Martin Pool
- test that pointless commits are trapped
172
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
173
            Useful for test or import commands that need to tightly
174
            control what revisions are assigned.  If you duplicate
175
            a revision id that exists elsewhere it is your own fault.
176
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
177
178
        allow_pointless -- If true (default), commit even if nothing
179
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
180
181
        revprops -- Properties for new revision
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
183
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
184
185
        self.branch = branch
1248 by Martin Pool
- new weave based cleanup [broken]
186
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
187
        self.rev_id = rev_id
188
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
189
        self.allow_pointless = allow_pointless
1185.16.35 by Martin Pool
- stub for revision properties
190
        self.revprops = revprops
1189 by Martin Pool
- BROKEN: partial support for commit into weave
191
192
        if timestamp is None:
193
            self.timestamp = time.time()
194
        else:
195
            self.timestamp = long(timestamp)
196
            
1248 by Martin Pool
- new weave based cleanup [broken]
197
        if rev_id is None:
198
            self.rev_id = _gen_revision_id(self.branch, self.timestamp)
199
        else:
200
            self.rev_id = rev_id
201
1189 by Martin Pool
- BROKEN: partial support for commit into weave
202
        if committer is None:
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
203
            self.committer = bzrlib.config.username(self.branch)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
204
        else:
205
            assert isinstance(committer, basestring), type(committer)
206
            self.committer = committer
207
208
        if timezone is None:
209
            self.timezone = local_time_offset()
210
        else:
211
            self.timezone = int(timezone)
212
213
        assert isinstance(message, basestring), type(message)
214
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
215
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
1245 by Martin Pool
doc
217
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
218
        try:
219
            self.work_tree = self.branch.working_tree()
220
            self.work_inv = self.work_tree.inventory
221
            self.basis_tree = self.branch.basis_tree()
222
            self.basis_inv = self.basis_tree.inventory
223
1223 by Martin Pool
- store inventories in weave
224
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
225
            if len(self.parents) > 1 and self.specific_files:
226
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
227
            self._check_parents_present()
228
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
229
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
230
            self._populate_new_inv()
231
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
232
            self._report_deletes()
1245 by Martin Pool
doc
233
1248 by Martin Pool
- new weave based cleanup [broken]
234
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
235
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
236
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
237
                raise PointlessCommit()
238
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
239
            if len(list(self.work_tree.iter_conflicts()))>0:
240
                raise ConflictsInTree
241
1189 by Martin Pool
- BROKEN: partial support for commit into weave
242
            self._record_inventory()
243
            self._make_revision()
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
244
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
245
            self.branch.append_revision(self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
246
            self.branch.set_pending_merges([])
247
        finally:
248
            self.branch.unlock()
249
250
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
251
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
252
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
253
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
254
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
255
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
256
                   split_lines(inv_text), self.present_parents,
257
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
258
1390 by Robert Collins
pair programming worx... merge integration and weave
259
    def _escape_commit_message(self):
260
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
261
        # Python strings can include characters that can't be
262
        # represented in well-formed XML; escape characters that
263
        # aren't listed in the XML specification
264
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
265
        if isinstance(self.message, unicode):
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
266
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
267
        else:
268
            # Use a regular 'str' as pattern to avoid having re.subn
269
            # return 'unicode' results.
270
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
1390 by Robert Collins
pair programming worx... merge integration and weave
271
        self.message, escape_count = re.subn(
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
272
            char_pattern,
273
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
274
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
275
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
276
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
277
278
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
279
        """Record the parents of a merge for merge detection."""
1223 by Martin Pool
- store inventories in weave
280
        pending_merges = self.branch.pending_merges()
281
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
282
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
283
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
284
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
285
        if precursor_id:
286
            self.parents.append(precursor_id)
287
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
288
        for revision in self.parents:
289
            if self.branch.has_revision(revision):
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
290
                self.parent_invs.append(self.branch.get_inventory(revision))
1092.2.25 by Robert Collins
support ghosts in commits
291
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
292
293
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
294
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
295
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
296
            if not self.branch.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
297
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
298
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
299
                    raise HistoryMissing(self.branch, 'revision', parent_id)
300
                else:
301
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
302
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
303
    def _make_revision(self):
304
        """Record a new revision object for this commit."""
305
        self.rev = Revision(timestamp=self.timestamp,
306
                            timezone=self.timezone,
307
                            committer=self.committer,
308
                            message=self.message,
309
                            inventory_sha1=self.inv_sha1,
1185.16.35 by Martin Pool
- stub for revision properties
310
                            revision_id=self.rev_id,
311
                            properties=self.revprops)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
312
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
313
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
314
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
315
        rev_tmp.seek(0)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
316
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
317
        mutter('new revision_id is {%s}', self.rev_id)
318
319
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
320
        """Remove deleted files from the working inventories.
321
322
        This is done prior to taking the working inventory as the
323
        basis for the new committed inventory.
324
325
        This returns true if any files
326
        *that existed in the basis inventory* were deleted.
327
        Files that were added and deleted
328
        in the working copy don't matter.
329
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
330
        specific = self.specific_files
331
        deleted_ids = []
332
        for path, ie in self.work_inv.iter_entries():
333
            if specific and not is_inside_any(specific, path):
334
                continue
335
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
336
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
337
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
338
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
339
            deleted_ids.sort(reverse=True)
340
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
341
                del self.work_inv[file_id]
1249 by Martin Pool
- improvements to weave commit [broken]
342
            self.branch._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
343
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
344
    def _store_snapshot(self):
345
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
346
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
347
        Entries get a new revision when they are modified in 
348
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
349
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
350
        """
1303 by Martin Pool
- commit updates entry_version
351
        # XXX: Need to think more here about when the user has
352
        # made a specific decision on a particular value -- c.f.
353
        # mark-merge.  
354
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
355
            previous_entries = ie.find_previous_heads(
356
                self.parent_invs, 
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
357
                self.weave_store.get_weave_or_empty(ie.file_id,
358
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
359
            if ie.revision is None:
360
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
361
                                     self.work_tree, self.weave_store,
362
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
363
            else:
364
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
365
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
366
367
    def _populate_new_inv(self):
368
        """Build revision inventory.
369
370
        This creates a new empty inventory. Depending on
371
        which files are selected for commit, and what is present in the
372
        current tree, the new inventory is populated. inventory entries 
373
        which are candidates for modification have their revision set to
374
        None; inventory entries that are carried over untouched have their
375
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
376
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
377
        mutter("Selecting files for commit with filter %s", self.specific_files)
378
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
379
        for path, new_ie in self.work_inv.iter_entries():
380
            file_id = new_ie.file_id
381
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
382
            if self.specific_files:
383
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
384
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
385
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
386
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
387
                else:
388
                    # this is selected, ensure its parents are too.
389
                    parent_id = new_ie.parent_id
390
                    while parent_id != ROOT_ID:
391
                        if not self.new_inv.has_id(parent_id):
392
                            ie = self._select_entry(self.work_inv[parent_id])
393
                            mutter('%s selected for commit because of %s',
394
                                   self.new_inv.id2path(parent_id), path)
395
396
                        ie = self.new_inv[parent_id]
397
                        if ie.revision is not None:
398
                            ie.revision = None
399
                            mutter('%s selected for commit because of %s',
400
                                   self.new_inv.id2path(parent_id), path)
401
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
402
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
403
            self._select_entry(new_ie)
404
405
    def _select_entry(self, new_ie):
406
        """Make new_ie be considered for committing."""
407
        ie = new_ie.copy()
408
        ie.revision = None
409
        self.new_inv.add(ie)
410
        return ie
411
412
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
413
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
414
        if self.basis_inv.has_id(file_id):
415
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
416
417
    def _report_deletes(self):
418
        for file_id in self.basis_inv:
419
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
420
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
421
1189 by Martin Pool
- BROKEN: partial support for commit into weave
422
def _gen_revision_id(branch, when):
423
    """Return new revision-id."""
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
424
    s = '%s-%s-' % (bzrlib.config.user_email(branch), compact_date(when))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
425
    s += hexlify(rand_bytes(8))
426
    return s