/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
59
1189 by Martin Pool
- BROKEN: partial support for commit into weave
60
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
61
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
62
import sys
1188 by Martin Pool
- clean up imports in commit code
63
import time
1248 by Martin Pool
- new weave based cleanup [broken]
64
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1188 by Martin Pool
- clean up imports in commit code
66
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
67
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
68
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
69
from bzrlib.osutils import (local_time_offset,
70
                            rand_bytes, compact_date,
1188 by Martin Pool
- clean up imports in commit code
71
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
72
                            sha_string, sha_strings, sha_file, isdir, isfile,
73
                            split_lines)
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
74
from bzrlib.branch import gen_file_id
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
75
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
76
from bzrlib.errors import (BzrError, PointlessCommit,
77
                           HistoryMissing,
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
78
                           ConflictsInTree
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
79
                           )
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
80
from bzrlib.revision import Revision
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
81
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
82
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
83
from bzrlib.inventory import Inventory, ROOT_ID
1189 by Martin Pool
- BROKEN: partial support for commit into weave
84
from bzrlib.weave import Weave
85
from bzrlib.weavefile import read_weave, write_weave_v5
86
from bzrlib.atomicfile import AtomicFile
87
88
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
89
def commit(*args, **kwargs):
90
    """Commit a new revision to a branch.
91
92
    Function-style interface for convenience of old callers.
93
94
    New code should use the Commit class instead.
95
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
96
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
97
    Commit().commit(*args, **kwargs)
98
99
1189 by Martin Pool
- BROKEN: partial support for commit into weave
100
class NullCommitReporter(object):
101
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
102
103
    def snapshot_change(self, change, path):
104
        pass
105
106
    def completed(self, revno, rev_id):
107
        pass
108
109
    def deleted(self, file_id):
110
        pass
111
112
    def escaped(self, escape_count, message):
113
        pass
114
115
    def missing(self, path):
116
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
117
118
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
119
120
    def snapshot_change(self, change, path):
121
        note("%s %s", change, path)
122
123
    def completed(self, revno, rev_id):
124
        note('committed r%d {%s}', revno, rev_id)
125
    
126
    def deleted(self, file_id):
127
        note('deleted %s', file_id)
128
129
    def escaped(self, escape_count, message):
130
        note("replaced %d control characters in message", escape_count)
131
132
    def missing(self, path):
133
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
134
135
class Commit(object):
136
    """Task of committing a new revision.
137
138
    This is a MethodObject: it accumulates state as the commit is
139
    prepared, and then it is discarded.  It doesn't represent
140
    historical revisions, just the act of recording a new one.
141
142
            missing_ids
143
            Modified to hold a list of files that have been deleted from
144
            the working directory; these should be removed from the
145
            working inventory.
485 by Martin Pool
- move commit code into its own module
146
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
    def __init__(self,
148
                 reporter=None):
149
        if reporter is not None:
150
            self.reporter = reporter
151
        else:
152
            self.reporter = NullCommitReporter()
153
154
        
155
    def commit(self,
156
               branch, message,
157
               timestamp=None,
158
               timezone=None,
159
               committer=None,
160
               specific_files=None,
161
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
162
               allow_pointless=True,
163
               verbose=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
164
        """Commit working copy as a new revision.
165
166
        timestamp -- if not None, seconds-since-epoch for a
167
             postdated/predated commit.
168
1253 by Martin Pool
- test that pointless commits are trapped
169
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
1253 by Martin Pool
- test that pointless commits are trapped
171
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
172
            Useful for test or import commands that need to tightly
173
            control what revisions are assigned.  If you duplicate
174
            a revision id that exists elsewhere it is your own fault.
175
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
176
177
        allow_pointless -- If true (default), commit even if nothing
178
            has changed and no merges are recorded.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
179
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
180
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
181
182
        self.branch = branch
1248 by Martin Pool
- new weave based cleanup [broken]
183
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
184
        self.rev_id = rev_id
185
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
186
        self.allow_pointless = allow_pointless
1189 by Martin Pool
- BROKEN: partial support for commit into weave
187
188
        if timestamp is None:
189
            self.timestamp = time.time()
190
        else:
191
            self.timestamp = long(timestamp)
192
            
1248 by Martin Pool
- new weave based cleanup [broken]
193
        if rev_id is None:
194
            self.rev_id = _gen_revision_id(self.branch, self.timestamp)
195
        else:
196
            self.rev_id = rev_id
197
1189 by Martin Pool
- BROKEN: partial support for commit into weave
198
        if committer is None:
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
199
            self.committer = bzrlib.config.username(self.branch)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
200
        else:
201
            assert isinstance(committer, basestring), type(committer)
202
            self.committer = committer
203
204
        if timezone is None:
205
            self.timezone = local_time_offset()
206
        else:
207
            self.timezone = int(timezone)
208
209
        assert isinstance(message, basestring), type(message)
210
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
211
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
212
1245 by Martin Pool
doc
213
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
214
        try:
215
            self.work_tree = self.branch.working_tree()
216
            self.work_inv = self.work_tree.inventory
217
            self.basis_tree = self.branch.basis_tree()
218
            self.basis_inv = self.basis_tree.inventory
219
1223 by Martin Pool
- store inventories in weave
220
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
221
            if len(self.parents) > 1 and self.specific_files:
222
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
223
            self._check_parents_present()
224
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
225
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
226
            self._populate_new_inv()
227
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
228
            self._report_deletes()
1245 by Martin Pool
doc
229
1248 by Martin Pool
- new weave based cleanup [broken]
230
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
231
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
232
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
                raise PointlessCommit()
234
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
235
            if len(list(self.work_tree.iter_conflicts()))>0:
236
                raise ConflictsInTree
237
1189 by Martin Pool
- BROKEN: partial support for commit into weave
238
            self._record_inventory()
239
            self._make_revision()
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
240
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
241
            self.branch.append_revision(self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
242
            self.branch.set_pending_merges([])
243
        finally:
244
            self.branch.unlock()
245
246
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
247
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
248
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
249
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
250
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
251
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
252
                   split_lines(inv_text), self.present_parents,
253
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
254
1390 by Robert Collins
pair programming worx... merge integration and weave
255
    def _escape_commit_message(self):
256
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
257
        # Python strings can include characters that can't be
258
        # represented in well-formed XML; escape characters that
259
        # aren't listed in the XML specification
260
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
261
        if isinstance(self.message, unicode):
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
262
            char_pattern = u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]'
263
        else:
264
            # Use a regular 'str' as pattern to avoid having re.subn
265
            # return 'unicode' results.
266
            char_pattern = '[^x09\x0A\x0D\x20-\xFF]'
1390 by Robert Collins
pair programming worx... merge integration and weave
267
        self.message, escape_count = re.subn(
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
268
            char_pattern,
269
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
270
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
271
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
272
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
273
274
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
275
        """Record the parents of a merge for merge detection."""
1223 by Martin Pool
- store inventories in weave
276
        pending_merges = self.branch.pending_merges()
277
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
278
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
279
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
280
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
281
        if precursor_id:
282
            self.parents.append(precursor_id)
283
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
284
        for revision in self.parents:
285
            if self.branch.has_revision(revision):
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
286
                self.parent_invs.append(self.branch.get_inventory(revision))
1092.2.25 by Robert Collins
support ghosts in commits
287
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
288
289
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
290
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
291
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
292
            if not self.branch.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
293
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
294
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
295
                    raise HistoryMissing(self.branch, 'revision', parent_id)
296
                else:
297
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
298
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
299
    def _make_revision(self):
300
        """Record a new revision object for this commit."""
301
        self.rev = Revision(timestamp=self.timestamp,
302
                            timezone=self.timezone,
303
                            committer=self.committer,
304
                            message=self.message,
305
                            inventory_sha1=self.inv_sha1,
306
                            revision_id=self.rev_id)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
307
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
308
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
309
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
310
        rev_tmp.seek(0)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
311
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
312
        mutter('new revision_id is {%s}', self.rev_id)
313
314
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
315
        """Remove deleted files from the working inventories.
316
317
        This is done prior to taking the working inventory as the
318
        basis for the new committed inventory.
319
320
        This returns true if any files
321
        *that existed in the basis inventory* were deleted.
322
        Files that were added and deleted
323
        in the working copy don't matter.
324
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
325
        specific = self.specific_files
326
        deleted_ids = []
327
        for path, ie in self.work_inv.iter_entries():
328
            if specific and not is_inside_any(specific, path):
329
                continue
330
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
331
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
332
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
333
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
334
            deleted_ids.sort(reverse=True)
335
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
336
                del self.work_inv[file_id]
1249 by Martin Pool
- improvements to weave commit [broken]
337
            self.branch._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
338
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
339
    def _store_snapshot(self):
340
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
341
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
342
        Entries get a new revision when they are modified in 
343
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
344
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
345
        """
1303 by Martin Pool
- commit updates entry_version
346
        # XXX: Need to think more here about when the user has
347
        # made a specific decision on a particular value -- c.f.
348
        # mark-merge.  
349
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
350
            previous_entries = ie.find_previous_heads(
351
                self.parent_invs, 
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
352
                self.weave_store.get_weave_or_empty(ie.file_id,
353
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
354
            if ie.revision is None:
355
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
356
                                     self.work_tree, self.weave_store,
357
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
358
            else:
359
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
360
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
361
362
    def _populate_new_inv(self):
363
        """Build revision inventory.
364
365
        This creates a new empty inventory. Depending on
366
        which files are selected for commit, and what is present in the
367
        current tree, the new inventory is populated. inventory entries 
368
        which are candidates for modification have their revision set to
369
        None; inventory entries that are carried over untouched have their
370
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
371
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
372
        mutter("Selecting files for commit with filter %s", self.specific_files)
373
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
374
        for path, new_ie in self.work_inv.iter_entries():
375
            file_id = new_ie.file_id
376
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
377
            if self.specific_files:
378
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
379
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
380
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
381
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
382
                else:
383
                    # this is selected, ensure its parents are too.
384
                    parent_id = new_ie.parent_id
385
                    while parent_id != ROOT_ID:
386
                        if not self.new_inv.has_id(parent_id):
387
                            ie = self._select_entry(self.work_inv[parent_id])
388
                            mutter('%s selected for commit because of %s',
389
                                   self.new_inv.id2path(parent_id), path)
390
391
                        ie = self.new_inv[parent_id]
392
                        if ie.revision is not None:
393
                            ie.revision = None
394
                            mutter('%s selected for commit because of %s',
395
                                   self.new_inv.id2path(parent_id), path)
396
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
397
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
398
            self._select_entry(new_ie)
399
400
    def _select_entry(self, new_ie):
401
        """Make new_ie be considered for committing."""
402
        ie = new_ie.copy()
403
        ie.revision = None
404
        self.new_inv.add(ie)
405
        return ie
406
407
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
408
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
409
        if self.basis_inv.has_id(file_id):
410
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
411
412
    def _report_deletes(self):
413
        for file_id in self.basis_inv:
414
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
415
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
416
1189 by Martin Pool
- BROKEN: partial support for commit into weave
417
def _gen_revision_id(branch, when):
418
    """Return new revision-id."""
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
419
    s = '%s-%s-' % (bzrlib.config.user_email(branch), compact_date(when))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
420
    s += hexlify(rand_bytes(8))
421
    return s