/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
485 by Martin Pool
- move commit code into its own module
1
# Copyright (C) 2005 Canonical Ltd
1248 by Martin Pool
- new weave based cleanup [broken]
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
1248 by Martin Pool
- new weave based cleanup [broken]
18
# XXX: Can we do any better about making interrupted commits change
19
# nothing?  Perhaps the best approach is to integrate commit of
20
# AtomicFiles with releasing the lock on the Branch.
21
22
# TODO: Separate 'prepare' phase where we find a list of potentially
23
# committed files.  We then can then pause the commit to prompt for a
24
# commit message, knowing the summary will be the same as what's
25
# actually used for the commit.  (But perhaps simpler to simply get
26
# the tree status, then use that for a selective commit?)
27
28
# The newly committed revision is going to have a shape corresponding
29
# to that of the working inventory.  Files that are not in the
30
# working tree and that were in the predecessor are reported as
31
# removed --- this can include files that were either removed from the
32
# inventory or deleted in the working tree.  If they were only
33
# deleted from disk, they are removed from the working inventory.
34
35
# We then consider the remaining entries, which will be in the new
36
# version.  Directory entries are simply copied across.  File entries
37
# must be checked to see if a new version of the file should be
38
# recorded.  For each parent revision inventory, we check to see what
39
# version of the file was present.  If the file was present in at
40
# least one tree, and if it was the same version in all the trees,
41
# then we can just refer to that version.  Otherwise, a new version
42
# representing the merger of the file versions must be added.
43
44
# TODO: Update hashcache before and after - or does the WorkingTree
45
# look after that?
1245 by Martin Pool
doc
46
1339 by Martin Pool
- doc
47
# TODO: Rather than mashing together the ancestry and storing it back,
48
# perhaps the weave should have single method which does it all in one
49
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
50
1341 by Martin Pool
- doc
51
# TODO: Perhaps give a warning if one of the revisions marked as
52
# merged is already in the ancestry, and then don't record it as a
53
# distinct parent.
54
1343 by Martin Pool
- fix up test for merge of trees
55
# TODO: If the file is newly merged but unchanged from the version it
56
# merges from, then it should still be reported as newly added
57
# relative to the basis revision.
58
1185.16.66 by mbp at sourcefrog
- todo
59
# TODO: Do checks that the tree can be committed *before* running the 
60
# editor; this should include checks for a pointless commit and for 
61
# unknown or missing files.
62
63
# TODO: If commit fails, leave the message in a file somewhere.
64
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
65
1189 by Martin Pool
- BROKEN: partial support for commit into weave
66
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
67
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
68
import sys
1188 by Martin Pool
- clean up imports in commit code
69
import time
1248 by Martin Pool
- new weave based cleanup [broken]
70
import pdb
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
71
1188 by Martin Pool
- clean up imports in commit code
72
from binascii import hexlify
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
73
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
74
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
75
from bzrlib.atomicfile import AtomicFile
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
76
from bzrlib.osutils import (local_time_offset,
77
                            rand_bytes, compact_date,
1188 by Martin Pool
- clean up imports in commit code
78
                            kind_marker, is_inside_any, quotefn,
1248 by Martin Pool
- new weave based cleanup [broken]
79
                            sha_string, sha_strings, sha_file, isdir, isfile,
80
                            split_lines)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
81
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
82
from bzrlib.errors import (BzrError, PointlessCommit,
83
                           HistoryMissing,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
84
                           ConflictsInTree,
85
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
86
                           )
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
87
import bzrlib.errors as errors
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
88
import bzrlib.gpg as gpg
1311 by Martin Pool
- remove RevisionReference; just hold parent ids directly
89
from bzrlib.revision import Revision
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
90
from bzrlib.testament import Testament
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
91
from bzrlib.trace import mutter, note, warning
1189 by Martin Pool
- BROKEN: partial support for commit into weave
92
from bzrlib.xml5 import serializer_v5
1416 by Robert Collins
when committing a specific file, include all its parents
93
from bzrlib.inventory import Inventory, ROOT_ID
1189 by Martin Pool
- BROKEN: partial support for commit into weave
94
from bzrlib.weave import Weave
95
from bzrlib.weavefile import read_weave, write_weave_v5
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
96
from bzrlib.workingtree import WorkingTree
1189 by Martin Pool
- BROKEN: partial support for commit into weave
97
98
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
99
def commit(*args, **kwargs):
100
    """Commit a new revision to a branch.
101
102
    Function-style interface for convenience of old callers.
103
104
    New code should use the Commit class instead.
105
    """
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
106
    ## XXX: Remove this in favor of Branch.commit?
1205 by Martin Pool
- add bzrlib.commit.commit compatability interface
107
    Commit().commit(*args, **kwargs)
108
109
1189 by Martin Pool
- BROKEN: partial support for commit into weave
110
class NullCommitReporter(object):
111
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
112
113
    def snapshot_change(self, change, path):
114
        pass
115
116
    def completed(self, revno, rev_id):
117
        pass
118
119
    def deleted(self, file_id):
120
        pass
121
122
    def escaped(self, escape_count, message):
123
        pass
124
125
    def missing(self, path):
126
        pass
1189 by Martin Pool
- BROKEN: partial support for commit into weave
127
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
128
1189 by Martin Pool
- BROKEN: partial support for commit into weave
129
class ReportCommitToLog(NullCommitReporter):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
130
131
    def snapshot_change(self, change, path):
132
        note("%s %s", change, path)
133
134
    def completed(self, revno, rev_id):
135
        note('committed r%d {%s}', revno, rev_id)
136
    
137
    def deleted(self, file_id):
138
        note('deleted %s', file_id)
139
140
    def escaped(self, escape_count, message):
141
        note("replaced %d control characters in message", escape_count)
142
143
    def missing(self, path):
144
        note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
145
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
146
1189 by Martin Pool
- BROKEN: partial support for commit into weave
147
class Commit(object):
148
    """Task of committing a new revision.
149
150
    This is a MethodObject: it accumulates state as the commit is
151
    prepared, and then it is discarded.  It doesn't represent
152
    historical revisions, just the act of recording a new one.
153
154
            missing_ids
155
            Modified to hold a list of files that have been deleted from
156
            the working directory; these should be removed from the
157
            working inventory.
485 by Martin Pool
- move commit code into its own module
158
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
159
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
160
                 reporter=None,
161
                 config=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
162
        if reporter is not None:
163
            self.reporter = reporter
164
        else:
165
            self.reporter = NullCommitReporter()
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
166
        if config is not None:
167
            self.config = config
168
        else:
169
            self.config = None
1189 by Martin Pool
- BROKEN: partial support for commit into weave
170
        
171
    def commit(self,
172
               branch, message,
173
               timestamp=None,
174
               timezone=None,
175
               committer=None,
176
               specific_files=None,
177
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
178
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
179
               strict=False,
1185.16.35 by Martin Pool
- stub for revision properties
180
               verbose=False,
181
               revprops=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
        """Commit working copy as a new revision.
183
184
        timestamp -- if not None, seconds-since-epoch for a
185
             postdated/predated commit.
186
1253 by Martin Pool
- test that pointless commits are trapped
187
        specific_files -- If true, commit only those files.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
188
1253 by Martin Pool
- test that pointless commits are trapped
189
        rev_id -- If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
190
            Useful for test or import commands that need to tightly
191
            control what revisions are assigned.  If you duplicate
192
            a revision id that exists elsewhere it is your own fault.
193
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
194
195
        allow_pointless -- If true (default), commit even if nothing
196
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
197
1185.16.65 by mbp at sourcefrog
- new commit --strict option
198
        strict -- If true, don't allow a commit if the working tree
199
            contains unknown files.
200
1185.16.35 by Martin Pool
- stub for revision properties
201
        revprops -- Properties for new revision
1189 by Martin Pool
- BROKEN: partial support for commit into weave
202
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
203
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
204
205
        self.branch = branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
206
        self.bound_branch = None
207
        self.master_branch = None
1248 by Martin Pool
- new weave based cleanup [broken]
208
        self.weave_store = branch.weave_store
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
        self.rev_id = rev_id
210
        self.specific_files = specific_files
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
211
        self.allow_pointless = allow_pointless
1185.35.15 by Aaron Bentley
Added branch nicks to revisions
212
        self.revprops = {'branch-nick': branch.nick}
213
        if revprops:
214
            self.revprops.update(revprops)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
215
        self.work_tree = branch.working_tree()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
1185.22.4 by Michael Ellerman
Strict commit was a little .. ah .. too strict, oops :}
217
        if strict:
218
            # raise an exception as soon as we find a single unknown.
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
219
            for unknown in self.work_tree.unknowns():
1185.22.4 by Michael Ellerman
Strict commit was a little .. ah .. too strict, oops :}
220
                raise StrictCommitFailed()
1185.16.65 by mbp at sourcefrog
- new commit --strict option
221
1189 by Martin Pool
- BROKEN: partial support for commit into weave
222
        if timestamp is None:
223
            self.timestamp = time.time()
224
        else:
225
            self.timestamp = long(timestamp)
226
            
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
227
        if self.config is None:
228
            self.config = bzrlib.config.BranchConfig(self.branch)
229
1248 by Martin Pool
- new weave based cleanup [broken]
230
        if rev_id is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
231
            self.rev_id = _gen_revision_id(self.config, self.timestamp)
1248 by Martin Pool
- new weave based cleanup [broken]
232
        else:
233
            self.rev_id = rev_id
234
1189 by Martin Pool
- BROKEN: partial support for commit into weave
235
        if committer is None:
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
236
            self.committer = self.config.username()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
237
        else:
238
            assert isinstance(committer, basestring), type(committer)
239
            self.committer = committer
240
241
        if timezone is None:
242
            self.timezone = local_time_offset()
243
        else:
244
            self.timezone = int(timezone)
245
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
246
        if isinstance(message, str):
247
            message = message.decode(bzrlib.user_encoding)
248
        assert isinstance(message, unicode), type(message)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
249
        self.message = message
1390 by Robert Collins
pair programming worx... merge integration and weave
250
        self._escape_commit_message()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
251
1245 by Martin Pool
doc
252
        self.branch.lock_write()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
253
        try:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
254
            self._check_bound_branch()
255
1189 by Martin Pool
- BROKEN: partial support for commit into weave
256
            self.work_inv = self.work_tree.inventory
257
            self.basis_tree = self.branch.basis_tree()
258
            self.basis_inv = self.basis_tree.inventory
259
1223 by Martin Pool
- store inventories in weave
260
            self._gather_parents()
1344 by Martin Pool
- disallow selected-file commit of merges
261
            if len(self.parents) > 1 and self.specific_files:
262
                raise NotImplementedError('selected-file commit of merges is not supported yet')
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
263
            self._check_parents_present()
264
            
1251 by Martin Pool
- fix up commit in directory with some deleted files
265
            self._remove_deleted()
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
266
            self._populate_new_inv()
267
            self._store_snapshot()
1248 by Martin Pool
- new weave based cleanup [broken]
268
            self._report_deletes()
1245 by Martin Pool
doc
269
1248 by Martin Pool
- new weave based cleanup [broken]
270
            if not (self.allow_pointless
1279 by Martin Pool
- pointless commit of r1 no longer allowed
271
                    or len(self.parents) > 1
1249 by Martin Pool
- improvements to weave commit [broken]
272
                    or self.new_inv != self.basis_inv):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
273
                raise PointlessCommit()
274
1185.14.10 by Aaron Bentley
Commit aborts with conflicts in the tree.
275
            if len(list(self.work_tree.iter_conflicts()))>0:
276
                raise ConflictsInTree
277
1189 by Martin Pool
- BROKEN: partial support for commit into weave
278
            self._record_inventory()
279
            self._make_revision()
1185.33.59 by Martin Pool
[patch] keep a cached basis inventory (Johan Rydberg)
280
            self.work_tree.set_pending_merges([])
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
281
            self.branch.append_revision(self.rev_id)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
282
            self._update_bound_branch()
1472 by Robert Collins
post commit hook, first pass implementation
283
            self.reporter.completed(self.branch.revno()+1, self.rev_id)
284
            if self.config.post_commit() is not None:
285
                hooks = self.config.post_commit().split(' ')
286
                # this would be nicer with twisted.python.reflect.namedAny
287
                for hook in hooks:
288
                    result = eval(hook + '(branch, rev_id)',
289
                                  {'branch':self.branch,
290
                                   'bzrlib':bzrlib,
291
                                   'rev_id':self.rev_id})
1189 by Martin Pool
- BROKEN: partial support for commit into weave
292
        finally:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
293
            self._cleanup_bound_branch()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
294
            self.branch.unlock()
295
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
296
    def _check_bound_branch(self):
297
        """Check to see if the local branch is bound.
298
299
        If it is bound, then most of the commit will actually be
300
        done using the remote branch as the target branch.
301
        Only at the end will the local branch be updated.
302
        """
303
        # TODO: jam 20051230 Consider a special error for the case
304
        #       where the local branch is bound, and can't access the
305
        #       master branch
306
        self.master_branch = self.branch.get_bound_branch()
307
        if not self.master_branch:
308
            return
309
310
        # If the master branch is bound, we must fail
311
        master_bound_location = self.master_branch.get_bound_location()
312
        if master_bound_location:
313
            raise CommitToDoubleBoundBranch(self.branch,
314
                    self.master_branch, master_bound_location)
315
316
        # TODO: jam 20051230 We could automatically push local
317
        #       commits to the remote branch if they would fit.
318
        #       But for now, just require remote to be identical
319
        #       to local.
320
        
321
        # Make sure the local branch is identical to the master
322
        master_rh = self.master_branch.revision_history()
323
        local_rh = self.branch.revision_history()
324
        if local_rh != master_rh:
325
            raise errors.BoundBranchOutOfDate(self.branch,
326
                    self.master_branch)
327
328
        # Now things are ready to change the master branch
329
        # so grab the lock
330
        self.bound_branch = self.branch
331
        self.master_branch.lock_write()
332
        self.branch = self.master_branch
333
334
        # Check to see if we have any pending merges. If we do
335
        # those need to be pushed into the master branch
336
        pending_merges = self.work_tree.pending_merges()
337
        if pending_merges:
338
            from bzrlib.fetch import fetch
339
            for revision_id in pending_merges:
340
                fetch(self.master_branch, self.bound_branch, revision_id)
341
342
    def _cleanup_bound_branch(self):
343
        """Executed at the end of a try/finally to cleanup a bound branch.
344
345
        If the branch wasn't bound, this is a no-op.
346
        If it was, it resents self.branch to the local branch, instead
347
        of being the master.
348
        """
349
        if not self.bound_branch:
350
            return
351
        self.branch = self.bound_branch
352
        self.master_branch.unlock()
353
354
    def _update_bound_branch(self):
355
        """Update the local bound branch, after commit.
356
357
        This only runs if the commit to the remote branch succeeds.
358
        """
359
        if not self.bound_branch:
360
            return
361
        # We always want the local branch to look like the remote one
362
        self.bound_branch.pull(self.master_branch)
363
1189 by Martin Pool
- BROKEN: partial support for commit into weave
364
    def _record_inventory(self):
1223 by Martin Pool
- store inventories in weave
365
        """Store the inventory for the new revision."""
1248 by Martin Pool
- new weave based cleanup [broken]
366
        inv_text = serializer_v5.write_inventory_to_string(self.new_inv)
367
        self.inv_sha1 = sha_string(inv_text)
1390 by Robert Collins
pair programming worx... merge integration and weave
368
        s = self.branch.control_weaves
1352 by Martin Pool
- store control weaves in .bzr/, not mixed in with file weaves
369
        s.add_text('inventory', self.rev_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
370
                   split_lines(inv_text), self.present_parents,
371
                   self.branch.get_transaction())
1223 by Martin Pool
- store inventories in weave
372
1390 by Robert Collins
pair programming worx... merge integration and weave
373
    def _escape_commit_message(self):
374
        """Replace xml-incompatible control characters."""
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
375
        # Python strings can include characters that can't be
376
        # represented in well-formed XML; escape characters that
377
        # aren't listed in the XML specification
378
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
379
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
380
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
381
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
382
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
383
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
384
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
385
386
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
387
        """Record the parents of a merge for merge detection."""
1457.1.14 by Robert Collins
Move pending_merges() to WorkingTree.
388
        pending_merges = self.work_tree.pending_merges()
1223 by Martin Pool
- store inventories in weave
389
        self.parents = []
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
390
        self.parent_invs = []
1092.2.25 by Robert Collins
support ghosts in commits
391
        self.present_parents = []
1241 by Martin Pool
- rename last_patch to last_revision
392
        precursor_id = self.branch.last_revision()
1223 by Martin Pool
- store inventories in weave
393
        if precursor_id:
394
            self.parents.append(precursor_id)
395
        self.parents += pending_merges
1092.2.25 by Robert Collins
support ghosts in commits
396
        for revision in self.parents:
397
            if self.branch.has_revision(revision):
1408 by Robert Collins
we do not need revision_trees in commit, parent inventories are sufficient
398
                self.parent_invs.append(self.branch.get_inventory(revision))
1092.2.25 by Robert Collins
support ghosts in commits
399
                self.present_parents.append(revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
400
401
    def _check_parents_present(self):
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
402
        for parent_id in self.parents:
1270 by Martin Pool
- fix recording of merged ancestry lines
403
            mutter('commit parent revision {%s}', parent_id)
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
404
            if not self.branch.has_revision(parent_id):
1092.2.25 by Robert Collins
support ghosts in commits
405
                if parent_id == self.branch.last_revision():
1185.12.9 by Aaron Bentley
Removed crude language
406
                    warning("parent is missing %r", parent_id)
1092.2.25 by Robert Collins
support ghosts in commits
407
                    raise HistoryMissing(self.branch, 'revision', parent_id)
408
                else:
409
                    mutter("commit will ghost revision %r", parent_id)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
410
            
1189 by Martin Pool
- BROKEN: partial support for commit into weave
411
    def _make_revision(self):
412
        """Record a new revision object for this commit."""
413
        self.rev = Revision(timestamp=self.timestamp,
414
                            timezone=self.timezone,
415
                            committer=self.committer,
416
                            message=self.message,
417
                            inventory_sha1=self.inv_sha1,
1185.16.35 by Martin Pool
- stub for revision properties
418
                            revision_id=self.rev_id,
419
                            properties=self.revprops)
1313 by Martin Pool
- rename to Revision.parent_ids to avoid confusion with old usage
420
        self.rev.parent_ids = self.parents
1248 by Martin Pool
- new weave based cleanup [broken]
421
        rev_tmp = StringIO()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
422
        serializer_v5.write_revision(self.rev, rev_tmp)
580 by Martin Pool
- Use explicit lock methods on a branch, rather than doing it
423
        rev_tmp.seek(0)
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
424
        if self.config.signature_needed():
425
            plaintext = Testament(self.rev, self.new_inv).as_short_text()
426
            self.branch.store_revision_signature(gpg.GPGStrategy(self.config),
427
                                                 plaintext, self.rev_id)
1393.2.3 by John Arbash Meinel
Fixing typos, updating stores, getting tests to pass.
428
        self.branch.revision_store.add(rev_tmp, self.rev_id)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
429
        mutter('new revision_id is {%s}', self.rev_id)
430
431
    def _remove_deleted(self):
1248 by Martin Pool
- new weave based cleanup [broken]
432
        """Remove deleted files from the working inventories.
433
434
        This is done prior to taking the working inventory as the
435
        basis for the new committed inventory.
436
437
        This returns true if any files
438
        *that existed in the basis inventory* were deleted.
439
        Files that were added and deleted
440
        in the working copy don't matter.
441
        """
1254 by Martin Pool
- fix handling of selective commit with deleted files
442
        specific = self.specific_files
443
        deleted_ids = []
444
        for path, ie in self.work_inv.iter_entries():
445
            if specific and not is_inside_any(specific, path):
446
                continue
447
            if not self.work_tree.has_filename(path):
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
448
                self.reporter.missing(path)
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
449
                deleted_ids.append((path, ie.file_id))
1254 by Martin Pool
- fix handling of selective commit with deleted files
450
        if deleted_ids:
1185.12.5 by Aaron Bentley
Fixed ordering issue in Commit._remove_deleted
451
            deleted_ids.sort(reverse=True)
452
            for path, file_id in deleted_ids:
1248 by Martin Pool
- new weave based cleanup [broken]
453
                del self.work_inv[file_id]
1457.1.11 by Robert Collins
Move _write_inventory to WorkingTree.
454
            self.work_tree._write_inventory(self.work_inv)
1248 by Martin Pool
- new weave based cleanup [broken]
455
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
456
    def _store_snapshot(self):
457
        """Pass over inventory and record a snapshot.
1303 by Martin Pool
- commit updates entry_version
458
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
459
        Entries get a new revision when they are modified in 
460
        any way, which includes a merge with a new set of
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
461
        parents that have the same entry. 
1092.2.21 by Robert Collins
convert name_version to revision in inventory entries
462
        """
1303 by Martin Pool
- commit updates entry_version
463
        # XXX: Need to think more here about when the user has
464
        # made a specific decision on a particular value -- c.f.
465
        # mark-merge.  
466
        for path, ie in self.new_inv.iter_entries():
1411 by Robert Collins
use weave ancestry to determine inventory entry previous heads, prevent propogating 'I did a merge' merges.
467
            previous_entries = ie.find_previous_heads(
468
                self.parent_invs, 
1185.33.88 by Martin Pool
[patch] read only the table-of-contents of weaves to speed up commit
469
                self.weave_store.get_weave_prelude_or_empty(ie.file_id,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
470
                    self.branch.get_transaction()))
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
471
            if ie.revision is None:
472
                change = ie.snapshot(self.rev_id, path, previous_entries,
1417.1.8 by Robert Collins
use transactions in the weave store interface, which enables caching for log
473
                                     self.work_tree, self.weave_store,
474
                                     self.branch.get_transaction())
1092.2.23 by Robert Collins
move inventory entry centric snapshot taking logic to inventory.py
475
            else:
476
                change = "unchanged"
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
477
            self.reporter.snapshot_change(change, path)
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
478
479
    def _populate_new_inv(self):
480
        """Build revision inventory.
481
482
        This creates a new empty inventory. Depending on
483
        which files are selected for commit, and what is present in the
484
        current tree, the new inventory is populated. inventory entries 
485
        which are candidates for modification have their revision set to
486
        None; inventory entries that are carried over untouched have their
487
        revision set to their prior value.
1301 by Martin Pool
- more docs in commit code
488
        """
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
489
        mutter("Selecting files for commit with filter %s", self.specific_files)
490
        self.new_inv = Inventory()
1249 by Martin Pool
- improvements to weave commit [broken]
491
        for path, new_ie in self.work_inv.iter_entries():
492
            file_id = new_ie.file_id
493
            mutter('check %s {%s}', path, new_ie.file_id)
1248 by Martin Pool
- new weave based cleanup [broken]
494
            if self.specific_files:
495
                if not is_inside_any(self.specific_files, path):
1249 by Martin Pool
- improvements to weave commit [broken]
496
                    mutter('%s not selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
497
                    self._carry_entry(file_id)
1249 by Martin Pool
- improvements to weave commit [broken]
498
                    continue
1416 by Robert Collins
when committing a specific file, include all its parents
499
                else:
500
                    # this is selected, ensure its parents are too.
501
                    parent_id = new_ie.parent_id
502
                    while parent_id != ROOT_ID:
503
                        if not self.new_inv.has_id(parent_id):
504
                            ie = self._select_entry(self.work_inv[parent_id])
505
                            mutter('%s selected for commit because of %s',
506
                                   self.new_inv.id2path(parent_id), path)
507
508
                        ie = self.new_inv[parent_id]
509
                        if ie.revision is not None:
510
                            ie.revision = None
511
                            mutter('%s selected for commit because of %s',
512
                                   self.new_inv.id2path(parent_id), path)
513
                        parent_id = ie.parent_id
1092.2.22 by Robert Collins
text_version and name_version unification looking reasonable
514
            mutter('%s selected for commit', path)
1416 by Robert Collins
when committing a specific file, include all its parents
515
            self._select_entry(new_ie)
516
517
    def _select_entry(self, new_ie):
518
        """Make new_ie be considered for committing."""
519
        ie = new_ie.copy()
520
        ie.revision = None
521
        self.new_inv.add(ie)
522
        return ie
523
524
    def _carry_entry(self, file_id):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
525
        """Carry the file unchanged from the basis revision."""
1249 by Martin Pool
- improvements to weave commit [broken]
526
        if self.basis_inv.has_id(file_id):
527
            self.new_inv.add(self.basis_inv[file_id].copy())
1248 by Martin Pool
- new weave based cleanup [broken]
528
529
    def _report_deletes(self):
530
        for file_id in self.basis_inv:
531
            if file_id not in self.new_inv:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
532
                self.reporter.deleted(self.basis_inv.id2path(file_id))
1248 by Martin Pool
- new weave based cleanup [broken]
533
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
534
def _gen_revision_id(config, when):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
535
    """Return new revision-id."""
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
536
    s = '%s-%s-' % (config.user_email(), compact_date(when))
1189 by Martin Pool
- BROKEN: partial support for commit into weave
537
    s += hexlify(rand_bytes(8))
538
    return s