/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
1553.5.12 by Martin Pool
New LockDir locking mechanism
1
# Copyright (C) 2006 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
"""Tests for LockDir"""
18
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
19
from cStringIO import StringIO
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
20
import os
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
21
from threading import Thread, Lock
1553.5.12 by Martin Pool
New LockDir locking mechanism
22
import time
23
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
24
import bzrlib
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
25
from bzrlib import (
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
26
    config,
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
27
    errors,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
28
    osutils,
1551.10.4 by Aaron Bentley
Update to skip on win32
29
    tests,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
30
    )
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
31
from bzrlib.errors import (
32
        LockBreakMismatch,
33
        LockContention, LockError, UnlockableTransport,
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
34
        LockNotHeld, LockBroken
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
35
        )
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
36
from bzrlib.lockdir import LockDir, _DEFAULT_TIMEOUT_SECONDS
1553.5.33 by Martin Pool
LockDir review comment fixes
37
from bzrlib.tests import TestCaseWithTransport
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
38
from bzrlib.trace import note
1553.5.12 by Martin Pool
New LockDir locking mechanism
39
40
# These tests sometimes use threads to test the behaviour of lock files with
41
# concurrent actors.  This is not a typical (or necessarily supported) use;
42
# they're really meant for guarding between processes.
43
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
44
# These tests are run on the default transport provided by the test framework
45
# (typically a local disk transport).  That can be changed by the --transport
46
# option to bzr selftest.  The required properties of the transport
47
# implementation are tested separately.  (The main requirement is just that
48
# they don't allow overwriting nonempty directories.)
49
1553.5.12 by Martin Pool
New LockDir locking mechanism
50
class TestLockDir(TestCaseWithTransport):
51
    """Test LockDir operations"""
52
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
53
    def logging_report_function(self, fmt, *args):
54
        self._logged_reports.append((fmt, args))
55
56
    def setup_log_reporter(self, lock_dir):
57
        self._logged_reports = []
58
        lock_dir._report_function = self.logging_report_function
59
1553.5.12 by Martin Pool
New LockDir locking mechanism
60
    def test_00_lock_creation(self):
61
        """Creation of lock file on a transport"""
62
        t = self.get_transport()
63
        lf = LockDir(t, 'test_lock')
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
64
        self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
65
66
    def test_01_lock_repr(self):
67
        """Lock string representation"""
68
        lf = LockDir(self.get_transport(), 'test_lock')
69
        r = repr(lf)
70
        self.assertContainsRe(r, r'^LockDir\(.*/test_lock\)$')
71
72
    def test_02_unlocked_peek(self):
73
        lf = LockDir(self.get_transport(), 'test_lock')
74
        self.assertEqual(lf.peek(), None)
75
1687.1.3 by Robert Collins
Make LockDir.unlock check the lock is still intact.
76
    def get_lock(self):
77
        return LockDir(self.get_transport(), 'test_lock')
78
79
    def test_unlock_after_break_raises(self):
80
        ld = self.get_lock()
81
        ld2 = self.get_lock()
82
        ld.create()
83
        ld.attempt_lock()
84
        ld2.force_break(ld2.peek())
85
        self.assertRaises(LockBroken, ld.unlock)
86
1553.5.12 by Martin Pool
New LockDir locking mechanism
87
    def test_03_readonly_peek(self):
88
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
89
        self.assertEqual(lf.peek(), None)
90
91
    def test_10_lock_uncontested(self):
92
        """Acquire and release a lock"""
93
        t = self.get_transport()
94
        lf = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
95
        lf.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
96
        lf.attempt_lock()
97
        try:
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
98
            self.assertTrue(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
99
        finally:
100
            lf.unlock()
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
101
            self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
102
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
103
    def test_11_create_readonly_transport(self):
104
        """Fail to create lock on readonly transport"""
105
        t = self.get_readonly_transport()
106
        lf = LockDir(t, 'test_lock')
107
        self.assertRaises(UnlockableTransport, lf.create)
108
109
    def test_12_lock_readonly_transport(self):
1553.5.12 by Martin Pool
New LockDir locking mechanism
110
        """Fail to lock on readonly transport"""
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
111
        lf = LockDir(self.get_transport(), 'test_lock')
112
        lf.create()
113
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
1553.5.12 by Martin Pool
New LockDir locking mechanism
114
        self.assertRaises(UnlockableTransport, lf.attempt_lock)
115
116
    def test_20_lock_contested(self):
117
        """Contention to get a lock"""
118
        t = self.get_transport()
119
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
120
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
121
        lf1.attempt_lock()
122
        lf2 = LockDir(t, 'test_lock')
123
        try:
124
            # locking is between LockDir instances; aliases within 
125
            # a single process are not detected
126
            lf2.attempt_lock()
127
            self.fail('Failed to detect lock collision')
128
        except LockContention, e:
129
            self.assertEqual(e.lock, lf2)
130
            self.assertContainsRe(str(e),
131
                    r'^Could not acquire.*test_lock.*$')
132
        lf1.unlock()
133
134
    def test_20_lock_peek(self):
135
        """Peek at the state of a lock"""
136
        t = self.get_transport()
137
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
138
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
139
        lf1.attempt_lock()
140
        # lock is held, should get some info on it
141
        info1 = lf1.peek()
142
        self.assertEqual(set(info1.keys()),
143
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
144
        # should get the same info if we look at it through a different
145
        # instance
146
        info2 = LockDir(t, 'test_lock').peek()
147
        self.assertEqual(info1, info2)
148
        # locks which are never used should be not-held
149
        self.assertEqual(LockDir(t, 'other_lock').peek(), None)
150
151
    def test_21_peek_readonly(self):
152
        """Peek over a readonly transport"""
153
        t = self.get_transport()
154
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
155
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
156
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
157
        self.assertEqual(lf2.peek(), None)
158
        lf1.attempt_lock()
159
        info2 = lf2.peek()
160
        self.assertTrue(info2)
161
        self.assertEqual(info2['nonce'], lf1.nonce)
162
163
    def test_30_lock_wait_fail(self):
164
        """Wait on a lock, then fail
165
        
166
        We ask to wait up to 400ms; this should fail within at most one
167
        second.  (Longer times are more realistic but we don't want the test
168
        suite to take too long, and this should do for now.)
169
        """
170
        t = self.get_transport()
171
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
172
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
173
        lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
174
        self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
175
        lf1.attempt_lock()
176
        try:
177
            before = time.time()
178
            self.assertRaises(LockContention, lf2.wait_lock,
179
                              timeout=0.4, poll=0.1)
180
            after = time.time()
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
181
            # it should only take about 0.4 seconds, but we allow more time in
182
            # case the machine is heavily loaded
183
            self.assertTrue(after - before <= 8.0, 
184
                    "took %f seconds to detect lock contention" % (after - before))
1553.5.12 by Martin Pool
New LockDir locking mechanism
185
        finally:
186
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
187
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
188
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
189
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
190
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
191
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
192
                         self._logged_reports[0][0])
193
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
194
        self.assertEqual('Unable to obtain', args[0])
195
        self.assertEqual('lock %s' % (lock_base,), args[1])
196
        self.assertStartsWith(args[2], 'held by ')
197
        self.assertStartsWith(args[3], 'locked ')
198
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
199
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1553.5.12 by Martin Pool
New LockDir locking mechanism
200
201
    def test_31_lock_wait_easy(self):
202
        """Succeed when waiting on a lock with no contention.
203
        """
204
        t = self.get_transport()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
205
        lf1 = LockDir(t, 'test_lock')
206
        lf1.create()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
207
        self.setup_log_reporter(lf1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
208
        try:
209
            before = time.time()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
210
            lf1.wait_lock(timeout=0.4, poll=0.1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
211
            after = time.time()
212
            self.assertTrue(after - before <= 1.0)
213
        finally:
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
214
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
215
        self.assertEqual([], self._logged_reports)
1553.5.12 by Martin Pool
New LockDir locking mechanism
216
217
    def test_32_lock_wait_succeed(self):
218
        """Succeed when trying to acquire a lock that gets released
219
1553.5.77 by Martin Pool
doc
220
        One thread holds on a lock and then releases it; another 
221
        tries to lock it.
1553.5.12 by Martin Pool
New LockDir locking mechanism
222
        """
223
        t = self.get_transport()
224
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
225
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
226
        lf1.attempt_lock()
227
228
        def wait_and_unlock():
229
            time.sleep(0.1)
230
            lf1.unlock()
231
        unlocker = Thread(target=wait_and_unlock)
232
        unlocker.start()
233
        try:
234
            lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
235
            self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
236
            before = time.time()
237
            # wait and then lock
238
            lf2.wait_lock(timeout=0.4, poll=0.1)
239
            after = time.time()
240
            self.assertTrue(after - before <= 1.0)
241
        finally:
242
            unlocker.join()
243
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
244
        # There should be only 1 report, even though it should have to
245
        # wait for a while
246
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
247
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
248
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
249
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
250
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
251
                         self._logged_reports[0][0])
252
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
253
        self.assertEqual('Unable to obtain', args[0])
254
        self.assertEqual('lock %s' % (lock_base,), args[1])
255
        self.assertStartsWith(args[2], 'held by ')
256
        self.assertStartsWith(args[3], 'locked ')
257
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
258
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
259
1553.5.12 by Martin Pool
New LockDir locking mechanism
260
    def test_33_wait(self):
261
        """Succeed when waiting on a lock that gets released
262
263
        The difference from test_32_lock_wait_succeed is that the second 
264
        caller does not actually acquire the lock, but just waits for it
265
        to be released.  This is done over a readonly transport.
266
        """
267
        t = self.get_transport()
268
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
269
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
270
        lf1.attempt_lock()
271
272
        def wait_and_unlock():
273
            time.sleep(0.1)
274
            lf1.unlock()
275
        unlocker = Thread(target=wait_and_unlock)
276
        unlocker.start()
277
        try:
278
            lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
279
            before = time.time()
280
            # wait but don't lock
281
            lf2.wait(timeout=0.4, poll=0.1)
282
            after = time.time()
283
            self.assertTrue(after - before <= 1.0)
284
        finally:
285
            unlocker.join()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
286
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
287
    def test_34_lock_write_waits(self):
288
        """LockDir.lock_write() will wait for the lock.""" 
289
        t = self.get_transport()
290
        lf1 = LockDir(t, 'test_lock')
291
        lf1.create()
292
        lf1.attempt_lock()
293
294
        def wait_and_unlock():
295
            time.sleep(0.1)
296
            lf1.unlock()
297
        unlocker = Thread(target=wait_and_unlock)
298
        unlocker.start()
299
        try:
300
            lf2 = LockDir(t, 'test_lock')
301
            self.setup_log_reporter(lf2)
302
            before = time.time()
303
            # wait and then lock
304
            lf2.lock_write()
305
            after = time.time()
306
        finally:
307
            unlocker.join()
308
309
        # There should be only 1 report, even though it should have to
310
        # wait for a while
311
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
312
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
313
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
314
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
315
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
316
                         self._logged_reports[0][0])
317
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
318
        self.assertEqual('Unable to obtain', args[0])
319
        self.assertEqual('lock %s' % (lock_base,), args[1])
320
        self.assertStartsWith(args[2], 'held by ')
321
        self.assertStartsWith(args[3], 'locked ')
322
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
323
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
324
325
    def test_35_wait_lock_changing(self):
326
        """LockDir.wait_lock() will report if the lock changes underneath.
327
        
328
        This is the stages we want to happen:
329
330
        0) Synchronization locks are created and locked.
331
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
332
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
333
           It sees the lockdir is already acquired, reports the fact, 
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
334
           and unsets the 'checked' lock.
335
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
336
           Lock1 to release and acquire the lockdir. This resets the 'check'
337
           lock.
338
        4) Lock2 acquires the 'check' lock, and checks again. It notices
339
           that the holder of the lock has changed, and so reports a new 
340
           lock holder.
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
341
        5) Thread1 blocks on the 'checked' lock, this time, it completely
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
342
           unlocks the lockdir, allowing Lock2 to acquire the lock.
343
        """
344
345
        wait_to_check_lock = Lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
346
        wait_until_checked_lock = Lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
347
348
        wait_to_check_lock.acquire()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
349
        wait_until_checked_lock.acquire()
350
        note('locked check and checked locks')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
351
352
        class LockDir1(LockDir):
353
            """Use the synchronization points for the first lock."""
354
355
            def attempt_lock(self):
356
                # Once we have acquired the lock, it is okay for
357
                # the other lock to check it
358
                try:
359
                    return super(LockDir1, self).attempt_lock()
360
                finally:
361
                    note('lock1: releasing check lock')
362
                    wait_to_check_lock.release()
363
364
        class LockDir2(LockDir):
365
            """Use the synchronization points for the second lock."""
366
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
367
            def attempt_lock(self):
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
368
                note('lock2: waiting for check lock')
369
                wait_to_check_lock.acquire()
370
                note('lock2: acquired check lock')
371
                try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
372
                    return super(LockDir2, self).attempt_lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
373
                finally:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
374
                    note('lock2: releasing checked lock')
375
                    wait_until_checked_lock.release()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
376
377
        t = self.get_transport()
378
        lf1 = LockDir1(t, 'test_lock')
379
        lf1.create()
380
381
        lf2 = LockDir2(t, 'test_lock')
382
        self.setup_log_reporter(lf2)
383
384
        def wait_and_switch():
385
            lf1.attempt_lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
386
            # Block until lock2 has had a chance to check
387
            note('lock1: waiting 1 for checked lock')
388
            wait_until_checked_lock.acquire()
389
            note('lock1: acquired for checked lock')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
390
            note('lock1: released lockdir')
391
            lf1.unlock()
392
            note('lock1: acquiring lockdir')
393
            # Create a new nonce, so the lock looks different.
394
            lf1.nonce = osutils.rand_chars(20)
395
            lf1.lock_write()
396
            note('lock1: acquired lockdir')
397
398
            # Block until lock2 has peeked again
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
399
            note('lock1: waiting 2 for checked lock')
400
            wait_until_checked_lock.acquire()
401
            note('lock1: acquired for checked lock')
402
            # Now unlock, and let lock 2 grab the lock
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
403
            lf1.unlock()
404
            wait_to_check_lock.release()
405
406
        unlocker = Thread(target=wait_and_switch)
407
        unlocker.start()
408
        try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
409
            # Wait and play against the other thread
410
            lf2.wait_lock(timeout=1.0, poll=0.01)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
411
        finally:
412
            unlocker.join()
413
        lf2.unlock()
414
415
        # There should be 2 reports, because the lock changed
416
        lock_base = lf2.transport.abspath(lf2.path)
417
        self.assertEqual(2, len(self._logged_reports))
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
418
1957.1.15 by John Arbash Meinel
Review feedback from Robert
419
        self.assertEqual('%s %s\n'
420
                         '%s\n%s\n'
421
                         'Will continue to try until %s\n',
422
                         self._logged_reports[0][0])
423
        args = self._logged_reports[0][1]
424
        self.assertEqual('Unable to obtain', args[0])
425
        self.assertEqual('lock %s' % (lock_base,), args[1])
426
        self.assertStartsWith(args[2], 'held by ')
427
        self.assertStartsWith(args[3], 'locked ')
428
        self.assertEndsWith(args[3], ' ago')
429
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
430
1957.1.15 by John Arbash Meinel
Review feedback from Robert
431
        self.assertEqual('%s %s\n'
432
                         '%s\n%s\n'
433
                         'Will continue to try until %s\n',
434
                         self._logged_reports[1][0])
435
        args = self._logged_reports[1][1]
436
        self.assertEqual('Lock owner changed for', args[0])
437
        self.assertEqual('lock %s' % (lock_base,), args[1])
438
        self.assertStartsWith(args[2], 'held by ')
439
        self.assertStartsWith(args[3], 'locked ')
440
        self.assertEndsWith(args[3], ' ago')
441
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
442
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
443
    def test_40_confirm_easy(self):
444
        """Confirm a lock that's already held"""
445
        t = self.get_transport()
446
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
447
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
448
        lf1.attempt_lock()
449
        lf1.confirm()
450
451
    def test_41_confirm_not_held(self):
452
        """Confirm a lock that's already held"""
453
        t = self.get_transport()
454
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
455
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
456
        self.assertRaises(LockNotHeld, lf1.confirm)
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
457
458
    def test_42_confirm_broken_manually(self):
459
        """Confirm a lock broken by hand"""
460
        t = self.get_transport()
461
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
462
        lf1.create()
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
463
        lf1.attempt_lock()
464
        t.move('test_lock', 'lock_gone_now')
465
        self.assertRaises(LockBroken, lf1.confirm)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
466
467
    def test_43_break(self):
468
        """Break a lock whose caller has forgotten it"""
469
        t = self.get_transport()
470
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
471
        lf1.create()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
472
        lf1.attempt_lock()
473
        # we incorrectly discard the lock object without unlocking it
474
        del lf1
475
        # someone else sees it's still locked
476
        lf2 = LockDir(t, 'test_lock')
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
477
        holder_info = lf2.peek()
478
        self.assertTrue(holder_info)
479
        lf2.force_break(holder_info)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
480
        # now we should be able to take it
481
        lf2.attempt_lock()
482
        lf2.confirm()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
483
484
    def test_44_break_already_released(self):
485
        """Lock break races with regular release"""
486
        t = self.get_transport()
487
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
488
        lf1.create()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
489
        lf1.attempt_lock()
490
        # someone else sees it's still locked
491
        lf2 = LockDir(t, 'test_lock')
492
        holder_info = lf2.peek()
493
        # in the interim the lock is released
494
        lf1.unlock()
495
        # break should succeed
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
496
        lf2.force_break(holder_info)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
497
        # now we should be able to take it
498
        lf2.attempt_lock()
499
        lf2.confirm()
500
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
501
    def test_45_break_mismatch(self):
502
        """Lock break races with someone else acquiring it"""
503
        t = self.get_transport()
504
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
505
        lf1.create()
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
506
        lf1.attempt_lock()
507
        # someone else sees it's still locked
508
        lf2 = LockDir(t, 'test_lock')
509
        holder_info = lf2.peek()
510
        # in the interim the lock is released
511
        lf1.unlock()
512
        lf3 = LockDir(t, 'test_lock')
513
        lf3.attempt_lock()
514
        # break should now *fail*
515
        self.assertRaises(LockBreakMismatch, lf2.force_break,
516
                          holder_info)
517
        lf3.unlock()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
518
519
    def test_46_fake_read_lock(self):
520
        t = self.get_transport()
521
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
522
        lf1.create()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
523
        lf1.lock_read()
524
        lf1.unlock()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
525
526
    def test_50_lockdir_representation(self):
527
        """Check the on-disk representation of LockDirs is as expected.
528
529
        There should always be a top-level directory named by the lock.
530
        When the lock is held, there should be a lockname/held directory 
531
        containing an info file.
532
        """
533
        t = self.get_transport()
534
        lf1 = LockDir(t, 'test_lock')
535
        lf1.create()
536
        self.assertTrue(t.has('test_lock'))
537
        lf1.lock_write()
538
        self.assertTrue(t.has('test_lock/held/info'))
539
        lf1.unlock()
540
        self.assertFalse(t.has('test_lock/held/info'))
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
541
542
    def test_break_lock(self):
543
        # the ui based break_lock routine should Just Work (tm)
544
        ld1 = self.get_lock()
545
        ld2 = self.get_lock()
546
        ld1.create()
547
        ld1.lock_write()
1687.1.6 by Robert Collins
Extend LockableFiles to support break_lock() calls.
548
        # do this without IO redirection to ensure it doesn't prompt.
549
        self.assertRaises(AssertionError, ld1.break_lock)
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
550
        orig_factory = bzrlib.ui.ui_factory
551
        # silent ui - no need for stdout
552
        bzrlib.ui.ui_factory = bzrlib.ui.SilentUIFactory()
553
        bzrlib.ui.ui_factory.stdin = StringIO("y\n")
554
        try:
555
            ld2.break_lock()
556
            self.assertRaises(LockBroken, ld1.unlock)
557
        finally:
558
            bzrlib.ui.ui_factory = orig_factory
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
559
560
    def test_create_missing_base_directory(self):
561
        """If LockDir.path doesn't exist, it can be created
562
563
        Some people manually remove the entire lock/ directory trying
564
        to unlock a stuck repository/branch/etc. Rather than failing
565
        after that, just create the lock directory when needed.
566
        """
567
        t = self.get_transport()
568
        lf1 = LockDir(t, 'test_lock')
569
570
        lf1.create()
571
        self.failUnless(t.has('test_lock'))
572
573
        t.rmdir('test_lock')
574
        self.failIf(t.has('test_lock'))
575
576
        # This will create 'test_lock' if it needs to
577
        lf1.lock_write()
578
        self.failUnless(t.has('test_lock'))
579
        self.failUnless(t.has('test_lock/held/info'))
580
581
        lf1.unlock()
582
        self.failIf(t.has('test_lock/held/info'))
1957.1.6 by John Arbash Meinel
[merge] bzr.dev 2009
583
1957.1.5 by John Arbash Meinel
Create a helper function for formatting lock information
584
    def test__format_lock_info(self):
585
        ld1 = self.get_lock()
586
        ld1.create()
587
        ld1.lock_write()
588
        try:
589
            info_list = ld1._format_lock_info(ld1.peek())
590
        finally:
591
            ld1.unlock()
592
        self.assertEqual('lock %s' % (ld1.transport.abspath(ld1.path),),
593
                         info_list[0])
594
        self.assertContainsRe(info_list[1],
595
                              r'^held by .* on host .* \[process #\d*\]$')
596
        self.assertContainsRe(info_list[2], r'locked \d+ seconds? ago$')
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
597
598
    def test_lock_without_email(self):
599
        global_config = config.GlobalConfig()
600
        # Intentionally has no email address
601
        global_config.set_user_option('email', 'User Identity')
602
        ld1 = self.get_lock()
603
        ld1.create()
604
        ld1.lock_write()
605
        ld1.unlock()
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
606
607
    def test_lock_permission(self):
1551.10.4 by Aaron Bentley
Update to skip on win32
608
        if not osutils.supports_posix_readonly():
609
            raise tests.TestSkipped('Cannot induce a permission failure')
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
610
        ld1 = self.get_lock()
611
        lock_path = ld1.transport.local_abspath('test_lock')
612
        os.mkdir(lock_path)
613
        osutils.make_readonly(lock_path)
614
        self.assertRaises(errors.PermissionDenied, ld1.attempt_lock)