/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
2018.18.22 by Martin Pool
merge bzr.dev
1
# Copyright (C) 2006, 2007 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
2018.18.22 by Martin Pool
merge bzr.dev
3
#            and others
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
4
#
5
# This program is free software; you can redistribute it and/or modify
6
# it under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 2 of the License, or
8
# (at your option) any later version.
9
#
10
# This program is distributed in the hope that it will be useful,
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with this program; if not, write to the Free Software
17
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
19
"""Tests for the formatting and construction of errors."""
20
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
21
from bzrlib import (
22
    bzrdir,
23
    errors,
24
    )
25
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
26
27
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
28
# TODO: Make sure builtin exception class formats are consistent - e.g. should
29
# or shouldn't end with a full stop, etc.
30
31
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
32
class TestErrors(TestCaseWithTransport):
33
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
34
    def test_disabled_method(self):
35
        error = errors.DisabledMethod("class name")
36
        self.assertEqualDiff(
37
            "The smart server method 'class name' is disabled.", str(error))
38
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
39
    def test_duplicate_file_id(self):
40
        error = errors.DuplicateFileId('a_file_id', 'foo')
41
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
42
                             ' as foo', str(error))
43
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
44
    def test_inventory_modified(self):
45
        error = errors.InventoryModified("a tree to be repred")
46
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
47
            "be repred' has been modified, so a clean inventory cannot be "
48
            "read without data loss.",
49
            str(error))
50
2116.3.1 by John Arbash Meinel
Cleanup error tests
51
    def test_install_failed(self):
52
        error = errors.InstallFailed(['rev-one'])
53
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
54
        error = errors.InstallFailed(['rev-one', 'rev-two'])
55
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
56
                         str(error))
57
        error = errors.InstallFailed([None])
58
        self.assertEqual("Could not install revisions:\nNone", str(error))
59
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
60
    def test_lock_active(self):
61
        error = errors.LockActive("lock description")
62
        self.assertEqualDiff("The lock for 'lock description' is in use and "
63
            "cannot be broken.",
64
            str(error))
65
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
66
    def test_knit_header_error(self):
67
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
68
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
69
                         " for file path/to/file", str(error))
70
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
71
    def test_knit_index_unknown_method(self):
72
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
73
                                              ['bad', 'no-eol'])
74
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
75
                         " known method in options: ['bad', 'no-eol']",
76
                         str(error))
77
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
78
    def test_medium_not_connected(self):
79
        error = errors.MediumNotConnected("a medium")
80
        self.assertEqualDiff(
81
            "The medium 'a medium' is not connected.", str(error))
82
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
83
    def test_no_repo(self):
84
        dir = bzrdir.BzrDir.create(self.get_url())
85
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
86
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
87
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
88
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
89
    def test_no_smart_medium(self):
90
        error = errors.NoSmartMedium("a transport")
91
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
92
            "smart protocol.",
93
            str(error))
94
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
95
    def test_no_such_id(self):
96
        error = errors.NoSuchId("atree", "anid")
97
        self.assertEqualDiff("The file id anid is not present in the tree "
98
            "atree.",
99
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
100
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
101
    def test_no_such_revision_in_tree(self):
102
        error = errors.NoSuchRevisionInTree("atree", "anid")
103
        self.assertEqualDiff("The revision id anid is not present in the tree "
104
            "atree.",
105
            str(error))
106
        self.assertIsInstance(error, errors.NoSuchRevision)
107
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
108
    def test_not_write_locked(self):
109
        error = errors.NotWriteLocked('a thing to repr')
110
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
111
            "to be.",
112
            str(error))
113
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
114
    def test_read_only_lock_error(self):
115
        error = errors.ReadOnlyLockError('filename', 'error message')
116
        self.assertEqualDiff("Cannot acquire write lock on filename."
117
                             " error message", str(error))
118
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
119
    def test_too_many_concurrent_requests(self):
120
        error = errors.TooManyConcurrentRequests("a medium")
121
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
122
            "request limit. Be sure to finish_writing and finish_reading on "
2018.5.134 by Andrew Bennetts
Fix the TooManyConcurrentRequests error message.
123
            "the currently open request.",
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
124
            str(error))
125
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
126
    def test_unknown_hook(self):
127
        error = errors.UnknownHook("branch", "foo")
128
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
129
            " of bzrlib.",
130
            str(error))
131
        error = errors.UnknownHook("tree", "bar")
132
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
133
            " of bzrlib.",
134
            str(error))
135
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
136
    def test_up_to_date(self):
137
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
138
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
139
                             "format 0.0.4 is already at the most "
140
                             "recent format.",
141
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
142
143
    def test_corrupt_repository(self):
144
        repo = self.make_repository('.')
145
        error = errors.CorruptRepository(repo)
146
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
147
                             "Please run bzr reconcile on this repository." %
148
                             repo.bzrdir.root_transport.base,
149
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
150
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
151
    def test_bzrnewerror_is_deprecated(self):
152
        class DeprecatedError(errors.BzrNewError):
153
            pass
2067.3.6 by Martin Pool
Update deprecation version
154
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
155
             'please convert DeprecatedError to use BzrError instead'],
156
            DeprecatedError)
157
158
    def test_bzrerror_from_literal_string(self):
159
        # Some code constructs BzrError from a literal string, in which case
160
        # no further formatting is done.  (I'm not sure raising the base class
161
        # is a great idea, but if the exception is not intended to be caught
162
        # perhaps no more is needed.)
163
        try:
164
            raise errors.BzrError('this is my errors; %d is not expanded')
165
        except errors.BzrError, e:
166
            self.assertEqual('this is my errors; %d is not expanded', str(e))
167
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
168
    def test_reading_completed(self):
169
        error = errors.ReadingCompleted("a request")
170
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
171
            "finish_reading called upon it - the request has been completed and"
172
            " no more data may be read.",
173
            str(error))
174
175
    def test_writing_completed(self):
176
        error = errors.WritingCompleted("a request")
177
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
178
            "finish_writing called upon it - accept bytes may not be called "
179
            "anymore.",
180
            str(error))
181
182
    def test_writing_not_completed(self):
183
        error = errors.WritingNotComplete("a request")
184
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
185
            "finish_writing called upon it - until the write phase is complete"
186
            " no data may be read.",
187
            str(error))
188
2045.1.3 by John Arbash Meinel
Lukáš Lalinský: TransportNotPossible has a bad docstring
189
    def test_transport_not_possible(self):
190
        e = errors.TransportNotPossible('readonly', 'original error')
191
        self.assertEqual('Transport operation not possible:'
192
                         ' readonly original error', str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
193
194
    def assertSocketConnectionError(self, expected, *args, **kwargs):
195
        """Check the formatting of a SocketConnectionError exception"""
196
        e = errors.SocketConnectionError(*args, **kwargs)
197
        self.assertEqual(expected, str(e))
198
199
    def test_socket_connection_error(self):
200
        """Test the formatting of SocketConnectionError"""
201
202
        # There should be a default msg about failing to connect
203
        # we only require a host name.
204
        self.assertSocketConnectionError(
205
            'Failed to connect to ahost',
206
            'ahost')
207
208
        # If port is None, we don't put :None
209
        self.assertSocketConnectionError(
210
            'Failed to connect to ahost',
211
            'ahost', port=None)
212
        # But if port is supplied we include it
213
        self.assertSocketConnectionError(
214
            'Failed to connect to ahost:22',
215
            'ahost', port=22)
216
217
        # We can also supply extra information about the error
218
        # with or without a port
219
        self.assertSocketConnectionError(
220
            'Failed to connect to ahost:22; bogus error',
221
            'ahost', port=22, orig_error='bogus error')
222
        self.assertSocketConnectionError(
223
            'Failed to connect to ahost; bogus error',
224
            'ahost', orig_error='bogus error')
225
        # An exception object can be passed rather than a string
226
        orig_error = ValueError('bad value')
227
        self.assertSocketConnectionError(
228
            'Failed to connect to ahost; %s' % (str(orig_error),),
229
            host='ahost', orig_error=orig_error)
230
231
        # And we can supply a custom failure message
232
        self.assertSocketConnectionError(
233
            'Unable to connect to ssh host ahost:444; my_error',
234
            host='ahost', port=444, msg='Unable to connect to ssh host',
235
            orig_error='my_error')
236
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
237
    def test_unexpected_smart_server_response(self):
238
        e = errors.UnexpectedSmartServerResponse(('not yes',))
239
        self.assertEqual(
240
            "Could not understand response from smart server: ('not yes',)",
241
            str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
242
2116.3.1 by John Arbash Meinel
Cleanup error tests
243
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
244
class PassThroughError(errors.BzrError):
245
    
246
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
247
248
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
249
        errors.BzrError.__init__(self, foo=foo, bar=bar)
250
251
252
class ErrorWithBadFormat(errors.BzrError):
253
254
    _fmt = """One format specifier: %(thing)s"""
255
256
257
class ErrorWithNoFormat(errors.BzrError):
258
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
259
260
261
class TestErrorFormatting(TestCase):
262
    
263
    def test_always_str(self):
264
        e = PassThroughError(u'\xb5', 'bar')
265
        self.assertIsInstance(e.__str__(), str)
266
        # In Python str(foo) *must* return a real byte string
267
        # not a Unicode string. The following line would raise a
268
        # Unicode error, because it tries to call str() on the string
269
        # returned from e.__str__(), and it has non ascii characters
270
        s = str(e)
271
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
272
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
273
    def test_missing_format_string(self):
274
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
275
        s = self.callDeprecated(
276
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
277
                lambda x: str(x), e)
278
        ## s = str(e)
279
        self.assertEqual(s, 
280
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
281
2116.3.1 by John Arbash Meinel
Cleanup error tests
282
    def test_mismatched_format_args(self):
283
        # Even though ErrorWithBadFormat's format string does not match the
284
        # arguments we constructing it with, we can still stringify an instance
285
        # of this exception. The resulting string will say its unprintable.
286
        e = ErrorWithBadFormat(not_thing='x')
287
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
288
            str(e), 'Unprintable exception ErrorWithBadFormat')
2116.3.1 by John Arbash Meinel
Cleanup error tests
289