/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
2018.18.22 by Martin Pool
merge bzr.dev
1
# Copyright (C) 2006, 2007 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
2018.18.22 by Martin Pool
merge bzr.dev
3
#            and others
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
4
#
5
# This program is free software; you can redistribute it and/or modify
6
# it under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 2 of the License, or
8
# (at your option) any later version.
9
#
10
# This program is distributed in the hope that it will be useful,
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with this program; if not, write to the Free Software
17
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
19
"""Tests for the formatting and construction of errors."""
20
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
21
from bzrlib import (
22
    bzrdir,
23
    errors,
24
    )
25
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
26
27
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
28
# TODO: Make sure builtin exception class formats are consistent - e.g. should
29
# or shouldn't end with a full stop, etc.
30
31
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
32
class TestErrors(TestCaseWithTransport):
33
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
34
    def test_disabled_method(self):
35
        error = errors.DisabledMethod("class name")
36
        self.assertEqualDiff(
37
            "The smart server method 'class name' is disabled.", str(error))
38
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
39
    def test_duplicate_file_id(self):
40
        error = errors.DuplicateFileId('a_file_id', 'foo')
41
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
42
                             ' as foo', str(error))
43
2432.1.19 by Robert Collins
Ensure each HelpIndex has a unique prefix.
44
    def test_duplicate_help_prefix(self):
45
        error = errors.DuplicateHelpPrefix('foo')
46
        self.assertEqualDiff('The prefix foo is in the help search path twice.',
47
            str(error))
48
2550.2.3 by Robert Collins
Add require_api API.
49
    def test_incompatibleAPI(self):
50
        error = errors.IncompatibleAPI("module", (1, 2, 3), (4, 5, 6), (7, 8, 9))
51
        self.assertEqualDiff(
52
            'The API for "module" is not compatible with "(1, 2, 3)". '
53
            'It supports versions "(4, 5, 6)" to "(7, 8, 9)".',
54
            str(error))
55
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
56
    def test_inventory_modified(self):
57
        error = errors.InventoryModified("a tree to be repred")
58
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
59
            "be repred' has been modified, so a clean inventory cannot be "
60
            "read without data loss.",
61
            str(error))
62
2116.3.1 by John Arbash Meinel
Cleanup error tests
63
    def test_install_failed(self):
64
        error = errors.InstallFailed(['rev-one'])
65
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
66
        error = errors.InstallFailed(['rev-one', 'rev-two'])
67
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
68
                         str(error))
69
        error = errors.InstallFailed([None])
70
        self.assertEqual("Could not install revisions:\nNone", str(error))
71
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
72
    def test_lock_active(self):
73
        error = errors.LockActive("lock description")
74
        self.assertEqualDiff("The lock for 'lock description' is in use and "
75
            "cannot be broken.",
76
            str(error))
77
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
78
    def test_knit_header_error(self):
79
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
80
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
81
                         " for file path/to/file", str(error))
82
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
83
    def test_knit_index_unknown_method(self):
84
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
85
                                              ['bad', 'no-eol'])
86
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
87
                         " known method in options: ['bad', 'no-eol']",
88
                         str(error))
89
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
90
    def test_medium_not_connected(self):
91
        error = errors.MediumNotConnected("a medium")
92
        self.assertEqualDiff(
93
            "The medium 'a medium' is not connected.", str(error))
94
        
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
95
    def test_no_repo(self):
96
        dir = bzrdir.BzrDir.create(self.get_url())
97
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
98
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
99
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
100
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
101
    def test_no_smart_medium(self):
102
        error = errors.NoSmartMedium("a transport")
103
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
104
            "smart protocol.",
105
            str(error))
106
2432.1.4 by Robert Collins
Add an explicit error for missing help topics.
107
    def test_no_help_topic(self):
108
        error = errors.NoHelpTopic("topic")
109
        self.assertEqualDiff("No help could be found for 'topic'. "
110
            "Please use 'bzr help topics' to obtain a list of topics.",
111
            str(error))
112
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
113
    def test_no_such_id(self):
114
        error = errors.NoSuchId("atree", "anid")
115
        self.assertEqualDiff("The file id anid is not present in the tree "
116
            "atree.",
117
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
118
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
119
    def test_no_such_revision_in_tree(self):
120
        error = errors.NoSuchRevisionInTree("atree", "anid")
121
        self.assertEqualDiff("The revision id anid is not present in the tree "
122
            "atree.",
123
            str(error))
124
        self.assertIsInstance(error, errors.NoSuchRevision)
125
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
126
    def test_not_write_locked(self):
127
        error = errors.NotWriteLocked('a thing to repr')
128
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
129
            "to be.",
130
            str(error))
131
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
132
    def test_read_only_lock_error(self):
133
        error = errors.ReadOnlyLockError('filename', 'error message')
134
        self.assertEqualDiff("Cannot acquire write lock on filename."
135
                             " error message", str(error))
136
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
137
    def test_too_many_concurrent_requests(self):
138
        error = errors.TooManyConcurrentRequests("a medium")
139
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
140
            "request limit. Be sure to finish_writing and finish_reading on "
2018.5.134 by Andrew Bennetts
Fix the TooManyConcurrentRequests error message.
141
            "the currently open request.",
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
142
            str(error))
143
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
144
    def test_unknown_hook(self):
145
        error = errors.UnknownHook("branch", "foo")
146
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
147
            " of bzrlib.",
148
            str(error))
149
        error = errors.UnknownHook("tree", "bar")
150
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
151
            " of bzrlib.",
152
            str(error))
153
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
154
    def test_up_to_date(self):
155
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
156
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
157
                             "format 0.0.4 is already at the most "
158
                             "recent format.",
159
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
160
161
    def test_corrupt_repository(self):
162
        repo = self.make_repository('.')
163
        error = errors.CorruptRepository(repo)
164
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
165
                             "Please run bzr reconcile on this repository." %
166
                             repo.bzrdir.root_transport.base,
167
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
168
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
169
    def test_read_error(self):
170
        # a unicode path to check that %r is being used.
171
        path = u'a path'
172
        error = errors.ReadError(path)
173
        self.assertEqualDiff("Error reading from u'a path'.", str(error))
174
2592.1.7 by Robert Collins
A validate that goes boom.
175
    def test_bad_index_format_signature(self):
176
        error = errors.BadIndexFormatSignature("foo", "bar")
177
        self.assertEqual("foo is not an index of type bar.",
178
            str(error))
2052.6.2 by Robert Collins
Merge bzr.dev.
179
2592.1.11 by Robert Collins
Detect truncated indices.
180
    def test_bad_index_data(self):
181
        error = errors.BadIndexData("foo")
182
        self.assertEqual("Error in data for index foo.",
183
            str(error))
184
2592.1.15 by Robert Collins
Detect duplicate key insertion.
185
    def test_bad_index_duplicate_key(self):
186
        error = errors.BadIndexDuplicateKey("foo", "bar")
187
        self.assertEqual("The key 'foo' is already in index 'bar'.",
188
            str(error))
189
2592.1.12 by Robert Collins
Handle basic node adds.
190
    def test_bad_index_key(self):
191
        error = errors.BadIndexKey("foo")
192
        self.assertEqual("The key 'foo' is not a valid key.",
193
            str(error))
194
2592.1.10 by Robert Collins
Make validate detect node reference parsing errors.
195
    def test_bad_index_options(self):
196
        error = errors.BadIndexOptions("foo")
197
        self.assertEqual("Could not parse options for index foo.",
198
            str(error))
199
2592.1.12 by Robert Collins
Handle basic node adds.
200
    def test_bad_index_value(self):
201
        error = errors.BadIndexValue("foo")
202
        self.assertEqual("The value 'foo' is not a valid value.",
203
            str(error))
204
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
205
    def test_bzrnewerror_is_deprecated(self):
206
        class DeprecatedError(errors.BzrNewError):
207
            pass
2067.3.6 by Martin Pool
Update deprecation version
208
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
209
             'please convert DeprecatedError to use BzrError instead'],
210
            DeprecatedError)
211
212
    def test_bzrerror_from_literal_string(self):
213
        # Some code constructs BzrError from a literal string, in which case
214
        # no further formatting is done.  (I'm not sure raising the base class
215
        # is a great idea, but if the exception is not intended to be caught
216
        # perhaps no more is needed.)
217
        try:
218
            raise errors.BzrError('this is my errors; %d is not expanded')
219
        except errors.BzrError, e:
220
            self.assertEqual('this is my errors; %d is not expanded', str(e))
221
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
222
    def test_reading_completed(self):
223
        error = errors.ReadingCompleted("a request")
224
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
225
            "finish_reading called upon it - the request has been completed and"
226
            " no more data may be read.",
227
            str(error))
228
229
    def test_writing_completed(self):
230
        error = errors.WritingCompleted("a request")
231
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
232
            "finish_writing called upon it - accept bytes may not be called "
233
            "anymore.",
234
            str(error))
235
236
    def test_writing_not_completed(self):
237
        error = errors.WritingNotComplete("a request")
238
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
239
            "finish_writing called upon it - until the write phase is complete"
240
            " no data may be read.",
241
            str(error))
242
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
243
    def test_transport_not_possible(self):
244
        error = errors.TransportNotPossible('readonly', 'original error')
245
        self.assertEqualDiff('Transport operation not possible:'
246
                         ' readonly original error', str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
247
248
    def assertSocketConnectionError(self, expected, *args, **kwargs):
249
        """Check the formatting of a SocketConnectionError exception"""
250
        e = errors.SocketConnectionError(*args, **kwargs)
251
        self.assertEqual(expected, str(e))
252
253
    def test_socket_connection_error(self):
254
        """Test the formatting of SocketConnectionError"""
255
256
        # There should be a default msg about failing to connect
257
        # we only require a host name.
258
        self.assertSocketConnectionError(
259
            'Failed to connect to ahost',
260
            'ahost')
261
262
        # If port is None, we don't put :None
263
        self.assertSocketConnectionError(
264
            'Failed to connect to ahost',
265
            'ahost', port=None)
266
        # But if port is supplied we include it
267
        self.assertSocketConnectionError(
268
            'Failed to connect to ahost:22',
269
            'ahost', port=22)
270
271
        # We can also supply extra information about the error
272
        # with or without a port
273
        self.assertSocketConnectionError(
274
            'Failed to connect to ahost:22; bogus error',
275
            'ahost', port=22, orig_error='bogus error')
276
        self.assertSocketConnectionError(
277
            'Failed to connect to ahost; bogus error',
278
            'ahost', orig_error='bogus error')
279
        # An exception object can be passed rather than a string
280
        orig_error = ValueError('bad value')
281
        self.assertSocketConnectionError(
282
            'Failed to connect to ahost; %s' % (str(orig_error),),
283
            host='ahost', orig_error=orig_error)
284
285
        # And we can supply a custom failure message
286
        self.assertSocketConnectionError(
287
            'Unable to connect to ssh host ahost:444; my_error',
288
            host='ahost', port=444, msg='Unable to connect to ssh host',
289
            orig_error='my_error')
290
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
291
    def test_malformed_bug_identifier(self):
292
        """Test the formatting of MalformedBugIdentifier."""
293
        error = errors.MalformedBugIdentifier('bogus', 'reason for bogosity')
294
        self.assertEqual(
295
            "Did not understand bug identifier bogus: reason for bogosity",
296
            str(error))
297
298
    def test_unknown_bug_tracker_abbreviation(self):
299
        """Test the formatting of UnknownBugTrackerAbbreviation."""
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
300
        branch = self.make_branch('some_branch')
301
        error = errors.UnknownBugTrackerAbbreviation('xxx', branch)
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
302
        self.assertEqual(
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
303
            "Cannot find registered bug tracker called xxx on %s" % branch,
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
304
            str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
305
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
306
    def test_unexpected_smart_server_response(self):
307
        e = errors.UnexpectedSmartServerResponse(('not yes',))
308
        self.assertEqual(
309
            "Could not understand response from smart server: ('not yes',)",
310
            str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
311
2506.2.1 by Andrew Bennetts
Start implementing container format reading and writing.
312
    def test_unknown_container_format(self):
313
        """Test the formatting of UnknownContainerFormatError."""
314
        e = errors.UnknownContainerFormatError('bad format string')
315
        self.assertEqual(
316
            "Unrecognised container format: 'bad format string'",
317
            str(e))
318
319
    def test_unexpected_end_of_container(self):
320
        """Test the formatting of UnexpectedEndOfContainerError."""
321
        e = errors.UnexpectedEndOfContainerError()
322
        self.assertEqual(
323
            "Unexpected end of container stream", str(e))
324
325
    def test_unknown_record_type(self):
326
        """Test the formatting of UnknownRecordTypeError."""
327
        e = errors.UnknownRecordTypeError("X")
328
        self.assertEqual(
329
            "Unknown record type: 'X'",
330
            str(e))
331
2506.3.1 by Andrew Bennetts
More progress:
332
    def test_invalid_record(self):
333
        """Test the formatting of InvalidRecordError."""
334
        e = errors.InvalidRecordError("xxx")
335
        self.assertEqual(
336
            "Invalid record: xxx",
337
            str(e))
338
2506.2.6 by Andrew Bennetts
Add validate method to ContainerReader and BytesRecordReader.
339
    def test_container_has_excess_data(self):
340
        """Test the formatting of ContainerHasExcessDataError."""
341
        e = errors.ContainerHasExcessDataError("excess bytes")
342
        self.assertEqual(
343
            "Container has data after end marker: 'excess bytes'",
344
            str(e))
345
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
346
    def test_duplicate_record_name_error(self):
347
        """Test the formatting of DuplicateRecordNameError."""
348
        e = errors.DuplicateRecordNameError(u"n\xe5me".encode('utf-8'))
349
        self.assertEqual(
350
            "Container has multiple records with the same name: \"n\xc3\xa5me\"",
351
            str(e))
352
2116.3.1 by John Arbash Meinel
Cleanup error tests
353
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
354
class PassThroughError(errors.BzrError):
355
    
356
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
357
358
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
359
        errors.BzrError.__init__(self, foo=foo, bar=bar)
360
361
362
class ErrorWithBadFormat(errors.BzrError):
363
364
    _fmt = """One format specifier: %(thing)s"""
365
366
367
class ErrorWithNoFormat(errors.BzrError):
368
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
369
370
371
class TestErrorFormatting(TestCase):
372
    
373
    def test_always_str(self):
374
        e = PassThroughError(u'\xb5', 'bar')
375
        self.assertIsInstance(e.__str__(), str)
376
        # In Python str(foo) *must* return a real byte string
377
        # not a Unicode string. The following line would raise a
378
        # Unicode error, because it tries to call str() on the string
379
        # returned from e.__str__(), and it has non ascii characters
380
        s = str(e)
381
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
382
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
383
    def test_missing_format_string(self):
384
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
385
        s = self.callDeprecated(
386
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
387
                lambda x: str(x), e)
388
        ## s = str(e)
389
        self.assertEqual(s, 
390
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
391
2116.3.1 by John Arbash Meinel
Cleanup error tests
392
    def test_mismatched_format_args(self):
393
        # Even though ErrorWithBadFormat's format string does not match the
394
        # arguments we constructing it with, we can still stringify an instance
395
        # of this exception. The resulting string will say its unprintable.
396
        e = ErrorWithBadFormat(not_thing='x')
397
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
398
            str(e), 'Unprintable exception ErrorWithBadFormat')