/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
3221.1.3 by Martin Pool
Review cleanups for CorruptDirstate: use the path everywhere rather than the object, and use more standard phrasing.
1
# Copyright (C) 2006, 2007, 2008 Canonical Ltd
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
2
#   Authors: Robert Collins <robert.collins@canonical.com>
2018.18.22 by Martin Pool
merge bzr.dev
3
#            and others
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
4
#
5
# This program is free software; you can redistribute it and/or modify
6
# it under the terms of the GNU General Public License as published by
7
# the Free Software Foundation; either version 2 of the License, or
8
# (at your option) any later version.
9
#
10
# This program is distributed in the hope that it will be useful,
11
# but WITHOUT ANY WARRANTY; without even the implied warranty of
12
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
13
# GNU General Public License for more details.
14
#
15
# You should have received a copy of the GNU General Public License
16
# along with this program; if not, write to the Free Software
17
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
18
19
"""Tests for the formatting and construction of errors."""
20
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
21
from bzrlib import (
22
    bzrdir,
23
    errors,
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
24
    symbol_versioning,
3200.2.1 by Robert Collins
* The ``register-branch`` command will now use the public url of the branch
25
    urlutils,
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
26
    )
27
from bzrlib.tests import TestCase, TestCaseWithTransport
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
28
29
30
class TestErrors(TestCaseWithTransport):
31
3207.2.1 by jameinel
Add a test that _iter_changes raises a clearer error when we encounter an invalid rename.
32
    def test_corrupt_dirstate(self):
33
        error = errors.CorruptDirstate('path/to/dirstate', 'the reason why')
3221.1.3 by Martin Pool
Review cleanups for CorruptDirstate: use the path everywhere rather than the object, and use more standard phrasing.
34
        self.assertEqualDiff(
35
            "Inconsistency in dirstate file path/to/dirstate.\n"
36
            "Error: the reason why",
37
            str(error))
3207.2.1 by jameinel
Add a test that _iter_changes raises a clearer error when we encounter an invalid rename.
38
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
39
    def test_disabled_method(self):
40
        error = errors.DisabledMethod("class name")
41
        self.assertEqualDiff(
42
            "The smart server method 'class name' is disabled.", str(error))
43
2255.7.16 by John Arbash Meinel
Make sure adding a duplicate file_id raises DuplicateFileId.
44
    def test_duplicate_file_id(self):
45
        error = errors.DuplicateFileId('a_file_id', 'foo')
46
        self.assertEqualDiff('File id {a_file_id} already exists in inventory'
47
                             ' as foo', str(error))
48
2432.1.19 by Robert Collins
Ensure each HelpIndex has a unique prefix.
49
    def test_duplicate_help_prefix(self):
50
        error = errors.DuplicateHelpPrefix('foo')
51
        self.assertEqualDiff('The prefix foo is in the help search path twice.',
52
            str(error))
53
2550.2.3 by Robert Collins
Add require_api API.
54
    def test_incompatibleAPI(self):
55
        error = errors.IncompatibleAPI("module", (1, 2, 3), (4, 5, 6), (7, 8, 9))
56
        self.assertEqualDiff(
57
            'The API for "module" is not compatible with "(1, 2, 3)". '
58
            'It supports versions "(4, 5, 6)" to "(7, 8, 9)".',
59
            str(error))
60
3207.2.2 by John Arbash Meinel
Fix bug #187169, when an invalid delta is supplied to update_basis_by_delta
61
    def test_inconsistent_delta(self):
62
        error = errors.InconsistentDelta('path', 'file-id', 'reason for foo')
63
        self.assertEqualDiff(
3221.1.8 by Martin Pool
Update error format in test_inconsistent_delta
64
            "An inconsistent delta was supplied involving 'path', 'file-id'\n"
3207.2.2 by John Arbash Meinel
Fix bug #187169, when an invalid delta is supplied to update_basis_by_delta
65
            "reason: reason for foo",
66
            str(error))
67
2634.1.1 by Robert Collins
(robertc) Reinstate the accidentally backed out external_url patch.
68
    def test_in_process_transport(self):
69
        error = errors.InProcessTransport('fpp')
70
        self.assertEqualDiff(
71
            "The transport 'fpp' is only accessible within this process.",
72
            str(error))
73
3059.2.12 by Vincent Ladeuil
Spiv review feedback.
74
    def test_invalid_http_range(self):
75
        error = errors.InvalidHttpRange('path',
76
                                        'Content-Range: potatoes 0-00/o0oo0',
77
                                        'bad range')
78
        self.assertEquals("Invalid http range"
79
                          " 'Content-Range: potatoes 0-00/o0oo0'"
80
                          " for path: bad range",
81
                          str(error))
82
83
    def test_invalid_range(self):
84
        error = errors.InvalidRange('path', 12, 'bad range')
85
        self.assertEquals("Invalid range access in path at 12: bad range",
86
                          str(error))
87
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
88
    def test_inventory_modified(self):
89
        error = errors.InventoryModified("a tree to be repred")
90
        self.assertEqualDiff("The current inventory for the tree 'a tree to "
91
            "be repred' has been modified, so a clean inventory cannot be "
92
            "read without data loss.",
93
            str(error))
94
2116.3.1 by John Arbash Meinel
Cleanup error tests
95
    def test_install_failed(self):
96
        error = errors.InstallFailed(['rev-one'])
97
        self.assertEqual("Could not install revisions:\nrev-one", str(error))
98
        error = errors.InstallFailed(['rev-one', 'rev-two'])
99
        self.assertEqual("Could not install revisions:\nrev-one, rev-two",
100
                         str(error))
101
        error = errors.InstallFailed([None])
102
        self.assertEqual("Could not install revisions:\nNone", str(error))
103
2255.2.145 by Robert Collins
Support unbreakable locks for trees.
104
    def test_lock_active(self):
105
        error = errors.LockActive("lock description")
106
        self.assertEqualDiff("The lock for 'lock description' is in use and "
107
            "cannot be broken.",
108
            str(error))
109
2535.3.4 by Andrew Bennetts
Simple implementation of Knit.insert_data_stream.
110
    def test_knit_data_stream_incompatible(self):
111
        error = errors.KnitDataStreamIncompatible(
112
            'stream format', 'target format')
113
        self.assertEqual('Cannot insert knit data stream of format '
114
                         '"stream format" into knit of format '
115
                         '"target format".', str(error))
116
3052.2.1 by Robert Collins
Add a new KnitDataStreamUnknown error class for showing formats we can't understand.
117
    def test_knit_data_stream_unknown(self):
118
        error = errors.KnitDataStreamUnknown(
119
            'stream format')
120
        self.assertEqual('Cannot parse knit data stream of format '
121
                         '"stream format".', str(error))
122
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
123
    def test_knit_header_error(self):
124
        error = errors.KnitHeaderError('line foo\n', 'path/to/file')
125
        self.assertEqual("Knit header error: 'line foo\\n' unexpected"
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
126
                         " for file \"path/to/file\".", str(error))
2171.1.1 by John Arbash Meinel
Knit index files should ignore empty indexes rather than consider them corrupt.
127
2196.2.5 by John Arbash Meinel
Add an exception class when the knit index storage method is unknown, and properly test for it
128
    def test_knit_index_unknown_method(self):
129
        error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
130
                                              ['bad', 'no-eol'])
131
        self.assertEqual("Knit index http://host/foo.kndx does not have a"
132
                         " known method in options: ['bad', 'no-eol']",
133
                         str(error))
134
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
135
    def test_medium_not_connected(self):
136
        error = errors.MediumNotConnected("a medium")
137
        self.assertEqualDiff(
138
            "The medium 'a medium' is not connected.", str(error))
3200.2.1 by Robert Collins
* The ``register-branch`` command will now use the public url of the branch
139
 
140
    def test_no_public_branch(self):
141
        b = self.make_branch('.')
142
        error = errors.NoPublicBranch(b)
143
        url = urlutils.unescape_for_display(b.base, 'ascii')
144
        self.assertEqualDiff(
145
            'There is no public branch set for "%s".' % url, str(error))
146
1534.4.50 by Robert Collins
Got the bzrdir api straightened out, plenty of refactoring to use it pending, but the api is up and running.
147
    def test_no_repo(self):
148
        dir = bzrdir.BzrDir.create(self.get_url())
149
        error = errors.NoRepositoryPresent(dir)
1740.5.6 by Martin Pool
Clean up many exception classes.
150
        self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
151
        self.assertEqual(-1, str(error).find((dir.transport.base)))
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
152
        
2018.2.3 by Andrew Bennetts
Starting factoring out the smart server client "medium" from the protocol.
153
    def test_no_smart_medium(self):
154
        error = errors.NoSmartMedium("a transport")
155
        self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
156
            "smart protocol.",
157
            str(error))
158
2432.1.4 by Robert Collins
Add an explicit error for missing help topics.
159
    def test_no_help_topic(self):
160
        error = errors.NoHelpTopic("topic")
161
        self.assertEqualDiff("No help could be found for 'topic'. "
162
            "Please use 'bzr help topics' to obtain a list of topics.",
163
            str(error))
164
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
165
    def test_no_such_id(self):
166
        error = errors.NoSuchId("atree", "anid")
2745.3.2 by Daniel Watkins
Updated tests to reflect new error text.
167
        self.assertEqualDiff("The file id \"anid\" is not present in the tree "
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
168
            "atree.",
1988.2.1 by Robert Collins
WorkingTree has a new api ``unversion`` which allow the unversioning of
169
            str(error))
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
170
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
171
    def test_no_such_revision_in_tree(self):
172
        error = errors.NoSuchRevisionInTree("atree", "anid")
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
173
        self.assertEqualDiff("The revision id {anid} is not present in the"
174
                             " tree atree.", str(error))
1908.11.1 by Robert Collins
Add a new method ``Tree.revision_tree`` which allows access to cached
175
        self.assertIsInstance(error, errors.NoSuchRevision)
176
3221.11.2 by Robert Collins
Create basic stackable branch facility.
177
    def test_not_stacked(self):
178
        error = errors.NotStacked('a branch')
179
        self.assertEqualDiff("The branch 'a branch' is not stacked.",
180
            str(error))
181
1986.5.3 by Robert Collins
New method ``WorkingTree.flush()`` which will write the current memory
182
    def test_not_write_locked(self):
183
        error = errors.NotWriteLocked('a thing to repr')
184
        self.assertEqualDiff("'a thing to repr' is not write locked but needs "
185
            "to be.",
186
            str(error))
187
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
188
    def test_read_only_lock_error(self):
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
189
        error = self.applyDeprecated(symbol_versioning.zero_ninetytwo,
190
            errors.ReadOnlyLockError, 'filename', 'error message')
2353.3.10 by John Arbash Meinel
Cleanup errors, and change ReadOnlyLockError to pass around more details.
191
        self.assertEqualDiff("Cannot acquire write lock on filename."
192
                             " error message", str(error))
193
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
194
    def test_lock_failed(self):
195
        error = errors.LockFailed('http://canonical.com/', 'readonly transport')
196
        self.assertEqualDiff("Cannot lock http://canonical.com/: readonly transport",
197
            str(error))
198
        self.assertFalse(error.internal_error)
199
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
200
    def test_too_many_concurrent_requests(self):
201
        error = errors.TooManyConcurrentRequests("a medium")
202
        self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
203
            "request limit. Be sure to finish_writing and finish_reading on "
2018.5.134 by Andrew Bennetts
Fix the TooManyConcurrentRequests error message.
204
            "the currently open request.",
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
205
            str(error))
206
2245.1.3 by Robert Collins
Add install_hook to the BranchHooks class as the official means for installing a hook.
207
    def test_unknown_hook(self):
208
        error = errors.UnknownHook("branch", "foo")
209
        self.assertEqualDiff("The branch hook 'foo' is unknown in this version"
210
            " of bzrlib.",
211
            str(error))
212
        error = errors.UnknownHook("tree", "bar")
213
        self.assertEqualDiff("The tree hook 'bar' is unknown in this version"
214
            " of bzrlib.",
215
            str(error))
216
3221.11.2 by Robert Collins
Create basic stackable branch facility.
217
    def test_unstackable_branch_format(self):
218
        format = u'foo'
219
        url = "/foo"
220
        error = errors.UnstackableBranchFormat(format, url)
221
        self.assertEqualDiff(
222
            "The branch '/foo'(foo) is not a stackable format. "
223
            "You will need to upgrade the branch to permit branch stacking.",
224
            str(error))
225
226
    def test_unstackable_repository_format(self):
227
        format = u'foo'
228
        url = "/foo"
229
        error = errors.UnstackableRepositoryFormat(format, url)
230
        self.assertEqualDiff(
231
            "The repository '/foo'(foo) is not a stackable format. "
232
            "You will need to upgrade the repository to permit branch stacking.",
233
            str(error))
234
1534.5.7 by Robert Collins
Start factoring out the upgrade policy logic.
235
    def test_up_to_date(self):
236
        error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
1534.5.9 by Robert Collins
Advise users running upgrade on a checkout to also run it on the branch.
237
        self.assertEqualDiff("The branch format Bazaar-NG branch, "
238
                             "format 0.0.4 is already at the most "
239
                             "recent format.",
240
                             str(error))
1570.1.13 by Robert Collins
Check for incorrect revision parentage in the weave during revision access.
241
242
    def test_corrupt_repository(self):
243
        repo = self.make_repository('.')
244
        error = errors.CorruptRepository(repo)
245
        self.assertEqualDiff("An error has been detected in the repository %s.\n"
246
                             "Please run bzr reconcile on this repository." %
247
                             repo.bzrdir.root_transport.base,
248
                             str(error))
1948.1.6 by John Arbash Meinel
Make BzrNewError always return a str object
249
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
250
    def test_read_error(self):
251
        # a unicode path to check that %r is being used.
252
        path = u'a path'
253
        error = errors.ReadError(path)
254
        self.assertEqualDiff("Error reading from u'a path'.", str(error))
255
2592.1.7 by Robert Collins
A validate that goes boom.
256
    def test_bad_index_format_signature(self):
257
        error = errors.BadIndexFormatSignature("foo", "bar")
258
        self.assertEqual("foo is not an index of type bar.",
259
            str(error))
2052.6.2 by Robert Collins
Merge bzr.dev.
260
2592.1.11 by Robert Collins
Detect truncated indices.
261
    def test_bad_index_data(self):
262
        error = errors.BadIndexData("foo")
263
        self.assertEqual("Error in data for index foo.",
264
            str(error))
265
2592.1.15 by Robert Collins
Detect duplicate key insertion.
266
    def test_bad_index_duplicate_key(self):
267
        error = errors.BadIndexDuplicateKey("foo", "bar")
268
        self.assertEqual("The key 'foo' is already in index 'bar'.",
269
            str(error))
270
2592.1.12 by Robert Collins
Handle basic node adds.
271
    def test_bad_index_key(self):
272
        error = errors.BadIndexKey("foo")
273
        self.assertEqual("The key 'foo' is not a valid key.",
274
            str(error))
275
2592.1.10 by Robert Collins
Make validate detect node reference parsing errors.
276
    def test_bad_index_options(self):
277
        error = errors.BadIndexOptions("foo")
278
        self.assertEqual("Could not parse options for index foo.",
279
            str(error))
280
2592.1.12 by Robert Collins
Handle basic node adds.
281
    def test_bad_index_value(self):
282
        error = errors.BadIndexValue("foo")
283
        self.assertEqual("The value 'foo' is not a valid value.",
284
            str(error))
285
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
286
    def test_bzrnewerror_is_deprecated(self):
287
        class DeprecatedError(errors.BzrNewError):
288
            pass
2067.3.6 by Martin Pool
Update deprecation version
289
        self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
290
             'please convert DeprecatedError to use BzrError instead'],
291
            DeprecatedError)
292
293
    def test_bzrerror_from_literal_string(self):
294
        # Some code constructs BzrError from a literal string, in which case
295
        # no further formatting is done.  (I'm not sure raising the base class
296
        # is a great idea, but if the exception is not intended to be caught
297
        # perhaps no more is needed.)
298
        try:
299
            raise errors.BzrError('this is my errors; %d is not expanded')
300
        except errors.BzrError, e:
301
            self.assertEqual('this is my errors; %d is not expanded', str(e))
302
2018.2.4 by Robert Collins
separate out the client medium from the client encoding protocol for the smart server.
303
    def test_reading_completed(self):
304
        error = errors.ReadingCompleted("a request")
305
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
306
            "finish_reading called upon it - the request has been completed and"
307
            " no more data may be read.",
308
            str(error))
309
310
    def test_writing_completed(self):
311
        error = errors.WritingCompleted("a request")
312
        self.assertEqualDiff("The MediumRequest 'a request' has already had "
313
            "finish_writing called upon it - accept bytes may not be called "
314
            "anymore.",
315
            str(error))
316
317
    def test_writing_not_completed(self):
318
        error = errors.WritingNotComplete("a request")
319
        self.assertEqualDiff("The MediumRequest 'a request' has not has "
320
            "finish_writing called upon it - until the write phase is complete"
321
            " no data may be read.",
322
            str(error))
323
2052.6.1 by Robert Collins
``Transport.get`` has had its interface made more clear for ease of use.
324
    def test_transport_not_possible(self):
325
        error = errors.TransportNotPossible('readonly', 'original error')
326
        self.assertEqualDiff('Transport operation not possible:'
327
                         ' readonly original error', str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
328
329
    def assertSocketConnectionError(self, expected, *args, **kwargs):
330
        """Check the formatting of a SocketConnectionError exception"""
331
        e = errors.SocketConnectionError(*args, **kwargs)
332
        self.assertEqual(expected, str(e))
333
334
    def test_socket_connection_error(self):
335
        """Test the formatting of SocketConnectionError"""
336
337
        # There should be a default msg about failing to connect
338
        # we only require a host name.
339
        self.assertSocketConnectionError(
340
            'Failed to connect to ahost',
341
            'ahost')
342
343
        # If port is None, we don't put :None
344
        self.assertSocketConnectionError(
345
            'Failed to connect to ahost',
346
            'ahost', port=None)
347
        # But if port is supplied we include it
348
        self.assertSocketConnectionError(
349
            'Failed to connect to ahost:22',
350
            'ahost', port=22)
351
352
        # We can also supply extra information about the error
353
        # with or without a port
354
        self.assertSocketConnectionError(
355
            'Failed to connect to ahost:22; bogus error',
356
            'ahost', port=22, orig_error='bogus error')
357
        self.assertSocketConnectionError(
358
            'Failed to connect to ahost; bogus error',
359
            'ahost', orig_error='bogus error')
360
        # An exception object can be passed rather than a string
361
        orig_error = ValueError('bad value')
362
        self.assertSocketConnectionError(
363
            'Failed to connect to ahost; %s' % (str(orig_error),),
364
            host='ahost', orig_error=orig_error)
365
366
        # And we can supply a custom failure message
367
        self.assertSocketConnectionError(
368
            'Unable to connect to ssh host ahost:444; my_error',
369
            host='ahost', port=444, msg='Unable to connect to ssh host',
370
            orig_error='my_error')
371
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
372
    def test_malformed_bug_identifier(self):
373
        """Test the formatting of MalformedBugIdentifier."""
374
        error = errors.MalformedBugIdentifier('bogus', 'reason for bogosity')
375
        self.assertEqual(
376
            "Did not understand bug identifier bogus: reason for bogosity",
377
            str(error))
378
379
    def test_unknown_bug_tracker_abbreviation(self):
380
        """Test the formatting of UnknownBugTrackerAbbreviation."""
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
381
        branch = self.make_branch('some_branch')
382
        error = errors.UnknownBugTrackerAbbreviation('xxx', branch)
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
383
        self.assertEqual(
2376.4.27 by Jonathan Lange
Include branch information in UnknownBugTrackerAbbreviation
384
            "Cannot find registered bug tracker called xxx on %s" % branch,
2376.4.26 by Jonathan Lange
Tests for MalformedBugIdentifier and new error UnknownBugTrackerAbbreviation.
385
            str(error))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
386
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
387
    def test_unexpected_smart_server_response(self):
388
        e = errors.UnexpectedSmartServerResponse(('not yes',))
389
        self.assertEqual(
390
            "Could not understand response from smart server: ('not yes',)",
391
            str(e))
2052.4.4 by John Arbash Meinel
Create a SocketConnectionError to make creating nice errors easier
392
2506.2.1 by Andrew Bennetts
Start implementing container format reading and writing.
393
    def test_unknown_container_format(self):
394
        """Test the formatting of UnknownContainerFormatError."""
395
        e = errors.UnknownContainerFormatError('bad format string')
396
        self.assertEqual(
397
            "Unrecognised container format: 'bad format string'",
398
            str(e))
399
400
    def test_unexpected_end_of_container(self):
401
        """Test the formatting of UnexpectedEndOfContainerError."""
402
        e = errors.UnexpectedEndOfContainerError()
403
        self.assertEqual(
404
            "Unexpected end of container stream", str(e))
405
406
    def test_unknown_record_type(self):
407
        """Test the formatting of UnknownRecordTypeError."""
408
        e = errors.UnknownRecordTypeError("X")
409
        self.assertEqual(
410
            "Unknown record type: 'X'",
411
            str(e))
412
2506.3.1 by Andrew Bennetts
More progress:
413
    def test_invalid_record(self):
414
        """Test the formatting of InvalidRecordError."""
415
        e = errors.InvalidRecordError("xxx")
416
        self.assertEqual(
417
            "Invalid record: xxx",
418
            str(e))
419
2506.2.6 by Andrew Bennetts
Add validate method to ContainerReader and BytesRecordReader.
420
    def test_container_has_excess_data(self):
421
        """Test the formatting of ContainerHasExcessDataError."""
422
        e = errors.ContainerHasExcessDataError("excess bytes")
423
        self.assertEqual(
424
            "Container has data after end marker: 'excess bytes'",
425
            str(e))
426
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
427
    def test_duplicate_record_name_error(self):
428
        """Test the formatting of DuplicateRecordNameError."""
429
        e = errors.DuplicateRecordNameError(u"n\xe5me".encode('utf-8'))
430
        self.assertEqual(
2745.3.3 by Daniel Watkins
Changed to remove need for escaping of quotes.
431
            "Container has multiple records with the same name: n\xc3\xa5me",
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
432
            str(e))
2854.1.1 by Martin Pool
Fix "unprintable error" message for BzrCheckError and others
433
        
434
    def test_check_error(self):
435
        # This has a member called 'message', which is problematic in
436
        # python2.5 because that is a slot on the base Exception class
437
        e = errors.BzrCheckError('example check failure')
438
        self.assertEqual(
439
            "Internal check failed: example check failure",
440
            str(e))
441
        self.assertTrue(e.internal_error)
2506.6.1 by Andrew Bennetts
Return a callable instead of a str from read, and add more validation.
442
2535.3.40 by Andrew Bennetts
Tidy up more XXXs.
443
    def test_repository_data_stream_error(self):
444
        """Test the formatting of RepositoryDataStreamError."""
445
        e = errors.RepositoryDataStreamError(u"my reason")
446
        self.assertEqual(
447
            "Corrupt or incompatible data stream: my reason", str(e))
448
2978.2.1 by Alexander Belchenko
fix formatting of ImmortalPendingDeletion error message.
449
    def test_immortal_pending_deletion_message(self):
450
        err = errors.ImmortalPendingDeletion('foo')
451
        self.assertEquals(
452
            "Unable to delete transform temporary directory foo.  "
453
            "Please examine foo to see if it contains any files "
454
            "you wish to keep, and delete it when you are done.",
455
            str(err))
456
3006.2.2 by Alexander Belchenko
tests added.
457
    def test_unable_create_symlink(self):
458
        err = errors.UnableCreateSymlink()
459
        self.assertEquals(
460
            "Unable to create symlink on this platform",
461
            str(err))
462
        err = errors.UnableCreateSymlink(path=u'foo')
463
        self.assertEquals(
464
            "Unable to create symlink 'foo' on this platform",
465
            str(err))
466
        err = errors.UnableCreateSymlink(path=u'\xb5')
467
        self.assertEquals(
468
            "Unable to create symlink u'\\xb5' on this platform",
469
            str(err))
470
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
471
    def test_incorrect_url(self):
472
        err = errors.InvalidBugTrackerURL('foo', 'http://bug.com/')
473
        self.assertEquals(
474
            ("The URL for bug tracker \"foo\" doesn't contain {id}: "
475
             "http://bug.com/"),
476
            str(err))
477
2116.3.1 by John Arbash Meinel
Cleanup error tests
478
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
479
class PassThroughError(errors.BzrError):
480
    
481
    _fmt = """Pass through %(foo)s and %(bar)s"""
2116.3.1 by John Arbash Meinel
Cleanup error tests
482
483
    def __init__(self, foo, bar):
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
484
        errors.BzrError.__init__(self, foo=foo, bar=bar)
485
486
487
class ErrorWithBadFormat(errors.BzrError):
488
489
    _fmt = """One format specifier: %(thing)s"""
490
491
492
class ErrorWithNoFormat(errors.BzrError):
493
    """This class has a docstring but no format string."""
2116.3.1 by John Arbash Meinel
Cleanup error tests
494
495
496
class TestErrorFormatting(TestCase):
497
    
498
    def test_always_str(self):
499
        e = PassThroughError(u'\xb5', 'bar')
500
        self.assertIsInstance(e.__str__(), str)
501
        # In Python str(foo) *must* return a real byte string
502
        # not a Unicode string. The following line would raise a
503
        # Unicode error, because it tries to call str() on the string
504
        # returned from e.__str__(), and it has non ascii characters
505
        s = str(e)
506
        self.assertEqual('Pass through \xc2\xb5 and bar', s)
507
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
508
    def test_missing_format_string(self):
509
        e = ErrorWithNoFormat(param='randomvalue')
2067.3.3 by Martin Pool
merge bzr.dev and reconcile several changes, also some test fixes
510
        s = self.callDeprecated(
511
                ['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
512
                lambda x: str(x), e)
513
        ## s = str(e)
514
        self.assertEqual(s, 
515
                "This class has a docstring but no format string.")
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
516
2116.3.1 by John Arbash Meinel
Cleanup error tests
517
    def test_mismatched_format_args(self):
518
        # Even though ErrorWithBadFormat's format string does not match the
519
        # arguments we constructing it with, we can still stringify an instance
520
        # of this exception. The resulting string will say its unprintable.
521
        e = ErrorWithBadFormat(not_thing='x')
522
        self.assertStartsWith(
2067.3.1 by Martin Pool
Clean up BzrNewError, other exception classes and users.
523
            str(e), 'Unprintable exception ErrorWithBadFormat')