/brz/remove-bazaar

# Copyright (C) 2007 Canonical Ltd

#

# This program is free software; you can redistribute it and/or modify

# it under the terms of the GNU General Public License as published by

# the Free Software Foundation; either version 2 of the License, or

# (at your option) any later version.

#

# This program is distributed in the hope that it will be useful,

# but WITHOUT ANY WARRANTY; without even the implied warranty of

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

# GNU General Public License for more details.

#

# You should have received a copy of the GNU General Public License

# along with this program; if not, write to the Free Software

# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA

from bzrlib import (

    debug,

    errors,

    revision,

    symbol_versioning,

    trace,

    tsort,

    )

from bzrlib.deprecated_graph import (node_distances, select_farthest)

# DIAGRAM of terminology

#       A

#       /\

#      B  C

#      |  |\

#      D  E F

#      |\/| |

#      |/\|/

#      G  H

#

# In this diagram, relative to G and H:

# A, B, C, D, E are common ancestors.

# C, D and E are border ancestors, because each has a non-common descendant.

# D and E are least common ancestors because none of their descendants are

# common ancestors.

# C is not a least common ancestor because its descendant, E, is a common

# ancestor.

#

# The find_unique_lca algorithm will pick A in two steps:

# 1. find_lca('G', 'H') => ['D', 'E']

# 2. Since len(['D', 'E']) > 1, find_lca('D', 'E') => ['A']

class DictParentsProvider(object):

    """A parents provider for Graph objects."""

    def __init__(self, ancestry):

        self.ancestry = ancestry

    def __repr__(self):

        return 'DictParentsProvider(%r)' % self.ancestry

    def get_parent_map(self, keys):

        """See _StackedParentsProvider.get_parent_map"""

        ancestry = self.ancestry

        return dict((k, ancestry[k]) for k in keys if k in ancestry)

class _StackedParentsProvider(object):

    def __init__(self, parent_providers):

        self._parent_providers = parent_providers

    def __repr__(self):

        return "_StackedParentsProvider(%r)" % self._parent_providers

    def get_parent_map(self, keys):

        """Get a mapping of keys => parents

        A dictionary is returned with an entry for each key present in this

        source. If this source doesn't have information about a key, it should

        not include an entry.

        [NULL_REVISION] is used as the parent of the first user-committed

        revision.  Its parent list is empty.

        :param keys: An iterable returning keys to check (eg revision_ids)

        :return: A dictionary mapping each key to its parents

        """

        found = {}

        remaining = set(keys)

        for parents_provider in self._parent_providers:

            new_found = parents_provider.get_parent_map(remaining)

            found.update(new_found)

            remaining.difference_update(new_found)

            if not remaining:

                break

        return found

class CachingParentsProvider(object):

    """A parents provider which will cache the revision => parents in a dict.

    This is useful for providers that have an expensive lookup.

    """

    def __init__(self, parent_provider):

        self._real_provider = parent_provider

        # Theoretically we could use an LRUCache here

        self._cache = {}

    def __repr__(self):

        return "%s(%r)" % (self.__class__.__name__, self._real_provider)

    def get_parent_map(self, keys):

        """See _StackedParentsProvider.get_parent_map"""

        needed = set()

        # If the _real_provider doesn't have a key, we cache a value of None,

        # which we then later use to realize we cannot provide a value for that

        # key.

        parent_map = {}

        cache = self._cache

        for key in keys:

            if key in cache:

                value = cache[key]

                if value is not None:

                    parent_map[key] = value

            else:

                needed.add(key)

        if needed:

            new_parents = self._real_provider.get_parent_map(needed)

            cache.update(new_parents)

            parent_map.update(new_parents)

            needed.difference_update(new_parents)

            cache.update(dict.fromkeys(needed, None))

        return parent_map

class Graph(object):

    """Provide incremental access to revision graphs.

    This is the generic implementation; it is intended to be subclassed to

    specialize it for other repository types.

    """

    def __init__(self, parents_provider):

        """Construct a Graph that uses several graphs as its input

        This should not normally be invoked directly, because there may be

        specialized implementations for particular repository types.  See

        Repository.get_graph().

        :param parents_provider: An object providing a get_parent_map call

            conforming to the behavior of

            StackedParentsProvider.get_parent_map.

        """

        if getattr(parents_provider, 'get_parents', None) is not None:

            self.get_parents = parents_provider.get_parents

        if getattr(parents_provider, 'get_parent_map', None) is not None:

            self.get_parent_map = parents_provider.get_parent_map

        self._parents_provider = parents_provider

    def __repr__(self):

        return 'Graph(%r)' % self._parents_provider

    def find_lca(self, *revisions):

        """Determine the lowest common ancestors of the provided revisions

        A lowest common ancestor is a common ancestor none of whose

        descendants are common ancestors.  In graphs, unlike trees, there may

        be multiple lowest common ancestors.

        This algorithm has two phases.  Phase 1 identifies border ancestors,

        and phase 2 filters border ancestors to determine lowest common

        ancestors.

        In phase 1, border ancestors are identified, using a breadth-first

        search starting at the bottom of the graph.  Searches are stopped

        whenever a node or one of its descendants is determined to be common

        In phase 2, the border ancestors are filtered to find the least

        common ancestors.  This is done by searching the ancestries of each

        border ancestor.

        Phase 2 is perfomed on the principle that a border ancestor that is

        not an ancestor of any other border ancestor is a least common

        ancestor.

        Searches are stopped when they find a node that is determined to be a

        common ancestor of all border ancestors, because this shows that it

        cannot be a descendant of any border ancestor.

        The scaling of this operation should be proportional to

        1. The number of uncommon ancestors

        2. The number of border ancestors

        3. The length of the shortest path between a border ancestor and an

           ancestor of all border ancestors.

        """

        border_common, common, sides = self._find_border_ancestors(revisions)

        # We may have common ancestors that can be reached from each other.

        # - ask for the heads of them to filter it down to only ones that

        # cannot be reached from each other - phase 2.

        return self.heads(border_common)

    def find_difference(self, left_revision, right_revision):

        """Determine the graph difference between two revisions"""

        border, common, searchers = self._find_border_ancestors(

            [left_revision, right_revision])

        self._search_for_extra_common(common, searchers)

        left = searchers[0].seen

        right = searchers[1].seen

        return (left.difference(right), right.difference(left))

    def find_unique_ancestors(self, unique_revision, common_revisions):

        """Find the unique ancestors for a revision versus others.

        This returns the ancestry of unique_revision, excluding all revisions

        in the ancestry of common_revisions. If unique_revision is in the

        ancestry, then the empty set will be returned.

        :param unique_revision: The revision_id whose ancestry we are

            interested in.

            XXX: Would this API be better if we allowed multiple revisions on

                 to be searched here?

        :param common_revisions: Revision_ids of ancestries to exclude.

        :return: A set of revisions in the ancestry of unique_revision

        """

        if unique_revision in common_revisions:

            return set()

        # Algorithm description

        # 1) Walk backwards from the unique node and all common nodes.

        # 2) When a node is seen by both sides, stop searching it in the unique

        #    walker, include it in the common walker.

        # 3) Stop searching when there are no nodes left for the unique walker.

        #    At this point, you have a maximal set of unique nodes. Some of

        #    them may actually be common, and you haven't reached them yet.

        # 4) Start new searchers for the unique nodes, seeded with the

        #    information you have so far.

        # 5) Continue searching, stopping the common searches when the search

        #    tip is an ancestor of all unique nodes.

        # 6) Search is done when all common searchers have completed.

        if 'graph' in debug.debug_flags:

            _mutter = trace.mutter

        else:

            def _mutter(*args, **kwargs):

                pass

        unique_searcher = self._make_breadth_first_searcher([unique_revision])

        # we know that unique_revision isn't in common_revisions

        unique_searcher.next()

        common_searcher = self._make_breadth_first_searcher(common_revisions)

        while unique_searcher._next_query:

            next_unique_nodes = set(unique_searcher.step())

            next_common_nodes = set(common_searcher.step())

            # Check if either searcher encounters new nodes seen by the other

            # side.

            unique_are_common_nodes = next_unique_nodes.intersection(

                common_searcher.seen)

            unique_are_common_nodes.update(

                next_common_nodes.intersection(unique_searcher.seen))

            if unique_are_common_nodes:

                ancestors = unique_searcher.find_seen_ancestors(

                                unique_are_common_nodes)

                ancestors.update(common_searcher.find_seen_ancestors(ancestors))

                unique_searcher.stop_searching_any(ancestors)

                common_searcher.start_searching(ancestors)

        unique_nodes = unique_searcher.seen.difference(common_searcher.seen)

        if not unique_nodes:

            return unique_nodes

        unique_tips = self._remove_simple_descendants(unique_nodes,

                        self.get_parent_map(unique_nodes))

        if len(unique_tips) == 1:

            unique_searchers = []

            ancestor_all_unique = unique_searcher.find_seen_ancestors(unique_tips)

        else:

            unique_searchers = []

            for tip in unique_tips:

                revs_to_search = unique_searcher.find_seen_ancestors([tip])

                searcher = self._make_breadth_first_searcher(revs_to_search)

                # We don't care about the starting nodes.

                searcher._label = tip

                searcher.step()

                unique_searchers.append(searcher)

            ancestor_all_unique = None

            for searcher in unique_searchers:

                if ancestor_all_unique is None:

                    ancestor_all_unique = set(searcher.seen)

                else:

                    ancestor_all_unique = ancestor_all_unique.intersection(

                                                searcher.seen)

        # Collapse all the common nodes into a single searcher

        all_unique_searcher = self._make_breadth_first_searcher(ancestor_all_unique)

        if ancestor_all_unique:

            all_unique_searcher.step()

            # Stop any search tips that are already known as ancestors of the

            # unique nodes

            common_searcher.stop_searching_any(

                common_searcher.find_seen_ancestors(ancestor_all_unique))

            total_stopped = 0

            for searcher in unique_searchers:

                total_stopped += len(searcher.stop_searching_any(

                    searcher.find_seen_ancestors(ancestor_all_unique)))

            _mutter('For %s unique nodes, created %s + 1 unique searchers'

                    ' (%s stopped search tips, %s common ancestors)',

                    len(unique_nodes), len(unique_searchers), total_stopped,

                    len(ancestor_all_unique))

            del ancestor_all_unique

        # While we still have common nodes to search

        while common_searcher._next_query:

            newly_seen_common = set(common_searcher.step())

            newly_seen_unique = set()

            for searcher in unique_searchers:

                newly_seen_unique.update(searcher.step())

            # These nodes are common ancestors of all unique nodes

            unique_are_common_nodes = newly_seen_unique.copy()

            for searcher in unique_searchers:

                unique_are_common_nodes = unique_are_common_nodes.intersection(

                                            searcher.seen)

            unique_are_common_nodes = unique_are_common_nodes.intersection(

                                        all_unique_searcher.seen)

            unique_are_common_nodes.update(all_unique_searcher.step())

            if newly_seen_common:

                # If a 'common' node is an ancestor of all unique searchers, we

                # can stop searching it.

                common_searcher.stop_searching_any(

                    all_unique_searcher.seen.intersection(newly_seen_common))

            if unique_are_common_nodes:

                # We have new common-to-all-unique-searchers nodes

                for searcher in unique_searchers:

                    unique_are_common_nodes.update(

                        searcher.find_seen_ancestors(unique_are_common_nodes))

                unique_are_common_nodes.update(

                    all_unique_searcher.find_seen_ancestors(unique_are_common_nodes))

                # Since these are common, we can grab another set of ancestors

                # that we have seen

                unique_are_common_nodes.update(

                    common_searcher.find_seen_ancestors(unique_are_common_nodes))

                # The all_unique searcher can start searching the common nodes

                # but everyone else can stop.

                all_unique_searcher.start_searching(unique_are_common_nodes)

                common_searcher.stop_searching_any(unique_are_common_nodes)

                # Filter out searchers that don't actually search different

                # nodes. We already have the ancestry intersection for them

                next_unique_searchers = []

                unique_search_sets = set()

                for searcher in unique_searchers:

                    stopped = searcher.stop_searching_any(unique_are_common_nodes)

                    will_search_set = frozenset(searcher._next_query)

                    if not will_search_set:

                        _mutter('Unique searcher %s was stopped.'

                                ' (%s iterations) %d nodes stopped',

                                searcher._label,

                                searcher._iterations,

                                len(stopped))

                    elif will_search_set not in unique_search_sets:

                        # This searcher is searching a unique set of nodes, let it

                        unique_search_sets.add(will_search_set)

                        next_unique_searchers.append(searcher)

                    else:

                        _mutter('Unique searcher %s stopped for repeated'

                                ' search of %s nodes', 

                                searcher._label, len(will_search_set))

                if len(unique_searchers) != len(next_unique_searchers):

                    _mutter('Collapsed %s unique searchers => %s'

                            ' at %s iterations',

                            len(unique_searchers), len(next_unique_searchers),

                            all_unique_searcher._iterations)

                unique_searchers = next_unique_searchers

        return unique_nodes.difference(common_searcher.seen)

    @symbol_versioning.deprecated_method(symbol_versioning.one_one)

    def get_parents(self, revisions):

        """Find revision ids of the parents of a list of revisions

        A list is returned of the same length as the input.  Each entry

        is a list of parent ids for the corresponding input revision.

        [NULL_REVISION] is used as the parent of the first user-committed

        revision.  Its parent list is empty.

        If the revision is not present (i.e. a ghost), None is used in place

        of the list of parents.

        Deprecated in bzr 1.2 - please see get_parent_map.

        """

        parents = self.get_parent_map(revisions)

        return [parents.get(r, None) for r in revisions]

    def get_parent_map(self, revisions):

        """Get a map of key:parent_list for revisions.

        This implementation delegates to get_parents, for old parent_providers

        that do not supply get_parent_map.

        """

        result = {}

        for rev, parents in self.get_parents(revisions):

            if parents is not None:

                result[rev] = parents

        return result

    def _make_breadth_first_searcher(self, revisions):

        return _BreadthFirstSearcher(revisions, self)

    def _find_border_ancestors(self, revisions):

        """Find common ancestors with at least one uncommon descendant.

        Border ancestors are identified using a breadth-first

        search starting at the bottom of the graph.  Searches are stopped

        whenever a node or one of its descendants is determined to be common.

        This will scale with the number of uncommon ancestors.

        As well as the border ancestors, a set of seen common ancestors and a

        list of sets of seen ancestors for each input revision is returned.

        This allows calculation of graph difference from the results of this

        operation.

        """

        if None in revisions:

            raise errors.InvalidRevisionId(None, self)

        common_ancestors = set()

        searchers = [self._make_breadth_first_searcher([r])

                     for r in revisions]

        active_searchers = searchers[:]

        border_ancestors = set()

        while True:

            newly_seen = set()

            for searcher in searchers:

                new_ancestors = searcher.step()

                if new_ancestors:

                    newly_seen.update(new_ancestors)

            new_common = set()

            for revision in newly_seen:

                if revision in common_ancestors:

                    # Not a border ancestor because it was seen as common

                    # already

                    new_common.add(revision)

                    continue

                for searcher in searchers:

                    if revision not in searcher.seen:

                        break

                else:

                    # This is a border because it is a first common that we see

                    # after walking for a while.

                    border_ancestors.add(revision)

                    new_common.add(revision)

            if new_common:

                for searcher in searchers:

                    new_common.update(searcher.find_seen_ancestors(new_common))

                for searcher in searchers:

                    searcher.start_searching(new_common)

                common_ancestors.update(new_common)

            # Figure out what the searchers will be searching next, and if

            # there is only 1 set being searched, then we are done searching,

            # since all searchers would have to be searching the same data,

            # thus it *must* be in common.

            unique_search_sets = set()

            for searcher in searchers:

                will_search_set = frozenset(searcher._next_query)

                if will_search_set not in unique_search_sets:

                    # This searcher is searching a unique set of nodes, let it

                    unique_search_sets.add(will_search_set)

            if len(unique_search_sets) == 1:

                nodes = unique_search_sets.pop()

                uncommon_nodes = nodes.difference(common_ancestors)

                assert not uncommon_nodes, ("Somehow we ended up converging"

                                            " without actually marking them as"

                                            " in common."

                                            "\nStart_nodes: %s"

                                            "\nuncommon_nodes: %s"

                                            % (revisions, uncommon_nodes))

                break

        return border_ancestors, common_ancestors, searchers

    def heads(self, keys):

        """Return the heads from amongst keys.

        This is done by searching the ancestries of each key.  Any key that is

        reachable from another key is not returned; all the others are.

        This operation scales with the relative depth between any two keys. If

        any two keys are completely disconnected all ancestry of both sides

        will be retrieved.

        :param keys: An iterable of keys.

        :return: A set of the heads. Note that as a set there is no ordering

            information. Callers will need to filter their input to create

            order if they need it.

        """

        candidate_heads = set(keys)

        if revision.NULL_REVISION in candidate_heads:

            # NULL_REVISION is only a head if it is the only entry

            candidate_heads.remove(revision.NULL_REVISION)

            if not candidate_heads:

                return set([revision.NULL_REVISION])

        if len(candidate_heads) < 2:

            return candidate_heads

        searchers = dict((c, self._make_breadth_first_searcher([c]))

                          for c in candidate_heads)

        active_searchers = dict(searchers)

        # skip over the actual candidate for each searcher

        for searcher in active_searchers.itervalues():

            searcher.next()

        # The common walker finds nodes that are common to two or more of the

        # input keys, so that we don't access all history when a currently

        # uncommon search point actually meets up with something behind a

        # common search point. Common search points do not keep searches

        # active; they just allow us to make searches inactive without

        # accessing all history.

        common_walker = self._make_breadth_first_searcher([])

        while len(active_searchers) > 0:

            ancestors = set()

            # advance searches

            try:

                common_walker.next()

            except StopIteration:

                # No common points being searched at this time.

                pass

            for candidate in active_searchers.keys():

                try:

                    searcher = active_searchers[candidate]

                except KeyError:

                    # rare case: we deleted candidate in a previous iteration

                    # through this for loop, because it was determined to be

                    # a descendant of another candidate.

                    continue

                try:

                    ancestors.update(searcher.next())

                except StopIteration:

                    del active_searchers[candidate]

                    continue

            # process found nodes

            new_common = set()

            for ancestor in ancestors:

                if ancestor in candidate_heads:

                    candidate_heads.remove(ancestor)

                    del searchers[ancestor]

                    if ancestor in active_searchers:

                        del active_searchers[ancestor]

                # it may meet up with a known common node

                if ancestor in common_walker.seen:

                    # some searcher has encountered our known common nodes:

                    # just stop it

                    ancestor_set = set([ancestor])

                    for searcher in searchers.itervalues():

                        searcher.stop_searching_any(ancestor_set)

                else:

                    # or it may have been just reached by all the searchers:

                    for searcher in searchers.itervalues():

                        if ancestor not in searcher.seen:

                            break

                    else:

                        # The final active searcher has just reached this node,

                        # making it be known as a descendant of all candidates,

                        # so we can stop searching it, and any seen ancestors

                        new_common.add(ancestor)

                        for searcher in searchers.itervalues():

                            seen_ancestors =\

                                searcher.find_seen_ancestors([ancestor])

                            searcher.stop_searching_any(seen_ancestors)

            common_walker.start_searching(new_common)

        return candidate_heads

    def find_unique_lca(self, left_revision, right_revision,

                        count_steps=False):

        """Find a unique LCA.

        Find lowest common ancestors.  If there is no unique  common

        ancestor, find the lowest common ancestors of those ancestors.

        Iteration stops when a unique lowest common ancestor is found.

        The graph origin is necessarily a unique lowest common ancestor.

        Note that None is not an acceptable substitute for NULL_REVISION.

        in the input for this method.

        :param count_steps: If True, the return value will be a tuple of

            (unique_lca, steps) where steps is the number of times that

            find_lca was run.  If False, only unique_lca is returned.

        """

        revisions = [left_revision, right_revision]

        steps = 0

        while True:

            steps += 1

            lca = self.find_lca(*revisions)

            if len(lca) == 1:

                result = lca.pop()

                if count_steps:

                    return result, steps

                else:

                    return result

            if len(lca) == 0:

                raise errors.NoCommonAncestor(left_revision, right_revision)

            revisions = lca

    def iter_ancestry(self, revision_ids):

        """Iterate the ancestry of this revision.

        :param revision_ids: Nodes to start the search

        :return: Yield tuples mapping a revision_id to its parents for the

            ancestry of revision_id.

            Ghosts will be returned with None as their parents, and nodes

            with no parents will have NULL_REVISION as their only parent. (As

            defined by get_parent_map.)

            There will also be a node for (NULL_REVISION, ())

        """

        pending = set(revision_ids)

        processed = set()

        while pending:

            processed.update(pending)

            next_map = self.get_parent_map(pending)

            next_pending = set()

            for item in next_map.iteritems():

                yield item

                next_pending.update(p for p in item[1] if p not in processed)

            ghosts = pending.difference(next_map)

            for ghost in ghosts:

                yield (ghost, None)

            pending = next_pending

    def iter_topo_order(self, revisions):

        """Iterate through the input revisions in topological order.

        This sorting only ensures that parents come before their children.

        An ancestor may sort after a descendant if the relationship is not

        visible in the supplied list of revisions.

        """

        sorter = tsort.TopoSorter(self.get_parent_map(revisions))

        return sorter.iter_topo_order()

    def is_ancestor(self, candidate_ancestor, candidate_descendant):

        """Determine whether a revision is an ancestor of another.

        We answer this using heads() as heads() has the logic to perform the

        smallest number of parent lookups to determine the ancestral

        relationship between N revisions.

        """

        return set([candidate_descendant]) == self.heads(

            [candidate_ancestor, candidate_descendant])

    def _search_for_extra_common(self, common, searchers):

        """Make sure that unique nodes are genuinely unique.

        After _find_border_ancestors, all nodes marked "common" are indeed

        common. Some of the nodes considered unique are not, due to history

        shortcuts stopping the searches early.

        We know that we have searched enough when all common search tips are

        descended from all unique (uncommon) nodes because we know that a node

        cannot be an ancestor of its own ancestor.

        :param common: A set of common nodes

        :param searchers: The searchers returned from _find_border_ancestors

        :return: None

        """

        # Basic algorithm...

        #   A) The passed in searchers should all be on the same tips, thus

        #      they should be considered the "common" searchers.

        #   B) We find the difference between the searchers, these are the

        #      "unique" nodes for each side.

        #   C) We do a quick culling so that we only start searching from the

        #      more interesting unique nodes. (A unique ancestor is more

        #      interesting than any of its children.)

        #   D) We start searching for ancestors common to all unique nodes.

        #   E) We have the common searchers stop searching any ancestors of

        #      nodes found by (D)

        #   F) When there are no more common search tips, we stop

        # TODO: We need a way to remove unique_searchers when they overlap with

        #       other unique searchers.

        assert len(searchers) == 2, (

            "Algorithm not yet implemented for > 2 searchers")

        common_searchers = searchers

        left_searcher = searchers[0]

        right_searcher = searchers[1]

        unique = left_searcher.seen.symmetric_difference(right_searcher.seen)

        if not unique: # No unique nodes, nothing to do

            return

        total_unique = len(unique)

        unique = self._remove_simple_descendants(unique,

                    self.get_parent_map(unique))

        simple_unique = len(unique)

        unique_searchers = []

        for revision_id in unique:

            if revision_id in left_searcher.seen:

                parent_searcher = left_searcher

            else:

                parent_searcher = right_searcher

            revs_to_search = parent_searcher.find_seen_ancestors([revision_id])

            if not revs_to_search: # XXX: This shouldn't be possible

                revs_to_search = [revision_id]

            searcher = self._make_breadth_first_searcher(revs_to_search)

            # We don't care about the starting nodes.

            searcher.step()

            unique_searchers.append(searcher)

        # possible todo: aggregate the common searchers into a single common

        #   searcher, just make sure that we include the nodes into the .seen

        #   properties of the original searchers

        ancestor_all_unique = None

        for searcher in unique_searchers:

            if ancestor_all_unique is None:

                ancestor_all_unique = set(searcher.seen)

            else:

                ancestor_all_unique = ancestor_all_unique.intersection(

                                            searcher.seen)

        trace.mutter('Started %s unique searchers for %s unique revisions',

                     simple_unique, total_unique)

        while True: # If we have no more nodes we have nothing to do

            newly_seen_common = set()

            for searcher in common_searchers:

                newly_seen_common.update(searcher.step())

            newly_seen_unique = set()

            for searcher in unique_searchers:

                newly_seen_unique.update(searcher.step())

            new_common_unique = set()

            for revision in newly_seen_unique:

                for searcher in unique_searchers:

                    if revision not in searcher.seen:

                        break

                else:

                    # This is a border because it is a first common that we see

                    # after walking for a while.