/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
1
# Copyright (C) 2007 Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
17
import textwrap
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
18
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
19
from bzrlib import registry, help_topics
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
20
from bzrlib.lazy_import import lazy_import
21
lazy_import(globals(), """
2376.4.17 by Jonathan Lange
Use urlutils.join instead of ugly, buggy, string mashing
22
from bzrlib import errors, urlutils
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
23
""")
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
24
25
2376.4.7 by jml at canonical
- Add docstrings to tests.
26
"""Provides a shorthand for referring to bugs on a variety of bug trackers.
27
28
'commit --fixes' stores references to bugs as a <bug_url> -> <bug_status>
29
mapping in the properties for that revision.
30
31
However, it's inconvenient to type out full URLs for bugs on the command line,
32
particularly given that many users will be using only a single bug tracker per
33
branch.
34
35
Thus, this module provides a registry of types of bug tracker (e.g. Launchpad,
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
36
Trac). Given an abbreviated name (e.g. 'lp', 'twisted') and a branch with
2376.4.7 by jml at canonical
- Add docstrings to tests.
37
configuration information, these tracker types can return an instance capable
38
of converting bug IDs into URLs.
39
"""
40
41
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
42
_bugs_help = \
43
"""When making a commit, metadata about bugs fixed by that change can be
44
recorded by using the --fixes option. For each bug marked as fixed, an
45
entry is included in the 'bugs' revision property stating '<url> <status>'.
3154.1.1 by Ian Clatworthy
Minor tweaks to bug tracker integration documentation
46
(The only ``status`` value currently supported is ``fixed.``)
3535.10.2 by James Westby
Flesh out the bugs help topic and explain the simple things first.
47
48
The --fixes option allows you to specify a bug tracker and a bug identifier
49
rather than a full URL. This looks like
50
51
    bzr commit --fixes <tag>:<id>
52
53
where "<tag>" is an identifier for the bug tracker, and "<id>" is the
54
identifier for that bug within the bugtracker, usually the bug number.
55
56
Bazaar knows about a few bug trackers that have a well-know location. If
57
you use one of these bug trackers then there is no setup required to
58
use this feature, you just need to know the tag to use. These are the
59
bugtrackers that are built in:
60
                URL               |    Tag     |   Example
61
   ------------------------------------------------------------
62
     https://bugs.launchpad.net/  |     lp     |     lp:12345
63
       http://bugs.debian.org/    |   debian   | debian:12345
64
     http://bugzilla.gnome.org/   |   gnome    |  gnome:12345
65
66
For the bug trackers that don't have a well known location some
67
configuration is required. Support for generating the URLs for any
68
project using Bugzilla or Trac is built in, along with a template
69
mechanism for other bugtrackers with simple URL schemes.
70
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
71
If you use Bugzilla or Trac, then you only need to set a configuration
72
variable which contains the base URL of the bug tracker. These options
73
can go into ``bazaar.conf``, ``branch.conf`` or into a branch-specific
74
configuration section in ``locations.conf``.  You can set up these values
75
for each of the projects you work on.
76
77
Note: As you provide a short name for each tracker, you can specify one or
78
more bugs in one or more trackers at commit time if you wish.
79
80
bugzilla_<tracker_abbreviation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
81
-----------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
82
83
If present, the location of the Bugzilla bug tracker referred to by
84
<tracker_abbreviation>. This option can then be used together with ``bzr commit
85
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
86
example::
87
88
    bugzilla_squid_url = http://www.squid-cache.org/bugs
89
90
would allow ``bzr commit --fixes squid:1234`` to mark Squid's bug 1234 as
91
fixed.
92
93
trac_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
94
------------------------------
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
95
96
If present, the location of the Trac instance referred to by
97
<tracker_abbreviation>. This option can then be used together with ``bzr commit
98
--fixes`` to mark bugs in that tracker as being fixed by that commit. For
99
example::
100
101
    trac_twisted_url = http://www.twistedmatrix.com/trac
102
103
would allow ``bzr commit --fixes twisted:1234`` to mark Twisted's bug 1234 as
104
fixed.
105
106
bugtracker_<tracker_abbrevation>_url
3089.3.14 by Ian Clatworthy
follow-up tweaks to bzr.dev integration
107
------------------------------------
108
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
109
If present, the location of a generic bug tracker instance referred to by
110
<tracker_abbreviation>. The location must contain an ``{id}`` placeholder,
111
which will be replaced by a specific bug ID. This option can then be used
112
together with ``bzr commit --fixes`` to mark bugs in that tracker as being
113
fixed by that commit. For example::
114
115
    bugtracker_python_url = http://bugs.python.org/issue{id}
116
117
would allow ``bzr commit --fixes python:1234`` to mark bug 1234 in Python's
118
Roundup bug tracker as fixed, or::
119
120
    bugtracker_cpan_url = http://rt.cpan.org/Public/Bug/Display.html?id={id}
121
122
for CPAN's RT bug tracker.
123
"""
124
125
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
126
def get_bug_url(abbreviated_bugtracker_name, branch, bug_id):
127
    """Return a URL pointing to the canonical web page of the bug identified by
128
    'bug_id'.
129
    """
130
    tracker = tracker_registry.get_tracker(abbreviated_bugtracker_name, branch)
131
    return tracker.get_bug_url(bug_id)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
132
133
134
class TrackerRegistry(registry.Registry):
135
    """Registry of bug tracker types."""
136
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
137
    def get_tracker(self, abbreviated_bugtracker_name, branch):
138
        """Return the first registered tracker that understands
139
        'abbreviated_bugtracker_name'.
2376.4.7 by jml at canonical
- Add docstrings to tests.
140
141
        If no such tracker is found, raise KeyError.
142
        """
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
143
        for tracker_name in self.keys():
144
            tracker_type = self.get(tracker_name)
145
            tracker = tracker_type.get(abbreviated_bugtracker_name, branch)
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
146
            if tracker is not None:
147
                return tracker
2376.4.28 by Jonathan Lange
Focus the tests better and clean up some dodgy bits in UnknownBugTrackerAbbreviation
148
        raise errors.UnknownBugTrackerAbbreviation(abbreviated_bugtracker_name,
149
                                                   branch)
2376.4.7 by jml at canonical
- Add docstrings to tests.
150
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
151
    def help_topic(self, topic):
3053.8.1 by Ian Clatworthy
Improve bug tracker integration documentation (Ian Clatworthy)
152
        return _bugs_help
2376.4.36 by Jonathan Lange
Provide really basic help topic for our bug tracker support.
153
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
154
155
tracker_registry = TrackerRegistry()
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
156
"""Registry of bug trackers."""
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
157
2376.4.15 by Jonathan Lange
Whitespace cleanup
158
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
159
class BugTracker(object):
160
    """Base class for bug trackers."""
161
162
    def check_bug_id(self, bug_id):
163
        """Check that the bug_id is valid.
164
165
        The base implementation assumes that all bug_ids are valid.
166
        """
167
168
    def get_bug_url(self, bug_id):
169
        """Return the URL for bug_id. Raise an error if bug ID is malformed."""
170
        self.check_bug_id(bug_id)
171
        return self._get_bug_url(bug_id)
172
173
    def _get_bug_url(self, bug_id):
174
        """Given a validated bug_id, return the bug's web page's URL."""
175
176
177
class IntegerBugTracker(BugTracker):
178
    """A bug tracker that only allows integer bug IDs."""
179
180
    def check_bug_id(self, bug_id):
181
        try:
182
            int(bug_id)
183
        except ValueError:
184
            raise errors.MalformedBugIdentifier(bug_id, "Must be an integer")
185
186
187
class UniqueIntegerBugTracker(IntegerBugTracker):
2376.4.19 by Jonathan Lange
Rename SimpleBugTracker to UniqueBugTracker
188
    """A style of bug tracker that exists in one place only, such as Launchpad.
2376.4.15 by Jonathan Lange
Whitespace cleanup
189
2376.4.41 by Jonathan Lange
Update UniqueIntegerBugTracker docstring for new API
190
    If you have one of these trackers then register an instance passing in an
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
191
    abbreviated name for the bug tracker and a base URL. The bug ids are
192
    appended directly to the URL.
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
193
    """
194
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
195
    def __init__(self, abbreviated_bugtracker_name, base_url):
196
        self.abbreviation = abbreviated_bugtracker_name
197
        self.base_url = base_url
198
199
    def get(self, abbreviated_bugtracker_name, branch):
2376.4.23 by Jonathan Lange
Change 'tag' to 'abbreviated_tracker_name'
200
        """Returns the tracker if the abbreviation matches. Returns None
201
        otherwise."""
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
202
        if abbreviated_bugtracker_name != self.abbreviation:
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
203
            return None
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
204
        return self
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
205
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
206
    def _get_bug_url(self, bug_id):
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
207
        """Return the URL for bug_id."""
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
208
        return self.base_url + bug_id
2376.5.1 by James Westby
Add a superclass for easy bug trackers. Also add bugs.debian.org as deb:
209
210
2376.4.25 by Jonathan Lange
Make singleton bug tracker thing work via instances.
211
tracker_registry.register(
212
    'launchpad', UniqueIntegerBugTracker('lp', 'https://launchpad.net/bugs/'))
213
214
215
tracker_registry.register(
2376.4.29 by Jonathan Lange
Tests for builtin trackers.
216
    'debian', UniqueIntegerBugTracker('deb', 'http://bugs.debian.org/'))
2376.4.4 by jml at canonical
Beginnings of generic bug-tracker plugin system.
217
2376.4.15 by Jonathan Lange
Whitespace cleanup
218
3270.5.3 by James Westby
No longer add an extra class to accomoadate gnome.
219
tracker_registry.register('gnome',
220
    UniqueIntegerBugTracker('gnome', 'http://bugzilla.gnome.org/show_bug.cgi?id='))
221
222
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
223
class URLParametrizedIntegerBugTracker(IntegerBugTracker):
224
    """A type of bug tracker that can be found on a variety of different sites,
225
    and thus needs to have the base URL configured.
226
227
    Looks for a config setting in the form '<type_name>_<abbreviation>_url'.
228
    `type_name` is the name of the type of tracker (e.g. 'bugzilla' or 'trac')
229
    and `abbreviation` is a short name for the particular instance (e.g.
230
    'squid' or 'apache').
231
    """
232
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
233
    def get(self, abbreviation, branch):
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
234
        config = branch.get_config()
235
        url = config.get_user_option(
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
236
            "%s_%s_url" % (self.type_name, abbreviation))
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
237
        if url is None:
238
            return None
239
        self._base_url = url
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
240
        return self
241
242
    def __init__(self, type_name, bug_area):
243
        self.type_name = type_name
244
        self._bug_area = bug_area
2376.4.40 by Jonathan Lange
Redo the hierarchy of bug trackers to reduce duplication.
245
246
    def _get_bug_url(self, bug_id):
2376.4.6 by jml at canonical
Basic docstrings for bugtracker.py
247
        """Return a URL for a bug on this Trac instance."""
2376.4.42 by Jonathan Lange
Parametrize URLParametrizedIntegerBugTracker even further so we don't need to
248
        return urlutils.join(self._base_url, self._bug_area) + str(bug_id)
249
250
251
tracker_registry.register(
252
    'trac', URLParametrizedIntegerBugTracker('trac', 'ticket/'))
253
254
tracker_registry.register(
255
    'bugzilla',
256
    URLParametrizedIntegerBugTracker('bugzilla', 'show_bug.cgi?id='))
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
257
258
259
class GenericBugTracker(URLParametrizedIntegerBugTracker):
260
    """Generic bug tracker specified by an URL template."""
261
262
    def __init__(self):
3035.3.2 by Lukáš Lalinský
Add tests for InvalidBugTrackerURL.
263
        super(GenericBugTracker, self).__init__('bugtracker', None)
264
265
    def get(self, abbreviation, branch):
266
        self._abbreviation = abbreviation
267
        return super(GenericBugTracker, self).get(abbreviation, branch)
3035.3.1 by Lukáš Lalinský
Generic bug tracker configuration.
268
269
    def _get_bug_url(self, bug_id):
270
        """Given a validated bug_id, return the bug's web page's URL."""
271
        if '{id}' not in self._base_url:
272
            raise errors.InvalidBugTrackerURL(self._abbreviation,
273
                                              self._base_url)
274
        return self._base_url.replace('{id}', str(bug_id))
275
276
277
tracker_registry.register('generic', GenericBugTracker())