/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
1
# Copyright (C) 2007 Canonical Ltd
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
2245.1.2 by Robert Collins
Remove the static DefaultHooks method from Branch, replacing it with a derived dict BranchHooks object, which is easier to use and provides a place to put the policy-checking add method discussed on list.
17
"""Tests that branch classes implement hook callouts correctly."""
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
18
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
19
from bzrlib.branch import Branch, ChangeBranchTipParams
3331.1.2 by James Henstridge
Add calls to set_last_revision_info hook to both BzrBranch and
20
from bzrlib.revision import NULL_REVISION
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
21
from bzrlib.tests import TestCaseWithMemoryTransport
22
23
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
24
class TestSetRevisionHistoryHook(TestCaseWithMemoryTransport):
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
25
26
    def setUp(self):
27
        self.hook_calls = []
28
        TestCaseWithMemoryTransport.setUp(self)
29
30
    def capture_set_rh_hook(self, branch, rev_history):
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
31
        """Capture post set-rh hook calls to self.hook_calls.
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
32
        
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
33
        The call is logged, as is some state of the branch.
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
34
        """
35
        self.hook_calls.append(
36
            ('set_rh', branch, rev_history, branch.is_locked()))
37
38
    def test_set_rh_empty_history(self):
39
        branch = self.make_branch('source')
3256.2.15 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.branch_implementation.test_hooks.
40
        Branch.hooks.install_named_hook('set_rh', self.capture_set_rh_hook,
41
                                        None)
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
42
        branch.set_revision_history([])
43
        self.assertEqual(self.hook_calls,
44
            [('set_rh', branch, [], True)])
45
46
    def test_set_rh_nonempty_history(self):
2230.3.20 by Aaron Bentley
Add hooking for set_revision_history
47
        tree = self.make_branch_and_memory_tree('source')
48
        tree.lock_write()
49
        tree.add('')
2696.3.7 by Martin Pool
Update hook test to cope with branches that can't set their last revision to one that's not present
50
        tree.commit('another commit', rev_id='f\xc2\xb5')
2230.3.20 by Aaron Bentley
Add hooking for set_revision_history
51
        tree.commit('empty commit', rev_id='foo')
52
        tree.unlock()
53
        branch = tree.branch
3256.2.15 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.branch_implementation.test_hooks.
54
        Branch.hooks.install_named_hook('set_rh', self.capture_set_rh_hook,
55
                                        None)
2696.3.7 by Martin Pool
Update hook test to cope with branches that can't set their last revision to one that's not present
56
        # some branches require that their history be set to a revision in the
57
        # repository
2309.4.10 by John Arbash Meinel
(fixed) Fix the last few tests that were explicitly passing around unicode ids
58
        branch.set_revision_history(['f\xc2\xb5'])
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
59
        self.assertEqual(self.hook_calls,
2309.4.10 by John Arbash Meinel
(fixed) Fix the last few tests that were explicitly passing around unicode ids
60
            [('set_rh', branch, ['f\xc2\xb5'], True)])
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
61
62
    def test_set_rh_branch_is_locked(self):
63
        branch = self.make_branch('source')
3256.2.15 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.branch_implementation.test_hooks.
64
        Branch.hooks.install_named_hook('set_rh', self.capture_set_rh_hook,
65
                                        None)
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
66
        branch.set_revision_history([])
67
        self.assertEqual(self.hook_calls,
68
            [('set_rh', branch, [], True)])
69
70
    def test_set_rh_calls_all_hooks_no_errors(self):
71
        branch = self.make_branch('source')
3256.2.15 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.branch_implementation.test_hooks.
72
        Branch.hooks.install_named_hook('set_rh', self.capture_set_rh_hook,
73
                                        None)
74
        Branch.hooks.install_named_hook('set_rh', self.capture_set_rh_hook,
75
                                        None)
2245.1.1 by Robert Collins
New Branch hooks facility, with one initial hook 'set_rh' which triggers
76
        branch.set_revision_history([])
77
        self.assertEqual(self.hook_calls,
78
            [('set_rh', branch, [], True),
79
             ('set_rh', branch, [], True),
80
            ])
3331.1.2 by James Henstridge
Add calls to set_last_revision_info hook to both BzrBranch and
81
82
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
83
class ChangeBranchTipTestCase(TestCaseWithMemoryTransport):
84
    """Base TestCase for testing pre/post_change_branch_tip hooks."""
85
86
    def install_logging_hook(self, prefix):
87
        """Add a hook that logs calls made to it.
88
        
89
        :returns: the list that the calls will be appended to.
90
        """
91
        hook_calls = []
92
        Branch.hooks.install_named_hook(
93
            'pre_change_branch_tip', hook_calls.append, None)
94
        return hook_calls
95
96
    def make_branch_with_revision_ids(self, *revision_ids):
97
        """Makes a branch with the given commits."""
98
        tree = self.make_branch_and_memory_tree('source')
99
        tree.lock_write()
100
        tree.add('')
101
        for revision_id in revision_ids:
102
            tree.commit('Message of ' + revision_id, rev_id=revision_id)
103
        tree.unlock()
104
        branch = tree.branch
105
        return branch
106
107
108
class TestPreChangeBranchTip(ChangeBranchTipTestCase):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
109
    """Tests for pre_change_branch_tip hook.
110
    
111
    Most of these tests are very similar to the tests in
112
    TestPostChangeBranchTip.
113
    """
114
115
    def test_hook_runs_before_change(self):
116
        """The hook runs *before* the branch's last_revision_info has changed.
117
        """
118
        branch = self.make_branch_with_revision_ids('revid-one')
119
        def assertBranchAtRevision1(params):
120
            self.assertEquals(
121
                (1, 'revid-one'), params.branch.last_revision_info())
122
        Branch.hooks.install_named_hook(
123
            'pre_change_branch_tip', assertBranchAtRevision1, None)
124
        branch.set_last_revision_info(0, NULL_REVISION)
125
3517.2.2 by Andrew Bennetts
Add test for a pre_change_branch_tip hook rejecting a change.
126
    def test_reject_by_hook(self):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
127
        """If a hook raises an exception, the change does not take effect.
128
        
129
        Also, the exception will be propogated.
130
        """
3517.2.2 by Andrew Bennetts
Add test for a pre_change_branch_tip hook rejecting a change.
131
        branch = self.make_branch_with_revision_ids(
132
            'one-\xc2\xb5', 'two-\xc2\xb5')
133
        class PearShapedError(Exception):
134
            pass
135
        def hook_that_raises(params):
136
            raise PearShapedError()
137
        Branch.hooks.install_named_hook(
138
            'pre_change_branch_tip', hook_that_raises, None)
139
        self.assertRaises(
140
            PearShapedError, branch.set_last_revision_info, 0, NULL_REVISION)
141
        # The revision info is unchanged.
142
        self.assertEqual((2, 'two-\xc2\xb5'), branch.last_revision_info())
143
        
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
144
    def test_empty_history(self):
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
145
        branch = self.make_branch('source')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
146
        hook_calls = self.install_logging_hook('pre')
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
147
        branch.set_last_revision_info(0, NULL_REVISION)
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
148
        expected_params = ChangeBranchTipParams(
149
            branch, 0, 0, NULL_REVISION, NULL_REVISION)
150
        self.assertEqual([expected_params], hook_calls)
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
151
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
152
    def test_nonempty_history(self):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
153
        # some branches require that their history be set to a revision in the
154
        # repository, so we need to make a branch with non-empty history for
155
        # this test.
3517.2.2 by Andrew Bennetts
Add test for a pre_change_branch_tip hook rejecting a change.
156
        branch = self.make_branch_with_revision_ids(
157
            'one-\xc2\xb5', 'two-\xc2\xb5')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
158
        hook_calls = self.install_logging_hook('pre')
3517.2.2 by Andrew Bennetts
Add test for a pre_change_branch_tip hook rejecting a change.
159
        branch.set_last_revision_info(1, 'one-\xc2\xb5')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
160
        expected_params = ChangeBranchTipParams(
161
            branch, 2, 1, 'two-\xc2\xb5', 'one-\xc2\xb5')
162
        self.assertEqual([expected_params], hook_calls)
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
163
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
164
    def test_branch_is_locked(self):
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
165
        branch = self.make_branch('source')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
166
        def assertBranchIsLocked(params):
167
            self.assertTrue(params.branch.is_locked())
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
168
        Branch.hooks.install_named_hook(
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
169
            'pre_change_branch_tip', assertBranchIsLocked, None)
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
170
        branch.set_last_revision_info(0, NULL_REVISION)
171
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
172
    def test_calls_all_hooks_no_errors(self):
173
        """If multiple hooks are registered, all are called (if none raise
174
        errors).
175
        """
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
176
        branch = self.make_branch('source')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
177
        hook_calls_1 = self.install_logging_hook('pre')
178
        hook_calls_2 = self.install_logging_hook('pre')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
179
        self.assertIsNot(hook_calls_1, hook_calls_2)
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
180
        branch.set_last_revision_info(0, NULL_REVISION)
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
181
        # Both hooks are called.
182
        self.assertEqual(len(hook_calls_1), 1)
183
        self.assertEqual(len(hook_calls_2), 1)
3517.2.1 by Andrew Bennetts
Quick draft of pre_change_branch_tip hook.
184
185
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
186
class TestPostChangeBranchTip(ChangeBranchTipTestCase):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
187
    """Tests for post_change_branch_tip hook.
188
189
    Most of these tests are very similar to the tests in
190
    TestPostChangeBranchTip.
191
    """
192
193
    def test_hook_runs_after_change(self):
194
        """The hook runs *after* the branch's last_revision_info has changed.
195
        """
196
        branch = self.make_branch_with_revision_ids('revid-one')
197
        def assertBranchAtRevision1(params):
198
            self.assertEquals(
199
                (0, NULL_REVISION), params.branch.last_revision_info())
3256.2.26 by Daniel Watkins
Updated tests to use install_named_hook.
200
        Branch.hooks.install_named_hook(
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
201
            'post_change_branch_tip', assertBranchAtRevision1, None)
202
        branch.set_last_revision_info(0, NULL_REVISION)
203
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
204
    def test_empty_history(self):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
205
        branch = self.make_branch('source')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
206
        hook_calls = self.install_logging_hook('post')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
207
        branch.set_last_revision_info(0, NULL_REVISION)
208
        expected_params = ChangeBranchTipParams(
209
            branch, 0, 0, NULL_REVISION, NULL_REVISION)
210
        self.assertEqual([expected_params], hook_calls)
211
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
212
    def test_nonempty_history(self):
3331.1.2 by James Henstridge
Add calls to set_last_revision_info hook to both BzrBranch and
213
        # some branches require that their history be set to a revision in the
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
214
        # repository, so we need to make a branch with non-empty history for
215
        # this test.
216
        branch = self.make_branch_with_revision_ids(
217
            'one-\xc2\xb5', 'two-\xc2\xb5')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
218
        hook_calls = self.install_logging_hook('post')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
219
        branch.set_last_revision_info(1, 'one-\xc2\xb5')
220
        expected_params = ChangeBranchTipParams(
221
            branch, 2, 1, 'two-\xc2\xb5', 'one-\xc2\xb5')
222
        self.assertEqual([expected_params], hook_calls)
223
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
224
    def test_branch_is_locked(self):
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
225
        """The branch passed to the hook is locked."""
226
        branch = self.make_branch('source')
227
        def assertBranchIsLocked(params):
228
            self.assertTrue(params.branch.is_locked())
229
        Branch.hooks.install_named_hook(
3517.2.4 by Andrew Bennetts
Fix typo.
230
            'post_change_branch_tip', assertBranchIsLocked, None)
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
231
        branch.set_last_revision_info(0, NULL_REVISION)
232
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
233
    def test_calls_all_hooks_no_errors(self):
234
        """If multiple hooks are registered, all are called (if none raise
235
        errors).
236
        """
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
237
        branch = self.make_branch('source')
3517.2.5 by Andrew Bennetts
Reduce duplication in test_hooks a little.
238
        hook_calls_1 = self.install_logging_hook('post')
239
        hook_calls_2 = self.install_logging_hook('post')
3517.2.3 by Andrew Bennetts
Better tests for {pre,post}_change_branch_tip hooks.
240
        self.assertIsNot(hook_calls_1, hook_calls_2)
241
        branch.set_last_revision_info(0, NULL_REVISION)
242
        # Both hooks are called.
243
        self.assertEqual(len(hook_calls_1), 1)
244
        self.assertEqual(len(hook_calls_2), 1)