/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
2374.2.2 by John Arbash Meinel
Fix the small bug that ie.snapshot() didn't think about kind changes.
1
# Copyright (C) 2005, 2006, 2007 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
1551.8.30 by Aaron Bentley
Tweak from review comments
63
    tree,
64
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
65
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
66
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
67
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
68
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
69
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
70
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
71
from bzrlib.osutils import (get_user_encoding,
72
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
73
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
74
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
75
                            quotefn, sha_file, split_lines,
76
                            splitpath,
77
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
78
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
79
from bzrlib.trace import mutter, note, warning, is_quiet
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
80
from bzrlib.inventory import InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
81
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
82
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
83
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
84
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
85
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
86
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
87
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
88
89
90
class NullCommitReporter(object):
91
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
92
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
93
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
94
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
95
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
96
                                   "to started.", DeprecationWarning,
97
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
98
        pass
99
100
    def snapshot_change(self, change, path):
101
        pass
102
103
    def completed(self, revno, rev_id):
104
        pass
105
106
    def deleted(self, file_id):
107
        pass
108
109
    def escaped(self, escape_count, message):
110
        pass
111
112
    def missing(self, path):
113
        pass
114
115
    def renamed(self, change, old_path, new_path):
116
        pass
117
2789.2.11 by Ian Clatworthy
remove more reporting stuff
118
    def is_verbose(self):
119
        return False
120
121
122
class ReportCommitToLog(NullCommitReporter):
123
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
124
    def _note(self, format, *args):
125
        """Output a message.
126
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
127
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
128
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
129
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
130
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
131
    def snapshot_change(self, change, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
132
        if change == 'unchanged':
133
            return
134
        if change == 'added' and path == '':
135
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
136
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
137
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
138
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
139
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
140
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
141
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
142
            # When started was added, location was only made optional by
143
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
144
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
145
                                   "to started.", DeprecationWarning,
146
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
147
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
148
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
149
150
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
151
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
152
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
153
    def deleted(self, file_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
154
        self._note('deleted %s', file_id)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
155
156
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
157
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
158
159
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
160
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
162
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
163
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
164
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
165
    def is_verbose(self):
166
        return True
167
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
168
1189 by Martin Pool
- BROKEN: partial support for commit into weave
169
class Commit(object):
170
    """Task of committing a new revision.
171
172
    This is a MethodObject: it accumulates state as the commit is
173
    prepared, and then it is discarded.  It doesn't represent
174
    historical revisions, just the act of recording a new one.
175
176
            missing_ids
177
            Modified to hold a list of files that have been deleted from
178
            the working directory; these should be removed from the
179
            working inventory.
485 by Martin Pool
- move commit code into its own module
180
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
181
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
182
                 reporter=None,
183
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
184
        """Create a Commit object.
185
186
        :param reporter: the default reporter to use or None to decide later
187
        """
188
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
189
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
190
1189 by Martin Pool
- BROKEN: partial support for commit into weave
191
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
192
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
193
               timestamp=None,
194
               timezone=None,
195
               committer=None,
196
               specific_files=None,
197
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
198
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
199
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
200
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
201
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
202
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
203
               local=False,
204
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
205
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
206
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
207
               recursive='down',
208
               exclude=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
        """Commit working copy as a new revision.
210
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
211
        :param message: the commit message (it or message_callback is required)
212
213
        :param timestamp: if not None, seconds-since-epoch for a
214
            postdated/predated commit.
215
216
        :param specific_files: If true, commit only those files.
217
218
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
219
            Useful for test or import commands that need to tightly
220
            control what revisions are assigned.  If you duplicate
221
            a revision id that exists elsewhere it is your own fault.
222
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
223
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
224
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
225
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
226
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
227
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
228
            contains unknown files.
229
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
230
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
231
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
232
        :param reporter: the reporter to use or None for the default
233
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
234
        :param recursive: If set to 'down', commit in any subtrees that have
235
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
236
        :param exclude: None or a list of relative paths to exclude from the
237
            commit. Pending changes to excluded files will be ignored by the
238
            commit. 
1189 by Martin Pool
- BROKEN: partial support for commit into weave
239
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
240
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
242
        if working_tree is None:
243
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
244
        else:
245
            self.work_tree = working_tree
246
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
247
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
248
                if not self.branch.repository.supports_rich_root():
249
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
250
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
251
            if message is not None:
252
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
253
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
254
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
255
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
256
                raise BzrError("The message or message_callback keyword"
257
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
258
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
259
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
260
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
261
        if exclude is not None:
262
            self.exclude = sorted(
263
                minimum_path_selection(exclude))
264
        else:
265
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
266
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
267
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
268
        self.master_locked = False
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
269
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
270
        self.rev_id = None
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
271
        if specific_files is not None:
272
            self.specific_files = sorted(
273
                minimum_path_selection(specific_files))
274
        else:
275
            self.specific_files = None
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
276
        self.specific_file_ids = None
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
277
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
278
        self.revprops = revprops
279
        self.message_callback = message_callback
280
        self.timestamp = timestamp
281
        self.timezone = timezone
282
        self.committer = committer
283
        self.strict = strict
284
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
285
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
286
        self.work_tree.lock_write()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
287
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
288
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
289
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
290
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
291
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
292
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
293
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
294
                raise ConflictsInTree
295
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
296
            # Setup the bound branch variables as needed.
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
297
            self._check_bound_branch()
298
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
299
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
300
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
301
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
302
            # Complete configuration setup
303
            if reporter is not None:
304
                self.reporter = reporter
305
            elif self.reporter is None:
306
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
307
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
308
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
309
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
310
            # If provided, ensure the specified files are versioned
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
311
            if self.specific_files is not None:
2776.4.13 by Robert Collins
Merge bzr.dev.
312
                # Note: This routine is being called because it raises
2776.4.14 by Robert Collins
Merge bzr.dev.
313
                # PathNotVersionedError as a side effect of finding the IDs. We
2776.4.13 by Robert Collins
Merge bzr.dev.
314
                # later use the ids we found as input to the working tree
315
                # inventory iterator, so we only consider those ids rather than
316
                # examining the whole tree again.
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
317
                # XXX: Dont we have filter_unversioned to do this more
318
                # cheaply?
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
319
                self.specific_file_ids = tree.find_ids_across_trees(
320
                    specific_files, [self.basis_tree, self.work_tree])
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
321
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
322
            # Setup the progress bar. As the number of files that need to be
323
            # committed in unknown, progress is reported as stages.
324
            # We keep track of entries separately though and include that
325
            # information in the progress bar during the relevant stages.
326
            self.pb_stage_name = ""
327
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
328
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
329
            if self.bound_branch:
330
                self.pb_stage_total += 1
331
            self.pb.show_pct = False
332
            self.pb.show_spinner = False
333
            self.pb.show_eta = False
334
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
335
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
336
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
337
            self.basis_inv = self.basis_tree.inventory
338
            self._gather_parents()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
339
            # After a merge, a selected file commit is not supported.
340
            # See 'bzr help merge' for an explanation as to why.
1344 by Martin Pool
- disallow selected-file commit of merges
341
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
342
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
343
            # Excludes are a form of selected file commit.
344
            if len(self.parents) > 1 and self.exclude:
345
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
346
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
347
            # Collect the changes
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
348
            self._set_progress_stage("Collecting changes",
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
349
                    entries_title="Directory")
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
350
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
351
                self.config, timestamp, timezone, committer, revprops, rev_id)
2659.3.5 by NamNguyen
merge with bzr.dev
352
            
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
353
            try:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
354
                self.builder.recording_deletes()
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
355
                # find the location being committed to
356
                if self.bound_branch:
357
                    master_location = self.master_branch.base
358
                else:
359
                    master_location = self.branch.base
360
361
                # report the start of the commit
362
                self.reporter.started(new_revno, self.rev_id, master_location)
363
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
364
                self._update_builder_with_changes()
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
365
                self._report_and_accumulate_deletes()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
366
                self._check_pointless()
367
368
                # TODO: Now the new inventory is known, check for conflicts.
369
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
370
                # weave lines, because nothing should be recorded until it is known
371
                # that commit will succeed.
2592.3.49 by Robert Collins
Merge bzr.dev.
372
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
373
                self.builder.finish_inventory()
374
375
                # Prompt the user for a commit message if none provided
376
                message = message_callback(self)
377
                self.message = message
378
                self._escape_commit_message()
379
380
                # Add revision data to the local branch
381
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
382
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
383
            except:
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
384
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
385
                raise
386
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
387
            self._process_pre_hooks(old_revno, new_revno)
388
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
389
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
390
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
391
            if self.bound_branch:
3113.6.7 by Aaron Bentley
Fix commit for a checkout sharing a repo with its branch (abentley, #177592)
392
                if not self.master_branch.repository.has_same_location(
393
                        self.branch.repository):
394
                    self._set_progress_stage("Uploading data to master branch")
395
                    self.master_branch.repository.fetch(self.branch.repository,
396
                        revision_id=self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
397
                # now the master has the revision data
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
398
                # 'commit' to the master first so a timeout here causes the
399
                # local branch to be out of date
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
400
                self.master_branch.set_last_revision_info(new_revno,
401
                                                          self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
402
403
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
404
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
405
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
406
            # Make the working tree up to date with the branch
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
407
            self._set_progress_stage("Updating the working tree")
2929.2.1 by Robert Collins
* Commit updates the state of the working tree via a delta rather than
408
            self.work_tree.update_basis_by_delta(self.rev_id,
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
409
                 self.builder.basis_delta)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
410
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
411
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
412
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
413
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
414
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
415
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
416
    def _select_reporter(self):
417
        """Select the CommitReporter to use."""
418
        if is_quiet():
419
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
420
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
421
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
422
    def _check_pointless(self):
423
        if self.allow_pointless:
424
            return
425
        # A merge with no effect on files
426
        if len(self.parents) > 1:
427
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
428
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
429
2921.4.6 by Robert Collins
Typos found by Rob Weir.
430
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
431
        # a worthwhile commit.
432
        if (self.basis_revid == revision.NULL_REVISION and
433
            len(self.builder.new_inventory) == 1):
1731.1.49 by Aaron Bentley
Merge bzr.dev
434
            raise PointlessCommit()
2044.1.1 by Robert Collins
(Robert Collins) Forward merge from 0.11rc2 NEWS and performance-regression fix.
435
        # If length == 1, then we only have the root entry. Which means
436
        # that there is no real difference (only the root could be different)
2921.4.7 by Robert Collins
Correct the check_pointless change to pass all tests.
437
        # unless deletes occured, in which case the length is irrelevant.
438
        if (self.any_entries_deleted or 
439
            (len(self.builder.new_inventory) != 1 and
3775.2.9 by Robert Collins
CommitBuilder handles deletes via record_iter_entries.
440
             self.builder.any_changes())):
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
441
            return
442
        raise PointlessCommit()
443
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
444
    def _check_bound_branch(self):
445
        """Check to see if the local branch is bound.
446
447
        If it is bound, then most of the commit will actually be
448
        done using the remote branch as the target branch.
449
        Only at the end will the local branch be updated.
450
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
451
        if self.local and not self.branch.get_bound_location():
452
            raise errors.LocalRequiresBoundBranch()
453
454
        if not self.local:
455
            self.master_branch = self.branch.get_master_branch()
456
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
457
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
458
            # make this branch the reference branch for out of date checks.
459
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
460
            return
461
462
        # If the master branch is bound, we must fail
463
        master_bound_location = self.master_branch.get_bound_location()
464
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
465
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
466
                    self.master_branch, master_bound_location)
467
468
        # TODO: jam 20051230 We could automatically push local
469
        #       commits to the remote branch if they would fit.
470
        #       But for now, just require remote to be identical
471
        #       to local.
472
        
473
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
474
        master_info = self.master_branch.last_revision_info()
475
        local_info = self.branch.last_revision_info()
476
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
477
            raise errors.BoundBranchOutOfDate(self.branch,
478
                    self.master_branch)
479
480
        # Now things are ready to change the master branch
481
        # so grab the lock
482
        self.bound_branch = self.branch
483
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
484
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
485
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
486
    def _check_out_of_date_tree(self):
487
        """Check that the working tree is up to date.
488
489
        :return: old_revision_number,new_revision_number tuple
490
        """
491
        try:
492
            first_tree_parent = self.work_tree.get_parent_ids()[0]
493
        except IndexError:
494
            # if there are no parents, treat our parent as 'None'
495
            # this is so that we still consider the master branch
496
            # - in a checkout scenario the tree may have no
497
            # parents but the branch may do.
498
            first_tree_parent = bzrlib.revision.NULL_REVISION
499
        old_revno, master_last = self.master_branch.last_revision_info()
500
        if master_last != first_tree_parent:
501
            if master_last != bzrlib.revision.NULL_REVISION:
502
                raise errors.OutOfDateTree(self.work_tree)
503
        if self.branch.repository.has_revision(first_tree_parent):
504
            new_revno = old_revno + 1
505
        else:
506
            # ghost parents never appear in revision history.
507
            new_revno = 1
508
        return old_revno,new_revno
509
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
510
    def _process_pre_hooks(self, old_revno, new_revno):
511
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
512
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
513
        self._process_hooks("pre_commit", old_revno, new_revno)
514
515
    def _process_post_hooks(self, old_revno, new_revno):
516
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
517
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
518
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
519
        # old style commit hooks - should be deprecated ? (obsoleted in
520
        # 0.15)
521
        if self.config.post_commit() is not None:
522
            hooks = self.config.post_commit().split(' ')
523
            # this would be nicer with twisted.python.reflect.namedAny
524
            for hook in hooks:
525
                result = eval(hook + '(branch, rev_id)',
526
                              {'branch':self.branch,
527
                               'bzrlib':bzrlib,
528
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
529
        # process new style post commit hooks
530
        self._process_hooks("post_commit", old_revno, new_revno)
531
532
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
533
        if not Branch.hooks[hook_name]:
534
            return
535
        
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
536
        # new style commit hooks:
537
        if not self.bound_branch:
538
            hook_master = self.branch
539
            hook_local = None
540
        else:
541
            hook_master = self.master_branch
542
            hook_local = self.branch
543
        # With bound branches, when the master is behind the local branch,
544
        # the 'old_revno' and old_revid values here are incorrect.
545
        # XXX: FIXME ^. RBC 20060206
546
        if self.parents:
547
            old_revid = self.parents[0]
548
        else:
549
            old_revid = bzrlib.revision.NULL_REVISION
2659.3.9 by NamNguyen
branch.py:
550
        
551
        if hook_name == "pre_commit":
552
            future_tree = self.builder.revision_tree()
553
            tree_delta = future_tree.changes_from(self.basis_tree,
554
                                             include_root=True)
555
        
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
556
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
557
            # show the running hook in the progress bar. As hooks may
558
            # end up doing nothing (e.g. because they are not configured by
559
            # the user) this is still showing progress, not showing overall
560
            # actions - its up to each plugin to show a UI if it want's to
561
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
562
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
563
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
564
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
565
            if 'hooks' in debug.debug_flags:
566
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
567
            if hook_name == "post_commit":
568
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
569
                     self.rev_id)
570
            elif hook_name == "pre_commit":
571
                hook(hook_local, hook_master,
572
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
573
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
574
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
575
    def _cleanup(self):
576
        """Cleanup any open locks, progress bars etc."""
577
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
578
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
579
                    self.work_tree.unlock,
580
                    self.pb.finished]
581
        found_exception = None
582
        for cleanup in cleanups:
583
            try:
584
                cleanup()
585
            # we want every cleanup to run no matter what.
586
            # so we have a catchall here, but we will raise the
587
            # last encountered exception up the stack: and
588
            # typically this will be useful enough.
589
            except Exception, e:
590
                found_exception = e
591
        if found_exception is not None: 
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
592
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
593
            # trashed, e is our sure-to-work exception even though it loses the
594
            # full traceback. XXX: RBC 20060421 perhaps we could check the
595
            # exc_info and if its the same one do a plain raise otherwise 
596
            # 'raise e' as we do now.
597
            raise e
598
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
599
    def _cleanup_bound_branch(self):
600
        """Executed at the end of a try/finally to cleanup a bound branch.
601
602
        If the branch wasn't bound, this is a no-op.
603
        If it was, it resents self.branch to the local branch, instead
604
        of being the master.
605
        """
606
        if not self.bound_branch:
607
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
608
        if self.master_locked:
609
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
610
1390 by Robert Collins
pair programming worx... merge integration and weave
611
    def _escape_commit_message(self):
612
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
613
        # FIXME: RBC 20060419 this should be done by the revision
614
        # serialiser not by commit. Then we can also add an unescaper
615
        # in the deserializer and start roundtripping revision messages
616
        # precisely. See repository_implementations/test_repository.py
617
        
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
618
        # Python strings can include characters that can't be
619
        # represented in well-formed XML; escape characters that
620
        # aren't listed in the XML specification
621
        # (http://www.w3.org/TR/REC-xml/#NT-Char).
1390 by Robert Collins
pair programming worx... merge integration and weave
622
        self.message, escape_count = re.subn(
1393.4.2 by Harald Meland
Cleanup + better test of commit-msg control character escape code.
623
            u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
624
            lambda match: match.group(0).encode('unicode_escape'),
1390 by Robert Collins
pair programming worx... merge integration and weave
625
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
626
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
627
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
628
629
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
630
        """Record the parents of a merge for merge detection."""
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
631
        # TODO: Make sure that this list doesn't contain duplicate 
632
        # entries and the order is preserved when doing this.
1773.2.1 by Robert Collins
Teach all trees about unknowns, conflicts and get_parent_ids.
633
        self.parents = self.work_tree.get_parent_ids()
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
634
        self.parent_invs = [self.basis_inv]
635
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
636
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
637
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
638
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
639
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
640
            else:
641
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
642
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
643
    def _update_builder_with_changes(self):
644
        """Update the commit builder with the data about what has changed.
645
        """
646
        # Build the revision inventory.
647
        #
648
        # This starts by creating a new empty inventory. Depending on
649
        # which files are selected for commit, and what is present in the
650
        # current tree, the new inventory is populated. inventory entries 
651
        # which are candidates for modification have their revision set to
652
        # None; inventory entries that are carried over untouched have their
653
        # revision set to their prior value.
654
        #
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
655
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
656
        # results to create a new inventory at the same time, which results
1852.10.3 by Robert Collins
Remove all uses of compare_trees and replace with Tree.changes_from throughout bzrlib.
657
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
658
        # ADHB 11-07-2006
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
659
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
660
        exclude = self.exclude
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
661
        specific_files = self.specific_files or []
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
662
        mutter("Selecting files for commit with filter %s", specific_files)
663
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
664
        # Build the new inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
665
        self._populate_from_inventory()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
666
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
667
        # If specific files are selected, then all un-selected files must be
668
        # recorded in their previous state. For more details, see
669
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
670
        if specific_files or exclude:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
671
            for path, old_ie in self.basis_inv.iter_entries():
672
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
673
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
674
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
675
                if (is_inside_any(specific_files, path)
676
                    and not is_inside_any(exclude, path)):
677
                    # was inside the selected path, and not excluded - if not
678
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
679
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
680
                # From here down it was either not selected, or was excluded:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
681
                if old_ie.kind == 'directory':
682
                    self._next_progress_entry()
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
683
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
684
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
685
                # Note: specific file commits after a merge are currently
686
                # prohibited. This test is for sanity/safety in case it's
687
                # required after that changes.
688
                if len(self.parents) > 1:
689
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
690
                self.builder.record_entry_contents(ie, self.parent_invs, path,
691
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
692
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
693
    def _report_and_accumulate_deletes(self):
2903.2.6 by Martin Pool
Remove unnecessary double handling of deletions
694
        # XXX: Could the list of deleted paths and ids be instead taken from
695
        # _populate_from_inventory?
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
696
        deleted_ids = set(self.basis_inv._byid.keys()) - \
697
            set(self.builder.new_inventory._byid.keys())
698
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
699
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
700
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
701
                for file_id in deleted_ids]
702
            deleted.sort()
703
            # XXX: this is not quite directory-order sorting
704
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
705
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
706
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
707
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
708
    def _populate_from_inventory(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
709
        """Populate the CommitBuilder by walking the working tree inventory."""
710
        if self.strict:
711
            # raise an exception as soon as we find a single unknown.
712
            for unknown in self.work_tree.unknowns():
713
                raise StrictCommitFailed()
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
714
        
715
        specific_files = self.specific_files
716
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
717
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
718
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
719
        # A tree of paths that have been deleted. E.g. if foo/bar has been
720
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
721
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
722
        # XXX: Note that entries may have the wrong kind because the entry does
723
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
724
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
725
        # NB: entries will include entries within the excluded ids/paths
726
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
727
        entries = work_inv.iter_entries_by_dir(
728
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
729
        for path, existing_ie in entries:
730
            file_id = existing_ie.file_id
731
            name = existing_ie.name
732
            parent_id = existing_ie.parent_id
733
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
734
            if kind == 'directory':
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
735
                self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
736
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
737
            # The deleted path ids are also recorded so they can be explicitly
738
            # unversioned later.
739
            if deleted_paths:
740
                path_segments = splitpath(path)
741
                deleted_dict = deleted_paths
742
                for segment in path_segments:
743
                    deleted_dict = deleted_dict.get(segment, None)
744
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
745
                        # We either took a path not present in the dict
746
                        # (deleted_dict was None), or we've reached an empty
747
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
748
                        break
749
                else:
750
                    deleted_dict = None
751
                if deleted_dict is not None:
752
                    # the path has a deleted parent, do not add it.
753
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
754
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
755
                # Skip excluded paths. Excluded paths are processed by
756
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
757
                continue
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
758
            content_summary = self.work_tree.path_content_summary(path)
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
759
            # Note that when a filter of specific files is given, we must only
760
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
761
            if not specific_files or is_inside_any(specific_files, path):
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
762
                if content_summary[0] == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
763
                    if not deleted_paths:
764
                        # path won't have been split yet.
765
                        path_segments = splitpath(path)
766
                    deleted_dict = deleted_paths
767
                    for segment in path_segments:
768
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
769
                    self.reporter.missing(path)
770
                    deleted_ids.append(file_id)
771
                    continue
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
772
            # TODO: have the builder do the nested commit just-in-time IF and
773
            # only if needed.
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
774
            if content_summary[0] == 'tree-reference':
775
                # enforce repository nested tree policy.
776
                if (not self.work_tree.supports_tree_reference() or
777
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
778
                    not self.branch.repository._format.supports_tree_reference):
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
779
                    content_summary = ('directory',) + content_summary[1:]
780
            kind = content_summary[0]
781
            # TODO: specific_files filtering before nested tree processing
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
782
            if kind == 'tree-reference':
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
783
                if self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
784
                    nested_revision_id = self._commit_nested_tree(
785
                        file_id, path)
786
                    content_summary = content_summary[:3] + (
787
                        nested_revision_id,)
788
                else:
789
                    content_summary = content_summary[:3] + (
790
                        self.work_tree.get_reference_revision(file_id),)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
791
792
            # Record an entry for this item
793
            # Note: I don't particularly want to have the existing_ie
794
            # parameter but the test suite currently (28-Jun-07) breaks
795
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
796
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
797
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
798
                parent_id, definitely_changed, existing_ie, report_changes,
799
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
800
801
        # Unversion IDs that were found to be deleted
802
        self.work_tree.unversion(deleted_ids)
803
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
804
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
805
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
806
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
807
        # FIXME: be more comprehensive here:
808
        # this works when both trees are in --trees repository,
809
        # but when both are bound to a different repository,
810
        # it fails; a better way of approaching this is to 
811
        # finally implement the explicit-caches approach design
812
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
813
        if sub_tree.branch.repository.has_same_location(
814
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
815
            sub_tree.branch.repository = \
816
                self.work_tree.branch.repository
817
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
818
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
819
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
820
                message_callback=self.message_callback,
821
                timestamp=self.timestamp, timezone=self.timezone,
822
                committer=self.committer,
823
                allow_pointless=self.allow_pointless,
824
                strict=self.strict, verbose=self.verbose,
825
                local=self.local, reporter=self.reporter)
826
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
827
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
828
829
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
830
        parent_id, definitely_changed, existing_ie, report_changes,
831
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
832
        "Record the new inventory entry for a path if any."
833
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
834
        # mutter('%s selected for commit', path)
835
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
836
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
837
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
838
            ie = existing_ie.copy()
839
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
840
        # For carried over entries we don't care about the fs hash - the repo
841
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
842
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
843
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
844
        if report_changes:
845
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
846
        if fs_hash:
847
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
848
        return ie
849
850
    def _report_change(self, ie, path):
851
        """Report a change to the user.
852
853
        The change that has occurred is described relative to the basis
854
        inventory.
855
        """
856
        if (self.basis_inv.has_id(ie.file_id)):
857
            basis_ie = self.basis_inv[ie.file_id]
858
        else:
859
            basis_ie = None
860
        change = ie.describe_change(basis_ie, ie)
861
        if change in (InventoryEntry.RENAMED, 
862
            InventoryEntry.MODIFIED_AND_RENAMED):
863
            old_path = self.basis_inv.id2path(ie.file_id)
864
            self.reporter.renamed(change, old_path, path)
865
        else:
866
            self.reporter.snapshot_change(change, path)
867
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
868
    def _set_progress_stage(self, name, entries_title=None):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
869
        """Set the progress stage and emit an update to the progress bar."""
870
        self.pb_stage_name = name
871
        self.pb_stage_count += 1
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
872
        self.pb_entries_title = entries_title
873
        if entries_title is not None:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
874
            self.pb_entries_count = 0
875
            self.pb_entries_total = '?'
876
        self._emit_progress()
877
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
878
    def _next_progress_entry(self):
879
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
880
        self.pb_entries_count += 1
881
        self._emit_progress()
882
883
    def _emit_progress(self):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
884
        if self.pb_entries_title:
885
            if self.pb_entries_total == '?':
886
                text = "%s [%s %d] - Stage" % (self.pb_stage_name,
887
                    self.pb_entries_title, self.pb_entries_count)
888
            else:
889
                text = "%s [%s %d/%s] - Stage" % (self.pb_stage_name,
890
                    self.pb_entries_title, self.pb_entries_count,
891
                    str(self.pb_entries_total))
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
892
        else:
893
            text = "%s - Stage" % (self.pb_stage_name)
894
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
895