/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
3224.5.8 by Andrew Bennetts
Fix failing tests.
1
# Copyright (C) 2006, 2007 Canonical Ltd
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
17
"""Basic server-side logic for dealing with requests.
18
19
**XXX**:
20
21
The class names are a little confusing: the protocol will instantiate a
22
SmartServerRequestHandler, whose dispatch_command method creates an instance of
23
a SmartServerRequest subclass.
24
25
The request_handlers registry tracks SmartServerRequest classes (rather than
26
SmartServerRequestHandler).
27
"""
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
28
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
29
import tempfile
30
2402.1.2 by Andrew Bennetts
Deal with review comments.
31
from bzrlib import (
32
    bzrdir,
33
    errors,
34
    registry,
35
    revision,
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
36
    urlutils,
2402.1.2 by Andrew Bennetts
Deal with review comments.
37
    )
3224.5.6 by Andrew Bennetts
Don't import bzrlib.bundle in bzrlib.smart.request until it's needed.
38
from bzrlib.lazy_import import lazy_import
39
lazy_import(globals(), """
40
from bzrlib.bundle import serializer
41
""")
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
42
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
43
44
class SmartServerRequest(object):
2692.1.10 by Andrew Bennetts
More docstring polish
45
    """Base class for request handlers.
46
    
47
    To define a new request, subclass this class and override the `do` method
48
    (and if appropriate, `do_body` as well).  Request implementors should take
49
    care to call `translate_client_path` and `transport_from_client_path` as
50
    appropriate when dealing with paths received from the client.
51
    """
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
52
    # XXX: rename this class to BaseSmartServerRequestHandler ?  A request
53
    # *handler* is a different concept to the request.
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
54
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
55
    def __init__(self, backing_transport, root_client_path='/'):
2402.1.2 by Andrew Bennetts
Deal with review comments.
56
        """Constructor.
57
58
        :param backing_transport: the base transport to be used when performing
59
            this request.
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
60
        :param root_client_path: the client path that maps to the root of
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
61
            backing_transport.  This is used to interpret relpaths received
62
            from the client.  Clients will not be able to refer to paths above
2692.1.16 by Andrew Bennetts
Improve comments.
63
            this root.  If root_client_path is None, then no translation will
64
            be performed on client paths.  Default is '/'.
2402.1.2 by Andrew Bennetts
Deal with review comments.
65
        """
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
66
        self._backing_transport = backing_transport
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
67
        if root_client_path is not None:
68
            if not root_client_path.startswith('/'):
69
                root_client_path = '/' + root_client_path
70
            if not root_client_path.endswith('/'):
71
                root_client_path += '/'
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
72
        self._root_client_path = root_client_path
3842.3.19 by Andrew Bennetts
Tweaks suggested by review.
73
        self._body_chunks = []
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
74
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
75
    def _check_enabled(self):
76
        """Raises DisabledMethod if this method is disabled."""
77
        pass
78
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
79
    def do(self, *args):
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
80
        """Mandatory extension point for SmartServerRequest subclasses.
81
        
82
        Subclasses must implement this.
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
83
        
84
        This should return a SmartServerResponse if this command expects to
85
        receive no body.
86
        """
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
87
        raise NotImplementedError(self.do)
88
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
89
    def execute(self, *args):
90
        """Public entry point to execute this request.
91
92
        It will return a SmartServerResponse if the command does not expect a
93
        body.
94
95
        :param *args: the arguments of the request.
96
        """
97
        self._check_enabled()
98
        return self.do(*args)
99
2018.5.5 by Andrew Bennetts
Pass body_bytes directly to SmartServerRequest.do_body
100
    def do_body(self, body_bytes):
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
101
        """Called if the client sends a body with the request.
3184.1.10 by Robert Collins
Change the smart server verb for Repository.stream_revisions_chunked to use SearchResults as the request mechanism for downloads.
102
103
        The do() method is still called, and must have returned None.
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
104
        
105
        Must return a SmartServerResponse.
106
        """
2018.5.4 by Andrew Bennetts
Split smart server VFS logic out into a new file, and start using the command pattern in the SmartServerRequestHandler.
107
        raise NotImplementedError(self.do_body)
108
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
109
    def do_chunk(self, chunk_bytes):
110
        """Called with each body chunk if the request has a streamed body.
111
112
        The do() method is still called, and must have returned None.
113
        """
3842.3.19 by Andrew Bennetts
Tweaks suggested by review.
114
        self._body_chunks.append(chunk_bytes)
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
115
116
    def do_end(self):
117
        """Called when the end of the request has been received."""
3842.3.19 by Andrew Bennetts
Tweaks suggested by review.
118
        body_bytes = ''.join(self._body_chunks)
119
        self._body_chunks = None
3923.5.2 by Andrew Bennetts
Completely delegate handling of request body chunks to the command object. The default implementation accumulates, like the existing behaviour.
120
        return self.do_body(body_bytes)
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
121
    
122
    def translate_client_path(self, client_path):
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
123
        """Translate a path received from a network client into a local
124
        relpath.
125
126
        All paths received from the client *must* be translated.
127
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
128
        :param client_path: the path from the client.
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
129
        :returns: a relpath that may be used with self._backing_transport
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
130
            (unlike the untranslated client_path, which must not be used with
131
            the backing transport).
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
132
        """
2692.1.14 by Andrew Bennetts
All WSGI tests passing, and manual testing works too.
133
        if self._root_client_path is None:
134
            # no translation necessary!
135
            return client_path
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
136
        if not client_path.startswith('/'):
137
            client_path = '/' + client_path
138
        if client_path.startswith(self._root_client_path):
139
            path = client_path[len(self._root_client_path):]
140
            relpath = urlutils.joinpath('/', path)
3376.2.4 by Martin Pool
Remove every assert statement from bzrlib!
141
            if not relpath.startswith('/'):
142
                raise ValueError(relpath)
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
143
            return '.' + relpath
144
        else:
145
            raise errors.PathNotChild(client_path, self._root_client_path)
146
147
    def transport_from_client_path(self, client_path):
2692.1.9 by Andrew Bennetts
Docstrings for translate_client_path and transport_from_client_path.
148
        """Get a backing transport corresponding to the location referred to by
149
        a network client.
150
151
        :seealso: translate_client_path
152
        :returns: a transport cloned from self._backing_transport
153
        """
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
154
        relpath = self.translate_client_path(client_path)
2692.1.16 by Andrew Bennetts
Improve comments.
155
        return self._backing_transport.clone(relpath)
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
156
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
157
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
158
class SmartServerResponse(object):
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
159
    """A response to a client request.
160
    
161
    This base class should not be used. Instead use
162
    SuccessfulSmartServerResponse and FailedSmartServerResponse as appropriate.
163
    """
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
164
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
165
    def __init__(self, args, body=None, body_stream=None):
166
        """Constructor.
167
168
        :param args: tuple of response arguments.
169
        :param body: string of a response body.
170
        :param body_stream: iterable of bytestrings to be streamed to the
171
            client.
172
        """
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
173
        self.args = args
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
174
        if body is not None and body_stream is not None:
175
            raise errors.BzrError(
176
                "'body' and 'body_stream' are mutually exclusive.")
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
177
        self.body = body
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
178
        self.body_stream = body_stream
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
179
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
180
    def __eq__(self, other):
181
        if other is None:
182
            return False
2748.4.2 by Andrew Bennetts
Add protocol (version two) support for streaming bodies (using chunking) in responses.
183
        return (other.args == self.args and
184
                other.body == self.body and
185
                other.body_stream is self.body_stream)
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
186
187
    def __repr__(self):
3691.2.6 by Martin Pool
Disable RemoteBranch stacking, but get get_stacked_on_url working, and passing back exceptions
188
        return "<%s args=%r body=%r>" % (self.__class__.__name__,
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
189
            self.args, self.body)
2402.1.1 by Andrew Bennetts
Use the Command pattern for handling smart server commands.
190
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
191
2432.4.2 by Robert Collins
Add FailedSmartServerResponse.
192
class FailedSmartServerResponse(SmartServerResponse):
193
    """A SmartServerResponse for a request which failed."""
194
195
    def is_successful(self):
196
        """FailedSmartServerResponse are not successful."""
197
        return False
198
199
2432.4.1 by Robert Collins
Add SuccessfulSmartServerResponse.
200
class SuccessfulSmartServerResponse(SmartServerResponse):
201
    """A SmartServerResponse for a successfully completed request."""
202
203
    def is_successful(self):
204
        """SuccessfulSmartServerResponse are successful."""
205
        return True
206
2018.5.16 by Andrew Bennetts
Move SmartServerResponse to smart/request.py, untangling more import dependencies.
207
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
208
class SmartServerRequestHandler(object):
209
    """Protocol logic for smart server.
210
    
211
    This doesn't handle serialization at all, it just processes requests and
212
    creates responses.
213
    """
214
215
    # IMPORTANT FOR IMPLEMENTORS: It is important that SmartServerRequestHandler
216
    # not contain encoding or decoding logic to allow the wire protocol to vary
217
    # from the object protocol: we will want to tweak the wire protocol separate
218
    # from the object model, and ideally we will be able to do that without
219
    # having a SmartServerRequestHandler subclass for each wire protocol, rather
220
    # just a Protocol subclass.
221
222
    # TODO: Better way of representing the body for commands that take it,
223
    # and allow it to be streamed into the server.
224
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
225
    def __init__(self, backing_transport, commands, root_client_path):
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
226
        """Constructor.
227
228
        :param backing_transport: a Transport to handle requests for.
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
229
        :param commands: a registry mapping command names to SmartServerRequest
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
230
            subclasses. e.g. bzrlib.transport.smart.vfs.vfs_commands.
231
        """
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
232
        self._backing_transport = backing_transport
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
233
        self._root_client_path = root_client_path
2018.5.17 by Andrew Bennetts
Paramaterise the commands handled by SmartServerRequestHandler.
234
        self._commands = commands
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
235
        self.response = None
236
        self.finished_reading = False
237
        self._command = None
238
239
    def accept_body(self, bytes):
240
        """Accept body data."""
3923.5.2 by Andrew Bennetts
Completely delegate handling of request body chunks to the command object. The default implementation accumulates, like the existing behaviour.
241
        self._run_handler_code(self._command.do_chunk, (bytes,), {})
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
242
        
243
    def end_of_body(self):
244
        """No more body data will be received."""
3923.5.2 by Andrew Bennetts
Completely delegate handling of request body chunks to the command object. The default implementation accumulates, like the existing behaviour.
245
        self._run_handler_code(self._command.do_end, (), {})
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
246
        # cannot read after this.
247
        self.finished_reading = True
248
249
    def dispatch_command(self, cmd, args):
250
        """Deprecated compatibility method.""" # XXX XXX
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
251
        try:
252
            command = self._commands.get(cmd)
253
        except LookupError:
3245.4.29 by Andrew Bennetts
Add/tidy some comments, remove dud test_errors_are_logged test, add explicit UnknownSmartMethod to v3.
254
            raise errors.UnknownSmartMethod(cmd)
2692.1.1 by Andrew Bennetts
Add translate_client_path method to SmartServerRequest.
255
        self._command = command(self._backing_transport, self._root_client_path)
2018.5.24 by Andrew Bennetts
Setting NO_SMART_VFS in environment will disable VFS methods in the smart server. (Robert Collins, John Arbash Meinel, Andrew Bennetts)
256
        self._run_handler_code(self._command.execute, args, {})
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
257
258
    def _run_handler_code(self, callable, args, kwargs):
259
        """Run some handler specific code 'callable'.
260
261
        If a result is returned, it is considered to be the commands response,
262
        and finished_reading is set true, and its assigned to self.response.
263
264
        Any exceptions caught are translated and a response object created
265
        from them.
266
        """
267
        result = self._call_converting_errors(callable, args, kwargs)
2018.5.19 by Andrew Bennetts
Add docstrings to all the new modules, and a few other places.
268
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
269
        if result is not None:
270
            self.response = result
271
            self.finished_reading = True
272
273
    def _call_converting_errors(self, callable, args, kwargs):
274
        """Call callable converting errors to Response objects."""
275
        # XXX: most of this error conversion is VFS-related, and thus ought to
276
        # be in SmartServerVFSRequestHandler somewhere.
277
        try:
278
            return callable(*args, **kwargs)
279
        except errors.NoSuchFile, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
280
            return FailedSmartServerResponse(('NoSuchFile', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
281
        except errors.FileExists, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
282
            return FailedSmartServerResponse(('FileExists', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
283
        except errors.DirectoryNotEmpty, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
284
            return FailedSmartServerResponse(('DirectoryNotEmpty', e.path))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
285
        except errors.ShortReadvError, e:
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
286
            return FailedSmartServerResponse(('ShortReadvError',
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
287
                e.path, str(e.offset), str(e.length), str(e.actual)))
3691.2.6 by Martin Pool
Disable RemoteBranch stacking, but get get_stacked_on_url working, and passing back exceptions
288
        except errors.UnstackableRepositoryFormat, e:
289
            return FailedSmartServerResponse(('UnstackableRepositoryFormat',
290
                str(e.format), e.url))
291
        except errors.UnstackableBranchFormat, e:
292
            return FailedSmartServerResponse(('UnstackableBranchFormat',
293
                str(e.format), e.url))
294
        except errors.NotStacked, e:
295
            return FailedSmartServerResponse(('NotStacked',))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
296
        except UnicodeError, e:
297
            # If it is a DecodeError, than most likely we are starting
298
            # with a plain string
299
            str_or_unicode = e.object
300
            if isinstance(str_or_unicode, unicode):
3779.3.1 by Andrew Bennetts
Move encoding/decoding logic of PermissionDenied and ReadError so that it happens for all RPCs.
301
                # XXX: UTF-8 might have \x01 (our protocol v1 and v2 seperator
302
                # byte) in it, so this encoding could cause broken responses.
303
                # Newer clients use protocol v3, so will be fine.
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
304
                val = 'u:' + str_or_unicode.encode('utf-8')
305
            else:
306
                val = 's:' + str_or_unicode.encode('base64')
307
            # This handles UnicodeEncodeError or UnicodeDecodeError
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
308
            return FailedSmartServerResponse((e.__class__.__name__,
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
309
                    e.encoding, val, str(e.start), str(e.end), e.reason))
310
        except errors.TransportNotPossible, e:
311
            if e.msg == "readonly transport":
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
312
                return FailedSmartServerResponse(('ReadOnlyError', ))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
313
            else:
314
                raise
3779.3.1 by Andrew Bennetts
Move encoding/decoding logic of PermissionDenied and ReadError so that it happens for all RPCs.
315
        except errors.ReadError, e:
316
            # cannot read the file
317
            return FailedSmartServerResponse(('ReadError', e.path))
318
        except errors.PermissionDenied, e:
319
            return FailedSmartServerResponse(
320
                ('PermissionDenied', e.path, e.extra))
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
321
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
322
    def headers_received(self, headers):
3245.4.33 by Andrew Bennetts
Remove unused no_body_received method on SmartServerRequestHandler.
323
        # Just a no-op at the moment.
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
324
        pass
325
326
    def args_received(self, args):
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
327
        cmd = args[0]
328
        args = args[1:]
329
        try:
330
            command = self._commands.get(cmd)
331
        except LookupError:
3245.4.48 by Andrew Bennetts
raise UnknownSmartMethod from dispatch_command.
332
            raise errors.UnknownSmartMethod(cmd)
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
333
        self._command = command(self._backing_transport)
334
        self._run_handler_code(self._command.execute, args, {})
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
335
3195.3.4 by Andrew Bennetts
Make the general request handler dispatch version 3 events to the specific request handler (i.e. to the SmartServerRequest instance).
336
    def end_received(self):
337
        self._run_handler_code(self._command.do_end, (), {})
3195.3.2 by Andrew Bennetts
Checkpoint first rough cut of SmartServerRequestProtocolThree, this implementation reuses the _StatefulDecoder class. Plus some attempts to start tidying the smart protocol tests.
338
3923.5.4 by Andrew Bennetts
Allow a request's body part(s) to be followed by an error.
339
    def post_body_error_received(self, error_args):
340
        # Just a no-op at the moment.
341
        pass
342
2018.5.14 by Andrew Bennetts
Move SmartTCPServer to smart/server.py, and SmartServerRequestHandler to smart/request.py.
343
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
344
class HelloRequest(SmartServerRequest):
2432.2.6 by Andrew Bennetts
Improve HelloRequest's docstring.
345
    """Answer a version request with the highest protocol version this server
346
    supports.
347
    """
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
348
349
    def do(self):
3245.4.59 by Andrew Bennetts
Various tweaks in response to Martin's review.
350
        return SuccessfulSmartServerResponse(('ok', '2'))
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
351
352
353
class GetBundleRequest(SmartServerRequest):
2402.1.2 by Andrew Bennetts
Deal with review comments.
354
    """Get a bundle of from the null revision to the specified revision."""
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
355
356
    def do(self, path, revision_id):
357
        # open transport relative to our base
2692.1.7 by Andrew Bennetts
Translate path in GetBundleRequest too.
358
        t = self.transport_from_client_path(path)
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
359
        control, extra_path = bzrdir.BzrDir.open_containing_from_transport(t)
360
        repo = control.open_repository()
361
        tmpf = tempfile.TemporaryFile()
362
        base_revision = revision.NULL_REVISION
3224.5.6 by Andrew Bennetts
Don't import bzrlib.bundle in bzrlib.smart.request until it's needed.
363
        serializer.write_bundle(repo, revision_id, base_revision, tmpf)
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
364
        tmpf.seek(0)
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
365
        return SuccessfulSmartServerResponse((), tmpf.read())
2018.5.6 by Andrew Bennetts
Tidy ups, and turn do_hello and do_get_bundle into command objects.
366
367
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
368
class SmartServerIsReadonly(SmartServerRequest):
369
    # XXX: this request method belongs somewhere else.
370
371
    def do(self):
372
        if self._backing_transport.is_readonly():
373
            answer = 'yes'
374
        else:
375
            answer = 'no'
2432.4.5 by Robert Collins
Make using SuccessfulSmartServerResponse and FailedSmartServerResponse mandatory rather than optional in smart server logic.
376
        return SuccessfulSmartServerResponse((answer,))
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
377
378
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
379
request_handlers = registry.Registry()
380
request_handlers.register_lazy(
381
    'append', 'bzrlib.smart.vfs', 'AppendRequest')
382
request_handlers.register_lazy(
2018.5.59 by Robert Collins
Get BranchConfig working somewhat on RemoteBranches (Robert Collins, Vincent Ladeuil).
383
    'Branch.get_config_file', 'bzrlib.smart.branch', 'SmartServerBranchGetConfigFile')
384
request_handlers.register_lazy(
3691.2.5 by Martin Pool
Add Branch.get_stacked_on_url rpc and tests for same
385
    'Branch.get_stacked_on_url', 'bzrlib.smart.branch', 'SmartServerBranchRequestGetStackedOnURL')
386
request_handlers.register_lazy(
2018.5.51 by Wouter van Heyst
Test and implement RemoteBranch.last_revision_info()
387
    'Branch.last_revision_info', 'bzrlib.smart.branch', 'SmartServerBranchRequestLastRevisionInfo')
388
request_handlers.register_lazy(
2018.5.79 by Andrew Bennetts
Implement RemoteBranch.lock_write/unlock as smart operations.
389
    'Branch.lock_write', 'bzrlib.smart.branch', 'SmartServerBranchRequestLockWrite')
390
request_handlers.register_lazy(
2018.5.38 by Robert Collins
Implement RemoteBranch.revision_history().
391
    'Branch.revision_history', 'bzrlib.smart.branch', 'SmartServerRequestRevisionHistory')
392
request_handlers.register_lazy(
2018.5.77 by Wouter van Heyst
Fix typo in request_handlers registration of Branch.set_last_revision, and test that registration
393
    'Branch.set_last_revision', 'bzrlib.smart.branch', 'SmartServerBranchRequestSetLastRevision')
2018.12.3 by Andrew Bennetts
Add a Branch.set_last_revision smart method, and make RemoteBranch.set_revision_history use it.
394
request_handlers.register_lazy(
2892.2.1 by Andrew Bennetts
Add Branch.set_last_revision_info smart method, and make the RemoteBranch client use it.
395
    'Branch.set_last_revision_info', 'bzrlib.smart.branch',
396
    'SmartServerBranchRequestSetLastRevisionInfo')
397
request_handlers.register_lazy(
3441.5.25 by Andrew Bennetts
Rename Branch.set_last_revision_descendant verb to Branch.set_last_revision_ex. It's a cop out, but at least it's not misleading.
398
    'Branch.set_last_revision_ex', 'bzrlib.smart.branch',
399
    'SmartServerBranchRequestSetLastRevisionEx')
3441.5.6 by Andrew Bennetts
Greatly simplify RemoteBranch.update_revisions. Still needs more tests.
400
request_handlers.register_lazy(
2018.5.79 by Andrew Bennetts
Implement RemoteBranch.lock_write/unlock as smart operations.
401
    'Branch.unlock', 'bzrlib.smart.branch', 'SmartServerBranchRequestUnlock')
402
request_handlers.register_lazy(
3221.3.2 by Robert Collins
* New remote method ``RemoteBzrDir.find_repositoryV2`` adding support for
403
    'BzrDir.find_repository', 'bzrlib.smart.bzrdir', 'SmartServerRequestFindRepositoryV1')
404
request_handlers.register_lazy(
405
    'BzrDir.find_repositoryV2', 'bzrlib.smart.bzrdir', 'SmartServerRequestFindRepositoryV2')
2018.5.34 by Robert Collins
Get test_remote.BasicRemoteObjectTests.test_open_remote_branch passing by implementing a remote method BzrDir.find_repository.
406
request_handlers.register_lazy(
2018.5.42 by Robert Collins
Various hopefully improvements, but wsgi is broken, handing over to spiv :).
407
    'BzrDirFormat.initialize', 'bzrlib.smart.bzrdir', 'SmartServerRequestInitializeBzrDir')
408
request_handlers.register_lazy(
2018.6.1 by Robert Collins
Implement a BzrDir.open_branch smart server method for opening a branch without VFS.
409
    'BzrDir.open_branch', 'bzrlib.smart.bzrdir', 'SmartServerRequestOpenBranch')
410
request_handlers.register_lazy(
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
411
    'delete', 'bzrlib.smart.vfs', 'DeleteRequest')
412
request_handlers.register_lazy(
413
    'get', 'bzrlib.smart.vfs', 'GetRequest')
414
request_handlers.register_lazy(
415
    'get_bundle', 'bzrlib.smart.request', 'GetBundleRequest')
416
request_handlers.register_lazy(
417
    'has', 'bzrlib.smart.vfs', 'HasRequest')
418
request_handlers.register_lazy(
419
    'hello', 'bzrlib.smart.request', 'HelloRequest')
420
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
421
    'iter_files_recursive', 'bzrlib.smart.vfs', 'IterFilesRecursiveRequest')
2018.5.23 by Andrew Bennetts
Use a Registry for smart server command handlers.
422
request_handlers.register_lazy(
423
    'list_dir', 'bzrlib.smart.vfs', 'ListDirRequest')
424
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
425
    'mkdir', 'bzrlib.smart.vfs', 'MkdirRequest')
426
request_handlers.register_lazy(
427
    'move', 'bzrlib.smart.vfs', 'MoveRequest')
428
request_handlers.register_lazy(
429
    'put', 'bzrlib.smart.vfs', 'PutRequest')
430
request_handlers.register_lazy(
431
    'put_non_atomic', 'bzrlib.smart.vfs', 'PutNonAtomicRequest')
432
request_handlers.register_lazy(
433
    'readv', 'bzrlib.smart.vfs', 'ReadvRequest')
434
request_handlers.register_lazy(
435
    'rename', 'bzrlib.smart.vfs', 'RenameRequest')
3452.2.2 by Andrew Bennetts
Experimental PackRepository.{check_references,autopack} RPCs.
436
request_handlers.register_lazy(
437
    'PackRepository.autopack', 'bzrlib.smart.packrepository',
438
    'SmartServerPackRepositoryAutopack')
2018.10.2 by v.ladeuil+lp at free
gather_stats server side and request registration
439
request_handlers.register_lazy('Repository.gather_stats',
440
                               'bzrlib.smart.repository',
441
                               'SmartServerRepositoryGatherStats')
3842.3.3 by Andrew Bennetts
Remove RPC registration for VersionedFiles.get_parent_map, not Repository.get_parent_map.
442
request_handlers.register_lazy('Repository.get_parent_map',
443
                               'bzrlib.smart.repository',
444
                               'SmartServerRepositoryGetParentMap')
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
445
request_handlers.register_lazy(
2018.5.67 by Wouter van Heyst
Implement RemoteRepository.get_revision_graph (Wouter van Heyst, Robert Collins)
446
    'Repository.get_revision_graph', 'bzrlib.smart.repository', 'SmartServerRepositoryGetRevisionGraph')
447
request_handlers.register_lazy(
2018.5.40 by Robert Collins
Implement a remote Repository.has_revision method.
448
    'Repository.has_revision', 'bzrlib.smart.repository', 'SmartServerRequestHasRevision')
449
request_handlers.register_lazy(
2018.5.57 by Robert Collins
Implement RemoteRepository.is_shared (Robert Collins, Vincent Ladeuil).
450
    'Repository.is_shared', 'bzrlib.smart.repository', 'SmartServerRepositoryIsShared')
451
request_handlers.register_lazy(
2018.5.78 by Andrew Bennetts
Implement RemoteRepository.lock_write/unlock to expect and send tokens over the
452
    'Repository.lock_write', 'bzrlib.smart.repository', 'SmartServerRepositoryLockWrite')
453
request_handlers.register_lazy(
454
    'Repository.unlock', 'bzrlib.smart.repository', 'SmartServerRepositoryUnlock')
455
request_handlers.register_lazy(
2018.18.1 by Martin Pool
Add stub Repository.tarball smart method
456
    'Repository.tarball', 'bzrlib.smart.repository',
457
    'SmartServerRepositoryTarball')
458
request_handlers.register_lazy(
2018.5.37 by Andrew Bennetts
Make sure all the request handlers in bzrlib/smart/vfs.py have consistent names.
459
    'rmdir', 'bzrlib.smart.vfs', 'RmdirRequest')
460
request_handlers.register_lazy(
461
    'stat', 'bzrlib.smart.vfs', 'StatRequest')
2018.5.26 by Andrew Bennetts
Extract a simple SmartClient class from RemoteTransport, and a hack to avoid VFS operations when probing for a bzrdir over a smart transport.
462
request_handlers.register_lazy(
2018.5.95 by Andrew Bennetts
Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.
463
    'Transport.is_readonly', 'bzrlib.smart.request', 'SmartServerIsReadonly')
464
request_handlers.register_lazy(
2018.5.163 by Andrew Bennetts
Deal with various review comments from Robert.
465
    'BzrDir.open', 'bzrlib.smart.bzrdir', 'SmartServerRequestOpenBzrDir')