/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
3735.5.1 by Martin Pool
commit code should not rely on inventory._byid
1
# Copyright (C) 2005, 2006, 2007, 2008 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
17
2921.4.6 by Robert Collins
Typos found by Rob Weir.
18
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
19
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
20
# working tree and that were in the predecessor are reported as
21
# removed --- this can include files that were either removed from the
22
# inventory or deleted in the working tree.  If they were only
23
# deleted from disk, they are removed from the working inventory.
24
25
# We then consider the remaining entries, which will be in the new
26
# version.  Directory entries are simply copied across.  File entries
27
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
28
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
29
# version of the file was present.  If the file was present in at
30
# least one tree, and if it was the same version in all the trees,
31
# then we can just refer to that version.  Otherwise, a new version
32
# representing the merger of the file versions must be added.
33
34
# TODO: Update hashcache before and after - or does the WorkingTree
35
# look after that?
1245 by Martin Pool
doc
36
1339 by Martin Pool
- doc
37
# TODO: Rather than mashing together the ancestry and storing it back,
38
# perhaps the weave should have single method which does it all in one
39
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
40
1341 by Martin Pool
- doc
41
# TODO: Perhaps give a warning if one of the revisions marked as
42
# merged is already in the ancestry, and then don't record it as a
43
# distinct parent.
44
1343 by Martin Pool
- fix up test for merge of trees
45
# TODO: If the file is newly merged but unchanged from the version it
46
# merges from, then it should still be reported as newly added
47
# relative to the basis revision.
48
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
51
1189 by Martin Pool
- BROKEN: partial support for commit into weave
52
import os
1390 by Robert Collins
pair programming worx... merge integration and weave
53
import re
1189 by Martin Pool
- BROKEN: partial support for commit into weave
54
import sys
1188 by Martin Pool
- clean up imports in commit code
55
import time
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
56
57
from cStringIO import StringIO
1188 by Martin Pool
- clean up imports in commit code
58
1551.8.30 by Aaron Bentley
Tweak from review comments
59
from bzrlib import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
60
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
61
    errors,
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
62
    revision,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
63
    trace,
1551.8.30 by Aaron Bentley
Tweak from review comments
64
    tree,
4222.1.1 by Jelmer Vernooij
Make function for escaping invalid XML characters public.
65
    xml_serializer,
1551.8.30 by Aaron Bentley
Tweak from review comments
66
    )
2246.1.3 by Robert Collins
New branch hooks: post_push, post_pull, post_commit, post_uncommit. These
67
from bzrlib.branch import Branch
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
68
import bzrlib.config
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
69
from bzrlib.errors import (BzrError, PointlessCommit,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
70
                           ConflictsInTree,
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
71
                           StrictCommitFailed
1264 by Martin Pool
- Raise a better error from commit when a parent is absent
72
                           )
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
73
from bzrlib.osutils import (get_user_encoding,
74
                            kind_marker, isdir,isfile, is_inside_any,
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
75
                            is_inside_or_parent_of_any,
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
76
                            minimum_path_selection,
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
77
                            quotefn, sha_file, split_lines,
78
                            splitpath,
79
                            )
1442.1.62 by Robert Collins
Allow creation of testaments from uncommitted data, and use that to get signatures before committing revisions.
80
from bzrlib.testament import Testament
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
81
from bzrlib.trace import mutter, note, warning, is_quiet
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
82
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
1910.2.9 by Aaron Bentley
Inroduce assertDeprecated, and use it to test old commitbuilder API
83
from bzrlib import symbol_versioning
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
84
from bzrlib.symbol_versioning import (deprecated_passed,
1773.4.3 by Martin Pool
[merge] bzr.dev
85
        deprecated_function,
1773.4.1 by Martin Pool
Add pyflakes makefile target; fix many warnings
86
        DEPRECATED_PARAMETER)
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
87
from bzrlib.workingtree import WorkingTree
2747.6.11 by Daniel Watkins
Modified ReportCommitToLog.started to use urlutils.unescape_for_display for 'location'.
88
from bzrlib.urlutils import unescape_for_display
2094.3.5 by John Arbash Meinel
Fix imports to ensure modules are loaded before they are used
89
import bzrlib.ui
1189 by Martin Pool
- BROKEN: partial support for commit into weave
90
91
92
class NullCommitReporter(object):
93
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
94
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
95
    def started(self, revno, revid, location=None):
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
96
        if location is None:
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
97
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
98
                                   "to started.", DeprecationWarning,
99
                                   stacklevel=2)
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
100
        pass
101
102
    def snapshot_change(self, change, path):
103
        pass
104
105
    def completed(self, revno, rev_id):
106
        pass
107
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
108
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
109
        pass
110
111
    def escaped(self, escape_count, message):
112
        pass
113
114
    def missing(self, path):
115
        pass
116
117
    def renamed(self, change, old_path, new_path):
118
        pass
119
2789.2.11 by Ian Clatworthy
remove more reporting stuff
120
    def is_verbose(self):
121
        return False
122
123
124
class ReportCommitToLog(NullCommitReporter):
125
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
126
    def _note(self, format, *args):
127
        """Output a message.
128
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
129
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
130
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
131
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
132
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
133
    def snapshot_change(self, change, path):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
134
        if path == '' and change in ('added', 'modified'):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
135
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
136
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
137
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
138
    def started(self, revno, rev_id, location=None):
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
139
        if location is not None:
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
140
            location = ' to: ' + unescape_for_display(location, 'utf-8')
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
141
        else:
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
142
            # When started was added, location was only made optional by
143
            # accident.  Matt Nordhoff 20071129
3052.4.6 by Matt Nordhoff
Update the warning message to use 1.0 instead of 0.93.
144
            symbol_versioning.warn("As of bzr 1.0 you must pass a location "
3052.4.2 by Matt Nordhoff
Deprecate not passing a location to commit reporters' started() methods.
145
                                   "to started.", DeprecationWarning,
146
                                   stacklevel=2)
2747.6.1 by Daniel Watkins
Added message at the end of commit for bound branches.
147
            location = ''
3052.4.1 by Matt Nordhoff
bzr commit: don't print the revision number twice. (Bug #172612)
148
        self._note('Committing%s', location)
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
149
150
    def completed(self, revno, rev_id):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
151
        self._note('Committed revision %d.', revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
152
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
153
    def deleted(self, path):
154
        self._note('deleted %s', path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
155
156
    def escaped(self, escape_count, message):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
157
        self._note("replaced %d control characters in message", escape_count)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
158
159
    def missing(self, path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
160
        self._note('missing %s', path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
161
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
162
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
163
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
164
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
165
    def is_verbose(self):
166
        return True
167
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
168
1189 by Martin Pool
- BROKEN: partial support for commit into weave
169
class Commit(object):
170
    """Task of committing a new revision.
171
172
    This is a MethodObject: it accumulates state as the commit is
173
    prepared, and then it is discarded.  It doesn't represent
174
    historical revisions, just the act of recording a new one.
175
176
            missing_ids
177
            Modified to hold a list of files that have been deleted from
178
            the working directory; these should be removed from the
179
            working inventory.
485 by Martin Pool
- move commit code into its own module
180
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
181
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
182
                 reporter=None,
183
                 config=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
184
        """Create a Commit object.
185
186
        :param reporter: the default reporter to use or None to decide later
187
        """
188
        self.reporter = reporter
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
189
        self.config = config
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
190
1189 by Martin Pool
- BROKEN: partial support for commit into weave
191
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
192
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
193
               timestamp=None,
194
               timezone=None,
195
               committer=None,
196
               specific_files=None,
197
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
198
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
199
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
200
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
201
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
202
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
203
               local=False,
204
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
205
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
206
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
207
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
208
               exclude=None,
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
209
               possible_master_transports=None,
210
               target_branch=None):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
211
        """Commit working copy as a new revision.
212
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
        :param message: the commit message (it or message_callback is required)
214
215
        :param timestamp: if not None, seconds-since-epoch for a
216
            postdated/predated commit.
217
218
        :param specific_files: If true, commit only those files.
219
220
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
221
            Useful for test or import commands that need to tightly
222
            control what revisions are assigned.  If you duplicate
223
            a revision id that exists elsewhere it is your own fault.
224
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
225
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
226
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
227
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
228
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
229
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
230
            contains unknown files.
231
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
232
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
233
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
234
        :param reporter: the reporter to use or None for the default
235
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
236
        :param recursive: If set to 'down', commit in any subtrees that have
237
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
238
        :param exclude: None or a list of relative paths to exclude from the
239
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
240
            commit.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
241
        """
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
242
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
243
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
244
        if working_tree is None:
245
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
246
        else:
247
            self.work_tree = working_tree
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
248
            if target_branch is None:
249
                self.branch = self.work_tree.branch
250
                update_tree = True
251
            else:
252
                self.branch = target_branch
253
                update_tree = False
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
254
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
255
                if not self.branch.repository.supports_rich_root():
256
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
257
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
258
            if message is not None:
259
                if isinstance(message, str):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
260
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
261
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
262
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
263
                raise BzrError("The message or message_callback keyword"
264
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
265
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
266
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
267
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
268
        if exclude is not None:
269
            self.exclude = sorted(
270
                minimum_path_selection(exclude))
271
        else:
272
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
273
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
274
        self.master_branch = None
1614.1.1 by Aaron Bentley
Fixed master locking in commit
275
        self.master_locked = False
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
276
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
277
        self.rev_id = None
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
278
        if specific_files is not None:
279
            self.specific_files = sorted(
280
                minimum_path_selection(specific_files))
281
        else:
282
            self.specific_files = None
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
283
            
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
284
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
285
        self.revprops = revprops
286
        self.message_callback = message_callback
287
        self.timestamp = timestamp
288
        self.timezone = timezone
289
        self.committer = committer
290
        self.strict = strict
291
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
292
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
293
        self.branch.lock_write()
294
        if update_tree:
295
            self.work_tree.lock_write()
296
        else:
297
            self.work_tree.lock_read()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
298
        self.parents = self.work_tree.get_parent_ids()
299
        # We can use record_iter_changes IFF iter_changes is compatible with
300
        # the command line parameters, and the repository has fast delta
301
        # generation. See bug 347649.
302
        self.use_record_iter_changes = (
303
            not self.specific_files and
304
            not self.exclude and 
305
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
306
            (self.branch.repository._format.fast_deltas or
307
             len(self.parents) < 2))
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
308
        self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
309
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
310
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
311
        self.basis_tree.lock_read()
1189 by Martin Pool
- BROKEN: partial support for commit into weave
312
        try:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
313
            # Cannot commit with conflicts present.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
314
            if len(self.work_tree.conflicts()) > 0:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
315
                raise ConflictsInTree
316
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
317
            # Setup the bound branch variables as needed.
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
318
            self._check_bound_branch(possible_master_transports)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
319
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
320
            # Check that the working tree is up to date
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
321
            old_revno, new_revno = self._check_out_of_date_tree()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
322
2789.2.5 by Ian Clatworthy
Upgrade commit tests to reflect new reporting formats
323
            # Complete configuration setup
324
            if reporter is not None:
325
                self.reporter = reporter
326
            elif self.reporter is None:
327
                self.reporter = self._select_reporter()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
328
            if self.config is None:
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
329
                self.config = self.branch.get_config()
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
330
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
331
            self._set_specific_file_ids()
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
332
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
333
            # Setup the progress bar. As the number of files that need to be
334
            # committed in unknown, progress is reported as stages.
335
            # We keep track of entries separately though and include that
336
            # information in the progress bar during the relevant stages.
337
            self.pb_stage_name = ""
338
            self.pb_stage_count = 0
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
339
            self.pb_stage_total = 5
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
340
            if self.bound_branch:
341
                self.pb_stage_total += 1
342
            self.pb.show_pct = False
343
            self.pb.show_spinner = False
344
            self.pb.show_eta = False
345
            self.pb.show_count = True
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
346
            self.pb.show_bar = True
1189 by Martin Pool
- BROKEN: partial support for commit into weave
347
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
348
            self._gather_parents()
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
349
            # After a merge, a selected file commit is not supported.
350
            # See 'bzr help merge' for an explanation as to why.
1344 by Martin Pool
- disallow selected-file commit of merges
351
            if len(self.parents) > 1 and self.specific_files:
1551.15.9 by Aaron Bentley
Better error for selected-file commit of merges
352
                raise errors.CannotCommitSelectedFileMerge(self.specific_files)
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
353
            # Excludes are a form of selected file commit.
354
            if len(self.parents) > 1 and self.exclude:
355
                raise errors.CannotCommitSelectedFileMerge(self.exclude)
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
356
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
357
            # Collect the changes
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
358
            self._set_progress_stage("Collecting changes", counter=True)
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
359
            self.builder = self.branch.get_commit_builder(self.parents,
1740.3.7 by Jelmer Vernooij
Move committer, log, revprops, timestamp and timezone to CommitBuilder.
360
                self.config, timestamp, timezone, committer, revprops, rev_id)
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
361
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
362
            try:
3879.2.3 by John Arbash Meinel
Hide the .basis_delta variable, and require callers to use .get_basis_delta()
363
                self.builder.will_record_deletes()
2747.6.6 by Daniel Watkins
Added call to CommitReport.started hook.
364
                # find the location being committed to
365
                if self.bound_branch:
366
                    master_location = self.master_branch.base
367
                else:
368
                    master_location = self.branch.base
369
370
                # report the start of the commit
371
                self.reporter.started(new_revno, self.rev_id, master_location)
372
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
373
                self._update_builder_with_changes(update_tree)
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
374
                self._check_pointless()
375
376
                # TODO: Now the new inventory is known, check for conflicts.
377
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
378
                # weave lines, because nothing should be recorded until it is known
379
                # that commit will succeed.
2592.3.49 by Robert Collins
Merge bzr.dev.
380
                self._set_progress_stage("Saving data locally")
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
381
                self.builder.finish_inventory()
382
383
                # Prompt the user for a commit message if none provided
384
                message = message_callback(self)
385
                self.message = message
386
                self._escape_commit_message()
387
388
                # Add revision data to the local branch
389
                self.rev_id = self.builder.commit(self.message)
2659.3.5 by NamNguyen
merge with bzr.dev
390
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
391
            except Exception, e:
392
                mutter("aborting commit write group because of exception:")
393
                trace.log_exception_quietly()
394
                note("aborting commit write group: %r" % (e,))
2749.3.1 by Jelmer Vernooij
Add CommitBuilder.abort().
395
                self.builder.abort()
2617.6.2 by Robert Collins
Add abort_write_group and wire write_groups into fetch and commit.
396
                raise
397
2659.3.6 by NamNguyen
branch_implementations/test_commit.py:
398
            self._process_pre_hooks(old_revno, new_revno)
399
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
400
            # Upload revision data to the master.
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
401
            # this will propagate merged revisions too if needed.
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
402
            if self.bound_branch:
4048.2.1 by Jelmer Vernooij
Use Branch.pull() to update master branch.
403
                self._set_progress_stage("Uploading data to master branch")
4048.2.2 by Jelmer Vernooij
New Branch.import_last_Revision_info() function used to pull revisions into the master branch during commit.
404
                # 'commit' to the master first so a timeout here causes the
405
                # local branch to be out of date
406
                self.master_branch.import_last_revision_info(
407
                    self.branch.repository, new_revno, self.rev_id)
1587.1.7 by Robert Collins
Commit revision data locally first for bound branch commits.
408
409
            # and now do the commit locally.
2230.3.51 by Aaron Bentley
Store revno for Branch6, set_last_revision -> set_last_revision_info
410
            self.branch.set_last_revision_info(new_revno, self.rev_id)
1587.1.6 by Robert Collins
Update bound branch implementation to 0.8.
411
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
412
            # Make the working tree up to date with the branch
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
413
            if update_tree:
414
                self._set_progress_stage("Updating the working tree")
415
                self.work_tree.update_basis_by_delta(self.rev_id,
416
                     self.builder.get_basis_delta())
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
417
            self.reporter.completed(new_revno, self.rev_id)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
418
            self._process_post_hooks(old_revno, new_revno)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
419
        finally:
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
420
            self._cleanup()
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
421
        return self.rev_id
1189 by Martin Pool
- BROKEN: partial support for commit into weave
422
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
423
    def _select_reporter(self):
424
        """Select the CommitReporter to use."""
425
        if is_quiet():
426
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
427
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
428
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
429
    def _check_pointless(self):
430
        if self.allow_pointless:
431
            return
432
        # A merge with no effect on files
433
        if len(self.parents) > 1:
434
            return
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
435
        # TODO: we could simplify this by using self.builder.basis_delta.
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
436
2921.4.6 by Robert Collins
Typos found by Rob Weir.
437
        # The initial commit adds a root directory, but this in itself is not
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
438
        # a worthwhile commit.
439
        if (self.basis_revid == revision.NULL_REVISION and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
440
            ((self.builder.new_inventory is not None and
441
             len(self.builder.new_inventory) == 1) or
442
            len(self.builder._basis_delta) == 1)):
1731.1.49 by Aaron Bentley
Merge bzr.dev
443
            raise PointlessCommit()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
444
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
445
            return
446
        raise PointlessCommit()
447
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
448
    def _check_bound_branch(self, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
449
        """Check to see if the local branch is bound.
450
451
        If it is bound, then most of the commit will actually be
452
        done using the remote branch as the target branch.
453
        Only at the end will the local branch be updated.
454
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
455
        if self.local and not self.branch.get_bound_location():
456
            raise errors.LocalRequiresBoundBranch()
457
458
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
459
            self.master_branch = self.branch.get_master_branch(
460
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
461
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
462
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
463
            # make this branch the reference branch for out of date checks.
464
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
465
            return
466
467
        # If the master branch is bound, we must fail
468
        master_bound_location = self.master_branch.get_bound_location()
469
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
470
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
471
                    self.master_branch, master_bound_location)
472
473
        # TODO: jam 20051230 We could automatically push local
474
        #       commits to the remote branch if they would fit.
475
        #       But for now, just require remote to be identical
476
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
477
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
478
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
479
        master_info = self.master_branch.last_revision_info()
480
        local_info = self.branch.last_revision_info()
481
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
482
            raise errors.BoundBranchOutOfDate(self.branch,
483
                    self.master_branch)
484
485
        # Now things are ready to change the master branch
486
        # so grab the lock
487
        self.bound_branch = self.branch
488
        self.master_branch.lock_write()
1614.1.1 by Aaron Bentley
Fixed master locking in commit
489
        self.master_locked = True
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
490
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
491
    def _check_out_of_date_tree(self):
492
        """Check that the working tree is up to date.
493
494
        :return: old_revision_number,new_revision_number tuple
495
        """
496
        try:
497
            first_tree_parent = self.work_tree.get_parent_ids()[0]
498
        except IndexError:
499
            # if there are no parents, treat our parent as 'None'
500
            # this is so that we still consider the master branch
501
            # - in a checkout scenario the tree may have no
502
            # parents but the branch may do.
503
            first_tree_parent = bzrlib.revision.NULL_REVISION
504
        old_revno, master_last = self.master_branch.last_revision_info()
505
        if master_last != first_tree_parent:
506
            if master_last != bzrlib.revision.NULL_REVISION:
507
                raise errors.OutOfDateTree(self.work_tree)
508
        if self.branch.repository.has_revision(first_tree_parent):
509
            new_revno = old_revno + 1
510
        else:
511
            # ghost parents never appear in revision history.
512
            new_revno = 1
513
        return old_revno,new_revno
514
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
515
    def _process_pre_hooks(self, old_revno, new_revno):
516
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
517
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
518
        self._process_hooks("pre_commit", old_revno, new_revno)
519
520
    def _process_post_hooks(self, old_revno, new_revno):
521
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
522
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
523
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
524
        # old style commit hooks - should be deprecated ? (obsoleted in
525
        # 0.15)
526
        if self.config.post_commit() is not None:
527
            hooks = self.config.post_commit().split(' ')
528
            # this would be nicer with twisted.python.reflect.namedAny
529
            for hook in hooks:
530
                result = eval(hook + '(branch, rev_id)',
531
                              {'branch':self.branch,
532
                               'bzrlib':bzrlib,
533
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
534
        # process new style post commit hooks
535
        self._process_hooks("post_commit", old_revno, new_revno)
536
537
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
538
        if not Branch.hooks[hook_name]:
539
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
540
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
541
        # new style commit hooks:
542
        if not self.bound_branch:
543
            hook_master = self.branch
544
            hook_local = None
545
        else:
546
            hook_master = self.master_branch
547
            hook_local = self.branch
548
        # With bound branches, when the master is behind the local branch,
549
        # the 'old_revno' and old_revid values here are incorrect.
550
        # XXX: FIXME ^. RBC 20060206
551
        if self.parents:
552
            old_revid = self.parents[0]
553
        else:
554
            old_revid = bzrlib.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
555
2659.3.9 by NamNguyen
branch.py:
556
        if hook_name == "pre_commit":
557
            future_tree = self.builder.revision_tree()
558
            tree_delta = future_tree.changes_from(self.basis_tree,
559
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
560
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
561
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
562
            # show the running hook in the progress bar. As hooks may
563
            # end up doing nothing (e.g. because they are not configured by
564
            # the user) this is still showing progress, not showing overall
565
            # actions - its up to each plugin to show a UI if it want's to
566
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
567
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
568
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
569
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
570
            if 'hooks' in debug.debug_flags:
571
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
572
            if hook_name == "post_commit":
573
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
574
                     self.rev_id)
575
            elif hook_name == "pre_commit":
576
                hook(hook_local, hook_master,
577
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
578
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
579
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
580
    def _cleanup(self):
581
        """Cleanup any open locks, progress bars etc."""
582
        cleanups = [self._cleanup_bound_branch,
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
583
                    self.basis_tree.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
584
                    self.work_tree.unlock,
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
585
                    self.branch.unlock,
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
586
                    self.pb.finished]
587
        found_exception = None
588
        for cleanup in cleanups:
589
            try:
590
                cleanup()
591
            # we want every cleanup to run no matter what.
592
            # so we have a catchall here, but we will raise the
593
            # last encountered exception up the stack: and
594
            # typically this will be useful enough.
595
            except Exception, e:
596
                found_exception = e
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
597
        if found_exception is not None:
1759.2.2 by Jelmer Vernooij
Revert some of my spelling fixes and fix some typos after review by Aaron.
598
            # don't do a plan raise, because the last exception may have been
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
599
            # trashed, e is our sure-to-work exception even though it loses the
600
            # full traceback. XXX: RBC 20060421 perhaps we could check the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
601
            # exc_info and if its the same one do a plain raise otherwise
1666.1.18 by Robert Collins
Add a progress bar during commit operations.
602
            # 'raise e' as we do now.
603
            raise e
604
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
605
    def _cleanup_bound_branch(self):
606
        """Executed at the end of a try/finally to cleanup a bound branch.
607
608
        If the branch wasn't bound, this is a no-op.
609
        If it was, it resents self.branch to the local branch, instead
610
        of being the master.
611
        """
612
        if not self.bound_branch:
613
            return
1614.1.1 by Aaron Bentley
Fixed master locking in commit
614
        if self.master_locked:
615
            self.master_branch.unlock()
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
616
1390 by Robert Collins
pair programming worx... merge integration and weave
617
    def _escape_commit_message(self):
618
        """Replace xml-incompatible control characters."""
1666.1.6 by Robert Collins
Make knit the default format.
619
        # FIXME: RBC 20060419 this should be done by the revision
620
        # serialiser not by commit. Then we can also add an unescaper
621
        # in the deserializer and start roundtripping revision messages
622
        # precisely. See repository_implementations/test_repository.py
4222.1.1 by Jelmer Vernooij
Make function for escaping invalid XML characters public.
623
        self.message, escape_count = xml_serializer.escape_invalid_chars(
1390 by Robert Collins
pair programming worx... merge integration and weave
624
            self.message)
1185.11.5 by John Arbash Meinel
Merged up-to-date against mainline, still broken.
625
        if escape_count:
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
626
            self.reporter.escaped(escape_count, self.message)
1223 by Martin Pool
- store inventories in weave
627
628
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
629
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
630
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
631
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
632
        if self.use_record_iter_changes:
633
            return
634
        self.basis_inv = self.basis_tree.inventory
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
635
        self.parent_invs = [self.basis_inv]
636
        for revision in self.parents[1:]:
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
637
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
638
                mutter('commit parent revision {%s}', revision)
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
639
                inventory = self.branch.repository.get_inventory(revision)
1185.65.1 by Aaron Bentley
Refactored out ControlFiles and RevisionStore from _Branch
640
                self.parent_invs.append(inventory)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
641
            else:
642
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
643
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
644
    def _update_builder_with_changes(self, update_tree):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
645
        """Update the commit builder with the data about what has changed.
646
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
647
        exclude = self.exclude
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
648
        specific_files = self.specific_files or []
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
649
        mutter("Selecting files for commit with filter %s", specific_files)
650
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
651
        self._check_strict()
652
        if self.use_record_iter_changes:
653
            iter_changes = self.work_tree.iter_changes(self.basis_tree)
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
654
            iter_changes = self._filter_iter_changes(iter_changes, update_tree)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
655
            for file_id, path, fs_hash in self.builder.record_iter_changes(
656
                self.work_tree, self.basis_revid, iter_changes):
4354.4.2 by Aaron Bentley
Allow committing a file add to a PreviewTree.
657
                if fs_hash[1] is not None:
658
                    self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
659
        else:
660
            # Build the new inventory
661
            self._populate_from_inventory()
662
            self._record_unselected()
663
            self._report_and_accumulate_deletes()
664
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
665
    def _filter_iter_changes(self, iter_changes, update_tree):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
666
        """Process iter_changes.
667
668
        This method reports on the changes in iter_changes to the user, and 
669
        converts 'missing' entries in the iter_changes iterator to 'deleted'
670
        entries. 'missing' entries have their
671
672
        :param iter_changes: An iter_changes to process.
673
        :return: A generator of changes.
674
        """
675
        reporter = self.reporter
676
        report_changes = reporter.is_verbose()
677
        deleted_ids = []
678
        for change in iter_changes:
679
            if report_changes:
680
                old_path = change[1][0]
681
                new_path = change[1][1]
682
                versioned = change[3][1]
683
            kind = change[6][1]
684
            versioned = change[3][1]
685
            if kind is None and versioned:
686
                # 'missing' path
687
                if report_changes:
688
                    reporter.missing(new_path)
689
                deleted_ids.append(change[0])
690
                # Reset the new path (None) and new versioned flag (False)
691
                change = (change[0], (change[1][0], None), change[2],
692
                    (change[3][0], False)) + change[4:]
693
            elif kind == 'tree-reference':
694
                if self.recursive == 'down':
695
                    self._commit_nested_tree(change[0], change[1][1])
696
            if change[3][0] or change[3][1]:
697
                yield change
698
                if report_changes:
699
                    if new_path is None:
700
                        reporter.deleted(old_path)
701
                    elif old_path is None:
702
                        reporter.snapshot_change('added', new_path)
703
                    elif old_path != new_path:
704
                        reporter.renamed('renamed', old_path, new_path)
705
                    else:
706
                        if (new_path or 
707
                            self.work_tree.branch.repository._format.rich_root_data):
708
                            # Don't report on changes to '' in non rich root
709
                            # repositories.
710
                            reporter.snapshot_change('modified', new_path)
711
            self._next_progress_entry()
712
        # Unversion IDs that were found to be deleted
4354.4.1 by Aaron Bentley
Trivial support for committing PreviewTree.
713
        if update_tree:
714
            self.work_tree.unversion(deleted_ids)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
715
716
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
717
        # If specific files are selected, then all un-selected files must be
718
        # recorded in their previous state. For more details, see
719
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
720
        if self.specific_files or self.exclude:
721
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
722
            for path, old_ie in self.basis_inv.iter_entries():
723
                if old_ie.file_id in self.builder.new_inventory:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
724
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
725
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
726
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
727
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
728
                    # was inside the selected path, and not excluded - if not
729
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
730
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
731
                # From here down it was either not selected, or was excluded:
732
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
733
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
734
                # Note: specific file commits after a merge are currently
735
                # prohibited. This test is for sanity/safety in case it's
736
                # required after that changes.
737
                if len(self.parents) > 1:
738
                    ie.revision = None
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
739
                self.builder.record_entry_contents(ie, self.parent_invs, path,
740
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
741
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
742
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
743
        if (isinstance(self.basis_inv, Inventory)
744
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
745
            # the older Inventory classes provide a _byid dict, and building a
746
            # set from the keys of this dict is substantially faster than even
747
            # getting a set of ids from the inventory
748
            #
749
            # <lifeless> set(dict) is roughly the same speed as
750
            # set(iter(dict)) and both are significantly slower than
751
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
752
            deleted_ids = set(self.basis_inv._byid.keys()) - \
753
               set(self.builder.new_inventory._byid.keys())
754
        else:
755
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
756
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
757
            self.any_entries_deleted = True
2921.4.3 by Robert Collins
Remove more basis inventory usage.
758
            deleted = [(self.basis_tree.id2path(file_id), file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
759
                for file_id in deleted_ids]
760
            deleted.sort()
761
            # XXX: this is not quite directory-order sorting
762
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
763
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
764
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
765
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
766
    def _check_strict(self):
767
        # XXX: when we use iter_changes this would likely be faster if
768
        # iter_changes would check for us (even in the presence of
769
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
770
        if self.strict:
771
            # raise an exception as soon as we find a single unknown.
772
            for unknown in self.work_tree.unknowns():
773
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
774
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
775
    def _populate_from_inventory(self):
776
        """Populate the CommitBuilder by walking the working tree inventory."""
777
        # Build the revision inventory.
778
        #
779
        # This starts by creating a new empty inventory. Depending on
780
        # which files are selected for commit, and what is present in the
781
        # current tree, the new inventory is populated. inventory entries
782
        # which are candidates for modification have their revision set to
783
        # None; inventory entries that are carried over untouched have their
784
        # revision set to their prior value.
785
        #
786
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
787
        # results to create a new inventory at the same time, which results
788
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
789
        # ADHB 11-07-2006
790
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
791
        specific_files = self.specific_files
792
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
793
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
794
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
795
        # A tree of paths that have been deleted. E.g. if foo/bar has been
796
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
797
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
798
        # XXX: Note that entries may have the wrong kind because the entry does
799
        # not reflect the status on disk.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
800
        work_inv = self.work_tree.inventory
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
801
        # NB: entries will include entries within the excluded ids/paths
802
        # because iter_entries_by_dir has no 'exclude' facility today.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
803
        entries = work_inv.iter_entries_by_dir(
804
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
805
        for path, existing_ie in entries:
806
            file_id = existing_ie.file_id
807
            name = existing_ie.name
808
            parent_id = existing_ie.parent_id
809
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
810
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
811
            # The deleted path ids are also recorded so they can be explicitly
812
            # unversioned later.
813
            if deleted_paths:
814
                path_segments = splitpath(path)
815
                deleted_dict = deleted_paths
816
                for segment in path_segments:
817
                    deleted_dict = deleted_dict.get(segment, None)
818
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
819
                        # We either took a path not present in the dict
820
                        # (deleted_dict was None), or we've reached an empty
821
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
822
                        break
823
                else:
824
                    deleted_dict = None
825
                if deleted_dict is not None:
826
                    # the path has a deleted parent, do not add it.
827
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
828
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
829
                # Skip excluded paths. Excluded paths are processed by
830
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
831
                continue
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
832
            content_summary = self.work_tree.path_content_summary(path)
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
833
            # Note that when a filter of specific files is given, we must only
834
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
835
            if not specific_files or is_inside_any(specific_files, path):
2776.4.7 by Robert Collins
Remove another stat by using path_content_summary to avoid a has_filename call.
836
                if content_summary[0] == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
837
                    if not deleted_paths:
838
                        # path won't have been split yet.
839
                        path_segments = splitpath(path)
840
                    deleted_dict = deleted_paths
841
                    for segment in path_segments:
842
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
843
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
844
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
845
                    deleted_ids.append(file_id)
846
                    continue
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
847
            # TODO: have the builder do the nested commit just-in-time IF and
848
            # only if needed.
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
849
            if content_summary[0] == 'tree-reference':
850
                # enforce repository nested tree policy.
851
                if (not self.work_tree.supports_tree_reference() or
852
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
853
                    not self.branch.repository._format.supports_tree_reference):
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
854
                    content_summary = ('directory',) + content_summary[1:]
855
            kind = content_summary[0]
856
            # TODO: specific_files filtering before nested tree processing
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
857
            if kind == 'tree-reference':
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
858
                if self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
859
                    nested_revision_id = self._commit_nested_tree(
860
                        file_id, path)
861
                    content_summary = content_summary[:3] + (
862
                        nested_revision_id,)
863
                else:
864
                    content_summary = content_summary[:3] + (
865
                        self.work_tree.get_reference_revision(file_id),)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
866
867
            # Record an entry for this item
868
            # Note: I don't particularly want to have the existing_ie
869
            # parameter but the test suite currently (28-Jun-07) breaks
870
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
871
            definitely_changed = kind != existing_ie.kind
2789.2.12 by Ian Clatworthy
reduce conditionals
872
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
873
                parent_id, definitely_changed, existing_ie, report_changes,
874
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
875
876
        # Unversion IDs that were found to be deleted
877
        self.work_tree.unversion(deleted_ids)
878
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
879
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
880
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
881
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
882
        # FIXME: be more comprehensive here:
883
        # this works when both trees are in --trees repository,
884
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
885
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
886
        # finally implement the explicit-caches approach design
887
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
888
        if sub_tree.branch.repository.has_same_location(
889
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
890
            sub_tree.branch.repository = \
891
                self.work_tree.branch.repository
892
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
893
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
894
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
895
                message_callback=self.message_callback,
896
                timestamp=self.timestamp, timezone=self.timezone,
897
                committer=self.committer,
898
                allow_pointless=self.allow_pointless,
899
                strict=self.strict, verbose=self.verbose,
900
                local=self.local, reporter=self.reporter)
901
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
902
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
903
904
    def _record_entry(self, path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
905
        parent_id, definitely_changed, existing_ie, report_changes,
906
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
907
        "Record the new inventory entry for a path if any."
908
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
909
        # mutter('%s selected for commit', path)
910
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
911
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
912
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
913
            ie = existing_ie.copy()
914
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
915
        # For carried over entries we don't care about the fs hash - the repo
916
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
917
        _, _, fs_hash = self.builder.record_entry_contents(
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
918
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
919
        if report_changes:
920
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
921
        if fs_hash:
922
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
923
        return ie
924
925
    def _report_change(self, ie, path):
926
        """Report a change to the user.
927
928
        The change that has occurred is described relative to the basis
929
        inventory.
930
        """
931
        if (self.basis_inv.has_id(ie.file_id)):
932
            basis_ie = self.basis_inv[ie.file_id]
933
        else:
934
            basis_ie = None
935
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
936
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
937
            InventoryEntry.MODIFIED_AND_RENAMED):
938
            old_path = self.basis_inv.id2path(ie.file_id)
939
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
940
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
941
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
942
            if change == 'unchanged':
943
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
944
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
945
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
946
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
947
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
948
        """Set the progress stage and emit an update to the progress bar."""
949
        self.pb_stage_name = name
950
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
951
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
952
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
953
        else:
954
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
955
        self._emit_progress()
956
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
957
    def _next_progress_entry(self):
958
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
959
        self.pb_entries_count += 1
960
        self._emit_progress()
961
962
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
963
        if self.pb_entries_count is not None:
964
            text = "%s [%d] - Stage" % (self.pb_stage_name,
965
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
966
        else:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
967
            text = "%s - Stage" % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
968
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
969
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
970
    def _set_specific_file_ids(self):
971
        """populate self.specific_file_ids if we will use it."""
972
        if not self.use_record_iter_changes:
973
            # If provided, ensure the specified files are versioned
974
            if self.specific_files is not None:
975
                # Note: This routine is being called because it raises
976
                # PathNotVersionedError as a side effect of finding the IDs. We
977
                # later use the ids we found as input to the working tree
978
                # inventory iterator, so we only consider those ids rather than
979
                # examining the whole tree again.
980
                # XXX: Dont we have filter_unversioned to do this more
981
                # cheaply?
982
                self.specific_file_ids = tree.find_ids_across_trees(
983
                    self.specific_files, [self.basis_tree, self.work_tree])
984
            else:
985
                self.specific_file_ids = None