/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
4988.10.3 by John Arbash Meinel
Merge bzr.dev 5007, resolve conflict, update NEWS
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
369 by Martin Pool
- Split out log printing into new show_log function
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
369 by Martin Pool
- Split out log printing into new show_log function
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
369 by Martin Pool
- Split out log printing into new show_log function
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
369 by Martin Pool
- Split out log printing into new show_log function
16
375 by Martin Pool
- New command touching-revisions and function to trace
17
18
527 by Martin Pool
- refactor log command
19
"""Code to show logs of changes.
20
21
Various flavors of log can be produced:
22
23
* for one file, or the whole tree, and (not done yet) for
24
  files in a given directory
25
26
* in "verbose" mode with a description of what changed from one
27
  version to the next
28
29
* with file-ids and revision-ids shown
30
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
31
Logs are actually written out through an abstract LogFormatter
32
interface, which allows for different preferred formats.  Plugins can
33
register formats too.
34
35
Logs can be produced in either forward (oldest->newest) or reverse
36
(newest->oldest) order.
37
38
Logs can be filtered to show only revisions matching a particular
39
search string, or within a particular range of revisions.  The range
40
can be given as date/times, which are reduced to revisions before
41
calling in here.
42
43
In verbose mode we show a summary of what changed in each particular
44
revision.  Note that this is the delta for changes in that revision
2466.12.2 by Kent Gibson
shift log output with only merge revisions to the left margin
45
relative to its left-most parent, not the delta relative to the last
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
46
logged revision.  So for example if you ask for a verbose log of
47
changes touching hello.c you will get a list of those revisions also
48
listing other things that were changed in the same revision, but not
49
all the changes since the previous revision that touched hello.c.
527 by Martin Pool
- refactor log command
50
"""
51
2997.1.2 by Kent Gibson
Move all imports to top of log.py
52
import codecs
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
53
from cStringIO import StringIO
2997.1.2 by Kent Gibson
Move all imports to top of log.py
54
from itertools import (
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
55
    chain,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
56
    izip,
57
    )
1624.1.3 by Robert Collins
Convert log to use the new tsort.merge_sort routine.
58
import re
2997.1.2 by Kent Gibson
Move all imports to top of log.py
59
import sys
60
from warnings import (
61
    warn,
62
    )
1185.33.41 by Martin Pool
Fix regression of 'bzr log -v' - it wasn't showing changed files at all. (#4676)
63
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
64
from bzrlib.lazy_import import lazy_import
65
lazy_import(globals(), """
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
66
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib import (
4202.2.1 by Ian Clatworthy
get directory logging working again
68
    bzrdir,
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
69
    config,
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
70
    diff,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
71
    errors,
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
72
    foreign,
4797.57.10 by Alexander Belchenko
path_encoding selection logic extracted as helper function
73
    osutils,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
74
    repository as _mod_repository,
75
    revision as _mod_revision,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
76
    revisionspec,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
77
    trace,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
78
    tsort,
79
    )
80
""")
81
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
82
from bzrlib import (
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
83
    registry,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
84
    )
85
from bzrlib.osutils import (
86
    format_date,
4379.4.1 by Ian Clatworthy
make log --long faster
87
    format_date_with_offset_in_original_timezone,
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
88
    get_terminal_encoding,
4183.6.4 by Martin Pool
Separate out re_compile_checked
89
    re_compile_checked,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
90
    terminal_width,
91
    )
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
92
from bzrlib.symbol_versioning import (
93
    deprecated_function,
94
    deprecated_in,
95
    )
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
96
375 by Martin Pool
- New command touching-revisions and function to trace
97
98
def find_touching_revisions(branch, file_id):
99
    """Yield a description of revisions which affect the file_id.
100
101
    Each returned element is (revno, revision_id, description)
102
103
    This is the list of revisions where the file is either added,
104
    modified, renamed or deleted.
105
106
    TODO: Perhaps some way to limit this to only particular revisions,
522 by Martin Pool
todo
107
    or to traverse a non-mainline set of revisions?
375 by Martin Pool
- New command touching-revisions and function to trace
108
    """
109
    last_ie = None
110
    last_path = None
111
    revno = 1
112
    for revision_id in branch.revision_history():
5035.3.1 by Jelmer Vernooij
Remove Repository.get_revision_inventory.
113
        this_inv = branch.repository.get_inventory(revision_id)
375 by Martin Pool
- New command touching-revisions and function to trace
114
        if file_id in this_inv:
115
            this_ie = this_inv[file_id]
116
            this_path = this_inv.id2path(file_id)
117
        else:
118
            this_ie = this_path = None
119
120
        # now we know how it was last time, and how it is in this revision.
121
        # are those two states effectively the same or not?
122
123
        if not this_ie and not last_ie:
124
            # not present in either
125
            pass
126
        elif this_ie and not last_ie:
127
            yield revno, revision_id, "added " + this_path
128
        elif not this_ie and last_ie:
129
            # deleted here
130
            yield revno, revision_id, "deleted " + last_path
131
        elif this_path != last_path:
132
            yield revno, revision_id, ("renamed %s => %s" % (last_path, this_path))
133
        elif (this_ie.text_size != last_ie.text_size
134
              or this_ie.text_sha1 != last_ie.text_sha1):
135
            yield revno, revision_id, "modified " + this_path
136
137
        last_ie = this_ie
138
        last_path = this_path
139
        revno += 1
140
141
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
142
def _enumerate_history(branch):
143
    rh = []
144
    revno = 1
145
    for rev_id in branch.revision_history():
146
        rh.append((revno, rev_id))
147
        revno += 1
148
    return rh
149
150
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
151
def show_log(branch,
152
             lf,
153
             specific_fileid=None,
154
             verbose=False,
155
             direction='reverse',
156
             start_revision=None,
157
             end_revision=None,
158
             search=None,
159
             limit=None,
160
             show_diff=False):
161
    """Write out human-readable log of commits to this branch.
162
163
    This function is being retained for backwards compatibility but
164
    should not be extended with new parameters. Use the new Logger class
165
    instead, eg. Logger(branch, rqst).show(lf), adding parameters to the
4205.1.1 by Ian Clatworthy
log multiple files and directories (Ian Clatworthy)
166
    make_log_request_dict function.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
167
168
    :param lf: The LogFormatter object showing the output.
169
170
    :param specific_fileid: If not None, list only the commits affecting the
171
        specified file, rather than all commits.
172
173
    :param verbose: If True show added/changed/deleted/renamed files.
174
175
    :param direction: 'reverse' (default) is latest to earliest; 'forward' is
176
        earliest to latest.
177
178
    :param start_revision: If not None, only show revisions >= start_revision
179
180
    :param end_revision: If not None, only show revisions <= end_revision
181
182
    :param search: If not None, only show revisions with matching commit
183
        messages
184
185
    :param limit: If set, shows only 'limit' revisions, all revisions are shown
186
        if None or 0.
187
188
    :param show_diff: If True, output a diff after each revision.
189
    """
190
    # Convert old-style parameters to new-style parameters
191
    if specific_fileid is not None:
192
        file_ids = [specific_fileid]
193
    else:
194
        file_ids = None
195
    if verbose:
196
        if file_ids:
197
            delta_type = 'partial'
198
        else:
199
            delta_type = 'full'
200
    else:
201
        delta_type = None
202
    if show_diff:
203
        if file_ids:
204
            diff_type = 'partial'
205
        else:
206
            diff_type = 'full'
207
    else:
208
        diff_type = None
209
210
    # Build the request and execute it
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
211
    rqst = make_log_request_dict(direction=direction, specific_fileids=file_ids,
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
212
        start_revision=start_revision, end_revision=end_revision,
213
        limit=limit, message_search=search,
214
        delta_type=delta_type, diff_type=diff_type)
215
    Logger(branch, rqst).show(lf)
216
217
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
218
# Note: This needs to be kept this in sync with the defaults in
219
# make_log_request_dict() below
220
_DEFAULT_REQUEST_PARAMS = {
221
    'direction': 'reverse',
222
    'levels': 1,
223
    'generate_tags': True,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
224
    'exclude_common_ancestry': False,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
225
    '_match_using_deltas': True,
226
    }
227
228
229
def make_log_request_dict(direction='reverse', specific_fileids=None,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
230
                          start_revision=None, end_revision=None, limit=None,
231
                          message_search=None, levels=1, generate_tags=True,
232
                          delta_type=None,
233
                          diff_type=None, _match_using_deltas=True,
234
                          exclude_common_ancestry=False,
235
                          ):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
236
    """Convenience function for making a logging request dictionary.
237
238
    Using this function may make code slightly safer by ensuring
239
    parameters have the correct names. It also provides a reference
240
    point for documenting the supported parameters.
241
242
    :param direction: 'reverse' (default) is latest to earliest;
243
      'forward' is earliest to latest.
244
245
    :param specific_fileids: If not None, only include revisions
246
      affecting the specified files, rather than all revisions.
247
248
    :param start_revision: If not None, only generate
249
      revisions >= start_revision
250
251
    :param end_revision: If not None, only generate
252
      revisions <= end_revision
253
254
    :param limit: If set, generate only 'limit' revisions, all revisions
255
      are shown if None or 0.
256
257
    :param message_search: If not None, only include revisions with
258
      matching commit messages
259
260
    :param levels: the number of levels of revisions to
261
      generate; 1 for just the mainline; 0 for all levels.
262
263
    :param generate_tags: If True, include tags for matched revisions.
264
265
    :param delta_type: Either 'full', 'partial' or None.
266
      'full' means generate the complete delta - adds/deletes/modifies/etc;
267
      'partial' means filter the delta using specific_fileids;
268
      None means do not generate any delta.
269
270
    :param diff_type: Either 'full', 'partial' or None.
271
      'full' means generate the complete diff - adds/deletes/modifies/etc;
272
      'partial' means filter the diff using specific_fileids;
273
      None means do not generate any diff.
274
275
    :param _match_using_deltas: a private parameter controlling the
276
      algorithm used for matching specific_fileids. This parameter
277
      may be removed in the future so bzrlib client code should NOT
278
      use it.
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
279
280
    :param exclude_common_ancestry: Whether -rX..Y should be interpreted as a
281
      range operator or as a graph difference.
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
282
    """
283
    return {
284
        'direction': direction,
285
        'specific_fileids': specific_fileids,
286
        'start_revision': start_revision,
287
        'end_revision': end_revision,
288
        'limit': limit,
289
        'message_search': message_search,
290
        'levels': levels,
291
        'generate_tags': generate_tags,
292
        'delta_type': delta_type,
293
        'diff_type': diff_type,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
294
        'exclude_common_ancestry': exclude_common_ancestry,
4202.2.1 by Ian Clatworthy
get directory logging working again
295
        # Add 'private' attributes for features that may be deprecated
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
296
        '_match_using_deltas': _match_using_deltas,
297
    }
298
299
300
def _apply_log_request_defaults(rqst):
301
    """Apply default values to a request dictionary."""
302
    result = _DEFAULT_REQUEST_PARAMS
303
    if rqst:
304
        result.update(rqst)
305
    return result
4202.2.1 by Ian Clatworthy
get directory logging working again
306
307
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
308
class LogGenerator(object):
309
    """A generator of log revisions."""
310
311
    def iter_log_revisions(self):
312
        """Iterate over LogRevision objects.
313
314
        :return: An iterator yielding LogRevision objects.
315
        """
316
        raise NotImplementedError(self.iter_log_revisions)
317
318
319
class Logger(object):
4955.5.3 by Vincent Ladeuil
Cleanup.
320
    """An object that generates, formats and displays a log."""
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
321
322
    def __init__(self, branch, rqst):
323
        """Create a Logger.
324
325
        :param branch: the branch to log
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
326
        :param rqst: A dictionary specifying the query parameters.
327
          See make_log_request_dict() for supported values.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
328
        """
329
        self.branch = branch
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
330
        self.rqst = _apply_log_request_defaults(rqst)
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
331
332
    def show(self, lf):
333
        """Display the log.
334
335
        :param lf: The LogFormatter object to send the output to.
336
        """
337
        if not isinstance(lf, LogFormatter):
338
            warn("not a LogFormatter instance: %r" % lf)
339
340
        self.branch.lock_read()
341
        try:
342
            if getattr(lf, 'begin_log', None):
343
                lf.begin_log()
344
            self._show_body(lf)
345
            if getattr(lf, 'end_log', None):
346
                lf.end_log()
347
        finally:
348
            self.branch.unlock()
349
350
    def _show_body(self, lf):
351
        """Show the main log output.
352
353
        Subclasses may wish to override this.
354
        """
355
        # Tweak the LogRequest based on what the LogFormatter can handle.
356
        # (There's no point generating stuff if the formatter can't display it.)
357
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
358
        rqst['levels'] = lf.get_levels()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
359
        if not getattr(lf, 'supports_tags', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
360
            rqst['generate_tags'] = False
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
361
        if not getattr(lf, 'supports_delta', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
362
            rqst['delta_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
363
        if not getattr(lf, 'supports_diff', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
364
            rqst['diff_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
365
366
        # Find and print the interesting revisions
367
        generator = self._generator_factory(self.branch, rqst)
368
        for lr in generator.iter_log_revisions():
369
            lf.log_revision(lr)
4208.2.1 by Ian Clatworthy
merge indicators in log --long
370
        lf.show_advice()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
371
372
    def _generator_factory(self, branch, rqst):
373
        """Make the LogGenerator object to use.
374
        
375
        Subclasses may wish to override this.
376
        """
377
        return _DefaultLogGenerator(branch, rqst)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
378
379
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
380
class _StartNotLinearAncestor(Exception):
381
    """Raised when a start revision is not found walking left-hand history."""
382
383
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
384
class _DefaultLogGenerator(LogGenerator):
385
    """The default generator of log revisions."""
4202.2.1 by Ian Clatworthy
get directory logging working again
386
387
    def __init__(self, branch, rqst):
388
        self.branch = branch
389
        self.rqst = rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
390
        if rqst.get('generate_tags') and branch.supports_tags():
4202.2.1 by Ian Clatworthy
get directory logging working again
391
            self.rev_tag_dict = branch.tags.get_reverse_tag_dict()
392
        else:
393
            self.rev_tag_dict = {}
394
395
    def iter_log_revisions(self):
396
        """Iterate over LogRevision objects.
397
398
        :return: An iterator yielding LogRevision objects.
399
        """
400
        rqst = self.rqst
4379.4.1 by Ian Clatworthy
make log --long faster
401
        levels = rqst.get('levels')
402
        limit = rqst.get('limit')
403
        diff_type = rqst.get('diff_type')
4202.2.1 by Ian Clatworthy
get directory logging working again
404
        log_count = 0
405
        revision_iterator = self._create_log_revision_iterator()
406
        for revs in revision_iterator:
407
            for (rev_id, revno, merge_depth), rev, delta in revs:
408
                # 0 levels means show everything; merge_depth counts from 0
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
409
                if levels != 0 and merge_depth >= levels:
4202.2.1 by Ian Clatworthy
get directory logging working again
410
                    continue
4379.4.1 by Ian Clatworthy
make log --long faster
411
                if diff_type is None:
412
                    diff = None
413
                else:
414
                    diff = self._format_diff(rev, rev_id, diff_type)
4202.2.1 by Ian Clatworthy
get directory logging working again
415
                yield LogRevision(rev, revno, merge_depth, delta,
416
                    self.rev_tag_dict.get(rev_id), diff)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
417
                if limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
418
                    log_count += 1
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
419
                    if log_count >= limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
420
                        return
421
4379.4.1 by Ian Clatworthy
make log --long faster
422
    def _format_diff(self, rev, rev_id, diff_type):
4202.2.1 by Ian Clatworthy
get directory logging working again
423
        repo = self.branch.repository
424
        if len(rev.parent_ids) == 0:
425
            ancestor_id = _mod_revision.NULL_REVISION
426
        else:
427
            ancestor_id = rev.parent_ids[0]
428
        tree_1 = repo.revision_tree(ancestor_id)
429
        tree_2 = repo.revision_tree(rev_id)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
430
        file_ids = self.rqst.get('specific_fileids')
4202.2.1 by Ian Clatworthy
get directory logging working again
431
        if diff_type == 'partial' and file_ids is not None:
432
            specific_files = [tree_2.id2path(id) for id in file_ids]
433
        else:
434
            specific_files = None
435
        s = StringIO()
4797.57.10 by Alexander Belchenko
path_encoding selection logic extracted as helper function
436
        path_encoding = osutils.get_diff_header_encoding()
4202.2.1 by Ian Clatworthy
get directory logging working again
437
        diff.show_diff_trees(tree_1, tree_2, s, specific_files, old_label='',
4797.57.9 by Alexander Belchenko
using terminal_encoding for log -p
438
            new_label='', path_encoding=path_encoding)
4202.2.1 by Ian Clatworthy
get directory logging working again
439
        return s.getvalue()
440
441
    def _create_log_revision_iterator(self):
442
        """Create a revision iterator for log.
443
444
        :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
445
            delta).
446
        """
447
        self.start_rev_id, self.end_rev_id = _get_revision_limits(
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
448
            self.branch, self.rqst.get('start_revision'),
449
            self.rqst.get('end_revision'))
450
        if self.rqst.get('_match_using_deltas'):
4202.2.1 by Ian Clatworthy
get directory logging working again
451
            return self._log_revision_iterator_using_delta_matching()
452
        else:
453
            # We're using the per-file-graph algorithm. This scales really
454
            # well but only makes sense if there is a single file and it's
455
            # not a directory
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
456
            file_count = len(self.rqst.get('specific_fileids'))
4202.2.1 by Ian Clatworthy
get directory logging working again
457
            if file_count != 1:
458
                raise BzrError("illegal LogRequest: must match-using-deltas "
459
                    "when logging %d files" % file_count)
460
            return self._log_revision_iterator_using_per_file_graph()
461
462
    def _log_revision_iterator_using_delta_matching(self):
463
        # Get the base revisions, filtering by the revision range
464
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
465
        generate_merge_revisions = rqst.get('levels') != 1
466
        delayed_graph_generation = not rqst.get('specific_fileids') and (
467
                rqst.get('limit') or self.start_rev_id or self.end_rev_id)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
468
        view_revisions = _calc_view_revisions(
469
            self.branch, self.start_rev_id, self.end_rev_id,
470
            rqst.get('direction'),
471
            generate_merge_revisions=generate_merge_revisions,
472
            delayed_graph_generation=delayed_graph_generation,
473
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
4202.2.1 by Ian Clatworthy
get directory logging working again
474
475
        # Apply the other filters
476
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
477
            rqst.get('delta_type'), rqst.get('message_search'),
478
            file_ids=rqst.get('specific_fileids'),
479
            direction=rqst.get('direction'))
4202.2.1 by Ian Clatworthy
get directory logging working again
480
481
    def _log_revision_iterator_using_per_file_graph(self):
482
        # Get the base revisions, filtering by the revision range.
483
        # Note that we always generate the merge revisions because
484
        # filter_revisions_touching_file_id() requires them ...
485
        rqst = self.rqst
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
486
        view_revisions = _calc_view_revisions(
487
            self.branch, self.start_rev_id, self.end_rev_id,
488
            rqst.get('direction'), generate_merge_revisions=True,
489
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
490
        if not isinstance(view_revisions, list):
491
            view_revisions = list(view_revisions)
4202.2.1 by Ian Clatworthy
get directory logging working again
492
        view_revisions = _filter_revisions_touching_file_id(self.branch,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
493
            rqst.get('specific_fileids')[0], view_revisions,
494
            include_merges=rqst.get('levels') != 1)
4202.2.1 by Ian Clatworthy
get directory logging working again
495
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
496
            rqst.get('delta_type'), rqst.get('message_search'))
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
497
498
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
499
def _calc_view_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
500
                         generate_merge_revisions,
501
                         delayed_graph_generation=False,
502
                         exclude_common_ancestry=False,
503
                         ):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
504
    """Calculate the revisions to view.
505
506
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
507
             a list of the same tuples.
508
    """
5097.1.13 by Vincent Ladeuil
Add more tests.
509
    if (exclude_common_ancestry and start_rev_id == end_rev_id):
510
        raise errors.BzrCommandError(
511
            '--exclude-common-ancestry requires two different revisions')
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
512
    if direction not in ('reverse', 'forward'):
513
        raise ValueError('invalid direction %r' % direction)
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
514
    br_revno, br_rev_id = branch.last_revision_info()
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
515
    if br_revno == 0:
516
        return []
517
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
518
    if (end_rev_id and start_rev_id == end_rev_id
5129.1.3 by Vincent Ladeuil
Slightly refactor the direction handling in log.
519
        and (not generate_merge_revisions
520
             or not _has_merges(branch, end_rev_id))):
5097.1.13 by Vincent Ladeuil
Add more tests.
521
        # If a single revision is requested, check we can handle it
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
522
        iter_revs = _generate_one_revision(branch, end_rev_id, br_rev_id,
523
                                           br_revno)
524
    elif not generate_merge_revisions:
525
        # If we only want to see linear revisions, we can iterate ...
526
        iter_revs = _generate_flat_revisions(branch, start_rev_id, end_rev_id,
527
                                             direction)
528
        if direction == 'forward':
529
            iter_revs = reversed(iter_revs)
4202.2.1 by Ian Clatworthy
get directory logging working again
530
    else:
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
531
        iter_revs = _generate_all_revisions(branch, start_rev_id, end_rev_id,
532
                                            direction, delayed_graph_generation,
533
                                            exclude_common_ancestry)
534
        if direction == 'forward':
535
            iter_revs = _rebase_merge_depth(reverse_by_depth(list(iter_revs)))
536
    return iter_revs
4202.2.1 by Ian Clatworthy
get directory logging working again
537
538
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
539
def _generate_one_revision(branch, rev_id, br_rev_id, br_revno):
4202.2.1 by Ian Clatworthy
get directory logging working again
540
    if rev_id == br_rev_id:
541
        # It's the tip
542
        return [(br_rev_id, br_revno, 0)]
543
    else:
544
        revno = branch.revision_id_to_dotted_revno(rev_id)
545
        revno_str = '.'.join(str(n) for n in revno)
546
        return [(rev_id, revno_str, 0)]
547
548
549
def _generate_flat_revisions(branch, start_rev_id, end_rev_id, direction):
550
    result = _linear_view_revisions(branch, start_rev_id, end_rev_id)
551
    # If a start limit was given and it's not obviously an
552
    # ancestor of the end limit, check it before outputting anything
553
    if direction == 'forward' or (start_rev_id
554
        and not _is_obvious_ancestor(branch, start_rev_id, end_rev_id)):
555
        try:
556
            result = list(result)
557
        except _StartNotLinearAncestor:
558
            raise errors.BzrCommandError('Start revision not found in'
559
                ' left-hand history of end revision.')
560
    return result
561
562
563
def _generate_all_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
564
                            delayed_graph_generation,
565
                            exclude_common_ancestry=False):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
566
    # On large trees, generating the merge graph can take 30-60 seconds
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
567
    # so we delay doing it until a merge is detected, incrementally
4955.7.5 by Vincent Ladeuil
Fixed as per Ian's review.
568
    # returning initial (non-merge) revisions while we can.
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
569
570
    # The above is only true for old formats (<= 0.92), for newer formats, a
571
    # couple of seconds only should be needed to load the whole graph and the
572
    # other graph operations needed are even faster than that -- vila 100201
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
573
    initial_revisions = []
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
574
    if delayed_graph_generation:
575
        try:
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
576
            for rev_id, revno, depth in  _linear_view_revisions(
577
                branch, start_rev_id, end_rev_id):
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
578
                if _has_merges(branch, rev_id):
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
579
                    # The end_rev_id can be nested down somewhere. We need an
580
                    # explicit ancestry check. There is an ambiguity here as we
581
                    # may not raise _StartNotLinearAncestor for a revision that
582
                    # is an ancestor but not a *linear* one. But since we have
583
                    # loaded the graph to do the check (or calculate a dotted
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
584
                    # revno), we may as well accept to show the log...  We need
585
                    # the check only if start_rev_id is not None as all
586
                    # revisions have _mod_revision.NULL_REVISION as an ancestor
587
                    # -- vila 20100319
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
588
                    graph = branch.repository.get_graph()
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
589
                    if (start_rev_id is not None
590
                        and not graph.is_ancestor(start_rev_id, end_rev_id)):
591
                        raise _StartNotLinearAncestor()
5097.1.1 by Vincent Ladeuil
Reduce duplication.
592
                    # Since we collected the revisions so far, we need to
593
                    # adjust end_rev_id.
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
594
                    end_rev_id = rev_id
595
                    break
596
                else:
597
                    initial_revisions.append((rev_id, revno, depth))
598
            else:
599
                # No merged revisions found
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
600
                return initial_revisions
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
601
        except _StartNotLinearAncestor:
602
            # A merge was never detected so the lower revision limit can't
603
            # be nested down somewhere
604
            raise errors.BzrCommandError('Start revision not found in'
605
                ' history of end revision.')
3936.3.15 by Ian Clatworthy
faster long log for a limited range with no merges
606
5097.1.1 by Vincent Ladeuil
Reduce duplication.
607
    # We exit the loop above because we encounter a revision with merges, from
608
    # this revision, we need to switch to _graph_view_revisions.
609
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
610
    # A log including nested merges is required. If the direction is reverse,
611
    # we rebase the initial merge depths so that the development line is
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
612
    # shown naturally, i.e. just like it is for linear logging. We can easily
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
613
    # make forward the exact opposite display, but showing the merge revisions
614
    # indented at the end seems slightly nicer in that case.
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
615
    view_revisions = chain(iter(initial_revisions),
616
        _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
617
                              rebase_initial_depths=(direction == 'reverse'),
618
                              exclude_common_ancestry=exclude_common_ancestry))
619
    return view_revisions
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
620
530 by Martin Pool
- put back verbose log support for reversed logs
621
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
622
def _has_merges(branch, rev_id):
623
    """Does a revision have multiple parents or not?"""
3936.3.40 by Ian Clatworthy
review feedback from jam
624
    parents = branch.repository.get_parent_map([rev_id]).get(rev_id, [])
625
    return len(parents) > 1
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
626
627
3936.3.31 by Ian Clatworthy
nicer obvious ancestor checking
628
def _is_obvious_ancestor(branch, start_rev_id, end_rev_id):
629
    """Is start_rev_id an obvious ancestor of end_rev_id?"""
630
    if start_rev_id and end_rev_id:
631
        start_dotted = branch.revision_id_to_dotted_revno(start_rev_id)
632
        end_dotted = branch.revision_id_to_dotted_revno(end_rev_id)
633
        if len(start_dotted) == 1 and len(end_dotted) == 1:
634
            # both on mainline
635
            return start_dotted[0] <= end_dotted[0]
636
        elif (len(start_dotted) == 3 and len(end_dotted) == 3 and
637
            start_dotted[0:1] == end_dotted[0:1]):
638
            # both on same development line
639
            return start_dotted[2] <= end_dotted[2]
640
        else:
641
            # not obvious
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
642
            return False
4955.5.3 by Vincent Ladeuil
Cleanup.
643
    # if either start or end is not specified then we use either the first or
644
    # the last revision and *they* are obvious ancestors.
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
645
    return True
646
647
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
648
def _linear_view_revisions(branch, start_rev_id, end_rev_id):
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
649
    """Calculate a sequence of revisions to view, newest to oldest.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
650
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
651
    :param start_rev_id: the lower revision-id
652
    :param end_rev_id: the upper revision-id
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
653
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
654
    :raises _StartNotLinearAncestor: if a start_rev_id is specified but
655
      is not found walking the left-hand history
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
656
    """
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
657
    br_revno, br_rev_id = branch.last_revision_info()
3943.4.5 by John Arbash Meinel
Restore _linear_view_revisions.
658
    repo = branch.repository
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
659
    if start_rev_id is None and end_rev_id is None:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
660
        cur_revno = br_revno
661
        for revision_id in repo.iter_reverse_revision_history(br_rev_id):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
662
            yield revision_id, str(cur_revno), 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
663
            cur_revno -= 1
3936.3.14 by Ian Clatworthy
bug fix
664
    else:
665
        if end_rev_id is None:
666
            end_rev_id = br_rev_id
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
667
        found_start = start_rev_id is None
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
668
        for revision_id in repo.iter_reverse_revision_history(end_rev_id):
3936.3.26 by Ian Clatworthy
use new dotted-revno-revision-id conversion methods to simplify & speed up code
669
            revno = branch.revision_id_to_dotted_revno(revision_id)
670
            revno_str = '.'.join(str(n) for n in revno)
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
671
            if not found_start and revision_id == start_rev_id:
672
                yield revision_id, revno_str, 0
673
                found_start = True
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
674
                break
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
675
            else:
676
                yield revision_id, revno_str, 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
677
        else:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
678
            if not found_start:
679
                raise _StartNotLinearAncestor()
3302.1.3 by Aaron Bentley
Add optimization of the simple case of generating view revisions
680
681
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
682
def _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
683
                          rebase_initial_depths=True,
684
                          exclude_common_ancestry=False):
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
685
    """Calculate revisions to view including merges, newest to oldest.
686
687
    :param branch: the branch
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
688
    :param start_rev_id: the lower revision-id
689
    :param end_rev_id: the upper revision-id
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
690
    :param rebase_initial_depth: should depths be rebased until a mainline
691
      revision is found?
692
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
693
    """
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
694
    if exclude_common_ancestry:
695
        stop_rule = 'with-merges-without-common-ancestry'
696
    else:
697
        stop_rule = 'with-merges'
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
698
    view_revisions = branch.iter_merge_sorted_revisions(
699
        start_revision_id=end_rev_id, stop_revision_id=start_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
700
        stop_rule=stop_rule)
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
701
    if not rebase_initial_depths:
702
        for (rev_id, merge_depth, revno, end_of_merge
703
             ) in view_revisions:
704
            yield rev_id, '.'.join(map(str, revno)), merge_depth
705
    else:
706
        # We're following a development line starting at a merged revision.
707
        # We need to adjust depths down by the initial depth until we find
708
        # a depth less than it. Then we use that depth as the adjustment.
709
        # If and when we reach the mainline, depth adjustment ends.
710
        depth_adjustment = None
711
        for (rev_id, merge_depth, revno, end_of_merge
712
             ) in view_revisions:
713
            if depth_adjustment is None:
714
                depth_adjustment = merge_depth
715
            if depth_adjustment:
716
                if merge_depth < depth_adjustment:
4955.5.3 by Vincent Ladeuil
Cleanup.
717
                    # From now on we reduce the depth adjustement, this can be
718
                    # surprising for users. The alternative requires two passes
719
                    # which breaks the fast display of the first revision
720
                    # though.
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
721
                    depth_adjustment = merge_depth
722
                merge_depth -= depth_adjustment
723
            yield rev_id, '.'.join(map(str, revno)), merge_depth
724
725
4955.4.14 by Vincent Ladeuil
Properly deprecate log.calculate_view_revisions.
726
@deprecated_function(deprecated_in((2, 2, 0)))
3936.3.13 by Ian Clatworthy
feedback from jameinel
727
def calculate_view_revisions(branch, start_revision, end_revision, direction,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
728
        specific_fileid, generate_merge_revisions):
3936.3.13 by Ian Clatworthy
feedback from jameinel
729
    """Calculate the revisions to view.
730
731
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
732
             a list of the same tuples.
733
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
734
    start_rev_id, end_rev_id = _get_revision_limits(branch, start_revision,
735
        end_revision)
736
    view_revisions = list(_calc_view_revisions(branch, start_rev_id, end_rev_id,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
737
        direction, generate_merge_revisions or specific_fileid))
3936.3.13 by Ian Clatworthy
feedback from jameinel
738
    if specific_fileid:
739
        view_revisions = _filter_revisions_touching_file_id(branch,
740
            specific_fileid, view_revisions,
741
            include_merges=generate_merge_revisions)
3936.3.28 by Ian Clatworthy
api compatibility: calculate_view_revisions rebases merge depth again
742
    return _rebase_merge_depth(view_revisions)
3936.3.13 by Ian Clatworthy
feedback from jameinel
743
744
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
745
def _rebase_merge_depth(view_revisions):
746
    """Adjust depths upwards so the top level is 0."""
747
    # If either the first or last revision have a merge_depth of 0, we're done
748
    if view_revisions and view_revisions[0][2] and view_revisions[-1][2]:
749
        min_depth = min([d for r,n,d in view_revisions])
750
        if min_depth != 0:
751
            view_revisions = [(r,n,d-min_depth) for r,n,d in view_revisions]
752
    return view_revisions
753
754
3936.3.16 by Ian Clatworthy
use deltas to match files in selected use cases
755
def make_log_rev_iterator(branch, view_revisions, generate_delta, search,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
756
        file_ids=None, direction='reverse'):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
757
    """Create a revision iterator for log.
758
759
    :param branch: The branch being logged.
760
    :param view_revisions: The revisions being viewed.
761
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
762
      Permitted values are None, 'full' and 'partial'.
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
763
    :param search: A user text search string.
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
764
    :param file_ids: If non empty, only revisions matching one or more of
765
      the file-ids are to be kept.
766
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
767
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
768
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
769
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
770
    # Convert view_revisions into (view, None, None) groups to fit with
771
    # the standard interface here.
772
    if type(view_revisions) == list:
3642.1.7 by Robert Collins
Review feedback.
773
        # A single batch conversion is faster than many incremental ones.
774
        # As we have all the data, do a batch conversion.
3642.1.5 by Robert Collins
Separate out batching of revisions.
775
        nones = [None] * len(view_revisions)
776
        log_rev_iterator = iter([zip(view_revisions, nones, nones)])
777
    else:
778
        def _convert():
779
            for view in view_revisions:
780
                yield (view, None, None)
781
        log_rev_iterator = iter([_convert()])
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
782
    for adapter in log_adapters:
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
783
        # It would be nicer if log adapters were first class objects
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
784
        # with custom parameters. This will do for now. IGC 20090127
785
        if adapter == _make_delta_filter:
786
            log_rev_iterator = adapter(branch, generate_delta,
787
                search, log_rev_iterator, file_ids, direction)
788
        else:
789
            log_rev_iterator = adapter(branch, generate_delta,
790
                search, log_rev_iterator)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
791
    return log_rev_iterator
792
793
3642.1.7 by Robert Collins
Review feedback.
794
def _make_search_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
795
    """Create a filtered iterator of log_rev_iterator matching on a regex.
796
797
    :param branch: The branch being logged.
798
    :param generate_delta: Whether to generate a delta for each revision.
799
    :param search: A user text search string.
800
    :param log_rev_iterator: An input iterator containing all revisions that
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
801
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
802
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
803
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
804
    """
805
    if search is None:
806
        return log_rev_iterator
4183.6.4 by Martin Pool
Separate out re_compile_checked
807
    searchRE = re_compile_checked(search, re.IGNORECASE,
808
            'log message filter')
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
809
    return _filter_message_re(searchRE, log_rev_iterator)
810
811
812
def _filter_message_re(searchRE, log_rev_iterator):
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
813
    for revs in log_rev_iterator:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
814
        new_revs = []
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
815
        for (rev_id, revno, merge_depth), rev, delta in revs:
816
            if searchRE.search(rev.message):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
817
                new_revs.append(((rev_id, revno, merge_depth), rev, delta))
818
        yield new_revs
819
820
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
821
def _make_delta_filter(branch, generate_delta, search, log_rev_iterator,
822
    fileids=None, direction='reverse'):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
823
    """Add revision deltas to a log iterator if needed.
824
825
    :param branch: The branch being logged.
826
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
827
      Permitted values are None, 'full' and 'partial'.
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
828
    :param search: A user text search string.
829
    :param log_rev_iterator: An input iterator containing all revisions that
830
        could be displayed, in lists.
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
831
    :param fileids: If non empty, only revisions matching one or more of
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
832
      the file-ids are to be kept.
833
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
834
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
835
        delta).
836
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
837
    if not generate_delta and not fileids:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
838
        return log_rev_iterator
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
839
    return _generate_deltas(branch.repository, log_rev_iterator,
840
        generate_delta, fileids, direction)
841
842
4202.2.1 by Ian Clatworthy
get directory logging working again
843
def _generate_deltas(repository, log_rev_iterator, delta_type, fileids,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
844
    direction):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
845
    """Create deltas for each batch of revisions in log_rev_iterator.
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
846
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
847
    If we're only generating deltas for the sake of filtering against
848
    file-ids, we stop generating deltas once all file-ids reach the
849
    appropriate life-cycle point. If we're receiving data newest to
850
    oldest, then that life-cycle point is 'add', otherwise it's 'remove'.
851
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
852
    check_fileids = fileids is not None and len(fileids) > 0
853
    if check_fileids:
854
        fileid_set = set(fileids)
855
        if direction == 'reverse':
856
            stop_on = 'add'
857
        else:
858
            stop_on = 'remove'
859
    else:
860
        fileid_set = None
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
861
    for revs in log_rev_iterator:
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
862
        # If we were matching against fileids and we've run out,
3936.3.40 by Ian Clatworthy
review feedback from jam
863
        # there's nothing left to do
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
864
        if check_fileids and not fileid_set:
3936.3.40 by Ian Clatworthy
review feedback from jam
865
            return
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
866
        revisions = [rev[1] for rev in revs]
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
867
        new_revs = []
4202.2.1 by Ian Clatworthy
get directory logging working again
868
        if delta_type == 'full' and not check_fileids:
869
            deltas = repository.get_deltas_for_revisions(revisions)
870
            for rev, delta in izip(revs, deltas):
871
                new_revs.append((rev[0], rev[1], delta))
872
        else:
873
            deltas = repository.get_deltas_for_revisions(revisions, fileid_set)
874
            for rev, delta in izip(revs, deltas):
875
                if check_fileids:
876
                    if delta is None or not delta.has_changed():
877
                        continue
878
                    else:
879
                        _update_fileids(delta, fileid_set, stop_on)
880
                        if delta_type is None:
881
                            delta = None
882
                        elif delta_type == 'full':
883
                            # If the file matches all the time, rebuilding
884
                            # a full delta like this in addition to a partial
4202.2.4 by Ian Clatworthy
comment tweak from vila's review
885
                            # one could be slow. However, it's likely that
4202.2.1 by Ian Clatworthy
get directory logging working again
886
                            # most revisions won't get this far, making it
887
                            # faster to filter on the partial deltas and
888
                            # build the occasional full delta than always
889
                            # building full deltas and filtering those.
890
                            rev_id = rev[0][0]
891
                            delta = repository.get_revision_delta(rev_id)
892
                new_revs.append((rev[0], rev[1], delta))
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
893
        yield new_revs
894
895
4202.2.1 by Ian Clatworthy
get directory logging working again
896
def _update_fileids(delta, fileids, stop_on):
897
    """Update the set of file-ids to search based on file lifecycle events.
898
    
899
    :param fileids: a set of fileids to update
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
900
    :param stop_on: either 'add' or 'remove' - take file-ids out of the
901
      fileids set once their add or remove entry is detected respectively
902
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
903
    if stop_on == 'add':
904
        for item in delta.added:
905
            if item[1] in fileids:
906
                fileids.remove(item[1])
907
    elif stop_on == 'delete':
908
        for item in delta.removed:
909
            if item[1] in fileids:
910
                fileids.remove(item[1])
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
911
912
3642.1.7 by Robert Collins
Review feedback.
913
def _make_revision_objects(branch, generate_delta, search, log_rev_iterator):
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
914
    """Extract revision objects from the repository
915
916
    :param branch: The branch being logged.
917
    :param generate_delta: Whether to generate a delta for each revision.
918
    :param search: A user text search string.
919
    :param log_rev_iterator: An input iterator containing all revisions that
920
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
921
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
922
        delta).
923
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
924
    repository = branch.repository
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
925
    for revs in log_rev_iterator:
926
        # r = revision_id, n = revno, d = merge depth
927
        revision_ids = [view[0] for view, _, _ in revs]
928
        revisions = repository.get_revisions(revision_ids)
929
        revs = [(rev[0], revision, rev[2]) for rev, revision in
930
            izip(revs, revisions)]
931
        yield revs
932
933
3642.1.7 by Robert Collins
Review feedback.
934
def _make_batch_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.5 by Robert Collins
Separate out batching of revisions.
935
    """Group up a single large batch into smaller ones.
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
936
937
    :param branch: The branch being logged.
938
    :param generate_delta: Whether to generate a delta for each revision.
939
    :param search: A user text search string.
3642.1.5 by Robert Collins
Separate out batching of revisions.
940
    :param log_rev_iterator: An input iterator containing all revisions that
941
        could be displayed, in lists.
3874.2.4 by Vincent Ladeuil
Fix too long lines.
942
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
943
        delta).
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
944
    """
945
    repository = branch.repository
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
946
    num = 9
3642.1.5 by Robert Collins
Separate out batching of revisions.
947
    for batch in log_rev_iterator:
948
        batch = iter(batch)
949
        while True:
950
            step = [detail for _, detail in zip(range(num), batch)]
951
            if len(step) == 0:
952
                break
953
            yield step
954
            num = min(int(num * 1.5), 200)
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
955
956
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
957
def _get_revision_limits(branch, start_revision, end_revision):
958
    """Get and check revision limits.
959
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
960
    :param  branch: The branch containing the revisions.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
961
962
    :param  start_revision: The first revision to be logged.
963
            For backwards compatibility this may be a mainline integer revno,
964
            but for merge revision support a RevisionInfo is expected.
965
966
    :param  end_revision: The last revision to be logged.
967
            For backwards compatibility this may be a mainline integer revno,
968
            but for merge revision support a RevisionInfo is expected.
969
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
970
    :return: (start_rev_id, end_rev_id) tuple.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
971
    """
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
972
    branch_revno, branch_rev_id = branch.last_revision_info()
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
973
    start_rev_id = None
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
974
    if start_revision is None:
975
        start_revno = 1
976
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
977
        if isinstance(start_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
978
            start_rev_id = start_revision.rev_id
979
            start_revno = start_revision.revno or 1
980
        else:
981
            branch.check_real_revno(start_revision)
982
            start_revno = start_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
983
            start_rev_id = branch.get_rev_id(start_revno)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
984
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
985
    end_rev_id = None
986
    if end_revision is None:
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
987
        end_revno = branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
988
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
989
        if isinstance(end_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
990
            end_rev_id = end_revision.rev_id
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
991
            end_revno = end_revision.revno or branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
992
        else:
993
            branch.check_real_revno(end_revision)
994
            end_revno = end_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
995
            end_rev_id = branch.get_rev_id(end_revno)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
996
3936.3.4 by Ian Clatworthy
fix empty_branch log
997
    if branch_revno != 0:
998
        if (start_rev_id == _mod_revision.NULL_REVISION
999
            or end_rev_id == _mod_revision.NULL_REVISION):
1000
            raise errors.BzrCommandError('Logging revision 0 is invalid.')
1001
        if start_revno > end_revno:
1002
            raise errors.BzrCommandError("Start revision must be older than "
1003
                                         "the end revision.")
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1004
    return (start_rev_id, end_rev_id)
1005
1006
1007
def _get_mainline_revs(branch, start_revision, end_revision):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1008
    """Get the mainline revisions from the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1009
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1010
    Generates the list of mainline revisions for the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1011
1012
    :param  branch: The branch containing the revisions.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1013
1014
    :param  start_revision: The first revision to be logged.
1015
            For backwards compatibility this may be a mainline integer revno,
1016
            but for merge revision support a RevisionInfo is expected.
1017
1018
    :param  end_revision: The last revision to be logged.
1019
            For backwards compatibility this may be a mainline integer revno,
1020
            but for merge revision support a RevisionInfo is expected.
1021
1022
    :return: A (mainline_revs, rev_nos, start_rev_id, end_rev_id) tuple.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1023
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1024
    branch_revno, branch_last_revision = branch.last_revision_info()
1025
    if branch_revno == 0:
1026
        return None, None, None, None
1027
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1028
    # For mainline generation, map start_revision and end_revision to
1029
    # mainline revnos. If the revision is not on the mainline choose the
1030
    # appropriate extreme of the mainline instead - the extra will be
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1031
    # filtered later.
1032
    # Also map the revisions to rev_ids, to be used in the later filtering
1033
    # stage.
1034
    start_rev_id = None
1035
    if start_revision is None:
1036
        start_revno = 1
1037
    else:
1038
        if isinstance(start_revision, revisionspec.RevisionInfo):
1039
            start_rev_id = start_revision.rev_id
1040
            start_revno = start_revision.revno or 1
1041
        else:
1042
            branch.check_real_revno(start_revision)
1043
            start_revno = start_revision
1044
1045
    end_rev_id = None
1046
    if end_revision is None:
1047
        end_revno = branch_revno
1048
    else:
1049
        if isinstance(end_revision, revisionspec.RevisionInfo):
1050
            end_rev_id = end_revision.rev_id
1051
            end_revno = end_revision.revno or branch_revno
1052
        else:
1053
            branch.check_real_revno(end_revision)
1054
            end_revno = end_revision
1055
1056
    if ((start_rev_id == _mod_revision.NULL_REVISION)
1057
        or (end_rev_id == _mod_revision.NULL_REVISION)):
1058
        raise errors.BzrCommandError('Logging revision 0 is invalid.')
1059
    if start_revno > end_revno:
1060
        raise errors.BzrCommandError("Start revision must be older than "
1061
                                     "the end revision.")
1062
1063
    if end_revno < start_revno:
1064
        return None, None, None, None
1065
    cur_revno = branch_revno
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1066
    rev_nos = {}
1067
    mainline_revs = []
1068
    for revision_id in branch.repository.iter_reverse_revision_history(
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1069
                        branch_last_revision):
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1070
        if cur_revno < start_revno:
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1071
            # We have gone far enough, but we always add 1 more revision
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1072
            rev_nos[revision_id] = cur_revno
1073
            mainline_revs.append(revision_id)
1074
            break
1075
        if cur_revno <= end_revno:
1076
            rev_nos[revision_id] = cur_revno
1077
            mainline_revs.append(revision_id)
1078
        cur_revno -= 1
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1079
    else:
1080
        # We walked off the edge of all revisions, so we add a 'None' marker
1081
        mainline_revs.append(None)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1082
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1083
    mainline_revs.reverse()
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1084
1085
    # override the mainline to look like the revision history.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1086
    return mainline_revs, rev_nos, start_rev_id, end_rev_id
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1087
1088
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1089
@deprecated_function(deprecated_in((2, 2, 0)))
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1090
def _filter_revision_range(view_revisions, start_rev_id, end_rev_id):
1091
    """Filter view_revisions based on revision ranges.
1092
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1093
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1094
            tuples to be filtered.
1095
1096
    :param start_rev_id: If not NONE specifies the first revision to be logged.
1097
            If NONE then all revisions up to the end_rev_id are logged.
1098
1099
    :param end_rev_id: If not NONE specifies the last revision to be logged.
1100
            If NONE then all revisions up to the end of the log are logged.
1101
1102
    :return: The filtered view_revisions.
1103
    """
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1104
    if start_rev_id or end_rev_id:
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1105
        revision_ids = [r for r, n, d in view_revisions]
1106
        if start_rev_id:
1107
            start_index = revision_ids.index(start_rev_id)
1108
        else:
1109
            start_index = 0
1110
        if start_rev_id == end_rev_id:
1111
            end_index = start_index
1112
        else:
1113
            if end_rev_id:
1114
                end_index = revision_ids.index(end_rev_id)
1115
            else:
1116
                end_index = len(view_revisions) - 1
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1117
        # To include the revisions merged into the last revision,
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1118
        # extend end_rev_id down to, but not including, the next rev
1119
        # with the same or lesser merge_depth
1120
        end_merge_depth = view_revisions[end_index][2]
1121
        try:
1122
            for index in xrange(end_index+1, len(view_revisions)+1):
1123
                if view_revisions[index][2] <= end_merge_depth:
1124
                    end_index = index - 1
1125
                    break
1126
        except IndexError:
1127
            # if the search falls off the end then log to the end as well
1128
            end_index = len(view_revisions) - 1
1129
        view_revisions = view_revisions[start_index:end_index+1]
1130
    return view_revisions
1131
1132
3940.1.3 by Ian Clatworthy
fix code
1133
def _filter_revisions_touching_file_id(branch, file_id, view_revisions,
1134
    include_merges=True):
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1135
    r"""Return the list of revision ids which touch a given file id.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1136
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1137
    The function filters view_revisions and returns a subset.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1138
    This includes the revisions which directly change the file id,
1139
    and the revisions which merge these changes. So if the
1140
    revision graph is::
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1141
        A-.
1142
        |\ \
1143
        B C E
1144
        |/ /
1145
        D |
1146
        |\|
1147
        | F
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1148
        |/
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1149
        G
1150
1151
    And 'C' changes a file, then both C and D will be returned. F will not be
1152
    returned even though it brings the changes to C into the branch starting
1153
    with E. (Note that if we were using F as the tip instead of G, then we
1154
    would see C, D, F.)
1155
1156
    This will also be restricted based on a subset of the mainline.
1157
1158
    :param branch: The branch where we can get text revision information.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1159
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1160
    :param file_id: Filter out revisions that do not touch file_id.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1161
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1162
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
1163
        tuples. This is the list of revisions which will be filtered. It is
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1164
        assumed that view_revisions is in merge_sort order (i.e. newest
1165
        revision first ).
1166
3940.1.3 by Ian Clatworthy
fix code
1167
    :param include_merges: include merge revisions in the result or not
1168
2359.1.8 by John Arbash Meinel
doc
1169
    :return: A list of (revision_id, dotted_revno, merge_depth) tuples.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1170
    """
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1171
    # Lookup all possible text keys to determine which ones actually modified
1172
    # the file.
1173
    text_keys = [(file_id, rev_id) for rev_id, revno, depth in view_revisions]
4183.3.1 by Vincent Ladeuil
Fix bug #346431 by allowing log._filter_revisions_touching_file_id to be
1174
    next_keys = None
3711.3.16 by John Arbash Meinel
Doc update.
1175
    # Looking up keys in batches of 1000 can cut the time in half, as well as
1176
    # memory consumption. GraphIndex *does* like to look for a few keys in
1177
    # parallel, it just doesn't like looking for *lots* of keys in parallel.
3711.3.19 by John Arbash Meinel
Add a TODO discussing how our index requests should evolve.
1178
    # TODO: This code needs to be re-evaluated periodically as we tune the
1179
    #       indexing layer. We might consider passing in hints as to the known
1180
    #       access pattern (sparse/clustered, high success rate/low success
1181
    #       rate). This particular access is clustered with a low success rate.
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1182
    get_parent_map = branch.repository.texts.get_parent_map
1183
    modified_text_revisions = set()
1184
    chunk_size = 1000
1185
    for start in xrange(0, len(text_keys), chunk_size):
1186
        next_keys = text_keys[start:start + chunk_size]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1187
        # Only keep the revision_id portion of the key
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1188
        modified_text_revisions.update(
1189
            [k[1] for k in get_parent_map(next_keys)])
1190
    del text_keys, next_keys
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1191
1192
    result = []
1193
    # Track what revisions will merge the current revision, replace entries
1194
    # with 'None' when they have been added to result
1195
    current_merge_stack = [None]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1196
    for info in view_revisions:
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1197
        rev_id, revno, depth = info
1198
        if depth == len(current_merge_stack):
1199
            current_merge_stack.append(info)
1200
        else:
1201
            del current_merge_stack[depth + 1:]
1202
            current_merge_stack[-1] = info
1203
1204
        if rev_id in modified_text_revisions:
1205
            # This needs to be logged, along with the extra revisions
1206
            for idx in xrange(len(current_merge_stack)):
1207
                node = current_merge_stack[idx]
1208
                if node is not None:
3940.1.3 by Ian Clatworthy
fix code
1209
                    if include_merges or node[2] == 0:
1210
                        result.append(node)
1211
                        current_merge_stack[idx] = None
3711.3.4 by John Arbash Meinel
Significantly faster, but consuming more memory.
1212
    return result
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1213
1214
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1215
@deprecated_function(deprecated_in((2, 2, 0)))
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1216
def get_view_revisions(mainline_revs, rev_nos, branch, direction,
1756.2.22 by Aaron Bentley
Apply review comments
1217
                       include_merges=True):
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1218
    """Produce an iterator of revisions to show
1219
    :return: an iterator of (revision_id, revno, merge_depth)
1220
    (if there is no revno for a revision, None is supplied)
1221
    """
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1222
    if not include_merges:
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1223
        revision_ids = mainline_revs[1:]
1224
        if direction == 'reverse':
1225
            revision_ids.reverse()
1226
        for revision_id in revision_ids:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1227
            yield revision_id, str(rev_nos[revision_id]), 0
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1228
        return
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1229
    graph = branch.repository.get_graph()
1230
    # This asks for all mainline revisions, which means we only have to spider
1231
    # sideways, rather than depth history. That said, its still size-of-history
1232
    # and should be addressed.
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1233
    # mainline_revisions always includes an extra revision at the beginning, so
1234
    # don't request it.
3287.6.8 by Robert Collins
Reduce code duplication as per review.
1235
    parent_map = dict(((key, value) for key, value in
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1236
        graph.iter_ancestry(mainline_revs[1:]) if value is not None))
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1237
    # filter out ghosts; merge_sort errors on ghosts.
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
1238
    rev_graph = _mod_repository._strip_NULL_ghosts(parent_map)
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1239
    merge_sorted_revisions = tsort.merge_sort(
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1240
        rev_graph,
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1241
        mainline_revs[-1],
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1242
        mainline_revs,
1243
        generate_revno=True)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1244
1245
    if direction == 'forward':
1246
        # forward means oldest first.
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1247
        merge_sorted_revisions = reverse_by_depth(merge_sorted_revisions)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1248
    elif direction != 'reverse':
1249
        raise ValueError('invalid direction %r' % direction)
1250
3874.2.4 by Vincent Ladeuil
Fix too long lines.
1251
    for (sequence, rev_id, merge_depth, revno, end_of_merge
1252
         ) in merge_sorted_revisions:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1253
        yield rev_id, '.'.join(map(str, revno)), merge_depth
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1254
1255
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1256
def reverse_by_depth(merge_sorted_revisions, _depth=0):
1257
    """Reverse revisions by depth.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1258
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1259
    Revisions with a different depth are sorted as a group with the previous
1260
    revision of that depth.  There may be no topological justification for this,
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1261
    but it looks much nicer.
1262
    """
3842.2.6 by Vincent Ladeuil
Fix typo.
1263
    # Add a fake revision at start so that we can always attach sub revisions
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1264
    merge_sorted_revisions = [(None, None, _depth)] + merge_sorted_revisions
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1265
    zd_revisions = []
1266
    for val in merge_sorted_revisions:
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1267
        if val[2] == _depth:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1268
            # Each revision at the current depth becomes a chunk grouping all
1269
            # higher depth revisions.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1270
            zd_revisions.append([val])
1271
        else:
1272
            zd_revisions[-1].append(val)
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1273
    for revisions in zd_revisions:
1274
        if len(revisions) > 1:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1275
            # We have higher depth revisions, let reverse them locally
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1276
            revisions[1:] = reverse_by_depth(revisions[1:], _depth + 1)
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1277
    zd_revisions.reverse()
1278
    result = []
1279
    for chunk in zd_revisions:
1280
        result.extend(chunk)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1281
    if _depth == 0:
1282
        # Top level call, get rid of the fake revisions that have been added
1283
        result = [r for r in result if r[0] is not None and r[1] is not None]
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1284
    return result
1285
1286
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1287
class LogRevision(object):
1288
    """A revision to be logged (by LogFormatter.log_revision).
1289
1290
    A simple wrapper for the attributes of a revision to be logged.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1291
    The attributes may or may not be populated, as determined by the
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1292
    logging options and the log formatter capabilities.
1293
    """
1294
2490.1.2 by John Arbash Meinel
Cleanup according to PEP8 and some other small whitespace fixes
1295
    def __init__(self, rev=None, revno=None, merge_depth=0, delta=None,
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1296
                 tags=None, diff=None):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1297
        self.rev = rev
3936.3.39 by Ian Clatworthy
merge bzr.dev r3975
1298
        self.revno = str(revno)
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1299
        self.merge_depth = merge_depth
1300
        self.delta = delta
1301
        self.tags = tags
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1302
        self.diff = diff
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1303
1304
794 by Martin Pool
- Merge John's nice short-log format.
1305
class LogFormatter(object):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1306
    """Abstract class to display log messages.
1307
1308
    At a minimum, a derived class must implement the log_revision method.
1309
1310
    If the LogFormatter needs to be informed of the beginning or end of
1311
    a log it should implement the begin_log and/or end_log hook methods.
1312
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1313
    A LogFormatter should define the following supports_XXX flags
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1314
    to indicate which LogRevision attributes it supports:
1315
1316
    - supports_delta must be True if this log formatter supports delta.
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1317
        Otherwise the delta attribute may not be populated.  The 'delta_format'
1318
        attribute describes whether the 'short_status' format (1) or the long
3936.3.2 by Ian Clatworthy
minor cleanups
1319
        one (2) should be used.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1320
1321
    - supports_merge_revisions must be True if this log formatter supports
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
1322
        merge revisions.  If not, then only mainline revisions will be passed
1323
        to the formatter.
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1324
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1325
    - preferred_levels is the number of levels this formatter defaults to.
1326
        The default value is zero meaning display all levels.
1327
        This value is only relevant if supports_merge_revisions is True.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1328
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1329
    - supports_tags must be True if this log formatter supports tags.
1330
        Otherwise the tags attribute may not be populated.
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1331
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1332
    - supports_diff must be True if this log formatter supports diffs.
1333
        Otherwise the diff attribute may not be populated.
1334
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1335
    Plugins can register functions to show custom revision properties using
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1336
    the properties_handler_registry. The registered function
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1337
    must respect the following interface description:
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1338
        def my_show_properties(properties_dict):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1339
            # code that returns a dict {'name':'value'} of the properties
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1340
            # to be shown
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1341
    """
3947.1.10 by Ian Clatworthy
review feedback from vila
1342
    preferred_levels = 0
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1343
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1344
    def __init__(self, to_file, show_ids=False, show_timezone='original',
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
1345
                 delta_format=None, levels=None, show_advice=False,
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1346
                 to_exact_file=None, author_list_handler=None):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1347
        """Create a LogFormatter.
1348
1349
        :param to_file: the file to output to
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1350
        :param to_exact_file: if set, gives an output stream to which 
1351
             non-Unicode diffs are written.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1352
        :param show_ids: if True, revision-ids are to be displayed
1353
        :param show_timezone: the timezone to use
1354
        :param delta_format: the level of delta information to display
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1355
          or None to leave it to the formatter to decide
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1356
        :param levels: the number of levels to display; None or -1 to
1357
          let the log formatter decide.
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1358
        :param show_advice: whether to show advice at the end of the
1359
          log or not
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1360
        :param author_list_handler: callable generating a list of
1361
          authors to display for a given revision
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1362
        """
794 by Martin Pool
- Merge John's nice short-log format.
1363
        self.to_file = to_file
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1364
        # 'exact' stream used to show diff, it should print content 'as is'
1365
        # and should not try to decode/encode it to unicode to avoid bug #328007
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1366
        if to_exact_file is not None:
1367
            self.to_exact_file = to_exact_file
1368
        else:
4792.8.12 by Martin Pool
comment
1369
            # XXX: somewhat hacky; this assumes it's a codec writer; it's better
1370
            # for code that expects to get diffs to pass in the exact file
1371
            # stream
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1372
            self.to_exact_file = getattr(to_file, 'stream', to_file)
794 by Martin Pool
- Merge John's nice short-log format.
1373
        self.show_ids = show_ids
1374
        self.show_timezone = show_timezone
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1375
        if delta_format is None:
1376
            # Ensures backward compatibility
1377
            delta_format = 2 # long format
1378
        self.delta_format = delta_format
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1379
        self.levels = levels
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1380
        self._show_advice = show_advice
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1381
        self._merge_count = 0
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1382
        self._author_list_handler = author_list_handler
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1383
3947.1.10 by Ian Clatworthy
review feedback from vila
1384
    def get_levels(self):
1385
        """Get the number of levels to display or 0 for all."""
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1386
        if getattr(self, 'supports_merge_revisions', False):
1387
            if self.levels is None or self.levels == -1:
4217.2.1 by Ian Clatworthy
fix log advice when the # of levels is implicit
1388
                self.levels = self.preferred_levels
1389
        else:
1390
            self.levels = 1
1391
        return self.levels
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1392
3947.1.10 by Ian Clatworthy
review feedback from vila
1393
    def log_revision(self, revision):
1394
        """Log a revision.
1395
1396
        :param  revision:   The LogRevision to be logged.
1397
        """
1398
        raise NotImplementedError('not implemented in abstract base')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1399
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1400
    def show_advice(self):
1401
        """Output user advice, if any, when the log is completed."""
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1402
        if self._show_advice and self.levels == 1 and self._merge_count > 0:
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1403
            advice_sep = self.get_advice_separator()
1404
            if advice_sep:
1405
                self.to_file.write(advice_sep)
4208.2.2 by Ian Clatworthy
show --levels 0 in advice, not just -n0
1406
            self.to_file.write(
4221.2.1 by Ian Clatworthy
--include-merges as an alias for --levels 0 in log
1407
                "Use --include-merges or -n0 to see merged revisions.\n")
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1408
1409
    def get_advice_separator(self):
1410
        """Get the text separating the log from the closing advice."""
1411
        return ''
1412
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1413
    def short_committer(self, rev):
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1414
        name, address = config.parse_username(rev.committer)
1415
        if name:
3063.3.1 by Lukáš Lalinský
Fall back to showing e-mail in ``log --short/--line`` if the committer/author has only e-mail.
1416
            return name
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1417
        return address
2388.1.11 by Alexander Belchenko
changes after John's review
1418
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1419
    def short_author(self, rev):
4081.3.14 by Martin von Gagern
Pass keyword arguments of authors method by name.
1420
        return self.authors(rev, 'first', short=True, sep=', ')
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1421
1422
    def authors(self, rev, who, short=False, sep=None):
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1423
        """Generate list of authors, taking --authors option into account.
1424
1425
        The caller has to specify the name of a author list handler,
1426
        as provided by the author list registry, using the ``who``
1427
        argument.  That name only sets a default, though: when the
1428
        user selected a different author list generation using the
1429
        ``--authors`` command line switch, as represented by the
1430
        ``author_list_handler`` constructor argument, that value takes
1431
        precedence.
1432
1433
        :param rev: The revision for which to generate the list of authors.
1434
        :param who: Name of the default handler.
1435
        :param short: Whether to shorten names to either name or address.
1436
        :param sep: What separator to use for automatic concatenation.
1437
        """
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1438
        if self._author_list_handler is not None:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1439
            # The user did specify --authors, which overrides the default
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1440
            author_list_handler = self._author_list_handler
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1441
        else:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1442
            # The user didn't specify --authors, so we use the caller's default
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1443
            author_list_handler = author_list_registry.get(who)
1444
        names = author_list_handler(rev)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1445
        if short:
1446
            for i in range(len(names)):
1447
                name, address = config.parse_username(names[i])
1448
                if name:
1449
                    names[i] = name
1450
                else:
1451
                    names[i] = address
1452
        if sep is not None:
1453
            names = sep.join(names)
1454
        return names
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1455
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1456
    def merge_marker(self, revision):
4213.1.1 by Ian Clatworthy
merge indicators in log --long (Ian Clatworthy)
1457
        """Get the merge marker to include in the output or '' if none."""
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1458
        if len(revision.rev.parent_ids) > 1:
1459
            self._merge_count += 1
1460
            return ' [merge]'
1461
        else:
1462
            return ''
1463
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
1464
    def show_properties(self, revision, indent):
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1465
        """Displays the custom properties returned by each registered handler.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1466
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1467
        If a registered handler raises an error it is propagated.
3144.7.5 by Guillermo Gonzalez
* some improvements to the doctstring in show_properties method and in LogFormatter
1468
        """
4379.4.1 by Ian Clatworthy
make log --long faster
1469
        for line in self.custom_properties(revision):
1470
            self.to_file.write("%s%s\n" % (indent, line))
1471
1472
    def custom_properties(self, revision):
1473
        """Format the custom properties returned by each registered handler.
1474
1475
        If a registered handler raises an error it is propagated.
1476
1477
        :return: a list of formatted lines (excluding trailing newlines)
1478
        """
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1479
        lines = self._foreign_info_properties(revision)
1480
        for key, handler in properties_handler_registry.iteritems():
1481
            lines.extend(self._format_properties(handler(revision)))
1482
        return lines
1483
1484
    def _foreign_info_properties(self, rev):
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1485
        """Custom log displayer for foreign revision identifiers.
1486
1487
        :param rev: Revision object.
1488
        """
1489
        # Revision comes directly from a foreign repository
1490
        if isinstance(rev, foreign.ForeignRevision):
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
1491
            return self._format_properties(
1492
                rev.mapping.vcs.show_foreign_revid(rev.foreign_revid))
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1493
1494
        # Imported foreign revision revision ids always contain :
1495
        if not ":" in rev.revision_id:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1496
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1497
1498
        # Revision was once imported from a foreign repository
1499
        try:
1500
            foreign_revid, mapping = \
1501
                foreign.foreign_vcs_registry.parse_revision_id(rev.revision_id)
1502
        except errors.InvalidRevisionId:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1503
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1504
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1505
        return self._format_properties(
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1506
            mapping.vcs.show_foreign_revid(foreign_revid))
1507
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1508
    def _format_properties(self, properties):
4379.4.1 by Ian Clatworthy
make log --long faster
1509
        lines = []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1510
        for key, value in properties.items():
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1511
            lines.append(key + ': ' + value)
4379.4.1 by Ian Clatworthy
make log --long faster
1512
        return lines
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1513
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1514
    def show_diff(self, to_file, diff, indent):
1515
        for l in diff.rstrip().split('\n'):
1516
            to_file.write(indent + '%s\n' % (l,))
1517
2388.1.11 by Alexander Belchenko
changes after John's review
1518
4379.4.1 by Ian Clatworthy
make log --long faster
1519
# Separator between revisions in long format
1520
_LONG_SEP = '-' * 60
1521
1522
794 by Martin Pool
- Merge John's nice short-log format.
1523
class LongLogFormatter(LogFormatter):
2388.1.11 by Alexander Belchenko
changes after John's review
1524
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1525
    supports_merge_revisions = True
4206.1.1 by Ian Clatworthy
log mainline by default
1526
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1527
    supports_delta = True
1528
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1529
    supports_diff = True
2388.1.10 by Alexander Belchenko
Slightly reworked: use None instead of [] as default tags list; PEP-8
1530
4379.4.1 by Ian Clatworthy
make log --long faster
1531
    def __init__(self, *args, **kwargs):
1532
        super(LongLogFormatter, self).__init__(*args, **kwargs)
1533
        if self.show_timezone == 'original':
1534
            self.date_string = self._date_string_original_timezone
1535
        else:
1536
            self.date_string = self._date_string_with_timezone
1537
1538
    def _date_string_with_timezone(self, rev):
1539
        return format_date(rev.timestamp, rev.timezone or 0,
1540
                           self.show_timezone)
1541
1542
    def _date_string_original_timezone(self, rev):
1543
        return format_date_with_offset_in_original_timezone(rev.timestamp,
1544
            rev.timezone or 0)
1545
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1546
    def log_revision(self, revision):
1547
        """Log a revision, either merged or not."""
2671.2.5 by Lukáš Lalinský
Fixes for comments from the mailing list.
1548
        indent = '    ' * revision.merge_depth
4379.4.1 by Ian Clatworthy
make log --long faster
1549
        lines = [_LONG_SEP]
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1550
        if revision.revno is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1551
            lines.append('revno: %s%s' % (revision.revno,
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1552
                self.merge_marker(revision)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1553
        if revision.tags:
4379.4.1 by Ian Clatworthy
make log --long faster
1554
            lines.append('tags: %s' % (', '.join(revision.tags)))
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1555
        if self.show_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1556
            lines.append('revision-id: %s' % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1557
            for parent_id in revision.rev.parent_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1558
                lines.append('parent: %s' % (parent_id,))
1559
        lines.extend(self.custom_properties(revision.rev))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1560
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1561
        committer = revision.rev.committer
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1562
        authors = self.authors(revision.rev, 'all')
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1563
        if authors != [committer]:
4379.4.1 by Ian Clatworthy
make log --long faster
1564
            lines.append('author: %s' % (", ".join(authors),))
1565
        lines.append('committer: %s' % (committer,))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1566
1567
        branch_nick = revision.rev.properties.get('branch-nick', None)
1568
        if branch_nick is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1569
            lines.append('branch nick: %s' % (branch_nick,))
1570
1571
        lines.append('timestamp: %s' % (self.date_string(revision.rev),))
1572
1573
        lines.append('message:')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1574
        if not revision.rev.message:
4379.4.1 by Ian Clatworthy
make log --long faster
1575
            lines.append('  (no message)')
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1576
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1577
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1578
            for l in message.split('\n'):
4379.4.1 by Ian Clatworthy
make log --long faster
1579
                lines.append('  %s' % (l,))
1580
1581
        # Dump the output, appending the delta and diff if requested
1582
        to_file = self.to_file
1583
        to_file.write("%s%s\n" % (indent, ('\n' + indent).join(lines)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1584
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1585
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1586
            from bzrlib.delta import report_delta
1587
            report_delta(to_file, revision.delta, short_status=False, 
1588
                         show_ids=self.show_ids, indent=indent)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1589
        if revision.diff is not None:
1590
            to_file.write(indent + 'diff:\n')
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1591
            to_file.flush()
3943.5.6 by Ian Clatworthy
feedback from jam's review
1592
            # Note: we explicitly don't indent the diff (relative to the
1593
            # revision information) so that the output can be fed to patch -p0
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1594
            self.show_diff(self.to_exact_file, revision.diff, indent)
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1595
            self.to_exact_file.flush()
794 by Martin Pool
- Merge John's nice short-log format.
1596
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1597
    def get_advice_separator(self):
1598
        """Get the text separating the log from the closing advice."""
1599
        return '-' * 60 + '\n'
1600
794 by Martin Pool
- Merge John's nice short-log format.
1601
1602
class ShortLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1603
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1604
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1605
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1606
    supports_delta = True
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1607
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1608
    supports_diff = True
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1609
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1610
    def __init__(self, *args, **kwargs):
1611
        super(ShortLogFormatter, self).__init__(*args, **kwargs)
1612
        self.revno_width_by_depth = {}
1613
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1614
    def log_revision(self, revision):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1615
        # We need two indents: one per depth and one for the information
1616
        # relative to that indent. Most mainline revnos are 5 chars or
3970.1.1 by Ian Clatworthy
log -n/--levels (Ian Clatworthy)
1617
        # less while dotted revnos are typically 11 chars or less. Once
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1618
        # calculated, we need to remember the offset for a given depth
1619
        # as we might be starting from a dotted revno in the first column
1620
        # and we want subsequent mainline revisions to line up.
1621
        depth = revision.merge_depth
1622
        indent = '    ' * depth
1623
        revno_width = self.revno_width_by_depth.get(depth)
1624
        if revno_width is None:
1625
            if revision.revno.find('.') == -1:
3947.1.10 by Ian Clatworthy
review feedback from vila
1626
                # mainline revno, e.g. 12345
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1627
                revno_width = 5
1628
            else:
3947.1.10 by Ian Clatworthy
review feedback from vila
1629
                # dotted revno, e.g. 12345.10.55
1630
                revno_width = 11
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1631
            self.revno_width_by_depth[depth] = revno_width
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1632
        offset = ' ' * (revno_width + 1)
1633
794 by Martin Pool
- Merge John's nice short-log format.
1634
        to_file = self.to_file
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1635
        tags = ''
1636
        if revision.tags:
3946.3.2 by Ian Clatworthy
add tests & NEWS item
1637
            tags = ' {%s}' % (', '.join(revision.tags))
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1638
        to_file.write(indent + "%*s %s\t%s%s%s\n" % (revno_width,
1639
                revision.revno, self.short_author(revision.rev),
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1640
                format_date(revision.rev.timestamp,
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1641
                            revision.rev.timezone or 0,
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1642
                            self.show_timezone, date_fmt="%Y-%m-%d",
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1643
                            show_offset=False),
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1644
                tags, self.merge_marker(revision)))
3976.3.1 by Neil Martinsen-Burrell
Add custom properties handling to short log format
1645
        self.show_properties(revision.rev, indent+offset)
794 by Martin Pool
- Merge John's nice short-log format.
1646
        if self.show_ids:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1647
            to_file.write(indent + offset + 'revision-id:%s\n'
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1648
                          % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1649
        if not revision.rev.message:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1650
            to_file.write(indent + offset + '(no message)\n')
794 by Martin Pool
- Merge John's nice short-log format.
1651
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1652
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1653
            for l in message.split('\n'):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1654
                to_file.write(indent + offset + '%s\n' % (l,))
794 by Martin Pool
- Merge John's nice short-log format.
1655
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1656
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1657
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1658
            from bzrlib.delta import report_delta
5076.4.6 by Arnaud Jeansen
Go back to unified report_delta method (i.e. former TreeDelta.show())
1659
            report_delta(to_file, revision.delta, 
1660
                         short_status=self.delta_format==1, 
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1661
                         show_ids=self.show_ids, indent=indent + offset)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1662
        if revision.diff is not None:
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1663
            self.show_diff(self.to_exact_file, revision.diff, '      ')
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1664
        to_file.write('\n')
794 by Martin Pool
- Merge John's nice short-log format.
1665
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1666
1185.12.25 by Aaron Bentley
Added one-line log format
1667
class LineLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1668
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1669
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1670
    preferred_levels = 1
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1671
    supports_tags = True
2997.1.1 by Kent Gibson
Support logging single merge revisions with short and line log formatters.
1672
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1673
    def __init__(self, *args, **kwargs):
1674
        super(LineLogFormatter, self).__init__(*args, **kwargs)
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1675
        width = terminal_width()
1676
        if width is not None:
1677
            # we need one extra space for terminals that wrap on last char
1678
            width = width - 1
1679
        self._max_chars = width
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1680
1185.12.25 by Aaron Bentley
Added one-line log format
1681
    def truncate(self, str, max_len):
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1682
        if max_len is None or len(str) <= max_len:
1185.12.25 by Aaron Bentley
Added one-line log format
1683
            return str
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1684
        return str[:max_len-3] + '...'
1185.12.25 by Aaron Bentley
Added one-line log format
1685
1686
    def date_string(self, rev):
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1687
        return format_date(rev.timestamp, rev.timezone or 0,
1185.12.25 by Aaron Bentley
Added one-line log format
1688
                           self.show_timezone, date_fmt="%Y-%m-%d",
1689
                           show_offset=False)
1690
1691
    def message(self, rev):
1692
        if not rev.message:
1693
            return '(no message)'
1694
        else:
1695
            return rev.message
1696
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1697
    def log_revision(self, revision):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1698
        indent = '  ' * revision.merge_depth
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1699
        self.to_file.write(self.log_string(revision.revno, revision.rev,
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1700
            self._max_chars, revision.tags, indent))
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1701
        self.to_file.write('\n')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1702
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1703
    def log_string(self, revno, rev, max_chars, tags=None, prefix=''):
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1704
        """Format log info into one string. Truncate tail of string
3677.1.1 by Vincent Ladeuil
Begin fixing bug #233817.
1705
        :param  revno:      revision number or None.
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1706
                            Revision numbers counts from 1.
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1707
        :param  rev:        revision object
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1708
        :param  max_chars:  maximum length of resulting string
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1709
        :param  tags:       list of tags or None
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1710
        :param  prefix:     string to prefix each line
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1711
        :return:            formatted truncated string
1712
        """
1713
        out = []
1714
        if revno:
1715
            # show revno only when is not None
3946.3.4 by Ian Clatworthy
minor cleanup
1716
            out.append("%s:" % revno)
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1717
        out.append(self.truncate(self.short_author(rev), 20))
1185.12.25 by Aaron Bentley
Added one-line log format
1718
        out.append(self.date_string(rev))
3983.2.1 by Neil Martinsen-Burrell
add merge indication to the line format
1719
        if len(rev.parent_ids) > 1:
1720
            out.append('[merge]')
3946.3.3 by Ian Clatworthy
feedback from jelmer re position of tags in --line
1721
        if tags:
1722
            tag_str = '{%s}' % (', '.join(tags))
1723
            out.append(tag_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
1724
        out.append(rev.get_summary())
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1725
        return self.truncate(prefix + " ".join(out).rstrip('\n'), max_chars)
794 by Martin Pool
- Merge John's nice short-log format.
1726
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1727
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1728
class GnuChangelogLogFormatter(LogFormatter):
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1729
1730
    supports_merge_revisions = True
1731
    supports_delta = True
1732
1733
    def log_revision(self, revision):
1734
        """Log a revision, either merged or not."""
1735
        to_file = self.to_file
1736
1737
        date_str = format_date(revision.rev.timestamp,
1738
                               revision.rev.timezone or 0,
1739
                               self.show_timezone,
1740
                               date_fmt='%Y-%m-%d',
1741
                               show_offset=False)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1742
        committer_str = self.authors(revision.rev, 'first', sep=', ')
4081.3.6 by Martin von Gagern
Drop space to make John happy.
1743
        committer_str = committer_str.replace(' <', '  <')
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1744
        to_file.write('%s  %s\n\n' % (date_str,committer_str))
1745
4137.1.1 by James Westby
Small improvements to the GNU ChangeLog formatter.
1746
        if revision.delta is not None and revision.delta.has_changed():
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1747
            for c in revision.delta.added + revision.delta.removed + revision.delta.modified:
1748
                path, = c[:1]
1749
                to_file.write('\t* %s:\n' % (path,))
1750
            for c in revision.delta.renamed:
1751
                oldpath,newpath = c[:2]
1752
                # For renamed files, show both the old and the new path
1753
                to_file.write('\t* %s:\n\t* %s:\n' % (oldpath,newpath))
1754
            to_file.write('\n')
1755
1756
        if not revision.rev.message:
1757
            to_file.write('\tNo commit message\n')
1758
        else:
1759
            message = revision.rev.message.rstrip('\r\n')
1760
            for l in message.split('\n'):
1761
                to_file.write('\t%s\n' % (l.lstrip(),))
1762
            to_file.write('\n')
1763
1764
1185.12.27 by Aaron Bentley
Use line log for pending merges
1765
def line_log(rev, max_chars):
1766
    lf = LineLogFormatter(None)
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1767
    return lf.log_string(None, rev, max_chars)
1185.12.27 by Aaron Bentley
Use line log for pending merges
1768
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1769
1770
class LogFormatterRegistry(registry.Registry):
1771
    """Registry for log formatters"""
1772
1773
    def make_formatter(self, name, *args, **kwargs):
1774
        """Construct a formatter from arguments.
1775
1776
        :param name: Name of the formatter to construct.  'short', 'long' and
1777
            'line' are built-in.
1778
        """
1779
        return self.get(name)(*args, **kwargs)
1780
1781
    def get_default(self, branch):
1782
        return self.get(branch.get_config().log_format())
1783
1784
1785
log_formatter_registry = LogFormatterRegistry()
1786
1787
1788
log_formatter_registry.register('short', ShortLogFormatter,
1789
                                'Moderately short log format')
1790
log_formatter_registry.register('long', LongLogFormatter,
1791
                                'Detailed log format')
1792
log_formatter_registry.register('line', LineLogFormatter,
1793
                                'Log format with one line per revision')
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1794
log_formatter_registry.register('gnu-changelog', GnuChangelogLogFormatter,
1795
                                'Format used by GNU ChangeLog files')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1796
794 by Martin Pool
- Merge John's nice short-log format.
1797
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1798
def register_formatter(name, formatter):
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1799
    log_formatter_registry.register(name, formatter)
1800
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1801
794 by Martin Pool
- Merge John's nice short-log format.
1802
def log_formatter(name, *args, **kwargs):
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1803
    """Construct a formatter from arguments.
1804
1185.12.27 by Aaron Bentley
Use line log for pending merges
1805
    name -- Name of the formatter to construct; currently 'long', 'short' and
1806
        'line' are supported.
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1807
    """
794 by Martin Pool
- Merge John's nice short-log format.
1808
    try:
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1809
        return log_formatter_registry.make_formatter(name, *args, **kwargs)
1553.2.2 by Erik Bågfors
Made "unknown log formatter" error message work
1810
    except KeyError:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1811
        raise errors.BzrCommandError("unknown log formatter: %r" % name)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1812
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1813
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1814
def author_list_all(rev):
1815
    return rev.get_apparent_authors()[:]
1816
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1817
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1818
def author_list_first(rev):
1819
    lst = rev.get_apparent_authors()
1820
    try:
1821
        return [lst[0]]
1822
    except IndexError:
1823
        return []
1824
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1825
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1826
def author_list_committer(rev):
1827
    return [rev.committer]
1828
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1829
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1830
author_list_registry = registry.Registry()
1831
1832
author_list_registry.register('all', author_list_all,
1833
                              'All authors')
1834
1835
author_list_registry.register('first', author_list_first,
1836
                              'The first author')
1837
1838
author_list_registry.register('committer', author_list_committer,
1839
                              'The committer')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1840
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1841
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1842
def show_one_log(revno, rev, delta, verbose, to_file, show_timezone):
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
1843
    # deprecated; for compatibility
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1844
    lf = LongLogFormatter(to_file=to_file, show_timezone=show_timezone)
1845
    lf.show(revno, rev, delta)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1846
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1847
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1848
def show_changed_revisions(branch, old_rh, new_rh, to_file=None,
1849
                           log_format='long'):
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1850
    """Show the change in revision history comparing the old revision history to the new one.
1851
1852
    :param branch: The branch where the revisions exist
1853
    :param old_rh: The old revision history
1854
    :param new_rh: The new revision history
1855
    :param to_file: A file to write the results to. If None, stdout will be used
1856
    """
1857
    if to_file is None:
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
1858
        to_file = codecs.getwriter(get_terminal_encoding())(sys.stdout,
1859
            errors='replace')
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1860
    lf = log_formatter(log_format,
1861
                       show_ids=False,
1862
                       to_file=to_file,
1863
                       show_timezone='original')
1864
1865
    # This is the first index which is different between
1866
    # old and new
1867
    base_idx = None
1868
    for i in xrange(max(len(new_rh),
1869
                        len(old_rh))):
1870
        if (len(new_rh) <= i
1871
            or len(old_rh) <= i
1872
            or new_rh[i] != old_rh[i]):
1873
            base_idx = i
1874
            break
1875
1876
    if base_idx is None:
1877
        to_file.write('Nothing seems to have changed\n')
1878
        return
1879
    ## TODO: It might be nice to do something like show_log
1880
    ##       and show the merged entries. But since this is the
1881
    ##       removed revisions, it shouldn't be as important
1882
    if base_idx < len(old_rh):
1883
        to_file.write('*'*60)
1884
        to_file.write('\nRemoved Revisions:\n')
1885
        for i in range(base_idx, len(old_rh)):
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
1886
            rev = branch.repository.get_revision(old_rh[i])
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1887
            lr = LogRevision(rev, i+1, 0, None)
1888
            lf.log_revision(lr)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1889
        to_file.write('*'*60)
1890
        to_file.write('\n\n')
1891
    if base_idx < len(new_rh):
1892
        to_file.write('Added Revisions:\n')
1893
        show_log(branch,
1894
                 lf,
1895
                 None,
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1896
                 verbose=False,
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1897
                 direction='forward',
1898
                 start_revision=base_idx+1,
1899
                 end_revision=len(new_rh),
1900
                 search=None)
1901
3144.7.4 by Guillermo Gonzalez
* move the function regisstry into a real Registry instead of a list
1902
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1903
def get_history_change(old_revision_id, new_revision_id, repository):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1904
    """Calculate the uncommon lefthand history between two revisions.
1905
1906
    :param old_revision_id: The original revision id.
1907
    :param new_revision_id: The new revision id.
3848.1.22 by Aaron Bentley
Fix spelling
1908
    :param repository: The repository to use for the calculation.
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1909
1910
    return old_history, new_history
1911
    """
3848.1.6 by Aaron Bentley
Implement get_history_change
1912
    old_history = []
1913
    old_revisions = set()
1914
    new_history = []
1915
    new_revisions = set()
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1916
    new_iter = repository.iter_reverse_revision_history(new_revision_id)
1917
    old_iter = repository.iter_reverse_revision_history(old_revision_id)
3848.1.6 by Aaron Bentley
Implement get_history_change
1918
    stop_revision = None
1919
    do_old = True
1920
    do_new = True
1921
    while do_new or do_old:
1922
        if do_new:
1923
            try:
1924
                new_revision = new_iter.next()
1925
            except StopIteration:
1926
                do_new = False
1927
            else:
1928
                new_history.append(new_revision)
1929
                new_revisions.add(new_revision)
1930
                if new_revision in old_revisions:
1931
                    stop_revision = new_revision
1932
                    break
1933
        if do_old:
1934
            try:
1935
                old_revision = old_iter.next()
1936
            except StopIteration:
1937
                do_old = False
1938
            else:
1939
                old_history.append(old_revision)
1940
                old_revisions.add(old_revision)
1941
                if old_revision in new_revisions:
1942
                    stop_revision = old_revision
1943
                    break
1944
    new_history.reverse()
1945
    old_history.reverse()
1946
    if stop_revision is not None:
1947
        new_history = new_history[new_history.index(stop_revision) + 1:]
1948
        old_history = old_history[old_history.index(stop_revision) + 1:]
1949
    return old_history, new_history
1950
1951
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1952
def show_branch_change(branch, output, old_revno, old_revision_id):
1953
    """Show the changes made to a branch.
1954
1955
    :param branch: The branch to show changes about.
1956
    :param output: A file-like object to write changes to.
1957
    :param old_revno: The revno of the old tip.
1958
    :param old_revision_id: The revision_id of the old tip.
1959
    """
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1960
    new_revno, new_revision_id = branch.last_revision_info()
1961
    old_history, new_history = get_history_change(old_revision_id,
1962
                                                  new_revision_id,
1963
                                                  branch.repository)
1964
    if old_history == [] and new_history == []:
1965
        output.write('Nothing seems to have changed\n')
1966
        return
1967
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1968
    log_format = log_formatter_registry.get_default(branch)
1969
    lf = log_format(show_ids=False, to_file=output, show_timezone='original')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1970
    if old_history != []:
1971
        output.write('*'*60)
1972
        output.write('\nRemoved Revisions:\n')
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1973
        show_flat_log(branch.repository, old_history, old_revno, lf)
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1974
        output.write('*'*60)
1975
        output.write('\n\n')
1976
    if new_history != []:
3848.1.9 by Aaron Bentley
new/old sections are omitted as appropriate.
1977
        output.write('Added Revisions:\n')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1978
        start_revno = new_revno - len(new_history) + 1
1979
        show_log(branch, lf, None, verbose=False, direction='forward',
1980
                 start_revision=start_revno,)
1981
1982
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1983
def show_flat_log(repository, history, last_revno, lf):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1984
    """Show a simple log of the specified history.
1985
1986
    :param repository: The repository to retrieve revisions from.
1987
    :param history: A list of revision_ids indicating the lefthand history.
1988
    :param last_revno: The revno of the last revision_id in the history.
1989
    :param lf: The log formatter to use.
1990
    """
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1991
    start_revno = last_revno - len(history) + 1
1992
    revisions = repository.get_revisions(history)
1993
    for i, rev in enumerate(revisions):
1994
        lr = LogRevision(rev, i + last_revno, 0, None)
1995
        lf.log_revision(lr)
1996
1997
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
1998
def _get_info_for_log_files(revisionspec_list, file_list, add_cleanup):
4202.2.1 by Ian Clatworthy
get directory logging working again
1999
    """Find file-ids and kinds given a list of files and a revision range.
2000
2001
    We search for files at the end of the range. If not found there,
2002
    we try the start of the range.
2003
2004
    :param revisionspec_list: revision range as parsed on the command line
2005
    :param file_list: the list of paths given on the command line;
2006
      the first of these can be a branch location or a file path,
2007
      the remainder must be file paths
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2008
    :param add_cleanup: When the branch returned is read locked,
2009
      an unlock call will be queued to the cleanup.
4202.2.1 by Ian Clatworthy
get directory logging working again
2010
    :return: (branch, info_list, start_rev_info, end_rev_info) where
2011
      info_list is a list of (relative_path, file_id, kind) tuples where
2012
      kind is one of values 'directory', 'file', 'symlink', 'tree-reference'.
4634.90.1 by Andrew Bennetts
Fix ObjectNotLocked error during 'bzr log' by acquiring branch read lock as soon as cmd_log acquires the branch, only releasing it at the end.
2013
      branch will be read-locked.
3943.6.4 by Ian Clatworthy
review feedback from vila
2014
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
2015
    from builtins import _get_revision_range, safe_relpath_files
2016
    tree, b, path = bzrdir.BzrDir.open_containing_tree_or_branch(file_list[0])
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2017
    add_cleanup(b.lock_read().unlock)
4202.2.1 by Ian Clatworthy
get directory logging working again
2018
    # XXX: It's damn messy converting a list of paths to relative paths when
2019
    # those paths might be deleted ones, they might be on a case-insensitive
2020
    # filesystem and/or they might be in silly locations (like another branch).
2021
    # For example, what should "log bzr://branch/dir/file1 file2" do? (Is
2022
    # file2 implicitly in the same dir as file1 or should its directory be
2023
    # taken from the current tree somehow?) For now, this solves the common
2024
    # case of running log in a nested directory, assuming paths beyond the
2025
    # first one haven't been deleted ...
2026
    if tree:
2027
        relpaths = [path] + safe_relpath_files(tree, file_list[1:])
2028
    else:
2029
        relpaths = [path] + file_list[1:]
2030
    info_list = []
2031
    start_rev_info, end_rev_info = _get_revision_range(revisionspec_list, b,
2032
        "log")
4296.2.1 by Jelmer Vernooij
Don't retrieve the tree if log is called on the root.
2033
    if relpaths in ([], [u'']):
2034
        return b, [], start_rev_info, end_rev_info
4202.2.1 by Ian Clatworthy
get directory logging working again
2035
    if start_rev_info is None and end_rev_info is None:
3943.6.4 by Ian Clatworthy
review feedback from vila
2036
        if tree is None:
2037
            tree = b.basis_tree()
4202.2.1 by Ian Clatworthy
get directory logging working again
2038
        tree1 = None
2039
        for fp in relpaths:
2040
            file_id = tree.path2id(fp)
2041
            kind = _get_kind_for_file_id(tree, file_id)
2042
            if file_id is None:
2043
                # go back to when time began
2044
                if tree1 is None:
2045
                    try:
2046
                        rev1 = b.get_rev_id(1)
2047
                    except errors.NoSuchRevision:
2048
                        # No history at all
2049
                        file_id = None
2050
                        kind = None
2051
                    else:
2052
                        tree1 = b.repository.revision_tree(rev1)
2053
                if tree1:
2054
                    file_id = tree1.path2id(fp)
2055
                    kind = _get_kind_for_file_id(tree1, file_id)
2056
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2057
4202.2.1 by Ian Clatworthy
get directory logging working again
2058
    elif start_rev_info == end_rev_info:
3943.6.4 by Ian Clatworthy
review feedback from vila
2059
        # One revision given - file must exist in it
4202.2.1 by Ian Clatworthy
get directory logging working again
2060
        tree = b.repository.revision_tree(end_rev_info.rev_id)
2061
        for fp in relpaths:
2062
            file_id = tree.path2id(fp)
2063
            kind = _get_kind_for_file_id(tree, file_id)
2064
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2065
4202.2.1 by Ian Clatworthy
get directory logging working again
2066
    else:
3943.6.4 by Ian Clatworthy
review feedback from vila
2067
        # Revision range given. Get the file-id from the end tree.
2068
        # If that fails, try the start tree.
4202.2.1 by Ian Clatworthy
get directory logging working again
2069
        rev_id = end_rev_info.rev_id
3943.6.4 by Ian Clatworthy
review feedback from vila
2070
        if rev_id is None:
2071
            tree = b.basis_tree()
2072
        else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2073
            tree = b.repository.revision_tree(rev_id)
2074
        tree1 = None
2075
        for fp in relpaths:
3943.6.4 by Ian Clatworthy
review feedback from vila
2076
            file_id = tree.path2id(fp)
4202.2.1 by Ian Clatworthy
get directory logging working again
2077
            kind = _get_kind_for_file_id(tree, file_id)
2078
            if file_id is None:
2079
                if tree1 is None:
2080
                    rev_id = start_rev_info.rev_id
2081
                    if rev_id is None:
2082
                        rev1 = b.get_rev_id(1)
2083
                        tree1 = b.repository.revision_tree(rev1)
2084
                    else:
2085
                        tree1 = b.repository.revision_tree(rev_id)
2086
                file_id = tree1.path2id(fp)
2087
                kind = _get_kind_for_file_id(tree1, file_id)
2088
            info_list.append((fp, file_id, kind))
2089
    return b, info_list, start_rev_info, end_rev_info
2090
2091
2092
def _get_kind_for_file_id(tree, file_id):
2093
    """Return the kind of a file-id or None if it doesn't exist."""
2094
    if file_id is not None:
2095
        return tree.kind(file_id)
3943.6.4 by Ian Clatworthy
review feedback from vila
2096
    else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2097
        return None
3943.6.4 by Ian Clatworthy
review feedback from vila
2098
2099
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
2100
properties_handler_registry = registry.Registry()
3830.4.1 by Jelmer Vernooij
Add base classes for foreign branches.
2101
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2102
# Use the properties handlers to print out bug information if available
2103
def _bugs_properties_handler(revision):
2104
    if revision.properties.has_key('bugs'):
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2105
        bug_lines = revision.properties['bugs'].split('\n')
2106
        bug_rows = [line.split(' ', 1) for line in bug_lines]
2107
        fixed_bug_urls = [row[0] for row in bug_rows if
2108
                          len(row) > 1 and row[1] == 'fixed']
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
2109
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2110
        if fixed_bug_urls:
2111
            return {'fixes bug(s)': ' '.join(fixed_bug_urls)}
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2112
    return {}
2113
2114
properties_handler_registry.register('bugs_properties_handler',
2115
                                     _bugs_properties_handler)
2116
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2117
2118
# adapters which revision ids to log are filtered. When log is called, the
2119
# log_rev_iterator is adapted through each of these factory methods.
2120
# Plugins are welcome to mutate this list in any way they like - as long
2121
# as the overall behaviour is preserved. At this point there is no extensible
2122
# mechanism for getting parameters to each factory method, and until there is
2123
# this won't be considered a stable api.
2124
log_adapters = [
2125
    # core log logic
3642.1.7 by Robert Collins
Review feedback.
2126
    _make_batch_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2127
    # read revision objects
3642.1.7 by Robert Collins
Review feedback.
2128
    _make_revision_objects,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2129
    # filter on log messages
3642.1.7 by Robert Collins
Review feedback.
2130
    _make_search_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2131
    # generate deltas for things we will show
3642.1.7 by Robert Collins
Review feedback.
2132
    _make_delta_filter
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2133
    ]