/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
4634.39.32 by Ian Clatworthy
proper Contents panel in bzr-developers.chm
1
====================
2
Bazaar Testing Guide
3
====================
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
4
5
6
The Importance of Testing
7
=========================
8
5225.2.1 by Martin Pool
Mention Babune in test guide.
9
Reliability is a critical success factor for any version control system.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
10
We want Bazaar to be highly reliable across multiple platforms while
11
evolving over time to meet the needs of its community.
12
13
In a nutshell, this is what we expect and encourage:
14
15
* New functionality should have test cases.  Preferably write the
16
  test before writing the code.
17
18
  In general, you can test at either the command-line level or the
19
  internal API level.  See `Writing tests`_ below for more detail.
20
21
* Try to practice Test-Driven Development: before fixing a bug, write a
22
  test case so that it does not regress.  Similarly for adding a new
23
  feature: write a test case for a small version of the new feature before
24
  starting on the code itself.  Check the test fails on the old code, then
25
  add the feature or fix and check it passes.
26
27
By doing these things, the Bazaar team gets increased confidence that
28
changes do what they claim to do, whether provided by the core team or
29
by community members. Equally importantly, we can be surer that changes
30
down the track do not break new features or bug fixes that you are
31
contributing today.
32
4665.2.2 by Martin Pool
Doc update that there are actually many more tests now
33
As of September 2009, Bazaar ships with a test suite containing over
34
23,000 tests and growing. We are proud of it and want to remain so. As
35
community members, we all benefit from it. Would you trust version control
36
on your project to a product *without* a test suite like Bazaar has?
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
37
38
39
Running the Test Suite
40
======================
41
5004.2.5 by Martin Pool
More docs on testing
42
As of Bazaar 2.1, you must have the testtools_ library installed to run
43
the bzr test suite.
44
45
.. _testtools: https://launchpad.net/testtools/
46
5004.2.4 by Martin Pool
More tips on running tests
47
To test all of Bazaar, just run::
48
49
  bzr selftest 
50
5004.2.5 by Martin Pool
More docs on testing
51
With ``--verbose`` bzr will print the name of every test as it is run.
52
5004.2.4 by Martin Pool
More tips on running tests
53
This should always pass, whether run from a source tree or an installed
54
copy of Bazaar.  Please investigate and/or report any failures.
55
56
57
Running particular tests
58
------------------------
59
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
60
Currently, bzr selftest is used to invoke tests.
61
You can provide a pattern argument to run a subset. For example,
62
to run just the blackbox tests, run::
63
64
  ./bzr selftest -v blackbox
65
66
To skip a particular test (or set of tests), use the --exclude option
67
(shorthand -x) like so::
68
69
  ./bzr selftest -v -x blackbox
70
71
To ensure that all tests are being run and succeeding, you can use the
72
--strict option which will fail if there are any missing features or known
73
failures, like so::
74
75
  ./bzr selftest --strict
76
77
To list tests without running them, use the --list-only option like so::
78
79
  ./bzr selftest --list-only
80
81
This option can be combined with other selftest options (like -x) and
82
filter patterns to understand their effect.
83
84
Once you understand how to create a list of tests, you can use the --load-list
85
option to run only a restricted set of tests that you kept in a file, one test
86
id by line. Keep in mind that this will never be sufficient to validate your
87
modifications, you still need to run the full test suite for that, but using it
88
can help in some cases (like running only the failed tests for some time)::
89
90
  ./bzr selftest -- load-list my_failing_tests
91
92
This option can also be combined with other selftest options, including
93
patterns. It has some drawbacks though, the list can become out of date pretty
94
quick when doing Test Driven Development.
95
96
To address this concern, there is another way to run a restricted set of tests:
97
the --starting-with option will run only the tests whose name starts with the
98
specified string. It will also avoid loading the other tests and as a
99
consequence starts running your tests quicker::
100
101
  ./bzr selftest --starting-with bzrlib.blackbox
102
103
This option can be combined with all the other selftest options including
104
--load-list. The later is rarely used but allows to run a subset of a list of
105
failing tests for example.
106
5004.2.4 by Martin Pool
More tips on running tests
107
Disabling plugins
108
-----------------
109
110
To test only the bzr core, ignoring any plugins you may have installed,
111
use::
112
113
  ./bzr --no-plugins selftest 
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
114
5004.2.2 by Martin Pool
Recommend using -Dno_apport for development
115
Disabling crash reporting
116
-------------------------
117
118
By default Bazaar uses apport_ to report program crashes.  In developing
119
Bazaar it's normal and expected to have it crash from time to time, at
120
least because a test failed if for no other reason.
121
122
Therefore you should probably add ``debug_flags = no_apport`` to your
123
``bazaar.conf`` file (in ``~/.bazaar/`` on Unix), so that failures just
124
print a traceback rather than writing a crash file.
125
126
.. _apport: https://launchpad.net/apport/
127
128
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
129
Test suite debug flags
130
----------------------
131
132
Similar to the global ``-Dfoo`` debug options, bzr selftest accepts
133
``-E=foo`` debug flags.  These flags are:
134
135
:allow_debug: do *not* clear the global debug flags when running a test.
136
  This can provide useful logging to help debug test failures when used
137
  with e.g. ``bzr -Dhpss selftest -E=allow_debug``
138
5004.2.3 by Martin Pool
Caveat on -Eallow_debug
139
  Note that this will probably cause some tests to fail, because they
140
  don't expect to run with any debug flags on.
141
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
142
5004.2.5 by Martin Pool
More docs on testing
143
Using subunit
144
-------------
145
146
Bazaar can optionally produce output in the machine-readable subunit_
5060.2.1 by Robert Collins
* bzr now has a ``.testr.conf`` file in its source tree configured
147
format, so that test output can be post-processed by various tools. To
148
generate a subunit test stream::
149
150
 $ ./bzr selftest --subunit
151
152
Processing such a stream can be done using a variety of tools including:
153
154
* The builtin ``subunit2pyunit``, ``subunit-filter``, ``subunit-ls``,
155
  ``subunit2junitxml`` from the subunit project.
156
157
* tribunal_, a GUI for showing test results.
158
159
* testrepository_, a tool for gathering and managing test runs.
5004.2.5 by Martin Pool
More docs on testing
160
161
.. _subunit: https://launchpad.net/subunit/
5060.2.1 by Robert Collins
* bzr now has a ``.testr.conf`` file in its source tree configured
162
.. _tribunal: https://launchpad.net/tribunal/
163
164
165
Using testrepository
166
--------------------
167
168
Bazaar ships with a config file for testrepository_. This can be very
169
useful for keeping track of failing tests and doing general workflow
170
support. To run tests using testrepository::
171
172
  $ testr run
173
174
To run only failing tests::
175
176
  $ testr run --failing
177
178
To run only some tests, without plugins::
179
180
  $ test run test_selftest -- --no-plugins
181
182
See the testrepository documentation for more details.
183
184
.. _testrepository: https://launchpad.net/testrepository
5004.2.5 by Martin Pool
More docs on testing
185
5225.2.1 by Martin Pool
Mention Babune in test guide.
186
187
Babune continuous integration
188
-----------------------------
189
190
We have a Hudson continuous-integration system that automatically runs 
191
tests across various platforms.  In the future we plan to add more 
192
combinations including testing plugins.  See 
193
<http://babune.ladeuil.net:24842/>.  (Babune = Bazaar Buildbot Network.)
194
195
5335.3.2 by Martin Pool
Note about selftest --parallel
196
Running tests in parallel
197
-------------------------
198
199
Bazaar can use subunit to spawn multiple test processes.  There is
200
slightly more chance you will hit ordering or timing-dependent bugs but
201
it's much faster::
202
203
  $ ./bzr selftest --parallel=fork
204
5335.3.4 by Martin Pool
Review tweaks to testing documentation
205
Note that you will need the Subunit library
206
<https://launchpad.net/subunit/> to use this, which is in
207
``python-subunit`` on Ubuntu.
208
5335.3.2 by Martin Pool
Note about selftest --parallel
209
5335.3.1 by Martin Pool
notes on testing on a tmpfs
210
Running tests from a ramdisk
211
----------------------------
212
213
The tests create and delete a lot of temporary files.  In some cases you
214
can make the test suite run much faster by running it on a ramdisk.  For
215
example::
216
217
  $ sudo mkdir /ram
218
  $ sudo mount -t tmpfs none /ram
219
  $ TMPDIR=/ram ./bzr selftest ...
220
221
You could also change ``/tmp`` in ``/etc/fstab`` to have type ``tmpfs``,
222
if you don't mind possibly losing other files in there when the machine
5335.3.4 by Martin Pool
Review tweaks to testing documentation
223
restarts.  Add this line (if there is none for ``/tmp`` already)::
224
225
  none           /tmp            tmpfs  defaults        0       0
5335.3.1 by Martin Pool
notes on testing on a tmpfs
226
227
With a 6-core machine and ``--parallel=fork`` using a tmpfs doubles the
228
test execution speed.
229
230
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
231
Writing Tests
232
=============
233
5004.2.5 by Martin Pool
More docs on testing
234
Normally you should add or update a test for all bug fixes or new features
235
in Bazaar.
236
237
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
238
Where should I put a new test?
239
------------------------------
240
241
Bzrlib's tests are organised by the type of test.  Most of the tests in
242
bzr's test suite belong to one of these categories:
243
244
 - Unit tests
245
 - Blackbox (UI) tests
246
 - Per-implementation tests
247
 - Doctests
248
249
A quick description of these test types and where they belong in bzrlib's
250
source follows.  Not all tests fall neatly into one of these categories;
251
in those cases use your judgement.
252
253
254
Unit tests
255
~~~~~~~~~~
256
257
Unit tests make up the bulk of our test suite.  These are tests that are
258
focused on exercising a single, specific unit of the code as directly
259
as possible.  Each unit test is generally fairly short and runs very
260
quickly.
261
262
They are found in ``bzrlib/tests/test_*.py``.  So in general tests should
263
be placed in a file named test_FOO.py where FOO is the logical thing under
264
test.
265
266
For example, tests for merge3 in bzrlib belong in bzrlib/tests/test_merge3.py.
267
See bzrlib/tests/test_sampler.py for a template test script.
268
269
270
Blackbox (UI) tests
271
~~~~~~~~~~~~~~~~~~~
272
273
Tests can be written for the UI or for individual areas of the library.
274
Choose whichever is appropriate: if adding a new command, or a new command
275
option, then you should be writing a UI test.  If you are both adding UI
276
functionality and library functionality, you will want to write tests for
277
both the UI and the core behaviours.  We call UI tests 'blackbox' tests
278
and they belong in ``bzrlib/tests/blackbox/*.py``.
279
280
When writing blackbox tests please honour the following conventions:
281
282
 1. Place the tests for the command 'name' in
283
    bzrlib/tests/blackbox/test_name.py. This makes it easy for developers
284
    to locate the test script for a faulty command.
285
286
 2. Use the 'self.run_bzr("name")' utility function to invoke the command
287
    rather than running bzr in a subprocess or invoking the
288
    cmd_object.run() method directly. This is a lot faster than
289
    subprocesses and generates the same logging output as running it in a
290
    subprocess (which invoking the method directly does not).
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
291
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
292
 3. Only test the one command in a single test script. Use the bzrlib
293
    library when setting up tests and when evaluating the side-effects of
294
    the command. We do this so that the library api has continual pressure
295
    on it to be as functional as the command line in a simple manner, and
296
    to isolate knock-on effects throughout the blackbox test suite when a
297
    command changes its name or signature. Ideally only the tests for a
298
    given command are affected when a given command is changed.
299
300
 4. If you have a test which does actually require running bzr in a
301
    subprocess you can use ``run_bzr_subprocess``. By default the spawned
302
    process will not load plugins unless ``--allow-plugins`` is supplied.
303
304
305
Per-implementation tests
306
~~~~~~~~~~~~~~~~~~~~~~~~
307
308
Per-implementation tests are tests that are defined once and then run
309
against multiple implementations of an interface.  For example,
4913.3.7 by John Arbash Meinel
Doc updates for permute_for_extension
310
``per_transport.py`` defines tests that all Transport implementations
311
(local filesystem, HTTP, and so on) must pass. They are found in
312
``bzrlib/tests/per_*/*.py``, and ``bzrlib/tests/per_*.py``.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
313
314
These are really a sub-category of unit tests, but an important one.
315
4913.3.7 by John Arbash Meinel
Doc updates for permute_for_extension
316
Along the same lines are tests for extension modules. We generally have
317
both a pure-python and a compiled implementation for each module. As such,
318
we want to run the same tests against both implementations. These can
319
generally be found in ``bzrlib/tests/*__*.py`` since extension modules are
320
usually prefixed with an underscore. Since there are only two
321
implementations, we have a helper function
322
``bzrlib.tests.permute_for_extension``, which can simplify the
323
``load_tests`` implementation.
324
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
325
326
Doctests
327
~~~~~~~~
328
329
We make selective use of doctests__.  In general they should provide
330
*examples* within the API documentation which can incidentally be tested.  We
5193.5.8 by Vincent Ladeuil
Revert previous change as I can't reproduce the related problem anymore.
331
don't try to test every important case using doctests |--| regular Python
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
332
tests are generally a better solution.  That is, we just use doctests to
333
make our documentation testable, rather than as a way to make tests.
334
335
Most of these are in ``bzrlib/doc/api``.  More additions are welcome.
336
337
  __ http://docs.python.org/lib/module-doctest.html
338
339
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
340
Shell-like tests
4917.2.1 by Martin Pool
Add better example for ScriptRunner and tweak its place in the document hierarchy
341
----------------
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
342
5455.1.2 by Vincent Ladeuil
More docs.
343
``bzrlib/tests/script.py`` allows users to write tests in a syntax very
344
close to a shell session, using a restricted and limited set of commands
345
that should be enough to mimic most of the behaviours.
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
346
347
A script is a set of commands, each command is composed of:
348
349
 * one mandatory command line,
350
 * one optional set of input lines to feed the command,
351
 * one optional set of output expected lines,
352
 * one optional set of error expected lines.
353
354
Input, output and error lines can be specified in any order.
355
356
Except for the expected output, all lines start with a special
357
string (based on their origin when used under a Unix shell):
358
359
 * '$ ' for the command,
360
 * '<' for input,
361
 * nothing for output,
362
 * '2>' for errors,
363
364
Comments can be added anywhere, they start with '#' and end with
365
the line.
366
367
The execution stops as soon as an expected output or an expected error is not
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
368
matched.
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
369
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
370
If output occurs and no output is expected, the execution stops and the
371
test fails.  If unexpected output occurs on the standard error, then
5509.1.3 by Neil Martinsen-Burrell
change option name and mention the effect on standard error
372
execution stops and the test fails.
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
373
374
If an error occurs and no expected error is specified, the execution stops.
375
376
An error is defined by a returned status different from zero, not by the
377
presence of text on the error stream.
378
379
The matching is done on a full string comparison basis unless '...' is used, in
380
which case expected output/errors can be less precise.
381
382
Examples:
383
384
The following will succeeds only if 'bzr add' outputs 'adding file'::
385
386
  $ bzr add file
387
  >adding file
388
389
If you want the command to succeed for any output, just use::
390
391
  $ bzr add file
5422.3.3 by Martin Pool
Update ScriptRunner docs: blank won't match output; suggest -q
392
  ...
393
  2>...
394
395
or use the ``--quiet`` option::
396
397
  $ bzr add -q file
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
398
399
The following will stop with an error::
400
401
  $ bzr not-a-command
402
403
If you want it to succeed, use::
404
405
  $ bzr not-a-command
406
  2> bzr: ERROR: unknown command "not-a-command"
407
408
You can use ellipsis (...) to replace any piece of text you don't want to be
409
matched exactly::
410
411
  $ bzr branch not-a-branch
412
  2>bzr: ERROR: Not a branch...not-a-branch/".
413
414
This can be used to ignore entire lines too::
415
416
  $ cat
417
  <first line
418
  <second line
419
  <third line
420
  # And here we explain that surprising fourth line
421
  <fourth line
422
  <last line
423
  >first line
424
  >...
425
  >last line
426
427
You can check the content of a file with cat::
428
429
  $ cat <file
430
  >expected content
431
432
You can also check the existence of a file with cat, the following will fail if
433
the file doesn't exist::
434
435
  $ cat file
436
5455.1.2 by Vincent Ladeuil
More docs.
437
You can run files containing shell-like scripts with::
438
439
  $ bzr test-script <script>
440
441
where ``<script>`` is the path to the file containing the shell-like script.
442
4917.2.1 by Martin Pool
Add better example for ScriptRunner and tweak its place in the document hierarchy
443
The actual use of ScriptRunner within a TestCase looks something like
444
this::
445
5283.1.1 by Martin Pool
Add helper function script.run_script and suggest using it
446
    from bzrlib.tests import script
447
448
    def test_unshelve_keep(self):
449
        # some setup here
450
        script.run_script(self, '''
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
451
            $ bzr add -q file
452
            $ bzr shelve -q --all -m Foo
5283.1.1 by Martin Pool
Add helper function script.run_script and suggest using it
453
            $ bzr shelve --list
454
            1: Foo
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
455
            $ bzr unshelve -q --keep
5283.1.1 by Martin Pool
Add helper function script.run_script and suggest using it
456
            $ bzr shelve --list
457
            1: Foo
458
            $ cat file
459
            contents of file
460
            ''')
4917.2.1 by Martin Pool
Add better example for ScriptRunner and tweak its place in the document hierarchy
461
5417.1.1 by Martin Pool
ScriptRunner can now cope with commands that prompt for input.
462
You can also test commands that read user interaction::
463
464
    def test_confirm_action(self):
465
        """You can write tests that demonstrate user confirmation"""
466
        commands.builtin_command_registry.register(cmd_test_confirm)
467
        self.addCleanup(commands.builtin_command_registry.remove, 'test-confirm')
468
        self.run_script("""
469
            $ bzr test-confirm
470
            2>Really do it? [y/n]: 
471
            <yes
472
            yes
473
            """)
4665.5.20 by Vincent Ladeuil
Fixed as per Martin's review.
474
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
475
To avoid having to specify "-q" for all commands whose output is
476
irrelevant, the run_script() method may be passed the keyword argument
5531.1.2 by Vincent Ladeuil
s/blank_output/null_output/
477
``null_output_matches_anything=True``.  For example::
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
478
5531.1.2 by Vincent Ladeuil
s/blank_output/null_output/
479
    def test_ignoring_null_output(self):
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
480
        self.run_script("""
481
            $ bzr init
482
            $ bzr ci -m 'first revision' --unchanged
483
            $ bzr log --line
484
            1: ...
5531.1.2 by Vincent Ladeuil
s/blank_output/null_output/
485
            """, null_output_matches_anything=True)
5509.1.1 by Neil Martinsen-Burrell
add ignore_blanks to run_script to recover old behavior
486
           
487
5017.2.2 by Martin Pool
Add import tariff tests
488
Import tariff tests
489
-------------------
490
491
`bzrlib.tests.test_import_tariff` has some tests that measure how many
492
Python modules are loaded to run some representative commands.
493
494
We want to avoid loading code unnecessarily, for reasons including:
495
496
* Python modules are interpreted when they're loaded, either to define
497
  classes or modules or perhaps to initialize some structures.
498
499
* With a cold cache we may incur blocking real disk IO for each module.
500
501
* Some modules depend on many others.
502
503
* Some optional modules such as `testtools` are meant to be soft
504
  dependencies and only needed for particular cases.  If they're loaded in
505
  other cases then bzr may break for people who don't have those modules.
506
  
5279.1.1 by Andrew Bennetts
lazy_import most things in merge.py; add a few representative modules to the import tariff tests; tweak a couple of other modules so that patiencediff is not necessarily imported; remove a bunch of unused imports from test_knit.py.
507
`test_import_tariff` allows us to check that removal of imports doesn't
5017.2.2 by Martin Pool
Add import tariff tests
508
regress.
509
510
This is done by running the command in a subprocess with
511
``--profile-imports``.  Starting a whole Python interpreter is pretty
512
slow, so we don't want exhaustive testing here, but just enough to guard
513
against distinct fixed problems.
514
515
Assertions about precisely what is loaded tend to be brittle so we instead
516
make assertions that particular things aren't loaded.
517
518
Unless selftest is run with ``--no-plugins``, modules will be loaded in
519
the usual way and checks made on what they cause to be loaded.  This is
520
probably worth checking into, because many bzr users have at least some
521
plugins installed (and they're included in binary installers).
522
523
In theory, plugins might have a good reason to load almost anything:
524
someone might write a plugin that opens a network connection or pops up a
525
gui window every time you run 'bzr status'.  However, it's more likely
526
that the code to do these things is just being loaded accidentally.  We
527
might eventually need to have a way to make exceptions for particular
528
plugins.
529
530
Some things to check:
531
532
* non-GUI commands shouldn't load GUI libraries
533
534
* operations on bzr native formats sholudn't load foreign branch libraries
535
536
* network code shouldn't be loaded for purely local operations
537
538
* particularly expensive Python built-in modules shouldn't be loaded
539
  unless there is a good reason
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
540
541
4634.146.7 by Danny van Heumen
Updated documentation on how to approach testing locking behaviour.
542
Testing locking behaviour
543
-------------------------
544
545
In order to test the locking behaviour of commands, it is possible to install
546
a hook that is called when a write lock is: acquired, released or broken.
547
(Read locks also exist, they cannot be discovered in this way.)
548
549
A hook can be installed by calling bzrlib.lock.Lock.hooks.install_named_hook.
550
The three valid hooks are: `lock_acquired`, `lock_released` and `lock_broken`.
551
552
Example::
553
554
    locks_acquired = []
555
    locks_released = []
556
557
    lock.Lock.hooks.install_named_hook('lock_acquired',
558
        locks_acquired.append, None)
559
    lock.Lock.hooks.install_named_hook('lock_released',
560
        locks_released.append, None)
561
562
`locks_acquired` will now receive a LockResult instance for all locks acquired
563
since the time the hook is installed.
564
4634.146.10 by Danny van Heumen
Updated documentation: added case for BzrDir (removed "special case" remark) and removed explanation for LockResult representation.
565
The last part of the `lock_url` allows you to identify the type of object that is locked.
566
567
- BzrDir: `/branch-lock`
568
- Working tree: `/checkout/lock`
569
- Branch: `/branch/lock`
570
- Repository: `/repository/lock`
4634.146.7 by Danny van Heumen
Updated documentation on how to approach testing locking behaviour.
571
572
To test if a lock is a write lock on a working tree, one can do the following::
573
574
    self.assertEndsWith(locks_acquired[0].lock_url, "/checkout/lock")
575
576
See bzrlib/tests/commands/test_revert.py for an example of how to use this for
577
testing locks.
578
5077.3.1 by Martin Pool
Tip on testing locking behaviour
579
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
580
Skipping tests
581
--------------
582
583
In our enhancements to unittest we allow for some addition results beyond
584
just success or failure.
585
586
If a test can't be run, it can say that it's skipped by raising a special
5193.5.8 by Vincent Ladeuil
Revert previous change as I can't reproduce the related problem anymore.
587
exception.  This is typically used in parameterized tests |--| for example
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
588
if a transport doesn't support setting permissions, we'll skip the tests
589
that relating to that.  ::
590
591
    try:
592
        return self.branch_format.initialize(repo.bzrdir)
593
    except errors.UninitializableFormat:
594
        raise tests.TestSkipped('Uninitializable branch format')
595
596
Raising TestSkipped is a good idea when you want to make it clear that the
597
test was not run, rather than just returning which makes it look as if it
598
was run and passed.
599
600
Several different cases are distinguished:
601
602
TestSkipped
603
        Generic skip; the only type that was present up to bzr 0.18.
604
605
TestNotApplicable
606
        The test doesn't apply to the parameters with which it was run.
607
        This is typically used when the test is being applied to all
608
        implementations of an interface, but some aspects of the interface
609
        are optional and not present in particular concrete
610
        implementations.  (Some tests that should raise this currently
611
        either silently return or raise TestSkipped.)  Another option is
612
        to use more precise parameterization to avoid generating the test
613
        at all.
614
615
UnavailableFeature
616
        The test can't be run because a dependency (typically a Python
617
        library) is not available in the test environment.  These
618
        are in general things that the person running the test could fix
619
        by installing the library.  It's OK if some of these occur when
620
        an end user runs the tests or if we're specifically testing in a
621
        limited environment, but a full test should never see them.
622
623
        See `Test feature dependencies`_ below.
624
625
KnownFailure
626
        The test exists but is known to fail, for example this might be
627
        appropriate to raise if you've committed a test for a bug but not
628
        the fix for it, or if something works on Unix but not on Windows.
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
629
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
630
        Raising this allows you to distinguish these failures from the
631
        ones that are not expected to fail.  If the test would fail
632
        because of something we don't expect or intend to fix,
633
        KnownFailure is not appropriate, and TestNotApplicable might be
634
        better.
635
636
        KnownFailure should be used with care as we don't want a
637
        proliferation of quietly broken tests.
638
4873.2.4 by John Arbash Meinel
Add a NEWS entry and an entry in the testing docs about ModuleAvailableFeature
639
640
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
641
We plan to support three modes for running the test suite to control the
642
interpretation of these results.  Strict mode is for use in situations
643
like merges to the mainline and releases where we want to make sure that
644
everything that can be tested has been tested.  Lax mode is for use by
645
developers who want to temporarily tolerate some known failures.  The
646
default behaviour is obtained by ``bzr selftest`` with no options, and
647
also (if possible) by running under another unittest harness.
648
649
======================= ======= ======= ========
650
result                  strict  default lax
651
======================= ======= ======= ========
652
TestSkipped             pass    pass    pass
653
TestNotApplicable       pass    pass    pass
3619.3.2 by Andrew Bennetts
Remove references to unimplemented TestPlatformLimit, remove some redundant (and misplaced) text from 'Test feature dependencies'.
654
UnavailableFeature      fail    pass    pass
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
655
KnownFailure            fail    pass    pass
656
======================= ======= ======= ========
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
657
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
658
659
Test feature dependencies
660
-------------------------
661
662
Writing tests that require a feature
663
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
664
665
Rather than manually checking the environment in each test, a test class
666
can declare its dependence on some test features.  The feature objects are
667
checked only once for each run of the whole test suite.
668
669
(For historical reasons, as of May 2007 many cases that should depend on
670
features currently raise TestSkipped.)
671
672
For example::
673
674
    class TestStrace(TestCaseWithTransport):
675
676
        _test_needs_features = [StraceFeature]
677
3619.3.2 by Andrew Bennetts
Remove references to unimplemented TestPlatformLimit, remove some redundant (and misplaced) text from 'Test feature dependencies'.
678
This means all tests in this class need the feature.  If the feature is
679
not available the test will be skipped using UnavailableFeature.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
680
681
Individual tests can also require a feature using the ``requireFeature``
682
method::
683
684
    self.requireFeature(StraceFeature)
685
5004.2.1 by Martin Pool
Better documentation of ModuleAvailableFeature
686
The old naming style for features is CamelCase, but because they're
687
actually instances not classses they're now given instance-style names
688
like ``apport``.
689
690
Features already defined in ``bzrlib.tests`` and ``bzrlib.tests.features``
691
include:
692
693
 - apport
694
 - paramiko
695
 - SymlinkFeature
696
 - HardlinkFeature
697
 - OsFifoFeature
698
 - UnicodeFilenameFeature
699
 - FTPServerFeature
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
700
 - CaseInsensitiveFilesystemFeature.
5094.3.1 by Martin Pool
``.bazaar``, ``.bazaar/bazaar.conf`` and ``.bzr.log`` inherit user and group ownership from the containing directory. This allow bzr to work better with sudo.
701
 - chown_feature: The test can rely on OS being POSIX and python
5051.4.6 by Parth Malwankar
documented ChownFeature in testing.txt
702
   supporting os.chown.
5094.3.1 by Martin Pool
``.bazaar``, ``.bazaar/bazaar.conf`` and ``.bzr.log`` inherit user and group ownership from the containing directory. This allow bzr to work better with sudo.
703
 - posix_permissions_feature: The test can use POSIX-style
704
   user/group/other permission bits.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
705
706
707
Defining a new feature that tests can require
708
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
709
710
New features for use with ``_test_needs_features`` or ``requireFeature``
711
are defined by subclassing ``bzrlib.tests.Feature`` and overriding the
712
``_probe`` and ``feature_name`` methods.  For example::
713
714
    class _SymlinkFeature(Feature):
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
715
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
716
        def _probe(self):
717
            return osutils.has_symlinks()
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
718
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
719
        def feature_name(self):
720
            return 'symlinks'
4853.1.1 by Patrick Regan
Removed trailing whitespace from files in doc directory
721
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
722
    SymlinkFeature = _SymlinkFeature()
723
5004.2.1 by Martin Pool
Better documentation of ModuleAvailableFeature
724
A helper for handling running tests based on whether a python
725
module is available. This can handle 3rd-party dependencies (is
726
``paramiko`` available?) as well as stdlib (``termios``) or
727
extension modules (``bzrlib._groupcompress_pyx``). You create a
728
new feature instance with::
729
730
    # in bzrlib/tests/features.py
731
    apport = tests.ModuleAvailableFeature('apport')
732
733
734
    # then in bzrlib/tests/test_apport.py
735
    class TestApportReporting(TestCaseInTempDir):
736
737
        _test_needs_features = [features.apport]
738
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
739
5432.6.1 by John C Barstow
Mention applyDeprecated in doc/developers/testing.txt
740
Testing deprecated code
741
-----------------------
742
743
When code is deprecated, it is still supported for some length of time,
744
usually until the next major version. The ``applyDeprecated`` helper
745
wraps calls to deprecated code to verify that it is correctly issuing the
746
deprecation warning, and also prevents the warnings from being printed
747
during test runs.
748
749
Typically patches that apply the ``@deprecated_function`` decorator should
750
update the accompanying tests to use the ``applyDeprecated`` wrapper.
751
752
``applyDeprecated`` is defined in ``bzrlib.tests.TestCase``. See the API
753
docs for more details.
754
755
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
756
Testing exceptions and errors
757
-----------------------------
758
759
It's important to test handling of errors and exceptions.  Because this
760
code is often not hit in ad-hoc testing it can often have hidden bugs --
761
it's particularly common to get NameError because the exception code
762
references a variable that has since been renamed.
763
764
.. TODO: Something about how to provoke errors in the right way?
765
766
In general we want to test errors at two levels:
767
768
1. A test in ``test_errors.py`` checking that when the exception object is
769
   constructed with known parameters it produces an expected string form.
770
   This guards against mistakes in writing the format string, or in the
771
   ``str`` representations of its parameters.  There should be one for
772
   each exception class.
773
774
2. Tests that when an api is called in a particular situation, it raises
775
   an error of the expected class.  You should typically use
776
   ``assertRaises``, which in the Bazaar test suite returns the exception
777
   object to allow you to examine its parameters.
778
779
In some cases blackbox tests will also want to check error reporting.  But
780
it can be difficult to provoke every error through the commandline
5193.5.8 by Vincent Ladeuil
Revert previous change as I can't reproduce the related problem anymore.
781
interface, so those tests are only done as needed |--| eg in response to a
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
782
particular bug or if the error is reported in an unusual way(?)  Blackbox
783
tests should mostly be testing how the command-line interface works, so
784
should only test errors if there is something particular to the cli in how
785
they're displayed or handled.
786
787
788
Testing warnings
789
----------------
790
791
The Python ``warnings`` module is used to indicate a non-fatal code
792
problem.  Code that's expected to raise a warning can be tested through
793
callCatchWarnings.
794
795
The test suite can be run with ``-Werror`` to check no unexpected errors
796
occur.
797
798
However, warnings should be used with discretion.  It's not an appropriate
799
way to give messages to the user, because the warning is normally shown
800
only once per source line that causes the problem.  You should also think
801
about whether the warning is serious enought that it should be visible to
802
users who may not be able to fix it.
803
804
805
Interface implementation testing and test scenarios
806
---------------------------------------------------
807
808
There are several cases in Bazaar of multiple implementations of a common
809
conceptual interface.  ("Conceptual" because it's not necessary for all
810
the implementations to share a base class, though they often do.)
811
Examples include transports and the working tree, branch and repository
812
classes.
813
814
In these cases we want to make sure that every implementation correctly
815
fulfils the interface requirements.  For example, every Transport should
816
support the ``has()`` and ``get()`` and ``clone()`` methods.  We have a
817
sub-suite of tests in ``test_transport_implementations``.  (Most
818
per-implementation tests are in submodules of ``bzrlib.tests``, but not
819
the transport tests at the moment.)
820
821
These tests are repeated for each registered Transport, by generating a
822
new TestCase instance for the cross product of test methods and transport
823
implementations.  As each test runs, it has ``transport_class`` and
824
``transport_server`` set to the class it should test.  Most tests don't
825
access these directly, but rather use ``self.get_transport`` which returns
826
a transport of the appropriate type.
827
828
The goal is to run per-implementation only the tests that relate to that
829
particular interface.  Sometimes we discover a bug elsewhere that happens
830
with only one particular transport.  Once it's isolated, we can consider
831
whether a test should be added for that particular implementation,
832
or for all implementations of the interface.
833
834
See also `Per-implementation tests`_ (above).
835
836
5462.3.12 by Martin Pool
Doc for variations
837
Test scenarios and variations
838
-----------------------------
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
839
840
Some utilities are provided for generating variations of tests.  This can
841
be used for per-implementation tests, or other cases where the same test
842
code needs to run several times on different scenarios.
843
844
The general approach is to define a class that provides test methods,
845
which depend on attributes of the test object being pre-set with the
846
values to which the test should be applied.  The test suite should then
847
also provide a list of scenarios in which to run the tests.
848
5462.3.14 by Martin Pool
Unify varations with scenario protocol
849
A single *scenario* is defined by a `(name, parameter_dict)` tuple.  The
850
short string name is combined with the name of the test method to form the
851
test instance name.  The parameter dict is merged into the instance's
852
attributes.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
853
5462.3.17 by Martin Pool
Updated test scenario docs
854
For example::
855
5462.3.21 by Martin Pool
Rename to load_tests_apply_scenarios
856
    load_tests = load_tests_apply_scenarios
5462.3.17 by Martin Pool
Updated test scenario docs
857
858
    class TestCheckout(TestCase):
859
5559.2.1 by Martin Pool
Format and name correction for test scenario docs
860
        scenarios = multiply_scenarios(
861
            VaryByRepositoryFormat(), 
862
            VaryByTreeFormat(),
863
            )
5462.3.14 by Martin Pool
Unify varations with scenario protocol
864
865
The `load_tests` declaration or definition should be near the top of the
866
file so its effect can be seen.
867
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
868
869
Test support
870
------------
871
872
We have a rich collection of tools to support writing tests. Please use
873
them in preference to ad-hoc solutions as they provide portability and
874
performance benefits.
875
876
877
TestCase and its subclasses
878
~~~~~~~~~~~~~~~~~~~~~~~~~~~
879
880
The ``bzrlib.tests`` module defines many TestCase classes to help you
881
write your tests.
882
883
TestCase
884
    A base TestCase that extends the Python standard library's
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
885
    TestCase in several ways.  TestCase is build on
886
    ``testtools.TestCase``, which gives it support for more assertion
887
    methods (e.g.  ``assertContainsRe``), ``addCleanup``, and other
888
    features (see its API docs for details).  It also has a ``setUp`` that
889
    makes sure that global state like registered hooks and loggers won't
890
    interfere with your test.  All tests should use this base class
891
    (whether directly or via a subclass).  Note that we are trying not to
892
    add more assertions at this point, and instead to build up a library
893
    of ``bzrlib.tests.matchers``.
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
894
895
TestCaseWithMemoryTransport
896
    Extends TestCase and adds methods like ``get_transport``,
897
    ``make_branch`` and ``make_branch_builder``.  The files created are
898
    stored in a MemoryTransport that is discarded at the end of the test.
899
    This class is good for tests that need to make branches or use
900
    transports, but that don't require storing things on disk.  All tests
901
    that create bzrdirs should use this base class (either directly or via
902
    a subclass) as it ensures that the test won't accidentally operate on
903
    real branches in your filesystem.
904
905
TestCaseInTempDir
906
    Extends TestCaseWithMemoryTransport.  For tests that really do need
907
    files to be stored on disk, e.g. because a subprocess uses a file, or
908
    for testing functionality that accesses the filesystem directly rather
909
    than via the Transport layer (such as dirstate).
910
911
TestCaseWithTransport
912
    Extends TestCaseInTempDir.  Provides ``get_url`` and
913
    ``get_readonly_url`` facilities.  Subclasses can control the
914
    transports used by setting ``vfs_transport_factory``,
915
    ``transport_server`` and/or ``transport_readonly_server``.
916
917
918
See the API docs for more details.
919
920
921
BranchBuilder
922
~~~~~~~~~~~~~
923
924
When writing a test for a feature, it is often necessary to set up a
925
branch with a certain history.  The ``BranchBuilder`` interface allows the
926
creation of test branches in a quick and easy manner.  Here's a sample
927
session::
928
929
  builder = self.make_branch_builder('relpath')
930
  builder.build_commit()
931
  builder.build_commit()
932
  builder.build_commit()
933
  branch = builder.get_branch()
934
935
``make_branch_builder`` is a method of ``TestCaseWithMemoryTransport``.
936
937
Note that many current tests create test branches by inheriting from
938
``TestCaseWithTransport`` and using the ``make_branch_and_tree`` helper to
939
give them a ``WorkingTree`` that they can commit to. However, using the
940
newer ``make_branch_builder`` helper is preferred, because it can build
941
the changes in memory, rather than on disk. Tests that are explictly
942
testing how we work with disk objects should, of course, use a real
943
``WorkingTree``.
944
945
Please see bzrlib.branchbuilder for more details.
946
4070.5.2 by Martin Pool
Recommend setting timestamp in BranchBuilder
947
If you're going to examine the commit timestamps e.g. in a test for log
948
output, you should set the timestamp on the tree, rather than using fuzzy
949
matches in the test.
950
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
951
952
TreeBuilder
953
~~~~~~~~~~~
954
955
The ``TreeBuilder`` interface allows the construction of arbitrary trees
956
with a declarative interface. A sample session might look like::
957
958
  tree = self.make_branch_and_tree('path')
959
  builder = TreeBuilder()
960
  builder.start_tree(tree)
961
  builder.build(['foo', "bar/", "bar/file"])
962
  tree.commit('commit the tree')
963
  builder.finish_tree()
964
965
Usually a test will create a tree using ``make_branch_and_memory_tree`` (a
966
method of ``TestCaseWithMemoryTransport``) or ``make_branch_and_tree`` (a
967
method of ``TestCaseWithTransport``).
968
969
Please see bzrlib.treebuilder for more details.
970
5193.5.8 by Vincent Ladeuil
Revert previous change as I can't reproduce the related problem anymore.
971
4986.2.7 by Martin Pool
Recommend overrideAttr in the test writing guide
972
Temporarily changing state
973
~~~~~~~~~~~~~~~~~~~~~~~~~~
974
975
If your test needs to temporarily mutate some global state, and you need
976
it restored at the end, you can say for example::
977
978
    self.overrideAttr(osutils, '_cached_user_encoding', 'latin-1')
979
5570.3.17 by Vincent Ladeuil
Final tweaks and doc.
980
Temporarily changing environment variables
981
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
982
983
If yout test needs to temporarily change some environment variable value
984
(which generally means you want it restored at the end), you can use::
985
986
    self.overrideEnv('BZR_ENV_VAR', 'new_value')
987
988
If you want to remove a variable from the environment, you should use the
989
special ``None`` value::
990
991
    self.overrideEnv('PATH', None)
992
993
If you add a new feature which depends on a new environment variable, make
994
sure it behaves properly when this variable is not defined (if applicable) and
995
if you need to enforce a specific default value, check the
996
``TestCase._cleanEnvironment`` in ``bzrlib.tests.__init__.py`` which defines a
997
proper set of values for all tests.
998
4986.2.7 by Martin Pool
Recommend overrideAttr in the test writing guide
999
Cleaning up
4986.2.2 by Martin Pool
Doc about using addCleanup not tearDown
1000
~~~~~~~~~~~
1001
1002
Our base ``TestCase`` class provides an ``addCleanup`` method, which
1003
should be used instead of ``tearDown``.  All the cleanups are run when the
1004
test finishes, regardless of whether it passes or fails.  If one cleanup
1005
fails, later cleanups are still run.
1006
1007
(The same facility is available outside of tests through
1008
``bzrlib.cleanup``.)
1009
5335.3.5 by Martin Pool
merge trunk
1010
5335.3.3 by Martin Pool
Developer documentation about tc qdisc
1011
Manual testing
1012
==============
1013
1014
Generally we prefer automated testing but sometimes a manual test is the
1015
right thing, especially for performance tests that want to measure elapsed
1016
time rather than effort.
1017
1018
Simulating slow networks
1019
------------------------
1020
1021
To get realistically slow network performance for manually measuring
1022
performance, we can simulate 500ms latency (thus 1000ms round trips)::
1023
1024
  $ sudo tc qdisc add dev lo root netem delay 500ms
1025
1026
Normal system behaviour is restored with ::
1027
1028
  $ sudo tc qdisc del dev lo root
1029
1030
A more precise version that only filters traffic to port 4155 is::
1031
1032
    tc qdisc add dev lo root handle 1: prio
1033
    tc qdisc add dev lo parent 1:3 handle 30: netem delay 500ms 
1034
    tc qdisc add dev lo parent 30:1 handle 40: prio
1035
    tc filter add dev lo protocol ip parent 1:0 prio 3 u32 match ip dport 4155 0xffff flowid 1:3 handle 800::800
1036
    tc filter add dev lo protocol ip parent 1:0 prio 3 u32 match ip sport 4155 0xffff flowid 1:3 handle 800::801
1037
1038
and to remove this::
1039
1040
    tc filter del dev lo protocol ip parent 1: pref 3 u32
1041
    tc qdisc del dev lo root handle 1:
1042
5335.3.4 by Martin Pool
Review tweaks to testing documentation
1043
You can use similar code to add additional delay to a real network
1044
interface, perhaps only when talking to a particular server or pointing at
1045
a VM.  For more information see <http://lartc.org/>.
1046
5335.3.3 by Martin Pool
Developer documentation about tc qdisc
1047
5193.5.8 by Vincent Ladeuil
Revert previous change as I can't reproduce the related problem anymore.
1048
.. |--| unicode:: U+2014
1049
3619.3.1 by Andrew Bennetts
Move the notes on writing tests out of HACKING into a new file, and improve
1050
..
5283.1.1 by Martin Pool
Add helper function script.run_script and suggest using it
1051
   vim: ft=rst tw=74 ai et sw=4