/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.15 by John Arbash Meinel
Merge bzr.dev 5597 to resolve NEWS, aka bzr-2.3.txt
1
# Copyright (C) 2006-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
1553.5.12 by Martin Pool
New LockDir locking mechanism
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1553.5.12 by Martin Pool
New LockDir locking mechanism
16
17
"""Tests for LockDir"""
18
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
19
import os
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
20
from threading import Thread, Lock
1553.5.12 by Martin Pool
New LockDir locking mechanism
21
import time
22
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
23
import bzrlib
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
24
from bzrlib import (
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
25
    config,
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
26
    errors,
3331.3.13 by Martin Pool
Fix up imports
27
    lock,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
28
    osutils,
1551.10.4 by Aaron Bentley
Update to skip on win32
29
    tests,
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
30
    transport,
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
31
    )
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
32
from bzrlib.errors import (
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
33
    LockBreakMismatch,
34
    LockBroken,
35
    LockContention,
36
    LockFailed,
37
    LockNotHeld,
38
    )
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
39
from bzrlib.lockdir import LockDir
5579.3.1 by Jelmer Vernooij
Remove unused imports.
40
from bzrlib.tests import (
41
    features,
42
    TestCaseWithTransport,
43
    )
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
44
from bzrlib.trace import note
1553.5.12 by Martin Pool
New LockDir locking mechanism
45
46
# These tests sometimes use threads to test the behaviour of lock files with
47
# concurrent actors.  This is not a typical (or necessarily supported) use;
48
# they're really meant for guarding between processes.
49
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
50
# These tests are run on the default transport provided by the test framework
51
# (typically a local disk transport).  That can be changed by the --transport
52
# option to bzr selftest.  The required properties of the transport
53
# implementation are tested separately.  (The main requirement is just that
54
# they don't allow overwriting nonempty directories.)
55
1553.5.12 by Martin Pool
New LockDir locking mechanism
56
class TestLockDir(TestCaseWithTransport):
57
    """Test LockDir operations"""
58
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
59
    def logging_report_function(self, fmt, *args):
60
        self._logged_reports.append((fmt, args))
61
62
    def setup_log_reporter(self, lock_dir):
63
        self._logged_reports = []
64
        lock_dir._report_function = self.logging_report_function
65
1553.5.12 by Martin Pool
New LockDir locking mechanism
66
    def test_00_lock_creation(self):
67
        """Creation of lock file on a transport"""
68
        t = self.get_transport()
69
        lf = LockDir(t, 'test_lock')
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
70
        self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
71
72
    def test_01_lock_repr(self):
73
        """Lock string representation"""
74
        lf = LockDir(self.get_transport(), 'test_lock')
75
        r = repr(lf)
76
        self.assertContainsRe(r, r'^LockDir\(.*/test_lock\)$')
77
78
    def test_02_unlocked_peek(self):
79
        lf = LockDir(self.get_transport(), 'test_lock')
80
        self.assertEqual(lf.peek(), None)
81
1687.1.3 by Robert Collins
Make LockDir.unlock check the lock is still intact.
82
    def get_lock(self):
83
        return LockDir(self.get_transport(), 'test_lock')
84
85
    def test_unlock_after_break_raises(self):
86
        ld = self.get_lock()
87
        ld2 = self.get_lock()
88
        ld.create()
89
        ld.attempt_lock()
90
        ld2.force_break(ld2.peek())
91
        self.assertRaises(LockBroken, ld.unlock)
92
1553.5.12 by Martin Pool
New LockDir locking mechanism
93
    def test_03_readonly_peek(self):
94
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
95
        self.assertEqual(lf.peek(), None)
96
97
    def test_10_lock_uncontested(self):
98
        """Acquire and release a lock"""
99
        t = self.get_transport()
100
        lf = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
101
        lf.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
102
        lf.attempt_lock()
103
        try:
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
104
            self.assertTrue(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
105
        finally:
106
            lf.unlock()
1553.5.13 by Martin Pool
New Transport.rename that mustn't overwrite
107
            self.assertFalse(lf.is_held)
1553.5.12 by Martin Pool
New LockDir locking mechanism
108
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
109
    def test_11_create_readonly_transport(self):
110
        """Fail to create lock on readonly transport"""
111
        t = self.get_readonly_transport()
112
        lf = LockDir(t, 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
113
        self.assertRaises(LockFailed, lf.create)
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
114
115
    def test_12_lock_readonly_transport(self):
1553.5.12 by Martin Pool
New LockDir locking mechanism
116
        """Fail to lock on readonly transport"""
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
117
        lf = LockDir(self.get_transport(), 'test_lock')
118
        lf.create()
119
        lf = LockDir(self.get_readonly_transport(), 'test_lock')
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
120
        self.assertRaises(LockFailed, lf.attempt_lock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
121
122
    def test_20_lock_contested(self):
123
        """Contention to get a lock"""
124
        t = self.get_transport()
125
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
126
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
127
        lf1.attempt_lock()
128
        lf2 = LockDir(t, 'test_lock')
129
        try:
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
130
            # locking is between LockDir instances; aliases within
1553.5.12 by Martin Pool
New LockDir locking mechanism
131
            # a single process are not detected
132
            lf2.attempt_lock()
133
            self.fail('Failed to detect lock collision')
134
        except LockContention, e:
135
            self.assertEqual(e.lock, lf2)
136
            self.assertContainsRe(str(e),
137
                    r'^Could not acquire.*test_lock.*$')
138
        lf1.unlock()
139
140
    def test_20_lock_peek(self):
141
        """Peek at the state of a lock"""
142
        t = self.get_transport()
143
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
144
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
145
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
146
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
147
        # lock is held, should get some info on it
148
        info1 = lf1.peek()
149
        self.assertEqual(set(info1.keys()),
150
                         set(['user', 'nonce', 'hostname', 'pid', 'start_time']))
151
        # should get the same info if we look at it through a different
152
        # instance
153
        info2 = LockDir(t, 'test_lock').peek()
154
        self.assertEqual(info1, info2)
155
        # locks which are never used should be not-held
156
        self.assertEqual(LockDir(t, 'other_lock').peek(), None)
157
158
    def test_21_peek_readonly(self):
159
        """Peek over a readonly transport"""
160
        t = self.get_transport()
161
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
162
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
163
        lf2 = LockDir(self.get_readonly_transport(), 'test_lock')
164
        self.assertEqual(lf2.peek(), None)
165
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
166
        self.addCleanup(lf1.unlock)
1553.5.12 by Martin Pool
New LockDir locking mechanism
167
        info2 = lf2.peek()
168
        self.assertTrue(info2)
169
        self.assertEqual(info2['nonce'], lf1.nonce)
170
171
    def test_30_lock_wait_fail(self):
172
        """Wait on a lock, then fail
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
173
1553.5.12 by Martin Pool
New LockDir locking mechanism
174
        We ask to wait up to 400ms; this should fail within at most one
175
        second.  (Longer times are more realistic but we don't want the test
176
        suite to take too long, and this should do for now.)
177
        """
178
        t = self.get_transport()
179
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
180
        lf1.create()
1553.5.12 by Martin Pool
New LockDir locking mechanism
181
        lf2 = LockDir(t, 'test_lock')
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
182
        self.setup_log_reporter(lf2)
1553.5.12 by Martin Pool
New LockDir locking mechanism
183
        lf1.attempt_lock()
184
        try:
185
            before = time.time()
186
            self.assertRaises(LockContention, lf2.wait_lock,
187
                              timeout=0.4, poll=0.1)
188
            after = time.time()
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
189
            # it should only take about 0.4 seconds, but we allow more time in
190
            # case the machine is heavily loaded
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
191
            self.assertTrue(after - before <= 8.0,
1704.2.1 by Martin Pool
Fix time-dependency in LockDir tests -- allow more margin for error in time to detect lock contention
192
                    "took %f seconds to detect lock contention" % (after - before))
1553.5.12 by Martin Pool
New LockDir locking mechanism
193
        finally:
194
            lf1.unlock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
195
        self.assertEqual(1, len(self._logged_reports))
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
196
        self.assertEqual(self._logged_reports[0][0],
5284.6.9 by Parth Malwankar
cleaner handling of lock_url display.
197
            '%s lock %s held by %s\n'
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
198
            'at %s [process #%s], acquired %s.\n'
199
            'Will continue to try until %s, unless '
200
            'you press Ctrl-C.\n'
201
            'See "bzr help break-lock" for more.')
5284.6.4 by Parth Malwankar
local urls are now shows as they are valid.
202
        start, lock_url, user, hostname, pid, time_ago, deadline_str = \
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
203
            self._logged_reports[0][1]
204
        self.assertEqual(start, u'Unable to obtain')
205
        self.assertEqual(user, u'jrandom@example.com')
206
        # skip hostname
207
        self.assertContainsRe(pid, r'\d+')
208
        self.assertContainsRe(time_ago, r'.* ago')
209
        self.assertContainsRe(deadline_str, r'\d{2}:\d{2}:\d{2}')
1553.5.12 by Martin Pool
New LockDir locking mechanism
210
211
    def test_31_lock_wait_easy(self):
212
        """Succeed when waiting on a lock with no contention.
213
        """
214
        t = self.get_transport()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
215
        lf1 = LockDir(t, 'test_lock')
216
        lf1.create()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
217
        self.setup_log_reporter(lf1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
218
        try:
219
            before = time.time()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
220
            lf1.wait_lock(timeout=0.4, poll=0.1)
1553.5.12 by Martin Pool
New LockDir locking mechanism
221
            after = time.time()
222
            self.assertTrue(after - before <= 1.0)
223
        finally:
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
224
            lf1.unlock()
1957.1.1 by John Arbash Meinel
Report to the user when we are spinning on a lock
225
        self.assertEqual([], self._logged_reports)
1553.5.12 by Martin Pool
New LockDir locking mechanism
226
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
227
    def test_32_lock_wait_succeed(self):
228
        """Succeed when trying to acquire a lock that gets released
229
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
230
        One thread holds on a lock and then releases it; another
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
231
        tries to lock it.
232
        """
1551.15.22 by Aaron Bentley
Redo test skip
233
        # This test sometimes fails like this:
234
        # Traceback (most recent call last):
235
236
        #   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/
237
        # test_lockdir.py", line 247, in test_32_lock_wait_succeed
238
        #     self.assertEqual(1, len(self._logged_reports))
239
        # AssertionError: not equal:
240
        # a = 1
241
        # b = 0
242
        raise tests.TestSkipped("Test fails intermittently")
1551.15.18 by Aaron Bentley
Skip itermittently-failing test instead of deleting it
243
        t = self.get_transport()
244
        lf1 = LockDir(t, 'test_lock')
245
        lf1.create()
246
        lf1.attempt_lock()
247
248
        def wait_and_unlock():
249
            time.sleep(0.1)
250
            lf1.unlock()
251
        unlocker = Thread(target=wait_and_unlock)
252
        unlocker.start()
253
        try:
254
            lf2 = LockDir(t, 'test_lock')
255
            self.setup_log_reporter(lf2)
256
            before = time.time()
257
            # wait and then lock
258
            lf2.wait_lock(timeout=0.4, poll=0.1)
259
            after = time.time()
260
            self.assertTrue(after - before <= 1.0)
261
        finally:
262
            unlocker.join()
263
264
        # There should be only 1 report, even though it should have to
265
        # wait for a while
266
        lock_base = lf2.transport.abspath(lf2.path)
267
        self.assertEqual(1, len(self._logged_reports))
268
        self.assertEqual('%s %s\n'
269
                         '%s\n%s\n'
270
                         'Will continue to try until %s\n',
271
                         self._logged_reports[0][0])
272
        args = self._logged_reports[0][1]
273
        self.assertEqual('Unable to obtain', args[0])
274
        self.assertEqual('lock %s' % (lock_base,), args[1])
275
        self.assertStartsWith(args[2], 'held by ')
276
        self.assertStartsWith(args[3], 'locked ')
277
        self.assertEndsWith(args[3], ' ago')
278
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
279
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
280
    def test_34_lock_write_waits(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
281
        """LockDir.lock_write() will wait for the lock."""
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
282
        # the test suite sets the default to 0 to make deadlocks fail fast.
283
        # change it for this test, as we want to try a manual deadlock.
2631.1.4 by Aaron Bentley
Fix test skip
284
        raise tests.TestSkipped('Timing-sensitive test')
2381.1.4 by Robert Collins
Unbreak lockdir tests after adding fast lockdir timeouts to the test suite default environment.
285
        bzrlib.lockdir._DEFAULT_TIMEOUT_SECONDS = 300
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
286
        t = self.get_transport()
287
        lf1 = LockDir(t, 'test_lock')
288
        lf1.create()
289
        lf1.attempt_lock()
290
291
        def wait_and_unlock():
292
            time.sleep(0.1)
293
            lf1.unlock()
294
        unlocker = Thread(target=wait_and_unlock)
295
        unlocker.start()
296
        try:
297
            lf2 = LockDir(t, 'test_lock')
298
            self.setup_log_reporter(lf2)
299
            before = time.time()
300
            # wait and then lock
301
            lf2.lock_write()
302
            after = time.time()
303
        finally:
304
            unlocker.join()
305
306
        # There should be only 1 report, even though it should have to
307
        # wait for a while
308
        lock_base = lf2.transport.abspath(lf2.path)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
309
        self.assertEqual(1, len(self._logged_reports))
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
310
        self.assertEqual('%s %s\n'
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
311
                         '%s\n%s\n'
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
312
                         'Will continue to try until %s\n',
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
313
                         self._logged_reports[0][0])
314
        args = self._logged_reports[0][1]
1957.1.9 by John Arbash Meinel
Change default timeouts, and report differently the first failure
315
        self.assertEqual('Unable to obtain', args[0])
316
        self.assertEqual('lock %s' % (lock_base,), args[1])
317
        self.assertStartsWith(args[2], 'held by ')
318
        self.assertStartsWith(args[3], 'locked ')
319
        self.assertEndsWith(args[3], ' ago')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
320
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
321
322
    def test_35_wait_lock_changing(self):
323
        """LockDir.wait_lock() will report if the lock changes underneath.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
324
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
325
        This is the stages we want to happen:
326
327
        0) Synchronization locks are created and locked.
328
        1) Lock1 obtains the lockdir, and releases the 'check' lock.
329
        2) Lock2 grabs the 'check' lock, and checks the lockdir.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
330
           It sees the lockdir is already acquired, reports the fact,
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
331
           and unsets the 'checked' lock.
332
        3) Thread1 blocks on acquiring the 'checked' lock, and then tells
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
333
           Lock1 to release and acquire the lockdir. This resets the 'check'
334
           lock.
335
        4) Lock2 acquires the 'check' lock, and checks again. It notices
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
336
           that the holder of the lock has changed, and so reports a new
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
337
           lock holder.
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
338
        5) Thread1 blocks on the 'checked' lock, this time, it completely
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
339
           unlocks the lockdir, allowing Lock2 to acquire the lock.
340
        """
341
3497.1.1 by Martin Pool
xfail test_35_wait_lock_changing
342
        raise tests.KnownFailure(
343
            "timing dependency in lock tests (#213182)")
344
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
345
        wait_to_check_lock = Lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
346
        wait_until_checked_lock = Lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
347
348
        wait_to_check_lock.acquire()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
349
        wait_until_checked_lock.acquire()
350
        note('locked check and checked locks')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
351
352
        class LockDir1(LockDir):
353
            """Use the synchronization points for the first lock."""
354
355
            def attempt_lock(self):
356
                # Once we have acquired the lock, it is okay for
357
                # the other lock to check it
358
                try:
359
                    return super(LockDir1, self).attempt_lock()
360
                finally:
361
                    note('lock1: releasing check lock')
362
                    wait_to_check_lock.release()
363
364
        class LockDir2(LockDir):
365
            """Use the synchronization points for the second lock."""
366
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
367
            def attempt_lock(self):
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
368
                note('lock2: waiting for check lock')
369
                wait_to_check_lock.acquire()
370
                note('lock2: acquired check lock')
371
                try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
372
                    return super(LockDir2, self).attempt_lock()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
373
                finally:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
374
                    note('lock2: releasing checked lock')
375
                    wait_until_checked_lock.release()
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
376
377
        t = self.get_transport()
378
        lf1 = LockDir1(t, 'test_lock')
379
        lf1.create()
380
381
        lf2 = LockDir2(t, 'test_lock')
382
        self.setup_log_reporter(lf2)
383
384
        def wait_and_switch():
385
            lf1.attempt_lock()
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
386
            # Block until lock2 has had a chance to check
387
            note('lock1: waiting 1 for checked lock')
388
            wait_until_checked_lock.acquire()
389
            note('lock1: acquired for checked lock')
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
390
            note('lock1: released lockdir')
391
            lf1.unlock()
392
            note('lock1: acquiring lockdir')
393
            # Create a new nonce, so the lock looks different.
394
            lf1.nonce = osutils.rand_chars(20)
395
            lf1.lock_write()
396
            note('lock1: acquired lockdir')
397
398
            # Block until lock2 has peeked again
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
399
            note('lock1: waiting 2 for checked lock')
400
            wait_until_checked_lock.acquire()
401
            note('lock1: acquired for checked lock')
402
            # Now unlock, and let lock 2 grab the lock
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
403
            lf1.unlock()
404
            wait_to_check_lock.release()
405
406
        unlocker = Thread(target=wait_and_switch)
407
        unlocker.start()
408
        try:
1957.1.11 by John Arbash Meinel
Switch from locking the peek() to locking attempt_lock(), which is much more stable
409
            # Wait and play against the other thread
2709.1.1 by Martin Pool
Make TestLockDir.test_35_wait_lock_changing less timing-sensitive
410
            lf2.wait_lock(timeout=20.0, poll=0.01)
1957.1.7 by John Arbash Meinel
Add the ability to report if the lock changes from underneath you
411
        finally:
412
            unlocker.join()
413
        lf2.unlock()
414
415
        # There should be 2 reports, because the lock changed
416
        lock_base = lf2.transport.abspath(lf2.path)
417
        self.assertEqual(2, len(self._logged_reports))
3441.4.2 by Martin Albisetti
Fixed failing tests
418
        lock_url = lf2.transport.abspath(lf2.path)
1957.1.15 by John Arbash Meinel
Review feedback from Robert
419
        self.assertEqual('%s %s\n'
420
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
421
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
422
                         'you press Ctrl-C.\n'
423
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
424
                         self._logged_reports[0][0])
425
        args = self._logged_reports[0][1]
426
        self.assertEqual('Unable to obtain', args[0])
427
        self.assertEqual('lock %s' % (lock_base,), args[1])
428
        self.assertStartsWith(args[2], 'held by ')
429
        self.assertStartsWith(args[3], 'locked ')
430
        self.assertEndsWith(args[3], ' ago')
431
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.13 by John Arbash Meinel
Change to reporting the time when we will stop trying to grab the lock
432
1957.1.15 by John Arbash Meinel
Review feedback from Robert
433
        self.assertEqual('%s %s\n'
434
                         '%s\n%s\n'
3441.4.2 by Martin Albisetti
Fixed failing tests
435
                         'Will continue to try until %s, unless '
4960.2.2 by Martin Pool
Tweak Lockdir contention message to suggest reading help break-lock.
436
                         'you press Ctrl-C.\n'
437
                         'See "bzr help break-lock" for more.',
1957.1.15 by John Arbash Meinel
Review feedback from Robert
438
                         self._logged_reports[1][0])
439
        args = self._logged_reports[1][1]
440
        self.assertEqual('Lock owner changed for', args[0])
441
        self.assertEqual('lock %s' % (lock_base,), args[1])
442
        self.assertStartsWith(args[2], 'held by ')
443
        self.assertStartsWith(args[3], 'locked ')
444
        self.assertEndsWith(args[3], ' ago')
445
        self.assertContainsRe(args[4], r'\d\d:\d\d:\d\d')
1957.1.2 by John Arbash Meinel
Switch the default from instantly aborting, to waiting as long as 1 minute (down from 5 minutes)
446
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
447
    def test_40_confirm_easy(self):
448
        """Confirm a lock that's already held"""
449
        t = self.get_transport()
450
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
451
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
452
        lf1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
453
        self.addCleanup(lf1.unlock)
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
454
        lf1.confirm()
455
456
    def test_41_confirm_not_held(self):
457
        """Confirm a lock that's already held"""
458
        t = self.get_transport()
459
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
460
        lf1.create()
1553.5.20 by Martin Pool
Start adding LockDir.confirm() method
461
        self.assertRaises(LockNotHeld, lf1.confirm)
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
462
463
    def test_42_confirm_broken_manually(self):
464
        """Confirm a lock broken by hand"""
465
        t = self.get_transport()
466
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
467
        lf1.create()
1553.5.23 by Martin Pool
Start LockDir.confirm method and LockBroken exception
468
        lf1.attempt_lock()
469
        t.move('test_lock', 'lock_gone_now')
470
        self.assertRaises(LockBroken, lf1.confirm)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
471
        # Clean up
472
        t.move('lock_gone_now', 'test_lock')
473
        lf1.unlock()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
474
475
    def test_43_break(self):
476
        """Break a lock whose caller has forgotten it"""
477
        t = self.get_transport()
478
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
479
        lf1.create()
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
480
        lf1.attempt_lock()
481
        # we incorrectly discard the lock object without unlocking it
482
        del lf1
483
        # someone else sees it's still locked
484
        lf2 = LockDir(t, 'test_lock')
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
485
        holder_info = lf2.peek()
486
        self.assertTrue(holder_info)
487
        lf2.force_break(holder_info)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
488
        # now we should be able to take it
489
        lf2.attempt_lock()
4327.1.4 by Vincent Ladeuil
Fix lock test failures by taking lock breaking into account.
490
        self.addCleanup(lf2.unlock)
1553.5.25 by Martin Pool
New LockDir.force_break and simple test case
491
        lf2.confirm()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
492
493
    def test_44_break_already_released(self):
494
        """Lock break races with regular release"""
495
        t = self.get_transport()
496
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
497
        lf1.create()
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
498
        lf1.attempt_lock()
499
        # someone else sees it's still locked
500
        lf2 = LockDir(t, 'test_lock')
501
        holder_info = lf2.peek()
502
        # in the interim the lock is released
503
        lf1.unlock()
504
        # break should succeed
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
505
        lf2.force_break(holder_info)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
506
        # now we should be able to take it
507
        lf2.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
508
        self.addCleanup(lf2.unlock)
1553.5.26 by Martin Pool
Breaking an already-released lock should just succeed
509
        lf2.confirm()
510
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
511
    def test_45_break_mismatch(self):
512
        """Lock break races with someone else acquiring it"""
513
        t = self.get_transport()
514
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
515
        lf1.create()
1553.5.27 by Martin Pool
Confirm that only the intended holder of a lock was broken.
516
        lf1.attempt_lock()
517
        # someone else sees it's still locked
518
        lf2 = LockDir(t, 'test_lock')
519
        holder_info = lf2.peek()
520
        # in the interim the lock is released
521
        lf1.unlock()
522
        lf3 = LockDir(t, 'test_lock')
523
        lf3.attempt_lock()
524
        # break should now *fail*
525
        self.assertRaises(LockBreakMismatch, lf2.force_break,
526
                          holder_info)
527
        lf3.unlock()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
528
529
    def test_46_fake_read_lock(self):
530
        t = self.get_transport()
531
        lf1 = LockDir(t, 'test_lock')
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
532
        lf1.create()
1553.5.54 by Martin Pool
Add LockDir.read_lock fake method
533
        lf1.lock_read()
534
        lf1.unlock()
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
535
536
    def test_50_lockdir_representation(self):
537
        """Check the on-disk representation of LockDirs is as expected.
538
539
        There should always be a top-level directory named by the lock.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
540
        When the lock is held, there should be a lockname/held directory
1553.5.58 by Martin Pool
Change LockDirs to format "lock-name/held/info"
541
        containing an info file.
542
        """
543
        t = self.get_transport()
544
        lf1 = LockDir(t, 'test_lock')
545
        lf1.create()
546
        self.assertTrue(t.has('test_lock'))
547
        lf1.lock_write()
548
        self.assertTrue(t.has('test_lock/held/info'))
549
        lf1.unlock()
550
        self.assertFalse(t.has('test_lock/held/info'))
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
551
552
    def test_break_lock(self):
553
        # the ui based break_lock routine should Just Work (tm)
554
        ld1 = self.get_lock()
555
        ld2 = self.get_lock()
556
        ld1.create()
557
        ld1.lock_write()
1687.1.6 by Robert Collins
Extend LockableFiles to support break_lock() calls.
558
        # do this without IO redirection to ensure it doesn't prompt.
559
        self.assertRaises(AssertionError, ld1.break_lock)
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
560
        orig_factory = bzrlib.ui.ui_factory
4449.3.27 by Martin Pool
More test updates to use CannedInputUIFactory
561
        bzrlib.ui.ui_factory = bzrlib.ui.CannedInputUIFactory([True])
1687.1.5 by Robert Collins
Add break_lock utility function to LockDir.
562
        try:
563
            ld2.break_lock()
564
            self.assertRaises(LockBroken, ld1.unlock)
565
        finally:
566
            bzrlib.ui.ui_factory = orig_factory
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
567
4634.161.1 by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files.
568
    def test_break_lock_corrupt_info(self):
569
        """break_lock works even if the info file is corrupt (and tells the UI
570
        that it is corrupt).
571
        """
572
        ld = self.get_lock()
573
        ld2 = self.get_lock()
574
        ld.create()
575
        ld.lock_write()
576
        ld.transport.put_bytes_non_atomic('test_lock/held/info', '\0')
577
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
578
            def __init__(self):
579
                self.prompts = []
580
            def get_boolean(self, prompt):
581
                self.prompts.append(('boolean', prompt))
582
                return True
583
        ui = LoggingUIFactory()
5599.2.1 by John Arbash Meinel
Fix breaking corrupt lock files on Windows.
584
        self.overrideAttr(bzrlib.ui, 'ui_factory', ui)
585
        ld2.break_lock()
586
        self.assertLength(1, ui.prompts)
587
        self.assertEqual('boolean', ui.prompts[0][0])
588
        self.assertStartsWith(ui.prompts[0][1], 'Break (corrupt LockDir')
589
        self.assertRaises(LockBroken, ld.unlock)
4634.161.1 by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files.
590
591
    def test_break_lock_missing_info(self):
592
        """break_lock works even if the info file is missing (and tells the UI
593
        that it is corrupt).
594
        """
595
        ld = self.get_lock()
596
        ld2 = self.get_lock()
597
        ld.create()
598
        ld.lock_write()
599
        ld.transport.delete('test_lock/held/info')
600
        class LoggingUIFactory(bzrlib.ui.SilentUIFactory):
601
            def __init__(self):
602
                self.prompts = []
603
            def get_boolean(self, prompt):
604
                self.prompts.append(('boolean', prompt))
605
                return True
606
        ui = LoggingUIFactory()
607
        orig_factory = bzrlib.ui.ui_factory
608
        bzrlib.ui.ui_factory = ui
609
        try:
610
            ld2.break_lock()
611
            self.assertRaises(LockBroken, ld.unlock)
612
            self.assertLength(0, ui.prompts)
613
        finally:
614
            bzrlib.ui.ui_factory = orig_factory
615
        # Suppress warnings due to ld not being unlocked
616
        # XXX: if lock_broken hook was invoked in this case, this hack would
617
        # not be necessary.  - Andrew Bennetts, 2010-09-06.
618
        del self._lock_actions[:]
619
1955.1.1 by John Arbash Meinel
LockDir can create the root directory if it fails to create a pending directory due to NoSuchFile.
620
    def test_create_missing_base_directory(self):
621
        """If LockDir.path doesn't exist, it can be created
622
623
        Some people manually remove the entire lock/ directory trying
624
        to unlock a stuck repository/branch/etc. Rather than failing
625
        after that, just create the lock directory when needed.
626
        """
627
        t = self.get_transport()
628
        lf1 = LockDir(t, 'test_lock')
629
630
        lf1.create()
631
        self.failUnless(t.has('test_lock'))
632
633
        t.rmdir('test_lock')
634
        self.failIf(t.has('test_lock'))
635
636
        # This will create 'test_lock' if it needs to
637
        lf1.lock_write()
638
        self.failUnless(t.has('test_lock'))
639
        self.failUnless(t.has('test_lock/held/info'))
640
641
        lf1.unlock()
642
        self.failIf(t.has('test_lock/held/info'))
1957.1.6 by John Arbash Meinel
[merge] bzr.dev 2009
643
1957.1.5 by John Arbash Meinel
Create a helper function for formatting lock information
644
    def test__format_lock_info(self):
645
        ld1 = self.get_lock()
646
        ld1.create()
647
        ld1.lock_write()
648
        try:
649
            info_list = ld1._format_lock_info(ld1.peek())
650
        finally:
651
            ld1.unlock()
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
652
        self.assertEqual(info_list[0], u'jrandom@example.com')
653
        # info_list[1] is hostname. we skip this.
654
        self.assertContainsRe(info_list[2], '^\d+$') # pid
655
        self.assertContainsRe(info_list[3], r'^\d+ seconds? ago$') # time_ago
2055.2.1 by John Arbash Meinel
Make LockDir less sensitive to invalid configuration of email
656
657
    def test_lock_without_email(self):
658
        global_config = config.GlobalConfig()
659
        # Intentionally has no email address
660
        global_config.set_user_option('email', 'User Identity')
661
        ld1 = self.get_lock()
662
        ld1.create()
663
        ld1.lock_write()
664
        ld1.unlock()
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
665
666
    def test_lock_permission(self):
4797.70.1 by Vincent Ladeuil
Skip chmodbits dependent tests when running as root
667
        self.requireFeature(features.not_running_as_root)
1551.10.4 by Aaron Bentley
Update to skip on win32
668
        if not osutils.supports_posix_readonly():
3107.2.2 by John Arbash Meinel
feedback from Martin.
669
            raise tests.TestSkipped('Cannot induce a permission failure')
1551.10.3 by Aaron Bentley
Lock attempts don't treat permission problems as lock contention
670
        ld1 = self.get_lock()
671
        lock_path = ld1.transport.local_abspath('test_lock')
672
        os.mkdir(lock_path)
673
        osutils.make_readonly(lock_path)
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
674
        self.assertRaises(errors.LockFailed, ld1.attempt_lock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
675
676
    def test_lock_by_token(self):
677
        ld1 = self.get_lock()
678
        token = ld1.lock_write()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
679
        self.addCleanup(ld1.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
680
        self.assertNotEqual(None, token)
681
        ld2 = self.get_lock()
682
        t2 = ld2.lock_write(token)
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
683
        self.addCleanup(ld2.unlock)
2555.3.5 by Martin Pool
Return token directly from LockDir.acquire to avoid unnecessary peek()
684
        self.assertEqual(token, t2)
2555.3.9 by Martin Pool
Add test and fix for locking robustly when rename of directories doesn't act as a mutex (thank John)
685
686
    def test_lock_with_buggy_rename(self):
687
        # test that lock acquisition handles servers which pretend they
688
        # renamed correctly but that actually fail
689
        t = transport.get_transport('brokenrename+' + self.get_url())
690
        ld1 = LockDir(t, 'test_lock')
691
        ld1.create()
692
        ld1.attempt_lock()
693
        ld2 = LockDir(t, 'test_lock')
2555.3.14 by Martin Pool
Better handling in LockDir of rename that moves one directory within another
694
        # we should fail to lock
695
        e = self.assertRaises(errors.LockContention, ld2.attempt_lock)
696
        # now the original caller should succeed in unlocking
697
        ld1.unlock()
698
        # and there should be nothing left over
699
        self.assertEquals([], t.list_dir('test_lock'))
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
700
701
    def test_failed_lock_leaves_no_trash(self):
702
        # if we fail to acquire the lock, we don't leave pending directories
703
        # behind -- https://bugs.launchpad.net/bzr/+bug/109169
704
        ld1 = self.get_lock()
705
        ld2 = self.get_lock()
706
        # should be nothing before we start
707
        ld1.create()
708
        t = self.get_transport().clone('test_lock')
709
        def check_dir(a):
710
            self.assertEquals(a, t.list_dir('.'))
711
        check_dir([])
712
        # when held, that's all we see
713
        ld1.attempt_lock()
4327.1.1 by Vincent Ladeuil
Start addressing test failing when run with -Dlock.
714
        self.addCleanup(ld1.unlock)
2555.3.12 by Martin Pool
Add test for https://bugs.launchpad.net/bzr/+bug/109169 -- test_failed_lock_leaves_no_trash
715
        check_dir(['held'])
716
        # second guy should fail
717
        self.assertRaises(errors.LockContention, ld2.attempt_lock)
718
        # no kibble
719
        check_dir(['held'])
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
720
4634.138.1 by Martin Pool
Add failing test for \#185103
721
    def test_no_lockdir_info(self):
722
        """We can cope with empty info files."""
723
        # This seems like a fairly common failure case - see
5243.1.2 by Martin
Point launchpad links in comments at production server rather than edge
724
        # <https://bugs.launchpad.net/bzr/+bug/185103> and all its dupes.
4634.138.1 by Martin Pool
Add failing test for \#185103
725
        # Processes are often interrupted after opening the file
726
        # before the actual contents are committed.
727
        t = self.get_transport()
728
        t.mkdir('test_lock')
729
        t.mkdir('test_lock/held')
730
        t.put_bytes('test_lock/held/info', '')
731
        lf = LockDir(t, 'test_lock')
4634.138.2 by Martin Pool
Copy with lock info file being empty
732
        info = lf.peek()
733
        formatted_info = lf._format_lock_info(info)
734
        self.assertEquals(
5284.6.3 by Parth Malwankar
fixed tests. closed review comments by mgz.
735
            ['<unknown>', '<unknown>', '<unknown>', '(unknown)'],
4634.138.2 by Martin Pool
Copy with lock info file being empty
736
            formatted_info)
4634.138.1 by Martin Pool
Add failing test for \#185103
737
4634.161.1 by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files.
738
    def test_corrupt_lockdir_info(self):
739
        """We can cope with corrupt (and thus unparseable) info files."""
740
        # This seems like a fairly common failure case too - see
4634.165.4 by Vincent Ladeuil
Fix all comments where bugs.edge.launchpad.net was used.
741
        # <https://bugs.launchpad.net/bzr/+bug/619872> for instance.
4634.161.1 by Andrew Bennetts
Add LockCorrupt error, and use it to provide nicer handling of unparseable lock/held/info files.
742
        # In particular some systems tend to fill recently created files with
743
        # nul bytes after recovering from a system crash.
744
        t = self.get_transport()
745
        t.mkdir('test_lock')
746
        t.mkdir('test_lock/held')
747
        t.put_bytes('test_lock/held/info', '\0')
748
        lf = LockDir(t, 'test_lock')
749
        self.assertRaises(errors.LockCorrupt, lf.peek)
750
        # Currently attempt_lock gives LockContention, but LockCorrupt would be
751
        # a reasonable result too.
752
        self.assertRaises(
753
            (errors.LockCorrupt, errors.LockContention), lf.attempt_lock)
754
        self.assertRaises(errors.LockCorrupt, lf.validate_token, 'fake token')
755
756
    def test_missing_lockdir_info(self):
757
        """We can cope with absent info files."""
758
        t = self.get_transport()
759
        t.mkdir('test_lock')
760
        t.mkdir('test_lock/held')
761
        lf = LockDir(t, 'test_lock')
762
        # In this case we expect the 'not held' result from peek, because peek
763
        # cannot be expected to notice that there is a 'held' directory with no
764
        # 'info' file.
765
        self.assertEqual(None, lf.peek())
766
        # And lock/unlock may work or give LockContention (but not any other
767
        # error).
768
        try:
769
            lf.attempt_lock()
770
        except LockContention:
771
            # LockContention is ok, and expected on Windows
772
            pass
773
        else:
774
            # no error is ok, and expected on POSIX (because POSIX allows
775
            # os.rename over an empty directory).
776
            lf.unlock()
777
        # Currently raises TokenMismatch, but LockCorrupt would be reasonable
778
        # too.
779
        self.assertRaises(
780
            (errors.TokenMismatch, errors.LockCorrupt),
781
            lf.validate_token, 'fake token')
782
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
783
784
class TestLockDirHooks(TestCaseWithTransport):
785
786
    def setUp(self):
787
        super(TestLockDirHooks, self).setUp()
788
        self._calls = []
789
790
    def get_lock(self):
791
        return LockDir(self.get_transport(), 'test_lock')
792
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
793
    def record_hook(self, result):
794
        self._calls.append(result)
795
3331.3.12 by Martin Pool
Remove PhysicalLock class
796
    def test_LockDir_acquired_success(self):
797
        # the LockDir.lock_acquired hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
798
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
799
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
800
        ld = self.get_lock()
801
        ld.create()
802
        self.assertEqual([], self._calls)
803
        result = ld.attempt_lock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
804
        lock_path = ld.transport.abspath(ld.path)
805
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
806
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
807
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
808
3331.3.12 by Martin Pool
Remove PhysicalLock class
809
    def test_LockDir_acquired_fail(self):
810
        # the LockDir.lock_acquired hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
811
        ld = self.get_lock()
812
        ld.create()
813
        ld2 = self.get_lock()
814
        ld2.attempt_lock()
815
        # install a lock hook now, when the disk lock is locked
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
816
        LockDir.hooks.install_named_hook('lock_acquired',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
817
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
818
        self.assertRaises(errors.LockContention, ld.attempt_lock)
819
        self.assertEqual([], self._calls)
820
        ld2.unlock()
821
        self.assertEqual([], self._calls)
822
3331.3.12 by Martin Pool
Remove PhysicalLock class
823
    def test_LockDir_released_success(self):
824
        # the LockDir.lock_released hook fires when a lock is acquired.
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
825
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
826
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
827
        ld = self.get_lock()
828
        ld.create()
829
        self.assertEqual([], self._calls)
830
        result = ld.attempt_lock()
831
        self.assertEqual([], self._calls)
832
        ld.unlock()
3331.3.2 by Robert Collins
Polish on lock hooks to be easier to use.
833
        lock_path = ld.transport.abspath(ld.path)
834
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
835
3331.3.12 by Martin Pool
Remove PhysicalLock class
836
    def test_LockDir_released_fail(self):
837
        # the LockDir.lock_released hook does not fire on failure.
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
838
        ld = self.get_lock()
839
        ld.create()
840
        ld2 = self.get_lock()
841
        ld.attempt_lock()
842
        ld2.force_break(ld2.peek())
3331.3.11 by Martin Pool
Move LockDir hooks onto LockDir
843
        LockDir.hooks.install_named_hook('lock_released',
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
844
                                         self.record_hook, 'record_hook')
3331.3.1 by Robert Collins
* ``LockDir`` lock acquisition and release now trigger hooks allowing
845
        self.assertRaises(LockBroken, ld.unlock)
846
        self.assertEqual([], self._calls)
4327.1.2 by Vincent Ladeuil
Introduce a new lock_broken hook.
847
848
    def test_LockDir_broken_success(self):
849
        # the LockDir.lock_broken hook fires when a lock is broken.
850
        ld = self.get_lock()
851
        ld.create()
852
        ld2 = self.get_lock()
853
        result = ld.attempt_lock()
854
        LockDir.hooks.install_named_hook('lock_broken',
855
                                         self.record_hook, 'record_hook')
856
        ld2.force_break(ld2.peek())
857
        lock_path = ld.transport.abspath(ld.path)
858
        self.assertEqual([lock.LockResult(lock_path, result)], self._calls)
859
860
    def test_LockDir_broken_failure(self):
861
        # the LockDir.lock_broken hook does not fires when a lock is already
862
        # released.
863
        ld = self.get_lock()
864
        ld.create()
865
        ld2 = self.get_lock()
866
        result = ld.attempt_lock()
867
        holder_info = ld2.peek()
868
        ld.unlock()
869
        LockDir.hooks.install_named_hook('lock_broken',
870
                                         self.record_hook, 'record_hook')
871
        ld2.force_break(holder_info)
872
        lock_path = ld.transport.abspath(ld.path)
873
        self.assertEqual([], self._calls)