/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
4988.10.3 by John Arbash Meinel
Merge bzr.dev 5007, resolve conflict, update NEWS
1
# Copyright (C) 2005-2010 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
369 by Martin Pool
- Split out log printing into new show_log function
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
369 by Martin Pool
- Split out log printing into new show_log function
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
12
#
369 by Martin Pool
- Split out log printing into new show_log function
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
369 by Martin Pool
- Split out log printing into new show_log function
16
375 by Martin Pool
- New command touching-revisions and function to trace
17
18
527 by Martin Pool
- refactor log command
19
"""Code to show logs of changes.
20
21
Various flavors of log can be produced:
22
23
* for one file, or the whole tree, and (not done yet) for
24
  files in a given directory
25
26
* in "verbose" mode with a description of what changed from one
27
  version to the next
28
29
* with file-ids and revision-ids shown
30
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
31
Logs are actually written out through an abstract LogFormatter
32
interface, which allows for different preferred formats.  Plugins can
33
register formats too.
34
35
Logs can be produced in either forward (oldest->newest) or reverse
36
(newest->oldest) order.
37
38
Logs can be filtered to show only revisions matching a particular
39
search string, or within a particular range of revisions.  The range
40
can be given as date/times, which are reduced to revisions before
41
calling in here.
42
43
In verbose mode we show a summary of what changed in each particular
44
revision.  Note that this is the delta for changes in that revision
2466.12.2 by Kent Gibson
shift log output with only merge revisions to the left margin
45
relative to its left-most parent, not the delta relative to the last
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
46
logged revision.  So for example if you ask for a verbose log of
47
changes touching hello.c you will get a list of those revisions also
48
listing other things that were changed in the same revision, but not
49
all the changes since the previous revision that touched hello.c.
527 by Martin Pool
- refactor log command
50
"""
51
2997.1.2 by Kent Gibson
Move all imports to top of log.py
52
import codecs
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
53
from cStringIO import StringIO
2997.1.2 by Kent Gibson
Move all imports to top of log.py
54
from itertools import (
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
55
    chain,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
56
    izip,
57
    )
1624.1.3 by Robert Collins
Convert log to use the new tsort.merge_sort routine.
58
import re
2997.1.2 by Kent Gibson
Move all imports to top of log.py
59
import sys
60
from warnings import (
61
    warn,
62
    )
1185.33.41 by Martin Pool
Fix regression of 'bzr log -v' - it wasn't showing changed files at all. (#4676)
63
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
64
from bzrlib.lazy_import import lazy_import
65
lazy_import(globals(), """
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
66
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
67
from bzrlib import (
4202.2.1 by Ian Clatworthy
get directory logging working again
68
    bzrdir,
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
69
    config,
3943.5.1 by Ian Clatworthy
first cut at log --show-diff
70
    diff,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
71
    errors,
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
72
    foreign,
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
73
    repository as _mod_repository,
74
    revision as _mod_revision,
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
75
    revisionspec,
76
    tsort,
77
    )
78
""")
79
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
80
from bzrlib import (
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
81
    registry,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
82
    )
83
from bzrlib.osutils import (
84
    format_date,
4379.4.1 by Ian Clatworthy
make log --long faster
85
    format_date_with_offset_in_original_timezone,
5753.2.2 by Jelmer Vernooij
Remove some unnecessary imports, clean up lazy imports.
86
    get_diff_header_encoding,
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
87
    get_terminal_encoding,
2997.1.2 by Kent Gibson
Move all imports to top of log.py
88
    terminal_width,
89
    )
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
90
from bzrlib.symbol_versioning import (
91
    deprecated_function,
92
    deprecated_in,
93
    )
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
94
375 by Martin Pool
- New command touching-revisions and function to trace
95
96
def find_touching_revisions(branch, file_id):
97
    """Yield a description of revisions which affect the file_id.
98
99
    Each returned element is (revno, revision_id, description)
100
101
    This is the list of revisions where the file is either added,
102
    modified, renamed or deleted.
103
104
    TODO: Perhaps some way to limit this to only particular revisions,
522 by Martin Pool
todo
105
    or to traverse a non-mainline set of revisions?
375 by Martin Pool
- New command touching-revisions and function to trace
106
    """
107
    last_ie = None
108
    last_path = None
109
    revno = 1
110
    for revision_id in branch.revision_history():
5035.3.1 by Jelmer Vernooij
Remove Repository.get_revision_inventory.
111
        this_inv = branch.repository.get_inventory(revision_id)
375 by Martin Pool
- New command touching-revisions and function to trace
112
        if file_id in this_inv:
113
            this_ie = this_inv[file_id]
114
            this_path = this_inv.id2path(file_id)
115
        else:
116
            this_ie = this_path = None
117
118
        # now we know how it was last time, and how it is in this revision.
119
        # are those two states effectively the same or not?
120
121
        if not this_ie and not last_ie:
122
            # not present in either
123
            pass
124
        elif this_ie and not last_ie:
125
            yield revno, revision_id, "added " + this_path
126
        elif not this_ie and last_ie:
127
            # deleted here
128
            yield revno, revision_id, "deleted " + last_path
129
        elif this_path != last_path:
130
            yield revno, revision_id, ("renamed %s => %s" % (last_path, this_path))
131
        elif (this_ie.text_size != last_ie.text_size
132
              or this_ie.text_sha1 != last_ie.text_sha1):
133
            yield revno, revision_id, "modified " + this_path
134
135
        last_ie = this_ie
136
        last_path = this_path
137
        revno += 1
138
139
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
140
def _enumerate_history(branch):
141
    rh = []
142
    revno = 1
143
    for rev_id in branch.revision_history():
144
        rh.append((revno, rev_id))
145
        revno += 1
146
    return rh
147
148
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
149
def show_log(branch,
150
             lf,
151
             specific_fileid=None,
152
             verbose=False,
153
             direction='reverse',
154
             start_revision=None,
155
             end_revision=None,
156
             search=None,
157
             limit=None,
158
             show_diff=False):
159
    """Write out human-readable log of commits to this branch.
160
161
    This function is being retained for backwards compatibility but
162
    should not be extended with new parameters. Use the new Logger class
163
    instead, eg. Logger(branch, rqst).show(lf), adding parameters to the
4205.1.1 by Ian Clatworthy
log multiple files and directories (Ian Clatworthy)
164
    make_log_request_dict function.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
165
166
    :param lf: The LogFormatter object showing the output.
167
168
    :param specific_fileid: If not None, list only the commits affecting the
169
        specified file, rather than all commits.
170
171
    :param verbose: If True show added/changed/deleted/renamed files.
172
173
    :param direction: 'reverse' (default) is latest to earliest; 'forward' is
174
        earliest to latest.
175
176
    :param start_revision: If not None, only show revisions >= start_revision
177
178
    :param end_revision: If not None, only show revisions <= end_revision
179
180
    :param search: If not None, only show revisions with matching commit
181
        messages
182
183
    :param limit: If set, shows only 'limit' revisions, all revisions are shown
184
        if None or 0.
185
186
    :param show_diff: If True, output a diff after each revision.
187
    """
188
    # Convert old-style parameters to new-style parameters
189
    if specific_fileid is not None:
190
        file_ids = [specific_fileid]
191
    else:
192
        file_ids = None
193
    if verbose:
194
        if file_ids:
195
            delta_type = 'partial'
196
        else:
197
            delta_type = 'full'
198
    else:
199
        delta_type = None
200
    if show_diff:
201
        if file_ids:
202
            diff_type = 'partial'
203
        else:
204
            diff_type = 'full'
205
    else:
206
        diff_type = None
207
208
    # Build the request and execute it
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
209
    rqst = make_log_request_dict(direction=direction, specific_fileids=file_ids,
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
210
        start_revision=start_revision, end_revision=end_revision,
211
        limit=limit, message_search=search,
212
        delta_type=delta_type, diff_type=diff_type)
213
    Logger(branch, rqst).show(lf)
214
215
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
216
# Note: This needs to be kept this in sync with the defaults in
217
# make_log_request_dict() below
218
_DEFAULT_REQUEST_PARAMS = {
219
    'direction': 'reverse',
220
    'levels': 1,
221
    'generate_tags': True,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
222
    'exclude_common_ancestry': False,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
223
    '_match_using_deltas': True,
224
    }
225
226
227
def make_log_request_dict(direction='reverse', specific_fileids=None,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
228
                          start_revision=None, end_revision=None, limit=None,
229
                          message_search=None, levels=1, generate_tags=True,
230
                          delta_type=None,
231
                          diff_type=None, _match_using_deltas=True,
232
                          exclude_common_ancestry=False,
233
                          ):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
234
    """Convenience function for making a logging request dictionary.
235
236
    Using this function may make code slightly safer by ensuring
237
    parameters have the correct names. It also provides a reference
238
    point for documenting the supported parameters.
239
240
    :param direction: 'reverse' (default) is latest to earliest;
241
      'forward' is earliest to latest.
242
243
    :param specific_fileids: If not None, only include revisions
244
      affecting the specified files, rather than all revisions.
245
246
    :param start_revision: If not None, only generate
247
      revisions >= start_revision
248
249
    :param end_revision: If not None, only generate
250
      revisions <= end_revision
251
252
    :param limit: If set, generate only 'limit' revisions, all revisions
253
      are shown if None or 0.
254
255
    :param message_search: If not None, only include revisions with
256
      matching commit messages
257
258
    :param levels: the number of levels of revisions to
259
      generate; 1 for just the mainline; 0 for all levels.
260
261
    :param generate_tags: If True, include tags for matched revisions.
262
263
    :param delta_type: Either 'full', 'partial' or None.
264
      'full' means generate the complete delta - adds/deletes/modifies/etc;
265
      'partial' means filter the delta using specific_fileids;
266
      None means do not generate any delta.
267
268
    :param diff_type: Either 'full', 'partial' or None.
269
      'full' means generate the complete diff - adds/deletes/modifies/etc;
270
      'partial' means filter the diff using specific_fileids;
271
      None means do not generate any diff.
272
273
    :param _match_using_deltas: a private parameter controlling the
274
      algorithm used for matching specific_fileids. This parameter
275
      may be removed in the future so bzrlib client code should NOT
276
      use it.
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
277
278
    :param exclude_common_ancestry: Whether -rX..Y should be interpreted as a
279
      range operator or as a graph difference.
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
280
    """
281
    return {
282
        'direction': direction,
283
        'specific_fileids': specific_fileids,
284
        'start_revision': start_revision,
285
        'end_revision': end_revision,
286
        'limit': limit,
287
        'message_search': message_search,
288
        'levels': levels,
289
        'generate_tags': generate_tags,
290
        'delta_type': delta_type,
291
        'diff_type': diff_type,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
292
        'exclude_common_ancestry': exclude_common_ancestry,
4202.2.1 by Ian Clatworthy
get directory logging working again
293
        # Add 'private' attributes for features that may be deprecated
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
294
        '_match_using_deltas': _match_using_deltas,
295
    }
296
297
298
def _apply_log_request_defaults(rqst):
299
    """Apply default values to a request dictionary."""
300
    result = _DEFAULT_REQUEST_PARAMS
301
    if rqst:
302
        result.update(rqst)
303
    return result
4202.2.1 by Ian Clatworthy
get directory logging working again
304
305
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
306
class LogGenerator(object):
307
    """A generator of log revisions."""
308
309
    def iter_log_revisions(self):
310
        """Iterate over LogRevision objects.
311
312
        :return: An iterator yielding LogRevision objects.
313
        """
314
        raise NotImplementedError(self.iter_log_revisions)
315
316
317
class Logger(object):
4955.5.3 by Vincent Ladeuil
Cleanup.
318
    """An object that generates, formats and displays a log."""
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
319
320
    def __init__(self, branch, rqst):
321
        """Create a Logger.
322
323
        :param branch: the branch to log
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
324
        :param rqst: A dictionary specifying the query parameters.
325
          See make_log_request_dict() for supported values.
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
326
        """
327
        self.branch = branch
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
328
        self.rqst = _apply_log_request_defaults(rqst)
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
329
330
    def show(self, lf):
331
        """Display the log.
332
333
        :param lf: The LogFormatter object to send the output to.
334
        """
335
        if not isinstance(lf, LogFormatter):
336
            warn("not a LogFormatter instance: %r" % lf)
337
338
        self.branch.lock_read()
339
        try:
340
            if getattr(lf, 'begin_log', None):
341
                lf.begin_log()
342
            self._show_body(lf)
343
            if getattr(lf, 'end_log', None):
344
                lf.end_log()
345
        finally:
346
            self.branch.unlock()
347
348
    def _show_body(self, lf):
349
        """Show the main log output.
350
351
        Subclasses may wish to override this.
352
        """
353
        # Tweak the LogRequest based on what the LogFormatter can handle.
354
        # (There's no point generating stuff if the formatter can't display it.)
355
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
356
        rqst['levels'] = lf.get_levels()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
357
        if not getattr(lf, 'supports_tags', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
358
            rqst['generate_tags'] = False
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
359
        if not getattr(lf, 'supports_delta', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
360
            rqst['delta_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
361
        if not getattr(lf, 'supports_diff', False):
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
362
            rqst['diff_type'] = None
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
363
364
        # Find and print the interesting revisions
365
        generator = self._generator_factory(self.branch, rqst)
366
        for lr in generator.iter_log_revisions():
367
            lf.log_revision(lr)
4208.2.1 by Ian Clatworthy
merge indicators in log --long
368
        lf.show_advice()
4202.2.3 by Ian Clatworthy
replace show_log_request with a Logger class
369
370
    def _generator_factory(self, branch, rqst):
371
        """Make the LogGenerator object to use.
372
        
373
        Subclasses may wish to override this.
374
        """
375
        return _DefaultLogGenerator(branch, rqst)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
376
377
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
378
class _StartNotLinearAncestor(Exception):
379
    """Raised when a start revision is not found walking left-hand history."""
380
381
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
382
class _DefaultLogGenerator(LogGenerator):
383
    """The default generator of log revisions."""
4202.2.1 by Ian Clatworthy
get directory logging working again
384
385
    def __init__(self, branch, rqst):
386
        self.branch = branch
387
        self.rqst = rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
388
        if rqst.get('generate_tags') and branch.supports_tags():
4202.2.1 by Ian Clatworthy
get directory logging working again
389
            self.rev_tag_dict = branch.tags.get_reverse_tag_dict()
390
        else:
391
            self.rev_tag_dict = {}
392
393
    def iter_log_revisions(self):
394
        """Iterate over LogRevision objects.
395
396
        :return: An iterator yielding LogRevision objects.
397
        """
398
        rqst = self.rqst
4379.4.1 by Ian Clatworthy
make log --long faster
399
        levels = rqst.get('levels')
400
        limit = rqst.get('limit')
401
        diff_type = rqst.get('diff_type')
4202.2.1 by Ian Clatworthy
get directory logging working again
402
        log_count = 0
403
        revision_iterator = self._create_log_revision_iterator()
404
        for revs in revision_iterator:
405
            for (rev_id, revno, merge_depth), rev, delta in revs:
406
                # 0 levels means show everything; merge_depth counts from 0
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
407
                if levels != 0 and merge_depth >= levels:
4202.2.1 by Ian Clatworthy
get directory logging working again
408
                    continue
4379.4.1 by Ian Clatworthy
make log --long faster
409
                if diff_type is None:
410
                    diff = None
411
                else:
412
                    diff = self._format_diff(rev, rev_id, diff_type)
4202.2.1 by Ian Clatworthy
get directory logging working again
413
                yield LogRevision(rev, revno, merge_depth, delta,
414
                    self.rev_tag_dict.get(rev_id), diff)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
415
                if limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
416
                    log_count += 1
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
417
                    if log_count >= limit:
4202.2.1 by Ian Clatworthy
get directory logging working again
418
                        return
419
4379.4.1 by Ian Clatworthy
make log --long faster
420
    def _format_diff(self, rev, rev_id, diff_type):
4202.2.1 by Ian Clatworthy
get directory logging working again
421
        repo = self.branch.repository
422
        if len(rev.parent_ids) == 0:
423
            ancestor_id = _mod_revision.NULL_REVISION
424
        else:
425
            ancestor_id = rev.parent_ids[0]
426
        tree_1 = repo.revision_tree(ancestor_id)
427
        tree_2 = repo.revision_tree(rev_id)
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
428
        file_ids = self.rqst.get('specific_fileids')
4202.2.1 by Ian Clatworthy
get directory logging working again
429
        if diff_type == 'partial' and file_ids is not None:
430
            specific_files = [tree_2.id2path(id) for id in file_ids]
431
        else:
432
            specific_files = None
433
        s = StringIO()
5753.2.2 by Jelmer Vernooij
Remove some unnecessary imports, clean up lazy imports.
434
        path_encoding = get_diff_header_encoding()
4202.2.1 by Ian Clatworthy
get directory logging working again
435
        diff.show_diff_trees(tree_1, tree_2, s, specific_files, old_label='',
4797.57.9 by Alexander Belchenko
using terminal_encoding for log -p
436
            new_label='', path_encoding=path_encoding)
4202.2.1 by Ian Clatworthy
get directory logging working again
437
        return s.getvalue()
438
439
    def _create_log_revision_iterator(self):
440
        """Create a revision iterator for log.
441
442
        :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
443
            delta).
444
        """
445
        self.start_rev_id, self.end_rev_id = _get_revision_limits(
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
446
            self.branch, self.rqst.get('start_revision'),
447
            self.rqst.get('end_revision'))
448
        if self.rqst.get('_match_using_deltas'):
4202.2.1 by Ian Clatworthy
get directory logging working again
449
            return self._log_revision_iterator_using_delta_matching()
450
        else:
451
            # We're using the per-file-graph algorithm. This scales really
452
            # well but only makes sense if there is a single file and it's
453
            # not a directory
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
454
            file_count = len(self.rqst.get('specific_fileids'))
4202.2.1 by Ian Clatworthy
get directory logging working again
455
            if file_count != 1:
456
                raise BzrError("illegal LogRequest: must match-using-deltas "
457
                    "when logging %d files" % file_count)
458
            return self._log_revision_iterator_using_per_file_graph()
459
460
    def _log_revision_iterator_using_delta_matching(self):
461
        # Get the base revisions, filtering by the revision range
462
        rqst = self.rqst
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
463
        generate_merge_revisions = rqst.get('levels') != 1
464
        delayed_graph_generation = not rqst.get('specific_fileids') and (
465
                rqst.get('limit') or self.start_rev_id or self.end_rev_id)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
466
        view_revisions = _calc_view_revisions(
467
            self.branch, self.start_rev_id, self.end_rev_id,
468
            rqst.get('direction'),
469
            generate_merge_revisions=generate_merge_revisions,
470
            delayed_graph_generation=delayed_graph_generation,
471
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
4202.2.1 by Ian Clatworthy
get directory logging working again
472
473
        # Apply the other filters
474
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
475
            rqst.get('delta_type'), rqst.get('message_search'),
476
            file_ids=rqst.get('specific_fileids'),
477
            direction=rqst.get('direction'))
4202.2.1 by Ian Clatworthy
get directory logging working again
478
479
    def _log_revision_iterator_using_per_file_graph(self):
480
        # Get the base revisions, filtering by the revision range.
481
        # Note that we always generate the merge revisions because
482
        # filter_revisions_touching_file_id() requires them ...
483
        rqst = self.rqst
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
484
        view_revisions = _calc_view_revisions(
485
            self.branch, self.start_rev_id, self.end_rev_id,
486
            rqst.get('direction'), generate_merge_revisions=True,
487
            exclude_common_ancestry=rqst.get('exclude_common_ancestry'))
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
488
        if not isinstance(view_revisions, list):
489
            view_revisions = list(view_revisions)
4202.2.1 by Ian Clatworthy
get directory logging working again
490
        view_revisions = _filter_revisions_touching_file_id(self.branch,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
491
            rqst.get('specific_fileids')[0], view_revisions,
492
            include_merges=rqst.get('levels') != 1)
4202.2.1 by Ian Clatworthy
get directory logging working again
493
        return make_log_rev_iterator(self.branch, view_revisions,
4202.2.5 by Ian Clatworthy
apply review tweaks & update help
494
            rqst.get('delta_type'), rqst.get('message_search'))
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
495
496
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
497
def _calc_view_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
498
                         generate_merge_revisions,
499
                         delayed_graph_generation=False,
500
                         exclude_common_ancestry=False,
501
                         ):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
502
    """Calculate the revisions to view.
503
504
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
505
             a list of the same tuples.
506
    """
5097.1.13 by Vincent Ladeuil
Add more tests.
507
    if (exclude_common_ancestry and start_rev_id == end_rev_id):
508
        raise errors.BzrCommandError(
509
            '--exclude-common-ancestry requires two different revisions')
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
510
    if direction not in ('reverse', 'forward'):
511
        raise ValueError('invalid direction %r' % direction)
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
512
    br_revno, br_rev_id = branch.last_revision_info()
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
513
    if br_revno == 0:
514
        return []
515
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
516
    if (end_rev_id and start_rev_id == end_rev_id
5129.1.3 by Vincent Ladeuil
Slightly refactor the direction handling in log.
517
        and (not generate_merge_revisions
518
             or not _has_merges(branch, end_rev_id))):
5097.1.13 by Vincent Ladeuil
Add more tests.
519
        # If a single revision is requested, check we can handle it
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
520
        iter_revs = _generate_one_revision(branch, end_rev_id, br_rev_id,
521
                                           br_revno)
522
    elif not generate_merge_revisions:
523
        # If we only want to see linear revisions, we can iterate ...
524
        iter_revs = _generate_flat_revisions(branch, start_rev_id, end_rev_id,
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
525
                                             direction, exclude_common_ancestry)
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
526
        if direction == 'forward':
527
            iter_revs = reversed(iter_revs)
4202.2.1 by Ian Clatworthy
get directory logging working again
528
    else:
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
529
        iter_revs = _generate_all_revisions(branch, start_rev_id, end_rev_id,
530
                                            direction, delayed_graph_generation,
531
                                            exclude_common_ancestry)
532
        if direction == 'forward':
533
            iter_revs = _rebase_merge_depth(reverse_by_depth(list(iter_revs)))
534
    return iter_revs
4202.2.1 by Ian Clatworthy
get directory logging working again
535
536
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
537
def _generate_one_revision(branch, rev_id, br_rev_id, br_revno):
4202.2.1 by Ian Clatworthy
get directory logging working again
538
    if rev_id == br_rev_id:
539
        # It's the tip
540
        return [(br_rev_id, br_revno, 0)]
541
    else:
542
        revno = branch.revision_id_to_dotted_revno(rev_id)
543
        revno_str = '.'.join(str(n) for n in revno)
544
        return [(rev_id, revno_str, 0)]
545
546
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
547
def _generate_flat_revisions(branch, start_rev_id, end_rev_id, direction,
548
                             exclude_common_ancestry=False):
549
    result = _linear_view_revisions(
550
        branch, start_rev_id, end_rev_id,
551
        exclude_common_ancestry=exclude_common_ancestry)
4202.2.1 by Ian Clatworthy
get directory logging working again
552
    # If a start limit was given and it's not obviously an
553
    # ancestor of the end limit, check it before outputting anything
554
    if direction == 'forward' or (start_rev_id
555
        and not _is_obvious_ancestor(branch, start_rev_id, end_rev_id)):
556
        try:
557
            result = list(result)
558
        except _StartNotLinearAncestor:
559
            raise errors.BzrCommandError('Start revision not found in'
560
                ' left-hand history of end revision.')
561
    return result
562
563
564
def _generate_all_revisions(branch, start_rev_id, end_rev_id, direction,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
565
                            delayed_graph_generation,
566
                            exclude_common_ancestry=False):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
567
    # On large trees, generating the merge graph can take 30-60 seconds
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
568
    # so we delay doing it until a merge is detected, incrementally
4955.7.5 by Vincent Ladeuil
Fixed as per Ian's review.
569
    # returning initial (non-merge) revisions while we can.
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
570
571
    # The above is only true for old formats (<= 0.92), for newer formats, a
572
    # couple of seconds only should be needed to load the whole graph and the
573
    # other graph operations needed are even faster than that -- vila 100201
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
574
    initial_revisions = []
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
575
    if delayed_graph_generation:
576
        try:
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
577
            for rev_id, revno, depth in  _linear_view_revisions(
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
578
                branch, start_rev_id, end_rev_id, exclude_common_ancestry):
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
579
                if _has_merges(branch, rev_id):
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
580
                    # The end_rev_id can be nested down somewhere. We need an
581
                    # explicit ancestry check. There is an ambiguity here as we
582
                    # may not raise _StartNotLinearAncestor for a revision that
583
                    # is an ancestor but not a *linear* one. But since we have
584
                    # loaded the graph to do the check (or calculate a dotted
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
585
                    # revno), we may as well accept to show the log...  We need
586
                    # the check only if start_rev_id is not None as all
587
                    # revisions have _mod_revision.NULL_REVISION as an ancestor
588
                    # -- vila 20100319
4955.7.3 by Vincent Ladeuil
Check ancestry so we don't output random revisions.
589
                    graph = branch.repository.get_graph()
5092.1.4 by Vincent Ladeuil
Fixed as per Andrew's review.
590
                    if (start_rev_id is not None
591
                        and not graph.is_ancestor(start_rev_id, end_rev_id)):
592
                        raise _StartNotLinearAncestor()
5097.1.1 by Vincent Ladeuil
Reduce duplication.
593
                    # Since we collected the revisions so far, we need to
594
                    # adjust end_rev_id.
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
595
                    end_rev_id = rev_id
596
                    break
597
                else:
598
                    initial_revisions.append((rev_id, revno, depth))
599
            else:
600
                # No merged revisions found
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
601
                return initial_revisions
3936.3.37 by Ian Clatworthy
selectively delay graph generation, not always
602
        except _StartNotLinearAncestor:
603
            # A merge was never detected so the lower revision limit can't
604
            # be nested down somewhere
605
            raise errors.BzrCommandError('Start revision not found in'
606
                ' history of end revision.')
3936.3.15 by Ian Clatworthy
faster long log for a limited range with no merges
607
5097.1.1 by Vincent Ladeuil
Reduce duplication.
608
    # We exit the loop above because we encounter a revision with merges, from
609
    # this revision, we need to switch to _graph_view_revisions.
610
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
611
    # A log including nested merges is required. If the direction is reverse,
612
    # we rebase the initial merge depths so that the development line is
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
613
    # shown naturally, i.e. just like it is for linear logging. We can easily
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
614
    # make forward the exact opposite display, but showing the merge revisions
615
    # indented at the end seems slightly nicer in that case.
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
616
    view_revisions = chain(iter(initial_revisions),
617
        _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
618
                              rebase_initial_depths=(direction == 'reverse'),
619
                              exclude_common_ancestry=exclude_common_ancestry))
620
    return view_revisions
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
621
530 by Martin Pool
- put back verbose log support for reversed logs
622
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
623
def _has_merges(branch, rev_id):
624
    """Does a revision have multiple parents or not?"""
3936.3.40 by Ian Clatworthy
review feedback from jam
625
    parents = branch.repository.get_parent_map([rev_id]).get(rev_id, [])
626
    return len(parents) > 1
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
627
628
3936.3.31 by Ian Clatworthy
nicer obvious ancestor checking
629
def _is_obvious_ancestor(branch, start_rev_id, end_rev_id):
630
    """Is start_rev_id an obvious ancestor of end_rev_id?"""
631
    if start_rev_id and end_rev_id:
632
        start_dotted = branch.revision_id_to_dotted_revno(start_rev_id)
633
        end_dotted = branch.revision_id_to_dotted_revno(end_rev_id)
634
        if len(start_dotted) == 1 and len(end_dotted) == 1:
635
            # both on mainline
636
            return start_dotted[0] <= end_dotted[0]
637
        elif (len(start_dotted) == 3 and len(end_dotted) == 3 and
638
            start_dotted[0:1] == end_dotted[0:1]):
639
            # both on same development line
640
            return start_dotted[2] <= end_dotted[2]
641
        else:
642
            # not obvious
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
643
            return False
4955.5.3 by Vincent Ladeuil
Cleanup.
644
    # if either start or end is not specified then we use either the first or
645
    # the last revision and *they* are obvious ancestors.
3936.3.18 by Ian Clatworthy
faster incremental results for FILE logging
646
    return True
647
648
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
649
def _linear_view_revisions(branch, start_rev_id, end_rev_id,
650
                           exclude_common_ancestry=False):
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
651
    """Calculate a sequence of revisions to view, newest to oldest.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
652
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
653
    :param start_rev_id: the lower revision-id
654
    :param end_rev_id: the upper revision-id
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
655
    :param exclude_common_ancestry: Whether the start_rev_id should be part of
656
        the iterated revisions.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
657
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
658
    :raises _StartNotLinearAncestor: if a start_rev_id is specified but
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
659
        is not found walking the left-hand history
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
660
    """
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
661
    br_revno, br_rev_id = branch.last_revision_info()
3943.4.5 by John Arbash Meinel
Restore _linear_view_revisions.
662
    repo = branch.repository
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
663
    if start_rev_id is None and end_rev_id is None:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
664
        cur_revno = br_revno
665
        for revision_id in repo.iter_reverse_revision_history(br_rev_id):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
666
            yield revision_id, str(cur_revno), 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
667
            cur_revno -= 1
3936.3.14 by Ian Clatworthy
bug fix
668
    else:
669
        if end_rev_id is None:
670
            end_rev_id = br_rev_id
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
671
        found_start = start_rev_id is None
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
672
        for revision_id in repo.iter_reverse_revision_history(end_rev_id):
3936.3.26 by Ian Clatworthy
use new dotted-revno-revision-id conversion methods to simplify & speed up code
673
            revno = branch.revision_id_to_dotted_revno(revision_id)
674
            revno_str = '.'.join(str(n) for n in revno)
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
675
            if not found_start and revision_id == start_rev_id:
5268.4.3 by Vincent Ladeuil
Respect --exclude-common-ancestry for linear ancestries.
676
                if not exclude_common_ancestry:
677
                    yield revision_id, revno_str, 0
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
678
                found_start = True
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
679
                break
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
680
            else:
681
                yield revision_id, revno_str, 0
3936.3.6 by Ian Clatworthy
add & use _NonMainlineRevisionLimit exception
682
        else:
3936.3.12 by Ian Clatworthy
more single revision & sequence tuning
683
            if not found_start:
684
                raise _StartNotLinearAncestor()
3302.1.3 by Aaron Bentley
Add optimization of the simple case of generating view revisions
685
686
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
687
def _graph_view_revisions(branch, start_rev_id, end_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
688
                          rebase_initial_depths=True,
689
                          exclude_common_ancestry=False):
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
690
    """Calculate revisions to view including merges, newest to oldest.
691
692
    :param branch: the branch
3936.3.32 by Ian Clatworthy
always delay merge graph generation until necessary
693
    :param start_rev_id: the lower revision-id
694
    :param end_rev_id: the upper revision-id
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
695
    :param rebase_initial_depth: should depths be rebased until a mainline
696
      revision is found?
697
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples.
698
    """
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
699
    if exclude_common_ancestry:
700
        stop_rule = 'with-merges-without-common-ancestry'
701
    else:
702
        stop_rule = 'with-merges'
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
703
    view_revisions = branch.iter_merge_sorted_revisions(
704
        start_revision_id=end_rev_id, stop_revision_id=start_rev_id,
5097.1.12 by Vincent Ladeuil
Implement the --exclude-common-ancestry log option.
705
        stop_rule=stop_rule)
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
706
    if not rebase_initial_depths:
707
        for (rev_id, merge_depth, revno, end_of_merge
708
             ) in view_revisions:
709
            yield rev_id, '.'.join(map(str, revno)), merge_depth
710
    else:
711
        # We're following a development line starting at a merged revision.
712
        # We need to adjust depths down by the initial depth until we find
713
        # a depth less than it. Then we use that depth as the adjustment.
714
        # If and when we reach the mainline, depth adjustment ends.
715
        depth_adjustment = None
716
        for (rev_id, merge_depth, revno, end_of_merge
717
             ) in view_revisions:
718
            if depth_adjustment is None:
719
                depth_adjustment = merge_depth
720
            if depth_adjustment:
721
                if merge_depth < depth_adjustment:
4955.5.3 by Vincent Ladeuil
Cleanup.
722
                    # From now on we reduce the depth adjustement, this can be
723
                    # surprising for users. The alternative requires two passes
724
                    # which breaks the fast display of the first revision
725
                    # though.
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
726
                    depth_adjustment = merge_depth
727
                merge_depth -= depth_adjustment
728
            yield rev_id, '.'.join(map(str, revno)), merge_depth
729
730
4955.4.14 by Vincent Ladeuil
Properly deprecate log.calculate_view_revisions.
731
@deprecated_function(deprecated_in((2, 2, 0)))
3936.3.13 by Ian Clatworthy
feedback from jameinel
732
def calculate_view_revisions(branch, start_revision, end_revision, direction,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
733
        specific_fileid, generate_merge_revisions):
3936.3.13 by Ian Clatworthy
feedback from jameinel
734
    """Calculate the revisions to view.
735
736
    :return: An iterator of (revision_id, dotted_revno, merge_depth) tuples OR
737
             a list of the same tuples.
738
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
739
    start_rev_id, end_rev_id = _get_revision_limits(branch, start_revision,
740
        end_revision)
741
    view_revisions = list(_calc_view_revisions(branch, start_rev_id, end_rev_id,
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
742
        direction, generate_merge_revisions or specific_fileid))
3936.3.13 by Ian Clatworthy
feedback from jameinel
743
    if specific_fileid:
744
        view_revisions = _filter_revisions_touching_file_id(branch,
745
            specific_fileid, view_revisions,
746
            include_merges=generate_merge_revisions)
3936.3.28 by Ian Clatworthy
api compatibility: calculate_view_revisions rebases merge depth again
747
    return _rebase_merge_depth(view_revisions)
3936.3.13 by Ian Clatworthy
feedback from jameinel
748
749
3936.3.30 by Ian Clatworthy
use iter_merge_sorted_revisions() with stop_range feature
750
def _rebase_merge_depth(view_revisions):
751
    """Adjust depths upwards so the top level is 0."""
752
    # If either the first or last revision have a merge_depth of 0, we're done
753
    if view_revisions and view_revisions[0][2] and view_revisions[-1][2]:
754
        min_depth = min([d for r,n,d in view_revisions])
755
        if min_depth != 0:
756
            view_revisions = [(r,n,d-min_depth) for r,n,d in view_revisions]
757
    return view_revisions
758
759
3936.3.16 by Ian Clatworthy
use deltas to match files in selected use cases
760
def make_log_rev_iterator(branch, view_revisions, generate_delta, search,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
761
        file_ids=None, direction='reverse'):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
762
    """Create a revision iterator for log.
763
764
    :param branch: The branch being logged.
765
    :param view_revisions: The revisions being viewed.
766
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
767
      Permitted values are None, 'full' and 'partial'.
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
768
    :param search: A user text search string.
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
769
    :param file_ids: If non empty, only revisions matching one or more of
770
      the file-ids are to be kept.
771
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
772
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
773
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
774
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
775
    # Convert view_revisions into (view, None, None) groups to fit with
776
    # the standard interface here.
777
    if type(view_revisions) == list:
3642.1.7 by Robert Collins
Review feedback.
778
        # A single batch conversion is faster than many incremental ones.
779
        # As we have all the data, do a batch conversion.
3642.1.5 by Robert Collins
Separate out batching of revisions.
780
        nones = [None] * len(view_revisions)
781
        log_rev_iterator = iter([zip(view_revisions, nones, nones)])
782
    else:
783
        def _convert():
784
            for view in view_revisions:
785
                yield (view, None, None)
786
        log_rev_iterator = iter([_convert()])
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
787
    for adapter in log_adapters:
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
788
        # It would be nicer if log adapters were first class objects
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
789
        # with custom parameters. This will do for now. IGC 20090127
790
        if adapter == _make_delta_filter:
791
            log_rev_iterator = adapter(branch, generate_delta,
792
                search, log_rev_iterator, file_ids, direction)
793
        else:
794
            log_rev_iterator = adapter(branch, generate_delta,
795
                search, log_rev_iterator)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
796
    return log_rev_iterator
797
798
3642.1.7 by Robert Collins
Review feedback.
799
def _make_search_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
800
    """Create a filtered iterator of log_rev_iterator matching on a regex.
801
802
    :param branch: The branch being logged.
803
    :param generate_delta: Whether to generate a delta for each revision.
804
    :param search: A user text search string.
805
    :param log_rev_iterator: An input iterator containing all revisions that
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
806
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
807
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
808
        delta).
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
809
    """
810
    if search is None:
811
        return log_rev_iterator
5326.2.1 by Parth Malwankar
added InvalidPattern error.
812
    searchRE = re.compile(search, re.IGNORECASE)
3642.1.1 by Robert Collins
Refactoring in log towards more pluggable revision selection.
813
    return _filter_message_re(searchRE, log_rev_iterator)
814
815
816
def _filter_message_re(searchRE, log_rev_iterator):
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
817
    for revs in log_rev_iterator:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
818
        new_revs = []
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
819
        for (rev_id, revno, merge_depth), rev, delta in revs:
820
            if searchRE.search(rev.message):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
821
                new_revs.append(((rev_id, revno, merge_depth), rev, delta))
822
        yield new_revs
823
824
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
825
def _make_delta_filter(branch, generate_delta, search, log_rev_iterator,
826
    fileids=None, direction='reverse'):
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
827
    """Add revision deltas to a log iterator if needed.
828
829
    :param branch: The branch being logged.
830
    :param generate_delta: Whether to generate a delta for each revision.
4202.2.1 by Ian Clatworthy
get directory logging working again
831
      Permitted values are None, 'full' and 'partial'.
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
832
    :param search: A user text search string.
833
    :param log_rev_iterator: An input iterator containing all revisions that
834
        could be displayed, in lists.
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
835
    :param fileids: If non empty, only revisions matching one or more of
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
836
      the file-ids are to be kept.
837
    :param direction: the direction in which view_revisions is sorted
3642.1.7 by Robert Collins
Review feedback.
838
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
839
        delta).
840
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
841
    if not generate_delta and not fileids:
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
842
        return log_rev_iterator
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
843
    return _generate_deltas(branch.repository, log_rev_iterator,
844
        generate_delta, fileids, direction)
845
846
4202.2.1 by Ian Clatworthy
get directory logging working again
847
def _generate_deltas(repository, log_rev_iterator, delta_type, fileids,
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
848
    direction):
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
849
    """Create deltas for each batch of revisions in log_rev_iterator.
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
850
3936.3.36 by Ian Clatworthy
minor comment polish & refactoring
851
    If we're only generating deltas for the sake of filtering against
852
    file-ids, we stop generating deltas once all file-ids reach the
853
    appropriate life-cycle point. If we're receiving data newest to
854
    oldest, then that life-cycle point is 'add', otherwise it's 'remove'.
855
    """
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
856
    check_fileids = fileids is not None and len(fileids) > 0
857
    if check_fileids:
858
        fileid_set = set(fileids)
859
        if direction == 'reverse':
860
            stop_on = 'add'
861
        else:
862
            stop_on = 'remove'
863
    else:
864
        fileid_set = None
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
865
    for revs in log_rev_iterator:
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
866
        # If we were matching against fileids and we've run out,
3936.3.40 by Ian Clatworthy
review feedback from jam
867
        # there's nothing left to do
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
868
        if check_fileids and not fileid_set:
3936.3.40 by Ian Clatworthy
review feedback from jam
869
            return
3642.1.3 by Robert Collins
Split out delta generation from revision content reading, and structure it after message evaluation, increasing performance of log -v -m.
870
        revisions = [rev[1] for rev in revs]
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
871
        new_revs = []
4202.2.1 by Ian Clatworthy
get directory logging working again
872
        if delta_type == 'full' and not check_fileids:
873
            deltas = repository.get_deltas_for_revisions(revisions)
874
            for rev, delta in izip(revs, deltas):
875
                new_revs.append((rev[0], rev[1], delta))
876
        else:
877
            deltas = repository.get_deltas_for_revisions(revisions, fileid_set)
878
            for rev, delta in izip(revs, deltas):
879
                if check_fileids:
880
                    if delta is None or not delta.has_changed():
881
                        continue
882
                    else:
883
                        _update_fileids(delta, fileid_set, stop_on)
884
                        if delta_type is None:
885
                            delta = None
886
                        elif delta_type == 'full':
887
                            # If the file matches all the time, rebuilding
888
                            # a full delta like this in addition to a partial
4202.2.4 by Ian Clatworthy
comment tweak from vila's review
889
                            # one could be slow. However, it's likely that
4202.2.1 by Ian Clatworthy
get directory logging working again
890
                            # most revisions won't get this far, making it
891
                            # faster to filter on the partial deltas and
892
                            # build the occasional full delta than always
893
                            # building full deltas and filtering those.
894
                            rev_id = rev[0][0]
895
                            delta = repository.get_revision_delta(rev_id)
896
                new_revs.append((rev[0], rev[1], delta))
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
897
        yield new_revs
898
899
4202.2.1 by Ian Clatworthy
get directory logging working again
900
def _update_fileids(delta, fileids, stop_on):
901
    """Update the set of file-ids to search based on file lifecycle events.
902
    
903
    :param fileids: a set of fileids to update
3936.3.33 by Ian Clatworthy
only generate deltas for file matching as long as necessary
904
    :param stop_on: either 'add' or 'remove' - take file-ids out of the
905
      fileids set once their add or remove entry is detected respectively
906
    """
4202.2.1 by Ian Clatworthy
get directory logging working again
907
    if stop_on == 'add':
908
        for item in delta.added:
909
            if item[1] in fileids:
910
                fileids.remove(item[1])
911
    elif stop_on == 'delete':
912
        for item in delta.removed:
913
            if item[1] in fileids:
914
                fileids.remove(item[1])
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
915
916
3642.1.7 by Robert Collins
Review feedback.
917
def _make_revision_objects(branch, generate_delta, search, log_rev_iterator):
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
918
    """Extract revision objects from the repository
919
920
    :param branch: The branch being logged.
921
    :param generate_delta: Whether to generate a delta for each revision.
922
    :param search: A user text search string.
923
    :param log_rev_iterator: An input iterator containing all revisions that
924
        could be displayed, in lists.
3642.1.7 by Robert Collins
Review feedback.
925
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
926
        delta).
927
    """
3642.1.5 by Robert Collins
Separate out batching of revisions.
928
    repository = branch.repository
3642.1.4 by Robert Collins
Factor out revision object extraction from revision batching.
929
    for revs in log_rev_iterator:
930
        # r = revision_id, n = revno, d = merge depth
931
        revision_ids = [view[0] for view, _, _ in revs]
932
        revisions = repository.get_revisions(revision_ids)
933
        revs = [(rev[0], revision, rev[2]) for rev, revision in
934
            izip(revs, revisions)]
935
        yield revs
936
937
3642.1.7 by Robert Collins
Review feedback.
938
def _make_batch_filter(branch, generate_delta, search, log_rev_iterator):
3642.1.5 by Robert Collins
Separate out batching of revisions.
939
    """Group up a single large batch into smaller ones.
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
940
941
    :param branch: The branch being logged.
942
    :param generate_delta: Whether to generate a delta for each revision.
943
    :param search: A user text search string.
3642.1.5 by Robert Collins
Separate out batching of revisions.
944
    :param log_rev_iterator: An input iterator containing all revisions that
945
        could be displayed, in lists.
3874.2.4 by Vincent Ladeuil
Fix too long lines.
946
    :return: An iterator over lists of ((rev_id, revno, merge_depth), rev,
947
        delta).
3642.1.2 by Robert Collins
Setup a log iterator that more closely matches what the code tries to do with repository operations.
948
    """
949
    repository = branch.repository
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
950
    num = 9
3642.1.5 by Robert Collins
Separate out batching of revisions.
951
    for batch in log_rev_iterator:
952
        batch = iter(batch)
953
        while True:
954
            step = [detail for _, detail in zip(range(num), batch)]
955
            if len(step) == 0:
956
                break
957
            yield step
958
            num = min(int(num * 1.5), 200)
3302.1.1 by Aaron Bentley
Split out _iter_revision, allow view_revisions to be an iterator
959
960
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
961
def _get_revision_limits(branch, start_revision, end_revision):
962
    """Get and check revision limits.
963
4032.1.1 by John Arbash Meinel
Merge the removal of all trailing whitespace, and resolve conflicts.
964
    :param  branch: The branch containing the revisions.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
965
966
    :param  start_revision: The first revision to be logged.
967
            For backwards compatibility this may be a mainline integer revno,
968
            but for merge revision support a RevisionInfo is expected.
969
970
    :param  end_revision: The last revision to be logged.
971
            For backwards compatibility this may be a mainline integer revno,
972
            but for merge revision support a RevisionInfo is expected.
973
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
974
    :return: (start_rev_id, end_rev_id) tuple.
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
975
    """
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
976
    branch_revno, branch_rev_id = branch.last_revision_info()
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
977
    start_rev_id = None
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
978
    if start_revision is None:
979
        start_revno = 1
980
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
981
        if isinstance(start_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
982
            start_rev_id = start_revision.rev_id
983
            start_revno = start_revision.revno or 1
984
        else:
985
            branch.check_real_revno(start_revision)
986
            start_revno = start_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
987
            start_rev_id = branch.get_rev_id(start_revno)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
988
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
989
    end_rev_id = None
990
    if end_revision is None:
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
991
        end_revno = branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
992
    else:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
993
        if isinstance(end_revision, revisionspec.RevisionInfo):
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
994
            end_rev_id = end_revision.rev_id
3449.2.5 by John Arbash Meinel
Stop referencing the variable I removed.
995
            end_revno = end_revision.revno or branch_revno
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
996
        else:
997
            branch.check_real_revno(end_revision)
998
            end_revno = end_revision
3936.3.25 by Ian Clatworthy
fix bug when start/end revision are integers
999
            end_rev_id = branch.get_rev_id(end_revno)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1000
3936.3.4 by Ian Clatworthy
fix empty_branch log
1001
    if branch_revno != 0:
1002
        if (start_rev_id == _mod_revision.NULL_REVISION
1003
            or end_rev_id == _mod_revision.NULL_REVISION):
1004
            raise errors.BzrCommandError('Logging revision 0 is invalid.')
1005
        if start_revno > end_revno:
1006
            raise errors.BzrCommandError("Start revision must be older than "
1007
                                         "the end revision.")
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1008
    return (start_rev_id, end_rev_id)
1009
1010
1011
def _get_mainline_revs(branch, start_revision, end_revision):
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1012
    """Get the mainline revisions from the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1013
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1014
    Generates the list of mainline revisions for the branch.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1015
1016
    :param  branch: The branch containing the revisions.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1017
1018
    :param  start_revision: The first revision to be logged.
1019
            For backwards compatibility this may be a mainline integer revno,
1020
            but for merge revision support a RevisionInfo is expected.
1021
1022
    :param  end_revision: The last revision to be logged.
1023
            For backwards compatibility this may be a mainline integer revno,
1024
            but for merge revision support a RevisionInfo is expected.
1025
1026
    :return: A (mainline_revs, rev_nos, start_rev_id, end_rev_id) tuple.
3936.3.3 by Ian Clatworthy
add --strict and more refactoring
1027
    """
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1028
    branch_revno, branch_last_revision = branch.last_revision_info()
1029
    if branch_revno == 0:
1030
        return None, None, None, None
1031
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1032
    # For mainline generation, map start_revision and end_revision to
1033
    # mainline revnos. If the revision is not on the mainline choose the
1034
    # appropriate extreme of the mainline instead - the extra will be
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1035
    # filtered later.
1036
    # Also map the revisions to rev_ids, to be used in the later filtering
1037
    # stage.
1038
    start_rev_id = None
1039
    if start_revision is None:
1040
        start_revno = 1
1041
    else:
1042
        if isinstance(start_revision, revisionspec.RevisionInfo):
1043
            start_rev_id = start_revision.rev_id
1044
            start_revno = start_revision.revno or 1
1045
        else:
1046
            branch.check_real_revno(start_revision)
1047
            start_revno = start_revision
1048
1049
    end_rev_id = None
1050
    if end_revision is None:
1051
        end_revno = branch_revno
1052
    else:
1053
        if isinstance(end_revision, revisionspec.RevisionInfo):
1054
            end_rev_id = end_revision.rev_id
1055
            end_revno = end_revision.revno or branch_revno
1056
        else:
1057
            branch.check_real_revno(end_revision)
1058
            end_revno = end_revision
1059
1060
    if ((start_rev_id == _mod_revision.NULL_REVISION)
1061
        or (end_rev_id == _mod_revision.NULL_REVISION)):
1062
        raise errors.BzrCommandError('Logging revision 0 is invalid.')
1063
    if start_revno > end_revno:
1064
        raise errors.BzrCommandError("Start revision must be older than "
1065
                                     "the end revision.")
1066
1067
    if end_revno < start_revno:
1068
        return None, None, None, None
1069
    cur_revno = branch_revno
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1070
    rev_nos = {}
1071
    mainline_revs = []
1072
    for revision_id in branch.repository.iter_reverse_revision_history(
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1073
                        branch_last_revision):
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1074
        if cur_revno < start_revno:
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1075
            # We have gone far enough, but we always add 1 more revision
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1076
            rev_nos[revision_id] = cur_revno
1077
            mainline_revs.append(revision_id)
1078
            break
1079
        if cur_revno <= end_revno:
1080
            rev_nos[revision_id] = cur_revno
1081
            mainline_revs.append(revision_id)
1082
        cur_revno -= 1
3449.2.2 by John Arbash Meinel
Fix bug #172649. Cleanup, and handle the case where we are logging to the first revision.
1083
    else:
1084
        # We walked off the edge of all revisions, so we add a 'None' marker
1085
        mainline_revs.append(None)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1086
3449.2.1 by John Arbash Meinel
bzr uncommit doesn't need to work in terms of 'revision_history()'
1087
    mainline_revs.reverse()
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1088
1089
    # override the mainline to look like the revision history.
3936.3.34 by Ian Clatworthy
return _mainline_revs() API as used in missing.py
1090
    return mainline_revs, rev_nos, start_rev_id, end_rev_id
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1091
1092
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1093
@deprecated_function(deprecated_in((2, 2, 0)))
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1094
def _filter_revision_range(view_revisions, start_rev_id, end_rev_id):
1095
    """Filter view_revisions based on revision ranges.
1096
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1097
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1098
            tuples to be filtered.
1099
1100
    :param start_rev_id: If not NONE specifies the first revision to be logged.
1101
            If NONE then all revisions up to the end_rev_id are logged.
1102
1103
    :param end_rev_id: If not NONE specifies the last revision to be logged.
1104
            If NONE then all revisions up to the end of the log are logged.
1105
1106
    :return: The filtered view_revisions.
1107
    """
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1108
    if start_rev_id or end_rev_id:
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1109
        revision_ids = [r for r, n, d in view_revisions]
1110
        if start_rev_id:
1111
            start_index = revision_ids.index(start_rev_id)
1112
        else:
1113
            start_index = 0
1114
        if start_rev_id == end_rev_id:
1115
            end_index = start_index
1116
        else:
1117
            if end_rev_id:
1118
                end_index = revision_ids.index(end_rev_id)
1119
            else:
1120
                end_index = len(view_revisions) - 1
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1121
        # To include the revisions merged into the last revision,
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1122
        # extend end_rev_id down to, but not including, the next rev
1123
        # with the same or lesser merge_depth
1124
        end_merge_depth = view_revisions[end_index][2]
1125
        try:
1126
            for index in xrange(end_index+1, len(view_revisions)+1):
1127
                if view_revisions[index][2] <= end_merge_depth:
1128
                    end_index = index - 1
1129
                    break
1130
        except IndexError:
1131
            # if the search falls off the end then log to the end as well
1132
            end_index = len(view_revisions) - 1
1133
        view_revisions = view_revisions[start_index:end_index+1]
1134
    return view_revisions
1135
1136
3940.1.3 by Ian Clatworthy
fix code
1137
def _filter_revisions_touching_file_id(branch, file_id, view_revisions,
1138
    include_merges=True):
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1139
    r"""Return the list of revision ids which touch a given file id.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1140
2466.12.1 by Kent Gibson
Fix ``bzr log -r`` to support selecting merge revisions.
1141
    The function filters view_revisions and returns a subset.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1142
    This includes the revisions which directly change the file id,
1143
    and the revisions which merge these changes. So if the
1144
    revision graph is::
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1145
        A-.
1146
        |\ \
1147
        B C E
1148
        |/ /
1149
        D |
1150
        |\|
1151
        | F
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1152
        |/
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1153
        G
1154
1155
    And 'C' changes a file, then both C and D will be returned. F will not be
1156
    returned even though it brings the changes to C into the branch starting
1157
    with E. (Note that if we were using F as the tip instead of G, then we
1158
    would see C, D, F.)
1159
1160
    This will also be restricted based on a subset of the mainline.
1161
1162
    :param branch: The branch where we can get text revision information.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1163
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1164
    :param file_id: Filter out revisions that do not touch file_id.
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1165
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1166
    :param view_revisions: A list of (revision_id, dotted_revno, merge_depth)
1167
        tuples. This is the list of revisions which will be filtered. It is
3842.2.5 by Vincent Ladeuil
Better fix for bug #300055.
1168
        assumed that view_revisions is in merge_sort order (i.e. newest
1169
        revision first ).
1170
3940.1.3 by Ian Clatworthy
fix code
1171
    :param include_merges: include merge revisions in the result or not
1172
2359.1.8 by John Arbash Meinel
doc
1173
    :return: A list of (revision_id, dotted_revno, merge_depth) tuples.
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1174
    """
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1175
    # Lookup all possible text keys to determine which ones actually modified
1176
    # the file.
1177
    text_keys = [(file_id, rev_id) for rev_id, revno, depth in view_revisions]
4183.3.1 by Vincent Ladeuil
Fix bug #346431 by allowing log._filter_revisions_touching_file_id to be
1178
    next_keys = None
3711.3.16 by John Arbash Meinel
Doc update.
1179
    # Looking up keys in batches of 1000 can cut the time in half, as well as
1180
    # memory consumption. GraphIndex *does* like to look for a few keys in
1181
    # parallel, it just doesn't like looking for *lots* of keys in parallel.
3711.3.19 by John Arbash Meinel
Add a TODO discussing how our index requests should evolve.
1182
    # TODO: This code needs to be re-evaluated periodically as we tune the
1183
    #       indexing layer. We might consider passing in hints as to the known
1184
    #       access pattern (sparse/clustered, high success rate/low success
1185
    #       rate). This particular access is clustered with a low success rate.
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1186
    get_parent_map = branch.repository.texts.get_parent_map
1187
    modified_text_revisions = set()
1188
    chunk_size = 1000
1189
    for start in xrange(0, len(text_keys), chunk_size):
1190
        next_keys = text_keys[start:start + chunk_size]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1191
        # Only keep the revision_id portion of the key
3711.3.15 by John Arbash Meinel
Work around GraphIndex inefficiencies by requesting keys 1000 at a time.
1192
        modified_text_revisions.update(
1193
            [k[1] for k in get_parent_map(next_keys)])
1194
    del text_keys, next_keys
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1195
1196
    result = []
1197
    # Track what revisions will merge the current revision, replace entries
1198
    # with 'None' when they have been added to result
1199
    current_merge_stack = [None]
3711.3.23 by John Arbash Meinel
Documentation and cleanup.
1200
    for info in view_revisions:
3711.3.14 by John Arbash Meinel
Change the per-file log algorithm dramatically.
1201
        rev_id, revno, depth = info
1202
        if depth == len(current_merge_stack):
1203
            current_merge_stack.append(info)
1204
        else:
1205
            del current_merge_stack[depth + 1:]
1206
            current_merge_stack[-1] = info
1207
1208
        if rev_id in modified_text_revisions:
1209
            # This needs to be logged, along with the extra revisions
1210
            for idx in xrange(len(current_merge_stack)):
1211
                node = current_merge_stack[idx]
1212
                if node is not None:
3940.1.3 by Ian Clatworthy
fix code
1213
                    if include_merges or node[2] == 0:
1214
                        result.append(node)
1215
                        current_merge_stack[idx] = None
3711.3.4 by John Arbash Meinel
Significantly faster, but consuming more memory.
1216
    return result
2359.1.4 by John Arbash Meinel
Refactor the specific revisions for file id into a helper function.
1217
1218
4955.4.20 by Vincent Ladeuil
Properly deprecate dead code.
1219
@deprecated_function(deprecated_in((2, 2, 0)))
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1220
def get_view_revisions(mainline_revs, rev_nos, branch, direction,
1756.2.22 by Aaron Bentley
Apply review comments
1221
                       include_merges=True):
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1222
    """Produce an iterator of revisions to show
1223
    :return: an iterator of (revision_id, revno, merge_depth)
1224
    (if there is no revno for a revision, None is supplied)
1225
    """
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1226
    if not include_merges:
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1227
        revision_ids = mainline_revs[1:]
1228
        if direction == 'reverse':
1229
            revision_ids.reverse()
1230
        for revision_id in revision_ids:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1231
            yield revision_id, str(rev_nos[revision_id]), 0
1756.2.20 by Aaron Bentley
Optimize log formats that don't show merges
1232
        return
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1233
    graph = branch.repository.get_graph()
1234
    # This asks for all mainline revisions, which means we only have to spider
1235
    # sideways, rather than depth history. That said, its still size-of-history
1236
    # and should be addressed.
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1237
    # mainline_revisions always includes an extra revision at the beginning, so
1238
    # don't request it.
3287.6.8 by Robert Collins
Reduce code duplication as per review.
1239
    parent_map = dict(((key, value) for key, value in
3373.5.4 by John Arbash Meinel
Track down another bogus location. Only triggered with --long
1240
        graph.iter_ancestry(mainline_revs[1:]) if value is not None))
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1241
    # filter out ghosts; merge_sort errors on ghosts.
3535.5.1 by John Arbash Meinel
cleanup a few imports to be lazily loaded.
1242
    rev_graph = _mod_repository._strip_NULL_ghosts(parent_map)
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1243
    merge_sorted_revisions = tsort.merge_sort(
3287.6.1 by Robert Collins
* ``VersionedFile.get_graph`` is deprecated, with no replacement method.
1244
        rev_graph,
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1245
        mainline_revs[-1],
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1246
        mainline_revs,
1247
        generate_revno=True)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1248
1249
    if direction == 'forward':
1250
        # forward means oldest first.
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1251
        merge_sorted_revisions = reverse_by_depth(merge_sorted_revisions)
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1252
    elif direction != 'reverse':
1253
        raise ValueError('invalid direction %r' % direction)
1254
3874.2.4 by Vincent Ladeuil
Fix too long lines.
1255
    for (sequence, rev_id, merge_depth, revno, end_of_merge
1256
         ) in merge_sorted_revisions:
1988.4.2 by Robert Collins
``bzr log`` Now shows dotted-decimal revision numbers for all revisions,
1257
        yield rev_id, '.'.join(map(str, revno)), merge_depth
1756.2.18 by Aaron Bentley
Factor out the revision list generation
1258
1259
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1260
def reverse_by_depth(merge_sorted_revisions, _depth=0):
1261
    """Reverse revisions by depth.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1262
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1263
    Revisions with a different depth are sorted as a group with the previous
1264
    revision of that depth.  There may be no topological justification for this,
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1265
    but it looks much nicer.
1266
    """
3842.2.6 by Vincent Ladeuil
Fix typo.
1267
    # Add a fake revision at start so that we can always attach sub revisions
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1268
    merge_sorted_revisions = [(None, None, _depth)] + merge_sorted_revisions
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1269
    zd_revisions = []
1270
    for val in merge_sorted_revisions:
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1271
        if val[2] == _depth:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1272
            # Each revision at the current depth becomes a chunk grouping all
1273
            # higher depth revisions.
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1274
            zd_revisions.append([val])
1275
        else:
1276
            zd_revisions[-1].append(val)
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1277
    for revisions in zd_revisions:
1278
        if len(revisions) > 1:
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1279
            # We have higher depth revisions, let reverse them locally
1756.2.25 by Aaron Bentley
Sort revisions at each depth, instead of just mainline revisions.
1280
            revisions[1:] = reverse_by_depth(revisions[1:], _depth + 1)
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1281
    zd_revisions.reverse()
1282
    result = []
1283
    for chunk in zd_revisions:
1284
        result.extend(chunk)
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1285
    if _depth == 0:
1286
        # Top level call, get rid of the fake revisions that have been added
1287
        result = [r for r in result if r[0] is not None and r[1] is not None]
1756.2.24 by Aaron Bentley
Forward sorting shows merges under mainline revision
1288
    return result
1289
1290
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1291
class LogRevision(object):
1292
    """A revision to be logged (by LogFormatter.log_revision).
1293
1294
    A simple wrapper for the attributes of a revision to be logged.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1295
    The attributes may or may not be populated, as determined by the
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1296
    logging options and the log formatter capabilities.
1297
    """
1298
2490.1.2 by John Arbash Meinel
Cleanup according to PEP8 and some other small whitespace fixes
1299
    def __init__(self, rev=None, revno=None, merge_depth=0, delta=None,
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1300
                 tags=None, diff=None):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1301
        self.rev = rev
3936.3.39 by Ian Clatworthy
merge bzr.dev r3975
1302
        self.revno = str(revno)
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1303
        self.merge_depth = merge_depth
1304
        self.delta = delta
1305
        self.tags = tags
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1306
        self.diff = diff
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1307
1308
794 by Martin Pool
- Merge John's nice short-log format.
1309
class LogFormatter(object):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1310
    """Abstract class to display log messages.
1311
1312
    At a minimum, a derived class must implement the log_revision method.
1313
1314
    If the LogFormatter needs to be informed of the beginning or end of
1315
    a log it should implement the begin_log and/or end_log hook methods.
1316
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1317
    A LogFormatter should define the following supports_XXX flags
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1318
    to indicate which LogRevision attributes it supports:
1319
1320
    - supports_delta must be True if this log formatter supports delta.
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1321
        Otherwise the delta attribute may not be populated.  The 'delta_format'
1322
        attribute describes whether the 'short_status' format (1) or the long
3936.3.2 by Ian Clatworthy
minor cleanups
1323
        one (2) should be used.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1324
1325
    - supports_merge_revisions must be True if this log formatter supports
4215.1.1 by Ian Clatworthy
remove supports_single_merge_revision
1326
        merge revisions.  If not, then only mainline revisions will be passed
1327
        to the formatter.
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1328
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1329
    - preferred_levels is the number of levels this formatter defaults to.
1330
        The default value is zero meaning display all levels.
1331
        This value is only relevant if supports_merge_revisions is True.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1332
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1333
    - supports_tags must be True if this log formatter supports tags.
1334
        Otherwise the tags attribute may not be populated.
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1335
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1336
    - supports_diff must be True if this log formatter supports diffs.
1337
        Otherwise the diff attribute may not be populated.
1338
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1339
    Plugins can register functions to show custom revision properties using
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1340
    the properties_handler_registry. The registered function
3144.7.1 by Guillermo Gonzalez
* added show_properties to LonLogFormat and the hooks to register custom functions
1341
    must respect the following interface description:
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1342
        def my_show_properties(properties_dict):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1343
            # code that returns a dict {'name':'value'} of the properties
3144.7.2 by Guillermo Gonzalez
* cleanup a bit the interface
1344
            # to be shown
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1345
    """
3947.1.10 by Ian Clatworthy
review feedback from vila
1346
    preferred_levels = 0
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1347
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1348
    def __init__(self, to_file, show_ids=False, show_timezone='original',
4955.4.5 by Vincent Ladeuil
Start reproducing the problems reported in the bug.
1349
                 delta_format=None, levels=None, show_advice=False,
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1350
                 to_exact_file=None, author_list_handler=None):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1351
        """Create a LogFormatter.
1352
1353
        :param to_file: the file to output to
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1354
        :param to_exact_file: if set, gives an output stream to which 
1355
             non-Unicode diffs are written.
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1356
        :param show_ids: if True, revision-ids are to be displayed
1357
        :param show_timezone: the timezone to use
1358
        :param delta_format: the level of delta information to display
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1359
          or None to leave it to the formatter to decide
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1360
        :param levels: the number of levels to display; None or -1 to
1361
          let the log formatter decide.
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1362
        :param show_advice: whether to show advice at the end of the
1363
          log or not
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1364
        :param author_list_handler: callable generating a list of
1365
          authors to display for a given revision
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1366
        """
794 by Martin Pool
- Merge John's nice short-log format.
1367
        self.to_file = to_file
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1368
        # 'exact' stream used to show diff, it should print content 'as is'
1369
        # and should not try to decode/encode it to unicode to avoid bug #328007
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1370
        if to_exact_file is not None:
1371
            self.to_exact_file = to_exact_file
1372
        else:
4792.8.12 by Martin Pool
comment
1373
            # XXX: somewhat hacky; this assumes it's a codec writer; it's better
1374
            # for code that expects to get diffs to pass in the exact file
1375
            # stream
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1376
            self.to_exact_file = getattr(to_file, 'stream', to_file)
794 by Martin Pool
- Merge John's nice short-log format.
1377
        self.show_ids = show_ids
1378
        self.show_timezone = show_timezone
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1379
        if delta_format is None:
1380
            # Ensures backward compatibility
1381
            delta_format = 2 # long format
1382
        self.delta_format = delta_format
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1383
        self.levels = levels
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1384
        self._show_advice = show_advice
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1385
        self._merge_count = 0
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1386
        self._author_list_handler = author_list_handler
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1387
3947.1.10 by Ian Clatworthy
review feedback from vila
1388
    def get_levels(self):
1389
        """Get the number of levels to display or 0 for all."""
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1390
        if getattr(self, 'supports_merge_revisions', False):
1391
            if self.levels is None or self.levels == -1:
4217.2.1 by Ian Clatworthy
fix log advice when the # of levels is implicit
1392
                self.levels = self.preferred_levels
1393
        else:
1394
            self.levels = 1
1395
        return self.levels
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1396
3947.1.10 by Ian Clatworthy
review feedback from vila
1397
    def log_revision(self, revision):
1398
        """Log a revision.
1399
1400
        :param  revision:   The LogRevision to be logged.
1401
        """
1402
        raise NotImplementedError('not implemented in abstract base')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1403
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1404
    def show_advice(self):
1405
        """Output user advice, if any, when the log is completed."""
4221.2.3 by Ian Clatworthy
jam feedback: don't show advice if --levels explicitly given
1406
        if self._show_advice and self.levels == 1 and self._merge_count > 0:
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1407
            advice_sep = self.get_advice_separator()
1408
            if advice_sep:
1409
                self.to_file.write(advice_sep)
4208.2.2 by Ian Clatworthy
show --levels 0 in advice, not just -n0
1410
            self.to_file.write(
4221.2.1 by Ian Clatworthy
--include-merges as an alias for --levels 0 in log
1411
                "Use --include-merges or -n0 to see merged revisions.\n")
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1412
1413
    def get_advice_separator(self):
1414
        """Get the text separating the log from the closing advice."""
1415
        return ''
1416
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1417
    def short_committer(self, rev):
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1418
        name, address = config.parse_username(rev.committer)
1419
        if name:
3063.3.1 by Lukáš Lalinský
Fall back to showing e-mail in ``log --short/--line`` if the committer/author has only e-mail.
1420
            return name
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1421
        return address
2388.1.11 by Alexander Belchenko
changes after John's review
1422
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1423
    def short_author(self, rev):
4081.3.14 by Martin von Gagern
Pass keyword arguments of authors method by name.
1424
        return self.authors(rev, 'first', short=True, sep=', ')
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1425
1426
    def authors(self, rev, who, short=False, sep=None):
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1427
        """Generate list of authors, taking --authors option into account.
1428
1429
        The caller has to specify the name of a author list handler,
1430
        as provided by the author list registry, using the ``who``
1431
        argument.  That name only sets a default, though: when the
1432
        user selected a different author list generation using the
1433
        ``--authors`` command line switch, as represented by the
1434
        ``author_list_handler`` constructor argument, that value takes
1435
        precedence.
1436
1437
        :param rev: The revision for which to generate the list of authors.
1438
        :param who: Name of the default handler.
1439
        :param short: Whether to shorten names to either name or address.
1440
        :param sep: What separator to use for automatic concatenation.
1441
        """
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1442
        if self._author_list_handler is not None:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1443
            # The user did specify --authors, which overrides the default
4081.3.10 by Martin von Gagern
Renamed "authors" to "author_list_handler" in several places.
1444
            author_list_handler = self._author_list_handler
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1445
        else:
4081.3.13 by Martin von Gagern
Added extensive docstring and comments to authors method.
1446
            # The user didn't specify --authors, so we use the caller's default
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1447
            author_list_handler = author_list_registry.get(who)
1448
        names = author_list_handler(rev)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1449
        if short:
1450
            for i in range(len(names)):
1451
                name, address = config.parse_username(names[i])
1452
                if name:
1453
                    names[i] = name
1454
                else:
1455
                    names[i] = address
1456
        if sep is not None:
1457
            names = sep.join(names)
1458
        return names
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1459
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1460
    def merge_marker(self, revision):
4213.1.1 by Ian Clatworthy
merge indicators in log --long (Ian Clatworthy)
1461
        """Get the merge marker to include in the output or '' if none."""
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1462
        if len(revision.rev.parent_ids) > 1:
1463
            self._merge_count += 1
1464
            return ' [merge]'
1465
        else:
1466
            return ''
1467
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
1468
    def show_properties(self, revision, indent):
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1469
        """Displays the custom properties returned by each registered handler.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
1470
3144.7.13 by Guillermo Gonzalez
* fixed typo LogFormatter.show_properties in docstring
1471
        If a registered handler raises an error it is propagated.
3144.7.5 by Guillermo Gonzalez
* some improvements to the doctstring in show_properties method and in LogFormatter
1472
        """
4379.4.1 by Ian Clatworthy
make log --long faster
1473
        for line in self.custom_properties(revision):
1474
            self.to_file.write("%s%s\n" % (indent, line))
1475
1476
    def custom_properties(self, revision):
1477
        """Format the custom properties returned by each registered handler.
1478
1479
        If a registered handler raises an error it is propagated.
1480
1481
        :return: a list of formatted lines (excluding trailing newlines)
1482
        """
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1483
        lines = self._foreign_info_properties(revision)
1484
        for key, handler in properties_handler_registry.iteritems():
1485
            lines.extend(self._format_properties(handler(revision)))
1486
        return lines
1487
1488
    def _foreign_info_properties(self, rev):
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1489
        """Custom log displayer for foreign revision identifiers.
1490
1491
        :param rev: Revision object.
1492
        """
1493
        # Revision comes directly from a foreign repository
1494
        if isinstance(rev, foreign.ForeignRevision):
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
1495
            return self._format_properties(
1496
                rev.mapping.vcs.show_foreign_revid(rev.foreign_revid))
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1497
1498
        # Imported foreign revision revision ids always contain :
1499
        if not ":" in rev.revision_id:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1500
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1501
1502
        # Revision was once imported from a foreign repository
1503
        try:
1504
            foreign_revid, mapping = \
1505
                foreign.foreign_vcs_registry.parse_revision_id(rev.revision_id)
1506
        except errors.InvalidRevisionId:
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1507
            return []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1508
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1509
        return self._format_properties(
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1510
            mapping.vcs.show_foreign_revid(foreign_revid))
1511
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1512
    def _format_properties(self, properties):
4379.4.1 by Ian Clatworthy
make log --long faster
1513
        lines = []
4393.1.2 by Jelmer Vernooij
Move showing of foreign revision info onto log, for better performance.
1514
        for key, value in properties.items():
4379.4.3 by Ian Clatworthy
merge bzr.dev r4426
1515
            lines.append(key + ': ' + value)
4379.4.1 by Ian Clatworthy
make log --long faster
1516
        return lines
3144.7.8 by Guillermo Gonzalez
* added error handling (and logging) to LogFormatter.show_properties when a handler raise an error
1517
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1518
    def show_diff(self, to_file, diff, indent):
1519
        for l in diff.rstrip().split('\n'):
1520
            to_file.write(indent + '%s\n' % (l,))
1521
2388.1.11 by Alexander Belchenko
changes after John's review
1522
4379.4.1 by Ian Clatworthy
make log --long faster
1523
# Separator between revisions in long format
1524
_LONG_SEP = '-' * 60
1525
1526
794 by Martin Pool
- Merge John's nice short-log format.
1527
class LongLogFormatter(LogFormatter):
2388.1.11 by Alexander Belchenko
changes after John's review
1528
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1529
    supports_merge_revisions = True
4206.1.1 by Ian Clatworthy
log mainline by default
1530
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1531
    supports_delta = True
1532
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1533
    supports_diff = True
2388.1.10 by Alexander Belchenko
Slightly reworked: use None instead of [] as default tags list; PEP-8
1534
4379.4.1 by Ian Clatworthy
make log --long faster
1535
    def __init__(self, *args, **kwargs):
1536
        super(LongLogFormatter, self).__init__(*args, **kwargs)
1537
        if self.show_timezone == 'original':
1538
            self.date_string = self._date_string_original_timezone
1539
        else:
1540
            self.date_string = self._date_string_with_timezone
1541
1542
    def _date_string_with_timezone(self, rev):
1543
        return format_date(rev.timestamp, rev.timezone or 0,
1544
                           self.show_timezone)
1545
1546
    def _date_string_original_timezone(self, rev):
1547
        return format_date_with_offset_in_original_timezone(rev.timestamp,
1548
            rev.timezone or 0)
1549
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1550
    def log_revision(self, revision):
1551
        """Log a revision, either merged or not."""
2671.2.5 by Lukáš Lalinský
Fixes for comments from the mailing list.
1552
        indent = '    ' * revision.merge_depth
4379.4.1 by Ian Clatworthy
make log --long faster
1553
        lines = [_LONG_SEP]
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1554
        if revision.revno is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1555
            lines.append('revno: %s%s' % (revision.revno,
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1556
                self.merge_marker(revision)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1557
        if revision.tags:
4379.4.1 by Ian Clatworthy
make log --long faster
1558
            lines.append('tags: %s' % (', '.join(revision.tags)))
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1559
        if self.show_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1560
            lines.append('revision-id: %s' % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1561
            for parent_id in revision.rev.parent_ids:
4379.4.1 by Ian Clatworthy
make log --long faster
1562
                lines.append('parent: %s' % (parent_id,))
1563
        lines.extend(self.custom_properties(revision.rev))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1564
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1565
        committer = revision.rev.committer
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1566
        authors = self.authors(revision.rev, 'all')
4056.2.3 by James Westby
Use a new "authors" revision property to allow multiple authors
1567
        if authors != [committer]:
4379.4.1 by Ian Clatworthy
make log --long faster
1568
            lines.append('author: %s' % (", ".join(authors),))
1569
        lines.append('committer: %s' % (committer,))
2671.2.2 by Lukáš Lalinský
Move setting of the author revision property to MutableTree.commit. Don't use try/except KeyError in LongLogFormatter to display authors and branch-nicks. Removed warning about missing e-mail in the authors name.
1570
1571
        branch_nick = revision.rev.properties.get('branch-nick', None)
1572
        if branch_nick is not None:
4379.4.1 by Ian Clatworthy
make log --long faster
1573
            lines.append('branch nick: %s' % (branch_nick,))
1574
1575
        lines.append('timestamp: %s' % (self.date_string(revision.rev),))
1576
1577
        lines.append('message:')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1578
        if not revision.rev.message:
4379.4.1 by Ian Clatworthy
make log --long faster
1579
            lines.append('  (no message)')
1433 by Robert Collins
merge in and make incremental Gustavo Niemeyers nested log patch, and remove all bare exceptions in store and transport packages.
1580
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1581
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1582
            for l in message.split('\n'):
4379.4.1 by Ian Clatworthy
make log --long faster
1583
                lines.append('  %s' % (l,))
1584
1585
        # Dump the output, appending the delta and diff if requested
1586
        to_file = self.to_file
1587
        to_file.write("%s%s\n" % (indent, ('\n' + indent).join(lines)))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1588
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1589
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1590
            from bzrlib.delta import report_delta
1591
            report_delta(to_file, revision.delta, short_status=False, 
1592
                         show_ids=self.show_ids, indent=indent)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1593
        if revision.diff is not None:
1594
            to_file.write(indent + 'diff:\n')
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1595
            to_file.flush()
3943.5.6 by Ian Clatworthy
feedback from jam's review
1596
            # Note: we explicitly don't indent the diff (relative to the
1597
            # revision information) so that the output can be fed to patch -p0
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1598
            self.show_diff(self.to_exact_file, revision.diff, indent)
4792.8.11 by Martin Pool
Give LogFormatters a second byte output stream for their diffs
1599
            self.to_exact_file.flush()
794 by Martin Pool
- Merge John's nice short-log format.
1600
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1601
    def get_advice_separator(self):
1602
        """Get the text separating the log from the closing advice."""
1603
        return '-' * 60 + '\n'
1604
794 by Martin Pool
- Merge John's nice short-log format.
1605
1606
class ShortLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1607
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1608
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1609
    preferred_levels = 1
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1610
    supports_delta = True
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1611
    supports_tags = True
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1612
    supports_diff = True
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1613
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1614
    def __init__(self, *args, **kwargs):
1615
        super(ShortLogFormatter, self).__init__(*args, **kwargs)
1616
        self.revno_width_by_depth = {}
1617
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1618
    def log_revision(self, revision):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1619
        # We need two indents: one per depth and one for the information
1620
        # relative to that indent. Most mainline revnos are 5 chars or
3970.1.1 by Ian Clatworthy
log -n/--levels (Ian Clatworthy)
1621
        # less while dotted revnos are typically 11 chars or less. Once
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1622
        # calculated, we need to remember the offset for a given depth
1623
        # as we might be starting from a dotted revno in the first column
1624
        # and we want subsequent mainline revisions to line up.
1625
        depth = revision.merge_depth
1626
        indent = '    ' * depth
1627
        revno_width = self.revno_width_by_depth.get(depth)
1628
        if revno_width is None:
1629
            if revision.revno.find('.') == -1:
3947.1.10 by Ian Clatworthy
review feedback from vila
1630
                # mainline revno, e.g. 12345
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1631
                revno_width = 5
1632
            else:
3947.1.10 by Ian Clatworthy
review feedback from vila
1633
                # dotted revno, e.g. 12345.10.55
1634
                revno_width = 11
3947.1.9 by Ian Clatworthy
get offset right when dotted-revno in column 1
1635
            self.revno_width_by_depth[depth] = revno_width
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1636
        offset = ' ' * (revno_width + 1)
1637
794 by Martin Pool
- Merge John's nice short-log format.
1638
        to_file = self.to_file
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1639
        tags = ''
1640
        if revision.tags:
3946.3.2 by Ian Clatworthy
add tests & NEWS item
1641
            tags = ' {%s}' % (', '.join(revision.tags))
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1642
        to_file.write(indent + "%*s %s\t%s%s%s\n" % (revno_width,
1643
                revision.revno, self.short_author(revision.rev),
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1644
                format_date(revision.rev.timestamp,
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1645
                            revision.rev.timezone or 0,
1185.35.19 by Aaron Bentley
Tweaked short-log as Meinel suggested
1646
                            self.show_timezone, date_fmt="%Y-%m-%d",
2483.2.5 by John Arbash Meinel
[merge] bzr.dev 2501
1647
                            show_offset=False),
4208.2.1 by Ian Clatworthy
merge indicators in log --long
1648
                tags, self.merge_marker(revision)))
3976.3.1 by Neil Martinsen-Burrell
Add custom properties handling to short log format
1649
        self.show_properties(revision.rev, indent+offset)
794 by Martin Pool
- Merge John's nice short-log format.
1650
        if self.show_ids:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1651
            to_file.write(indent + offset + 'revision-id:%s\n'
3874.1.4 by Vincent Ladeuil
Fixed as per Aarons' comment.
1652
                          % (revision.rev.revision_id,))
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1653
        if not revision.rev.message:
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1654
            to_file.write(indent + offset + '(no message)\n')
794 by Martin Pool
- Merge John's nice short-log format.
1655
        else:
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1656
            message = revision.rev.message.rstrip('\r\n')
1185.31.20 by John Arbash Meinel
Stripping trailing newlines when displaying log messages
1657
            for l in message.split('\n'):
3947.1.7 by Ian Clatworthy
tweak indenting/offsetting for --short given dotted revno lengths
1658
                to_file.write(indent + offset + '%s\n' % (l,))
794 by Martin Pool
- Merge John's nice short-log format.
1659
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1660
        if revision.delta is not None:
5076.4.2 by Arnaud Jeansen
Create a short show callback using the previously removed short code (it was not dead, only not used by status). Port log to directly call the callbacks.
1661
            # Use the standard status output to display changes
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1662
            from bzrlib.delta import report_delta
5076.4.6 by Arnaud Jeansen
Go back to unified report_delta method (i.e. former TreeDelta.show())
1663
            report_delta(to_file, revision.delta, 
1664
                         short_status=self.delta_format==1, 
5076.4.4 by Arnaud Jeansen
Add a unified report_delta method
1665
                         show_ids=self.show_ids, indent=indent + offset)
3943.5.2 by Ian Clatworthy
hand control of diff formatting to the log formatter
1666
        if revision.diff is not None:
4110.1.1 by Alexander Belchenko
Fixed problem with `log -p` and non-ascii content of files: show_diff should write the diff to exact [stdout] stream.
1667
            self.show_diff(self.to_exact_file, revision.diff, '      ')
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1668
        to_file.write('\n')
794 by Martin Pool
- Merge John's nice short-log format.
1669
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1670
1185.12.25 by Aaron Bentley
Added one-line log format
1671
class LineLogFormatter(LogFormatter):
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1672
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1673
    supports_merge_revisions = True
3947.1.6 by Ian Clatworthy
log -n/--level-count N option
1674
    preferred_levels = 1
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1675
    supports_tags = True
2997.1.1 by Kent Gibson
Support logging single merge revisions with short and line log formatters.
1676
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1677
    def __init__(self, *args, **kwargs):
1678
        super(LineLogFormatter, self).__init__(*args, **kwargs)
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1679
        width = terminal_width()
1680
        if width is not None:
1681
            # we need one extra space for terminals that wrap on last char
1682
            width = width - 1
1683
        self._max_chars = width
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1684
1185.12.25 by Aaron Bentley
Added one-line log format
1685
    def truncate(self, str, max_len):
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1686
        if max_len is None or len(str) <= max_len:
1185.12.25 by Aaron Bentley
Added one-line log format
1687
            return str
4747.3.6 by Vincent Ladeuil
terminal_width can now returns None.
1688
        return str[:max_len-3] + '...'
1185.12.25 by Aaron Bentley
Added one-line log format
1689
1690
    def date_string(self, rev):
3842.2.4 by Vincent Ladeuil
Superficial fix for bug #300055.
1691
        return format_date(rev.timestamp, rev.timezone or 0,
1185.12.25 by Aaron Bentley
Added one-line log format
1692
                           self.show_timezone, date_fmt="%Y-%m-%d",
1693
                           show_offset=False)
1694
1695
    def message(self, rev):
1696
        if not rev.message:
1697
            return '(no message)'
1698
        else:
1699
            return rev.message
1700
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1701
    def log_revision(self, revision):
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1702
        indent = '  ' * revision.merge_depth
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1703
        self.to_file.write(self.log_string(revision.revno, revision.rev,
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1704
            self._max_chars, revision.tags, indent))
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
1705
        self.to_file.write('\n')
2466.8.1 by Kent Gibson
Reworked LogFormatter API to simplify extending the attributes of the revision being logged. Added support for begin_log() and end_log() hooks in LogFormatters.
1706
3947.1.8 by Ian Clatworthy
merge bzr.dev r3954
1707
    def log_string(self, revno, rev, max_chars, tags=None, prefix=''):
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1708
        """Format log info into one string. Truncate tail of string
3677.1.1 by Vincent Ladeuil
Begin fixing bug #233817.
1709
        :param  revno:      revision number or None.
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1710
                            Revision numbers counts from 1.
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1711
        :param  rev:        revision object
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1712
        :param  max_chars:  maximum length of resulting string
3946.3.1 by Ian Clatworthy
extend ShortLogFormatter & LineLogFormatter to support tags
1713
        :param  tags:       list of tags or None
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1714
        :param  prefix:     string to prefix each line
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1715
        :return:            formatted truncated string
1716
        """
1717
        out = []
1718
        if revno:
1719
            # show revno only when is not None
3946.3.4 by Ian Clatworthy
minor cleanup
1720
            out.append("%s:" % revno)
2671.5.4 by Lukáš Lalinsky
Replace the committer with the author in log, the committer is displayed only in the long format and only if it's different from the author.
1721
        out.append(self.truncate(self.short_author(rev), 20))
1185.12.25 by Aaron Bentley
Added one-line log format
1722
        out.append(self.date_string(rev))
3983.2.1 by Neil Martinsen-Burrell
add merge indication to the line format
1723
        if len(rev.parent_ids) > 1:
1724
            out.append('[merge]')
3946.3.3 by Ian Clatworthy
feedback from jelmer re position of tags in --line
1725
        if tags:
1726
            tag_str = '{%s}' % (', '.join(tags))
1727
            out.append(tag_str)
1740.2.5 by Aaron Bentley
Merge from bzr.dev
1728
        out.append(rev.get_summary())
3947.1.1 by Ian Clatworthy
add --merge-revisions to log
1729
        return self.truncate(prefix + " ".join(out).rstrip('\n'), max_chars)
794 by Martin Pool
- Merge John's nice short-log format.
1730
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1731
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1732
class GnuChangelogLogFormatter(LogFormatter):
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1733
1734
    supports_merge_revisions = True
1735
    supports_delta = True
1736
1737
    def log_revision(self, revision):
1738
        """Log a revision, either merged or not."""
1739
        to_file = self.to_file
1740
1741
        date_str = format_date(revision.rev.timestamp,
1742
                               revision.rev.timezone or 0,
1743
                               self.show_timezone,
1744
                               date_fmt='%Y-%m-%d',
1745
                               show_offset=False)
4081.3.2 by Martin von Gagern
Provide --authors argument to log command.
1746
        committer_str = self.authors(revision.rev, 'first', sep=', ')
4081.3.6 by Martin von Gagern
Drop space to make John happy.
1747
        committer_str = committer_str.replace(' <', '  <')
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1748
        to_file.write('%s  %s\n\n' % (date_str,committer_str))
1749
4137.1.1 by James Westby
Small improvements to the GNU ChangeLog formatter.
1750
        if revision.delta is not None and revision.delta.has_changed():
4070.4.1 by Andrea Bolognani
New GNU Changelog log format
1751
            for c in revision.delta.added + revision.delta.removed + revision.delta.modified:
1752
                path, = c[:1]
1753
                to_file.write('\t* %s:\n' % (path,))
1754
            for c in revision.delta.renamed:
1755
                oldpath,newpath = c[:2]
1756
                # For renamed files, show both the old and the new path
1757
                to_file.write('\t* %s:\n\t* %s:\n' % (oldpath,newpath))
1758
            to_file.write('\n')
1759
1760
        if not revision.rev.message:
1761
            to_file.write('\tNo commit message\n')
1762
        else:
1763
            message = revision.rev.message.rstrip('\r\n')
1764
            for l in message.split('\n'):
1765
                to_file.write('\t%s\n' % (l.lstrip(),))
1766
            to_file.write('\n')
1767
1768
1185.12.27 by Aaron Bentley
Use line log for pending merges
1769
def line_log(rev, max_chars):
1770
    lf = LineLogFormatter(None)
1704.2.20 by Martin Pool
log --line shows revision numbers (Alexander)
1771
    return lf.log_string(None, rev, max_chars)
1185.12.27 by Aaron Bentley
Use line log for pending merges
1772
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1773
1774
class LogFormatterRegistry(registry.Registry):
1775
    """Registry for log formatters"""
1776
1777
    def make_formatter(self, name, *args, **kwargs):
1778
        """Construct a formatter from arguments.
1779
1780
        :param name: Name of the formatter to construct.  'short', 'long' and
1781
            'line' are built-in.
1782
        """
1783
        return self.get(name)(*args, **kwargs)
1784
1785
    def get_default(self, branch):
1786
        return self.get(branch.get_config().log_format())
1787
1788
1789
log_formatter_registry = LogFormatterRegistry()
1790
1791
1792
log_formatter_registry.register('short', ShortLogFormatter,
1793
                                'Moderately short log format')
1794
log_formatter_registry.register('long', LongLogFormatter,
1795
                                'Detailed log format')
1796
log_formatter_registry.register('line', LineLogFormatter,
1797
                                'Log format with one line per revision')
4129.1.1 by Andrea Bolognani
Renamed the ChangeLogLogFormatter class to GnuChangelogLogFormatter.
1798
log_formatter_registry.register('gnu-changelog', GnuChangelogLogFormatter,
1799
                                'Format used by GNU ChangeLog files')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1800
794 by Martin Pool
- Merge John's nice short-log format.
1801
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1802
def register_formatter(name, formatter):
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1803
    log_formatter_registry.register(name, formatter)
1804
1553.2.1 by Erik Bågfors
Support for plugins to register log formatters and set default formatter
1805
794 by Martin Pool
- Merge John's nice short-log format.
1806
def log_formatter(name, *args, **kwargs):
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1807
    """Construct a formatter from arguments.
1808
1185.12.27 by Aaron Bentley
Use line log for pending merges
1809
    name -- Name of the formatter to construct; currently 'long', 'short' and
1810
        'line' are supported.
1393.1.56 by Martin Pool
- doc and small refactoring of log code
1811
    """
794 by Martin Pool
- Merge John's nice short-log format.
1812
    try:
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1813
        return log_formatter_registry.make_formatter(name, *args, **kwargs)
1553.2.2 by Erik Bågfors
Made "unknown log formatter" error message work
1814
    except KeyError:
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
1815
        raise errors.BzrCommandError("unknown log formatter: %r" % name)
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1816
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1817
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1818
def author_list_all(rev):
1819
    return rev.get_apparent_authors()[:]
1820
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1821
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1822
def author_list_first(rev):
1823
    lst = rev.get_apparent_authors()
1824
    try:
1825
        return [lst[0]]
1826
    except IndexError:
1827
        return []
1828
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1829
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1830
def author_list_committer(rev):
1831
    return [rev.committer]
1832
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1833
4081.3.9 by Martin von Gagern
Use proper registry for --authors option.
1834
author_list_registry = registry.Registry()
1835
1836
author_list_registry.register('all', author_list_all,
1837
                              'All authors')
1838
1839
author_list_registry.register('first', author_list_first,
1840
                              'The first author')
1841
1842
author_list_registry.register('committer', author_list_committer,
1843
                              'The committer')
2221.4.10 by Aaron Bentley
Implement log options using RegistryOption
1844
4081.3.12 by Martin von Gagern
Separate top level functions with two blank lines.
1845
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1846
def show_one_log(revno, rev, delta, verbose, to_file, show_timezone):
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
1847
    # deprecated; for compatibility
974.1.26 by aaron.bentley at utoronto
merged mbp@sourcefrog.net-20050817233101-0939da1cf91f2472
1848
    lf = LongLogFormatter(to_file=to_file, show_timezone=show_timezone)
1849
    lf.show(revno, rev, delta)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1850
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1851
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1852
def show_changed_revisions(branch, old_rh, new_rh, to_file=None,
1853
                           log_format='long'):
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1854
    """Show the change in revision history comparing the old revision history to the new one.
1855
1856
    :param branch: The branch where the revisions exist
1857
    :param old_rh: The old revision history
1858
    :param new_rh: The new revision history
1859
    :param to_file: A file to write the results to. If None, stdout will be used
1860
    """
1861
    if to_file is None:
2997.1.3 by Alexander Belchenko
file wrapper around stdout should use terminal encoding, not user_encoding.
1862
        to_file = codecs.getwriter(get_terminal_encoding())(sys.stdout,
1863
            errors='replace')
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1864
    lf = log_formatter(log_format,
1865
                       show_ids=False,
1866
                       to_file=to_file,
1867
                       show_timezone='original')
1868
1869
    # This is the first index which is different between
1870
    # old and new
1871
    base_idx = None
1872
    for i in xrange(max(len(new_rh),
1873
                        len(old_rh))):
1874
        if (len(new_rh) <= i
1875
            or len(old_rh) <= i
1876
            or new_rh[i] != old_rh[i]):
1877
            base_idx = i
1878
            break
1879
1880
    if base_idx is None:
1881
        to_file.write('Nothing seems to have changed\n')
1882
        return
1883
    ## TODO: It might be nice to do something like show_log
1884
    ##       and show the merged entries. But since this is the
1885
    ##       removed revisions, it shouldn't be as important
1886
    if base_idx < len(old_rh):
1887
        to_file.write('*'*60)
1888
        to_file.write('\nRemoved Revisions:\n')
1889
        for i in range(base_idx, len(old_rh)):
1185.67.2 by Aaron Bentley
Renamed Branch.storage to Branch.repository
1890
            rev = branch.repository.get_revision(old_rh[i])
2490.1.4 by John Arbash Meinel
Update bzrlib.log.show_changed_revisions to use the new api
1891
            lr = LogRevision(rev, i+1, 0, None)
1892
            lf.log_revision(lr)
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1893
        to_file.write('*'*60)
1894
        to_file.write('\n\n')
1895
    if base_idx < len(new_rh):
1896
        to_file.write('Added Revisions:\n')
1897
        show_log(branch,
1898
                 lf,
1899
                 None,
1551.17.2 by Aaron Bentley
Stop showing deltas in pull -v output
1900
                 verbose=False,
1185.32.2 by John Arbash Meinel
Refactor pull --verbose into a log.py function, add tests.
1901
                 direction='forward',
1902
                 start_revision=base_idx+1,
1903
                 end_revision=len(new_rh),
1904
                 search=None)
1905
3144.7.4 by Guillermo Gonzalez
* move the function regisstry into a real Registry instead of a list
1906
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1907
def get_history_change(old_revision_id, new_revision_id, repository):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1908
    """Calculate the uncommon lefthand history between two revisions.
1909
1910
    :param old_revision_id: The original revision id.
1911
    :param new_revision_id: The new revision id.
3848.1.22 by Aaron Bentley
Fix spelling
1912
    :param repository: The repository to use for the calculation.
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1913
1914
    return old_history, new_history
1915
    """
3848.1.6 by Aaron Bentley
Implement get_history_change
1916
    old_history = []
1917
    old_revisions = set()
1918
    new_history = []
1919
    new_revisions = set()
3848.1.7 by Aaron Bentley
Use repository in get_history_change
1920
    new_iter = repository.iter_reverse_revision_history(new_revision_id)
1921
    old_iter = repository.iter_reverse_revision_history(old_revision_id)
3848.1.6 by Aaron Bentley
Implement get_history_change
1922
    stop_revision = None
1923
    do_old = True
1924
    do_new = True
1925
    while do_new or do_old:
1926
        if do_new:
1927
            try:
1928
                new_revision = new_iter.next()
1929
            except StopIteration:
1930
                do_new = False
1931
            else:
1932
                new_history.append(new_revision)
1933
                new_revisions.add(new_revision)
1934
                if new_revision in old_revisions:
1935
                    stop_revision = new_revision
1936
                    break
1937
        if do_old:
1938
            try:
1939
                old_revision = old_iter.next()
1940
            except StopIteration:
1941
                do_old = False
1942
            else:
1943
                old_history.append(old_revision)
1944
                old_revisions.add(old_revision)
1945
                if old_revision in new_revisions:
1946
                    stop_revision = old_revision
1947
                    break
1948
    new_history.reverse()
1949
    old_history.reverse()
1950
    if stop_revision is not None:
1951
        new_history = new_history[new_history.index(stop_revision) + 1:]
1952
        old_history = old_history[old_history.index(stop_revision) + 1:]
1953
    return old_history, new_history
1954
1955
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1956
def show_branch_change(branch, output, old_revno, old_revision_id):
1957
    """Show the changes made to a branch.
1958
1959
    :param branch: The branch to show changes about.
1960
    :param output: A file-like object to write changes to.
1961
    :param old_revno: The revno of the old tip.
1962
    :param old_revision_id: The revision_id of the old tip.
1963
    """
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1964
    new_revno, new_revision_id = branch.last_revision_info()
1965
    old_history, new_history = get_history_change(old_revision_id,
1966
                                                  new_revision_id,
1967
                                                  branch.repository)
1968
    if old_history == [] and new_history == []:
1969
        output.write('Nothing seems to have changed\n')
1970
        return
1971
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1972
    log_format = log_formatter_registry.get_default(branch)
1973
    lf = log_format(show_ids=False, to_file=output, show_timezone='original')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1974
    if old_history != []:
1975
        output.write('*'*60)
1976
        output.write('\nRemoved Revisions:\n')
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1977
        show_flat_log(branch.repository, old_history, old_revno, lf)
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1978
        output.write('*'*60)
1979
        output.write('\n\n')
1980
    if new_history != []:
3848.1.9 by Aaron Bentley
new/old sections are omitted as appropriate.
1981
        output.write('Added Revisions:\n')
3848.1.8 by Aaron Bentley
Implement basic show_branch_change
1982
        start_revno = new_revno - len(new_history) + 1
1983
        show_log(branch, lf, None, verbose=False, direction='forward',
1984
                 start_revision=start_revno,)
1985
1986
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1987
def show_flat_log(repository, history, last_revno, lf):
3848.1.11 by Aaron Bentley
Cleanup and use of show_branch_change
1988
    """Show a simple log of the specified history.
1989
1990
    :param repository: The repository to retrieve revisions from.
1991
    :param history: A list of revision_ids indicating the lefthand history.
1992
    :param last_revno: The revno of the last revision_id in the history.
1993
    :param lf: The log formatter to use.
1994
    """
3848.1.10 by Aaron Bentley
Move log display into show_flat_log
1995
    start_revno = last_revno - len(history) + 1
1996
    revisions = repository.get_revisions(history)
1997
    for i, rev in enumerate(revisions):
1998
        lr = LogRevision(rev, i + last_revno, 0, None)
1999
        lf.log_revision(lr)
2000
2001
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2002
def _get_info_for_log_files(revisionspec_list, file_list, add_cleanup):
4202.2.1 by Ian Clatworthy
get directory logging working again
2003
    """Find file-ids and kinds given a list of files and a revision range.
2004
2005
    We search for files at the end of the range. If not found there,
2006
    we try the start of the range.
2007
2008
    :param revisionspec_list: revision range as parsed on the command line
2009
    :param file_list: the list of paths given on the command line;
2010
      the first of these can be a branch location or a file path,
2011
      the remainder must be file paths
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2012
    :param add_cleanup: When the branch returned is read locked,
2013
      an unlock call will be queued to the cleanup.
4202.2.1 by Ian Clatworthy
get directory logging working again
2014
    :return: (branch, info_list, start_rev_info, end_rev_info) where
2015
      info_list is a list of (relative_path, file_id, kind) tuples where
2016
      kind is one of values 'directory', 'file', 'symlink', 'tree-reference'.
4634.90.1 by Andrew Bennetts
Fix ObjectNotLocked error during 'bzr log' by acquiring branch read lock as soon as cmd_log acquires the branch, only releasing it at the end.
2017
      branch will be read-locked.
3943.6.4 by Ian Clatworthy
review feedback from vila
2018
    """
5346.4.2 by Martin Pool
Move internal_tree_files and safe_relpath_files onto WorkingTree
2019
    from builtins import _get_revision_range
4202.2.1 by Ian Clatworthy
get directory logging working again
2020
    tree, b, path = bzrdir.BzrDir.open_containing_tree_or_branch(file_list[0])
5200.3.3 by Robert Collins
Lock methods on ``Tree``, ``Branch`` and ``Repository`` are now
2021
    add_cleanup(b.lock_read().unlock)
4202.2.1 by Ian Clatworthy
get directory logging working again
2022
    # XXX: It's damn messy converting a list of paths to relative paths when
2023
    # those paths might be deleted ones, they might be on a case-insensitive
2024
    # filesystem and/or they might be in silly locations (like another branch).
2025
    # For example, what should "log bzr://branch/dir/file1 file2" do? (Is
2026
    # file2 implicitly in the same dir as file1 or should its directory be
2027
    # taken from the current tree somehow?) For now, this solves the common
2028
    # case of running log in a nested directory, assuming paths beyond the
2029
    # first one haven't been deleted ...
2030
    if tree:
5346.4.2 by Martin Pool
Move internal_tree_files and safe_relpath_files onto WorkingTree
2031
        relpaths = [path] + tree.safe_relpath_files(file_list[1:])
4202.2.1 by Ian Clatworthy
get directory logging working again
2032
    else:
2033
        relpaths = [path] + file_list[1:]
2034
    info_list = []
2035
    start_rev_info, end_rev_info = _get_revision_range(revisionspec_list, b,
2036
        "log")
4296.2.1 by Jelmer Vernooij
Don't retrieve the tree if log is called on the root.
2037
    if relpaths in ([], [u'']):
2038
        return b, [], start_rev_info, end_rev_info
4202.2.1 by Ian Clatworthy
get directory logging working again
2039
    if start_rev_info is None and end_rev_info is None:
3943.6.4 by Ian Clatworthy
review feedback from vila
2040
        if tree is None:
2041
            tree = b.basis_tree()
4202.2.1 by Ian Clatworthy
get directory logging working again
2042
        tree1 = None
2043
        for fp in relpaths:
2044
            file_id = tree.path2id(fp)
2045
            kind = _get_kind_for_file_id(tree, file_id)
2046
            if file_id is None:
2047
                # go back to when time began
2048
                if tree1 is None:
2049
                    try:
2050
                        rev1 = b.get_rev_id(1)
2051
                    except errors.NoSuchRevision:
2052
                        # No history at all
2053
                        file_id = None
2054
                        kind = None
2055
                    else:
2056
                        tree1 = b.repository.revision_tree(rev1)
2057
                if tree1:
2058
                    file_id = tree1.path2id(fp)
2059
                    kind = _get_kind_for_file_id(tree1, file_id)
2060
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2061
4202.2.1 by Ian Clatworthy
get directory logging working again
2062
    elif start_rev_info == end_rev_info:
3943.6.4 by Ian Clatworthy
review feedback from vila
2063
        # One revision given - file must exist in it
4202.2.1 by Ian Clatworthy
get directory logging working again
2064
        tree = b.repository.revision_tree(end_rev_info.rev_id)
2065
        for fp in relpaths:
2066
            file_id = tree.path2id(fp)
2067
            kind = _get_kind_for_file_id(tree, file_id)
2068
            info_list.append((fp, file_id, kind))
3943.6.4 by Ian Clatworthy
review feedback from vila
2069
4202.2.1 by Ian Clatworthy
get directory logging working again
2070
    else:
3943.6.4 by Ian Clatworthy
review feedback from vila
2071
        # Revision range given. Get the file-id from the end tree.
2072
        # If that fails, try the start tree.
4202.2.1 by Ian Clatworthy
get directory logging working again
2073
        rev_id = end_rev_info.rev_id
3943.6.4 by Ian Clatworthy
review feedback from vila
2074
        if rev_id is None:
2075
            tree = b.basis_tree()
2076
        else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2077
            tree = b.repository.revision_tree(rev_id)
2078
        tree1 = None
2079
        for fp in relpaths:
3943.6.4 by Ian Clatworthy
review feedback from vila
2080
            file_id = tree.path2id(fp)
4202.2.1 by Ian Clatworthy
get directory logging working again
2081
            kind = _get_kind_for_file_id(tree, file_id)
2082
            if file_id is None:
2083
                if tree1 is None:
2084
                    rev_id = start_rev_info.rev_id
2085
                    if rev_id is None:
2086
                        rev1 = b.get_rev_id(1)
2087
                        tree1 = b.repository.revision_tree(rev1)
2088
                    else:
2089
                        tree1 = b.repository.revision_tree(rev_id)
2090
                file_id = tree1.path2id(fp)
2091
                kind = _get_kind_for_file_id(tree1, file_id)
2092
            info_list.append((fp, file_id, kind))
2093
    return b, info_list, start_rev_info, end_rev_info
2094
2095
2096
def _get_kind_for_file_id(tree, file_id):
2097
    """Return the kind of a file-id or None if it doesn't exist."""
2098
    if file_id is not None:
2099
        return tree.kind(file_id)
3943.6.4 by Ian Clatworthy
review feedback from vila
2100
    else:
4202.2.1 by Ian Clatworthy
get directory logging working again
2101
        return None
3943.6.4 by Ian Clatworthy
review feedback from vila
2102
2103
3144.7.9 by Guillermo Gonzalez
* bzrlib.log.show_roperties don't hide handler errors
2104
properties_handler_registry = registry.Registry()
3830.4.1 by Jelmer Vernooij
Add base classes for foreign branches.
2105
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2106
# Use the properties handlers to print out bug information if available
2107
def _bugs_properties_handler(revision):
2108
    if revision.properties.has_key('bugs'):
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2109
        bug_lines = revision.properties['bugs'].split('\n')
2110
        bug_rows = [line.split(' ', 1) for line in bug_lines]
2111
        fixed_bug_urls = [row[0] for row in bug_rows if
2112
                          len(row) > 1 and row[1] == 'fixed']
5092.1.2 by Vincent Ladeuil
Fix bug #519862.
2113
4921.2.2 by Neil Martinsen-Burrell
from review comments: improve splitting, add test that handler is present, use build_tree in tests
2114
        if fixed_bug_urls:
2115
            return {'fixes bug(s)': ' '.join(fixed_bug_urls)}
4921.2.1 by Neil Martinsen-Burrell
include bug fixes in log output
2116
    return {}
2117
2118
properties_handler_registry.register('bugs_properties_handler',
2119
                                     _bugs_properties_handler)
2120
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2121
2122
# adapters which revision ids to log are filtered. When log is called, the
2123
# log_rev_iterator is adapted through each of these factory methods.
2124
# Plugins are welcome to mutate this list in any way they like - as long
2125
# as the overall behaviour is preserved. At this point there is no extensible
2126
# mechanism for getting parameters to each factory method, and until there is
2127
# this won't be considered a stable api.
2128
log_adapters = [
2129
    # core log logic
3642.1.7 by Robert Collins
Review feedback.
2130
    _make_batch_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2131
    # read revision objects
3642.1.7 by Robert Collins
Review feedback.
2132
    _make_revision_objects,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2133
    # filter on log messages
3642.1.7 by Robert Collins
Review feedback.
2134
    _make_search_filter,
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2135
    # generate deltas for things we will show
3642.1.7 by Robert Collins
Review feedback.
2136
    _make_delta_filter
3642.1.6 by Robert Collins
Make log revision filtering pluggable.
2137
    ]