/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.7 by John Arbash Meinel
Merge in the bzr.dev 5582
1
# Copyright (C) 2005-2011 Canonical Ltd
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
16
17
"""Tests for finding and reading the bzr config file[s]."""
18
# import system imports here
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
19
from cStringIO import StringIO
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
20
import os
21
import sys
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
22
import threading
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
23
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
24
25
from testtools import matchers
26
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
27
#import bzrlib specific imports here
1878.1.3 by John Arbash Meinel
some test cleanups
28
from bzrlib import (
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
29
    branch,
30
    bzrdir,
1878.1.3 by John Arbash Meinel
some test cleanups
31
    config,
4603.1.10 by Aaron Bentley
Provide change editor via config.
32
    diff,
1878.1.3 by John Arbash Meinel
some test cleanups
33
    errors,
34
    osutils,
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
35
    mail_client,
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
36
    mergetools,
2900.2.14 by Vincent Ladeuil
More tests.
37
    ui,
1878.1.3 by John Arbash Meinel
some test cleanups
38
    urlutils,
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
39
    registry,
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
40
    remote,
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
41
    tests,
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
42
    trace,
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
43
    transport,
1878.1.3 by John Arbash Meinel
some test cleanups
44
    )
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
45
from bzrlib.symbol_versioning import (
46
    deprecated_in,
47
    deprecated_method,
48
    )
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
49
from bzrlib.transport import remote as transport_remote
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
50
from bzrlib.tests import (
51
    features,
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
52
    scenarios,
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
53
    test_server,
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
54
    )
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
55
from bzrlib.util.configobj import configobj
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
56
57
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
58
def lockable_config_scenarios():
59
    return [
60
        ('global',
61
         {'config_class': config.GlobalConfig,
62
          'config_args': [],
63
          'config_section': 'DEFAULT'}),
64
        ('locations',
65
         {'config_class': config.LocationConfig,
66
          'config_args': ['.'],
67
          'config_section': '.'}),]
68
69
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
70
load_tests = scenarios.load_tests_apply_scenarios
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
71
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
72
# Register helpers to build stores
73
config.test_store_builder_registry.register(
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
74
    'configobj', lambda test: config.IniFileStore(test.get_transport(),
75
                                                  'configobj.conf'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
76
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
77
    'bazaar', lambda test: config.GlobalStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
78
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
79
    'location', lambda test: config.LocationStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
80
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
81
82
def build_backing_branch(test, relpath,
83
                         transport_class=None, server_class=None):
84
    """Test helper to create a backing branch only once.
85
86
    Some tests needs multiple stores/stacks to check concurrent update
87
    behaviours. As such, they need to build different branch *objects* even if
88
    they share the branch on disk.
89
90
    :param relpath: The relative path to the branch. (Note that the helper
91
        should always specify the same relpath).
92
93
    :param transport_class: The Transport class the test needs to use.
94
95
    :param server_class: The server associated with the ``transport_class``
96
        above.
97
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
98
    Either both or neither of ``transport_class`` and ``server_class`` should
99
    be specified.
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
100
    """
101
    if transport_class is not None and server_class is not None:
102
        test.transport_class = transport_class
103
        test.transport_server = server_class
104
    elif not (transport_class is None and server_class is None):
105
        raise AssertionError('Specify both ``transport_class`` and '
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
106
                             '``server_class`` or neither of them')
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
107
    if getattr(test, 'backing_branch', None) is None:
108
        # First call, let's build the branch on disk
109
        test.backing_branch = test.make_branch(relpath)
110
111
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
112
def build_branch_store(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
113
    build_backing_branch(test, 'branch')
114
    b = branch.Branch.open('branch')
115
    return config.BranchStore(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
116
config.test_store_builder_registry.register('branch', build_branch_store)
117
118
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
119
def build_remote_branch_store(test):
120
    # There is only one permutation (but we won't be able to handle more with
121
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
122
    (transport_class,
123
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
124
    build_backing_branch(test, 'branch', transport_class, server_class)
125
    b = branch.Branch.open(test.get_url('branch'))
126
    return config.BranchStore(b)
127
config.test_store_builder_registry.register('remote_branch',
128
                                            build_remote_branch_store)
129
130
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
131
config.test_stack_builder_registry.register(
132
    'bazaar', lambda test: config.GlobalStack())
133
config.test_stack_builder_registry.register(
134
    'location', lambda test: config.LocationStack('.'))
135
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
136
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
137
def build_branch_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
138
    build_backing_branch(test, 'branch')
139
    b = branch.Branch.open('branch')
140
    return config.BranchStack(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
141
config.test_stack_builder_registry.register('branch', build_branch_stack)
142
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
143
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
144
def build_remote_branch_stack(test):
145
    # There is only one permutation (but we won't be able to handle more with
146
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
147
    (transport_class,
148
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
149
    build_backing_branch(test, 'branch', transport_class, server_class)
150
    b = branch.Branch.open(test.get_url('branch'))
151
    return config.BranchStack(b)
152
config.test_stack_builder_registry.register('remote_branch',
153
                                            build_remote_branch_stack)
154
155
1553.6.12 by Erik Bågfors
remove AliasConfig, based on input from abentley
156
sample_long_alias="log -r-15..-1 --line"
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
157
sample_config_text = u"""
158
[DEFAULT]
159
email=Erik B\u00e5gfors <erik@bagfors.nu>
160
editor=vim
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
161
change_editor=vimdiff -of @new_path @old_path
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
162
gpg_signing_command=gnome-gpg
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
163
gpg_signing_key=DD4D5088
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
164
log_format=short
5971.1.58 by Jonathan Riddell
more tests for new config options
165
validate_signatures_in_log=true
166
acceptable_keys=amy
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
167
user_global_option=something
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
168
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
5321.2.3 by Vincent Ladeuil
Prefix mergetools option names with 'bzr.'.
169
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
170
bzr.default_mergetool=sometool
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
171
[ALIASES]
172
h=help
173
ll=""" + sample_long_alias + "\n"
174
175
176
sample_always_signatures = """
177
[DEFAULT]
178
check_signatures=ignore
179
create_signatures=always
180
"""
181
182
sample_ignore_signatures = """
183
[DEFAULT]
184
check_signatures=require
185
create_signatures=never
186
"""
187
188
sample_maybe_signatures = """
189
[DEFAULT]
190
check_signatures=ignore
191
create_signatures=when-required
192
"""
193
194
sample_branches_text = """
195
[http://www.example.com]
196
# Top level policy
197
email=Robert Collins <robertc@example.org>
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
198
normal_option = normal
199
appendpath_option = append
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
200
appendpath_option:policy = appendpath
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
201
norecurse_option = norecurse
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
202
norecurse_option:policy = norecurse
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
203
[http://www.example.com/ignoreparent]
204
# different project: ignore parent dir config
205
ignore_parents=true
206
[http://www.example.com/norecurse]
207
# configuration items that only apply to this dir
208
recurse=false
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
209
normal_option = norecurse
210
[http://www.example.com/dir]
211
appendpath_option = normal
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
212
[/b/]
213
check_signatures=require
214
# test trailing / matching with no children
215
[/a/]
216
check_signatures=check-available
217
gpg_signing_command=false
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
218
gpg_signing_key=default
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
219
user_local_option=local
220
# test trailing / matching
221
[/a/*]
222
#subdirs will match but not the parent
223
[/a/c]
224
check_signatures=ignore
225
post_commit=bzrlib.tests.test_config.post_commit
226
#testing explicit beats globs
227
"""
1553.6.3 by Erik Bågfors
tests for AliasesConfig
228
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
229
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
230
def create_configs(test):
231
    """Create configuration files for a given test.
232
233
    This requires creating a tree (and populate the ``test.tree`` attribute)
234
    and its associated branch and will populate the following attributes:
235
236
    - branch_config: A BranchConfig for the associated branch.
237
238
    - locations_config : A LocationConfig for the associated branch
239
240
    - bazaar_config: A GlobalConfig.
241
242
    The tree and branch are created in a 'tree' subdirectory so the tests can
243
    still use the test directory to stay outside of the branch.
244
    """
245
    tree = test.make_branch_and_tree('tree')
246
    test.tree = tree
247
    test.branch_config = config.BranchConfig(tree.branch)
248
    test.locations_config = config.LocationConfig(tree.basedir)
249
    test.bazaar_config = config.GlobalConfig()
250
5533.2.4 by Vincent Ladeuil
Fix whitespace issue.
251
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
252
def create_configs_with_file_option(test):
253
    """Create configuration files with a ``file`` option set in each.
254
255
    This builds on ``create_configs`` and add one ``file`` option in each
256
    configuration with a value which allows identifying the configuration file.
257
    """
258
    create_configs(test)
259
    test.bazaar_config.set_user_option('file', 'bazaar')
260
    test.locations_config.set_user_option('file', 'locations')
261
    test.branch_config.set_user_option('file', 'branch')
262
263
264
class TestOptionsMixin:
265
266
    def assertOptions(self, expected, conf):
267
        # We don't care about the parser (as it will make tests hard to write
268
        # and error-prone anyway)
269
        self.assertThat([opt[:4] for opt in conf._get_options()],
270
                        matchers.Equals(expected))
271
272
1474 by Robert Collins
Merge from Aaron Bentley.
273
class InstrumentedConfigObj(object):
274
    """A config obj look-enough-alike to record calls made to it."""
275
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
276
    def __contains__(self, thing):
277
        self._calls.append(('__contains__', thing))
278
        return False
279
280
    def __getitem__(self, key):
281
        self._calls.append(('__getitem__', key))
282
        return self
283
1551.2.20 by Aaron Bentley
Treated config files as utf-8
284
    def __init__(self, input, encoding=None):
285
        self._calls = [('__init__', input, encoding)]
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
286
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
287
    def __setitem__(self, key, value):
288
        self._calls.append(('__setitem__', key, value))
289
2120.6.4 by James Henstridge
add support for specifying policy when storing options
290
    def __delitem__(self, key):
291
        self._calls.append(('__delitem__', key))
292
293
    def keys(self):
294
        self._calls.append(('keys',))
295
        return []
296
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
297
    def reload(self):
298
        self._calls.append(('reload',))
299
1551.2.49 by abentley
Made ConfigObj output binary-identical files on win32 and *nix
300
    def write(self, arg):
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
301
        self._calls.append(('write',))
302
2120.6.4 by James Henstridge
add support for specifying policy when storing options
303
    def as_bool(self, value):
304
        self._calls.append(('as_bool', value))
305
        return False
306
307
    def get_value(self, section, name):
308
        self._calls.append(('get_value', section, name))
309
        return None
310
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
311
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
312
class FakeBranch(object):
313
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
314
    def __init__(self, base=None, user_id=None):
315
        if base is None:
316
            self.base = "http://example.com/branches/demo"
317
        else:
318
            self.base = base
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
319
        self._transport = self.control_files = \
320
            FakeControlFilesAndTransport(user_id=user_id)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
321
4226.1.7 by Robert Collins
Alter test_config.FakeBranch in accordance with the Branch change to have a _get_config.
322
    def _get_config(self):
323
        return config.TransportConfig(self._transport, 'branch.conf')
324
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
325
    def lock_write(self):
326
        pass
327
328
    def unlock(self):
329
        pass
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
330
331
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
332
class FakeControlFilesAndTransport(object):
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
333
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
334
    def __init__(self, user_id=None):
335
        self.files = {}
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
336
        if user_id:
337
            self.files['email'] = user_id
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
338
        self._transport = self
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
339
1185.65.29 by Robert Collins
Implement final review suggestions.
340
    def get_utf8(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
341
        # from LockableFiles
342
        raise AssertionError("get_utf8 should no longer be used")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
343
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
344
    def get(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
345
        # from Transport
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
346
        try:
347
            return StringIO(self.files[filename])
348
        except KeyError:
349
            raise errors.NoSuchFile(filename)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
350
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
351
    def get_bytes(self, filename):
352
        # from Transport
353
        try:
354
            return self.files[filename]
355
        except KeyError:
356
            raise errors.NoSuchFile(filename)
357
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
358
    def put(self, filename, fileobj):
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
359
        self.files[filename] = fileobj.read()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
360
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
361
    def put_file(self, filename, fileobj):
362
        return self.put(filename, fileobj)
363
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
364
365
class InstrumentedConfig(config.Config):
366
    """An instrumented config that supplies stubs for template methods."""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
367
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
368
    def __init__(self):
369
        super(InstrumentedConfig, self).__init__()
370
        self._calls = []
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
371
        self._signatures = config.CHECK_NEVER
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
372
373
    def _get_user_id(self):
374
        self._calls.append('_get_user_id')
375
        return "Robert Collins <robert.collins@example.org>"
376
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
377
    def _get_signature_checking(self):
378
        self._calls.append('_get_signature_checking')
379
        return self._signatures
380
4603.1.10 by Aaron Bentley
Provide change editor via config.
381
    def _get_change_editor(self):
382
        self._calls.append('_get_change_editor')
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
383
        return 'vimdiff -fo @new_path @old_path'
4603.1.10 by Aaron Bentley
Provide change editor via config.
384
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
385
1556.2.2 by Aaron Bentley
Fixed get_bool
386
bool_config = """[DEFAULT]
387
active = true
388
inactive = false
389
[UPPERCASE]
390
active = True
391
nonactive = False
392
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
393
394
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
395
class TestConfigObj(tests.TestCase):
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
396
1556.2.2 by Aaron Bentley
Fixed get_bool
397
    def test_get_bool(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
398
        co = config.ConfigObj(StringIO(bool_config))
1556.2.2 by Aaron Bentley
Fixed get_bool
399
        self.assertIs(co.get_bool('DEFAULT', 'active'), True)
400
        self.assertIs(co.get_bool('DEFAULT', 'inactive'), False)
401
        self.assertIs(co.get_bool('UPPERCASE', 'active'), True)
402
        self.assertIs(co.get_bool('UPPERCASE', 'nonactive'), False)
403
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
404
    def test_hash_sign_in_value(self):
405
        """
406
        Before 4.5.0, ConfigObj did not quote # signs in values, so they'd be
407
        treated as comments when read in again. (#86838)
408
        """
409
        co = config.ConfigObj()
410
        co['test'] = 'foo#bar'
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
411
        outfile = StringIO()
412
        co.write(outfile=outfile)
413
        lines = outfile.getvalue().splitlines()
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
414
        self.assertEqual(lines, ['test = "foo#bar"'])
415
        co2 = config.ConfigObj(lines)
416
        self.assertEqual(co2['test'], 'foo#bar')
417
5050.62.10 by Alexander Belchenko
test to illustrate the problem
418
    def test_triple_quotes(self):
419
        # Bug #710410: if the value string has triple quotes
420
        # then ConfigObj versions up to 4.7.2 will quote them wrong
5050.62.12 by Alexander Belchenko
added NEWS entry
421
        # and won't able to read them back
5050.62.10 by Alexander Belchenko
test to illustrate the problem
422
        triple_quotes_value = '''spam
423
""" that's my spam """
424
eggs'''
425
        co = config.ConfigObj()
426
        co['test'] = triple_quotes_value
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
427
        # While writing this test another bug in ConfigObj has been found:
5050.62.10 by Alexander Belchenko
test to illustrate the problem
428
        # method co.write() without arguments produces list of lines
429
        # one option per line, and multiline values are not split
430
        # across multiple lines,
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
431
        # and that breaks the parsing these lines back by ConfigObj.
432
        # This issue only affects test, but it's better to avoid
433
        # `co.write()` construct at all.
434
        # [bialix 20110222] bug report sent to ConfigObj's author
5050.62.10 by Alexander Belchenko
test to illustrate the problem
435
        outfile = StringIO()
436
        co.write(outfile=outfile)
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
437
        output = outfile.getvalue()
5050.62.10 by Alexander Belchenko
test to illustrate the problem
438
        # now we're trying to read it back
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
439
        co2 = config.ConfigObj(StringIO(output))
5050.62.10 by Alexander Belchenko
test to illustrate the problem
440
        self.assertEquals(triple_quotes_value, co2['test'])
441
1556.2.2 by Aaron Bentley
Fixed get_bool
442
2900.1.1 by Vincent Ladeuil
443
erroneous_config = """[section] # line 1
444
good=good # line 2
445
[section] # line 3
446
whocares=notme # line 4
447
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
448
449
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
450
class TestConfigObjErrors(tests.TestCase):
2900.1.1 by Vincent Ladeuil
451
452
    def test_duplicate_section_name_error_line(self):
453
        try:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
454
            co = configobj.ConfigObj(StringIO(erroneous_config),
455
                                     raise_errors=True)
2900.1.1 by Vincent Ladeuil
456
        except config.configobj.DuplicateError, e:
457
            self.assertEqual(3, e.line_number)
458
        else:
459
            self.fail('Error in config file not detected')
460
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
461
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
462
class TestConfig(tests.TestCase):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
463
464
    def test_constructs(self):
465
        config.Config()
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
466
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
467
    def test_no_default_editor(self):
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
468
        self.assertRaises(
469
            NotImplementedError,
470
            self.applyDeprecated, deprecated_in((2, 4, 0)),
471
            config.Config().get_editor)
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
472
473
    def test_user_email(self):
474
        my_config = InstrumentedConfig()
475
        self.assertEqual('robert.collins@example.org', my_config.user_email())
476
        self.assertEqual(['_get_user_id'], my_config._calls)
477
478
    def test_username(self):
479
        my_config = InstrumentedConfig()
480
        self.assertEqual('Robert Collins <robert.collins@example.org>',
481
                         my_config.username())
482
        self.assertEqual(['_get_user_id'], my_config._calls)
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
483
484
    def test_signatures_default(self):
485
        my_config = config.Config()
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
486
        self.assertFalse(my_config.signature_needed())
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
487
        self.assertEqual(config.CHECK_IF_POSSIBLE,
488
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
489
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
490
                         my_config.signing_policy())
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
491
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
492
    def test_signatures_template_method(self):
493
        my_config = InstrumentedConfig()
494
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
495
        self.assertEqual(['_get_signature_checking'], my_config._calls)
496
497
    def test_signatures_template_method_none(self):
498
        my_config = InstrumentedConfig()
499
        my_config._signatures = None
500
        self.assertEqual(config.CHECK_IF_POSSIBLE,
501
                         my_config.signature_checking())
502
        self.assertEqual(['_get_signature_checking'], my_config._calls)
503
1442.1.56 by Robert Collins
gpg_signing_command configuration item
504
    def test_gpg_signing_command_default(self):
505
        my_config = config.Config()
506
        self.assertEqual('gpg', my_config.gpg_signing_command())
507
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
508
    def test_get_user_option_default(self):
509
        my_config = config.Config()
510
        self.assertEqual(None, my_config.get_user_option('no_option'))
511
1472 by Robert Collins
post commit hook, first pass implementation
512
    def test_post_commit_default(self):
513
        my_config = config.Config()
514
        self.assertEqual(None, my_config.post_commit())
515
1553.2.9 by Erik Bågfors
log_formatter => log_format for "named" formatters
516
    def test_log_format_default(self):
1553.2.8 by Erik Bågfors
tests for config log_formatter
517
        my_config = config.Config()
1553.2.9 by Erik Bågfors
log_formatter => log_format for "named" formatters
518
        self.assertEqual('long', my_config.log_format())
1553.2.8 by Erik Bågfors
tests for config log_formatter
519
5971.1.57 by Jonathan Riddell
tests for new config options
520
    def test_acceptable_keys_default(self):
521
        my_config = config.Config()
522
        self.assertEqual(None, my_config.acceptable_keys())
523
524
    def test_validate_signatures_in_log_default(self):
525
        my_config = config.Config()
526
        self.assertEqual(False, my_config.validate_signatures_in_log())
527
4603.1.10 by Aaron Bentley
Provide change editor via config.
528
    def test_get_change_editor(self):
529
        my_config = InstrumentedConfig()
530
        change_editor = my_config.get_change_editor('old_tree', 'new_tree')
531
        self.assertEqual(['_get_change_editor'], my_config._calls)
532
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
533
        self.assertEqual(['vimdiff', '-fo', '@new_path', '@old_path'],
4603.1.10 by Aaron Bentley
Provide change editor via config.
534
                         change_editor.command_template)
535
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
536
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
537
class TestConfigPath(tests.TestCase):
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
538
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
539
    def setUp(self):
540
        super(TestConfigPath, self).setUp()
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
541
        self.overrideEnv('HOME', '/home/bogus')
542
        self.overrideEnv('XDG_CACHE_DIR', '')
2309.2.6 by Alexander Belchenko
bzr now use Win32 API to determine Application Data location, and don't rely solely on $APPDATA
543
        if sys.platform == 'win32':
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
544
            self.overrideEnv(
545
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
546
            self.bzr_home = \
547
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
5519.4.3 by Neil Martinsen-Burrell
be permissive about using $XDG_CONFIG_HOME/bazaar, but dont complain
548
        else:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
549
            self.bzr_home = '/home/bogus/.bazaar'
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
550
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
551
    def test_config_dir(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
552
        self.assertEqual(config.config_dir(), self.bzr_home)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
553
554
    def test_config_filename(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
555
        self.assertEqual(config.config_filename(),
556
                         self.bzr_home + '/bazaar.conf')
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
557
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
558
    def test_locations_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
559
        self.assertEqual(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
560
                         self.bzr_home + '/locations.conf')
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
561
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
562
    def test_authentication_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
563
        self.assertEqual(config.authentication_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
564
                         self.bzr_home + '/authentication.conf')
565
4584.3.23 by Martin Pool
Correction to xdg_cache_dir and add a simple test
566
    def test_xdg_cache_dir(self):
567
        self.assertEqual(config.xdg_cache_dir(),
568
            '/home/bogus/.cache')
569
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
570
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
571
class TestXDGConfigDir(tests.TestCaseInTempDir):
572
    # must be in temp dir because config tests for the existence of the bazaar
573
    # subdirectory of $XDG_CONFIG_HOME
574
5519.4.9 by Neil Martinsen-Burrell
working tests
575
    def setUp(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
576
        if sys.platform in ('darwin', 'win32'):
577
            raise tests.TestNotApplicable(
578
                'XDG config dir not used on this platform')
5519.4.9 by Neil Martinsen-Burrell
working tests
579
        super(TestXDGConfigDir, self).setUp()
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
580
        self.overrideEnv('HOME', self.test_home_dir)
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
581
        # BZR_HOME overrides everything we want to test so unset it.
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
582
        self.overrideEnv('BZR_HOME', None)
5519.4.9 by Neil Martinsen-Burrell
working tests
583
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
584
    def test_xdg_config_dir_exists(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
585
        """When ~/.config/bazaar exists, use it as the config dir."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
586
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
587
        os.makedirs(newdir)
588
        self.assertEqual(config.config_dir(), newdir)
589
590
    def test_xdg_config_home(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
591
        """When XDG_CONFIG_HOME is set, use it."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
592
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
593
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
594
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
595
        os.makedirs(newdir)
596
        self.assertEqual(config.config_dir(), newdir)
597
598
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
599
class TestIniConfig(tests.TestCaseInTempDir):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
600
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
601
    def make_config_parser(self, s):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
602
        conf = config.IniBasedConfig.from_string(s)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
603
        return conf, conf._get_parser()
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
604
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
605
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
606
class TestIniConfigBuilding(TestIniConfig):
607
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
608
    def test_contructs(self):
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
609
        my_config = config.IniBasedConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
610
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
611
    def test_from_fp(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
612
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
613
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
614
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
615
    def test_cached(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
616
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
617
        parser = my_config._get_parser()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
618
        self.assertTrue(my_config._get_parser() is parser)
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
619
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
620
    def _dummy_chown(self, path, uid, gid):
621
        self.path, self.uid, self.gid = path, uid, gid
622
623
    def test_ini_config_ownership(self):
5345.5.8 by Vincent Ladeuil
More doc and ensure that the config is locked when _write_config_file is called.
624
        """Ensure that chown is happening during _write_config_file"""
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
625
        self.requireFeature(features.chown_feature)
626
        self.overrideAttr(os, 'chown', self._dummy_chown)
627
        self.path = self.uid = self.gid = None
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
628
        conf = config.IniBasedConfig(file_name='./foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
629
        conf._write_config_file()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
630
        self.assertEquals(self.path, './foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
631
        self.assertTrue(isinstance(self.uid, int))
632
        self.assertTrue(isinstance(self.gid, int))
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
633
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
634
    def test_get_filename_parameter_is_deprecated_(self):
635
        conf = self.callDeprecated([
636
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
637
            ' Use file_name instead.'],
638
            config.IniBasedConfig, lambda: 'ini.conf')
5345.3.1 by Vincent Ladeuil
Check that _get_filename() is called and produces the desired side effect.
639
        self.assertEqual('ini.conf', conf.file_name)
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
640
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
641
    def test_get_parser_file_parameter_is_deprecated_(self):
642
        config_file = StringIO(sample_config_text.encode('utf-8'))
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
643
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
644
        conf = self.callDeprecated([
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
645
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
646
            ' Use IniBasedConfig(_content=xxx) instead.'],
647
            conf._get_parser, file=config_file)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
648
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
649
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
650
class TestIniConfigSaving(tests.TestCaseInTempDir):
651
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
652
    def test_cant_save_without_a_file_name(self):
653
        conf = config.IniBasedConfig()
654
        self.assertRaises(AssertionError, conf._write_config_file)
655
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
656
    def test_saved_with_content(self):
657
        content = 'foo = bar\n'
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
658
        conf = config.IniBasedConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
659
            content, file_name='./test.conf', save=True)
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
660
        self.assertFileEqual(content, 'test.conf')
661
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
662
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
663
class TestIniConfigOptionExpansionDefaultValue(tests.TestCaseInTempDir):
664
    """What is the default value of expand for config options.
665
666
    This is an opt-in beta feature used to evaluate whether or not option
667
    references can appear in dangerous place raising exceptions, disapearing
668
    (and as such corrupting data) or if it's safe to activate the option by
669
    default.
670
671
    Note that these tests relies on config._expand_default_value being already
672
    overwritten in the parent class setUp.
673
    """
674
675
    def setUp(self):
676
        super(TestIniConfigOptionExpansionDefaultValue, self).setUp()
677
        self.config = None
678
        self.warnings = []
679
        def warning(*args):
680
            self.warnings.append(args[0] % args[1:])
681
        self.overrideAttr(trace, 'warning', warning)
682
683
    def get_config(self, expand):
684
        c = config.GlobalConfig.from_string('bzr.config.expand=%s' % (expand,),
685
                                            save=True)
686
        return c
687
688
    def assertExpandIs(self, expected):
689
        actual = config._get_expand_default_value()
690
        #self.config.get_user_option_as_bool('bzr.config.expand')
691
        self.assertEquals(expected, actual)
692
693
    def test_default_is_None(self):
694
        self.assertEquals(None, config._expand_default_value)
695
696
    def test_default_is_False_even_if_None(self):
697
        self.config = self.get_config(None)
698
        self.assertExpandIs(False)
699
700
    def test_default_is_False_even_if_invalid(self):
701
        self.config = self.get_config('<your choice>')
702
        self.assertExpandIs(False)
703
        # ...
704
        # Huh ? My choice is False ? Thanks, always happy to hear that :D
705
        # Wait, you've been warned !
706
        self.assertLength(1, self.warnings)
707
        self.assertEquals(
708
            'Value "<your choice>" is not a boolean for "bzr.config.expand"',
709
            self.warnings[0])
710
711
    def test_default_is_True(self):
712
        self.config = self.get_config(True)
713
        self.assertExpandIs(True)
5743.10.10 by Vincent Ladeuil
Remove spurious space
714
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
715
    def test_default_is_False(self):
716
        self.config = self.get_config(False)
717
        self.assertExpandIs(False)
5743.10.10 by Vincent Ladeuil
Remove spurious space
718
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
719
720
class TestIniConfigOptionExpansion(tests.TestCase):
721
    """Test option expansion from the IniConfig level.
722
723
    What we really want here is to test the Config level, but the class being
724
    abstract as far as storing values is concerned, this can't be done
725
    properly (yet).
726
    """
727
    # FIXME: This should be rewritten when all configs share a storage
728
    # implementation -- vila 2011-02-18
729
730
    def get_config(self, string=None):
731
        if string is None:
732
            string = ''
733
        c = config.IniBasedConfig.from_string(string)
734
        return c
735
736
    def assertExpansion(self, expected, conf, string, env=None):
737
        self.assertEquals(expected, conf.expand_options(string, env))
738
739
    def test_no_expansion(self):
740
        c = self.get_config('')
741
        self.assertExpansion('foo', c, 'foo')
742
743
    def test_env_adding_options(self):
744
        c = self.get_config('')
745
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
746
747
    def test_env_overriding_options(self):
748
        c = self.get_config('foo=baz')
749
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
750
751
    def test_simple_ref(self):
752
        c = self.get_config('foo=xxx')
753
        self.assertExpansion('xxx', c, '{foo}')
754
755
    def test_unknown_ref(self):
756
        c = self.get_config('')
757
        self.assertRaises(errors.ExpandingUnknownOption,
758
                          c.expand_options, '{foo}')
759
760
    def test_indirect_ref(self):
761
        c = self.get_config('''
762
foo=xxx
763
bar={foo}
764
''')
765
        self.assertExpansion('xxx', c, '{bar}')
766
767
    def test_embedded_ref(self):
768
        c = self.get_config('''
769
foo=xxx
770
bar=foo
771
''')
772
        self.assertExpansion('xxx', c, '{{bar}}')
773
774
    def test_simple_loop(self):
775
        c = self.get_config('foo={foo}')
776
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
777
778
    def test_indirect_loop(self):
779
        c = self.get_config('''
780
foo={bar}
781
bar={baz}
782
baz={foo}''')
783
        e = self.assertRaises(errors.OptionExpansionLoop,
784
                              c.expand_options, '{foo}')
785
        self.assertEquals('foo->bar->baz', e.refs)
786
        self.assertEquals('{foo}', e.string)
787
788
    def test_list(self):
789
        conf = self.get_config('''
790
foo=start
791
bar=middle
792
baz=end
793
list={foo},{bar},{baz}
794
''')
795
        self.assertEquals(['start', 'middle', 'end'],
796
                           conf.get_user_option('list', expand=True))
797
798
    def test_cascading_list(self):
799
        conf = self.get_config('''
800
foo=start,{bar}
801
bar=middle,{baz}
802
baz=end
803
list={foo}
804
''')
805
        self.assertEquals(['start', 'middle', 'end'],
806
                           conf.get_user_option('list', expand=True))
807
808
    def test_pathological_hidden_list(self):
809
        conf = self.get_config('''
810
foo=bin
811
bar=go
812
start={foo
813
middle=},{
814
end=bar}
815
hidden={start}{middle}{end}
816
''')
817
        # Nope, it's either a string or a list, and the list wins as soon as a
818
        # ',' appears, so the string concatenation never occur.
819
        self.assertEquals(['{foo', '}', '{', 'bar}'],
820
                          conf.get_user_option('hidden', expand=True))
821
822
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
823
824
    def get_config(self, location, string=None):
825
        if string is None:
826
            string = ''
827
        # Since we don't save the config we won't strictly require to inherit
828
        # from TestCaseInTempDir, but an error occurs so quickly...
829
        c = config.LocationConfig.from_string(string, location)
830
        return c
831
832
    def test_dont_cross_unrelated_section(self):
833
        c = self.get_config('/another/branch/path','''
834
[/one/branch/path]
835
foo = hello
836
bar = {foo}/2
837
838
[/another/branch/path]
839
bar = {foo}/2
840
''')
841
        self.assertRaises(errors.ExpandingUnknownOption,
842
                          c.get_user_option, 'bar', expand=True)
843
844
    def test_cross_related_sections(self):
845
        c = self.get_config('/project/branch/path','''
846
[/project]
847
foo = qu
848
849
[/project/branch/path]
850
bar = {foo}ux
851
''')
852
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
853
854
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
855
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
856
857
    def test_cannot_reload_without_name(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
858
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
859
        self.assertRaises(AssertionError, conf.reload)
860
861
    def test_reload_see_new_value(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
862
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
863
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
864
        c1._write_config_file()
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
865
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
866
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
867
        c2._write_config_file()
868
        self.assertEqual('vim', c1.get_user_option('editor'))
869
        self.assertEqual('emacs', c2.get_user_option('editor'))
870
        # Make sure we get the Right value
871
        c1.reload()
872
        self.assertEqual('emacs', c1.get_user_option('editor'))
873
874
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
875
class TestLockableConfig(tests.TestCaseInTempDir):
876
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
877
    scenarios = lockable_config_scenarios()
878
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
879
    # Set by load_tests
880
    config_class = None
881
    config_args = None
882
    config_section = None
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
883
884
    def setUp(self):
885
        super(TestLockableConfig, self).setUp()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
886
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
887
        self.config = self.create_config(self._content)
888
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
889
    def get_existing_config(self):
890
        return self.config_class(*self.config_args)
891
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
892
    def create_config(self, content):
5396.1.1 by Vincent Ladeuil
Fix python-2.6-ism.
893
        kwargs = dict(save=True)
894
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
895
        return c
896
897
    def test_simple_read_access(self):
898
        self.assertEquals('1', self.config.get_user_option('one'))
899
900
    def test_simple_write_access(self):
901
        self.config.set_user_option('one', 'one')
902
        self.assertEquals('one', self.config.get_user_option('one'))
903
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
904
    def test_listen_to_the_last_speaker(self):
905
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
906
        c2 = self.get_existing_config()
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
907
        c1.set_user_option('one', 'ONE')
908
        c2.set_user_option('two', 'TWO')
909
        self.assertEquals('ONE', c1.get_user_option('one'))
910
        self.assertEquals('TWO', c2.get_user_option('two'))
911
        # The second update respect the first one
912
        self.assertEquals('ONE', c2.get_user_option('one'))
913
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
914
    def test_last_speaker_wins(self):
915
        # If the same config is not shared, the same variable modified twice
916
        # can only see a single result.
917
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
918
        c2 = self.get_existing_config()
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
919
        c1.set_user_option('one', 'c1')
920
        c2.set_user_option('one', 'c2')
921
        self.assertEquals('c2', c2._get_user_option('one'))
922
        # The first modification is still available until another refresh
923
        # occur
924
        self.assertEquals('c1', c1._get_user_option('one'))
925
        c1.set_user_option('two', 'done')
926
        self.assertEquals('c2', c1._get_user_option('one'))
927
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
928
    def test_writes_are_serialized(self):
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
929
        c1 = self.config
930
        c2 = self.get_existing_config()
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
931
932
        # We spawn a thread that will pause *during* the write
933
        before_writing = threading.Event()
934
        after_writing = threading.Event()
935
        writing_done = threading.Event()
936
        c1_orig = c1._write_config_file
937
        def c1_write_config_file():
938
            before_writing.set()
939
            c1_orig()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
940
            # The lock is held. We wait for the main thread to decide when to
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
941
            # continue
942
            after_writing.wait()
943
        c1._write_config_file = c1_write_config_file
944
        def c1_set_option():
945
            c1.set_user_option('one', 'c1')
946
            writing_done.set()
947
        t1 = threading.Thread(target=c1_set_option)
948
        # Collect the thread after the test
949
        self.addCleanup(t1.join)
950
        # Be ready to unblock the thread if the test goes wrong
951
        self.addCleanup(after_writing.set)
952
        t1.start()
953
        before_writing.wait()
954
        self.assertTrue(c1._lock.is_held)
955
        self.assertRaises(errors.LockContention,
956
                          c2.set_user_option, 'one', 'c2')
957
        self.assertEquals('c1', c1.get_user_option('one'))
958
        # Let the lock be released
959
        after_writing.set()
960
        writing_done.wait()
961
        c2.set_user_option('one', 'c2')
962
        self.assertEquals('c2', c2.get_user_option('one'))
963
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
964
    def test_read_while_writing(self):
965
       c1 = self.config
966
       # We spawn a thread that will pause *during* the write
967
       ready_to_write = threading.Event()
968
       do_writing = threading.Event()
969
       writing_done = threading.Event()
970
       c1_orig = c1._write_config_file
971
       def c1_write_config_file():
972
           ready_to_write.set()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
973
           # The lock is held. We wait for the main thread to decide when to
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
974
           # continue
975
           do_writing.wait()
976
           c1_orig()
977
           writing_done.set()
978
       c1._write_config_file = c1_write_config_file
979
       def c1_set_option():
980
           c1.set_user_option('one', 'c1')
981
       t1 = threading.Thread(target=c1_set_option)
982
       # Collect the thread after the test
983
       self.addCleanup(t1.join)
984
       # Be ready to unblock the thread if the test goes wrong
985
       self.addCleanup(do_writing.set)
986
       t1.start()
987
       # Ensure the thread is ready to write
988
       ready_to_write.wait()
989
       self.assertTrue(c1._lock.is_held)
990
       self.assertEquals('c1', c1.get_user_option('one'))
991
       # If we read during the write, we get the old value
992
       c2 = self.get_existing_config()
993
       self.assertEquals('1', c2.get_user_option('one'))
994
       # Let the writing occur and ensure it occurred
995
       do_writing.set()
996
       writing_done.wait()
997
       # Now we get the updated value
998
       c3 = self.get_existing_config()
999
       self.assertEquals('c1', c3.get_user_option('one'))
1000
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
1001
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1002
class TestGetUserOptionAs(TestIniConfig):
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
1003
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
1004
    def test_get_user_option_as_bool(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1005
        conf, parser = self.make_config_parser("""
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
1006
a_true_bool = true
1007
a_false_bool = 0
1008
an_invalid_bool = maybe
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1009
a_list = hmm, who knows ? # This is interpreted as a list !
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
1010
""")
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1011
        get_bool = conf.get_user_option_as_bool
1012
        self.assertEqual(True, get_bool('a_true_bool'))
1013
        self.assertEqual(False, get_bool('a_false_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1014
        warnings = []
1015
        def warning(*args):
1016
            warnings.append(args[0] % args[1:])
1017
        self.overrideAttr(trace, 'warning', warning)
1018
        msg = 'Value "%s" is not a boolean for "%s"'
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1019
        self.assertIs(None, get_bool('an_invalid_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1020
        self.assertEquals(msg % ('maybe', 'an_invalid_bool'), warnings[0])
1021
        warnings = []
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1022
        self.assertIs(None, get_bool('not_defined_in_this_config'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
1023
        self.assertEquals([], warnings)
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1024
1025
    def test_get_user_option_as_list(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1026
        conf, parser = self.make_config_parser("""
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1027
a_list = a,b,c
1028
length_1 = 1,
1029
one_item = x
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1030
""")
1031
        get_list = conf.get_user_option_as_list
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1032
        self.assertEqual(['a', 'b', 'c'], get_list('a_list'))
1033
        self.assertEqual(['1'], get_list('length_1'))
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1034
        self.assertEqual('x', conf.get_user_option('one_item'))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1035
        # automatically cast to list
1036
        self.assertEqual(['x'], get_list('one_item'))
1037
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1038
    def test_get_user_option_as_int_from_SI(self):
1039
        conf, parser = self.make_config_parser("""
1040
plain = 100
1041
si_k = 5k,
1042
si_kb = 5kb,
1043
si_m = 5M,
1044
si_mb = 5MB,
1045
si_g = 5g,
1046
si_gb = 5gB,
1047
""")
1048
        get_si = conf.get_user_option_as_int_from_SI
1049
        self.assertEqual(100, get_si('plain'))
1050
        self.assertEqual(5000, get_si('si_k'))
1051
        self.assertEqual(5000, get_si('si_kb'))
1052
        self.assertEqual(5000000, get_si('si_m'))
1053
        self.assertEqual(5000000, get_si('si_mb'))
1054
        self.assertEqual(5000000000, get_si('si_g'))
1055
        self.assertEqual(5000000000, get_si('si_gb'))
1056
        self.assertEqual(None, get_si('non-exist'))
1057
        self.assertEqual(42, get_si('non-exist-with-default',  42))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1058
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1059
class TestSupressWarning(TestIniConfig):
1060
1061
    def make_warnings_config(self, s):
1062
        conf, parser = self.make_config_parser(s)
1063
        return conf.suppress_warning
1064
1065
    def test_suppress_warning_unknown(self):
1066
        suppress_warning = self.make_warnings_config('')
1067
        self.assertEqual(False, suppress_warning('unknown_warning'))
1068
1069
    def test_suppress_warning_known(self):
1070
        suppress_warning = self.make_warnings_config('suppress_warnings=a,b')
1071
        self.assertEqual(False, suppress_warning('c'))
1072
        self.assertEqual(True, suppress_warning('a'))
1073
        self.assertEqual(True, suppress_warning('b'))
1074
1075
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1076
class TestGetConfig(tests.TestCase):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1077
1078
    def test_constructs(self):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1079
        my_config = config.GlobalConfig()
1080
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1081
    def test_calls_read_filenames(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1082
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1083
        oldparserclass = config.ConfigObj
1084
        config.ConfigObj = InstrumentedConfigObj
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1085
        my_config = config.GlobalConfig()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1086
        try:
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1087
            parser = my_config._get_parser()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1088
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1089
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1090
        self.assertIsInstance(parser, InstrumentedConfigObj)
1551.2.20 by Aaron Bentley
Treated config files as utf-8
1091
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
1092
                                          'utf-8')])
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1093
1094
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1095
class TestBranchConfig(tests.TestCaseWithTransport):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1096
1097
    def test_constructs(self):
1098
        branch = FakeBranch()
1099
        my_config = config.BranchConfig(branch)
1100
        self.assertRaises(TypeError, config.BranchConfig)
1101
1102
    def test_get_location_config(self):
1103
        branch = FakeBranch()
1104
        my_config = config.BranchConfig(branch)
1105
        location_config = my_config._get_location_config()
1106
        self.assertEqual(branch.base, location_config.location)
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1107
        self.assertIs(location_config, my_config._get_location_config())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1108
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1109
    def test_get_config(self):
1110
        """The Branch.get_config method works properly"""
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1111
        b = bzrdir.BzrDir.create_standalone_workingtree('.').branch
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1112
        my_config = b.get_config()
1113
        self.assertIs(my_config.get_user_option('wacky'), None)
1114
        my_config.set_user_option('wacky', 'unlikely')
1115
        self.assertEqual(my_config.get_user_option('wacky'), 'unlikely')
1116
1117
        # Ensure we get the same thing if we start again
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1118
        b2 = branch.Branch.open('.')
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1119
        my_config2 = b2.get_config()
1120
        self.assertEqual(my_config2.get_user_option('wacky'), 'unlikely')
1121
1824.1.1 by Robert Collins
Add BranchConfig.has_explicit_nickname call.
1122
    def test_has_explicit_nickname(self):
1123
        b = self.make_branch('.')
1124
        self.assertFalse(b.get_config().has_explicit_nickname())
1125
        b.nick = 'foo'
1126
        self.assertTrue(b.get_config().has_explicit_nickname())
1127
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1128
    def test_config_url(self):
1129
        """The Branch.get_config will use section that uses a local url"""
1130
        branch = self.make_branch('branch')
1131
        self.assertEqual('branch', branch.nick)
1132
1133
        local_url = urlutils.local_path_to_url('branch')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1134
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1135
            '[%s]\nnickname = foobar' % (local_url,),
1136
            local_url, save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1137
        self.assertEqual('foobar', branch.nick)
1138
1139
    def test_config_local_path(self):
1140
        """The Branch.get_config will use a local system path"""
1141
        branch = self.make_branch('branch')
1142
        self.assertEqual('branch', branch.nick)
1143
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1144
        local_path = osutils.getcwd().encode('utf8')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1145
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1146
            '[%s/branch]\nnickname = barry' % (local_path,),
1147
            'branch',  save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1148
        self.assertEqual('barry', branch.nick)
1149
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1150
    def test_config_creates_local(self):
1151
        """Creating a new entry in config uses a local path."""
2230.3.6 by Aaron Bentley
work in progress bind stuff
1152
        branch = self.make_branch('branch', format='knit')
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1153
        branch.set_push_location('http://foobar')
1154
        local_path = osutils.getcwd().encode('utf8')
1155
        # Surprisingly ConfigObj doesn't create a trailing newline
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1156
        self.check_file_contents(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1157
                                 '[%s/branch]\n'
1158
                                 'push_location = http://foobar\n'
3221.7.1 by Matt Nordhoff
Upgrade ConfigObj to version 4.5.1.
1159
                                 'push_location:policy = norecurse\n'
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1160
                                 % (local_path,))
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1161
2120.5.4 by Alexander Belchenko
Whitebox test for Config.get_nickname (req. by Aaron Bentley)
1162
    def test_autonick_urlencoded(self):
1163
        b = self.make_branch('!repo')
1164
        self.assertEqual('!repo', b.get_config().get_nickname())
1165
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1166
    def test_warn_if_masked(self):
1167
        warnings = []
1168
        def warning(*args):
1169
            warnings.append(args[0] % args[1:])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1170
        self.overrideAttr(trace, 'warning', warning)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1171
1172
        def set_option(store, warn_masked=True):
1173
            warnings[:] = []
1174
            conf.set_user_option('example_option', repr(store), store=store,
1175
                                 warn_masked=warn_masked)
1176
        def assertWarning(warning):
1177
            if warning is None:
1178
                self.assertEqual(0, len(warnings))
1179
            else:
1180
                self.assertEqual(1, len(warnings))
1181
                self.assertEqual(warning, warnings[0])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1182
        branch = self.make_branch('.')
1183
        conf = branch.get_config()
1184
        set_option(config.STORE_GLOBAL)
1185
        assertWarning(None)
1186
        set_option(config.STORE_BRANCH)
1187
        assertWarning(None)
1188
        set_option(config.STORE_GLOBAL)
1189
        assertWarning('Value "4" is masked by "3" from branch.conf')
1190
        set_option(config.STORE_GLOBAL, warn_masked=False)
1191
        assertWarning(None)
1192
        set_option(config.STORE_LOCATION)
1193
        assertWarning(None)
1194
        set_option(config.STORE_BRANCH)
1195
        assertWarning('Value "3" is masked by "0" from locations.conf')
1196
        set_option(config.STORE_BRANCH, warn_masked=False)
1197
        assertWarning(None)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1198
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1199
5448.1.1 by Vincent Ladeuil
Use TestCaseInTempDir for tests requiring disk resources
1200
class TestGlobalConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1201
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1202
    def test_user_id(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1203
        my_config = config.GlobalConfig.from_string(sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1204
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1205
                         my_config._get_user_id())
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1206
1207
    def test_absent_user_id(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1208
        my_config = config.GlobalConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1209
        self.assertEqual(None, my_config._get_user_id())
1210
1211
    def test_configured_editor(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1212
        my_config = config.GlobalConfig.from_string(sample_config_text)
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
1213
        editor = self.applyDeprecated(
1214
            deprecated_in((2, 4, 0)), my_config.get_editor)
1215
        self.assertEqual('vim', editor)
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1216
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1217
    def test_signatures_always(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1218
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1219
        self.assertEqual(config.CHECK_NEVER,
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1220
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1221
        self.assertEqual(config.SIGN_ALWAYS,
1222
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1223
        self.assertEqual(True, my_config.signature_needed())
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1224
1225
    def test_signatures_if_possible(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1226
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1227
        self.assertEqual(config.CHECK_NEVER,
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1228
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1229
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
1230
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1231
        self.assertEqual(False, my_config.signature_needed())
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1232
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1233
    def test_signatures_ignore(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1234
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1235
        self.assertEqual(config.CHECK_ALWAYS,
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1236
                         my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1237
        self.assertEqual(config.SIGN_NEVER,
1238
                         my_config.signing_policy())
1442.1.21 by Robert Collins
create signature_needed() call for commit to trigger creating signatures
1239
        self.assertEqual(False, my_config.signature_needed())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1240
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1241
    def _get_sample_config(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1242
        my_config = config.GlobalConfig.from_string(sample_config_text)
1534.7.154 by Aaron Bentley
Removed changes from bzr.ab 1529..1536
1243
        return my_config
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1244
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1245
    def test_gpg_signing_command(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1246
        my_config = self._get_sample_config()
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1247
        self.assertEqual("gnome-gpg", my_config.gpg_signing_command())
1248
        self.assertEqual(False, my_config.signature_needed())
1249
6012.2.3 by Jonathan Riddell
add config option for signing key
1250
    def test_gpg_signing_key(self):
1251
        my_config = self._get_sample_config()
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1252
        self.assertEqual("DD4D5088", my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1253
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1254
    def _get_empty_config(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1255
        my_config = config.GlobalConfig()
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1256
        return my_config
1257
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1258
    def test_gpg_signing_command_unset(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1259
        my_config = self._get_empty_config()
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1260
        self.assertEqual("gpg", my_config.gpg_signing_command())
1261
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1262
    def test_get_user_option_default(self):
1263
        my_config = self._get_empty_config()
1264
        self.assertEqual(None, my_config.get_user_option('no_option'))
1265
1266
    def test_get_user_option_global(self):
1267
        my_config = self._get_sample_config()
1268
        self.assertEqual("something",
1269
                         my_config.get_user_option('user_global_option'))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1270
1472 by Robert Collins
post commit hook, first pass implementation
1271
    def test_post_commit_default(self):
1272
        my_config = self._get_sample_config()
1273
        self.assertEqual(None, my_config.post_commit())
1274
1553.2.9 by Erik Bågfors
log_formatter => log_format for "named" formatters
1275
    def test_configured_logformat(self):
1553.2.8 by Erik Bågfors
tests for config log_formatter
1276
        my_config = self._get_sample_config()
1553.2.9 by Erik Bågfors
log_formatter => log_format for "named" formatters
1277
        self.assertEqual("short", my_config.log_format())
1553.2.8 by Erik Bågfors
tests for config log_formatter
1278
5971.1.58 by Jonathan Riddell
more tests for new config options
1279
    def test_configured_acceptable_keys(self):
1280
        my_config = self._get_sample_config()
1281
        self.assertEqual("amy", my_config.acceptable_keys())
1282
1283
    def test_configured_validate_signatures_in_log(self):
1284
        my_config = self._get_sample_config()
1285
        self.assertEqual(True, my_config.validate_signatures_in_log())
1286
1553.6.12 by Erik Bågfors
remove AliasConfig, based on input from abentley
1287
    def test_get_alias(self):
1288
        my_config = self._get_sample_config()
1289
        self.assertEqual('help', my_config.get_alias('h'))
1290
2900.3.6 by Tim Penhey
Added tests.
1291
    def test_get_aliases(self):
1292
        my_config = self._get_sample_config()
1293
        aliases = my_config.get_aliases()
1294
        self.assertEqual(2, len(aliases))
1295
        sorted_keys = sorted(aliases)
1296
        self.assertEqual('help', aliases[sorted_keys[0]])
1297
        self.assertEqual(sample_long_alias, aliases[sorted_keys[1]])
1298
1553.6.12 by Erik Bågfors
remove AliasConfig, based on input from abentley
1299
    def test_get_no_alias(self):
1300
        my_config = self._get_sample_config()
1301
        self.assertEqual(None, my_config.get_alias('foo'))
1302
1303
    def test_get_long_alias(self):
1304
        my_config = self._get_sample_config()
1305
        self.assertEqual(sample_long_alias, my_config.get_alias('ll'))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1306
4603.1.10 by Aaron Bentley
Provide change editor via config.
1307
    def test_get_change_editor(self):
1308
        my_config = self._get_sample_config()
1309
        change_editor = my_config.get_change_editor('old', 'new')
1310
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
1311
        self.assertEqual('vimdiff -of @new_path @old_path',
4603.1.10 by Aaron Bentley
Provide change editor via config.
1312
                         ' '.join(change_editor.command_template))
1313
1314
    def test_get_no_change_editor(self):
1315
        my_config = self._get_empty_config()
1316
        change_editor = my_config.get_change_editor('old', 'new')
1317
        self.assertIs(None, change_editor)
1318
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1319
    def test_get_merge_tools(self):
1320
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1321
        tools = conf.get_merge_tools()
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1322
        self.log(repr(tools))
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1323
        self.assertEqual(
1324
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
1325
            u'sometool' : u'sometool {base} {this} {other} -o {result}'},
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1326
            tools)
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1327
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1328
    def test_get_merge_tools_empty(self):
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1329
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1330
        tools = conf.get_merge_tools()
1331
        self.assertEqual({}, tools)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1332
1333
    def test_find_merge_tool(self):
1334
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1335
        cmdline = conf.find_merge_tool('sometool')
1336
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1337
1338
    def test_find_merge_tool_not_found(self):
1339
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1340
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
1341
        self.assertIs(cmdline, None)
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1342
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1343
    def test_find_merge_tool_known(self):
1344
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1345
        cmdline = conf.find_merge_tool('kdiff3')
1346
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
1347
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1348
    def test_find_merge_tool_override_known(self):
1349
        conf = self._get_empty_config()
5321.1.112 by Gordon Tyler
Removed set_merge_tool, remove_merge_tool and set_default_merge_tool from Config.
1350
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1351
        cmdline = conf.find_merge_tool('kdiff3')
1352
        self.assertEqual('kdiff3 blah', cmdline)
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1353
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1354
2900.3.6 by Tim Penhey
Added tests.
1355
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
1356
1357
    def test_empty(self):
1358
        my_config = config.GlobalConfig()
1359
        self.assertEqual(0, len(my_config.get_aliases()))
1360
1361
    def test_set_alias(self):
1362
        my_config = config.GlobalConfig()
1363
        alias_value = 'commit --strict'
1364
        my_config.set_alias('commit', alias_value)
1365
        new_config = config.GlobalConfig()
1366
        self.assertEqual(alias_value, new_config.get_alias('commit'))
1367
1368
    def test_remove_alias(self):
1369
        my_config = config.GlobalConfig()
1370
        my_config.set_alias('commit', 'commit --strict')
1371
        # Now remove the alias again.
1372
        my_config.unset_alias('commit')
1373
        new_config = config.GlobalConfig()
1374
        self.assertIs(None, new_config.get_alias('commit'))
1375
1376
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1377
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1378
1379
    def test_constructs(self):
1380
        my_config = config.LocationConfig('http://example.com')
1381
        self.assertRaises(TypeError, config.LocationConfig)
1382
1383
    def test_branch_calls_read_filenames(self):
1474 by Robert Collins
Merge from Aaron Bentley.
1384
        # This is testing the correct file names are provided.
1385
        # TODO: consolidate with the test for GlobalConfigs filename checks.
1386
        #
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1387
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1388
        oldparserclass = config.ConfigObj
1389
        config.ConfigObj = InstrumentedConfigObj
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1390
        try:
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1391
            my_config = config.LocationConfig('http://www.example.com')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1392
            parser = my_config._get_parser()
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1393
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1394
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1395
        self.assertIsInstance(parser, InstrumentedConfigObj)
1474 by Robert Collins
Merge from Aaron Bentley.
1396
        self.assertEqual(parser._calls,
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1397
                         [('__init__', config.locations_config_filename(),
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1398
                           'utf-8')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1399
1400
    def test_get_global_config(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1401
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1402
        global_config = my_config._get_global_config()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1403
        self.assertIsInstance(global_config, config.GlobalConfig)
1404
        self.assertIs(global_config, my_config._get_global_config())
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1405
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1406
    def assertLocationMatching(self, expected):
1407
        self.assertEqual(expected,
1408
                         list(self.my_location_config._get_matching_sections()))
1409
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1410
    def test__get_matching_sections_no_match(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1411
        self.get_branch_config('/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1412
        self.assertLocationMatching([])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1413
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1414
    def test__get_matching_sections_exact(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1415
        self.get_branch_config('http://www.example.com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1416
        self.assertLocationMatching([('http://www.example.com', '')])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1417
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1418
    def test__get_matching_sections_suffix_does_not(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1419
        self.get_branch_config('http://www.example.com-com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1420
        self.assertLocationMatching([])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1421
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1422
    def test__get_matching_sections_subdir_recursive(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1423
        self.get_branch_config('http://www.example.com/com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1424
        self.assertLocationMatching([('http://www.example.com', 'com')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1425
1993.3.5 by James Henstridge
add back recurse=False option to config file
1426
    def test__get_matching_sections_ignoreparent(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1427
        self.get_branch_config('http://www.example.com/ignoreparent')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1428
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1429
                                      '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1430
1993.3.5 by James Henstridge
add back recurse=False option to config file
1431
    def test__get_matching_sections_ignoreparent_subdir(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1432
        self.get_branch_config(
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1433
            'http://www.example.com/ignoreparent/childbranch')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1434
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1435
                                      'childbranch')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1436
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1437
    def test__get_matching_sections_subdir_trailing_slash(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1438
        self.get_branch_config('/b')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1439
        self.assertLocationMatching([('/b/', '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1440
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1441
    def test__get_matching_sections_subdir_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1442
        self.get_branch_config('/a/foo')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1443
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1444
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1445
    def test__get_matching_sections_subdir_child_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1446
        self.get_branch_config('/a/foo/bar')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1447
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1448
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1449
    def test__get_matching_sections_trailing_slash_with_children(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1450
        self.get_branch_config('/a/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1451
        self.assertLocationMatching([('/a/', '')])
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1452
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1453
    def test__get_matching_sections_explicit_over_glob(self):
1454
        # XXX: 2006-09-08 jamesh
1455
        # This test only passes because ord('c') > ord('*').  If there
1456
        # was a config section for '/a/?', it would get precedence
1457
        # over '/a/c'.
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1458
        self.get_branch_config('/a/c')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1459
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1460
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1461
    def test__get_option_policy_normal(self):
1462
        self.get_branch_config('http://www.example.com')
1463
        self.assertEqual(
1464
            self.my_location_config._get_config_policy(
1465
            'http://www.example.com', 'normal_option'),
1466
            config.POLICY_NONE)
1467
1468
    def test__get_option_policy_norecurse(self):
1469
        self.get_branch_config('http://www.example.com')
1470
        self.assertEqual(
1471
            self.my_location_config._get_option_policy(
1472
            'http://www.example.com', 'norecurse_option'),
1473
            config.POLICY_NORECURSE)
1474
        # Test old recurse=False setting:
1475
        self.assertEqual(
1476
            self.my_location_config._get_option_policy(
1477
            'http://www.example.com/norecurse', 'normal_option'),
1478
            config.POLICY_NORECURSE)
1479
1480
    def test__get_option_policy_normal(self):
1481
        self.get_branch_config('http://www.example.com')
1482
        self.assertEqual(
1483
            self.my_location_config._get_option_policy(
1484
            'http://www.example.com', 'appendpath_option'),
1485
            config.POLICY_APPENDPATH)
1486
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1487
    def test__get_options_with_policy(self):
1488
        self.get_branch_config('/dir/subdir',
1489
                               location_config="""\
1490
[/dir]
1491
other_url = /other-dir
1492
other_url:policy = appendpath
1493
[/dir/subdir]
1494
other_url = /other-subdir
1495
""")
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1496
        self.assertOptions(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1497
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
1498
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
1499
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1500
            self.my_location_config)
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1501
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1502
    def test_location_without_username(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1503
        self.get_branch_config('http://www.example.com/ignoreparent')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1504
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1505
                         self.my_config.username())
1506
1507
    def test_location_not_listed(self):
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1508
        """Test that the global username is used when no location matches"""
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1509
        self.get_branch_config('/home/robertc/sources')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1510
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1511
                         self.my_config.username())
1512
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1513
    def test_overriding_location(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1514
        self.get_branch_config('http://www.example.com/foo')
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1515
        self.assertEqual('Robert Collins <robertc@example.org>',
1516
                         self.my_config.username())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1517
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1518
    def test_signatures_not_set(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1519
        self.get_branch_config('http://www.example.com',
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1520
                                 global_config=sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1521
        self.assertEqual(config.CHECK_ALWAYS,
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1522
                         self.my_config.signature_checking())
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1523
        self.assertEqual(config.SIGN_NEVER,
1524
                         self.my_config.signing_policy())
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1525
1526
    def test_signatures_never(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1527
        self.get_branch_config('/a/c')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1528
        self.assertEqual(config.CHECK_NEVER,
1529
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1530
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1531
    def test_signatures_when_available(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1532
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1533
        self.assertEqual(config.CHECK_IF_POSSIBLE,
1534
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1535
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1536
    def test_signatures_always(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1537
        self.get_branch_config('/b')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1538
        self.assertEqual(config.CHECK_ALWAYS,
1539
                         self.my_config.signature_checking())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1540
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1541
    def test_gpg_signing_command(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1542
        self.get_branch_config('/b')
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1543
        self.assertEqual("gnome-gpg", self.my_config.gpg_signing_command())
1544
1545
    def test_gpg_signing_command_missing(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1546
        self.get_branch_config('/a')
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1547
        self.assertEqual("false", self.my_config.gpg_signing_command())
1548
6012.2.3 by Jonathan Riddell
add config option for signing key
1549
    def test_gpg_signing_key(self):
1550
        self.get_branch_config('/b')
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1551
        self.assertEqual("DD4D5088", self.my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1552
6012.2.9 by Jonathan Riddell
fixes 68501
1553
    def test_gpg_signing_key_default(self):
6012.2.3 by Jonathan Riddell
add config option for signing key
1554
        self.get_branch_config('/a')
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
1555
        self.assertEqual("erik@bagfors.nu", self.my_config.gpg_signing_key())
6012.2.3 by Jonathan Riddell
add config option for signing key
1556
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1557
    def test_get_user_option_global(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1558
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1559
        self.assertEqual('something',
1560
                         self.my_config.get_user_option('user_global_option'))
1561
1562
    def test_get_user_option_local(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1563
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1564
        self.assertEqual('local',
1565
                         self.my_config.get_user_option('user_local_option'))
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1566
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1567
    def test_get_user_option_appendpath(self):
1568
        # returned as is for the base path:
1569
        self.get_branch_config('http://www.example.com')
1570
        self.assertEqual('append',
1571
                         self.my_config.get_user_option('appendpath_option'))
1572
        # Extra path components get appended:
1573
        self.get_branch_config('http://www.example.com/a/b/c')
1574
        self.assertEqual('append/a/b/c',
1575
                         self.my_config.get_user_option('appendpath_option'))
1576
        # Overriden for http://www.example.com/dir, where it is a
1577
        # normal option:
1578
        self.get_branch_config('http://www.example.com/dir/a/b/c')
1579
        self.assertEqual('normal',
1580
                         self.my_config.get_user_option('appendpath_option'))
1581
1582
    def test_get_user_option_norecurse(self):
1583
        self.get_branch_config('http://www.example.com')
1584
        self.assertEqual('norecurse',
1585
                         self.my_config.get_user_option('norecurse_option'))
1586
        self.get_branch_config('http://www.example.com/dir')
1587
        self.assertEqual(None,
1588
                         self.my_config.get_user_option('norecurse_option'))
1589
        # http://www.example.com/norecurse is a recurse=False section
1590
        # that redefines normal_option.  Subdirectories do not pick up
1591
        # this redefinition.
1592
        self.get_branch_config('http://www.example.com/norecurse')
1593
        self.assertEqual('norecurse',
1594
                         self.my_config.get_user_option('normal_option'))
1595
        self.get_branch_config('http://www.example.com/norecurse/subdir')
1596
        self.assertEqual('normal',
1597
                         self.my_config.get_user_option('normal_option'))
1598
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1599
    def test_set_user_option_norecurse(self):
1600
        self.get_branch_config('http://www.example.com')
1601
        self.my_config.set_user_option('foo', 'bar',
1602
                                       store=config.STORE_LOCATION_NORECURSE)
1603
        self.assertEqual(
1604
            self.my_location_config._get_option_policy(
1605
            'http://www.example.com', 'foo'),
1606
            config.POLICY_NORECURSE)
1607
1608
    def test_set_user_option_appendpath(self):
1609
        self.get_branch_config('http://www.example.com')
1610
        self.my_config.set_user_option('foo', 'bar',
1611
                                       store=config.STORE_LOCATION_APPENDPATH)
1612
        self.assertEqual(
1613
            self.my_location_config._get_option_policy(
1614
            'http://www.example.com', 'foo'),
1615
            config.POLICY_APPENDPATH)
1616
1617
    def test_set_user_option_change_policy(self):
1618
        self.get_branch_config('http://www.example.com')
1619
        self.my_config.set_user_option('norecurse_option', 'normal',
1620
                                       store=config.STORE_LOCATION)
1621
        self.assertEqual(
1622
            self.my_location_config._get_option_policy(
1623
            'http://www.example.com', 'norecurse_option'),
1624
            config.POLICY_NONE)
1625
1626
    def test_set_user_option_recurse_false_section(self):
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1627
        # The following section has recurse=False set.  The test is to
1628
        # make sure that a normal option can be added to the section,
1629
        # converting recurse=False to the norecurse policy.
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1630
        self.get_branch_config('http://www.example.com/norecurse')
2120.6.11 by James Henstridge
s/0.13/0.14/ in deprecation warning
1631
        self.callDeprecated(['The recurse option is deprecated as of 0.14.  '
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1632
                             'The section "http://www.example.com/norecurse" '
1633
                             'has been converted to use policies.'],
1634
                            self.my_config.set_user_option,
1635
                            'foo', 'bar', store=config.STORE_LOCATION)
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1636
        self.assertEqual(
1637
            self.my_location_config._get_option_policy(
1638
            'http://www.example.com/norecurse', 'foo'),
1639
            config.POLICY_NONE)
1640
        # The previously existing option is still norecurse:
1641
        self.assertEqual(
1642
            self.my_location_config._get_option_policy(
1643
            'http://www.example.com/norecurse', 'normal_option'),
1644
            config.POLICY_NORECURSE)
1645
1472 by Robert Collins
post commit hook, first pass implementation
1646
    def test_post_commit_default(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1647
        self.get_branch_config('/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1648
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1472 by Robert Collins
post commit hook, first pass implementation
1649
                         self.my_config.post_commit())
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1650
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1651
    def get_branch_config(self, location, global_config=None,
1652
                          location_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1653
        my_branch = FakeBranch(location)
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1654
        if global_config is None:
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1655
            global_config = sample_config_text
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1656
        if location_config is None:
1657
            location_config = sample_branches_text
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1658
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1659
        my_global_config = config.GlobalConfig.from_string(global_config,
1660
                                                           save=True)
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1661
        my_location_config = config.LocationConfig.from_string(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1662
            location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1663
        my_config = config.BranchConfig(my_branch)
1664
        self.my_config = my_config
1665
        self.my_location_config = my_config._get_location_config()
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1666
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1667
    def test_set_user_setting_sets_and_saves(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1668
        self.get_branch_config('/a/c')
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1669
        record = InstrumentedConfigObj("foo")
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1670
        self.my_location_config._parser = record
1185.62.6 by John Arbash Meinel
Updated test_set_user_setting_sets_and_saves to remove the print statement, and make sure it is doing the right thing
1671
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1672
        self.callDeprecated(['The recurse option is deprecated as of '
1673
                             '0.14.  The section "/a/c" has been '
1674
                             'converted to use policies.'],
1675
                            self.my_config.set_user_option,
1676
                            'foo', 'bar', store=config.STORE_LOCATION)
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
1677
        self.assertEqual([('reload',),
1678
                          ('__contains__', '/a/c'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1679
                          ('__contains__', '/a/c/'),
1680
                          ('__setitem__', '/a/c', {}),
1681
                          ('__getitem__', '/a/c'),
1682
                          ('__setitem__', 'foo', 'bar'),
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1683
                          ('__getitem__', '/a/c'),
1684
                          ('as_bool', 'recurse'),
1685
                          ('__getitem__', '/a/c'),
1686
                          ('__delitem__', 'recurse'),
1687
                          ('__getitem__', '/a/c'),
1688
                          ('keys',),
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
1689
                          ('__getitem__', '/a/c'),
1690
                          ('__contains__', 'foo:policy'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1691
                          ('write',)],
1692
                         record._calls[1:])
1693
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1694
    def test_set_user_setting_sets_and_saves2(self):
1695
        self.get_branch_config('/a/c')
1696
        self.assertIs(self.my_config.get_user_option('foo'), None)
1697
        self.my_config.set_user_option('foo', 'bar')
1698
        self.assertEqual(
3616.2.6 by Mark Hammond
Fix test_set_user_setting_sets_and_saves2 on windows by stripping EOL
1699
            self.my_config.branch.control_files.files['branch.conf'].strip(),
1700
            'foo = bar')
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1701
        self.assertEqual(self.my_config.get_user_option('foo'), 'bar')
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1702
        self.my_config.set_user_option('foo', 'baz',
1703
                                       store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1704
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
1705
        self.my_config.set_user_option('foo', 'qux')
1706
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1707
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1708
    def test_get_bzr_remote_path(self):
1709
        my_config = config.LocationConfig('/a/c')
1710
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1711
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1712
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1713
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1714
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1715
1185.62.7 by John Arbash Meinel
Whitespace cleanup.
1716
1770.2.8 by Aaron Bentley
Add precedence test
1717
precedence_global = 'option = global'
1718
precedence_branch = 'option = branch'
1719
precedence_location = """
1720
[http://]
1721
recurse = true
1722
option = recurse
1723
[http://example.com/specific]
1724
option = exact
1725
"""
1726
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1727
class TestBranchConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1728
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1729
    def get_branch_config(self, global_config=None, location=None,
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1730
                          location_config=None, branch_data_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1731
        my_branch = FakeBranch(location)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1732
        if global_config is not None:
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1733
            my_global_config = config.GlobalConfig.from_string(global_config,
1734
                                                               save=True)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1735
        if location_config is not None:
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1736
            my_location_config = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1737
                location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1738
        my_config = config.BranchConfig(my_branch)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1739
        if branch_data_config is not None:
1740
            my_config.branch.control_files.files['branch.conf'] = \
1741
                branch_data_config
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1742
        return my_config
1743
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1744
    def test_user_id(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1745
        branch = FakeBranch(user_id='Robert Collins <robertc@example.net>')
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1746
        my_config = config.BranchConfig(branch)
1747
        self.assertEqual("Robert Collins <robertc@example.net>",
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1748
                         my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1749
        my_config.branch.control_files.files['email'] = "John"
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1750
        my_config.set_user_option('email',
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1751
                                  "Robert Collins <robertc@example.org>")
1752
        self.assertEqual("John", my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1753
        del my_config.branch.control_files.files['email']
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1754
        self.assertEqual("Robert Collins <robertc@example.org>",
1755
                         my_config.username())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1756
1757
    def test_not_set_in_branch(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1758
        my_config = self.get_branch_config(global_config=sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1759
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1760
                         my_config._get_user_id())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1761
        my_config.branch.control_files.files['email'] = "John"
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1762
        self.assertEqual("John", my_config._get_user_id())
1763
1861.4.1 by Matthieu Moy
BZREMAIL renamed to BZR_EMAIL.
1764
    def test_BZR_EMAIL_OVERRIDES(self):
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1765
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1766
        branch = FakeBranch()
1767
        my_config = config.BranchConfig(branch)
1768
        self.assertEqual("Robert Collins <robertc@example.org>",
1769
                         my_config.username())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1770
1442.1.19 by Robert Collins
BranchConfigs inherit signature_checking policy from their LocationConfig.
1771
    def test_signatures_forced(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1772
        my_config = self.get_branch_config(
1773
            global_config=sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1774
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1775
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1776
        self.assertTrue(my_config.signature_needed())
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1777
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1778
    def test_signatures_forced_branch(self):
1779
        my_config = self.get_branch_config(
1780
            global_config=sample_ignore_signatures,
1781
            branch_data_config=sample_always_signatures)
1782
        self.assertEqual(config.CHECK_NEVER, my_config.signature_checking())
1783
        self.assertEqual(config.SIGN_ALWAYS, my_config.signing_policy())
1784
        self.assertTrue(my_config.signature_needed())
1785
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1786
    def test_gpg_signing_command(self):
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1787
        my_config = self.get_branch_config(
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1788
            global_config=sample_config_text,
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1789
            # branch data cannot set gpg_signing_command
1790
            branch_data_config="gpg_signing_command=pgp")
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1791
        self.assertEqual('gnome-gpg', my_config.gpg_signing_command())
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1792
1793
    def test_get_user_option_global(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1794
        my_config = self.get_branch_config(global_config=sample_config_text)
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1795
        self.assertEqual('something',
1796
                         my_config.get_user_option('user_global_option'))
1472 by Robert Collins
post commit hook, first pass implementation
1797
1798
    def test_post_commit_default(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1799
        my_config = self.get_branch_config(global_config=sample_config_text,
1800
                                      location='/a/c',
1801
                                      location_config=sample_branches_text)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1802
        self.assertEqual(my_config.branch.base, '/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1803
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1472 by Robert Collins
post commit hook, first pass implementation
1804
                         my_config.post_commit())
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1805
        my_config.set_user_option('post_commit', 'rmtree_root')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1806
        # post-commit is ignored when present in branch data
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1807
        self.assertEqual('bzrlib.tests.test_config.post_commit',
1808
                         my_config.post_commit())
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1809
        my_config.set_user_option('post_commit', 'rmtree_root',
1810
                                  store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1811
        self.assertEqual('rmtree_root', my_config.post_commit())
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1812
1770.2.8 by Aaron Bentley
Add precedence test
1813
    def test_config_precedence(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1814
        # FIXME: eager test, luckily no persitent config file makes it fail
1815
        # -- vila 20100716
1770.2.8 by Aaron Bentley
Add precedence test
1816
        my_config = self.get_branch_config(global_config=precedence_global)
1817
        self.assertEqual(my_config.get_user_option('option'), 'global')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1818
        my_config = self.get_branch_config(global_config=precedence_global,
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1819
                                           branch_data_config=precedence_branch)
1770.2.8 by Aaron Bentley
Add precedence test
1820
        self.assertEqual(my_config.get_user_option('option'), 'branch')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1821
        my_config = self.get_branch_config(
1822
            global_config=precedence_global,
1823
            branch_data_config=precedence_branch,
1824
            location_config=precedence_location)
1770.2.8 by Aaron Bentley
Add precedence test
1825
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1826
        my_config = self.get_branch_config(
1827
            global_config=precedence_global,
1828
            branch_data_config=precedence_branch,
1829
            location_config=precedence_location,
1830
            location='http://example.com/specific')
1770.2.8 by Aaron Bentley
Add precedence test
1831
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1832
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
1833
    def test_get_mail_client(self):
1834
        config = self.get_branch_config()
1835
        client = config.get_mail_client()
2681.1.24 by Aaron Bentley
Handle default mail client by trying xdg-email, falling back to editor
1836
        self.assertIsInstance(client, mail_client.DefaultMail)
1837
2790.2.2 by Keir Mierle
Change alphabetic ordering into two categories; one for specific clients the other for generic options.
1838
        # Specific clients
2681.1.21 by Aaron Bentley
Refactor prompt generation to make it testable, test it with unicode
1839
        config.set_user_option('mail_client', 'evolution')
1840
        client = config.get_mail_client()
1841
        self.assertIsInstance(client, mail_client.Evolution)
1842
2681.5.1 by ghigo
Add KMail support to bzr send
1843
        config.set_user_option('mail_client', 'kmail')
1844
        client = config.get_mail_client()
1845
        self.assertIsInstance(client, mail_client.KMail)
1846
2790.2.1 by Keir Mierle
Add Mutt as a supported client email program. Also rearranges various listings
1847
        config.set_user_option('mail_client', 'mutt')
1848
        client = config.get_mail_client()
1849
        self.assertIsInstance(client, mail_client.Mutt)
1850
1851
        config.set_user_option('mail_client', 'thunderbird')
1852
        client = config.get_mail_client()
1853
        self.assertIsInstance(client, mail_client.Thunderbird)
1854
2790.2.2 by Keir Mierle
Change alphabetic ordering into two categories; one for specific clients the other for generic options.
1855
        # Generic options
1856
        config.set_user_option('mail_client', 'default')
1857
        client = config.get_mail_client()
1858
        self.assertIsInstance(client, mail_client.DefaultMail)
1859
1860
        config.set_user_option('mail_client', 'editor')
1861
        client = config.get_mail_client()
1862
        self.assertIsInstance(client, mail_client.Editor)
1863
1864
        config.set_user_option('mail_client', 'mapi')
1865
        client = config.get_mail_client()
1866
        self.assertIsInstance(client, mail_client.MAPIClient)
1867
2681.1.23 by Aaron Bentley
Add support for xdg-email
1868
        config.set_user_option('mail_client', 'xdg-email')
1869
        client = config.get_mail_client()
1870
        self.assertIsInstance(client, mail_client.XDGEmail)
1871
2681.1.10 by Aaron Bentley
Clean up handling of unknown mail clients
1872
        config.set_user_option('mail_client', 'firebird')
1873
        self.assertRaises(errors.UnknownMailClient, config.get_mail_client)
1874
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1875
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1876
class TestMailAddressExtraction(tests.TestCase):
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1877
1878
    def test_extract_email_address(self):
1879
        self.assertEqual('jane@test.com',
1880
                         config.extract_email_address('Jane <jane@test.com>'))
2055.2.2 by John Arbash Meinel
Switch extract_email_address() to use a more specific exception
1881
        self.assertRaises(errors.NoEmailInUsername,
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1882
                          config.extract_email_address, 'Jane Tester')
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1883
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1884
    def test_parse_username(self):
1885
        self.assertEqual(('', 'jdoe@example.com'),
1886
                         config.parse_username('jdoe@example.com'))
1887
        self.assertEqual(('', 'jdoe@example.com'),
1888
                         config.parse_username('<jdoe@example.com>'))
1889
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1890
                         config.parse_username('John Doe <jdoe@example.com>'))
1891
        self.assertEqual(('John Doe', ''),
1892
                         config.parse_username('John Doe'))
3063.3.3 by Lukáš Lalinský
Add one more test for config.parse_username().
1893
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1894
                         config.parse_username('John Doe jdoe@example.com'))
2562.1.2 by John Arbash Meinel
Clean up whitespace
1895
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1896
class TestTreeConfig(tests.TestCaseWithTransport):
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1897
1898
    def test_get_value(self):
1899
        """Test that retreiving a value from a section is possible"""
1900
        branch = self.make_branch('.')
1901
        tree_config = config.TreeConfig(branch)
1902
        tree_config.set_option('value', 'key', 'SECTION')
1903
        tree_config.set_option('value2', 'key2')
1904
        tree_config.set_option('value3-top', 'key3')
1905
        tree_config.set_option('value3-section', 'key3', 'SECTION')
1906
        value = tree_config.get_option('key', 'SECTION')
1907
        self.assertEqual(value, 'value')
1908
        value = tree_config.get_option('key2')
1909
        self.assertEqual(value, 'value2')
1910
        self.assertEqual(tree_config.get_option('non-existant'), None)
1911
        value = tree_config.get_option('non-existant', 'SECTION')
1912
        self.assertEqual(value, None)
1913
        value = tree_config.get_option('non-existant', default='default')
1914
        self.assertEqual(value, 'default')
1915
        self.assertEqual(tree_config.get_option('key2', 'NOSECTION'), None)
1916
        value = tree_config.get_option('key2', 'NOSECTION', default='default')
1917
        self.assertEqual(value, 'default')
1918
        value = tree_config.get_option('key3')
1919
        self.assertEqual(value, 'value3-top')
1920
        value = tree_config.get_option('key3', 'SECTION')
1921
        self.assertEqual(value, 'value3-section')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
1922
1923
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1924
class TestTransportConfig(tests.TestCaseWithTransport):
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1925
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1926
    def test_load_utf8(self):
1927
        """Ensure we can load an utf8-encoded file."""
1928
        t = self.get_transport()
1929
        unicode_user = u'b\N{Euro Sign}ar'
1930
        unicode_content = u'user=%s' % (unicode_user,)
1931
        utf8_content = unicode_content.encode('utf8')
1932
        # Store the raw content in the config file
1933
        t.put_bytes('foo.conf', utf8_content)
1934
        conf = config.TransportConfig(t, 'foo.conf')
1935
        self.assertEquals(unicode_user, conf.get_option('user'))
1936
1937
    def test_load_non_ascii(self):
1938
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
1939
        t = self.get_transport()
1940
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
1941
        conf = config.TransportConfig(t, 'foo.conf')
1942
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
1943
1944
    def test_load_erroneous_content(self):
1945
        """Ensure we display a proper error on content that can't be parsed."""
1946
        t = self.get_transport()
1947
        t.put_bytes('foo.conf', '[open_section\n')
1948
        conf = config.TransportConfig(t, 'foo.conf')
1949
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
1950
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1951
    def test_get_value(self):
1952
        """Test that retreiving a value from a section is possible"""
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1953
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1954
                                               'control.conf')
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1955
        bzrdir_config.set_option('value', 'key', 'SECTION')
1956
        bzrdir_config.set_option('value2', 'key2')
1957
        bzrdir_config.set_option('value3-top', 'key3')
1958
        bzrdir_config.set_option('value3-section', 'key3', 'SECTION')
1959
        value = bzrdir_config.get_option('key', 'SECTION')
1960
        self.assertEqual(value, 'value')
1961
        value = bzrdir_config.get_option('key2')
1962
        self.assertEqual(value, 'value2')
1963
        self.assertEqual(bzrdir_config.get_option('non-existant'), None)
1964
        value = bzrdir_config.get_option('non-existant', 'SECTION')
1965
        self.assertEqual(value, None)
1966
        value = bzrdir_config.get_option('non-existant', default='default')
1967
        self.assertEqual(value, 'default')
1968
        self.assertEqual(bzrdir_config.get_option('key2', 'NOSECTION'), None)
1969
        value = bzrdir_config.get_option('key2', 'NOSECTION',
1970
                                         default='default')
1971
        self.assertEqual(value, 'default')
1972
        value = bzrdir_config.get_option('key3')
1973
        self.assertEqual(value, 'value3-top')
1974
        value = bzrdir_config.get_option('key3', 'SECTION')
1975
        self.assertEqual(value, 'value3-section')
1976
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1977
    def test_set_unset_default_stack_on(self):
1978
        my_dir = self.make_bzrdir('.')
4288.1.3 by Robert Collins
Fix BzrDirConfig tests.
1979
        bzrdir_config = config.BzrDirConfig(my_dir)
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1980
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1981
        bzrdir_config.set_default_stack_on('Foo')
3242.3.14 by Aaron Bentley
Make BzrDirConfig use TransportConfig
1982
        self.assertEqual('Foo', bzrdir_config._config.get_option(
1983
                         'default_stack_on'))
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1984
        self.assertEqual('Foo', bzrdir_config.get_default_stack_on())
1985
        bzrdir_config.set_default_stack_on(None)
1986
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1987
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1988
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
1989
class TestOldConfigHooks(tests.TestCaseWithTransport):
1990
1991
    def setUp(self):
1992
        super(TestOldConfigHooks, self).setUp()
1993
        create_configs_with_file_option(self)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
1994
1995
    def assertGetHook(self, conf, name, value):
1996
        calls = []
1997
        def hook(*args):
1998
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
1999
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2000
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2001
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2002
        self.assertLength(0, calls)
2003
        actual_value = conf.get_user_option(name)
2004
        self.assertEquals(value, actual_value)
2005
        self.assertLength(1, calls)
2006
        self.assertEquals((conf, name, value), calls[0])
2007
2008
    def test_get_hook_bazaar(self):
2009
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
2010
2011
    def test_get_hook_locations(self):
2012
        self.assertGetHook(self.locations_config, 'file', 'locations')
2013
2014
    def test_get_hook_branch(self):
2015
        # Since locations masks branch, we define a different option
2016
        self.branch_config.set_user_option('file2', 'branch')
2017
        self.assertGetHook(self.branch_config, 'file2', 'branch')
2018
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2019
    def assertSetHook(self, conf, name, value):
2020
        calls = []
2021
        def hook(*args):
2022
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2023
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2024
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2025
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2026
        self.assertLength(0, calls)
2027
        conf.set_user_option(name, value)
2028
        self.assertLength(1, calls)
2029
        # We can't assert the conf object below as different configs use
2030
        # different means to implement set_user_option and we care only about
2031
        # coverage here.
2032
        self.assertEquals((name, value), calls[0][1:])
2033
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2034
    def test_set_hook_bazaar(self):
2035
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
2036
2037
    def test_set_hook_locations(self):
2038
        self.assertSetHook(self.locations_config, 'foo', 'locations')
2039
2040
    def test_set_hook_branch(self):
2041
        self.assertSetHook(self.branch_config, 'foo', 'branch')
2042
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2043
    def assertRemoveHook(self, conf, name, section_name=None):
2044
        calls = []
2045
        def hook(*args):
2046
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2047
        config.OldConfigHooks.install_named_hook('remove', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2048
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2049
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2050
        self.assertLength(0, calls)
2051
        conf.remove_user_option(name, section_name)
2052
        self.assertLength(1, calls)
2053
        # We can't assert the conf object below as different configs use
2054
        # different means to implement remove_user_option and we care only about
2055
        # coverage here.
2056
        self.assertEquals((name,), calls[0][1:])
2057
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2058
    def test_remove_hook_bazaar(self):
2059
        self.assertRemoveHook(self.bazaar_config, 'file')
2060
2061
    def test_remove_hook_locations(self):
2062
        self.assertRemoveHook(self.locations_config, 'file',
2063
                              self.locations_config.location)
2064
2065
    def test_remove_hook_branch(self):
2066
        self.assertRemoveHook(self.branch_config, 'file')
2067
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2068
    def assertLoadHook(self, name, conf_class, *conf_args):
2069
        calls = []
2070
        def hook(*args):
2071
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2072
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2073
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2074
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2075
        self.assertLength(0, calls)
2076
        # Build a config
2077
        conf = conf_class(*conf_args)
2078
        # Access an option to trigger a load
2079
        conf.get_user_option(name)
2080
        self.assertLength(1, calls)
2081
        # Since we can't assert about conf, we just use the number of calls ;-/
2082
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2083
    def test_load_hook_bazaar(self):
2084
        self.assertLoadHook('file', config.GlobalConfig)
2085
2086
    def test_load_hook_locations(self):
2087
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
2088
2089
    def test_load_hook_branch(self):
2090
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
2091
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2092
    def assertSaveHook(self, conf):
2093
        calls = []
2094
        def hook(*args):
2095
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2096
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2097
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2098
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2099
        self.assertLength(0, calls)
2100
        # Setting an option triggers a save
2101
        conf.set_user_option('foo', 'bar')
2102
        self.assertLength(1, calls)
2103
        # Since we can't assert about conf, we just use the number of calls ;-/
2104
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2105
    def test_save_hook_bazaar(self):
2106
        self.assertSaveHook(self.bazaar_config)
2107
2108
    def test_save_hook_locations(self):
2109
        self.assertSaveHook(self.locations_config)
2110
2111
    def test_save_hook_branch(self):
2112
        self.assertSaveHook(self.branch_config)
2113
2114
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2115
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
2116
    """Tests config hooks for remote configs.
2117
2118
    No tests for the remove hook as this is not implemented there.
2119
    """
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2120
2121
    def setUp(self):
2122
        super(TestOldConfigHooksForRemote, self).setUp()
2123
        self.transport_server = test_server.SmartTCPServer_for_testing
2124
        create_configs_with_file_option(self)
2125
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2126
    def assertGetHook(self, conf, name, value):
2127
        calls = []
2128
        def hook(*args):
2129
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2130
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2131
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2132
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2133
        self.assertLength(0, calls)
2134
        actual_value = conf.get_option(name)
2135
        self.assertEquals(value, actual_value)
2136
        self.assertLength(1, calls)
2137
        self.assertEquals((conf, name, value), calls[0])
2138
2139
    def test_get_hook_remote_branch(self):
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2140
        remote_branch = branch.Branch.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2141
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2142
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2143
    def test_get_hook_remote_bzrdir(self):
2144
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2145
        conf = remote_bzrdir._get_config()
2146
        conf.set_option('remotedir', 'file')
2147
        self.assertGetHook(conf, 'file', 'remotedir')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2148
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2149
    def assertSetHook(self, conf, name, value):
2150
        calls = []
2151
        def hook(*args):
2152
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2153
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2154
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2155
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2156
        self.assertLength(0, calls)
2157
        conf.set_option(value, name)
2158
        self.assertLength(1, calls)
2159
        # We can't assert the conf object below as different configs use
2160
        # different means to implement set_user_option and we care only about
2161
        # coverage here.
2162
        self.assertEquals((name, value), calls[0][1:])
2163
2164
    def test_set_hook_remote_branch(self):
2165
        remote_branch = branch.Branch.open(self.get_url('tree'))
2166
        self.addCleanup(remote_branch.lock_write().unlock)
2167
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
2168
2169
    def test_set_hook_remote_bzrdir(self):
2170
        remote_branch = branch.Branch.open(self.get_url('tree'))
2171
        self.addCleanup(remote_branch.lock_write().unlock)
2172
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2173
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
2174
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2175
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
2176
        calls = []
2177
        def hook(*args):
2178
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2179
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2180
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2181
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2182
        self.assertLength(0, calls)
2183
        # Build a config
2184
        conf = conf_class(*conf_args)
2185
        # Access an option to trigger a load
2186
        conf.get_option(name)
2187
        self.assertLength(expected_nb_calls, calls)
2188
        # Since we can't assert about conf, we just use the number of calls ;-/
2189
2190
    def test_load_hook_remote_branch(self):
2191
        remote_branch = branch.Branch.open(self.get_url('tree'))
2192
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
2193
2194
    def test_load_hook_remote_bzrdir(self):
2195
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2196
        # The config file doesn't exist, set an option to force its creation
2197
        conf = remote_bzrdir._get_config()
2198
        conf.set_option('remotedir', 'file')
2199
        # We get one call for the server and one call for the client, this is
2200
        # caused by the differences in implementations betwen
2201
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
2202
        # SmartServerBranchGetConfigFile (in smart/branch.py)
2203
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
2204
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2205
    def assertSaveHook(self, conf):
2206
        calls = []
2207
        def hook(*args):
2208
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2209
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2210
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2211
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2212
        self.assertLength(0, calls)
2213
        # Setting an option triggers a save
2214
        conf.set_option('foo', 'bar')
2215
        self.assertLength(1, calls)
2216
        # Since we can't assert about conf, we just use the number of calls ;-/
2217
2218
    def test_save_hook_remote_branch(self):
2219
        remote_branch = branch.Branch.open(self.get_url('tree'))
2220
        self.addCleanup(remote_branch.lock_write().unlock)
2221
        self.assertSaveHook(remote_branch._get_config())
2222
2223
    def test_save_hook_remote_bzrdir(self):
2224
        remote_branch = branch.Branch.open(self.get_url('tree'))
2225
        self.addCleanup(remote_branch.lock_write().unlock)
2226
        remote_bzrdir = bzrdir.BzrDir.open(self.get_url('tree'))
2227
        self.assertSaveHook(remote_bzrdir._get_config())
2228
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2229
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2230
class TestOption(tests.TestCase):
2231
2232
    def test_default_value(self):
2233
        opt = config.Option('foo', default='bar')
2234
        self.assertEquals('bar', opt.get_default())
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2235
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2236
    def test_default_value_from_env(self):
2237
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
2238
        self.overrideEnv('FOO', 'quux')
2239
        # Env variable provides a default taking over the option one
2240
        self.assertEquals('quux', opt.get_default())
2241
        
2242
    def test_first_default_value_from_env_wins(self):
2243
        opt = config.Option('foo', default='bar',
2244
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
2245
        self.overrideEnv('FOO', 'foo')
2246
        self.overrideEnv('BAZ', 'baz')
2247
        # The first env var set wins
2248
        self.assertEquals('foo', opt.get_default())
2249
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2250
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2251
class TestOptionRegistry(tests.TestCase):
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2252
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2253
    def setUp(self):
2254
        super(TestOptionRegistry, self).setUp()
2255
        # Always start with an empty registry
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2256
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2257
        self.registry = config.option_registry
2258
2259
    def test_register(self):
2260
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2261
        self.registry.register(opt)
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2262
        self.assertIs(opt, self.registry.get('foo'))
2263
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2264
    def test_registered_help(self):
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2265
        opt = config.Option('foo', help='A simple option')
2266
        self.registry.register(opt)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2267
        self.assertEquals('A simple option', self.registry.get_help('foo'))
2268
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2269
    lazy_option = config.Option('lazy_foo', help='Lazy help')
2270
2271
    def test_register_lazy(self):
2272
        self.registry.register_lazy('lazy_foo', self.__module__,
2273
                                    'TestOptionRegistry.lazy_option')
2274
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
2275
2276
    def test_registered_lazy_help(self):
2277
        self.registry.register_lazy('lazy_foo', self.__module__,
2278
                                    'TestOptionRegistry.lazy_option')
2279
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
2280
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2281
2282
class TestRegisteredOptions(tests.TestCase):
2283
    """All registered options should verify some constraints."""
2284
2285
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
2286
                 in config.option_registry.iteritems()]
2287
2288
    def setUp(self):
2289
        super(TestRegisteredOptions, self).setUp()
2290
        self.registry = config.option_registry
2291
2292
    def test_proper_name(self):
2293
        # An option should be registered under its own name, this can't be
2294
        # checked at registration time for the lazy ones.
2295
        self.assertEquals(self.option_name, self.option.name)
2296
2297
    def test_help_is_set(self):
2298
        option_help = self.registry.get_help(self.option_name)
2299
        self.assertNotEquals(None, option_help)
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2300
        # Come on, think about the user, he really wants to know what the
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2301
        # option is about
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2302
        self.assertIsNot(None, option_help)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2303
        self.assertNotEquals('', option_help)
2304
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2305
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2306
class TestSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2307
2308
    # FIXME: Parametrize so that all sections produced by Stores run these
5743.3.1 by Vincent Ladeuil
Add a docstring and dates to FIXMEs.
2309
    # tests -- vila 2011-04-01
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2310
2311
    def test_get_a_value(self):
2312
        a_dict = dict(foo='bar')
5743.3.11 by Vincent Ladeuil
Config sections only implement read access.
2313
        section = config.Section('myID', a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2314
        self.assertEquals('bar', section.get('foo'))
2315
5743.3.10 by Vincent Ladeuil
Fix typos mentioned in reviews.
2316
    def test_get_unknown_option(self):
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2317
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2318
        section = config.Section(None, a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2319
        self.assertEquals('out of thin air',
2320
                          section.get('foo', 'out of thin air'))
2321
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2322
    def test_options_is_shared(self):
2323
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2324
        section = config.Section(None, a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2325
        self.assertIs(a_dict, section.options)
2326
2327
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2328
class TestMutableSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2329
5743.4.20 by Vincent Ladeuil
Fix typo.
2330
    # FIXME: Parametrize so that all sections (including os.environ and the
5743.3.1 by Vincent Ladeuil
Add a docstring and dates to FIXMEs.
2331
    # ones produced by Stores) run these tests -- vila 2011-04-01
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2332
2333
    def test_set(self):
2334
        a_dict = dict(foo='bar')
2335
        section = config.MutableSection('myID', a_dict)
2336
        section.set('foo', 'new_value')
2337
        self.assertEquals('new_value', section.get('foo'))
2338
        # The change appears in the shared section
2339
        self.assertEquals('new_value', a_dict.get('foo'))
2340
        # We keep track of the change
2341
        self.assertTrue('foo' in section.orig)
2342
        self.assertEquals('bar', section.orig.get('foo'))
2343
2344
    def test_set_preserve_original_once(self):
2345
        a_dict = dict(foo='bar')
2346
        section = config.MutableSection('myID', a_dict)
2347
        section.set('foo', 'first_value')
2348
        section.set('foo', 'second_value')
2349
        # We keep track of the original value
2350
        self.assertTrue('foo' in section.orig)
2351
        self.assertEquals('bar', section.orig.get('foo'))
2352
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2353
    def test_remove(self):
2354
        a_dict = dict(foo='bar')
2355
        section = config.MutableSection('myID', a_dict)
2356
        section.remove('foo')
2357
        # We get None for unknown options via the default value
2358
        self.assertEquals(None, section.get('foo'))
2359
        # Or we just get the default value
2360
        self.assertEquals('unknown', section.get('foo', 'unknown'))
2361
        self.assertFalse('foo' in section.options)
2362
        # We keep track of the deletion
2363
        self.assertTrue('foo' in section.orig)
2364
        self.assertEquals('bar', section.orig.get('foo'))
2365
2366
    def test_remove_new_option(self):
2367
        a_dict = dict()
2368
        section = config.MutableSection('myID', a_dict)
2369
        section.set('foo', 'bar')
2370
        section.remove('foo')
2371
        self.assertFalse('foo' in section.options)
2372
        # The option didn't exist initially so it we need to keep track of it
2373
        # with a special value
2374
        self.assertTrue('foo' in section.orig)
5743.3.6 by Vincent Ladeuil
Use a name less likely to be reused.
2375
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2376
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2377
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2378
class TestStore(tests.TestCaseWithTransport):
2379
2380
    def assertSectionContent(self, expected, section):
2381
        """Assert that some options have the proper values in a section."""
2382
        expected_name, expected_options = expected
2383
        self.assertEquals(expected_name, section.id)
2384
        self.assertEquals(
2385
            expected_options,
2386
            dict([(k, section.get(k)) for k in expected_options.keys()]))
2387
2388
2389
class TestReadonlyStore(TestStore):
2390
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2391
    scenarios = [(key, {'get_store': builder}) for key, builder
2392
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2393
2394
    def setUp(self):
2395
        super(TestReadonlyStore, self).setUp()
2396
2397
    def test_building_delays_load(self):
2398
        store = self.get_store(self)
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2399
        self.assertEquals(False, store.is_loaded())
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2400
        store._load_from_string('')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2401
        self.assertEquals(True, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2402
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2403
    def test_get_no_sections_for_empty(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2404
        store = self.get_store(self)
2405
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2406
        self.assertEquals([], list(store.get_sections()))
2407
2408
    def test_get_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2409
        store = self.get_store(self)
2410
        store._load_from_string('foo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2411
        sections = list(store.get_sections())
2412
        self.assertLength(1, sections)
2413
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2414
2415
    def test_get_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2416
        store = self.get_store(self)
2417
        store._load_from_string('[baz]\nfoo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2418
        sections = list(store.get_sections())
2419
        self.assertLength(1, sections)
2420
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2421
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2422
    def test_load_from_string_fails_for_non_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2423
        store = self.get_store(self)
2424
        store._load_from_string('foo=bar')
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2425
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
2426
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2427
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2428
class TestIniFileStoreContent(tests.TestCaseWithTransport):
2429
    """Simulate loading a config store without content of various encodings.
2430
2431
    All files produced by bzr are in utf8 content.
2432
2433
    Users may modify them manually and end up with a file that can't be
2434
    loaded. We need to issue proper error messages in this case.
2435
    """
2436
2437
    invalid_utf8_char = '\xff'
2438
2439
    def test_load_utf8(self):
2440
        """Ensure we can load an utf8-encoded file."""
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2441
        t = self.get_transport()
2442
        # From http://pad.lv/799212
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2443
        unicode_user = u'b\N{Euro Sign}ar'
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2444
        unicode_content = u'user=%s' % (unicode_user,)
2445
        utf8_content = unicode_content.encode('utf8')
2446
        # Store the raw content in the config file
2447
        t.put_bytes('foo.conf', utf8_content)
2448
        store = config.IniFileStore(t, 'foo.conf')
2449
        store.load()
2450
        stack = config.Stack([store.get_sections], store)
2451
        self.assertEquals(unicode_user, stack.get('user'))
2452
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2453
    def test_load_non_ascii(self):
2454
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2455
        t = self.get_transport()
2456
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
2457
        store = config.IniFileStore(t, 'foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2458
        self.assertRaises(errors.ConfigContentError, store.load)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2459
2460
    def test_load_erroneous_content(self):
2461
        """Ensure we display a proper error on content that can't be parsed."""
2462
        t = self.get_transport()
2463
        t.put_bytes('foo.conf', '[open_section\n')
2464
        store = config.IniFileStore(t, 'foo.conf')
2465
        self.assertRaises(errors.ParseConfigError, store.load)
2466
2467
2468
class TestIniConfigContent(tests.TestCaseWithTransport):
2469
    """Simulate loading a IniBasedConfig without content of various encodings.
2470
2471
    All files produced by bzr are in utf8 content.
2472
2473
    Users may modify them manually and end up with a file that can't be
2474
    loaded. We need to issue proper error messages in this case.
2475
    """
2476
2477
    invalid_utf8_char = '\xff'
2478
2479
    def test_load_utf8(self):
2480
        """Ensure we can load an utf8-encoded file."""
2481
        # From http://pad.lv/799212
2482
        unicode_user = u'b\N{Euro Sign}ar'
2483
        unicode_content = u'user=%s' % (unicode_user,)
2484
        utf8_content = unicode_content.encode('utf8')
2485
        # Store the raw content in the config file
2486
        with open('foo.conf', 'wb') as f:
2487
            f.write(utf8_content)
2488
        conf = config.IniBasedConfig(file_name='foo.conf')
2489
        self.assertEquals(unicode_user, conf.get_user_option('user'))
2490
2491
    def test_load_badly_encoded_content(self):
2492
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2493
        with open('foo.conf', 'wb') as f:
2494
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
2495
        conf = config.IniBasedConfig(file_name='foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2496
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2497
2498
    def test_load_erroneous_content(self):
2499
        """Ensure we display a proper error on content that can't be parsed."""
2500
        with open('foo.conf', 'wb') as f:
2501
            f.write('[open_section\n')
2502
        conf = config.IniBasedConfig(file_name='foo.conf')
2503
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
2504
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2505
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2506
class TestMutableStore(TestStore):
2507
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2508
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
2509
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2510
2511
    def setUp(self):
2512
        super(TestMutableStore, self).setUp()
2513
        self.transport = self.get_transport()
2514
2515
    def has_store(self, store):
2516
        store_basename = urlutils.relative_url(self.transport.external_url(),
2517
                                               store.external_url())
2518
        return self.transport.has(store_basename)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2519
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2520
    def test_save_empty_creates_no_file(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2521
        # FIXME: There should be a better way than relying on the test
2522
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2523
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2524
            raise tests.TestNotApplicable(
2525
                'branch.conf is *always* created when a branch is initialized')
2526
        store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2527
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2528
        self.assertEquals(False, self.has_store(store))
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2529
2530
    def test_save_emptied_succeeds(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2531
        store = self.get_store(self)
2532
        store._load_from_string('foo=bar\n')
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2533
        section = store.get_mutable_section(None)
2534
        section.remove('foo')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2535
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2536
        self.assertEquals(True, self.has_store(store))
2537
        modified_store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2538
        sections = list(modified_store.get_sections())
2539
        self.assertLength(0, sections)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2540
2541
    def test_save_with_content_succeeds(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2542
        # FIXME: There should be a better way than relying on the test
2543
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2544
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2545
            raise tests.TestNotApplicable(
2546
                'branch.conf is *always* created when a branch is initialized')
2547
        store = self.get_store(self)
2548
        store._load_from_string('foo=bar\n')
2549
        self.assertEquals(False, self.has_store(store))
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2550
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2551
        self.assertEquals(True, self.has_store(store))
2552
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2553
        sections = list(modified_store.get_sections())
2554
        self.assertLength(1, sections)
2555
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2556
2557
    def test_set_option_in_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2558
        store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2559
        section = store.get_mutable_section(None)
2560
        section.set('foo', 'bar')
2561
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2562
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2563
        sections = list(modified_store.get_sections())
2564
        self.assertLength(1, sections)
2565
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2566
2567
    def test_set_option_in_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2568
        store = self.get_store(self)
2569
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2570
        section = store.get_mutable_section(None)
2571
        section.set('foo', 'bar')
2572
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2573
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2574
        sections = list(modified_store.get_sections())
2575
        self.assertLength(1, sections)
2576
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2577
2578
    def test_set_option_in_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2579
        store = self.get_store(self)
2580
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2581
        section = store.get_mutable_section('baz')
2582
        section.set('foo', 'bar')
2583
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2584
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2585
        sections = list(modified_store.get_sections())
2586
        self.assertLength(1, sections)
2587
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2588
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2589
    def test_load_hook(self):
2590
        # We first needs to ensure that the store exists
2591
        store = self.get_store(self)
2592
        section = store.get_mutable_section('baz')
2593
        section.set('foo', 'bar')
2594
        store.save()
2595
        # Now we can try to load it
5743.8.11 by Vincent Ladeuil
Restrict the scope when testing hooks to avoid spurious failures.
2596
        store = self.get_store(self)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2597
        calls = []
2598
        def hook(*args):
2599
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2600
        config.ConfigHooks.install_named_hook('load', hook, None)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2601
        self.assertLength(0, calls)
2602
        store.load()
2603
        self.assertLength(1, calls)
2604
        self.assertEquals((store,), calls[0])
2605
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2606
    def test_save_hook(self):
2607
        calls = []
2608
        def hook(*args):
2609
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2610
        config.ConfigHooks.install_named_hook('save', hook, None)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2611
        self.assertLength(0, calls)
2612
        store = self.get_store(self)
2613
        section = store.get_mutable_section('baz')
2614
        section.set('foo', 'bar')
2615
        store.save()
2616
        self.assertLength(1, calls)
2617
        self.assertEquals((store,), calls[0])
2618
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2619
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2620
class TestIniFileStore(TestStore):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2621
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
2622
    def test_loading_unknown_file_fails(self):
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2623
        store = config.IniFileStore(self.get_transport(), 'I-do-not-exist')
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
2624
        self.assertRaises(errors.NoSuchFile, store.load)
2625
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2626
    def test_invalid_content(self):
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2627
        store = config.IniFileStore(self.get_transport(), 'foo.conf', )
2628
        self.assertEquals(False, store.is_loaded())
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2629
        exc = self.assertRaises(
2630
            errors.ParseConfigError, store._load_from_string,
2631
            'this is invalid !')
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2632
        self.assertEndsWith(exc.filename, 'foo.conf')
2633
        # And the load failed
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2634
        self.assertEquals(False, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2635
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2636
    def test_get_embedded_sections(self):
5743.2.11 by Vincent Ladeuil
Basic store.set implementation.
2637
        # A more complicated example (which also shows that section names and
2638
        # option names share the same name space...)
5743.4.7 by Vincent Ladeuil
The test is now specific to ConfigObjStore and highlight a pending problem there.
2639
        # FIXME: This should be fixed by forbidding dicts as values ?
2640
        # -- vila 2011-04-05
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2641
        store = config.IniFileStore(self.get_transport(), 'foo.conf', )
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2642
        store._load_from_string('''
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2643
foo=bar
2644
l=1,2
2645
[DEFAULT]
2646
foo_in_DEFAULT=foo_DEFAULT
2647
[bar]
2648
foo_in_bar=barbar
2649
[baz]
2650
foo_in_baz=barbaz
2651
[[qux]]
2652
foo_in_qux=quux
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
2653
''')
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2654
        sections = list(store.get_sections())
2655
        self.assertLength(4, sections)
2656
        # The default section has no name.
2657
        # List values are provided as lists
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
2658
        self.assertSectionContent((None, {'foo': 'bar', 'l': ['1', '2']}),
2659
                                  sections[0])
2660
        self.assertSectionContent(
2661
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
2662
        self.assertSectionContent(
2663
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2664
        # sub sections are provided as embedded dicts.
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
2665
        self.assertSectionContent(
2666
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
2667
            sections[3])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
2668
5743.4.5 by Vincent Ladeuil
Split store tests between readonly and mutable ones.
2669
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2670
class TestLockableIniFileStore(TestStore):
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2671
2672
    def test_create_store_in_created_dir(self):
5743.6.21 by Vincent Ladeuil
Tighten the test.
2673
        self.assertPathDoesNotExist('dir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2674
        t = self.get_transport('dir/subdir')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2675
        store = config.LockableIniFileStore(t, 'foo.conf')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2676
        store.get_mutable_section(None).set('foo', 'bar')
2677
        store.save()
5743.6.21 by Vincent Ladeuil
Tighten the test.
2678
        self.assertPathExists('dir/subdir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2679
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2680
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2681
class TestConcurrentStoreUpdates(TestStore):
5743.10.13 by Vincent Ladeuil
Mention that the the concurrent update tests are not targeted at *all* Store implementations.
2682
    """Test that Stores properly handle conccurent updates.
2683
2684
    New Store implementation may fail some of these tests but until such
2685
    implementations exist it's hard to properly filter them from the scenarios
2686
    applied here. If you encounter such a case, contact the bzr devs.
2687
    """
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2688
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2689
    scenarios = [(key, {'get_stack': builder}) for key, builder
2690
                 in config.test_stack_builder_registry.iteritems()]
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2691
2692
    def setUp(self):
2693
        super(TestConcurrentStoreUpdates, self).setUp()
2694
        self._content = 'one=1\ntwo=2\n'
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2695
        self.stack = self.get_stack(self)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2696
        if not isinstance(self.stack, config._CompatibleStack):
2697
            raise tests.TestNotApplicable(
2698
                '%s is not meant to be compatible with the old config design'
2699
                % (self.stack,))
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2700
        self.stack.store._load_from_string(self._content)
2701
        # Flush the store
2702
        self.stack.store.save()
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2703
2704
    def test_simple_read_access(self):
2705
        self.assertEquals('1', self.stack.get('one'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2706
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
2707
    def test_simple_write_access(self):
2708
        self.stack.set('one', 'one')
2709
        self.assertEquals('one', self.stack.get('one'))
2710
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
2711
    def test_listen_to_the_last_speaker(self):
2712
        c1 = self.stack
2713
        c2 = self.get_stack(self)
2714
        c1.set('one', 'ONE')
2715
        c2.set('two', 'TWO')
2716
        self.assertEquals('ONE', c1.get('one'))
2717
        self.assertEquals('TWO', c2.get('two'))
2718
        # The second update respect the first one
2719
        self.assertEquals('ONE', c2.get('one'))
2720
2721
    def test_last_speaker_wins(self):
2722
        # If the same config is not shared, the same variable modified twice
2723
        # can only see a single result.
2724
        c1 = self.stack
2725
        c2 = self.get_stack(self)
2726
        c1.set('one', 'c1')
2727
        c2.set('one', 'c2')
2728
        self.assertEquals('c2', c2.get('one'))
2729
        # The first modification is still available until another refresh
2730
        # occur
2731
        self.assertEquals('c1', c1.get('one'))
2732
        c1.set('two', 'done')
2733
        self.assertEquals('c2', c1.get('one'))
2734
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
2735
    def test_writes_are_serialized(self):
2736
        c1 = self.stack
2737
        c2 = self.get_stack(self)
2738
5743.6.25 by Vincent Ladeuil
Last test rewritten.
2739
        # We spawn a thread that will pause *during* the config saving.
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
2740
        before_writing = threading.Event()
2741
        after_writing = threading.Event()
2742
        writing_done = threading.Event()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2743
        c1_save_without_locking_orig = c1.store.save_without_locking
2744
        def c1_save_without_locking():
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
2745
            before_writing.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2746
            c1_save_without_locking_orig()
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
2747
            # The lock is held. We wait for the main thread to decide when to
2748
            # continue
2749
            after_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2750
        c1.store.save_without_locking = c1_save_without_locking
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
2751
        def c1_set():
2752
            c1.set('one', 'c1')
2753
            writing_done.set()
2754
        t1 = threading.Thread(target=c1_set)
2755
        # Collect the thread after the test
2756
        self.addCleanup(t1.join)
2757
        # Be ready to unblock the thread if the test goes wrong
2758
        self.addCleanup(after_writing.set)
2759
        t1.start()
2760
        before_writing.wait()
2761
        self.assertRaises(errors.LockContention,
2762
                          c2.set, 'one', 'c2')
2763
        self.assertEquals('c1', c1.get('one'))
2764
        # Let the lock be released
2765
        after_writing.set()
2766
        writing_done.wait()
2767
        c2.set('one', 'c2')
2768
        self.assertEquals('c2', c2.get('one'))
2769
5743.6.25 by Vincent Ladeuil
Last test rewritten.
2770
    def test_read_while_writing(self):
2771
       c1 = self.stack
2772
       # We spawn a thread that will pause *during* the write
2773
       ready_to_write = threading.Event()
2774
       do_writing = threading.Event()
2775
       writing_done = threading.Event()
2776
       # We override the _save implementation so we know the store is locked
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2777
       c1_save_without_locking_orig = c1.store.save_without_locking
2778
       def c1_save_without_locking():
5743.6.25 by Vincent Ladeuil
Last test rewritten.
2779
           ready_to_write.set()
2780
           # The lock is held. We wait for the main thread to decide when to
2781
           # continue
2782
           do_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2783
           c1_save_without_locking_orig()
5743.6.25 by Vincent Ladeuil
Last test rewritten.
2784
           writing_done.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
2785
       c1.store.save_without_locking = c1_save_without_locking
5743.6.25 by Vincent Ladeuil
Last test rewritten.
2786
       def c1_set():
2787
           c1.set('one', 'c1')
2788
       t1 = threading.Thread(target=c1_set)
2789
       # Collect the thread after the test
2790
       self.addCleanup(t1.join)
2791
       # Be ready to unblock the thread if the test goes wrong
2792
       self.addCleanup(do_writing.set)
2793
       t1.start()
2794
       # Ensure the thread is ready to write
2795
       ready_to_write.wait()
2796
       self.assertEquals('c1', c1.get('one'))
2797
       # If we read during the write, we get the old value
2798
       c2 = self.get_stack(self)
2799
       self.assertEquals('1', c2.get('one'))
2800
       # Let the writing occur and ensure it occurred
2801
       do_writing.set()
2802
       writing_done.wait()
2803
       # Now we get the updated value
2804
       c3 = self.get_stack(self)
2805
       self.assertEquals('c1', c3.get('one'))
2806
2807
    # FIXME: It may be worth looking into removing the lock dir when it's not
2808
    # needed anymore and look at possible fallouts for concurrent lockers. This
2809
    # will matter if/when we use config files outside of bazaar directories
2810
    # (.bazaar or .bzr) -- vila 20110-04-11
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
2811
2812
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
2813
class TestSectionMatcher(TestStore):
2814
2815
    scenarios = [('location', {'matcher': config.LocationMatcher})]
2816
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2817
    def get_store(self, file_name):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
2818
        return config.IniFileStore(self.get_readonly_transport(), file_name)
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
2819
2820
    def test_no_matches_for_empty_stores(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2821
        store = self.get_store('foo.conf')
2822
        store._load_from_string('')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2823
        matcher = self.matcher(store, '/bar')
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
2824
        self.assertEquals([], list(matcher.get_sections()))
2825
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2826
    def test_build_doesnt_load_store(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2827
        store = self.get_store('foo.conf')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2828
        matcher = self.matcher(store, '/bar')
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
2829
        self.assertFalse(store.is_loaded())
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2830
2831
2832
class TestLocationSection(tests.TestCase):
2833
2834
    def get_section(self, options, extra_path):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
2835
        section = config.Section('foo', options)
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2836
        # We don't care about the length so we use '0'
2837
        return config.LocationSection(section, 0, extra_path)
2838
2839
    def test_simple_option(self):
2840
        section = self.get_section({'foo': 'bar'}, '')
2841
        self.assertEquals('bar', section.get('foo'))
2842
2843
    def test_option_with_extra_path(self):
2844
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
2845
                                   'baz')
2846
        self.assertEquals('bar/baz', section.get('foo'))
2847
2848
    def test_invalid_policy(self):
2849
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
2850
                                   'baz')
2851
        # invalid policies are ignored
2852
        self.assertEquals('bar', section.get('foo'))
2853
2854
2855
class TestLocationMatcher(TestStore):
2856
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2857
    def get_store(self, file_name):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
2858
        return config.IniFileStore(self.get_readonly_transport(), file_name)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2859
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2860
    def test_more_specific_sections_first(self):
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2861
        store = self.get_store('foo.conf')
2862
        store._load_from_string('''
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2863
[/foo]
2864
section=/foo
2865
[/foo/bar]
2866
section=/foo/bar
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
2867
''')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
2868
        self.assertEquals(['/foo', '/foo/bar'],
2869
                          [section.id for section in store.get_sections()])
2870
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
2871
        sections = list(matcher.get_sections())
2872
        self.assertEquals([3, 2],
2873
                          [section.length for section in sections])
2874
        self.assertEquals(['/foo/bar', '/foo'],
2875
                          [section.id for section in sections])
2876
        self.assertEquals(['baz', 'bar/baz'],
2877
                          [section.extra_path for section in sections])
2878
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
2879
    def test_appendpath_in_no_name_section(self):
2880
        # It's a bit weird to allow appendpath in a no-name section, but
2881
        # someone may found a use for it
2882
        store = self.get_store('foo.conf')
2883
        store._load_from_string('''
2884
foo=bar
2885
foo:policy = appendpath
2886
''')
2887
        matcher = config.LocationMatcher(store, 'dir/subdir')
2888
        sections = list(matcher.get_sections())
2889
        self.assertLength(1, sections)
2890
        self.assertEquals('bar/dir/subdir', sections[0].get('foo'))
2891
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
2892
    def test_file_urls_are_normalized(self):
2893
        store = self.get_store('foo.conf')
5912.3.1 by Vincent Ladeuil
Fix spurious windows-specific test failure
2894
        if sys.platform == 'win32':
2895
            expected_url = 'file:///C:/dir/subdir'
2896
            expected_location = 'C:/dir/subdir'
2897
        else:
2898
            expected_url = 'file:///dir/subdir'
2899
            expected_location = '/dir/subdir'
2900
        matcher = config.LocationMatcher(store, expected_url)
2901
        self.assertEquals(expected_location, matcher.location)
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
2902
5743.1.20 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
2903
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
2904
class TestStackGet(tests.TestCase):
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
2905
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
2906
    # FIXME: This should be parametrized for all known Stack or dedicated
5743.1.3 by Vincent Ladeuil
Don't forget to parametrized for people *providing* new stacks.
2907
    # paramerized tests created to avoid bloating -- vila 2011-03-31
2908
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2909
    def overrideOptionRegistry(self):
2910
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
2911
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
2912
    def test_single_config_get(self):
2913
        conf = dict(foo='bar')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
2914
        conf_stack = config.Stack([conf])
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
2915
        self.assertEquals('bar', conf_stack.get('foo'))
2916
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
2917
    def test_get_with_registered_default_value(self):
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
2918
        conf_stack = config.Stack([dict()])
2919
        opt = config.Option('foo', default='bar')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2920
        self.overrideOptionRegistry()
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
2921
        config.option_registry.register('foo', opt)
2922
        self.assertEquals('bar', conf_stack.get('foo'))
2923
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
2924
    def test_get_without_registered_default_value(self):
2925
        conf_stack = config.Stack([dict()])
2926
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2927
        self.overrideOptionRegistry()
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
2928
        config.option_registry.register('foo', opt)
2929
        self.assertEquals(None, conf_stack.get('foo'))
2930
2931
    def test_get_without_default_value_for_not_registered(self):
2932
        conf_stack = config.Stack([dict()])
2933
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2934
        self.overrideOptionRegistry()
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
2935
        self.assertEquals(None, conf_stack.get('foo'))
2936
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
2937
    def test_get_first_definition(self):
2938
        conf1 = dict(foo='bar')
2939
        conf2 = dict(foo='baz')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
2940
        conf_stack = config.Stack([conf1, conf2])
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
2941
        self.assertEquals('bar', conf_stack.get('foo'))
2942
5743.1.2 by Vincent Ladeuil
Stacks can be used as read-only sections.
2943
    def test_get_embedded_definition(self):
2944
        conf1 = dict(yy='12')
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
2945
        conf2 = config.Stack([dict(xx='42'), dict(foo='baz')])
2946
        conf_stack = config.Stack([conf1, conf2])
5743.1.2 by Vincent Ladeuil
Stacks can be used as read-only sections.
2947
        self.assertEquals('baz', conf_stack.get('foo'))
2948
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
2949
    def test_get_for_empty_section_callable(self):
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
2950
        conf_stack = config.Stack([lambda : []])
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
2951
        self.assertEquals(None, conf_stack.get('foo'))
2952
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
2953
    def test_get_for_broken_callable(self):
2954
        # Trying to use and invalid callable raises an exception on first use
2955
        conf_stack = config.Stack([lambda : object()])
2956
        self.assertRaises(TypeError, conf_stack.get, 'foo')
2957
2958
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
2959
class TestStackWithTransport(tests.TestCaseWithTransport):
2960
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2961
    scenarios = [(key, {'get_stack': builder}) for key, builder
2962
                 in config.test_stack_builder_registry.iteritems()]
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
2963
2964
5743.11.1 by Vincent Ladeuil
Add a note about config store builders being called several times by some tests.
2965
class TestConcreteStacks(TestStackWithTransport):
2966
2967
    def test_build_stack(self):
2968
        # Just a smoke test to help debug builders
2969
        stack = self.get_stack(self)
2970
2971
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2972
class TestStackGet(TestStackWithTransport):
2973
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
2974
    def setUp(self):
2975
        super(TestStackGet, self).setUp()
2976
        self.conf = self.get_stack(self)
2977
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2978
    def test_get_for_empty_stack(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
2979
        self.assertEquals(None, self.conf.get('foo'))
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2980
2981
    def test_get_hook(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
2982
        self.conf.store._load_from_string('foo=bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2983
        calls = []
2984
        def hook(*args):
2985
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2986
        config.ConfigHooks.install_named_hook('get', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2987
        self.assertLength(0, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
2988
        value = self.conf.get('foo')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
2989
        self.assertEquals('bar', value)
2990
        self.assertLength(1, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
2991
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
2992
2993
2994
class TestStackGetWithConverter(TestStackGet):
2995
2996
    def setUp(self):
2997
        super(TestStackGetWithConverter, self).setUp()
2998
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
2999
        self.registry = config.option_registry
3000
6059.1.5 by Vincent Ladeuil
Handle invalid config option values.
3001
    def register_bool_option(self, name, default, invalid=None):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3002
        b = config.Option(name, default=default, help='A boolean.',
6059.1.5 by Vincent Ladeuil
Handle invalid config option values.
3003
                          from_unicode=config.bool_from_store,
3004
                          invalid=invalid)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3005
        self.registry.register(b)
3006
3007
    def test_get_with_bool_not_defined_default_true(self):
3008
        self.register_bool_option('foo', True)
3009
        self.assertEquals(True, self.conf.get('foo'))
3010
3011
    def test_get_with_bool_not_defined_default_false(self):
3012
        self.register_bool_option('foo', False)
3013
        self.assertEquals(False, self.conf.get('foo'))
3014
3015
    def test_get_with_bool_converter_not_default(self):
3016
        self.register_bool_option('foo', False)
3017
        self.conf.store._load_from_string('foo=yes')
3018
        self.assertEquals(True, self.conf.get('foo'))
3019
6059.1.7 by Vincent Ladeuil
Catch TypeError when a list value is encountered while attempting to
3020
    def test_get_with_bool_converter_invalid_string(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3021
        self.register_bool_option('foo', False)
3022
        self.conf.store._load_from_string('foo=not-a-boolean')
3023
        self.assertEquals(False, self.conf.get('foo'))
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3024
6059.1.7 by Vincent Ladeuil
Catch TypeError when a list value is encountered while attempting to
3025
    def test_get_with_bool_converter_invalid_list(self):
3026
        self.register_bool_option('foo', False)
3027
        self.conf.store._load_from_string('foo=not,a,boolean')
3028
        self.assertEquals(False, self.conf.get('foo'))
3029
6059.1.5 by Vincent Ladeuil
Handle invalid config option values.
3030
    def test_get_invalid_warns(self):
3031
        self.register_bool_option('foo', False, invalid='warning')
3032
        self.conf.store._load_from_string('foo=not-a-boolean')
3033
        warnings = []
3034
        def warning(*args):
3035
            warnings.append(args[0] % args[1:])
3036
        self.overrideAttr(trace, 'warning', warning)
3037
        self.assertEquals(False, self.conf.get('foo'))
3038
        self.assertLength(1, warnings)
3039
        self.assertEquals('Value "not-a-boolean" is not valid for "foo"',
3040
                          warnings[0])
3041
3042
    def test_get_invalid_errors(self):
3043
        self.register_bool_option('foo', False, invalid='error')
3044
        self.conf.store._load_from_string('foo=not-a-boolean')
3045
        self.assertRaises(errors.ConfigOptionValueError, self.conf.get, 'foo')
3046
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3047
    def register_integer_option(self, name, default):
6059.2.1 by Vincent Ladeuil
Implement list config options.
3048
        i = config.Option(name, default=default, help='An integer.',
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3049
                          from_unicode=config.int_from_store)
3050
        self.registry.register(i)
3051
3052
    def test_get_with_integer_not_defined_returns_default(self):
3053
        self.register_integer_option('foo', 42)
3054
        self.assertEquals(42, self.conf.get('foo'))
3055
3056
    def test_get_with_integer_converter_not_default(self):
3057
        self.register_integer_option('foo', 42)
3058
        self.conf.store._load_from_string('foo=16')
3059
        self.assertEquals(16, self.conf.get('foo'))
3060
6059.1.7 by Vincent Ladeuil
Catch TypeError when a list value is encountered while attempting to
3061
    def test_get_with_integer_converter_invalid_string(self):
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3062
        # We don't set a default value
3063
        self.register_integer_option('foo', None)
3064
        self.conf.store._load_from_string('foo=forty-two')
3065
        # No default value, so we should get None
3066
        self.assertEquals(None, self.conf.get('foo'))
3067
6059.1.7 by Vincent Ladeuil
Catch TypeError when a list value is encountered while attempting to
3068
    def test_get_with_integer_converter_invalid_list(self):
3069
        # We don't set a default value
3070
        self.register_integer_option('foo', None)
3071
        self.conf.store._load_from_string('foo=a,list')
3072
        # No default value, so we should get None
3073
        self.assertEquals(None, self.conf.get('foo'))
3074
6059.2.1 by Vincent Ladeuil
Implement list config options.
3075
    def register_list_option(self, name, default):
3076
        l = config.Option(name, default=default, help='A list.',
3077
                          from_unicode=config.list_from_store)
3078
        self.registry.register(l)
3079
3080
    def test_get_with_list_not_defined_returns_default(self):
3081
        self.register_list_option('foo', [])
3082
        self.assertEquals([], self.conf.get('foo'))
3083
3084
    def test_get_with_list_converter_nothing(self):
3085
        self.register_list_option('foo', [1])
3086
        self.conf.store._load_from_string('foo=')
3087
        self.assertEquals([], self.conf.get('foo'))
3088
3089
    def test_get_with_list_converter_no_item(self):
3090
        self.register_list_option('foo', [1])
3091
        self.conf.store._load_from_string('foo=,')
3092
        self.assertEquals([], self.conf.get('foo'))
3093
6059.2.2 by Vincent Ladeuil
Add more tests to be really sure we get lists.
3094
    def test_get_with_list_converter_one_boolean(self):
3095
        self.register_list_option('foo', [1])
3096
        self.conf.store._load_from_string('foo=True')
3097
        # We get a list of one string
3098
        self.assertEquals(['True'], self.conf.get('foo'))
3099
3100
    def test_get_with_list_converter_one_integer(self):
6059.2.1 by Vincent Ladeuil
Implement list config options.
3101
        self.register_list_option('foo', [1])
3102
        self.conf.store._load_from_string('foo=2')
6059.2.2 by Vincent Ladeuil
Add more tests to be really sure we get lists.
3103
        # We get a list of one string
6059.2.1 by Vincent Ladeuil
Implement list config options.
3104
        self.assertEquals(['2'], self.conf.get('foo'))
3105
6059.2.2 by Vincent Ladeuil
Add more tests to be really sure we get lists.
3106
    def test_get_with_list_converter_one_string(self):
3107
        self.register_list_option('foo', ['foo'])
3108
        self.conf.store._load_from_string('foo=bar')
3109
        # We get a list of one string
3110
        self.assertEquals(['bar'], self.conf.get('foo'))
3111
6059.2.1 by Vincent Ladeuil
Implement list config options.
3112
    def test_get_with_list_converter_many_items(self):
3113
        self.register_list_option('foo', [1])
3114
        self.conf.store._load_from_string('foo=m,o,r,e')
3115
        self.assertEquals(['m', 'o', 'r', 'e'], self.conf.get('foo'))
3116
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3117
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3118
class TestStackSet(TestStackWithTransport):
3119
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3120
    def test_simple_set(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3121
        conf = self.get_stack(self)
3122
        conf.store._load_from_string('foo=bar')
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3123
        self.assertEquals('bar', conf.get('foo'))
3124
        conf.set('foo', 'baz')
3125
        # Did we get it back ?
3126
        self.assertEquals('baz', conf.get('foo'))
3127
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3128
    def test_set_creates_a_new_section(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3129
        conf = self.get_stack(self)
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3130
        conf.set('foo', 'baz')
5743.1.9 by Vincent Ladeuil
Fix the issue by allowing delayed section acquisition.
3131
        self.assertEquals, 'baz', conf.get('foo')
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
3132
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3133
    def test_set_hook(self):
3134
        calls = []
3135
        def hook(*args):
3136
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3137
        config.ConfigHooks.install_named_hook('set', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3138
        self.assertLength(0, calls)
3139
        conf = self.get_stack(self)
3140
        conf.set('foo', 'bar')
3141
        self.assertLength(1, calls)
3142
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
3143
5743.1.7 by Vincent Ladeuil
Simple set implementation.
3144
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3145
class TestStackRemove(TestStackWithTransport):
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3146
3147
    def test_remove_existing(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3148
        conf = self.get_stack(self)
3149
        conf.store._load_from_string('foo=bar')
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3150
        self.assertEquals('bar', conf.get('foo'))
3151
        conf.remove('foo')
3152
        # Did we get it back ?
3153
        self.assertEquals(None, conf.get('foo'))
3154
3155
    def test_remove_unknown(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3156
        conf = self.get_stack(self)
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3157
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
3158
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3159
    def test_remove_hook(self):
3160
        calls = []
3161
        def hook(*args):
3162
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3163
        config.ConfigHooks.install_named_hook('remove', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3164
        self.assertLength(0, calls)
3165
        conf = self.get_stack(self)
3166
        conf.store._load_from_string('foo=bar')
3167
        conf.remove('foo')
3168
        self.assertLength(1, calls)
3169
        self.assertEquals((conf, 'foo'), calls[0])
3170
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
3171
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
3172
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3173
3174
    def setUp(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3175
        super(TestConfigGetOptions, self).setUp()
3176
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3177
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3178
    def test_no_variable(self):
3179
        # Using branch should query branch, locations and bazaar
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3180
        self.assertOptions([], self.branch_config)
3181
3182
    def test_option_in_bazaar(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3183
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3184
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3185
                           self.bazaar_config)
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3186
3187
    def test_option_in_locations(self):
3188
        self.locations_config.set_user_option('file', 'locations')
3189
        self.assertOptions(
3190
            [('file', 'locations', self.tree.basedir, 'locations')],
3191
            self.locations_config)
3192
3193
    def test_option_in_branch(self):
3194
        self.branch_config.set_user_option('file', 'branch')
3195
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
3196
                           self.branch_config)
3197
3198
    def test_option_in_bazaar_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3199
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3200
        self.branch_config.set_user_option('file', 'branch')
3201
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
3202
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3203
                           self.branch_config)
3204
3205
    def test_option_in_branch_and_locations(self):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3206
        # Hmm, locations override branch :-/
3207
        self.locations_config.set_user_option('file', 'locations')
3208
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3209
        self.assertOptions(
3210
            [('file', 'locations', self.tree.basedir, 'locations'),
3211
             ('file', 'branch', 'DEFAULT', 'branch'),],
3212
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3213
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3214
    def test_option_in_bazaar_locations_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3215
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3216
        self.locations_config.set_user_option('file', 'locations')
3217
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
3218
        self.assertOptions(
3219
            [('file', 'locations', self.tree.basedir, 'locations'),
3220
             ('file', 'branch', 'DEFAULT', 'branch'),
3221
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3222
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
3223
3224
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
3225
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3226
3227
    def setUp(self):
3228
        super(TestConfigRemoveOption, self).setUp()
3229
        create_configs_with_file_option(self)
3230
5447.4.11 by Vincent Ladeuil
Implement ``bzr config --remove <option>``.
3231
    def test_remove_in_locations(self):
3232
        self.locations_config.remove_user_option('file', self.tree.basedir)
3233
        self.assertOptions(
3234
            [('file', 'branch', 'DEFAULT', 'branch'),
3235
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3236
            self.branch_config)
3237
3238
    def test_remove_in_branch(self):
3239
        self.branch_config.remove_user_option('file')
3240
        self.assertOptions(
3241
            [('file', 'locations', self.tree.basedir, 'locations'),
3242
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
3243
            self.branch_config)
3244
3245
    def test_remove_in_bazaar(self):
3246
        self.bazaar_config.remove_user_option('file')
3247
        self.assertOptions(
3248
            [('file', 'locations', self.tree.basedir, 'locations'),
3249
             ('file', 'branch', 'DEFAULT', 'branch'),],
3250
            self.branch_config)
3251
5447.4.7 by Vincent Ladeuil
Check error message if the test is checking for errors or we have unexpected success for wrong errors.
3252
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3253
class TestConfigGetSections(tests.TestCaseWithTransport):
3254
3255
    def setUp(self):
3256
        super(TestConfigGetSections, self).setUp()
3257
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3258
3259
    def assertSectionNames(self, expected, conf, name=None):
3260
        """Check which sections are returned for a given config.
3261
3262
        If fallback configurations exist their sections can be included.
3263
3264
        :param expected: A list of section names.
3265
3266
        :param conf: The configuration that will be queried.
3267
3268
        :param name: An optional section name that will be passed to
3269
            get_sections().
3270
        """
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
3271
        sections = list(conf._get_sections(name))
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3272
        self.assertLength(len(expected), sections)
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
3273
        self.assertEqual(expected, [name for name, _, _ in sections])
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3274
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3275
    def test_bazaar_default_section(self):
3276
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3277
3278
    def test_locations_default_section(self):
3279
        # No sections are defined in an empty file
3280
        self.assertSectionNames([], self.locations_config)
3281
3282
    def test_locations_named_section(self):
3283
        self.locations_config.set_user_option('file', 'locations')
3284
        self.assertSectionNames([self.tree.basedir], self.locations_config)
3285
3286
    def test_locations_matching_sections(self):
3287
        loc_config = self.locations_config
3288
        loc_config.set_user_option('file', 'locations')
3289
        # We need to cheat a bit here to create an option in sections above and
3290
        # below the 'location' one.
3291
        parser = loc_config._get_parser()
3292
        # locations.cong deals with '/' ignoring native os.sep
3293
        location_names = self.tree.basedir.split('/')
3294
        parent = '/'.join(location_names[:-1])
3295
        child = '/'.join(location_names + ['child'])
3296
        parser[parent] = {}
3297
        parser[parent]['file'] = 'parent'
3298
        parser[child] = {}
3299
        parser[child]['file'] = 'child'
3300
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
3301
3302
    def test_branch_data_default_section(self):
3303
        self.assertSectionNames([None],
3304
                                self.branch_config._get_branch_data_config())
3305
3306
    def test_branch_default_sections(self):
3307
        # No sections are defined in an empty locations file
3308
        self.assertSectionNames([None, 'DEFAULT'],
3309
                                self.branch_config)
3310
        # Unless we define an option
3311
        self.branch_config._get_location_config().set_user_option(
3312
            'file', 'locations')
3313
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
3314
                                self.branch_config)
3315
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3316
    def test_bazaar_named_section(self):
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3317
        # We need to cheat as the API doesn't give direct access to sections
3318
        # other than DEFAULT.
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
3319
        self.bazaar_config.set_alias('bazaar', 'bzr')
3320
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
3321
3322
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
3323
class TestAuthenticationConfigFile(tests.TestCase):
2900.2.14 by Vincent Ladeuil
More tests.
3324
    """Test the authentication.conf file matching"""
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3325
3326
    def _got_user_passwd(self, expected_user, expected_password,
3327
                         config, *args, **kwargs):
3328
        credentials = config.get_credentials(*args, **kwargs)
3329
        if credentials is None:
3330
            user = None
3331
            password = None
3332
        else:
3333
            user = credentials['user']
3334
            password = credentials['password']
3335
        self.assertEquals(expected_user, user)
3336
        self.assertEquals(expected_password, password)
3337
2978.5.1 by John Arbash Meinel
Fix bug #162494, 'bzr register-branch' needs proper auth handling.
3338
    def test_empty_config(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3339
        conf = config.AuthenticationConfig(_file=StringIO())
3340
        self.assertEquals({}, conf._get_config())
3341
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
3342
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
3343
    def test_non_utf8_config(self):
3344
        conf = config.AuthenticationConfig(_file=StringIO(
3345
                'foo = bar\xff'))
5987.1.3 by Vincent Ladeuil
Proper message when authentication.conf has non-utf8 content
3346
        self.assertRaises(errors.ConfigContentError, conf._get_config)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3347
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3348
    def test_missing_auth_section_header(self):
3349
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
3350
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3351
3352
    def test_auth_section_header_not_closed(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3353
        conf = config.AuthenticationConfig(_file=StringIO('[DEF'))
3354
        self.assertRaises(errors.ParseConfigError, conf._get_config)
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
3355
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3356
    def test_auth_value_not_boolean(self):
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
3357
        conf = config.AuthenticationConfig(_file=StringIO(
3358
                """[broken]
3359
scheme=ftp
3360
user=joe
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
3361
verify_certificates=askme # Error: Not a boolean
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
3362
"""))
3363
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
3364
3365
    def test_auth_value_not_int(self):
2900.2.22 by Vincent Ladeuil
Polishing.
3366
        conf = config.AuthenticationConfig(_file=StringIO(
3367
                """[broken]
3368
scheme=ftp
3369
user=joe
3370
port=port # Error: Not an int
3371
"""))
3372
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3373
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
3374
    def test_unknown_password_encoding(self):
3375
        conf = config.AuthenticationConfig(_file=StringIO(
3376
                """[broken]
3377
scheme=ftp
3378
user=joe
3379
password_encoding=unknown
3380
"""))
3381
        self.assertRaises(ValueError, conf.get_password,
3382
                          'ftp', 'foo.net', 'joe')
3383
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3384
    def test_credentials_for_scheme_host(self):
3385
        conf = config.AuthenticationConfig(_file=StringIO(
3386
                """# Identity on foo.net
3387
[ftp definition]
3388
scheme=ftp
3389
host=foo.net
3390
user=joe
3391
password=secret-pass
3392
"""))
3393
        # Basic matching
3394
        self._got_user_passwd('joe', 'secret-pass', conf, 'ftp', 'foo.net')
3395
        # different scheme
3396
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
3397
        # different host
3398
        self._got_user_passwd(None, None, conf, 'ftp', 'bar.net')
3399
3400
    def test_credentials_for_host_port(self):
3401
        conf = config.AuthenticationConfig(_file=StringIO(
3402
                """# Identity on foo.net
3403
[ftp definition]
3404
scheme=ftp
3405
port=10021
3406
host=foo.net
3407
user=joe
3408
password=secret-pass
3409
"""))
3410
        # No port
3411
        self._got_user_passwd('joe', 'secret-pass',
3412
                              conf, 'ftp', 'foo.net', port=10021)
3413
        # different port
3414
        self._got_user_passwd(None, None, conf, 'ftp', 'foo.net')
3415
3416
    def test_for_matching_host(self):
3417
        conf = config.AuthenticationConfig(_file=StringIO(
3418
                """# Identity on foo.net
3419
[sourceforge]
3420
scheme=bzr
3421
host=bzr.sf.net
3422
user=joe
3423
password=joepass
3424
[sourceforge domain]
3425
scheme=bzr
3426
host=.bzr.sf.net
3427
user=georges
3428
password=bendover
3429
"""))
3430
        # matching domain
3431
        self._got_user_passwd('georges', 'bendover',
3432
                              conf, 'bzr', 'foo.bzr.sf.net')
3433
        # phishing attempt
3434
        self._got_user_passwd(None, None,
3435
                              conf, 'bzr', 'bbzr.sf.net')
3436
3437
    def test_for_matching_host_None(self):
3438
        conf = config.AuthenticationConfig(_file=StringIO(
3439
                """# Identity on foo.net
3440
[catchup bzr]
3441
scheme=bzr
3442
user=joe
3443
password=joepass
3444
[DEFAULT]
3445
user=georges
3446
password=bendover
3447
"""))
3448
        # match no host
3449
        self._got_user_passwd('joe', 'joepass',
3450
                              conf, 'bzr', 'quux.net')
3451
        # no host but different scheme
3452
        self._got_user_passwd('georges', 'bendover',
3453
                              conf, 'ftp', 'quux.net')
3454
3455
    def test_credentials_for_path(self):
3456
        conf = config.AuthenticationConfig(_file=StringIO(
3457
                """
3458
[http dir1]
3459
scheme=http
3460
host=bar.org
3461
path=/dir1
3462
user=jim
3463
password=jimpass
3464
[http dir2]
3465
scheme=http
3466
host=bar.org
3467
path=/dir2
3468
user=georges
3469
password=bendover
3470
"""))
3471
        # no path no dice
3472
        self._got_user_passwd(None, None,
3473
                              conf, 'http', host='bar.org', path='/dir3')
3474
        # matching path
3475
        self._got_user_passwd('georges', 'bendover',
3476
                              conf, 'http', host='bar.org', path='/dir2')
3477
        # matching subdir
3478
        self._got_user_passwd('jim', 'jimpass',
3479
                              conf, 'http', host='bar.org',path='/dir1/subdir')
3480
3481
    def test_credentials_for_user(self):
3482
        conf = config.AuthenticationConfig(_file=StringIO(
3483
                """
3484
[with user]
3485
scheme=http
3486
host=bar.org
3487
user=jim
3488
password=jimpass
3489
"""))
3490
        # Get user
3491
        self._got_user_passwd('jim', 'jimpass',
3492
                              conf, 'http', 'bar.org')
3493
        # Get same user
3494
        self._got_user_passwd('jim', 'jimpass',
3495
                              conf, 'http', 'bar.org', user='jim')
3496
        # Don't get a different user if one is specified
3497
        self._got_user_passwd(None, None,
3498
                              conf, 'http', 'bar.org', user='georges')
3499
3418.4.1 by Vincent Ladeuil
Reproduce bug 199440.
3500
    def test_credentials_for_user_without_password(self):
3501
        conf = config.AuthenticationConfig(_file=StringIO(
3502
                """
3503
[without password]
3504
scheme=http
3505
host=bar.org
3506
user=jim
3507
"""))
3508
        # Get user but no password
3509
        self._got_user_passwd('jim', None,
3510
                              conf, 'http', 'bar.org')
3511
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
3512
    def test_verify_certificates(self):
3513
        conf = config.AuthenticationConfig(_file=StringIO(
3514
                """
3515
[self-signed]
3516
scheme=https
3517
host=bar.org
3518
user=jim
3519
password=jimpass
3520
verify_certificates=False
3521
[normal]
3522
scheme=https
3523
host=foo.net
3524
user=georges
3525
password=bendover
3526
"""))
3527
        credentials = conf.get_credentials('https', 'bar.org')
3528
        self.assertEquals(False, credentials.get('verify_certificates'))
3529
        credentials = conf.get_credentials('https', 'foo.net')
3530
        self.assertEquals(True, credentials.get('verify_certificates'))
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
3531
3777.1.10 by Aaron Bentley
Ensure credentials are stored
3532
3533
class TestAuthenticationStorage(tests.TestCaseInTempDir):
3534
3777.1.8 by Aaron Bentley
Commit work-in-progress
3535
    def test_set_credentials(self):
3777.1.10 by Aaron Bentley
Ensure credentials are stored
3536
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
3537
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
3538
        99, path='/foo', verify_certificates=False, realm='realm')
3777.1.8 by Aaron Bentley
Commit work-in-progress
3539
        credentials = conf.get_credentials(host='host', scheme='scheme',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
3540
                                           port=99, path='/foo',
3541
                                           realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
3542
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
3543
                       'verify_certificates': False, 'scheme': 'scheme', 
3544
                       'host': 'host', 'port': 99, 'path': '/foo', 
3545
                       'realm': 'realm'}
3777.1.10 by Aaron Bentley
Ensure credentials are stored
3546
        self.assertEqual(CREDENTIALS, credentials)
3547
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
3548
            host='host', scheme='scheme', port=99, path='/foo', realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
3549
        self.assertEqual(CREDENTIALS, credentials_from_disk)
3777.1.8 by Aaron Bentley
Commit work-in-progress
3550
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
3551
    def test_reset_credentials_different_name(self):
3552
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
3553
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password'),
3554
        conf.set_credentials('name2', 'host', 'user2', 'scheme', 'password'),
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
3555
        self.assertIs(None, conf._get_config().get('name'))
3556
        credentials = conf.get_credentials(host='host', scheme='scheme')
3557
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
3558
                       'password', 'verify_certificates': True, 
3559
                       'scheme': 'scheme', 'host': 'host', 'port': None, 
3560
                       'path': None, 'realm': None}
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
3561
        self.assertEqual(CREDENTIALS, credentials)
3562
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
3563
2900.2.14 by Vincent Ladeuil
More tests.
3564
class TestAuthenticationConfig(tests.TestCase):
3565
    """Test AuthenticationConfig behaviour"""
3566
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
3567
    def _check_default_password_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3568
                                       host=None, port=None, realm=None,
3569
                                       path=None):
2900.2.14 by Vincent Ladeuil
More tests.
3570
        if host is None:
3571
            host = 'bar.org'
3572
        user, password = 'jim', 'precious'
3573
        expected_prompt = expected_prompt_format % {
3574
            'scheme': scheme, 'host': host, 'port': port,
3575
            'user': user, 'realm': realm}
3576
3577
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3578
        stderr = tests.StringIOWrapper()
2900.2.14 by Vincent Ladeuil
More tests.
3579
        ui.ui_factory = tests.TestUIFactory(stdin=password + '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3580
                                            stdout=stdout, stderr=stderr)
2900.2.14 by Vincent Ladeuil
More tests.
3581
        # We use an empty conf so that the user is always prompted
3582
        conf = config.AuthenticationConfig()
3583
        self.assertEquals(password,
3584
                          conf.get_password(scheme, host, user, port=port,
3585
                                            realm=realm, path=path))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3586
        self.assertEquals(expected_prompt, stderr.getvalue())
3587
        self.assertEquals('', stdout.getvalue())
2900.2.14 by Vincent Ladeuil
More tests.
3588
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3589
    def _check_default_username_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3590
                                       host=None, port=None, realm=None,
3591
                                       path=None):
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3592
        if host is None:
3593
            host = 'bar.org'
3594
        username = 'jim'
3595
        expected_prompt = expected_prompt_format % {
3596
            'scheme': scheme, 'host': host, 'port': port,
3597
            'realm': realm}
3598
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3599
        stderr = tests.StringIOWrapper()
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3600
        ui.ui_factory = tests.TestUIFactory(stdin=username+ '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3601
                                            stdout=stdout, stderr=stderr)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3602
        # We use an empty conf so that the user is always prompted
3603
        conf = config.AuthenticationConfig()
4222.3.5 by Jelmer Vernooij
Fix test.
3604
        self.assertEquals(username, conf.get_user(scheme, host, port=port,
3605
                          realm=realm, path=path, ask=True))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
3606
        self.assertEquals(expected_prompt, stderr.getvalue())
3607
        self.assertEquals('', stdout.getvalue())
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3608
3609
    def test_username_defaults_prompts(self):
3610
        # HTTP prompts can't be tested here, see test_http.py
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
3611
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
3612
        self._check_default_username_prompt(
3613
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
3614
        self._check_default_username_prompt(
3615
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
3616
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
3617
    def test_username_default_no_prompt(self):
3618
        conf = config.AuthenticationConfig()
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
3619
        self.assertEquals(None,
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
3620
            conf.get_user('ftp', 'example.com'))
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
3621
        self.assertEquals("explicitdefault",
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
3622
            conf.get_user('ftp', 'example.com', default="explicitdefault"))
3623
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
3624
    def test_password_default_prompts(self):
2900.2.19 by Vincent Ladeuil
Mention proxy and https in the password prompts, with tests.
3625
        # HTTP prompts can't be tested here, see test_http.py
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
3626
        self._check_default_password_prompt(
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
3627
            u'FTP %(user)s@%(host)s password: ', 'ftp')
3628
        self._check_default_password_prompt(
3629
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
3630
        self._check_default_password_prompt(
3631
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
2900.2.14 by Vincent Ladeuil
More tests.
3632
        # SMTP port handling is a bit special (it's handled if embedded in the
3633
        # host too)
2900.2.22 by Vincent Ladeuil
Polishing.
3634
        # FIXME: should we: forbid that, extend it to other schemes, leave
3635
        # things as they are that's fine thank you ?
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
3636
        self._check_default_password_prompt(
3637
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
3638
        self._check_default_password_prompt(
3639
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
3640
        self._check_default_password_prompt(
3641
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
2900.2.14 by Vincent Ladeuil
More tests.
3642
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
3643
    def test_ssh_password_emits_warning(self):
3644
        conf = config.AuthenticationConfig(_file=StringIO(
3645
                """
3646
[ssh with password]
3647
scheme=ssh
3648
host=bar.org
3649
user=jim
3650
password=jimpass
3651
"""))
3652
        entered_password = 'typed-by-hand'
3653
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
3654
        stderr = tests.StringIOWrapper()
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
3655
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
3656
                                            stdout=stdout, stderr=stderr)
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
3657
3658
        # Since the password defined in the authentication config is ignored,
3659
        # the user is prompted
3660
        self.assertEquals(entered_password,
3661
                          conf.get_password('ssh', 'bar.org', user='jim'))
3662
        self.assertContainsRe(
4794.1.17 by Robert Collins
Fix from vila for type log_log.
3663
            self.get_log(),
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
3664
            'password ignored in section \[ssh with password\]')
3665
3420.1.3 by Vincent Ladeuil
John's review feedback.
3666
    def test_ssh_without_password_doesnt_emit_warning(self):
3667
        conf = config.AuthenticationConfig(_file=StringIO(
3668
                """
3669
[ssh with password]
3670
scheme=ssh
3671
host=bar.org
3672
user=jim
3673
"""))
3674
        entered_password = 'typed-by-hand'
3675
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
3676
        stderr = tests.StringIOWrapper()
3420.1.3 by Vincent Ladeuil
John's review feedback.
3677
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
3678
                                            stdout=stdout,
3679
                                            stderr=stderr)
3420.1.3 by Vincent Ladeuil
John's review feedback.
3680
3681
        # Since the password defined in the authentication config is ignored,
3682
        # the user is prompted
3683
        self.assertEquals(entered_password,
3684
                          conf.get_password('ssh', 'bar.org', user='jim'))
3420.1.4 by Vincent Ladeuil
Fix comment.
3685
        # No warning shoud be emitted since there is no password. We are only
3686
        # providing "user".
3420.1.3 by Vincent Ladeuil
John's review feedback.
3687
        self.assertNotContainsRe(
4794.1.15 by Robert Collins
Review feedback.
3688
            self.get_log(),
3420.1.3 by Vincent Ladeuil
John's review feedback.
3689
            'password ignored in section \[ssh with password\]')
3690
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
3691
    def test_uses_fallback_stores(self):
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
3692
        self.overrideAttr(config, 'credential_store_registry',
3693
                          config.CredentialStoreRegistry())
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
3694
        store = StubCredentialStore()
3695
        store.add_credentials("http", "example.com", "joe", "secret")
3696
        config.credential_store_registry.register("stub", store, fallback=True)
3697
        conf = config.AuthenticationConfig(_file=StringIO())
3698
        creds = conf.get_credentials("http", "example.com")
3699
        self.assertEquals("joe", creds["user"])
3700
        self.assertEquals("secret", creds["password"])
3701
2900.2.14 by Vincent Ladeuil
More tests.
3702
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3703
class StubCredentialStore(config.CredentialStore):
3704
3705
    def __init__(self):
3706
        self._username = {}
3707
        self._password = {}
3708
3709
    def add_credentials(self, scheme, host, user, password=None):
3710
        self._username[(scheme, host)] = user
3711
        self._password[(scheme, host)] = password
3712
3713
    def get_credentials(self, scheme, host, port=None, user=None,
3714
        path=None, realm=None):
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3715
        key = (scheme, host)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3716
        if not key in self._username:
3717
            return None
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3718
        return { "scheme": scheme, "host": host, "port": port,
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3719
                "user": self._username[key], "password": self._password[key]}
3720
3721
3722
class CountingCredentialStore(config.CredentialStore):
3723
3724
    def __init__(self):
3725
        self._calls = 0
3726
3727
    def get_credentials(self, scheme, host, port=None, user=None,
3728
        path=None, realm=None):
3729
        self._calls += 1
3730
        return None
3731
3732
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
3733
class TestCredentialStoreRegistry(tests.TestCase):
3734
3735
    def _get_cs_registry(self):
3736
        return config.credential_store_registry
3737
3738
    def test_default_credential_store(self):
3739
        r = self._get_cs_registry()
3740
        default = r.get_credential_store(None)
3741
        self.assertIsInstance(default, config.PlainTextCredentialStore)
3742
3743
    def test_unknown_credential_store(self):
3744
        r = self._get_cs_registry()
3745
        # It's hard to imagine someone creating a credential store named
3746
        # 'unknown' so we use that as an never registered key.
3747
        self.assertRaises(KeyError, r.get_credential_store, 'unknown')
3748
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3749
    def test_fallback_none_registered(self):
3750
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3751
        self.assertEquals(None,
3752
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3753
3754
    def test_register(self):
3755
        r = config.CredentialStoreRegistry()
3756
        r.register("stub", StubCredentialStore(), fallback=False)
3757
        r.register("another", StubCredentialStore(), fallback=True)
3758
        self.assertEquals(["another", "stub"], r.keys())
3759
3760
    def test_register_lazy(self):
3761
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3762
        r.register_lazy("stub", "bzrlib.tests.test_config",
3763
                        "StubCredentialStore", fallback=False)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3764
        self.assertEquals(["stub"], r.keys())
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3765
        self.assertIsInstance(r.get_credential_store("stub"),
3766
                              StubCredentialStore)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3767
3768
    def test_is_fallback(self):
3769
        r = config.CredentialStoreRegistry()
3770
        r.register("stub1", None, fallback=False)
3771
        r.register("stub2", None, fallback=True)
3772
        self.assertEquals(False, r.is_fallback("stub1"))
3773
        self.assertEquals(True, r.is_fallback("stub2"))
3774
3775
    def test_no_fallback(self):
3776
        r = config.CredentialStoreRegistry()
3777
        store = CountingCredentialStore()
3778
        r.register("count", store, fallback=False)
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3779
        self.assertEquals(None,
3780
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3781
        self.assertEquals(0, store._calls)
3782
3783
    def test_fallback_credentials(self):
3784
        r = config.CredentialStoreRegistry()
3785
        store = StubCredentialStore()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3786
        store.add_credentials("http", "example.com",
3787
                              "somebody", "geheim")
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
3788
        r.register("stub", store, fallback=True)
3789
        creds = r.get_fallback_credentials("http", "example.com")
3790
        self.assertEquals("somebody", creds["user"])
3791
        self.assertEquals("geheim", creds["password"])
3792
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
3793
    def test_fallback_first_wins(self):
3794
        r = config.CredentialStoreRegistry()
3795
        stub1 = StubCredentialStore()
3796
        stub1.add_credentials("http", "example.com",
3797
                              "somebody", "stub1")
3798
        r.register("stub1", stub1, fallback=True)
3799
        stub2 = StubCredentialStore()
3800
        stub2.add_credentials("http", "example.com",
3801
                              "somebody", "stub2")
3802
        r.register("stub2", stub1, fallback=True)
3803
        creds = r.get_fallback_credentials("http", "example.com")
3804
        self.assertEquals("somebody", creds["user"])
3805
        self.assertEquals("stub1", creds["password"])
3806
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
3807
3808
class TestPlainTextCredentialStore(tests.TestCase):
3809
3810
    def test_decode_password(self):
3811
        r = config.credential_store_registry
3812
        plain_text = r.get_credential_store()
3813
        decoded = plain_text.decode_password(dict(password='secret'))
3814
        self.assertEquals('secret', decoded)
3815
3816
2900.2.14 by Vincent Ladeuil
More tests.
3817
# FIXME: Once we have a way to declare authentication to all test servers, we
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
3818
# can implement generic tests.
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
3819
# test_user_password_in_url
3820
# test_user_in_url_password_from_config
3821
# test_user_in_url_password_prompted
3822
# test_user_in_config
3823
# test_user_getpass.getuser
3824
# test_user_prompted ?
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
3825
class TestAuthenticationRing(tests.TestCaseWithTransport):
3826
    pass
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
3827
3828
3829
class TestAutoUserId(tests.TestCase):
3830
    """Test inferring an automatic user name."""
3831
3832
    def test_auto_user_id(self):
3833
        """Automatic inference of user name.
3834
        
3835
        This is a bit hard to test in an isolated way, because it depends on
3836
        system functions that go direct to /etc or perhaps somewhere else.
3837
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
3838
        to be able to choose a user name with no configuration.
3839
        """
3840
        if sys.platform == 'win32':
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
3841
            raise tests.TestSkipped(
3842
                "User name inference not implemented on win32")
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
3843
        realname, address = config._auto_user_id()
3844
        if os.path.exists('/etc/mailname'):
5813.1.1 by Jelmer Vernooij
Allow realname to be empty in tests.
3845
            self.assertIsNot(None, realname)
3846
            self.assertIsNot(None, address)
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
3847
        else:
3848
            self.assertEquals((None, None), (realname, address))
3849