/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
1
# Copyright (C) 2005-2012 Canonical Ltd
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
16
17
"""Tests for finding and reading the bzr config file[s]."""
18
# import system imports here
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
19
from cStringIO import StringIO
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
20
import os
21
import sys
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
22
import threading
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
23
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
24
25
from testtools import matchers
26
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
27
#import bzrlib specific imports here
1878.1.3 by John Arbash Meinel
some test cleanups
28
from bzrlib import (
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
29
    branch,
1878.1.3 by John Arbash Meinel
some test cleanups
30
    config,
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
31
    controldir,
4603.1.10 by Aaron Bentley
Provide change editor via config.
32
    diff,
1878.1.3 by John Arbash Meinel
some test cleanups
33
    errors,
34
    osutils,
2681.1.8 by Aaron Bentley
Add Thunderbird support to bzr send
35
    mail_client,
2900.2.14 by Vincent Ladeuil
More tests.
36
    ui,
1878.1.3 by John Arbash Meinel
some test cleanups
37
    urlutils,
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
38
    registry as _mod_registry,
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
39
    remote,
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
40
    tests,
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
41
    trace,
1878.1.3 by John Arbash Meinel
some test cleanups
42
    )
5743.13.1 by Vincent Ladeuil
Deprecate _get_editor to identify its usages.
43
from bzrlib.symbol_versioning import (
44
    deprecated_in,
45
    )
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
46
from bzrlib.transport import remote as transport_remote
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
47
from bzrlib.tests import (
48
    features,
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
49
    scenarios,
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
50
    test_server,
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
51
    )
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
52
from bzrlib.util.configobj import configobj
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
53
54
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
55
def lockable_config_scenarios():
56
    return [
57
        ('global',
58
         {'config_class': config.GlobalConfig,
59
          'config_args': [],
60
          'config_section': 'DEFAULT'}),
61
        ('locations',
62
         {'config_class': config.LocationConfig,
63
          'config_args': ['.'],
64
          'config_section': '.'}),]
65
66
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
67
load_tests = scenarios.load_tests_apply_scenarios
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
68
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
69
# Register helpers to build stores
70
config.test_store_builder_registry.register(
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
71
    'configobj', lambda test: config.TransportIniFileStore(
72
        test.get_transport(), 'configobj.conf'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
73
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
74
    'bazaar', lambda test: config.GlobalStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
75
config.test_store_builder_registry.register(
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
76
    'location', lambda test: config.LocationStore())
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
77
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
78
79
def build_backing_branch(test, relpath,
80
                         transport_class=None, server_class=None):
81
    """Test helper to create a backing branch only once.
82
83
    Some tests needs multiple stores/stacks to check concurrent update
84
    behaviours. As such, they need to build different branch *objects* even if
85
    they share the branch on disk.
86
87
    :param relpath: The relative path to the branch. (Note that the helper
88
        should always specify the same relpath).
89
90
    :param transport_class: The Transport class the test needs to use.
91
92
    :param server_class: The server associated with the ``transport_class``
93
        above.
94
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
95
    Either both or neither of ``transport_class`` and ``server_class`` should
96
    be specified.
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
97
    """
98
    if transport_class is not None and server_class is not None:
99
        test.transport_class = transport_class
100
        test.transport_server = server_class
101
    elif not (transport_class is None and server_class is None):
102
        raise AssertionError('Specify both ``transport_class`` and '
5743.10.9 by Vincent Ladeuil
Fix use of none where neither is required.
103
                             '``server_class`` or neither of them')
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
104
    if getattr(test, 'backing_branch', None) is None:
105
        # First call, let's build the branch on disk
106
        test.backing_branch = test.make_branch(relpath)
107
108
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
109
def build_branch_store(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
110
    build_backing_branch(test, 'branch')
111
    b = branch.Branch.open('branch')
112
    return config.BranchStore(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
113
config.test_store_builder_registry.register('branch', build_branch_store)
114
115
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
116
def build_control_store(test):
117
    build_backing_branch(test, 'branch')
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
118
    b = controldir.ControlDir.open('branch')
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
119
    return config.ControlStore(b)
120
config.test_store_builder_registry.register('control', build_control_store)
121
122
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
123
def build_remote_branch_store(test):
124
    # There is only one permutation (but we won't be able to handle more with
125
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
126
    (transport_class,
127
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
128
    build_backing_branch(test, 'branch', transport_class, server_class)
129
    b = branch.Branch.open(test.get_url('branch'))
130
    return config.BranchStore(b)
131
config.test_store_builder_registry.register('remote_branch',
132
                                            build_remote_branch_store)
133
134
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
135
config.test_stack_builder_registry.register(
136
    'bazaar', lambda test: config.GlobalStack())
137
config.test_stack_builder_registry.register(
138
    'location', lambda test: config.LocationStack('.'))
139
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
140
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
141
def build_branch_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
142
    build_backing_branch(test, 'branch')
143
    b = branch.Branch.open('branch')
144
    return config.BranchStack(b)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
145
config.test_stack_builder_registry.register('branch', build_branch_stack)
146
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
147
6379.11.1 by Vincent Ladeuil
Migrate location options to config stacks.
148
def build_branch_only_stack(test):
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
149
    # There is only one permutation (but we won't be able to handle more with
150
    # this design anyway)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
151
    (transport_class,
152
     server_class) = transport_remote.get_test_permutations()[0]
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
153
    build_backing_branch(test, 'branch', transport_class, server_class)
154
    b = branch.Branch.open(test.get_url('branch'))
6379.11.2 by Vincent Ladeuil
No matter how weird BranchOnlyStack is, it's public, the FIXMEs should be enough for devs to notice.
155
    return config.BranchOnlyStack(b)
6379.11.1 by Vincent Ladeuil
Migrate location options to config stacks.
156
config.test_stack_builder_registry.register('branch_only',
157
                                            build_branch_only_stack)
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
158
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
159
def build_remote_control_stack(test):
160
    # There is only one permutation (but we won't be able to handle more with
161
    # this design anyway)
162
    (transport_class,
163
     server_class) = transport_remote.get_test_permutations()[0]
164
    # We need only a bzrdir for this, not a full branch, but it's not worth
165
    # creating a dedicated helper to create only the bzrdir
166
    build_backing_branch(test, 'branch', transport_class, server_class)
167
    b = branch.Branch.open(test.get_url('branch'))
6270.1.20 by Jelmer Vernooij
Revert RemoteBranchStack / RemoteControlStack changes.
168
    return config.RemoteControlStack(b.bzrdir)
6076.1.1 by Vincent Ladeuil
Add the missing config stacks and store
169
config.test_stack_builder_registry.register('remote_control',
170
                                            build_remote_control_stack)
171
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
172
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
173
sample_long_alias="log -r-15..-1 --line"
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
174
sample_config_text = u"""
175
[DEFAULT]
176
email=Erik B\u00e5gfors <erik@bagfors.nu>
177
editor=vim
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
178
change_editor=vimdiff -of @new_path @old_path
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
179
gpg_signing_command=gnome-gpg
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
180
gpg_signing_key=DD4D5088
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
181
log_format=short
5971.1.58 by Jonathan Riddell
more tests for new config options
182
validate_signatures_in_log=true
183
acceptable_keys=amy
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
184
user_global_option=something
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
185
bzr.mergetool.sometool=sometool {base} {this} {other} -o {result}
5321.2.3 by Vincent Ladeuil
Prefix mergetools option names with 'bzr.'.
186
bzr.mergetool.funkytool=funkytool "arg with spaces" {this_temp}
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
187
bzr.mergetool.newtool='"newtool with spaces" {this_temp}'
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
188
bzr.default_mergetool=sometool
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
189
[ALIASES]
190
h=help
191
ll=""" + sample_long_alias + "\n"
192
193
194
sample_always_signatures = """
195
[DEFAULT]
196
check_signatures=ignore
197
create_signatures=always
198
"""
199
200
sample_ignore_signatures = """
201
[DEFAULT]
202
check_signatures=require
203
create_signatures=never
204
"""
205
206
sample_maybe_signatures = """
207
[DEFAULT]
208
check_signatures=ignore
209
create_signatures=when-required
210
"""
211
212
sample_branches_text = """
213
[http://www.example.com]
214
# Top level policy
215
email=Robert Collins <robertc@example.org>
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
216
normal_option = normal
217
appendpath_option = append
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
218
appendpath_option:policy = appendpath
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
219
norecurse_option = norecurse
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
220
norecurse_option:policy = norecurse
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
221
[http://www.example.com/ignoreparent]
222
# different project: ignore parent dir config
223
ignore_parents=true
224
[http://www.example.com/norecurse]
225
# configuration items that only apply to this dir
226
recurse=false
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
227
normal_option = norecurse
228
[http://www.example.com/dir]
229
appendpath_option = normal
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
230
[/b/]
231
check_signatures=require
232
# test trailing / matching with no children
233
[/a/]
234
check_signatures=check-available
235
gpg_signing_command=false
6012.2.11 by Jonathan Riddell
rename config option signing_key to gpg_signing_key
236
gpg_signing_key=default
2120.6.2 by James Henstridge
remove get_matching_sections() norecurse tests, since that feature is handled in the config policy code now
237
user_local_option=local
238
# test trailing / matching
239
[/a/*]
240
#subdirs will match but not the parent
241
[/a/c]
242
check_signatures=ignore
243
post_commit=bzrlib.tests.test_config.post_commit
244
#testing explicit beats globs
245
"""
1553.6.3 by Erik BÃ¥gfors
tests for AliasesConfig
246
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
247
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
248
def create_configs(test):
249
    """Create configuration files for a given test.
250
251
    This requires creating a tree (and populate the ``test.tree`` attribute)
252
    and its associated branch and will populate the following attributes:
253
254
    - branch_config: A BranchConfig for the associated branch.
255
256
    - locations_config : A LocationConfig for the associated branch
257
258
    - bazaar_config: A GlobalConfig.
259
260
    The tree and branch are created in a 'tree' subdirectory so the tests can
261
    still use the test directory to stay outside of the branch.
262
    """
263
    tree = test.make_branch_and_tree('tree')
264
    test.tree = tree
265
    test.branch_config = config.BranchConfig(tree.branch)
266
    test.locations_config = config.LocationConfig(tree.basedir)
267
    test.bazaar_config = config.GlobalConfig()
268
5533.2.4 by Vincent Ladeuil
Fix whitespace issue.
269
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
270
def create_configs_with_file_option(test):
271
    """Create configuration files with a ``file`` option set in each.
272
273
    This builds on ``create_configs`` and add one ``file`` option in each
274
    configuration with a value which allows identifying the configuration file.
275
    """
276
    create_configs(test)
277
    test.bazaar_config.set_user_option('file', 'bazaar')
278
    test.locations_config.set_user_option('file', 'locations')
279
    test.branch_config.set_user_option('file', 'branch')
280
281
282
class TestOptionsMixin:
283
284
    def assertOptions(self, expected, conf):
285
        # We don't care about the parser (as it will make tests hard to write
286
        # and error-prone anyway)
287
        self.assertThat([opt[:4] for opt in conf._get_options()],
288
                        matchers.Equals(expected))
289
290
1474 by Robert Collins
Merge from Aaron Bentley.
291
class InstrumentedConfigObj(object):
292
    """A config obj look-enough-alike to record calls made to it."""
293
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
294
    def __contains__(self, thing):
295
        self._calls.append(('__contains__', thing))
296
        return False
297
298
    def __getitem__(self, key):
299
        self._calls.append(('__getitem__', key))
300
        return self
301
1551.2.20 by Aaron Bentley
Treated config files as utf-8
302
    def __init__(self, input, encoding=None):
303
        self._calls = [('__init__', input, encoding)]
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
304
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
305
    def __setitem__(self, key, value):
306
        self._calls.append(('__setitem__', key, value))
307
2120.6.4 by James Henstridge
add support for specifying policy when storing options
308
    def __delitem__(self, key):
309
        self._calls.append(('__delitem__', key))
310
311
    def keys(self):
312
        self._calls.append(('keys',))
313
        return []
314
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
315
    def reload(self):
316
        self._calls.append(('reload',))
317
1551.2.49 by abentley
Made ConfigObj output binary-identical files on win32 and *nix
318
    def write(self, arg):
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
319
        self._calls.append(('write',))
320
2120.6.4 by James Henstridge
add support for specifying policy when storing options
321
    def as_bool(self, value):
322
        self._calls.append(('as_bool', value))
323
        return False
324
325
    def get_value(self, section, name):
326
        self._calls.append(('get_value', section, name))
327
        return None
328
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
329
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
330
class FakeBranch(object):
331
6362.1.4 by Jelmer Vernooij
Fix tests.
332
    def __init__(self, base=None):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
333
        if base is None:
334
            self.base = "http://example.com/branches/demo"
335
        else:
336
            self.base = base
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
337
        self._transport = self.control_files = \
6362.1.4 by Jelmer Vernooij
Fix tests.
338
            FakeControlFilesAndTransport()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
339
4226.1.7 by Robert Collins
Alter test_config.FakeBranch in accordance with the Branch change to have a _get_config.
340
    def _get_config(self):
341
        return config.TransportConfig(self._transport, 'branch.conf')
342
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
343
    def lock_write(self):
344
        pass
345
346
    def unlock(self):
347
        pass
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
348
349
3407.2.13 by Martin Pool
Remove indirection through control_files to get transports
350
class FakeControlFilesAndTransport(object):
1185.65.11 by Robert Collins
Disable inheritance for getting at LockableFiles, rather use composition.
351
6362.1.4 by Jelmer Vernooij
Fix tests.
352
    def __init__(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
353
        self.files = {}
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
354
        self._transport = self
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
355
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
356
    def get(self, filename):
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
357
        # from Transport
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
358
        try:
359
            return StringIO(self.files[filename])
360
        except KeyError:
361
            raise errors.NoSuchFile(filename)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
362
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
363
    def get_bytes(self, filename):
364
        # from Transport
365
        try:
366
            return self.files[filename]
367
        except KeyError:
368
            raise errors.NoSuchFile(filename)
369
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
370
    def put(self, filename, fileobj):
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
371
        self.files[filename] = fileobj.read()
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
372
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
373
    def put_file(self, filename, fileobj):
374
        return self.put(filename, fileobj)
375
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
376
377
class InstrumentedConfig(config.Config):
378
    """An instrumented config that supplies stubs for template methods."""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
379
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
380
    def __init__(self):
381
        super(InstrumentedConfig, self).__init__()
382
        self._calls = []
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
383
        self._signatures = config.CHECK_NEVER
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
384
385
    def _get_user_id(self):
386
        self._calls.append('_get_user_id')
387
        return "Robert Collins <robert.collins@example.org>"
388
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
389
    def _get_signature_checking(self):
390
        self._calls.append('_get_signature_checking')
391
        return self._signatures
392
4603.1.10 by Aaron Bentley
Provide change editor via config.
393
    def _get_change_editor(self):
394
        self._calls.append('_get_change_editor')
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
395
        return 'vimdiff -fo @new_path @old_path'
4603.1.10 by Aaron Bentley
Provide change editor via config.
396
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
397
1556.2.2 by Aaron Bentley
Fixed get_bool
398
bool_config = """[DEFAULT]
399
active = true
400
inactive = false
401
[UPPERCASE]
402
active = True
403
nonactive = False
404
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
405
406
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
407
class TestConfigObj(tests.TestCase):
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
408
1556.2.2 by Aaron Bentley
Fixed get_bool
409
    def test_get_bool(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
410
        co = config.ConfigObj(StringIO(bool_config))
1556.2.2 by Aaron Bentley
Fixed get_bool
411
        self.assertIs(co.get_bool('DEFAULT', 'active'), True)
412
        self.assertIs(co.get_bool('DEFAULT', 'inactive'), False)
413
        self.assertIs(co.get_bool('UPPERCASE', 'active'), True)
414
        self.assertIs(co.get_bool('UPPERCASE', 'nonactive'), False)
415
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
416
    def test_hash_sign_in_value(self):
417
        """
418
        Before 4.5.0, ConfigObj did not quote # signs in values, so they'd be
419
        treated as comments when read in again. (#86838)
420
        """
421
        co = config.ConfigObj()
422
        co['test'] = 'foo#bar'
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
423
        outfile = StringIO()
424
        co.write(outfile=outfile)
425
        lines = outfile.getvalue().splitlines()
3221.7.4 by Matt Nordhoff
Add test for bug #86838.
426
        self.assertEqual(lines, ['test = "foo#bar"'])
427
        co2 = config.ConfigObj(lines)
428
        self.assertEqual(co2['test'], 'foo#bar')
429
5050.62.10 by Alexander Belchenko
test to illustrate the problem
430
    def test_triple_quotes(self):
431
        # Bug #710410: if the value string has triple quotes
432
        # then ConfigObj versions up to 4.7.2 will quote them wrong
5050.62.12 by Alexander Belchenko
added NEWS entry
433
        # and won't able to read them back
5050.62.10 by Alexander Belchenko
test to illustrate the problem
434
        triple_quotes_value = '''spam
435
""" that's my spam """
436
eggs'''
437
        co = config.ConfigObj()
438
        co['test'] = triple_quotes_value
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
439
        # While writing this test another bug in ConfigObj has been found:
5050.62.10 by Alexander Belchenko
test to illustrate the problem
440
        # method co.write() without arguments produces list of lines
441
        # one option per line, and multiline values are not split
442
        # across multiple lines,
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
443
        # and that breaks the parsing these lines back by ConfigObj.
444
        # This issue only affects test, but it's better to avoid
445
        # `co.write()` construct at all.
446
        # [bialix 20110222] bug report sent to ConfigObj's author
5050.62.10 by Alexander Belchenko
test to illustrate the problem
447
        outfile = StringIO()
448
        co.write(outfile=outfile)
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
449
        output = outfile.getvalue()
5050.62.10 by Alexander Belchenko
test to illustrate the problem
450
        # now we're trying to read it back
5050.62.14 by Alexander Belchenko
don't use lines in the tests, and better comment about the corresponding bug in configobj; avoid using write() method without outfile parameter.
451
        co2 = config.ConfigObj(StringIO(output))
5050.62.10 by Alexander Belchenko
test to illustrate the problem
452
        self.assertEquals(triple_quotes_value, co2['test'])
453
1556.2.2 by Aaron Bentley
Fixed get_bool
454
2900.1.1 by Vincent Ladeuil
455
erroneous_config = """[section] # line 1
456
good=good # line 2
457
[section] # line 3
458
whocares=notme # line 4
459
"""
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
460
461
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
462
class TestConfigObjErrors(tests.TestCase):
2900.1.1 by Vincent Ladeuil
463
464
    def test_duplicate_section_name_error_line(self):
465
        try:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
466
            co = configobj.ConfigObj(StringIO(erroneous_config),
467
                                     raise_errors=True)
2900.1.1 by Vincent Ladeuil
468
        except config.configobj.DuplicateError, e:
469
            self.assertEqual(3, e.line_number)
470
        else:
471
            self.fail('Error in config file not detected')
472
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
473
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
474
class TestConfig(tests.TestCase):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
475
476
    def test_constructs(self):
477
        config.Config()
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
478
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
479
    def test_user_email(self):
480
        my_config = InstrumentedConfig()
481
        self.assertEqual('robert.collins@example.org', my_config.user_email())
482
        self.assertEqual(['_get_user_id'], my_config._calls)
483
484
    def test_username(self):
485
        my_config = InstrumentedConfig()
486
        self.assertEqual('Robert Collins <robert.collins@example.org>',
487
                         my_config.username())
488
        self.assertEqual(['_get_user_id'], my_config._calls)
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
489
490
    def test_signatures_default(self):
491
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
492
        self.assertFalse(
493
            self.applyDeprecated(deprecated_in((2, 5, 0)),
494
                my_config.signature_needed))
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
495
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
496
            self.applyDeprecated(deprecated_in((2, 5, 0)),
497
                my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
498
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
499
                self.applyDeprecated(deprecated_in((2, 5, 0)),
500
                    my_config.signing_policy))
1442.1.14 by Robert Collins
Create a default signature checking policy of CHECK_IF_POSSIBLE
501
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
502
    def test_signatures_template_method(self):
503
        my_config = InstrumentedConfig()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
504
        self.assertEqual(config.CHECK_NEVER,
505
            self.applyDeprecated(deprecated_in((2, 5, 0)),
506
                my_config.signature_checking))
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
507
        self.assertEqual(['_get_signature_checking'], my_config._calls)
508
509
    def test_signatures_template_method_none(self):
510
        my_config = InstrumentedConfig()
511
        my_config._signatures = None
512
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
513
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
514
                             my_config.signature_checking))
1442.1.15 by Robert Collins
make getting the signature checking policy a template method
515
        self.assertEqual(['_get_signature_checking'], my_config._calls)
516
1442.1.56 by Robert Collins
gpg_signing_command configuration item
517
    def test_gpg_signing_command_default(self):
518
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
519
        self.assertEqual('gpg',
520
            self.applyDeprecated(deprecated_in((2, 5, 0)),
521
                my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
522
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
523
    def test_get_user_option_default(self):
524
        my_config = config.Config()
525
        self.assertEqual(None, my_config.get_user_option('no_option'))
526
1472 by Robert Collins
post commit hook, first pass implementation
527
    def test_post_commit_default(self):
528
        my_config = config.Config()
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
529
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
530
                                                    my_config.post_commit))
531
1472 by Robert Collins
post commit hook, first pass implementation
532
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
533
    def test_log_format_default(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
534
        my_config = config.Config()
6378.1.3 by Vincent Ladeuil
log_format has been migrated but the old config method needs to be deprecated.
535
        self.assertEqual('long',
536
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
537
                                              my_config.log_format))
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
538
5971.1.57 by Jonathan Riddell
tests for new config options
539
    def test_acceptable_keys_default(self):
540
        my_config = config.Config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
541
        self.assertEqual(None, self.applyDeprecated(deprecated_in((2, 5, 0)),
542
            my_config.acceptable_keys))
5971.1.57 by Jonathan Riddell
tests for new config options
543
544
    def test_validate_signatures_in_log_default(self):
545
        my_config = config.Config()
546
        self.assertEqual(False, my_config.validate_signatures_in_log())
547
4603.1.10 by Aaron Bentley
Provide change editor via config.
548
    def test_get_change_editor(self):
549
        my_config = InstrumentedConfig()
550
        change_editor = my_config.get_change_editor('old_tree', 'new_tree')
551
        self.assertEqual(['_get_change_editor'], my_config._calls)
552
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
553
        self.assertEqual(['vimdiff', '-fo', '@new_path', '@old_path'],
4603.1.10 by Aaron Bentley
Provide change editor via config.
554
                         change_editor.command_template)
555
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
556
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
557
class TestConfigPath(tests.TestCase):
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
558
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
559
    def setUp(self):
560
        super(TestConfigPath, self).setUp()
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
561
        self.overrideEnv('HOME', '/home/bogus')
562
        self.overrideEnv('XDG_CACHE_DIR', '')
2309.2.6 by Alexander Belchenko
bzr now use Win32 API to determine Application Data location, and don't rely solely on $APPDATA
563
        if sys.platform == 'win32':
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
564
            self.overrideEnv(
565
                'BZR_HOME', r'C:\Documents and Settings\bogus\Application Data')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
566
            self.bzr_home = \
567
                'C:/Documents and Settings/bogus/Application Data/bazaar/2.0'
5519.4.3 by Neil Martinsen-Burrell
be permissive about using $XDG_CONFIG_HOME/bazaar, but dont complain
568
        else:
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
569
            self.bzr_home = '/home/bogus/.bazaar'
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
570
1442.1.1 by Robert Collins
move config_dir into bzrlib.config
571
    def test_config_dir(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
572
        self.assertEqual(config.config_dir(), self.bzr_home)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
573
6437.27.5 by Martin Packman
Document and test that config_dir now always returns unicode
574
    def test_config_dir_is_unicode(self):
575
        self.assertIsInstance(config.config_dir(), unicode)
576
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
577
    def test_config_filename(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
578
        self.assertEqual(config.config_filename(),
579
                         self.bzr_home + '/bazaar.conf')
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
580
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
581
    def test_locations_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
582
        self.assertEqual(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
583
                         self.bzr_home + '/locations.conf')
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
584
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
585
    def test_authentication_config_filename(self):
2991.2.4 by Vincent Ladeuil
Various fixes following local testing environment rebuild.
586
        self.assertEqual(config.authentication_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
587
                         self.bzr_home + '/authentication.conf')
588
4584.3.23 by Martin Pool
Correction to xdg_cache_dir and add a simple test
589
    def test_xdg_cache_dir(self):
590
        self.assertEqual(config.xdg_cache_dir(),
591
            '/home/bogus/.cache')
592
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
593
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
594
class TestXDGConfigDir(tests.TestCaseInTempDir):
595
    # must be in temp dir because config tests for the existence of the bazaar
596
    # subdirectory of $XDG_CONFIG_HOME
597
5519.4.9 by Neil Martinsen-Burrell
working tests
598
    def setUp(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
599
        if sys.platform in ('darwin', 'win32'):
600
            raise tests.TestNotApplicable(
601
                'XDG config dir not used on this platform')
5519.4.9 by Neil Martinsen-Burrell
working tests
602
        super(TestXDGConfigDir, self).setUp()
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
603
        self.overrideEnv('HOME', self.test_home_dir)
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
604
        # BZR_HOME overrides everything we want to test so unset it.
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
605
        self.overrideEnv('BZR_HOME', None)
5519.4.9 by Neil Martinsen-Burrell
working tests
606
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
607
    def test_xdg_config_dir_exists(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
608
        """When ~/.config/bazaar exists, use it as the config dir."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
609
        newdir = osutils.pathjoin(self.test_home_dir, '.config', 'bazaar')
610
        os.makedirs(newdir)
611
        self.assertEqual(config.config_dir(), newdir)
612
613
    def test_xdg_config_home(self):
5519.4.10 by Andrew Bennetts
Cosmetic tweaks to TestXDGConfigDir.
614
        """When XDG_CONFIG_HOME is set, use it."""
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
615
        xdgconfigdir = osutils.pathjoin(self.test_home_dir, 'xdgconfig')
5570.3.8 by Vincent Ladeuil
More use cases for overrideEnv.
616
        self.overrideEnv('XDG_CONFIG_HOME', xdgconfigdir)
5519.4.8 by Neil Martinsen-Burrell
some tests and mention in Whats New
617
        newdir = osutils.pathjoin(xdgconfigdir, 'bazaar')
618
        os.makedirs(newdir)
619
        self.assertEqual(config.config_dir(), newdir)
620
621
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
622
class TestIniConfig(tests.TestCaseInTempDir):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
623
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
624
    def make_config_parser(self, s):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
625
        conf = config.IniBasedConfig.from_string(s)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
626
        return conf, conf._get_parser()
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
627
5050.13.2 by Parth Malwankar
copy config file ownership only if a new file is created
628
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
629
class TestIniConfigBuilding(TestIniConfig):
630
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
631
    def test_contructs(self):
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
632
        my_config = config.IniBasedConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
633
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
634
    def test_from_fp(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
635
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
636
        self.assertIsInstance(my_config._get_parser(), configobj.ConfigObj)
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
637
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
638
    def test_cached(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
639
        my_config = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
640
        parser = my_config._get_parser()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
641
        self.assertTrue(my_config._get_parser() is parser)
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
642
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
643
    def _dummy_chown(self, path, uid, gid):
644
        self.path, self.uid, self.gid = path, uid, gid
645
646
    def test_ini_config_ownership(self):
5345.5.8 by Vincent Ladeuil
More doc and ensure that the config is locked when _write_config_file is called.
647
        """Ensure that chown is happening during _write_config_file"""
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
648
        self.requireFeature(features.chown_feature)
649
        self.overrideAttr(os, 'chown', self._dummy_chown)
650
        self.path = self.uid = self.gid = None
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
651
        conf = config.IniBasedConfig(file_name='./foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
652
        conf._write_config_file()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
653
        self.assertEquals(self.path, './foo.conf')
5050.13.1 by Parth Malwankar
fixed .bazaar ownership regression
654
        self.assertTrue(isinstance(self.uid, int))
655
        self.assertTrue(isinstance(self.gid, int))
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
656
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
657
    def test_get_filename_parameter_is_deprecated_(self):
658
        conf = self.callDeprecated([
659
            'IniBasedConfig.__init__(get_filename) was deprecated in 2.3.'
660
            ' Use file_name instead.'],
661
            config.IniBasedConfig, lambda: 'ini.conf')
5345.3.1 by Vincent Ladeuil
Check that _get_filename() is called and produces the desired side effect.
662
        self.assertEqual('ini.conf', conf.file_name)
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
663
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
664
    def test_get_parser_file_parameter_is_deprecated_(self):
665
        config_file = StringIO(sample_config_text.encode('utf-8'))
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
666
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
667
        conf = self.callDeprecated([
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
668
            'IniBasedConfig._get_parser(file=xxx) was deprecated in 2.3.'
669
            ' Use IniBasedConfig(_content=xxx) instead.'],
670
            conf._get_parser, file=config_file)
5345.1.4 by Vincent Ladeuil
Deprecate the ``file`` parameter of the ``config._get_parser()`` method.
671
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
672
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
673
class TestIniConfigSaving(tests.TestCaseInTempDir):
674
5345.1.1 by Vincent Ladeuil
Deprecate the get_filename parameter in IniBasedConfig.
675
    def test_cant_save_without_a_file_name(self):
676
        conf = config.IniBasedConfig()
677
        self.assertRaises(AssertionError, conf._write_config_file)
678
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
679
    def test_saved_with_content(self):
680
        content = 'foo = bar\n'
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
681
        conf = config.IniBasedConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
682
            content, file_name='./test.conf', save=True)
5345.1.16 by Vincent Ladeuil
Allows tests to save the config file at build time.
683
        self.assertFileEqual(content, 'test.conf')
684
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
685
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
686
class TestIniConfigOptionExpansion(tests.TestCase):
687
    """Test option expansion from the IniConfig level.
688
689
    What we really want here is to test the Config level, but the class being
690
    abstract as far as storing values is concerned, this can't be done
691
    properly (yet).
692
    """
693
    # FIXME: This should be rewritten when all configs share a storage
694
    # implementation -- vila 2011-02-18
695
696
    def get_config(self, string=None):
697
        if string is None:
698
            string = ''
699
        c = config.IniBasedConfig.from_string(string)
700
        return c
701
702
    def assertExpansion(self, expected, conf, string, env=None):
703
        self.assertEquals(expected, conf.expand_options(string, env))
704
705
    def test_no_expansion(self):
706
        c = self.get_config('')
707
        self.assertExpansion('foo', c, 'foo')
708
709
    def test_env_adding_options(self):
710
        c = self.get_config('')
711
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
712
713
    def test_env_overriding_options(self):
714
        c = self.get_config('foo=baz')
715
        self.assertExpansion('bar', c, '{foo}', {'foo': 'bar'})
716
717
    def test_simple_ref(self):
718
        c = self.get_config('foo=xxx')
719
        self.assertExpansion('xxx', c, '{foo}')
720
721
    def test_unknown_ref(self):
722
        c = self.get_config('')
723
        self.assertRaises(errors.ExpandingUnknownOption,
724
                          c.expand_options, '{foo}')
725
726
    def test_indirect_ref(self):
727
        c = self.get_config('''
728
foo=xxx
729
bar={foo}
730
''')
731
        self.assertExpansion('xxx', c, '{bar}')
732
733
    def test_embedded_ref(self):
734
        c = self.get_config('''
735
foo=xxx
736
bar=foo
737
''')
738
        self.assertExpansion('xxx', c, '{{bar}}')
739
740
    def test_simple_loop(self):
741
        c = self.get_config('foo={foo}')
742
        self.assertRaises(errors.OptionExpansionLoop, c.expand_options, '{foo}')
743
744
    def test_indirect_loop(self):
745
        c = self.get_config('''
746
foo={bar}
747
bar={baz}
748
baz={foo}''')
749
        e = self.assertRaises(errors.OptionExpansionLoop,
750
                              c.expand_options, '{foo}')
751
        self.assertEquals('foo->bar->baz', e.refs)
752
        self.assertEquals('{foo}', e.string)
753
754
    def test_list(self):
755
        conf = self.get_config('''
756
foo=start
757
bar=middle
758
baz=end
759
list={foo},{bar},{baz}
760
''')
761
        self.assertEquals(['start', 'middle', 'end'],
762
                           conf.get_user_option('list', expand=True))
763
764
    def test_cascading_list(self):
765
        conf = self.get_config('''
766
foo=start,{bar}
767
bar=middle,{baz}
768
baz=end
769
list={foo}
770
''')
771
        self.assertEquals(['start', 'middle', 'end'],
772
                           conf.get_user_option('list', expand=True))
773
774
    def test_pathological_hidden_list(self):
775
        conf = self.get_config('''
776
foo=bin
777
bar=go
778
start={foo
779
middle=},{
780
end=bar}
781
hidden={start}{middle}{end}
782
''')
783
        # Nope, it's either a string or a list, and the list wins as soon as a
784
        # ',' appears, so the string concatenation never occur.
785
        self.assertEquals(['{foo', '}', '{', 'bar}'],
786
                          conf.get_user_option('hidden', expand=True))
787
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
788
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
789
class TestLocationConfigOptionExpansion(tests.TestCaseInTempDir):
790
791
    def get_config(self, location, string=None):
792
        if string is None:
793
            string = ''
794
        # Since we don't save the config we won't strictly require to inherit
795
        # from TestCaseInTempDir, but an error occurs so quickly...
796
        c = config.LocationConfig.from_string(string, location)
797
        return c
798
799
    def test_dont_cross_unrelated_section(self):
800
        c = self.get_config('/another/branch/path','''
801
[/one/branch/path]
802
foo = hello
803
bar = {foo}/2
804
805
[/another/branch/path]
806
bar = {foo}/2
807
''')
808
        self.assertRaises(errors.ExpandingUnknownOption,
809
                          c.get_user_option, 'bar', expand=True)
810
811
    def test_cross_related_sections(self):
812
        c = self.get_config('/project/branch/path','''
813
[/project]
814
foo = qu
815
816
[/project/branch/path]
817
bar = {foo}ux
818
''')
819
        self.assertEquals('quux', c.get_user_option('bar', expand=True))
820
821
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
822
class TestIniBaseConfigOnDisk(tests.TestCaseInTempDir):
823
824
    def test_cannot_reload_without_name(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
825
        conf = config.IniBasedConfig.from_string(sample_config_text)
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
826
        self.assertRaises(AssertionError, conf.reload)
827
828
    def test_reload_see_new_value(self):
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
829
        c1 = config.IniBasedConfig.from_string('editor=vim\n',
830
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
831
        c1._write_config_file()
5345.5.13 by Vincent Ladeuil
Merge simplify-test-config-building into lockable-config-files resolving conflicts
832
        c2 = config.IniBasedConfig.from_string('editor=emacs\n',
833
                                               file_name='./test/conf')
5345.5.1 by Vincent Ladeuil
Implement config.reload and make sure we have a file name when using it.
834
        c2._write_config_file()
835
        self.assertEqual('vim', c1.get_user_option('editor'))
836
        self.assertEqual('emacs', c2.get_user_option('editor'))
837
        # Make sure we get the Right value
838
        c1.reload()
839
        self.assertEqual('emacs', c1.get_user_option('editor'))
840
841
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
842
class TestLockableConfig(tests.TestCaseInTempDir):
843
5506.2.1 by Vincent Ladeuil
Implements ``bzr config --active option`` displaying only the value.
844
    scenarios = lockable_config_scenarios()
845
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
846
    # Set by load_tests
847
    config_class = None
848
    config_args = None
849
    config_section = None
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
850
851
    def setUp(self):
852
        super(TestLockableConfig, self).setUp()
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
853
        self._content = '[%s]\none=1\ntwo=2\n' % (self.config_section,)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
854
        self.config = self.create_config(self._content)
855
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
856
    def get_existing_config(self):
857
        return self.config_class(*self.config_args)
858
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
859
    def create_config(self, content):
5396.1.1 by Vincent Ladeuil
Fix python-2.6-ism.
860
        kwargs = dict(save=True)
861
        c = self.config_class.from_string(content, *self.config_args, **kwargs)
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
862
        return c
863
864
    def test_simple_read_access(self):
865
        self.assertEquals('1', self.config.get_user_option('one'))
866
867
    def test_simple_write_access(self):
868
        self.config.set_user_option('one', 'one')
869
        self.assertEquals('one', self.config.get_user_option('one'))
870
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
871
    def test_listen_to_the_last_speaker(self):
872
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
873
        c2 = self.get_existing_config()
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
874
        c1.set_user_option('one', 'ONE')
875
        c2.set_user_option('two', 'TWO')
876
        self.assertEquals('ONE', c1.get_user_option('one'))
877
        self.assertEquals('TWO', c2.get_user_option('two'))
878
        # The second update respect the first one
879
        self.assertEquals('ONE', c2.get_user_option('one'))
880
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
881
    def test_last_speaker_wins(self):
882
        # If the same config is not shared, the same variable modified twice
883
        # can only see a single result.
884
        c1 = self.config
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
885
        c2 = self.get_existing_config()
5345.5.3 by Vincent Ladeuil
Add a test for concurrent writers ensuring the values propagate.
886
        c1.set_user_option('one', 'c1')
887
        c2.set_user_option('one', 'c2')
888
        self.assertEquals('c2', c2._get_user_option('one'))
889
        # The first modification is still available until another refresh
890
        # occur
891
        self.assertEquals('c1', c1._get_user_option('one'))
892
        c1.set_user_option('two', 'done')
893
        self.assertEquals('c2', c1._get_user_option('one'))
894
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
895
    def test_writes_are_serialized(self):
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
896
        c1 = self.config
897
        c2 = self.get_existing_config()
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
898
899
        # We spawn a thread that will pause *during* the write
900
        before_writing = threading.Event()
901
        after_writing = threading.Event()
902
        writing_done = threading.Event()
903
        c1_orig = c1._write_config_file
904
        def c1_write_config_file():
905
            before_writing.set()
906
            c1_orig()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
907
            # The lock is held. We wait for the main thread to decide when to
5345.5.4 by Vincent Ladeuil
Start implementing config files locking.
908
            # continue
909
            after_writing.wait()
910
        c1._write_config_file = c1_write_config_file
911
        def c1_set_option():
912
            c1.set_user_option('one', 'c1')
913
            writing_done.set()
914
        t1 = threading.Thread(target=c1_set_option)
915
        # Collect the thread after the test
916
        self.addCleanup(t1.join)
917
        # Be ready to unblock the thread if the test goes wrong
918
        self.addCleanup(after_writing.set)
919
        t1.start()
920
        before_writing.wait()
921
        self.assertTrue(c1._lock.is_held)
922
        self.assertRaises(errors.LockContention,
923
                          c2.set_user_option, 'one', 'c2')
924
        self.assertEquals('c1', c1.get_user_option('one'))
925
        # Let the lock be released
926
        after_writing.set()
927
        writing_done.wait()
928
        c2.set_user_option('one', 'c2')
929
        self.assertEquals('c2', c2.get_user_option('one'))
930
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
931
    def test_read_while_writing(self):
932
       c1 = self.config
933
       # We spawn a thread that will pause *during* the write
934
       ready_to_write = threading.Event()
935
       do_writing = threading.Event()
936
       writing_done = threading.Event()
937
       c1_orig = c1._write_config_file
938
       def c1_write_config_file():
939
           ready_to_write.set()
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
940
           # The lock is held. We wait for the main thread to decide when to
5345.5.7 by Vincent Ladeuil
Make LocationConfig use a lock too.
941
           # continue
942
           do_writing.wait()
943
           c1_orig()
944
           writing_done.set()
945
       c1._write_config_file = c1_write_config_file
946
       def c1_set_option():
947
           c1.set_user_option('one', 'c1')
948
       t1 = threading.Thread(target=c1_set_option)
949
       # Collect the thread after the test
950
       self.addCleanup(t1.join)
951
       # Be ready to unblock the thread if the test goes wrong
952
       self.addCleanup(do_writing.set)
953
       t1.start()
954
       # Ensure the thread is ready to write
955
       ready_to_write.wait()
956
       self.assertTrue(c1._lock.is_held)
957
       self.assertEquals('c1', c1.get_user_option('one'))
958
       # If we read during the write, we get the old value
959
       c2 = self.get_existing_config()
960
       self.assertEquals('1', c2.get_user_option('one'))
961
       # Let the writing occur and ensure it occurred
962
       do_writing.set()
963
       writing_done.wait()
964
       # Now we get the updated value
965
       c3 = self.get_existing_config()
966
       self.assertEquals('c1', c3.get_user_option('one'))
967
5345.1.7 by Vincent Ladeuil
Start LockableConfig tests.
968
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
969
class TestGetUserOptionAs(TestIniConfig):
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
970
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
971
    def test_get_user_option_as_bool(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
972
        conf, parser = self.make_config_parser("""
4503.2.2 by Vincent Ladeuil
Get a bool or none from a config file.
973
a_true_bool = true
974
a_false_bool = 0
975
an_invalid_bool = maybe
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
976
a_list = hmm, who knows ? # This is interpreted as a list !
4840.2.5 by Vincent Ladeuil
Refactor get_user_option_as_* tests.
977
""")
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
978
        get_bool = conf.get_user_option_as_bool
979
        self.assertEqual(True, get_bool('a_true_bool'))
980
        self.assertEqual(False, get_bool('a_false_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
981
        warnings = []
982
        def warning(*args):
983
            warnings.append(args[0] % args[1:])
984
        self.overrideAttr(trace, 'warning', warning)
985
        msg = 'Value "%s" is not a boolean for "%s"'
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
986
        self.assertIs(None, get_bool('an_invalid_bool'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
987
        self.assertEquals(msg % ('maybe', 'an_invalid_bool'), warnings[0])
988
        warnings = []
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
989
        self.assertIs(None, get_bool('not_defined_in_this_config'))
4989.2.12 by Vincent Ladeuil
Display a warning if an option value is not boolean.
990
        self.assertEquals([], warnings)
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
991
992
    def test_get_user_option_as_list(self):
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
993
        conf, parser = self.make_config_parser("""
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
994
a_list = a,b,c
995
length_1 = 1,
996
one_item = x
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
997
""")
998
        get_list = conf.get_user_option_as_list
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
999
        self.assertEqual(['a', 'b', 'c'], get_list('a_list'))
1000
        self.assertEqual(['1'], get_list('length_1'))
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1001
        self.assertEqual('x', conf.get_user_option('one_item'))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1002
        # automatically cast to list
1003
        self.assertEqual(['x'], get_list('one_item'))
1004
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1005
    def test_get_user_option_as_int_from_SI(self):
1006
        conf, parser = self.make_config_parser("""
1007
plain = 100
1008
si_k = 5k,
1009
si_kb = 5kb,
1010
si_m = 5M,
1011
si_mb = 5MB,
1012
si_g = 5g,
1013
si_gb = 5gB,
1014
""")
6378.1.2 by Vincent Ladeuil
Migrate add.maximum_file_size to the new config scheme
1015
        def get_si(s, default=None):
1016
            return self.applyDeprecated(
1017
                deprecated_in((2, 5, 0)),
1018
                conf.get_user_option_as_int_from_SI, s, default)
6046.2.3 by Shannon Weyrick
Add get_user_option_as_int_from_SI, for retrieving an integer
1019
        self.assertEqual(100, get_si('plain'))
1020
        self.assertEqual(5000, get_si('si_k'))
1021
        self.assertEqual(5000, get_si('si_kb'))
1022
        self.assertEqual(5000000, get_si('si_m'))
1023
        self.assertEqual(5000000, get_si('si_mb'))
1024
        self.assertEqual(5000000000, get_si('si_g'))
1025
        self.assertEqual(5000000000, get_si('si_gb'))
1026
        self.assertEqual(None, get_si('non-exist'))
1027
        self.assertEqual(42, get_si('non-exist-with-default',  42))
4840.2.4 by Vincent Ladeuil
Implement config.get_user_option_as_list.
1028
6378.1.1 by Vincent Ladeuil
Add int_SI_from_store as a config option helper
1029
4840.2.6 by Vincent Ladeuil
Implement config.suppress_warning.
1030
class TestSupressWarning(TestIniConfig):
1031
1032
    def make_warnings_config(self, s):
1033
        conf, parser = self.make_config_parser(s)
1034
        return conf.suppress_warning
1035
1036
    def test_suppress_warning_unknown(self):
1037
        suppress_warning = self.make_warnings_config('')
1038
        self.assertEqual(False, suppress_warning('unknown_warning'))
1039
1040
    def test_suppress_warning_known(self):
1041
        suppress_warning = self.make_warnings_config('suppress_warnings=a,b')
1042
        self.assertEqual(False, suppress_warning('c'))
1043
        self.assertEqual(True, suppress_warning('a'))
1044
        self.assertEqual(True, suppress_warning('b'))
1045
1046
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1047
class TestGetConfig(tests.TestCase):
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1048
1049
    def test_constructs(self):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1050
        my_config = config.GlobalConfig()
1051
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1052
    def test_calls_read_filenames(self):
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1053
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1054
        oldparserclass = config.ConfigObj
1055
        config.ConfigObj = InstrumentedConfigObj
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1056
        my_config = config.GlobalConfig()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1057
        try:
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1058
            parser = my_config._get_parser()
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1059
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1060
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1061
        self.assertIsInstance(parser, InstrumentedConfigObj)
1551.2.20 by Aaron Bentley
Treated config files as utf-8
1062
        self.assertEqual(parser._calls, [('__init__', config.config_filename(),
1063
                                          'utf-8')])
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1064
1065
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1066
class TestBranchConfig(tests.TestCaseWithTransport):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1067
1068
    def test_constructs(self):
1069
        branch = FakeBranch()
1070
        my_config = config.BranchConfig(branch)
1071
        self.assertRaises(TypeError, config.BranchConfig)
1072
1073
    def test_get_location_config(self):
1074
        branch = FakeBranch()
1075
        my_config = config.BranchConfig(branch)
1076
        location_config = my_config._get_location_config()
1077
        self.assertEqual(branch.base, location_config.location)
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1078
        self.assertIs(location_config, my_config._get_location_config())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1079
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1080
    def test_get_config(self):
1081
        """The Branch.get_config method works properly"""
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
1082
        b = controldir.ControlDir.create_standalone_workingtree('.').branch
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1083
        my_config = b.get_config()
1084
        self.assertIs(my_config.get_user_option('wacky'), None)
1085
        my_config.set_user_option('wacky', 'unlikely')
1086
        self.assertEqual(my_config.get_user_option('wacky'), 'unlikely')
1087
1088
        # Ensure we get the same thing if we start again
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1089
        b2 = branch.Branch.open('.')
1770.2.9 by Aaron Bentley
Add Branch.get_config, update BranchConfig() callers
1090
        my_config2 = b2.get_config()
1091
        self.assertEqual(my_config2.get_user_option('wacky'), 'unlikely')
1092
1824.1.1 by Robert Collins
Add BranchConfig.has_explicit_nickname call.
1093
    def test_has_explicit_nickname(self):
1094
        b = self.make_branch('.')
1095
        self.assertFalse(b.get_config().has_explicit_nickname())
1096
        b.nick = 'foo'
1097
        self.assertTrue(b.get_config().has_explicit_nickname())
1098
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1099
    def test_config_url(self):
1100
        """The Branch.get_config will use section that uses a local url"""
1101
        branch = self.make_branch('branch')
1102
        self.assertEqual('branch', branch.nick)
1103
1104
        local_url = urlutils.local_path_to_url('branch')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1105
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1106
            '[%s]\nnickname = foobar' % (local_url,),
1107
            local_url, save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1108
        self.assertEqual('foobar', branch.nick)
1109
1110
    def test_config_local_path(self):
1111
        """The Branch.get_config will use a local system path"""
1112
        branch = self.make_branch('branch')
1113
        self.assertEqual('branch', branch.nick)
1114
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1115
        local_path = osutils.getcwd().encode('utf8')
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1116
        conf = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1117
            '[%s/branch]\nnickname = barry' % (local_path,),
1118
            'branch',  save=True)
1878.1.1 by John Arbash Meinel
Entries in locations.conf should prefer local paths if available (bug #53653)
1119
        self.assertEqual('barry', branch.nick)
1120
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1121
    def test_config_creates_local(self):
1122
        """Creating a new entry in config uses a local path."""
2230.3.6 by Aaron Bentley
work in progress bind stuff
1123
        branch = self.make_branch('branch', format='knit')
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1124
        branch.set_push_location('http://foobar')
1125
        local_path = osutils.getcwd().encode('utf8')
1126
        # Surprisingly ConfigObj doesn't create a trailing newline
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1127
        self.check_file_contents(config.locations_config_filename(),
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1128
                                 '[%s/branch]\n'
1129
                                 'push_location = http://foobar\n'
3221.7.1 by Matt Nordhoff
Upgrade ConfigObj to version 4.5.1.
1130
                                 'push_location:policy = norecurse\n'
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1131
                                 % (local_path,))
1878.1.2 by John Arbash Meinel
Add a test that new locations.conf entries are created with a local path, rather than a URL
1132
2120.5.4 by Alexander Belchenko
Whitebox test for Config.get_nickname (req. by Aaron Bentley)
1133
    def test_autonick_urlencoded(self):
1134
        b = self.make_branch('!repo')
1135
        self.assertEqual('!repo', b.get_config().get_nickname())
1136
6437.32.1 by Aaron Bentley
Use colocated branch names as nicknames.
1137
    def test_autonick_uses_branch_name(self):
1138
        b = self.make_branch('foo', name='bar')
1139
        self.assertEqual('bar', b.get_config().get_nickname())
1140
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1141
    def test_warn_if_masked(self):
1142
        warnings = []
1143
        def warning(*args):
1144
            warnings.append(args[0] % args[1:])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1145
        self.overrideAttr(trace, 'warning', warning)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1146
1147
        def set_option(store, warn_masked=True):
1148
            warnings[:] = []
1149
            conf.set_user_option('example_option', repr(store), store=store,
1150
                                 warn_masked=warn_masked)
1151
        def assertWarning(warning):
1152
            if warning is None:
1153
                self.assertEqual(0, len(warnings))
1154
            else:
1155
                self.assertEqual(1, len(warnings))
1156
                self.assertEqual(warning, warnings[0])
5345.1.12 by Vincent Ladeuil
Cleanup test_config some more.
1157
        branch = self.make_branch('.')
1158
        conf = branch.get_config()
1159
        set_option(config.STORE_GLOBAL)
1160
        assertWarning(None)
1161
        set_option(config.STORE_BRANCH)
1162
        assertWarning(None)
1163
        set_option(config.STORE_GLOBAL)
1164
        assertWarning('Value "4" is masked by "3" from branch.conf')
1165
        set_option(config.STORE_GLOBAL, warn_masked=False)
1166
        assertWarning(None)
1167
        set_option(config.STORE_LOCATION)
1168
        assertWarning(None)
1169
        set_option(config.STORE_BRANCH)
1170
        assertWarning('Value "3" is masked by "0" from locations.conf')
1171
        set_option(config.STORE_BRANCH, warn_masked=False)
1172
        assertWarning(None)
1551.15.35 by Aaron Bentley
Warn when setting config values that will be masked (#122286)
1173
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1174
5448.1.1 by Vincent Ladeuil
Use TestCaseInTempDir for tests requiring disk resources
1175
class TestGlobalConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1176
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1177
    def test_user_id(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1178
        my_config = config.GlobalConfig.from_string(sample_config_text)
1551.2.21 by Aaron Bentley
Formatted unicode config tests as ASCII
1179
        self.assertEqual(u"Erik B\u00e5gfors <erik@bagfors.nu>",
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1180
                         my_config._get_user_id())
1442.1.2 by Robert Collins
create a config module - there is enough config logic to make this worthwhile, and start testing config processing.
1181
1182
    def test_absent_user_id(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1183
        my_config = config.GlobalConfig()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1184
        self.assertEqual(None, my_config._get_user_id())
1185
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1186
    def test_signatures_always(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1187
        my_config = config.GlobalConfig.from_string(sample_always_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1188
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1189
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1190
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1191
        self.assertEqual(config.SIGN_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1192
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1193
                             my_config.signing_policy))
1194
        self.assertEqual(True,
1195
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1196
                my_config.signature_needed))
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1197
1198
    def test_signatures_if_possible(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1199
        my_config = config.GlobalConfig.from_string(sample_maybe_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1200
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1201
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1202
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1203
        self.assertEqual(config.SIGN_WHEN_REQUIRED,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1204
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1205
                             my_config.signing_policy))
1206
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1207
            my_config.signature_needed))
1442.1.17 by Robert Collins
allow global overriding of signature policy to force checking, or (pointless but allowed) to set auto checking
1208
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1209
    def test_signatures_ignore(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1210
        my_config = config.GlobalConfig.from_string(sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1211
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1212
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1213
                             my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1214
        self.assertEqual(config.SIGN_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1215
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1216
                             my_config.signing_policy))
1217
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1218
            my_config.signature_needed))
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1219
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1220
    def _get_sample_config(self):
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1221
        my_config = config.GlobalConfig.from_string(sample_config_text)
1534.7.154 by Aaron Bentley
Removed changes from bzr.ab 1529..1536
1222
        return my_config
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1223
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1224
    def test_gpg_signing_command(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1225
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1226
        self.assertEqual("gnome-gpg",
1227
            self.applyDeprecated(
1228
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
1229
        self.assertEqual(False, self.applyDeprecated(deprecated_in((2, 5, 0)),
1230
            my_config.signature_needed))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1231
6012.2.3 by Jonathan Riddell
add config option for signing key
1232
    def test_gpg_signing_key(self):
1233
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1234
        self.assertEqual("DD4D5088",
1235
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1236
                my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1237
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1238
    def _get_empty_config(self):
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1239
        my_config = config.GlobalConfig()
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1240
        return my_config
1241
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1242
    def test_gpg_signing_command_unset(self):
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1243
        my_config = self._get_empty_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1244
        self.assertEqual("gpg",
1245
            self.applyDeprecated(
1246
                deprecated_in((2, 5, 0)), my_config.gpg_signing_command))
1442.1.59 by Robert Collins
Add re-sign command to generate a digital signature on a single revision.
1247
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1248
    def test_get_user_option_default(self):
1249
        my_config = self._get_empty_config()
1250
        self.assertEqual(None, my_config.get_user_option('no_option'))
1251
1252
    def test_get_user_option_global(self):
1253
        my_config = self._get_sample_config()
1254
        self.assertEqual("something",
1255
                         my_config.get_user_option('user_global_option'))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1256
1472 by Robert Collins
post commit hook, first pass implementation
1257
    def test_post_commit_default(self):
1258
        my_config = self._get_sample_config()
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1259
        self.assertEqual(None,
1260
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1261
                                              my_config.post_commit))
1472 by Robert Collins
post commit hook, first pass implementation
1262
1553.2.9 by Erik BÃ¥gfors
log_formatter => log_format for "named" formatters
1263
    def test_configured_logformat(self):
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1264
        my_config = self._get_sample_config()
6378.1.3 by Vincent Ladeuil
log_format has been migrated but the old config method needs to be deprecated.
1265
        self.assertEqual("short",
1266
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1267
                                              my_config.log_format))
1553.2.8 by Erik BÃ¥gfors
tests for config log_formatter
1268
5971.1.58 by Jonathan Riddell
more tests for new config options
1269
    def test_configured_acceptable_keys(self):
1270
        my_config = self._get_sample_config()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1271
        self.assertEqual("amy",
1272
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1273
                my_config.acceptable_keys))
5971.1.58 by Jonathan Riddell
more tests for new config options
1274
1275
    def test_configured_validate_signatures_in_log(self):
1276
        my_config = self._get_sample_config()
1277
        self.assertEqual(True, my_config.validate_signatures_in_log())
1278
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1279
    def test_get_alias(self):
1280
        my_config = self._get_sample_config()
1281
        self.assertEqual('help', my_config.get_alias('h'))
1282
2900.3.6 by Tim Penhey
Added tests.
1283
    def test_get_aliases(self):
1284
        my_config = self._get_sample_config()
1285
        aliases = my_config.get_aliases()
1286
        self.assertEqual(2, len(aliases))
1287
        sorted_keys = sorted(aliases)
1288
        self.assertEqual('help', aliases[sorted_keys[0]])
1289
        self.assertEqual(sample_long_alias, aliases[sorted_keys[1]])
1290
1553.6.12 by Erik BÃ¥gfors
remove AliasConfig, based on input from abentley
1291
    def test_get_no_alias(self):
1292
        my_config = self._get_sample_config()
1293
        self.assertEqual(None, my_config.get_alias('foo'))
1294
1295
    def test_get_long_alias(self):
1296
        my_config = self._get_sample_config()
1297
        self.assertEqual(sample_long_alias, my_config.get_alias('ll'))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1298
4603.1.10 by Aaron Bentley
Provide change editor via config.
1299
    def test_get_change_editor(self):
1300
        my_config = self._get_sample_config()
1301
        change_editor = my_config.get_change_editor('old', 'new')
1302
        self.assertIs(diff.DiffFromTool, change_editor.__class__)
4603.1.20 by Aaron Bentley
Use string.Template substitution with @ as delimiter.
1303
        self.assertEqual('vimdiff -of @new_path @old_path',
4603.1.10 by Aaron Bentley
Provide change editor via config.
1304
                         ' '.join(change_editor.command_template))
1305
1306
    def test_get_no_change_editor(self):
1307
        my_config = self._get_empty_config()
1308
        change_editor = my_config.get_change_editor('old', 'new')
1309
        self.assertIs(None, change_editor)
1310
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1311
    def test_get_merge_tools(self):
1312
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1313
        tools = conf.get_merge_tools()
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1314
        self.log(repr(tools))
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1315
        self.assertEqual(
1316
            {u'funkytool' : u'funkytool "arg with spaces" {this_temp}',
6091.4.2 by Gordon Tyler
Updated TestGlobalConfigItems.test_get_merge_tools for new config quoting behaviour.
1317
            u'sometool' : u'sometool {base} {this} {other} -o {result}',
1318
            u'newtool' : u'"newtool with spaces" {this_temp}'},
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1319
            tools)
5321.1.89 by Gordon Tyler
Moved mergetools config tests to bzrlib.tests.test_config.
1320
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1321
    def test_get_merge_tools_empty(self):
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1322
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1323
        tools = conf.get_merge_tools()
1324
        self.assertEqual({}, tools)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1325
1326
    def test_find_merge_tool(self):
1327
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1328
        cmdline = conf.find_merge_tool('sometool')
1329
        self.assertEqual('sometool {base} {this} {other} -o {result}', cmdline)
5321.1.103 by Gordon Tyler
Renamed _find_merge_tool back to find_merge_tool since it must be public for UI code to lookup merge tools by name, and added tests for it.
1330
1331
    def test_find_merge_tool_not_found(self):
1332
        conf = self._get_sample_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1333
        cmdline = conf.find_merge_tool('DOES NOT EXIST')
1334
        self.assertIs(cmdline, None)
5321.1.93 by Gordon Tyler
Added tests for get_default_merge_tool.
1335
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1336
    def test_find_merge_tool_known(self):
1337
        conf = self._get_empty_config()
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1338
        cmdline = conf.find_merge_tool('kdiff3')
1339
        self.assertEquals('kdiff3 {base} {this} {other} -o {result}', cmdline)
5676.1.4 by Jelmer Vernooij
merge bzr.dev.
1340
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1341
    def test_find_merge_tool_override_known(self):
1342
        conf = self._get_empty_config()
5321.1.112 by Gordon Tyler
Removed set_merge_tool, remove_merge_tool and set_default_merge_tool from Config.
1343
        conf.set_user_option('bzr.mergetool.kdiff3', 'kdiff3 blah')
5321.1.116 by Gordon Tyler
Simplified mergetools module down to functions which deal with command lines -- no MergeTool class.
1344
        cmdline = conf.find_merge_tool('kdiff3')
1345
        self.assertEqual('kdiff3 blah', cmdline)
5321.1.108 by Gordon Tyler
Changed known merge tools into a default set of merge tools that are always defined but can be overridden by user-defined merge tools.
1346
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1347
2900.3.6 by Tim Penhey
Added tests.
1348
class TestGlobalConfigSavingOptions(tests.TestCaseInTempDir):
1349
1350
    def test_empty(self):
1351
        my_config = config.GlobalConfig()
1352
        self.assertEqual(0, len(my_config.get_aliases()))
1353
1354
    def test_set_alias(self):
1355
        my_config = config.GlobalConfig()
1356
        alias_value = 'commit --strict'
1357
        my_config.set_alias('commit', alias_value)
1358
        new_config = config.GlobalConfig()
1359
        self.assertEqual(alias_value, new_config.get_alias('commit'))
1360
1361
    def test_remove_alias(self):
1362
        my_config = config.GlobalConfig()
1363
        my_config.set_alias('commit', 'commit --strict')
1364
        # Now remove the alias again.
1365
        my_config.unset_alias('commit')
1366
        new_config = config.GlobalConfig()
1367
        self.assertIs(None, new_config.get_alias('commit'))
1368
1369
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1370
class TestLocationConfig(tests.TestCaseInTempDir, TestOptionsMixin):
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1371
1372
    def test_constructs(self):
1373
        my_config = config.LocationConfig('http://example.com')
1374
        self.assertRaises(TypeError, config.LocationConfig)
1375
1376
    def test_branch_calls_read_filenames(self):
1474 by Robert Collins
Merge from Aaron Bentley.
1377
        # This is testing the correct file names are provided.
1378
        # TODO: consolidate with the test for GlobalConfigs filename checks.
1379
        #
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1380
        # replace the class that is constructed, to check its parameters
1474 by Robert Collins
Merge from Aaron Bentley.
1381
        oldparserclass = config.ConfigObj
1382
        config.ConfigObj = InstrumentedConfigObj
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1383
        try:
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1384
            my_config = config.LocationConfig('http://www.example.com')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1385
            parser = my_config._get_parser()
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1386
        finally:
1474 by Robert Collins
Merge from Aaron Bentley.
1387
            config.ConfigObj = oldparserclass
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1388
        self.assertIsInstance(parser, InstrumentedConfigObj)
1474 by Robert Collins
Merge from Aaron Bentley.
1389
        self.assertEqual(parser._calls,
1770.2.2 by Aaron Bentley
Rename branches.conf to locations.conf
1390
                         [('__init__', config.locations_config_filename(),
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1391
                           'utf-8')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1392
1393
    def test_get_global_config(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1394
        my_config = config.BranchConfig(FakeBranch('http://example.com'))
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1395
        global_config = my_config._get_global_config()
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
1396
        self.assertIsInstance(global_config, config.GlobalConfig)
1397
        self.assertIs(global_config, my_config._get_global_config())
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1398
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1399
    def assertLocationMatching(self, expected):
1400
        self.assertEqual(expected,
1401
                         list(self.my_location_config._get_matching_sections()))
1402
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1403
    def test__get_matching_sections_no_match(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1404
        self.get_branch_config('/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1405
        self.assertLocationMatching([])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1406
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1407
    def test__get_matching_sections_exact(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1408
        self.get_branch_config('http://www.example.com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1409
        self.assertLocationMatching([('http://www.example.com', '')])
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1410
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1411
    def test__get_matching_sections_suffix_does_not(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1412
        self.get_branch_config('http://www.example.com-com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1413
        self.assertLocationMatching([])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1414
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1415
    def test__get_matching_sections_subdir_recursive(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1416
        self.get_branch_config('http://www.example.com/com')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1417
        self.assertLocationMatching([('http://www.example.com', 'com')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1418
1993.3.5 by James Henstridge
add back recurse=False option to config file
1419
    def test__get_matching_sections_ignoreparent(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1420
        self.get_branch_config('http://www.example.com/ignoreparent')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1421
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1422
                                      '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1423
1993.3.5 by James Henstridge
add back recurse=False option to config file
1424
    def test__get_matching_sections_ignoreparent_subdir(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1425
        self.get_branch_config(
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1426
            'http://www.example.com/ignoreparent/childbranch')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1427
        self.assertLocationMatching([('http://www.example.com/ignoreparent',
1428
                                      'childbranch')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1429
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1430
    def test__get_matching_sections_subdir_trailing_slash(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1431
        self.get_branch_config('/b')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1432
        self.assertLocationMatching([('/b/', '')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1433
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1434
    def test__get_matching_sections_subdir_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1435
        self.get_branch_config('/a/foo')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1436
        self.assertLocationMatching([('/a/*', ''), ('/a/', 'foo')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1437
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1438
    def test__get_matching_sections_subdir_child_child(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1439
        self.get_branch_config('/a/foo/bar')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1440
        self.assertLocationMatching([('/a/*', 'bar'), ('/a/', 'foo/bar')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1441
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1442
    def test__get_matching_sections_trailing_slash_with_children(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1443
        self.get_branch_config('/a/')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1444
        self.assertLocationMatching([('/a/', '')])
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1445
1993.3.1 by James Henstridge
first go at making location config lookup recursive
1446
    def test__get_matching_sections_explicit_over_glob(self):
1447
        # XXX: 2006-09-08 jamesh
1448
        # This test only passes because ord('c') > ord('*').  If there
1449
        # was a config section for '/a/?', it would get precedence
1450
        # over '/a/c'.
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1451
        self.get_branch_config('/a/c')
5764.1.4 by Vincent Ladeuil
Using iterators is even clearer.
1452
        self.assertLocationMatching([('/a/c', ''), ('/a/*', ''), ('/a/', 'c')])
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1453
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1454
    def test__get_option_policy_normal(self):
1455
        self.get_branch_config('http://www.example.com')
1456
        self.assertEqual(
1457
            self.my_location_config._get_config_policy(
1458
            'http://www.example.com', 'normal_option'),
1459
            config.POLICY_NONE)
1460
1461
    def test__get_option_policy_norecurse(self):
1462
        self.get_branch_config('http://www.example.com')
1463
        self.assertEqual(
1464
            self.my_location_config._get_option_policy(
1465
            'http://www.example.com', 'norecurse_option'),
1466
            config.POLICY_NORECURSE)
1467
        # Test old recurse=False setting:
1468
        self.assertEqual(
1469
            self.my_location_config._get_option_policy(
1470
            'http://www.example.com/norecurse', 'normal_option'),
1471
            config.POLICY_NORECURSE)
1472
1473
    def test__get_option_policy_normal(self):
1474
        self.get_branch_config('http://www.example.com')
1475
        self.assertEqual(
1476
            self.my_location_config._get_option_policy(
1477
            'http://www.example.com', 'appendpath_option'),
1478
            config.POLICY_APPENDPATH)
1479
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1480
    def test__get_options_with_policy(self):
1481
        self.get_branch_config('/dir/subdir',
1482
                               location_config="""\
1483
[/dir]
1484
other_url = /other-dir
1485
other_url:policy = appendpath
1486
[/dir/subdir]
1487
other_url = /other-subdir
1488
""")
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1489
        self.assertOptions(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1490
            [(u'other_url', u'/other-subdir', u'/dir/subdir', 'locations'),
1491
             (u'other_url', u'/other-dir', u'/dir', 'locations'),
1492
             (u'other_url:policy', u'appendpath', u'/dir', 'locations')],
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
1493
            self.my_location_config)
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1494
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1495
    def test_location_without_username(self):
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1496
        self.get_branch_config('http://www.example.com/ignoreparent')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1497
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1498
                         self.my_config.username())
1499
1500
    def test_location_not_listed(self):
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1501
        """Test that the global username is used when no location matches"""
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1502
        self.get_branch_config('/home/robertc/sources')
1704.2.18 by Martin Pool
Remove duplicated TestLocationConfig and update previously hidden tests. (#32587)
1503
        self.assertEqual(u'Erik B\u00e5gfors <erik@bagfors.nu>',
1442.1.8 by Robert Collins
preparing some tests for LocationConfig
1504
                         self.my_config.username())
1505
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1506
    def test_overriding_location(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1507
        self.get_branch_config('http://www.example.com/foo')
1442.1.13 by Robert Collins
branches.conf is now able to override the users email
1508
        self.assertEqual('Robert Collins <robertc@example.org>',
1509
                         self.my_config.username())
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1510
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1511
    def test_signatures_not_set(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1512
        self.get_branch_config('http://www.example.com',
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1513
                                 global_config=sample_ignore_signatures)
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1514
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1515
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1516
                             self.my_config.signature_checking))
1770.2.1 by Aaron Bentley
Use create_signature for signing policy, deprecate check_signatures for this
1517
        self.assertEqual(config.SIGN_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1518
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1519
                             self.my_config.signing_policy))
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1520
1521
    def test_signatures_never(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1522
        self.get_branch_config('/a/c')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1523
        self.assertEqual(config.CHECK_NEVER,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1524
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1525
                             self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1526
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1527
    def test_signatures_when_available(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1528
        self.get_branch_config('/a/', global_config=sample_ignore_signatures)
1442.1.16 by Robert Collins
allow global overriding of signature policy to never check
1529
        self.assertEqual(config.CHECK_IF_POSSIBLE,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1530
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1531
                             self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1532
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1533
    def test_signatures_always(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1534
        self.get_branch_config('/b')
1442.1.18 by Robert Collins
permit per branch location overriding of signature checking policy
1535
        self.assertEqual(config.CHECK_ALWAYS,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1536
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1537
                         self.my_config.signature_checking))
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1538
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1539
    def test_gpg_signing_command(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1540
        self.get_branch_config('/b')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1541
        self.assertEqual("gnome-gpg",
1542
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1543
                self.my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1544
1545
    def test_gpg_signing_command_missing(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1546
        self.get_branch_config('/a')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1547
        self.assertEqual("false",
1548
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1549
                self.my_config.gpg_signing_command))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1550
6012.2.3 by Jonathan Riddell
add config option for signing key
1551
    def test_gpg_signing_key(self):
1552
        self.get_branch_config('/b')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1553
        self.assertEqual("DD4D5088", self.applyDeprecated(deprecated_in((2, 5, 0)),
1554
            self.my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1555
6012.2.9 by Jonathan Riddell
fixes 68501
1556
    def test_gpg_signing_key_default(self):
6012.2.3 by Jonathan Riddell
add config option for signing key
1557
        self.get_branch_config('/a')
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1558
        self.assertEqual("erik@bagfors.nu",
1559
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1560
                self.my_config.gpg_signing_key))
6012.2.3 by Jonathan Riddell
add config option for signing key
1561
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1562
    def test_get_user_option_global(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1563
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1564
        self.assertEqual('something',
1565
                         self.my_config.get_user_option('user_global_option'))
1566
1567
    def test_get_user_option_local(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1568
        self.get_branch_config('/a')
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1569
        self.assertEqual('local',
1570
                         self.my_config.get_user_option('user_local_option'))
1993.3.3 by James Henstridge
make _get_matching_sections() return (section, extra_path) tuples, and adjust other code to match
1571
2120.6.3 by James Henstridge
add some more tests for getting policy options, and behaviour of get_user_option in the presence of config policies
1572
    def test_get_user_option_appendpath(self):
1573
        # returned as is for the base path:
1574
        self.get_branch_config('http://www.example.com')
1575
        self.assertEqual('append',
1576
                         self.my_config.get_user_option('appendpath_option'))
1577
        # Extra path components get appended:
1578
        self.get_branch_config('http://www.example.com/a/b/c')
1579
        self.assertEqual('append/a/b/c',
1580
                         self.my_config.get_user_option('appendpath_option'))
1581
        # Overriden for http://www.example.com/dir, where it is a
1582
        # normal option:
1583
        self.get_branch_config('http://www.example.com/dir/a/b/c')
1584
        self.assertEqual('normal',
1585
                         self.my_config.get_user_option('appendpath_option'))
1586
1587
    def test_get_user_option_norecurse(self):
1588
        self.get_branch_config('http://www.example.com')
1589
        self.assertEqual('norecurse',
1590
                         self.my_config.get_user_option('norecurse_option'))
1591
        self.get_branch_config('http://www.example.com/dir')
1592
        self.assertEqual(None,
1593
                         self.my_config.get_user_option('norecurse_option'))
1594
        # http://www.example.com/norecurse is a recurse=False section
1595
        # that redefines normal_option.  Subdirectories do not pick up
1596
        # this redefinition.
1597
        self.get_branch_config('http://www.example.com/norecurse')
1598
        self.assertEqual('norecurse',
1599
                         self.my_config.get_user_option('normal_option'))
1600
        self.get_branch_config('http://www.example.com/norecurse/subdir')
1601
        self.assertEqual('normal',
1602
                         self.my_config.get_user_option('normal_option'))
1603
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1604
    def test_set_user_option_norecurse(self):
1605
        self.get_branch_config('http://www.example.com')
1606
        self.my_config.set_user_option('foo', 'bar',
1607
                                       store=config.STORE_LOCATION_NORECURSE)
1608
        self.assertEqual(
1609
            self.my_location_config._get_option_policy(
1610
            'http://www.example.com', 'foo'),
1611
            config.POLICY_NORECURSE)
1612
1613
    def test_set_user_option_appendpath(self):
1614
        self.get_branch_config('http://www.example.com')
1615
        self.my_config.set_user_option('foo', 'bar',
1616
                                       store=config.STORE_LOCATION_APPENDPATH)
1617
        self.assertEqual(
1618
            self.my_location_config._get_option_policy(
1619
            'http://www.example.com', 'foo'),
1620
            config.POLICY_APPENDPATH)
1621
1622
    def test_set_user_option_change_policy(self):
1623
        self.get_branch_config('http://www.example.com')
1624
        self.my_config.set_user_option('norecurse_option', 'normal',
1625
                                       store=config.STORE_LOCATION)
1626
        self.assertEqual(
1627
            self.my_location_config._get_option_policy(
1628
            'http://www.example.com', 'norecurse_option'),
1629
            config.POLICY_NONE)
1630
1631
    def test_set_user_option_recurse_false_section(self):
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1632
        # The following section has recurse=False set.  The test is to
1633
        # make sure that a normal option can be added to the section,
1634
        # converting recurse=False to the norecurse policy.
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1635
        self.get_branch_config('http://www.example.com/norecurse')
2120.6.11 by James Henstridge
s/0.13/0.14/ in deprecation warning
1636
        self.callDeprecated(['The recurse option is deprecated as of 0.14.  '
2120.6.9 by James Henstridge
Fixes for issues brought up in John's review
1637
                             'The section "http://www.example.com/norecurse" '
1638
                             'has been converted to use policies.'],
1639
                            self.my_config.set_user_option,
1640
                            'foo', 'bar', store=config.STORE_LOCATION)
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1641
        self.assertEqual(
1642
            self.my_location_config._get_option_policy(
1643
            'http://www.example.com/norecurse', 'foo'),
1644
            config.POLICY_NONE)
1645
        # The previously existing option is still norecurse:
1646
        self.assertEqual(
1647
            self.my_location_config._get_option_policy(
1648
            'http://www.example.com/norecurse', 'normal_option'),
1649
            config.POLICY_NORECURSE)
1650
1472 by Robert Collins
post commit hook, first pass implementation
1651
    def test_post_commit_default(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1652
        self.get_branch_config('/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1653
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1654
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1655
                                              self.my_config.post_commit))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1656
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1657
    def get_branch_config(self, location, global_config=None,
1658
                          location_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1659
        my_branch = FakeBranch(location)
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1660
        if global_config is None:
5345.2.2 by Vincent Ladeuil
Simplify test config building.
1661
            global_config = sample_config_text
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1662
        if location_config is None:
1663
            location_config = sample_branches_text
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1664
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1665
        my_global_config = config.GlobalConfig.from_string(global_config,
1666
                                                           save=True)
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1667
        my_location_config = config.LocationConfig.from_string(
5533.1.1 by Vincent Ladeuil
Fix ``bzr config`` to respect policies when displaying values and also display sections when appropriate.
1668
            location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1669
        my_config = config.BranchConfig(my_branch)
1670
        self.my_config = my_config
1671
        self.my_location_config = my_config._get_location_config()
1502 by Robert Collins
Bugfix the config test suite to not create .bazaar in the dir where it is run.
1672
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1673
    def test_set_user_setting_sets_and_saves(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1674
        self.get_branch_config('/a/c')
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1675
        record = InstrumentedConfigObj("foo")
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1676
        self.my_location_config._parser = record
1185.62.6 by John Arbash Meinel
Updated test_set_user_setting_sets_and_saves to remove the print statement, and make sure it is doing the right thing
1677
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1678
        self.callDeprecated(['The recurse option is deprecated as of '
1679
                             '0.14.  The section "/a/c" has been '
1680
                             'converted to use policies.'],
1681
                            self.my_config.set_user_option,
1682
                            'foo', 'bar', store=config.STORE_LOCATION)
5345.1.8 by Vincent Ladeuil
Make the test_listen_to_the_last_speaker pass and fix fallouts.
1683
        self.assertEqual([('reload',),
1684
                          ('__contains__', '/a/c'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1685
                          ('__contains__', '/a/c/'),
1686
                          ('__setitem__', '/a/c', {}),
1687
                          ('__getitem__', '/a/c'),
1688
                          ('__setitem__', 'foo', 'bar'),
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1689
                          ('__getitem__', '/a/c'),
1690
                          ('as_bool', 'recurse'),
1691
                          ('__getitem__', '/a/c'),
1692
                          ('__delitem__', 'recurse'),
1693
                          ('__getitem__', '/a/c'),
1694
                          ('keys',),
2120.6.8 by James Henstridge
Change syntax for setting config option policies. Rather than
1695
                          ('__getitem__', '/a/c'),
1696
                          ('__contains__', 'foo:policy'),
1490 by Robert Collins
Implement a 'bzr push' command, with saved locations; update diff to return 1.
1697
                          ('write',)],
1698
                         record._calls[1:])
1699
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1700
    def test_set_user_setting_sets_and_saves2(self):
1701
        self.get_branch_config('/a/c')
1702
        self.assertIs(self.my_config.get_user_option('foo'), None)
1703
        self.my_config.set_user_option('foo', 'bar')
1704
        self.assertEqual(
3616.2.6 by Mark Hammond
Fix test_set_user_setting_sets_and_saves2 on windows by stripping EOL
1705
            self.my_config.branch.control_files.files['branch.conf'].strip(),
1706
            'foo = bar')
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1707
        self.assertEqual(self.my_config.get_user_option('foo'), 'bar')
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1708
        self.my_config.set_user_option('foo', 'baz',
1709
                                       store=config.STORE_LOCATION)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1710
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
1711
        self.my_config.set_user_option('foo', 'qux')
1712
        self.assertEqual(self.my_config.get_user_option('foo'), 'baz')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1713
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1714
    def test_get_bzr_remote_path(self):
1715
        my_config = config.LocationConfig('/a/c')
1716
        self.assertEqual('bzr', my_config.get_bzr_remote_path())
1717
        my_config.set_user_option('bzr_remote_path', '/path-bzr')
1718
        self.assertEqual('/path-bzr', my_config.get_bzr_remote_path())
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1719
        self.overrideEnv('BZR_REMOTE_PATH', '/environ-bzr')
1551.18.17 by Aaron Bentley
Introduce bzr_remote_path configuration variable
1720
        self.assertEqual('/environ-bzr', my_config.get_bzr_remote_path())
1721
1185.62.7 by John Arbash Meinel
Whitespace cleanup.
1722
1770.2.8 by Aaron Bentley
Add precedence test
1723
precedence_global = 'option = global'
1724
precedence_branch = 'option = branch'
1725
precedence_location = """
1726
[http://]
1727
recurse = true
1728
option = recurse
1729
[http://example.com/specific]
1730
option = exact
1731
"""
1732
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1733
class TestBranchConfigItems(tests.TestCaseInTempDir):
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1734
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1735
    def get_branch_config(self, global_config=None, location=None,
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1736
                          location_config=None, branch_data_config=None):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1737
        my_branch = FakeBranch(location)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1738
        if global_config is not None:
5345.1.26 by Vincent Ladeuil
Merge lockable-config-files into remove-gratuitous-ensure-config-dir-exist-calls resolving conflicts
1739
            my_global_config = config.GlobalConfig.from_string(global_config,
1740
                                                               save=True)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1741
        if location_config is not None:
5345.2.9 by Vincent Ladeuil
Rename IniBaseConfig.from_bytes to from_string.
1742
            my_location_config = config.LocationConfig.from_string(
5345.1.25 by Vincent Ladeuil
Move the '_save' parameter from '__init__' to 'from_bytes', fix fallouts.
1743
                location_config, my_branch.base, save=True)
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1744
        my_config = config.BranchConfig(my_branch)
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1745
        if branch_data_config is not None:
1746
            my_config.branch.control_files.files['branch.conf'] = \
1747
                branch_data_config
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1748
        return my_config
1749
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1750
    def test_user_id(self):
6362.1.4 by Jelmer Vernooij
Fix tests.
1751
        branch = FakeBranch()
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1752
        my_config = config.BranchConfig(branch)
6362.1.4 by Jelmer Vernooij
Fix tests.
1753
        self.assertIsNot(None, my_config.username())
3388.2.3 by Martin Pool
Fix up more uses of LockableFiles.get_utf8 in tests
1754
        my_config.branch.control_files.files['email'] = "John"
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1755
        my_config.set_user_option('email',
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1756
                                  "Robert Collins <robertc@example.org>")
1757
        self.assertEqual("Robert Collins <robertc@example.org>",
6362.1.4 by Jelmer Vernooij
Fix tests.
1758
                        my_config.username())
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1759
1861.4.1 by Matthieu Moy
BZREMAIL renamed to BZR_EMAIL.
1760
    def test_BZR_EMAIL_OVERRIDES(self):
5570.3.9 by Vincent Ladeuil
More use cases for overrideEnv, _cleanEnvironment *may* contain too much variables now.
1761
        self.overrideEnv('BZR_EMAIL', "Robert Collins <robertc@example.org>")
1442.1.6 by Robert Collins
first stage major overhaul of configs, giving use BranchConfigs, LocationConfigs and GlobalConfigs
1762
        branch = FakeBranch()
1763
        my_config = config.BranchConfig(branch)
1764
        self.assertEqual("Robert Collins <robertc@example.org>",
1765
                         my_config.username())
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1766
1442.1.19 by Robert Collins
BranchConfigs inherit signature_checking policy from their LocationConfig.
1767
    def test_signatures_forced(self):
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1768
        my_config = self.get_branch_config(
1769
            global_config=sample_always_signatures)
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1770
        self.assertEqual(config.CHECK_NEVER,
1771
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1772
                my_config.signature_checking))
1773
        self.assertEqual(config.SIGN_ALWAYS,
1774
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1775
                my_config.signing_policy))
1776
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
1777
            my_config.signature_needed))
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1778
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1779
    def test_signatures_forced_branch(self):
1780
        my_config = self.get_branch_config(
1781
            global_config=sample_ignore_signatures,
1782
            branch_data_config=sample_always_signatures)
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1783
        self.assertEqual(config.CHECK_NEVER,
1784
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1785
                my_config.signature_checking))
1786
        self.assertEqual(config.SIGN_ALWAYS,
1787
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1788
                my_config.signing_policy))
1789
        self.assertTrue(self.applyDeprecated(deprecated_in((2, 5, 0)),
1790
            my_config.signature_needed))
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1791
1442.1.56 by Robert Collins
gpg_signing_command configuration item
1792
    def test_gpg_signing_command(self):
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1793
        my_config = self.get_branch_config(
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1794
            global_config=sample_config_text,
1770.2.10 by Aaron Bentley
Added test that branch_config can't influence gpg_signing_command
1795
            # branch data cannot set gpg_signing_command
1796
            branch_data_config="gpg_signing_command=pgp")
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
1797
        self.assertEqual('gnome-gpg',
1798
            self.applyDeprecated(deprecated_in((2, 5, 0)),
1799
                my_config.gpg_signing_command))
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1800
1801
    def test_get_user_option_global(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1802
        my_config = self.get_branch_config(global_config=sample_config_text)
1442.1.69 by Robert Collins
config.Config has a 'get_user_option' call that accepts an option name.
1803
        self.assertEqual('something',
1804
                         my_config.get_user_option('user_global_option'))
1472 by Robert Collins
post commit hook, first pass implementation
1805
1806
    def test_post_commit_default(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1807
        my_config = self.get_branch_config(global_config=sample_config_text,
1808
                                      location='/a/c',
1809
                                      location_config=sample_branches_text)
1770.2.5 by Aaron Bentley
Integrate branch.conf into BranchConfig
1810
        self.assertEqual(my_config.branch.base, '/a/c')
1185.31.25 by John Arbash Meinel
Renamed all of the tests from selftest/foo.py to tests/test_foo.py
1811
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1812
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1813
                                              my_config.post_commit))
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1814
        my_config.set_user_option('post_commit', 'rmtree_root')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1815
        # post-commit is ignored when present in branch data
1770.2.6 by Aaron Bentley
Ensure branch.conf works properly
1816
        self.assertEqual('bzrlib.tests.test_config.post_commit',
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1817
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1818
                                              my_config.post_commit))
2120.6.4 by James Henstridge
add support for specifying policy when storing options
1819
        my_config.set_user_option('post_commit', 'rmtree_root',
1820
                                  store=config.STORE_LOCATION)
6351.3.16 by Vincent Ladeuil
Fix fallouts from deprecating config.post_commit.
1821
        self.assertEqual('rmtree_root',
1822
                         self.applyDeprecated(deprecated_in((2, 5, 0)),
1823
                                              my_config.post_commit))
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1824
1770.2.8 by Aaron Bentley
Add precedence test
1825
    def test_config_precedence(self):
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1826
        # FIXME: eager test, luckily no persitent config file makes it fail
1827
        # -- vila 20100716
1770.2.8 by Aaron Bentley
Add precedence test
1828
        my_config = self.get_branch_config(global_config=precedence_global)
1829
        self.assertEqual(my_config.get_user_option('option'), 'global')
2991.2.2 by Vincent Ladeuil
No tests worth adding after upgrading to configobj-4.4.0.
1830
        my_config = self.get_branch_config(global_config=precedence_global,
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1831
                                           branch_data_config=precedence_branch)
1770.2.8 by Aaron Bentley
Add precedence test
1832
        self.assertEqual(my_config.get_user_option('option'), 'branch')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1833
        my_config = self.get_branch_config(
1834
            global_config=precedence_global,
1835
            branch_data_config=precedence_branch,
1836
            location_config=precedence_location)
1770.2.8 by Aaron Bentley
Add precedence test
1837
        self.assertEqual(my_config.get_user_option('option'), 'recurse')
5345.1.5 by Vincent Ladeuil
Fix fallouts by slightly editing the tests. More refactoring avoided to keep the review light.
1838
        my_config = self.get_branch_config(
1839
            global_config=precedence_global,
1840
            branch_data_config=precedence_branch,
1841
            location_config=precedence_location,
1842
            location='http://example.com/specific')
1770.2.8 by Aaron Bentley
Add precedence test
1843
        self.assertEqual(my_config.get_user_option('option'), 'exact')
1844
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1845
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1846
class TestMailAddressExtraction(tests.TestCase):
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1847
1848
    def test_extract_email_address(self):
1849
        self.assertEqual('jane@test.com',
1850
                         config.extract_email_address('Jane <jane@test.com>'))
2055.2.2 by John Arbash Meinel
Switch extract_email_address() to use a more specific exception
1851
        self.assertRaises(errors.NoEmailInUsername,
1185.33.31 by Martin Pool
Make annotate cope better with revisions committed without a valid
1852
                          config.extract_email_address, 'Jane Tester')
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1853
3063.3.2 by Lukáš Lalinský
Move the name and e-mail address extraction logic to config.parse_username.
1854
    def test_parse_username(self):
1855
        self.assertEqual(('', 'jdoe@example.com'),
1856
                         config.parse_username('jdoe@example.com'))
1857
        self.assertEqual(('', 'jdoe@example.com'),
1858
                         config.parse_username('<jdoe@example.com>'))
1859
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1860
                         config.parse_username('John Doe <jdoe@example.com>'))
1861
        self.assertEqual(('John Doe', ''),
1862
                         config.parse_username('John Doe'))
3063.3.3 by Lukáš Lalinský
Add one more test for config.parse_username().
1863
        self.assertEqual(('John Doe', 'jdoe@example.com'),
1864
                         config.parse_username('John Doe jdoe@example.com'))
2562.1.2 by John Arbash Meinel
Clean up whitespace
1865
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
1866
class TestTreeConfig(tests.TestCaseWithTransport):
2533.1.1 by James Westby
Fix TreeConfig to return values from sections.
1867
1868
    def test_get_value(self):
1869
        """Test that retreiving a value from a section is possible"""
1870
        branch = self.make_branch('.')
1871
        tree_config = config.TreeConfig(branch)
1872
        tree_config.set_option('value', 'key', 'SECTION')
1873
        tree_config.set_option('value2', 'key2')
1874
        tree_config.set_option('value3-top', 'key3')
1875
        tree_config.set_option('value3-section', 'key3', 'SECTION')
1876
        value = tree_config.get_option('key', 'SECTION')
1877
        self.assertEqual(value, 'value')
1878
        value = tree_config.get_option('key2')
1879
        self.assertEqual(value, 'value2')
1880
        self.assertEqual(tree_config.get_option('non-existant'), None)
1881
        value = tree_config.get_option('non-existant', 'SECTION')
1882
        self.assertEqual(value, None)
1883
        value = tree_config.get_option('non-existant', default='default')
1884
        self.assertEqual(value, 'default')
1885
        self.assertEqual(tree_config.get_option('key2', 'NOSECTION'), None)
1886
        value = tree_config.get_option('key2', 'NOSECTION', default='default')
1887
        self.assertEqual(value, 'default')
1888
        value = tree_config.get_option('key3')
1889
        self.assertEqual(value, 'value3-top')
1890
        value = tree_config.get_option('key3', 'SECTION')
1891
        self.assertEqual(value, 'value3-section')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
1892
1893
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1894
class TestTransportConfig(tests.TestCaseWithTransport):
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1895
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1896
    def test_load_utf8(self):
1897
        """Ensure we can load an utf8-encoded file."""
1898
        t = self.get_transport()
1899
        unicode_user = u'b\N{Euro Sign}ar'
1900
        unicode_content = u'user=%s' % (unicode_user,)
1901
        utf8_content = unicode_content.encode('utf8')
1902
        # Store the raw content in the config file
1903
        t.put_bytes('foo.conf', utf8_content)
1904
        conf = config.TransportConfig(t, 'foo.conf')
1905
        self.assertEquals(unicode_user, conf.get_option('user'))
1906
1907
    def test_load_non_ascii(self):
1908
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
1909
        t = self.get_transport()
1910
        t.put_bytes('foo.conf', 'user=foo\n#\xff\n')
1911
        conf = config.TransportConfig(t, 'foo.conf')
1912
        self.assertRaises(errors.ConfigContentError, conf._get_configobj)
1913
1914
    def test_load_erroneous_content(self):
1915
        """Ensure we display a proper error on content that can't be parsed."""
1916
        t = self.get_transport()
1917
        t.put_bytes('foo.conf', '[open_section\n')
1918
        conf = config.TransportConfig(t, 'foo.conf')
1919
        self.assertRaises(errors.ParseConfigError, conf._get_configobj)
1920
6110.5.1 by Jelmer Vernooij
Warn when a configuration file can not be opened.
1921
    def test_load_permission_denied(self):
1922
        """Ensure we get an empty config file if the file is inaccessible."""
1923
        warnings = []
1924
        def warning(*args):
1925
            warnings.append(args[0] % args[1:])
1926
        self.overrideAttr(trace, 'warning', warning)
1927
1928
        class DenyingTransport(object):
1929
1930
            def __init__(self, base):
1931
                self.base = base
1932
1933
            def get_bytes(self, relpath):
1934
                raise errors.PermissionDenied(relpath, "")
1935
1936
        cfg = config.TransportConfig(
1937
            DenyingTransport("nonexisting://"), 'control.conf')
1938
        self.assertIs(None, cfg.get_option('non-existant', 'SECTION'))
1939
        self.assertEquals(
1940
            warnings,
1941
            [u'Permission denied while trying to open configuration file '
1942
             u'nonexisting:///control.conf.'])
1943
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1944
    def test_get_value(self):
1945
        """Test that retreiving a value from a section is possible"""
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
1946
        bzrdir_config = config.TransportConfig(self.get_transport('.'),
3242.1.2 by Aaron Bentley
Turn BzrDirConfig into TransportConfig, reduce code duplication
1947
                                               'control.conf')
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1948
        bzrdir_config.set_option('value', 'key', 'SECTION')
1949
        bzrdir_config.set_option('value2', 'key2')
1950
        bzrdir_config.set_option('value3-top', 'key3')
1951
        bzrdir_config.set_option('value3-section', 'key3', 'SECTION')
1952
        value = bzrdir_config.get_option('key', 'SECTION')
1953
        self.assertEqual(value, 'value')
1954
        value = bzrdir_config.get_option('key2')
1955
        self.assertEqual(value, 'value2')
1956
        self.assertEqual(bzrdir_config.get_option('non-existant'), None)
1957
        value = bzrdir_config.get_option('non-existant', 'SECTION')
1958
        self.assertEqual(value, None)
1959
        value = bzrdir_config.get_option('non-existant', default='default')
1960
        self.assertEqual(value, 'default')
1961
        self.assertEqual(bzrdir_config.get_option('key2', 'NOSECTION'), None)
1962
        value = bzrdir_config.get_option('key2', 'NOSECTION',
1963
                                         default='default')
1964
        self.assertEqual(value, 'default')
1965
        value = bzrdir_config.get_option('key3')
1966
        self.assertEqual(value, 'value3-top')
1967
        value = bzrdir_config.get_option('key3', 'SECTION')
1968
        self.assertEqual(value, 'value3-section')
1969
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1970
    def test_set_unset_default_stack_on(self):
1971
        my_dir = self.make_bzrdir('.')
4288.1.3 by Robert Collins
Fix BzrDirConfig tests.
1972
        bzrdir_config = config.BzrDirConfig(my_dir)
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1973
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1974
        bzrdir_config.set_default_stack_on('Foo')
3242.3.14 by Aaron Bentley
Make BzrDirConfig use TransportConfig
1975
        self.assertEqual('Foo', bzrdir_config._config.get_option(
1976
                         'default_stack_on'))
3242.3.11 by Aaron Bentley
Clean up BzrDirConfig usage
1977
        self.assertEqual('Foo', bzrdir_config.get_default_stack_on())
1978
        bzrdir_config.set_default_stack_on(None)
1979
        self.assertIs(None, bzrdir_config.get_default_stack_on())
1980
3242.1.1 by Aaron Bentley
Implement BzrDir configuration
1981
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
1982
class TestOldConfigHooks(tests.TestCaseWithTransport):
1983
1984
    def setUp(self):
1985
        super(TestOldConfigHooks, self).setUp()
1986
        create_configs_with_file_option(self)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
1987
1988
    def assertGetHook(self, conf, name, value):
1989
        calls = []
1990
        def hook(*args):
1991
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
1992
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
1993
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
1994
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
1995
        self.assertLength(0, calls)
1996
        actual_value = conf.get_user_option(name)
1997
        self.assertEquals(value, actual_value)
1998
        self.assertLength(1, calls)
1999
        self.assertEquals((conf, name, value), calls[0])
2000
2001
    def test_get_hook_bazaar(self):
2002
        self.assertGetHook(self.bazaar_config, 'file', 'bazaar')
2003
2004
    def test_get_hook_locations(self):
2005
        self.assertGetHook(self.locations_config, 'file', 'locations')
2006
2007
    def test_get_hook_branch(self):
2008
        # Since locations masks branch, we define a different option
2009
        self.branch_config.set_user_option('file2', 'branch')
2010
        self.assertGetHook(self.branch_config, 'file2', 'branch')
2011
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2012
    def assertSetHook(self, conf, name, value):
2013
        calls = []
2014
        def hook(*args):
2015
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2016
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2017
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2018
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2019
        self.assertLength(0, calls)
2020
        conf.set_user_option(name, value)
2021
        self.assertLength(1, calls)
2022
        # We can't assert the conf object below as different configs use
2023
        # different means to implement set_user_option and we care only about
2024
        # coverage here.
2025
        self.assertEquals((name, value), calls[0][1:])
2026
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2027
    def test_set_hook_bazaar(self):
2028
        self.assertSetHook(self.bazaar_config, 'foo', 'bazaar')
2029
2030
    def test_set_hook_locations(self):
2031
        self.assertSetHook(self.locations_config, 'foo', 'locations')
2032
2033
    def test_set_hook_branch(self):
2034
        self.assertSetHook(self.branch_config, 'foo', 'branch')
2035
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2036
    def assertRemoveHook(self, conf, name, section_name=None):
2037
        calls = []
2038
        def hook(*args):
2039
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2040
        config.OldConfigHooks.install_named_hook('remove', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2041
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2042
            config.OldConfigHooks.uninstall_named_hook, 'remove', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2043
        self.assertLength(0, calls)
2044
        conf.remove_user_option(name, section_name)
2045
        self.assertLength(1, calls)
2046
        # We can't assert the conf object below as different configs use
2047
        # different means to implement remove_user_option and we care only about
2048
        # coverage here.
2049
        self.assertEquals((name,), calls[0][1:])
2050
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2051
    def test_remove_hook_bazaar(self):
2052
        self.assertRemoveHook(self.bazaar_config, 'file')
2053
2054
    def test_remove_hook_locations(self):
2055
        self.assertRemoveHook(self.locations_config, 'file',
2056
                              self.locations_config.location)
2057
2058
    def test_remove_hook_branch(self):
2059
        self.assertRemoveHook(self.branch_config, 'file')
2060
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2061
    def assertLoadHook(self, name, conf_class, *conf_args):
2062
        calls = []
2063
        def hook(*args):
2064
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2065
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2066
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2067
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2068
        self.assertLength(0, calls)
2069
        # Build a config
2070
        conf = conf_class(*conf_args)
2071
        # Access an option to trigger a load
2072
        conf.get_user_option(name)
2073
        self.assertLength(1, calls)
2074
        # Since we can't assert about conf, we just use the number of calls ;-/
2075
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2076
    def test_load_hook_bazaar(self):
2077
        self.assertLoadHook('file', config.GlobalConfig)
2078
2079
    def test_load_hook_locations(self):
2080
        self.assertLoadHook('file', config.LocationConfig, self.tree.basedir)
2081
2082
    def test_load_hook_branch(self):
2083
        self.assertLoadHook('file', config.BranchConfig, self.tree.branch)
2084
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2085
    def assertSaveHook(self, conf):
2086
        calls = []
2087
        def hook(*args):
2088
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2089
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.23 by Vincent Ladeuil
Don't publicize the hooks yet and add proper cleanups to avoid hook leaks (or hooks triggering during tests cleanup).
2090
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2091
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.19 by Vincent Ladeuil
Revert the mixin addition, no way to share with remote configs which implements a different API.
2092
        self.assertLength(0, calls)
2093
        # Setting an option triggers a save
2094
        conf.set_user_option('foo', 'bar')
2095
        self.assertLength(1, calls)
2096
        # Since we can't assert about conf, we just use the number of calls ;-/
2097
5743.8.15 by Vincent Ladeuil
Add tests for old config hooks covering bazaar.conf, locations.conf and branch.conf.
2098
    def test_save_hook_bazaar(self):
2099
        self.assertSaveHook(self.bazaar_config)
2100
2101
    def test_save_hook_locations(self):
2102
        self.assertSaveHook(self.locations_config)
2103
2104
    def test_save_hook_branch(self):
2105
        self.assertSaveHook(self.branch_config)
2106
2107
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2108
class TestOldConfigHooksForRemote(tests.TestCaseWithTransport):
2109
    """Tests config hooks for remote configs.
2110
2111
    No tests for the remove hook as this is not implemented there.
2112
    """
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2113
2114
    def setUp(self):
2115
        super(TestOldConfigHooksForRemote, self).setUp()
2116
        self.transport_server = test_server.SmartTCPServer_for_testing
2117
        create_configs_with_file_option(self)
2118
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2119
    def assertGetHook(self, conf, name, value):
2120
        calls = []
2121
        def hook(*args):
2122
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2123
        config.OldConfigHooks.install_named_hook('get', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2124
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2125
            config.OldConfigHooks.uninstall_named_hook, 'get', None)
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2126
        self.assertLength(0, calls)
2127
        actual_value = conf.get_option(name)
2128
        self.assertEquals(value, actual_value)
2129
        self.assertLength(1, calls)
2130
        self.assertEquals((conf, name, value), calls[0])
2131
2132
    def test_get_hook_remote_branch(self):
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2133
        remote_branch = branch.Branch.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2134
        self.assertGetHook(remote_branch._get_config(), 'file', 'branch')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2135
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2136
    def test_get_hook_remote_bzrdir(self):
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2137
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.18 by Vincent Ladeuil
Add a test for remote bzr dir.
2138
        conf = remote_bzrdir._get_config()
2139
        conf.set_option('remotedir', 'file')
2140
        self.assertGetHook(conf, 'file', 'remotedir')
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2141
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2142
    def assertSetHook(self, conf, name, value):
2143
        calls = []
2144
        def hook(*args):
2145
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2146
        config.OldConfigHooks.install_named_hook('set', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2147
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2148
            config.OldConfigHooks.uninstall_named_hook, 'set', None)
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2149
        self.assertLength(0, calls)
2150
        conf.set_option(value, name)
2151
        self.assertLength(1, calls)
2152
        # We can't assert the conf object below as different configs use
2153
        # different means to implement set_user_option and we care only about
2154
        # coverage here.
2155
        self.assertEquals((name, value), calls[0][1:])
2156
2157
    def test_set_hook_remote_branch(self):
2158
        remote_branch = branch.Branch.open(self.get_url('tree'))
2159
        self.addCleanup(remote_branch.lock_write().unlock)
2160
        self.assertSetHook(remote_branch._get_config(), 'file', 'remote')
2161
2162
    def test_set_hook_remote_bzrdir(self):
2163
        remote_branch = branch.Branch.open(self.get_url('tree'))
2164
        self.addCleanup(remote_branch.lock_write().unlock)
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2165
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.20 by Vincent Ladeuil
Add tests for set hook.
2166
        self.assertSetHook(remote_bzrdir._get_config(), 'file', 'remotedir')
2167
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2168
    def assertLoadHook(self, expected_nb_calls, name, conf_class, *conf_args):
2169
        calls = []
2170
        def hook(*args):
2171
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2172
        config.OldConfigHooks.install_named_hook('load', hook, None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2173
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2174
            config.OldConfigHooks.uninstall_named_hook, 'load', None)
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2175
        self.assertLength(0, calls)
2176
        # Build a config
2177
        conf = conf_class(*conf_args)
2178
        # Access an option to trigger a load
2179
        conf.get_option(name)
2180
        self.assertLength(expected_nb_calls, calls)
2181
        # Since we can't assert about conf, we just use the number of calls ;-/
2182
2183
    def test_load_hook_remote_branch(self):
2184
        remote_branch = branch.Branch.open(self.get_url('tree'))
2185
        self.assertLoadHook(1, 'file', remote.RemoteBranchConfig, remote_branch)
2186
2187
    def test_load_hook_remote_bzrdir(self):
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2188
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.21 by Vincent Ladeuil
Add test for config load hook for remote configs.
2189
        # The config file doesn't exist, set an option to force its creation
2190
        conf = remote_bzrdir._get_config()
2191
        conf.set_option('remotedir', 'file')
2192
        # We get one call for the server and one call for the client, this is
2193
        # caused by the differences in implementations betwen
2194
        # SmartServerBzrDirRequestConfigFile (in smart/bzrdir.py) and
2195
        # SmartServerBranchGetConfigFile (in smart/branch.py)
2196
        self.assertLoadHook(2 ,'file', remote.RemoteBzrDirConfig, remote_bzrdir)
2197
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2198
    def assertSaveHook(self, conf):
2199
        calls = []
2200
        def hook(*args):
2201
            calls.append(args)
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2202
        config.OldConfigHooks.install_named_hook('save', hook, None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2203
        self.addCleanup(
5743.8.24 by Vincent Ladeuil
Clearly seaparate both sets of hooks for the old and new config implementations.
2204
            config.OldConfigHooks.uninstall_named_hook, 'save', None)
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2205
        self.assertLength(0, calls)
2206
        # Setting an option triggers a save
2207
        conf.set_option('foo', 'bar')
2208
        self.assertLength(1, calls)
2209
        # Since we can't assert about conf, we just use the number of calls ;-/
2210
2211
    def test_save_hook_remote_branch(self):
2212
        remote_branch = branch.Branch.open(self.get_url('tree'))
2213
        self.addCleanup(remote_branch.lock_write().unlock)
2214
        self.assertSaveHook(remote_branch._get_config())
2215
2216
    def test_save_hook_remote_bzrdir(self):
2217
        remote_branch = branch.Branch.open(self.get_url('tree'))
2218
        self.addCleanup(remote_branch.lock_write().unlock)
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
2219
        remote_bzrdir = controldir.ControlDir.open(self.get_url('tree'))
5743.8.22 by Vincent Ladeuil
Add tests for config save hook for remote configs.
2220
        self.assertSaveHook(remote_bzrdir._get_config())
2221
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
2222
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2223
class TestOption(tests.TestCase):
2224
2225
    def test_default_value(self):
2226
        opt = config.Option('foo', default='bar')
2227
        self.assertEquals('bar', opt.get_default())
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2228
6349.3.1 by Vincent Ladeuil
Allow config option default value to be a python callable
2229
    def test_callable_default_value(self):
2230
        def bar_as_unicode():
2231
            return u'bar'
2232
        opt = config.Option('foo', default=bar_as_unicode)
2233
        self.assertEquals('bar', opt.get_default())
2234
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2235
    def test_default_value_from_env(self):
2236
        opt = config.Option('foo', default='bar', default_from_env=['FOO'])
2237
        self.overrideEnv('FOO', 'quux')
2238
        # Env variable provides a default taking over the option one
2239
        self.assertEquals('quux', opt.get_default())
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2240
6082.2.1 by Vincent Ladeuil
Implement default values from environment for config options
2241
    def test_first_default_value_from_env_wins(self):
2242
        opt = config.Option('foo', default='bar',
2243
                            default_from_env=['NO_VALUE', 'FOO', 'BAZ'])
2244
        self.overrideEnv('FOO', 'foo')
2245
        self.overrideEnv('BAZ', 'baz')
2246
        # The first env var set wins
2247
        self.assertEquals('foo', opt.get_default())
2248
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
2249
    def test_not_supported_list_default_value(self):
2250
        self.assertRaises(AssertionError, config.Option, 'foo', default=[1])
2251
2252
    def test_not_supported_object_default_value(self):
2253
        self.assertRaises(AssertionError, config.Option, 'foo',
2254
                          default=object())
2255
6349.3.1 by Vincent Ladeuil
Allow config option default value to be a python callable
2256
    def test_not_supported_callable_default_value_not_unicode(self):
2257
        def bar_not_unicode():
2258
            return 'bar'
2259
        opt = config.Option('foo', default=bar_not_unicode)
2260
        self.assertRaises(AssertionError, opt.get_default)
2261
6437.42.1 by Jelmer Vernooij
Make sure help options can provide their own help topic.
2262
    def test_get_help_topic(self):
2263
        opt = config.Option('foo')
2264
        self.assertEquals('foo', opt.get_help_topic())
2265
5743.12.4 by Vincent Ladeuil
An option can provide a default value.
2266
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2267
class TestOptionConverterMixin(object):
2268
2269
    def assertConverted(self, expected, opt, value):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2270
        self.assertEquals(expected, opt.convert_from_unicode(None, value))
2271
2272
    def assertWarns(self, opt, value):
2273
        warnings = []
2274
        def warning(*args):
2275
            warnings.append(args[0] % args[1:])
2276
        self.overrideAttr(trace, 'warning', warning)
2277
        self.assertEquals(None, opt.convert_from_unicode(None, value))
2278
        self.assertLength(1, warnings)
2279
        self.assertEquals(
2280
            'Value "%s" is not valid for "%s"' % (value, opt.name),
2281
            warnings[0])
2282
2283
    def assertErrors(self, opt, value):
2284
        self.assertRaises(errors.ConfigOptionValueError,
2285
                          opt.convert_from_unicode, None, value)
2286
2287
    def assertConvertInvalid(self, opt, invalid_value):
2288
        opt.invalid = None
2289
        self.assertEquals(None, opt.convert_from_unicode(None, invalid_value))
2290
        opt.invalid = 'warning'
2291
        self.assertWarns(opt, invalid_value)
2292
        opt.invalid = 'error'
2293
        self.assertErrors(opt, invalid_value)
2294
2295
2296
class TestOptionWithBooleanConverter(tests.TestCase, TestOptionConverterMixin):
2297
2298
    def get_option(self):
2299
        return config.Option('foo', help='A boolean.',
2300
                             from_unicode=config.bool_from_store)
2301
2302
    def test_convert_invalid(self):
2303
        opt = self.get_option()
2304
        # A string that is not recognized as a boolean
2305
        self.assertConvertInvalid(opt, u'invalid-boolean')
2306
        # A list of strings is never recognized as a boolean
2307
        self.assertConvertInvalid(opt, [u'not', u'a', u'boolean'])
2308
2309
    def test_convert_valid(self):
2310
        opt = self.get_option()
2311
        self.assertConverted(True, opt, u'True')
2312
        self.assertConverted(True, opt, u'1')
2313
        self.assertConverted(False, opt, u'False')
2314
2315
2316
class TestOptionWithIntegerConverter(tests.TestCase, TestOptionConverterMixin):
2317
2318
    def get_option(self):
2319
        return config.Option('foo', help='An integer.',
2320
                             from_unicode=config.int_from_store)
2321
2322
    def test_convert_invalid(self):
2323
        opt = self.get_option()
2324
        # A string that is not recognized as an integer
2325
        self.assertConvertInvalid(opt, u'forty-two')
2326
        # A list of strings is never recognized as an integer
2327
        self.assertConvertInvalid(opt, [u'a', u'list'])
2328
2329
    def test_convert_valid(self):
2330
        opt = self.get_option()
2331
        self.assertConverted(16, opt, u'16')
2332
2333
6378.1.1 by Vincent Ladeuil
Add int_SI_from_store as a config option helper
2334
class TestOptionWithSIUnitConverter(tests.TestCase, TestOptionConverterMixin):
2335
2336
    def get_option(self):
2337
        return config.Option('foo', help='An integer in SI units.',
2338
                             from_unicode=config.int_SI_from_store)
2339
2340
    def test_convert_invalid(self):
2341
        opt = self.get_option()
2342
        self.assertConvertInvalid(opt, u'not-a-unit')
2343
        self.assertConvertInvalid(opt, u'Gb') # Forgot the int
2344
        self.assertConvertInvalid(opt, u'1b') # Forgot the unit
2345
        self.assertConvertInvalid(opt, u'1GG')
2346
        self.assertConvertInvalid(opt, u'1Mbb')
2347
        self.assertConvertInvalid(opt, u'1MM')
2348
2349
    def test_convert_valid(self):
2350
        opt = self.get_option()
2351
        self.assertConverted(int(5e3), opt, u'5kb')
2352
        self.assertConverted(int(5e6), opt, u'5M')
2353
        self.assertConverted(int(5e6), opt, u'5MB')
2354
        self.assertConverted(int(5e9), opt, u'5g')
2355
        self.assertConverted(int(5e9), opt, u'5gB')
2356
        self.assertConverted(100, opt, u'100')
2357
2358
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2359
class TestListOption(tests.TestCase, TestOptionConverterMixin):
2360
2361
    def get_option(self):
2362
        return config.ListOption('foo', help='A list.')
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2363
2364
    def test_convert_invalid(self):
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
2365
        opt = self.get_option()
2366
        # We don't even try to convert a list into a list, we only expect
2367
        # strings
2368
        self.assertConvertInvalid(opt, [1])
6091.3.1 by Vincent Ladeuil
Add convert_from_unicode to Option and rewrite the tests to need only an
2369
        # No string is invalid as all forms can be converted to a list
2370
2371
    def test_convert_valid(self):
2372
        opt = self.get_option()
2373
        # An empty string is an empty list
2374
        self.assertConverted([], opt, '') # Using a bare str() just in case
2375
        self.assertConverted([], opt, u'')
2376
        # A boolean
2377
        self.assertConverted([u'True'], opt, u'True')
2378
        # An integer
2379
        self.assertConverted([u'42'], opt, u'42')
2380
        # A single string
2381
        self.assertConverted([u'bar'], opt, u'bar')
2382
2383
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2384
class TestRegistryOption(tests.TestCase, TestOptionConverterMixin):
2385
2386
    def get_option(self, registry):
2387
        return config.RegistryOption('foo', registry,
2388
                help='A registry option.')
2389
2390
    def test_convert_invalid(self):
2391
        registry = _mod_registry.Registry()
2392
        opt = self.get_option(registry)
2393
        self.assertConvertInvalid(opt, [1])
2394
        self.assertConvertInvalid(opt, u"notregistered")
2395
2396
    def test_convert_valid(self):
2397
        registry = _mod_registry.Registry()
2398
        registry.register("someval", 1234)
2399
        opt = self.get_option(registry)
2400
        # Using a bare str() just in case
2401
        self.assertConverted(1234, opt, "someval")
2402
        self.assertConverted(1234, opt, u'someval')
2403
        self.assertConverted(None, opt, None)
2404
2405
    def test_help(self):
2406
        registry = _mod_registry.Registry()
2407
        registry.register("someval", 1234, help="some option")
2408
        registry.register("dunno", 1234, help="some other option")
2409
        opt = self.get_option(registry)
2410
        self.assertEquals(
2411
            'A registry option.\n'
2412
            '\n'
2413
            'The following values are supported:\n'
2414
            ' dunno - some other option\n'
2415
            ' someval - some option\n',
6449.2.2 by Jelmer Vernooij
Moar tests.
2416
            opt.help)
2417
2418
    def test_get_help_text(self):
2419
        registry = _mod_registry.Registry()
2420
        registry.register("someval", 1234, help="some option")
2421
        registry.register("dunno", 1234, help="some other option")
2422
        opt = self.get_option(registry)
2423
        self.assertEquals(
2424
            'A registry option.\n'
2425
            '\n'
2426
            'The following values are supported:\n'
2427
            ' dunno - some other option\n'
2428
            ' someval - some option\n',
2429
            opt.get_help_text())
6449.2.1 by Jelmer Vernooij
Add bzrlib.config.RegistryOption.
2430
2431
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2432
class TestOptionRegistry(tests.TestCase):
5743.12.5 by Vincent Ladeuil
Remove spurious spaces.
2433
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2434
    def setUp(self):
2435
        super(TestOptionRegistry, self).setUp()
2436
        # Always start with an empty registry
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2437
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2438
        self.registry = config.option_registry
2439
2440
    def test_register(self):
2441
        opt = config.Option('foo')
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2442
        self.registry.register(opt)
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2443
        self.assertIs(opt, self.registry.get('foo'))
2444
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2445
    def test_registered_help(self):
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2446
        opt = config.Option('foo', help='A simple option')
2447
        self.registry.register(opt)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2448
        self.assertEquals('A simple option', self.registry.get_help('foo'))
2449
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
2450
    lazy_option = config.Option('lazy_foo', help='Lazy help')
2451
2452
    def test_register_lazy(self):
2453
        self.registry.register_lazy('lazy_foo', self.__module__,
2454
                                    'TestOptionRegistry.lazy_option')
2455
        self.assertIs(self.lazy_option, self.registry.get('lazy_foo'))
2456
2457
    def test_registered_lazy_help(self):
2458
        self.registry.register_lazy('lazy_foo', self.__module__,
2459
                                    'TestOptionRegistry.lazy_option')
2460
        self.assertEquals('Lazy help', self.registry.get_help('lazy_foo'))
2461
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2462
2463
class TestRegisteredOptions(tests.TestCase):
2464
    """All registered options should verify some constraints."""
2465
2466
    scenarios = [(key, {'option_name': key, 'option': option}) for key, option
2467
                 in config.option_registry.iteritems()]
2468
2469
    def setUp(self):
2470
        super(TestRegisteredOptions, self).setUp()
2471
        self.registry = config.option_registry
2472
2473
    def test_proper_name(self):
2474
        # An option should be registered under its own name, this can't be
2475
        # checked at registration time for the lazy ones.
2476
        self.assertEquals(self.option_name, self.option.name)
2477
2478
    def test_help_is_set(self):
2479
        option_help = self.registry.get_help(self.option_name)
2480
        self.assertNotEquals(None, option_help)
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2481
        # Come on, think about the user, he really wants to know what the
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2482
        # option is about
6056.2.5 by Vincent Ladeuil
Fix typos caught by jelmer.
2483
        self.assertIsNot(None, option_help)
5743.12.3 by Vincent Ladeuil
More basic tests for options. Start tests for all registered options.
2484
        self.assertNotEquals('', option_help)
2485
5743.12.2 by Vincent Ladeuil
Basic registry for options.
2486
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2487
class TestSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2488
2489
    # FIXME: Parametrize so that all sections produced by Stores run these
5743.3.1 by Vincent Ladeuil
Add a docstring and dates to FIXMEs.
2490
    # tests -- vila 2011-04-01
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2491
2492
    def test_get_a_value(self):
2493
        a_dict = dict(foo='bar')
5743.3.11 by Vincent Ladeuil
Config sections only implement read access.
2494
        section = config.Section('myID', a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2495
        self.assertEquals('bar', section.get('foo'))
2496
5743.3.10 by Vincent Ladeuil
Fix typos mentioned in reviews.
2497
    def test_get_unknown_option(self):
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2498
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2499
        section = config.Section(None, a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2500
        self.assertEquals('out of thin air',
2501
                          section.get('foo', 'out of thin air'))
2502
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2503
    def test_options_is_shared(self):
2504
        a_dict = dict()
5743.5.13 by Vincent Ladeuil
Merge config-abstract-store into config-concrete-stores resolving conflicts
2505
        section = config.Section(None, a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2506
        self.assertIs(a_dict, section.options)
2507
2508
5743.3.12 by Vincent Ladeuil
Add an ad-hoc __repr__.
2509
class TestMutableSection(tests.TestCase):
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2510
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2511
    scenarios = [('mutable',
2512
                  {'get_section':
2513
                       lambda opts: config.MutableSection('myID', opts)},),
2514
        ]
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2515
2516
    def test_set(self):
2517
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2518
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2519
        section.set('foo', 'new_value')
2520
        self.assertEquals('new_value', section.get('foo'))
2521
        # The change appears in the shared section
2522
        self.assertEquals('new_value', a_dict.get('foo'))
2523
        # We keep track of the change
2524
        self.assertTrue('foo' in section.orig)
2525
        self.assertEquals('bar', section.orig.get('foo'))
2526
2527
    def test_set_preserve_original_once(self):
2528
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2529
        section = self.get_section(a_dict)
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2530
        section.set('foo', 'first_value')
2531
        section.set('foo', 'second_value')
2532
        # We keep track of the original value
2533
        self.assertTrue('foo' in section.orig)
2534
        self.assertEquals('bar', section.orig.get('foo'))
2535
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2536
    def test_remove(self):
2537
        a_dict = dict(foo='bar')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2538
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2539
        section.remove('foo')
2540
        # We get None for unknown options via the default value
2541
        self.assertEquals(None, section.get('foo'))
2542
        # Or we just get the default value
2543
        self.assertEquals('unknown', section.get('foo', 'unknown'))
2544
        self.assertFalse('foo' in section.options)
2545
        # We keep track of the deletion
2546
        self.assertTrue('foo' in section.orig)
2547
        self.assertEquals('bar', section.orig.get('foo'))
2548
2549
    def test_remove_new_option(self):
2550
        a_dict = dict()
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2551
        section = self.get_section(a_dict)
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2552
        section.set('foo', 'bar')
2553
        section.remove('foo')
2554
        self.assertFalse('foo' in section.options)
2555
        # The option didn't exist initially so it we need to keep track of it
2556
        # with a special value
2557
        self.assertTrue('foo' in section.orig)
5743.3.6 by Vincent Ladeuil
Use a name less likely to be reused.
2558
        self.assertEquals(config._NewlyCreatedOption, section.orig['foo'])
5743.2.2 by Vincent Ladeuil
Add tests for remove.
2559
5743.2.1 by Vincent Ladeuil
Basic tests and implementations for read-only and mutable sections.
2560
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2561
class TestCommandLineStore(tests.TestCase):
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2562
2563
    def setUp(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2564
        super(TestCommandLineStore, self).setUp()
2565
        self.store = config.CommandLineStore()
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2566
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2567
2568
    def get_section(self):
2569
        """Get the unique section for the command line overrides."""
2570
        sections = list(self.store.get_sections())
2571
        self.assertLength(1, sections)
2572
        store, section = sections[0]
2573
        self.assertEquals(self.store, store)
2574
        return section
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2575
2576
    def test_no_override(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2577
        self.store._from_cmdline([])
2578
        section = self.get_section()
2579
        self.assertLength(0, list(section.iter_option_names()))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2580
2581
    def test_simple_override(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2582
        self.store._from_cmdline(['a=b'])
2583
        section = self.get_section()
2584
        self.assertEqual('b', section.get('a'))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2585
2586
    def test_list_override(self):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2587
        opt = config.ListOption('l')
2588
        config.option_registry.register(opt)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2589
        self.store._from_cmdline(['l=1,2,3'])
2590
        val = self.get_section().get('l')
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2591
        self.assertEqual('1,2,3', val)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2592
        # Reminder: lists should be registered as such explicitely, otherwise
2593
        # the conversion needs to be done afterwards.
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
2594
        self.assertEqual(['1', '2', '3'],
2595
                         opt.convert_from_unicode(self.store, val))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2596
2597
    def test_multiple_overrides(self):
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2598
        self.store._from_cmdline(['a=b', 'x=y'])
2599
        section = self.get_section()
2600
        self.assertEquals('b', section.get('a'))
2601
        self.assertEquals('y', section.get('x'))
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2602
2603
    def test_wrong_syntax(self):
2604
        self.assertRaises(errors.BzrCommandError,
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2605
                          self.store._from_cmdline, ['a=b', 'c'])
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2606
6404.4.1 by Vincent Ladeuil
Properly support config.CommandLineStore in ``bzr config``
2607
class TestStoreMinimalAPI(tests.TestCaseWithTransport):
2608
2609
    scenarios = [(key, {'get_store': builder}) for key, builder
2610
                 in config.test_store_builder_registry.iteritems()] + [
2611
        ('cmdline', {'get_store': lambda test: config.CommandLineStore()})]
2612
2613
    def test_id(self):
2614
        store = self.get_store(self)
2615
        if type(store) == config.TransportIniFileStore:
6404.4.2 by Vincent Ladeuil
test_id is not applicable (which is why is it skipped) to TransportIniFileStore.
2616
            raise tests.TestNotApplicable(
6404.4.1 by Vincent Ladeuil
Properly support config.CommandLineStore in ``bzr config``
2617
                "%s is not a concrete Store implementation"
2618
                " so it doesn't need an id" % (store.__class__.__name__,))
2619
        self.assertIsNot(None, store.id)
2620
6161.1.1 by Vincent Ladeuil
Allow config options to be overridden from the command line
2621
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2622
class TestStore(tests.TestCaseWithTransport):
2623
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
2624
    def assertSectionContent(self, expected, (store, section)):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2625
        """Assert that some options have the proper values in a section."""
2626
        expected_name, expected_options = expected
2627
        self.assertEquals(expected_name, section.id)
2628
        self.assertEquals(
2629
            expected_options,
2630
            dict([(k, section.get(k)) for k in expected_options.keys()]))
2631
2632
2633
class TestReadonlyStore(TestStore):
2634
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2635
    scenarios = [(key, {'get_store': builder}) for key, builder
2636
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2637
2638
    def test_building_delays_load(self):
2639
        store = self.get_store(self)
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2640
        self.assertEquals(False, store.is_loaded())
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2641
        store._load_from_string('')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
2642
        self.assertEquals(True, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
2643
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2644
    def test_get_no_sections_for_empty(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2645
        store = self.get_store(self)
2646
        store._load_from_string('')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2647
        self.assertEquals([], list(store.get_sections()))
2648
2649
    def test_get_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2650
        store = self.get_store(self)
2651
        store._load_from_string('foo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2652
        sections = list(store.get_sections())
2653
        self.assertLength(1, sections)
2654
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2655
2656
    def test_get_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2657
        store = self.get_store(self)
2658
        store._load_from_string('[baz]\nfoo=bar')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2659
        sections = list(store.get_sections())
2660
        self.assertLength(1, sections)
2661
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2662
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2663
    def test_load_from_string_fails_for_non_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2664
        store = self.get_store(self)
2665
        store._load_from_string('foo=bar')
5743.4.21 by Vincent Ladeuil
All stores should provide _load_from_string to reuse the existing tests.
2666
        self.assertRaises(AssertionError, store._load_from_string, 'bar=baz')
2667
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2668
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2669
class TestStoreQuoting(TestStore):
2670
2671
    scenarios = [(key, {'get_store': builder}) for key, builder
2672
                 in config.test_store_builder_registry.iteritems()]
2673
2674
    def setUp(self):
2675
        super(TestStoreQuoting, self).setUp()
2676
        self.store = self.get_store(self)
2677
        # We need a loaded store but any content will do
2678
        self.store._load_from_string('')
2679
2680
    def assertIdempotent(self, s):
2681
        """Assert that quoting an unquoted string is a no-op and vice-versa.
2682
2683
        What matters here is that option values, as they appear in a store, can
2684
        be safely round-tripped out of the store and back.
2685
2686
        :param s: A string, quoted if required.
2687
        """
2688
        self.assertEquals(s, self.store.quote(self.store.unquote(s)))
2689
        self.assertEquals(s, self.store.unquote(self.store.quote(s)))
2690
2691
    def test_empty_string(self):
2692
        if isinstance(self.store, config.IniFileStore):
2693
            # configobj._quote doesn't handle empty values
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2694
            self.assertRaises(AssertionError,
2695
                              self.assertIdempotent, '')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2696
        else:
2697
            self.assertIdempotent('')
2698
        # But quoted empty strings are ok
2699
        self.assertIdempotent('""')
2700
2701
    def test_embedded_spaces(self):
2702
        self.assertIdempotent('" a b c "')
2703
2704
    def test_embedded_commas(self):
2705
        self.assertIdempotent('" a , b c "')
2706
2707
    def test_simple_comma(self):
2708
        if isinstance(self.store, config.IniFileStore):
2709
            # configobj requires that lists are special-cased
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2710
           self.assertRaises(AssertionError,
2711
                             self.assertIdempotent, ',')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2712
        else:
2713
            self.assertIdempotent(',')
2714
        # When a single comma is required, quoting is also required
2715
        self.assertIdempotent('","')
2716
2717
    def test_list(self):
2718
        if isinstance(self.store, config.IniFileStore):
2719
            # configobj requires that lists are special-cased
6385.1.4 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
2720
            self.assertRaises(AssertionError,
2721
                              self.assertIdempotent, 'a,b')
6385.1.2 by Vincent Ladeuil
Add tests for Store quoting/unquoting
2722
        else:
2723
            self.assertIdempotent('a,b')
2724
2725
6404.3.1 by Vincent Ladeuil
Robustly unquote configuration values (workaround configobj presenting a section as a dict in weird edge cases)
2726
class TestDictFromStore(tests.TestCase):
2727
2728
    def test_unquote_not_string(self):
2729
        conf = config.MemoryStack('x=2\n[a_section]\na=1\n')
2730
        value = conf.get('a_section')
2731
        # Urgh, despite 'conf' asking for the no-name section, we get the
2732
        # content of another section as a dict o_O
2733
        self.assertEquals({'a': '1'}, value)
2734
        unquoted = conf.store.unquote(value)
2735
        # Which cannot be unquoted but shouldn't crash either (the use cases
2736
        # are getting the value or displaying it. In the later case, '%s' will
2737
        # do).
2738
        self.assertEquals({'a': '1'}, unquoted)
2739
        self.assertEquals("{u'a': u'1'}", '%s' % (unquoted,))
2740
2741
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2742
class TestIniFileStoreContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2743
    """Simulate loading a config store with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2744
2745
    All files produced by bzr are in utf8 content.
2746
2747
    Users may modify them manually and end up with a file that can't be
2748
    loaded. We need to issue proper error messages in this case.
2749
    """
2750
2751
    invalid_utf8_char = '\xff'
2752
2753
    def test_load_utf8(self):
2754
        """Ensure we can load an utf8-encoded file."""
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2755
        t = self.get_transport()
2756
        # From http://pad.lv/799212
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2757
        unicode_user = u'b\N{Euro Sign}ar'
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2758
        unicode_content = u'user=%s' % (unicode_user,)
2759
        utf8_content = unicode_content.encode('utf8')
2760
        # Store the raw content in the config file
2761
        t.put_bytes('foo.conf', utf8_content)
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2762
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2763
        store.load()
2764
        stack = config.Stack([store.get_sections], store)
2765
        self.assertEquals(unicode_user, stack.get('user'))
2766
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2767
    def test_load_non_ascii(self):
2768
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2769
        t = self.get_transport()
2770
        t.put_bytes('foo.conf', 'user=foo\n#%s\n' % (self.invalid_utf8_char,))
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2771
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2772
        self.assertRaises(errors.ConfigContentError, store.load)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2773
2774
    def test_load_erroneous_content(self):
2775
        """Ensure we display a proper error on content that can't be parsed."""
2776
        t = self.get_transport()
2777
        t.put_bytes('foo.conf', '[open_section\n')
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2778
        store = config.TransportIniFileStore(t, 'foo.conf')
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2779
        self.assertRaises(errors.ParseConfigError, store.load)
2780
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2781
    def test_load_permission_denied(self):
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2782
        """Ensure we get warned when trying to load an inaccessible file."""
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2783
        warnings = []
2784
        def warning(*args):
2785
            warnings.append(args[0] % args[1:])
2786
        self.overrideAttr(trace, 'warning', warning)
2787
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2788
        t = self.get_transport()
2789
2790
        def get_bytes(relpath):
2791
            raise errors.PermissionDenied(relpath, "")
2792
        t.get_bytes = get_bytes
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
2793
        store = config.TransportIniFileStore(t, 'foo.conf')
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2794
        self.assertRaises(errors.PermissionDenied, store.load)
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2795
        self.assertEquals(
2796
            warnings,
6110.5.5 by Vincent Ladeuil
Warn when loading, fail if saving will occur later
2797
            [u'Permission denied while trying to load configuration store %s.'
2798
             % store.external_url()])
6110.5.3 by Jelmer Vernooij
Add test for IniFileStore.
2799
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2800
2801
class TestIniConfigContent(tests.TestCaseWithTransport):
6082.5.13 by Vincent Ladeuil
Fix typos.
2802
    """Simulate loading a IniBasedConfig with content of various encodings.
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2803
2804
    All files produced by bzr are in utf8 content.
2805
2806
    Users may modify them manually and end up with a file that can't be
2807
    loaded. We need to issue proper error messages in this case.
2808
    """
2809
2810
    invalid_utf8_char = '\xff'
2811
2812
    def test_load_utf8(self):
2813
        """Ensure we can load an utf8-encoded file."""
2814
        # From http://pad.lv/799212
2815
        unicode_user = u'b\N{Euro Sign}ar'
2816
        unicode_content = u'user=%s' % (unicode_user,)
2817
        utf8_content = unicode_content.encode('utf8')
2818
        # Store the raw content in the config file
2819
        with open('foo.conf', 'wb') as f:
2820
            f.write(utf8_content)
2821
        conf = config.IniBasedConfig(file_name='foo.conf')
2822
        self.assertEquals(unicode_user, conf.get_user_option('user'))
2823
2824
    def test_load_badly_encoded_content(self):
2825
        """Ensure we display a proper error on non-ascii, non utf-8 content."""
2826
        with open('foo.conf', 'wb') as f:
2827
            f.write('user=foo\n#%s\n' % (self.invalid_utf8_char,))
2828
        conf = config.IniBasedConfig(file_name='foo.conf')
5987.1.4 by Vincent Ladeuil
Proper error messages for config files with content in non-utf encoding or that cannot be parsed
2829
        self.assertRaises(errors.ConfigContentError, conf._get_parser)
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
2830
2831
    def test_load_erroneous_content(self):
2832
        """Ensure we display a proper error on content that can't be parsed."""
2833
        with open('foo.conf', 'wb') as f:
2834
            f.write('[open_section\n')
2835
        conf = config.IniBasedConfig(file_name='foo.conf')
2836
        self.assertRaises(errors.ParseConfigError, conf._get_parser)
2837
5987.1.1 by Vincent Ladeuil
Properly load utf8-encoded config files
2838
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2839
class TestMutableStore(TestStore):
2840
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
2841
    scenarios = [(key, {'store_id': key, 'get_store': builder}) for key, builder
2842
                 in config.test_store_builder_registry.iteritems()]
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2843
2844
    def setUp(self):
2845
        super(TestMutableStore, self).setUp()
2846
        self.transport = self.get_transport()
2847
2848
    def has_store(self, store):
2849
        store_basename = urlutils.relative_url(self.transport.external_url(),
2850
                                               store.external_url())
2851
        return self.transport.has(store_basename)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2852
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2853
    def test_save_empty_creates_no_file(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2854
        # FIXME: There should be a better way than relying on the test
2855
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2856
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2857
            raise tests.TestNotApplicable(
2858
                'branch.conf is *always* created when a branch is initialized')
2859
        store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2860
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2861
        self.assertEquals(False, self.has_store(store))
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2862
6499.2.1 by Vincent Ladeuil
Save branch config options only during the final unlock
2863
    def test_mutable_section_shared(self):
2864
        store = self.get_store(self)
2865
        store._load_from_string('foo=bar\n')
2866
        # FIXME: There should be a better way than relying on the test
2867
        # parametrization to identify branch.conf -- vila 2011-0526
2868
        if self.store_id in ('branch', 'remote_branch'):
2869
            # branch stores requires write locked branches
2870
            self.addCleanup(store.branch.lock_write().unlock)
2871
        section1 = store.get_mutable_section(None)
2872
        section2 = store.get_mutable_section(None)
2873
        # If we get different sections, different callers won't share the
2874
        # modification
2875
        self.assertIs(section1, section2)
2876
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2877
    def test_save_emptied_succeeds(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2878
        store = self.get_store(self)
2879
        store._load_from_string('foo=bar\n')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2880
        # FIXME: There should be a better way than relying on the test
2881
        # parametrization to identify branch.conf -- vila 2011-0526
2882
        if self.store_id in ('branch', 'remote_branch'):
2883
            # branch stores requires write locked branches
2884
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2885
        section = store.get_mutable_section(None)
2886
        section.remove('foo')
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2887
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2888
        self.assertEquals(True, self.has_store(store))
2889
        modified_store = self.get_store(self)
5743.4.19 by Vincent Ladeuil
Clarify that only Store.get_mutable_section() can accept an empty file.
2890
        sections = list(modified_store.get_sections())
2891
        self.assertLength(0, sections)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2892
2893
    def test_save_with_content_succeeds(self):
5743.10.4 by Vincent Ladeuil
Add FIXME.
2894
        # FIXME: There should be a better way than relying on the test
2895
        # parametrization to identify branch.conf -- vila 2011-0526
5743.10.2 by Vincent Ladeuil
Make sure RemoteBranch are supported as well, relying on the vfs API.
2896
        if self.store_id in ('branch', 'remote_branch'):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2897
            raise tests.TestNotApplicable(
2898
                'branch.conf is *always* created when a branch is initialized')
2899
        store = self.get_store(self)
2900
        store._load_from_string('foo=bar\n')
2901
        self.assertEquals(False, self.has_store(store))
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2902
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2903
        self.assertEquals(True, self.has_store(store))
2904
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2905
        sections = list(modified_store.get_sections())
2906
        self.assertLength(1, sections)
2907
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2908
2909
    def test_set_option_in_empty_store(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2910
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2911
        # FIXME: There should be a better way than relying on the test
2912
        # parametrization to identify branch.conf -- vila 2011-0526
2913
        if self.store_id in ('branch', 'remote_branch'):
2914
            # branch stores requires write locked branches
2915
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2916
        section = store.get_mutable_section(None)
2917
        section.set('foo', 'bar')
2918
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2919
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2920
        sections = list(modified_store.get_sections())
2921
        self.assertLength(1, sections)
2922
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2923
2924
    def test_set_option_in_default_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2925
        store = self.get_store(self)
2926
        store._load_from_string('')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2927
        # FIXME: There should be a better way than relying on the test
2928
        # parametrization to identify branch.conf -- vila 2011-0526
2929
        if self.store_id in ('branch', 'remote_branch'):
2930
            # branch stores requires write locked branches
2931
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2932
        section = store.get_mutable_section(None)
2933
        section.set('foo', 'bar')
2934
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2935
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2936
        sections = list(modified_store.get_sections())
2937
        self.assertLength(1, sections)
2938
        self.assertSectionContent((None, {'foo': 'bar'}), sections[0])
2939
2940
    def test_set_option_in_named_section(self):
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2941
        store = self.get_store(self)
2942
        store._load_from_string('')
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2943
        # FIXME: There should be a better way than relying on the test
2944
        # parametrization to identify branch.conf -- vila 2011-0526
2945
        if self.store_id in ('branch', 'remote_branch'):
2946
            # branch stores requires write locked branches
2947
            self.addCleanup(store.branch.lock_write().unlock)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2948
        section = store.get_mutable_section('baz')
2949
        section.set('foo', 'bar')
2950
        store.save()
5743.5.10 by Vincent Ladeuil
Parametrize the generic tests against the concrete stores.
2951
        modified_store = self.get_store(self)
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
2952
        sections = list(modified_store.get_sections())
2953
        self.assertLength(1, sections)
2954
        self.assertSectionContent(('baz', {'foo': 'bar'}), sections[0])
2955
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2956
    def test_load_hook(self):
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2957
        # First, we need to ensure that the store exists
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2958
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2959
        # FIXME: There should be a better way than relying on the test
2960
        # parametrization to identify branch.conf -- vila 2011-0526
2961
        if self.store_id in ('branch', 'remote_branch'):
2962
            # branch stores requires write locked branches
2963
            self.addCleanup(store.branch.lock_write().unlock)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2964
        section = store.get_mutable_section('baz')
2965
        section.set('foo', 'bar')
2966
        store.save()
2967
        # Now we can try to load it
5743.8.11 by Vincent Ladeuil
Restrict the scope when testing hooks to avoid spurious failures.
2968
        store = self.get_store(self)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2969
        calls = []
2970
        def hook(*args):
2971
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2972
        config.ConfigHooks.install_named_hook('load', hook, None)
5743.8.8 by Vincent Ladeuil
Puth the load hook in the right place.
2973
        self.assertLength(0, calls)
2974
        store.load()
2975
        self.assertLength(1, calls)
2976
        self.assertEquals((store,), calls[0])
2977
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2978
    def test_save_hook(self):
2979
        calls = []
2980
        def hook(*args):
2981
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
2982
        config.ConfigHooks.install_named_hook('save', hook, None)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2983
        self.assertLength(0, calls)
2984
        store = self.get_store(self)
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
2985
        # FIXME: There should be a better way than relying on the test
2986
        # parametrization to identify branch.conf -- vila 2011-0526
2987
        if self.store_id in ('branch', 'remote_branch'):
2988
            # branch stores requires write locked branches
2989
            self.addCleanup(store.branch.lock_write().unlock)
5743.8.7 by Vincent Ladeuil
Add hooks for config stores (but the load one is not in the right place).
2990
        section = store.get_mutable_section('baz')
2991
        section.set('foo', 'bar')
2992
        store.save()
2993
        self.assertLength(1, calls)
2994
        self.assertEquals((store,), calls[0])
2995
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
2996
    def test_set_mark_dirty(self):
2997
        stack = config.MemoryStack('')
2998
        self.assertLength(0, stack.store.dirty_sections)
2999
        stack.set('foo', 'baz')
3000
        self.assertLength(1, stack.store.dirty_sections)
6404.5.3 by Vincent Ladeuil
If at least one mutable section contain a change, the store needs to be saved
3001
        self.assertTrue(stack.store._need_saving())
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
3002
3003
    def test_remove_mark_dirty(self):
3004
        stack = config.MemoryStack('foo=bar')
3005
        self.assertLength(0, stack.store.dirty_sections)
3006
        stack.remove('foo')
3007
        self.assertLength(1, stack.store.dirty_sections)
6404.5.3 by Vincent Ladeuil
If at least one mutable section contain a change, the store needs to be saved
3008
        self.assertTrue(stack.store._need_saving())
6404.5.1 by Vincent Ladeuil
Setting or removing an option records the section as dirty
3009
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3010
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3011
class TestStoreSaveChanges(tests.TestCaseWithTransport):
3012
    """Tests that config changes are kept in memory and saved on-demand."""
3013
3014
    def setUp(self):
3015
        super(TestStoreSaveChanges, self).setUp()
3016
        self.transport = self.get_transport()
3017
        # Most of the tests involve two stores pointing to the same persistent
3018
        # storage to observe the effects of concurrent changes
3019
        self.st1 = config.TransportIniFileStore(self.transport, 'foo.conf')
3020
        self.st2 = config.TransportIniFileStore(self.transport, 'foo.conf')
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3021
        self.warnings = []
3022
        def warning(*args):
3023
            self.warnings.append(args[0] % args[1:])
3024
        self.overrideAttr(trace, 'warning', warning)
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3025
3026
    def has_store(self, store):
3027
        store_basename = urlutils.relative_url(self.transport.external_url(),
3028
                                               store.external_url())
3029
        return self.transport.has(store_basename)
3030
3031
    def get_stack(self, store):
3032
        # Any stack will do as long as it uses the right store, just a single
3033
        # no-name section is enough
3034
        return config.Stack([store.get_sections], store)
3035
3036
    def test_no_changes_no_save(self):
3037
        s = self.get_stack(self.st1)
3038
        s.store.save_changes()
3039
        self.assertEquals(False, self.has_store(self.st1))
3040
3041
    def test_unrelated_concurrent_update(self):
3042
        s1 = self.get_stack(self.st1)
3043
        s2 = self.get_stack(self.st2)
3044
        s1.set('foo', 'bar')
3045
        s2.set('baz', 'quux')
3046
        s1.store.save()
3047
        # Changes don't propagate magically
3048
        self.assertEquals(None, s1.get('baz'))
3049
        s2.store.save_changes()
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3050
        self.assertEquals('quux', s2.get('baz'))
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3051
        # Changes are acquired when saving
3052
        self.assertEquals('bar', s2.get('foo'))
6404.5.5 by Vincent Ladeuil
Refine implementations and add more precise tests. More tests can be added for more scenarios if it doesn't seem worth it until we encounter them in real life (which is unlikely so far)
3053
        # Since there is no overlap, no warnings are emitted
3054
        self.assertLength(0, self.warnings)
3055
3056
    def test_concurrent_update_modified(self):
3057
        s1 = self.get_stack(self.st1)
3058
        s2 = self.get_stack(self.st2)
3059
        s1.set('foo', 'bar')
3060
        s2.set('foo', 'baz')
3061
        s1.store.save()
3062
        # Last speaker wins
3063
        s2.store.save_changes()
3064
        self.assertEquals('baz', s2.get('foo'))
3065
        # But the user get a warning
3066
        self.assertLength(1, self.warnings)
3067
        warning = self.warnings[0]
3068
        self.assertStartsWith(warning, 'Option foo in section None')
3069
        self.assertEndsWith(warning, 'was changed from <CREATED> to bar.'
3070
                            ' The baz value will be saved.')
3071
3072
    def test_concurrent_deletion(self):
3073
        self.st1._load_from_string('foo=bar')
3074
        self.st1.save()
3075
        s1 = self.get_stack(self.st1)
3076
        s2 = self.get_stack(self.st2)
3077
        s1.remove('foo')
3078
        s2.remove('foo')
3079
        s1.store.save_changes()
3080
        # No warning yet
3081
        self.assertLength(0, self.warnings)
3082
        s2.store.save_changes()
3083
        # Now we get one
3084
        self.assertLength(1, self.warnings)
3085
        warning = self.warnings[0]
3086
        self.assertStartsWith(warning, 'Option foo in section None')
3087
        self.assertEndsWith(warning, 'was changed from bar to <CREATED>.'
3088
                            ' The <DELETED> value will be saved.')
6404.5.4 by Vincent Ladeuil
Saving changes is incremental and brings back updates from concurrent users
3089
3090
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3091
class TestQuotingIniFileStore(tests.TestCaseWithTransport):
3092
3093
    def get_store(self):
3094
        return config.TransportIniFileStore(self.get_transport(), 'foo.conf')
3095
3096
    def test_get_quoted_string(self):
3097
        store = self.get_store()
3098
        store._load_from_string('foo= " abc "')
3099
        stack = config.Stack([store.get_sections])
3100
        self.assertEquals(' abc ', stack.get('foo'))
3101
3102
    def test_set_quoted_string(self):
3103
        store = self.get_store()
3104
        stack = config.Stack([store.get_sections], store)
3105
        stack.set('foo', ' a b c ')
3106
        store.save()
6421.1.1 by Martin Packman
Fix test_config failure by expecting suitable platform newlines in config file
3107
        self.assertFileEqual('foo = " a b c "' + os.linesep, 'foo.conf')
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3108
3109
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3110
class TestTransportIniFileStore(TestStore):
5743.4.6 by Vincent Ladeuil
Parametrize Store tests and isolate the ConfigObjStore specific ones.
3111
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
3112
    def test_loading_unknown_file_fails(self):
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3113
        store = config.TransportIniFileStore(self.get_transport(),
3114
            'I-do-not-exist')
5743.4.3 by Vincent Ladeuil
Implement get_mutable_section.
3115
        self.assertRaises(errors.NoSuchFile, store.load)
3116
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3117
    def test_invalid_content(self):
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3118
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3119
        self.assertEquals(False, store.is_loaded())
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3120
        exc = self.assertRaises(
3121
            errors.ParseConfigError, store._load_from_string,
3122
            'this is invalid !')
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3123
        self.assertEndsWith(exc.filename, 'foo.conf')
3124
        # And the load failed
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3125
        self.assertEquals(False, store.is_loaded())
5743.2.7 by Vincent Ladeuil
Implement loading a config store from a string or a file.
3126
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3127
    def test_get_embedded_sections(self):
5743.2.11 by Vincent Ladeuil
Basic store.set implementation.
3128
        # A more complicated example (which also shows that section names and
3129
        # option names share the same name space...)
5743.4.7 by Vincent Ladeuil
The test is now specific to ConfigObjStore and highlight a pending problem there.
3130
        # FIXME: This should be fixed by forbidding dicts as values ?
3131
        # -- vila 2011-04-05
6270.1.5 by Jelmer Vernooij
Add TransportIniFileStore.
3132
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3133
        store._load_from_string('''
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3134
foo=bar
3135
l=1,2
3136
[DEFAULT]
3137
foo_in_DEFAULT=foo_DEFAULT
3138
[bar]
3139
foo_in_bar=barbar
3140
[baz]
3141
foo_in_baz=barbaz
3142
[[qux]]
3143
foo_in_qux=quux
5743.4.18 by Vincent Ladeuil
Replace class.from_string with self._load_from_string to all stores can use it.
3144
''')
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3145
        sections = list(store.get_sections())
3146
        self.assertLength(4, sections)
3147
        # The default section has no name.
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3148
        # List values are provided as strings and need to be explicitly
3149
        # converted by specifying from_unicode=list_from_store at option
3150
        # registration
3151
        self.assertSectionContent((None, {'foo': 'bar', 'l': u'1,2'}),
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
3152
                                  sections[0])
3153
        self.assertSectionContent(
3154
            ('DEFAULT', {'foo_in_DEFAULT': 'foo_DEFAULT'}), sections[1])
3155
        self.assertSectionContent(
3156
            ('bar', {'foo_in_bar': 'barbar'}), sections[2])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3157
        # sub sections are provided as embedded dicts.
5743.4.1 by Vincent Ladeuil
Use proper ReadOnly sections in ConfigObjStore.get_sections().
3158
        self.assertSectionContent(
3159
            ('baz', {'foo_in_baz': 'barbaz', 'qux': {'foo_in_qux': 'quux'}}),
3160
            sections[3])
5743.2.10 by Vincent Ladeuil
Implement store.get_sections() as an iterator and provides the configobj implementation.
3161
5743.4.5 by Vincent Ladeuil
Split store tests between readonly and mutable ones.
3162
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3163
class TestLockableIniFileStore(TestStore):
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3164
3165
    def test_create_store_in_created_dir(self):
5743.6.21 by Vincent Ladeuil
Tighten the test.
3166
        self.assertPathDoesNotExist('dir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3167
        t = self.get_transport('dir/subdir')
5743.4.25 by Vincent Ladeuil
Address review comments by jelmer and poolie.
3168
        store = config.LockableIniFileStore(t, 'foo.conf')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3169
        store.get_mutable_section(None).set('foo', 'bar')
3170
        store.save()
5743.6.21 by Vincent Ladeuil
Tighten the test.
3171
        self.assertPathExists('dir/subdir')
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3172
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3173
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3174
class TestConcurrentStoreUpdates(TestStore):
5743.10.13 by Vincent Ladeuil
Mention that the the concurrent update tests are not targeted at *all* Store implementations.
3175
    """Test that Stores properly handle conccurent updates.
3176
3177
    New Store implementation may fail some of these tests but until such
3178
    implementations exist it's hard to properly filter them from the scenarios
3179
    applied here. If you encounter such a case, contact the bzr devs.
3180
    """
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3181
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3182
    scenarios = [(key, {'get_stack': builder}) for key, builder
3183
                 in config.test_stack_builder_registry.iteritems()]
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3184
3185
    def setUp(self):
3186
        super(TestConcurrentStoreUpdates, self).setUp()
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3187
        self.stack = self.get_stack(self)
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3188
        if not isinstance(self.stack, config._CompatibleStack):
3189
            raise tests.TestNotApplicable(
3190
                '%s is not meant to be compatible with the old config design'
3191
                % (self.stack,))
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3192
        self.stack.set('one', '1')
3193
        self.stack.set('two', '2')
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3194
        # Flush the store
3195
        self.stack.store.save()
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3196
3197
    def test_simple_read_access(self):
3198
        self.assertEquals('1', self.stack.get('one'))
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3199
5743.6.22 by Vincent Ladeuil
Start writing tests for lockable stores.
3200
    def test_simple_write_access(self):
3201
        self.stack.set('one', 'one')
3202
        self.assertEquals('one', self.stack.get('one'))
3203
5743.6.23 by Vincent Ladeuil
More config concurrent updates tests.
3204
    def test_listen_to_the_last_speaker(self):
3205
        c1 = self.stack
3206
        c2 = self.get_stack(self)
3207
        c1.set('one', 'ONE')
3208
        c2.set('two', 'TWO')
3209
        self.assertEquals('ONE', c1.get('one'))
3210
        self.assertEquals('TWO', c2.get('two'))
3211
        # The second update respect the first one
3212
        self.assertEquals('ONE', c2.get('one'))
3213
3214
    def test_last_speaker_wins(self):
3215
        # If the same config is not shared, the same variable modified twice
3216
        # can only see a single result.
3217
        c1 = self.stack
3218
        c2 = self.get_stack(self)
3219
        c1.set('one', 'c1')
3220
        c2.set('one', 'c2')
3221
        self.assertEquals('c2', c2.get('one'))
3222
        # The first modification is still available until another refresh
3223
        # occur
3224
        self.assertEquals('c1', c1.get('one'))
3225
        c1.set('two', 'done')
3226
        self.assertEquals('c2', c1.get('one'))
3227
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3228
    def test_writes_are_serialized(self):
3229
        c1 = self.stack
3230
        c2 = self.get_stack(self)
3231
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3232
        # We spawn a thread that will pause *during* the config saving.
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3233
        before_writing = threading.Event()
3234
        after_writing = threading.Event()
3235
        writing_done = threading.Event()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3236
        c1_save_without_locking_orig = c1.store.save_without_locking
3237
        def c1_save_without_locking():
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3238
            before_writing.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3239
            c1_save_without_locking_orig()
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3240
            # The lock is held. We wait for the main thread to decide when to
3241
            # continue
3242
            after_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3243
        c1.store.save_without_locking = c1_save_without_locking
5743.6.24 by Vincent Ladeuil
One more test with a ugly hack to allow the test to stop in the right place.
3244
        def c1_set():
3245
            c1.set('one', 'c1')
3246
            writing_done.set()
3247
        t1 = threading.Thread(target=c1_set)
3248
        # Collect the thread after the test
3249
        self.addCleanup(t1.join)
3250
        # Be ready to unblock the thread if the test goes wrong
3251
        self.addCleanup(after_writing.set)
3252
        t1.start()
3253
        before_writing.wait()
3254
        self.assertRaises(errors.LockContention,
3255
                          c2.set, 'one', 'c2')
3256
        self.assertEquals('c1', c1.get('one'))
3257
        # Let the lock be released
3258
        after_writing.set()
3259
        writing_done.wait()
3260
        c2.set('one', 'c2')
3261
        self.assertEquals('c2', c2.get('one'))
3262
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3263
    def test_read_while_writing(self):
3264
       c1 = self.stack
3265
       # We spawn a thread that will pause *during* the write
3266
       ready_to_write = threading.Event()
3267
       do_writing = threading.Event()
3268
       writing_done = threading.Event()
3269
       # We override the _save implementation so we know the store is locked
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3270
       c1_save_without_locking_orig = c1.store.save_without_locking
3271
       def c1_save_without_locking():
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3272
           ready_to_write.set()
3273
           # The lock is held. We wait for the main thread to decide when to
3274
           # continue
3275
           do_writing.wait()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3276
           c1_save_without_locking_orig()
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3277
           writing_done.set()
5743.6.32 by Vincent Ladeuil
Address poolie's review comments.
3278
       c1.store.save_without_locking = c1_save_without_locking
5743.6.25 by Vincent Ladeuil
Last test rewritten.
3279
       def c1_set():
3280
           c1.set('one', 'c1')
3281
       t1 = threading.Thread(target=c1_set)
3282
       # Collect the thread after the test
3283
       self.addCleanup(t1.join)
3284
       # Be ready to unblock the thread if the test goes wrong
3285
       self.addCleanup(do_writing.set)
3286
       t1.start()
3287
       # Ensure the thread is ready to write
3288
       ready_to_write.wait()
3289
       self.assertEquals('c1', c1.get('one'))
3290
       # If we read during the write, we get the old value
3291
       c2 = self.get_stack(self)
3292
       self.assertEquals('1', c2.get('one'))
3293
       # Let the writing occur and ensure it occurred
3294
       do_writing.set()
3295
       writing_done.wait()
3296
       # Now we get the updated value
3297
       c3 = self.get_stack(self)
3298
       self.assertEquals('c1', c3.get('one'))
3299
3300
    # FIXME: It may be worth looking into removing the lock dir when it's not
3301
    # needed anymore and look at possible fallouts for concurrent lockers. This
3302
    # will matter if/when we use config files outside of bazaar directories
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3303
    # (.bazaar or .bzr) -- vila 20110-04-111
5743.4.9 by Vincent Ladeuil
Implement a LockableConfigObjStore to be able to mimick the actual behaviour.
3304
3305
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3306
class TestSectionMatcher(TestStore):
3307
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3308
    scenarios = [('location', {'matcher': config.LocationMatcher}),
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3309
                 ('id', {'matcher': config.NameMatcher}),]
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3310
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3311
    def setUp(self):
3312
        super(TestSectionMatcher, self).setUp()
3313
        # Any simple store is good enough
3314
        self.get_store = config.test_store_builder_registry.get('configobj')
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3315
3316
    def test_no_matches_for_empty_stores(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3317
        store = self.get_store(self)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3318
        store._load_from_string('')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3319
        matcher = self.matcher(store, '/bar')
5743.2.22 by Vincent Ladeuil
Some minimal SectionMatcher implementation to setup the test infrastucture.
3320
        self.assertEquals([], list(matcher.get_sections()))
3321
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3322
    def test_build_doesnt_load_store(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3323
        store = self.get_store(self)
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3324
        matcher = self.matcher(store, '/bar')
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3325
        self.assertFalse(store.is_loaded())
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3326
3327
3328
class TestLocationSection(tests.TestCase):
3329
3330
    def get_section(self, options, extra_path):
5743.2.37 by Vincent Ladeuil
Merge config-concrete-stores into config-section-matchers resolving conflicts
3331
        section = config.Section('foo', options)
6402.2.1 by Vincent Ladeuil
Get rid of LocationSection.length as its not needed in the general case.
3332
        return config.LocationSection(section, extra_path)
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3333
3334
    def test_simple_option(self):
3335
        section = self.get_section({'foo': 'bar'}, '')
3336
        self.assertEquals('bar', section.get('foo'))
3337
3338
    def test_option_with_extra_path(self):
3339
        section = self.get_section({'foo': 'bar', 'foo:policy': 'appendpath'},
3340
                                   'baz')
3341
        self.assertEquals('bar/baz', section.get('foo'))
3342
3343
    def test_invalid_policy(self):
3344
        section = self.get_section({'foo': 'bar', 'foo:policy': 'die'},
3345
                                   'baz')
3346
        # invalid policies are ignored
3347
        self.assertEquals('bar', section.get('foo'))
3348
3349
3350
class TestLocationMatcher(TestStore):
3351
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3352
    def setUp(self):
3353
        super(TestLocationMatcher, self).setUp()
3354
        # Any simple store is good enough
3355
        self.get_store = config.test_store_builder_registry.get('configobj')
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3356
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3357
    def test_unrelated_section_excluded(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3358
        store = self.get_store(self)
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3359
        store._load_from_string('''
3360
[/foo]
3361
section=/foo
3362
[/foo/baz]
3363
section=/foo/baz
3364
[/foo/bar]
3365
section=/foo/bar
3366
[/foo/bar/baz]
3367
section=/foo/bar/baz
3368
[/quux/quux]
3369
section=/quux/quux
3370
''')
3371
        self.assertEquals(['/foo', '/foo/baz', '/foo/bar', '/foo/bar/baz',
3372
                           '/quux/quux'],
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3373
                          [section.id for _, section in store.get_sections()])
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3374
        matcher = config.LocationMatcher(store, '/foo/bar/quux')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3375
        sections = [section for _, section in matcher.get_sections()]
6015.22.1 by Vincent Ladeuil
config.LocationMatcher properly excludes unrelated sections
3376
        self.assertEquals(['/foo/bar', '/foo'],
3377
                          [section.id for section in sections])
3378
        self.assertEquals(['quux', 'bar/quux'],
3379
                          [section.extra_path for section in sections])
3380
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3381
    def test_more_specific_sections_first(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3382
        store = self.get_store(self)
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3383
        store._load_from_string('''
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3384
[/foo]
3385
section=/foo
3386
[/foo/bar]
3387
section=/foo/bar
5743.2.33 by Vincent Ladeuil
Stop using get_ConfigObjStore.
3388
''')
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3389
        self.assertEquals(['/foo', '/foo/bar'],
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3390
                          [section.id for _, section in store.get_sections()])
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3391
        matcher = config.LocationMatcher(store, '/foo/bar/baz')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3392
        sections = [section for _, section in matcher.get_sections()]
5743.2.24 by Vincent Ladeuil
Complete location config helpers with basic tests.
3393
        self.assertEquals(['/foo/bar', '/foo'],
3394
                          [section.id for section in sections])
3395
        self.assertEquals(['baz', 'bar/baz'],
3396
                          [section.extra_path for section in sections])
3397
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3398
    def test_appendpath_in_no_name_section(self):
3399
        # It's a bit weird to allow appendpath in a no-name section, but
3400
        # someone may found a use for it
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3401
        store = self.get_store(self)
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3402
        store._load_from_string('''
3403
foo=bar
3404
foo:policy = appendpath
3405
''')
3406
        matcher = config.LocationMatcher(store, 'dir/subdir')
3407
        sections = list(matcher.get_sections())
3408
        self.assertLength(1, sections)
6260.3.1 by Vincent Ladeuil
Switch ``bzr config`` to the new config implementation
3409
        self.assertEquals('bar/dir/subdir', sections[0][1].get('foo'))
5743.6.18 by Vincent Ladeuil
Add a test for appendpath support in no-name section.
3410
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3411
    def test_file_urls_are_normalized(self):
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3412
        store = self.get_store(self)
5912.3.1 by Vincent Ladeuil
Fix spurious windows-specific test failure
3413
        if sys.platform == 'win32':
3414
            expected_url = 'file:///C:/dir/subdir'
3415
            expected_location = 'C:/dir/subdir'
3416
        else:
3417
            expected_url = 'file:///dir/subdir'
3418
            expected_location = '/dir/subdir'
3419
        matcher = config.LocationMatcher(store, expected_url)
3420
        self.assertEquals(expected_location, matcher.location)
5743.6.19 by Vincent Ladeuil
Clarify comments about section names for Location-related objects (also fix LocationMatcher and add tests).
3421
5743.1.20 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3422
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3423
class TestStartingPathMatcher(TestStore):
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3424
3425
    def setUp(self):
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3426
        super(TestStartingPathMatcher, self).setUp()
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3427
        # Any simple store is good enough
3428
        self.store = config.IniFileStore()
3429
3430
    def assertSectionIDs(self, expected, location, content):
3431
        self.store._load_from_string(content)
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3432
        matcher = config.StartingPathMatcher(self.store, location)
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3433
        sections = list(matcher.get_sections())
3434
        self.assertLength(len(expected), sections)
3435
        self.assertEqual(expected, [section.id for _, section in sections])
3436
        return sections
3437
3438
    def test_empty(self):
6402.2.7 by Vincent Ladeuil
Cleanup a bit and make sure we use at least one file:// url in the tests.
3439
        self.assertSectionIDs([], self.get_url(), '')
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3440
6402.2.8 by Vincent Ladeuil
Feedback from review.
3441
    def test_url_vs_local_paths(self):
3442
        # The matcher location is an url and the section names are local paths
3443
        sections = self.assertSectionIDs(['/foo/bar', '/foo'],
3444
                                         'file:///foo/bar/baz', '''\
3445
[/foo]
3446
[/foo/bar]
3447
''')
3448
3449
    def test_local_path_vs_url(self):
3450
        # The matcher location is a local path and the section names are urls
3451
        sections = self.assertSectionIDs(['file:///foo/bar', 'file:///foo'],
3452
                                         '/foo/bar/baz', '''\
3453
[file:///foo]
3454
[file:///foo/bar]
3455
''')
3456
3457
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3458
    def test_no_name_section_included_when_present(self):
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3459
        # Note that other tests will cover the case where the no-name section
3460
        # is empty and as such, not included.
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3461
        sections = self.assertSectionIDs(['/foo/bar', '/foo', None],
3462
                                         '/foo/bar/baz', '''\
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3463
option = defined so the no-name section exists
3464
[/foo]
3465
[/foo/bar]
3466
''')
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3467
        self.assertEquals(['baz', 'bar/baz', '/foo/bar/baz'],
3468
                          [s.locals['relpath'] for _, s in sections])
6402.2.5 by Vincent Ladeuil
Always return the no-name section if present.
3469
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3470
    def test_order_reversed(self):
3471
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
3472
[/foo]
3473
[/foo/bar]
3474
''')
3475
3476
    def test_unrelated_section_excluded(self):
3477
        self.assertSectionIDs(['/foo/bar', '/foo'], '/foo/bar/baz', '''\
3478
[/foo]
3479
[/foo/qux]
3480
[/foo/bar]
3481
''')
3482
3483
    def test_glob_included(self):
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3484
        sections = self.assertSectionIDs(['/foo/*/baz', '/foo/b*', '/foo'],
3485
                                         '/foo/bar/baz', '''\
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3486
[/foo]
3487
[/foo/qux]
3488
[/foo/b*]
3489
[/foo/*/baz]
3490
''')
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3491
        # Note that 'baz' as a relpath for /foo/b* is not fully correct, but
6402.2.8 by Vincent Ladeuil
Feedback from review.
3492
        # nothing really is... as far using {relpath} to append it to something
3493
        # else, this seems good enough though.
6402.2.6 by Vincent Ladeuil
Fix {relpath} support, realizing that when a section ends with a glob, it's not obivous to decide what should be done.
3494
        self.assertEquals(['', 'baz', 'bar/baz'],
3495
                          [s.locals['relpath'] for _, s in sections])
6402.2.3 by Vincent Ladeuil
More tests, a real implementation and some tweaks.
3496
3497
    def test_respect_order(self):
3498
        self.assertSectionIDs(['/foo', '/foo/b*', '/foo/*/baz'],
3499
                              '/foo/bar/baz', '''\
3500
[/foo/*/baz]
3501
[/foo/qux]
3502
[/foo/b*]
3503
[/foo]
3504
''')
3505
3506
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3507
class TestNameMatcher(TestStore):
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3508
3509
    def setUp(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3510
        super(TestNameMatcher, self).setUp()
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3511
        self.matcher = config.NameMatcher
3512
        # Any simple store is good enough
3513
        self.get_store = config.test_store_builder_registry.get('configobj')
3514
3515
    def get_matching_sections(self, name):
3516
        store = self.get_store(self)
3517
        store._load_from_string('''
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3518
[foo]
3519
option=foo
3520
[foo/baz]
3521
option=foo/baz
3522
[bar]
3523
option=bar
3524
''')
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
3525
        matcher = self.matcher(store, name)
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3526
        return list(matcher.get_sections())
3527
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3528
    def test_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3529
        sections = self.get_matching_sections('foo')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3530
        self.assertLength(1, sections)
3531
        self.assertSectionContent(('foo', {'option': 'foo'}), sections[0])
3532
3533
    def test_not_matching(self):
6123.7.2 by Vincent Ladeuil
Rename IdMatcher to NameMatcher.
3534
        sections = self.get_matching_sections('baz')
6123.7.1 by Vincent Ladeuil
Provide config.IdMatcher for config files defining secion names as unique ids
3535
        self.assertLength(0, sections)
3536
3537
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3538
class TestBaseStackGet(tests.TestCase):
3539
3540
    def setUp(self):
3541
        super(TestBaseStackGet, self).setUp()
6056.2.4 by Vincent Ladeuil
Option help is now part of the object itself.
3542
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3543
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3544
    def test_get_first_definition(self):
3545
        store1 = config.IniFileStore()
3546
        store1._load_from_string('foo=bar')
3547
        store2 = config.IniFileStore()
3548
        store2._load_from_string('foo=baz')
3549
        conf = config.Stack([store1.get_sections, store2.get_sections])
3550
        self.assertEquals('bar', conf.get('foo'))
5743.1.1 by Vincent Ladeuil
Start implementing a config stack.
3551
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3552
    def test_get_with_registered_default_value(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3553
        config.option_registry.register(config.Option('foo', default='bar'))
3554
        conf_stack = config.Stack([])
5743.12.6 by Vincent Ladeuil
Stack.get() provides the registered option default value.
3555
        self.assertEquals('bar', conf_stack.get('foo'))
3556
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3557
    def test_get_without_registered_default_value(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3558
        config.option_registry.register(config.Option('foo'))
3559
        conf_stack = config.Stack([])
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3560
        self.assertEquals(None, conf_stack.get('foo'))
3561
3562
    def test_get_without_default_value_for_not_registered(self):
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3563
        conf_stack = config.Stack([])
5743.12.7 by Vincent Ladeuil
Test that providing a default value doesn't break for non-registered options.
3564
        self.assertEquals(None, conf_stack.get('foo'))
3565
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3566
    def test_get_for_empty_section_callable(self):
5743.1.34 by Vincent Ladeuil
Merge config-section-matchers into config-stack resolving conflicts
3567
        conf_stack = config.Stack([lambda : []])
5743.1.16 by Vincent Ladeuil
Allows empty sections and empty section callables.
3568
        self.assertEquals(None, conf_stack.get('foo'))
3569
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3570
    def test_get_for_broken_callable(self):
3571
        # Trying to use and invalid callable raises an exception on first use
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3572
        conf_stack = config.Stack([object])
5743.1.35 by Vincent Ladeuil
Address some review comments from jelmer and poolie.
3573
        self.assertRaises(TypeError, conf_stack.get, 'foo')
3574
3575
6393.3.1 by Vincent Ladeuil
Configuration option value can be overridden by os environ variables
3576
class TestStackWithSimpleStore(tests.TestCase):
3577
3578
    def setUp(self):
3579
        super(TestStackWithSimpleStore, self).setUp()
3580
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3581
        self.registry = config.option_registry
3582
3583
    def get_conf(self, content=None):
3584
        return config.MemoryStack(content)
3585
3586
    def test_override_value_from_env(self):
3587
        self.registry.register(
3588
            config.Option('foo', default='bar', override_from_env=['FOO']))
3589
        self.overrideEnv('FOO', 'quux')
3590
        # Env variable provides a default taking over the option one
3591
        conf = self.get_conf('foo=store')
3592
        self.assertEquals('quux', conf.get('foo'))
3593
3594
    def test_first_override_value_from_env_wins(self):
3595
        self.registry.register(
3596
            config.Option('foo', default='bar',
3597
                          override_from_env=['NO_VALUE', 'FOO', 'BAZ']))
3598
        self.overrideEnv('FOO', 'foo')
3599
        self.overrideEnv('BAZ', 'baz')
3600
        # The first env var set wins
3601
        conf = self.get_conf('foo=store')
3602
        self.assertEquals('foo', conf.get('foo'))
3603
3604
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3605
class TestMemoryStack(tests.TestCase):
3606
3607
    def test_get(self):
3608
        conf = config.MemoryStack('foo=bar')
3609
        self.assertEquals('bar', conf.get('foo'))
3610
3611
    def test_set(self):
3612
        conf = config.MemoryStack('foo=bar')
3613
        conf.set('foo', 'baz')
3614
        self.assertEquals('baz', conf.get('foo'))
3615
3616
    def test_no_content(self):
3617
        conf = config.MemoryStack()
3618
        # No content means no loading
3619
        self.assertFalse(conf.store.is_loaded())
6393.1.2 by Vincent Ladeuil
Cannot use ExpectedException as pqm provides only testtools-0.9.8, 0.9.9 needed
3620
        self.assertRaises(NotImplementedError, conf.get, 'foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3621
        # But a content can still be provided
3622
        conf.store._load_from_string('foo=bar')
3623
        self.assertEquals('bar', conf.get('foo'))
3624
3625
6466.1.4 by Vincent Ladeuil
Fix typo and add tests.
3626
class TestStackIterSections(tests.TestCase):
3627
3628
    def test_empty_stack(self):
3629
        conf = config.Stack([])
3630
        sections = list(conf.iter_sections())
3631
        self.assertLength(0, sections)
3632
3633
    def test_empty_store(self):
3634
        store = config.IniFileStore()
3635
        store._load_from_string('')
3636
        conf = config.Stack([store.get_sections])
3637
        sections = list(conf.iter_sections())
3638
        self.assertLength(0, sections)
3639
3640
    def test_simple_store(self):
3641
        store = config.IniFileStore()
3642
        store._load_from_string('foo=bar')
3643
        conf = config.Stack([store.get_sections])
3644
        tuples = list(conf.iter_sections())
3645
        self.assertLength(1, tuples)
3646
        (found_store, found_section) = tuples[0]
3647
        self.assertIs(store, found_store)
3648
3649
    def test_two_stores(self):
3650
        store1 = config.IniFileStore()
3651
        store1._load_from_string('foo=bar')
3652
        store2 = config.IniFileStore()
3653
        store2._load_from_string('bar=qux')
3654
        conf = config.Stack([store1.get_sections, store2.get_sections])
3655
        tuples = list(conf.iter_sections())
3656
        self.assertLength(2, tuples)
3657
        self.assertIs(store1, tuples[0][0])
3658
        self.assertIs(store2, tuples[1][0])
3659
3660
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3661
class TestStackWithTransport(tests.TestCaseWithTransport):
3662
5743.6.27 by Vincent Ladeuil
Move the test registries to bzrlib.config so plugins will be able to use
3663
    scenarios = [(key, {'get_stack': builder}) for key, builder
3664
                 in config.test_stack_builder_registry.iteritems()]
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
3665
3666
5743.11.1 by Vincent Ladeuil
Add a note about config store builders being called several times by some tests.
3667
class TestConcreteStacks(TestStackWithTransport):
3668
3669
    def test_build_stack(self):
3670
        # Just a smoke test to help debug builders
3671
        stack = self.get_stack(self)
3672
3673
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3674
class TestStackGet(TestStackWithTransport):
3675
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3676
    def setUp(self):
3677
        super(TestStackGet, self).setUp()
3678
        self.conf = self.get_stack(self)
3679
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3680
    def test_get_for_empty_stack(self):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3681
        self.assertEquals(None, self.conf.get('foo'))
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3682
3683
    def test_get_hook(self):
6260.3.2 by Vincent Ladeuil
Only the DEFAULT section is searched for the normal uses of bazaar.conf
3684
        self.conf.set('foo', 'bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3685
        calls = []
3686
        def hook(*args):
3687
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
3688
        config.ConfigHooks.install_named_hook('get', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3689
        self.assertLength(0, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3690
        value = self.conf.get('foo')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3691
        self.assertEquals('bar', value)
3692
        self.assertLength(1, calls)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3693
        self.assertEquals((self.conf, 'foo', 'bar'), calls[0])
3694
3695
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3696
class TestStackGetWithConverter(tests.TestCase):
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3697
3698
    def setUp(self):
3699
        super(TestStackGetWithConverter, self).setUp()
3700
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3701
        self.registry = config.option_registry
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3702
3703
    def get_conf(self, content=None):
3704
        return config.MemoryStack(content)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3705
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3706
    def register_bool_option(self, name, default=None, default_from_env=None):
3707
        b = config.Option(name, help='A boolean.',
3708
                          default=default, default_from_env=default_from_env,
3709
                          from_unicode=config.bool_from_store)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
3710
        self.registry.register(b)
3711
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3712
    def test_get_default_bool_None(self):
3713
        self.register_bool_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3714
        conf = self.get_conf('')
3715
        self.assertEquals(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3716
3717
    def test_get_default_bool_True(self):
3718
        self.register_bool_option('foo', u'True')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3719
        conf = self.get_conf('')
3720
        self.assertEquals(True, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3721
3722
    def test_get_default_bool_False(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3723
        self.register_bool_option('foo', False)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3724
        conf = self.get_conf('')
3725
        self.assertEquals(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3726
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3727
    def test_get_default_bool_False_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3728
        self.register_bool_option('foo', u'False')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3729
        conf = self.get_conf('')
3730
        self.assertEquals(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3731
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3732
    def test_get_default_bool_from_env_converted(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3733
        self.register_bool_option('foo', u'True', default_from_env=['FOO'])
3734
        self.overrideEnv('FOO', 'False')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3735
        conf = self.get_conf('')
3736
        self.assertEquals(False, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3737
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3738
    def test_get_default_bool_when_conversion_fails(self):
3739
        self.register_bool_option('foo', default='True')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3740
        conf = self.get_conf('foo=invalid boolean')
3741
        self.assertEquals(True, conf.get('foo'))
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3742
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3743
    def register_integer_option(self, name,
3744
                                default=None, default_from_env=None):
3745
        i = config.Option(name, help='An integer.',
3746
                          default=default, default_from_env=default_from_env,
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3747
                          from_unicode=config.int_from_store)
3748
        self.registry.register(i)
3749
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3750
    def test_get_default_integer_None(self):
3751
        self.register_integer_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3752
        conf = self.get_conf('')
3753
        self.assertEquals(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3754
3755
    def test_get_default_integer(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3756
        self.register_integer_option('foo', 42)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3757
        conf = self.get_conf('')
3758
        self.assertEquals(42, conf.get('foo'))
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3759
3760
    def test_get_default_integer_as_string(self):
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3761
        self.register_integer_option('foo', u'42')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3762
        conf = self.get_conf('')
3763
        self.assertEquals(42, conf.get('foo'))
6059.1.6 by Vincent Ladeuil
Implement integer config options.
3764
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3765
    def test_get_default_integer_from_env(self):
3766
        self.register_integer_option('foo', default_from_env=['FOO'])
3767
        self.overrideEnv('FOO', '18')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3768
        conf = self.get_conf('')
3769
        self.assertEquals(18, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3770
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3771
    def test_get_default_integer_when_conversion_fails(self):
3772
        self.register_integer_option('foo', default='12')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3773
        conf = self.get_conf('foo=invalid integer')
3774
        self.assertEquals(12, conf.get('foo'))
6091.3.3 by Vincent Ladeuil
Update registered option default values and also convert the default value if the first conversion fails.
3775
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3776
    def register_list_option(self, name, default=None, default_from_env=None):
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3777
        l = config.ListOption(name, help='A list.', default=default,
3778
                              default_from_env=default_from_env)
6059.2.1 by Vincent Ladeuil
Implement list config options.
3779
        self.registry.register(l)
3780
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3781
    def test_get_default_list_None(self):
3782
        self.register_list_option('foo')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3783
        conf = self.get_conf('')
3784
        self.assertEquals(None, conf.get('foo'))
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3785
3786
    def test_get_default_list_empty(self):
3787
        self.register_list_option('foo', '')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3788
        conf = self.get_conf('')
3789
        self.assertEquals([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3790
6091.3.2 by Vincent Ladeuil
Cleanup now duplicated tests, always convert default value so environment variables can be used for more option types.
3791
    def test_get_default_list_from_env(self):
3792
        self.register_list_option('foo', default_from_env=['FOO'])
3793
        self.overrideEnv('FOO', '')
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3794
        conf = self.get_conf('')
3795
        self.assertEquals([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3796
3797
    def test_get_with_list_converter_no_item(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3798
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3799
        conf = self.get_conf('foo=,')
3800
        self.assertEquals([], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3801
3802
    def test_get_with_list_converter_many_items(self):
6091.3.6 by Vincent Ladeuil
Replace ugly default value declarations with ad-hoc and limited conversion to unicode strings.
3803
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3804
        conf = self.get_conf('foo=m,o,r,e')
3805
        self.assertEquals(['m', 'o', 'r', 'e'], conf.get('foo'))
6059.2.1 by Vincent Ladeuil
Implement list config options.
3806
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3807
    def test_get_with_list_converter_embedded_spaces_many_items(self):
3808
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3809
        conf = self.get_conf('foo=" bar", "baz "')
3810
        self.assertEquals([' bar', 'baz '], conf.get('foo'))
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3811
3812
    def test_get_with_list_converter_stripped_spaces_many_items(self):
3813
        self.register_list_option('foo', None)
6393.1.1 by Vincent Ladeuil
Provides MemoryStack to simplify configuration setup in tests
3814
        conf = self.get_conf('foo= bar ,  baz ')
3815
        self.assertEquals(['bar', 'baz'], conf.get('foo'))
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3816
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
3817
6082.5.20 by Vincent Ladeuil
Refactor iter_option_refs out of Stack so it can be reused.
3818
class TestIterOptionRefs(tests.TestCase):
3819
    """iter_option_refs is a bit unusual, document some cases."""
3820
3821
    def assertRefs(self, expected, string):
3822
        self.assertEquals(expected, list(config.iter_option_refs(string)))
3823
3824
    def test_empty(self):
3825
        self.assertRefs([(False, '')], '')
3826
3827
    def test_no_refs(self):
3828
        self.assertRefs([(False, 'foo bar')], 'foo bar')
3829
3830
    def test_single_ref(self):
3831
        self.assertRefs([(False, ''), (True, '{foo}'), (False, '')], '{foo}')
3832
3833
    def test_broken_ref(self):
3834
        self.assertRefs([(False, '{foo')], '{foo')
3835
3836
    def test_embedded_ref(self):
3837
        self.assertRefs([(False, '{'), (True, '{foo}'), (False, '}')],
3838
                        '{{foo}}')
3839
3840
    def test_two_refs(self):
3841
        self.assertRefs([(False, ''), (True, '{foo}'),
3842
                         (False, ''), (True, '{bar}'),
3843
                         (False, ''),],
3844
                        '{foo}{bar}')
3845
6351.1.1 by Vincent Ladeuil
Don't accept \n as part of a config option reference
3846
    def test_newline_in_refs_are_not_matched(self):
3847
        self.assertRefs([(False, '{\nxx}{xx\n}{{\n}}')], '{\nxx}{xx\n}{{\n}}')
3848
6082.5.20 by Vincent Ladeuil
Refactor iter_option_refs out of Stack so it can be reused.
3849
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3850
class TestStackExpandOptions(tests.TestCaseWithTransport):
3851
3852
    def setUp(self):
3853
        super(TestStackExpandOptions, self).setUp()
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3854
        self.overrideAttr(config, 'option_registry', config.OptionRegistry())
3855
        self.registry = config.option_registry
6404.6.1 by Vincent Ladeuil
Tests passing for a first rough version of a cached branch config store. The changes here are too invasive and several parallel proposals have been made.
3856
        store = config.TransportIniFileStore(self.get_transport(), 'foo.conf')
3857
        self.conf = config.Stack([store.get_sections], store)
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3858
3859
    def assertExpansion(self, expected, string, env=None):
3860
        self.assertEquals(expected, self.conf.expand_options(string, env))
3861
3862
    def test_no_expansion(self):
3863
        self.assertExpansion('foo', 'foo')
3864
6082.5.7 by Vincent Ladeuil
If conversion fails, the default value still needs to be expanded (if applicable).
3865
    def test_expand_default_value(self):
3866
        self.conf.store._load_from_string('bar=baz')
3867
        self.registry.register(config.Option('foo', default=u'{bar}'))
3868
        self.assertEquals('baz', self.conf.get('foo', expand=True))
3869
3870
    def test_expand_default_from_env(self):
3871
        self.conf.store._load_from_string('bar=baz')
3872
        self.registry.register(config.Option('foo', default_from_env=['FOO']))
3873
        self.overrideEnv('FOO', '{bar}')
3874
        self.assertEquals('baz', self.conf.get('foo', expand=True))
3875
3876
    def test_expand_default_on_failed_conversion(self):
3877
        self.conf.store._load_from_string('baz=bogus\nbar=42\nfoo={baz}')
3878
        self.registry.register(
3879
            config.Option('foo', default=u'{bar}',
3880
                          from_unicode=config.int_from_store))
3881
        self.assertEquals(42, self.conf.get('foo', expand=True))
3882
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3883
    def test_env_adding_options(self):
3884
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3885
3886
    def test_env_overriding_options(self):
3887
        self.conf.store._load_from_string('foo=baz')
3888
        self.assertExpansion('bar', '{foo}', {'foo': 'bar'})
3889
3890
    def test_simple_ref(self):
3891
        self.conf.store._load_from_string('foo=xxx')
3892
        self.assertExpansion('xxx', '{foo}')
3893
3894
    def test_unknown_ref(self):
3895
        self.assertRaises(errors.ExpandingUnknownOption,
3896
                          self.conf.expand_options, '{foo}')
3897
3898
    def test_indirect_ref(self):
3899
        self.conf.store._load_from_string('''
3900
foo=xxx
3901
bar={foo}
3902
''')
3903
        self.assertExpansion('xxx', '{bar}')
3904
3905
    def test_embedded_ref(self):
3906
        self.conf.store._load_from_string('''
3907
foo=xxx
3908
bar=foo
3909
''')
3910
        self.assertExpansion('xxx', '{{bar}}')
3911
3912
    def test_simple_loop(self):
3913
        self.conf.store._load_from_string('foo={foo}')
3914
        self.assertRaises(errors.OptionExpansionLoop,
3915
                          self.conf.expand_options, '{foo}')
3916
3917
    def test_indirect_loop(self):
3918
        self.conf.store._load_from_string('''
3919
foo={bar}
3920
bar={baz}
3921
baz={foo}''')
3922
        e = self.assertRaises(errors.OptionExpansionLoop,
3923
                              self.conf.expand_options, '{foo}')
3924
        self.assertEquals('foo->bar->baz', e.refs)
3925
        self.assertEquals('{foo}', e.string)
3926
3927
    def test_list(self):
3928
        self.conf.store._load_from_string('''
3929
foo=start
3930
bar=middle
3931
baz=end
3932
list={foo},{bar},{baz}
3933
''')
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3934
        self.registry.register(
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3935
            config.ListOption('list'))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3936
        self.assertEquals(['start', 'middle', 'end'],
3937
                           self.conf.get('list', expand=True))
3938
3939
    def test_cascading_list(self):
3940
        self.conf.store._load_from_string('''
3941
foo=start,{bar}
3942
bar=middle,{baz}
3943
baz=end
3944
list={foo}
3945
''')
6466.1.3 by Vincent Ladeuil
Values should never be converted during expansion.
3946
        self.registry.register(config.ListOption('list'))
3947
        # Register an intermediate option as a list to ensure no conversion
6466.1.4 by Vincent Ladeuil
Fix typo and add tests.
3948
        # happen while expanding. Conversion should only occur for the original
6466.1.3 by Vincent Ladeuil
Values should never be converted during expansion.
3949
        # option ('list' here).
3950
        self.registry.register(config.ListOption('baz'))
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3951
        self.assertEquals(['start', 'middle', 'end'],
3952
                           self.conf.get('list', expand=True))
3953
3954
    def test_pathologically_hidden_list(self):
3955
        self.conf.store._load_from_string('''
3956
foo=bin
3957
bar=go
3958
start={foo
3959
middle=},{
3960
end=bar}
3961
hidden={start}{middle}{end}
3962
''')
6082.5.13 by Vincent Ladeuil
Fix typos.
3963
        # What matters is what the registration says, the conversion happens
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3964
        # only after all expansions have been performed
6385.1.1 by Vincent Ladeuil
Stores allow Stacks to control when values are quoted/unquoted
3965
        self.registry.register(config.ListOption('hidden'))
6082.5.11 by Vincent Ladeuil
Disable list_values for config.Store, using a dedicated configobj object to trigger the string -> list conversion on-demand (via the option registration) only.
3966
        self.assertEquals(['bin', 'go'],
6082.5.2 by Vincent Ladeuil
Cargo-cult the config option expansion implementation with tweaks from the old to the new config design.
3967
                          self.conf.get('hidden', expand=True))
3968
3969
3970
class TestStackCrossSectionsExpand(tests.TestCaseWithTransport):
3971
3972
    def setUp(self):
3973
        super(TestStackCrossSectionsExpand, self).setUp()
3974
3975
    def get_config(self, location, string):
3976
        if string is None:
3977
            string = ''
3978
        # Since we don't save the config we won't strictly require to inherit
3979
        # from TestCaseInTempDir, but an error occurs so quickly...
3980
        c = config.LocationStack(location)
3981
        c.store._load_from_string(string)
3982
        return c
3983
3984
    def test_dont_cross_unrelated_section(self):
3985
        c = self.get_config('/another/branch/path','''
3986
[/one/branch/path]
3987
foo = hello
3988
bar = {foo}/2
3989
3990
[/another/branch/path]
3991
bar = {foo}/2
3992
''')
3993
        self.assertRaises(errors.ExpandingUnknownOption,
3994
                          c.get, 'bar', expand=True)
3995
3996
    def test_cross_related_sections(self):
3997
        c = self.get_config('/project/branch/path','''
3998
[/project]
3999
foo = qu
4000
4001
[/project/branch/path]
4002
bar = {foo}ux
4003
''')
4004
        self.assertEquals('quux', c.get('bar', expand=True))
4005
4006
6082.5.19 by Vincent Ladeuil
Bah, cross stores expansion already works of course, tests added.
4007
class TestStackCrossStoresExpand(tests.TestCaseWithTransport):
4008
4009
    def test_cross_global_locations(self):
4010
        l_store = config.LocationStore()
4011
        l_store._load_from_string('''
4012
[/branch]
4013
lfoo = loc-foo
4014
lbar = {gbar}
4015
''')
4016
        l_store.save()
4017
        g_store = config.GlobalStore()
4018
        g_store._load_from_string('''
4019
[DEFAULT]
4020
gfoo = {lfoo}
4021
gbar = glob-bar
4022
''')
4023
        g_store.save()
4024
        stack = config.LocationStack('/branch')
4025
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
4026
        self.assertEquals('loc-foo', stack.get('gfoo', expand=True))
4027
4028
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4029
class TestStackExpandSectionLocals(tests.TestCaseWithTransport):
4030
6082.5.25 by Vincent Ladeuil
Add ``basename`` as a section local option
4031
    def test_expand_locals_empty(self):
4032
        l_store = config.LocationStore()
4033
        l_store._load_from_string('''
4034
[/home/user/project]
4035
base = {basename}
4036
rel = {relpath}
4037
''')
4038
        l_store.save()
4039
        stack = config.LocationStack('/home/user/project/')
4040
        self.assertEquals('', stack.get('base', expand=True))
4041
        self.assertEquals('', stack.get('rel', expand=True))
4042
4043
    def test_expand_basename_locally(self):
4044
        l_store = config.LocationStore()
4045
        l_store._load_from_string('''
4046
[/home/user/project]
4047
bfoo = {basename}
4048
''')
4049
        l_store.save()
4050
        stack = config.LocationStack('/home/user/project/branch')
4051
        self.assertEquals('branch', stack.get('bfoo', expand=True))
4052
6082.5.28 by Vincent Ladeuil
Add a test to better expose the feature
4053
    def test_expand_basename_locally_longer_path(self):
4054
        l_store = config.LocationStore()
4055
        l_store._load_from_string('''
4056
[/home/user]
4057
bfoo = {basename}
4058
''')
4059
        l_store.save()
4060
        stack = config.LocationStack('/home/user/project/dir/branch')
4061
        self.assertEquals('branch', stack.get('bfoo', expand=True))
4062
6082.5.21 by Vincent Ladeuil
Implement 'relpath' as a section locally expanded option.
4063
    def test_expand_relpath_locally(self):
4064
        l_store = config.LocationStore()
4065
        l_store._load_from_string('''
4066
[/home/user/project]
4067
lfoo = loc-foo/{relpath}
4068
''')
4069
        l_store.save()
4070
        stack = config.LocationStack('/home/user/project/branch')
4071
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
4072
4073
    def test_expand_relpath_unknonw_in_global(self):
4074
        g_store = config.GlobalStore()
4075
        g_store._load_from_string('''
4076
[DEFAULT]
4077
gfoo = {relpath}
4078
''')
4079
        g_store.save()
4080
        stack = config.LocationStack('/home/user/project/branch')
4081
        self.assertRaises(errors.ExpandingUnknownOption,
4082
                          stack.get, 'gfoo', expand=True)
4083
4084
    def test_expand_local_option_locally(self):
4085
        l_store = config.LocationStore()
4086
        l_store._load_from_string('''
4087
[/home/user/project]
4088
lfoo = loc-foo/{relpath}
4089
lbar = {gbar}
4090
''')
4091
        l_store.save()
4092
        g_store = config.GlobalStore()
4093
        g_store._load_from_string('''
4094
[DEFAULT]
4095
gfoo = {lfoo}
4096
gbar = glob-bar
4097
''')
4098
        g_store.save()
4099
        stack = config.LocationStack('/home/user/project/branch')
4100
        self.assertEquals('glob-bar', stack.get('lbar', expand=True))
4101
        self.assertEquals('loc-foo/branch', stack.get('gfoo', expand=True))
4102
4103
    def test_locals_dont_leak(self):
4104
        """Make sure we chose the right local in presence of several sections.
4105
        """
4106
        l_store = config.LocationStore()
4107
        l_store._load_from_string('''
4108
[/home/user]
4109
lfoo = loc-foo/{relpath}
4110
[/home/user/project]
4111
lfoo = loc-foo/{relpath}
4112
''')
4113
        l_store.save()
4114
        stack = config.LocationStack('/home/user/project/branch')
4115
        self.assertEquals('loc-foo/branch', stack.get('lfoo', expand=True))
4116
        stack = config.LocationStack('/home/user/bar/baz')
4117
        self.assertEquals('loc-foo/bar/baz', stack.get('lfoo', expand=True))
4118
4119
6270.1.20 by Jelmer Vernooij
Revert RemoteBranchStack / RemoteControlStack changes.
4120
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4121
class TestStackSet(TestStackWithTransport):
4122
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4123
    def test_simple_set(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4124
        conf = self.get_stack(self)
6260.3.2 by Vincent Ladeuil
Only the DEFAULT section is searched for the normal uses of bazaar.conf
4125
        self.assertEquals(None, conf.get('foo'))
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4126
        conf.set('foo', 'baz')
4127
        # Did we get it back ?
4128
        self.assertEquals('baz', conf.get('foo'))
4129
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4130
    def test_set_creates_a_new_section(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4131
        conf = self.get_stack(self)
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4132
        conf.set('foo', 'baz')
5743.1.9 by Vincent Ladeuil
Fix the issue by allowing delayed section acquisition.
4133
        self.assertEquals, 'baz', conf.get('foo')
5743.1.8 by Vincent Ladeuil
Damn, the sections can't be pre-loaded or need to be reloaded on modifications or even better lazily iterated instead.
4134
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4135
    def test_set_hook(self):
4136
        calls = []
4137
        def hook(*args):
4138
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
4139
        config.ConfigHooks.install_named_hook('set', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4140
        self.assertLength(0, calls)
4141
        conf = self.get_stack(self)
4142
        conf.set('foo', 'bar')
4143
        self.assertLength(1, calls)
4144
        self.assertEquals((conf, 'foo', 'bar'), calls[0])
4145
5743.1.7 by Vincent Ladeuil
Simple set implementation.
4146
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4147
class TestStackRemove(TestStackWithTransport):
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4148
4149
    def test_remove_existing(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4150
        conf = self.get_stack(self)
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
4151
        conf.set('foo', 'bar')
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4152
        self.assertEquals('bar', conf.get('foo'))
4153
        conf.remove('foo')
4154
        # Did we get it back ?
4155
        self.assertEquals(None, conf.get('foo'))
4156
4157
    def test_remove_unknown(self):
5743.6.14 by Vincent Ladeuil
Parametrize the Stack tests.
4158
        conf = self.get_stack(self)
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4159
        self.assertRaises(KeyError, conf.remove, 'I_do_not_exist')
4160
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4161
    def test_remove_hook(self):
4162
        calls = []
4163
        def hook(*args):
4164
            calls.append(args)
5743.8.10 by Vincent Ladeuil
We don't need (nor want) to tie the config hooks to a particular class. Especially when we want to use the same hooks on both implementations.
4165
        config.ConfigHooks.install_named_hook('remove', hook, None)
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4166
        self.assertLength(0, calls)
4167
        conf = self.get_stack(self)
6191.3.1 by Vincent Ladeuil
Fix some issues where the config tests were either making a bad use of to the parametrization or asssuming implementation details which are not guaranteed.
4168
        conf.set('foo', 'bar')
5743.8.6 by Vincent Ladeuil
Add hooks for config stacks.
4169
        conf.remove('foo')
4170
        self.assertLength(1, calls)
4171
        self.assertEquals((conf, 'foo'), calls[0])
4172
5743.1.15 by Vincent Ladeuil
Test and implement ConfigStack.remove.
4173
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
4174
class TestConfigGetOptions(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4175
4176
    def setUp(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4177
        super(TestConfigGetOptions, self).setUp()
4178
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4179
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4180
    def test_no_variable(self):
4181
        # Using branch should query branch, locations and bazaar
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4182
        self.assertOptions([], self.branch_config)
4183
4184
    def test_option_in_bazaar(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4185
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4186
        self.assertOptions([('file', 'bazaar', 'DEFAULT', 'bazaar')],
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4187
                           self.bazaar_config)
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4188
4189
    def test_option_in_locations(self):
4190
        self.locations_config.set_user_option('file', 'locations')
4191
        self.assertOptions(
4192
            [('file', 'locations', self.tree.basedir, 'locations')],
4193
            self.locations_config)
4194
4195
    def test_option_in_branch(self):
4196
        self.branch_config.set_user_option('file', 'branch')
4197
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch')],
4198
                           self.branch_config)
4199
4200
    def test_option_in_bazaar_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4201
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4202
        self.branch_config.set_user_option('file', 'branch')
4203
        self.assertOptions([('file', 'branch', 'DEFAULT', 'branch'),
4204
                            ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4205
                           self.branch_config)
4206
4207
    def test_option_in_branch_and_locations(self):
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4208
        # Hmm, locations override branch :-/
4209
        self.locations_config.set_user_option('file', 'locations')
4210
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4211
        self.assertOptions(
4212
            [('file', 'locations', self.tree.basedir, 'locations'),
4213
             ('file', 'branch', 'DEFAULT', 'branch'),],
4214
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4215
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4216
    def test_option_in_bazaar_locations_and_branch(self):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4217
        self.bazaar_config.set_user_option('file', 'bazaar')
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4218
        self.locations_config.set_user_option('file', 'locations')
4219
        self.branch_config.set_user_option('file', 'branch')
5447.4.3 by Vincent Ladeuil
Simplify code and design by only defining get_options() where relevant.
4220
        self.assertOptions(
4221
            [('file', 'locations', self.tree.basedir, 'locations'),
4222
             ('file', 'branch', 'DEFAULT', 'branch'),
4223
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4224
            self.branch_config)
5447.4.1 by Vincent Ladeuil
Implement config.get_options_matching_regexp.
4225
4226
5533.2.1 by Vincent Ladeuil
``bzr config`` properly displays list values
4227
class TestConfigRemoveOption(tests.TestCaseWithTransport, TestOptionsMixin):
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4228
4229
    def setUp(self):
4230
        super(TestConfigRemoveOption, self).setUp()
4231
        create_configs_with_file_option(self)
4232
5447.4.11 by Vincent Ladeuil
Implement ``bzr config --remove <option>``.
4233
    def test_remove_in_locations(self):
4234
        self.locations_config.remove_user_option('file', self.tree.basedir)
4235
        self.assertOptions(
4236
            [('file', 'branch', 'DEFAULT', 'branch'),
4237
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4238
            self.branch_config)
4239
4240
    def test_remove_in_branch(self):
4241
        self.branch_config.remove_user_option('file')
4242
        self.assertOptions(
4243
            [('file', 'locations', self.tree.basedir, 'locations'),
4244
             ('file', 'bazaar', 'DEFAULT', 'bazaar'),],
4245
            self.branch_config)
4246
4247
    def test_remove_in_bazaar(self):
4248
        self.bazaar_config.remove_user_option('file')
4249
        self.assertOptions(
4250
            [('file', 'locations', self.tree.basedir, 'locations'),
4251
             ('file', 'branch', 'DEFAULT', 'branch'),],
4252
            self.branch_config)
4253
5447.4.7 by Vincent Ladeuil
Check error message if the test is checking for errors or we have unexpected success for wrong errors.
4254
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4255
class TestConfigGetSections(tests.TestCaseWithTransport):
4256
4257
    def setUp(self):
4258
        super(TestConfigGetSections, self).setUp()
4259
        create_configs(self)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4260
4261
    def assertSectionNames(self, expected, conf, name=None):
4262
        """Check which sections are returned for a given config.
4263
4264
        If fallback configurations exist their sections can be included.
4265
4266
        :param expected: A list of section names.
4267
4268
        :param conf: The configuration that will be queried.
4269
4270
        :param name: An optional section name that will be passed to
4271
            get_sections().
4272
        """
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
4273
        sections = list(conf._get_sections(name))
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4274
        self.assertLength(len(expected), sections)
5447.4.12 by Vincent Ladeuil
Turn get_options() and get_sections() into private methods because section handling is too messy and needs to be discussed and settled.
4275
        self.assertEqual(expected, [name for name, _, _ in sections])
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4276
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4277
    def test_bazaar_default_section(self):
4278
        self.assertSectionNames(['DEFAULT'], self.bazaar_config)
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4279
4280
    def test_locations_default_section(self):
4281
        # No sections are defined in an empty file
4282
        self.assertSectionNames([], self.locations_config)
4283
4284
    def test_locations_named_section(self):
4285
        self.locations_config.set_user_option('file', 'locations')
4286
        self.assertSectionNames([self.tree.basedir], self.locations_config)
4287
4288
    def test_locations_matching_sections(self):
4289
        loc_config = self.locations_config
4290
        loc_config.set_user_option('file', 'locations')
4291
        # We need to cheat a bit here to create an option in sections above and
4292
        # below the 'location' one.
4293
        parser = loc_config._get_parser()
4294
        # locations.cong deals with '/' ignoring native os.sep
4295
        location_names = self.tree.basedir.split('/')
4296
        parent = '/'.join(location_names[:-1])
4297
        child = '/'.join(location_names + ['child'])
4298
        parser[parent] = {}
4299
        parser[parent]['file'] = 'parent'
4300
        parser[child] = {}
4301
        parser[child]['file'] = 'child'
4302
        self.assertSectionNames([self.tree.basedir, parent], loc_config)
4303
4304
    def test_branch_data_default_section(self):
4305
        self.assertSectionNames([None],
4306
                                self.branch_config._get_branch_data_config())
4307
4308
    def test_branch_default_sections(self):
4309
        # No sections are defined in an empty locations file
4310
        self.assertSectionNames([None, 'DEFAULT'],
4311
                                self.branch_config)
4312
        # Unless we define an option
4313
        self.branch_config._get_location_config().set_user_option(
4314
            'file', 'locations')
4315
        self.assertSectionNames([self.tree.basedir, None, 'DEFAULT'],
4316
                                self.branch_config)
4317
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4318
    def test_bazaar_named_section(self):
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4319
        # We need to cheat as the API doesn't give direct access to sections
4320
        # other than DEFAULT.
5447.4.6 by Vincent Ladeuil
Start defining fixtures but we still have an unexpected sucessful test.
4321
        self.bazaar_config.set_alias('bazaar', 'bzr')
4322
        self.assertSectionNames(['ALIASES'], self.bazaar_config, 'ALIASES')
5447.4.4 by Vincent Ladeuil
Implement config.get_sections() to clarify how sections can be used.
4323
4324
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4325
class TestAuthenticationConfigFile(tests.TestCase):
2900.2.14 by Vincent Ladeuil
More tests.
4326
    """Test the authentication.conf file matching"""
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4327
4328
    def _got_user_passwd(self, expected_user, expected_password,
4329
                         config, *args, **kwargs):
4330
        credentials = config.get_credentials(*args, **kwargs)
4331
        if credentials is None:
4332
            user = None
4333
            password = None
4334
        else:
4335
            user = credentials['user']
4336
            password = credentials['password']
4337
        self.assertEquals(expected_user, user)
4338
        self.assertEquals(expected_password, password)
4339
2978.5.1 by John Arbash Meinel
Fix bug #162494, 'bzr register-branch' needs proper auth handling.
4340
    def test_empty_config(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4341
        conf = config.AuthenticationConfig(_file=StringIO())
4342
        self.assertEquals({}, conf._get_config())
4343
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
4344
5987.1.2 by Vincent Ladeuil
Reproduce bug #502060, bug #688677 and bug #792246.
4345
    def test_non_utf8_config(self):
4346
        conf = config.AuthenticationConfig(_file=StringIO(
4347
                'foo = bar\xff'))
5987.1.3 by Vincent Ladeuil
Proper message when authentication.conf has non-utf8 content
4348
        self.assertRaises(errors.ConfigContentError, conf._get_config)
6059.1.1 by Vincent Ladeuil
Implement from_unicode to convert config option values from store.
4349
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4350
    def test_missing_auth_section_header(self):
4351
        conf = config.AuthenticationConfig(_file=StringIO('foo = bar'))
4352
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
4353
4354
    def test_auth_section_header_not_closed(self):
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4355
        conf = config.AuthenticationConfig(_file=StringIO('[DEF'))
4356
        self.assertRaises(errors.ParseConfigError, conf._get_config)
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4357
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4358
    def test_auth_value_not_boolean(self):
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4359
        conf = config.AuthenticationConfig(_file=StringIO(
4360
                """[broken]
4361
scheme=ftp
4362
user=joe
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4363
verify_certificates=askme # Error: Not a boolean
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4364
"""))
4365
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
3418.2.1 by Vincent Ladeuil
Fix #217650 by catching declarations outside sections.
4366
4367
    def test_auth_value_not_int(self):
2900.2.22 by Vincent Ladeuil
Polishing.
4368
        conf = config.AuthenticationConfig(_file=StringIO(
4369
                """[broken]
4370
scheme=ftp
4371
user=joe
4372
port=port # Error: Not an int
4373
"""))
4374
        self.assertRaises(ValueError, conf.get_credentials, 'ftp', 'foo.net')
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4375
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4376
    def test_unknown_password_encoding(self):
4377
        conf = config.AuthenticationConfig(_file=StringIO(
4378
                """[broken]
4379
scheme=ftp
4380
user=joe
4381
password_encoding=unknown
4382
"""))
4383
        self.assertRaises(ValueError, conf.get_password,
4384
                          'ftp', 'foo.net', 'joe')
4385
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4386
    def test_credentials_for_scheme_host(self):
4387
        conf = config.AuthenticationConfig(_file=StringIO(
4388
                """# Identity on foo.net
4389
[ftp definition]
4390
scheme=ftp
4391
host=foo.net
4392
user=joe
4393
password=secret-pass
4394
"""))
4395
        # Basic matching
4396
        self._got_user_passwd('joe', 'secret-pass', conf, 'ftp', 'foo.net')
4397
        # different scheme
4398
        self._got_user_passwd(None, None, conf, 'http', 'foo.net')
4399
        # different host
4400
        self._got_user_passwd(None, None, conf, 'ftp', 'bar.net')
4401
4402
    def test_credentials_for_host_port(self):
4403
        conf = config.AuthenticationConfig(_file=StringIO(
4404
                """# Identity on foo.net
4405
[ftp definition]
4406
scheme=ftp
4407
port=10021
4408
host=foo.net
4409
user=joe
4410
password=secret-pass
4411
"""))
4412
        # No port
4413
        self._got_user_passwd('joe', 'secret-pass',
4414
                              conf, 'ftp', 'foo.net', port=10021)
4415
        # different port
4416
        self._got_user_passwd(None, None, conf, 'ftp', 'foo.net')
4417
4418
    def test_for_matching_host(self):
4419
        conf = config.AuthenticationConfig(_file=StringIO(
4420
                """# Identity on foo.net
4421
[sourceforge]
4422
scheme=bzr
4423
host=bzr.sf.net
4424
user=joe
4425
password=joepass
4426
[sourceforge domain]
4427
scheme=bzr
4428
host=.bzr.sf.net
4429
user=georges
4430
password=bendover
4431
"""))
4432
        # matching domain
4433
        self._got_user_passwd('georges', 'bendover',
4434
                              conf, 'bzr', 'foo.bzr.sf.net')
4435
        # phishing attempt
4436
        self._got_user_passwd(None, None,
4437
                              conf, 'bzr', 'bbzr.sf.net')
4438
4439
    def test_for_matching_host_None(self):
4440
        conf = config.AuthenticationConfig(_file=StringIO(
4441
                """# Identity on foo.net
4442
[catchup bzr]
4443
scheme=bzr
4444
user=joe
4445
password=joepass
4446
[DEFAULT]
4447
user=georges
4448
password=bendover
4449
"""))
4450
        # match no host
4451
        self._got_user_passwd('joe', 'joepass',
4452
                              conf, 'bzr', 'quux.net')
4453
        # no host but different scheme
4454
        self._got_user_passwd('georges', 'bendover',
4455
                              conf, 'ftp', 'quux.net')
4456
4457
    def test_credentials_for_path(self):
4458
        conf = config.AuthenticationConfig(_file=StringIO(
4459
                """
4460
[http dir1]
4461
scheme=http
4462
host=bar.org
4463
path=/dir1
4464
user=jim
4465
password=jimpass
4466
[http dir2]
4467
scheme=http
4468
host=bar.org
4469
path=/dir2
4470
user=georges
4471
password=bendover
4472
"""))
4473
        # no path no dice
4474
        self._got_user_passwd(None, None,
4475
                              conf, 'http', host='bar.org', path='/dir3')
4476
        # matching path
4477
        self._got_user_passwd('georges', 'bendover',
4478
                              conf, 'http', host='bar.org', path='/dir2')
4479
        # matching subdir
4480
        self._got_user_passwd('jim', 'jimpass',
4481
                              conf, 'http', host='bar.org',path='/dir1/subdir')
4482
4483
    def test_credentials_for_user(self):
4484
        conf = config.AuthenticationConfig(_file=StringIO(
4485
                """
4486
[with user]
4487
scheme=http
4488
host=bar.org
4489
user=jim
4490
password=jimpass
4491
"""))
4492
        # Get user
4493
        self._got_user_passwd('jim', 'jimpass',
4494
                              conf, 'http', 'bar.org')
4495
        # Get same user
4496
        self._got_user_passwd('jim', 'jimpass',
4497
                              conf, 'http', 'bar.org', user='jim')
4498
        # Don't get a different user if one is specified
4499
        self._got_user_passwd(None, None,
4500
                              conf, 'http', 'bar.org', user='georges')
4501
3418.4.1 by Vincent Ladeuil
Reproduce bug 199440.
4502
    def test_credentials_for_user_without_password(self):
4503
        conf = config.AuthenticationConfig(_file=StringIO(
4504
                """
4505
[without password]
4506
scheme=http
4507
host=bar.org
4508
user=jim
4509
"""))
4510
        # Get user but no password
4511
        self._got_user_passwd('jim', None,
4512
                              conf, 'http', 'bar.org')
4513
2900.2.3 by Vincent Ladeuil
Credentials matching implementation.
4514
    def test_verify_certificates(self):
4515
        conf = config.AuthenticationConfig(_file=StringIO(
4516
                """
4517
[self-signed]
4518
scheme=https
4519
host=bar.org
4520
user=jim
4521
password=jimpass
4522
verify_certificates=False
4523
[normal]
4524
scheme=https
4525
host=foo.net
4526
user=georges
4527
password=bendover
4528
"""))
4529
        credentials = conf.get_credentials('https', 'bar.org')
4530
        self.assertEquals(False, credentials.get('verify_certificates'))
4531
        credentials = conf.get_credentials('https', 'foo.net')
4532
        self.assertEquals(True, credentials.get('verify_certificates'))
2900.2.4 by Vincent Ladeuil
Cosmetic changes.
4533
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4534
4535
class TestAuthenticationStorage(tests.TestCaseInTempDir):
4536
3777.1.8 by Aaron Bentley
Commit work-in-progress
4537
    def test_set_credentials(self):
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4538
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4539
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4540
        99, path='/foo', verify_certificates=False, realm='realm')
3777.1.8 by Aaron Bentley
Commit work-in-progress
4541
        credentials = conf.get_credentials(host='host', scheme='scheme',
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4542
                                           port=99, path='/foo',
4543
                                           realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4544
        CREDENTIALS = {'name': 'name', 'user': 'user', 'password': 'password',
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4545
                       'verify_certificates': False, 'scheme': 'scheme', 
4546
                       'host': 'host', 'port': 99, 'path': '/foo', 
4547
                       'realm': 'realm'}
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4548
        self.assertEqual(CREDENTIALS, credentials)
4549
        credentials_from_disk = config.AuthenticationConfig().get_credentials(
4081.1.1 by Jean-Francois Roy
A 'realm' optional argument was added to the get_credentials and set_credentials
4550
            host='host', scheme='scheme', port=99, path='/foo', realm='realm')
3777.1.10 by Aaron Bentley
Ensure credentials are stored
4551
        self.assertEqual(CREDENTIALS, credentials_from_disk)
3777.1.8 by Aaron Bentley
Commit work-in-progress
4552
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4553
    def test_reset_credentials_different_name(self):
4554
        conf = config.AuthenticationConfig()
3777.3.2 by Aaron Bentley
Reverse order of scheme and password
4555
        conf.set_credentials('name', 'host', 'user', 'scheme', 'password'),
4556
        conf.set_credentials('name2', 'host', 'user2', 'scheme', 'password'),
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4557
        self.assertIs(None, conf._get_config().get('name'))
4558
        credentials = conf.get_credentials(host='host', scheme='scheme')
4559
        CREDENTIALS = {'name': 'name2', 'user': 'user2', 'password':
4107.1.8 by Jean-Francois Roy
Updated test_config to account for the new credentials keys.
4560
                       'password', 'verify_certificates': True, 
4561
                       'scheme': 'scheme', 'host': 'host', 'port': None, 
4562
                       'path': None, 'realm': None}
3777.1.11 by Aaron Bentley
Ensure changed-name updates clear old values
4563
        self.assertEqual(CREDENTIALS, credentials)
4564
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4565
2900.2.14 by Vincent Ladeuil
More tests.
4566
class TestAuthenticationConfig(tests.TestCase):
4567
    """Test AuthenticationConfig behaviour"""
4568
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4569
    def _check_default_password_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4570
                                       host=None, port=None, realm=None,
4571
                                       path=None):
2900.2.14 by Vincent Ladeuil
More tests.
4572
        if host is None:
4573
            host = 'bar.org'
4574
        user, password = 'jim', 'precious'
4575
        expected_prompt = expected_prompt_format % {
4576
            'scheme': scheme, 'host': host, 'port': port,
4577
            'user': user, 'realm': realm}
4578
4579
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4580
        stderr = tests.StringIOWrapper()
2900.2.14 by Vincent Ladeuil
More tests.
4581
        ui.ui_factory = tests.TestUIFactory(stdin=password + '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4582
                                            stdout=stdout, stderr=stderr)
2900.2.14 by Vincent Ladeuil
More tests.
4583
        # We use an empty conf so that the user is always prompted
4584
        conf = config.AuthenticationConfig()
4585
        self.assertEquals(password,
4586
                          conf.get_password(scheme, host, user, port=port,
4587
                                            realm=realm, path=path))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4588
        self.assertEquals(expected_prompt, stderr.getvalue())
4589
        self.assertEquals('', stdout.getvalue())
2900.2.14 by Vincent Ladeuil
More tests.
4590
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4591
    def _check_default_username_prompt(self, expected_prompt_format, scheme,
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4592
                                       host=None, port=None, realm=None,
4593
                                       path=None):
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4594
        if host is None:
4595
            host = 'bar.org'
4596
        username = 'jim'
4597
        expected_prompt = expected_prompt_format % {
4598
            'scheme': scheme, 'host': host, 'port': port,
4599
            'realm': realm}
4600
        stdout = tests.StringIOWrapper()
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4601
        stderr = tests.StringIOWrapper()
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4602
        ui.ui_factory = tests.TestUIFactory(stdin=username+ '\n',
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4603
                                            stdout=stdout, stderr=stderr)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4604
        # We use an empty conf so that the user is always prompted
4605
        conf = config.AuthenticationConfig()
4222.3.5 by Jelmer Vernooij
Fix test.
4606
        self.assertEquals(username, conf.get_user(scheme, host, port=port,
4607
                          realm=realm, path=path, ask=True))
4368.3.1 by Vincent Ladeuil
Use stderr for UI prompt to address bug #376582.
4608
        self.assertEquals(expected_prompt, stderr.getvalue())
4609
        self.assertEquals('', stdout.getvalue())
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4610
4611
    def test_username_defaults_prompts(self):
4612
        # HTTP prompts can't be tested here, see test_http.py
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4613
        self._check_default_username_prompt(u'FTP %(host)s username: ', 'ftp')
4614
        self._check_default_username_prompt(
4615
            u'FTP %(host)s:%(port)d username: ', 'ftp', port=10020)
4616
        self._check_default_username_prompt(
4617
            u'SSH %(host)s:%(port)d username: ', 'ssh', port=12345)
4222.3.2 by Jelmer Vernooij
Prompt for user names if they are not in the configuration.
4618
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4619
    def test_username_default_no_prompt(self):
4620
        conf = config.AuthenticationConfig()
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
4621
        self.assertEquals(None,
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4622
            conf.get_user('ftp', 'example.com'))
4304.2.1 by Vincent Ladeuil
Fix bug #367726 by reverting some default user handling introduced
4623
        self.assertEquals("explicitdefault",
4222.3.11 by Jelmer Vernooij
Add test to make sure the default= parameter works.
4624
            conf.get_user('ftp', 'example.com', default="explicitdefault"))
4625
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4626
    def test_password_default_prompts(self):
2900.2.19 by Vincent Ladeuil
Mention proxy and https in the password prompts, with tests.
4627
        # HTTP prompts can't be tested here, see test_http.py
4222.3.1 by Jelmer Vernooij
Mention password when checking default prompt.
4628
        self._check_default_password_prompt(
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4629
            u'FTP %(user)s@%(host)s password: ', 'ftp')
4630
        self._check_default_password_prompt(
4631
            u'FTP %(user)s@%(host)s:%(port)d password: ', 'ftp', port=10020)
4632
        self._check_default_password_prompt(
4633
            u'SSH %(user)s@%(host)s:%(port)d password: ', 'ssh', port=12345)
2900.2.14 by Vincent Ladeuil
More tests.
4634
        # SMTP port handling is a bit special (it's handled if embedded in the
4635
        # host too)
2900.2.22 by Vincent Ladeuil
Polishing.
4636
        # FIXME: should we: forbid that, extend it to other schemes, leave
4637
        # things as they are that's fine thank you ?
5923.1.3 by Vincent Ladeuil
Even more unicode prompts fixes revealed by pqm.
4638
        self._check_default_password_prompt(
4639
            u'SMTP %(user)s@%(host)s password: ', 'smtp')
4640
        self._check_default_password_prompt(
4641
            u'SMTP %(user)s@%(host)s password: ', 'smtp', host='bar.org:10025')
4642
        self._check_default_password_prompt(
4643
            u'SMTP %(user)s@%(host)s:%(port)d password: ', 'smtp', port=10025)
2900.2.14 by Vincent Ladeuil
More tests.
4644
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4645
    def test_ssh_password_emits_warning(self):
4646
        conf = config.AuthenticationConfig(_file=StringIO(
4647
                """
4648
[ssh with password]
4649
scheme=ssh
4650
host=bar.org
4651
user=jim
4652
password=jimpass
4653
"""))
4654
        entered_password = 'typed-by-hand'
4655
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4656
        stderr = tests.StringIOWrapper()
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4657
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4658
                                            stdout=stdout, stderr=stderr)
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4659
4660
        # Since the password defined in the authentication config is ignored,
4661
        # the user is prompted
4662
        self.assertEquals(entered_password,
4663
                          conf.get_password('ssh', 'bar.org', user='jim'))
4664
        self.assertContainsRe(
4794.1.17 by Robert Collins
Fix from vila for type log_log.
4665
            self.get_log(),
3420.1.2 by Vincent Ladeuil
Fix bug #203186 by ignoring passwords for ssh and warning user.
4666
            'password ignored in section \[ssh with password\]')
4667
3420.1.3 by Vincent Ladeuil
John's review feedback.
4668
    def test_ssh_without_password_doesnt_emit_warning(self):
4669
        conf = config.AuthenticationConfig(_file=StringIO(
4670
                """
4671
[ssh with password]
4672
scheme=ssh
4673
host=bar.org
4674
user=jim
4675
"""))
4676
        entered_password = 'typed-by-hand'
4677
        stdout = tests.StringIOWrapper()
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4678
        stderr = tests.StringIOWrapper()
3420.1.3 by Vincent Ladeuil
John's review feedback.
4679
        ui.ui_factory = tests.TestUIFactory(stdin=entered_password + '\n',
4449.3.30 by Martin Pool
Tweaks to test_config ui factory use
4680
                                            stdout=stdout,
4681
                                            stderr=stderr)
3420.1.3 by Vincent Ladeuil
John's review feedback.
4682
4683
        # Since the password defined in the authentication config is ignored,
4684
        # the user is prompted
4685
        self.assertEquals(entered_password,
4686
                          conf.get_password('ssh', 'bar.org', user='jim'))
3420.1.4 by Vincent Ladeuil
Fix comment.
4687
        # No warning shoud be emitted since there is no password. We are only
4688
        # providing "user".
3420.1.3 by Vincent Ladeuil
John's review feedback.
4689
        self.assertNotContainsRe(
4794.1.15 by Robert Collins
Review feedback.
4690
            self.get_log(),
3420.1.3 by Vincent Ladeuil
John's review feedback.
4691
            'password ignored in section \[ssh with password\]')
4692
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4693
    def test_uses_fallback_stores(self):
4985.1.5 by Vincent Ladeuil
Deploying the new overrideAttr facility further reduces the complexity
4694
        self.overrideAttr(config, 'credential_store_registry',
4695
                          config.CredentialStoreRegistry())
4283.1.3 by Jelmer Vernooij
Add test to make sure AuthenticationConfig queries for fallback credentials.
4696
        store = StubCredentialStore()
4697
        store.add_credentials("http", "example.com", "joe", "secret")
4698
        config.credential_store_registry.register("stub", store, fallback=True)
4699
        conf = config.AuthenticationConfig(_file=StringIO())
4700
        creds = conf.get_credentials("http", "example.com")
4701
        self.assertEquals("joe", creds["user"])
4702
        self.assertEquals("secret", creds["password"])
4703
2900.2.14 by Vincent Ladeuil
More tests.
4704
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4705
class StubCredentialStore(config.CredentialStore):
4706
4707
    def __init__(self):
4708
        self._username = {}
4709
        self._password = {}
4710
4711
    def add_credentials(self, scheme, host, user, password=None):
4712
        self._username[(scheme, host)] = user
4713
        self._password[(scheme, host)] = password
4714
4715
    def get_credentials(self, scheme, host, port=None, user=None,
4716
        path=None, realm=None):
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4717
        key = (scheme, host)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4718
        if not key in self._username:
4719
            return None
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4720
        return { "scheme": scheme, "host": host, "port": port,
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4721
                "user": self._username[key], "password": self._password[key]}
4722
4723
4724
class CountingCredentialStore(config.CredentialStore):
4725
4726
    def __init__(self):
4727
        self._calls = 0
4728
4729
    def get_credentials(self, scheme, host, port=None, user=None,
4730
        path=None, realm=None):
4731
        self._calls += 1
4732
        return None
4733
4734
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4735
class TestCredentialStoreRegistry(tests.TestCase):
4736
4737
    def _get_cs_registry(self):
4738
        return config.credential_store_registry
4739
4740
    def test_default_credential_store(self):
4741
        r = self._get_cs_registry()
4742
        default = r.get_credential_store(None)
4743
        self.assertIsInstance(default, config.PlainTextCredentialStore)
4744
4745
    def test_unknown_credential_store(self):
4746
        r = self._get_cs_registry()
4747
        # It's hard to imagine someone creating a credential store named
4748
        # 'unknown' so we use that as an never registered key.
4749
        self.assertRaises(KeyError, r.get_credential_store, 'unknown')
4750
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4751
    def test_fallback_none_registered(self):
4752
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4753
        self.assertEquals(None,
4754
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4755
4756
    def test_register(self):
4757
        r = config.CredentialStoreRegistry()
4758
        r.register("stub", StubCredentialStore(), fallback=False)
4759
        r.register("another", StubCredentialStore(), fallback=True)
4760
        self.assertEquals(["another", "stub"], r.keys())
4761
4762
    def test_register_lazy(self):
4763
        r = config.CredentialStoreRegistry()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4764
        r.register_lazy("stub", "bzrlib.tests.test_config",
4765
                        "StubCredentialStore", fallback=False)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4766
        self.assertEquals(["stub"], r.keys())
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4767
        self.assertIsInstance(r.get_credential_store("stub"),
4768
                              StubCredentialStore)
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4769
4770
    def test_is_fallback(self):
4771
        r = config.CredentialStoreRegistry()
4772
        r.register("stub1", None, fallback=False)
4773
        r.register("stub2", None, fallback=True)
4774
        self.assertEquals(False, r.is_fallback("stub1"))
4775
        self.assertEquals(True, r.is_fallback("stub2"))
4776
4777
    def test_no_fallback(self):
4778
        r = config.CredentialStoreRegistry()
4779
        store = CountingCredentialStore()
4780
        r.register("count", store, fallback=False)
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4781
        self.assertEquals(None,
4782
                          r.get_fallback_credentials("http", "example.com"))
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4783
        self.assertEquals(0, store._calls)
4784
4785
    def test_fallback_credentials(self):
4786
        r = config.CredentialStoreRegistry()
4787
        store = StubCredentialStore()
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4788
        store.add_credentials("http", "example.com",
4789
                              "somebody", "geheim")
4283.1.2 by Jelmer Vernooij
Add tests, NEWS item.
4790
        r.register("stub", store, fallback=True)
4791
        creds = r.get_fallback_credentials("http", "example.com")
4792
        self.assertEquals("somebody", creds["user"])
4793
        self.assertEquals("geheim", creds["password"])
4794
4283.2.1 by Vincent Ladeuil
Add a test and cleanup some PEP8 issues.
4795
    def test_fallback_first_wins(self):
4796
        r = config.CredentialStoreRegistry()
4797
        stub1 = StubCredentialStore()
4798
        stub1.add_credentials("http", "example.com",
4799
                              "somebody", "stub1")
4800
        r.register("stub1", stub1, fallback=True)
4801
        stub2 = StubCredentialStore()
4802
        stub2.add_credentials("http", "example.com",
4803
                              "somebody", "stub2")
4804
        r.register("stub2", stub1, fallback=True)
4805
        creds = r.get_fallback_credentials("http", "example.com")
4806
        self.assertEquals("somebody", creds["user"])
4807
        self.assertEquals("stub1", creds["password"])
4808
3757.3.1 by Vincent Ladeuil
Add credential stores plugging.
4809
4810
class TestPlainTextCredentialStore(tests.TestCase):
4811
4812
    def test_decode_password(self):
4813
        r = config.credential_store_registry
4814
        plain_text = r.get_credential_store()
4815
        decoded = plain_text.decode_password(dict(password='secret'))
4816
        self.assertEquals('secret', decoded)
4817
4818
2900.2.14 by Vincent Ladeuil
More tests.
4819
# FIXME: Once we have a way to declare authentication to all test servers, we
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4820
# can implement generic tests.
2900.2.15 by Vincent Ladeuil
AuthenticationConfig can be queried for logins too (first step).
4821
# test_user_password_in_url
4822
# test_user_in_url_password_from_config
4823
# test_user_in_url_password_prompted
4824
# test_user_in_config
4825
# test_user_getpass.getuser
4826
# test_user_prompted ?
2900.2.5 by Vincent Ladeuil
ake ftp aware of authentication config.
4827
class TestAuthenticationRing(tests.TestCaseWithTransport):
4828
    pass
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4829
4830
4831
class TestAutoUserId(tests.TestCase):
4832
    """Test inferring an automatic user name."""
4833
4834
    def test_auto_user_id(self):
4835
        """Automatic inference of user name.
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4836
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4837
        This is a bit hard to test in an isolated way, because it depends on
4838
        system functions that go direct to /etc or perhaps somewhere else.
4839
        But it's reasonable to say that on Unix, with an /etc/mailname, we ought
4840
        to be able to choose a user name with no configuration.
4841
        """
4842
        if sys.platform == 'win32':
5743.8.17 by Vincent Ladeuil
Add config old_get hook for remote config.
4843
            raise tests.TestSkipped(
4844
                "User name inference not implemented on win32")
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4845
        realname, address = config._auto_user_id()
4846
        if os.path.exists('/etc/mailname'):
5813.1.1 by Jelmer Vernooij
Allow realname to be empty in tests.
4847
            self.assertIsNot(None, realname)
4848
            self.assertIsNot(None, address)
5050.72.1 by Martin Pool
Set email address from /etc/mailname if possible
4849
        else:
4850
            self.assertEquals((None, None), (realname, address))
4851
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4852
4853
class EmailOptionTests(tests.TestCase):
4854
4855
    def test_default_email_uses_BZR_EMAIL(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4856
        conf = config.MemoryStack('email=jelmer@debian.org')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4857
        # BZR_EMAIL takes precedence over EMAIL
4858
        self.overrideEnv('BZR_EMAIL', 'jelmer@samba.org')
4859
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4860
        self.assertEquals('jelmer@samba.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4861
4862
    def test_default_email_uses_EMAIL(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4863
        conf = config.MemoryStack('')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4864
        self.overrideEnv('BZR_EMAIL', None)
4865
        self.overrideEnv('EMAIL', 'jelmer@apache.org')
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4866
        self.assertEquals('jelmer@apache.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4867
4868
    def test_BZR_EMAIL_overrides(self):
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4869
        conf = config.MemoryStack('email=jelmer@debian.org')
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4870
        self.overrideEnv('BZR_EMAIL', 'jelmer@apache.org')
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4871
        self.assertEquals('jelmer@apache.org', conf.get('email'))
6374.1.3 by Jelmer Vernooij
Add tests for default_email behaviour.
4872
        self.overrideEnv('BZR_EMAIL', None)
4873
        self.overrideEnv('EMAIL', 'jelmer@samba.org')
6393.3.3 by Vincent Ladeuil
Add Option.override_from_env allowing environ variables to override config settings
4874
        self.assertEquals('jelmer@debian.org', conf.get('email'))
6449.5.6 by Jelmer Vernooij
Port mail client tests to config stacks.
4875
4876
4877
class MailClientOptionTests(tests.TestCase):
4878
4879
    def test_default(self):
4880
        conf = config.MemoryStack('')
4881
        client = conf.get('mail_client')
4882
        self.assertIs(client, mail_client.DefaultMail)
4883
4884
    def test_evolution(self):
4885
        conf = config.MemoryStack('mail_client=evolution')
4886
        client = conf.get('mail_client')
4887
        self.assertIs(client, mail_client.Evolution)
4888
4889
    def test_kmail(self):
4890
        conf = config.MemoryStack('mail_client=kmail')
4891
        client = conf.get('mail_client')
4892
        self.assertIs(client, mail_client.KMail)
4893
4894
    def test_mutt(self):
4895
        conf = config.MemoryStack('mail_client=mutt')
4896
        client = conf.get('mail_client')
4897
        self.assertIs(client, mail_client.Mutt)
4898
4899
    def test_thunderbird(self):
4900
        conf = config.MemoryStack('mail_client=thunderbird')
4901
        client = conf.get('mail_client')
4902
        self.assertIs(client, mail_client.Thunderbird)
4903
4904
    def test_explicit_default(self):
4905
        conf = config.MemoryStack('mail_client=default')
4906
        client = conf.get('mail_client')
4907
        self.assertIs(client, mail_client.DefaultMail)
4908
4909
    def test_editor(self):
4910
        conf = config.MemoryStack('mail_client=editor')
4911
        client = conf.get('mail_client')
4912
        self.assertIs(client, mail_client.Editor)
4913
4914
    def test_mapi(self):
4915
        conf = config.MemoryStack('mail_client=mapi')
4916
        client = conf.get('mail_client')
4917
        self.assertIs(client, mail_client.MAPIClient)
4918
4919
    def test_xdg_email(self):
4920
        conf = config.MemoryStack('mail_client=xdg-email')
4921
        client = conf.get('mail_client')
4922
        self.assertIs(client, mail_client.XDGEmail)
4923
4924
    def test_unknown(self):
4925
        conf = config.MemoryStack('mail_client=firebird')
4926
        self.assertRaises(errors.ConfigOptionValueError, conf.get,
4927
                'mail_client')