/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
57
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
58
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
59
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
60
from .branch import Branch
61
from .cleanup import OperationWithCleanups
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
62
import breezy.config
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
63
from .errors import (BzrError, PointlessCommit,
64
                     ConflictsInTree,
65
                     StrictCommitFailed
66
                     )
67
from .osutils import (get_user_encoding,
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      splitpath,
71
                      )
72
from .trace import mutter, note, is_quiet
6670.4.1 by Jelmer Vernooij
Update imports.
73
from .bzr.inventory import Inventory, InventoryEntry, make_entry
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
74
from .urlutils import unescape_for_display
75
from .i18n import gettext
76
1189 by Martin Pool
- BROKEN: partial support for commit into weave
77
78
class NullCommitReporter(object):
79
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
80
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
81
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
82
        pass
83
84
    def snapshot_change(self, change, path):
85
        pass
86
87
    def completed(self, revno, rev_id):
88
        pass
89
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
90
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
91
        pass
92
93
    def missing(self, path):
94
        pass
95
96
    def renamed(self, change, old_path, new_path):
97
        pass
98
2789.2.11 by Ian Clatworthy
remove more reporting stuff
99
    def is_verbose(self):
100
        return False
101
102
103
class ReportCommitToLog(NullCommitReporter):
104
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
105
    def _note(self, format, *args):
106
        """Output a message.
107
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
108
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
109
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
110
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
111
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
112
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
113
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
114
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
115
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
116
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
117
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
118
        self._note(
119
            gettext('Committing to: %s'),
120
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
121
122
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
123
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
124
        # self._note goes to the console too; so while we want to log the
125
        # rev_id, we can't trivially only log it. (See bug 526425). Long
126
        # term we should rearrange the reporting structure, but for now
127
        # we just mutter seperately. We mutter the revid and revno together
128
        # so that concurrent bzr invocations won't lead to confusion.
129
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
130
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
131
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
132
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
133
134
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
135
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
136
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
137
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
138
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
139
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
140
    def is_verbose(self):
141
        return True
142
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
143
1189 by Martin Pool
- BROKEN: partial support for commit into weave
144
class Commit(object):
145
    """Task of committing a new revision.
146
147
    This is a MethodObject: it accumulates state as the commit is
148
    prepared, and then it is discarded.  It doesn't represent
149
    historical revisions, just the act of recording a new one.
150
151
            missing_ids
152
            Modified to hold a list of files that have been deleted from
153
            the working directory; these should be removed from the
154
            working inventory.
485 by Martin Pool
- move commit code into its own module
155
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
156
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
157
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
158
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
159
        """Create a Commit object.
160
161
        :param reporter: the default reporter to use or None to decide later
162
        """
163
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
164
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
165
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
166
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
167
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
168
                        local=False, possible_master_transports=None):
169
        if revprops is None:
170
            revprops = {}
171
        if possible_master_transports is None:
172
            possible_master_transports = []
173
        if not 'branch-nick' in revprops:
174
            revprops['branch-nick'] = branch._get_nick(
175
                local,
176
                possible_master_transports)
177
        if authors is not None:
178
            if 'author' in revprops or 'authors' in revprops:
179
                # XXX: maybe we should just accept one of them?
180
                raise AssertionError('author property given twice')
181
            if authors:
182
                for individual in authors:
183
                    if '\n' in individual:
184
                        raise AssertionError('\\n is not a valid character '
185
                                'in an author identity')
186
                revprops['authors'] = '\n'.join(authors)
187
        return revprops
188
1189 by Martin Pool
- BROKEN: partial support for commit into weave
189
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
190
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
191
               timestamp=None,
192
               timezone=None,
193
               committer=None,
194
               specific_files=None,
195
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
196
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
197
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
198
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
199
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
200
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
201
               local=False,
202
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
203
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
204
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
205
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
206
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
207
               possible_master_transports=None,
208
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
209
        """Commit working copy as a new revision.
210
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
211
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
212
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
213
214
        :param timestamp: if not None, seconds-since-epoch for a
215
            postdated/predated commit.
216
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
217
        :param specific_files: If not None, commit only those files. An empty
218
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
219
220
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
221
            Useful for test or import commands that need to tightly
222
            control what revisions are assigned.  If you duplicate
223
            a revision id that exists elsewhere it is your own fault.
224
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
225
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
226
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
227
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
228
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
229
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
230
            contains unknown files.
231
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
232
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
233
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
234
        :param reporter: the reporter to use or None for the default
235
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
236
        :param recursive: If set to 'down', commit in any subtrees that have
237
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
238
        :param exclude: None or a list of relative paths to exclude from the
239
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
240
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
241
        :param lossy: When committing to a foreign VCS, ignore any
242
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
243
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
244
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
245
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
246
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
247
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
248
        return operation.run(
249
               message=message,
250
               timestamp=timestamp,
251
               timezone=timezone,
252
               committer=committer,
253
               specific_files=specific_files,
254
               rev_id=rev_id,
255
               allow_pointless=allow_pointless,
256
               strict=strict,
257
               verbose=verbose,
258
               working_tree=working_tree,
259
               local=local,
260
               reporter=reporter,
261
               message_callback=message_callback,
262
               recursive=recursive,
263
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
264
               possible_master_transports=possible_master_transports,
265
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
266
267
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
268
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
269
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
270
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
271
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
272
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
273
        if working_tree is None:
274
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
275
        else:
276
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
277
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
278
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
279
                if not self.branch.repository.supports_rich_root():
280
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
281
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
282
            if message is not None:
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
283
                if isinstance(message, bytes):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
284
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
285
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
286
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
287
                raise BzrError("The message or message_callback keyword"
288
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
289
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
290
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
291
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
292
        if exclude is not None:
293
            self.exclude = sorted(
294
                minimum_path_selection(exclude))
295
        else:
296
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
297
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
298
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
299
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
300
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
301
        # self.specific_files is None to indicate no filter, or any iterable to
302
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
303
        if specific_files is not None:
304
            self.specific_files = sorted(
305
                minimum_path_selection(specific_files))
306
        else:
307
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
308
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
309
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
310
        self.message_callback = message_callback
311
        self.timestamp = timestamp
312
        self.timezone = timezone
313
        self.committer = committer
314
        self.strict = strict
315
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
316
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
317
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
318
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
319
        self.parents = self.work_tree.get_parent_ids()
320
        # We can use record_iter_changes IFF iter_changes is compatible with
321
        # the command line parameters, and the repository has fast delta
322
        # generation. See bug 347649.
323
        self.use_record_iter_changes = (
324
            not self.exclude and 
325
            not self.branch.repository._format.supports_tree_reference and
4183.5.8 by Robert Collins
Correct logic for detecting when to use record_iter_changes in commit.
326
            (self.branch.repository._format.fast_deltas or
327
             len(self.parents) < 2))
5582.10.6 by Jelmer Vernooij
Fix ui imports.
328
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
329
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
330
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
331
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
332
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
333
        operation.add_cleanup(self.basis_tree.unlock)
334
        # Cannot commit with conflicts present.
335
        if len(self.work_tree.conflicts()) > 0:
336
            raise ConflictsInTree
337
338
        # Setup the bound branch variables as needed.
339
        self._check_bound_branch(operation, possible_master_transports)
340
341
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
342
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
343
344
        # Complete configuration setup
345
        if reporter is not None:
346
            self.reporter = reporter
347
        elif self.reporter is None:
348
            self.reporter = self._select_reporter()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
349
        if self.config_stack is None:
6449.6.4 by Jelmer Vernooij
Use config stack.
350
            self.config_stack = self.work_tree.get_config_stack()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
351
352
        self._set_specific_file_ids()
353
354
        # Setup the progress bar. As the number of files that need to be
355
        # committed in unknown, progress is reported as stages.
356
        # We keep track of entries separately though and include that
357
        # information in the progress bar during the relevant stages.
358
        self.pb_stage_name = ""
359
        self.pb_stage_count = 0
360
        self.pb_stage_total = 5
361
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
362
            # 2 extra stages: "Uploading data to master branch" and "Merging
363
            # tags to master branch"
364
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
365
        self.pb.show_pct = False
366
        self.pb.show_spinner = False
367
        self.pb.show_eta = False
368
        self.pb.show_count = True
369
        self.pb.show_bar = True
370
371
        self._gather_parents()
372
        # After a merge, a selected file commit is not supported.
373
        # See 'bzr help merge' for an explanation as to why.
374
        if len(self.parents) > 1 and self.specific_files is not None:
375
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
376
        # Excludes are a form of selected file commit.
377
        if len(self.parents) > 1 and self.exclude:
378
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
379
380
        # Collect the changes
381
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
382
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
383
        self.builder = self.branch.get_commit_builder(self.parents,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
384
            self.config_stack, timestamp, timezone, committer, self.revprops,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
385
            rev_id, lossy=lossy)
5718.4.9 by Jelmer Vernooij
Fix logic for raising ExcludesUnsupported exception. It's a pity we have no record-iter-changes-only formats in bzr.dev.
386
        if not self.builder.supports_record_entry_contents and self.exclude:
5718.4.5 by Jelmer Vernooij
Move ExcludesUnsupported raise location.
387
            self.builder.abort()
388
            raise errors.ExcludesUnsupported(self.branch.repository)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
389
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
390
        if self.builder.updates_branch and self.bound_branch:
391
            self.builder.abort()
392
            raise AssertionError(
393
                "bound branches not supported for commit builders "
394
                "that update the branch")
395
1189 by Martin Pool
- BROKEN: partial support for commit into weave
396
        try:
5718.4.8 by Jelmer Vernooij
Revert conditional will_record_deletes.
397
            self.builder.will_record_deletes()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
398
            # find the location being committed to
399
            if self.bound_branch:
400
                master_location = self.master_branch.base
401
            else:
402
                master_location = self.branch.base
403
404
            # report the start of the commit
405
            self.reporter.started(new_revno, self.rev_id, master_location)
406
407
            self._update_builder_with_changes()
408
            self._check_pointless()
409
410
            # TODO: Now the new inventory is known, check for conflicts.
411
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
412
            # weave lines, because nothing should be recorded until it is known
413
            # that commit will succeed.
414
            self._set_progress_stage("Saving data locally")
415
            self.builder.finish_inventory()
416
417
            # Prompt the user for a commit message if none provided
418
            message = message_callback(self)
419
            self.message = message
420
421
            # Add revision data to the local branch
422
            self.rev_id = self.builder.commit(self.message)
423
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
424
        except Exception as e:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
425
            mutter("aborting commit write group because of exception:")
426
            trace.log_exception_quietly()
427
            self.builder.abort()
428
            raise
429
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
430
        self._update_branches(old_revno, old_revid, new_revno)
431
432
        # Make the working tree be up to date with the branch. This
433
        # includes automatic changes scheduled to be made to the tree, such
434
        # as updating its basis and unversioning paths that were missing.
435
        self.work_tree.unversion(self.deleted_ids)
436
        self._set_progress_stage("Updating the working tree")
437
        self.work_tree.update_basis_by_delta(self.rev_id,
438
             self.builder.get_basis_delta())
439
        self.reporter.completed(new_revno, self.rev_id)
440
        self._process_post_hooks(old_revno, new_revno)
441
        return self.rev_id
442
443
    def _update_branches(self, old_revno, old_revid, new_revno):
444
        """Update the master and local branch to the new revision.
445
446
        This will try to make sure that the master branch is updated
447
        before the local branch.
448
449
        :param old_revno: Revision number of master branch before the
450
            commit
451
        :param old_revid: Tip of master branch before the commit
452
        :param new_revno: Revision number of the new commit
453
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
454
        if not self.builder.updates_branch:
455
            self._process_pre_hooks(old_revno, new_revno)
456
457
            # Upload revision data to the master.
458
            # this will propagate merged revisions too if needed.
459
            if self.bound_branch:
460
                self._set_progress_stage("Uploading data to master branch")
461
                # 'commit' to the master first so a timeout here causes the
462
                # local branch to be out of date
463
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
464
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
465
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
466
                    self.branch.fetch(self.master_branch, self.rev_id)
467
468
            # and now do the commit locally.
469
            self.branch.set_last_revision_info(new_revno, self.rev_id)
470
        else:
471
            try:
472
                self._process_pre_hooks(old_revno, new_revno)
473
            except:
474
                # The commit builder will already have updated the branch,
475
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
476
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
477
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
478
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
479
        # Merge local tags to remote
480
        if self.bound_branch:
481
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
482
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
483
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
484
            if tag_conflicts:
485
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
6138.3.5 by Jonathan Riddell
make the test suite pass
486
                note( gettext("Conflicting tags in bound branch:\n{0}".format(
487
                    "\n".join(warning_lines))) )
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
488
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
489
    def _select_reporter(self):
490
        """Select the CommitReporter to use."""
491
        if is_quiet():
492
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
493
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
494
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
495
    def _check_pointless(self):
496
        if self.allow_pointless:
497
            return
498
        # A merge with no effect on files
499
        if len(self.parents) > 1:
500
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
501
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
502
            return
503
        raise PointlessCommit()
504
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
505
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
506
        """Check to see if the local branch is bound.
507
508
        If it is bound, then most of the commit will actually be
509
        done using the remote branch as the target branch.
510
        Only at the end will the local branch be updated.
511
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
512
        if self.local and not self.branch.get_bound_location():
513
            raise errors.LocalRequiresBoundBranch()
514
515
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
516
            self.master_branch = self.branch.get_master_branch(
517
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
518
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
519
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
520
            # make this branch the reference branch for out of date checks.
521
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
522
            return
523
524
        # If the master branch is bound, we must fail
525
        master_bound_location = self.master_branch.get_bound_location()
526
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
527
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
528
                    self.master_branch, master_bound_location)
529
530
        # TODO: jam 20051230 We could automatically push local
531
        #       commits to the remote branch if they would fit.
532
        #       But for now, just require remote to be identical
533
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
534
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
535
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
536
        master_info = self.master_branch.last_revision_info()
537
        local_info = self.branch.last_revision_info()
538
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
539
            raise errors.BoundBranchOutOfDate(self.branch,
540
                    self.master_branch)
541
542
        # Now things are ready to change the master branch
543
        # so grab the lock
544
        self.bound_branch = self.branch
545
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
546
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
547
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
548
    def _check_out_of_date_tree(self):
549
        """Check that the working tree is up to date.
550
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
551
        :return: old_revision_number, old_revision_id, new_revision_number
552
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
553
        """
554
        try:
555
            first_tree_parent = self.work_tree.get_parent_ids()[0]
556
        except IndexError:
557
            # if there are no parents, treat our parent as 'None'
558
            # this is so that we still consider the master branch
559
            # - in a checkout scenario the tree may have no
560
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
561
            first_tree_parent = breezy.revision.NULL_REVISION
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
562
        old_revno, master_last = self.master_branch.last_revision_info()
563
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
564
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
565
                raise errors.OutOfDateTree(self.work_tree)
566
        if self.branch.repository.has_revision(first_tree_parent):
567
            new_revno = old_revno + 1
568
        else:
569
            # ghost parents never appear in revision history.
570
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
571
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
572
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
573
    def _process_pre_hooks(self, old_revno, new_revno):
574
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
575
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
576
        self._process_hooks("pre_commit", old_revno, new_revno)
577
578
    def _process_post_hooks(self, old_revno, new_revno):
579
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
580
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
581
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
582
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
583
        # 0.15^H^H^H^H 2.5.0)
584
        post_commit = self.config_stack.get('post_commit')
585
        if post_commit is not None:
586
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
587
            # this would be nicer with twisted.python.reflect.namedAny
588
            for hook in hooks:
589
                result = eval(hook + '(branch, rev_id)',
590
                              {'branch':self.branch,
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
591
                               'breezy':breezy,
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
592
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
593
        # process new style post commit hooks
594
        self._process_hooks("post_commit", old_revno, new_revno)
595
596
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
597
        if not Branch.hooks[hook_name]:
598
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
599
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
600
        # new style commit hooks:
601
        if not self.bound_branch:
602
            hook_master = self.branch
603
            hook_local = None
604
        else:
605
            hook_master = self.master_branch
606
            hook_local = self.branch
607
        # With bound branches, when the master is behind the local branch,
608
        # the 'old_revno' and old_revid values here are incorrect.
609
        # XXX: FIXME ^. RBC 20060206
610
        if self.parents:
611
            old_revid = self.parents[0]
612
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
613
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
614
2659.3.9 by NamNguyen
branch.py:
615
        if hook_name == "pre_commit":
616
            future_tree = self.builder.revision_tree()
617
            tree_delta = future_tree.changes_from(self.basis_tree,
618
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
619
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
620
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
621
            # show the running hook in the progress bar. As hooks may
622
            # end up doing nothing (e.g. because they are not configured by
623
            # the user) this is still showing progress, not showing overall
624
            # actions - its up to each plugin to show a UI if it want's to
625
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
626
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
627
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
628
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
629
            if 'hooks' in debug.debug_flags:
630
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
631
            if hook_name == "post_commit":
632
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
633
                     self.rev_id)
634
            elif hook_name == "pre_commit":
635
                hook(hook_local, hook_master,
636
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
637
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
638
1223 by Martin Pool
- store inventories in weave
639
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
640
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
641
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
642
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
643
        if self.use_record_iter_changes:
644
            return
6405.2.5 by Jelmer Vernooij
Add root_inventory.
645
        self.basis_inv = self.basis_tree.root_inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
646
        self.parent_invs = [self.basis_inv]
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
647
        for revision in self.parents[1:]:
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
648
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
649
                mutter('commit parent revision {%s}', revision)
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
650
                inventory = self.branch.repository.get_inventory(revision)
651
                self.parent_invs.append(inventory)
652
            else:
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
653
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
654
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
655
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
656
        """Update the commit builder with the data about what has changed.
657
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
658
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
659
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
660
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
661
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
662
        self._check_strict()
663
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
664
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
665
                specific_files=specific_files)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
666
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
667
            for file_id, path, fs_hash in self.builder.record_iter_changes(
668
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
669
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
670
        else:
671
            # Build the new inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
672
            self._populate_from_inventory()
673
            self._record_unselected()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
674
            self._report_and_accumulate_deletes()
675
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
676
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
677
        """Process iter_changes.
678
679
        This method reports on the changes in iter_changes to the user, and 
680
        converts 'missing' entries in the iter_changes iterator to 'deleted'
681
        entries. 'missing' entries have their
682
683
        :param iter_changes: An iter_changes to process.
684
        :return: A generator of changes.
685
        """
686
        reporter = self.reporter
687
        report_changes = reporter.is_verbose()
688
        deleted_ids = []
689
        for change in iter_changes:
690
            if report_changes:
691
                old_path = change[1][0]
692
                new_path = change[1][1]
693
                versioned = change[3][1]
694
            kind = change[6][1]
695
            versioned = change[3][1]
696
            if kind is None and versioned:
697
                # 'missing' path
698
                if report_changes:
699
                    reporter.missing(new_path)
700
                deleted_ids.append(change[0])
701
                # Reset the new path (None) and new versioned flag (False)
702
                change = (change[0], (change[1][0], None), change[2],
703
                    (change[3][0], False)) + change[4:]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
704
                new_path = change[1][1]
705
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
706
            elif kind == 'tree-reference':
707
                if self.recursive == 'down':
708
                    self._commit_nested_tree(change[0], change[1][1])
709
            if change[3][0] or change[3][1]:
710
                yield change
711
                if report_changes:
712
                    if new_path is None:
713
                        reporter.deleted(old_path)
714
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
715
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
716
                    elif old_path != new_path:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
717
                        reporter.renamed(gettext('renamed'), old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
718
                    else:
719
                        if (new_path or 
720
                            self.work_tree.branch.repository._format.rich_root_data):
721
                            # Don't report on changes to '' in non rich root
722
                            # repositories.
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
723
                            reporter.snapshot_change(gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
724
            self._next_progress_entry()
725
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
726
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
727
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
728
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
729
        # If specific files are selected, then all un-selected files must be
730
        # recorded in their previous state. For more details, see
731
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
732
        if self.specific_files or self.exclude:
733
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
734
            for path, old_ie in self.basis_inv.iter_entries():
5967.7.1 by Martin Pool
Deprecate __contains__ on Tree and Inventory
735
                if self.builder.new_inventory.has_id(old_ie.file_id):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
736
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
737
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
738
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
739
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
740
                    # was inside the selected path, and not excluded - if not
741
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
742
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
743
                # From here down it was either not selected, or was excluded:
744
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
745
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
746
                # Note: specific file commits after a merge are currently
747
                # prohibited. This test is for sanity/safety in case it's
748
                # required after that changes.
749
                if len(self.parents) > 1:
750
                    ie.revision = None
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
751
                self.builder.record_entry_contents(ie, self.parent_invs, path,
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
752
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
753
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
754
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
755
        if (isinstance(self.basis_inv, Inventory)
756
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
757
            # the older Inventory classes provide a _byid dict, and building a
758
            # set from the keys of this dict is substantially faster than even
759
            # getting a set of ids from the inventory
760
            #
761
            # <lifeless> set(dict) is roughly the same speed as
762
            # set(iter(dict)) and both are significantly slower than
763
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
764
            deleted_ids = set(self.basis_inv._byid.keys()) - \
765
               set(self.builder.new_inventory._byid.keys())
766
        else:
767
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
768
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
769
            self.any_entries_deleted = True
6619.3.18 by Jelmer Vernooij
Run 2to3 idioms fixer.
770
            deleted = sorted([(self.basis_tree.id2path(file_id), file_id)
771
                for file_id in deleted_ids])
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
772
            # XXX: this is not quite directory-order sorting
773
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
774
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
775
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
776
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
777
    def _check_strict(self):
778
        # XXX: when we use iter_changes this would likely be faster if
779
        # iter_changes would check for us (even in the presence of
780
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
781
        if self.strict:
782
            # raise an exception as soon as we find a single unknown.
783
            for unknown in self.work_tree.unknowns():
784
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
785
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
786
    def _populate_from_inventory(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
787
        """Populate the CommitBuilder by walking the working tree inventory."""
788
        # Build the revision inventory.
789
        #
790
        # This starts by creating a new empty inventory. Depending on
791
        # which files are selected for commit, and what is present in the
792
        # current tree, the new inventory is populated. inventory entries
793
        # which are candidates for modification have their revision set to
794
        # None; inventory entries that are carried over untouched have their
795
        # revision set to their prior value.
796
        #
797
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
798
        # results to create a new inventory at the same time, which results
799
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
800
        # ADHB 11-07-2006
801
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
802
        specific_files = self.specific_files
803
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
804
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
805
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
806
        # A tree of paths that have been deleted. E.g. if foo/bar has been
807
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
808
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
809
        # XXX: Note that entries may have the wrong kind because the entry does
810
        # not reflect the status on disk.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
811
        # NB: entries will include entries within the excluded ids/paths
812
        # because iter_entries_by_dir has no 'exclude' facility today.
6468.2.7 by Jelmer Vernooij
Use .iter_entries_by_dir.
813
        entries = self.work_tree.iter_entries_by_dir(
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
814
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
815
        for path, existing_ie in entries:
816
            file_id = existing_ie.file_id
817
            name = existing_ie.name
818
            parent_id = existing_ie.parent_id
819
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
820
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
821
            # The deleted path ids are also recorded so they can be explicitly
822
            # unversioned later.
823
            if deleted_paths:
824
                path_segments = splitpath(path)
825
                deleted_dict = deleted_paths
826
                for segment in path_segments:
827
                    deleted_dict = deleted_dict.get(segment, None)
828
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
829
                        # We either took a path not present in the dict
830
                        # (deleted_dict was None), or we've reached an empty
831
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
832
                        break
833
                else:
834
                    deleted_dict = None
835
                if deleted_dict is not None:
836
                    # the path has a deleted parent, do not add it.
837
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
838
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
839
                # Skip excluded paths. Excluded paths are processed by
840
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
841
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
842
            content_summary = self.work_tree.path_content_summary(path)
843
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
844
            # Note that when a filter of specific files is given, we must only
845
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
846
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
847
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
848
                    if not deleted_paths:
849
                        # path won't have been split yet.
850
                        path_segments = splitpath(path)
851
                    deleted_dict = deleted_paths
852
                    for segment in path_segments:
853
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
854
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
855
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
856
                    deleted_ids.append(file_id)
857
                    continue
4595.11.14 by Martin Pool
Small code cleanups
858
            # TODO: have the builder do the nested commit just-in-time IF and
859
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
860
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
861
                # enforce repository nested tree policy.
862
                if (not self.work_tree.supports_tree_reference() or
863
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
864
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
865
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
866
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
867
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
868
                    nested_revision_id = self._commit_nested_tree(
869
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
870
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
871
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
872
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
873
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
874
875
            # Record an entry for this item
876
            # Note: I don't particularly want to have the existing_ie
877
            # parameter but the test suite currently (28-Jun-07) breaks
878
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
879
            definitely_changed = kind != existing_ie.kind
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
880
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
881
                parent_id, definitely_changed, existing_ie, report_changes,
882
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
883
884
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
885
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
886
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
887
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
888
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
889
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
890
        # FIXME: be more comprehensive here:
891
        # this works when both trees are in --trees repository,
892
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
893
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
894
        # finally implement the explicit-caches approach design
895
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
896
        if sub_tree.branch.repository.has_same_location(
897
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
898
            sub_tree.branch.repository = \
899
                self.work_tree.branch.repository
900
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
901
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
902
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
903
                message_callback=self.message_callback,
904
                timestamp=self.timestamp, timezone=self.timezone,
905
                committer=self.committer,
906
                allow_pointless=self.allow_pointless,
907
                strict=self.strict, verbose=self.verbose,
908
                local=self.local, reporter=self.reporter)
909
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
910
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
911
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
912
    def _record_entry(self, path, file_id, specific_files, kind, name,
913
        parent_id, definitely_changed, existing_ie, report_changes,
914
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
915
        "Record the new inventory entry for a path if any."
916
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
917
        # mutter('%s selected for commit', path)
918
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
919
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
920
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
921
            ie = existing_ie.copy()
922
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
923
        # For carried over entries we don't care about the fs hash - the repo
924
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
925
        _, _, fs_hash = self.builder.record_entry_contents(
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
926
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
927
        if report_changes:
928
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
929
        if fs_hash:
930
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
931
        return ie
932
933
    def _report_change(self, ie, path):
934
        """Report a change to the user.
935
936
        The change that has occurred is described relative to the basis
937
        inventory.
938
        """
939
        if (self.basis_inv.has_id(ie.file_id)):
940
            basis_ie = self.basis_inv[ie.file_id]
941
        else:
942
            basis_ie = None
943
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
944
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
945
            InventoryEntry.MODIFIED_AND_RENAMED):
946
            old_path = self.basis_inv.id2path(ie.file_id)
947
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
948
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
949
        else:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
950
            if change == gettext('unchanged'):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
951
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
952
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
953
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
954
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
955
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
956
        """Set the progress stage and emit an update to the progress bar."""
957
        self.pb_stage_name = name
958
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
959
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
960
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
961
        else:
962
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
963
        self._emit_progress()
964
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
965
    def _next_progress_entry(self):
966
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
967
        self.pb_entries_count += 1
968
        self._emit_progress()
969
970
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
971
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
972
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
973
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
974
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
975
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
976
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
977
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
978
    def _set_specific_file_ids(self):
979
        """populate self.specific_file_ids if we will use it."""
980
        if not self.use_record_iter_changes:
981
            # If provided, ensure the specified files are versioned
982
            if self.specific_files is not None:
983
                # Note: This routine is being called because it raises
984
                # PathNotVersionedError as a side effect of finding the IDs. We
985
                # later use the ids we found as input to the working tree
986
                # inventory iterator, so we only consider those ids rather than
987
                # examining the whole tree again.
988
                # XXX: Dont we have filter_unversioned to do this more
989
                # cheaply?
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
990
                self.specific_file_ids = tree.find_ids_across_trees(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
991
                    self.specific_files, [self.basis_tree, self.work_tree])
992
            else:
993
                self.specific_file_ids = None