bzr branch
http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11
by John Arbash Meinel
Remove extra pdb stuff |
1 |
# Copyright (C) 2005-2011 Canonical Ltd
|
1887.1.1
by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines, |
2 |
#
|
485
by Martin Pool
- move commit code into its own module |
3 |
# This program is free software; you can redistribute it and/or modify
|
4 |
# it under the terms of the GNU General Public License as published by
|
|
5 |
# the Free Software Foundation; either version 2 of the License, or
|
|
6 |
# (at your option) any later version.
|
|
1248
by Martin Pool
- new weave based cleanup [broken] |
7 |
#
|
485
by Martin Pool
- move commit code into its own module |
8 |
# This program is distributed in the hope that it will be useful,
|
9 |
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
10 |
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
11 |
# GNU General Public License for more details.
|
|
1248
by Martin Pool
- new weave based cleanup [broken] |
12 |
#
|
485
by Martin Pool
- move commit code into its own module |
13 |
# You should have received a copy of the GNU General Public License
|
14 |
# along with this program; if not, write to the Free Software
|
|
4183.7.1
by Sabin Iacob
update FSF mailing address |
15 |
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
485
by Martin Pool
- move commit code into its own module |
16 |
|
6379.6.1
by Jelmer Vernooij
Import absolute_import in a few places. |
17 |
from __future__ import absolute_import |
485
by Martin Pool
- move commit code into its own module |
18 |
|
2921.4.6
by Robert Collins
Typos found by Rob Weir. |
19 |
# The newly committed revision is going to have a shape corresponding
|
2921.4.4
by Robert Collins
Minor import cleanup in commit.py. |
20 |
# to that of the working tree. Files that are not in the
|
1248
by Martin Pool
- new weave based cleanup [broken] |
21 |
# working tree and that were in the predecessor are reported as
|
22 |
# removed --- this can include files that were either removed from the
|
|
23 |
# inventory or deleted in the working tree. If they were only
|
|
24 |
# deleted from disk, they are removed from the working inventory.
|
|
25 |
||
26 |
# We then consider the remaining entries, which will be in the new
|
|
27 |
# version. Directory entries are simply copied across. File entries
|
|
28 |
# must be checked to see if a new version of the file should be
|
|
2921.4.4
by Robert Collins
Minor import cleanup in commit.py. |
29 |
# recorded. For each parent revision tree, we check to see what
|
1248
by Martin Pool
- new weave based cleanup [broken] |
30 |
# version of the file was present. If the file was present in at
|
31 |
# least one tree, and if it was the same version in all the trees,
|
|
32 |
# then we can just refer to that version. Otherwise, a new version
|
|
33 |
# representing the merger of the file versions must be added.
|
|
34 |
||
35 |
# TODO: Update hashcache before and after - or does the WorkingTree
|
|
36 |
# look after that?
|
|
1245
by Martin Pool
doc |
37 |
|
1339
by Martin Pool
- doc |
38 |
# TODO: Rather than mashing together the ancestry and storing it back,
|
39 |
# perhaps the weave should have single method which does it all in one
|
|
40 |
# go, avoiding a lot of redundant work.
|
|
1335
by Martin Pool
doc |
41 |
|
1341
by Martin Pool
- doc |
42 |
# TODO: Perhaps give a warning if one of the revisions marked as
|
43 |
# merged is already in the ancestry, and then don't record it as a
|
|
44 |
# distinct parent.
|
|
45 |
||
1343
by Martin Pool
- fix up test for merge of trees |
46 |
# TODO: If the file is newly merged but unchanged from the version it
|
47 |
# merges from, then it should still be reported as newly added
|
|
48 |
# relative to the basis revision.
|
|
49 |
||
1910.7.17
by Andrew Bennetts
Various cosmetic changes. |
50 |
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
|
51 |
# the rest of the code; add a deprecation of the old name.
|
|
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
52 |
|
6624
by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes') |
53 |
from . import ( |
2560.1.4
by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged. |
54 |
debug, |
1551.8.30
by Aaron Bentley
Tweak from review comments |
55 |
errors, |
3830.3.3
by Martin Pool
commit should log original exception when aborting write group |
56 |
trace, |
5856.1.4
by Jelmer Vernooij
Revert unnecessary change. |
57 |
tree, |
5582.10.6
by Jelmer Vernooij
Fix ui imports. |
58 |
ui, |
1551.8.30
by Aaron Bentley
Tweak from review comments |
59 |
)
|
6624
by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes') |
60 |
from .branch import Branch |
61 |
from .cleanup import OperationWithCleanups |
|
6622.1.34
by Jelmer Vernooij
Rename brzlib => breezy. |
62 |
import breezy.config |
6624
by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes') |
63 |
from .errors import (BzrError, PointlessCommit, |
64 |
ConflictsInTree, |
|
65 |
StrictCommitFailed
|
|
66 |
)
|
|
67 |
from .osutils import (get_user_encoding, |
|
68 |
is_inside_any, |
|
69 |
minimum_path_selection, |
|
70 |
splitpath, |
|
71 |
)
|
|
72 |
from .trace import mutter, note, is_quiet |
|
6670.4.1
by Jelmer Vernooij
Update imports. |
73 |
from .bzr.inventory import Inventory, InventoryEntry, make_entry |
6624
by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes') |
74 |
from .urlutils import unescape_for_display |
75 |
from .i18n import gettext |
|
76 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
77 |
|
6699.1.1
by Jelmer Vernooij
Support excludes with "bzr commit -x". |
78 |
def filter_excluded(iter_changes, exclude): |
79 |
"""Filter exclude filenames. |
|
80 |
||
81 |
:param iter_changes: iter_changes function
|
|
82 |
:param exclude: List of paths to exclude
|
|
83 |
:return: iter_changes function
|
|
84 |
"""
|
|
85 |
for change in iter_changes: |
|
86 |
old_path = change[1][0] |
|
87 |
new_path = change[1][1] |
|
88 |
||
89 |
new_excluded = (new_path is not None and |
|
90 |
is_inside_any(exclude, new_path)) |
|
91 |
||
92 |
old_excluded = (old_path is not None and |
|
93 |
is_inside_any(exclude, old_path)) |
|
94 |
||
95 |
if old_excluded and new_excluded: |
|
96 |
continue
|
|
97 |
||
98 |
if old_excluded or new_excluded: |
|
99 |
# TODO(jelmer): Perhaps raise an error here instead?
|
|
100 |
continue
|
|
101 |
||
102 |
yield change |
|
103 |
||
104 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
105 |
class NullCommitReporter(object): |
106 |
"""I report on progress of a commit.""" |
|
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
107 |
|
6630.1.1
by Jelmer Vernooij
Remove deprecated functionality. |
108 |
def started(self, revno, revid, location): |
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
109 |
pass
|
110 |
||
111 |
def snapshot_change(self, change, path): |
|
112 |
pass
|
|
113 |
||
114 |
def completed(self, revno, rev_id): |
|
115 |
pass
|
|
116 |
||
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
117 |
def deleted(self, path): |
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
118 |
pass
|
119 |
||
120 |
def missing(self, path): |
|
121 |
pass
|
|
122 |
||
123 |
def renamed(self, change, old_path, new_path): |
|
124 |
pass
|
|
125 |
||
2789.2.11
by Ian Clatworthy
remove more reporting stuff |
126 |
def is_verbose(self): |
127 |
return False |
|
128 |
||
129 |
||
130 |
class ReportCommitToLog(NullCommitReporter): |
|
131 |
||
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
132 |
def _note(self, format, *args): |
133 |
"""Output a message. |
|
134 |
||
2522.2.3
by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930) |
135 |
Subclasses may choose to override this method.
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
136 |
"""
|
2522.2.3
by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930) |
137 |
note(format, *args) |
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
138 |
|
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
139 |
def snapshot_change(self, change, path): |
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
140 |
if path == '' and change in (gettext('added'), gettext('modified')): |
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
141 |
return
|
2789.2.11
by Ian Clatworthy
remove more reporting stuff |
142 |
self._note("%s %s", change, path) |
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
143 |
|
6630.1.3
by Jelmer Vernooij
Make location argument non-optional. |
144 |
def started(self, revno, rev_id, location): |
6630.1.1
by Jelmer Vernooij
Remove deprecated functionality. |
145 |
self._note( |
146 |
gettext('Committing to: %s'), |
|
147 |
unescape_for_display(location, 'utf-8')) |
|
2747.6.5
by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it. |
148 |
|
149 |
def completed(self, revno, rev_id): |
|
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
150 |
self._note(gettext('Committed revision %d.'), revno) |
5086.6.2
by Robert Collins
Log revision id as well as revno when committing. |
151 |
# self._note goes to the console too; so while we want to log the
|
152 |
# rev_id, we can't trivially only log it. (See bug 526425). Long
|
|
153 |
# term we should rearrange the reporting structure, but for now
|
|
154 |
# we just mutter seperately. We mutter the revid and revno together
|
|
155 |
# so that concurrent bzr invocations won't lead to confusion.
|
|
156 |
mutter('Committed revid %s as revno %d.', rev_id, revno) |
|
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
157 |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
158 |
def deleted(self, path): |
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
159 |
self._note(gettext('deleted %s'), path) |
1185.12.8
by Aaron Bentley
Fixed commit so all output comes though CommitReporter |
160 |
|
161 |
def missing(self, path): |
|
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
162 |
self._note(gettext('missing %s'), path) |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
163 |
|
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
164 |
def renamed(self, change, old_path, new_path): |
2789.2.11
by Ian Clatworthy
remove more reporting stuff |
165 |
self._note('%s %s => %s', change, old_path, new_path) |
1668.1.5
by Martin Pool
[broken] fix up display of files changed by a commit |
166 |
|
2789.2.1
by Ian Clatworthy
Make commit less verbose by default |
167 |
def is_verbose(self): |
168 |
return True |
|
169 |
||
1508.1.6
by Robert Collins
Move Branch.unknowns() to WorkingTree. |
170 |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
171 |
class Commit(object): |
172 |
"""Task of committing a new revision. |
|
173 |
||
174 |
This is a MethodObject: it accumulates state as the commit is
|
|
175 |
prepared, and then it is discarded. It doesn't represent
|
|
176 |
historical revisions, just the act of recording a new one.
|
|
177 |
||
178 |
missing_ids
|
|
179 |
Modified to hold a list of files that have been deleted from
|
|
180 |
the working directory; these should be removed from the
|
|
181 |
working inventory.
|
|
485
by Martin Pool
- move commit code into its own module |
182 |
"""
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
183 |
def __init__(self, |
1442.1.60
by Robert Collins
gpg sign commits if the policy says we need to |
184 |
reporter=None, |
6351.3.2
by Jelmer Vernooij
Convert some gpg options to config stacks. |
185 |
config_stack=None): |
2789.2.1
by Ian Clatworthy
Make commit less verbose by default |
186 |
"""Create a Commit object. |
187 |
||
188 |
:param reporter: the default reporter to use or None to decide later
|
|
189 |
"""
|
|
190 |
self.reporter = reporter |
|
6351.3.2
by Jelmer Vernooij
Convert some gpg options to config stacks. |
191 |
self.config_stack = config_stack |
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
192 |
|
5162.4.1
by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick. |
193 |
@staticmethod
|
6630.1.1
by Jelmer Vernooij
Remove deprecated functionality. |
194 |
def update_revprops(revprops, branch, authors=None, |
5162.4.1
by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick. |
195 |
local=False, possible_master_transports=None): |
196 |
if revprops is None: |
|
197 |
revprops = {} |
|
198 |
if possible_master_transports is None: |
|
199 |
possible_master_transports = [] |
|
200 |
if not 'branch-nick' in revprops: |
|
201 |
revprops['branch-nick'] = branch._get_nick( |
|
202 |
local, |
|
203 |
possible_master_transports) |
|
204 |
if authors is not None: |
|
205 |
if 'author' in revprops or 'authors' in revprops: |
|
206 |
# XXX: maybe we should just accept one of them?
|
|
207 |
raise AssertionError('author property given twice') |
|
208 |
if authors: |
|
209 |
for individual in authors: |
|
210 |
if '\n' in individual: |
|
211 |
raise AssertionError('\\n is not a valid character ' |
|
212 |
'in an author identity') |
|
213 |
revprops['authors'] = '\n'.join(authors) |
|
214 |
return revprops |
|
215 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
216 |
def commit(self, |
2367.2.1
by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins) |
217 |
message=None, |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
218 |
timestamp=None, |
219 |
timezone=None, |
|
220 |
committer=None, |
|
221 |
specific_files=None, |
|
222 |
rev_id=None, |
|
1276
by Martin Pool
- make Branch.commit accept (and ignore) verbose argument |
223 |
allow_pointless=True, |
1185.16.65
by mbp at sourcefrog
- new commit --strict option |
224 |
strict=False, |
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
225 |
verbose=False, |
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
226 |
revprops=None, |
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
227 |
working_tree=None, |
1607.1.5
by Robert Collins
Make commit verbose mode work!. |
228 |
local=False, |
229 |
reporter=None, |
|
2149.1.1
by Aaron Bentley
Provide a message_callback parameter to tree.commit |
230 |
config=None, |
2255.2.218
by Robert Collins
Make the nested tree commit smoke test be more rigourous. |
231 |
message_callback=None, |
3602.1.1
by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins) |
232 |
recursive='down', |
3565.6.9
by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch. |
233 |
exclude=None, |
5777.6.1
by Jelmer Vernooij
Add --lossy option to 'bzr commit'. |
234 |
possible_master_transports=None, |
235 |
lossy=False): |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
236 |
"""Commit working copy as a new revision. |
237 |
||
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
238 |
:param message: the commit message (it or message_callback is required)
|
4536.3.1
by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402) |
239 |
:param message_callback: A callback: message = message_callback(cmt_obj)
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
240 |
|
241 |
:param timestamp: if not None, seconds-since-epoch for a
|
|
242 |
postdated/predated commit.
|
|
243 |
||
4570.4.3
by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit. |
244 |
:param specific_files: If not None, commit only those files. An empty
|
245 |
list means 'commit no files'.
|
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
246 |
|
247 |
:param rev_id: If set, use this as the new revision id.
|
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
248 |
Useful for test or import commands that need to tightly
|
249 |
control what revisions are assigned. If you duplicate
|
|
250 |
a revision id that exists elsewhere it is your own fault.
|
|
251 |
If null (default), a time/random revision id is generated.
|
|
1253
by Martin Pool
- test that pointless commits are trapped |
252 |
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
253 |
:param allow_pointless: If true (default), commit even if nothing
|
1253
by Martin Pool
- test that pointless commits are trapped |
254 |
has changed and no merges are recorded.
|
1185.16.35
by Martin Pool
- stub for revision properties |
255 |
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
256 |
:param strict: If true, don't allow a commit if the working tree
|
1185.16.65
by mbp at sourcefrog
- new commit --strict option |
257 |
contains unknown files.
|
258 |
||
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
259 |
:param revprops: Properties for new revision
|
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
260 |
:param local: Perform a local only commit.
|
2789.2.1
by Ian Clatworthy
Make commit less verbose by default |
261 |
:param reporter: the reporter to use or None for the default
|
262 |
:param verbose: if True and the reporter is not None, report everything
|
|
2255.2.218
by Robert Collins
Make the nested tree commit smoke test be more rigourous. |
263 |
:param recursive: If set to 'down', commit in any subtrees that have
|
264 |
pending changes of any sort during this commit.
|
|
3602.1.1
by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins) |
265 |
:param exclude: None or a list of relative paths to exclude from the
|
266 |
commit. Pending changes to excluded files will be ignored by the
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
267 |
commit.
|
5777.6.1
by Jelmer Vernooij
Add --lossy option to 'bzr commit'. |
268 |
:param lossy: When committing to a foreign VCS, ignore any
|
269 |
data that can not be natively represented.
|
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
270 |
"""
|
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
271 |
operation = OperationWithCleanups(self._commit) |
5086.6.1
by Robert Collins
Minor commit tidyup in preparation for hooking around revprops. |
272 |
self.revprops = revprops or {} |
5141.1.1
by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in |
273 |
# XXX: Can be set on __init__ or passed in - this is a bit ugly.
|
6351.3.2
by Jelmer Vernooij
Convert some gpg options to config stacks. |
274 |
self.config_stack = config or self.config_stack |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
275 |
return operation.run( |
276 |
message=message, |
|
277 |
timestamp=timestamp, |
|
278 |
timezone=timezone, |
|
279 |
committer=committer, |
|
280 |
specific_files=specific_files, |
|
281 |
rev_id=rev_id, |
|
282 |
allow_pointless=allow_pointless, |
|
283 |
strict=strict, |
|
284 |
verbose=verbose, |
|
285 |
working_tree=working_tree, |
|
286 |
local=local, |
|
287 |
reporter=reporter, |
|
288 |
message_callback=message_callback, |
|
289 |
recursive=recursive, |
|
290 |
exclude=exclude, |
|
5777.6.1
by Jelmer Vernooij
Add --lossy option to 'bzr commit'. |
291 |
possible_master_transports=possible_master_transports, |
292 |
lossy=lossy) |
|
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
293 |
|
294 |
def _commit(self, operation, message, timestamp, timezone, committer, |
|
5086.6.1
by Robert Collins
Minor commit tidyup in preparation for hooking around revprops. |
295 |
specific_files, rev_id, allow_pointless, strict, verbose, |
5141.1.1
by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in |
296 |
working_tree, local, reporter, message_callback, recursive, |
5777.6.1
by Jelmer Vernooij
Add --lossy option to 'bzr commit'. |
297 |
exclude, possible_master_transports, lossy): |
1285
by Martin Pool
- fix bug in committing files that are renamed but not modified |
298 |
mutter('preparing to commit') |
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
299 |
|
2367.2.1
by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins) |
300 |
if working_tree is None: |
301 |
raise BzrError("working_tree must be passed into commit().") |
|
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
302 |
else: |
303 |
self.work_tree = working_tree |
|
4354.4.4
by Aaron Bentley
Simplify by using CommitBuilder directly |
304 |
self.branch = self.work_tree.branch |
2100.3.14
by Aaron Bentley
Test workingtree4 format, prevent use with old repos |
305 |
if getattr(self.work_tree, 'requires_rich_root', lambda: False)(): |
306 |
if not self.branch.repository.supports_rich_root(): |
|
307 |
raise errors.RootNotRich() |
|
2149.1.1
by Aaron Bentley
Provide a message_callback parameter to tree.commit |
308 |
if message_callback is None: |
2149.1.3
by Aaron Bentley
Updates from review comments |
309 |
if message is not None: |
6684.1.3
by Martin
Changes across many modules working towards Python 3 support |
310 |
if isinstance(message, bytes): |
3224.5.1
by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop. |
311 |
message = message.decode(get_user_encoding()) |
2149.1.3
by Aaron Bentley
Updates from review comments |
312 |
message_callback = lambda x: message |
2149.1.1
by Aaron Bentley
Provide a message_callback parameter to tree.commit |
313 |
else: |
2149.1.3
by Aaron Bentley
Updates from review comments |
314 |
raise BzrError("The message or message_callback keyword" |
315 |
" parameter is required for commit().") |
|
1534.4.25
by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite. |
316 |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
317 |
self.bound_branch = None |
2840.1.1
by Ian Clatworthy
faster pointless commit detection (Robert Collins) |
318 |
self.any_entries_deleted = False |
3602.1.1
by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins) |
319 |
if exclude is not None: |
320 |
self.exclude = sorted( |
|
321 |
minimum_path_selection(exclude)) |
|
322 |
else: |
|
323 |
self.exclude = [] |
|
1587.1.9
by Robert Collins
Local commits do no alter or access the master branch. |
324 |
self.local = local |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
325 |
self.master_branch = None |
2776.4.15
by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder. |
326 |
self.recursive = recursive |
1740.3.10
by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m. |
327 |
self.rev_id = None |
4570.4.3
by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit. |
328 |
# self.specific_files is None to indicate no filter, or any iterable to
|
329 |
# indicate a filter - [] means no files at all, as per iter_changes.
|
|
2843.1.1
by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins) |
330 |
if specific_files is not None: |
331 |
self.specific_files = sorted( |
|
332 |
minimum_path_selection(specific_files)) |
|
333 |
else: |
|
334 |
self.specific_files = None |
|
5718.4.1
by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents. |
335 |
|
1194
by Martin Pool
- [BROKEN] more progress of commit into weaves |
336 |
self.allow_pointless = allow_pointless |
2255.2.218
by Robert Collins
Make the nested tree commit smoke test be more rigourous. |
337 |
self.message_callback = message_callback |
338 |
self.timestamp = timestamp |
|
339 |
self.timezone = timezone |
|
340 |
self.committer = committer |
|
341 |
self.strict = strict |
|
342 |
self.verbose = verbose |
|
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
343 |
|
4354.4.4
by Aaron Bentley
Simplify by using CommitBuilder directly |
344 |
self.work_tree.lock_write() |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
345 |
operation.add_cleanup(self.work_tree.unlock) |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
346 |
self.parents = self.work_tree.get_parent_ids() |
5582.10.6
by Jelmer Vernooij
Fix ui imports. |
347 |
self.pb = ui.ui_factory.nested_progress_bar() |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
348 |
operation.add_cleanup(self.pb.finished) |
2921.4.1
by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory. |
349 |
self.basis_revid = self.work_tree.last_revision() |
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
350 |
self.basis_tree = self.work_tree.basis_tree() |
2255.2.25
by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree |
351 |
self.basis_tree.lock_read() |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
352 |
operation.add_cleanup(self.basis_tree.unlock) |
353 |
# Cannot commit with conflicts present.
|
|
354 |
if len(self.work_tree.conflicts()) > 0: |
|
355 |
raise ConflictsInTree |
|
356 |
||
357 |
# Setup the bound branch variables as needed.
|
|
358 |
self._check_bound_branch(operation, possible_master_transports) |
|
359 |
||
360 |
# Check that the working tree is up to date
|
|
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
361 |
old_revno, old_revid, new_revno = self._check_out_of_date_tree() |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
362 |
|
363 |
# Complete configuration setup
|
|
364 |
if reporter is not None: |
|
365 |
self.reporter = reporter |
|
366 |
elif self.reporter is None: |
|
367 |
self.reporter = self._select_reporter() |
|
6351.3.2
by Jelmer Vernooij
Convert some gpg options to config stacks. |
368 |
if self.config_stack is None: |
6449.6.4
by Jelmer Vernooij
Use config stack. |
369 |
self.config_stack = self.work_tree.get_config_stack() |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
370 |
|
371 |
# Setup the progress bar. As the number of files that need to be
|
|
372 |
# committed in unknown, progress is reported as stages.
|
|
373 |
# We keep track of entries separately though and include that
|
|
374 |
# information in the progress bar during the relevant stages.
|
|
375 |
self.pb_stage_name = "" |
|
376 |
self.pb_stage_count = 0 |
|
377 |
self.pb_stage_total = 5 |
|
378 |
if self.bound_branch: |
|
5050.52.3
by Andrew Bennetts
Merge tags from local to master when committing in a bound branch. |
379 |
# 2 extra stages: "Uploading data to master branch" and "Merging
|
380 |
# tags to master branch"
|
|
381 |
self.pb_stage_total += 2 |
|
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
382 |
self.pb.show_pct = False |
383 |
self.pb.show_spinner = False |
|
384 |
self.pb.show_eta = False |
|
385 |
self.pb.show_count = True |
|
386 |
self.pb.show_bar = True |
|
387 |
||
388 |
# After a merge, a selected file commit is not supported.
|
|
389 |
# See 'bzr help merge' for an explanation as to why.
|
|
390 |
if len(self.parents) > 1 and self.specific_files is not None: |
|
391 |
raise errors.CannotCommitSelectedFileMerge(self.specific_files) |
|
392 |
# Excludes are a form of selected file commit.
|
|
393 |
if len(self.parents) > 1 and self.exclude: |
|
394 |
raise errors.CannotCommitSelectedFileMerge(self.exclude) |
|
395 |
||
396 |
# Collect the changes
|
|
397 |
self._set_progress_stage("Collecting changes", counter=True) |
|
5777.6.5
by Jelmer Vernooij
Add tests for lossy commit. |
398 |
self._lossy = lossy |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
399 |
self.builder = self.branch.get_commit_builder(self.parents, |
6351.3.2
by Jelmer Vernooij
Convert some gpg options to config stacks. |
400 |
self.config_stack, timestamp, timezone, committer, self.revprops, |
5777.6.1
by Jelmer Vernooij
Add --lossy option to 'bzr commit'. |
401 |
rev_id, lossy=lossy) |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
402 |
|
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
403 |
if self.builder.updates_branch and self.bound_branch: |
404 |
self.builder.abort() |
|
405 |
raise AssertionError( |
|
406 |
"bound branches not supported for commit builders "
|
|
407 |
"that update the branch") |
|
408 |
||
1189
by Martin Pool
- BROKEN: partial support for commit into weave |
409 |
try: |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
410 |
# find the location being committed to
|
411 |
if self.bound_branch: |
|
412 |
master_location = self.master_branch.base |
|
413 |
else: |
|
414 |
master_location = self.branch.base |
|
415 |
||
416 |
# report the start of the commit
|
|
417 |
self.reporter.started(new_revno, self.rev_id, master_location) |
|
418 |
||
419 |
self._update_builder_with_changes() |
|
420 |
self._check_pointless() |
|
421 |
||
422 |
# TODO: Now the new inventory is known, check for conflicts.
|
|
423 |
# ADHB 2006-08-08: If this is done, populate_new_inv should not add
|
|
424 |
# weave lines, because nothing should be recorded until it is known
|
|
425 |
# that commit will succeed.
|
|
426 |
self._set_progress_stage("Saving data locally") |
|
427 |
self.builder.finish_inventory() |
|
428 |
||
429 |
# Prompt the user for a commit message if none provided
|
|
430 |
message = message_callback(self) |
|
431 |
self.message = message |
|
432 |
||
433 |
# Add revision data to the local branch
|
|
434 |
self.rev_id = self.builder.commit(self.message) |
|
435 |
||
6619.3.2
by Jelmer Vernooij
Apply 2to3 except fix. |
436 |
except Exception as e: |
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
437 |
mutter("aborting commit write group because of exception:") |
438 |
trace.log_exception_quietly() |
|
439 |
self.builder.abort() |
|
440 |
raise
|
|
441 |
||
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
442 |
self._update_branches(old_revno, old_revid, new_revno) |
443 |
||
444 |
# Make the working tree be up to date with the branch. This
|
|
445 |
# includes automatic changes scheduled to be made to the tree, such
|
|
446 |
# as updating its basis and unversioning paths that were missing.
|
|
447 |
self.work_tree.unversion(self.deleted_ids) |
|
448 |
self._set_progress_stage("Updating the working tree") |
|
449 |
self.work_tree.update_basis_by_delta(self.rev_id, |
|
450 |
self.builder.get_basis_delta()) |
|
451 |
self.reporter.completed(new_revno, self.rev_id) |
|
452 |
self._process_post_hooks(old_revno, new_revno) |
|
453 |
return self.rev_id |
|
454 |
||
455 |
def _update_branches(self, old_revno, old_revid, new_revno): |
|
456 |
"""Update the master and local branch to the new revision. |
|
457 |
||
458 |
This will try to make sure that the master branch is updated
|
|
459 |
before the local branch.
|
|
460 |
||
461 |
:param old_revno: Revision number of master branch before the
|
|
462 |
commit
|
|
463 |
:param old_revid: Tip of master branch before the commit
|
|
464 |
:param new_revno: Revision number of the new commit
|
|
465 |
"""
|
|
6217.5.1
by Jelmer Vernooij
Add CommitBuilder.updates_branch. |
466 |
if not self.builder.updates_branch: |
467 |
self._process_pre_hooks(old_revno, new_revno) |
|
468 |
||
469 |
# Upload revision data to the master.
|
|
470 |
# this will propagate merged revisions too if needed.
|
|
471 |
if self.bound_branch: |
|
472 |
self._set_progress_stage("Uploading data to master branch") |
|
473 |
# 'commit' to the master first so a timeout here causes the
|
|
474 |
# local branch to be out of date
|
|
475 |
(new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags( |
|
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
476 |
self.branch, new_revno, self.rev_id, lossy=self._lossy) |
477 |
if self._lossy: |
|
6217.5.1
by Jelmer Vernooij
Add CommitBuilder.updates_branch. |
478 |
self.branch.fetch(self.master_branch, self.rev_id) |
479 |
||
480 |
# and now do the commit locally.
|
|
481 |
self.branch.set_last_revision_info(new_revno, self.rev_id) |
|
482 |
else: |
|
483 |
try: |
|
484 |
self._process_pre_hooks(old_revno, new_revno) |
|
485 |
except: |
|
486 |
# The commit builder will already have updated the branch,
|
|
487 |
# revert it.
|
|
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
488 |
self.branch.set_last_revision_info(old_revno, old_revid) |
6217.5.1
by Jelmer Vernooij
Add CommitBuilder.updates_branch. |
489 |
raise
|
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
490 |
|
5050.52.3
by Andrew Bennetts
Merge tags from local to master when committing in a bound branch. |
491 |
# Merge local tags to remote
|
492 |
if self.bound_branch: |
|
493 |
self._set_progress_stage("Merging tags to master branch") |
|
6112.4.2
by Jelmer Vernooij
Fix tag tests. |
494 |
tag_updates, tag_conflicts = self.branch.tags.merge_to( |
495 |
self.master_branch.tags) |
|
5050.52.3
by Andrew Bennetts
Merge tags from local to master when committing in a bound branch. |
496 |
if tag_conflicts: |
497 |
warning_lines = [' ' + name for name, _, _ in tag_conflicts] |
|
6138.3.5
by Jonathan Riddell
make the test suite pass |
498 |
note( gettext("Conflicting tags in bound branch:\n{0}".format( |
499 |
"\n".join(warning_lines))) ) |
|
5050.52.3
by Andrew Bennetts
Merge tags from local to master when committing in a bound branch. |
500 |
|
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
501 |
def _select_reporter(self): |
502 |
"""Select the CommitReporter to use.""" |
|
503 |
if is_quiet(): |
|
504 |
return NullCommitReporter() |
|
2789.2.10
by Ian Clatworthy
focus on performance gains, not better reporting |
505 |
return ReportCommitToLog() |
2789.2.4
by Ian Clatworthy
make change reporting smarter for initial commit |
506 |
|
1910.2.37
by Aaron Bentley
Handle empty commits, fix test |
507 |
def _check_pointless(self): |
508 |
if self.allow_pointless: |
|
509 |
return
|
|
510 |
# A merge with no effect on files
|
|
511 |
if len(self.parents) > 1: |
|
512 |
return
|
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
513 |
if self.builder.any_changes(): |
1910.2.37
by Aaron Bentley
Handle empty commits, fix test |
514 |
return
|
515 |
raise PointlessCommit() |
|
516 |
||
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
517 |
def _check_bound_branch(self, operation, possible_master_transports=None): |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
518 |
"""Check to see if the local branch is bound. |
519 |
||
520 |
If it is bound, then most of the commit will actually be
|
|
521 |
done using the remote branch as the target branch.
|
|
522 |
Only at the end will the local branch be updated.
|
|
523 |
"""
|
|
1587.1.9
by Robert Collins
Local commits do no alter or access the master branch. |
524 |
if self.local and not self.branch.get_bound_location(): |
525 |
raise errors.LocalRequiresBoundBranch() |
|
526 |
||
527 |
if not self.local: |
|
3565.6.9
by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch. |
528 |
self.master_branch = self.branch.get_master_branch( |
529 |
possible_master_transports) |
|
1587.1.9
by Robert Collins
Local commits do no alter or access the master branch. |
530 |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
531 |
if not self.master_branch: |
1587.1.8
by Robert Collins
Local commits on unbound branches fail. |
532 |
# make this branch the reference branch for out of date checks.
|
533 |
self.master_branch = self.branch |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
534 |
return
|
535 |
||
536 |
# If the master branch is bound, we must fail
|
|
537 |
master_bound_location = self.master_branch.get_bound_location() |
|
538 |
if master_bound_location: |
|
1505.1.27
by John Arbash Meinel
Adding tests against an sftp branch. |
539 |
raise errors.CommitToDoubleBoundBranch(self.branch, |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
540 |
self.master_branch, master_bound_location) |
541 |
||
542 |
# TODO: jam 20051230 We could automatically push local
|
|
543 |
# commits to the remote branch if they would fit.
|
|
544 |
# But for now, just require remote to be identical
|
|
545 |
# to local.
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
546 |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
547 |
# Make sure the local branch is identical to the master
|
2249.4.2
by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible. |
548 |
master_info = self.master_branch.last_revision_info() |
549 |
local_info = self.branch.last_revision_info() |
|
550 |
if local_info != master_info: |
|
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
551 |
raise errors.BoundBranchOutOfDate(self.branch, |
552 |
self.master_branch) |
|
553 |
||
554 |
# Now things are ready to change the master branch
|
|
555 |
# so grab the lock
|
|
556 |
self.bound_branch = self.branch |
|
557 |
self.master_branch.lock_write() |
|
4744.3.2
by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust. |
558 |
operation.add_cleanup(self.master_branch.unlock) |
1505.1.24
by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge |
559 |
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
560 |
def _check_out_of_date_tree(self): |
561 |
"""Check that the working tree is up to date. |
|
562 |
||
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
563 |
:return: old_revision_number, old_revision_id, new_revision_number
|
564 |
tuple
|
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
565 |
"""
|
566 |
try: |
|
567 |
first_tree_parent = self.work_tree.get_parent_ids()[0] |
|
568 |
except IndexError: |
|
569 |
# if there are no parents, treat our parent as 'None'
|
|
570 |
# this is so that we still consider the master branch
|
|
571 |
# - in a checkout scenario the tree may have no
|
|
572 |
# parents but the branch may do.
|
|
6622.1.34
by Jelmer Vernooij
Rename brzlib => breezy. |
573 |
first_tree_parent = breezy.revision.NULL_REVISION |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
574 |
old_revno, master_last = self.master_branch.last_revision_info() |
575 |
if master_last != first_tree_parent: |
|
6622.1.34
by Jelmer Vernooij
Rename brzlib => breezy. |
576 |
if master_last != breezy.revision.NULL_REVISION: |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
577 |
raise errors.OutOfDateTree(self.work_tree) |
578 |
if self.branch.repository.has_revision(first_tree_parent): |
|
579 |
new_revno = old_revno + 1 |
|
580 |
else: |
|
581 |
# ghost parents never appear in revision history.
|
|
582 |
new_revno = 1 |
|
6217.5.2
by Jelmer Vernooij
Factor out the updating of branches into a separate helper. |
583 |
return old_revno, master_last, new_revno |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
584 |
|
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
585 |
def _process_pre_hooks(self, old_revno, new_revno): |
586 |
"""Process any registered pre commit hooks.""" |
|
2659.3.9
by NamNguyen
branch.py: |
587 |
self._set_progress_stage("Running pre_commit hooks") |
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
588 |
self._process_hooks("pre_commit", old_revno, new_revno) |
589 |
||
590 |
def _process_post_hooks(self, old_revno, new_revno): |
|
591 |
"""Process any registered post commit hooks.""" |
|
2553.1.2
by Robert Collins
Show hook names during commit. |
592 |
# Process the post commit hooks, if any
|
2659.3.9
by NamNguyen
branch.py: |
593 |
self._set_progress_stage("Running post_commit hooks") |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
594 |
# old style commit hooks - should be deprecated ? (obsoleted in
|
6351.3.12
by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API. |
595 |
# 0.15^H^H^H^H 2.5.0)
|
596 |
post_commit = self.config_stack.get('post_commit') |
|
597 |
if post_commit is not None: |
|
598 |
hooks = post_commit.split(' ') |
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
599 |
# this would be nicer with twisted.python.reflect.namedAny
|
600 |
for hook in hooks: |
|
601 |
result = eval(hook + '(branch, rev_id)', |
|
602 |
{'branch':self.branch, |
|
6622.1.34
by Jelmer Vernooij
Rename brzlib => breezy. |
603 |
'breezy':breezy, |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
604 |
'rev_id':self.rev_id}) |
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
605 |
# process new style post commit hooks
|
606 |
self._process_hooks("post_commit", old_revno, new_revno) |
|
607 |
||
608 |
def _process_hooks(self, hook_name, old_revno, new_revno): |
|
2659.3.3
by NamNguyen
Changed ``pre_commit`` hook signature. |
609 |
if not Branch.hooks[hook_name]: |
610 |
return
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
611 |
|
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
612 |
# new style commit hooks:
|
613 |
if not self.bound_branch: |
|
614 |
hook_master = self.branch |
|
615 |
hook_local = None |
|
616 |
else: |
|
617 |
hook_master = self.master_branch |
|
618 |
hook_local = self.branch |
|
619 |
# With bound branches, when the master is behind the local branch,
|
|
620 |
# the 'old_revno' and old_revid values here are incorrect.
|
|
621 |
# XXX: FIXME ^. RBC 20060206
|
|
622 |
if self.parents: |
|
623 |
old_revid = self.parents[0] |
|
624 |
else: |
|
6622.1.34
by Jelmer Vernooij
Rename brzlib => breezy. |
625 |
old_revid = breezy.revision.NULL_REVISION |
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
626 |
|
2659.3.9
by NamNguyen
branch.py: |
627 |
if hook_name == "pre_commit": |
628 |
future_tree = self.builder.revision_tree() |
|
629 |
tree_delta = future_tree.changes_from(self.basis_tree, |
|
630 |
include_root=True) |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
631 |
|
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
632 |
for hook in Branch.hooks[hook_name]: |
2553.1.3
by Robert Collins
Increase docs in response to review feedback. |
633 |
# show the running hook in the progress bar. As hooks may
|
634 |
# end up doing nothing (e.g. because they are not configured by
|
|
635 |
# the user) this is still showing progress, not showing overall
|
|
636 |
# actions - its up to each plugin to show a UI if it want's to
|
|
637 |
# (such as 'Emailing diff to foo@example.com').
|
|
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
638 |
self.pb_stage_name = "Running %s hooks [%s]" % \ |
2659.3.9
by NamNguyen
branch.py: |
639 |
(hook_name, Branch.hooks.get_hook_name(hook)) |
2553.1.2
by Robert Collins
Show hook names during commit. |
640 |
self._emit_progress() |
2560.1.4
by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged. |
641 |
if 'hooks' in debug.debug_flags: |
642 |
mutter("Invoking commit hook: %r", hook) |
|
2659.3.1
by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook. |
643 |
if hook_name == "post_commit": |
644 |
hook(hook_local, hook_master, old_revno, old_revid, new_revno, |
|
645 |
self.rev_id) |
|
646 |
elif hook_name == "pre_commit": |
|
647 |
hook(hook_local, hook_master, |
|
648 |
old_revno, old_revid, new_revno, self.rev_id, |
|
2659.3.9
by NamNguyen
branch.py: |
649 |
tree_delta, future_tree) |
2511.1.1
by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log |
650 |
|
4354.4.4
by Aaron Bentley
Simplify by using CommitBuilder directly |
651 |
def _update_builder_with_changes(self): |
2541.1.1
by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less |
652 |
"""Update the commit builder with the data about what has changed. |
653 |
"""
|
|
4570.4.3
by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit. |
654 |
specific_files = self.specific_files |
6684.1.3
by Martin
Changes across many modules working towards Python 3 support |
655 |
mutter("Selecting files for commit with filter %r", specific_files) |
2541.1.1
by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less |
656 |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
657 |
self._check_strict() |
6700.1.3
by Jelmer Vernooij
Drop support for committing using record_entr_contents. |
658 |
iter_changes = self.work_tree.iter_changes(self.basis_tree, |
659 |
specific_files=specific_files) |
|
660 |
if self.exclude: |
|
661 |
iter_changes = filter_excluded(iter_changes, self.exclude) |
|
662 |
iter_changes = self._filter_iter_changes(iter_changes) |
|
663 |
for file_id, path, fs_hash in self.builder.record_iter_changes( |
|
664 |
self.work_tree, self.basis_revid, iter_changes): |
|
665 |
self.work_tree._observed_sha1(file_id, path, fs_hash) |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
666 |
|
4354.4.4
by Aaron Bentley
Simplify by using CommitBuilder directly |
667 |
def _filter_iter_changes(self, iter_changes): |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
668 |
"""Process iter_changes. |
669 |
||
670 |
This method reports on the changes in iter_changes to the user, and
|
|
671 |
converts 'missing' entries in the iter_changes iterator to 'deleted'
|
|
672 |
entries. 'missing' entries have their
|
|
673 |
||
674 |
:param iter_changes: An iter_changes to process.
|
|
675 |
:return: A generator of changes.
|
|
676 |
"""
|
|
677 |
reporter = self.reporter |
|
678 |
report_changes = reporter.is_verbose() |
|
679 |
deleted_ids = [] |
|
680 |
for change in iter_changes: |
|
681 |
if report_changes: |
|
682 |
old_path = change[1][0] |
|
683 |
new_path = change[1][1] |
|
684 |
versioned = change[3][1] |
|
685 |
kind = change[6][1] |
|
686 |
versioned = change[3][1] |
|
687 |
if kind is None and versioned: |
|
688 |
# 'missing' path
|
|
689 |
if report_changes: |
|
690 |
reporter.missing(new_path) |
|
691 |
deleted_ids.append(change[0]) |
|
692 |
# Reset the new path (None) and new versioned flag (False)
|
|
693 |
change = (change[0], (change[1][0], None), change[2], |
|
694 |
(change[3][0], False)) + change[4:] |
|
6125.1.1
by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified. |
695 |
new_path = change[1][1] |
696 |
versioned = False |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
697 |
elif kind == 'tree-reference': |
698 |
if self.recursive == 'down': |
|
699 |
self._commit_nested_tree(change[0], change[1][1]) |
|
700 |
if change[3][0] or change[3][1]: |
|
701 |
yield change |
|
702 |
if report_changes: |
|
703 |
if new_path is None: |
|
704 |
reporter.deleted(old_path) |
|
705 |
elif old_path is None: |
|
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
706 |
reporter.snapshot_change(gettext('added'), new_path) |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
707 |
elif old_path != new_path: |
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
708 |
reporter.renamed(gettext('renamed'), old_path, new_path) |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
709 |
else: |
710 |
if (new_path or |
|
711 |
self.work_tree.branch.repository._format.rich_root_data): |
|
712 |
# Don't report on changes to '' in non rich root
|
|
713 |
# repositories.
|
|
6138.3.2
by Jonathan Riddell
gettext-ify bzrlib/commit.py |
714 |
reporter.snapshot_change(gettext('modified'), new_path) |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
715 |
self._next_progress_entry() |
716 |
# Unversion IDs that were found to be deleted
|
|
4536.3.1
by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402) |
717 |
self.deleted_ids = deleted_ids |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
718 |
|
719 |
def _check_strict(self): |
|
720 |
# XXX: when we use iter_changes this would likely be faster if
|
|
721 |
# iter_changes would check for us (even in the presence of
|
|
722 |
# selected_files).
|
|
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
723 |
if self.strict: |
724 |
# raise an exception as soon as we find a single unknown.
|
|
725 |
for unknown in self.work_tree.unknowns(): |
|
726 |
raise StrictCommitFailed() |
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
727 |
|
2564.2.3
by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id |
728 |
def _commit_nested_tree(self, file_id, path): |
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
729 |
"Commit a nested tree."
|
2564.2.3
by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id |
730 |
sub_tree = self.work_tree.get_nested_tree(file_id, path) |
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
731 |
# FIXME: be more comprehensive here:
|
732 |
# this works when both trees are in --trees repository,
|
|
733 |
# but when both are bound to a different repository,
|
|
3943.8.1
by Marius Kruger
remove all trailing whitespace from bzr source |
734 |
# it fails; a better way of approaching this is to
|
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
735 |
# finally implement the explicit-caches approach design
|
736 |
# a while back - RBC 20070306.
|
|
2665.5.2
by Aaron Bentley
Switch commit and merge to Repository.has_same_location |
737 |
if sub_tree.branch.repository.has_same_location( |
738 |
self.work_tree.branch.repository): |
|
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
739 |
sub_tree.branch.repository = \ |
740 |
self.work_tree.branch.repository |
|
741 |
try: |
|
2776.4.6
by Robert Collins
Fixup various commit test failures falling out from the other commit changes. |
742 |
return sub_tree.commit(message=None, revprops=self.revprops, |
2776.4.15
by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder. |
743 |
recursive=self.recursive, |
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
744 |
message_callback=self.message_callback, |
745 |
timestamp=self.timestamp, timezone=self.timezone, |
|
746 |
committer=self.committer, |
|
747 |
allow_pointless=self.allow_pointless, |
|
748 |
strict=self.strict, verbose=self.verbose, |
|
749 |
local=self.local, reporter=self.reporter) |
|
750 |
except errors.PointlessCommit: |
|
2776.4.6
by Robert Collins
Fixup various commit test failures falling out from the other commit changes. |
751 |
return self.work_tree.get_reference_revision(file_id) |
2564.2.1
by Ian Clatworthy
refactor commit to support alternative population meothds |
752 |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
753 |
def _set_progress_stage(self, name, counter=False): |
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
754 |
"""Set the progress stage and emit an update to the progress bar.""" |
755 |
self.pb_stage_name = name |
|
756 |
self.pb_stage_count += 1 |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
757 |
if counter: |
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
758 |
self.pb_entries_count = 0 |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
759 |
else: |
760 |
self.pb_entries_count = None |
|
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
761 |
self._emit_progress() |
762 |
||
2564.2.2
by Ian Clatworthy
incorporate feedback from abentley |
763 |
def _next_progress_entry(self): |
764 |
"""Emit an update to the progress bar and increment the entry count.""" |
|
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
765 |
self.pb_entries_count += 1 |
766 |
self._emit_progress() |
|
767 |
||
768 |
def _emit_progress(self): |
|
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
769 |
if self.pb_entries_count is not None: |
6138.4.1
by Jonathan Riddell
add gettext to progress bar strings |
770 |
text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name, |
4183.5.5
by Robert Collins
Enable record_iter_changes for cases where it can work. |
771 |
self.pb_entries_count) |
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
772 |
else: |
6138.4.1
by Jonathan Riddell
add gettext to progress bar strings |
773 |
text = gettext("%s - Stage") % (self.pb_stage_name, ) |
2531.1.2
by Ian Clatworthy
Improved progress reporting for commit |
774 |
self.pb.update(text, self.pb_stage_count, self.pb_stage_total) |