/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
57
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
58
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
59
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
60
from .branch import Branch
61
from .cleanup import OperationWithCleanups
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
62
import breezy.config
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
63
from .errors import (BzrError, PointlessCommit,
64
                     ConflictsInTree,
65
                     StrictCommitFailed
66
                     )
67
from .osutils import (get_user_encoding,
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      splitpath,
71
                      )
72
from .trace import mutter, note, is_quiet
6670.4.1 by Jelmer Vernooij
Update imports.
73
from .bzr.inventory import Inventory, InventoryEntry, make_entry
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
74
from .urlutils import unescape_for_display
75
from .i18n import gettext
76
1189 by Martin Pool
- BROKEN: partial support for commit into weave
77
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
78
def filter_excluded(iter_changes, exclude):
79
    """Filter exclude filenames.
80
81
    :param iter_changes: iter_changes function
82
    :param exclude: List of paths to exclude
83
    :return: iter_changes function
84
    """
85
    for change in iter_changes:
86
        old_path = change[1][0]
87
        new_path = change[1][1]
88
89
        new_excluded = (new_path is not None and
90
            is_inside_any(exclude, new_path))
91
92
        old_excluded = (old_path is not None and
93
            is_inside_any(exclude, old_path))
94
95
        if old_excluded and new_excluded:
96
            continue
97
98
        if old_excluded or new_excluded:
99
            # TODO(jelmer): Perhaps raise an error here instead?
100
            continue
101
102
        yield change
103
104
1189 by Martin Pool
- BROKEN: partial support for commit into weave
105
class NullCommitReporter(object):
106
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
107
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
108
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
109
        pass
110
111
    def snapshot_change(self, change, path):
112
        pass
113
114
    def completed(self, revno, rev_id):
115
        pass
116
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
117
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
        pass
119
120
    def missing(self, path):
121
        pass
122
123
    def renamed(self, change, old_path, new_path):
124
        pass
125
2789.2.11 by Ian Clatworthy
remove more reporting stuff
126
    def is_verbose(self):
127
        return False
128
129
130
class ReportCommitToLog(NullCommitReporter):
131
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
132
    def _note(self, format, *args):
133
        """Output a message.
134
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
135
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
136
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
137
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
138
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
139
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
140
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
141
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
142
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
143
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
144
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
145
        self._note(
146
            gettext('Committing to: %s'),
147
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
148
149
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
150
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
151
        # self._note goes to the console too; so while we want to log the
152
        # rev_id, we can't trivially only log it. (See bug 526425). Long
153
        # term we should rearrange the reporting structure, but for now
154
        # we just mutter seperately. We mutter the revid and revno together
155
        # so that concurrent bzr invocations won't lead to confusion.
156
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
157
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
158
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
159
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
160
161
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
162
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
163
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
164
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
165
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
166
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
167
    def is_verbose(self):
168
        return True
169
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
170
1189 by Martin Pool
- BROKEN: partial support for commit into weave
171
class Commit(object):
172
    """Task of committing a new revision.
173
174
    This is a MethodObject: it accumulates state as the commit is
175
    prepared, and then it is discarded.  It doesn't represent
176
    historical revisions, just the act of recording a new one.
177
178
            missing_ids
179
            Modified to hold a list of files that have been deleted from
180
            the working directory; these should be removed from the
181
            working inventory.
485 by Martin Pool
- move commit code into its own module
182
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
184
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
185
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
186
        """Create a Commit object.
187
188
        :param reporter: the default reporter to use or None to decide later
189
        """
190
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
191
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
192
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
193
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
194
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
195
                        local=False, possible_master_transports=None):
196
        if revprops is None:
197
            revprops = {}
198
        if possible_master_transports is None:
199
            possible_master_transports = []
200
        if not 'branch-nick' in revprops:
201
            revprops['branch-nick'] = branch._get_nick(
202
                local,
203
                possible_master_transports)
204
        if authors is not None:
205
            if 'author' in revprops or 'authors' in revprops:
206
                # XXX: maybe we should just accept one of them?
207
                raise AssertionError('author property given twice')
208
            if authors:
209
                for individual in authors:
210
                    if '\n' in individual:
211
                        raise AssertionError('\\n is not a valid character '
212
                                'in an author identity')
213
                revprops['authors'] = '\n'.join(authors)
214
        return revprops
215
1189 by Martin Pool
- BROKEN: partial support for commit into weave
216
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
217
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
218
               timestamp=None,
219
               timezone=None,
220
               committer=None,
221
               specific_files=None,
222
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
223
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
224
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
225
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
226
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
227
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
228
               local=False,
229
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
230
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
231
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
232
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
233
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
234
               possible_master_transports=None,
235
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
236
        """Commit working copy as a new revision.
237
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
238
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
239
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
240
241
        :param timestamp: if not None, seconds-since-epoch for a
242
            postdated/predated commit.
243
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
244
        :param specific_files: If not None, commit only those files. An empty
245
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
246
247
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
248
            Useful for test or import commands that need to tightly
249
            control what revisions are assigned.  If you duplicate
250
            a revision id that exists elsewhere it is your own fault.
251
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
252
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
253
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
254
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
255
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
256
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
257
            contains unknown files.
258
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
259
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
260
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
261
        :param reporter: the reporter to use or None for the default
262
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
263
        :param recursive: If set to 'down', commit in any subtrees that have
264
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
265
        :param exclude: None or a list of relative paths to exclude from the
266
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
267
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
268
        :param lossy: When committing to a foreign VCS, ignore any
269
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
270
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
271
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
272
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
273
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
274
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
275
        return operation.run(
276
               message=message,
277
               timestamp=timestamp,
278
               timezone=timezone,
279
               committer=committer,
280
               specific_files=specific_files,
281
               rev_id=rev_id,
282
               allow_pointless=allow_pointless,
283
               strict=strict,
284
               verbose=verbose,
285
               working_tree=working_tree,
286
               local=local,
287
               reporter=reporter,
288
               message_callback=message_callback,
289
               recursive=recursive,
290
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
291
               possible_master_transports=possible_master_transports,
292
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
293
294
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
295
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
296
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
297
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
298
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
299
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
300
        if working_tree is None:
301
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
302
        else:
303
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
304
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
305
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
306
                if not self.branch.repository.supports_rich_root():
307
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
308
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
309
            if message is not None:
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
310
                if isinstance(message, bytes):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
311
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
312
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
313
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
314
                raise BzrError("The message or message_callback keyword"
315
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
316
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
317
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
318
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
319
        if exclude is not None:
320
            self.exclude = sorted(
321
                minimum_path_selection(exclude))
322
        else:
323
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
324
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
325
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
326
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
327
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
328
        # self.specific_files is None to indicate no filter, or any iterable to
329
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
330
        if specific_files is not None:
331
            self.specific_files = sorted(
332
                minimum_path_selection(specific_files))
333
        else:
334
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
335
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
336
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
337
        self.message_callback = message_callback
338
        self.timestamp = timestamp
339
        self.timezone = timezone
340
        self.committer = committer
341
        self.strict = strict
342
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
343
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
344
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
345
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
346
        self.parents = self.work_tree.get_parent_ids()
6700.1.2 by Jelmer Vernooij
Merge trunk.
347
        # We can use record_iter_changes IFF no tree references are involved.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
348
        self.use_record_iter_changes = (
6700.1.1 by Jelmer Vernooij
Don't use record_entry_contents for older formats; record_iter_changes works just fine and performs reasonably.
349
            not self.branch.repository._format.supports_tree_reference)
5582.10.6 by Jelmer Vernooij
Fix ui imports.
350
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
351
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
352
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
353
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
354
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
355
        operation.add_cleanup(self.basis_tree.unlock)
356
        # Cannot commit with conflicts present.
357
        if len(self.work_tree.conflicts()) > 0:
358
            raise ConflictsInTree
359
360
        # Setup the bound branch variables as needed.
361
        self._check_bound_branch(operation, possible_master_transports)
362
363
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
364
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
365
366
        # Complete configuration setup
367
        if reporter is not None:
368
            self.reporter = reporter
369
        elif self.reporter is None:
370
            self.reporter = self._select_reporter()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
371
        if self.config_stack is None:
6449.6.4 by Jelmer Vernooij
Use config stack.
372
            self.config_stack = self.work_tree.get_config_stack()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
373
374
        self._set_specific_file_ids()
375
376
        # Setup the progress bar. As the number of files that need to be
377
        # committed in unknown, progress is reported as stages.
378
        # We keep track of entries separately though and include that
379
        # information in the progress bar during the relevant stages.
380
        self.pb_stage_name = ""
381
        self.pb_stage_count = 0
382
        self.pb_stage_total = 5
383
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
384
            # 2 extra stages: "Uploading data to master branch" and "Merging
385
            # tags to master branch"
386
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
387
        self.pb.show_pct = False
388
        self.pb.show_spinner = False
389
        self.pb.show_eta = False
390
        self.pb.show_count = True
391
        self.pb.show_bar = True
392
393
        self._gather_parents()
394
        # After a merge, a selected file commit is not supported.
395
        # See 'bzr help merge' for an explanation as to why.
396
        if len(self.parents) > 1 and self.specific_files is not None:
397
            raise errors.CannotCommitSelectedFileMerge(self.specific_files)
398
        # Excludes are a form of selected file commit.
399
        if len(self.parents) > 1 and self.exclude:
400
            raise errors.CannotCommitSelectedFileMerge(self.exclude)
401
402
        # Collect the changes
403
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
404
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
405
        self.builder = self.branch.get_commit_builder(self.parents,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
406
            self.config_stack, timestamp, timezone, committer, self.revprops,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
407
            rev_id, lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
408
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
409
        if self.builder.updates_branch and self.bound_branch:
410
            self.builder.abort()
411
            raise AssertionError(
412
                "bound branches not supported for commit builders "
413
                "that update the branch")
414
1189 by Martin Pool
- BROKEN: partial support for commit into weave
415
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
416
            # find the location being committed to
417
            if self.bound_branch:
418
                master_location = self.master_branch.base
419
            else:
420
                master_location = self.branch.base
421
422
            # report the start of the commit
423
            self.reporter.started(new_revno, self.rev_id, master_location)
424
425
            self._update_builder_with_changes()
426
            self._check_pointless()
427
428
            # TODO: Now the new inventory is known, check for conflicts.
429
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
430
            # weave lines, because nothing should be recorded until it is known
431
            # that commit will succeed.
432
            self._set_progress_stage("Saving data locally")
433
            self.builder.finish_inventory()
434
435
            # Prompt the user for a commit message if none provided
436
            message = message_callback(self)
437
            self.message = message
438
439
            # Add revision data to the local branch
440
            self.rev_id = self.builder.commit(self.message)
441
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
442
        except Exception as e:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
443
            mutter("aborting commit write group because of exception:")
444
            trace.log_exception_quietly()
445
            self.builder.abort()
446
            raise
447
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
448
        self._update_branches(old_revno, old_revid, new_revno)
449
450
        # Make the working tree be up to date with the branch. This
451
        # includes automatic changes scheduled to be made to the tree, such
452
        # as updating its basis and unversioning paths that were missing.
453
        self.work_tree.unversion(self.deleted_ids)
454
        self._set_progress_stage("Updating the working tree")
455
        self.work_tree.update_basis_by_delta(self.rev_id,
456
             self.builder.get_basis_delta())
457
        self.reporter.completed(new_revno, self.rev_id)
458
        self._process_post_hooks(old_revno, new_revno)
459
        return self.rev_id
460
461
    def _update_branches(self, old_revno, old_revid, new_revno):
462
        """Update the master and local branch to the new revision.
463
464
        This will try to make sure that the master branch is updated
465
        before the local branch.
466
467
        :param old_revno: Revision number of master branch before the
468
            commit
469
        :param old_revid: Tip of master branch before the commit
470
        :param new_revno: Revision number of the new commit
471
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
472
        if not self.builder.updates_branch:
473
            self._process_pre_hooks(old_revno, new_revno)
474
475
            # Upload revision data to the master.
476
            # this will propagate merged revisions too if needed.
477
            if self.bound_branch:
478
                self._set_progress_stage("Uploading data to master branch")
479
                # 'commit' to the master first so a timeout here causes the
480
                # local branch to be out of date
481
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
482
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
483
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
484
                    self.branch.fetch(self.master_branch, self.rev_id)
485
486
            # and now do the commit locally.
487
            self.branch.set_last_revision_info(new_revno, self.rev_id)
488
        else:
489
            try:
490
                self._process_pre_hooks(old_revno, new_revno)
491
            except:
492
                # The commit builder will already have updated the branch,
493
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
494
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
495
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
496
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
497
        # Merge local tags to remote
498
        if self.bound_branch:
499
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
500
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
501
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
502
            if tag_conflicts:
503
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
6138.3.5 by Jonathan Riddell
make the test suite pass
504
                note( gettext("Conflicting tags in bound branch:\n{0}".format(
505
                    "\n".join(warning_lines))) )
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
506
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
507
    def _select_reporter(self):
508
        """Select the CommitReporter to use."""
509
        if is_quiet():
510
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
511
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
512
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
513
    def _check_pointless(self):
514
        if self.allow_pointless:
515
            return
516
        # A merge with no effect on files
517
        if len(self.parents) > 1:
518
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
519
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
520
            return
521
        raise PointlessCommit()
522
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
523
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
524
        """Check to see if the local branch is bound.
525
526
        If it is bound, then most of the commit will actually be
527
        done using the remote branch as the target branch.
528
        Only at the end will the local branch be updated.
529
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
530
        if self.local and not self.branch.get_bound_location():
531
            raise errors.LocalRequiresBoundBranch()
532
533
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
534
            self.master_branch = self.branch.get_master_branch(
535
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
536
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
537
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
538
            # make this branch the reference branch for out of date checks.
539
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
540
            return
541
542
        # If the master branch is bound, we must fail
543
        master_bound_location = self.master_branch.get_bound_location()
544
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
545
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
546
                    self.master_branch, master_bound_location)
547
548
        # TODO: jam 20051230 We could automatically push local
549
        #       commits to the remote branch if they would fit.
550
        #       But for now, just require remote to be identical
551
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
552
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
553
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
554
        master_info = self.master_branch.last_revision_info()
555
        local_info = self.branch.last_revision_info()
556
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
557
            raise errors.BoundBranchOutOfDate(self.branch,
558
                    self.master_branch)
559
560
        # Now things are ready to change the master branch
561
        # so grab the lock
562
        self.bound_branch = self.branch
563
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
564
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
565
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
566
    def _check_out_of_date_tree(self):
567
        """Check that the working tree is up to date.
568
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
569
        :return: old_revision_number, old_revision_id, new_revision_number
570
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
571
        """
572
        try:
573
            first_tree_parent = self.work_tree.get_parent_ids()[0]
574
        except IndexError:
575
            # if there are no parents, treat our parent as 'None'
576
            # this is so that we still consider the master branch
577
            # - in a checkout scenario the tree may have no
578
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
579
            first_tree_parent = breezy.revision.NULL_REVISION
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
580
        old_revno, master_last = self.master_branch.last_revision_info()
581
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
582
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
583
                raise errors.OutOfDateTree(self.work_tree)
584
        if self.branch.repository.has_revision(first_tree_parent):
585
            new_revno = old_revno + 1
586
        else:
587
            # ghost parents never appear in revision history.
588
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
589
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
590
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
591
    def _process_pre_hooks(self, old_revno, new_revno):
592
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
593
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
594
        self._process_hooks("pre_commit", old_revno, new_revno)
595
596
    def _process_post_hooks(self, old_revno, new_revno):
597
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
598
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
599
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
600
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
601
        # 0.15^H^H^H^H 2.5.0)
602
        post_commit = self.config_stack.get('post_commit')
603
        if post_commit is not None:
604
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
605
            # this would be nicer with twisted.python.reflect.namedAny
606
            for hook in hooks:
607
                result = eval(hook + '(branch, rev_id)',
608
                              {'branch':self.branch,
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
609
                               'breezy':breezy,
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
610
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
611
        # process new style post commit hooks
612
        self._process_hooks("post_commit", old_revno, new_revno)
613
614
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
615
        if not Branch.hooks[hook_name]:
616
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
617
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
618
        # new style commit hooks:
619
        if not self.bound_branch:
620
            hook_master = self.branch
621
            hook_local = None
622
        else:
623
            hook_master = self.master_branch
624
            hook_local = self.branch
625
        # With bound branches, when the master is behind the local branch,
626
        # the 'old_revno' and old_revid values here are incorrect.
627
        # XXX: FIXME ^. RBC 20060206
628
        if self.parents:
629
            old_revid = self.parents[0]
630
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
631
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
632
2659.3.9 by NamNguyen
branch.py:
633
        if hook_name == "pre_commit":
634
            future_tree = self.builder.revision_tree()
635
            tree_delta = future_tree.changes_from(self.basis_tree,
636
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
637
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
638
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
639
            # show the running hook in the progress bar. As hooks may
640
            # end up doing nothing (e.g. because they are not configured by
641
            # the user) this is still showing progress, not showing overall
642
            # actions - its up to each plugin to show a UI if it want's to
643
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
644
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
645
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
646
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
647
            if 'hooks' in debug.debug_flags:
648
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
649
            if hook_name == "post_commit":
650
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
651
                     self.rev_id)
652
            elif hook_name == "pre_commit":
653
                hook(hook_local, hook_master,
654
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
655
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
656
1223 by Martin Pool
- store inventories in weave
657
    def _gather_parents(self):
1092.2.25 by Robert Collins
support ghosts in commits
658
        """Record the parents of a merge for merge detection."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
659
        # TODO: Make sure that this list doesn't contain duplicate
1740.3.6 by Jelmer Vernooij
Move inventory writing to the commit builder.
660
        # entries and the order is preserved when doing this.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
661
        if self.use_record_iter_changes:
662
            return
6405.2.5 by Jelmer Vernooij
Add root_inventory.
663
        self.basis_inv = self.basis_tree.root_inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
664
        self.parent_invs = [self.basis_inv]
2283.2.1 by John Arbash Meinel
Avoid deserializing an inventory we have already parsed.
665
        for revision in self.parents[1:]:
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
666
            if self.branch.repository.has_revision(revision):
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
667
                mutter('commit parent revision {%s}', revision)
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
668
                inventory = self.branch.repository.get_inventory(revision)
669
                self.parent_invs.append(inventory)
670
            else:
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
671
                mutter('commit parent ghost revision {%s}', revision)
1284 by Martin Pool
- in commit, avoid reading basis inventory twice
672
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
673
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
674
        """Update the commit builder with the data about what has changed.
675
        """
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
676
        exclude = self.exclude
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
677
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
678
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
679
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
680
        self._check_strict()
681
        if self.use_record_iter_changes:
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
682
            iter_changes = self.work_tree.iter_changes(self.basis_tree,
683
                specific_files=specific_files)
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
684
            if self.exclude:
685
                iter_changes = filter_excluded(iter_changes, self.exclude)
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
686
            iter_changes = self._filter_iter_changes(iter_changes)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
687
            for file_id, path, fs_hash in self.builder.record_iter_changes(
688
                self.work_tree, self.basis_revid, iter_changes):
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
689
                self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
690
        else:
691
            # Build the new inventory
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
692
            self._populate_from_inventory()
693
            self._record_unselected()
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
694
            self._report_and_accumulate_deletes()
695
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
696
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
697
        """Process iter_changes.
698
699
        This method reports on the changes in iter_changes to the user, and 
700
        converts 'missing' entries in the iter_changes iterator to 'deleted'
701
        entries. 'missing' entries have their
702
703
        :param iter_changes: An iter_changes to process.
704
        :return: A generator of changes.
705
        """
706
        reporter = self.reporter
707
        report_changes = reporter.is_verbose()
708
        deleted_ids = []
709
        for change in iter_changes:
710
            if report_changes:
711
                old_path = change[1][0]
712
                new_path = change[1][1]
713
                versioned = change[3][1]
714
            kind = change[6][1]
715
            versioned = change[3][1]
716
            if kind is None and versioned:
717
                # 'missing' path
718
                if report_changes:
719
                    reporter.missing(new_path)
720
                deleted_ids.append(change[0])
721
                # Reset the new path (None) and new versioned flag (False)
722
                change = (change[0], (change[1][0], None), change[2],
723
                    (change[3][0], False)) + change[4:]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
724
                new_path = change[1][1]
725
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
726
            elif kind == 'tree-reference':
727
                if self.recursive == 'down':
728
                    self._commit_nested_tree(change[0], change[1][1])
729
            if change[3][0] or change[3][1]:
730
                yield change
731
                if report_changes:
732
                    if new_path is None:
733
                        reporter.deleted(old_path)
734
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
735
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
736
                    elif old_path != new_path:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
737
                        reporter.renamed(gettext('renamed'), old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
738
                    else:
739
                        if (new_path or 
740
                            self.work_tree.branch.repository._format.rich_root_data):
741
                            # Don't report on changes to '' in non rich root
742
                            # repositories.
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
743
                            reporter.snapshot_change(gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
744
            self._next_progress_entry()
745
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
746
        self.deleted_ids = deleted_ids
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
747
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
748
    def _record_unselected(self):
2564.2.7 by Ian Clatworthy
Clean-up comments and make use of self.builder.record_root_entry more explicit
749
        # If specific files are selected, then all un-selected files must be
750
        # recorded in their previous state. For more details, see
751
        # https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
752
        if self.specific_files or self.exclude:
753
            specific_files = self.specific_files or []
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
754
            for path, old_ie in self.basis_inv.iter_entries():
5967.7.1 by Martin Pool
Deprecate __contains__ on Tree and Inventory
755
                if self.builder.new_inventory.has_id(old_ie.file_id):
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
756
                    # already added - skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
757
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
758
                if (is_inside_any(specific_files, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
759
                    and not is_inside_any(self.exclude, path)):
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
760
                    # was inside the selected path, and not excluded - if not
761
                    # present it has been deleted so skip.
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
762
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
763
                # From here down it was either not selected, or was excluded:
764
                # We preserve the entry unaltered.
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
765
                ie = old_ie.copy()
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
766
                # Note: specific file commits after a merge are currently
767
                # prohibited. This test is for sanity/safety in case it's
768
                # required after that changes.
769
                if len(self.parents) > 1:
770
                    ie.revision = None
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
771
                self.builder.record_entry_contents(ie, self.parent_invs, path,
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
772
                    self.basis_tree, None)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
773
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
774
    def _report_and_accumulate_deletes(self):
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
775
        if (isinstance(self.basis_inv, Inventory)
776
            and isinstance(self.builder.new_inventory, Inventory)):
3825.1.1 by Martin Pool
commit should not assume Inventories have a _byid dictionary
777
            # the older Inventory classes provide a _byid dict, and building a
778
            # set from the keys of this dict is substantially faster than even
779
            # getting a set of ids from the inventory
780
            #
781
            # <lifeless> set(dict) is roughly the same speed as
782
            # set(iter(dict)) and both are significantly slower than
783
            # set(dict.keys())
3735.5.2 by Martin Pool
Restore optimization in commit _report_and_accumulate_deletes
784
            deleted_ids = set(self.basis_inv._byid.keys()) - \
785
               set(self.builder.new_inventory._byid.keys())
786
        else:
787
            deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
2903.2.1 by Martin Pool
Commit now tells the working tree about the new basis by passing the an inventory delta from the previous basis
788
        if deleted_ids:
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
789
            self.any_entries_deleted = True
6619.3.18 by Jelmer Vernooij
Run 2to3 idioms fixer.
790
            deleted = sorted([(self.basis_tree.id2path(file_id), file_id)
791
                for file_id in deleted_ids])
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
792
            # XXX: this is not quite directory-order sorting
793
            for path, file_id in deleted:
3775.2.3 by Robert Collins
Delegate basis inventory calculation during commit to the CommitBuilder object.
794
                self.builder.record_delete(path, file_id)
2903.2.8 by Martin Pool
More efficient reporting of deletions from a large tree during commit
795
                self.reporter.deleted(path)
1551.7.24 by Aaron Bentley
Ensure commit respects file spec when committing removals
796
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
797
    def _check_strict(self):
798
        # XXX: when we use iter_changes this would likely be faster if
799
        # iter_changes would check for us (even in the presence of
800
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
801
        if self.strict:
802
            # raise an exception as soon as we find a single unknown.
803
            for unknown in self.work_tree.unknowns():
804
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
805
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
806
    def _populate_from_inventory(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
807
        """Populate the CommitBuilder by walking the working tree inventory."""
808
        # Build the revision inventory.
809
        #
810
        # This starts by creating a new empty inventory. Depending on
811
        # which files are selected for commit, and what is present in the
812
        # current tree, the new inventory is populated. inventory entries
813
        # which are candidates for modification have their revision set to
814
        # None; inventory entries that are carried over untouched have their
815
        # revision set to their prior value.
816
        #
817
        # ESEPARATIONOFCONCERNS: this function is diffing and using the diff
818
        # results to create a new inventory at the same time, which results
819
        # in bugs like #46635.  Any reason not to use/enhance Tree.changes_from?
820
        # ADHB 11-07-2006
821
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
822
        specific_files = self.specific_files
823
        exclude = self.exclude
2789.2.11 by Ian Clatworthy
remove more reporting stuff
824
        report_changes = self.reporter.is_verbose()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
825
        deleted_ids = []
2938.3.2 by Robert Collins
Review feedback.
826
        # A tree of paths that have been deleted. E.g. if foo/bar has been
827
        # deleted, then we have {'foo':{'bar':{}}}
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
828
        deleted_paths = {}
2921.4.5 by Robert Collins
Remove an unnecessary assertion.
829
        # XXX: Note that entries may have the wrong kind because the entry does
830
        # not reflect the status on disk.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
831
        # NB: entries will include entries within the excluded ids/paths
832
        # because iter_entries_by_dir has no 'exclude' facility today.
6468.2.7 by Jelmer Vernooij
Use .iter_entries_by_dir.
833
        entries = self.work_tree.iter_entries_by_dir(
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
834
            specific_file_ids=self.specific_file_ids, yield_parents=True)
2564.2.6 by Ian Clatworthy
Incorporate feedback from abentley
835
        for path, existing_ie in entries:
836
            file_id = existing_ie.file_id
837
            name = existing_ie.name
838
            parent_id = existing_ie.parent_id
839
            kind = existing_ie.kind
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
840
            # Skip files that have been deleted from the working tree.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
841
            # The deleted path ids are also recorded so they can be explicitly
842
            # unversioned later.
843
            if deleted_paths:
844
                path_segments = splitpath(path)
845
                deleted_dict = deleted_paths
846
                for segment in path_segments:
847
                    deleted_dict = deleted_dict.get(segment, None)
848
                    if not deleted_dict:
2938.3.2 by Robert Collins
Review feedback.
849
                        # We either took a path not present in the dict
850
                        # (deleted_dict was None), or we've reached an empty
851
                        # child dir in the dict, so are now a sub-path.
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
852
                        break
853
                else:
854
                    deleted_dict = None
855
                if deleted_dict is not None:
856
                    # the path has a deleted parent, do not add it.
857
                    continue
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
858
            if exclude and is_inside_any(exclude, path):
3603.1.1 by Robert Collins
Further tweaks to tests and comments in the commit excludes feature.
859
                # Skip excluded paths. Excluded paths are processed by
860
                # _update_builder_with_changes.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
861
                continue
4595.11.13 by Martin Pool
Remove get_kind_and_executable_by_path; go back to using plain path_content_summary
862
            content_summary = self.work_tree.path_content_summary(path)
863
            kind = content_summary[0]
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
864
            # Note that when a filter of specific files is given, we must only
865
            # skip/record deleted files matching that filter.
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
866
            if not specific_files or is_inside_any(specific_files, path):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
867
                if kind == 'missing':
2938.3.1 by Robert Collins
* Commit with many automatically found deleted paths no longer performs
868
                    if not deleted_paths:
869
                        # path won't have been split yet.
870
                        path_segments = splitpath(path)
871
                    deleted_dict = deleted_paths
872
                    for segment in path_segments:
873
                        deleted_dict = deleted_dict.setdefault(segment, {})
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
874
                    self.reporter.missing(path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
875
                    self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
876
                    deleted_ids.append(file_id)
877
                    continue
4595.11.14 by Martin Pool
Small code cleanups
878
            # TODO: have the builder do the nested commit just-in-time IF and
879
            # only if needed.
4595.11.12 by Martin Pool
Change commit back to using path_content_summary rather than synthesizing it
880
            if kind == 'tree-reference':
2776.4.4 by Robert Collins
Move content summary generation outside of record_entry_contents.
881
                # enforce repository nested tree policy.
882
                if (not self.work_tree.supports_tree_reference() or
883
                    # repository does not support it either.
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
884
                    not self.branch.repository._format.supports_tree_reference):
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
885
                    kind = 'directory'
4595.11.14 by Martin Pool
Small code cleanups
886
                    content_summary = (kind, None, None, None)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
887
                elif self.recursive == 'down':
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
888
                    nested_revision_id = self._commit_nested_tree(
889
                        file_id, path)
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
890
                    content_summary = (kind, None, None, nested_revision_id)
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
891
                else:
4595.11.8 by Martin Pool
Commit synthesizes a content_summary without using path_content_summary
892
                    nested_revision_id = self.work_tree.get_reference_revision(file_id)
893
                    content_summary = (kind, None, None, nested_revision_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
894
895
            # Record an entry for this item
896
            # Note: I don't particularly want to have the existing_ie
897
            # parameter but the test suite currently (28-Jun-07) breaks
898
            # without it thanks to a unicode normalisation issue. :-(
2776.4.2 by Robert Collins
nuke _read_tree_state and snapshot from inventory, moving responsibility into the commit builder.
899
            definitely_changed = kind != existing_ie.kind
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
900
            self._record_entry(path, file_id, specific_files, kind, name,
2592.3.140 by Robert Collins
Merge bzr.dev.
901
                parent_id, definitely_changed, existing_ie, report_changes,
902
                content_summary)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
903
904
        # Unversion IDs that were found to be deleted
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
905
        self.deleted_ids = deleted_ids
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
906
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
907
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
908
        "Commit a nested tree."
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
909
        sub_tree = self.work_tree.get_nested_tree(file_id, path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
910
        # FIXME: be more comprehensive here:
911
        # this works when both trees are in --trees repository,
912
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
913
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
914
        # finally implement the explicit-caches approach design
915
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
916
        if sub_tree.branch.repository.has_same_location(
917
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
918
            sub_tree.branch.repository = \
919
                self.work_tree.branch.repository
920
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
921
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
922
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
923
                message_callback=self.message_callback,
924
                timestamp=self.timestamp, timezone=self.timezone,
925
                committer=self.committer,
926
                allow_pointless=self.allow_pointless,
927
                strict=self.strict, verbose=self.verbose,
928
                local=self.local, reporter=self.reporter)
929
        except errors.PointlessCommit:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
930
            return self.work_tree.get_reference_revision(file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
931
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
932
    def _record_entry(self, path, file_id, specific_files, kind, name,
933
        parent_id, definitely_changed, existing_ie, report_changes,
934
        content_summary):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
935
        "Record the new inventory entry for a path if any."
936
        # mutter('check %s {%s}', path, file_id)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
937
        # mutter('%s selected for commit', path)
938
        if definitely_changed or existing_ie is None:
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
939
            ie = make_entry(kind, name, parent_id, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
940
        else:
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
941
            ie = existing_ie.copy()
942
            ie.revision = None
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
943
        # For carried over entries we don't care about the fs hash - the repo
944
        # isn't generating a sha, so we're not saving computation time.
3775.2.8 by Robert Collins
Move --unchanged detection in commit into the CommitBuilder.
945
        _, _, fs_hash = self.builder.record_entry_contents(
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
946
            ie, self.parent_invs, path, self.work_tree, content_summary)
2825.7.1 by Robert Collins
* Partial commits are now approximately 40% faster by walking over the
947
        if report_changes:
948
            self._report_change(ie, path)
3709.3.1 by Robert Collins
First cut - make it work - at updating the tree stat cache during commit.
949
        if fs_hash:
950
            self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
951
        return ie
952
953
    def _report_change(self, ie, path):
954
        """Report a change to the user.
955
956
        The change that has occurred is described relative to the basis
957
        inventory.
958
        """
959
        if (self.basis_inv.has_id(ie.file_id)):
960
            basis_ie = self.basis_inv[ie.file_id]
961
        else:
962
            basis_ie = None
963
        change = ie.describe_change(basis_ie, ie)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
964
        if change in (InventoryEntry.RENAMED,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
965
            InventoryEntry.MODIFIED_AND_RENAMED):
966
            old_path = self.basis_inv.id2path(ie.file_id)
967
            self.reporter.renamed(change, old_path, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
968
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
969
        else:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
970
            if change == gettext('unchanged'):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
971
                return
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
972
            self.reporter.snapshot_change(change, path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
973
            self._next_progress_entry()
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
974
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
975
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
976
        """Set the progress stage and emit an update to the progress bar."""
977
        self.pb_stage_name = name
978
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
979
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
980
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
981
        else:
982
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
983
        self._emit_progress()
984
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
985
    def _next_progress_entry(self):
986
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
987
        self.pb_entries_count += 1
988
        self._emit_progress()
989
990
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
991
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
992
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
993
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
994
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
995
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
996
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
997
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
998
    def _set_specific_file_ids(self):
999
        """populate self.specific_file_ids if we will use it."""
1000
        if not self.use_record_iter_changes:
1001
            # If provided, ensure the specified files are versioned
1002
            if self.specific_files is not None:
1003
                # Note: This routine is being called because it raises
1004
                # PathNotVersionedError as a side effect of finding the IDs. We
1005
                # later use the ids we found as input to the working tree
1006
                # inventory iterator, so we only consider those ids rather than
1007
                # examining the whole tree again.
1008
                # XXX: Dont we have filter_unversioned to do this more
1009
                # cheaply?
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
1010
                self.specific_file_ids = tree.find_ids_across_trees(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
1011
                    self.specific_files, [self.basis_tree, self.work_tree])
1012
            else:
1013
                self.specific_file_ids = None