/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
1
# Copyright (C) 2005-2012, 2016 Canonical Ltd, 2017 Breezy developers
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
750 by Martin Pool
- stubbed-out tests for python plugins
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
7
#
750 by Martin Pool
- stubbed-out tests for python plugins
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
2052.3.1 by John Arbash Meinel
Add tests to cleanup the copyright of all source files
12
#
750 by Martin Pool
- stubbed-out tests for python plugins
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
750 by Martin Pool
- stubbed-out tests for python plugins
16
17
"""Tests for plugins"""
18
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
19
import imp
20
import importlib
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
21
import logging
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
22
import os
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
23
import sys
750 by Martin Pool
- stubbed-out tests for python plugins
24
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
25
import breezy
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
26
from .. import (
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
27
    errors,
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
28
    osutils,
29
    plugin,
30
    tests,
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
31
    trace,
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
32
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
33
from ..sixish import (
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
34
    PY3,
35
    StringIO,
36
    viewkeys,
6621.22.2 by Martin
Use BytesIO or StringIO from bzrlib.sixish
37
    )
1141 by Martin Pool
- rename FunctionalTest to TestCaseInTempDir
38
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
39
1492 by Robert Collins
Support decoration of commands.
40
# TODO: Write a test for plugin decoration of commands.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
41
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
42
invalidate_caches = getattr(importlib, "invalidate_caches", lambda: None)
43
44
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
45
class BaseTestPlugins(tests.TestCaseInTempDir):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
46
    """TestCase that isolates plugin imports and cleans up on completion."""
47
48
    def setUp(self):
49
        super(BaseTestPlugins, self).setUp()
50
        self.module_name = "breezy.testingplugins"
51
        self.module_prefix = self.module_name + "."
52
        self.module = imp.new_module(self.module_name)
53
54
        self.overrideAttr(plugin, "_MODULE_PREFIX", self.module_prefix)
55
        self.overrideAttr(breezy, "testingplugins", self.module)
56
57
        sys.modules[self.module_name] = self.module
58
        self.addCleanup(self._unregister_all)
59
        self.addCleanup(self._unregister_finder)
60
61
        invalidate_caches()
62
63
    def reset(self):
64
        """Remove all global testing state and clean up module."""
65
        # GZ 2017-06-02: Ideally don't do this, write new test or generate
66
        # bytecode by other mechanism.
67
        self.log("resetting plugin testing context")
68
        self._unregister_all()
69
        self._unregister_finder()
70
        sys.modules[self.module_name] = self.module
71
        for name in list(self.module.__dict__):
72
            if name[:2] != '__':
73
                delattr(self.module, name)
74
        invalidate_caches()
75
        self.plugins = None
76
77
    def update_module_paths(self, paths):
78
        paths = plugin.extend_path(paths, self.module_name)
79
        self.module.__path__ = paths
80
        self.log("using %r", paths)
81
        return paths
82
83
    def load_with_paths(self, paths):
84
        self.log("loading plugins!")
85
        plugin.load_plugins(self.update_module_paths(paths), state=self)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
86
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
87
    def create_plugin(self, name, source=None, dir='.', file_name=None):
88
        if source is None:
89
            source = '''\
90
"""This is the doc for %s"""
91
''' % (name)
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
92
        if file_name is None:
93
            file_name = name + '.py'
94
        # 'source' must not fail to load
5086.1.7 by Vincent Ladeuil
Cleaner fix for bug #411413.
95
        path = osutils.pathjoin(dir, file_name)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
96
        with open(path, 'w') as f:
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
97
            f.write(source + '\n')
98
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
99
    def create_plugin_package(self, name, dir=None, source=None):
100
        if dir is None:
101
            dir = name
102
        if source is None:
103
            source = '''\
104
"""This is the doc for %s"""
105
dir_source = '%s'
106
''' % (name, dir)
107
        os.makedirs(dir)
108
        self.create_plugin(name, source, dir,
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
109
                           file_name='__init__.py')
110
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
111
    def promote_cache(self, directory):
112
        """Move bytecode files out of __pycache__ in given directory."""
113
        cache_dir = os.path.join(directory, '__pycache__')
114
        if os.path.isdir(cache_dir):
115
            for name in os.listdir(cache_dir):
116
                magicless_name = '.'.join(name.split('.')[0::name.count('.')])
117
                rel = osutils.relpath(self.test_dir, cache_dir)
118
                self.log("moving %s in %s to %s", name, rel, magicless_name)
119
                os.rename(os.path.join(cache_dir, name),
120
                    os.path.join(directory, magicless_name))
121
122
    def _unregister_finder(self):
123
        """Removes any test copies of _PluginsAtFinder from sys.meta_path."""
124
        idx = len(sys.meta_path)
125
        while idx:
126
            idx -= 1
127
            finder = sys.meta_path[idx]
128
            if getattr(finder, "prefix", "") == self.module_prefix:
129
                self.log("removed %r from sys.meta_path", finder)
130
                sys.meta_path.pop(idx)
131
132
    def _unregister_all(self):
133
        """Remove all plugins in the test namespace from sys.modules."""
134
        for name in list(sys.modules):
135
            if name.startswith(self.module_prefix) or name == self.module_name:
136
                self.log("removed %s from sys.modules", name)
137
                del sys.modules[name]
138
139
    def assertPluginModules(self, plugin_dict):
140
        self.assertEqual(
141
            dict((k[len(self.module_prefix):], sys.modules[k])
142
                for k in sys.modules if k.startswith(self.module_prefix)),
143
            plugin_dict)
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
144
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
145
    def assertPluginUnknown(self, name):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
146
        self.assertTrue(getattr(self.module, name, None) is None)
147
        self.assertFalse(self.module_prefix + name in sys.modules)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
148
149
    def assertPluginKnown(self, name):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
150
        self.assertTrue(getattr(self.module, name, None) is not None)
151
        self.assertTrue(self.module_prefix + name in sys.modules)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
152
153
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
154
class TestLoadingPlugins(BaseTestPlugins):
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
155
156
    activeattributes = {}
157
158
    def test_plugins_with_the_same_name_are_not_loaded(self):
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
159
        # This test tests that having two plugins in different directories does
160
        # not result in both being loaded when they have the same name.  get a
161
        # file name we can use which is also a valid attribute for accessing in
162
        # activeattributes. - we cannot give import parameters.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
163
        tempattribute = "0"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
164
        self.assertFalse(tempattribute in self.activeattributes)
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
165
        # set a place for the plugins to record their loading, and at the same
166
        # time validate that the location the plugins should record to is
167
        # valid and correct.
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
168
        self.__class__.activeattributes [tempattribute] = []
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
169
        self.assertTrue(tempattribute in self.activeattributes)
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
170
        # create two plugin directories
171
        os.mkdir('first')
172
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
173
        # write a plugin that will record when its loaded in the
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
174
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
175
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
176
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
177
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
178
        with open(os.path.join('first', 'plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
179
            outfile.write(template % (tempattribute, 'first'))
180
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
181
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
182
        with open(os.path.join('second', 'plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
183
            outfile.write(template % (tempattribute, 'second'))
184
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
185
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
186
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
187
            self.load_with_paths(['first', 'second'])
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
188
            self.assertEqual(['first'], self.activeattributes[tempattribute])
189
        finally:
190
            del self.activeattributes[tempattribute]
191
192
    def test_plugins_from_different_dirs_can_demand_load(self):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
193
        self.assertFalse('breezy.plugins.pluginone' in sys.modules)
194
        self.assertFalse('breezy.plugins.plugintwo' in sys.modules)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
195
        # This test tests that having two plugins in different
196
        # directories with different names allows them both to be loaded, when
197
        # we do a direct import statement.
198
        # Determine a file name we can use which is also a valid attribute
199
        # for accessing in activeattributes. - we cannot give import parameters.
200
        tempattribute = "different-dirs"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
201
        self.assertFalse(tempattribute in self.activeattributes)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
202
        # set a place for the plugins to record their loading, and at the same
203
        # time validate that the location the plugins should record to is
204
        # valid and correct.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
205
        breezy.tests.test_plugins.TestLoadingPlugins.activeattributes \
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
206
            [tempattribute] = []
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
207
        self.assertTrue(tempattribute in self.activeattributes)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
208
        # create two plugin directories
209
        os.mkdir('first')
210
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
211
        # write plugins that will record when they are loaded in the
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
212
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
213
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
214
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
215
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
216
        with open(os.path.join('first', 'pluginone.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
217
            outfile.write(template % (tempattribute, 'first'))
218
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
219
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
220
        with open(os.path.join('second', 'plugintwo.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
221
            outfile.write(template % (tempattribute, 'second'))
222
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
223
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
224
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
225
            self.assertPluginUnknown('pluginone')
226
            self.assertPluginUnknown('plugintwo')
227
            self.update_module_paths(['first', 'second'])
228
            exec("import %spluginone" % self.module_prefix)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
229
            self.assertEqual(['first'], self.activeattributes[tempattribute])
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
230
            exec("import %splugintwo" % self.module_prefix)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
231
            self.assertEqual(['first', 'second'],
232
                self.activeattributes[tempattribute])
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
233
        finally:
234
            del self.activeattributes[tempattribute]
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
235
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
236
    def test_plugins_can_load_from_directory_with_trailing_slash(self):
237
        # This test tests that a plugin can load from a directory when the
238
        # directory in the path has a trailing slash.
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
239
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
240
        self.assertPluginUnknown('ts_plugin')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
241
        tempattribute = "trailing-slash"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
242
        self.assertFalse(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
243
        # set a place for the plugin to record its loading, and at the same
244
        # time validate that the location the plugin should record to is
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
245
        # valid and correct.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
246
        breezy.tests.test_plugins.TestLoadingPlugins.activeattributes \
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
247
            [tempattribute] = []
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
248
        self.assertTrue(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
249
        # create a directory for the plugin
250
        os.mkdir('plugin_test')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
251
        # write a plugin that will record when its loaded in the
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
252
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
253
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
254
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
255
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
256
        with open(os.path.join('plugin_test', 'ts_plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
257
            outfile.write(template % (tempattribute, 'plugin'))
2911.6.4 by Blake Winton
Fix test failures
258
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
259
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
260
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
261
            self.load_with_paths(['plugin_test'+os.sep])
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
262
            self.assertEqual(['plugin'], self.activeattributes[tempattribute])
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
263
            self.assertPluginKnown('ts_plugin')
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
264
        finally:
265
            del self.activeattributes[tempattribute]
266
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
267
    def load_and_capture(self, name):
268
        """Load plugins from '.' capturing the output.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
269
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
270
        :param name: The name of the plugin.
271
        :return: A string with the log from the plugin loading call.
272
        """
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
273
        # Capture output
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
274
        stream = StringIO()
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
275
        try:
276
            handler = logging.StreamHandler(stream)
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
277
            log = logging.getLogger('brz')
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
278
            log.addHandler(handler)
279
            try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
280
                self.load_with_paths(['.'])
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
281
            finally:
282
                # Stop capturing output
283
                handler.flush()
284
                handler.close()
285
                log.removeHandler(handler)
286
            return stream.getvalue()
287
        finally:
288
            stream.close()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
289
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
290
    def test_plugin_with_bad_api_version_reports(self):
5616.7.3 by Martin Pool
Put plugin warnings into both the apport and plain crash report
291
        """Try loading a plugin that requests an unsupported api.
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
292
5616.7.12 by Martin Pool
Comment correction
293
        Observe that it records the problem but doesn't complain on stderr.
5616.7.7 by Martin Pool
Paper over test global state dependency
294
295
        See https://bugs.launchpad.net/bzr/+bug/704195
5616.7.3 by Martin Pool
Put plugin warnings into both the apport and plain crash report
296
        """
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
297
        name = 'wants100.py'
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
298
        with open(name, 'w') as f:
6672.1.2 by Jelmer Vernooij
Remove breezy.api.
299
            f.write("import breezy\n"
300
                "from breezy.errors import IncompatibleVersion\n"
301
                "raise IncompatibleVersion(breezy, [(1, 0, 0)], (0, 0, 5))\n")
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
302
        log = self.load_and_capture(name)
5616.7.1 by Martin Pool
Record but don't show warnings about updated plugins
303
        self.assertNotContainsRe(log,
6672.1.2 by Jelmer Vernooij
Remove breezy.api.
304
            r"It supports breezy version")
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
305
        self.assertEqual({'wants100'}, viewkeys(self.plugin_warnings))
5616.7.1 by Martin Pool
Record but don't show warnings about updated plugins
306
        self.assertContainsRe(
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
307
            self.plugin_warnings['wants100'][0],
6672.1.2 by Jelmer Vernooij
Remove breezy.api.
308
            r"It supports breezy version")
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
309
310
    def test_plugin_with_bad_name_does_not_load(self):
311
        # The file name here invalid for a python module.
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
312
        name = 'brz-bad plugin-name..py'
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
313
        open(name, 'w').close()
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
314
        log = self.load_and_capture(name)
315
        self.assertContainsRe(log,
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
316
            r"Unable to load 'brz-bad plugin-name\.' in '\.' as a plugin "
3290.1.1 by James Westby
Strip "bzr_" from the start of the suggested plugin name.
317
            "because the file path isn't a valid module name; try renaming "
318
            "it to 'bad_plugin_name_'\.")
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
319
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
320
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
321
class TestPlugins(BaseTestPlugins):
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
322
323
    def setup_plugin(self, source=""):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
324
        # This test tests a new plugin appears in breezy.plugin.plugins().
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
325
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
326
        self.assertPluginUnknown('plugin')
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
327
        # write a plugin that _cannot_ fail to load.
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
328
        with open('plugin.py', 'w') as f: f.write(source + '\n')
329
        self.load_with_paths(['.'])
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
330
6759.4.3 by Jelmer Vernooij
Avoid accessing global state.
331
    def test_plugin_loaded(self):
332
        self.assertPluginUnknown('plugin')
333
        self.assertIs(None, breezy.plugin.get_loaded_plugin('plugin'))
334
        self.setup_plugin()
335
        p = breezy.plugin.get_loaded_plugin('plugin')
336
        self.assertIsInstance(p, breezy.plugin.PlugIn)
337
        self.assertIs(p.module, sys.modules[self.module_prefix + 'plugin'])
338
6780.1.1 by Jelmer Vernooij
Check for plugin existing in sys.modules but being None.
339
    def test_plugin_loaded_disabled(self):
340
        self.assertPluginUnknown('plugin')
341
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'plugin')
342
        self.setup_plugin()
343
        self.assertIs(None, breezy.plugin.get_loaded_plugin('plugin'))
344
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
345
    def test_plugin_appears_in_plugins(self):
346
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
347
        self.assertPluginKnown('plugin')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
348
        p = self.plugins['plugin']
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
349
        self.assertIsInstance(p, breezy.plugin.PlugIn)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
350
        self.assertIs(p.module, sys.modules[self.module_prefix + 'plugin'])
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
351
352
    def test_trivial_plugin_get_path(self):
353
        self.setup_plugin()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
354
        p = self.plugins['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
355
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
356
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
357
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
358
    def test_plugin_get_path_py_not_pyc(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
359
        # first import creates plugin.pyc
360
        self.setup_plugin()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
361
        self.promote_cache(self.test_dir)
362
        self.reset()
363
        self.load_with_paths(['.']) # import plugin.pyc
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
364
        p = plugin.plugins()['plugin']
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
365
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
366
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
367
368
    def test_plugin_get_path_pyc_only(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
369
        # first import creates plugin.pyc (or plugin.pyo depending on __debug__)
370
        self.setup_plugin()
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
371
        os.unlink(self.test_dir + '/plugin.py')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
372
        self.promote_cache(self.test_dir)
373
        self.reset()
374
        self.load_with_paths(['.']) # import plugin.pyc (or .pyo)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
375
        p = plugin.plugins()['plugin']
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
376
        plugin_path = self.test_dir + '/plugin' + plugin.COMPILED_EXT
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
377
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
378
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
379
    def test_no_test_suite_gives_None_for_test_suite(self):
380
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
381
        p = plugin.plugins()['plugin']
382
        self.assertEqual(None, p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
383
384
    def test_test_suite_gives_test_suite_result(self):
385
        source = """def test_suite(): return 'foo'"""
386
        self.setup_plugin(source)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
387
        p = plugin.plugins()['plugin']
388
        self.assertEqual('foo', p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
389
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
390
    def test_no_load_plugin_tests_gives_None_for_load_plugin_tests(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
391
        self.setup_plugin()
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
392
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
393
        p = plugin.plugins()['plugin']
394
        self.assertEqual(None, p.load_plugin_tests(loader))
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
395
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
396
    def test_load_plugin_tests_gives_load_plugin_tests_result(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
397
        source = """
6625.1.5 by Martin
Drop custom load_tests implementation and use unittest signature
398
def load_tests(loader, standard_tests, pattern):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
399
    return 'foo'"""
400
        self.setup_plugin(source)
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
401
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
402
        p = plugin.plugins()['plugin']
403
        self.assertEqual('foo', p.load_plugin_tests(loader))
404
405
    def check_version_info(self, expected, source='', name='plugin'):
406
        self.setup_plugin(source)
407
        self.assertEqual(expected, plugin.plugins()[name].version_info())
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
408
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
409
    def test_no_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
410
        self.check_version_info(None)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
411
412
    def test_with_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
413
        self.check_version_info((1, 2, 3, 'dev', 4),
414
                                "version_info = (1, 2, 3, 'dev', 4)")
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
415
416
    def test_short_version_info_gets_padded(self):
417
        # the gtk plugin has version_info = (1,2,3) rather than the 5-tuple.
418
        # so we adapt it
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
419
        self.check_version_info((1, 2, 3, 'final', 0),
420
                                "version_info = (1, 2, 3)")
421
422
    def check_version(self, expected, source=None, name='plugin'):
423
        self.setup_plugin(source)
424
        self.assertEqual(expected, plugins[name].__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
425
426
    def test_no_version_info___version__(self):
427
        self.setup_plugin()
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
428
        plugin = breezy.plugin.plugins()['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
429
        self.assertEqual("unknown", plugin.__version__)
430
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
431
    def test_str__version__with_version_info(self):
432
        self.setup_plugin("version_info = '1.2.3'")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
433
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
434
        self.assertEqual("1.2.3", plugin.__version__)
435
436
    def test_noniterable__version__with_version_info(self):
437
        self.setup_plugin("version_info = (1)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
438
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
439
        self.assertEqual("1", plugin.__version__)
440
441
    def test_1__version__with_version_info(self):
442
        self.setup_plugin("version_info = (1,)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
443
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
444
        self.assertEqual("1", plugin.__version__)
445
446
    def test_1_2__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
447
        self.setup_plugin("version_info = (1, 2)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
448
        plugin = breezy.plugin.plugins()['plugin']
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
449
        self.assertEqual("1.2", plugin.__version__)
450
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
451
    def test_1_2_3__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
452
        self.setup_plugin("version_info = (1, 2, 3)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
453
        plugin = breezy.plugin.plugins()['plugin']
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
454
        self.assertEqual("1.2.3", plugin.__version__)
455
456
    def test_candidate__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
457
        self.setup_plugin("version_info = (1, 2, 3, 'candidate', 1)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
458
        plugin = breezy.plugin.plugins()['plugin']
3777.6.4 by Marius Kruger
fix tests
459
        self.assertEqual("1.2.3rc1", plugin.__version__)
460
461
    def test_dev__version__with_version_info(self):
462
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 0)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
463
        plugin = breezy.plugin.plugins()['plugin']
3777.6.4 by Marius Kruger
fix tests
464
        self.assertEqual("1.2.3dev", plugin.__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
465
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
466
    def test_dev_fallback__version__with_version_info(self):
467
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 4)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
468
        plugin = breezy.plugin.plugins()['plugin']
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
469
        self.assertEqual("1.2.3dev4", plugin.__version__)
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
470
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
471
    def test_final__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
472
        self.setup_plugin("version_info = (1, 2, 3, 'final', 0)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
473
        plugin = breezy.plugin.plugins()['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
474
        self.assertEqual("1.2.3", plugin.__version__)
475
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
476
    def test_final_fallback__version__with_version_info(self):
477
        self.setup_plugin("version_info = (1, 2, 3, 'final', 2)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
478
        plugin = breezy.plugin.plugins()['plugin']
5851.2.2 by Martin Pool
Format plugin version as 1.2.3.2 not 1.2.3.final.2
479
        self.assertEqual("1.2.3.2", plugin.__version__)
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
480
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
481
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
482
# GZ 2017-06-02: Move this suite to blackbox, as it's what it actually is.
483
class TestPluginHelp(BaseTestPlugins):
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
484
485
    def split_help_commands(self):
486
        help = {}
487
        current = None
3908.1.1 by Andrew Bennetts
Try harder to avoid loading plugins during the test suite.
488
        out, err = self.run_bzr('--no-plugins help commands')
489
        for line in out.splitlines():
2034.1.2 by Aaron Bentley
Fix testcase
490
            if not line.startswith(' '):
491
                current = line.split()[0]
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
492
            help[current] = help.get(current, '') + line
493
494
        return help
495
496
    def test_plugin_help_builtins_unaffected(self):
497
        # Check we don't get false positives
498
        help_commands = self.split_help_commands()
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
499
        for cmd_name in breezy.commands.builtin_command_names():
500
            if cmd_name in breezy.commands.plugin_command_names():
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
501
                continue
502
            try:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
503
                help = breezy.commands.get_cmd_object(cmd_name).get_help_text()
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
504
            except NotImplementedError:
505
                # some commands have no help
506
                pass
507
            else:
2666.1.1 by Ian Clatworthy
Bazaar User Reference generated from online help
508
                self.assertNotContainsRe(help, 'plugin "[^"]*"')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
509
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
510
            if cmd_name in help_commands:
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
511
                # some commands are hidden
512
                help = help_commands[cmd_name]
2666.1.1 by Ian Clatworthy
Bazaar User Reference generated from online help
513
                self.assertNotContainsRe(help, 'plugin "[^"]*"')
1733.2.5 by Michael Ellerman
Show which plugin (if any) provides a command.
514
515
    def test_plugin_help_shows_plugin(self):
516
        # Create a test plugin
517
        os.mkdir('plugin_test')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
518
        source = (
519
            "from breezy import commands\n"
520
            "class cmd_myplug(commands.Command):\n"
521
            "    __doc__ = '''Just a simple test plugin.'''\n"
522
            "    aliases = ['mplg']\n"
523
            "    def run(self):\n"
524
            "        print ('Hello from my plugin')\n"
525
        )
526
        self.create_plugin('myplug', source, 'plugin_test')
527
528
        # Check its help
529
        self.load_with_paths(['plugin_test'])
530
        myplug = self.plugins['myplug'].module
531
        breezy.commands.register_command(myplug.cmd_myplug)
532
        self.addCleanup(breezy.commands.plugin_cmds.remove, 'myplug')
533
        help = self.run_bzr('help myplug')[0]
534
        self.assertContainsRe(help, 'plugin "myplug"')
535
        help = self.split_help_commands()['myplug']
536
        self.assertContainsRe(help, '\[myplug\]')
2215.4.1 by Alexander Belchenko
Bugfix #68124: Allow plugins import from zip archives.
537
538
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
539
class TestHelpIndex(tests.TestCase):
540
    """Tests for the PluginsHelpIndex class."""
541
542
    def test_default_constructable(self):
543
        index = plugin.PluginsHelpIndex()
544
545
    def test_get_topics_None(self):
546
        """Searching for None returns an empty list."""
547
        index = plugin.PluginsHelpIndex()
548
        self.assertEqual([], index.get_topics(None))
549
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
550
    def test_get_topics_for_plugin(self):
551
        """Searching for plugin name gets its docstring."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
552
        index = plugin.PluginsHelpIndex()
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
553
        # make a new plugin here for this test, even if we're run with
554
        # --no-plugins
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
555
        self.assertFalse('breezy.plugins.demo_module' in sys.modules)
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
556
        demo_module = FakeModule('', 'breezy.plugins.demo_module')
557
        sys.modules['breezy.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
558
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
559
            topics = index.get_topics('demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
560
            self.assertEqual(1, len(topics))
561
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
562
            self.assertEqual(demo_module, topics[0].module)
563
        finally:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
564
            del sys.modules['breezy.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
565
566
    def test_get_topics_no_topic(self):
567
        """Searching for something that is not a plugin returns []."""
568
        # test this by using a name that cannot be a plugin - its not
569
        # a valid python identifier.
570
        index = plugin.PluginsHelpIndex()
571
        self.assertEqual([], index.get_topics('nothing by this name'))
572
573
    def test_prefix(self):
574
        """PluginsHelpIndex has a prefix of 'plugins/'."""
575
        index = plugin.PluginsHelpIndex()
576
        self.assertEqual('plugins/', index.prefix)
577
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
578
    def test_get_plugin_topic_with_prefix(self):
579
        """Searching for plugins/demo_module returns help."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
580
        index = plugin.PluginsHelpIndex()
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
581
        self.assertFalse('breezy.plugins.demo_module' in sys.modules)
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
582
        demo_module = FakeModule('', 'breezy.plugins.demo_module')
583
        sys.modules['breezy.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
584
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
585
            topics = index.get_topics('plugins/demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
586
            self.assertEqual(1, len(topics))
587
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
588
            self.assertEqual(demo_module, topics[0].module)
589
        finally:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
590
            del sys.modules['breezy.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
591
592
593
class FakeModule(object):
594
    """A fake module to test with."""
595
596
    def __init__(self, doc, name):
597
        self.__doc__ = doc
598
        self.__name__ = name
599
600
601
class TestModuleHelpTopic(tests.TestCase):
602
    """Tests for the ModuleHelpTopic class."""
603
604
    def test_contruct(self):
605
        """Construction takes the module to document."""
606
        mod = FakeModule('foo', 'foo')
607
        topic = plugin.ModuleHelpTopic(mod)
608
        self.assertEqual(mod, topic.module)
609
610
    def test_get_help_text_None(self):
611
        """A ModuleHelpTopic returns the docstring for get_help_text."""
612
        mod = FakeModule(None, 'demo')
613
        topic = plugin.ModuleHelpTopic(mod)
614
        self.assertEqual("Plugin 'demo' has no docstring.\n",
615
            topic.get_help_text())
616
617
    def test_get_help_text_no_carriage_return(self):
618
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
619
        mod = FakeModule('one line of help', 'demo')
620
        topic = plugin.ModuleHelpTopic(mod)
621
        self.assertEqual("one line of help\n",
622
            topic.get_help_text())
623
624
    def test_get_help_text_carriage_return(self):
625
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
626
        mod = FakeModule('two lines of help\nand more\n', 'demo')
627
        topic = plugin.ModuleHelpTopic(mod)
628
        self.assertEqual("two lines of help\nand more\n",
629
            topic.get_help_text())
630
631
    def test_get_help_text_with_additional_see_also(self):
632
        mod = FakeModule('two lines of help\nand more', 'demo')
633
        topic = plugin.ModuleHelpTopic(mod)
6059.3.6 by Vincent Ladeuil
Fix tests failing on pqm.
634
        self.assertEqual("two lines of help\nand more\n\n:See also: bar, foo\n",
635
                         topic.get_help_text(['foo', 'bar']))
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
636
637
    def test_get_help_topic(self):
638
        """The help topic for a plugin is its module name."""
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
639
        mod = FakeModule('two lines of help\nand more', 'breezy.plugins.demo')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
640
        topic = plugin.ModuleHelpTopic(mod)
641
        self.assertEqual('demo', topic.get_help_topic())
6059.3.6 by Vincent Ladeuil
Fix tests failing on pqm.
642
        mod = FakeModule('two lines of help\nand more',
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
643
                         'breezy.plugins.foo_bar')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
644
        topic = plugin.ModuleHelpTopic(mod)
645
        self.assertEqual('foo_bar', topic.get_help_topic())
3835.2.7 by Aaron Bentley
Add tests for plugins
646
647
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
648
class TestEnvPluginPath(tests.TestCase):
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
649
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
650
    user = "USER"
651
    core = "CORE"
652
    site = "SITE"
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
653
654
    def check_path(self, expected_dirs, setting_dirs):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
655
        if setting_dirs is None:
656
            del os.environ['BRZ_PLUGIN_PATH']
657
        else:
658
            os.environ['BRZ_PLUGIN_PATH'] = os.pathsep.join(setting_dirs)
659
        actual = [(p if t == 'path' else t.upper())
660
            for p, t in plugin._env_plugin_path()]
661
        self.assertEqual(expected_dirs, actual)
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
662
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
663
    def test_default(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
664
        self.check_path([self.user, self.core, self.site],
665
                        None)
666
667
    def test_adhoc_policy(self):
668
        self.check_path([self.user, self.core, self.site],
669
                        ['+user', '+core', '+site'])
670
671
    def test_fallback_policy(self):
672
        self.check_path([self.core, self.site, self.user],
673
                        ['+core', '+site', '+user'])
674
675
    def test_override_policy(self):
676
        self.check_path([self.user, self.site, self.core],
677
                        ['+user', '+site', '+core'])
678
679
    def test_disable_user(self):
680
        self.check_path([self.core, self.site], ['-user'])
681
682
    def test_disable_user_twice(self):
683
        # Ensures multiple removals don't left cruft
684
        self.check_path([self.core, self.site], ['-user', '-user'])
685
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
686
    def test_duplicates_are_removed(self):
687
        self.check_path([self.user, self.core, self.site],
688
                        ['+user', '+user'])
689
        # And only the first reference is kept (since the later references will
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
690
        # only produce '<plugin> already loaded' mutters)
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
691
        self.check_path([self.user, self.core, self.site],
692
                        ['+user', '+user', '+core',
693
                         '+user', '+site', '+site',
694
                         '+core'])
695
5086.1.5 by Vincent Ladeuil
Fix typo in test name.
696
    def test_disable_overrides_enable(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
697
        self.check_path([self.core, self.site], ['-user', '+user'])
698
699
    def test_disable_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
700
        self.check_path([self.site], ['-core'])
701
        self.check_path([self.user, self.site], ['+user', '-core'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
702
703
    def test_disable_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
704
        self.check_path([self.core], ['-site'])
705
        self.check_path([self.user, self.core], ['-site', '+user'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
706
707
    def test_override_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
708
        self.check_path(['mysite', self.user, self.core],
709
                        ['mysite', '-site', '+user'])
710
        self.check_path(['mysite', self.core],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
711
                        ['mysite', '-site'])
712
713
    def test_override_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
714
        self.check_path(['mycore', self.user, self.site],
715
                        ['mycore', '-core', '+user', '+site'])
716
        self.check_path(['mycore', self.site],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
717
                        ['mycore', '-core'])
718
719
    def test_my_plugin_only(self):
720
        self.check_path(['myplugin'], ['myplugin', '-user', '-core', '-site'])
721
722
    def test_my_plugin_first(self):
723
        self.check_path(['myplugin', self.core, self.site, self.user],
724
                        ['myplugin', '+core', '+site', '+user'])
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
725
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
726
    def test_bogus_references(self):
727
        self.check_path(['+foo', '-bar', self.core, self.site],
728
                        ['+foo', '-bar'])
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
729
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
730
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
731
class TestDisablePlugin(BaseTestPlugins):
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
732
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
733
    def test_cannot_import(self):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
734
        self.create_plugin_package('works')
735
        self.create_plugin_package('fails')
736
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'fails')
737
        self.update_module_paths(["."])
738
        import breezy.testingplugins.works as works
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
739
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
740
            import breezy.testingplugins.fails as fails
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
741
        except ImportError:
742
            pass
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
743
        else:
744
            self.fail("Loaded blocked plugin: " + repr(fails))
745
        self.assertPluginModules({'fails': None, 'works': works})
746
747
    def test_partial_imports(self):
748
        self.create_plugin('good')
749
        self.create_plugin('bad')
750
        self.create_plugin_package('ugly')
751
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'bad:ugly')
752
        self.load_with_paths(['.'])
753
        self.assertEqual({'good'}, viewkeys(self.plugins))
754
        self.assertPluginModules({
755
            'good': self.plugins['good'].module,
756
            'bad': None,
757
            'ugly': None,
758
        })
759
        # Ensure there are no warnings about plugins not being imported as
760
        # the user has explictly requested they be disabled.
761
        self.assertNotContainsRe(self.get_log(), r"Unable to load plugin")
762
763
764
class TestEnvDisablePlugins(tests.TestCase):
765
766
    def _get_names(self, env_value):
767
        os.environ['BRZ_DISABLE_PLUGINS'] = env_value
768
        return plugin._env_disable_plugins()
769
770
    def test_unset(self):
771
        self.assertEqual([], plugin._env_disable_plugins())
772
773
    def test_empty(self):
774
        self.assertEqual([], self._get_names(''))
775
776
    def test_single(self):
777
        self.assertEqual(['single'], self._get_names('single'))
778
779
    def test_multi(self):
780
        expected = ['one', 'two']
781
        self.assertEqual(expected, self._get_names(os.pathsep.join(expected)))
782
783
    def test_mixed(self):
784
        value = os.pathsep.join(['valid', 'in-valid'])
785
        self.assertEqual(['valid'], self._get_names(value))
786
        self.assertContainsRe(self.get_log(),
787
            r"Invalid name 'in-valid' in BRZ_DISABLE_PLUGINS=" + repr(value))
788
789
790
class TestEnvPluginsAt(tests.TestCase):
791
792
    def _get_paths(self, env_value):
793
        os.environ['BRZ_PLUGINS_AT'] = env_value
794
        return plugin._env_plugins_at()
795
796
    def test_empty(self):
797
        self.assertEqual([], plugin._env_plugins_at())
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
798
        self.assertEqual([], self._get_paths(''))
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
799
800
    def test_one_path(self):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
801
        self.assertEqual([('b', 'man')], self._get_paths('b@man'))
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
802
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
803
    def test_multiple(self):
804
        self.assertEqual(
805
            [('tools', 'bzr-tools'), ('p', 'play.py')],
806
            self._get_paths(os.pathsep.join(('tools@bzr-tools', 'p@play.py'))))
807
808
    def test_many_at(self):
809
        self.assertEqual(
810
            [('church', 'StMichael@Plea@Norwich')],
811
            self._get_paths('church@StMichael@Plea@Norwich'))
812
813
    def test_only_py(self):
814
        self.assertEqual([('test', './test.py')], self._get_paths('./test.py'))
815
816
    def test_only_package(self):
817
        self.assertEqual([('py', '/opt/b/py')], self._get_paths('/opt/b/py'))
818
819
    def test_bad_name(self):
820
        self.assertEqual([], self._get_paths('/usr/local/bzr-git'))
821
        self.assertContainsRe(self.get_log(),
822
            r"Invalid name 'bzr-git' in BRZ_PLUGINS_AT='/usr/local/bzr-git'")
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
823
824
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
825
class TestLoadPluginAt(BaseTestPlugins):
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
826
827
    def setUp(self):
828
        super(TestLoadPluginAt, self).setUp()
829
        # Create the same plugin in two directories
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
830
        self.create_plugin_package('test_foo', dir='non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
831
        # The "normal" directory, we use 'standard' instead of 'plugins' to
832
        # avoid depending on the precise naming.
833
        self.create_plugin_package('test_foo', dir='standard/test_foo')
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
834
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
835
    def assertTestFooLoadedFrom(self, path):
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
836
        self.assertPluginKnown('test_foo')
5131.2.1 by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings
837
        self.assertDocstring('This is the doc for test_foo',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
838
                             self.module.test_foo)
839
        self.assertEqual(path, self.module.test_foo.dir_source)
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
840
841
    def test_regular_load(self):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
842
        self.load_with_paths(['standard'])
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
843
        self.assertTestFooLoadedFrom('standard/test_foo')
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
844
845
    def test_import(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
846
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
847
        self.update_module_paths(['standard'])
848
        import breezy.testingplugins.test_foo
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
849
        self.assertTestFooLoadedFrom('non-standard-dir')
850
851
    def test_loading(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
852
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
853
        self.load_with_paths(['standard'])
854
        self.assertTestFooLoadedFrom('non-standard-dir')
855
856
    def test_loading_other_name(self):
857
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
858
        os.rename('standard/test_foo', 'standard/test_bar')
859
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
860
        self.assertTestFooLoadedFrom('non-standard-dir')
861
862
    def test_compiled_loaded(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
863
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
864
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
865
        self.assertTestFooLoadedFrom('non-standard-dir')
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
866
        self.assertIsSameRealPath('non-standard-dir/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
867
                                  self.module.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
868
869
        # Try importing again now that the source has been compiled
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
870
        os.remove('non-standard-dir/__init__.py')
871
        self.promote_cache('non-standard-dir')
872
        self.reset()
873
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
874
        self.assertTestFooLoadedFrom('non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
875
        suffix = plugin.COMPILED_EXT
876
        self.assertIsSameRealPath('non-standard-dir/__init__' + suffix,
877
                                  self.module.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
878
879
    def test_submodule_loading(self):
880
        # We create an additional directory under the one for test_foo
881
        self.create_plugin_package('test_bar', dir='non-standard-dir/test_bar')
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
882
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
883
        self.update_module_paths(['standard'])
884
        import breezy.testingplugins.test_foo
885
        self.assertEqual(self.module_prefix + 'test_foo',
886
                         self.module.test_foo.__package__)
887
        import breezy.testingplugins.test_foo.test_bar
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
888
        self.assertIsSameRealPath('non-standard-dir/test_bar/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
889
                                  self.module.test_foo.test_bar.__file__)
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
890
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
891
    def test_relative_submodule_loading(self):
892
        self.create_plugin_package('test_foo', dir='another-dir', source='''
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
893
from . import test_bar
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
894
''')
895
        # We create an additional directory under the one for test_foo
896
        self.create_plugin_package('test_bar', dir='another-dir/test_bar')
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
897
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@another-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
898
        self.update_module_paths(['standard'])
899
        import breezy.testingplugins.test_foo
900
        self.assertEqual(self.module_prefix + 'test_foo',
901
                         self.module.test_foo.__package__)
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
902
        self.assertIsSameRealPath('another-dir/test_bar/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
903
                                  self.module.test_foo.test_bar.__file__)
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
904
5086.5.15 by Vincent Ladeuil
Fixed as per Ian's review.
905
    def test_loading_from___init__only(self):
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
906
        # We rename the existing __init__.py file to ensure that we don't load
907
        # a random file
908
        init = 'non-standard-dir/__init__.py'
909
        random = 'non-standard-dir/setup.py'
910
        os.rename(init, random)
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
911
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
912
        self.load_with_paths(['standard'])
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
913
        self.assertPluginUnknown('test_foo')
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
914
915
    def test_loading_from_specific_file(self):
916
        plugin_dir = 'non-standard-dir'
917
        plugin_file_name = 'iamtestfoo.py'
918
        plugin_path = osutils.pathjoin(plugin_dir, plugin_file_name)
919
        source = '''\
920
"""This is the doc for %s"""
921
dir_source = '%s'
922
''' % ('test_foo', plugin_path)
923
        self.create_plugin('test_foo', source=source,
924
                           dir=plugin_dir, file_name=plugin_file_name)
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
925
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@%s' % plugin_path)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
926
        self.load_with_paths(['standard'])
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
927
        self.assertTestFooLoadedFrom(plugin_path)
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
928
929
930
class TestDescribePlugins(BaseTestPlugins):
931
932
    def test_describe_plugins(self):
5616.7.11 by Martin Pool
Additional tests and fixes for refactored describe_plugins.
933
        class DummyModule(object):
934
            __doc__ = 'Hi there'
935
        class DummyPlugin(object):
936
            __version__ = '0.1.0'
937
            module = DummyModule()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
938
        self.plugin_warnings = {'bad': ['Failed to load (just testing)']}
939
        self.plugins = {'good': DummyPlugin()}
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
940
        self.assertEqual("""\
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
941
bad (failed to load)
942
  ** Failed to load (just testing)
943
5616.7.11 by Martin Pool
Additional tests and fixes for refactored describe_plugins.
944
good 0.1.0
945
  Hi there
946
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
947
""", ''.join(plugin.describe_plugins(state=self)))