/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5273.1.9 by Vincent Ladeuil
Merge bzr.dev into cleanup resolving conflicts
1
# Copyright (C) 2006-2010 Canonical Ltd
1534.2.1 by Robert Collins
Implement deprecated_method
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1534.2.1 by Robert Collins
Implement deprecated_method
16
17
"""Symbol versioning
18
19
The methods here allow for api symbol versioning.
20
"""
21
6379.6.7 by Jelmer Vernooij
Move importing from future until after doc string, otherwise the doc string will disappear.
22
from __future__ import absolute_import
23
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
24
__all__ = ['deprecated_function',
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
25
           'deprecated_in',
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
26
           'deprecated_list',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
27
           'deprecated_method',
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
28
           'DEPRECATED_PARAMETER',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
29
           'deprecated_passed',
3400.3.1 by Martin Pool
Remove methods deprecated in zero_eight
30
           'set_warning_method',
31
           'warn',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
32
           ]
1534.2.1 by Robert Collins
Implement deprecated_method
33
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
34
35
import warnings
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
36
# Import the 'warn' symbol so breezy can call it even if we redefine it
1534.2.1 by Robert Collins
Implement deprecated_method
37
from warnings import warn
38
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
39
import breezy
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
40
7067.14.1 by Jelmer Vernooij
Fix symbol versioning on Python 3.
41
from .sixish import PY3
1534.2.1 by Robert Collins
Implement deprecated_method
42
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
43
DEPRECATED_PARAMETER = "A deprecated parameter marker."
1534.2.1 by Robert Collins
Implement deprecated_method
44
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
45
46
def deprecated_in(version_tuple):
47
    """Generate a message that something was deprecated in a release.
48
49
    >>> deprecated_in((1, 4, 0))
4634.50.8 by John Arbash Meinel
it seems there was even a symbol_versioning doctest that I missed.
50
    '%s was deprecated in version 1.4.0.'
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
51
    """
3427.2.5 by John Arbash Meinel
Change deprecated_in to end with a '.'
52
    return ("%%s was deprecated in version %s."
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
53
            % breezy._format_version_tuple(version_tuple))
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
54
1534.2.1 by Robert Collins
Implement deprecated_method
55
56
def set_warning_method(method):
57
    """Set the warning method to be used by this module.
58
59
    It should take a message and a warning category as warnings.warn does.
60
    """
61
    global warn
62
    warn = method
63
64
1534.2.2 by Robert Collins
Implement deprecated_function.
65
# TODO - maybe this would be easier to use as one 'smart' method that
66
# guess if it is a method or a class or an attribute ? If so, we can
67
# add that on top of the primitives, once we have all three written
68
# - RBC 20050105
69
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
70
71
def deprecation_string(a_callable, deprecation_version):
72
    """Generate an automatic deprecation string for a_callable.
73
74
    :param a_callable: The callable to substitute into deprecation_version.
75
    :param deprecation_version: A deprecation format warning string. This should
76
        have a single %s operator in it. a_callable will be turned into a nice
77
        python symbol and then substituted into deprecation_version.
78
    """
7104.1.1 by Jelmer Vernooij
Fix remaining deprecation warning test.
79
    if getattr(a_callable, '__self__', None) is not None:
80
        symbol = "%s.%s.%s" % (a_callable.__self__.__class__.__module__,
81
                               a_callable.__self__.__class__.__name__,
82
                               a_callable.__name__)
83
    elif getattr(a_callable, '__qualname__', None) is not None and not '<' in a_callable.__qualname__:
84
        symbol = "%s.%s" % (a_callable.__module__,
85
                            a_callable.__qualname__)
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
86
    else:
7104.1.1 by Jelmer Vernooij
Fix remaining deprecation warning test.
87
        symbol = "%s.%s" % (a_callable.__module__,
88
                            a_callable.__name__)
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
89
    return deprecation_version % symbol
90
91
1534.2.2 by Robert Collins
Implement deprecated_function.
92
def deprecated_function(deprecation_version):
93
    """Decorate a function so that use of it will trigger a warning."""
94
95
    def function_decorator(callable):
96
        """This is the function python calls to perform the decoration."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
97
1534.2.2 by Robert Collins
Implement deprecated_function.
98
        def decorated_function(*args, **kwargs):
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
99
            """This is the decorated function."""
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
100
            from . import trace
3530.2.2 by John Arbash Meinel
Add extra debugging for when a deprecated function/method are called
101
            trace.mutter_callsite(4, "Deprecated function called")
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
102
            warn(deprecation_string(callable, deprecation_version),
103
                DeprecationWarning, stacklevel=2)
1534.2.2 by Robert Collins
Implement deprecated_function.
104
            return callable(*args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
105
        _populate_decorated(callable, deprecation_version, "function",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
106
                            decorated_function)
1534.2.2 by Robert Collins
Implement deprecated_function.
107
        return decorated_function
108
    return function_decorator
109
110
1534.2.1 by Robert Collins
Implement deprecated_method
111
def deprecated_method(deprecation_version):
112
    """Decorate a method so that use of it will trigger a warning.
2825.3.2 by Martin Pool
doc
113
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
114
    To deprecate a static or class method, use
2825.3.2 by Martin Pool
doc
115
116
        @staticmethod
117
        @deprecated_function
118
        def ...
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
119
1534.2.1 by Robert Collins
Implement deprecated_method
120
    To deprecate an entire class, decorate __init__.
121
    """
122
123
    def method_decorator(callable):
124
        """This is the function python calls to perform the decoration."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
125
1534.2.1 by Robert Collins
Implement deprecated_method
126
        def decorated_method(self, *args, **kwargs):
127
            """This is the decorated method."""
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
128
            from . import trace
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
129
            if callable.__name__ == '__init__':
130
                symbol = "%s.%s" % (self.__class__.__module__,
131
                                    self.__class__.__name__,
132
                                    )
133
            else:
134
                symbol = "%s.%s.%s" % (self.__class__.__module__,
135
                                       self.__class__.__name__,
136
                                       callable.__name__
137
                                       )
3530.2.2 by John Arbash Meinel
Add extra debugging for when a deprecated function/method are called
138
            trace.mutter_callsite(4, "Deprecated method called")
1534.4.26 by Robert Collins
Move working tree initialisation out from Branch.initialize, deprecated Branch.initialize to Branch.create.
139
            warn(deprecation_version % symbol, DeprecationWarning, stacklevel=2)
1534.2.1 by Robert Collins
Implement deprecated_method
140
            return callable(self, *args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
141
        _populate_decorated(callable, deprecation_version, "method",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
142
                            decorated_method)
1534.2.1 by Robert Collins
Implement deprecated_method
143
        return decorated_method
144
    return method_decorator
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
145
146
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
147
def deprecated_passed(parameter_value):
148
    """Return True if parameter_value was used."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
149
    # FIXME: it might be nice to have a parameter deprecation decorator.
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
150
    # it would need to handle positional and *args and **kwargs parameters,
151
    # which means some mechanism to describe how the parameter was being
152
    # passed before deprecation, and some way to deprecate parameters that
153
    # were not at the end of the arg list. Thats needed for __init__ where
154
    # we cannot just forward to a new method name.I.e. in the following
155
    # examples we would want to have callers that pass any value to 'bad' be
156
    # given a warning - because we have applied:
3400.3.4 by Martin Pool
Remove zero_seven deprecations
157
    # @deprecated_parameter('bad', deprecated_in((1, 5, 0))
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
158
    #
159
    # def __init__(self, bad=None)
160
    # def __init__(self, bad, other)
161
    # def __init__(self, **kwargs)
162
    # RBC 20060116
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
163
    return not parameter_value is DEPRECATED_PARAMETER
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
164
165
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
166
def _decorate_docstring(callable, deprecation_version, label,
167
                        decorated_callable):
1732.1.1 by John Arbash Meinel
deprecating appendpath, it does exactly what pathjoin does
168
    if callable.__doc__:
169
        docstring_lines = callable.__doc__.split('\n')
170
    else:
171
        docstring_lines = []
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
172
    if len(docstring_lines) == 0:
173
        decorated_callable.__doc__ = deprecation_version % ("This " + label)
174
    elif len(docstring_lines) == 1:
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
175
        decorated_callable.__doc__ = (callable.__doc__
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
176
                                    + "\n"
177
                                    + "\n"
178
                                    + deprecation_version % ("This " + label)
179
                                    + "\n")
180
    else:
181
        spaces = len(docstring_lines[-1])
182
        new_doc = callable.__doc__
183
        new_doc += "\n" + " " * spaces
184
        new_doc += deprecation_version % ("This " + label)
185
        new_doc += "\n" + " " * spaces
186
        decorated_callable.__doc__ = new_doc
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
187
188
189
def _populate_decorated(callable, deprecation_version, label,
190
                        decorated_callable):
191
    """Populate attributes like __name__ and __doc__ on the decorated callable.
192
    """
193
    _decorate_docstring(callable, deprecation_version, label,
194
                        decorated_callable)
1534.1.3 by Robert Collins
Bugfix the symbol_versioning deprecation decorators to update the
195
    decorated_callable.__module__ = callable.__module__
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
196
    decorated_callable.__name__ = callable.__name__
1581.1.1 by Robert Collins
Bugfix aliases to be backwards compatible with plugins providing command.run_argv.
197
    decorated_callable.is_deprecated = True
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
198
199
2227.1.5 by mbp at sourcefrog
doc cleanup
200
def _dict_deprecation_wrapper(wrapped_method):
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
201
    """Returns a closure that emits a warning and calls the superclass"""
202
    def cb(dep_dict, *args, **kwargs):
203
        msg = 'access to %s' % (dep_dict._variable_name, )
204
        msg = dep_dict._deprecation_version % (msg,)
205
        if dep_dict._advice:
206
            msg += ' ' + dep_dict._advice
207
        warn(msg, DeprecationWarning, stacklevel=2)
2227.1.5 by mbp at sourcefrog
doc cleanup
208
        return wrapped_method(dep_dict, *args, **kwargs)
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
209
    return cb
210
211
212
class DeprecatedDict(dict):
213
    """A dictionary that complains when read or written."""
214
215
    is_deprecated = True
216
217
    def __init__(self,
218
        deprecation_version,
219
        variable_name,
220
        initial_value,
221
        advice,
222
        ):
223
        """Create a dict that warns when read or modified.
224
3400.3.5 by Martin Pool
Remove zero_nine deprecations
225
        :param deprecation_version: string for the warning format to raise,
226
            typically from deprecated_in()
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
227
        :param initial_value: The contents of the dict
228
        :param variable_name: This allows better warnings to be printed
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
229
        :param advice: String of advice on what callers should do instead
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
230
            of using this variable.
231
        """
232
        self._deprecation_version = deprecation_version
233
        self._variable_name = variable_name
234
        self._advice = advice
235
        dict.__init__(self, initial_value)
236
237
    # This isn't every possible method but it should trap anyone using the
238
    # dict -- add more if desired
239
    __len__ = _dict_deprecation_wrapper(dict.__len__)
240
    __getitem__ = _dict_deprecation_wrapper(dict.__getitem__)
241
    __setitem__ = _dict_deprecation_wrapper(dict.__setitem__)
242
    __delitem__ = _dict_deprecation_wrapper(dict.__delitem__)
243
    keys = _dict_deprecation_wrapper(dict.keys)
244
    __contains__ = _dict_deprecation_wrapper(dict.__contains__)
245
246
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
247
def deprecated_list(deprecation_version, variable_name,
248
                    initial_value, extra=None):
249
    """Create a list that warns when modified
250
3400.3.5 by Martin Pool
Remove zero_nine deprecations
251
    :param deprecation_version: string for the warning format to raise,
252
        typically from deprecated_in()
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
253
    :param initial_value: The contents of the list
254
    :param variable_name: This allows better warnings to be printed
255
    :param extra: Extra info to print when printing a warning
256
    """
257
258
    subst_text = 'Modifying %s' % (variable_name,)
259
    msg = deprecation_version % (subst_text,)
260
    if extra:
261
        msg += ' ' + extra
262
263
    class _DeprecatedList(list):
264
        __doc__ = list.__doc__ + msg
265
266
        is_deprecated = True
267
268
        def _warn_deprecated(self, func, *args, **kwargs):
269
            warn(msg, DeprecationWarning, stacklevel=3)
270
            return func(self, *args, **kwargs)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
271
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
272
        def append(self, obj):
273
            """appending to %s is deprecated""" % (variable_name,)
274
            return self._warn_deprecated(list.append, obj)
275
276
        def insert(self, index, obj):
277
            """inserting to %s is deprecated""" % (variable_name,)
278
            return self._warn_deprecated(list.insert, index, obj)
279
280
        def extend(self, iterable):
281
            """extending %s is deprecated""" % (variable_name,)
282
            return self._warn_deprecated(list.extend, iterable)
283
284
        def remove(self, value):
285
            """removing from %s is deprecated""" % (variable_name,)
286
            return self._warn_deprecated(list.remove, value)
287
288
        def pop(self, index=None):
4031.3.1 by Frank Aspell
Fixing various typos
289
            """pop'ing from %s is deprecated""" % (variable_name,)
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
290
            if index:
291
                return self._warn_deprecated(list.pop, index)
292
            else:
293
                # Can't pass None
294
                return self._warn_deprecated(list.pop)
295
296
    return _DeprecatedList(initial_value)
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
297
298
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
299
def _check_for_filter(error_only):
300
    """Check if there is already a filter for deprecation warnings.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
301
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
302
    :param error_only: Only match an 'error' filter
303
    :return: True if a filter is found, False otherwise
304
    """
305
    for filter in warnings.filters:
306
        if issubclass(DeprecationWarning, filter[2]):
307
            # This filter will effect DeprecationWarning
308
            if not error_only or filter[0] == 'error':
309
                return True
310
    return False
311
312
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
313
def _remove_filter_callable(filter):
314
    """Build and returns a callable removing filter from the warnings.
315
316
    :param filter: The filter to remove (can be None).
317
318
    :return: A callable that will remove filter from warnings.filters.
319
    """
320
    def cleanup():
321
        if filter:
322
            warnings.filters.remove(filter)
323
    return cleanup
324
325
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
326
def suppress_deprecation_warnings(override=True):
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
327
    """Call this function to suppress all deprecation warnings.
328
329
    When this is a final release version, we don't want to annoy users with
330
    lots of deprecation warnings. We only want the deprecation warnings when
331
    running a dev or release candidate.
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
332
333
    :param override: If True, always set the ignore, if False, only set the
334
        ignore if there isn't already a filter.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
335
5320.2.1 by Robert Collins
The symbol_versioning module can now cleanup after itself -
336
    :return: A callable to remove the new warnings this added.
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
337
    """
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
338
    if not override and _check_for_filter(error_only=False):
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
339
        # If there is already a filter effecting suppress_deprecation_warnings,
340
        # then skip it.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
341
        filter = None
342
    else:
343
        warnings.filterwarnings('ignore', category=DeprecationWarning)
344
        filter = warnings.filters[0]
345
    return _remove_filter_callable(filter)
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
346
347
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
348
def activate_deprecation_warnings(override=True):
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
349
    """Call this function to activate deprecation warnings.
350
351
    When running in a 'final' release we suppress deprecation warnings.
352
    However, the test suite wants to see them. So when running selftest, we
353
    re-enable the deprecation warnings.
354
355
    Note: warnings that have already been issued under 'ignore' will not be
356
    reported after this point. The 'warnings' module has already marked them as
357
    handled, so they don't get issued again.
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
358
359
    :param override: If False, only add a filter if there isn't an error filter
360
        already. (This slightly differs from suppress_deprecation_warnings, in
361
        because it always overrides everything but -Werror).
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
362
363
    :return: A callable to remove the new warnings this added.
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
364
    """
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
365
    if not override and _check_for_filter(error_only=True):
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
366
        # DeprecationWarnings are already turned into errors, don't downgrade
367
        # them to 'default'.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
368
        filter = None
369
    else:
370
        warnings.filterwarnings('default', category=DeprecationWarning)
371
        filter = warnings.filters[0]
372
    return _remove_filter_callable(filter)