/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5856.1.4 by Jelmer Vernooij
Revert unnecessary change.
57
    tree,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
58
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
59
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
60
from .branch import Branch
61
from .cleanup import OperationWithCleanups
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
62
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
63
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
64
                     ConflictsInTree,
65
                     StrictCommitFailed
66
                     )
67
from .osutils import (get_user_encoding,
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      splitpath,
71
                      )
72
from .trace import mutter, note, is_quiet
73
from .urlutils import unescape_for_display
74
from .i18n import gettext
75
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
6734.1.20 by Jelmer Vernooij
Move errors.
77
class PointlessCommit(BzrError):
78
79
    _fmt = "No changes to commit"
80
81
82
class CannotCommitSelectedFileMerge(BzrError):
83
84
    _fmt = 'Selected-file commit of merges is not supported yet:'\
85
        ' files %(files_str)s'
86
87
    def __init__(self, files):
88
        files_str = ', '.join(files)
89
        BzrError.__init__(self, files=files, files_str=files_str)
90
91
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
92
def filter_excluded(iter_changes, exclude):
93
    """Filter exclude filenames.
94
95
    :param iter_changes: iter_changes function
96
    :param exclude: List of paths to exclude
97
    :return: iter_changes function
98
    """
99
    for change in iter_changes:
100
        old_path = change[1][0]
101
        new_path = change[1][1]
102
103
        new_excluded = (new_path is not None and
104
            is_inside_any(exclude, new_path))
105
106
        old_excluded = (old_path is not None and
107
            is_inside_any(exclude, old_path))
108
109
        if old_excluded and new_excluded:
110
            continue
111
112
        if old_excluded or new_excluded:
113
            # TODO(jelmer): Perhaps raise an error here instead?
114
            continue
115
116
        yield change
117
118
1189 by Martin Pool
- BROKEN: partial support for commit into weave
119
class NullCommitReporter(object):
120
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
121
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
122
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
123
        pass
124
125
    def snapshot_change(self, change, path):
126
        pass
127
128
    def completed(self, revno, rev_id):
129
        pass
130
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
131
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
132
        pass
133
134
    def missing(self, path):
135
        pass
136
137
    def renamed(self, change, old_path, new_path):
138
        pass
139
2789.2.11 by Ian Clatworthy
remove more reporting stuff
140
    def is_verbose(self):
141
        return False
142
143
144
class ReportCommitToLog(NullCommitReporter):
145
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
146
    def _note(self, format, *args):
147
        """Output a message.
148
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
149
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
150
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
151
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
152
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
153
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
154
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
155
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
156
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
157
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
158
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
159
        self._note(
160
            gettext('Committing to: %s'),
161
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
162
163
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
164
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
165
        # self._note goes to the console too; so while we want to log the
166
        # rev_id, we can't trivially only log it. (See bug 526425). Long
167
        # term we should rearrange the reporting structure, but for now
168
        # we just mutter seperately. We mutter the revid and revno together
169
        # so that concurrent bzr invocations won't lead to confusion.
170
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
171
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
172
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
173
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
174
175
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
176
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
177
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
178
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
179
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
180
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
181
    def is_verbose(self):
182
        return True
183
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
184
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
class Commit(object):
186
    """Task of committing a new revision.
187
188
    This is a MethodObject: it accumulates state as the commit is
189
    prepared, and then it is discarded.  It doesn't represent
190
    historical revisions, just the act of recording a new one.
191
192
            missing_ids
193
            Modified to hold a list of files that have been deleted from
194
            the working directory; these should be removed from the
195
            working inventory.
485 by Martin Pool
- move commit code into its own module
196
    """
1189 by Martin Pool
- BROKEN: partial support for commit into weave
197
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
198
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
199
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
200
        """Create a Commit object.
201
202
        :param reporter: the default reporter to use or None to decide later
203
        """
204
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
205
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
206
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
207
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
208
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
209
                        local=False, possible_master_transports=None):
210
        if revprops is None:
211
            revprops = {}
212
        if possible_master_transports is None:
213
            possible_master_transports = []
6973.12.3 by Jelmer Vernooij
Fixes.
214
        if (not u'branch-nick' in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
215
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
216
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
217
                local,
218
                possible_master_transports)
219
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
220
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
221
                # XXX: maybe we should just accept one of them?
222
                raise AssertionError('author property given twice')
223
            if authors:
224
                for individual in authors:
225
                    if '\n' in individual:
226
                        raise AssertionError('\\n is not a valid character '
227
                                'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
228
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
229
        return revprops
230
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
232
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
233
               timestamp=None,
234
               timezone=None,
235
               committer=None,
236
               specific_files=None,
237
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
238
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
239
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
240
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
241
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
242
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
243
               local=False,
244
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
245
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
246
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
247
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
248
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
249
               possible_master_transports=None,
250
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
251
        """Commit working copy as a new revision.
252
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
253
        :param message: the commit message (it or message_callback is required)
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
254
        :param message_callback: A callback: message = message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
255
256
        :param timestamp: if not None, seconds-since-epoch for a
257
            postdated/predated commit.
258
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
259
        :param specific_files: If not None, commit only those files. An empty
260
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
261
262
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
263
            Useful for test or import commands that need to tightly
264
            control what revisions are assigned.  If you duplicate
265
            a revision id that exists elsewhere it is your own fault.
266
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
267
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
268
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
269
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
270
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
271
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
272
            contains unknown files.
273
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
274
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
275
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
276
        :param reporter: the reporter to use or None for the default
277
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
278
        :param recursive: If set to 'down', commit in any subtrees that have
279
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
280
        :param exclude: None or a list of relative paths to exclude from the
281
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
282
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
283
        :param lossy: When committing to a foreign VCS, ignore any
284
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
285
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
286
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
287
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
288
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
289
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
290
        return operation.run(
291
               message=message,
292
               timestamp=timestamp,
293
               timezone=timezone,
294
               committer=committer,
295
               specific_files=specific_files,
296
               rev_id=rev_id,
297
               allow_pointless=allow_pointless,
298
               strict=strict,
299
               verbose=verbose,
300
               working_tree=working_tree,
301
               local=local,
302
               reporter=reporter,
303
               message_callback=message_callback,
304
               recursive=recursive,
305
               exclude=exclude,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
306
               possible_master_transports=possible_master_transports,
307
               lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
308
309
    def _commit(self, operation, message, timestamp, timezone, committer,
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
310
            specific_files, rev_id, allow_pointless, strict, verbose,
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
311
            working_tree, local, reporter, message_callback, recursive,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
312
            exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
313
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
314
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
315
        if working_tree is None:
316
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
317
        else:
318
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
319
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
320
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
321
                if not self.branch.repository.supports_rich_root():
322
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
323
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
324
            if message is not None:
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
325
                if isinstance(message, bytes):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
326
                    message = message.decode(get_user_encoding())
2149.1.3 by Aaron Bentley
Updates from review comments
327
                message_callback = lambda x: message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
328
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
329
                raise BzrError("The message or message_callback keyword"
330
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
331
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
332
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
333
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
334
        if exclude is not None:
335
            self.exclude = sorted(
336
                minimum_path_selection(exclude))
337
        else:
338
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
339
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
340
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
341
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
342
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
343
        # self.specific_files is None to indicate no filter, or any iterable to
344
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
345
        if specific_files is not None:
346
            self.specific_files = sorted(
347
                minimum_path_selection(specific_files))
348
        else:
349
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
350
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
351
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
352
        self.message_callback = message_callback
353
        self.timestamp = timestamp
354
        self.timezone = timezone
355
        self.committer = committer
356
        self.strict = strict
357
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
358
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
359
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
360
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
361
        self.parents = self.work_tree.get_parent_ids()
5582.10.6 by Jelmer Vernooij
Fix ui imports.
362
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
363
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
364
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
365
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
366
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
367
        operation.add_cleanup(self.basis_tree.unlock)
368
        # Cannot commit with conflicts present.
369
        if len(self.work_tree.conflicts()) > 0:
370
            raise ConflictsInTree
371
372
        # Setup the bound branch variables as needed.
373
        self._check_bound_branch(operation, possible_master_transports)
374
375
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
376
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
377
378
        # Complete configuration setup
379
        if reporter is not None:
380
            self.reporter = reporter
381
        elif self.reporter is None:
382
            self.reporter = self._select_reporter()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
383
        if self.config_stack is None:
6449.6.4 by Jelmer Vernooij
Use config stack.
384
            self.config_stack = self.work_tree.get_config_stack()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
385
386
        # Setup the progress bar. As the number of files that need to be
387
        # committed in unknown, progress is reported as stages.
388
        # We keep track of entries separately though and include that
389
        # information in the progress bar during the relevant stages.
390
        self.pb_stage_name = ""
391
        self.pb_stage_count = 0
392
        self.pb_stage_total = 5
393
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
394
            # 2 extra stages: "Uploading data to master branch" and "Merging
395
            # tags to master branch"
396
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
397
        self.pb.show_pct = False
398
        self.pb.show_spinner = False
399
        self.pb.show_eta = False
400
        self.pb.show_count = True
401
        self.pb.show_bar = True
402
403
        # After a merge, a selected file commit is not supported.
404
        # See 'bzr help merge' for an explanation as to why.
405
        if len(self.parents) > 1 and self.specific_files is not None:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
406
            raise CannotCommitSelectedFileMerge(self.specific_files)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
407
        # Excludes are a form of selected file commit.
408
        if len(self.parents) > 1 and self.exclude:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
409
            raise CannotCommitSelectedFileMerge(self.exclude)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
410
411
        # Collect the changes
412
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
413
        self._lossy = lossy
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
414
        self.builder = self.branch.get_commit_builder(self.parents,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
415
            self.config_stack, timestamp, timezone, committer, self.revprops,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
416
            rev_id, lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
417
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
418
        if self.builder.updates_branch and self.bound_branch:
419
            self.builder.abort()
420
            raise AssertionError(
421
                "bound branches not supported for commit builders "
422
                "that update the branch")
423
1189 by Martin Pool
- BROKEN: partial support for commit into weave
424
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
425
            # find the location being committed to
426
            if self.bound_branch:
427
                master_location = self.master_branch.base
428
            else:
429
                master_location = self.branch.base
430
431
            # report the start of the commit
432
            self.reporter.started(new_revno, self.rev_id, master_location)
433
434
            self._update_builder_with_changes()
435
            self._check_pointless()
436
437
            # TODO: Now the new inventory is known, check for conflicts.
438
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
439
            # weave lines, because nothing should be recorded until it is known
440
            # that commit will succeed.
441
            self._set_progress_stage("Saving data locally")
442
            self.builder.finish_inventory()
443
444
            # Prompt the user for a commit message if none provided
445
            message = message_callback(self)
446
            self.message = message
447
448
            # Add revision data to the local branch
449
            self.rev_id = self.builder.commit(self.message)
450
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
451
        except Exception as e:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
452
            mutter("aborting commit write group because of exception:")
453
            trace.log_exception_quietly()
454
            self.builder.abort()
455
            raise
456
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
457
        self._update_branches(old_revno, old_revid, new_revno)
458
459
        # Make the working tree be up to date with the branch. This
460
        # includes automatic changes scheduled to be made to the tree, such
461
        # as updating its basis and unversioning paths that were missing.
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
462
        self.work_tree.unversion(self.deleted_paths)
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
463
        self._set_progress_stage("Updating the working tree")
464
        self.work_tree.update_basis_by_delta(self.rev_id,
465
             self.builder.get_basis_delta())
466
        self.reporter.completed(new_revno, self.rev_id)
467
        self._process_post_hooks(old_revno, new_revno)
468
        return self.rev_id
469
470
    def _update_branches(self, old_revno, old_revid, new_revno):
471
        """Update the master and local branch to the new revision.
472
473
        This will try to make sure that the master branch is updated
474
        before the local branch.
475
476
        :param old_revno: Revision number of master branch before the
477
            commit
478
        :param old_revid: Tip of master branch before the commit
479
        :param new_revno: Revision number of the new commit
480
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
481
        if not self.builder.updates_branch:
482
            self._process_pre_hooks(old_revno, new_revno)
483
484
            # Upload revision data to the master.
485
            # this will propagate merged revisions too if needed.
486
            if self.bound_branch:
487
                self._set_progress_stage("Uploading data to master branch")
488
                # 'commit' to the master first so a timeout here causes the
489
                # local branch to be out of date
490
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
491
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
492
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
493
                    self.branch.fetch(self.master_branch, self.rev_id)
494
495
            # and now do the commit locally.
496
            self.branch.set_last_revision_info(new_revno, self.rev_id)
497
        else:
498
            try:
499
                self._process_pre_hooks(old_revno, new_revno)
500
            except:
501
                # The commit builder will already have updated the branch,
502
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
503
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
504
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
505
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
506
        # Merge local tags to remote
507
        if self.bound_branch:
508
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
509
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
510
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
511
            if tag_conflicts:
512
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
6138.3.5 by Jonathan Riddell
make the test suite pass
513
                note( gettext("Conflicting tags in bound branch:\n{0}".format(
514
                    "\n".join(warning_lines))) )
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
515
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
516
    def _select_reporter(self):
517
        """Select the CommitReporter to use."""
518
        if is_quiet():
519
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
520
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
521
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
522
    def _check_pointless(self):
523
        if self.allow_pointless:
524
            return
525
        # A merge with no effect on files
526
        if len(self.parents) > 1:
527
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
528
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
529
            return
530
        raise PointlessCommit()
531
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
532
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
533
        """Check to see if the local branch is bound.
534
535
        If it is bound, then most of the commit will actually be
536
        done using the remote branch as the target branch.
537
        Only at the end will the local branch be updated.
538
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
539
        if self.local and not self.branch.get_bound_location():
540
            raise errors.LocalRequiresBoundBranch()
541
542
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
543
            self.master_branch = self.branch.get_master_branch(
544
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
545
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
546
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
547
            # make this branch the reference branch for out of date checks.
548
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
549
            return
550
551
        # If the master branch is bound, we must fail
552
        master_bound_location = self.master_branch.get_bound_location()
553
        if master_bound_location:
1505.1.27 by John Arbash Meinel
Adding tests against an sftp branch.
554
            raise errors.CommitToDoubleBoundBranch(self.branch,
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
555
                    self.master_branch, master_bound_location)
556
557
        # TODO: jam 20051230 We could automatically push local
558
        #       commits to the remote branch if they would fit.
559
        #       But for now, just require remote to be identical
560
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
561
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
562
        # Make sure the local branch is identical to the master
2249.4.2 by Wouter van Heyst
Convert callers of Branch.revision_history() to Branch.last_revision_info() where sensible.
563
        master_info = self.master_branch.last_revision_info()
564
        local_info = self.branch.last_revision_info()
565
        if local_info != master_info:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
566
            raise errors.BoundBranchOutOfDate(self.branch,
567
                    self.master_branch)
568
569
        # Now things are ready to change the master branch
570
        # so grab the lock
571
        self.bound_branch = self.branch
572
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
573
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
574
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
575
    def _check_out_of_date_tree(self):
576
        """Check that the working tree is up to date.
577
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
578
        :return: old_revision_number, old_revision_id, new_revision_number
579
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
580
        """
581
        try:
582
            first_tree_parent = self.work_tree.get_parent_ids()[0]
583
        except IndexError:
584
            # if there are no parents, treat our parent as 'None'
585
            # this is so that we still consider the master branch
586
            # - in a checkout scenario the tree may have no
587
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
588
            first_tree_parent = breezy.revision.NULL_REVISION
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
589
        old_revno, master_last = self.master_branch.last_revision_info()
590
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
591
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
592
                raise errors.OutOfDateTree(self.work_tree)
593
        if self.branch.repository.has_revision(first_tree_parent):
594
            new_revno = old_revno + 1
595
        else:
596
            # ghost parents never appear in revision history.
597
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
598
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
599
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
600
    def _process_pre_hooks(self, old_revno, new_revno):
601
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
602
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
603
        self._process_hooks("pre_commit", old_revno, new_revno)
604
605
    def _process_post_hooks(self, old_revno, new_revno):
606
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
607
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
608
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
609
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
610
        # 0.15^H^H^H^H 2.5.0)
611
        post_commit = self.config_stack.get('post_commit')
612
        if post_commit is not None:
613
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
614
            # this would be nicer with twisted.python.reflect.namedAny
615
            for hook in hooks:
616
                result = eval(hook + '(branch, rev_id)',
617
                              {'branch':self.branch,
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
618
                               'breezy':breezy,
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
619
                               'rev_id':self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
620
        # process new style post commit hooks
621
        self._process_hooks("post_commit", old_revno, new_revno)
622
623
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
624
        if not Branch.hooks[hook_name]:
625
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
626
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
627
        # new style commit hooks:
628
        if not self.bound_branch:
629
            hook_master = self.branch
630
            hook_local = None
631
        else:
632
            hook_master = self.master_branch
633
            hook_local = self.branch
634
        # With bound branches, when the master is behind the local branch,
635
        # the 'old_revno' and old_revid values here are incorrect.
636
        # XXX: FIXME ^. RBC 20060206
637
        if self.parents:
638
            old_revid = self.parents[0]
639
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
640
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
641
2659.3.9 by NamNguyen
branch.py:
642
        if hook_name == "pre_commit":
643
            future_tree = self.builder.revision_tree()
644
            tree_delta = future_tree.changes_from(self.basis_tree,
645
                                             include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
646
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
647
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
648
            # show the running hook in the progress bar. As hooks may
649
            # end up doing nothing (e.g. because they are not configured by
650
            # the user) this is still showing progress, not showing overall
651
            # actions - its up to each plugin to show a UI if it want's to
652
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
653
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
654
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
655
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
656
            if 'hooks' in debug.debug_flags:
657
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
658
            if hook_name == "post_commit":
659
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
660
                     self.rev_id)
661
            elif hook_name == "pre_commit":
662
                hook(hook_local, hook_master,
663
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
664
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
665
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
666
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
667
        """Update the commit builder with the data about what has changed.
668
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
669
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
670
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
671
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
672
        self._check_strict()
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
673
        iter_changes = self.work_tree.iter_changes(self.basis_tree,
674
            specific_files=specific_files)
675
        if self.exclude:
676
            iter_changes = filter_excluded(iter_changes, self.exclude)
677
        iter_changes = self._filter_iter_changes(iter_changes)
678
        for file_id, path, fs_hash in self.builder.record_iter_changes(
679
            self.work_tree, self.basis_revid, iter_changes):
680
            self.work_tree._observed_sha1(file_id, path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
681
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
682
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
683
        """Process iter_changes.
684
685
        This method reports on the changes in iter_changes to the user, and 
686
        converts 'missing' entries in the iter_changes iterator to 'deleted'
687
        entries. 'missing' entries have their
688
689
        :param iter_changes: An iter_changes to process.
690
        :return: A generator of changes.
691
        """
692
        reporter = self.reporter
693
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
694
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
695
        for change in iter_changes:
696
            if report_changes:
697
                old_path = change[1][0]
698
                new_path = change[1][1]
699
                versioned = change[3][1]
700
            kind = change[6][1]
701
            versioned = change[3][1]
702
            if kind is None and versioned:
703
                # 'missing' path
704
                if report_changes:
705
                    reporter.missing(new_path)
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
706
                deleted_paths.append(change[1][1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
707
                # Reset the new path (None) and new versioned flag (False)
708
                change = (change[0], (change[1][0], None), change[2],
709
                    (change[3][0], False)) + change[4:]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
710
                new_path = change[1][1]
711
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
712
            elif kind == 'tree-reference':
713
                if self.recursive == 'down':
714
                    self._commit_nested_tree(change[0], change[1][1])
715
            if change[3][0] or change[3][1]:
716
                yield change
717
                if report_changes:
718
                    if new_path is None:
719
                        reporter.deleted(old_path)
720
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
721
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
722
                    elif old_path != new_path:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
723
                        reporter.renamed(gettext('renamed'), old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
724
                    else:
725
                        if (new_path or 
726
                            self.work_tree.branch.repository._format.rich_root_data):
727
                            # Don't report on changes to '' in non rich root
728
                            # repositories.
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
729
                            reporter.snapshot_change(gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
730
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
731
        # Unversion files that were found to be deleted
732
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
733
734
    def _check_strict(self):
735
        # XXX: when we use iter_changes this would likely be faster if
736
        # iter_changes would check for us (even in the presence of
737
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
738
        if self.strict:
739
            # raise an exception as soon as we find a single unknown.
740
            for unknown in self.work_tree.unknowns():
741
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
742
2564.2.3 by Ian Clatworthy
more abentley feedback: use get_nested_tree and include file_id
743
    def _commit_nested_tree(self, file_id, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
744
        "Commit a nested tree."
6809.4.1 by Jelmer Vernooij
Swap file_id and path arguments for get_reference_revision and get_nested_tree.
745
        sub_tree = self.work_tree.get_nested_tree(path, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
746
        # FIXME: be more comprehensive here:
747
        # this works when both trees are in --trees repository,
748
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
749
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
750
        # finally implement the explicit-caches approach design
751
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
752
        if sub_tree.branch.repository.has_same_location(
753
            self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
754
            sub_tree.branch.repository = \
755
                self.work_tree.branch.repository
756
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
757
            return sub_tree.commit(message=None, revprops=self.revprops,
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
758
                recursive=self.recursive,
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
759
                message_callback=self.message_callback,
760
                timestamp=self.timestamp, timezone=self.timezone,
761
                committer=self.committer,
762
                allow_pointless=self.allow_pointless,
763
                strict=self.strict, verbose=self.verbose,
764
                local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
765
        except PointlessCommit:
6809.4.1 by Jelmer Vernooij
Swap file_id and path arguments for get_reference_revision and get_nested_tree.
766
            return self.work_tree.get_reference_revision(path, file_id)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
767
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
768
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
769
        """Set the progress stage and emit an update to the progress bar."""
770
        self.pb_stage_name = name
771
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
772
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
773
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
774
        else:
775
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
776
        self._emit_progress()
777
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
778
    def _next_progress_entry(self):
779
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
780
        self.pb_entries_count += 1
781
        self._emit_progress()
782
783
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
784
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
785
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
786
                self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
787
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
788
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
789
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)