/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
7015.1.3 by Martin
Tweak copyright headers
1
# Copyright (C) 2005-2012, 2016 Canonical Ltd
2
# Copyright (C) 2017-2018 Breezy developers
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
3
#
750 by Martin Pool
- stubbed-out tests for python plugins
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
8
#
750 by Martin Pool
- stubbed-out tests for python plugins
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
2052.3.1 by John Arbash Meinel
Add tests to cleanup the copyright of all source files
13
#
750 by Martin Pool
- stubbed-out tests for python plugins
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
16
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
750 by Martin Pool
- stubbed-out tests for python plugins
17
18
"""Tests for plugins"""
19
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
20
import importlib
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
21
import logging
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
22
import os
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
23
import sys
7015.1.1 by Martin
Switch to compatible means of creating a module
24
import types
750 by Martin Pool
- stubbed-out tests for python plugins
25
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
26
import breezy
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
27
from .. import (
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
28
    osutils,
29
    plugin,
30
    tests,
31
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
32
from ..sixish import (
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
33
    StringIO,
34
    viewkeys,
6621.22.2 by Martin
Use BytesIO or StringIO from bzrlib.sixish
35
    )
1141 by Martin Pool
- rename FunctionalTest to TestCaseInTempDir
36
1185.16.83 by mbp at sourcefrog
- notes on testability of plugins
37
1492 by Robert Collins
Support decoration of commands.
38
# TODO: Write a test for plugin decoration of commands.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
39
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
40
invalidate_caches = getattr(importlib, "invalidate_caches", lambda: None)
41
42
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
43
class BaseTestPlugins(tests.TestCaseInTempDir):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
44
    """TestCase that isolates plugin imports and cleans up on completion."""
45
46
    def setUp(self):
47
        super(BaseTestPlugins, self).setUp()
48
        self.module_name = "breezy.testingplugins"
49
        self.module_prefix = self.module_name + "."
7015.1.1 by Martin
Switch to compatible means of creating a module
50
        self.module = types.ModuleType(self.module_name)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
51
52
        self.overrideAttr(plugin, "_MODULE_PREFIX", self.module_prefix)
53
        self.overrideAttr(breezy, "testingplugins", self.module)
54
55
        sys.modules[self.module_name] = self.module
56
        self.addCleanup(self._unregister_all)
57
        self.addCleanup(self._unregister_finder)
58
59
        invalidate_caches()
60
61
    def reset(self):
62
        """Remove all global testing state and clean up module."""
63
        # GZ 2017-06-02: Ideally don't do this, write new test or generate
64
        # bytecode by other mechanism.
65
        self.log("resetting plugin testing context")
66
        self._unregister_all()
67
        self._unregister_finder()
68
        sys.modules[self.module_name] = self.module
69
        for name in list(self.module.__dict__):
70
            if name[:2] != '__':
71
                delattr(self.module, name)
72
        invalidate_caches()
73
        self.plugins = None
74
75
    def update_module_paths(self, paths):
76
        paths = plugin.extend_path(paths, self.module_name)
77
        self.module.__path__ = paths
78
        self.log("using %r", paths)
79
        return paths
80
81
    def load_with_paths(self, paths):
82
        self.log("loading plugins!")
83
        plugin.load_plugins(self.update_module_paths(paths), state=self)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
84
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
85
    def create_plugin(self, name, source=None, dir='.', file_name=None):
86
        if source is None:
87
            source = '''\
88
"""This is the doc for %s"""
89
''' % (name)
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
90
        if file_name is None:
91
            file_name = name + '.py'
92
        # 'source' must not fail to load
5086.1.7 by Vincent Ladeuil
Cleaner fix for bug #411413.
93
        path = osutils.pathjoin(dir, file_name)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
94
        with open(path, 'w') as f:
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
95
            f.write(source + '\n')
96
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
97
    def create_plugin_package(self, name, dir=None, source=None):
98
        if dir is None:
99
            dir = name
100
        if source is None:
101
            source = '''\
102
"""This is the doc for %s"""
103
dir_source = '%s'
104
''' % (name, dir)
105
        os.makedirs(dir)
106
        self.create_plugin(name, source, dir,
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
107
                           file_name='__init__.py')
108
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
109
    def promote_cache(self, directory):
110
        """Move bytecode files out of __pycache__ in given directory."""
111
        cache_dir = os.path.join(directory, '__pycache__')
112
        if os.path.isdir(cache_dir):
113
            for name in os.listdir(cache_dir):
114
                magicless_name = '.'.join(name.split('.')[0::name.count('.')])
115
                rel = osutils.relpath(self.test_dir, cache_dir)
116
                self.log("moving %s in %s to %s", name, rel, magicless_name)
117
                os.rename(os.path.join(cache_dir, name),
7143.15.2 by Jelmer Vernooij
Run autopep8.
118
                          os.path.join(directory, magicless_name))
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
119
120
    def _unregister_finder(self):
121
        """Removes any test copies of _PluginsAtFinder from sys.meta_path."""
122
        idx = len(sys.meta_path)
123
        while idx:
124
            idx -= 1
125
            finder = sys.meta_path[idx]
126
            if getattr(finder, "prefix", "") == self.module_prefix:
127
                self.log("removed %r from sys.meta_path", finder)
128
                sys.meta_path.pop(idx)
129
130
    def _unregister_all(self):
131
        """Remove all plugins in the test namespace from sys.modules."""
132
        for name in list(sys.modules):
133
            if name.startswith(self.module_prefix) or name == self.module_name:
134
                self.log("removed %s from sys.modules", name)
135
                del sys.modules[name]
136
137
    def assertPluginModules(self, plugin_dict):
138
        self.assertEqual(
139
            dict((k[len(self.module_prefix):], sys.modules[k])
7143.15.2 by Jelmer Vernooij
Run autopep8.
140
                 for k in sys.modules if k.startswith(self.module_prefix)),
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
141
            plugin_dict)
5268.6.1 by Vincent Ladeuil
Drive-by fix of the submodule leak.
142
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
143
    def assertPluginUnknown(self, name):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
144
        self.assertTrue(getattr(self.module, name, None) is None)
145
        self.assertFalse(self.module_prefix + name in sys.modules)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
146
147
    def assertPluginKnown(self, name):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
148
        self.assertTrue(getattr(self.module, name, None) is not None)
149
        self.assertTrue(self.module_prefix + name in sys.modules)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
150
151
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
152
class TestLoadingPlugins(BaseTestPlugins):
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
153
154
    activeattributes = {}
155
156
    def test_plugins_with_the_same_name_are_not_loaded(self):
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
157
        # This test tests that having two plugins in different directories does
158
        # not result in both being loaded when they have the same name.  get a
159
        # file name we can use which is also a valid attribute for accessing in
160
        # activeattributes. - we cannot give import parameters.
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
161
        tempattribute = "0"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
162
        self.assertFalse(tempattribute in self.activeattributes)
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
163
        # set a place for the plugins to record their loading, and at the same
164
        # time validate that the location the plugins should record to is
165
        # valid and correct.
7143.15.2 by Jelmer Vernooij
Run autopep8.
166
        self.__class__.activeattributes[tempattribute] = []
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
167
        self.assertTrue(tempattribute in self.activeattributes)
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
168
        # create two plugin directories
169
        os.mkdir('first')
170
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
171
        # write a plugin that will record when its loaded in the
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
172
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
173
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
174
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
175
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
176
        with open(os.path.join('first', 'plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
177
            outfile.write(template % (tempattribute, 'first'))
178
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
179
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
180
        with open(os.path.join('second', 'plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
181
            outfile.write(template % (tempattribute, 'second'))
182
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
183
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
184
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
185
            self.load_with_paths(['first', 'second'])
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
186
            self.assertEqual(['first'], self.activeattributes[tempattribute])
187
        finally:
188
            del self.activeattributes[tempattribute]
189
190
    def test_plugins_from_different_dirs_can_demand_load(self):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
191
        self.assertFalse('breezy.plugins.pluginone' in sys.modules)
192
        self.assertFalse('breezy.plugins.plugintwo' in sys.modules)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
193
        # This test tests that having two plugins in different
194
        # directories with different names allows them both to be loaded, when
195
        # we do a direct import statement.
196
        # Determine a file name we can use which is also a valid attribute
197
        # for accessing in activeattributes. - we cannot give import parameters.
198
        tempattribute = "different-dirs"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
199
        self.assertFalse(tempattribute in self.activeattributes)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
200
        # set a place for the plugins to record their loading, and at the same
201
        # time validate that the location the plugins should record to is
202
        # valid and correct.
7143.15.2 by Jelmer Vernooij
Run autopep8.
203
        breezy.tests.test_plugins.TestLoadingPlugins.activeattributes[tempattribute] = [
204
            ]
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
205
        self.assertTrue(tempattribute in self.activeattributes)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
206
        # create two plugin directories
207
        os.mkdir('first')
208
        os.mkdir('second')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
209
        # write plugins that will record when they are loaded in the
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
210
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
211
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
212
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
213
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
214
        with open(os.path.join('first', 'pluginone.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
215
            outfile.write(template % (tempattribute, 'first'))
216
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
217
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
218
        with open(os.path.join('second', 'plugintwo.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
219
            outfile.write(template % (tempattribute, 'second'))
220
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
221
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
222
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
223
            self.assertPluginUnknown('pluginone')
224
            self.assertPluginUnknown('plugintwo')
225
            self.update_module_paths(['first', 'second'])
226
            exec("import %spluginone" % self.module_prefix)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
227
            self.assertEqual(['first'], self.activeattributes[tempattribute])
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
228
            exec("import %splugintwo" % self.module_prefix)
2256.2.2 by Robert Collins
Allow 'import bzrlib.plugins.NAME' to work when the plugin NAME has not
229
            self.assertEqual(['first', 'second'],
7143.15.2 by Jelmer Vernooij
Run autopep8.
230
                             self.activeattributes[tempattribute])
1515 by Robert Collins
* Plugins with the same name in different directories in the bzr plugin
231
        finally:
232
            del self.activeattributes[tempattribute]
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
233
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
234
    def test_plugins_can_load_from_directory_with_trailing_slash(self):
235
        # This test tests that a plugin can load from a directory when the
236
        # directory in the path has a trailing slash.
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
237
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
238
        self.assertPluginUnknown('ts_plugin')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
239
        tempattribute = "trailing-slash"
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
240
        self.assertFalse(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
241
        # set a place for the plugin to record its loading, and at the same
242
        # time validate that the location the plugin should record to is
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
243
        # valid and correct.
7143.15.2 by Jelmer Vernooij
Run autopep8.
244
        breezy.tests.test_plugins.TestLoadingPlugins.activeattributes[tempattribute] = [
245
            ]
5784.1.1 by Martin Pool
Stop using failIf, failUnless, etc
246
        self.assertTrue(tempattribute in self.activeattributes)
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
247
        # create a directory for the plugin
248
        os.mkdir('plugin_test')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
249
        # write a plugin that will record when its loaded in the
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
250
        # tempattribute list.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
251
        template = ("from breezy.tests.test_plugins import TestLoadingPlugins\n"
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
252
                    "TestLoadingPlugins.activeattributes[%r].append('%s')\n")
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
253
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
254
        with open(os.path.join('plugin_test', 'ts_plugin.py'), 'w') as outfile:
2911.6.1 by Blake Winton
Change 'print >> f,'s to 'f.write('s.
255
            outfile.write(template % (tempattribute, 'plugin'))
2911.6.4 by Blake Winton
Fix test failures
256
            outfile.write('\n')
2652.2.7 by Blake Winton
fix lines which were wider than 79 chars. Also handle files a little more safely.
257
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
258
        try:
7143.15.2 by Jelmer Vernooij
Run autopep8.
259
            self.load_with_paths(['plugin_test' + os.sep])
2652.2.3 by Blake Winton
Understand the code and comments of the test, instead of just cargo-culting them.
260
            self.assertEqual(['plugin'], self.activeattributes[tempattribute])
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
261
            self.assertPluginKnown('ts_plugin')
2652.2.1 by Blake Winton
Add a test for BZR_PLUGIN_PATH, and code and another test to allow BZR_PLUGIN_PATH to contain trailing slashes.
262
        finally:
263
            del self.activeattributes[tempattribute]
264
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
265
    def load_and_capture(self, name):
266
        """Load plugins from '.' capturing the output.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
267
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
268
        :param name: The name of the plugin.
269
        :return: A string with the log from the plugin loading call.
270
        """
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
271
        # Capture output
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
272
        stream = StringIO()
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
273
        try:
274
            handler = logging.StreamHandler(stream)
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
275
            log = logging.getLogger('brz')
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
276
            log.addHandler(handler)
277
            try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
278
                self.load_with_paths(['.'])
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
279
            finally:
280
                # Stop capturing output
281
                handler.flush()
282
                handler.close()
283
                log.removeHandler(handler)
284
            return stream.getvalue()
285
        finally:
286
            stream.close()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
287
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
288
    def test_plugin_with_bad_api_version_reports(self):
5616.7.3 by Martin Pool
Put plugin warnings into both the apport and plain crash report
289
        """Try loading a plugin that requests an unsupported api.
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
290
5616.7.12 by Martin Pool
Comment correction
291
        Observe that it records the problem but doesn't complain on stderr.
5616.7.7 by Martin Pool
Paper over test global state dependency
292
293
        See https://bugs.launchpad.net/bzr/+bug/704195
5616.7.3 by Martin Pool
Put plugin warnings into both the apport and plain crash report
294
        """
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
295
        name = 'wants100.py'
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
296
        with open(name, 'w') as f:
6672.1.2 by Jelmer Vernooij
Remove breezy.api.
297
            f.write("import breezy\n"
7143.15.2 by Jelmer Vernooij
Run autopep8.
298
                    "from breezy.errors import IncompatibleVersion\n"
299
                    "raise IncompatibleVersion(breezy, [(1, 0, 0)], (0, 0, 5))\n")
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
300
        log = self.load_and_capture(name)
5616.7.1 by Martin Pool
Record but don't show warnings about updated plugins
301
        self.assertNotContainsRe(log,
7143.15.2 by Jelmer Vernooij
Run autopep8.
302
                                 r"It supports breezy version")
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
303
        self.assertEqual({'wants100'}, viewkeys(self.plugin_warnings))
5616.7.1 by Martin Pool
Record but don't show warnings about updated plugins
304
        self.assertContainsRe(
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
305
            self.plugin_warnings['wants100'][0],
6672.1.2 by Jelmer Vernooij
Remove breezy.api.
306
            r"It supports breezy version")
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
307
308
    def test_plugin_with_bad_name_does_not_load(self):
309
        # The file name here invalid for a python module.
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
310
        name = 'brz-bad plugin-name..py'
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
311
        open(name, 'w').close()
3766.3.2 by Robert Collins
Fix reporting of incompatible api plugin load errors, fixing bug 279451.
312
        log = self.load_and_capture(name)
313
        self.assertContainsRe(log,
7143.15.2 by Jelmer Vernooij
Run autopep8.
314
                              r"Unable to load 'brz-bad plugin-name\.' in '\.' as a plugin "
315
                              "because the file path isn't a valid module name; try renaming "
316
                              "it to 'bad_plugin_name_'\\.")
2967.4.5 by Daniel Watkins
Added test for badly-named plugins.
317
1516 by Robert Collins
* bzrlib.plugin.all_plugins has been changed from an attribute to a
318
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
319
class TestPlugins(BaseTestPlugins):
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
320
321
    def setup_plugin(self, source=""):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
322
        # This test tests a new plugin appears in breezy.plugin.plugins().
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
323
        # check the plugin is not loaded already
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
324
        self.assertPluginUnknown('plugin')
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
325
        # write a plugin that _cannot_ fail to load.
7143.15.2 by Jelmer Vernooij
Run autopep8.
326
        with open('plugin.py', 'w') as f:
327
            f.write(source + '\n')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
328
        self.load_with_paths(['.'])
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
329
6759.4.3 by Jelmer Vernooij
Avoid accessing global state.
330
    def test_plugin_loaded(self):
331
        self.assertPluginUnknown('plugin')
332
        self.assertIs(None, breezy.plugin.get_loaded_plugin('plugin'))
333
        self.setup_plugin()
334
        p = breezy.plugin.get_loaded_plugin('plugin')
335
        self.assertIsInstance(p, breezy.plugin.PlugIn)
336
        self.assertIs(p.module, sys.modules[self.module_prefix + 'plugin'])
337
6780.1.1 by Jelmer Vernooij
Check for plugin existing in sys.modules but being None.
338
    def test_plugin_loaded_disabled(self):
339
        self.assertPluginUnknown('plugin')
340
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'plugin')
341
        self.setup_plugin()
342
        self.assertIs(None, breezy.plugin.get_loaded_plugin('plugin'))
343
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
344
    def test_plugin_appears_in_plugins(self):
345
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
346
        self.assertPluginKnown('plugin')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
347
        p = self.plugins['plugin']
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
348
        self.assertIsInstance(p, breezy.plugin.PlugIn)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
349
        self.assertIs(p.module, sys.modules[self.module_prefix + 'plugin'])
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
350
351
    def test_trivial_plugin_get_path(self):
352
        self.setup_plugin()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
353
        p = self.plugins['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
354
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
355
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
356
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
357
    def test_plugin_get_path_py_not_pyc(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
358
        # first import creates plugin.pyc
359
        self.setup_plugin()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
360
        self.promote_cache(self.test_dir)
361
        self.reset()
7143.15.2 by Jelmer Vernooij
Run autopep8.
362
        self.load_with_paths(['.'])  # import plugin.pyc
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
363
        p = plugin.plugins()['plugin']
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
364
        plugin_path = self.test_dir + '/plugin.py'
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
365
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
366
367
    def test_plugin_get_path_pyc_only(self):
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
368
        # first import creates plugin.pyc (or plugin.pyo depending on __debug__)
369
        self.setup_plugin()
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
370
        os.unlink(self.test_dir + '/plugin.py')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
371
        self.promote_cache(self.test_dir)
372
        self.reset()
7143.15.2 by Jelmer Vernooij
Run autopep8.
373
        self.load_with_paths(['.'])  # import plugin.pyc (or .pyo)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
374
        p = plugin.plugins()['plugin']
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
375
        plugin_path = self.test_dir + '/plugin' + plugin.COMPILED_EXT
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
376
        self.assertIsSameRealPath(plugin_path, osutils.normpath(p.path()))
3193.2.1 by Alexander Belchenko
show path to plugin module as *.py instead of *.pyc if python source available
377
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
378
    def test_no_test_suite_gives_None_for_test_suite(self):
379
        self.setup_plugin()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
380
        p = plugin.plugins()['plugin']
381
        self.assertEqual(None, p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
382
383
    def test_test_suite_gives_test_suite_result(self):
384
        source = """def test_suite(): return 'foo'"""
385
        self.setup_plugin(source)
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
386
        p = plugin.plugins()['plugin']
387
        self.assertEqual('foo', p.test_suite())
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
388
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
389
    def test_no_load_plugin_tests_gives_None_for_load_plugin_tests(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
390
        self.setup_plugin()
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
391
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
392
        p = plugin.plugins()['plugin']
393
        self.assertEqual(None, p.load_plugin_tests(loader))
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
394
3302.8.21 by Vincent Ladeuil
Fixed as per Robert's review.
395
    def test_load_plugin_tests_gives_load_plugin_tests_result(self):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
396
        source = """
6625.1.5 by Martin
Drop custom load_tests implementation and use unittest signature
397
def load_tests(loader, standard_tests, pattern):
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
398
    return 'foo'"""
399
        self.setup_plugin(source)
5086.1.3 by Vincent Ladeuil
Fix imports in test_plugins.
400
        loader = tests.TestUtil.TestLoader()
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
401
        p = plugin.plugins()['plugin']
402
        self.assertEqual('foo', p.load_plugin_tests(loader))
403
404
    def check_version_info(self, expected, source='', name='plugin'):
405
        self.setup_plugin(source)
406
        self.assertEqual(expected, plugin.plugins()[name].version_info())
3302.8.10 by Vincent Ladeuil
Prepare bzrlib.plugin to use the new test loader.
407
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
408
    def test_no_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
409
        self.check_version_info(None)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
410
411
    def test_with_version_info(self):
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
412
        self.check_version_info((1, 2, 3, 'dev', 4),
413
                                "version_info = (1, 2, 3, 'dev', 4)")
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
414
415
    def test_short_version_info_gets_padded(self):
416
        # the gtk plugin has version_info = (1,2,3) rather than the 5-tuple.
417
        # so we adapt it
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
418
        self.check_version_info((1, 2, 3, 'final', 0),
419
                                "version_info = (1, 2, 3)")
420
421
    def check_version(self, expected, source=None, name='plugin'):
422
        self.setup_plugin(source)
423
        self.assertEqual(expected, plugins[name].__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
424
425
    def test_no_version_info___version__(self):
426
        self.setup_plugin()
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
427
        plugin = breezy.plugin.plugins()['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
428
        self.assertEqual("unknown", plugin.__version__)
429
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
430
    def test_str__version__with_version_info(self):
431
        self.setup_plugin("version_info = '1.2.3'")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
432
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
433
        self.assertEqual("1.2.3", plugin.__version__)
434
435
    def test_noniterable__version__with_version_info(self):
436
        self.setup_plugin("version_info = (1)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
437
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
438
        self.assertEqual("1", plugin.__version__)
439
440
    def test_1__version__with_version_info(self):
441
        self.setup_plugin("version_info = (1,)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
442
        plugin = breezy.plugin.plugins()['plugin']
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
443
        self.assertEqual("1", plugin.__version__)
444
445
    def test_1_2__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
446
        self.setup_plugin("version_info = (1, 2)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
447
        plugin = breezy.plugin.plugins()['plugin']
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
448
        self.assertEqual("1.2", plugin.__version__)
449
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
450
    def test_1_2_3__version__with_version_info(self):
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
451
        self.setup_plugin("version_info = (1, 2, 3)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
452
        plugin = breezy.plugin.plugins()['plugin']
3777.6.5 by Marius Kruger
add 2 more tests for plugin version numbers
453
        self.assertEqual("1.2.3", plugin.__version__)
454
455
    def test_candidate__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
456
        self.setup_plugin("version_info = (1, 2, 3, 'candidate', 1)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
457
        plugin = breezy.plugin.plugins()['plugin']
3777.6.4 by Marius Kruger
fix tests
458
        self.assertEqual("1.2.3rc1", plugin.__version__)
459
460
    def test_dev__version__with_version_info(self):
461
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 0)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
462
        plugin = breezy.plugin.plugins()['plugin']
3777.6.4 by Marius Kruger
fix tests
463
        self.assertEqual("1.2.3dev", plugin.__version__)
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
464
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
465
    def test_dev_fallback__version__with_version_info(self):
466
        self.setup_plugin("version_info = (1, 2, 3, 'dev', 4)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
467
        plugin = breezy.plugin.plugins()['plugin']
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
468
        self.assertEqual("1.2.3dev4", plugin.__version__)
3777.6.7 by Marius Kruger
* Can now also handle non-iteratable and string plugin versions.
469
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
470
    def test_final__version__with_version_info(self):
3777.6.4 by Marius Kruger
fix tests
471
        self.setup_plugin("version_info = (1, 2, 3, 'final', 0)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
472
        plugin = breezy.plugin.plugins()['plugin']
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
473
        self.assertEqual("1.2.3", plugin.__version__)
474
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
475
    def test_final_fallback__version__with_version_info(self):
476
        self.setup_plugin("version_info = (1, 2, 3, 'final', 2)")
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
477
        plugin = breezy.plugin.plugins()['plugin']
5851.2.2 by Martin Pool
Format plugin version as 1.2.3.2 not 1.2.3.final.2
478
        self.assertEqual("1.2.3.2", plugin.__version__)
4634.50.6 by John Arbash Meinel
Handle a plugin fallback versioning issue.
479
2762.2.1 by Robert Collins
* ``bzr plugins`` now lists the version number for each plugin in square
480
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
481
class TestHelpIndex(tests.TestCase):
482
    """Tests for the PluginsHelpIndex class."""
483
484
    def test_default_constructable(self):
485
        index = plugin.PluginsHelpIndex()
486
487
    def test_get_topics_None(self):
488
        """Searching for None returns an empty list."""
489
        index = plugin.PluginsHelpIndex()
490
        self.assertEqual([], index.get_topics(None))
491
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
492
    def test_get_topics_for_plugin(self):
493
        """Searching for plugin name gets its docstring."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
494
        index = plugin.PluginsHelpIndex()
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
495
        # make a new plugin here for this test, even if we're run with
496
        # --no-plugins
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
497
        self.assertFalse('breezy.plugins.demo_module' in sys.modules)
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
498
        demo_module = FakeModule('', 'breezy.plugins.demo_module')
499
        sys.modules['breezy.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
500
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
501
            topics = index.get_topics('demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
502
            self.assertEqual(1, len(topics))
503
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
504
            self.assertEqual(demo_module, topics[0].module)
505
        finally:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
506
            del sys.modules['breezy.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
507
508
    def test_get_topics_no_topic(self):
509
        """Searching for something that is not a plugin returns []."""
510
        # test this by using a name that cannot be a plugin - its not
511
        # a valid python identifier.
512
        index = plugin.PluginsHelpIndex()
513
        self.assertEqual([], index.get_topics('nothing by this name'))
514
515
    def test_prefix(self):
516
        """PluginsHelpIndex has a prefix of 'plugins/'."""
517
        index = plugin.PluginsHelpIndex()
518
        self.assertEqual('plugins/', index.prefix)
519
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
520
    def test_get_plugin_topic_with_prefix(self):
521
        """Searching for plugins/demo_module returns help."""
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
522
        index = plugin.PluginsHelpIndex()
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
523
        self.assertFalse('breezy.plugins.demo_module' in sys.modules)
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
524
        demo_module = FakeModule('', 'breezy.plugins.demo_module')
525
        sys.modules['breezy.plugins.demo_module'] = demo_module
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
526
        try:
2475.1.1 by Martin Pool
Rename test_plugin tests and the example module used there.
527
            topics = index.get_topics('plugins/demo_module')
2457.1.1 by Robert Collins
(robertc) Fix bzr --no-plugins selftest which was broken by the help indices patch. (Robert Collins, Martin Pool)
528
            self.assertEqual(1, len(topics))
529
            self.assertIsInstance(topics[0], plugin.ModuleHelpTopic)
530
            self.assertEqual(demo_module, topics[0].module)
531
        finally:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
532
            del sys.modules['breezy.plugins.demo_module']
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
533
534
535
class FakeModule(object):
536
    """A fake module to test with."""
537
538
    def __init__(self, doc, name):
539
        self.__doc__ = doc
540
        self.__name__ = name
541
542
543
class TestModuleHelpTopic(tests.TestCase):
544
    """Tests for the ModuleHelpTopic class."""
545
546
    def test_contruct(self):
547
        """Construction takes the module to document."""
548
        mod = FakeModule('foo', 'foo')
549
        topic = plugin.ModuleHelpTopic(mod)
550
        self.assertEqual(mod, topic.module)
551
552
    def test_get_help_text_None(self):
553
        """A ModuleHelpTopic returns the docstring for get_help_text."""
554
        mod = FakeModule(None, 'demo')
555
        topic = plugin.ModuleHelpTopic(mod)
556
        self.assertEqual("Plugin 'demo' has no docstring.\n",
7143.15.2 by Jelmer Vernooij
Run autopep8.
557
                         topic.get_help_text())
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
558
559
    def test_get_help_text_no_carriage_return(self):
560
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
561
        mod = FakeModule('one line of help', 'demo')
562
        topic = plugin.ModuleHelpTopic(mod)
563
        self.assertEqual("one line of help\n",
7143.15.2 by Jelmer Vernooij
Run autopep8.
564
                         topic.get_help_text())
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
565
566
    def test_get_help_text_carriage_return(self):
567
        """ModuleHelpTopic.get_help_text adds a \n if needed."""
568
        mod = FakeModule('two lines of help\nand more\n', 'demo')
569
        topic = plugin.ModuleHelpTopic(mod)
570
        self.assertEqual("two lines of help\nand more\n",
7143.15.2 by Jelmer Vernooij
Run autopep8.
571
                         topic.get_help_text())
2432.1.25 by Robert Collins
Return plugin module docstrings for 'bzr help plugin'.
572
573
    def test_get_help_text_with_additional_see_also(self):
574
        mod = FakeModule('two lines of help\nand more', 'demo')
575
        topic = plugin.ModuleHelpTopic(mod)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
576
        self.assertEqual(
577
            "two lines of help\nand more\n\n:See also: bar, foo\n",
578
            topic.get_help_text(['foo', 'bar']))
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
579
580
    def test_get_help_topic(self):
581
        """The help topic for a plugin is its module name."""
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
582
        mod = FakeModule('two lines of help\nand more', 'breezy.plugins.demo')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
583
        topic = plugin.ModuleHelpTopic(mod)
584
        self.assertEqual('demo', topic.get_help_topic())
6059.3.6 by Vincent Ladeuil
Fix tests failing on pqm.
585
        mod = FakeModule('two lines of help\nand more',
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
586
                         'breezy.plugins.foo_bar')
2432.1.29 by Robert Collins
Add get_help_topic to ModuleHelpTopic.
587
        topic = plugin.ModuleHelpTopic(mod)
588
        self.assertEqual('foo_bar', topic.get_help_topic())
3835.2.7 by Aaron Bentley
Add tests for plugins
589
590
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
591
class TestEnvPluginPath(tests.TestCase):
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
592
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
593
    user = "USER"
594
    core = "CORE"
595
    site = "SITE"
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
596
597
    def check_path(self, expected_dirs, setting_dirs):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
598
        if setting_dirs is None:
599
            del os.environ['BRZ_PLUGIN_PATH']
600
        else:
601
            os.environ['BRZ_PLUGIN_PATH'] = os.pathsep.join(setting_dirs)
602
        actual = [(p if t == 'path' else t.upper())
7143.15.2 by Jelmer Vernooij
Run autopep8.
603
                  for p, t in plugin._env_plugin_path()]
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
604
        self.assertEqual(expected_dirs, actual)
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
605
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
606
    def test_default(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
607
        self.check_path([self.user, self.core, self.site],
608
                        None)
609
610
    def test_adhoc_policy(self):
611
        self.check_path([self.user, self.core, self.site],
612
                        ['+user', '+core', '+site'])
613
614
    def test_fallback_policy(self):
615
        self.check_path([self.core, self.site, self.user],
616
                        ['+core', '+site', '+user'])
617
618
    def test_override_policy(self):
619
        self.check_path([self.user, self.site, self.core],
620
                        ['+user', '+site', '+core'])
621
622
    def test_disable_user(self):
623
        self.check_path([self.core, self.site], ['-user'])
624
625
    def test_disable_user_twice(self):
626
        # Ensures multiple removals don't left cruft
627
        self.check_path([self.core, self.site], ['-user', '-user'])
628
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
629
    def test_duplicates_are_removed(self):
630
        self.check_path([self.user, self.core, self.site],
631
                        ['+user', '+user'])
632
        # And only the first reference is kept (since the later references will
5086.1.2 by Vincent Ladeuil
Cosmetic changes.
633
        # only produce '<plugin> already loaded' mutters)
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
634
        self.check_path([self.user, self.core, self.site],
635
                        ['+user', '+user', '+core',
636
                         '+user', '+site', '+site',
637
                         '+core'])
638
5086.1.5 by Vincent Ladeuil
Fix typo in test name.
639
    def test_disable_overrides_enable(self):
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
640
        self.check_path([self.core, self.site], ['-user', '+user'])
641
642
    def test_disable_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
643
        self.check_path([self.site], ['-core'])
644
        self.check_path([self.user, self.site], ['+user', '-core'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
645
646
    def test_disable_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
647
        self.check_path([self.core], ['-site'])
648
        self.check_path([self.user, self.core], ['-site', '+user'])
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
649
650
    def test_override_site(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
651
        self.check_path(['mysite', self.user, self.core],
652
                        ['mysite', '-site', '+user'])
653
        self.check_path(['mysite', self.core],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
654
                        ['mysite', '-site'])
655
656
    def test_override_core(self):
4628.2.3 by Vincent Ladeuil
Update doc and add NEWS entry.
657
        self.check_path(['mycore', self.user, self.site],
658
                        ['mycore', '-core', '+user', '+site'])
659
        self.check_path(['mycore', self.site],
4628.2.2 by Vincent Ladeuil
Add [+-]{user|core|site} handling in BZR_PLUGIN_PATH.
660
                        ['mycore', '-core'])
661
662
    def test_my_plugin_only(self):
663
        self.check_path(['myplugin'], ['myplugin', '-user', '-core', '-site'])
664
665
    def test_my_plugin_first(self):
666
        self.check_path(['myplugin', self.core, self.site, self.user],
667
                        ['myplugin', '+core', '+site', '+user'])
4628.2.1 by Vincent Ladeuil
Start introducing accessors for plugin paths.
668
4628.2.5 by Vincent Ladeuil
Fixes prompted by review.
669
    def test_bogus_references(self):
670
        self.check_path(['+foo', '-bar', self.core, self.site],
671
                        ['+foo', '-bar'])
5086.1.4 by Vincent Ladeuil
Slight plugin tests rewriting.
672
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
673
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
674
class TestDisablePlugin(BaseTestPlugins):
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
675
5086.1.8 by Vincent Ladeuil
Fix warnings during autoload, add doc and a NEWS entry.
676
    def test_cannot_import(self):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
677
        self.create_plugin_package('works')
678
        self.create_plugin_package('fails')
679
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'fails')
680
        self.update_module_paths(["."])
681
        import breezy.testingplugins.works as works
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
682
        try:
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
683
            import breezy.testingplugins.fails as fails
5086.1.6 by Vincent Ladeuil
Crude fix for bug #411413.
684
        except ImportError:
685
            pass
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
686
        else:
687
            self.fail("Loaded blocked plugin: " + repr(fails))
688
        self.assertPluginModules({'fails': None, 'works': works})
689
690
    def test_partial_imports(self):
691
        self.create_plugin('good')
692
        self.create_plugin('bad')
693
        self.create_plugin_package('ugly')
694
        self.overrideEnv('BRZ_DISABLE_PLUGINS', 'bad:ugly')
695
        self.load_with_paths(['.'])
696
        self.assertEqual({'good'}, viewkeys(self.plugins))
697
        self.assertPluginModules({
698
            'good': self.plugins['good'].module,
699
            'bad': None,
700
            'ugly': None,
701
        })
702
        # Ensure there are no warnings about plugins not being imported as
703
        # the user has explictly requested they be disabled.
704
        self.assertNotContainsRe(self.get_log(), r"Unable to load plugin")
705
706
707
class TestEnvDisablePlugins(tests.TestCase):
708
709
    def _get_names(self, env_value):
710
        os.environ['BRZ_DISABLE_PLUGINS'] = env_value
711
        return plugin._env_disable_plugins()
712
713
    def test_unset(self):
714
        self.assertEqual([], plugin._env_disable_plugins())
715
716
    def test_empty(self):
717
        self.assertEqual([], self._get_names(''))
718
719
    def test_single(self):
720
        self.assertEqual(['single'], self._get_names('single'))
721
722
    def test_multi(self):
723
        expected = ['one', 'two']
724
        self.assertEqual(expected, self._get_names(os.pathsep.join(expected)))
725
726
    def test_mixed(self):
727
        value = os.pathsep.join(['valid', 'in-valid'])
728
        self.assertEqual(['valid'], self._get_names(value))
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
729
        self.assertContainsRe(
730
            self.get_log(),
731
            r"Invalid name 'in-valid' in BRZ_DISABLE_PLUGINS=" + repr(value))
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
732
733
734
class TestEnvPluginsAt(tests.TestCase):
735
736
    def _get_paths(self, env_value):
737
        os.environ['BRZ_PLUGINS_AT'] = env_value
738
        return plugin._env_plugins_at()
739
740
    def test_empty(self):
741
        self.assertEqual([], plugin._env_plugins_at())
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
742
        self.assertEqual([], self._get_paths(''))
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
743
744
    def test_one_path(self):
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
745
        self.assertEqual([('b', 'man')], self._get_paths('b@man'))
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
746
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
747
    def test_multiple(self):
748
        self.assertEqual(
749
            [('tools', 'bzr-tools'), ('p', 'play.py')],
750
            self._get_paths(os.pathsep.join(('tools@bzr-tools', 'p@play.py'))))
751
752
    def test_many_at(self):
753
        self.assertEqual(
754
            [('church', 'StMichael@Plea@Norwich')],
755
            self._get_paths('church@StMichael@Plea@Norwich'))
756
757
    def test_only_py(self):
758
        self.assertEqual([('test', './test.py')], self._get_paths('./test.py'))
759
760
    def test_only_package(self):
761
        self.assertEqual([('py', '/opt/b/py')], self._get_paths('/opt/b/py'))
762
763
    def test_bad_name(self):
764
        self.assertEqual([], self._get_paths('/usr/local/bzr-git'))
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
765
        self.assertContainsRe(
766
            self.get_log(),
767
            r"Invalid name 'bzr-git' in BRZ_PLUGINS_AT='/usr/local/bzr-git'")
5268.5.1 by Vincent Ladeuil
Reproduce bug #591215.
768
769
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
770
class TestLoadPluginAt(BaseTestPlugins):
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
771
772
    def setUp(self):
773
        super(TestLoadPluginAt, self).setUp()
774
        # Create the same plugin in two directories
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
775
        self.create_plugin_package('test_foo', dir='non-standard-dir')
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
776
        # The "normal" directory, we use 'standard' instead of 'plugins' to
777
        # avoid depending on the precise naming.
778
        self.create_plugin_package('test_foo', dir='standard/test_foo')
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
779
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
780
    def assertTestFooLoadedFrom(self, path):
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
781
        self.assertPluginKnown('test_foo')
5131.2.1 by Martin
Permit bzrlib to run under python -OO by explictly assigning to __doc__ for user-visible docstrings
782
        self.assertDocstring('This is the doc for test_foo',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
783
                             self.module.test_foo)
784
        self.assertEqual(path, self.module.test_foo.dir_source)
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
785
786
    def test_regular_load(self):
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
787
        self.load_with_paths(['standard'])
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
788
        self.assertTestFooLoadedFrom('standard/test_foo')
5086.5.3 by Vincent Ladeuil
First shot at loading plugins from a specific directory.
789
790
    def test_import(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
791
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
792
        self.update_module_paths(['standard'])
793
        import breezy.testingplugins.test_foo
5086.5.8 by Vincent Ladeuil
Make sure we can load from a non-standard directory name.
794
        self.assertTestFooLoadedFrom('non-standard-dir')
795
796
    def test_loading(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
797
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
798
        self.load_with_paths(['standard'])
799
        self.assertTestFooLoadedFrom('non-standard-dir')
800
801
    def test_loading_other_name(self):
802
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
803
        os.rename('standard/test_foo', 'standard/test_bar')
804
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
805
        self.assertTestFooLoadedFrom('non-standard-dir')
806
807
    def test_compiled_loaded(self):
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
808
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
809
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
810
        self.assertTestFooLoadedFrom('non-standard-dir')
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
811
        self.assertIsSameRealPath('non-standard-dir/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
812
                                  self.module.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
813
814
        # Try importing again now that the source has been compiled
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
815
        os.remove('non-standard-dir/__init__.py')
816
        self.promote_cache('non-standard-dir')
817
        self.reset()
818
        self.load_with_paths(['standard'])
5086.5.9 by Vincent Ladeuil
More tests.
819
        self.assertTestFooLoadedFrom('non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
820
        suffix = plugin.COMPILED_EXT
821
        self.assertIsSameRealPath('non-standard-dir/__init__' + suffix,
822
                                  self.module.test_foo.__file__)
5086.5.9 by Vincent Ladeuil
More tests.
823
824
    def test_submodule_loading(self):
825
        # We create an additional directory under the one for test_foo
826
        self.create_plugin_package('test_bar', dir='non-standard-dir/test_bar')
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
827
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
828
        self.update_module_paths(['standard'])
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
829
        import breezy.testingplugins.test_foo  # noqa: F401
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
830
        self.assertEqual(self.module_prefix + 'test_foo',
831
                         self.module.test_foo.__package__)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
832
        import breezy.testingplugins.test_foo.test_bar  # noqa: F401
5235.1.1 by Martin
Make BZR_PLUGINS_AT tests that check filenames use a path-based assertion method rather than just string comparison
833
        self.assertIsSameRealPath('non-standard-dir/test_bar/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
834
                                  self.module.test_foo.test_bar.__file__)
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
835
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
836
    def test_relative_submodule_loading(self):
837
        self.create_plugin_package('test_foo', dir='another-dir', source='''
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
838
from . import test_bar
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
839
''')
840
        # We create an additional directory under the one for test_foo
841
        self.create_plugin_package('test_bar', dir='another-dir/test_bar')
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
842
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@another-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
843
        self.update_module_paths(['standard'])
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
844
        import breezy.testingplugins.test_foo  # noqa: F401
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
845
        self.assertEqual(self.module_prefix + 'test_foo',
846
                         self.module.test_foo.__package__)
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
847
        self.assertIsSameRealPath('another-dir/test_bar/__init__.py',
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
848
                                  self.module.test_foo.test_bar.__file__)
5268.6.2 by Vincent Ladeuil
Reproduce bug #588959.
849
5086.5.15 by Vincent Ladeuil
Fixed as per Ian's review.
850
    def test_loading_from___init__only(self):
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
851
        # We rename the existing __init__.py file to ensure that we don't load
852
        # a random file
853
        init = 'non-standard-dir/__init__.py'
854
        random = 'non-standard-dir/setup.py'
855
        os.rename(init, random)
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
856
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@non-standard-dir')
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
857
        self.load_with_paths(['standard'])
5086.5.13 by Vincent Ladeuil
Reproduce bug #552922.
858
        self.assertPluginUnknown('test_foo')
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
859
860
    def test_loading_from_specific_file(self):
861
        plugin_dir = 'non-standard-dir'
862
        plugin_file_name = 'iamtestfoo.py'
863
        plugin_path = osutils.pathjoin(plugin_dir, plugin_file_name)
864
        source = '''\
865
"""This is the doc for %s"""
866
dir_source = '%s'
867
''' % ('test_foo', plugin_path)
868
        self.create_plugin('test_foo', source=source,
869
                           dir=plugin_dir, file_name=plugin_file_name)
6622.1.28 by Jelmer Vernooij
More renames; commands in output, environment variables.
870
        self.overrideEnv('BRZ_PLUGINS_AT', 'test_foo@%s' % plugin_path)
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
871
        self.load_with_paths(['standard'])
5086.5.14 by Vincent Ladeuil
Fix bug #552922 by controlling which files can be used to load a plugin.
872
        self.assertTestFooLoadedFrom(plugin_path)
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
873
874
875
class TestDescribePlugins(BaseTestPlugins):
876
877
    def test_describe_plugins(self):
5616.7.11 by Martin Pool
Additional tests and fixes for refactored describe_plugins.
878
        class DummyModule(object):
879
            __doc__ = 'Hi there'
7143.15.2 by Jelmer Vernooij
Run autopep8.
880
5616.7.11 by Martin Pool
Additional tests and fixes for refactored describe_plugins.
881
        class DummyPlugin(object):
882
            __version__ = '0.1.0'
883
            module = DummyModule()
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
884
        self.plugin_warnings = {'bad': ['Failed to load (just testing)']}
885
        self.plugins = {'good': DummyPlugin()}
6614.1.3 by Vincent Ladeuil
Fix assertEquals being deprecated by using assertEqual.
886
        self.assertEqual("""\
5616.7.10 by Martin Pool
Clean up describe_plugins to sort loaded and unloaded plugins together.
887
bad (failed to load)
888
  ** Failed to load (just testing)
889
5616.7.11 by Martin Pool
Additional tests and fixes for refactored describe_plugins.
890
good 0.1.0
891
  Hi there
892
6651.4.1 by Martin
Rewrite of the plugin module for Python 3 compat and general sanity
893
""", ''.join(plugin.describe_plugins(state=self)))