/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5273.1.9 by Vincent Ladeuil
Merge bzr.dev into cleanup resolving conflicts
1
# Copyright (C) 2006-2010 Canonical Ltd
1534.2.1 by Robert Collins
Implement deprecated_method
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1534.2.1 by Robert Collins
Implement deprecated_method
16
17
"""Symbol versioning
18
19
The methods here allow for api symbol versioning.
20
"""
21
6379.6.7 by Jelmer Vernooij
Move importing from future until after doc string, otherwise the doc string will disappear.
22
from __future__ import absolute_import
23
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
24
__all__ = ['deprecated_function',
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
25
           'deprecated_in',
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
26
           'deprecated_list',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
27
           'deprecated_method',
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
28
           'DEPRECATED_PARAMETER',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
29
           'deprecated_passed',
3400.3.1 by Martin Pool
Remove methods deprecated in zero_eight
30
           'set_warning_method',
31
           'warn',
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
32
           ]
1534.2.1 by Robert Collins
Implement deprecated_method
33
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
34
35
import warnings
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
36
# Import the 'warn' symbol so breezy can call it even if we redefine it
1534.2.1 by Robert Collins
Implement deprecated_method
37
from warnings import warn
38
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
39
import breezy
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
40
1534.2.1 by Robert Collins
Implement deprecated_method
41
1534.4.32 by Robert Collins
Rename deprecated_nonce to DEPRECATED_PARAMETER
42
DEPRECATED_PARAMETER = "A deprecated parameter marker."
1534.2.1 by Robert Collins
Implement deprecated_method
43
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
44
45
def deprecated_in(version_tuple):
46
    """Generate a message that something was deprecated in a release.
47
48
    >>> deprecated_in((1, 4, 0))
4634.50.8 by John Arbash Meinel
it seems there was even a symbol_versioning doctest that I missed.
49
    '%s was deprecated in version 1.4.0.'
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
50
    """
3427.2.5 by John Arbash Meinel
Change deprecated_in to end with a '.'
51
    return ("%%s was deprecated in version %s."
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
52
            % breezy._format_version_tuple(version_tuple))
3388.1.2 by Martin Pool
Add new symbol_versioning.deprecated_in
53
1534.2.1 by Robert Collins
Implement deprecated_method
54
55
def set_warning_method(method):
56
    """Set the warning method to be used by this module.
57
58
    It should take a message and a warning category as warnings.warn does.
59
    """
60
    global warn
61
    warn = method
62
63
1534.2.2 by Robert Collins
Implement deprecated_function.
64
# TODO - maybe this would be easier to use as one 'smart' method that
65
# guess if it is a method or a class or an attribute ? If so, we can
66
# add that on top of the primitives, once we have all three written
67
# - RBC 20050105
68
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
69
70
def deprecation_string(a_callable, deprecation_version):
71
    """Generate an automatic deprecation string for a_callable.
72
73
    :param a_callable: The callable to substitute into deprecation_version.
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
74
    :param deprecation_version: A deprecation format warning string. This
75
        should have a single %s operator in it. a_callable will be turned into
76
        a nice python symbol and then substituted into deprecation_version.
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
77
    """
7104.1.1 by Jelmer Vernooij
Fix remaining deprecation warning test.
78
    if getattr(a_callable, '__self__', None) is not None:
79
        symbol = "%s.%s.%s" % (a_callable.__self__.__class__.__module__,
80
                               a_callable.__self__.__class__.__name__,
81
                               a_callable.__name__)
7183.3.1 by Martin
Fix E71* lint errors
82
    elif getattr(a_callable, '__qualname__', None) is not None and '<' not in a_callable.__qualname__:
7104.1.1 by Jelmer Vernooij
Fix remaining deprecation warning test.
83
        symbol = "%s.%s" % (a_callable.__module__,
84
                            a_callable.__qualname__)
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
85
    else:
7104.1.1 by Jelmer Vernooij
Fix remaining deprecation warning test.
86
        symbol = "%s.%s" % (a_callable.__module__,
87
                            a_callable.__name__)
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
88
    return deprecation_version % symbol
89
90
1534.2.2 by Robert Collins
Implement deprecated_function.
91
def deprecated_function(deprecation_version):
92
    """Decorate a function so that use of it will trigger a warning."""
93
94
    def function_decorator(callable):
95
        """This is the function python calls to perform the decoration."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
96
1534.2.2 by Robert Collins
Implement deprecated_function.
97
        def decorated_function(*args, **kwargs):
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
98
            """This is the decorated function."""
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
99
            from . import trace
3530.2.2 by John Arbash Meinel
Add extra debugging for when a deprecated function/method are called
100
            trace.mutter_callsite(4, "Deprecated function called")
1982.3.1 by Robert Collins
New utility function symbol_versioning.deprecation_string. Returns the
101
            warn(deprecation_string(callable, deprecation_version),
7143.15.2 by Jelmer Vernooij
Run autopep8.
102
                 DeprecationWarning, stacklevel=2)
1534.2.2 by Robert Collins
Implement deprecated_function.
103
            return callable(*args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
104
        _populate_decorated(callable, deprecation_version, "function",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
105
                            decorated_function)
1534.2.2 by Robert Collins
Implement deprecated_function.
106
        return decorated_function
107
    return function_decorator
108
109
1534.2.1 by Robert Collins
Implement deprecated_method
110
def deprecated_method(deprecation_version):
111
    """Decorate a method so that use of it will trigger a warning.
2825.3.2 by Martin Pool
doc
112
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
113
    To deprecate a static or class method, use
2825.3.2 by Martin Pool
doc
114
115
        @staticmethod
116
        @deprecated_function
117
        def ...
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
118
1534.2.1 by Robert Collins
Implement deprecated_method
119
    To deprecate an entire class, decorate __init__.
120
    """
121
122
    def method_decorator(callable):
123
        """This is the function python calls to perform the decoration."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
124
1534.2.1 by Robert Collins
Implement deprecated_method
125
        def decorated_method(self, *args, **kwargs):
126
            """This is the decorated method."""
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
127
            from . import trace
2872.5.1 by Martin Pool
Avoid internal error tracebacks on failure to lock on readonly transport (#129701).
128
            if callable.__name__ == '__init__':
129
                symbol = "%s.%s" % (self.__class__.__module__,
130
                                    self.__class__.__name__,
131
                                    )
132
            else:
133
                symbol = "%s.%s.%s" % (self.__class__.__module__,
134
                                       self.__class__.__name__,
135
                                       callable.__name__
136
                                       )
3530.2.2 by John Arbash Meinel
Add extra debugging for when a deprecated function/method are called
137
            trace.mutter_callsite(4, "Deprecated method called")
7143.15.2 by Jelmer Vernooij
Run autopep8.
138
            warn(deprecation_version %
139
                 symbol, DeprecationWarning, stacklevel=2)
1534.2.1 by Robert Collins
Implement deprecated_method
140
            return callable(self, *args, **kwargs)
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
141
        _populate_decorated(callable, deprecation_version, "method",
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
142
                            decorated_method)
1534.2.1 by Robert Collins
Implement deprecated_method
143
        return decorated_method
144
    return method_decorator
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
145
146
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
147
def deprecated_passed(parameter_value):
148
    """Return True if parameter_value was used."""
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
149
    # FIXME: it might be nice to have a parameter deprecation decorator.
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
150
    # it would need to handle positional and *args and **kwargs parameters,
151
    # which means some mechanism to describe how the parameter was being
152
    # passed before deprecation, and some way to deprecate parameters that
153
    # were not at the end of the arg list. Thats needed for __init__ where
154
    # we cannot just forward to a new method name.I.e. in the following
155
    # examples we would want to have callers that pass any value to 'bad' be
156
    # given a warning - because we have applied:
3400.3.4 by Martin Pool
Remove zero_seven deprecations
157
    # @deprecated_parameter('bad', deprecated_in((1, 5, 0))
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
158
    #
159
    # def __init__(self, bad=None)
160
    # def __init__(self, bad, other)
161
    # def __init__(self, **kwargs)
162
    # RBC 20060116
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
163
    return parameter_value is not DEPRECATED_PARAMETER
1534.4.2 by Robert Collins
Introduce BranchFormats - factoring out intialisation of Branches.
164
165
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
166
def _decorate_docstring(callable, deprecation_version, label,
167
                        decorated_callable):
1732.1.1 by John Arbash Meinel
deprecating appendpath, it does exactly what pathjoin does
168
    if callable.__doc__:
169
        docstring_lines = callable.__doc__.split('\n')
170
    else:
171
        docstring_lines = []
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
172
    if len(docstring_lines) == 0:
173
        decorated_callable.__doc__ = deprecation_version % ("This " + label)
174
    elif len(docstring_lines) == 1:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
175
        decorated_callable.__doc__ = (
176
            callable.__doc__ + "\n" + "\n" +
177
            deprecation_version % ("This " + label) + "\n")
1534.2.3 by Robert Collins
decorate docstrings in deprecated functions.
178
    else:
179
        spaces = len(docstring_lines[-1])
180
        new_doc = callable.__doc__
181
        new_doc += "\n" + " " * spaces
182
        new_doc += deprecation_version % ("This " + label)
183
        new_doc += "\n" + " " * spaces
184
        decorated_callable.__doc__ = new_doc
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
185
186
187
def _populate_decorated(callable, deprecation_version, label,
188
                        decorated_callable):
189
    """Populate attributes like __name__ and __doc__ on the decorated callable.
190
    """
191
    _decorate_docstring(callable, deprecation_version, label,
192
                        decorated_callable)
1534.1.3 by Robert Collins
Bugfix the symbol_versioning deprecation decorators to update the
193
    decorated_callable.__module__ = callable.__module__
1534.2.5 by Robert Collins
Set the __name__ attribute on decorated methods and functions.
194
    decorated_callable.__name__ = callable.__name__
1581.1.1 by Robert Collins
Bugfix aliases to be backwards compatible with plugins providing command.run_argv.
195
    decorated_callable.is_deprecated = True
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
196
197
2227.1.5 by mbp at sourcefrog
doc cleanup
198
def _dict_deprecation_wrapper(wrapped_method):
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
199
    """Returns a closure that emits a warning and calls the superclass"""
200
    def cb(dep_dict, *args, **kwargs):
201
        msg = 'access to %s' % (dep_dict._variable_name, )
202
        msg = dep_dict._deprecation_version % (msg,)
203
        if dep_dict._advice:
204
            msg += ' ' + dep_dict._advice
205
        warn(msg, DeprecationWarning, stacklevel=2)
2227.1.5 by mbp at sourcefrog
doc cleanup
206
        return wrapped_method(dep_dict, *args, **kwargs)
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
207
    return cb
208
209
210
class DeprecatedDict(dict):
211
    """A dictionary that complains when read or written."""
212
213
    is_deprecated = True
214
215
    def __init__(self,
7143.15.2 by Jelmer Vernooij
Run autopep8.
216
                 deprecation_version,
217
                 variable_name,
218
                 initial_value,
219
                 advice,
220
                 ):
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
221
        """Create a dict that warns when read or modified.
222
3400.3.5 by Martin Pool
Remove zero_nine deprecations
223
        :param deprecation_version: string for the warning format to raise,
224
            typically from deprecated_in()
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
225
        :param initial_value: The contents of the dict
226
        :param variable_name: This allows better warnings to be printed
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
227
        :param advice: String of advice on what callers should do instead
2227.1.2 by mbp at sourcefrog
Add a simple DeprecatedDict class
228
            of using this variable.
229
        """
230
        self._deprecation_version = deprecation_version
231
        self._variable_name = variable_name
232
        self._advice = advice
233
        dict.__init__(self, initial_value)
234
235
    # This isn't every possible method but it should trap anyone using the
236
    # dict -- add more if desired
237
    __len__ = _dict_deprecation_wrapper(dict.__len__)
238
    __getitem__ = _dict_deprecation_wrapper(dict.__getitem__)
239
    __setitem__ = _dict_deprecation_wrapper(dict.__setitem__)
240
    __delitem__ = _dict_deprecation_wrapper(dict.__delitem__)
241
    keys = _dict_deprecation_wrapper(dict.keys)
242
    __contains__ = _dict_deprecation_wrapper(dict.__contains__)
243
244
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
245
def deprecated_list(deprecation_version, variable_name,
246
                    initial_value, extra=None):
247
    """Create a list that warns when modified
248
3400.3.5 by Martin Pool
Remove zero_nine deprecations
249
    :param deprecation_version: string for the warning format to raise,
250
        typically from deprecated_in()
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
251
    :param initial_value: The contents of the list
252
    :param variable_name: This allows better warnings to be printed
253
    :param extra: Extra info to print when printing a warning
254
    """
255
256
    subst_text = 'Modifying %s' % (variable_name,)
257
    msg = deprecation_version % (subst_text,)
258
    if extra:
259
        msg += ' ' + extra
260
261
    class _DeprecatedList(list):
262
        __doc__ = list.__doc__ + msg
263
264
        is_deprecated = True
265
266
        def _warn_deprecated(self, func, *args, **kwargs):
267
            warn(msg, DeprecationWarning, stacklevel=3)
268
            return func(self, *args, **kwargs)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
269
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
270
        def append(self, obj):
271
            """appending to %s is deprecated""" % (variable_name,)
272
            return self._warn_deprecated(list.append, obj)
273
274
        def insert(self, index, obj):
275
            """inserting to %s is deprecated""" % (variable_name,)
276
            return self._warn_deprecated(list.insert, index, obj)
277
278
        def extend(self, iterable):
279
            """extending %s is deprecated""" % (variable_name,)
280
            return self._warn_deprecated(list.extend, iterable)
281
282
        def remove(self, value):
283
            """removing from %s is deprecated""" % (variable_name,)
284
            return self._warn_deprecated(list.remove, value)
285
286
        def pop(self, index=None):
4031.3.1 by Frank Aspell
Fixing various typos
287
            """pop'ing from %s is deprecated""" % (variable_name,)
1836.1.12 by John Arbash Meinel
Move ignores into a file of their own, make DEFAULT_IGNORE a deprecated list. Create deprecated_list in symbol versioning.
288
            if index:
289
                return self._warn_deprecated(list.pop, index)
290
            else:
291
                # Can't pass None
292
                return self._warn_deprecated(list.pop)
293
294
    return _DeprecatedList(initial_value)
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
295
296
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
297
def _check_for_filter(error_only):
298
    """Check if there is already a filter for deprecation warnings.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
299
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
300
    :param error_only: Only match an 'error' filter
301
    :return: True if a filter is found, False otherwise
302
    """
303
    for filter in warnings.filters:
304
        if issubclass(DeprecationWarning, filter[2]):
305
            # This filter will effect DeprecationWarning
306
            if not error_only or filter[0] == 'error':
307
                return True
308
    return False
309
310
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
311
def _remove_filter_callable(filter):
312
    """Build and returns a callable removing filter from the warnings.
313
314
    :param filter: The filter to remove (can be None).
315
316
    :return: A callable that will remove filter from warnings.filters.
317
    """
318
    def cleanup():
319
        if filter:
320
            warnings.filters.remove(filter)
321
    return cleanup
322
323
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
324
def suppress_deprecation_warnings(override=True):
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
325
    """Call this function to suppress all deprecation warnings.
326
327
    When this is a final release version, we don't want to annoy users with
328
    lots of deprecation warnings. We only want the deprecation warnings when
329
    running a dev or release candidate.
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
330
331
    :param override: If True, always set the ignore, if False, only set the
332
        ignore if there isn't already a filter.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
333
5320.2.1 by Robert Collins
The symbol_versioning module can now cleanup after itself -
334
    :return: A callable to remove the new warnings this added.
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
335
    """
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
336
    if not override and _check_for_filter(error_only=False):
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
337
        # If there is already a filter effecting suppress_deprecation_warnings,
338
        # then skip it.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
339
        filter = None
340
    else:
341
        warnings.filterwarnings('ignore', category=DeprecationWarning)
342
        filter = warnings.filters[0]
343
    return _remove_filter_callable(filter)
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
344
345
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
346
def activate_deprecation_warnings(override=True):
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
347
    """Call this function to activate deprecation warnings.
348
349
    When running in a 'final' release we suppress deprecation warnings.
350
    However, the test suite wants to see them. So when running selftest, we
351
    re-enable the deprecation warnings.
352
353
    Note: warnings that have already been issued under 'ignore' will not be
354
    reported after this point. The 'warnings' module has already marked them as
355
    handled, so they don't get issued again.
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
356
357
    :param override: If False, only add a filter if there isn't an error filter
358
        already. (This slightly differs from suppress_deprecation_warnings, in
359
        because it always overrides everything but -Werror).
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
360
361
    :return: A callable to remove the new warnings this added.
3427.5.1 by John Arbash Meinel
Have the bzrlib.commands.main() function suppress deprecation warnings when running a final release.
362
    """
3427.5.7 by John Arbash Meinel
Bring back always in the form of 'override'.
363
    if not override and _check_for_filter(error_only=True):
3427.5.5 by John Arbash Meinel
Disable suppression if there is already a filter present for Warnings
364
        # DeprecationWarnings are already turned into errors, don't downgrade
365
        # them to 'default'.
5393.2.1 by Vincent Ladeuil
Fix bug #625686 by removing the warning filter added by selftest.
366
        filter = None
367
    else:
368
        warnings.filterwarnings('default', category=DeprecationWarning)
369
        filter = warnings.filters[0]
370
    return _remove_filter_callable(filter)