/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
57
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
58
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
59
from .branch import Branch
60
from .cleanup import OperationWithCleanups
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
61
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
62
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
63
                     ConflictsInTree,
64
                     StrictCommitFailed
65
                     )
66
from .osutils import (get_user_encoding,
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
67
                      has_symlinks,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      )
71
from .trace import mutter, note, is_quiet
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
72
from .tree import TreeChange
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
73
from .urlutils import unescape_for_display
74
from .i18n import gettext
75
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
6734.1.20 by Jelmer Vernooij
Move errors.
77
class PointlessCommit(BzrError):
78
79
    _fmt = "No changes to commit"
80
81
82
class CannotCommitSelectedFileMerge(BzrError):
83
84
    _fmt = 'Selected-file commit of merges is not supported yet:'\
85
        ' files %(files_str)s'
86
87
    def __init__(self, files):
88
        files_str = ', '.join(files)
89
        BzrError.__init__(self, files=files, files_str=files_str)
90
91
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
92
def filter_excluded(iter_changes, exclude):
93
    """Filter exclude filenames.
94
95
    :param iter_changes: iter_changes function
96
    :param exclude: List of paths to exclude
97
    :return: iter_changes function
98
    """
99
    for change in iter_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
100
        new_excluded = (change.path[1] is not None and
101
                        is_inside_any(exclude, change.path[1]))
102
103
        old_excluded = (change.path[0] is not None and
104
                        is_inside_any(exclude, change.path[0]))
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
105
106
        if old_excluded and new_excluded:
107
            continue
108
109
        if old_excluded or new_excluded:
110
            # TODO(jelmer): Perhaps raise an error here instead?
111
            continue
112
113
        yield change
114
115
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
class NullCommitReporter(object):
117
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
118
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
119
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
120
        pass
121
122
    def snapshot_change(self, change, path):
123
        pass
124
125
    def completed(self, revno, rev_id):
126
        pass
127
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
128
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
129
        pass
130
131
    def missing(self, path):
132
        pass
133
134
    def renamed(self, change, old_path, new_path):
135
        pass
136
2789.2.11 by Ian Clatworthy
remove more reporting stuff
137
    def is_verbose(self):
138
        return False
139
140
141
class ReportCommitToLog(NullCommitReporter):
142
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
143
    def _note(self, format, *args):
144
        """Output a message.
145
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
146
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
147
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
148
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
149
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
150
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
151
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
152
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
153
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
154
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
155
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
156
        self._note(
157
            gettext('Committing to: %s'),
158
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
159
160
    def completed(self, revno, rev_id):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
161
        self._note(gettext('Committed revision %d.'), revno)
5086.6.2 by Robert Collins
Log revision id as well as revno when committing.
162
        # self._note goes to the console too; so while we want to log the
163
        # rev_id, we can't trivially only log it. (See bug 526425). Long
164
        # term we should rearrange the reporting structure, but for now
165
        # we just mutter seperately. We mutter the revid and revno together
166
        # so that concurrent bzr invocations won't lead to confusion.
167
        mutter('Committed revid %s as revno %d.', rev_id, revno)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
168
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
169
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
170
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
171
172
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
173
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
174
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
175
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
176
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
177
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
178
    def is_verbose(self):
179
        return True
180
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
181
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
class Commit(object):
183
    """Task of committing a new revision.
184
185
    This is a MethodObject: it accumulates state as the commit is
186
    prepared, and then it is discarded.  It doesn't represent
187
    historical revisions, just the act of recording a new one.
188
189
            missing_ids
190
            Modified to hold a list of files that have been deleted from
191
            the working directory; these should be removed from the
192
            working inventory.
485 by Martin Pool
- move commit code into its own module
193
    """
7143.15.2 by Jelmer Vernooij
Run autopep8.
194
1189 by Martin Pool
- BROKEN: partial support for commit into weave
195
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
196
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
197
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
198
        """Create a Commit object.
199
200
        :param reporter: the default reporter to use or None to decide later
201
        """
202
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
203
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
204
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
205
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
206
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
207
                        local=False, possible_master_transports=None):
208
        if revprops is None:
209
            revprops = {}
210
        if possible_master_transports is None:
211
            possible_master_transports = []
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
212
        if (u'branch-nick' not in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
213
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
214
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
215
                local,
216
                possible_master_transports)
217
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
218
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
219
                # XXX: maybe we should just accept one of them?
220
                raise AssertionError('author property given twice')
221
            if authors:
222
                for individual in authors:
223
                    if '\n' in individual:
224
                        raise AssertionError('\\n is not a valid character '
7143.15.2 by Jelmer Vernooij
Run autopep8.
225
                                             'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
226
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
227
        return revprops
228
1189 by Martin Pool
- BROKEN: partial support for commit into weave
229
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
230
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
               timestamp=None,
232
               timezone=None,
233
               committer=None,
234
               specific_files=None,
235
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
236
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
237
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
238
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
239
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
240
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
241
               local=False,
242
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
243
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
244
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
245
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
246
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
247
               possible_master_transports=None,
248
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
249
        """Commit working copy as a new revision.
250
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
251
        :param message: the commit message (it or message_callback is required)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
252
        :param message_callback: A callback: message =
253
            message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
255
        :param timestamp: if not None, seconds-since-epoch for a
256
            postdated/predated commit.
257
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
258
        :param specific_files: If not None, commit only those files. An empty
259
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
260
261
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
262
            Useful for test or import commands that need to tightly
263
            control what revisions are assigned.  If you duplicate
264
            a revision id that exists elsewhere it is your own fault.
265
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
266
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
267
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
268
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
269
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
270
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
271
            contains unknown files.
272
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
273
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
274
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
275
        :param reporter: the reporter to use or None for the default
276
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
277
        :param recursive: If set to 'down', commit in any subtrees that have
278
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
279
        :param exclude: None or a list of relative paths to exclude from the
280
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
281
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
282
        :param lossy: When committing to a foreign VCS, ignore any
283
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
284
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
285
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
286
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
287
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
288
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
289
        return operation.run(
7143.15.2 by Jelmer Vernooij
Run autopep8.
290
            message=message,
291
            timestamp=timestamp,
292
            timezone=timezone,
293
            committer=committer,
294
            specific_files=specific_files,
295
            rev_id=rev_id,
296
            allow_pointless=allow_pointless,
297
            strict=strict,
298
            verbose=verbose,
299
            working_tree=working_tree,
300
            local=local,
301
            reporter=reporter,
302
            message_callback=message_callback,
303
            recursive=recursive,
304
            exclude=exclude,
305
            possible_master_transports=possible_master_transports,
306
            lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
307
308
    def _commit(self, operation, message, timestamp, timezone, committer,
7143.15.2 by Jelmer Vernooij
Run autopep8.
309
                specific_files, rev_id, allow_pointless, strict, verbose,
310
                working_tree, local, reporter, message_callback, recursive,
311
                exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
312
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
313
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
314
        if working_tree is None:
315
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
316
        else:
317
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
318
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
319
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
320
                if not self.branch.repository.supports_rich_root():
321
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
322
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
323
            if message is not None:
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
324
                if isinstance(message, bytes):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
325
                    message = message.decode(get_user_encoding())
7143.15.2 by Jelmer Vernooij
Run autopep8.
326
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
327
                def message_callback(x):
328
                    return message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
329
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
330
                raise BzrError("The message or message_callback keyword"
331
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
332
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
333
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
334
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
335
        if exclude is not None:
336
            self.exclude = sorted(
337
                minimum_path_selection(exclude))
338
        else:
339
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
340
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
341
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
342
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
343
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
344
        # self.specific_files is None to indicate no filter, or any iterable to
345
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
346
        if specific_files is not None:
347
            self.specific_files = sorted(
348
                minimum_path_selection(specific_files))
349
        else:
350
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
351
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
352
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
353
        self.message_callback = message_callback
354
        self.timestamp = timestamp
355
        self.timezone = timezone
356
        self.committer = committer
357
        self.strict = strict
358
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
359
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
360
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
361
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
362
        self.parents = self.work_tree.get_parent_ids()
5582.10.6 by Jelmer Vernooij
Fix ui imports.
363
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
364
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
365
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
366
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
367
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
368
        operation.add_cleanup(self.basis_tree.unlock)
369
        # Cannot commit with conflicts present.
370
        if len(self.work_tree.conflicts()) > 0:
371
            raise ConflictsInTree
372
373
        # Setup the bound branch variables as needed.
374
        self._check_bound_branch(operation, possible_master_transports)
375
376
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
377
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
378
379
        # Complete configuration setup
380
        if reporter is not None:
381
            self.reporter = reporter
382
        elif self.reporter is None:
383
            self.reporter = self._select_reporter()
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
384
        if self.config_stack is None:
6449.6.4 by Jelmer Vernooij
Use config stack.
385
            self.config_stack = self.work_tree.get_config_stack()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
386
387
        # Setup the progress bar. As the number of files that need to be
388
        # committed in unknown, progress is reported as stages.
389
        # We keep track of entries separately though and include that
390
        # information in the progress bar during the relevant stages.
391
        self.pb_stage_name = ""
392
        self.pb_stage_count = 0
393
        self.pb_stage_total = 5
394
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
395
            # 2 extra stages: "Uploading data to master branch" and "Merging
396
            # tags to master branch"
397
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
398
        self.pb.show_pct = False
399
        self.pb.show_spinner = False
400
        self.pb.show_eta = False
401
        self.pb.show_count = True
402
        self.pb.show_bar = True
403
404
        # After a merge, a selected file commit is not supported.
405
        # See 'bzr help merge' for an explanation as to why.
406
        if len(self.parents) > 1 and self.specific_files is not None:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
407
            raise CannotCommitSelectedFileMerge(self.specific_files)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
408
        # Excludes are a form of selected file commit.
409
        if len(self.parents) > 1 and self.exclude:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
410
            raise CannotCommitSelectedFileMerge(self.exclude)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
411
412
        # Collect the changes
413
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
414
        self._lossy = lossy
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
415
        self.builder = self.branch.get_commit_builder(
416
            self.parents, self.config_stack, timestamp, timezone, committer,
417
            self.revprops, rev_id, lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
418
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
419
        if self.builder.updates_branch and self.bound_branch:
420
            self.builder.abort()
421
            raise AssertionError(
422
                "bound branches not supported for commit builders "
423
                "that update the branch")
424
1189 by Martin Pool
- BROKEN: partial support for commit into weave
425
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
426
            # find the location being committed to
427
            if self.bound_branch:
428
                master_location = self.master_branch.base
429
            else:
430
                master_location = self.branch.base
431
432
            # report the start of the commit
433
            self.reporter.started(new_revno, self.rev_id, master_location)
434
435
            self._update_builder_with_changes()
436
            self._check_pointless()
437
438
            # TODO: Now the new inventory is known, check for conflicts.
439
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
440
            # weave lines, because nothing should be recorded until it is known
441
            # that commit will succeed.
442
            self._set_progress_stage("Saving data locally")
443
            self.builder.finish_inventory()
444
445
            # Prompt the user for a commit message if none provided
446
            message = message_callback(self)
447
            self.message = message
448
449
            # Add revision data to the local branch
450
            self.rev_id = self.builder.commit(self.message)
451
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
452
        except Exception:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
453
            mutter("aborting commit write group because of exception:")
454
            trace.log_exception_quietly()
455
            self.builder.abort()
456
            raise
457
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
458
        self._update_branches(old_revno, old_revid, new_revno)
459
460
        # Make the working tree be up to date with the branch. This
461
        # includes automatic changes scheduled to be made to the tree, such
462
        # as updating its basis and unversioning paths that were missing.
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
463
        self.work_tree.unversion(self.deleted_paths)
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
464
        self._set_progress_stage("Updating the working tree")
465
        self.work_tree.update_basis_by_delta(self.rev_id,
7143.15.2 by Jelmer Vernooij
Run autopep8.
466
                                             self.builder.get_basis_delta())
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
467
        self.reporter.completed(new_revno, self.rev_id)
468
        self._process_post_hooks(old_revno, new_revno)
469
        return self.rev_id
470
471
    def _update_branches(self, old_revno, old_revid, new_revno):
472
        """Update the master and local branch to the new revision.
473
474
        This will try to make sure that the master branch is updated
475
        before the local branch.
476
477
        :param old_revno: Revision number of master branch before the
478
            commit
479
        :param old_revid: Tip of master branch before the commit
480
        :param new_revno: Revision number of the new commit
481
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
482
        if not self.builder.updates_branch:
483
            self._process_pre_hooks(old_revno, new_revno)
484
485
            # Upload revision data to the master.
486
            # this will propagate merged revisions too if needed.
487
            if self.bound_branch:
488
                self._set_progress_stage("Uploading data to master branch")
489
                # 'commit' to the master first so a timeout here causes the
490
                # local branch to be out of date
491
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
492
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
493
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
494
                    self.branch.fetch(self.master_branch, self.rev_id)
495
496
            # and now do the commit locally.
497
            self.branch.set_last_revision_info(new_revno, self.rev_id)
498
        else:
499
            try:
500
                self._process_pre_hooks(old_revno, new_revno)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
501
            except BaseException:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
502
                # The commit builder will already have updated the branch,
503
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
504
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
505
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
506
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
507
        # Merge local tags to remote
508
        if self.bound_branch:
509
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
510
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
511
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
512
            if tag_conflicts:
513
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
7143.15.2 by Jelmer Vernooij
Run autopep8.
514
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
515
                    "\n".join(warning_lines))))
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
516
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
517
    def _select_reporter(self):
518
        """Select the CommitReporter to use."""
519
        if is_quiet():
520
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
521
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
522
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
523
    def _check_pointless(self):
524
        if self.allow_pointless:
525
            return
526
        # A merge with no effect on files
527
        if len(self.parents) > 1:
528
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
529
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
530
            return
531
        raise PointlessCommit()
532
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
533
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
534
        """Check to see if the local branch is bound.
535
536
        If it is bound, then most of the commit will actually be
537
        done using the remote branch as the target branch.
538
        Only at the end will the local branch be updated.
539
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
540
        if self.local and not self.branch.get_bound_location():
541
            raise errors.LocalRequiresBoundBranch()
542
543
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
544
            self.master_branch = self.branch.get_master_branch(
545
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
546
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
547
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
548
            # make this branch the reference branch for out of date checks.
549
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
550
            return
551
552
        # If the master branch is bound, we must fail
553
        master_bound_location = self.master_branch.get_bound_location()
554
        if master_bound_location:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
555
            raise errors.CommitToDoubleBoundBranch(
556
                self.branch, self.master_branch, master_bound_location)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
557
558
        # TODO: jam 20051230 We could automatically push local
559
        #       commits to the remote branch if they would fit.
560
        #       But for now, just require remote to be identical
561
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
562
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
563
        # Make sure the local branch is identical to the master
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
564
        master_revid = self.master_branch.last_revision()
565
        local_revid = self.branch.last_revision()
566
        if local_revid != master_revid:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
567
            raise errors.BoundBranchOutOfDate(self.branch,
7143.15.2 by Jelmer Vernooij
Run autopep8.
568
                                              self.master_branch)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
569
570
        # Now things are ready to change the master branch
571
        # so grab the lock
572
        self.bound_branch = self.branch
573
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
574
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
575
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
576
    def _check_out_of_date_tree(self):
577
        """Check that the working tree is up to date.
578
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
579
        :return: old_revision_number, old_revision_id, new_revision_number
580
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
581
        """
582
        try:
583
            first_tree_parent = self.work_tree.get_parent_ids()[0]
584
        except IndexError:
585
            # if there are no parents, treat our parent as 'None'
586
            # this is so that we still consider the master branch
587
            # - in a checkout scenario the tree may have no
588
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
589
            first_tree_parent = breezy.revision.NULL_REVISION
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
590
        try:
591
            old_revno, master_last = self.master_branch.last_revision_info()
592
        except errors.UnsupportedOperation:
593
            master_last = self.master_branch.last_revision()
594
            old_revno = self.branch.revision_id_to_revno(master_last)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
595
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
596
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
597
                raise errors.OutOfDateTree(self.work_tree)
598
        if self.branch.repository.has_revision(first_tree_parent):
599
            new_revno = old_revno + 1
600
        else:
601
            # ghost parents never appear in revision history.
602
            new_revno = 1
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
603
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
604
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
605
    def _process_pre_hooks(self, old_revno, new_revno):
606
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
607
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
608
        self._process_hooks("pre_commit", old_revno, new_revno)
609
610
    def _process_post_hooks(self, old_revno, new_revno):
611
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
612
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
613
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
614
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
615
        # 0.15^H^H^H^H 2.5.0)
616
        post_commit = self.config_stack.get('post_commit')
617
        if post_commit is not None:
618
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
619
            # this would be nicer with twisted.python.reflect.namedAny
620
            for hook in hooks:
621
                result = eval(hook + '(branch, rev_id)',
7143.15.2 by Jelmer Vernooij
Run autopep8.
622
                              {'branch': self.branch,
623
                               'breezy': breezy,
624
                               'rev_id': self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
625
        # process new style post commit hooks
626
        self._process_hooks("post_commit", old_revno, new_revno)
627
628
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
629
        if not Branch.hooks[hook_name]:
630
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
631
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
632
        # new style commit hooks:
633
        if not self.bound_branch:
634
            hook_master = self.branch
635
            hook_local = None
636
        else:
637
            hook_master = self.master_branch
638
            hook_local = self.branch
639
        # With bound branches, when the master is behind the local branch,
640
        # the 'old_revno' and old_revid values here are incorrect.
641
        # XXX: FIXME ^. RBC 20060206
642
        if self.parents:
643
            old_revid = self.parents[0]
644
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
645
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
646
2659.3.9 by NamNguyen
branch.py:
647
        if hook_name == "pre_commit":
648
            future_tree = self.builder.revision_tree()
649
            tree_delta = future_tree.changes_from(self.basis_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
650
                                                  include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
651
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
652
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
653
            # show the running hook in the progress bar. As hooks may
654
            # end up doing nothing (e.g. because they are not configured by
655
            # the user) this is still showing progress, not showing overall
656
            # actions - its up to each plugin to show a UI if it want's to
657
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
658
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
659
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
660
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
661
            if 'hooks' in debug.debug_flags:
662
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
663
            if hook_name == "post_commit":
664
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
665
                     self.rev_id)
666
            elif hook_name == "pre_commit":
667
                hook(hook_local, hook_master,
668
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
669
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
670
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
671
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
672
        """Update the commit builder with the data about what has changed.
673
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
674
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
675
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
676
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
677
        self._check_strict()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
678
        iter_changes = self.work_tree.iter_changes(
679
            self.basis_tree, specific_files=specific_files)
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
680
        if self.exclude:
681
            iter_changes = filter_excluded(iter_changes, self.exclude)
682
        iter_changes = self._filter_iter_changes(iter_changes)
7206.6.1 by Jelmer Vernooij
Drop file_id from record_iter_changes return value.
683
        for path, fs_hash in self.builder.record_iter_changes(
7143.16.21 by Jelmer Vernooij
Fix regressions.
684
                self.work_tree, self.basis_revid, iter_changes):
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
685
            self.work_tree._observed_sha1(path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
686
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
687
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
688
        """Process iter_changes.
689
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
690
        This method reports on the changes in iter_changes to the user, and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
691
        converts 'missing' entries in the iter_changes iterator to 'deleted'
692
        entries. 'missing' entries have their
693
694
        :param iter_changes: An iter_changes to process.
695
        :return: A generator of changes.
696
        """
697
        reporter = self.reporter
698
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
699
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
700
        for change in iter_changes:
701
            if report_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
702
                old_path = change.path[0]
703
                new_path = change.path[1]
704
                versioned = change.versioned[1]
705
            kind = change.kind[1]
706
            versioned = change.versioned[1]
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
707
            if kind is None and versioned:
708
                # 'missing' path
709
                if report_changes:
710
                    reporter.missing(new_path)
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
711
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
712
                    trace.warning('Ignoring "%s" as symlinks are not '
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
713
                                  'supported on this filesystem.' % (change.path[0],))
6469.1.4 by Parth Malwankar
commit ignores symlinks on platforms that dont support symlinks
714
                    continue
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
715
                deleted_paths.append(change[1][1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
716
                # Reset the new path (None) and new versioned flag (False)
7322.1.7 by Jelmer Vernooij
Fix remaining tests.
717
                change = change.discard_new()
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
718
                new_path = change.path[1]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
719
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
720
            elif kind == 'tree-reference':
721
                if self.recursive == 'down':
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
722
                    self._commit_nested_tree(change[1][1])
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
723
            if change.versioned[0] or change.versioned[1]:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
724
                yield change
725
                if report_changes:
726
                    if new_path is None:
727
                        reporter.deleted(old_path)
728
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
729
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
730
                    elif old_path != new_path:
7143.15.2 by Jelmer Vernooij
Run autopep8.
731
                        reporter.renamed(gettext('renamed'),
732
                                         old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
733
                    else:
7143.15.2 by Jelmer Vernooij
Run autopep8.
734
                        if (new_path
735
                                or self.work_tree.branch.repository._format.rich_root_data):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
736
                            # Don't report on changes to '' in non rich root
737
                            # repositories.
7143.15.2 by Jelmer Vernooij
Run autopep8.
738
                            reporter.snapshot_change(
739
                                gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
740
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
741
        # Unversion files that were found to be deleted
742
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
743
744
    def _check_strict(self):
745
        # XXX: when we use iter_changes this would likely be faster if
746
        # iter_changes would check for us (even in the presence of
747
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
748
        if self.strict:
749
            # raise an exception as soon as we find a single unknown.
750
            for unknown in self.work_tree.unknowns():
751
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
752
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
753
    def _commit_nested_tree(self, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
754
        "Commit a nested tree."
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
755
        sub_tree = self.work_tree.get_nested_tree(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
756
        # FIXME: be more comprehensive here:
757
        # this works when both trees are in --trees repository,
758
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
759
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
760
        # finally implement the explicit-caches approach design
761
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
762
        if sub_tree.branch.repository.has_same_location(
7143.15.2 by Jelmer Vernooij
Run autopep8.
763
                self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
764
            sub_tree.branch.repository = \
765
                self.work_tree.branch.repository
766
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
767
            return sub_tree.commit(message=None, revprops=self.revprops,
7143.15.2 by Jelmer Vernooij
Run autopep8.
768
                                   recursive=self.recursive,
769
                                   message_callback=self.message_callback,
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
770
                                   timestamp=self.timestamp,
771
                                   timezone=self.timezone,
7143.15.2 by Jelmer Vernooij
Run autopep8.
772
                                   committer=self.committer,
773
                                   allow_pointless=self.allow_pointless,
774
                                   strict=self.strict, verbose=self.verbose,
775
                                   local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
776
        except PointlessCommit:
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
777
            return self.work_tree.get_reference_revision(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
778
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
779
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
780
        """Set the progress stage and emit an update to the progress bar."""
781
        self.pb_stage_name = name
782
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
783
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
784
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
785
        else:
786
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
787
        self._emit_progress()
788
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
789
    def _next_progress_entry(self):
790
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
791
        self.pb_entries_count += 1
792
        self._emit_progress()
793
794
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
795
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
796
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
7143.15.2 by Jelmer Vernooij
Run autopep8.
797
                                                       self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
798
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
799
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
800
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)