/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5752.3.8 by John Arbash Meinel
Merge bzr.dev 5764 to resolve release-notes (aka NEWS) conflicts
1
# Copyright (C) 2005-2011 Canonical Ltd
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
2
#
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
7
#
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
12
#
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1 by mbp at sourcefrog
import from baz patch-364
16
4961.1.1 by Martin Pool
doc
17
"""Messages and logging.
1185.33.6 by Martin Pool
Code and tests for shorter formatting of error messages
18
19
Messages are supplied by callers as a string-formatting template, plus values
20
to be inserted into it.  The actual %-formatting is deferred to the log
21
library so that it doesn't need to be done for messages that won't be emitted.
22
23
Messages are classified by severity levels: critical, error, warning, info,
24
and debug.
25
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
26
They can be sent to two places: stderr, and `$XDG_CACHE_HOME/breezy/brz.log`.
27
For purposes such as running the test suite, they can also be redirected away
28
from both of those two places to another location.
1185.33.6 by Martin Pool
Code and tests for shorter formatting of error messages
29
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
30
`brz.log` gets all messages, and full tracebacks for uncaught exceptions.
1185.33.51 by Martin Pool
Fix trace of non-ascii messages, and add test.
31
This trace file is always in UTF-8, regardless of the user's default encoding,
32
so that we can always rely on writing any message.
1185.33.6 by Martin Pool
Code and tests for shorter formatting of error messages
33
34
Output to stderr depends on the mode chosen by the user.  By default, messages
35
of info and above are sent out, which results in progress messages such as the
4961.1.1 by Martin Pool
doc
36
list of files processed by add and commit.  In debug mode, stderr gets debug messages too.
1185.33.6 by Martin Pool
Code and tests for shorter formatting of error messages
37
38
Errors that terminate an operation are generally passed back as exceptions;
39
others may be just emitted as messages.
40
41
Exceptions are reported in a brief form to stderr so as not to look scary.
42
BzrErrors are required to be able to format themselves into a properly
1759.2.1 by Jelmer Vernooij
Fix some types (found using aspell).
43
explanatory message.  This is not true for builtin exceptions such as
1185.33.6 by Martin Pool
Code and tests for shorter formatting of error messages
44
KeyError, which typically just str to "0".  They're printed in a different
45
form.
344 by Martin Pool
- It's not an error to use the library without
46
"""
47
6379.6.7 by Jelmer Vernooij
Move importing from future until after doc string, otherwise the doc string will disappear.
48
from __future__ import absolute_import
49
1185.16.74 by Martin Pool
doc
50
# FIXME: Unfortunately it turns out that python's logging module
51
# is quite expensive, even when the message is not printed by any handlers.
52
# We should perhaps change back to just simply doing it here.
3173.1.6 by Martin Pool
Remove _stderr_handler global
53
#
54
# On the other hand, as of 1.2 we generally only call the mutter() statement
55
# if (according to debug_flags) we actually intend to write it.  So the
56
# increased cost of logging.py is not so bad, and we could standardize on
57
# that.
1185.16.74 by Martin Pool
doc
58
6621.22.2 by Martin
Use BytesIO or StringIO from bzrlib.sixish
59
import errno
2978.1.1 by Alexander Belchenko
Output to stderr with trace module now going through wrapper that takes care about terminal encoding. (#54173)
60
import logging
1740.5.3 by Martin Pool
Cleanup more exception-formatting code
61
import os
1551.9.3 by Aaron Bentley
Revert buggy apport changes
62
import sys
3170.1.1 by Andrew Bennetts
Add -Dtimes, which adds a timestamp to mutters (using the time since the first mutter).
63
import time
1996.3.29 by John Arbash Meinel
don't import errors, and try to lazy import logging in bzrlib.trace
64
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
65
from .lazy_import import lazy_import
1996.3.29 by John Arbash Meinel
don't import errors, and try to lazy import logging in bzrlib.trace
66
lazy_import(globals(), """
5753.2.2 by Jelmer Vernooij
Remove some unnecessary imports, clean up lazy imports.
67
import tempfile
2725.1.1 by Robert Collins
Add -Devil flag to highlight the use of problematic API calls.
68
import traceback
1996.3.29 by John Arbash Meinel
don't import errors, and try to lazy import logging in bzrlib.trace
69
""")
1097 by Martin Pool
- send trace messages out through python logging module
70
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
71
import breezy
1097 by Martin Pool
- send trace messages out through python logging module
72
2095.5.2 by Martin Pool
save commit message if commit fails (#32054)
73
lazy_import(globals(), """
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
74
from breezy import (
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
75
    bedding,
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
76
    debug,
77
    errors,
2842.1.1 by Martin Pool
Report locale, encodings and plugins in traceback
78
    osutils,
4961.1.3 by Martin Pool
trace quietness now controls whether the progress bar appears
79
    ui,
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
80
    )
2095.5.2 by Martin Pool
save commit message if commit fails (#32054)
81
""")
82
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
83
from .sixish import (
6677.1.5 by Martin
Make crash debug and trace modules pass on Python 3
84
    PY3,
85
    StringIO,
6621.2.26 by Martin
Misc set of changes to get started with selftest on Python 3
86
    text_type,
6621.22.2 by Martin
Use BytesIO or StringIO from bzrlib.sixish
87
    )
88
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
89
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
90
# global verbosity for breezy; controls the log level for stderr; 0=normal; <0
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
91
# is quiet; >0 is verbose.
2768.1.2 by Ian Clatworthy
Make noise levels a scale, not just a boolean in trace.py
92
_verbosity_level = 0
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
93
94
# File-like object where mutter/debug output is currently sent.  Can be
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
95
# changed by _push_log_file etc.  This is directly manipulated by some
96
# external code; maybe there should be functions to do that more precisely
97
# than push/pop_log_file.
1185.43.7 by Martin Pool
Do debug messages not through python logging
98
_trace_file = None
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
99
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
100
# Absolute path for brz.log.  Not changed even if the log/trace output is
3173.1.5 by Martin Pool
Remove global _bzr_log_file
101
# redirected elsewhere.  Used to show the location in --version.
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
102
_brz_log_filename = None
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
103
104
# The time the first message was written to the trace file, so that we can
105
# show relative times since startup.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
106
_brz_log_start_time = breezy._start_time
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
107
1097 by Martin Pool
- send trace messages out through python logging module
108
3173.1.5 by Martin Pool
Remove global _bzr_log_file
109
# held in a global for quick reference
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
110
_brz_logger = logging.getLogger('brz')
1097 by Martin Pool
- send trace messages out through python logging module
111
2978.1.1 by Alexander Belchenko
Output to stderr with trace module now going through wrapper that takes care about terminal encoding. (#54173)
112
1558.8.1 by Aaron Bentley
Fix overall progress bar's interaction with 'note' and 'warning'
113
def note(*args, **kwargs):
5200.2.2 by Robert Collins
Document what note does a little.
114
    """Output a note to the user.
115
116
    Takes the same parameters as logging.info.
5200.2.4 by Robert Collins
Review feedback.
117
5200.2.2 by Robert Collins
Document what note does a little.
118
    :return: None
119
    """
3173.1.7 by Martin Pool
Rename push/pop_log_file, and deprecate enable/disable_test_log
120
    # FIXME: clearing the ui and then going through the abstract logging
121
    # framework is whack; we should probably have a logging Handler that
122
    # deals with terminal output if needed.
5582.10.6 by Jelmer Vernooij
Fix ui imports.
123
    ui.ui_factory.clear_term()
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
124
    _brz_logger.info(*args, **kwargs)
1558.8.1 by Aaron Bentley
Fix overall progress bar's interaction with 'note' and 'warning'
125
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
126
1558.8.1 by Aaron Bentley
Fix overall progress bar's interaction with 'note' and 'warning'
127
def warning(*args, **kwargs):
5582.10.6 by Jelmer Vernooij
Fix ui imports.
128
    ui.ui_factory.clear_term()
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
129
    _brz_logger.warning(*args, **kwargs)
1558.8.1 by Aaron Bentley
Fix overall progress bar's interaction with 'note' and 'warning'
130
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
131
5055.4.1 by Gordon Tyler
Fixed show_error args and added test for show_error.
132
def show_error(*args, **kwargs):
4695.5.9 by Martin Pool
Restore info, log_error and error, as deprecated functions
133
    """Show an error message to the user.
134
135
    Don't use this for exceptions, use report_exception instead.
136
    """
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
137
    _brz_logger.error(*args, **kwargs)
4695.5.9 by Martin Pool
Restore info, log_error and error, as deprecated functions
138
139
7008.2.1 by Martin
Make mutter saner with string interpolation
140
class _Bytes(str):
141
    """Compat class for displaying bytes on Python 2."""
142
143
    def __repr__(self):
144
        return 'b' + str.__repr__(self)
145
146
    def __unicode__(self):
147
        return self.decode('ascii', 'replace')
148
149
1185.43.7 by Martin Pool
Do debug messages not through python logging
150
def mutter(fmt, *args):
1185.43.10 by Martin Pool
Remove need for BZR_DEBUG to get debug info in trace file.
151
    if _trace_file is None:
152
        return
4792.6.1 by Martin Pool
Avoid time-based flushing of trace file, it's line buffered anyhow
153
    # XXX: Don't check this every time; instead anyone who closes the file
154
    # ought to deregister it.  We can tolerate None.
1963.2.6 by Robey Pointer
pychecker is on crack; go back to using 'is None'.
155
    if (getattr(_trace_file, 'closed', None) is not None) and _trace_file.closed:
1185.43.10 by Martin Pool
Remove need for BZR_DEBUG to get debug info in trace file.
156
        return
1948.1.9 by John Arbash Meinel
Change mutter() so that it doesn't try so hard to write out perfect utf8, instead, rather than using a utf8 file, it changes unicode to utf8 manually
157
7008.2.1 by Martin
Make mutter saner with string interpolation
158
    # Let format strings be specified as ascii bytes to help Python 2
159
    if isinstance(fmt, bytes):
160
        fmt = fmt.decode('ascii', 'replace')
1948.1.9 by John Arbash Meinel
Change mutter() so that it doesn't try so hard to write out perfect utf8, instead, rather than using a utf8 file, it changes unicode to utf8 manually
161
7008.2.1 by Martin
Make mutter saner with string interpolation
162
    if args:
163
        if not PY3:
164
            args = tuple(
165
                _Bytes(arg) if isinstance(arg, bytes) else arg for arg in args)
166
        out = fmt % args
1185.43.10 by Martin Pool
Remove need for BZR_DEBUG to get debug info in trace file.
167
    else:
1185.33.51 by Martin Pool
Fix trace of non-ascii messages, and add test.
168
        out = fmt
3928.2.1 by John Arbash Meinel
Update mutter() to flush occasionally.
169
    now = time.time()
7008.2.1 by Martin
Make mutter saner with string interpolation
170
    out = '%0.3f  %s\n' % (now - _brz_log_start_time, out)
171
    _trace_file.write(out.encode('utf-8'))
4792.6.1 by Martin Pool
Avoid time-based flushing of trace file, it's line buffered anyhow
172
    # there's no explicit flushing; the file is typically line buffered.
1097 by Martin Pool
- send trace messages out through python logging module
173
1185.43.10 by Martin Pool
Remove need for BZR_DEBUG to get debug info in trace file.
174
2725.1.1 by Robert Collins
Add -Devil flag to highlight the use of problematic API calls.
175
def mutter_callsite(stacklevel, fmt, *args):
176
    """Perform a mutter of fmt and args, logging the call trace.
177
178
    :param stacklevel: The number of frames to show. None will show all
179
        frames.
180
    :param fmt: The format string to pass to mutter.
181
    :param args: A list of substitution variables.
182
    """
6677.1.5 by Martin
Make crash debug and trace modules pass on Python 3
183
    outf = StringIO()
3441.5.1 by Andrew Bennetts
Avoid necessarily calling get_parent_map when pushing.
184
    if stacklevel is None:
185
        limit = None
186
    else:
187
        limit = stacklevel + 1
188
    traceback.print_stack(limit=limit, file=outf)
2725.1.1 by Robert Collins
Add -Devil flag to highlight the use of problematic API calls.
189
    formatted_lines = outf.getvalue().splitlines()
190
    formatted_stack = '\n'.join(formatted_lines[:-2])
191
    mutter(fmt + "\nCalled from:\n%s", *(args + (formatted_stack,)))
192
193
261 by Martin Pool
- auto-rollover of .bzr.log
194
def _rollover_trace_maybe(trace_fname):
359 by Martin Pool
- pychecker fixups
195
    import stat
261 by Martin Pool
- auto-rollover of .bzr.log
196
    try:
197
        size = os.stat(trace_fname)[stat.ST_SIZE]
333 by Martin Pool
- allow trace file to grow up to 4MB
198
        if size <= 4 << 20:
261 by Martin Pool
- auto-rollover of .bzr.log
199
            return
200
        old_fname = trace_fname + '.old'
2851.3.1 by Martin Pool
Add unit test for _rollover_trace_maybe
201
        osutils.rename(trace_fname, old_fname)
261 by Martin Pool
- auto-rollover of .bzr.log
202
    except OSError:
203
        return
204
205
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
206
def _get_brz_log_filename():
207
    brz_log = osutils.path_from_environ('BRZ_LOG')
208
    if brz_log:
209
        return brz_log
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
210
    return os.path.join(bedding.cache_dir(), 'brz.log')
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
211
212
213
def _open_brz_log():
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
214
    """Open the brz.log trace file.
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
215
216
    If the log is more than a particular length, the old file is renamed to
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
217
    brz.log.old and a new file is started.  Otherwise, we append to the
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
218
    existing file.
219
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
220
    This sets the global _brz_log_filename.
3173.1.2 by Martin Pool
bzrlib.trace docs and cleanups
221
    """
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
222
    global _brz_log_filename
5116.2.3 by Parth Malwankar
updated log file creation to avoid race based on implementation by Martin [gz]
223
5116.3.1 by Martin
Rearrange log opening helper function and fix a couple of bugs
224
    def _open_or_create_log_file(filename):
225
        """Open existing log file, or create with ownership and permissions
5116.2.6 by Parth Malwankar
renamed copy_ownership to copy_ownership_from_path.
226
227
        It inherits the ownership and permissions (masked by umask) from
228
        the containing directory to cope better with being run under sudo
229
        with $HOME still set to the user's homedir.
5116.2.3 by Parth Malwankar
updated log file creation to avoid race based on implementation by Martin [gz]
230
        """
5116.2.6 by Parth Malwankar
renamed copy_ownership to copy_ownership_from_path.
231
        flags = os.O_WRONLY | os.O_APPEND | osutils.O_TEXT
5116.2.5 by Parth Malwankar
added 'while True:' so multiple process can spin on log file creation
232
        while True:
233
            try:
5116.2.6 by Parth Malwankar
renamed copy_ownership to copy_ownership_from_path.
234
                fd = os.open(filename, flags)
5116.3.1 by Martin
Rearrange log opening helper function and fix a couple of bugs
235
                break
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
236
            except OSError as e:
5116.2.5 by Parth Malwankar
added 'while True:' so multiple process can spin on log file creation
237
                if e.errno != errno.ENOENT:
238
                    raise
239
            try:
6619.3.14 by Jelmer Vernooij
Convert some octal numbers to new notations.
240
                fd = os.open(filename, flags | os.O_CREAT | os.O_EXCL, 0o666)
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
241
            except OSError as e:
5116.2.5 by Parth Malwankar
added 'while True:' so multiple process can spin on log file creation
242
                if e.errno != errno.EEXIST:
243
                    raise
244
            else:
5116.2.6 by Parth Malwankar
renamed copy_ownership to copy_ownership_from_path.
245
                osutils.copy_ownership_from_path(filename)
5116.3.1 by Martin
Rearrange log opening helper function and fix a couple of bugs
246
                break
7143.15.2 by Jelmer Vernooij
Run autopep8.
247
        return os.fdopen(fd, 'ab', 0)  # unbuffered
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
248
249
    _brz_log_filename = _get_brz_log_filename()
250
    _rollover_trace_maybe(_brz_log_filename)
403 by Martin Pool
- Don't give an error if the trace file can't be opened
251
    try:
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
252
        brz_log_file = _open_or_create_log_file(_brz_log_filename)
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
253
        brz_log_file.write(b'\n')
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
254
        if brz_log_file.tell() <= 2:
7143.15.2 by Jelmer Vernooij
Run autopep8.
255
            brz_log_file.write(
256
                b"this is a debug log for diagnosing/reporting problems in brz\n")
257
            brz_log_file.write(
258
                b"you can delete or truncate this file, or include sections in\n")
259
            brz_log_file.write(
260
                b"bug reports to https://bugs.launchpad.net/brz/+filebug\n\n")
4634.143.2 by Parth Malwankar
fixed test cases to handle special .bzr.log files
261
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
262
        return brz_log_file
4634.143.4 by Parth Malwankar
added parent_dir and mkdir to osutils. osutils.mkdir optionally
263
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
264
    except EnvironmentError as e:
4634.118.1 by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr.
265
        # If we are failing to open the log, then most likely logging has not
266
        # been set up yet. So we just write to stderr rather than using
267
        # 'warning()'. If we using warning(), users get the unhelpful 'no
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
268
        # handlers registered for "brz"' when something goes wrong on the
4634.118.1 by John Arbash Meinel
Fix bug #503886, errors setting up logging go to stderr.
269
        # server. (bug #503886)
270
        sys.stderr.write("failed to open trace file: %s\n" % (e,))
3173.1.5 by Martin Pool
Remove global _bzr_log_file
271
    # TODO: What should happen if we fail to open the trace file?  Maybe the
272
    # objects should be pointed at /dev/null or the equivalent?  Currently
273
    # returns None which will cause failures later.
3805.2.4 by John Arbash Meinel
Handle when _open_bzr_log returns None.
274
    return None
260 by Martin Pool
- remove atexit() dependency for writing out execution times
275
1097 by Martin Pool
- send trace messages out through python logging module
276
1111 by Martin Pool
- add functions to enable and disable default logging, so that we can
277
def enable_default_logging():
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
278
    """Configure default logging: messages to stderr and debug to brz.log
3805.2.1 by John Arbash Meinel
Update trace to log when the process started.
279
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
280
    This should only be called once per process.
3173.1.6 by Martin Pool
Remove _stderr_handler global
281
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
282
    Non-command-line programs embedding breezy do not need to call this.  They
3173.1.6 by Martin Pool
Remove _stderr_handler global
283
    can instead either pass a file to _push_log_file, or act directly on
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
284
    logging.getLogger("brz").
3805.2.1 by John Arbash Meinel
Update trace to log when the process started.
285
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
286
    Output can be redirected away by calling _push_log_file.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
287
288
    :return: A memento from push_log_file for restoring the log state.
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
289
    """
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
290
    start_time = osutils.format_local_date(_brz_log_start_time,
3805.2.3 by John Arbash Meinel
Use osutils.format_local_date() instead of time.strftime()
291
                                           timezone='local')
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
292
    brz_log_file = _open_brz_log()
293
    if brz_log_file is not None:
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
294
        brz_log_file.write(start_time.encode('utf-8') + b'\n')
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
295
    memento = push_log_file(
296
        brz_log_file,
297
        r'[%(process)5d] %(asctime)s.%(msecs)03d %(levelname)s: %(message)s',
298
        r'%Y-%m-%d %H:%M:%S')
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
299
    # after hooking output into brz_log, we also need to attach a stderr
3173.1.6 by Martin Pool
Remove _stderr_handler global
300
    # handler, writing only at level info and with encoding
6973.12.9 by Jelmer Vernooij
More fixes.
301
    if sys.version_info[0] == 2:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
302
        stderr_handler = EncodedStreamHandler(
303
            sys.stderr, osutils.get_terminal_encoding(), 'replace',
304
            level=logging.INFO)
6973.12.9 by Jelmer Vernooij
More fixes.
305
    else:
306
        stderr_handler = logging.StreamHandler(stream=sys.stderr)
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
307
    logging.getLogger('brz').addHandler(stderr_handler)
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
308
    return memento
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
309
310
3173.1.7 by Martin Pool
Rename push/pop_log_file, and deprecate enable/disable_test_log
311
def push_log_file(to_file, log_format=None, date_format=None):
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
312
    """Intercept log and trace messages and send them to a file.
313
3173.1.11 by Martin Pool
Fix up renaming of push_log_file
314
    :param to_file: A file-like object to which messages will be sent.
315
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
316
    :returns: A memento that should be passed to _pop_log_file to restore the
5891.1.3 by Andrew Bennetts
Move docstring formatting fixes.
317
        previously active logging.
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
318
    """
319
    global _trace_file
320
    # make a new handler
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
321
    new_handler = EncodedStreamHandler(to_file, "utf-8", level=logging.DEBUG)
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
322
    if log_format is None:
323
        log_format = '%(levelname)8s  %(message)s'
324
    new_handler.setFormatter(logging.Formatter(log_format, date_format))
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
325
    # save and remove any existing log handlers
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
326
    brz_logger = logging.getLogger('brz')
327
    old_handlers = brz_logger.handlers[:]
328
    del brz_logger.handlers[:]
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
329
    # set that as the default logger
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
330
    brz_logger.addHandler(new_handler)
331
    brz_logger.setLevel(logging.DEBUG)
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
332
    # TODO: check if any changes are needed to the root logger
333
    #
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
334
    # TODO: also probably need to save and restore the level on brz_logger.
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
335
    # but maybe we can avoid setting the logger level altogether, and just set
336
    # the level on the handler?
337
    #
338
    # save the old trace file
339
    old_trace_file = _trace_file
340
    # send traces to the new one
341
    _trace_file = to_file
342
    return ('log_memento', old_handlers, new_handler, old_trace_file, to_file)
343
344
6619.3.15 by Jelmer Vernooij
Avoid tuple in function args.
345
def pop_log_file(entry):
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
346
    """Undo changes to logging/tracing done by _push_log_file.
347
5320.2.7 by Robert Collins
Sanity check that new_trace_file in pop_log_file is valid, and also fix a test that monkey patched get_terminal_encoding.
348
    This flushes, but does not close the trace file (so that anything that was
349
    in it is output.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
350
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
351
    Takes the memento returned from _push_log_file."""
6619.3.15 by Jelmer Vernooij
Avoid tuple in function args.
352
    (magic, old_handlers, new_handler, old_trace_file, new_trace_file) = entry
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
353
    global _trace_file
354
    _trace_file = old_trace_file
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
355
    brz_logger = logging.getLogger('brz')
356
    brz_logger.removeHandler(new_handler)
5222.2.7 by Robert Collins
Document bzrlib.initialize a little better, and explicitly propogate exceptions in the new __exit__ methods.
357
    # must be closed, otherwise logging will try to close it at exit, and the
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
358
    # file will likely already be closed underneath.
359
    new_handler.close()
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
360
    brz_logger.handlers = old_handlers
5320.2.7 by Robert Collins
Sanity check that new_trace_file in pop_log_file is valid, and also fix a test that monkey patched get_terminal_encoding.
361
    if new_trace_file is not None:
362
        new_trace_file.flush()
3173.1.1 by Martin Pool
New _push_log_file and _pop_log_file as a cleaner stack, towards a fix for #124153
363
364
3427.2.2 by James Westby
Just print the exception, keeping the API of log_exception_quietly the same.
365
def log_exception_quietly():
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
366
    """Log the last exception to the trace file only.
367
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
368
    Used for exceptions that occur internally and that may be
369
    interesting to developers but not to users.  For example,
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
370
    errors loading plugins.
371
    """
3427.2.2 by James Westby
Just print the exception, keeping the API of log_exception_quietly the same.
372
    mutter(traceback.format_exc())
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
373
374
375
def set_verbosity_level(level):
376
    """Set the verbosity level.
377
378
    :param level: -ve for quiet, 0 for normal, +ve for verbose
379
    """
380
    global _verbosity_level
381
    _verbosity_level = level
382
    _update_logging_level(level < 0)
4961.1.3 by Martin Pool
trace quietness now controls whether the progress bar appears
383
    ui.ui_factory.be_quiet(level < 0)
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
384
385
386
def get_verbosity_level():
387
    """Get the verbosity level.
388
389
    See set_verbosity_level() for values.
390
    """
391
    return _verbosity_level
392
393
394
def be_quiet(quiet=True):
395
    if quiet:
396
        set_verbosity_level(-1)
397
    else:
398
        set_verbosity_level(0)
399
400
401
def _update_logging_level(quiet=True):
402
    """Hide INFO messages if quiet."""
403
    if quiet:
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
404
        _brz_logger.setLevel(logging.WARNING)
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
405
    else:
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
406
        _brz_logger.setLevel(logging.INFO)
3173.1.4 by Martin Pool
Rearrange and clean up bzr trace/logging
407
408
409
def is_quiet():
410
    """Is the verbosity level negative?"""
411
    return _verbosity_level < 0
412
413
414
def is_verbose():
415
    """Is the verbosity level positive?"""
416
    return _verbosity_level > 0
417
418
3698.1.2 by John Arbash Meinel
Make message optional, don't check the memory flag directly.
419
def debug_memory(message='', short=True):
3698.1.1 by John Arbash Meinel
Move the memory debugging into a helper function.
420
    """Write out a memory dump."""
4011.1.1 by John Arbash Meinel
Implement -Dmemory for win32
421
    if sys.platform == 'win32':
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
422
        from breezy import win32utils
4011.1.1 by John Arbash Meinel
Implement -Dmemory for win32
423
        win32utils.debug_memory_win32api(message=message, short=short)
424
    else:
425
        _debug_memory_proc(message=message, short=short)
426
427
428
_short_fields = ('VmPeak', 'VmSize', 'VmRSS')
429
7143.15.2 by Jelmer Vernooij
Run autopep8.
430
4011.1.1 by John Arbash Meinel
Implement -Dmemory for win32
431
def _debug_memory_proc(message='', short=True):
3698.1.1 by John Arbash Meinel
Move the memory debugging into a helper function.
432
    try:
6973.7.5 by Jelmer Vernooij
s/file/open.
433
        status_file = open('/proc/%s/status' % os.getpid(), 'rb')
3698.1.1 by John Arbash Meinel
Move the memory debugging into a helper function.
434
    except IOError:
435
        return
436
    try:
437
        status = status_file.read()
438
    finally:
439
        status_file.close()
3698.1.2 by John Arbash Meinel
Make message optional, don't check the memory flag directly.
440
    if message:
441
        note(message)
3698.1.1 by John Arbash Meinel
Move the memory debugging into a helper function.
442
    for line in status.splitlines():
443
        if not short:
444
            note(line)
445
        else:
446
            for field in _short_fields:
447
                if line.startswith(field):
448
                    note(line)
449
                    break
450
7143.15.2 by Jelmer Vernooij
Run autopep8.
451
5448.5.2 by Karl Bielefeldt
Incorporated suggestions from code review:
452
def _dump_memory_usage(err_file):
5448.5.1 by Karl Bielefeldt
Use meliae to dump memory to a file upon MemoryError.
453
    try:
5448.5.4 by Karl Bielefeldt
Fix Python 2.4 incompatibilities
454
        try:
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
455
            fd, name = tempfile.mkstemp(prefix="brz_memdump", suffix=".json")
5448.5.4 by Karl Bielefeldt
Fix Python 2.4 incompatibilities
456
            dump_file = os.fdopen(fd, 'w')
457
            from meliae import scanner
458
            scanner.dump_gc_objects(dump_file)
459
            err_file.write("Memory dumped to %s\n" % name)
460
        except ImportError:
461
            err_file.write("Dumping memory requires meliae module.\n")
462
            log_exception_quietly()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
463
        except BaseException:
5448.5.4 by Karl Bielefeldt
Fix Python 2.4 incompatibilities
464
            err_file.write("Exception while dumping memory.\n")
465
            log_exception_quietly()
5448.5.2 by Karl Bielefeldt
Incorporated suggestions from code review:
466
    finally:
5448.5.4 by Karl Bielefeldt
Fix Python 2.4 incompatibilities
467
        if dump_file is not None:
468
            dump_file.close()
469
        elif fd is not None:
470
            os.close(fd)
3698.1.1 by John Arbash Meinel
Move the memory debugging into a helper function.
471
5677.3.1 by Martin
Add helper for getting qualified exception name to bzrlib.trace
472
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
473
def _qualified_exception_name(eclass, unqualified_breezy_errors=False):
5677.3.1 by Martin
Add helper for getting qualified exception name to bzrlib.trace
474
    """Give name of error class including module for non-builtin exceptions
475
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
476
    If `unqualified_breezy_errors` is True, errors specific to breezy will
5677.3.1 by Martin
Add helper for getting qualified exception name to bzrlib.trace
477
    also omit the module prefix.
478
    """
479
    class_name = eclass.__name__
480
    module_name = eclass.__module__
6677.1.5 by Martin
Make crash debug and trace modules pass on Python 3
481
    if module_name in ("builtins", "exceptions", "__main__") or (
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
482
            unqualified_breezy_errors and module_name == "breezy.errors"):
5677.3.1 by Martin
Add helper for getting qualified exception name to bzrlib.trace
483
        return class_name
484
    return "%s.%s" % (module_name, class_name)
485
486
1740.5.2 by Martin Pool
Improved tests for display of exceptions.
487
def report_exception(exc_info, err_file):
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
488
    """Report an exception to err_file (typically stderr) and to brz.log.
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
489
490
    This will show either a full traceback or a short message as appropriate.
491
492
    :return: The appropriate exit code for this error.
493
    """
7344.2.1 by Martin
Relocate the bzr log file out of $HOME
494
    # Log the full traceback to brz.log
4805.3.2 by Benoît Pierre
Always log the full traceback to ~/.bzr.log, even when -Derror is used.
495
    log_exception_quietly()
4805.3.1 by Benoît Pierre
Always honor 'error' debug flag.
496
    if 'error' in debug.debug_flags:
497
        print_exception(exc_info, err_file)
498
        return errors.EXIT_ERROR
1740.5.3 by Martin Pool
Cleanup more exception-formatting code
499
    exc_type, exc_object, exc_tb = exc_info
6336.2.1 by Martin Packman
Add is_environment_error() and switch trace to using it
500
    if isinstance(exc_object, KeyboardInterrupt):
6622.1.27 by Jelmer Vernooij
s/bzr/brz/
501
        err_file.write("brz: interrupted\n")
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
502
        return errors.EXIT_ERROR
4634.26.1 by Martin Pool
Cleaner message when out of memory
503
    elif isinstance(exc_object, MemoryError):
6622.1.27 by Jelmer Vernooij
s/bzr/brz/
504
        err_file.write("brz: out of memory\n")
5448.5.2 by Karl Bielefeldt
Incorporated suggestions from code review:
505
        if 'mem_dump' in debug.debug_flags:
506
            _dump_memory_usage(err_file)
507
        else:
508
            err_file.write("Use -Dmem_dump to dump memory to a file.\n")
4634.26.1 by Martin Pool
Cleaner message when out of memory
509
        return errors.EXIT_ERROR
3497.3.2 by Martin Pool
Show short error for missing libraries
510
    elif isinstance(exc_object, ImportError) \
7143.15.2 by Jelmer Vernooij
Run autopep8.
511
            and str(exc_object).startswith("No module named "):
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
512
        report_user_error(
513
            exc_info, err_file,
514
            'You may need to install this Python library separately.')
3497.3.2 by Martin Pool
Show short error for missing libraries
515
        return errors.EXIT_ERROR
2067.3.2 by Martin Pool
Error cleanup review comments:
516
    elif not getattr(exc_object, 'internal_error', True):
1740.5.6 by Martin Pool
Clean up many exception classes.
517
        report_user_error(exc_info, err_file)
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
518
        return errors.EXIT_ERROR
6336.2.1 by Martin Packman
Add is_environment_error() and switch trace to using it
519
    elif osutils.is_environment_error(exc_object):
520
        if getattr(exc_object, 'errno', None) == errno.EPIPE:
6622.1.27 by Jelmer Vernooij
s/bzr/brz/
521
            err_file.write("brz: broken pipe\n")
6336.2.1 by Martin Packman
Add is_environment_error() and switch trace to using it
522
            return errors.EXIT_ERROR
1740.5.6 by Martin Pool
Clean up many exception classes.
523
        # Might be nice to catch all of these and show them as something more
524
        # specific, but there are too many cases at the moment.
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
525
        report_user_error(exc_info, err_file)
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
526
        return errors.EXIT_ERROR
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
527
    else:
1551.9.3 by Aaron Bentley
Revert buggy apport changes
528
        report_bug(exc_info, err_file)
2713.2.1 by Martin Pool
Return exitcode 4 if an internal error occurs
529
        return errors.EXIT_INTERNAL_ERROR
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
530
531
3427.2.2 by James Westby
Just print the exception, keeping the API of log_exception_quietly the same.
532
def print_exception(exc_info, err_file):
533
    exc_type, exc_object, exc_tb = exc_info
6677.1.5 by Martin
Make crash debug and trace modules pass on Python 3
534
    err_file.write("brz: ERROR: %s: %s\n" % (
535
        _qualified_exception_name(exc_type), exc_object))
3427.2.2 by James Westby
Just print the exception, keeping the API of log_exception_quietly the same.
536
    err_file.write('\n')
537
    traceback.print_exception(exc_type, exc_object, exc_tb, file=err_file)
538
539
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
540
# TODO: Should these be specially encoding the output?
3497.3.2 by Martin Pool
Show short error for missing libraries
541
def report_user_error(exc_info, err_file, advice=None):
2095.5.1 by Martin Pool
Add new -Derror global option to always display tracebacks
542
    """Report to err_file an error that's not an internal error.
543
544
    These don't get a traceback unless -Derror was given.
3497.3.2 by Martin Pool
Show short error for missing libraries
545
546
    :param exc_info: 3-tuple from sys.exc_info()
547
    :param advice: Extra advice to the user to be printed following the
548
        exception.
2095.5.1 by Martin Pool
Add new -Derror global option to always display tracebacks
549
    """
6973.7.5 by Jelmer Vernooij
s/file/open.
550
    err_file.write(("brz: ERROR: %s\n" % (str(exc_info[1]),)))
3497.3.2 by Martin Pool
Show short error for missing libraries
551
    if advice:
6973.5.11 by Jelmer Vernooij
Fix tests under python2.
552
        err_file.write(("%s\n" % advice))
1740.5.1 by Martin Pool
When an unhandled exception occurs, write the traceback to stderr.
553
554
555
def report_bug(exc_info, err_file):
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
556
    """Report an exception that probably indicates a bug in brz"""
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
557
    from breezy.crash import report_bug
4584.3.6 by Martin Pool
Move apport integration to bzrlib.crash and send output to a file.
558
    report_bug(exc_info, err_file)
5017.1.1 by Martin Pool
Add bzrlib.initialize
559
560
561
def _flush_stdout_stderr():
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
562
    # called from the breezy library finalizer returned by breezy.initialize()
5017.1.1 by Martin Pool
Add bzrlib.initialize
563
    try:
564
        sys.stdout.flush()
565
        sys.stderr.flush()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
566
    except ValueError:
6133.4.62 by John Arbash Meinel
Add a nicer repr for shutting down.
567
        # On Windows, I get ValueError calling stdout.flush() on a closed
568
        # handle
569
        pass
6619.3.2 by Jelmer Vernooij
Apply 2to3 except fix.
570
    except IOError as e:
5017.1.1 by Martin Pool
Add bzrlib.initialize
571
        import errno
572
        if e.errno in [errno.EINVAL, errno.EPIPE]:
573
            pass
574
        else:
575
            raise
576
577
578
def _flush_trace():
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
579
    # called from the breezy library finalizer returned by breezy.initialize()
5017.1.1 by Martin Pool
Add bzrlib.initialize
580
    global _trace_file
581
    if _trace_file:
582
        _trace_file.flush()
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
583
584
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
585
class EncodedStreamHandler(logging.Handler):
586
    """Robustly write logging events to a stream using the specified encoding
587
588
    Messages are expected to be formatted to unicode, but UTF-8 byte strings
589
    are also accepted. An error during formatting or a str message in another
590
    encoding will be quitely noted as an error in the Bazaar log file.
591
592
    The stream is not closed so sys.stdout or sys.stderr may be passed.
593
    """
594
595
    def __init__(self, stream, encoding=None, errors='strict', level=0):
596
        logging.Handler.__init__(self, level)
597
        self.stream = stream
598
        if encoding is None:
599
            encoding = getattr(stream, "encoding", "ascii")
600
        self.encoding = encoding
601
        self.errors = errors
602
603
    def flush(self):
604
        flush = getattr(self.stream, "flush", None)
605
        if flush is not None:
606
            flush()
607
608
    def emit(self, record):
609
        try:
6677.1.5 by Martin
Make crash debug and trace modules pass on Python 3
610
            if not isinstance(record.msg, text_type):
611
                msg = record.msg.decode("utf-8")
612
                if PY3:
613
                    record.msg = msg
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
614
            line = self.format(record)
6621.2.26 by Martin
Misc set of changes to get started with selftest on Python 3
615
            if not isinstance(line, text_type):
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
616
                line = line.decode("utf-8")
6621.2.26 by Martin
Misc set of changes to get started with selftest on Python 3
617
            self.stream.write(line.encode(self.encoding, self.errors) + b"\n")
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
618
        except Exception:
619
            log_exception_quietly()
620
            # Try saving the details that would have been logged in some form
621
            msg = args = "<Unformattable>"
622
            try:
7008.2.1 by Martin
Make mutter saner with string interpolation
623
                msg = repr(record.msg)
624
                args = repr(record.args)
6015.52.2 by Martin Packman
Add EncodedStreamHandler as more robust logging class
625
            except Exception:
626
                pass
627
            # Using mutter() bypasses the logging module and writes directly
628
            # to the file so there's no danger of getting into a loop here.
629
            mutter("Logging record unformattable: %s %% %s", msg, args)
630
631
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
632
class Config(object):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
633
    """Configuration of message tracing in breezy.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
634
635
    This implements the context manager protocol and should manage any global
636
    variables still used. The default config used is DefaultConfig, but
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
637
    embedded uses of breezy may wish to use a custom manager.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
638
    """
639
640
    def __enter__(self):
7143.15.2 by Jelmer Vernooij
Run autopep8.
641
        return self  # This is bound to the 'as' clause in a with statement.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
642
643
    def __exit__(self, exc_type, exc_val, exc_tb):
7143.15.2 by Jelmer Vernooij
Run autopep8.
644
        return False  # propogate exceptions.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
645
646
647
class DefaultConfig(Config):
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
648
    """A default configuration for tracing of messages in breezy.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
649
650
    This implements the context manager protocol.
651
    """
652
653
    def __enter__(self):
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
654
        self._original_filename = _brz_log_filename
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
655
        self._original_state = enable_default_logging()
7143.15.2 by Jelmer Vernooij
Run autopep8.
656
        return self  # This is bound to the 'as' clause in a with statement.
5320.2.5 by Robert Collins
Make bzrlib startup use a trace context manager.
657
658
    def __exit__(self, exc_type, exc_val, exc_tb):
659
        pop_log_file(self._original_state)
6622.1.33 by Jelmer Vernooij
Fix more tests (all?)
660
        global _brz_log_filename
661
        _brz_log_filename = self._original_filename
7143.15.2 by Jelmer Vernooij
Run autopep8.
662
        return False  # propogate exceptions.