/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
57
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
58
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
59
from .branch import Branch
60
from .cleanup import OperationWithCleanups
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
61
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
62
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
63
                     ConflictsInTree,
64
                     StrictCommitFailed
65
                     )
66
from .osutils import (get_user_encoding,
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
67
                      has_symlinks,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      )
71
from .trace import mutter, note, is_quiet
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
72
from .tree import TreeChange
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
73
from .urlutils import unescape_for_display
74
from .i18n import gettext
75
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
6734.1.20 by Jelmer Vernooij
Move errors.
77
class PointlessCommit(BzrError):
78
79
    _fmt = "No changes to commit"
80
81
82
class CannotCommitSelectedFileMerge(BzrError):
83
84
    _fmt = 'Selected-file commit of merges is not supported yet:'\
85
        ' files %(files_str)s'
86
87
    def __init__(self, files):
88
        files_str = ', '.join(files)
89
        BzrError.__init__(self, files=files, files_str=files_str)
90
91
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
92
def filter_excluded(iter_changes, exclude):
93
    """Filter exclude filenames.
94
95
    :param iter_changes: iter_changes function
96
    :param exclude: List of paths to exclude
97
    :return: iter_changes function
98
    """
99
    for change in iter_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
100
        new_excluded = (change.path[1] is not None and
101
                        is_inside_any(exclude, change.path[1]))
102
103
        old_excluded = (change.path[0] is not None and
104
                        is_inside_any(exclude, change.path[0]))
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
105
106
        if old_excluded and new_excluded:
107
            continue
108
109
        if old_excluded or new_excluded:
110
            # TODO(jelmer): Perhaps raise an error here instead?
111
            continue
112
113
        yield change
114
115
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
class NullCommitReporter(object):
117
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
118
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
119
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
120
        pass
121
122
    def snapshot_change(self, change, path):
123
        pass
124
125
    def completed(self, revno, rev_id):
126
        pass
127
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
128
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
129
        pass
130
131
    def missing(self, path):
132
        pass
133
134
    def renamed(self, change, old_path, new_path):
135
        pass
136
2789.2.11 by Ian Clatworthy
remove more reporting stuff
137
    def is_verbose(self):
138
        return False
139
140
141
class ReportCommitToLog(NullCommitReporter):
142
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
143
    def _note(self, format, *args):
144
        """Output a message.
145
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
146
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
147
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
148
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
149
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
150
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
151
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
152
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
153
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
154
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
155
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
156
        self._note(
157
            gettext('Committing to: %s'),
158
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
159
160
    def completed(self, revno, rev_id):
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
161
        if revno is not None:
162
            self._note(gettext('Committed revision %d.'), revno)
163
            # self._note goes to the console too; so while we want to log the
164
            # rev_id, we can't trivially only log it. (See bug 526425). Long
165
            # term we should rearrange the reporting structure, but for now
166
            # we just mutter seperately. We mutter the revid and revno together
167
            # so that concurrent bzr invocations won't lead to confusion.
168
            mutter('Committed revid %s as revno %d.', rev_id, revno)
169
        else:
170
            self._note(gettext('Committed revid %s.'), rev_id)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
171
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
172
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
173
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
174
175
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
176
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
177
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
178
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
179
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
180
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
181
    def is_verbose(self):
182
        return True
183
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
184
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
class Commit(object):
186
    """Task of committing a new revision.
187
188
    This is a MethodObject: it accumulates state as the commit is
189
    prepared, and then it is discarded.  It doesn't represent
190
    historical revisions, just the act of recording a new one.
191
192
            missing_ids
193
            Modified to hold a list of files that have been deleted from
194
            the working directory; these should be removed from the
195
            working inventory.
485 by Martin Pool
- move commit code into its own module
196
    """
7143.15.2 by Jelmer Vernooij
Run autopep8.
197
1189 by Martin Pool
- BROKEN: partial support for commit into weave
198
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
199
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
200
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
201
        """Create a Commit object.
202
203
        :param reporter: the default reporter to use or None to decide later
204
        """
205
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
206
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
207
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
208
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
209
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
210
                        local=False, possible_master_transports=None):
211
        if revprops is None:
212
            revprops = {}
213
        if possible_master_transports is None:
214
            possible_master_transports = []
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
215
        if (u'branch-nick' not in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
216
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
217
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
218
                local,
219
                possible_master_transports)
220
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
221
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
222
                # XXX: maybe we should just accept one of them?
223
                raise AssertionError('author property given twice')
224
            if authors:
225
                for individual in authors:
226
                    if '\n' in individual:
227
                        raise AssertionError('\\n is not a valid character '
7143.15.2 by Jelmer Vernooij
Run autopep8.
228
                                             'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
229
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
230
        return revprops
231
1189 by Martin Pool
- BROKEN: partial support for commit into weave
232
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
233
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
               timestamp=None,
235
               timezone=None,
236
               committer=None,
237
               specific_files=None,
238
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
239
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
240
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
241
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
242
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
243
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
244
               local=False,
245
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
246
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
247
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
248
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
249
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
250
               possible_master_transports=None,
251
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
252
        """Commit working copy as a new revision.
253
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
        :param message: the commit message (it or message_callback is required)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
255
        :param message_callback: A callback: message =
256
            message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
257
258
        :param timestamp: if not None, seconds-since-epoch for a
259
            postdated/predated commit.
260
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
261
        :param specific_files: If not None, commit only those files. An empty
262
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
263
264
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
265
            Useful for test or import commands that need to tightly
266
            control what revisions are assigned.  If you duplicate
267
            a revision id that exists elsewhere it is your own fault.
268
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
269
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
270
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
271
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
272
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
273
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
274
            contains unknown files.
275
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
276
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
277
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
278
        :param reporter: the reporter to use or None for the default
279
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
280
        :param recursive: If set to 'down', commit in any subtrees that have
281
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
282
        :param exclude: None or a list of relative paths to exclude from the
283
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
284
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
285
        :param lossy: When committing to a foreign VCS, ignore any
286
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
287
        """
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
288
        operation = OperationWithCleanups(self._commit)
5086.6.1 by Robert Collins
Minor commit tidyup in preparation for hooking around revprops.
289
        self.revprops = revprops or {}
5141.1.1 by Robert Collins
``bzrlib.mutabletree.MutableTree.commit`` will now support a passed in
290
        # XXX: Can be set on __init__ or passed in - this is a bit ugly.
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
291
        self.config_stack = config or self.config_stack
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
292
        return operation.run(
7143.15.2 by Jelmer Vernooij
Run autopep8.
293
            message=message,
294
            timestamp=timestamp,
295
            timezone=timezone,
296
            committer=committer,
297
            specific_files=specific_files,
298
            rev_id=rev_id,
299
            allow_pointless=allow_pointless,
300
            strict=strict,
301
            verbose=verbose,
302
            working_tree=working_tree,
303
            local=local,
304
            reporter=reporter,
305
            message_callback=message_callback,
306
            recursive=recursive,
307
            exclude=exclude,
308
            possible_master_transports=possible_master_transports,
309
            lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
310
311
    def _commit(self, operation, message, timestamp, timezone, committer,
7143.15.2 by Jelmer Vernooij
Run autopep8.
312
                specific_files, rev_id, allow_pointless, strict, verbose,
313
                working_tree, local, reporter, message_callback, recursive,
314
                exclude, possible_master_transports, lossy):
1285 by Martin Pool
- fix bug in committing files that are renamed but not modified
315
        mutter('preparing to commit')
1189 by Martin Pool
- BROKEN: partial support for commit into weave
316
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
317
        if working_tree is None:
318
            raise BzrError("working_tree must be passed into commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
319
        else:
320
            self.work_tree = working_tree
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
321
            self.branch = self.work_tree.branch
2100.3.14 by Aaron Bentley
Test workingtree4 format, prevent use with old repos
322
            if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
323
                if not self.branch.repository.supports_rich_root():
324
                    raise errors.RootNotRich()
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
325
        if message_callback is None:
2149.1.3 by Aaron Bentley
Updates from review comments
326
            if message is not None:
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
327
                if isinstance(message, bytes):
3224.5.1 by Andrew Bennetts
Lots of assorted hackery to reduce the number of imports for common operations. Improves 'rocks', 'st' and 'help' times by ~50ms on my laptop.
328
                    message = message.decode(get_user_encoding())
7143.15.2 by Jelmer Vernooij
Run autopep8.
329
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
330
                def message_callback(x):
331
                    return message
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
332
            else:
2149.1.3 by Aaron Bentley
Updates from review comments
333
                raise BzrError("The message or message_callback keyword"
334
                               " parameter is required for commit().")
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
335
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
336
        self.bound_branch = None
2840.1.1 by Ian Clatworthy
faster pointless commit detection (Robert Collins)
337
        self.any_entries_deleted = False
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
338
        if exclude is not None:
339
            self.exclude = sorted(
340
                minimum_path_selection(exclude))
341
        else:
342
            self.exclude = []
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
343
        self.local = local
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
344
        self.master_branch = None
2776.4.15 by Robert Collins
Put checking for recursive commits back to the commit driver, not commit builder.
345
        self.recursive = recursive
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
346
        self.rev_id = None
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
347
        # self.specific_files is None to indicate no filter, or any iterable to
348
        # indicate a filter - [] means no files at all, as per iter_changes.
2843.1.1 by Ian Clatworthy
Faster partial commits by walking less data (Robert Collins)
349
        if specific_files is not None:
350
            self.specific_files = sorted(
351
                minimum_path_selection(specific_files))
352
        else:
353
            self.specific_files = None
5718.4.1 by Jelmer Vernooij
Add CommitBuilder.supports_record_entry_contents.
354
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
355
        self.allow_pointless = allow_pointless
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
356
        self.message_callback = message_callback
357
        self.timestamp = timestamp
358
        self.timezone = timezone
359
        self.committer = committer
360
        self.strict = strict
361
        self.verbose = verbose
1189 by Martin Pool
- BROKEN: partial support for commit into weave
362
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
363
        self.work_tree.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
364
        operation.add_cleanup(self.work_tree.unlock)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
365
        self.parents = self.work_tree.get_parent_ids()
5582.10.6 by Jelmer Vernooij
Fix ui imports.
366
        self.pb = ui.ui_factory.nested_progress_bar()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
367
        operation.add_cleanup(self.pb.finished)
2921.4.1 by Robert Collins
During commit check for the first commit by NULL_REVISION rather than a completely empty basis tree, removing one use of the basis inventory.
368
        self.basis_revid = self.work_tree.last_revision()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
369
        self.basis_tree = self.work_tree.basis_tree()
2255.2.25 by John Arbash Meinel
DirstateRevisionTrees need to be read_locked before they will work as BasisTree
370
        self.basis_tree.lock_read()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
371
        operation.add_cleanup(self.basis_tree.unlock)
372
        # Cannot commit with conflicts present.
373
        if len(self.work_tree.conflicts()) > 0:
374
            raise ConflictsInTree
375
376
        # Setup the bound branch variables as needed.
377
        self._check_bound_branch(operation, possible_master_transports)
378
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
379
        if self.config_stack is None:
380
            self.config_stack = self.work_tree.get_config_stack()
381
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
382
        # Check that the working tree is up to date
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
383
        old_revno, old_revid, new_revno = self._check_out_of_date_tree()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
384
385
        # Complete configuration setup
386
        if reporter is not None:
387
            self.reporter = reporter
388
        elif self.reporter is None:
389
            self.reporter = self._select_reporter()
390
391
        # Setup the progress bar. As the number of files that need to be
392
        # committed in unknown, progress is reported as stages.
393
        # We keep track of entries separately though and include that
394
        # information in the progress bar during the relevant stages.
395
        self.pb_stage_name = ""
396
        self.pb_stage_count = 0
397
        self.pb_stage_total = 5
398
        if self.bound_branch:
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
399
            # 2 extra stages: "Uploading data to master branch" and "Merging
400
            # tags to master branch"
401
            self.pb_stage_total += 2
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
402
        self.pb.show_pct = False
403
        self.pb.show_spinner = False
404
        self.pb.show_eta = False
405
        self.pb.show_count = True
406
        self.pb.show_bar = True
407
408
        # After a merge, a selected file commit is not supported.
409
        # See 'bzr help merge' for an explanation as to why.
410
        if len(self.parents) > 1 and self.specific_files is not None:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
411
            raise CannotCommitSelectedFileMerge(self.specific_files)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
412
        # Excludes are a form of selected file commit.
413
        if len(self.parents) > 1 and self.exclude:
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
414
            raise CannotCommitSelectedFileMerge(self.exclude)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
415
416
        # Collect the changes
417
        self._set_progress_stage("Collecting changes", counter=True)
5777.6.5 by Jelmer Vernooij
Add tests for lossy commit.
418
        self._lossy = lossy
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
419
        self.builder = self.branch.get_commit_builder(
420
            self.parents, self.config_stack, timestamp, timezone, committer,
421
            self.revprops, rev_id, lossy=lossy)
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
422
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
423
        if self.builder.updates_branch and self.bound_branch:
424
            self.builder.abort()
425
            raise AssertionError(
426
                "bound branches not supported for commit builders "
427
                "that update the branch")
428
1189 by Martin Pool
- BROKEN: partial support for commit into weave
429
        try:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
430
            # find the location being committed to
431
            if self.bound_branch:
432
                master_location = self.master_branch.base
433
            else:
434
                master_location = self.branch.base
435
436
            # report the start of the commit
437
            self.reporter.started(new_revno, self.rev_id, master_location)
438
439
            self._update_builder_with_changes()
440
            self._check_pointless()
441
442
            # TODO: Now the new inventory is known, check for conflicts.
443
            # ADHB 2006-08-08: If this is done, populate_new_inv should not add
444
            # weave lines, because nothing should be recorded until it is known
445
            # that commit will succeed.
446
            self._set_progress_stage("Saving data locally")
447
            self.builder.finish_inventory()
448
449
            # Prompt the user for a commit message if none provided
450
            message = message_callback(self)
451
            self.message = message
452
453
            # Add revision data to the local branch
454
            self.rev_id = self.builder.commit(self.message)
455
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
456
        except Exception:
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
457
            mutter("aborting commit write group because of exception:")
458
            trace.log_exception_quietly()
459
            self.builder.abort()
460
            raise
461
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
462
        self._update_branches(old_revno, old_revid, new_revno)
463
464
        # Make the working tree be up to date with the branch. This
465
        # includes automatic changes scheduled to be made to the tree, such
466
        # as updating its basis and unversioning paths that were missing.
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
467
        self.work_tree.unversion(self.deleted_paths)
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
468
        self._set_progress_stage("Updating the working tree")
469
        self.work_tree.update_basis_by_delta(self.rev_id,
7143.15.2 by Jelmer Vernooij
Run autopep8.
470
                                             self.builder.get_basis_delta())
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
471
        self.reporter.completed(new_revno, self.rev_id)
472
        self._process_post_hooks(old_revno, new_revno)
473
        return self.rev_id
474
475
    def _update_branches(self, old_revno, old_revid, new_revno):
476
        """Update the master and local branch to the new revision.
477
478
        This will try to make sure that the master branch is updated
479
        before the local branch.
480
481
        :param old_revno: Revision number of master branch before the
482
            commit
483
        :param old_revid: Tip of master branch before the commit
484
        :param new_revno: Revision number of the new commit
485
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
486
        if not self.builder.updates_branch:
487
            self._process_pre_hooks(old_revno, new_revno)
488
489
            # Upload revision data to the master.
490
            # this will propagate merged revisions too if needed.
491
            if self.bound_branch:
492
                self._set_progress_stage("Uploading data to master branch")
493
                # 'commit' to the master first so a timeout here causes the
494
                # local branch to be out of date
495
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
496
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
497
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
498
                    self.branch.fetch(self.master_branch, self.rev_id)
499
500
            # and now do the commit locally.
7339.1.9 by Jelmer Vernooij
Fix ghost handling during commit.
501
            if new_revno is None:
502
                # Keep existing behaviour around ghosts
503
                new_revno = 1
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
504
            self.branch.set_last_revision_info(new_revno, self.rev_id)
505
        else:
506
            try:
507
                self._process_pre_hooks(old_revno, new_revno)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
508
            except BaseException:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
509
                # The commit builder will already have updated the branch,
510
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
511
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
512
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
513
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
514
        # Merge local tags to remote
515
        if self.bound_branch:
516
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
517
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
518
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
519
            if tag_conflicts:
520
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
7143.15.2 by Jelmer Vernooij
Run autopep8.
521
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
522
                    "\n".join(warning_lines))))
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
523
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
524
    def _select_reporter(self):
525
        """Select the CommitReporter to use."""
526
        if is_quiet():
527
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
528
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
529
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
530
    def _check_pointless(self):
531
        if self.allow_pointless:
532
            return
533
        # A merge with no effect on files
534
        if len(self.parents) > 1:
535
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
536
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
537
            return
538
        raise PointlessCommit()
539
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
540
    def _check_bound_branch(self, operation, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
541
        """Check to see if the local branch is bound.
542
543
        If it is bound, then most of the commit will actually be
544
        done using the remote branch as the target branch.
545
        Only at the end will the local branch be updated.
546
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
547
        if self.local and not self.branch.get_bound_location():
548
            raise errors.LocalRequiresBoundBranch()
549
550
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
551
            self.master_branch = self.branch.get_master_branch(
552
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
553
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
554
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
555
            # make this branch the reference branch for out of date checks.
556
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
557
            return
558
559
        # If the master branch is bound, we must fail
560
        master_bound_location = self.master_branch.get_bound_location()
561
        if master_bound_location:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
562
            raise errors.CommitToDoubleBoundBranch(
563
                self.branch, self.master_branch, master_bound_location)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
564
565
        # TODO: jam 20051230 We could automatically push local
566
        #       commits to the remote branch if they would fit.
567
        #       But for now, just require remote to be identical
568
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
569
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
570
        # Make sure the local branch is identical to the master
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
571
        master_revid = self.master_branch.last_revision()
572
        local_revid = self.branch.last_revision()
573
        if local_revid != master_revid:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
574
            raise errors.BoundBranchOutOfDate(self.branch,
7143.15.2 by Jelmer Vernooij
Run autopep8.
575
                                              self.master_branch)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
576
577
        # Now things are ready to change the master branch
578
        # so grab the lock
579
        self.bound_branch = self.branch
580
        self.master_branch.lock_write()
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
581
        operation.add_cleanup(self.master_branch.unlock)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
582
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
583
    def _check_out_of_date_tree(self):
584
        """Check that the working tree is up to date.
585
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
586
        :return: old_revision_number, old_revision_id, new_revision_number
587
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
588
        """
589
        try:
590
            first_tree_parent = self.work_tree.get_parent_ids()[0]
591
        except IndexError:
592
            # if there are no parents, treat our parent as 'None'
593
            # this is so that we still consider the master branch
594
            # - in a checkout scenario the tree may have no
595
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
596
            first_tree_parent = breezy.revision.NULL_REVISION
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
597
        if (self.master_branch._format.stores_revno() or
598
                self.config_stack.get('calculate_revnos')):
599
            try:
600
                old_revno, master_last = self.master_branch.last_revision_info()
601
            except errors.UnsupportedOperation:
602
                master_last = self.master_branch.last_revision()
603
                old_revno = self.branch.revision_id_to_revno(master_last)
604
        else:
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
605
            master_last = self.master_branch.last_revision()
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
606
            old_revno = None
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
607
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
608
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
609
                raise errors.OutOfDateTree(self.work_tree)
7339.1.5 by Jelmer Vernooij
Change order for efficiency reasons.
610
        if (old_revno is not None and
611
                self.branch.repository.has_revision(first_tree_parent)):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
612
            new_revno = old_revno + 1
613
        else:
614
            # ghost parents never appear in revision history.
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
615
            new_revno = None
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
616
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
617
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
618
    def _process_pre_hooks(self, old_revno, new_revno):
619
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
620
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
621
        self._process_hooks("pre_commit", old_revno, new_revno)
622
623
    def _process_post_hooks(self, old_revno, new_revno):
624
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
625
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
626
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
627
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
628
        # 0.15^H^H^H^H 2.5.0)
629
        post_commit = self.config_stack.get('post_commit')
630
        if post_commit is not None:
631
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
632
            # this would be nicer with twisted.python.reflect.namedAny
633
            for hook in hooks:
634
                result = eval(hook + '(branch, rev_id)',
7143.15.2 by Jelmer Vernooij
Run autopep8.
635
                              {'branch': self.branch,
636
                               'breezy': breezy,
637
                               'rev_id': self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
638
        # process new style post commit hooks
639
        self._process_hooks("post_commit", old_revno, new_revno)
640
641
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
642
        if not Branch.hooks[hook_name]:
643
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
644
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
645
        # new style commit hooks:
646
        if not self.bound_branch:
647
            hook_master = self.branch
648
            hook_local = None
649
        else:
650
            hook_master = self.master_branch
651
            hook_local = self.branch
652
        # With bound branches, when the master is behind the local branch,
653
        # the 'old_revno' and old_revid values here are incorrect.
654
        # XXX: FIXME ^. RBC 20060206
655
        if self.parents:
656
            old_revid = self.parents[0]
657
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
658
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
659
2659.3.9 by NamNguyen
branch.py:
660
        if hook_name == "pre_commit":
661
            future_tree = self.builder.revision_tree()
662
            tree_delta = future_tree.changes_from(self.basis_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
663
                                                  include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
664
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
665
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
666
            # show the running hook in the progress bar. As hooks may
667
            # end up doing nothing (e.g. because they are not configured by
668
            # the user) this is still showing progress, not showing overall
669
            # actions - its up to each plugin to show a UI if it want's to
670
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
671
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
672
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
673
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
674
            if 'hooks' in debug.debug_flags:
675
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
676
            if hook_name == "post_commit":
677
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
678
                     self.rev_id)
679
            elif hook_name == "pre_commit":
680
                hook(hook_local, hook_master,
681
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
682
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
683
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
684
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
685
        """Update the commit builder with the data about what has changed.
686
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
687
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
688
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
689
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
690
        self._check_strict()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
691
        iter_changes = self.work_tree.iter_changes(
692
            self.basis_tree, specific_files=specific_files)
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
693
        if self.exclude:
694
            iter_changes = filter_excluded(iter_changes, self.exclude)
695
        iter_changes = self._filter_iter_changes(iter_changes)
7206.6.1 by Jelmer Vernooij
Drop file_id from record_iter_changes return value.
696
        for path, fs_hash in self.builder.record_iter_changes(
7143.16.21 by Jelmer Vernooij
Fix regressions.
697
                self.work_tree, self.basis_revid, iter_changes):
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
698
            self.work_tree._observed_sha1(path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
699
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
700
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
701
        """Process iter_changes.
702
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
703
        This method reports on the changes in iter_changes to the user, and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
704
        converts 'missing' entries in the iter_changes iterator to 'deleted'
705
        entries. 'missing' entries have their
706
707
        :param iter_changes: An iter_changes to process.
708
        :return: A generator of changes.
709
        """
710
        reporter = self.reporter
711
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
712
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
713
        for change in iter_changes:
714
            if report_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
715
                old_path = change.path[0]
716
                new_path = change.path[1]
717
                versioned = change.versioned[1]
718
            kind = change.kind[1]
719
            versioned = change.versioned[1]
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
720
            if kind is None and versioned:
721
                # 'missing' path
722
                if report_changes:
723
                    reporter.missing(new_path)
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
724
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
725
                    trace.warning('Ignoring "%s" as symlinks are not '
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
726
                                  'supported on this filesystem.' % (change.path[0],))
6469.1.4 by Parth Malwankar
commit ignores symlinks on platforms that dont support symlinks
727
                    continue
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
728
                deleted_paths.append(change[1][1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
729
                # Reset the new path (None) and new versioned flag (False)
7322.1.7 by Jelmer Vernooij
Fix remaining tests.
730
                change = change.discard_new()
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
731
                new_path = change.path[1]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
732
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
733
            elif kind == 'tree-reference':
734
                if self.recursive == 'down':
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
735
                    self._commit_nested_tree(change[1][1])
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
736
            if change.versioned[0] or change.versioned[1]:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
737
                yield change
738
                if report_changes:
739
                    if new_path is None:
740
                        reporter.deleted(old_path)
741
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
742
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
743
                    elif old_path != new_path:
7143.15.2 by Jelmer Vernooij
Run autopep8.
744
                        reporter.renamed(gettext('renamed'),
745
                                         old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
746
                    else:
7143.15.2 by Jelmer Vernooij
Run autopep8.
747
                        if (new_path
748
                                or self.work_tree.branch.repository._format.rich_root_data):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
749
                            # Don't report on changes to '' in non rich root
750
                            # repositories.
7143.15.2 by Jelmer Vernooij
Run autopep8.
751
                            reporter.snapshot_change(
752
                                gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
753
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
754
        # Unversion files that were found to be deleted
755
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
756
757
    def _check_strict(self):
758
        # XXX: when we use iter_changes this would likely be faster if
759
        # iter_changes would check for us (even in the presence of
760
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
761
        if self.strict:
762
            # raise an exception as soon as we find a single unknown.
763
            for unknown in self.work_tree.unknowns():
764
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
765
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
766
    def _commit_nested_tree(self, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
767
        "Commit a nested tree."
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
768
        sub_tree = self.work_tree.get_nested_tree(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
769
        # FIXME: be more comprehensive here:
770
        # this works when both trees are in --trees repository,
771
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
772
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
773
        # finally implement the explicit-caches approach design
774
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
775
        if sub_tree.branch.repository.has_same_location(
7143.15.2 by Jelmer Vernooij
Run autopep8.
776
                self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
777
            sub_tree.branch.repository = \
778
                self.work_tree.branch.repository
779
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
780
            return sub_tree.commit(message=None, revprops=self.revprops,
7143.15.2 by Jelmer Vernooij
Run autopep8.
781
                                   recursive=self.recursive,
782
                                   message_callback=self.message_callback,
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
783
                                   timestamp=self.timestamp,
784
                                   timezone=self.timezone,
7143.15.2 by Jelmer Vernooij
Run autopep8.
785
                                   committer=self.committer,
786
                                   allow_pointless=self.allow_pointless,
787
                                   strict=self.strict, verbose=self.verbose,
788
                                   local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
789
        except PointlessCommit:
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
790
            return self.work_tree.get_reference_revision(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
791
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
792
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
793
        """Set the progress stage and emit an update to the progress bar."""
794
        self.pb_stage_name = name
795
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
796
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
797
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
798
        else:
799
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
800
        self._emit_progress()
801
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
802
    def _next_progress_entry(self):
803
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
804
        self.pb_entries_count += 1
805
        self._emit_progress()
806
807
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
808
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
809
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
7143.15.2 by Jelmer Vernooij
Run autopep8.
810
                                                       self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
811
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
812
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
813
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)