/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
6379.6.1 by Jelmer Vernooij
Import absolute_import in a few places.
17
from __future__ import absolute_import
485 by Martin Pool
- move commit code into its own module
18
2921.4.6 by Robert Collins
Typos found by Rob Weir.
19
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
20
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
21
# working tree and that were in the predecessor are reported as
22
# removed --- this can include files that were either removed from the
23
# inventory or deleted in the working tree.  If they were only
24
# deleted from disk, they are removed from the working inventory.
25
26
# We then consider the remaining entries, which will be in the new
27
# version.  Directory entries are simply copied across.  File entries
28
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
29
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
30
# version of the file was present.  If the file was present in at
31
# least one tree, and if it was the same version in all the trees,
32
# then we can just refer to that version.  Otherwise, a new version
33
# representing the merger of the file versions must be added.
34
35
# TODO: Update hashcache before and after - or does the WorkingTree
36
# look after that?
1245 by Martin Pool
doc
37
1339 by Martin Pool
- doc
38
# TODO: Rather than mashing together the ancestry and storing it back,
39
# perhaps the weave should have single method which does it all in one
40
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
41
1341 by Martin Pool
- doc
42
# TODO: Perhaps give a warning if one of the revisions marked as
43
# merged is already in the ancestry, and then don't record it as a
44
# distinct parent.
45
1343 by Martin Pool
- fix up test for merge of trees
46
# TODO: If the file is newly merged but unchanged from the version it
47
# merges from, then it should still be reported as newly added
48
# relative to the basis revision.
49
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
50
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
51
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
52
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
53
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
54
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
55
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
56
    trace,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
57
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
58
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
59
from .branch import Branch
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
60
from .cleanup import ExitStack
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
61
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
62
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
63
                     ConflictsInTree,
64
                     StrictCommitFailed
65
                     )
66
from .osutils import (get_user_encoding,
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
67
                      has_symlinks,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
68
                      is_inside_any,
69
                      minimum_path_selection,
70
                      )
71
from .trace import mutter, note, is_quiet
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
72
from .tree import TreeChange
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
73
from .urlutils import unescape_for_display
74
from .i18n import gettext
75
1189 by Martin Pool
- BROKEN: partial support for commit into weave
76
6734.1.20 by Jelmer Vernooij
Move errors.
77
class PointlessCommit(BzrError):
78
79
    _fmt = "No changes to commit"
80
81
82
class CannotCommitSelectedFileMerge(BzrError):
83
84
    _fmt = 'Selected-file commit of merges is not supported yet:'\
85
        ' files %(files_str)s'
86
87
    def __init__(self, files):
88
        files_str = ', '.join(files)
89
        BzrError.__init__(self, files=files, files_str=files_str)
90
91
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
92
def filter_excluded(iter_changes, exclude):
93
    """Filter exclude filenames.
94
95
    :param iter_changes: iter_changes function
96
    :param exclude: List of paths to exclude
97
    :return: iter_changes function
98
    """
99
    for change in iter_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
100
        new_excluded = (change.path[1] is not None and
101
                        is_inside_any(exclude, change.path[1]))
102
103
        old_excluded = (change.path[0] is not None and
104
                        is_inside_any(exclude, change.path[0]))
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
105
106
        if old_excluded and new_excluded:
107
            continue
108
109
        if old_excluded or new_excluded:
110
            # TODO(jelmer): Perhaps raise an error here instead?
111
            continue
112
113
        yield change
114
115
1189 by Martin Pool
- BROKEN: partial support for commit into weave
116
class NullCommitReporter(object):
117
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
118
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
119
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
120
        pass
121
122
    def snapshot_change(self, change, path):
123
        pass
124
125
    def completed(self, revno, rev_id):
126
        pass
127
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
128
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
129
        pass
130
131
    def missing(self, path):
132
        pass
133
134
    def renamed(self, change, old_path, new_path):
135
        pass
136
2789.2.11 by Ian Clatworthy
remove more reporting stuff
137
    def is_verbose(self):
138
        return False
139
140
141
class ReportCommitToLog(NullCommitReporter):
142
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
143
    def _note(self, format, *args):
144
        """Output a message.
145
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
146
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
147
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
148
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
149
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
150
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
151
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
152
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
153
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
154
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
155
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
156
        self._note(
157
            gettext('Committing to: %s'),
158
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
159
160
    def completed(self, revno, rev_id):
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
161
        if revno is not None:
162
            self._note(gettext('Committed revision %d.'), revno)
163
            # self._note goes to the console too; so while we want to log the
164
            # rev_id, we can't trivially only log it. (See bug 526425). Long
165
            # term we should rearrange the reporting structure, but for now
166
            # we just mutter seperately. We mutter the revid and revno together
167
            # so that concurrent bzr invocations won't lead to confusion.
168
            mutter('Committed revid %s as revno %d.', rev_id, revno)
169
        else:
170
            self._note(gettext('Committed revid %s.'), rev_id)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
171
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
172
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
173
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
174
175
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
176
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
177
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
178
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
179
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
180
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
181
    def is_verbose(self):
182
        return True
183
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
184
1189 by Martin Pool
- BROKEN: partial support for commit into weave
185
class Commit(object):
186
    """Task of committing a new revision.
187
188
    This is a MethodObject: it accumulates state as the commit is
189
    prepared, and then it is discarded.  It doesn't represent
190
    historical revisions, just the act of recording a new one.
191
192
            missing_ids
193
            Modified to hold a list of files that have been deleted from
194
            the working directory; these should be removed from the
195
            working inventory.
485 by Martin Pool
- move commit code into its own module
196
    """
7143.15.2 by Jelmer Vernooij
Run autopep8.
197
1189 by Martin Pool
- BROKEN: partial support for commit into weave
198
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
199
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
200
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
201
        """Create a Commit object.
202
203
        :param reporter: the default reporter to use or None to decide later
204
        """
205
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
206
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
207
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
208
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
209
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
210
                        local=False, possible_master_transports=None):
211
        if revprops is None:
212
            revprops = {}
213
        if possible_master_transports is None:
214
            possible_master_transports = []
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
215
        if (u'branch-nick' not in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
216
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
217
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
218
                local,
219
                possible_master_transports)
220
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
221
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
222
                # XXX: maybe we should just accept one of them?
223
                raise AssertionError('author property given twice')
224
            if authors:
225
                for individual in authors:
226
                    if '\n' in individual:
227
                        raise AssertionError('\\n is not a valid character '
7143.15.2 by Jelmer Vernooij
Run autopep8.
228
                                             'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
229
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
230
        return revprops
231
1189 by Martin Pool
- BROKEN: partial support for commit into weave
232
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
233
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
234
               timestamp=None,
235
               timezone=None,
236
               committer=None,
237
               specific_files=None,
238
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
239
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
240
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
241
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
242
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
243
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
244
               local=False,
245
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
246
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
247
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
248
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
249
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
250
               possible_master_transports=None,
251
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
252
        """Commit working copy as a new revision.
253
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
        :param message: the commit message (it or message_callback is required)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
255
        :param message_callback: A callback: message =
256
            message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
257
258
        :param timestamp: if not None, seconds-since-epoch for a
259
            postdated/predated commit.
260
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
261
        :param specific_files: If not None, commit only those files. An empty
262
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
263
264
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
265
            Useful for test or import commands that need to tightly
266
            control what revisions are assigned.  If you duplicate
267
            a revision id that exists elsewhere it is your own fault.
268
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
269
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
270
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
271
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
272
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
273
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
274
            contains unknown files.
275
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
276
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
277
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
278
        :param reporter: the reporter to use or None for the default
279
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
280
        :param recursive: If set to 'down', commit in any subtrees that have
281
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
282
        :param exclude: None or a list of relative paths to exclude from the
283
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
284
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
285
        :param lossy: When committing to a foreign VCS, ignore any
286
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
287
        """
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
288
        with ExitStack() as stack:
289
            self.revprops = revprops or {}
290
            # XXX: Can be set on __init__ or passed in - this is a bit ugly.
291
            self.config_stack = config or self.config_stack
292
            mutter('preparing to commit')
293
294
            if working_tree is None:
295
                raise BzrError("working_tree must be passed into commit().")
296
            else:
297
                self.work_tree = working_tree
298
                self.branch = self.work_tree.branch
299
                if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
300
                    if not self.branch.repository.supports_rich_root():
301
                        raise errors.RootNotRich()
302
            if message_callback is None:
303
                if message is not None:
304
                    if isinstance(message, bytes):
305
                        message = message.decode(get_user_encoding())
306
307
                    def message_callback(x):
308
                        return message
309
                else:
310
                    raise BzrError("The message or message_callback keyword"
311
                                   " parameter is required for commit().")
312
313
            self.bound_branch = None
314
            self.any_entries_deleted = False
315
            if exclude is not None:
316
                self.exclude = sorted(
317
                    minimum_path_selection(exclude))
318
            else:
319
                self.exclude = []
320
            self.local = local
321
            self.master_branch = None
322
            self.recursive = recursive
323
            self.rev_id = None
324
            # self.specific_files is None to indicate no filter, or any iterable to
325
            # indicate a filter - [] means no files at all, as per iter_changes.
326
            if specific_files is not None:
327
                self.specific_files = sorted(
328
                    minimum_path_selection(specific_files))
329
            else:
330
                self.specific_files = None
331
332
            self.allow_pointless = allow_pointless
333
            self.message_callback = message_callback
334
            self.timestamp = timestamp
335
            self.timezone = timezone
336
            self.committer = committer
337
            self.strict = strict
338
            self.verbose = verbose
339
340
            stack.enter_context(self.work_tree.lock_write())
341
            self.parents = self.work_tree.get_parent_ids()
342
            self.pb = ui.ui_factory.nested_progress_bar()
343
            stack.callback(self.pb.finished)
344
            self.basis_revid = self.work_tree.last_revision()
345
            self.basis_tree = self.work_tree.basis_tree()
346
            stack.enter_context(self.basis_tree.lock_read())
347
            # Cannot commit with conflicts present.
348
            if len(self.work_tree.conflicts()) > 0:
349
                raise ConflictsInTree
350
351
            # Setup the bound branch variables as needed.
352
            self._check_bound_branch(stack, possible_master_transports)
7356.1.7 by Jelmer Vernooij
merge trunk.
353
            if self.config_stack is None:
354
                self.config_stack = self.work_tree.get_config_stack()
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
355
356
            # Check that the working tree is up to date
357
            old_revno, old_revid, new_revno = self._check_out_of_date_tree()
358
359
            # Complete configuration setup
360
            if reporter is not None:
361
                self.reporter = reporter
362
            elif self.reporter is None:
363
                self.reporter = self._select_reporter()
364
365
            # Setup the progress bar. As the number of files that need to be
366
            # committed in unknown, progress is reported as stages.
367
            # We keep track of entries separately though and include that
368
            # information in the progress bar during the relevant stages.
369
            self.pb_stage_name = ""
370
            self.pb_stage_count = 0
371
            self.pb_stage_total = 5
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
372
            if self.bound_branch:
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
373
                # 2 extra stages: "Uploading data to master branch" and "Merging
374
                # tags to master branch"
375
                self.pb_stage_total += 2
376
            self.pb.show_pct = False
377
            self.pb.show_spinner = False
378
            self.pb.show_eta = False
379
            self.pb.show_count = True
380
            self.pb.show_bar = True
381
382
            # After a merge, a selected file commit is not supported.
383
            # See 'bzr help merge' for an explanation as to why.
384
            if len(self.parents) > 1 and self.specific_files is not None:
385
                raise CannotCommitSelectedFileMerge(self.specific_files)
386
            # Excludes are a form of selected file commit.
387
            if len(self.parents) > 1 and self.exclude:
388
                raise CannotCommitSelectedFileMerge(self.exclude)
389
390
            # Collect the changes
391
            self._set_progress_stage("Collecting changes", counter=True)
392
            self._lossy = lossy
393
            self.builder = self.branch.get_commit_builder(
394
                self.parents, self.config_stack, timestamp, timezone, committer,
395
                self.revprops, rev_id, lossy=lossy)
396
397
            if self.builder.updates_branch and self.bound_branch:
398
                self.builder.abort()
399
                raise AssertionError(
400
                    "bound branches not supported for commit builders "
401
                    "that update the branch")
402
403
            try:
404
                # find the location being committed to
405
                if self.bound_branch:
406
                    master_location = self.master_branch.base
407
                else:
408
                    master_location = self.branch.base
409
410
                # report the start of the commit
411
                self.reporter.started(new_revno, self.rev_id, master_location)
412
413
                self._update_builder_with_changes()
414
                self._check_pointless()
415
416
                # TODO: Now the new inventory is known, check for conflicts.
417
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
418
                # weave lines, because nothing should be recorded until it is known
419
                # that commit will succeed.
420
                self._set_progress_stage("Saving data locally")
421
                self.builder.finish_inventory()
422
423
                # Prompt the user for a commit message if none provided
424
                message = message_callback(self)
425
                self.message = message
426
427
                # Add revision data to the local branch
428
                self.rev_id = self.builder.commit(self.message)
429
430
            except Exception:
431
                mutter("aborting commit write group because of exception:")
432
                trace.log_exception_quietly()
433
                self.builder.abort()
434
                raise
435
436
            self._update_branches(old_revno, old_revid, new_revno)
437
438
            # Make the working tree be up to date with the branch. This
439
            # includes automatic changes scheduled to be made to the tree, such
440
            # as updating its basis and unversioning paths that were missing.
441
            self.work_tree.unversion(self.deleted_paths)
442
            self._set_progress_stage("Updating the working tree")
443
            self.work_tree.update_basis_by_delta(self.rev_id,
444
                                                 self.builder.get_basis_delta())
445
            self.reporter.completed(new_revno, self.rev_id)
446
            self._process_post_hooks(old_revno, new_revno)
447
            return self.rev_id
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
448
449
    def _update_branches(self, old_revno, old_revid, new_revno):
450
        """Update the master and local branch to the new revision.
451
452
        This will try to make sure that the master branch is updated
453
        before the local branch.
454
455
        :param old_revno: Revision number of master branch before the
456
            commit
457
        :param old_revid: Tip of master branch before the commit
458
        :param new_revno: Revision number of the new commit
459
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
460
        if not self.builder.updates_branch:
461
            self._process_pre_hooks(old_revno, new_revno)
462
463
            # Upload revision data to the master.
464
            # this will propagate merged revisions too if needed.
465
            if self.bound_branch:
466
                self._set_progress_stage("Uploading data to master branch")
467
                # 'commit' to the master first so a timeout here causes the
468
                # local branch to be out of date
469
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
470
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
471
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
472
                    self.branch.fetch(self.master_branch, self.rev_id)
473
474
            # and now do the commit locally.
7339.1.9 by Jelmer Vernooij
Fix ghost handling during commit.
475
            if new_revno is None:
476
                # Keep existing behaviour around ghosts
477
                new_revno = 1
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
478
            self.branch.set_last_revision_info(new_revno, self.rev_id)
479
        else:
480
            try:
481
                self._process_pre_hooks(old_revno, new_revno)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
482
            except BaseException:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
483
                # The commit builder will already have updated the branch,
484
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
485
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
486
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
487
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
488
        # Merge local tags to remote
489
        if self.bound_branch:
490
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
491
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
492
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
493
            if tag_conflicts:
494
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
7143.15.2 by Jelmer Vernooij
Run autopep8.
495
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
496
                    "\n".join(warning_lines))))
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
497
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
498
    def _select_reporter(self):
499
        """Select the CommitReporter to use."""
500
        if is_quiet():
501
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
502
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
503
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
504
    def _check_pointless(self):
505
        if self.allow_pointless:
506
            return
507
        # A merge with no effect on files
508
        if len(self.parents) > 1:
509
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
510
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
511
            return
512
        raise PointlessCommit()
513
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
514
    def _check_bound_branch(self, stack, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
515
        """Check to see if the local branch is bound.
516
517
        If it is bound, then most of the commit will actually be
518
        done using the remote branch as the target branch.
519
        Only at the end will the local branch be updated.
520
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
521
        if self.local and not self.branch.get_bound_location():
522
            raise errors.LocalRequiresBoundBranch()
523
524
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
525
            self.master_branch = self.branch.get_master_branch(
526
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
527
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
528
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
529
            # make this branch the reference branch for out of date checks.
530
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
531
            return
532
533
        # If the master branch is bound, we must fail
534
        master_bound_location = self.master_branch.get_bound_location()
535
        if master_bound_location:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
536
            raise errors.CommitToDoubleBoundBranch(
537
                self.branch, self.master_branch, master_bound_location)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
538
539
        # TODO: jam 20051230 We could automatically push local
540
        #       commits to the remote branch if they would fit.
541
        #       But for now, just require remote to be identical
542
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
543
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
544
        # Make sure the local branch is identical to the master
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
545
        master_revid = self.master_branch.last_revision()
546
        local_revid = self.branch.last_revision()
547
        if local_revid != master_revid:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
548
            raise errors.BoundBranchOutOfDate(self.branch,
7143.15.2 by Jelmer Vernooij
Run autopep8.
549
                                              self.master_branch)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
550
551
        # Now things are ready to change the master branch
552
        # so grab the lock
553
        self.bound_branch = self.branch
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
554
        stack.enter_context(self.master_branch.lock_write())
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
555
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
556
    def _check_out_of_date_tree(self):
557
        """Check that the working tree is up to date.
558
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
559
        :return: old_revision_number, old_revision_id, new_revision_number
560
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
561
        """
562
        try:
563
            first_tree_parent = self.work_tree.get_parent_ids()[0]
564
        except IndexError:
565
            # if there are no parents, treat our parent as 'None'
566
            # this is so that we still consider the master branch
567
            # - in a checkout scenario the tree may have no
568
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
569
            first_tree_parent = breezy.revision.NULL_REVISION
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
570
        if (self.master_branch._format.stores_revno() or
571
                self.config_stack.get('calculate_revnos')):
572
            try:
573
                old_revno, master_last = self.master_branch.last_revision_info()
574
            except errors.UnsupportedOperation:
575
                master_last = self.master_branch.last_revision()
576
                old_revno = self.branch.revision_id_to_revno(master_last)
577
        else:
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
578
            master_last = self.master_branch.last_revision()
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
579
            old_revno = None
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
580
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
581
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
582
                raise errors.OutOfDateTree(self.work_tree)
7339.1.5 by Jelmer Vernooij
Change order for efficiency reasons.
583
        if (old_revno is not None and
584
                self.branch.repository.has_revision(first_tree_parent)):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
585
            new_revno = old_revno + 1
586
        else:
587
            # ghost parents never appear in revision history.
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
588
            new_revno = None
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
589
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
590
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
591
    def _process_pre_hooks(self, old_revno, new_revno):
592
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
593
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
594
        self._process_hooks("pre_commit", old_revno, new_revno)
595
596
    def _process_post_hooks(self, old_revno, new_revno):
597
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
598
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
599
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
600
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
601
        # 0.15^H^H^H^H 2.5.0)
602
        post_commit = self.config_stack.get('post_commit')
603
        if post_commit is not None:
604
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
605
            # this would be nicer with twisted.python.reflect.namedAny
606
            for hook in hooks:
607
                result = eval(hook + '(branch, rev_id)',
7143.15.2 by Jelmer Vernooij
Run autopep8.
608
                              {'branch': self.branch,
609
                               'breezy': breezy,
610
                               'rev_id': self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
611
        # process new style post commit hooks
612
        self._process_hooks("post_commit", old_revno, new_revno)
613
614
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
615
        if not Branch.hooks[hook_name]:
616
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
617
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
618
        # new style commit hooks:
619
        if not self.bound_branch:
620
            hook_master = self.branch
621
            hook_local = None
622
        else:
623
            hook_master = self.master_branch
624
            hook_local = self.branch
625
        # With bound branches, when the master is behind the local branch,
626
        # the 'old_revno' and old_revid values here are incorrect.
627
        # XXX: FIXME ^. RBC 20060206
628
        if self.parents:
629
            old_revid = self.parents[0]
630
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
631
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
632
2659.3.9 by NamNguyen
branch.py:
633
        if hook_name == "pre_commit":
634
            future_tree = self.builder.revision_tree()
635
            tree_delta = future_tree.changes_from(self.basis_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
636
                                                  include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
637
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
638
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
639
            # show the running hook in the progress bar. As hooks may
640
            # end up doing nothing (e.g. because they are not configured by
641
            # the user) this is still showing progress, not showing overall
642
            # actions - its up to each plugin to show a UI if it want's to
643
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
644
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
645
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
646
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
647
            if 'hooks' in debug.debug_flags:
648
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
649
            if hook_name == "post_commit":
650
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
651
                     self.rev_id)
652
            elif hook_name == "pre_commit":
653
                hook(hook_local, hook_master,
654
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
655
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
656
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
657
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
658
        """Update the commit builder with the data about what has changed.
659
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
660
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
661
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
662
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
663
        self._check_strict()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
664
        iter_changes = self.work_tree.iter_changes(
665
            self.basis_tree, specific_files=specific_files)
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
666
        if self.exclude:
667
            iter_changes = filter_excluded(iter_changes, self.exclude)
668
        iter_changes = self._filter_iter_changes(iter_changes)
7206.6.1 by Jelmer Vernooij
Drop file_id from record_iter_changes return value.
669
        for path, fs_hash in self.builder.record_iter_changes(
7143.16.21 by Jelmer Vernooij
Fix regressions.
670
                self.work_tree, self.basis_revid, iter_changes):
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
671
            self.work_tree._observed_sha1(path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
672
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
673
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
674
        """Process iter_changes.
675
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
676
        This method reports on the changes in iter_changes to the user, and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
677
        converts 'missing' entries in the iter_changes iterator to 'deleted'
678
        entries. 'missing' entries have their
679
680
        :param iter_changes: An iter_changes to process.
681
        :return: A generator of changes.
682
        """
683
        reporter = self.reporter
684
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
685
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
686
        for change in iter_changes:
687
            if report_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
688
                old_path = change.path[0]
689
                new_path = change.path[1]
690
                versioned = change.versioned[1]
691
            kind = change.kind[1]
692
            versioned = change.versioned[1]
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
693
            if kind is None and versioned:
694
                # 'missing' path
695
                if report_changes:
696
                    reporter.missing(new_path)
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
697
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
698
                    trace.warning('Ignoring "%s" as symlinks are not '
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
699
                                  'supported on this filesystem.' % (change.path[0],))
6469.1.4 by Parth Malwankar
commit ignores symlinks on platforms that dont support symlinks
700
                    continue
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
701
                deleted_paths.append(change.path[1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
702
                # Reset the new path (None) and new versioned flag (False)
7322.1.7 by Jelmer Vernooij
Fix remaining tests.
703
                change = change.discard_new()
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
704
                new_path = change.path[1]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
705
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
706
            elif kind == 'tree-reference':
707
                if self.recursive == 'down':
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
708
                    self._commit_nested_tree(change.path[1])
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
709
            if change.versioned[0] or change.versioned[1]:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
710
                yield change
711
                if report_changes:
712
                    if new_path is None:
713
                        reporter.deleted(old_path)
714
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
715
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
716
                    elif old_path != new_path:
7143.15.2 by Jelmer Vernooij
Run autopep8.
717
                        reporter.renamed(gettext('renamed'),
718
                                         old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
719
                    else:
7143.15.2 by Jelmer Vernooij
Run autopep8.
720
                        if (new_path
721
                                or self.work_tree.branch.repository._format.rich_root_data):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
722
                            # Don't report on changes to '' in non rich root
723
                            # repositories.
7143.15.2 by Jelmer Vernooij
Run autopep8.
724
                            reporter.snapshot_change(
725
                                gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
726
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
727
        # Unversion files that were found to be deleted
728
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
729
730
    def _check_strict(self):
731
        # XXX: when we use iter_changes this would likely be faster if
732
        # iter_changes would check for us (even in the presence of
733
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
734
        if self.strict:
735
            # raise an exception as soon as we find a single unknown.
736
            for unknown in self.work_tree.unknowns():
737
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
738
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
739
    def _commit_nested_tree(self, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
740
        "Commit a nested tree."
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
741
        sub_tree = self.work_tree.get_nested_tree(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
742
        # FIXME: be more comprehensive here:
743
        # this works when both trees are in --trees repository,
744
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
745
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
746
        # finally implement the explicit-caches approach design
747
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
748
        if sub_tree.branch.repository.has_same_location(
7143.15.2 by Jelmer Vernooij
Run autopep8.
749
                self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
750
            sub_tree.branch.repository = \
751
                self.work_tree.branch.repository
752
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
753
            return sub_tree.commit(message=None, revprops=self.revprops,
7143.15.2 by Jelmer Vernooij
Run autopep8.
754
                                   recursive=self.recursive,
755
                                   message_callback=self.message_callback,
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
756
                                   timestamp=self.timestamp,
757
                                   timezone=self.timezone,
7143.15.2 by Jelmer Vernooij
Run autopep8.
758
                                   committer=self.committer,
759
                                   allow_pointless=self.allow_pointless,
760
                                   strict=self.strict, verbose=self.verbose,
761
                                   local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
762
        except PointlessCommit:
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
763
            return self.work_tree.get_reference_revision(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
764
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
765
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
766
        """Set the progress stage and emit an update to the progress bar."""
767
        self.pb_stage_name = name
768
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
769
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
770
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
771
        else:
772
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
773
        self._emit_progress()
774
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
775
    def _next_progress_entry(self):
776
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
777
        self.pb_entries_count += 1
778
        self._emit_progress()
779
780
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
781
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
782
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
7143.15.2 by Jelmer Vernooij
Run autopep8.
783
                                                       self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
784
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
785
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
786
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)