/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
2921.4.6 by Robert Collins
Typos found by Rob Weir.
17
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
18
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
19
# working tree and that were in the predecessor are reported as
20
# removed --- this can include files that were either removed from the
21
# inventory or deleted in the working tree.  If they were only
22
# deleted from disk, they are removed from the working inventory.
23
24
# We then consider the remaining entries, which will be in the new
25
# version.  Directory entries are simply copied across.  File entries
26
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
27
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
28
# version of the file was present.  If the file was present in at
29
# least one tree, and if it was the same version in all the trees,
30
# then we can just refer to that version.  Otherwise, a new version
31
# representing the merger of the file versions must be added.
32
33
# TODO: Update hashcache before and after - or does the WorkingTree
34
# look after that?
1245 by Martin Pool
doc
35
1339 by Martin Pool
- doc
36
# TODO: Rather than mashing together the ancestry and storing it back,
37
# perhaps the weave should have single method which does it all in one
38
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
39
1341 by Martin Pool
- doc
40
# TODO: Perhaps give a warning if one of the revisions marked as
41
# merged is already in the ancestry, and then don't record it as a
42
# distinct parent.
43
1343 by Martin Pool
- fix up test for merge of trees
44
# TODO: If the file is newly merged but unchanged from the version it
45
# merges from, then it should still be reported as newly added
46
# relative to the basis revision.
47
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
48
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
49
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
50
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
51
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
52
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
53
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
54
    trace,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
55
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
56
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
57
from .branch import Branch
7479.2.1 by Jelmer Vernooij
Drop python2 support.
58
from contextlib import ExitStack
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
59
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
60
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
61
                     ConflictsInTree,
62
                     StrictCommitFailed
63
                     )
64
from .osutils import (get_user_encoding,
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
65
                      has_symlinks,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
66
                      is_inside_any,
67
                      minimum_path_selection,
68
                      )
69
from .trace import mutter, note, is_quiet
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
70
from .tree import TreeChange
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
71
from .urlutils import unescape_for_display
72
from .i18n import gettext
73
1189 by Martin Pool
- BROKEN: partial support for commit into weave
74
6734.1.20 by Jelmer Vernooij
Move errors.
75
class PointlessCommit(BzrError):
76
77
    _fmt = "No changes to commit"
78
79
80
class CannotCommitSelectedFileMerge(BzrError):
81
82
    _fmt = 'Selected-file commit of merges is not supported yet:'\
83
        ' files %(files_str)s'
84
85
    def __init__(self, files):
86
        files_str = ', '.join(files)
87
        BzrError.__init__(self, files=files, files_str=files_str)
88
89
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
90
def filter_excluded(iter_changes, exclude):
91
    """Filter exclude filenames.
92
93
    :param iter_changes: iter_changes function
94
    :param exclude: List of paths to exclude
95
    :return: iter_changes function
96
    """
97
    for change in iter_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
98
        new_excluded = (change.path[1] is not None and
99
                        is_inside_any(exclude, change.path[1]))
100
101
        old_excluded = (change.path[0] is not None and
102
                        is_inside_any(exclude, change.path[0]))
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
103
104
        if old_excluded and new_excluded:
105
            continue
106
107
        if old_excluded or new_excluded:
108
            # TODO(jelmer): Perhaps raise an error here instead?
109
            continue
110
111
        yield change
112
113
1189 by Martin Pool
- BROKEN: partial support for commit into weave
114
class NullCommitReporter(object):
115
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
116
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
117
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
118
        pass
119
120
    def snapshot_change(self, change, path):
121
        pass
122
123
    def completed(self, revno, rev_id):
124
        pass
125
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
126
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
127
        pass
128
129
    def missing(self, path):
130
        pass
131
132
    def renamed(self, change, old_path, new_path):
133
        pass
134
2789.2.11 by Ian Clatworthy
remove more reporting stuff
135
    def is_verbose(self):
136
        return False
137
138
139
class ReportCommitToLog(NullCommitReporter):
140
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
141
    def _note(self, format, *args):
142
        """Output a message.
143
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
144
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
145
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
146
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
147
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
148
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
149
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
150
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
151
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
152
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
153
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
154
        self._note(
155
            gettext('Committing to: %s'),
156
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
157
158
    def completed(self, revno, rev_id):
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
159
        if revno is not None:
160
            self._note(gettext('Committed revision %d.'), revno)
161
            # self._note goes to the console too; so while we want to log the
162
            # rev_id, we can't trivially only log it. (See bug 526425). Long
163
            # term we should rearrange the reporting structure, but for now
164
            # we just mutter seperately. We mutter the revid and revno together
165
            # so that concurrent bzr invocations won't lead to confusion.
166
            mutter('Committed revid %s as revno %d.', rev_id, revno)
167
        else:
168
            self._note(gettext('Committed revid %s.'), rev_id)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
169
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
170
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
171
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
172
173
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
174
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
175
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
176
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
177
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
178
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
179
    def is_verbose(self):
180
        return True
181
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
182
1189 by Martin Pool
- BROKEN: partial support for commit into weave
183
class Commit(object):
184
    """Task of committing a new revision.
185
186
    This is a MethodObject: it accumulates state as the commit is
187
    prepared, and then it is discarded.  It doesn't represent
188
    historical revisions, just the act of recording a new one.
189
190
            missing_ids
191
            Modified to hold a list of files that have been deleted from
192
            the working directory; these should be removed from the
193
            working inventory.
485 by Martin Pool
- move commit code into its own module
194
    """
7143.15.2 by Jelmer Vernooij
Run autopep8.
195
1189 by Martin Pool
- BROKEN: partial support for commit into weave
196
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
197
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
198
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
199
        """Create a Commit object.
200
201
        :param reporter: the default reporter to use or None to decide later
202
        """
203
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
204
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
205
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
206
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
207
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
208
                        local=False, possible_master_transports=None):
209
        if revprops is None:
210
            revprops = {}
211
        if possible_master_transports is None:
212
            possible_master_transports = []
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
213
        if (u'branch-nick' not in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
214
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
215
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
216
                local,
217
                possible_master_transports)
218
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
219
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
220
                # XXX: maybe we should just accept one of them?
221
                raise AssertionError('author property given twice')
222
            if authors:
223
                for individual in authors:
224
                    if '\n' in individual:
225
                        raise AssertionError('\\n is not a valid character '
7143.15.2 by Jelmer Vernooij
Run autopep8.
226
                                             'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
227
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
228
        return revprops
229
1189 by Martin Pool
- BROKEN: partial support for commit into weave
230
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
231
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
232
               timestamp=None,
233
               timezone=None,
234
               committer=None,
235
               specific_files=None,
236
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
237
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
238
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
239
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
240
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
241
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
242
               local=False,
243
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
244
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
245
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
246
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
247
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
248
               possible_master_transports=None,
249
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
250
        """Commit working copy as a new revision.
251
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
252
        :param message: the commit message (it or message_callback is required)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
253
        :param message_callback: A callback: message =
254
            message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
255
256
        :param timestamp: if not None, seconds-since-epoch for a
257
            postdated/predated commit.
258
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
259
        :param specific_files: If not None, commit only those files. An empty
260
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
261
262
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
263
            Useful for test or import commands that need to tightly
264
            control what revisions are assigned.  If you duplicate
265
            a revision id that exists elsewhere it is your own fault.
266
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
267
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
268
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
269
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
270
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
271
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
272
            contains unknown files.
273
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
274
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
275
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
276
        :param reporter: the reporter to use or None for the default
277
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
278
        :param recursive: If set to 'down', commit in any subtrees that have
279
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
280
        :param exclude: None or a list of relative paths to exclude from the
281
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
282
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
283
        :param lossy: When committing to a foreign VCS, ignore any
284
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
285
        """
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
286
        with ExitStack() as stack:
287
            self.revprops = revprops or {}
288
            # XXX: Can be set on __init__ or passed in - this is a bit ugly.
289
            self.config_stack = config or self.config_stack
290
            mutter('preparing to commit')
291
292
            if working_tree is None:
293
                raise BzrError("working_tree must be passed into commit().")
294
            else:
295
                self.work_tree = working_tree
296
                self.branch = self.work_tree.branch
297
                if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
298
                    if not self.branch.repository.supports_rich_root():
299
                        raise errors.RootNotRich()
300
            if message_callback is None:
301
                if message is not None:
302
                    if isinstance(message, bytes):
303
                        message = message.decode(get_user_encoding())
304
305
                    def message_callback(x):
306
                        return message
307
                else:
308
                    raise BzrError("The message or message_callback keyword"
309
                                   " parameter is required for commit().")
310
311
            self.bound_branch = None
312
            self.any_entries_deleted = False
313
            if exclude is not None:
314
                self.exclude = sorted(
315
                    minimum_path_selection(exclude))
316
            else:
317
                self.exclude = []
318
            self.local = local
319
            self.master_branch = None
320
            self.recursive = recursive
321
            self.rev_id = None
322
            # self.specific_files is None to indicate no filter, or any iterable to
323
            # indicate a filter - [] means no files at all, as per iter_changes.
324
            if specific_files is not None:
325
                self.specific_files = sorted(
326
                    minimum_path_selection(specific_files))
327
            else:
328
                self.specific_files = None
329
330
            self.allow_pointless = allow_pointless
331
            self.message_callback = message_callback
332
            self.timestamp = timestamp
333
            self.timezone = timezone
334
            self.committer = committer
335
            self.strict = strict
336
            self.verbose = verbose
337
338
            stack.enter_context(self.work_tree.lock_write())
339
            self.parents = self.work_tree.get_parent_ids()
340
            self.pb = ui.ui_factory.nested_progress_bar()
341
            stack.callback(self.pb.finished)
342
            self.basis_revid = self.work_tree.last_revision()
343
            self.basis_tree = self.work_tree.basis_tree()
344
            stack.enter_context(self.basis_tree.lock_read())
345
            # Cannot commit with conflicts present.
346
            if len(self.work_tree.conflicts()) > 0:
347
                raise ConflictsInTree
348
349
            # Setup the bound branch variables as needed.
350
            self._check_bound_branch(stack, possible_master_transports)
7356.1.7 by Jelmer Vernooij
merge trunk.
351
            if self.config_stack is None:
352
                self.config_stack = self.work_tree.get_config_stack()
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
353
354
            # Check that the working tree is up to date
355
            old_revno, old_revid, new_revno = self._check_out_of_date_tree()
356
357
            # Complete configuration setup
358
            if reporter is not None:
359
                self.reporter = reporter
360
            elif self.reporter is None:
361
                self.reporter = self._select_reporter()
362
363
            # Setup the progress bar. As the number of files that need to be
364
            # committed in unknown, progress is reported as stages.
365
            # We keep track of entries separately though and include that
366
            # information in the progress bar during the relevant stages.
367
            self.pb_stage_name = ""
368
            self.pb_stage_count = 0
369
            self.pb_stage_total = 5
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
370
            if self.bound_branch:
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
371
                # 2 extra stages: "Uploading data to master branch" and "Merging
372
                # tags to master branch"
373
                self.pb_stage_total += 2
374
            self.pb.show_pct = False
375
            self.pb.show_spinner = False
376
            self.pb.show_eta = False
377
            self.pb.show_count = True
378
            self.pb.show_bar = True
379
380
            # After a merge, a selected file commit is not supported.
381
            # See 'bzr help merge' for an explanation as to why.
382
            if len(self.parents) > 1 and self.specific_files is not None:
383
                raise CannotCommitSelectedFileMerge(self.specific_files)
384
            # Excludes are a form of selected file commit.
385
            if len(self.parents) > 1 and self.exclude:
386
                raise CannotCommitSelectedFileMerge(self.exclude)
387
388
            # Collect the changes
389
            self._set_progress_stage("Collecting changes", counter=True)
390
            self._lossy = lossy
391
            self.builder = self.branch.get_commit_builder(
392
                self.parents, self.config_stack, timestamp, timezone, committer,
393
                self.revprops, rev_id, lossy=lossy)
394
395
            if self.builder.updates_branch and self.bound_branch:
396
                self.builder.abort()
397
                raise AssertionError(
398
                    "bound branches not supported for commit builders "
399
                    "that update the branch")
400
401
            try:
402
                # find the location being committed to
403
                if self.bound_branch:
404
                    master_location = self.master_branch.base
405
                else:
406
                    master_location = self.branch.base
407
408
                # report the start of the commit
409
                self.reporter.started(new_revno, self.rev_id, master_location)
410
411
                self._update_builder_with_changes()
412
                self._check_pointless()
413
414
                # TODO: Now the new inventory is known, check for conflicts.
415
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
416
                # weave lines, because nothing should be recorded until it is known
417
                # that commit will succeed.
418
                self._set_progress_stage("Saving data locally")
419
                self.builder.finish_inventory()
420
421
                # Prompt the user for a commit message if none provided
422
                message = message_callback(self)
423
                self.message = message
424
425
                # Add revision data to the local branch
426
                self.rev_id = self.builder.commit(self.message)
427
428
            except Exception:
429
                mutter("aborting commit write group because of exception:")
430
                trace.log_exception_quietly()
431
                self.builder.abort()
432
                raise
433
434
            self._update_branches(old_revno, old_revid, new_revno)
435
436
            # Make the working tree be up to date with the branch. This
437
            # includes automatic changes scheduled to be made to the tree, such
438
            # as updating its basis and unversioning paths that were missing.
439
            self.work_tree.unversion(self.deleted_paths)
440
            self._set_progress_stage("Updating the working tree")
441
            self.work_tree.update_basis_by_delta(self.rev_id,
442
                                                 self.builder.get_basis_delta())
443
            self.reporter.completed(new_revno, self.rev_id)
444
            self._process_post_hooks(old_revno, new_revno)
445
            return self.rev_id
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
446
447
    def _update_branches(self, old_revno, old_revid, new_revno):
448
        """Update the master and local branch to the new revision.
449
450
        This will try to make sure that the master branch is updated
451
        before the local branch.
452
453
        :param old_revno: Revision number of master branch before the
454
            commit
455
        :param old_revid: Tip of master branch before the commit
456
        :param new_revno: Revision number of the new commit
457
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
458
        if not self.builder.updates_branch:
459
            self._process_pre_hooks(old_revno, new_revno)
460
461
            # Upload revision data to the master.
462
            # this will propagate merged revisions too if needed.
463
            if self.bound_branch:
464
                self._set_progress_stage("Uploading data to master branch")
465
                # 'commit' to the master first so a timeout here causes the
466
                # local branch to be out of date
467
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
468
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
469
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
470
                    self.branch.fetch(self.master_branch, self.rev_id)
471
472
            # and now do the commit locally.
7339.1.9 by Jelmer Vernooij
Fix ghost handling during commit.
473
            if new_revno is None:
474
                # Keep existing behaviour around ghosts
475
                new_revno = 1
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
476
            self.branch.set_last_revision_info(new_revno, self.rev_id)
477
        else:
478
            try:
479
                self._process_pre_hooks(old_revno, new_revno)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
480
            except BaseException:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
481
                # The commit builder will already have updated the branch,
482
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
483
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
484
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
485
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
486
        # Merge local tags to remote
487
        if self.bound_branch:
488
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
489
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
490
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
491
            if tag_conflicts:
492
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
7143.15.2 by Jelmer Vernooij
Run autopep8.
493
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
494
                    "\n".join(warning_lines))))
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
495
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
496
    def _select_reporter(self):
497
        """Select the CommitReporter to use."""
498
        if is_quiet():
499
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
500
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
501
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
502
    def _check_pointless(self):
503
        if self.allow_pointless:
504
            return
505
        # A merge with no effect on files
506
        if len(self.parents) > 1:
507
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
508
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
509
            return
510
        raise PointlessCommit()
511
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
512
    def _check_bound_branch(self, stack, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
513
        """Check to see if the local branch is bound.
514
515
        If it is bound, then most of the commit will actually be
516
        done using the remote branch as the target branch.
517
        Only at the end will the local branch be updated.
518
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
519
        if self.local and not self.branch.get_bound_location():
520
            raise errors.LocalRequiresBoundBranch()
521
522
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
523
            self.master_branch = self.branch.get_master_branch(
524
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
525
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
526
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
527
            # make this branch the reference branch for out of date checks.
528
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
529
            return
530
531
        # If the master branch is bound, we must fail
532
        master_bound_location = self.master_branch.get_bound_location()
533
        if master_bound_location:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
534
            raise errors.CommitToDoubleBoundBranch(
535
                self.branch, self.master_branch, master_bound_location)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
536
537
        # TODO: jam 20051230 We could automatically push local
538
        #       commits to the remote branch if they would fit.
539
        #       But for now, just require remote to be identical
540
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
541
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
542
        # Make sure the local branch is identical to the master
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
543
        master_revid = self.master_branch.last_revision()
544
        local_revid = self.branch.last_revision()
545
        if local_revid != master_revid:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
546
            raise errors.BoundBranchOutOfDate(self.branch,
7143.15.2 by Jelmer Vernooij
Run autopep8.
547
                                              self.master_branch)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
548
549
        # Now things are ready to change the master branch
550
        # so grab the lock
551
        self.bound_branch = self.branch
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
552
        stack.enter_context(self.master_branch.lock_write())
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
553
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
554
    def _check_out_of_date_tree(self):
555
        """Check that the working tree is up to date.
556
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
557
        :return: old_revision_number, old_revision_id, new_revision_number
558
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
559
        """
560
        try:
561
            first_tree_parent = self.work_tree.get_parent_ids()[0]
562
        except IndexError:
563
            # if there are no parents, treat our parent as 'None'
564
            # this is so that we still consider the master branch
565
            # - in a checkout scenario the tree may have no
566
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
567
            first_tree_parent = breezy.revision.NULL_REVISION
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
568
        if (self.master_branch._format.stores_revno() or
569
                self.config_stack.get('calculate_revnos')):
570
            try:
571
                old_revno, master_last = self.master_branch.last_revision_info()
572
            except errors.UnsupportedOperation:
573
                master_last = self.master_branch.last_revision()
574
                old_revno = self.branch.revision_id_to_revno(master_last)
575
        else:
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
576
            master_last = self.master_branch.last_revision()
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
577
            old_revno = None
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
578
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
579
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
580
                raise errors.OutOfDateTree(self.work_tree)
7339.1.5 by Jelmer Vernooij
Change order for efficiency reasons.
581
        if (old_revno is not None and
582
                self.branch.repository.has_revision(first_tree_parent)):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
583
            new_revno = old_revno + 1
584
        else:
585
            # ghost parents never appear in revision history.
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
586
            new_revno = None
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
587
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
588
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
589
    def _process_pre_hooks(self, old_revno, new_revno):
590
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
591
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
592
        self._process_hooks("pre_commit", old_revno, new_revno)
593
594
    def _process_post_hooks(self, old_revno, new_revno):
595
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
596
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
597
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
598
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
599
        # 0.15^H^H^H^H 2.5.0)
600
        post_commit = self.config_stack.get('post_commit')
601
        if post_commit is not None:
602
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
603
            # this would be nicer with twisted.python.reflect.namedAny
604
            for hook in hooks:
605
                result = eval(hook + '(branch, rev_id)',
7143.15.2 by Jelmer Vernooij
Run autopep8.
606
                              {'branch': self.branch,
607
                               'breezy': breezy,
608
                               'rev_id': self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
609
        # process new style post commit hooks
610
        self._process_hooks("post_commit", old_revno, new_revno)
611
612
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
613
        if not Branch.hooks[hook_name]:
614
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
615
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
616
        # new style commit hooks:
617
        if not self.bound_branch:
618
            hook_master = self.branch
619
            hook_local = None
620
        else:
621
            hook_master = self.master_branch
622
            hook_local = self.branch
623
        # With bound branches, when the master is behind the local branch,
624
        # the 'old_revno' and old_revid values here are incorrect.
625
        # XXX: FIXME ^. RBC 20060206
626
        if self.parents:
627
            old_revid = self.parents[0]
628
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
629
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
630
2659.3.9 by NamNguyen
branch.py:
631
        if hook_name == "pre_commit":
632
            future_tree = self.builder.revision_tree()
633
            tree_delta = future_tree.changes_from(self.basis_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
634
                                                  include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
635
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
636
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
637
            # show the running hook in the progress bar. As hooks may
638
            # end up doing nothing (e.g. because they are not configured by
639
            # the user) this is still showing progress, not showing overall
640
            # actions - its up to each plugin to show a UI if it want's to
641
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
642
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
643
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
644
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
645
            if 'hooks' in debug.debug_flags:
646
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
647
            if hook_name == "post_commit":
648
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
649
                     self.rev_id)
650
            elif hook_name == "pre_commit":
651
                hook(hook_local, hook_master,
652
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
653
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
654
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
655
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
656
        """Update the commit builder with the data about what has changed.
657
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
658
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
659
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
660
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
661
        self._check_strict()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
662
        iter_changes = self.work_tree.iter_changes(
663
            self.basis_tree, specific_files=specific_files)
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
664
        if self.exclude:
665
            iter_changes = filter_excluded(iter_changes, self.exclude)
666
        iter_changes = self._filter_iter_changes(iter_changes)
7206.6.1 by Jelmer Vernooij
Drop file_id from record_iter_changes return value.
667
        for path, fs_hash in self.builder.record_iter_changes(
7143.16.21 by Jelmer Vernooij
Fix regressions.
668
                self.work_tree, self.basis_revid, iter_changes):
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
669
            self.work_tree._observed_sha1(path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
670
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
671
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
672
        """Process iter_changes.
673
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
674
        This method reports on the changes in iter_changes to the user, and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
675
        converts 'missing' entries in the iter_changes iterator to 'deleted'
676
        entries. 'missing' entries have their
677
678
        :param iter_changes: An iter_changes to process.
679
        :return: A generator of changes.
680
        """
681
        reporter = self.reporter
682
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
683
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
684
        for change in iter_changes:
685
            if report_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
686
                old_path = change.path[0]
687
                new_path = change.path[1]
688
                versioned = change.versioned[1]
689
            kind = change.kind[1]
690
            versioned = change.versioned[1]
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
691
            if kind is None and versioned:
692
                # 'missing' path
693
                if report_changes:
694
                    reporter.missing(new_path)
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
695
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
696
                    trace.warning('Ignoring "%s" as symlinks are not '
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
697
                                  'supported on this filesystem.' % (change.path[0],))
6469.1.4 by Parth Malwankar
commit ignores symlinks on platforms that dont support symlinks
698
                    continue
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
699
                deleted_paths.append(change.path[1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
700
                # Reset the new path (None) and new versioned flag (False)
7322.1.7 by Jelmer Vernooij
Fix remaining tests.
701
                change = change.discard_new()
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
702
                new_path = change.path[1]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
703
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
704
            elif kind == 'tree-reference':
705
                if self.recursive == 'down':
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
706
                    self._commit_nested_tree(change.path[1])
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
707
            if change.versioned[0] or change.versioned[1]:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
708
                yield change
709
                if report_changes:
710
                    if new_path is None:
711
                        reporter.deleted(old_path)
712
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
713
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
714
                    elif old_path != new_path:
7143.15.2 by Jelmer Vernooij
Run autopep8.
715
                        reporter.renamed(gettext('renamed'),
716
                                         old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
717
                    else:
7143.15.2 by Jelmer Vernooij
Run autopep8.
718
                        if (new_path
719
                                or self.work_tree.branch.repository._format.rich_root_data):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
720
                            # Don't report on changes to '' in non rich root
721
                            # repositories.
7143.15.2 by Jelmer Vernooij
Run autopep8.
722
                            reporter.snapshot_change(
723
                                gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
724
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
725
        # Unversion files that were found to be deleted
726
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
727
728
    def _check_strict(self):
729
        # XXX: when we use iter_changes this would likely be faster if
730
        # iter_changes would check for us (even in the presence of
731
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
732
        if self.strict:
733
            # raise an exception as soon as we find a single unknown.
734
            for unknown in self.work_tree.unknowns():
735
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
736
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
737
    def _commit_nested_tree(self, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
738
        "Commit a nested tree."
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
739
        sub_tree = self.work_tree.get_nested_tree(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
740
        # FIXME: be more comprehensive here:
741
        # this works when both trees are in --trees repository,
742
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
743
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
744
        # finally implement the explicit-caches approach design
745
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
746
        if sub_tree.branch.repository.has_same_location(
7143.15.2 by Jelmer Vernooij
Run autopep8.
747
                self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
748
            sub_tree.branch.repository = \
749
                self.work_tree.branch.repository
750
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
751
            return sub_tree.commit(message=None, revprops=self.revprops,
7143.15.2 by Jelmer Vernooij
Run autopep8.
752
                                   recursive=self.recursive,
753
                                   message_callback=self.message_callback,
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
754
                                   timestamp=self.timestamp,
755
                                   timezone=self.timezone,
7143.15.2 by Jelmer Vernooij
Run autopep8.
756
                                   committer=self.committer,
757
                                   allow_pointless=self.allow_pointless,
758
                                   strict=self.strict, verbose=self.verbose,
759
                                   local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
760
        except PointlessCommit:
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
761
            return self.work_tree.get_reference_revision(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
762
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
763
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
764
        """Set the progress stage and emit an update to the progress bar."""
765
        self.pb_stage_name = name
766
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
767
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
768
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
769
        else:
770
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
771
        self._emit_progress()
772
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
773
    def _next_progress_entry(self):
774
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
775
        self.pb_entries_count += 1
776
        self._emit_progress()
777
778
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
779
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
780
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
7143.15.2 by Jelmer Vernooij
Run autopep8.
781
                                                       self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
782
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
783
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
784
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)