/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5557.1.11 by John Arbash Meinel
Remove extra pdb stuff
1
# Copyright (C) 2005-2011 Canonical Ltd
1887.1.1 by Adeodato Simó
Do not separate paragraphs in the copyright statement with blank lines,
2
#
485 by Martin Pool
- move commit code into its own module
3
# This program is free software; you can redistribute it and/or modify
4
# it under the terms of the GNU General Public License as published by
5
# the Free Software Foundation; either version 2 of the License, or
6
# (at your option) any later version.
1248 by Martin Pool
- new weave based cleanup [broken]
7
#
485 by Martin Pool
- move commit code into its own module
8
# This program is distributed in the hope that it will be useful,
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
# GNU General Public License for more details.
1248 by Martin Pool
- new weave based cleanup [broken]
12
#
485 by Martin Pool
- move commit code into its own module
13
# You should have received a copy of the GNU General Public License
14
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
485 by Martin Pool
- move commit code into its own module
16
2921.4.6 by Robert Collins
Typos found by Rob Weir.
17
# The newly committed revision is going to have a shape corresponding
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
18
# to that of the working tree.  Files that are not in the
1248 by Martin Pool
- new weave based cleanup [broken]
19
# working tree and that were in the predecessor are reported as
20
# removed --- this can include files that were either removed from the
21
# inventory or deleted in the working tree.  If they were only
22
# deleted from disk, they are removed from the working inventory.
23
24
# We then consider the remaining entries, which will be in the new
25
# version.  Directory entries are simply copied across.  File entries
26
# must be checked to see if a new version of the file should be
2921.4.4 by Robert Collins
Minor import cleanup in commit.py.
27
# recorded.  For each parent revision tree, we check to see what
1248 by Martin Pool
- new weave based cleanup [broken]
28
# version of the file was present.  If the file was present in at
29
# least one tree, and if it was the same version in all the trees,
30
# then we can just refer to that version.  Otherwise, a new version
31
# representing the merger of the file versions must be added.
32
33
# TODO: Update hashcache before and after - or does the WorkingTree
34
# look after that?
1245 by Martin Pool
doc
35
1339 by Martin Pool
- doc
36
# TODO: Rather than mashing together the ancestry and storing it back,
37
# perhaps the weave should have single method which does it all in one
38
# go, avoiding a lot of redundant work.
1335 by Martin Pool
doc
39
1341 by Martin Pool
- doc
40
# TODO: Perhaps give a warning if one of the revisions marked as
41
# merged is already in the ancestry, and then don't record it as a
42
# distinct parent.
43
1343 by Martin Pool
- fix up test for merge of trees
44
# TODO: If the file is newly merged but unchanged from the version it
45
# merges from, then it should still be reported as newly added
46
# relative to the basis revision.
47
1910.7.17 by Andrew Bennetts
Various cosmetic changes.
48
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
49
# the rest of the code; add a deprecation of the old name.
1194 by Martin Pool
- [BROKEN] more progress of commit into weaves
50
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
51
from . import (
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
52
    debug,
1551.8.30 by Aaron Bentley
Tweak from review comments
53
    errors,
3830.3.3 by Martin Pool
commit should log original exception when aborting write group
54
    trace,
5582.10.6 by Jelmer Vernooij
Fix ui imports.
55
    ui,
1551.8.30 by Aaron Bentley
Tweak from review comments
56
    )
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
57
from .branch import Branch
7479.2.1 by Jelmer Vernooij
Drop python2 support.
58
from contextlib import ExitStack
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
59
import breezy.config
6734.1.20 by Jelmer Vernooij
Move errors.
60
from .errors import (BzrError,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
61
                     ConflictsInTree,
62
                     StrictCommitFailed
63
                     )
64
from .osutils import (get_user_encoding,
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
65
                      has_symlinks,
6624 by Jelmer Vernooij
Merge Python3 porting work ('py3 pokes')
66
                      is_inside_any,
67
                      minimum_path_selection,
68
                      )
69
from .trace import mutter, note, is_quiet
70
from .urlutils import unescape_for_display
71
from .i18n import gettext
72
1189 by Martin Pool
- BROKEN: partial support for commit into weave
73
6734.1.20 by Jelmer Vernooij
Move errors.
74
class PointlessCommit(BzrError):
75
76
    _fmt = "No changes to commit"
77
78
79
class CannotCommitSelectedFileMerge(BzrError):
80
81
    _fmt = 'Selected-file commit of merges is not supported yet:'\
82
        ' files %(files_str)s'
83
84
    def __init__(self, files):
85
        files_str = ', '.join(files)
86
        BzrError.__init__(self, files=files, files_str=files_str)
87
88
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
89
def filter_excluded(iter_changes, exclude):
90
    """Filter exclude filenames.
91
92
    :param iter_changes: iter_changes function
93
    :param exclude: List of paths to exclude
94
    :return: iter_changes function
95
    """
96
    for change in iter_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
97
        new_excluded = (change.path[1] is not None and
98
                        is_inside_any(exclude, change.path[1]))
99
100
        old_excluded = (change.path[0] is not None and
101
                        is_inside_any(exclude, change.path[0]))
6699.1.1 by Jelmer Vernooij
Support excludes with "bzr commit -x".
102
103
        if old_excluded and new_excluded:
104
            continue
105
106
        if old_excluded or new_excluded:
107
            # TODO(jelmer): Perhaps raise an error here instead?
108
            continue
109
110
        yield change
111
112
1189 by Martin Pool
- BROKEN: partial support for commit into weave
113
class NullCommitReporter(object):
114
    """I report on progress of a commit."""
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
115
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
116
    def started(self, revno, revid, location):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
117
        pass
118
119
    def snapshot_change(self, change, path):
120
        pass
121
122
    def completed(self, revno, rev_id):
123
        pass
124
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
125
    def deleted(self, path):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
126
        pass
127
128
    def missing(self, path):
129
        pass
130
131
    def renamed(self, change, old_path, new_path):
132
        pass
133
2789.2.11 by Ian Clatworthy
remove more reporting stuff
134
    def is_verbose(self):
135
        return False
136
137
138
class ReportCommitToLog(NullCommitReporter):
139
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
140
    def _note(self, format, *args):
141
        """Output a message.
142
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
143
        Subclasses may choose to override this method.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
144
        """
2522.2.3 by Ian Clatworthy
Revert logging just to stderr in commit as broke unicode filenames (#120930)
145
        note(format, *args)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
146
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
147
    def snapshot_change(self, change, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
148
        if path == '' and change in (gettext('added'), gettext('modified')):
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
149
            return
2789.2.11 by Ian Clatworthy
remove more reporting stuff
150
        self._note("%s %s", change, path)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
151
6630.1.3 by Jelmer Vernooij
Make location argument non-optional.
152
    def started(self, revno, rev_id, location):
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
153
        self._note(
154
            gettext('Committing to: %s'),
155
            unescape_for_display(location, 'utf-8'))
2747.6.5 by Daniel Watkins
Added 'started' hook to CommitReporters and moved location functionality from completed hook into it.
156
157
    def completed(self, revno, rev_id):
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
158
        if revno is not None:
159
            self._note(gettext('Committed revision %d.'), revno)
160
            # self._note goes to the console too; so while we want to log the
161
            # rev_id, we can't trivially only log it. (See bug 526425). Long
162
            # term we should rearrange the reporting structure, but for now
163
            # we just mutter seperately. We mutter the revid and revno together
164
            # so that concurrent bzr invocations won't lead to confusion.
165
            mutter('Committed revid %s as revno %d.', rev_id, revno)
166
        else:
167
            self._note(gettext('Committed revid %s.'), rev_id)
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
168
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
169
    def deleted(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
170
        self._note(gettext('deleted %s'), path)
1185.12.8 by Aaron Bentley
Fixed commit so all output comes though CommitReporter
171
172
    def missing(self, path):
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
173
        self._note(gettext('missing %s'), path)
1189 by Martin Pool
- BROKEN: partial support for commit into weave
174
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
175
    def renamed(self, change, old_path, new_path):
2789.2.11 by Ian Clatworthy
remove more reporting stuff
176
        self._note('%s %s => %s', change, old_path, new_path)
1668.1.5 by Martin Pool
[broken] fix up display of files changed by a commit
177
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
178
    def is_verbose(self):
179
        return True
180
1508.1.6 by Robert Collins
Move Branch.unknowns() to WorkingTree.
181
1189 by Martin Pool
- BROKEN: partial support for commit into weave
182
class Commit(object):
183
    """Task of committing a new revision.
184
185
    This is a MethodObject: it accumulates state as the commit is
186
    prepared, and then it is discarded.  It doesn't represent
187
    historical revisions, just the act of recording a new one.
188
189
            missing_ids
190
            Modified to hold a list of files that have been deleted from
191
            the working directory; these should be removed from the
192
            working inventory.
485 by Martin Pool
- move commit code into its own module
193
    """
7143.15.2 by Jelmer Vernooij
Run autopep8.
194
1189 by Martin Pool
- BROKEN: partial support for commit into weave
195
    def __init__(self,
1442.1.60 by Robert Collins
gpg sign commits if the policy says we need to
196
                 reporter=None,
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
197
                 config_stack=None):
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
198
        """Create a Commit object.
199
200
        :param reporter: the default reporter to use or None to decide later
201
        """
202
        self.reporter = reporter
6351.3.2 by Jelmer Vernooij
Convert some gpg options to config stacks.
203
        self.config_stack = config_stack
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
204
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
205
    @staticmethod
6630.1.1 by Jelmer Vernooij
Remove deprecated functionality.
206
    def update_revprops(revprops, branch, authors=None,
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
207
                        local=False, possible_master_transports=None):
208
        if revprops is None:
209
            revprops = {}
210
        if possible_master_transports is None:
211
            possible_master_transports = []
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
212
        if (u'branch-nick' not in revprops and
6829.1.1 by Jelmer Vernooij
Avoid setting branch nick if format doesn't support it.
213
                branch.repository._format.supports_storing_branch_nick):
6973.12.3 by Jelmer Vernooij
Fixes.
214
            revprops[u'branch-nick'] = branch._get_nick(
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
215
                local,
216
                possible_master_transports)
217
        if authors is not None:
6973.12.3 by Jelmer Vernooij
Fixes.
218
            if u'author' in revprops or u'authors' in revprops:
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
219
                # XXX: maybe we should just accept one of them?
220
                raise AssertionError('author property given twice')
221
            if authors:
222
                for individual in authors:
223
                    if '\n' in individual:
224
                        raise AssertionError('\\n is not a valid character '
7143.15.2 by Jelmer Vernooij
Run autopep8.
225
                                             'in an author identity')
6973.12.3 by Jelmer Vernooij
Fixes.
226
                revprops[u'authors'] = '\n'.join(authors)
5162.4.1 by Aaron Bentley
TreeTransform supports normal commit parameters and includes branch nick.
227
        return revprops
228
1189 by Martin Pool
- BROKEN: partial support for commit into weave
229
    def commit(self,
2367.2.1 by Robert Collins
Remove bzrlib 0.8 compatability where it was making the code unclear or messy. (Robert Collins)
230
               message=None,
1189 by Martin Pool
- BROKEN: partial support for commit into weave
231
               timestamp=None,
232
               timezone=None,
233
               committer=None,
234
               specific_files=None,
235
               rev_id=None,
1276 by Martin Pool
- make Branch.commit accept (and ignore) verbose argument
236
               allow_pointless=True,
1185.16.65 by mbp at sourcefrog
- new commit --strict option
237
               strict=False,
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
238
               verbose=False,
1534.4.25 by Robert Collins
Add a --transport parameter to the test suite to set the default transport to be used in the test suite.
239
               revprops=None,
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
240
               working_tree=None,
1607.1.5 by Robert Collins
Make commit verbose mode work!.
241
               local=False,
242
               reporter=None,
2149.1.1 by Aaron Bentley
Provide a message_callback parameter to tree.commit
243
               config=None,
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
244
               message_callback=None,
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
245
               recursive='down',
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
246
               exclude=None,
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
247
               possible_master_transports=None,
248
               lossy=False):
1189 by Martin Pool
- BROKEN: partial support for commit into weave
249
        """Commit working copy as a new revision.
250
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
251
        :param message: the commit message (it or message_callback is required)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
252
        :param message_callback: A callback: message =
253
            message_callback(cmt_obj)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
254
255
        :param timestamp: if not None, seconds-since-epoch for a
256
            postdated/predated commit.
257
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
258
        :param specific_files: If not None, commit only those files. An empty
259
            list means 'commit no files'.
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
260
261
        :param rev_id: If set, use this as the new revision id.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
262
            Useful for test or import commands that need to tightly
263
            control what revisions are assigned.  If you duplicate
264
            a revision id that exists elsewhere it is your own fault.
265
            If null (default), a time/random revision id is generated.
1253 by Martin Pool
- test that pointless commits are trapped
266
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
267
        :param allow_pointless: If true (default), commit even if nothing
1253 by Martin Pool
- test that pointless commits are trapped
268
            has changed and no merges are recorded.
1185.16.35 by Martin Pool
- stub for revision properties
269
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
270
        :param strict: If true, don't allow a commit if the working tree
1185.16.65 by mbp at sourcefrog
- new commit --strict option
271
            contains unknown files.
272
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
273
        :param revprops: Properties for new revision
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
274
        :param local: Perform a local only commit.
2789.2.1 by Ian Clatworthy
Make commit less verbose by default
275
        :param reporter: the reporter to use or None for the default
276
        :param verbose: if True and the reporter is not None, report everything
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
277
        :param recursive: If set to 'down', commit in any subtrees that have
278
            pending changes of any sort during this commit.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
279
        :param exclude: None or a list of relative paths to exclude from the
280
            commit. Pending changes to excluded files will be ignored by the
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
281
            commit.
5777.6.1 by Jelmer Vernooij
Add --lossy option to 'bzr commit'.
282
        :param lossy: When committing to a foreign VCS, ignore any
283
            data that can not be natively represented.
1189 by Martin Pool
- BROKEN: partial support for commit into weave
284
        """
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
285
        with ExitStack() as stack:
286
            self.revprops = revprops or {}
287
            # XXX: Can be set on __init__ or passed in - this is a bit ugly.
288
            self.config_stack = config or self.config_stack
289
            mutter('preparing to commit')
290
291
            if working_tree is None:
292
                raise BzrError("working_tree must be passed into commit().")
293
            else:
294
                self.work_tree = working_tree
295
                self.branch = self.work_tree.branch
296
                if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
297
                    if not self.branch.repository.supports_rich_root():
298
                        raise errors.RootNotRich()
299
            if message_callback is None:
300
                if message is not None:
301
                    if isinstance(message, bytes):
302
                        message = message.decode(get_user_encoding())
303
304
                    def message_callback(x):
305
                        return message
306
                else:
307
                    raise BzrError("The message or message_callback keyword"
308
                                   " parameter is required for commit().")
309
310
            self.bound_branch = None
311
            self.any_entries_deleted = False
312
            if exclude is not None:
313
                self.exclude = sorted(
314
                    minimum_path_selection(exclude))
315
            else:
316
                self.exclude = []
317
            self.local = local
318
            self.master_branch = None
319
            self.recursive = recursive
320
            self.rev_id = None
321
            # self.specific_files is None to indicate no filter, or any iterable to
322
            # indicate a filter - [] means no files at all, as per iter_changes.
323
            if specific_files is not None:
324
                self.specific_files = sorted(
325
                    minimum_path_selection(specific_files))
326
            else:
327
                self.specific_files = None
328
329
            self.allow_pointless = allow_pointless
330
            self.message_callback = message_callback
331
            self.timestamp = timestamp
332
            self.timezone = timezone
333
            self.committer = committer
334
            self.strict = strict
335
            self.verbose = verbose
336
337
            stack.enter_context(self.work_tree.lock_write())
338
            self.parents = self.work_tree.get_parent_ids()
339
            self.pb = ui.ui_factory.nested_progress_bar()
340
            stack.callback(self.pb.finished)
341
            self.basis_revid = self.work_tree.last_revision()
342
            self.basis_tree = self.work_tree.basis_tree()
343
            stack.enter_context(self.basis_tree.lock_read())
344
            # Cannot commit with conflicts present.
345
            if len(self.work_tree.conflicts()) > 0:
346
                raise ConflictsInTree
347
348
            # Setup the bound branch variables as needed.
349
            self._check_bound_branch(stack, possible_master_transports)
7356.1.7 by Jelmer Vernooij
merge trunk.
350
            if self.config_stack is None:
351
                self.config_stack = self.work_tree.get_config_stack()
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
352
353
            # Check that the working tree is up to date
354
            old_revno, old_revid, new_revno = self._check_out_of_date_tree()
355
356
            # Complete configuration setup
357
            if reporter is not None:
358
                self.reporter = reporter
359
            elif self.reporter is None:
360
                self.reporter = self._select_reporter()
361
362
            # Setup the progress bar. As the number of files that need to be
363
            # committed in unknown, progress is reported as stages.
364
            # We keep track of entries separately though and include that
365
            # information in the progress bar during the relevant stages.
366
            self.pb_stage_name = ""
367
            self.pb_stage_count = 0
368
            self.pb_stage_total = 5
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
369
            if self.bound_branch:
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
370
                # 2 extra stages: "Uploading data to master branch" and "Merging
371
                # tags to master branch"
372
                self.pb_stage_total += 2
373
            self.pb.show_pct = False
374
            self.pb.show_spinner = False
375
            self.pb.show_eta = False
376
            self.pb.show_count = True
377
            self.pb.show_bar = True
378
379
            # After a merge, a selected file commit is not supported.
380
            # See 'bzr help merge' for an explanation as to why.
381
            if len(self.parents) > 1 and self.specific_files is not None:
382
                raise CannotCommitSelectedFileMerge(self.specific_files)
383
            # Excludes are a form of selected file commit.
384
            if len(self.parents) > 1 and self.exclude:
385
                raise CannotCommitSelectedFileMerge(self.exclude)
386
387
            # Collect the changes
388
            self._set_progress_stage("Collecting changes", counter=True)
389
            self._lossy = lossy
390
            self.builder = self.branch.get_commit_builder(
391
                self.parents, self.config_stack, timestamp, timezone, committer,
392
                self.revprops, rev_id, lossy=lossy)
393
394
            if self.builder.updates_branch and self.bound_branch:
395
                self.builder.abort()
396
                raise AssertionError(
397
                    "bound branches not supported for commit builders "
398
                    "that update the branch")
399
400
            try:
401
                # find the location being committed to
402
                if self.bound_branch:
403
                    master_location = self.master_branch.base
404
                else:
405
                    master_location = self.branch.base
406
407
                # report the start of the commit
408
                self.reporter.started(new_revno, self.rev_id, master_location)
409
410
                self._update_builder_with_changes()
411
                self._check_pointless()
412
413
                # TODO: Now the new inventory is known, check for conflicts.
414
                # ADHB 2006-08-08: If this is done, populate_new_inv should not add
415
                # weave lines, because nothing should be recorded until it is known
416
                # that commit will succeed.
417
                self._set_progress_stage("Saving data locally")
418
                self.builder.finish_inventory()
419
420
                # Prompt the user for a commit message if none provided
421
                message = message_callback(self)
422
                self.message = message
423
424
                # Add revision data to the local branch
425
                self.rev_id = self.builder.commit(self.message)
426
427
            except Exception:
428
                mutter("aborting commit write group because of exception:")
429
                trace.log_exception_quietly()
430
                self.builder.abort()
431
                raise
432
433
            self._update_branches(old_revno, old_revid, new_revno)
434
435
            # Make the working tree be up to date with the branch. This
436
            # includes automatic changes scheduled to be made to the tree, such
437
            # as updating its basis and unversioning paths that were missing.
438
            self.work_tree.unversion(self.deleted_paths)
439
            self._set_progress_stage("Updating the working tree")
7467.4.13 by Jelmer Vernooij
Fix last rename tests.
440
            self.work_tree.update_basis_by_delta(
441
                self.rev_id, self.builder.get_basis_delta())
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
442
            self.reporter.completed(new_revno, self.rev_id)
443
            self._process_post_hooks(old_revno, new_revno)
444
            return self.rev_id
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
445
446
    def _update_branches(self, old_revno, old_revid, new_revno):
447
        """Update the master and local branch to the new revision.
448
449
        This will try to make sure that the master branch is updated
450
        before the local branch.
451
452
        :param old_revno: Revision number of master branch before the
453
            commit
454
        :param old_revid: Tip of master branch before the commit
455
        :param new_revno: Revision number of the new commit
456
        """
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
457
        if not self.builder.updates_branch:
458
            self._process_pre_hooks(old_revno, new_revno)
459
460
            # Upload revision data to the master.
461
            # this will propagate merged revisions too if needed.
462
            if self.bound_branch:
463
                self._set_progress_stage("Uploading data to master branch")
464
                # 'commit' to the master first so a timeout here causes the
465
                # local branch to be out of date
466
                (new_revno, self.rev_id) = self.master_branch.import_last_revision_info_and_tags(
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
467
                    self.branch, new_revno, self.rev_id, lossy=self._lossy)
468
                if self._lossy:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
469
                    self.branch.fetch(self.master_branch, self.rev_id)
470
471
            # and now do the commit locally.
7339.1.9 by Jelmer Vernooij
Fix ghost handling during commit.
472
            if new_revno is None:
473
                # Keep existing behaviour around ghosts
474
                new_revno = 1
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
475
            self.branch.set_last_revision_info(new_revno, self.rev_id)
476
        else:
477
            try:
478
                self._process_pre_hooks(old_revno, new_revno)
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
479
            except BaseException:
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
480
                # The commit builder will already have updated the branch,
481
                # revert it.
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
482
                self.branch.set_last_revision_info(old_revno, old_revid)
6217.5.1 by Jelmer Vernooij
Add CommitBuilder.updates_branch.
483
                raise
4744.3.2 by Andrew Bennetts
Add OperationWithCleanups helper, use it to make commit.py simpler and more robust.
484
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
485
        # Merge local tags to remote
486
        if self.bound_branch:
487
            self._set_progress_stage("Merging tags to master branch")
6112.4.2 by Jelmer Vernooij
Fix tag tests.
488
            tag_updates, tag_conflicts = self.branch.tags.merge_to(
489
                self.master_branch.tags)
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
490
            if tag_conflicts:
491
                warning_lines = ['    ' + name for name, _, _ in tag_conflicts]
7143.15.2 by Jelmer Vernooij
Run autopep8.
492
                note(gettext("Conflicting tags in bound branch:\n{0}".format(
493
                    "\n".join(warning_lines))))
5050.52.3 by Andrew Bennetts
Merge tags from local to master when committing in a bound branch.
494
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
495
    def _select_reporter(self):
496
        """Select the CommitReporter to use."""
497
        if is_quiet():
498
            return NullCommitReporter()
2789.2.10 by Ian Clatworthy
focus on performance gains, not better reporting
499
        return ReportCommitToLog()
2789.2.4 by Ian Clatworthy
make change reporting smarter for initial commit
500
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
501
    def _check_pointless(self):
502
        if self.allow_pointless:
503
            return
504
        # A merge with no effect on files
505
        if len(self.parents) > 1:
506
            return
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
507
        if self.builder.any_changes():
1910.2.37 by Aaron Bentley
Handle empty commits, fix test
508
            return
509
        raise PointlessCommit()
510
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
511
    def _check_bound_branch(self, stack, possible_master_transports=None):
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
512
        """Check to see if the local branch is bound.
513
514
        If it is bound, then most of the commit will actually be
515
        done using the remote branch as the target branch.
516
        Only at the end will the local branch be updated.
517
        """
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
518
        if self.local and not self.branch.get_bound_location():
519
            raise errors.LocalRequiresBoundBranch()
520
521
        if not self.local:
3565.6.9 by Marius Kruger
Jump through hoops not to open multiple connections when committing to a bound branch.
522
            self.master_branch = self.branch.get_master_branch(
523
                possible_master_transports)
1587.1.9 by Robert Collins
Local commits do no alter or access the master branch.
524
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
525
        if not self.master_branch:
1587.1.8 by Robert Collins
Local commits on unbound branches fail.
526
            # make this branch the reference branch for out of date checks.
527
            self.master_branch = self.branch
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
528
            return
529
530
        # If the master branch is bound, we must fail
531
        master_bound_location = self.master_branch.get_bound_location()
532
        if master_bound_location:
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
533
            raise errors.CommitToDoubleBoundBranch(
534
                self.branch, self.master_branch, master_bound_location)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
535
536
        # TODO: jam 20051230 We could automatically push local
537
        #       commits to the remote branch if they would fit.
538
        #       But for now, just require remote to be identical
539
        #       to local.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
540
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
541
        # Make sure the local branch is identical to the master
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
542
        master_revid = self.master_branch.last_revision()
543
        local_revid = self.branch.last_revision()
544
        if local_revid != master_revid:
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
545
            raise errors.BoundBranchOutOfDate(self.branch,
7143.15.2 by Jelmer Vernooij
Run autopep8.
546
                                              self.master_branch)
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
547
548
        # Now things are ready to change the master branch
549
        # so grab the lock
550
        self.bound_branch = self.branch
7356.1.1 by Jelmer Vernooij
Use ExitStack context rather than brz-specific OperationWithCleanup.
551
        stack.enter_context(self.master_branch.lock_write())
1505.1.24 by John Arbash Meinel
Updated commit to handle bound branches. Included test to handle commit after merge
552
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
553
    def _check_out_of_date_tree(self):
554
        """Check that the working tree is up to date.
555
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
556
        :return: old_revision_number, old_revision_id, new_revision_number
557
            tuple
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
558
        """
559
        try:
560
            first_tree_parent = self.work_tree.get_parent_ids()[0]
561
        except IndexError:
562
            # if there are no parents, treat our parent as 'None'
563
            # this is so that we still consider the master branch
564
            # - in a checkout scenario the tree may have no
565
            # parents but the branch may do.
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
566
            first_tree_parent = breezy.revision.NULL_REVISION
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
567
        if (self.master_branch._format.stores_revno() or
568
                self.config_stack.get('calculate_revnos')):
569
            try:
570
                old_revno, master_last = self.master_branch.last_revision_info()
571
            except errors.UnsupportedOperation:
572
                master_last = self.master_branch.last_revision()
573
                old_revno = self.branch.revision_id_to_revno(master_last)
574
        else:
7131.14.1 by Jelmer Vernooij
Fix committing to a bzr branch bound to a git branch.
575
            master_last = self.master_branch.last_revision()
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
576
            old_revno = None
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
577
        if master_last != first_tree_parent:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
578
            if master_last != breezy.revision.NULL_REVISION:
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
579
                raise errors.OutOfDateTree(self.work_tree)
7339.1.5 by Jelmer Vernooij
Change order for efficiency reasons.
580
        if (old_revno is not None and
581
                self.branch.repository.has_revision(first_tree_parent)):
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
582
            new_revno = old_revno + 1
583
        else:
584
            # ghost parents never appear in revision history.
7339.1.4 by Jelmer Vernooij
Only display revnos in commit if calculate_revnos is enabled.
585
            new_revno = None
6217.5.2 by Jelmer Vernooij
Factor out the updating of branches into a separate helper.
586
        return old_revno, master_last, new_revno
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
587
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
588
    def _process_pre_hooks(self, old_revno, new_revno):
589
        """Process any registered pre commit hooks."""
2659.3.9 by NamNguyen
branch.py:
590
        self._set_progress_stage("Running pre_commit hooks")
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
591
        self._process_hooks("pre_commit", old_revno, new_revno)
592
593
    def _process_post_hooks(self, old_revno, new_revno):
594
        """Process any registered post commit hooks."""
2553.1.2 by Robert Collins
Show hook names during commit.
595
        # Process the post commit hooks, if any
2659.3.9 by NamNguyen
branch.py:
596
        self._set_progress_stage("Running post_commit hooks")
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
597
        # old style commit hooks - should be deprecated ? (obsoleted in
6351.3.12 by Vincent Ladeuil
Use simpler config stacks and use strings as inputs to better respect the API.
598
        # 0.15^H^H^H^H 2.5.0)
599
        post_commit = self.config_stack.get('post_commit')
600
        if post_commit is not None:
601
            hooks = post_commit.split(' ')
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
602
            # this would be nicer with twisted.python.reflect.namedAny
603
            for hook in hooks:
604
                result = eval(hook + '(branch, rev_id)',
7143.15.2 by Jelmer Vernooij
Run autopep8.
605
                              {'branch': self.branch,
606
                               'breezy': breezy,
607
                               'rev_id': self.rev_id})
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
608
        # process new style post commit hooks
609
        self._process_hooks("post_commit", old_revno, new_revno)
610
611
    def _process_hooks(self, hook_name, old_revno, new_revno):
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
612
        if not Branch.hooks[hook_name]:
613
            return
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
614
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
615
        # new style commit hooks:
616
        if not self.bound_branch:
617
            hook_master = self.branch
618
            hook_local = None
619
        else:
620
            hook_master = self.master_branch
621
            hook_local = self.branch
622
        # With bound branches, when the master is behind the local branch,
623
        # the 'old_revno' and old_revid values here are incorrect.
624
        # XXX: FIXME ^. RBC 20060206
625
        if self.parents:
626
            old_revid = self.parents[0]
627
        else:
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
628
            old_revid = breezy.revision.NULL_REVISION
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
629
2659.3.9 by NamNguyen
branch.py:
630
        if hook_name == "pre_commit":
631
            future_tree = self.builder.revision_tree()
632
            tree_delta = future_tree.changes_from(self.basis_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
633
                                                  include_root=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
634
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
635
        for hook in Branch.hooks[hook_name]:
2553.1.3 by Robert Collins
Increase docs in response to review feedback.
636
            # show the running hook in the progress bar. As hooks may
637
            # end up doing nothing (e.g. because they are not configured by
638
            # the user) this is still showing progress, not showing overall
639
            # actions - its up to each plugin to show a UI if it want's to
640
            # (such as 'Emailing diff to foo@example.com').
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
641
            self.pb_stage_name = "Running %s hooks [%s]" % \
2659.3.9 by NamNguyen
branch.py:
642
                (hook_name, Branch.hooks.get_hook_name(hook))
2553.1.2 by Robert Collins
Show hook names during commit.
643
            self._emit_progress()
2560.1.4 by Robert Collins
Allow -Dhooks to get the hooks invoked during commit logged.
644
            if 'hooks' in debug.debug_flags:
645
                mutter("Invoking commit hook: %r", hook)
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
646
            if hook_name == "post_commit":
647
                hook(hook_local, hook_master, old_revno, old_revid, new_revno,
648
                     self.rev_id)
649
            elif hook_name == "pre_commit":
650
                hook(hook_local, hook_master,
651
                     old_revno, old_revid, new_revno, self.rev_id,
2659.3.9 by NamNguyen
branch.py:
652
                     tree_delta, future_tree)
2511.1.1 by Ian Clatworthy
commit.py clean-up including logging just to stderr, not bzr.log
653
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
654
    def _update_builder_with_changes(self):
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
655
        """Update the commit builder with the data about what has changed.
656
        """
4570.4.3 by Robert Collins
Fix a couple of small bugs in the patch - use specific files with record_iter_changs, and the CLI shouldn't generate a filter of [] for commit.
657
        specific_files = self.specific_files
6684.1.3 by Martin
Changes across many modules working towards Python 3 support
658
        mutter("Selecting files for commit with filter %r", specific_files)
2541.1.1 by Ian Clatworthy
Refactor commit.commit() to walk the working inventory once/less
659
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
660
        self._check_strict()
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
661
        iter_changes = self.work_tree.iter_changes(
662
            self.basis_tree, specific_files=specific_files)
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
663
        if self.exclude:
664
            iter_changes = filter_excluded(iter_changes, self.exclude)
665
        iter_changes = self._filter_iter_changes(iter_changes)
7206.6.1 by Jelmer Vernooij
Drop file_id from record_iter_changes return value.
666
        for path, fs_hash in self.builder.record_iter_changes(
7143.16.21 by Jelmer Vernooij
Fix regressions.
667
                self.work_tree, self.basis_revid, iter_changes):
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
668
            self.work_tree._observed_sha1(path, fs_hash)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
669
4354.4.4 by Aaron Bentley
Simplify by using CommitBuilder directly
670
    def _filter_iter_changes(self, iter_changes):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
671
        """Process iter_changes.
672
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
673
        This method reports on the changes in iter_changes to the user, and
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
674
        converts 'missing' entries in the iter_changes iterator to 'deleted'
675
        entries. 'missing' entries have their
676
677
        :param iter_changes: An iter_changes to process.
678
        :return: A generator of changes.
679
        """
680
        reporter = self.reporter
681
        report_changes = reporter.is_verbose()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
682
        deleted_paths = []
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
683
        for change in iter_changes:
684
            if report_changes:
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
685
                old_path = change.path[0]
686
                new_path = change.path[1]
687
                versioned = change.versioned[1]
688
            kind = change.kind[1]
689
            versioned = change.versioned[1]
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
690
            if kind is None and versioned:
691
                # 'missing' path
692
                if report_changes:
693
                    reporter.missing(new_path)
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
694
                if change.kind[0] == 'symlink' and not self.work_tree.supports_symlinks():
7122.6.1 by Jelmer Vernooij
merge Parth's work into Breezy
695
                    trace.warning('Ignoring "%s" as symlinks are not '
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
696
                                  'supported on this filesystem.' % (change.path[0],))
6469.1.4 by Parth Malwankar
commit ignores symlinks on platforms that dont support symlinks
697
                    continue
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
698
                deleted_paths.append(change.path[1])
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
699
                # Reset the new path (None) and new versioned flag (False)
7322.1.7 by Jelmer Vernooij
Fix remaining tests.
700
                change = change.discard_new()
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
701
                new_path = change.path[1]
6125.1.1 by Jelmer Vernooij
Report missing files as removed in 'bzr commit', rather than modified.
702
                versioned = False
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
703
            elif kind == 'tree-reference':
704
                if self.recursive == 'down':
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
705
                    self._commit_nested_tree(change.path[1])
7322.1.6 by Jelmer Vernooij
Use the new attributes on TreeChange.
706
            if change.versioned[0] or change.versioned[1]:
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
707
                yield change
708
                if report_changes:
709
                    if new_path is None:
710
                        reporter.deleted(old_path)
711
                    elif old_path is None:
6138.3.2 by Jonathan Riddell
gettext-ify bzrlib/commit.py
712
                        reporter.snapshot_change(gettext('added'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
713
                    elif old_path != new_path:
7143.15.2 by Jelmer Vernooij
Run autopep8.
714
                        reporter.renamed(gettext('renamed'),
715
                                         old_path, new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
716
                    else:
7143.15.2 by Jelmer Vernooij
Run autopep8.
717
                        if (new_path
718
                                or self.work_tree.branch.repository._format.rich_root_data):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
719
                            # Don't report on changes to '' in non rich root
720
                            # repositories.
7143.15.2 by Jelmer Vernooij
Run autopep8.
721
                            reporter.snapshot_change(
722
                                gettext('modified'), new_path)
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
723
            self._next_progress_entry()
6883.7.3 by Jelmer Vernooij
Avoid Tree.id2path.
724
        # Unversion files that were found to be deleted
725
        self.deleted_paths = deleted_paths
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
726
727
    def _check_strict(self):
728
        # XXX: when we use iter_changes this would likely be faster if
729
        # iter_changes would check for us (even in the presence of
730
        # selected_files).
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
731
        if self.strict:
732
            # raise an exception as soon as we find a single unknown.
733
            for unknown in self.work_tree.unknowns():
734
                raise StrictCommitFailed()
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
735
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
736
    def _commit_nested_tree(self, path):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
737
        "Commit a nested tree."
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
738
        sub_tree = self.work_tree.get_nested_tree(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
739
        # FIXME: be more comprehensive here:
740
        # this works when both trees are in --trees repository,
741
        # but when both are bound to a different repository,
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
742
        # it fails; a better way of approaching this is to
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
743
        # finally implement the explicit-caches approach design
744
        # a while back - RBC 20070306.
2665.5.2 by Aaron Bentley
Switch commit and merge to Repository.has_same_location
745
        if sub_tree.branch.repository.has_same_location(
7143.15.2 by Jelmer Vernooij
Run autopep8.
746
                self.work_tree.branch.repository):
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
747
            sub_tree.branch.repository = \
748
                self.work_tree.branch.repository
749
        try:
2776.4.6 by Robert Collins
Fixup various commit test failures falling out from the other commit changes.
750
            return sub_tree.commit(message=None, revprops=self.revprops,
7143.15.2 by Jelmer Vernooij
Run autopep8.
751
                                   recursive=self.recursive,
752
                                   message_callback=self.message_callback,
7143.15.5 by Jelmer Vernooij
More PEP8 fixes.
753
                                   timestamp=self.timestamp,
754
                                   timezone=self.timezone,
7143.15.2 by Jelmer Vernooij
Run autopep8.
755
                                   committer=self.committer,
756
                                   allow_pointless=self.allow_pointless,
757
                                   strict=self.strict, verbose=self.verbose,
758
                                   local=self.local, reporter=self.reporter)
6744 by Jelmer Vernooij
Merge lp:~jelmer/brz/move-errors-knit.
759
        except PointlessCommit:
7141.7.1 by Jelmer Vernooij
Get rid of file_ids in most of Tree.
760
            return self.work_tree.get_reference_revision(path)
2564.2.1 by Ian Clatworthy
refactor commit to support alternative population meothds
761
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
762
    def _set_progress_stage(self, name, counter=False):
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
763
        """Set the progress stage and emit an update to the progress bar."""
764
        self.pb_stage_name = name
765
        self.pb_stage_count += 1
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
766
        if counter:
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
767
            self.pb_entries_count = 0
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
768
        else:
769
            self.pb_entries_count = None
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
770
        self._emit_progress()
771
2564.2.2 by Ian Clatworthy
incorporate feedback from abentley
772
    def _next_progress_entry(self):
773
        """Emit an update to the progress bar and increment the entry count."""
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
774
        self.pb_entries_count += 1
775
        self._emit_progress()
776
777
    def _emit_progress(self):
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
778
        if self.pb_entries_count is not None:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
779
            text = gettext("{0} [{1}] - Stage").format(self.pb_stage_name,
7143.15.2 by Jelmer Vernooij
Run autopep8.
780
                                                       self.pb_entries_count)
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
781
        else:
6138.4.1 by Jonathan Riddell
add gettext to progress bar strings
782
            text = gettext("%s - Stage") % (self.pb_stage_name, )
2531.1.2 by Ian Clatworthy
Improved progress reporting for commit
783
        self.pb.update(text, self.pb_stage_count, self.pb_stage_total)