/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar
5128.1.1 by Vincent Ladeuil
Uncontroversial cleanups, mostly comments
1
# Copyright (C) 2006-2010 Canonical Ltd
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
2
# Authors:  Robert Collins <robert.collins@canonical.com>
3
#
4
# This program is free software; you can redistribute it and/or modify
5
# it under the terms of the GNU General Public License as published by
6
# the Free Software Foundation; either version 2 of the License, or
7
# (at your option) any later version.
8
#
9
# This program is distributed in the hope that it will be useful,
10
# but WITHOUT ANY WARRANTY; without even the implied warranty of
11
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
12
# GNU General Public License for more details.
13
#
14
# You should have received a copy of the GNU General Public License
15
# along with this program; if not, write to the Free Software
4183.7.1 by Sabin Iacob
update FSF mailing address
16
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
17
18
import os
19
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
20
from breezy import (
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
21
    branch,
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
22
    conflicts,
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
23
    controldir,
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
24
    errors,
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
25
    mutabletree,
2922.2.1 by John Arbash Meinel
Add failing tests exposing part of bug #114615
26
    osutils,
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
27
    revision as _mod_revision,
5777.2.1 by Jelmer Vernooij
Skip commit exclude tests for repositories that don't support excludes.
28
    tests,
6437.70.1 by John Arbash Meinel
Set up the infrastructure to start testing a lightweight checkout of a remote repository.
29
    transport as _mod_transport,
2598.5.2 by Aaron Bentley
Got all tests passing with Branch returning 'null:' for null revision
30
    ui,
31
    )
6734.1.20 by Jelmer Vernooij
Move errors.
32
from breezy.commit import (
33
    CannotCommitSelectedFileMerge,
34
    PointlessCommit,
35
    )
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
36
from breezy.tests.matchers import HasPathRelations
6622.1.34 by Jelmer Vernooij
Rename brzlib => breezy.
37
from breezy.tests.per_workingtree import TestCaseWithWorkingTree
38
from breezy.tests.testui import ProgressRecordingUIFactory
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
39
40
41
class TestCommit(TestCaseWithWorkingTree):
42
2922.2.1 by John Arbash Meinel
Add failing tests exposing part of bug #114615
43
    def test_autodelete_renamed(self):
44
        tree_a = self.make_branch_and_tree('a')
45
        self.build_tree(['a/dir/', 'a/dir/f1', 'a/dir/f2'])
6745.1.1 by Jelmer Vernooij
Avoid explicitly setting file ids or guard it by checking
46
        tree_a.add(['dir', 'dir/f1', 'dir/f2'])
2922.2.1 by John Arbash Meinel
Add failing tests exposing part of bug #114615
47
        rev_id1 = tree_a.commit('init')
48
        # Start off by renaming entries,
49
        # but then actually auto delete the whole tree
50
        # https://bugs.launchpad.net/bzr/+bug/114615
51
        tree_a.rename_one('dir/f1', 'dir/a')
52
        tree_a.rename_one('dir/f2', 'dir/z')
53
        osutils.rmtree('a/dir')
54
        tree_a.commit('autoremoved')
55
7358.14.1 by Jelmer Vernooij
Remove Tree.get_root_id() in favour of Tree.path2id('').
56
        with tree_a.lock_read():
57
            root_id = tree_a.path2id('')
2922.2.1 by John Arbash Meinel
Add failing tests exposing part of bug #114615
58
            paths = [(path, ie.file_id)
59
                     for path, ie in tree_a.iter_entries_by_dir()]
60
        # The only paths left should be the root
61
        self.assertEqual([('', root_id)], paths)
62
2922.2.3 by John Arbash Meinel
Add a test which shows why the previous fix is broken.
63
    def test_no_autodelete_renamed_away(self):
64
        tree_a = self.make_branch_and_tree('a')
65
        self.build_tree(['a/dir/', 'a/dir/f1', 'a/dir/f2', 'a/dir2/'])
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
66
        tree_a.add(['dir', 'dir/f1', 'dir/f2', 'dir2'])
2922.2.3 by John Arbash Meinel
Add a test which shows why the previous fix is broken.
67
        rev_id1 = tree_a.commit('init')
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
68
        revtree = tree_a.branch.repository.revision_tree(rev_id1)
2922.2.3 by John Arbash Meinel
Add a test which shows why the previous fix is broken.
69
        # Rename one entry out of this directory
70
        tree_a.rename_one('dir/f1', 'dir2/a')
71
        osutils.rmtree('a/dir')
72
        tree_a.commit('autoremoved')
73
74
        # The only paths left should be the root
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
75
        self.assertThat(
76
            tree_a, HasPathRelations(
77
                revtree,
78
                [('', ''), ('dir2/', 'dir2/'), ('dir2/a', 'dir/f1')]))
2922.2.3 by John Arbash Meinel
Add a test which shows why the previous fix is broken.
79
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
80
    def test_no_autodelete_alternate_renamed(self):
81
        # Test for bug #114615
82
        tree_a = self.make_branch_and_tree('A')
83
        self.build_tree(['A/a/', 'A/a/m', 'A/a/n'])
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
84
        tree_a.add(['a', 'a/m', 'a/n'])
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
85
        tree_a.commit('init')
86
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
87
        tree_b = tree_a.controldir.sprout('B').open_workingtree()
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
88
        self.build_tree(['B/xyz/'])
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
89
        tree_b.add(['xyz'])
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
90
        tree_b.rename_one('a/m', 'xyz/m')
91
        osutils.rmtree('B/a')
92
        tree_b.commit('delete in B')
93
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
94
        self.assertThat(
7143.15.2 by Jelmer Vernooij
Run autopep8.
95
            tree_b,
96
            HasPathRelations(
97
                tree_a, [('', ''), ('xyz/', None), ('xyz/m', 'a/m')]))
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
98
6855.4.1 by Jelmer Vernooij
Yet more bees.
99
        self.build_tree_contents([('A/a/n', b'new contents for n\n')])
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
100
        tree_a.commit('change n in A')
101
102
        # Merging from A should introduce conflicts because 'n' was modified
5128.1.1 by Vincent Ladeuil
Uncontroversial cleanups, mostly comments
103
        # (in A) and removed (in B), so 'a' needs to be restored.
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
104
        num_conflicts = tree_b.merge_from_branch(tree_a.branch)
7490.129.9 by Jelmer Vernooij
Fix tests.
105
        if tree_b.has_versioned_directories():
106
            self.assertEqual(3, num_conflicts)
107
        else:
108
            self.assertEqual(2, num_conflicts)
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
109
110
        self.assertThat(
7143.15.2 by Jelmer Vernooij
Run autopep8.
111
            tree_b, HasPathRelations(
112
                tree_a,
113
                [('', ''), ('a/', 'a/'), ('xyz/', None),
114
                 ('a/n.OTHER', 'a/n'), ('xyz/m', 'a/m')]))
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
115
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
116
        osutils.rmtree('B/a')
117
        try:
118
            # bzr resolve --all
7490.129.3 by Jelmer Vernooij
Split out bzr-specific Conflicts code.
119
            tree_b.set_conflicts([])
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
120
        except errors.UnsupportedOperation:
121
            # On WT2, set_conflicts is unsupported, but the rmtree has the same
122
            # effect.
123
            pass
124
        tree_b.commit('autoremove a, without touching xyz/m')
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
125
126
        self.assertThat(
7143.15.2 by Jelmer Vernooij
Run autopep8.
127
            tree_b, HasPathRelations(
128
                tree_a,
129
                [('', ''), ('xyz/', None), ('xyz/m', 'a/m')]))
2922.2.4 by John Arbash Meinel
Fix bug #114615 by teaching unversion() to not touch renamed entries.
130
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
131
    def test_commit_exclude_pending_merge_fails(self):
132
        """Excludes are a form of partial commit."""
133
        wt = self.make_branch_and_tree('.')
134
        self.build_tree(['foo'])
135
        wt.add('foo')
136
        wt.commit('commit one')
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
137
        wt2 = wt.controldir.sprout('to').open_workingtree()
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
138
        wt2.commit('change_right')
139
        wt.merge_from_branch(wt2.branch)
6747.1.1 by Jelmer Vernooij
Remove unnecessary ExcludesUnsupported exception.
140
        self.assertRaises(CannotCommitSelectedFileMerge,
7143.15.2 by Jelmer Vernooij
Run autopep8.
141
                          wt.commit, 'test', exclude=['foo'])
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
142
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
143
    def test_commit_exclude_exclude_changed_is_pointless(self):
144
        tree = self.make_branch_and_tree('.')
145
        self.build_tree(['a'])
146
        tree.smart_add(['.'])
147
        tree.commit('setup test')
6855.4.1 by Jelmer Vernooij
Yet more bees.
148
        self.build_tree_contents([('a', b'new contents for "a"\n')])
6747.1.1 by Jelmer Vernooij
Remove unnecessary ExcludesUnsupported exception.
149
        self.assertRaises(PointlessCommit, tree.commit, 'test',
7143.15.2 by Jelmer Vernooij
Run autopep8.
150
                          exclude=['a'], allow_pointless=False)
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
151
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
152
    def test_commit_exclude_excludes_modified_files(self):
153
        tree = self.make_branch_and_tree('.')
154
        self.build_tree(['a', 'b', 'c'])
155
        tree.smart_add(['.'])
6747.1.1 by Jelmer Vernooij
Remove unnecessary ExcludesUnsupported exception.
156
        tree.commit('test', exclude=['b', 'c'])
3602.1.4 by Robert Collins
Andrew's review feedback.
157
        # If b was excluded it will still be 'added' in status.
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
158
        tree.lock_read()
159
        self.addCleanup(tree.unlock)
160
        changes = list(tree.iter_changes(tree.basis_tree()))
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
161
        self.assertEqual([(None, 'b'), (None, 'c')], [c.path for c in changes])
3602.1.1 by Robert Collins
Add support for -x or --exclude to bzr commit, fixing bug 3117. (Robert Collins)
162
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
163
    def test_commit_exclude_subtree_of_selected(self):
164
        tree = self.make_branch_and_tree('.')
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
165
        self.build_tree(['a/', 'a/b', 'a/c'])
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
166
        tree.smart_add(['.'])
6913.5.2 by Jelmer Vernooij
Use HasPathRelations.
167
        tree.commit('test', specific_files=['a', 'a/c'], exclude=['a/b'])
3602.1.4 by Robert Collins
Andrew's review feedback.
168
        # If a/b was excluded it will still be 'added' in status.
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
169
        tree.lock_read()
170
        self.addCleanup(tree.unlock)
171
        changes = list(tree.iter_changes(tree.basis_tree()))
7490.133.26 by Jelmer Vernooij
Some fixes.
172
        self.assertEqual(1, len(changes), changes)
7358.16.1 by Jelmer Vernooij
Don't make TreeChange tuple-like objects anymore, so we can add and remove attributes as necessary.
173
        self.assertEqual((None, 'a/b'), changes[0].path)
3602.1.2 by Robert Collins
Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.
174
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
175
    def test_commit_sets_last_revision(self):
176
        tree = self.make_branch_and_tree('tree')
6747.3.1 by Jelmer Vernooij
Avoid more uses of revision_id.
177
        if tree.branch.repository._format.supports_setting_revision_ids:
6855.4.1 by Jelmer Vernooij
Yet more bees.
178
            committed_id = tree.commit('foo', rev_id=b'foo')
6747.3.1 by Jelmer Vernooij
Avoid more uses of revision_id.
179
            # the commit should have returned the same id we asked for.
7045.1.14 by Jelmer Vernooij
More fixes.
180
            self.assertEqual(b'foo', committed_id)
6747.3.1 by Jelmer Vernooij
Avoid more uses of revision_id.
181
        else:
182
            committed_id = tree.commit('foo')
183
        self.assertEqual([committed_id], tree.get_parent_ids())
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
184
185
    def test_commit_returns_revision_id(self):
186
        tree = self.make_branch_and_tree('.')
2825.5.2 by Robert Collins
Review feedback, and fix pointless commits with nested trees to raise PointlessCommit appropriately.
187
        committed_id = tree.commit('message')
1773.1.1 by Robert Collins
Teach WorkingTree.commit to return the committed revision id.
188
        self.assertTrue(tree.branch.repository.has_revision(committed_id))
189
        self.assertNotEqual(None, committed_id)
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
190
191
    def test_commit_local_unbound(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
192
        # using the library api to do a local commit on unbound branches is
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
193
        # also an error
194
        tree = self.make_branch_and_tree('tree')
195
        self.assertRaises(errors.LocalRequiresBoundBranch,
196
                          tree.commit,
197
                          'foo',
198
                          local=True)
2374.2.1 by John Arbash Meinel
(broken) merge a test case showing that commiting a merge of a kind change fails.
199
200
    def test_commit_merged_kind_change(self):
201
        """Test merging a kind change.
202
203
        Test making a kind change in a working tree, and then merging that
204
        from another. When committed it should commit the new kind.
205
        """
206
        wt = self.make_branch_and_tree('.')
207
        self.build_tree(['a'])
208
        wt.add(['a'])
209
        wt.commit('commit one')
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
210
        wt2 = wt.controldir.sprout('to').open_workingtree()
2374.2.1 by John Arbash Meinel
(broken) merge a test case showing that commiting a merge of a kind change fails.
211
        os.remove('a')
212
        os.mkdir('a')
213
        wt.commit('changed kind')
214
        wt2.merge_from_branch(wt.branch)
215
        wt2.commit('merged kind change')
216
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
217
    def test_commit_aborted_does_not_apply_automatic_changes_bug_282402(self):
218
        wt = self.make_branch_and_tree('.')
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
219
        wt.add(['a'], None, ['file'])
7391.3.1 by Jelmer Vernooij
Use id2path in fewer places.
220
        self.assertTrue(wt.is_versioned('a'))
221
        if wt.supports_setting_file_ids():
222
            a_id = wt.path2id('a')
223
            self.assertEqual('a', wt.id2path(a_id))
7143.15.2 by Jelmer Vernooij
Run autopep8.
224
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
225
        def fail_message(obj):
7490.61.1 by Jelmer Vernooij
Rename BzrCommandError to CommandError.
226
            raise errors.CommandError("empty commit message")
227
        self.assertRaises(errors.CommandError, wt.commit,
7143.15.2 by Jelmer Vernooij
Run autopep8.
228
                          message_callback=fail_message)
7391.3.1 by Jelmer Vernooij
Use id2path in fewer places.
229
        self.assertTrue(wt.is_versioned('a'))
230
        if wt.supports_setting_file_ids():
231
            self.assertEqual('a', wt.id2path(a_id))
4536.3.1 by Robert Collins
Defer doing unversioning of file ids during commit to after completing branch operations. (Robert Collins, bug 282402)
232
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
233
    def test_local_commit_ignores_master(self):
234
        # a --local commit does not require access to the master branch
235
        # at all, or even for it to exist.
236
        # we test this by setting up a bound branch and then corrupting
237
        # the master.
238
        master = self.make_branch('master')
239
        tree = self.make_branch_and_tree('tree')
240
        try:
241
            tree.branch.bind(master)
242
        except errors.UpgradeRequired:
243
            # older format.
244
            return
7027.3.3 by Jelmer Vernooij
Add some more bees; support writing both bytes and unicode strings in build_tree_contents.
245
        master.controldir.transport.put_bytes('branch-format', b'garbage')
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
246
        del master
247
        # check its corrupted.
248
        self.assertRaises(errors.UnknownFormatError,
6472.2.2 by Jelmer Vernooij
Use controldir rather than bzrdir in a couple more places.
249
                          controldir.ControlDir.open,
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
250
                          'master')
6747.3.1 by Jelmer Vernooij
Avoid more uses of revision_id.
251
        tree.commit('foo', local=True)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
252
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
253
    def test_local_commit_does_not_push_to_master(self):
254
        # a --local commit does not require access to the master branch
255
        # at all, or even for it to exist.
256
        # we test that even when its available it does not push to it.
257
        master = self.make_branch('master')
258
        tree = self.make_branch_and_tree('tree')
259
        try:
260
            tree.branch.bind(master)
261
        except errors.UpgradeRequired:
262
            # older format.
263
            return
6747.3.1 by Jelmer Vernooij
Avoid more uses of revision_id.
264
        committed_id = tree.commit('foo', local=True)
265
        self.assertFalse(master.repository.has_revision(committed_id))
2598.5.7 by Aaron Bentley
Updates from review
266
        self.assertEqual(_mod_revision.NULL_REVISION,
267
                         (_mod_revision.ensure_null(master.last_revision())))
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
268
269
    def test_record_initial_ghost(self):
270
        """The working tree needs to record ghosts during commit."""
271
        wt = self.make_branch_and_tree('.')
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
272
        if not wt.branch.repository._format.supports_ghosts:
273
            raise tests.TestNotApplicable(
274
                'format does not support ghosts')
6973.10.6 by Jelmer Vernooij
Fix tests.
275
        wt.set_parent_ids([b'non:existent@rev--ision--0--2'],
7143.15.2 by Jelmer Vernooij
Run autopep8.
276
                          allow_leftmost_as_ghost=True)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
277
        rev_id = wt.commit('commit against a ghost first parent.')
278
        rev = wt.branch.repository.get_revision(rev_id)
6973.10.6 by Jelmer Vernooij
Fix tests.
279
        self.assertEqual(rev.parent_ids, [b'non:existent@rev--ision--0--2'])
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
280
        # parent_sha1s is not populated now, WTF. rbc 20051003
281
        self.assertEqual(len(rev.parent_sha1s), 0)
282
283
    def test_record_two_ghosts(self):
284
        """The working tree should preserve all the parents during commit."""
285
        wt = self.make_branch_and_tree('.')
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
286
        if not wt.branch.repository._format.supports_ghosts:
287
            raise tests.TestNotApplicable(
288
                'format does not support ghosts')
1908.6.7 by Robert Collins
Remove all users of set_pending_merges and add_pending_merge except tests that they work correctly.
289
        wt.set_parent_ids([
7143.15.2 by Jelmer Vernooij
Run autopep8.
290
            b'foo@azkhazan-123123-abcabc',
291
            b'wibble@fofof--20050401--1928390812',
1908.6.7 by Robert Collins
Remove all users of set_pending_merges and add_pending_merge except tests that they work correctly.
292
            ],
293
            allow_leftmost_as_ghost=True)
1927.2.1 by Robert Collins
Alter set_pending_merges to shove the left most merge into the trees last-revision if that is not set. Related bugfixes include basis_tree handling ghosts, de-duping the merges with the last-revision and update changing where and how it adds its pending merge.
294
        rev_id = wt.commit("commit from ghost base with one merge")
295
        # the revision should have been committed with two parents
296
        rev = wt.branch.repository.get_revision(rev_id)
6973.10.6 by Jelmer Vernooij
Fix tests.
297
        self.assertEqual([b'foo@azkhazan-123123-abcabc',
7143.15.2 by Jelmer Vernooij
Run autopep8.
298
                          b'wibble@fofof--20050401--1928390812'],
299
                         rev.parent_ids)
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
300
1988.3.1 by Robert Collins
Add test case to ensure that the working tree inventory and disk state is correctly update when commit is removing directory entries.
301
    def test_commit_deleted_subtree_and_files_updates_workingtree(self):
302
        """The working trees inventory may be adjusted by commit."""
303
        wt = self.make_branch_and_tree('.')
304
        wt.lock_write()
305
        self.build_tree(['a', 'b/', 'b/c', 'd'])
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
306
        wt.add(['a', 'b', 'b/c', 'd'])
307
        a_id = wt.path2id('a')
308
        b_id = wt.path2id('b')
309
        c_id = wt.path2id('b/c')
310
        d_id = wt.path2id('d')
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
311
        this_dir = wt.controldir.root_transport
1988.3.1 by Robert Collins
Add test case to ensure that the working tree inventory and disk state is correctly update when commit is removing directory entries.
312
        this_dir.delete_tree('b')
313
        this_dir.delete('d')
314
        # now we have a tree with a through d in the inventory, but only
315
        # a present on disk. After commit b-id, c-id and d-id should be
316
        # missing from the inventory, within the same tree transaction.
317
        wt.commit('commit stuff')
318
        self.assertTrue(wt.has_filename('a'))
319
        self.assertFalse(wt.has_filename('b'))
320
        self.assertFalse(wt.has_filename('b/c'))
321
        self.assertFalse(wt.has_filename('d'))
322
        wt.unlock()
323
        # the changes should have persisted to disk - reopen the workingtree
324
        # to be sure.
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
325
        wt = wt.controldir.open_workingtree()
7397.4.4 by Jelmer Vernooij
Allow has_id to be unsupported.
326
        with wt.lock_read():
327
            self.assertTrue(wt.has_filename('a'))
328
            self.assertFalse(wt.has_filename('b'))
329
            self.assertFalse(wt.has_filename('b/c'))
330
            self.assertFalse(wt.has_filename('d'))
1731.2.4 by Aaron Bentley
Ensure subsume works with Knit2 repos
331
2363.2.2 by John Arbash Meinel
Simplify the test even further....
332
    def test_commit_deleted_subtree_with_removed(self):
2363.2.1 by John Arbash Meinel
(broken) Add a simplified test which exposes the bug.
333
        wt = self.make_branch_and_tree('.')
334
        self.build_tree(['a', 'b/', 'b/c', 'd'])
6844.1.1 by Jelmer Vernooij
Many more foreign branch fixes.
335
        wt.add(['a', 'b', 'b/c'])
336
        a_id = wt.path2id('a')
337
        b_id = wt.path2id('b')
338
        c_id = wt.path2id('b/c')
2363.2.1 by John Arbash Meinel
(broken) Add a simplified test which exposes the bug.
339
        wt.commit('first')
2363.2.2 by John Arbash Meinel
Simplify the test even further....
340
        wt.remove('b/c')
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
341
        this_dir = wt.controldir.root_transport
2363.2.1 by John Arbash Meinel
(broken) Add a simplified test which exposes the bug.
342
        this_dir.delete_tree('b')
7397.4.4 by Jelmer Vernooij
Allow has_id to be unsupported.
343
        with wt.lock_write():
344
            wt.commit('commit deleted rename')
345
            self.assertTrue(wt.is_versioned('a'))
346
            self.assertTrue(wt.has_filename('a'))
347
            self.assertFalse(wt.has_filename('b'))
348
            self.assertFalse(wt.has_filename('b/c'))
2363.2.1 by John Arbash Meinel
(broken) Add a simplified test which exposes the bug.
349
1731.2.4 by Aaron Bentley
Ensure subsume works with Knit2 repos
350
    def test_commit_move_new(self):
351
        wt = self.make_branch_and_tree('first')
352
        wt.commit('first')
6653.6.1 by Jelmer Vernooij
Rename a number of attributes from bzrdir to controldir.
353
        wt2 = wt.controldir.sprout('second').open_workingtree()
1731.2.4 by Aaron Bentley
Ensure subsume works with Knit2 repos
354
        self.build_tree(['second/name1'])
6745.1.1 by Jelmer Vernooij
Avoid explicitly setting file ids or guard it by checking
355
        wt2.add('name1')
1731.2.4 by Aaron Bentley
Ensure subsume works with Knit2 repos
356
        wt2.commit('second')
357
        wt.merge_from_branch(wt2.branch)
358
        wt.rename_one('name1', 'name2')
359
        wt.commit('third')
6745.1.1 by Jelmer Vernooij
Avoid explicitly setting file ids or guard it by checking
360
        wt.path2id('name1')
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
361
362
    def test_nested_commit(self):
363
        """Commit in multiply-nested trees"""
364
        tree = self.make_branch_and_tree('.')
365
        if not tree.supports_tree_reference():
366
            # inapplicable test.
367
            return
368
        subtree = self.make_branch_and_tree('subtree')
369
        subsubtree = self.make_branch_and_tree('subtree/subtree')
6926.2.8 by Jelmer Vernooij
Fix some more tests.
370
        subsub_revid = subsubtree.commit('subsubtree')
371
        subtree.commit('subtree')
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
372
        subtree.add(['subtree'])
373
        tree.add(['subtree'])
374
        # use allow_pointless=False to ensure that the deepest tree, which
375
        # has no commits made to it, does not get a pointless commit.
376
        rev_id = tree.commit('added reference', allow_pointless=False)
377
        tree.lock_read()
378
        self.addCleanup(tree.unlock)
379
        # the deepest subtree has not changed, so no commit should take place.
6926.2.8 by Jelmer Vernooij
Fix some more tests.
380
        self.assertEqual(subsub_revid, subsubtree.last_revision())
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
381
        # the intermediate tree should have committed a pointer to the current
382
        # subtree revision.
383
        sub_basis = subtree.basis_tree()
384
        sub_basis.lock_read()
385
        self.addCleanup(sub_basis.unlock)
6809.4.1 by Jelmer Vernooij
Swap file_id and path arguments for get_reference_revision and get_nested_tree.
386
        self.assertEqual(
7143.15.2 by Jelmer Vernooij
Run autopep8.
387
            subsubtree.last_revision(),
388
            sub_basis.get_reference_revision('subtree'))
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
389
        # the intermediate tree has changed, so should have had a commit
390
        # take place.
391
        self.assertNotEqual(None, subtree.last_revision())
392
        # the outer tree should have committed a pointer to the current
393
        # subtree revision.
394
        basis = tree.basis_tree()
395
        basis.lock_read()
396
        self.addCleanup(basis.unlock)
397
        self.assertEqual(subtree.last_revision(),
7143.15.2 by Jelmer Vernooij
Run autopep8.
398
                         basis.get_reference_revision('subtree'))
2255.2.218 by Robert Collins
Make the nested tree commit smoke test be more rigourous.
399
        # the outer tree must have have changed too.
400
        self.assertNotEqual(None, rev_id)
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
401
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
402
    def test_nested_commit_second_commit_detects_changes(self):
403
        """Commit with a nested tree picks up the correct child revid."""
404
        tree = self.make_branch_and_tree('.')
405
        if not tree.supports_tree_reference():
406
            # inapplicable test.
407
            return
6700.1.3 by Jelmer Vernooij
Drop support for committing using record_entr_contents.
408
        self.knownFailure('nested trees don\'t work well with iter_changes')
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
409
        subtree = self.make_branch_and_tree('subtree')
410
        tree.add(['subtree'])
411
        self.build_tree(['subtree/file'])
6745.1.1 by Jelmer Vernooij
Avoid explicitly setting file ids or guard it by checking
412
        subtree.add(['file'])
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
413
        rev_id = tree.commit('added reference', allow_pointless=False)
6809.4.1 by Jelmer Vernooij
Swap file_id and path arguments for get_reference_revision and get_nested_tree.
414
        tree.get_reference_revision('subtree')
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
415
        child_revid = subtree.last_revision()
416
        # now change the child tree
6855.4.1 by Jelmer Vernooij
Yet more bees.
417
        self.build_tree_contents([('subtree/file', b'new-content')])
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
418
        # and commit in the parent should commit the child and grab its revid,
419
        # we test with allow_pointless=False here so that we are simulating
420
        # what users will see.
421
        rev_id2 = tree.commit('changed subtree only', allow_pointless=False)
422
        # the child tree has changed, so should have had a commit
423
        # take place.
424
        self.assertNotEqual(None, subtree.last_revision())
425
        self.assertNotEqual(child_revid, subtree.last_revision())
426
        # the outer tree should have committed a pointer to the current
427
        # subtree revision.
428
        basis = tree.basis_tree()
429
        basis.lock_read()
430
        self.addCleanup(basis.unlock)
431
        self.assertEqual(subtree.last_revision(),
7143.15.2 by Jelmer Vernooij
Run autopep8.
432
                         basis.get_reference_revision('subtree'))
2255.2.220 by Robert Collins
Fix failing detection of changes restricted to subtrees causing spurious pointless commit errors.
433
        self.assertNotEqual(rev_id, rev_id2)
434
2825.5.2 by Robert Collins
Review feedback, and fix pointless commits with nested trees to raise PointlessCommit appropriately.
435
    def test_nested_pointless_commits_are_pointless(self):
436
        tree = self.make_branch_and_tree('.')
437
        if not tree.supports_tree_reference():
438
            # inapplicable test.
439
            return
440
        subtree = self.make_branch_and_tree('subtree')
6926.2.8 by Jelmer Vernooij
Fix some more tests.
441
        subtree.commit('')
2825.5.2 by Robert Collins
Review feedback, and fix pointless commits with nested trees to raise PointlessCommit appropriately.
442
        tree.add(['subtree'])
443
        # record the reference.
444
        rev_id = tree.commit('added reference')
445
        child_revid = subtree.last_revision()
446
        # now do a no-op commit with allow_pointless=False
6734.1.20 by Jelmer Vernooij
Move errors.
447
        self.assertRaises(PointlessCommit, tree.commit, '',
7143.15.2 by Jelmer Vernooij
Run autopep8.
448
                          allow_pointless=False)
2825.5.2 by Robert Collins
Review feedback, and fix pointless commits with nested trees to raise PointlessCommit appropriately.
449
        self.assertEqual(child_revid, subtree.last_revision())
450
        self.assertEqual(rev_id, tree.last_revision())
451
1988.3.1 by Robert Collins
Add test case to ensure that the working tree inventory and disk state is correctly update when commit is removing directory entries.
452
1740.3.10 by Jelmer Vernooij
Fix some minor issues pointed out by j-a-m.
453
class TestCommitProgress(TestCaseWithWorkingTree):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
454
4985.2.1 by Vincent Ladeuil
Deploy addAttrCleanup on the whole test suite.
455
    def setUp(self):
456
        super(TestCommitProgress, self).setUp()
5422.1.4 by Martin Pool
Rename CapturingUIFactory to ProgressRecordingUIFactory
457
        ui.ui_factory = ProgressRecordingUIFactory()
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
458
459
    def test_commit_progress_steps(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
460
        # during commit we one progress update for every entry in the
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
461
        # inventory, and then one for the inventory, and one for the
462
        # inventory, and one for the revision insertions.
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
463
        # first we need a test commit to do. Lets setup a branch with
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
464
        # 3 files, and alter one in a selected-file commit. This exercises
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
465
        # a number of cases quickly. We should also test things like
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
466
        # selective commits which excludes newly added files.
467
        tree = self.make_branch_and_tree('.')
468
        self.build_tree(['a', 'b', 'c'])
469
        tree.add(['a', 'b', 'c'])
470
        tree.commit('first post')
6973.7.5 by Jelmer Vernooij
s/file/open.
471
        with open('b', 'wt') as f:
472
            f.write('new content')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
473
        # set a progress bar that captures the calls so we can see what is
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
474
        # emitted
5422.1.4 by Martin Pool
Rename CapturingUIFactory to ProgressRecordingUIFactory
475
        factory = ProgressRecordingUIFactory()
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
476
        ui.ui_factory = factory
477
        # TODO RBC 20060421 it would be nice to merge the reporter output
478
        # into the factory for this test - just make the test ui factory
479
        # pun as a reporter. Then we can check the ordering is right.
480
        tree.commit('second post', specific_files=['b'])
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
481
        # 5 steps, the first of which is reported 2 times, once per dir
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
482
        self.assertEqual(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
483
            [('update', 1, 5, 'Collecting changes [0] - Stage'),
484
             ('update', 1, 5, 'Collecting changes [1] - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
485
             ('update', 2, 5, 'Saving data locally - Stage'),
2659.3.9 by NamNguyen
branch.py:
486
             ('update', 3, 5, 'Running pre_commit hooks - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
487
             ('update', 4, 5, 'Updating the working tree - Stage'),
2659.3.9 by NamNguyen
branch.py:
488
             ('update', 5, 5, 'Running post_commit hooks - Stage')],
1666.1.19 by Robert Collins
Introduce a progress bar during commit.
489
            factory._calls
7143.15.2 by Jelmer Vernooij
Run autopep8.
490
            )
2553.1.2 by Robert Collins
Show hook names during commit.
491
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
492
    def test_commit_progress_shows_post_hook_names(self):
2553.1.2 by Robert Collins
Show hook names during commit.
493
        tree = self.make_branch_and_tree('.')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
494
        # set a progress bar that captures the calls so we can see what is
2553.1.2 by Robert Collins
Show hook names during commit.
495
        # emitted
5422.1.4 by Martin Pool
Rename CapturingUIFactory to ProgressRecordingUIFactory
496
        factory = ProgressRecordingUIFactory()
2553.1.2 by Robert Collins
Show hook names during commit.
497
        ui.ui_factory = factory
7143.15.2 by Jelmer Vernooij
Run autopep8.
498
2553.1.2 by Robert Collins
Show hook names during commit.
499
        def a_hook(_, _2, _3, _4, _5, _6):
500
            pass
3256.2.19 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.workingtree_implementations.test_commit.
501
        branch.Branch.hooks.install_named_hook('post_commit', a_hook,
502
                                               'hook name')
2553.1.2 by Robert Collins
Show hook names during commit.
503
        tree.commit('first post')
504
        self.assertEqual(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
505
            [('update', 1, 5, 'Collecting changes [0] - Stage'),
506
             ('update', 1, 5, 'Collecting changes [1] - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
507
             ('update', 2, 5, 'Saving data locally - Stage'),
2659.3.9 by NamNguyen
branch.py:
508
             ('update', 3, 5, 'Running pre_commit hooks - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
509
             ('update', 4, 5, 'Updating the working tree - Stage'),
2659.3.9 by NamNguyen
branch.py:
510
             ('update', 5, 5, 'Running post_commit hooks - Stage'),
511
             ('update', 5, 5, 'Running post_commit hooks [hook name] - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
512
             ],
513
            factory._calls
7143.15.2 by Jelmer Vernooij
Run autopep8.
514
            )
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
515
516
    def test_commit_progress_shows_pre_hook_names(self):
517
        tree = self.make_branch_and_tree('.')
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
518
        # set a progress bar that captures the calls so we can see what is
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
519
        # emitted
5422.1.4 by Martin Pool
Rename CapturingUIFactory to ProgressRecordingUIFactory
520
        factory = ProgressRecordingUIFactory()
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
521
        ui.ui_factory = factory
7143.15.2 by Jelmer Vernooij
Run autopep8.
522
2659.3.3 by NamNguyen
Changed ``pre_commit`` hook signature.
523
        def a_hook(_, _2, _3, _4, _5, _6, _7, _8):
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
524
            pass
3256.2.19 by Daniel Watkins
Updated uses of Hooks.install_hook to Hooks.install_named_hook in tests.workingtree_implementations.test_commit.
525
        branch.Branch.hooks.install_named_hook('pre_commit', a_hook,
526
                                               'hook name')
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
527
        tree.commit('first post')
528
        self.assertEqual(
4183.5.5 by Robert Collins
Enable record_iter_changes for cases where it can work.
529
            [('update', 1, 5, 'Collecting changes [0] - Stage'),
530
             ('update', 1, 5, 'Collecting changes [1] - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
531
             ('update', 2, 5, 'Saving data locally - Stage'),
2659.3.9 by NamNguyen
branch.py:
532
             ('update', 3, 5, 'Running pre_commit hooks - Stage'),
533
             ('update', 3, 5, 'Running pre_commit hooks [hook name] - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
534
             ('update', 4, 5, 'Updating the working tree - Stage'),
2659.3.9 by NamNguyen
branch.py:
535
             ('update', 5, 5, 'Running post_commit hooks - Stage'),
2659.3.1 by NamNguyen
``Branch.hooks`` now supports ``pre_commit`` hook.
536
             ],
537
            factory._calls
7143.15.2 by Jelmer Vernooij
Run autopep8.
538
            )
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
539
540
    def test_start_commit_hook(self):
3943.8.1 by Marius Kruger
remove all trailing whitespace from bzr source
541
        """Make sure a start commit hook can modify the tree that is
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
542
        committed."""
543
        def start_commit_hook_adds_file(tree):
7143.15.2 by Jelmer Vernooij
Run autopep8.
544
            with open(tree.abspath("newfile"), 'w') as f:
545
                f.write("data")
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
546
            tree.add(["newfile"])
7143.15.2 by Jelmer Vernooij
Run autopep8.
547
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
548
        def restoreDefaults():
549
            mutabletree.MutableTree.hooks['start_commit'] = []
550
        self.addCleanup(restoreDefaults)
551
        tree = self.make_branch_and_tree('.')
3256.2.26 by Daniel Watkins
Updated tests to use install_named_hook.
552
        mutabletree.MutableTree.hooks.install_named_hook(
553
            'start_commit',
554
            start_commit_hook_adds_file,
555
            None)
3335.1.3 by Jelmer Vernooij
Add tests for start_commit hook.
556
        revid = tree.commit('first post')
557
        committed_tree = tree.basis_tree()
558
        self.assertTrue(committed_tree.has_filename("newfile"))
4634.33.1 by Ian Clatworthy
original finish_commit hook patch
559
4634.33.3 by Ian Clatworthy
review feedback from Robert: rename finish_commit to post_commit
560
    def test_post_commit_hook(self):
561
        """Make sure a post_commit hook is called after a commit."""
562
        def post_commit_hook_test_params(params):
4634.33.2 by Ian Clatworthy
review feedback from jam
563
            self.assertTrue(isinstance(params,
7143.15.2 by Jelmer Vernooij
Run autopep8.
564
                                       mutabletree.PostCommitHookParams))
4634.33.2 by Ian Clatworthy
review feedback from jam
565
            self.assertTrue(isinstance(params.mutable_tree,
7143.15.2 by Jelmer Vernooij
Run autopep8.
566
                                       mutabletree.MutableTree))
567
            with open(tree.abspath("newfile"), 'w') as f:
568
                f.write("data")
4634.33.2 by Ian Clatworthy
review feedback from jam
569
            params.mutable_tree.add(["newfile"])
4634.33.1 by Ian Clatworthy
original finish_commit hook patch
570
        tree = self.make_branch_and_tree('.')
571
        mutabletree.MutableTree.hooks.install_named_hook(
4634.33.3 by Ian Clatworthy
review feedback from Robert: rename finish_commit to post_commit
572
            'post_commit',
573
            post_commit_hook_test_params,
4634.33.1 by Ian Clatworthy
original finish_commit hook patch
574
            None)
575
        self.assertFalse(tree.has_filename("newfile"))
576
        revid = tree.commit('first post')
577
        self.assertTrue(tree.has_filename("newfile"))
578
        committed_tree = tree.basis_tree()
579
        self.assertFalse(committed_tree.has_filename("newfile"))