/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

  • Committer: John Arbash Meinel
  • Date: 2009-08-07 03:29:09 UTC
  • Revision ID: john@arbash-meinel.com-20090807032909-9xg0nwcqoxi9763y
Removing the min(keys) and max(keys) calls saves 100ms in the inner loop
(get_ancestry() over all of bzr.dev in a single index is 347ms => 245ms).
The current breakdown is roughly:
0.4789      0.1127   bzrlib.btree_index:1129(get_ancestry)
0.0418      0.0418   +<method 'update' of 'set' objects>
0.0480      0.0325   +bzrlib.btree_index:966(_multi_bisect_right)
0.0274      0.0274   +<method 'difference' of 'set' objects>
0.0081      0.0081   +<method 'add' of 'set' objects>
0.0075      0.0075   +<sorted>
0.0048      0.0004   +bzrlib.btree_index:899(_get_internal_nodes)
0.2275      0.0004   +bzrlib.btree_index:917(_get_leaf_nodes)
0.0002      0.0002   +<method 'extend' of 'list' objects>
0.0009      0.0001   +bzrlib.btree_index:1375(key_count)

So we have a bit of just general overhead (112ms), and then
50ms spent in _multi_bisect_right, which we could move to a C extension.
50ms in set.update and 28ms in set.difference
227ms in reading and parsing the 222 nodes from disk.
It seems a little unfortunate that parsing is the primary overhead,
but previous investigation did not reveal much fat that could be trimmed.

It is 3.8MB of uncompressed data that is being parsed. That's got to
take some amount of time. 200ms might be reasonable.
Which would hint that the only way to speed it up would be:
1) a different format
2) don't read the whole thing, stupid :)
Filename Latest Rev Last Changed Committer Comment Size
..
__init__.py 4523.1.5 16 years ago Vincent Ladeuil Fixed as asked in review. * bzrlib/tests/per_work 14.7 KB Diff Download File
test_annotate_iter.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 2.1 KB Diff Download File
test_get_file_mtime.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 1.6 KB Diff Download File
test_get_file_with_stat.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 1.9 KB Diff Download File
test_get_root_id.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 1.5 KB Diff Download File
test_get_symlink_target.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 2.2 KB Diff Download File
test_inv.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 6.4 KB Diff Download File
test_iter_search_rules.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 3 KB Diff Download File
test_list_files.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 4.4 KB Diff Download File
test_path_content_summary.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 4.8 KB Diff Download File
test_revision_tree.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 1.2 KB Diff Download File
test_test_trees.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 13.8 KB Diff Download File
test_tree.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 10.8 KB Diff Download File
test_walkdirs.py 4523.1.4 16 years ago Martin Pool Rename remaining *_implementations tests 4.4 KB Diff Download File