/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

  • Committer: John Arbash Meinel
  • Date: 2009-12-14 15:52:24 UTC
  • mto: (4634.107.1 2.0)
  • Revision ID: john@arbash-meinel.com-20091214155224-6av92htxukvp69jk
Fix a rare segmentation fault in the groupcompress code.

When finding the location to insert an entry in the hash map,
we start by going to the next hash bucket, and walking backwards
to find the last empty entry.
The last entry in the hash table intentionally points to just
after the actual entry table, so that we have an 'upper bound'.
However, if the last actual bucket was full, this could cause
us to check to see if the 'sentinal' value pointed to NULL,
which isn't valid. If the memory allocator did not allocate
extra bytes after then end of the entry table, this would
access invalid memory and segfault.
The fix is to change the if check to evaluate whether the current
pointer is in the current bucket before we check to see whether
it is empty. (Note that the double check *should* be redundant.)
Filename Latest Rev Last Changed Committer Comment Size
..
__init__.py 4183.7.1 16 years ago Sabin Iacob update FSF mailing address 4.5 KB Diff Download File
branch.py 4556.2.8 16 years ago Andrew Bennetts Add TODO comment. 12.5 KB Diff Download File
bzrdir.py 4436.1.1 16 years ago Andrew Bennetts Rename BzrDirFormat.initialize_ex verb to BzrDirFo 18.2 KB Diff Download File
client.py 4183.7.1 16 years ago Sabin Iacob update FSF mailing address 9.3 KB Diff Download File
medium.py 4634.18.2 16 years ago Martin Pool Further until_no_eintr cover is smart.py 34.8 KB Diff Download File
message.py 4574.1.1 16 years ago Martin Pool Move 'byte part read' messages to -Dhpssdetail 13.4 KB Diff Download File
packrepository.py 4183.7.1 16 years ago Sabin Iacob update FSF mailing address 1.5 KB Diff Download File
protocol.py 4476.3.40 16 years ago Andrew Bennetts Merge bzr.dev. 49.7 KB Diff Download File
repository.py 4634.19.2 16 years ago Robert Collins Review feedback. 31.6 KB Diff Download File
request.py 4634.14.1 16 years ago Robert Collins (robertc) Handle IncompatibleRepositories better w 22.5 KB Diff Download File
server.py 4553.1.1 16 years ago Jonathan Lange Merge 1.17, resolving conflicts. 14.1 KB Diff Download File
vfs.py 4183.7.1 16 years ago Sabin Iacob update FSF mailing address 7 KB Diff Download File