/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

  • Committer: John Arbash Meinel
  • Date: 2009-12-14 15:52:24 UTC
  • mto: (4634.107.1 2.0)
  • Revision ID: john@arbash-meinel.com-20091214155224-6av92htxukvp69jk
Fix a rare segmentation fault in the groupcompress code.

When finding the location to insert an entry in the hash map,
we start by going to the next hash bucket, and walking backwards
to find the last empty entry.
The last entry in the hash table intentionally points to just
after the actual entry table, so that we have an 'upper bound'.
However, if the last actual bucket was full, this could cause
us to check to see if the 'sentinal' value pointed to NULL,
which isn't valid. If the memory allocator did not allocate
extra bytes after then end of the entry table, this would
access invalid memory and segfault.
The fix is to change the if check to evaluate whether the current
pointer is in the current bucket before we check to see whether
it is empty. (Note that the double check *should* be redundant.)
Filename Latest Rev Last Changed Committer Comment Size
..
configobj 1185.12.49 20 years ago Aaron Bentley Switched to ConfigObj Diff
effbot 1185.1.29 20 years ago Robert Collins merge merge tweaks from aaron, which includes late Diff
elementtree 1185.1.29 20 years ago Robert Collins merge merge tweaks from aaron, which includes late Diff
tests 2613.1.2 18 years ago Martin Pool Move bencode tests into util.tests Diff
__init__.py 1185.1.29 20 years ago Robert Collins merge merge tweaks from aaron, which includes late Empty Diff Download File
_bencode_py.py 4360.5.4 16 years ago Robert J. Tanner Merge 1.15.1 back to trunk 4.3 KB Diff Download File
bencode.py 4420.3.1 16 years ago Matt Nordhoff bzrlib.util.bencode's deprecation warning used the 1005 bytes Diff Download File
simplemapi.py 3943.8.1 16 years ago Marius Kruger remove all trailing whitespace from bzr source 8.2 KB Diff Download File