5
This document describes the Breezy internals and the development process.
6
It's meant for people interested in developing Breezy, and some parts will
7
also be useful to people developing Breezy plugins.
9
If you have any questions or something seems to be incorrect, unclear or
10
missing, please talk to us in ``irc://irc.freenode.net/#bzr``, or write to
11
the Breezy mailing list. To propose a correction or addition to this
12
document, send a merge request or new text to the mailing list.
14
The latest developer documentation can be found online at
15
https://www.breezy-vcs.org/developers/.
20
Exploring the Breezy Platform
21
=============================
23
Before making changes, it's a good idea to explore the work already
24
done by others. Perhaps the new feature or improvement you're looking
25
for is available in another plug-in already? If you find a bug,
26
perhaps someone else has already fixed it?
28
To answer these questions and more, take a moment to explore the
29
overall Breezy Platform. Here are some links to browse:
31
* The Plugins page on the Wiki - http://wiki.bazaar.canonical.com/BzrPlugins
33
* The Breezy product family on Launchpad - https://launchpad.net/breezy
35
* Bug Tracker for the core product - https://bugs.launchpad.net/brz/
37
If nothing else, perhaps you'll find inspiration in how other developers
38
have solved their challenges.
40
Finding Something To Do
41
=======================
43
Ad-hoc performance work can also be done. One useful tool is the 'evil' debug
44
flag. For instance running ``brz -Devil commit -m "test"`` will log a backtrace
45
to the Breezy log file for every method call which triggers a slow or non-scalable
46
part of the breezy library. So checking that a given command with ``-Devil`` has
47
no backtraces logged to the log file is a good way to find problem function
48
calls that might be nested deep in the code base.
50
Planning and Discussing Changes
51
===============================
53
There is a very active community around Breezy. Mostly we meet on IRC
54
(#bzr on irc.freenode.net) and on the mailing list. To join the Breezy
55
community, see https://www.breezy-vcs.org/pages/support.html.
57
If you are planning to make a change, it's a very good idea to mention it
58
on the IRC channel and/or on the mailing list. There are many advantages
59
to involving the community before you spend much time on a change.
62
* you get to build on the wisdom of others, saving time
64
* if others can direct you to similar code, it minimises the work to be done
66
* it assists everyone in coordinating direction, priorities and effort.
68
In summary, maximising the input from others typically minimises the
69
total effort required to get your changes merged. The community is
70
friendly, helpful and always keen to welcome newcomers.
73
Breezy Development in a Nutshell
74
================================
76
.. was from http://wiki.bazaar.canonical.com/BzrGivingBack
78
One of the fun things about working on a version control system like Breezy is
79
that the users have a high level of proficiency in contributing back into
80
the tool. Consider the following very brief introduction to contributing back
81
to Breezy. More detailed instructions are in the following sections.
86
First, get a local copy of the development mainline (See `Why make a local
90
$ brz init-shared-repo ~/bzr
92
$ brz branch lp:brz bzr.dev
94
Now make your own branch::
96
$ brz branch bzr.dev 123456-my-bugfix
98
This will give you a branch called "123456-my-bugfix" that you can work on
99
and commit in. Here, you can study the code, make a fix or a new feature.
100
Feel free to commit early and often (after all, it's your branch!).
102
Documentation improvements are an easy place to get started giving back to the
103
Breezy project. The documentation is in the `doc/` subdirectory of the Breezy
106
When you are done, make sure that you commit your last set of changes as well!
107
Once you are happy with your changes, ask for them to be merged, as described
110
Making a Merge Proposal
111
-----------------------
113
The Breezy developers use Launchpad to further enable a truly distributed
114
style of development. Anyone can propose a branch for merging into the Breezy
115
trunk. To start this process, you need to push your branch to Launchpad. To
116
do this, you will need a Launchpad account and user name, e.g.
117
`your_lp_username`. You can push your branch to Launchpad directly from
120
$ brz push lp:~<your_lp_username>/bzr/meaningful_name_here
122
After you have pushed your branch, you will need to propose it for merging to
123
the Breezy trunk. Go to
124
<https://launchpad.net/~<your_lp_username>/bzr/meaningful_name_here> and choose
125
"Propose for merging into another branch". Select "lp:bzr" to hand
126
your changes off to the Breezy developers for review and merging.
128
Alternatively, after pushing you can use the ``propose`` command to
129
create the merge proposal.
131
Using a meaningful name for your branch will help you and the reviewer(s)
132
better track the submission. Use a very succint description of your submission
133
and prefix it with bug number if needed (lp:~mbp/bzr/484558-merge-directory
134
for example). Alternatively, you can suffix with the bug number
135
(lp:~jameinel/bzr/export-file-511987).
141
Please put a "cover letter" on your merge request explaining:
143
* the reason **why** you're making this change
145
* **how** this change achieves this purpose
147
* anything else you may have fixed in passing
149
* anything significant that you thought of doing, such as a more
150
extensive fix or a different approach, but didn't or couldn't do now
152
A good cover letter makes reviewers' lives easier because they can decide
153
from the letter whether they agree with the purpose and approach, and then
154
assess whether the patch actually does what the cover letter says.
155
Explaining any "drive-by fixes" or roads not taken may also avoid queries
156
from the reviewer. All in all this should give faster and better reviews.
157
Sometimes writing the cover letter helps the submitter realize something
158
else they need to do. The size of the cover letter should be proportional
159
to the size and complexity of the patch.
162
Why make a local copy of bzr.dev?
163
---------------------------------
165
Making a local mirror of bzr.dev is not strictly necessary, but it means
167
- You can use that copy of bzr.dev as your main brz executable, and keep it
168
up-to-date using ``brz pull``.
169
- Certain operations are faster, and can be done when offline. For example:
172
- ``brz diff -r ancestor:...``
175
- When it's time to create your next branch, it's more convenient. When you
176
have further contributions to make, you should do them in their own branch::
179
$ brz branch bzr.dev additional_fixes
180
$ cd additional_fixes # hack, hack, hack
184
Understanding the Development Process
185
=====================================
187
The development team follows many practices including:
189
* a public roadmap and planning process in which anyone can participate
191
* time based milestones everyone can work towards and plan around
193
* extensive code review and feedback to contributors
195
* complete and rigorous test coverage on any code contributed
197
* automated validation that all tests still pass before code is merged
198
into the main code branch.
200
The key tools we use to enable these practices are:
202
* Launchpad - https://launchpad.net/
204
* Breezy - https://www.breezy-vcs.org/
206
* Patch Queue Manager - https://launchpad.net/pqm/
208
For further information, see <https://www.breezy-vcs.org/developers/>.
211
Preparing a Sandbox for Making Changes to Breezy
212
================================================
214
Breezy supports many ways of organising your work. See
215
http://wiki.bazaar.canonical.com/SharedRepositoryLayouts for a summary of the
216
popular alternatives.
218
Of course, the best choice for you will depend on numerous factors:
219
the number of changes you may be making, the complexity of the changes, etc.
220
As a starting suggestion though:
222
* create a local copy of the main development branch (bzr.dev) by using
225
brz branch lp:brz bzr.dev
227
* keep your copy of bzr.dev pristine (by not developing in it) and keep
228
it up to date (by using brz pull)
230
* create a new branch off your local bzr.dev copy for each issue
231
(bug or feature) you are working on.
233
This approach makes it easy to go back and make any required changes
234
after a code review. Resubmitting the change is then simple with no
235
risk of accidentally including edits related to other issues you may
236
be working on. After the changes for an issue are accepted and merged,
237
the associated branch can be deleted or archived as you wish.
240
Navigating the Code Base
241
========================
243
.. Was at <http://wiki.bazaar.canonical.com/NewDeveloperIntroduction>
245
Some of the key files in this directory are:
248
The command you run to start Breezy itself. This script is pretty
249
short and just does some checks then jumps into bzrlib.
252
This file covers a brief introduction to Breezy and lists some of its
256
Installs Breezy system-wide or to your home directory. To perform
257
development work on Breezy it is not required to run this file - you
258
can simply run the Breezy command from the top level directory of your
259
development copy. Note: That if you run setup.py this will create a
260
'build' directory in your development branch. There's nothing wrong
261
with this but don't be confused by it. The build process puts a copy
262
of the main code base into this build directory, along with some other
263
files. You don't need to go in here for anything discussed in this
267
Possibly the most exciting folder of all, bzrlib holds the main code
268
base. This is where you will go to edit python files and contribute to
272
Holds documentation on a whole range of things on Breezy from the
273
origination of ideas within the project to information on Breezy
274
features and use cases. Within this directory there is a subdirectory
275
for each translation into a human language. All the documentation
276
is in the ReStructuredText markup language.
279
Documentation specifically targeted at Breezy and plugin developers.
280
(Including this document.)
282
doc/en/release-notes/
284
Detailed changes in each Breezy release (there is one file by series:
285
bzr-2.3.txt, bzr-2.4.txt, etc) that can affect users or plugin
290
High-level summaries of changes in each Breezy release (there is one
291
file by series: whats-new-in-2.3.txt, whats-new-in-2.4.txt, etc).
294
Automatically-generated API reference information is available at
295
<https://www.breezy-vcs.org/developers/api/>.
297
See also the `Breezy Architectural Overview
298
<https://www.breezy-vcs.org/developers/overview.html>`_.
307
We don't change APIs in stable branches: any supported symbol in a stable
308
release of Breezy must not be altered in any way that would result in
1
============================
2
Guidelines for modifying bzr
3
============================
7
(The current version of this document is available in the file ``HACKING``
8
in the source tree, or at http://bazaar-ng.org/hacking.html)
13
* New functionality should have test cases. Preferably write the
14
test before writing the code.
16
In general, you can test at either the command-line level or the
17
internal API level. Choose whichever is appropriate: if adding a
18
new command, or a new command option, then call through run_bzr().
19
It is not necessary to do both. Tests that test the command line level
20
are appropriate for checking the UI behaves well - bug fixes and
21
core improvements should be tested closer to the code that is doing the
22
work. Command line level tests should be placed in 'blackbox.py'.
24
* Try to practice Test-Driven Development. before fixing a bug, write a
25
test case so that it does not regress. Similarly for adding a new
26
feature: write a test case for a small version of the new feature before
27
starting on the code itself. Check the test fails on the old code, then
28
add the feature or fix and check it passes.
30
* Exceptions should be defined inside bzrlib.errors, so that we can
31
see the whole tree at a glance.
33
* Imports should be done at the top-level of the file, unless there is
34
a strong reason to have them lazily loaded when a particular
35
function runs. Import statements have a cost, so try to make sure
36
they don't run inside hot functions.
38
* Module names should always be given fully-qualified,
39
i.e. ``bzrlib.hashcache`` not just ``hashcache``.
41
* Commands should return non-zero when they encounter circumstances that
42
the user should really pay attention to - which includes trivial shell
45
Recommended values are
47
1- Conflicts in merge-like operations, or changes are present in
49
2- Unrepresentable diff changes (i.e. binary files that we cannot show
51
3- An error or exception has occurred.
56
We have a commitment to 6 months API stability - any supported symbol in a
57
release of bzr MUST NOT be altered in any way that would result in
309
58
breaking existing code that uses it. That means that method names,
310
59
parameter ordering, parameter names, variable and attribute names etc must
311
60
not be changed without leaving a 'deprecated forwarder' behind. This even
312
61
applies to modules and classes.
314
63
If you wish to change the behaviour of a supported API in an incompatible
315
way, you need to change its name as well. For instance, if I add an optional keyword
64
way, you need to change its name as well. For instance, if I add a optional keyword
316
65
parameter to branch.commit - that's fine. On the other hand, if I add a
317
66
keyword parameter to branch.commit which is a *required* transaction
318
object, I should rename the API - i.e. to 'branch.commit_transaction'.
320
(Actually, that may break code that provides a new implementation of
321
``commit`` and doesn't expect to receive the parameter.)
67
object, I should rename the API - i.e. to 'branch.commit_transaction'.
323
69
When renaming such supported API's, be sure to leave a deprecated_method (or
324
70
_function or ...) behind which forwards to the new API. See the
325
71
bzrlib.symbol_versioning module for decorators that take care of the
326
72
details for you - such as updating the docstring, and issuing a warning
327
when the old API is used.
73
when the old api is used.
329
For unsupported API's, it does not hurt to follow this discipline, but it's
75
For unsupported API's, it does not hurt to follow this discipline, but its
330
76
not required. Minimally though, please try to rename things so that
331
77
callers will at least get an AttributeError rather than weird results.
334
Deprecation decorators
335
----------------------
337
``bzrlib.symbol_versioning`` provides decorators that can be attached to
338
methods, functions, and other interfaces to indicate that they should no
339
longer be used. For example::
341
@deprecated_method(deprecated_in((0, 1, 4)))
343
return self._new_foo()
345
To deprecate a static method you must call ``deprecated_function``
346
(**not** method), after the staticmethod call::
349
@deprecated_function(deprecated_in((0, 1, 4)))
350
def create_repository(base, shared=False, format=None):
352
When you deprecate an API, you should not just delete its tests, because
353
then we might introduce bugs in them. If the API is still present at all,
354
it should still work. The basic approach is to use
355
``TestCase.applyDeprecated`` which in one step checks that the API gives
356
the expected deprecation message, and also returns the real result from
357
the method, so that tests can keep running.
359
Deprecation warnings will be suppressed for final releases, but not for
360
development versions or release candidates, or when running ``bzr
361
selftest``. This gives developers information about whether their code is
362
using deprecated functions, but avoids confusing users about things they
375
Breezy has a few facilities to help debug problems by going into pdb_, the
378
.. _pdb: http://docs.python.org/lib/debugger-commands.html
380
If the ``BZR_PDB`` environment variable is set
381
then brz will go into pdb post-mortem mode when an unhandled exception
384
If you send a SIGQUIT or SIGBREAK signal to brz then it will drop into the
385
debugger immediately. SIGQUIT can be generated by pressing Ctrl-\\ on
386
Unix. SIGBREAK is generated with Ctrl-Pause on Windows (some laptops have
387
this as Fn-Pause). You can continue execution by typing ``c``. This can
388
be disabled if necessary by setting the environment variable
389
``BZR_SIGQUIT_PDB=0``.
391
All tests inheriting from bzrlib.tests.TestCase can use ``self.debug()``
392
instead of the longer ``import pdb; pdb.set_trace()``. The former also works
393
when ``stdin/stdout`` are redirected (by using the original ``stdin/stdout``
394
file handles at the start of the ``bzr`` script) while the later doesn't.
395
``bzrlib.debug.set_trace()`` also uses the original ``stdin/stdout`` file
401
Breezy accepts some global options starting with ``-D`` such as
402
``-Dhpss``. These set a value in `bzrlib.debug.debug_flags`, and
403
typically cause more information to be written to the trace file. Most
404
`mutter` calls should be guarded by a check of those flags so that we
405
don't write out too much information if it's not needed.
407
Debug flags may have effects other than just emitting trace messages.
409
Run ``brz help global-options`` to see them all.
411
These flags may also be set as a comma-separated list in the
412
``debug_flags`` option in e.g. ``~/.config/breezy/breezy.conf``. (Note
413
that it must be in this global file, not in the branch or location
414
configuration, because it's currently only loaded at startup time.) For
415
instance you may want to always record hpss traces and to see full error
418
debug_flags = hpss, error
80
Standard parameter types
81
------------------------
83
There are some common requirements in the library: some parameters need to be
84
unicode safe, some need byte strings, and so on. At the moment we have
85
only codified one specific pattern: Parameters that need to be unicode
86
should be check via 'bzrlib.osutils.safe_unicode'. This will coerce the
87
input into unicode in a consistent fashion, allowing trivial strings to be
88
used for programmer convenience, but not performing unpredictably in the
89
presence of different locales.
94
If you change the behaviour of a command, please update its docstring
95
in bzrlib/commands.py. This is displayed by the 'bzr help' command.
100
If you make a user-visible change, please add a note to the NEWS file.
101
The description should be written to make sense to someone who's just
102
a user of bzr, not a developer: new functions or classes shouldn't be
103
mentioned, but new commands, changes in behaviour or fixed nontrivial
104
bugs should be listed. See the existing entries for an idea of what
107
Within each release, entries in the news file should have the most
108
user-visible changes first. So the order should be approximately:
110
* changes to existing behaviour - the highest priority because the
111
user's existing knowledge is incorrect
112
* new features - should be brought to their attention
113
* bug fixes - may be of interest if the bug was affecting them, and
114
should include the bug number if any
115
* major documentation changes
116
* changes to internal interfaces
118
People who made significant contributions to each change are listed in
119
parenthesis. This can include reporting bugs (particularly with good
120
details or reproduction recipes), submitting patches, etc.
125
Functions, methods, classes and modules should have docstrings
126
describing how they are used.
128
The first line of the docstring should be a self-contained sentence.
130
For the special case of Command classes, this acts as the user-visible
131
documentation shown by the help command.
133
The docstrings should be formatted as reStructuredText_ (like this
134
document), suitable for processing using the epydoc_ tool into HTML
137
.. _reStructuredText: http://docutils.sourceforge.net/rst.html
138
.. _epydoc: http://epydoc.sourceforge.net/
145
Please write PEP-8__ compliant code.
147
One often-missed requirement is that the first line of docstrings
148
should be a self-contained one-sentence summary.
150
__ http://www.python.org/peps/pep-0008.html
157
Functions, methods or members that are in some sense "private" are given
158
a leading underscore prefix. This is just a hint that code outside the
159
implementation should probably not use that interface.
161
We prefer class names to be concatenated capital words (``TestCase``)
162
and variables, methods and functions to be lowercase words joined by
163
underscores (``revision_id``, ``get_revision``).
165
For the purposes of naming some names are treated as single compound
166
words: "filename", "revno".
168
Consider naming classes as nouns and functions/methods as verbs.
174
``revision_id`` not ``rev_id`` or ``revid``
176
Functions that transform one thing to another should be named ``x_to_y``
177
(not ``x2y`` as occurs in some old code.)
183
Python destructors (``__del__``) work differently to those of other
184
languages. In particular, bear in mind that destructors may be called
185
immediately when the object apparently becomes unreferenced, or at some
186
later time, or possibly never at all. Therefore we have restrictions on
187
what can be done inside them.
189
0. Never use a __del__ method without asking Martin/Robert first.
191
1. Never rely on a ``__del__`` method running. If there is code that
192
must run, do it from a ``finally`` block instead.
194
2. Never ``import`` from inside a ``__del__`` method, or you may crash the
197
3. In some places we raise a warning from the destructor if the object
198
has not been cleaned up or closed. This is considered OK: the warning
199
may not catch every case but it's still useful sometimes.
205
(The strategy described here is what we want to get to, but it's not
206
consistently followed in the code at the moment.)
208
bzrlib is intended to be a generically reusable library. It shouldn't
209
write messages to stdout or stderr, because some programs that use it
210
might want to display that information through a GUI or some other
213
We can distinguish two types of output from the library:
215
1. Structured data representing the progress or result of an
216
operation. For example, for a commit command this will be a list
217
of the modified files and the finally committed revision number
220
These should be exposed either through the return code or by calls
221
to a callback parameter.
223
A special case of this is progress indicators for long-lived
224
operations, where the caller should pass a ProgressBar object.
226
2. Unstructured log/debug messages, mostly for the benefit of the
227
developers or users trying to debug problems. This should always
228
be sent through ``bzrlib.trace`` and Python ``logging``, so that
229
it can be redirected by the client.
231
The distinction between the two is a bit subjective, but in general if
232
there is any chance that a library would want to see something as
233
structured data, we should make it so.
235
The policy about how output is presented in the text-mode client
236
should be only in the command-line tool.
241
In general tests should be placed in a file named testFOO.py where
242
FOO is the logical thing under test. That file should be placed in the
243
tests subdirectory under the package being tested.
245
For example, tests for merge3 in bzrlib belong in bzrlib/tests/testmerge3.py.
246
See bzrlib/selftest/testsampler.py for a template test script.
251
Currently, bzr selftest is used to invoke tests.
252
You can provide a pattern argument to run a subset. For example,
253
to run just the whitebox tests, run::
255
bzr selftest -v whitebox
258
Errors and exceptions
259
=====================
261
Errors are handled through Python exceptions. They can represent user
262
errors, environmental errors or program bugs. Sometimes we can't be sure
263
at the time it's raised which case applies. See bzrlib/errors.py for
264
details on the error-handling practices.
427
273
indexes into the branch's revision history.
430
Unicode and Encoding Support
431
============================
433
This section discusses various techniques that Breezy uses to handle
434
characters that are outside the ASCII set.
439
When a ``Command`` object is created, it is given a member variable
440
accessible by ``self.outf``. This is a file-like object, which is bound to
441
``sys.stdout``, and should be used to write information to the screen,
442
rather than directly writing to ``sys.stdout`` or calling ``print``.
443
This file has the ability to translate Unicode objects into the correct
444
representation, based on the console encoding. Also, the class attribute
445
``encoding_type`` will effect how unprintable characters will be
446
handled. This parameter can take one of 3 values:
449
Unprintable characters will be represented with a suitable replacement
450
marker (typically '?'), and no exception will be raised. This is for
451
any command which generates text for the user to review, rather than
452
for automated processing.
453
For example: ``brz log`` should not fail if one of the entries has text
454
that cannot be displayed.
457
Attempting to print an unprintable character will cause a UnicodeError.
458
This is for commands that are intended more as scripting support, rather
459
than plain user review.
460
For example: ``brz ls`` is designed to be used with shell scripting. One
461
use would be ``brz ls --null --unknowns | xargs -0 rm``. If ``bzr``
462
printed a filename with a '?', the wrong file could be deleted. (At the
463
very least, the correct file would not be deleted). An error is used to
464
indicate that the requested action could not be performed.
467
Do not attempt to automatically convert Unicode strings. This is used
468
for commands that must handle conversion themselves.
469
For example: ``brz diff`` needs to translate Unicode paths, but should
470
not change the exact text of the contents of the files.
473
``bzrlib.urlutils.unescape_for_display``
474
----------------------------------------
476
Because Transports work in URLs (as defined earlier), printing the raw URL
477
to the user is usually less than optimal. Characters outside the standard
478
set are printed as escapes, rather than the real character, and local
479
paths would be printed as ``file://`` URLs. The function
480
``unescape_for_display`` attempts to unescape a URL, such that anything
481
that cannot be printed in the current encoding stays an escaped URL, but
482
valid characters are generated where possible.
488
We write some extensions in C using Cython. We design these to work in
491
* User with no C compiler
492
* User with C compiler
495
The recommended way to install Breezy is to have a C compiler so that the
496
extensions can be built, but if no C compiler is present, the pure python
497
versions we supply will work, though more slowly.
499
For developers we recommend that Cython be installed, so that the C
500
extensions can be changed if needed.
502
For the C extensions, the extension module should always match the
503
original python one in all respects (modulo speed). This should be
504
maintained over time.
506
To create an extension, add rules to setup.py for building it with Cython ,
507
and with distutils. Now start with an empty .pyx file. At the top add
508
"include 'yourmodule.py'". This will import the contents of foo.py into this
509
file at build time - remember that only one module will be loaded at
510
runtime. Now you can subclass classes, or replace functions, and only your
511
changes need to be present in the .pyx file.
513
Making Installers for OS Windows
514
================================
515
To build a win32 installer, see the instructions on the wiki page:
516
http://wiki.bazaar.canonical.com/BzrWin32Installer
524
What is a Core Developer?
525
-------------------------
527
While everyone in the Breezy community is welcome and encouraged to
528
propose and submit changes, a smaller team is reponsible for pulling those
529
changes together into a cohesive whole. In addition to the general developer
530
stuff covered above, "core" developers have responsibility for:
534
* managing releases (see `Releasing Breezy <https://www.breezy-vcs.org/developers/releasing.html>`_)
537
Removing barriers to community participation is a key reason for adopting
538
distributed VCS technology. While DVCS removes many technical barriers,
539
a small number of social barriers are often necessary instead.
540
By documenting how the above things are done, we hope to
541
encourage more people to participate in these activities, keeping the
542
differences between core and non-core contributors to a minimum.
545
Communicating and Coordinating
546
------------------------------
548
While it has many advantages, one of the challenges of distributed
549
development is keeping everyone else aware of what you're working on.
550
There are numerous ways to do this:
552
#. Assign bugs to yourself in Launchpad
553
#. Mention it on the mailing list
556
As well as the email notifcations that occur when merge requests are sent
557
and reviewed, you can keep others informed of where you're spending your
558
energy by emailing the **bazaar-commits** list implicitly. To do this,
559
install and configure the Email plugin. One way to do this is add these
560
configuration settings to your central configuration file (e.g.
561
``~/.config/breezy/breezy.conf``)::
564
email = Joe Smith <joe.smith@internode.on.net>
565
smtp_server = mail.internode.on.net:25
567
Then add these lines for the relevant branches in ``locations.conf``::
569
post_commit_to = bazaar-commits@lists.canonical.com
570
post_commit_mailer = smtplib
572
While attending a sprint, RobertCollins' Dbus plugin is useful for the
573
same reason. See the documentation within the plugin for information on
574
how to set it up and configure it.
585
Keeping on top of bugs reported is an important part of ongoing release
586
planning. Everyone in the community is welcome and encouraged to raise
587
bugs, confirm bugs raised by others, and nominate a priority. Practically
588
though, a good percentage of bug triage is often done by the core
589
developers, partially because of their depth of product knowledge.
591
With respect to bug triage, core developers are encouraged to play an
592
active role with particular attention to the following tasks:
594
* keeping the number of unconfirmed bugs low
595
* ensuring the priorities are generally right (everything as critical - or
596
medium - is meaningless)
597
* looking out for regressions and turning those around sooner rather than later.
600
As well as prioritizing bugs and nominating them against a
601
target milestone, Launchpad lets core developers offer to mentor others in
279
If you'd like to propose a change, please post to the
280
bazaar-ng@lists.canonical.com list with a patch, bzr changeset, or link to a
281
branch. Please put '[patch]' in the subject so we can pick them out, and
282
include some text explaining the change. Remember to put an update to the NEWS
283
file in your diff, if it makes any changes visible to users or plugin
284
developers. Please include a diff against mainline if you're giving a link to
287
Please indicate if you think the code is ready to merge, or if it's just a
288
draft or for discussion. If you want comments from many developers rather than
289
to be merged, you can put '[rfc]' in the subject lines.
291
Anyone is welcome to review code. There are broadly three gates for
294
* Doesn't reduce test coverage: if it adds new methods or commands,
295
there should be tests for them. There is a good test framework
296
and plenty of examples to crib from, but if you are having trouble
297
working out how to test something feel free to post a draft patch
300
* Doesn't reduce design clarity, such as by entangling objects
301
we're trying to separate. This is mostly something the more
302
experienced reviewers need to help check.
304
* Improves bugs, features, speed, or code simplicity.
306
Code that goes in should pass all three.
308
If you read a patch please reply and say so. We can use a numeric scale
309
of -1, -0, +0, +1, meaning respectively "really don't want it in current
310
form", "somewhat uncomfortable", "ok with me", and "please put it in".
311
Anyone can "vote". (It's not really voting, just a terse expression.)
313
If something gets say two +1 votes from core reviewers, and no
314
vetos, then it's OK to come in. Any of the core developers can bring it
315
into their integration branch, which I'll merge regularly. (If you do
316
so, please reply and say so.)
added
removed
HACKING
