46
56
# merges from, then it should still be reported as newly added
47
57
# relative to the basis revision.
49
# TODO: Change the parameter 'rev_id' to 'revision_id' to be consistent with
50
# the rest of the code; add a deprecation of the old name.
59
# TODO: Do checks that the tree can be committed *before* running the
60
# editor; this should include checks for a pointless commit and for
61
# unknown or missing files.
63
# TODO: If commit fails, leave the message in a file somewhere.
72
from binascii import hexlify
57
73
from cStringIO import StringIO
67
from bzrlib.branch import Branch
68
from bzrlib.cleanup import OperationWithCleanups
75
from bzrlib.atomicfile import AtomicFile
76
from bzrlib.osutils import (local_time_offset,
77
rand_bytes, compact_date,
78
kind_marker, is_inside_any, quotefn,
79
sha_file, isdir, isfile,
69
81
import bzrlib.config
82
import bzrlib.errors as errors
70
83
from bzrlib.errors import (BzrError, PointlessCommit,
74
from bzrlib.osutils import (get_user_encoding,
75
kind_marker, isdir,isfile, is_inside_any,
76
is_inside_or_parent_of_any,
77
minimum_path_selection,
78
quotefn, sha_file, split_lines,
88
from bzrlib.revision import Revision
81
89
from bzrlib.testament import Testament
82
from bzrlib.trace import mutter, note, warning, is_quiet
83
from bzrlib.inventory import Inventory, InventoryEntry, make_entry
84
from bzrlib import symbol_versioning
85
from bzrlib.symbol_versioning import (deprecated_passed,
90
from bzrlib.trace import mutter, note, warning
91
from bzrlib.xml5 import serializer_v5
92
from bzrlib.inventory import Inventory, ROOT_ID
93
from bzrlib.symbol_versioning import *
88
94
from bzrlib.workingtree import WorkingTree
89
from bzrlib.urlutils import unescape_for_display
97
@deprecated_function(zero_seven)
98
def commit(*args, **kwargs):
99
"""Commit a new revision to a branch.
101
Function-style interface for convenience of old callers.
103
New code should use the Commit class instead.
105
## XXX: Remove this in favor of Branch.commit?
106
Commit().commit(*args, **kwargs)
93
109
class NullCommitReporter(object):
94
110
"""I report on progress of a commit."""
96
def started(self, revno, revid, location=None):
98
symbol_versioning.warn("As of bzr 1.0 you must pass a location "
99
"to started.", DeprecationWarning,
103
112
def snapshot_change(self, change, path):
106
115
def completed(self, revno, rev_id):
109
def deleted(self, path):
118
def deleted(self, file_id):
121
def escaped(self, escape_count, message):
112
124
def missing(self, path):
115
def renamed(self, change, old_path, new_path):
118
def is_verbose(self):
122
128
class ReportCommitToLog(NullCommitReporter):
124
def _note(self, format, *args):
127
Subclasses may choose to override this method.
131
130
def snapshot_change(self, change, path):
132
if path == '' and change in ('added', 'modified'):
131
if change == 'unchanged':
134
self._note("%s %s", change, path)
136
def started(self, revno, rev_id, location=None):
137
if location is not None:
138
location = ' to: ' + unescape_for_display(location, 'utf-8')
140
# When started was added, location was only made optional by
141
# accident. Matt Nordhoff 20071129
142
symbol_versioning.warn("As of bzr 1.0 you must pass a location "
143
"to started.", DeprecationWarning,
146
self._note('Committing%s', location)
133
note("%s %s", change, path)
148
135
def completed(self, revno, rev_id):
149
self._note('Committed revision %d.', revno)
150
# self._note goes to the console too; so while we want to log the
151
# rev_id, we can't trivially only log it. (See bug 526425). Long
152
# term we should rearrange the reporting structure, but for now
153
# we just mutter seperately. We mutter the revid and revno together
154
# so that concurrent bzr invocations won't lead to confusion.
155
mutter('Committed revid %s as revno %d.', rev_id, revno)
136
note('Committed revision %d.', revno)
138
def deleted(self, file_id):
139
note('deleted %s', file_id)
157
def deleted(self, path):
158
self._note('deleted %s', path)
141
def escaped(self, escape_count, message):
142
note("replaced %d control characters in message", escape_count)
160
144
def missing(self, path):
161
self._note('missing %s', path)
163
def renamed(self, change, old_path, new_path):
164
self._note('%s %s => %s', change, old_path, new_path)
166
def is_verbose(self):
145
note('missing %s', path)
170
148
class Commit(object):
203
183
working_tree=None,
207
message_callback=None,
210
possible_master_transports=None):
211
187
"""Commit working copy as a new revision.
213
:param message: the commit message (it or message_callback is required)
214
:param message_callback: A callback: message = message_callback(cmt_obj)
216
:param timestamp: if not None, seconds-since-epoch for a
217
postdated/predated commit.
219
:param specific_files: If not None, commit only those files. An empty
220
list means 'commit no files'.
222
:param rev_id: If set, use this as the new revision id.
189
branch -- the deprecated branch to commit to. New callers should pass in
192
message -- the commit message, a mandatory parameter
194
timestamp -- if not None, seconds-since-epoch for a
195
postdated/predated commit.
197
specific_files -- If true, commit only those files.
199
rev_id -- If set, use this as the new revision id.
223
200
Useful for test or import commands that need to tightly
224
201
control what revisions are assigned. If you duplicate
225
202
a revision id that exists elsewhere it is your own fault.
226
203
If null (default), a time/random revision id is generated.
228
:param allow_pointless: If true (default), commit even if nothing
205
allow_pointless -- If true (default), commit even if nothing
229
206
has changed and no merges are recorded.
231
:param strict: If true, don't allow a commit if the working tree
208
strict -- If true, don't allow a commit if the working tree
232
209
contains unknown files.
234
:param revprops: Properties for new revision
211
revprops -- Properties for new revision
235
212
:param local: Perform a local only commit.
236
:param reporter: the reporter to use or None for the default
237
:param verbose: if True and the reporter is not None, report everything
238
:param recursive: If set to 'down', commit in any subtrees that have
239
pending changes of any sort during this commit.
240
:param exclude: None or a list of relative paths to exclude from the
241
commit. Pending changes to excluded files will be ignored by the
244
operation = OperationWithCleanups(self._commit)
245
self.revprops = revprops or {}
246
# XXX: Can be set on __init__ or passed in - this is a bit ugly.
247
self.config = config or self.config
248
return operation.run(
253
specific_files=specific_files,
255
allow_pointless=allow_pointless,
258
working_tree=working_tree,
261
message_callback=message_callback,
264
possible_master_transports=possible_master_transports)
266
def _commit(self, operation, message, timestamp, timezone, committer,
267
specific_files, rev_id, allow_pointless, strict, verbose,
268
working_tree, local, reporter, message_callback, recursive,
269
exclude, possible_master_transports):
270
214
mutter('preparing to commit')
272
if working_tree is None:
273
raise BzrError("working_tree must be passed into commit().")
216
if deprecated_passed(branch):
217
warn("Commit.commit (branch, ...): The branch parameter is "
218
"deprecated as of bzr 0.8. Please use working_tree= instead.",
219
DeprecationWarning, stacklevel=2)
221
self.work_tree = self.branch.bzrdir.open_workingtree()
222
elif working_tree is None:
223
raise BzrError("One of branch and working_tree must be passed into commit().")
275
225
self.work_tree = working_tree
276
226
self.branch = self.work_tree.branch
277
if getattr(self.work_tree, 'requires_rich_root', lambda: False)():
278
if not self.branch.repository.supports_rich_root():
279
raise errors.RootNotRich()
280
if message_callback is None:
281
if message is not None:
282
if isinstance(message, str):
283
message = message.decode(get_user_encoding())
284
message_callback = lambda x: message
286
raise BzrError("The message or message_callback keyword"
287
" parameter is required for commit().")
228
raise BzrError("The message keyword parameter is required for commit().")
230
self.weave_store = self.branch.repository.weave_store
289
231
self.bound_branch = None
290
self.any_entries_deleted = False
291
if exclude is not None:
292
self.exclude = sorted(
293
minimum_path_selection(exclude))
296
232
self.local = local
297
233
self.master_branch = None
298
self.recursive = recursive
300
# self.specific_files is None to indicate no filter, or any iterable to
301
# indicate a filter - [] means no files at all, as per iter_changes.
302
if specific_files is not None:
303
self.specific_files = sorted(
304
minimum_path_selection(specific_files))
306
self.specific_files = None
234
self.master_locked = False
236
self.specific_files = specific_files
308
237
self.allow_pointless = allow_pointless
309
self.message_callback = message_callback
310
self.timestamp = timestamp
311
self.timezone = timezone
312
self.committer = committer
314
self.verbose = verbose
239
if revprops is not None:
240
self.revprops.update(revprops)
242
if reporter is None and self.reporter is None:
243
self.reporter = NullCommitReporter()
244
elif reporter is not None:
245
self.reporter = reporter
316
247
self.work_tree.lock_write()
317
operation.add_cleanup(self.work_tree.unlock)
318
self.parents = self.work_tree.get_parent_ids()
319
# We can use record_iter_changes IFF iter_changes is compatible with
320
# the command line parameters, and the repository has fast delta
321
# generation. See bug 347649.
322
self.use_record_iter_changes = (
324
not self.branch.repository._format.supports_tree_reference and
325
(self.branch.repository._format.fast_deltas or
326
len(self.parents) < 2))
327
self.pb = bzrlib.ui.ui_factory.nested_progress_bar()
328
operation.add_cleanup(self.pb.finished)
329
self.basis_revid = self.work_tree.last_revision()
330
self.basis_tree = self.work_tree.basis_tree()
331
self.basis_tree.lock_read()
332
operation.add_cleanup(self.basis_tree.unlock)
333
# Cannot commit with conflicts present.
334
if len(self.work_tree.conflicts()) > 0:
335
raise ConflictsInTree
337
# Setup the bound branch variables as needed.
338
self._check_bound_branch(operation, possible_master_transports)
340
# Check that the working tree is up to date
341
old_revno, new_revno = self._check_out_of_date_tree()
343
# Complete configuration setup
344
if reporter is not None:
345
self.reporter = reporter
346
elif self.reporter is None:
347
self.reporter = self._select_reporter()
348
if self.config is None:
349
self.config = self.branch.get_config()
351
self._set_specific_file_ids()
353
# Setup the progress bar. As the number of files that need to be
354
# committed in unknown, progress is reported as stages.
355
# We keep track of entries separately though and include that
356
# information in the progress bar during the relevant stages.
357
self.pb_stage_name = ""
358
self.pb_stage_count = 0
359
self.pb_stage_total = 5
360
if self.bound_branch:
361
self.pb_stage_total += 1
362
self.pb.show_pct = False
363
self.pb.show_spinner = False
364
self.pb.show_eta = False
365
self.pb.show_count = True
366
self.pb.show_bar = True
368
self._gather_parents()
369
# After a merge, a selected file commit is not supported.
370
# See 'bzr help merge' for an explanation as to why.
371
if len(self.parents) > 1 and self.specific_files is not None:
372
raise errors.CannotCommitSelectedFileMerge(self.specific_files)
373
# Excludes are a form of selected file commit.
374
if len(self.parents) > 1 and self.exclude:
375
raise errors.CannotCommitSelectedFileMerge(self.exclude)
377
# Collect the changes
378
self._set_progress_stage("Collecting changes", counter=True)
379
self.builder = self.branch.get_commit_builder(self.parents,
380
self.config, timestamp, timezone, committer, self.revprops, rev_id)
383
self.builder.will_record_deletes()
384
# find the location being committed to
249
# setup the bound branch variables as needed.
250
self._check_bound_branch()
252
# check for out of date working trees
253
# if we are bound, then self.branch is the master branch and this
254
# test is thus all we need.
255
if self.work_tree.last_revision() != self.master_branch.last_revision():
256
raise errors.OutOfDateTree(self.work_tree)
259
# raise an exception as soon as we find a single unknown.
260
for unknown in self.work_tree.unknowns():
261
raise StrictCommitFailed()
263
if timestamp is None:
264
self.timestamp = time.time()
266
self.timestamp = long(timestamp)
268
if self.config is None:
269
self.config = bzrlib.config.BranchConfig(self.branch)
272
self.rev_id = _gen_revision_id(self.config, self.timestamp)
276
if committer is None:
277
self.committer = self.config.username()
279
assert isinstance(committer, basestring), type(committer)
280
self.committer = committer
283
self.timezone = local_time_offset()
285
self.timezone = int(timezone)
287
if isinstance(message, str):
288
message = message.decode(bzrlib.user_encoding)
289
assert isinstance(message, unicode), type(message)
290
self.message = message
291
self._escape_commit_message()
293
self.work_inv = self.work_tree.inventory
294
self.basis_tree = self.work_tree.basis_tree()
295
self.basis_inv = self.basis_tree.inventory
297
self._gather_parents()
298
if len(self.parents) > 1 and self.specific_files:
299
raise NotImplementedError('selected-file commit of merges is not supported yet: files %r',
301
self._check_parents_present()
303
self._remove_deleted()
304
self._populate_new_inv()
305
self._store_snapshot()
306
self._report_deletes()
308
if not (self.allow_pointless
309
or len(self.parents) > 1
310
or self.new_inv != self.basis_inv):
311
raise PointlessCommit()
313
if len(self.work_tree.conflicts())>0:
314
raise ConflictsInTree
316
self.inv_sha1 = self.branch.repository.add_inventory(
321
self._make_revision()
322
# revision data is in the local branch now.
324
# upload revision data to the master.
325
# this will propogate merged revisions too if needed.
385
326
if self.bound_branch:
386
master_location = self.master_branch.base
388
master_location = self.branch.base
390
# report the start of the commit
391
self.reporter.started(new_revno, self.rev_id, master_location)
393
self._update_builder_with_changes()
394
self._check_pointless()
396
# TODO: Now the new inventory is known, check for conflicts.
397
# ADHB 2006-08-08: If this is done, populate_new_inv should not add
398
# weave lines, because nothing should be recorded until it is known
399
# that commit will succeed.
400
self._set_progress_stage("Saving data locally")
401
self.builder.finish_inventory()
403
# Prompt the user for a commit message if none provided
404
message = message_callback(self)
405
self.message = message
407
# Add revision data to the local branch
408
self.rev_id = self.builder.commit(self.message)
411
mutter("aborting commit write group because of exception:")
412
trace.log_exception_quietly()
413
note("aborting commit write group: %r" % (e,))
417
self._process_pre_hooks(old_revno, new_revno)
419
# Upload revision data to the master.
420
# this will propagate merged revisions too if needed.
421
if self.bound_branch:
422
self._set_progress_stage("Uploading data to master branch")
423
# 'commit' to the master first so a timeout here causes the
424
# local branch to be out of date
425
self.master_branch.import_last_revision_info(
426
self.branch.repository, new_revno, self.rev_id)
428
# and now do the commit locally.
429
self.branch.set_last_revision_info(new_revno, self.rev_id)
431
# Make the working tree be up to date with the branch. This
432
# includes automatic changes scheduled to be made to the tree, such
433
# as updating its basis and unversioning paths that were missing.
434
self.work_tree.unversion(self.deleted_ids)
435
self._set_progress_stage("Updating the working tree")
436
self.work_tree.update_basis_by_delta(self.rev_id,
437
self.builder.get_basis_delta())
438
self.reporter.completed(new_revno, self.rev_id)
439
self._process_post_hooks(old_revno, new_revno)
442
def _select_reporter(self):
443
"""Select the CommitReporter to use."""
445
return NullCommitReporter()
446
return ReportCommitToLog()
448
def _check_pointless(self):
449
if self.allow_pointless:
451
# A merge with no effect on files
452
if len(self.parents) > 1:
454
# TODO: we could simplify this by using self.builder.basis_delta.
456
# The initial commit adds a root directory, but this in itself is not
457
# a worthwhile commit.
458
if (self.basis_revid == revision.NULL_REVISION and
459
((self.builder.new_inventory is not None and
460
len(self.builder.new_inventory) == 1) or
461
len(self.builder._basis_delta) == 1)):
462
raise PointlessCommit()
463
if self.builder.any_changes():
465
raise PointlessCommit()
467
def _check_bound_branch(self, operation, possible_master_transports=None):
327
self.master_branch.repository.fetch(self.branch.repository,
328
revision_id=self.rev_id)
329
# now the master has the revision data
330
# 'commit' to the master first so a timeout here causes the local
331
# branch to be out of date
332
self.master_branch.append_revision(self.rev_id)
334
# and now do the commit locally.
335
self.branch.append_revision(self.rev_id)
337
self.work_tree.set_pending_merges([])
338
self.work_tree.set_last_revision(self.rev_id)
339
# now the work tree is up to date with the branch
341
self.reporter.completed(self.branch.revno(), self.rev_id)
342
if self.config.post_commit() is not None:
343
hooks = self.config.post_commit().split(' ')
344
# this would be nicer with twisted.python.reflect.namedAny
346
result = eval(hook + '(branch, rev_id)',
347
{'branch':self.branch,
349
'rev_id':self.rev_id})
351
self._cleanup_bound_branch()
352
self.work_tree.unlock()
354
def _check_bound_branch(self):
468
355
"""Check to see if the local branch is bound.
470
357
If it is bound, then most of the commit will actually be
505
391
# so grab the lock
506
392
self.bound_branch = self.branch
507
393
self.master_branch.lock_write()
508
operation.add_cleanup(self.master_branch.unlock)
510
def _check_out_of_date_tree(self):
511
"""Check that the working tree is up to date.
513
:return: old_revision_number,new_revision_number tuple
394
self.master_locked = True
396
#### # Check to see if we have any pending merges. If we do
397
#### # those need to be pushed into the master branch
398
#### pending_merges = self.work_tree.pending_merges()
399
#### if pending_merges:
400
#### for revision_id in pending_merges:
401
#### self.master_branch.repository.fetch(self.bound_branch.repository,
402
#### revision_id=revision_id)
404
def _cleanup_bound_branch(self):
405
"""Executed at the end of a try/finally to cleanup a bound branch.
407
If the branch wasn't bound, this is a no-op.
408
If it was, it resents self.branch to the local branch, instead
516
first_tree_parent = self.work_tree.get_parent_ids()[0]
518
# if there are no parents, treat our parent as 'None'
519
# this is so that we still consider the master branch
520
# - in a checkout scenario the tree may have no
521
# parents but the branch may do.
522
first_tree_parent = bzrlib.revision.NULL_REVISION
523
old_revno, master_last = self.master_branch.last_revision_info()
524
if master_last != first_tree_parent:
525
if master_last != bzrlib.revision.NULL_REVISION:
526
raise errors.OutOfDateTree(self.work_tree)
527
if self.branch.repository.has_revision(first_tree_parent):
528
new_revno = old_revno + 1
530
# ghost parents never appear in revision history.
532
return old_revno,new_revno
534
def _process_pre_hooks(self, old_revno, new_revno):
535
"""Process any registered pre commit hooks."""
536
self._set_progress_stage("Running pre_commit hooks")
537
self._process_hooks("pre_commit", old_revno, new_revno)
539
def _process_post_hooks(self, old_revno, new_revno):
540
"""Process any registered post commit hooks."""
541
# Process the post commit hooks, if any
542
self._set_progress_stage("Running post_commit hooks")
543
# old style commit hooks - should be deprecated ? (obsoleted in
545
if self.config.post_commit() is not None:
546
hooks = self.config.post_commit().split(' ')
547
# this would be nicer with twisted.python.reflect.namedAny
549
result = eval(hook + '(branch, rev_id)',
550
{'branch':self.branch,
552
'rev_id':self.rev_id})
553
# process new style post commit hooks
554
self._process_hooks("post_commit", old_revno, new_revno)
556
def _process_hooks(self, hook_name, old_revno, new_revno):
557
if not Branch.hooks[hook_name]:
560
# new style commit hooks:
561
411
if not self.bound_branch:
562
hook_master = self.branch
565
hook_master = self.master_branch
566
hook_local = self.branch
567
# With bound branches, when the master is behind the local branch,
568
# the 'old_revno' and old_revid values here are incorrect.
569
# XXX: FIXME ^. RBC 20060206
571
old_revid = self.parents[0]
573
old_revid = bzrlib.revision.NULL_REVISION
575
if hook_name == "pre_commit":
576
future_tree = self.builder.revision_tree()
577
tree_delta = future_tree.changes_from(self.basis_tree,
580
for hook in Branch.hooks[hook_name]:
581
# show the running hook in the progress bar. As hooks may
582
# end up doing nothing (e.g. because they are not configured by
583
# the user) this is still showing progress, not showing overall
584
# actions - its up to each plugin to show a UI if it want's to
585
# (such as 'Emailing diff to foo@example.com').
586
self.pb_stage_name = "Running %s hooks [%s]" % \
587
(hook_name, Branch.hooks.get_hook_name(hook))
588
self._emit_progress()
589
if 'hooks' in debug.debug_flags:
590
mutter("Invoking commit hook: %r", hook)
591
if hook_name == "post_commit":
592
hook(hook_local, hook_master, old_revno, old_revid, new_revno,
594
elif hook_name == "pre_commit":
595
hook(hook_local, hook_master,
596
old_revno, old_revid, new_revno, self.rev_id,
597
tree_delta, future_tree)
413
if self.master_locked:
414
self.master_branch.unlock()
416
def _escape_commit_message(self):
417
"""Replace xml-incompatible control characters."""
418
# FIXME: RBC 20060419 this should be done by the revision
419
# serialiser not by commit. Then we can also add an unescaper
420
# in the deserializer and start roundtripping revision messages
421
# precisely. See repository_implementations/test_repository.py
423
# Python strings can include characters that can't be
424
# represented in well-formed XML; escape characters that
425
# aren't listed in the XML specification
426
# (http://www.w3.org/TR/REC-xml/#NT-Char).
427
self.message, escape_count = re.subn(
428
u'[^\x09\x0A\x0D\u0020-\uD7FF\uE000-\uFFFD]+',
429
lambda match: match.group(0).encode('unicode_escape'),
432
self.reporter.escaped(escape_count, self.message)
599
434
def _gather_parents(self):
600
435
"""Record the parents of a merge for merge detection."""
601
# TODO: Make sure that this list doesn't contain duplicate
602
# entries and the order is preserved when doing this.
603
if self.use_record_iter_changes:
605
self.basis_inv = self.basis_tree.inventory
606
self.parent_invs = [self.basis_inv]
607
for revision in self.parents[1:]:
436
pending_merges = self.work_tree.pending_merges()
438
self.parent_invs = []
439
self.present_parents = []
440
precursor_id = self.branch.last_revision()
442
self.parents.append(precursor_id)
443
self.parents += pending_merges
444
for revision in self.parents:
608
445
if self.branch.repository.has_revision(revision):
609
mutter('commit parent revision {%s}', revision)
610
446
inventory = self.branch.repository.get_inventory(revision)
611
447
self.parent_invs.append(inventory)
613
mutter('commit parent ghost revision {%s}', revision)
615
def _update_builder_with_changes(self):
616
"""Update the commit builder with the data about what has changed.
618
exclude = self.exclude
619
specific_files = self.specific_files
620
mutter("Selecting files for commit with filter %s", specific_files)
623
if self.use_record_iter_changes:
624
iter_changes = self.work_tree.iter_changes(self.basis_tree,
625
specific_files=specific_files)
626
iter_changes = self._filter_iter_changes(iter_changes)
627
for file_id, path, fs_hash in self.builder.record_iter_changes(
628
self.work_tree, self.basis_revid, iter_changes):
629
self.work_tree._observed_sha1(file_id, path, fs_hash)
631
# Build the new inventory
632
self._populate_from_inventory()
633
self._record_unselected()
634
self._report_and_accumulate_deletes()
636
def _filter_iter_changes(self, iter_changes):
637
"""Process iter_changes.
639
This method reports on the changes in iter_changes to the user, and
640
converts 'missing' entries in the iter_changes iterator to 'deleted'
641
entries. 'missing' entries have their
643
:param iter_changes: An iter_changes to process.
644
:return: A generator of changes.
646
reporter = self.reporter
647
report_changes = reporter.is_verbose()
448
self.present_parents.append(revision)
450
def _check_parents_present(self):
451
for parent_id in self.parents:
452
mutter('commit parent revision {%s}', parent_id)
453
if not self.branch.repository.has_revision(parent_id):
454
if parent_id == self.branch.last_revision():
455
warning("parent is missing %r", parent_id)
456
raise HistoryMissing(self.branch, 'revision', parent_id)
458
mutter("commit will ghost revision %r", parent_id)
460
def _make_revision(self):
461
"""Record a new revision object for this commit."""
462
rev = Revision(timestamp=self.timestamp,
463
timezone=self.timezone,
464
committer=self.committer,
465
message=self.message,
466
inventory_sha1=self.inv_sha1,
467
revision_id=self.rev_id,
468
properties=self.revprops)
469
rev.parent_ids = self.parents
470
self.branch.repository.add_revision(self.rev_id, rev, self.new_inv, self.config)
472
def _remove_deleted(self):
473
"""Remove deleted files from the working inventories.
475
This is done prior to taking the working inventory as the
476
basis for the new committed inventory.
478
This returns true if any files
479
*that existed in the basis inventory* were deleted.
480
Files that were added and deleted
481
in the working copy don't matter.
483
specific = self.specific_files
649
for change in iter_changes:
651
old_path = change[1][0]
652
new_path = change[1][1]
653
versioned = change[3][1]
655
versioned = change[3][1]
656
if kind is None and versioned:
659
reporter.missing(new_path)
660
deleted_ids.append(change[0])
661
# Reset the new path (None) and new versioned flag (False)
662
change = (change[0], (change[1][0], None), change[2],
663
(change[3][0], False)) + change[4:]
664
elif kind == 'tree-reference':
665
if self.recursive == 'down':
666
self._commit_nested_tree(change[0], change[1][1])
667
if change[3][0] or change[3][1]:
671
reporter.deleted(old_path)
672
elif old_path is None:
673
reporter.snapshot_change('added', new_path)
674
elif old_path != new_path:
675
reporter.renamed('renamed', old_path, new_path)
678
self.work_tree.branch.repository._format.rich_root_data):
679
# Don't report on changes to '' in non rich root
681
reporter.snapshot_change('modified', new_path)
682
self._next_progress_entry()
683
# Unversion IDs that were found to be deleted
684
self.deleted_ids = deleted_ids
686
def _record_unselected(self):
687
# If specific files are selected, then all un-selected files must be
688
# recorded in their previous state. For more details, see
689
# https://lists.ubuntu.com/archives/bazaar/2007q3/028476.html.
690
if self.specific_files or self.exclude:
691
specific_files = self.specific_files or []
692
for path, old_ie in self.basis_inv.iter_entries():
693
if old_ie.file_id in self.builder.new_inventory:
694
# already added - skip.
696
if (is_inside_any(specific_files, path)
697
and not is_inside_any(self.exclude, path)):
698
# was inside the selected path, and not excluded - if not
699
# present it has been deleted so skip.
701
# From here down it was either not selected, or was excluded:
702
# We preserve the entry unaltered.
704
# Note: specific file commits after a merge are currently
705
# prohibited. This test is for sanity/safety in case it's
706
# required after that changes.
707
if len(self.parents) > 1:
709
self.builder.record_entry_contents(ie, self.parent_invs, path,
710
self.basis_tree, None)
712
def _report_and_accumulate_deletes(self):
713
if (isinstance(self.basis_inv, Inventory)
714
and isinstance(self.builder.new_inventory, Inventory)):
715
# the older Inventory classes provide a _byid dict, and building a
716
# set from the keys of this dict is substantially faster than even
717
# getting a set of ids from the inventory
719
# <lifeless> set(dict) is roughly the same speed as
720
# set(iter(dict)) and both are significantly slower than
722
deleted_ids = set(self.basis_inv._byid.keys()) - \
723
set(self.builder.new_inventory._byid.keys())
725
deleted_ids = set(self.basis_inv) - set(self.builder.new_inventory)
485
for path, ie in self.work_inv.iter_entries():
486
if specific and not is_inside_any(specific, path):
488
if not self.work_tree.has_filename(path):
489
self.reporter.missing(path)
490
deleted_ids.append((path, ie.file_id))
727
self.any_entries_deleted = True
728
deleted = [(self.basis_tree.id2path(file_id), file_id)
729
for file_id in deleted_ids]
731
# XXX: this is not quite directory-order sorting
732
for path, file_id in deleted:
733
self.builder.record_delete(path, file_id)
734
self.reporter.deleted(path)
736
def _check_strict(self):
737
# XXX: when we use iter_changes this would likely be faster if
738
# iter_changes would check for us (even in the presence of
741
# raise an exception as soon as we find a single unknown.
742
for unknown in self.work_tree.unknowns():
743
raise StrictCommitFailed()
745
def _populate_from_inventory(self):
746
"""Populate the CommitBuilder by walking the working tree inventory."""
747
# Build the revision inventory.
749
# This starts by creating a new empty inventory. Depending on
750
# which files are selected for commit, and what is present in the
751
# current tree, the new inventory is populated. inventory entries
752
# which are candidates for modification have their revision set to
753
# None; inventory entries that are carried over untouched have their
754
# revision set to their prior value.
756
# ESEPARATIONOFCONCERNS: this function is diffing and using the diff
757
# results to create a new inventory at the same time, which results
758
# in bugs like #46635. Any reason not to use/enhance Tree.changes_from?
761
specific_files = self.specific_files
762
exclude = self.exclude
763
report_changes = self.reporter.is_verbose()
765
# A tree of paths that have been deleted. E.g. if foo/bar has been
766
# deleted, then we have {'foo':{'bar':{}}}
768
# XXX: Note that entries may have the wrong kind because the entry does
769
# not reflect the status on disk.
770
work_inv = self.work_tree.inventory
771
# NB: entries will include entries within the excluded ids/paths
772
# because iter_entries_by_dir has no 'exclude' facility today.
773
entries = work_inv.iter_entries_by_dir(
774
specific_file_ids=self.specific_file_ids, yield_parents=True)
775
for path, existing_ie in entries:
776
file_id = existing_ie.file_id
777
name = existing_ie.name
778
parent_id = existing_ie.parent_id
779
kind = existing_ie.kind
780
# Skip files that have been deleted from the working tree.
781
# The deleted path ids are also recorded so they can be explicitly
784
path_segments = splitpath(path)
785
deleted_dict = deleted_paths
786
for segment in path_segments:
787
deleted_dict = deleted_dict.get(segment, None)
789
# We either took a path not present in the dict
790
# (deleted_dict was None), or we've reached an empty
791
# child dir in the dict, so are now a sub-path.
795
if deleted_dict is not None:
796
# the path has a deleted parent, do not add it.
798
if exclude and is_inside_any(exclude, path):
799
# Skip excluded paths. Excluded paths are processed by
800
# _update_builder_with_changes.
802
content_summary = self.work_tree.path_content_summary(path)
803
kind = content_summary[0]
804
# Note that when a filter of specific files is given, we must only
805
# skip/record deleted files matching that filter.
806
if not specific_files or is_inside_any(specific_files, path):
807
if kind == 'missing':
808
if not deleted_paths:
809
# path won't have been split yet.
810
path_segments = splitpath(path)
811
deleted_dict = deleted_paths
812
for segment in path_segments:
813
deleted_dict = deleted_dict.setdefault(segment, {})
814
self.reporter.missing(path)
815
self._next_progress_entry()
816
deleted_ids.append(file_id)
818
# TODO: have the builder do the nested commit just-in-time IF and
820
if kind == 'tree-reference':
821
# enforce repository nested tree policy.
822
if (not self.work_tree.supports_tree_reference() or
823
# repository does not support it either.
824
not self.branch.repository._format.supports_tree_reference):
826
content_summary = (kind, None, None, None)
827
elif self.recursive == 'down':
828
nested_revision_id = self._commit_nested_tree(
830
content_summary = (kind, None, None, nested_revision_id)
832
nested_revision_id = self.work_tree.get_reference_revision(file_id)
833
content_summary = (kind, None, None, nested_revision_id)
835
# Record an entry for this item
836
# Note: I don't particularly want to have the existing_ie
837
# parameter but the test suite currently (28-Jun-07) breaks
838
# without it thanks to a unicode normalisation issue. :-(
839
definitely_changed = kind != existing_ie.kind
840
self._record_entry(path, file_id, specific_files, kind, name,
841
parent_id, definitely_changed, existing_ie, report_changes,
844
# Unversion IDs that were found to be deleted
845
self.deleted_ids = deleted_ids
847
def _commit_nested_tree(self, file_id, path):
848
"Commit a nested tree."
849
sub_tree = self.work_tree.get_nested_tree(file_id, path)
850
# FIXME: be more comprehensive here:
851
# this works when both trees are in --trees repository,
852
# but when both are bound to a different repository,
853
# it fails; a better way of approaching this is to
854
# finally implement the explicit-caches approach design
855
# a while back - RBC 20070306.
856
if sub_tree.branch.repository.has_same_location(
857
self.work_tree.branch.repository):
858
sub_tree.branch.repository = \
859
self.work_tree.branch.repository
861
return sub_tree.commit(message=None, revprops=self.revprops,
862
recursive=self.recursive,
863
message_callback=self.message_callback,
864
timestamp=self.timestamp, timezone=self.timezone,
865
committer=self.committer,
866
allow_pointless=self.allow_pointless,
867
strict=self.strict, verbose=self.verbose,
868
local=self.local, reporter=self.reporter)
869
except errors.PointlessCommit:
870
return self.work_tree.get_reference_revision(file_id)
872
def _record_entry(self, path, file_id, specific_files, kind, name,
873
parent_id, definitely_changed, existing_ie, report_changes,
875
"Record the new inventory entry for a path if any."
876
# mutter('check %s {%s}', path, file_id)
877
# mutter('%s selected for commit', path)
878
if definitely_changed or existing_ie is None:
879
ie = make_entry(kind, name, parent_id, file_id)
881
ie = existing_ie.copy()
883
# For carried over entries we don't care about the fs hash - the repo
884
# isn't generating a sha, so we're not saving computation time.
885
_, _, fs_hash = self.builder.record_entry_contents(
886
ie, self.parent_invs, path, self.work_tree, content_summary)
888
self._report_change(ie, path)
890
self.work_tree._observed_sha1(ie.file_id, path, fs_hash)
492
deleted_ids.sort(reverse=True)
493
for path, file_id in deleted_ids:
494
del self.work_inv[file_id]
495
self.work_tree._write_inventory(self.work_inv)
497
def _store_snapshot(self):
498
"""Pass over inventory and record a snapshot.
500
Entries get a new revision when they are modified in
501
any way, which includes a merge with a new set of
502
parents that have the same entry.
504
# XXX: Need to think more here about when the user has
505
# made a specific decision on a particular value -- c.f.
507
for path, ie in self.new_inv.iter_entries():
508
previous_entries = ie.find_previous_heads(
511
self.branch.repository.get_transaction())
512
if ie.revision is None:
513
change = ie.snapshot(self.rev_id, path, previous_entries,
514
self.work_tree, self.weave_store,
515
self.branch.repository.get_transaction())
518
self.reporter.snapshot_change(change, path)
520
def _populate_new_inv(self):
521
"""Build revision inventory.
523
This creates a new empty inventory. Depending on
524
which files are selected for commit, and what is present in the
525
current tree, the new inventory is populated. inventory entries
526
which are candidates for modification have their revision set to
527
None; inventory entries that are carried over untouched have their
528
revision set to their prior value.
530
mutter("Selecting files for commit with filter %s", self.specific_files)
531
self.new_inv = Inventory(revision_id=self.rev_id)
532
for path, new_ie in self.work_inv.iter_entries():
533
file_id = new_ie.file_id
534
mutter('check %s {%s}', path, new_ie.file_id)
535
if self.specific_files:
536
if not is_inside_any(self.specific_files, path):
537
mutter('%s not selected for commit', path)
538
self._carry_entry(file_id)
541
# this is selected, ensure its parents are too.
542
parent_id = new_ie.parent_id
543
while parent_id != ROOT_ID:
544
if not self.new_inv.has_id(parent_id):
545
ie = self._select_entry(self.work_inv[parent_id])
546
mutter('%s selected for commit because of %s',
547
self.new_inv.id2path(parent_id), path)
549
ie = self.new_inv[parent_id]
550
if ie.revision is not None:
552
mutter('%s selected for commit because of %s',
553
self.new_inv.id2path(parent_id), path)
554
parent_id = ie.parent_id
555
mutter('%s selected for commit', path)
556
self._select_entry(new_ie)
558
def _select_entry(self, new_ie):
559
"""Make new_ie be considered for committing."""
893
def _report_change(self, ie, path):
894
"""Report a change to the user.
896
The change that has occurred is described relative to the basis
899
if (self.basis_inv.has_id(ie.file_id)):
900
basis_ie = self.basis_inv[ie.file_id]
903
change = ie.describe_change(basis_ie, ie)
904
if change in (InventoryEntry.RENAMED,
905
InventoryEntry.MODIFIED_AND_RENAMED):
906
old_path = self.basis_inv.id2path(ie.file_id)
907
self.reporter.renamed(change, old_path, path)
908
self._next_progress_entry()
910
if change == 'unchanged':
912
self.reporter.snapshot_change(change, path)
913
self._next_progress_entry()
915
def _set_progress_stage(self, name, counter=False):
916
"""Set the progress stage and emit an update to the progress bar."""
917
self.pb_stage_name = name
918
self.pb_stage_count += 1
920
self.pb_entries_count = 0
922
self.pb_entries_count = None
923
self._emit_progress()
925
def _next_progress_entry(self):
926
"""Emit an update to the progress bar and increment the entry count."""
927
self.pb_entries_count += 1
928
self._emit_progress()
930
def _emit_progress(self):
931
if self.pb_entries_count is not None:
932
text = "%s [%d] - Stage" % (self.pb_stage_name,
933
self.pb_entries_count)
935
text = "%s - Stage" % (self.pb_stage_name, )
936
self.pb.update(text, self.pb_stage_count, self.pb_stage_total)
938
def _set_specific_file_ids(self):
939
"""populate self.specific_file_ids if we will use it."""
940
if not self.use_record_iter_changes:
941
# If provided, ensure the specified files are versioned
942
if self.specific_files is not None:
943
# Note: This routine is being called because it raises
944
# PathNotVersionedError as a side effect of finding the IDs. We
945
# later use the ids we found as input to the working tree
946
# inventory iterator, so we only consider those ids rather than
947
# examining the whole tree again.
948
# XXX: Dont we have filter_unversioned to do this more
950
self.specific_file_ids = tree.find_ids_across_trees(
951
self.specific_files, [self.basis_tree, self.work_tree])
953
self.specific_file_ids = None
565
def _carry_entry(self, file_id):
566
"""Carry the file unchanged from the basis revision."""
567
if self.basis_inv.has_id(file_id):
568
self.new_inv.add(self.basis_inv[file_id].copy())
570
def _report_deletes(self):
571
for file_id in self.basis_inv:
572
if file_id not in self.new_inv:
573
self.reporter.deleted(self.basis_inv.id2path(file_id))
575
def _gen_revision_id(config, when):
576
"""Return new revision-id."""
577
s = '%s-%s-' % (config.user_email(), compact_date(when))
578
s += hexlify(rand_bytes(8))
added
removed
bzrlib/commit.py
