13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
17
17
from StringIO import StringIO
20
from bzrlib.branch import Branch
21
import bzrlib.errors as errors
25
22
from bzrlib.errors import BzrBadParameterNotString, NoSuchFile, ReadOnlyError
26
23
from bzrlib.lockable_files import LockableFiles, TransportLock
27
from bzrlib.symbol_versioning import (
30
from bzrlib.tests import (
24
from bzrlib import lockdir
25
from bzrlib.lockdir import LockDir
26
from bzrlib.tests import TestCaseInTempDir
34
27
from bzrlib.tests.test_smart import TestCaseWithSmartMedium
35
28
from bzrlib.tests.test_transactions import DummyWeave
36
29
from bzrlib.transactions import (PassThroughTransaction,
43
36
# these tests are applied in each parameterized suite for LockableFiles
45
# they use an old style of parameterization, but we want to remove this class
46
# so won't modernize them now. - mbp 20080430
47
37
class _TestLockableFiles_mixin(object):
40
self.reduceLockdirTimeout()
42
def test_read_write(self):
43
self.assertRaises(NoSuchFile, self.lockable.get, 'foo')
44
self.assertRaises(NoSuchFile, self.lockable.get_utf8, 'foo')
45
self.lockable.lock_write()
47
unicode_string = u'bar\u1234'
48
self.assertEqual(4, len(unicode_string))
49
byte_string = unicode_string.encode('utf-8')
50
self.assertEqual(6, len(byte_string))
51
self.assertRaises(UnicodeEncodeError, self.lockable.put, 'foo',
52
StringIO(unicode_string))
53
self.lockable.put('foo', StringIO(byte_string))
54
self.assertEqual(byte_string,
55
self.lockable.get('foo').read())
56
self.assertEqual(unicode_string,
57
self.lockable.get_utf8('foo').read())
58
self.assertRaises(BzrBadParameterNotString,
59
self.lockable.put_utf8,
61
StringIO(unicode_string)
63
self.lockable.put_utf8('bar', unicode_string)
64
self.assertEqual(unicode_string,
65
self.lockable.get_utf8('bar').read())
66
self.assertEqual(byte_string,
67
self.lockable.get('bar').read())
68
self.lockable.put_bytes('raw', 'raw\xffbytes')
69
self.assertEqual('raw\xffbytes',
70
self.lockable.get('raw').read())
72
self.lockable.unlock()
75
self.lockable.lock_read()
77
self.assertRaises(ReadOnlyError, self.lockable.put, 'foo',
78
StringIO('bar\u1234'))
80
self.lockable.unlock()
49
82
def test_transactions(self):
50
83
self.assertIs(self.lockable.get_transaction().__class__,
51
84
PassThroughTransaction)
99
133
def test_lock_write_returns_None_refuses_token(self):
100
134
token = self.lockable.lock_write()
101
self.addCleanup(self.lockable.unlock)
102
if token is not None:
103
# This test does not apply, because this lockable supports
105
raise TestNotApplicable("%r uses tokens" % (self.lockable,))
106
self.assertRaises(errors.TokenLockingNotSupported,
107
self.lockable.lock_write, token='token')
136
if token is not None:
137
# This test does not apply, because this lockable supports
140
self.assertRaises(errors.TokenLockingNotSupported,
141
self.lockable.lock_write, token='token')
143
self.lockable.unlock()
109
145
def test_lock_write_returns_token_when_given_token(self):
110
146
token = self.lockable.lock_write()
111
self.addCleanup(self.lockable.unlock)
113
# This test does not apply, because this lockable refuses
116
new_lockable = self.get_lockable()
117
token_from_new_lockable = new_lockable.lock_write(token=token)
118
self.addCleanup(new_lockable.unlock)
119
self.assertEqual(token, token_from_new_lockable)
149
# This test does not apply, because this lockable refuses
152
new_lockable = self.get_lockable()
153
token_from_new_lockable = new_lockable.lock_write(token=token)
155
self.assertEqual(token, token_from_new_lockable)
157
new_lockable.unlock()
159
self.lockable.unlock()
121
161
def test_lock_write_raises_on_token_mismatch(self):
122
162
token = self.lockable.lock_write()
123
self.addCleanup(self.lockable.unlock)
125
# This test does not apply, because this lockable refuses
128
different_token = token + 'xxx'
129
# Re-using the same lockable instance with a different token will
130
# raise TokenMismatch.
131
self.assertRaises(errors.TokenMismatch,
132
self.lockable.lock_write, token=different_token)
133
# A separate instance for the same lockable will also raise
135
# This detects the case where a caller claims to have a lock (via
136
# the token) for an external resource, but doesn't (the token is
137
# different). Clients need a separate lock object to make sure the
138
# external resource is probed, whereas the existing lock object
140
new_lockable = self.get_lockable()
141
self.assertRaises(errors.TokenMismatch,
142
new_lockable.lock_write, token=different_token)
165
# This test does not apply, because this lockable refuses
168
different_token = token + 'xxx'
169
# Re-using the same lockable instance with a different token will
170
# raise TokenMismatch.
171
self.assertRaises(errors.TokenMismatch,
172
self.lockable.lock_write, token=different_token)
173
# A seperate instance for the same lockable will also raise
175
# This detects the case where a caller claims to have a lock (via
176
# the token) for an external resource, but doesn't (the token is
177
# different). Clients need a seperate lock object to make sure the
178
# external resource is probed, whereas the existing lock object
180
new_lockable = self.get_lockable()
181
self.assertRaises(errors.TokenMismatch,
182
new_lockable.lock_write, token=different_token)
184
self.lockable.unlock()
144
186
def test_lock_write_with_matching_token(self):
145
187
# If the token matches, so no exception is raised by lock_write.
146
188
token = self.lockable.lock_write()
147
self.addCleanup(self.lockable.unlock)
149
# This test does not apply, because this lockable refuses
152
# The same instance will accept a second lock_write if the specified
154
self.lockable.lock_write(token=token)
155
self.lockable.unlock()
156
# Calling lock_write on a new instance for the same lockable will
158
new_lockable = self.get_lockable()
159
new_lockable.lock_write(token=token)
160
new_lockable.unlock()
191
# This test does not apply, because this lockable refuses
194
# The same instance will accept a second lock_write if the specified
196
self.lockable.lock_write(token=token)
197
self.lockable.unlock()
198
# Calling lock_write on a new instance for the same lockable will
200
new_lockable = self.get_lockable()
201
new_lockable.lock_write(token=token)
202
new_lockable.unlock()
204
self.lockable.unlock()
162
206
def test_unlock_after_lock_write_with_token(self):
163
207
# If lock_write did not physically acquire the lock (because it was
164
208
# passed a token), then unlock should not physically release it.
165
209
token = self.lockable.lock_write()
166
self.addCleanup(self.lockable.unlock)
168
# This test does not apply, because this lockable refuses
171
new_lockable = self.get_lockable()
172
new_lockable.lock_write(token=token)
173
new_lockable.unlock()
174
self.assertTrue(self.lockable.get_physical_lock_status())
212
# This test does not apply, because this lockable refuses
215
new_lockable = self.get_lockable()
216
new_lockable.lock_write(token=token)
217
new_lockable.unlock()
218
self.assertTrue(self.lockable.get_physical_lock_status())
220
self.lockable.unlock()
176
222
def test_lock_write_with_token_fails_when_unlocked(self):
177
223
# Lock and unlock to get a superficially valid token. This mimics a
271
295
third_lockable.unlock()
274
# This method of adapting tests to parameters is different to
275
# the TestProviderAdapters used elsewhere, but seems simpler for this
298
# This method of adapting tests to parameters is different to
299
# the TestProviderAdapters used elsewhere, but seems simpler for this
277
301
class TestLockableFiles_TransportLock(TestCaseInTempDir,
278
302
_TestLockableFiles_mixin):
281
305
TestCaseInTempDir.setUp(self)
306
_TestLockableFiles_mixin.setUp(self)
282
307
transport = get_transport('.')
283
308
transport.mkdir('.bzr')
284
309
self.sub_transport = transport.clone('.bzr')
285
310
self.lockable = self.get_lockable()
286
311
self.lockable.create_lock()
288
def stop_server(self):
289
super(TestLockableFiles_TransportLock, self).stop_server()
314
super(TestLockableFiles_TransportLock, self).tearDown()
290
315
# free the subtransport so that we do not get a 5 second
291
316
# timeout due to the SFTP connection cache.
293
del self.sub_transport
294
except AttributeError:
317
del self.sub_transport
297
319
def get_lockable(self):
298
320
return LockableFiles(self.sub_transport, 'my-lock', TransportLock)
301
323
class TestLockableFiles_LockDir(TestCaseInTempDir,
302
324
_TestLockableFiles_mixin):
306
328
TestCaseInTempDir.setUp(self)
329
_TestLockableFiles_mixin.setUp(self)
307
330
self.transport = get_transport('.')
308
331
self.lockable = self.get_lockable()
309
# the lock creation here sets mode - test_permissions on branch
310
# tests that implicitly, but it might be a good idea to factor
332
# the lock creation here sets mode - test_permissions on branch
333
# tests that implicitly, but it might be a good idea to factor
311
334
# out the mode checking logic and have it applied to loackable files
312
335
# directly. RBC 20060418
313
336
self.lockable.create_lock()
315
338
def get_lockable(self):
316
return LockableFiles(self.transport, 'my-lock', lockdir.LockDir)
339
return LockableFiles(self.transport, 'my-lock', LockDir)
318
341
def test_lock_created(self):
319
342
self.assertTrue(self.transport.has('my-lock'))
323
346
self.assertFalse(self.transport.has('my-lock/held/info'))
324
347
self.assertTrue(self.transport.has('my-lock'))
326
def test__file_modes(self):
327
self.transport.mkdir('readonly')
328
osutils.make_readonly('readonly')
329
lockable = LockableFiles(self.transport.clone('readonly'), 'test-lock',
331
# The directory mode should be read-write-execute for the current user
332
self.assertEqual(00700, lockable._dir_mode & 00700)
333
# Files should be read-write for the current user
334
self.assertEqual(00600, lockable._file_mode & 00700)
350
# TODO: Test the lockdir inherits the right file and directory permissions
351
# from the LockableFiles.
337
354
class TestLockableFiles_RemoteLockDir(TestCaseWithSmartMedium,
338
355
_TestLockableFiles_mixin):
342
359
TestCaseWithSmartMedium.setUp(self)
360
_TestLockableFiles_mixin.setUp(self)
343
361
# can only get a RemoteLockDir with some RemoteObject...
344
362
# use a branch as thats what we want. These mixin tests test the end
345
363
# to end behaviour, so stubbing out the backend and simulating would
346
364
# defeat the purpose. We test the protocol implementation separately
347
365
# in test_remote and test_smart as usual.
348
b = self.make_branch('foo')
349
self.addCleanup(b.bzrdir.transport.disconnect)
366
self.make_branch('foo')
350
367
self.transport = get_transport('.')
351
368
self.lockable = self.get_lockable()
353
370
def get_lockable(self):
354
371
# getting a new lockable involves opening a new instance of the branch
355
372
branch = bzrlib.branch.Branch.open(self.get_url('foo'))
356
self.addCleanup(branch.bzrdir.transport.disconnect)
357
373
return branch.control_files
375
def test_lock_write_returns_None_refuses_token(self):
376
# this test is not relevant for RemoteBranchLockableFiles as remote
377
# locks are done directly from the remote branch object.
380
def test_lock_write_raises_on_token_mismatch(self):
381
# See test_lock_write_returns_None_refuses_token.
384
def test_lock_write_with_matching_token(self):
385
# See test_lock_write_returns_None_refuses_token.
388
def test_unlock_after_lock_write_with_token(self):
389
# See test_lock_write_returns_None_refuses_token.
392
def test_lock_write_with_token_fails_when_unlocked(self):
393
# See test_lock_write_returns_None_refuses_token.
396
def test_lock_write_reenter_with_token(self):
397
# See test_lock_write_returns_None_refuses_token.
400
def test_leave_in_place(self):
401
# See test_lock_write_returns_None_refuses_token.
404
def test_dont_leave_in_place(self):
405
# See test_lock_write_returns_None_refuses_token.
408
def test_lock_write_returns_token_when_given_token(self):
409
# See test_lock_write_returns_None_refuses_token.