/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/tests/blackbox/test_serve.py

Add a Transport.is_readonly remote call, let {Branch,Repository}.lock_write remote call return UnlockableTransport, and miscellaneous test fixes.

Show diffs side-by-side

added added

removed removed

Lines of Context:
1
 
# Copyright (C) 2006-2010 Canonical Ltd
 
1
# Copyright (C) 2006 Canonical Ltd
2
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
12
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
 
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
 
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
17
17
 
18
18
"""Tests of the bzr serve command."""
19
19
 
20
20
import os
21
 
import os.path
22
21
import signal
23
22
import subprocess
24
 
import sys
25
 
import thread
26
23
import threading
27
24
 
28
 
from bzrlib import (
29
 
    builtins,
30
 
    debug,
31
 
    errors,
32
 
    osutils,
33
 
    revision as _mod_revision,
34
 
    urlutils,
35
 
    )
 
25
from bzrlib import errors
36
26
from bzrlib.branch import Branch
37
27
from bzrlib.bzrdir import BzrDir
38
 
from bzrlib.smart import client, medium
39
 
from bzrlib.smart.server import BzrServerFactory, SmartTCPServer
40
 
from bzrlib.tests import (
41
 
    TestCaseWithMemoryTransport,
42
 
    TestCaseWithTransport,
43
 
    TestSkipped,
44
 
    )
45
 
from bzrlib.trace import mutter
 
28
from bzrlib.errors import ParamikoNotPresent
 
29
from bzrlib.tests import TestCaseWithTransport, TestSkipped
46
30
from bzrlib.transport import get_transport, remote
47
 
 
48
 
 
49
 
class TestBzrServeBase(TestCaseWithTransport):
50
 
 
51
 
    def run_bzr_serve_then_func(self, serve_args, retcode=0, func=None,
52
 
                                *func_args, **func_kwargs):
53
 
        """Run 'bzr serve', and run the given func in a thread once the server
54
 
        has started.
55
 
        
56
 
        When 'func' terminates, the server will be terminated too.
57
 
        
58
 
        Returns stdout and stderr.
59
 
        """
60
 
        # install hook
61
 
        def on_server_start(backing_urls, tcp_server):
62
 
            t = threading.Thread(
63
 
                target=on_server_start_thread, args=(tcp_server,))
64
 
            t.start()
65
 
        def on_server_start_thread(tcp_server):
66
 
            try:
67
 
                # Run func if set
68
 
                self.tcp_server = tcp_server
69
 
                if not func is None:
70
 
                    try:
71
 
                        func(*func_args, **func_kwargs)
72
 
                    except Exception, e:
73
 
                        # Log errors to make some test failures a little less
74
 
                        # mysterious.
75
 
                        mutter('func broke: %r', e)
76
 
            finally:
77
 
                # Then stop the server
78
 
                mutter('interrupting...')
79
 
                thread.interrupt_main()
80
 
        SmartTCPServer.hooks.install_named_hook(
81
 
            'server_started_ex', on_server_start,
82
 
            'run_bzr_serve_then_func hook')
83
 
        # start a TCP server
84
 
        try:
85
 
            out, err = self.run_bzr(['serve'] + list(serve_args))
86
 
        except KeyboardInterrupt, e:
87
 
            out, err = e.args
88
 
        return out, err
89
 
 
90
 
 
91
 
class TestBzrServe(TestBzrServeBase):
92
 
 
93
 
    def setUp(self):
94
 
        super(TestBzrServe, self).setUp()
95
 
        self.disable_missing_extensions_warning()
 
31
from bzrlib.smart import medium
 
32
 
 
33
 
 
34
class TestBzrServe(TestCaseWithTransport):
96
35
 
97
36
    def assertInetServerShutsdownCleanly(self, process):
98
37
        """Shutdown the server process looking for errors."""
101
40
        process.stdin.close()
102
41
        # Hide stdin from the subprocess module, so it won't fail to close it.
103
42
        process.stdin = None
104
 
        result = self.finish_bzr_subprocess(process)
 
43
        result = self.finish_bzr_subprocess(process, retcode=0)
105
44
        self.assertEqual('', result[0])
106
45
        self.assertEqual('', result[1])
107
 
 
 
46
    
108
47
    def assertServerFinishesCleanly(self, process):
109
48
        """Shutdown the bzr serve instance process looking for errors."""
110
49
        # Shutdown the server
113
52
        self.assertEqual('', result[0])
114
53
        self.assertEqual('bzr: interrupted\n', result[1])
115
54
 
116
 
    def make_read_requests(self, branch):
117
 
        """Do some read only requests."""
118
 
        branch.lock_read()
119
 
        try:
120
 
            branch.repository.all_revision_ids()
121
 
            self.assertEqual(_mod_revision.NULL_REVISION,
122
 
                             _mod_revision.ensure_null(branch.last_revision()))
123
 
        finally:
124
 
            branch.unlock()
125
 
 
126
55
    def start_server_inet(self, extra_options=()):
127
56
        """Start a bzr server subprocess using the --inet option.
128
57
 
131
60
            finish_bzr_subprocess, a client for the server, and a transport.
132
61
        """
133
62
        # Serve from the current directory
134
 
        args = ['serve', '--inet']
135
 
        args.extend(extra_options)
136
 
        process = self.start_bzr_subprocess(args)
 
63
        process = self.start_bzr_subprocess(['serve', '--inet'])
137
64
 
138
65
        # Connect to the server
139
66
        # We use this url because while this is no valid URL to connect to this
140
67
        # server instance, the transport needs a URL.
141
 
        url = 'bzr://localhost/'
142
 
        self.permit_url(url)
143
68
        client_medium = medium.SmartSimplePipesClientMedium(
144
 
            process.stdout, process.stdin, url)
145
 
        transport = remote.RemoteTransport(url, medium=client_medium)
 
69
            process.stdout, process.stdin)
 
70
        transport = remote.RemoteTransport(
 
71
            'bzr://localhost/', medium=client_medium)
146
72
        return process, transport
147
73
 
148
74
    def start_server_port(self, extra_options=()):
156
82
        args = ['serve', '--port', 'localhost:0']
157
83
        args.extend(extra_options)
158
84
        process = self.start_bzr_subprocess(args, skip_if_plan_to_signal=True)
159
 
        port_line = process.stderr.readline()
 
85
        port_line = process.stdout.readline()
160
86
        prefix = 'listening on port: '
161
87
        self.assertStartsWith(port_line, prefix)
162
88
        port = int(port_line[len(prefix):])
163
 
        url = 'bzr://localhost:%d/' % port
164
 
        self.permit_url(url)
165
 
        return process, url
166
 
    
167
 
    def test_bzr_serve_quiet(self):
168
 
        self.make_branch('.')
169
 
        args = ['--port', 'localhost:0', '--quiet']
170
 
        out, err = self.run_bzr_serve_then_func(args, retcode=3)
171
 
        self.assertEqual('', out)
172
 
        self.assertEqual('', err)
 
89
        return process,'bzr://localhost:%d/' % port
173
90
 
174
91
    def test_bzr_serve_inet_readonly(self):
175
92
        """bzr server should provide a read only filesystem by default."""
183
100
 
184
101
        process, transport = self.start_server_inet(['--allow-writes'])
185
102
 
186
 
        # We get a working branch, and can create a directory
 
103
        # We get a working branch
187
104
        branch = BzrDir.open_from_transport(transport).open_branch()
188
 
        self.make_read_requests(branch)
189
 
        transport.mkdir('adir')
 
105
        branch.repository.get_revision_graph()
 
106
        self.assertEqual(None, branch.last_revision())
190
107
        self.assertInetServerShutsdownCleanly(process)
191
108
 
192
109
    def test_bzr_serve_port_readonly(self):
204
121
 
205
122
        # Connect to the server
206
123
        branch = Branch.open(url)
207
 
        self.make_read_requests(branch)
 
124
 
 
125
        # We get a working branch
 
126
        branch.repository.get_revision_graph()
 
127
        self.assertEqual(None, branch.last_revision())
 
128
 
208
129
        self.assertServerFinishesCleanly(process)
209
130
 
210
 
    def test_bzr_serve_supports_protocol(self):
 
131
    def test_bzr_connect_to_bzr_ssh(self):
 
132
        """User acceptance that get_transport of a bzr+ssh:// behaves correctly.
 
133
 
 
134
        bzr+ssh:// should cause bzr to run a remote bzr smart server over SSH.
 
135
        """
 
136
        try:
 
137
            from bzrlib.transport.sftp import SFTPServer
 
138
        except ParamikoNotPresent:
 
139
            raise TestSkipped('Paramiko not installed')
 
140
        from bzrlib.tests.stub_sftp import StubServer
 
141
        
211
142
        # Make a branch
212
 
        self.make_branch('.')
213
 
 
214
 
        process, url = self.start_server_port(['--allow-writes',
215
 
                                               '--protocol=bzr'])
216
 
 
217
 
        # Connect to the server
218
 
        branch = Branch.open(url)
219
 
        self.make_read_requests(branch)
220
 
        self.assertServerFinishesCleanly(process)
221
 
 
222
 
    def test_bzr_serve_dhpss(self):
223
 
        # This is a smoke test that the server doesn't crash when run with
224
 
        # -Dhpss, and does drop some hpss logging to the file.
225
 
        self.make_branch('.')
226
 
        log_fname = os.getcwd() + '/server.log'
227
 
        self._captureVar('BZR_LOG', log_fname)
228
 
        process, transport = self.start_server_inet(['-Dhpss'])
229
 
        branch = BzrDir.open_from_transport(transport).open_branch()
230
 
        self.make_read_requests(branch)
231
 
        self.assertInetServerShutsdownCleanly(process)
232
 
        f = open(log_fname, 'rb')
233
 
        content = f.read()
234
 
        f.close()
235
 
        self.assertContainsRe(content, r'hpss request: \[[0-9-]+\]')
236
 
 
237
 
 
238
 
class TestCmdServeChrooting(TestBzrServeBase):
239
 
 
240
 
    def test_serve_tcp(self):
241
 
        """'bzr serve' wraps the given --directory in a ChrootServer.
242
 
 
243
 
        So requests that search up through the parent directories (like
244
 
        find_repositoryV3) will give "not found" responses, rather than
245
 
        InvalidURLJoin or jail break errors.
246
 
        """
247
 
        t = self.get_transport()
248
 
        t.mkdir('server-root')
249
 
        self.run_bzr_serve_then_func(
250
 
            ['--port', '127.0.0.1:0',
251
 
             '--directory', t.local_abspath('server-root'),
252
 
             '--allow-writes'],
253
 
            func=self.when_server_started)
254
 
        # The when_server_started method issued a find_repositoryV3 that should
255
 
        # fail with 'norepository' because there are no repositories inside the
256
 
        # --directory.
257
 
        self.assertEqual(('norepository',), self.client_resp)
258
 
 
259
 
    def when_server_started(self):
260
 
        # Connect to the TCP server and issue some requests and see what comes
261
 
        # back.
262
 
        client_medium = medium.SmartTCPClientMedium(
263
 
            '127.0.0.1', self.tcp_server.port,
264
 
            'bzr://localhost:%d/' % (self.tcp_server.port,))
265
 
        smart_client = client._SmartClient(client_medium)
266
 
        resp = smart_client.call('mkdir', 'foo', '')
267
 
        resp = smart_client.call('BzrDirFormat.initialize', 'foo/')
 
143
        self.make_branch('a_branch')
 
144
 
 
145
        # Start an SSH server
 
146
        self.command_executed = []
 
147
        # XXX: This is horrible -- we define a really dumb SSH server that
 
148
        # executes commands, and manage the hooking up of stdin/out/err to the
 
149
        # SSH channel ourselves.  Surely this has already been implemented
 
150
        # elsewhere?
 
151
        class StubSSHServer(StubServer):
 
152
 
 
153
            test = self
 
154
 
 
155
            def check_channel_exec_request(self, channel, command):
 
156
                self.test.command_executed.append(command)
 
157
                proc = subprocess.Popen(
 
158
                    command, shell=True, stdin=subprocess.PIPE,
 
159
                    stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 
160
                
 
161
                # XXX: horribly inefficient, not to mention ugly.
 
162
                # Start a thread for each of stdin/out/err, and relay bytes from
 
163
                # the subprocess to channel and vice versa.
 
164
                def ferry_bytes(read, write, close):
 
165
                    while True:
 
166
                        bytes = read(1)
 
167
                        if bytes == '':
 
168
                            close()
 
169
                            break
 
170
                        write(bytes)
 
171
 
 
172
                file_functions = [
 
173
                    (channel.recv, proc.stdin.write, proc.stdin.close),
 
174
                    (proc.stdout.read, channel.sendall, channel.close),
 
175
                    (proc.stderr.read, channel.sendall_stderr, channel.close)]
 
176
                for read, write, close in file_functions:
 
177
                    t = threading.Thread(
 
178
                        target=ferry_bytes, args=(read, write, close))
 
179
                    t.start()
 
180
 
 
181
                return True
 
182
 
 
183
        ssh_server = SFTPServer(StubSSHServer)
 
184
        # XXX: We *don't* want to override the default SSH vendor, so we set
 
185
        # _vendor to what _get_ssh_vendor returns.
 
186
        ssh_server.setUp()
 
187
        self.addCleanup(ssh_server.tearDown)
 
188
        port = ssh_server._listener.port
 
189
 
 
190
        # Access the branch via a bzr+ssh URL.  The BZR_REMOTE_PATH environment
 
191
        # variable is used to tell bzr what command to run on the remote end.
 
192
        path_to_branch = os.path.abspath('a_branch')
 
193
        
 
194
        orig_bzr_remote_path = os.environ.get('BZR_REMOTE_PATH')
 
195
        os.environ['BZR_REMOTE_PATH'] = self.get_bzr_path()
268
196
        try:
269
 
            resp = smart_client.call('BzrDir.find_repositoryV3', 'foo/')
270
 
        except errors.ErrorFromSmartServer, e:
271
 
            resp = e.error_tuple
272
 
        self.client_resp = resp
273
 
        client_medium.disconnect()
274
 
 
275
 
 
276
 
class TestUserdirExpansion(TestCaseWithMemoryTransport):
277
 
 
278
 
    def fake_expanduser(self, path):
279
 
        """A simple, environment-independent, function for the duration of this
280
 
        test.
281
 
 
282
 
        Paths starting with a path segment of '~user' will expand to start with
283
 
        '/home/user/'.  Every other path will be unchanged.
284
 
        """
285
 
        if path.split('/', 1)[0] == '~user':
286
 
            return '/home/user' + path[len('~user'):]
287
 
        return path
288
 
 
289
 
    def make_test_server(self, base_path='/'):
290
 
        """Make and start a BzrServerFactory, backed by a memory transport, and
291
 
        creat '/home/user' in that transport.
292
 
        """
293
 
        bzr_server = BzrServerFactory(
294
 
            self.fake_expanduser, lambda t: base_path)
295
 
        mem_transport = self.get_transport()
296
 
        mem_transport.mkdir_multi(['home', 'home/user'])
297
 
        bzr_server.set_up(mem_transport, None, None, inet=True)
298
 
        self.addCleanup(bzr_server.tear_down)
299
 
        return bzr_server
300
 
 
301
 
    def test_bzr_serve_expands_userdir(self):
302
 
        bzr_server = self.make_test_server()
303
 
        self.assertTrue(bzr_server.smart_server.backing_transport.has('~user'))
304
 
 
305
 
    def test_bzr_serve_does_not_expand_userdir_outside_base(self):
306
 
        bzr_server = self.make_test_server('/foo')
307
 
        self.assertFalse(bzr_server.smart_server.backing_transport.has('~user'))
308
 
 
309
 
    def test_get_base_path(self):
310
 
        """cmd_serve will turn the --directory option into a LocalTransport
311
 
        (optionally decorated with 'readonly+').  BzrServerFactory can
312
 
        determine the original --directory from that transport.
313
 
        """
314
 
        # URLs always include the trailing slash, and get_base_path returns it
315
 
        base_dir = osutils.abspath('/a/b/c') + '/'
316
 
        base_url = urlutils.local_path_to_url(base_dir) + '/'
317
 
        # Define a fake 'protocol' to capture the transport that cmd_serve
318
 
        # passes to serve_bzr.
319
 
        def capture_transport(transport, host, port, inet):
320
 
            self.bzr_serve_transport = transport
321
 
        cmd = builtins.cmd_serve()
322
 
        # Read-only
323
 
        cmd.run(directory=base_dir, protocol=capture_transport)
324
 
        server_maker = BzrServerFactory()
325
 
        self.assertEqual(
326
 
            'readonly+%s' % base_url, self.bzr_serve_transport.base)
327
 
        self.assertEqual(
328
 
            base_dir, server_maker.get_base_path(self.bzr_serve_transport))
329
 
        # Read-write
330
 
        cmd.run(directory=base_dir, protocol=capture_transport,
331
 
            allow_writes=True)
332
 
        server_maker = BzrServerFactory()
333
 
        self.assertEqual(base_url, self.bzr_serve_transport.base)
334
 
        self.assertEqual(base_dir,
335
 
            server_maker.get_base_path(self.bzr_serve_transport))
336
 
 
 
197
            branch = Branch.open(
 
198
                'bzr+ssh://fred:secret@localhost:%d%s' % (port, path_to_branch))
 
199
            
 
200
            branch.repository.get_revision_graph()
 
201
            self.assertEqual(None, branch.last_revision())
 
202
            # Check we can perform write operations
 
203
            branch.bzrdir.root_transport.mkdir('foo')
 
204
        finally:
 
205
            # Restore the BZR_REMOTE_PATH environment variable back to its
 
206
            # original state.
 
207
            if orig_bzr_remote_path is None:
 
208
                del os.environ['BZR_REMOTE_PATH']
 
209
            else:
 
210
                os.environ['BZR_REMOTE_PATH'] = orig_bzr_remote_path
 
211
 
 
212
        self.assertEqual(
 
213
            ['%s serve --inet --directory=/ --allow-writes'
 
214
             % self.get_bzr_path()],
 
215
            self.command_executed)
 
216