/brz/remove-bazaar

To get this branch, use:
bzr branch http://gegoxaren.bato24.eu/bzr/brz/remove-bazaar

« back to all changes in this revision

Viewing changes to bzrlib/diff.py

  • Committer: Martin Pool
  • Date: 2006-10-29 01:49:15 UTC
  • mto: This revision was merged to the branch mainline in revision 2112.
  • Revision ID: mbp@sourcefrog.net-20061029014915-47f151a2834f8a6d
Fix an assertion with side effects

Show diffs side-by-side

added added

removed removed

Lines of Context:
bzrlib/diff.py
1
1
# Copyright (C) 2004, 2005, 2006 Canonical Ltd.
2
 
 
 
2
#
3
3
# This program is free software; you can redistribute it and/or modify
4
4
# it under the terms of the GNU General Public License as published by
5
5
# the Free Software Foundation; either version 2 of the License, or
6
6
# (at your option) any later version.
7
 
 
 
7
#
8
8
# This program is distributed in the hope that it will be useful,
9
9
# but WITHOUT ANY WARRANTY; without even the implied warranty of
10
10
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
11
11
# GNU General Public License for more details.
12
 
 
 
12
#
13
13
# You should have received a copy of the GNU General Public License
14
14
# along with this program; if not, write to the Free Software
15
15
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
16
16
 
 
17
import os
 
18
import re
 
19
import sys
 
20
 
 
21
from bzrlib.lazy_import import lazy_import
 
22
lazy_import(globals(), """
 
23
import errno
 
24
import subprocess
 
25
import tempfile
 
26
import time
 
27
 
 
28
from bzrlib import (
 
29
    errors,
 
30
    osutils,
 
31
    patiencediff,
 
32
    textfile,
 
33
    )
 
34
""")
 
35
 
 
36
# compatability - plugins import compare_trees from diff!!!
 
37
# deprecated as of 0.10
17
38
from bzrlib.delta import compare_trees
18
 
from bzrlib.errors import BzrError
19
 
import bzrlib.errors as errors
20
 
from bzrlib.symbol_versioning import *
21
 
from bzrlib.trace import mutter
 
39
from bzrlib.symbol_versioning import (
 
40
        deprecated_function,
 
41
        zero_eight,
 
42
        )
 
43
from bzrlib.trace import mutter, warning
 
44
 
22
45
 
23
46
# TODO: Rather than building a changeset object, we should probably
24
47
# invoke callbacks on an object.  That object can either accumulate a
25
48
# list, write them out directly, etc etc.
26
49
 
27
 
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file):
28
 
    import difflib
29
 
    
 
50
def internal_diff(old_filename, oldlines, new_filename, newlines, to_file,
 
51
                  allow_binary=False, sequence_matcher=None,
 
52
                  path_encoding='utf8'):
30
53
    # FIXME: difflib is wrong if there is no trailing newline.
31
54
    # The syntax used by patch seems to be "\ No newline at
32
55
    # end of file" following the last diff line from that
42
65
    # both sequences are empty.
43
66
    if not oldlines and not newlines:
44
67
        return
 
68
    
 
69
    if allow_binary is False:
 
70
        textfile.check_text_lines(oldlines)
 
71
        textfile.check_text_lines(newlines)
45
72
 
46
 
    ud = difflib.unified_diff(oldlines, newlines,
47
 
                              fromfile=old_filename+'\t', 
48
 
                              tofile=new_filename+'\t')
 
73
    if sequence_matcher is None:
 
74
        sequence_matcher = patiencediff.PatienceSequenceMatcher
 
75
    ud = patiencediff.unified_diff(oldlines, newlines,
 
76
                      fromfile=old_filename.encode(path_encoding),
 
77
                      tofile=new_filename.encode(path_encoding),
 
78
                      sequencematcher=sequence_matcher)
49
79
 
50
80
    ud = list(ud)
51
81
    # work-around for difflib being too smart for its own good
65
95
    print >>to_file
66
96
 
67
97
 
 
98
def _set_lang_C():
 
99
    """Set the env var LANG=C"""
 
100
    osutils.set_or_unset_env('LANG', 'C')
 
101
    osutils.set_or_unset_env('LC_ALL', None)
 
102
    osutils.set_or_unset_env('LC_CTYPE', None)
 
103
    osutils.set_or_unset_env('LANGUAGE', None)
 
104
 
 
105
 
 
106
def _spawn_external_diff(diffcmd, capture_errors=True):
 
107
    """Spawn the externall diff process, and return the child handle.
 
108
 
 
109
    :param diffcmd: The command list to spawn
 
110
    :param capture_errors: Capture stderr as well as setting LANG=C.
 
111
        This lets us read and understand the output of diff, and respond 
 
112
        to any errors.
 
113
    :return: A Popen object.
 
114
    """
 
115
    if capture_errors:
 
116
        if sys.platform == 'win32':
 
117
            # Win32 doesn't support preexec_fn, but that is
 
118
            # okay, because it doesn't support LANG either.
 
119
            preexec_fn = None
 
120
        else:
 
121
            preexec_fn = _set_lang_C
 
122
        stderr = subprocess.PIPE
 
123
    else:
 
124
        preexec_fn = None
 
125
        stderr = None
 
126
 
 
127
    try:
 
128
        pipe = subprocess.Popen(diffcmd,
 
129
                                stdin=subprocess.PIPE,
 
130
                                stdout=subprocess.PIPE,
 
131
                                stderr=stderr,
 
132
                                preexec_fn=preexec_fn)
 
133
    except OSError, e:
 
134
        if e.errno == errno.ENOENT:
 
135
            raise errors.NoDiff(str(e))
 
136
        raise
 
137
 
 
138
    return pipe
 
139
 
 
140
 
68
141
def external_diff(old_filename, oldlines, new_filename, newlines, to_file,
69
142
                  diff_opts):
70
143
    """Display a diff by calling out to the external diff program."""
71
 
    import sys
72
 
    
73
 
    if to_file != sys.stdout:
74
 
        raise NotImplementedError("sorry, can't send external diff other than to stdout yet",
75
 
                                  to_file)
76
 
 
77
144
    # make sure our own output is properly ordered before the diff
78
145
    to_file.flush()
79
146
 
80
 
    from tempfile import NamedTemporaryFile
81
 
    import os
82
 
 
83
 
    oldtmpf = NamedTemporaryFile()
84
 
    newtmpf = NamedTemporaryFile()
 
147
    oldtmp_fd, old_abspath = tempfile.mkstemp(prefix='bzr-diff-old-')
 
148
    newtmp_fd, new_abspath = tempfile.mkstemp(prefix='bzr-diff-new-')
 
149
    oldtmpf = os.fdopen(oldtmp_fd, 'wb')
 
150
    newtmpf = os.fdopen(newtmp_fd, 'wb')
85
151
 
86
152
    try:
87
153
        # TODO: perhaps a special case for comparing to or from the empty
94
160
        oldtmpf.writelines(oldlines)
95
161
        newtmpf.writelines(newlines)
96
162
 
97
 
        oldtmpf.flush()
98
 
        newtmpf.flush()
 
163
        oldtmpf.close()
 
164
        newtmpf.close()
99
165
 
100
166
        if not diff_opts:
101
167
            diff_opts = []
102
168
        diffcmd = ['diff',
103
 
                   '--label', old_filename+'\t',
104
 
                   oldtmpf.name,
105
 
                   '--label', new_filename+'\t',
106
 
                   newtmpf.name]
 
169
                   '--label', old_filename,
 
170
                   old_abspath,
 
171
                   '--label', new_filename,
 
172
                   new_abspath,
 
173
                   '--binary',
 
174
                  ]
107
175
 
108
176
        # diff only allows one style to be specified; they don't override.
109
177
        # note that some of these take optargs, and the optargs can be
129
197
        if diff_opts:
130
198
            diffcmd.extend(diff_opts)
131
199
 
132
 
        rc = os.spawnvp(os.P_WAIT, 'diff', diffcmd)
 
200
        pipe = _spawn_external_diff(diffcmd, capture_errors=True)
 
201
        out,err = pipe.communicate()
 
202
        rc = pipe.returncode
133
203
        
134
 
        if rc != 0 and rc != 1:
 
204
        # internal_diff() adds a trailing newline, add one here for consistency
 
205
        out += '\n'
 
206
        if rc == 2:
 
207
            # 'diff' gives retcode == 2 for all sorts of errors
 
208
            # one of those is 'Binary files differ'.
 
209
            # Bad options could also be the problem.
 
210
            # 'Binary files' is not a real error, so we suppress that error.
 
211
            lang_c_out = out
 
212
 
 
213
            # Since we got here, we want to make sure to give an i18n error
 
214
            pipe = _spawn_external_diff(diffcmd, capture_errors=False)
 
215
            out, err = pipe.communicate()
 
216
 
 
217
            # Write out the new i18n diff response
 
218
            to_file.write(out+'\n')
 
219
            if pipe.returncode != 2:
 
220
                raise errors.BzrError(
 
221
                               'external diff failed with exit code 2'
 
222
                               ' when run with LANG=C, but not when run'
 
223
                               ' natively: %r' % (diffcmd,))
 
224
 
 
225
            first_line = lang_c_out.split('\n', 1)[0]
 
226
            # Starting with diffutils 2.8.4 the word "binary" was dropped.
 
227
            m = re.match('^(binary )?files.*differ$', first_line, re.I)
 
228
            if m is None:
 
229
                raise errors.BzrError('external diff failed with exit code 2;'
 
230
                                      ' command: %r' % (diffcmd,))
 
231
            else:
 
232
                # Binary files differ, just return
 
233
                return
 
234
 
 
235
        # If we got to here, we haven't written out the output of diff
 
236
        # do so now
 
237
        to_file.write(out)
 
238
        if rc not in (0, 1):
135
239
            # returns 1 if files differ; that's OK
136
240
            if rc < 0:
137
241
                msg = 'signal %d' % (-rc)
138
242
            else:
139
243
                msg = 'exit code %d' % rc
140
244
                
141
 
            raise BzrError('external diff failed with %s; command: %r' % (rc, diffcmd))
 
245
            raise errors.BzrError('external diff failed with %s; command: %r' 
 
246
                                  % (rc, diffcmd))
 
247
 
 
248
 
142
249
    finally:
143
250
        oldtmpf.close()                 # and delete
144
251
        newtmpf.close()
 
252
        # Clean up. Warn in case the files couldn't be deleted
 
253
        # (in case windows still holds the file open, but not
 
254
        # if the files have already been deleted)
 
255
        try:
 
256
            os.remove(old_abspath)
 
257
        except OSError, e:
 
258
            if e.errno not in (errno.ENOENT,):
 
259
                warning('Failed to delete temporary file: %s %s',
 
260
                        old_abspath, e)
 
261
        try:
 
262
            os.remove(new_abspath)
 
263
        except OSError:
 
264
            if e.errno not in (errno.ENOENT,):
 
265
                warning('Failed to delete temporary file: %s %s',
 
266
                        new_abspath, e)
145
267
 
146
268
 
147
269
@deprecated_function(zero_eight)
161
283
    supplies any two trees.
162
284
    """
163
285
    if output is None:
164
 
        import sys
165
286
        output = sys.stdout
166
287
 
167
288
    if from_spec is None:
184
305
 
185
306
 
186
307
def diff_cmd_helper(tree, specific_files, external_diff_options, 
187
 
                    old_revision_spec=None, new_revision_spec=None):
 
308
                    old_revision_spec=None, new_revision_spec=None,
 
309
                    old_label='a/', new_label='b/'):
188
310
    """Helper for cmd_diff.
189
311
 
190
312
   tree 
207
329
    The more general form is show_diff_trees(), where the caller
208
330
    supplies any two trees.
209
331
    """
210
 
    import sys
211
 
    output = sys.stdout
212
332
    def spec_tree(spec):
213
 
        revision_id = spec.in_store(tree.branch).rev_id
214
 
        return tree.branch.repository.revision_tree(revision_id)
 
333
        if tree:
 
334
            revision = spec.in_store(tree.branch)
 
335
        else:
 
336
            revision = spec.in_store(None)
 
337
        revision_id = revision.rev_id
 
338
        branch = revision.branch
 
339
        return branch.repository.revision_tree(revision_id)
215
340
    if old_revision_spec is None:
216
341
        old_tree = tree.basis_tree()
217
342
    else:
221
346
        new_tree = tree
222
347
    else:
223
348
        new_tree = spec_tree(new_revision_spec)
 
349
    if new_tree is not tree:
 
350
        extra_trees = (tree,)
 
351
    else:
 
352
        extra_trees = None
224
353
 
225
354
    return show_diff_trees(old_tree, new_tree, sys.stdout, specific_files,
226
 
                           external_diff_options)
 
355
                           external_diff_options,
 
356
                           old_label=old_label, new_label=new_label,
 
357
                           extra_trees=extra_trees)
227
358
 
228
359
 
229
360
def show_diff_trees(old_tree, new_tree, to_file, specific_files=None,
230
 
                    external_diff_options=None):
 
361
                    external_diff_options=None,
 
362
                    old_label='a/', new_label='b/',
 
363
                    extra_trees=None):
231
364
    """Show in text form the changes from one tree to another.
232
365
 
233
366
    to_files
235
368
 
236
369
    external_diff_options
237
370
        If set, use an external GNU diff and pass these options.
 
371
 
 
372
    extra_trees
 
373
        If set, more Trees to use for looking up file ids
238
374
    """
239
375
    old_tree.lock_read()
240
376
    try:
241
377
        new_tree.lock_read()
242
378
        try:
243
379
            return _show_diff_trees(old_tree, new_tree, to_file,
244
 
                                    specific_files, external_diff_options)
 
380
                                    specific_files, external_diff_options,
 
381
                                    old_label=old_label, new_label=new_label,
 
382
                                    extra_trees=extra_trees)
245
383
        finally:
246
384
            new_tree.unlock()
247
385
    finally:
249
387
 
250
388
 
251
389
def _show_diff_trees(old_tree, new_tree, to_file,
252
 
                     specific_files, external_diff_options):
253
 
 
254
 
    # TODO: Options to control putting on a prefix or suffix, perhaps
255
 
    # as a format string?
256
 
    old_label = 'a/'
257
 
    new_label = 'b/'
258
 
 
259
 
    DEVNULL = '/dev/null'
260
 
    # Windows users, don't panic about this filename -- it is a
261
 
    # special signal to GNU patch that the file should be created or
262
 
    # deleted respectively.
 
390
                     specific_files, external_diff_options, 
 
391
                     old_label='a/', new_label='b/', extra_trees=None):
 
392
 
 
393
    # GNU Patch uses the epoch date to detect files that are being added
 
394
    # or removed in a diff.
 
395
    EPOCH_DATE = '1970-01-01 00:00:00 +0000'
263
396
 
264
397
    # TODO: Generation of pseudo-diffs for added/deleted files could
265
398
    # be usefully made into a much faster special case.
266
399
 
267
 
    _raise_if_doubly_unversioned(specific_files, old_tree, new_tree)
268
 
 
269
400
    if external_diff_options:
270
401
        assert isinstance(external_diff_options, basestring)
271
402
        opts = external_diff_options.split()
274
405
    else:
275
406
        diff_file = internal_diff
276
407
    
277
 
    delta = compare_trees(old_tree, new_tree, want_unchanged=False,
278
 
                          specific_files=specific_files)
 
408
    delta = new_tree.changes_from(old_tree,
 
409
        specific_files=specific_files,
 
410
        extra_trees=extra_trees, require_versioned=True)
279
411
 
280
412
    has_changes = 0
281
413
    for path, file_id, kind in delta.removed:
282
414
        has_changes = 1
283
 
        print >>to_file, '=== removed %s %r' % (kind, old_label + path)
284
 
        old_tree.inventory[file_id].diff(diff_file, old_label + path, old_tree,
285
 
                                         DEVNULL, None, None, to_file)
 
415
        print >>to_file, '=== removed %s %r' % (kind, path.encode('utf8'))
 
416
        old_name = '%s%s\t%s' % (old_label, path,
 
417
                                 _patch_header_date(old_tree, file_id, path))
 
418
        new_name = '%s%s\t%s' % (new_label, path, EPOCH_DATE)
 
419
        old_tree.inventory[file_id].diff(diff_file, old_name, old_tree,
 
420
                                         new_name, None, None, to_file)
286
421
    for path, file_id, kind in delta.added:
287
422
        has_changes = 1
288
 
        print >>to_file, '=== added %s %r' % (kind, new_label + path)
289
 
        new_tree.inventory[file_id].diff(diff_file, new_label + path, new_tree,
290
 
                                         DEVNULL, None, None, to_file, 
 
423
        print >>to_file, '=== added %s %r' % (kind, path.encode('utf8'))
 
424
        old_name = '%s%s\t%s' % (old_label, path, EPOCH_DATE)
 
425
        new_name = '%s%s\t%s' % (new_label, path,
 
426
                                 _patch_header_date(new_tree, file_id, path))
 
427
        new_tree.inventory[file_id].diff(diff_file, new_name, new_tree,
 
428
                                         old_name, None, None, to_file, 
291
429
                                         reverse=True)
292
430
    for (old_path, new_path, file_id, kind,
293
431
         text_modified, meta_modified) in delta.renamed:
294
432
        has_changes = 1
295
433
        prop_str = get_prop_change(meta_modified)
296
434
        print >>to_file, '=== renamed %s %r => %r%s' % (
297
 
                    kind, old_label + old_path, new_label + new_path, prop_str)
298
 
        _maybe_diff_file_or_symlink(old_label, old_path, old_tree, file_id,
299
 
                                    new_label, new_path, new_tree,
 
435
                    kind, old_path.encode('utf8'),
 
436
                    new_path.encode('utf8'), prop_str)
 
437
        old_name = '%s%s\t%s' % (old_label, old_path,
 
438
                                 _patch_header_date(old_tree, file_id,
 
439
                                                    old_path))
 
440
        new_name = '%s%s\t%s' % (new_label, new_path,
 
441
                                 _patch_header_date(new_tree, file_id,
 
442
                                                    new_path))
 
443
        _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
 
444
                                    new_name, new_tree,
300
445
                                    text_modified, kind, to_file, diff_file)
301
446
    for path, file_id, kind, text_modified, meta_modified in delta.modified:
302
447
        has_changes = 1
303
448
        prop_str = get_prop_change(meta_modified)
304
 
        print >>to_file, '=== modified %s %r%s' % (kind, old_label + path,
305
 
                    prop_str)
 
449
        print >>to_file, '=== modified %s %r%s' % (kind, path.encode('utf8'), prop_str)
 
450
        old_name = '%s%s\t%s' % (old_label, path,
 
451
                                 _patch_header_date(old_tree, file_id, path))
 
452
        new_name = '%s%s\t%s' % (new_label, path,
 
453
                                 _patch_header_date(new_tree, file_id, path))
306
454
        if text_modified:
307
 
            _maybe_diff_file_or_symlink(old_label, path, old_tree, file_id,
308
 
                                        new_label, path, new_tree,
 
455
            _maybe_diff_file_or_symlink(old_name, old_tree, file_id,
 
456
                                        new_name, new_tree,
309
457
                                        True, kind, to_file, diff_file)
310
458
 
311
459
    return has_changes
312
460
 
313
461
 
314
 
def _raise_if_doubly_unversioned(specific_files, old_tree, new_tree):
315
 
    """Complain if paths are not versioned in either tree."""
316
 
    if not specific_files:
 
462
def _patch_header_date(tree, file_id, path):
 
463
    """Returns a timestamp suitable for use in a patch header."""
 
464
    tm = time.gmtime(tree.get_file_mtime(file_id, path))
 
465
    return time.strftime('%Y-%m-%d %H:%M:%S +0000', tm)
 
466
 
 
467
 
 
468
def _raise_if_nonexistent(paths, old_tree, new_tree):
 
469
    """Complain if paths are not in either inventory or tree.
 
470
 
 
471
    It's OK with the files exist in either tree's inventory, or 
 
472
    if they exist in the tree but are not versioned.
 
473
    
 
474
    This can be used by operations such as bzr status that can accept
 
475
    unknown or ignored files.
 
476
    """
 
477
    mutter("check paths: %r", paths)
 
478
    if not paths:
317
479
        return
318
 
    old_unversioned = old_tree.filter_unversioned_files(specific_files)
319
 
    new_unversioned = new_tree.filter_unversioned_files(specific_files)
320
 
    unversioned = old_unversioned.intersection(new_unversioned)
321
 
    if unversioned:
322
 
        raise errors.PathsNotVersionedError(sorted(unversioned))
323
 
    
 
480
    s = old_tree.filter_unversioned_files(paths)
 
481
    s = new_tree.filter_unversioned_files(s)
 
482
    s = [path for path in s if not new_tree.has_filename(path)]
 
483
    if s:
 
484
        raise errors.PathsDoNotExist(sorted(s))
 
485
 
324
486
 
325
487
def get_prop_change(meta_modified):
326
488
    if meta_modified:
329
491
        return  ""
330
492
 
331
493
 
332
 
def _maybe_diff_file_or_symlink(old_label, old_path, old_tree, file_id,
333
 
                                new_label, new_path, new_tree, text_modified,
 
494
def _maybe_diff_file_or_symlink(old_path, old_tree, file_id,
 
495
                                new_path, new_tree, text_modified,
334
496
                                kind, to_file, diff_file):
335
497
    if text_modified:
336
498
        new_entry = new_tree.inventory[file_id]
337
499
        old_tree.inventory[file_id].diff(diff_file,
338
 
                                         old_label + old_path, old_tree,
339
 
                                         new_label + new_path, new_entry, 
 
500
                                         old_path, old_tree,
 
501
                                         new_path, new_entry, 
340
502
                                         new_tree, to_file)