18
18
"""Tests for the formatting and construction of errors."""
20
import bzrlib.bzrdir as bzrdir
21
import bzrlib.errors as errors
22
from bzrlib.tests import TestCaseWithTransport
24
from bzrlib.tests import TestCase, TestCaseWithTransport
27
# TODO: Make sure builtin exception class formats are consistent - e.g. should
28
# or shouldn't end with a full stop, etc.
25
31
class TestErrors(TestCaseWithTransport):
33
def test_inventory_modified(self):
34
error = errors.InventoryModified("a tree to be repred")
35
self.assertEqualDiff("The current inventory for the tree 'a tree to "
36
"be repred' has been modified, so a clean inventory cannot be "
37
"read without data loss.",
40
def test_install_failed(self):
41
error = errors.InstallFailed(['rev-one'])
42
self.assertEqual("Could not install revisions:\nrev-one", str(error))
43
error = errors.InstallFailed(['rev-one', 'rev-two'])
44
self.assertEqual("Could not install revisions:\nrev-one, rev-two",
46
error = errors.InstallFailed([None])
47
self.assertEqual("Could not install revisions:\nNone", str(error))
49
def test_knit_header_error(self):
50
error = errors.KnitHeaderError('line foo\n', 'path/to/file')
51
self.assertEqual("Knit header error: 'line foo\\n' unexpected"
52
" for file path/to/file", str(error))
54
def test_knit_index_unknown_method(self):
55
error = errors.KnitIndexUnknownMethod('http://host/foo.kndx',
57
self.assertEqual("Knit index http://host/foo.kndx does not have a"
58
" known method in options: ['bad', 'no-eol']",
61
def test_medium_not_connected(self):
62
error = errors.MediumNotConnected("a medium")
64
"The medium 'a medium' is not connected.", str(error))
27
66
def test_no_repo(self):
28
67
dir = bzrdir.BzrDir.create(self.get_url())
29
68
error = errors.NoRepositoryPresent(dir)
30
self.assertNotEqual(-1, str(error).find(repr(dir.transport.clone('..').base)))
31
self.assertEqual(-1, str(error).find(repr(dir.transport.base)))
69
self.assertNotEqual(-1, str(error).find((dir.transport.clone('..').base)))
70
self.assertEqual(-1, str(error).find((dir.transport.base)))
72
def test_no_smart_medium(self):
73
error = errors.NoSmartMedium("a transport")
74
self.assertEqualDiff("The transport 'a transport' cannot tunnel the "
78
def test_no_such_id(self):
79
error = errors.NoSuchId("atree", "anid")
80
self.assertEqualDiff("The file id anid is not present in the tree "
84
def test_not_write_locked(self):
85
error = errors.NotWriteLocked('a thing to repr')
86
self.assertEqualDiff("'a thing to repr' is not write locked but needs "
90
def test_too_many_concurrent_requests(self):
91
error = errors.TooManyConcurrentRequests("a medium")
92
self.assertEqualDiff("The medium 'a medium' has reached its concurrent "
93
"request limit. Be sure to finish_writing and finish_reading on "
94
"the current request that is open.",
33
97
def test_up_to_date(self):
34
98
error = errors.UpToDateFormat(bzrdir.BzrDirFormat4())
44
108
"Please run bzr reconcile on this repository." %
45
109
repo.bzrdir.root_transport.base,
112
def test_bzrnewerror_is_deprecated(self):
113
class DeprecatedError(errors.BzrNewError):
115
self.callDeprecated(['BzrNewError was deprecated in bzr 0.13; '
116
'please convert DeprecatedError to use BzrError instead'],
119
def test_bzrerror_from_literal_string(self):
120
# Some code constructs BzrError from a literal string, in which case
121
# no further formatting is done. (I'm not sure raising the base class
122
# is a great idea, but if the exception is not intended to be caught
123
# perhaps no more is needed.)
125
raise errors.BzrError('this is my errors; %d is not expanded')
126
except errors.BzrError, e:
127
self.assertEqual('this is my errors; %d is not expanded', str(e))
129
def test_reading_completed(self):
130
error = errors.ReadingCompleted("a request")
131
self.assertEqualDiff("The MediumRequest 'a request' has already had "
132
"finish_reading called upon it - the request has been completed and"
133
" no more data may be read.",
136
def test_writing_completed(self):
137
error = errors.WritingCompleted("a request")
138
self.assertEqualDiff("The MediumRequest 'a request' has already had "
139
"finish_writing called upon it - accept bytes may not be called "
143
def test_writing_not_completed(self):
144
error = errors.WritingNotComplete("a request")
145
self.assertEqualDiff("The MediumRequest 'a request' has not has "
146
"finish_writing called upon it - until the write phase is complete"
147
" no data may be read.",
150
def test_transport_not_possible(self):
151
e = errors.TransportNotPossible('readonly', 'original error')
152
self.assertEqual('Transport operation not possible:'
153
' readonly original error', str(e))
155
def assertSocketConnectionError(self, expected, *args, **kwargs):
156
"""Check the formatting of a SocketConnectionError exception"""
157
e = errors.SocketConnectionError(*args, **kwargs)
158
self.assertEqual(expected, str(e))
160
def test_socket_connection_error(self):
161
"""Test the formatting of SocketConnectionError"""
163
# There should be a default msg about failing to connect
164
# we only require a host name.
165
self.assertSocketConnectionError(
166
'Failed to connect to ahost',
169
# If port is None, we don't put :None
170
self.assertSocketConnectionError(
171
'Failed to connect to ahost',
173
# But if port is supplied we include it
174
self.assertSocketConnectionError(
175
'Failed to connect to ahost:22',
178
# We can also supply extra information about the error
179
# with or without a port
180
self.assertSocketConnectionError(
181
'Failed to connect to ahost:22; bogus error',
182
'ahost', port=22, orig_error='bogus error')
183
self.assertSocketConnectionError(
184
'Failed to connect to ahost; bogus error',
185
'ahost', orig_error='bogus error')
186
# An exception object can be passed rather than a string
187
orig_error = ValueError('bad value')
188
self.assertSocketConnectionError(
189
'Failed to connect to ahost; %s' % (str(orig_error),),
190
host='ahost', orig_error=orig_error)
192
# And we can supply a custom failure message
193
self.assertSocketConnectionError(
194
'Unable to connect to ssh host ahost:444; my_error',
195
host='ahost', port=444, msg='Unable to connect to ssh host',
196
orig_error='my_error')
200
class PassThroughError(errors.BzrError):
202
_fmt = """Pass through %(foo)s and %(bar)s"""
204
def __init__(self, foo, bar):
205
errors.BzrError.__init__(self, foo=foo, bar=bar)
208
class ErrorWithBadFormat(errors.BzrError):
210
_fmt = """One format specifier: %(thing)s"""
213
class ErrorWithNoFormat(errors.BzrError):
214
"""This class has a docstring but no format string."""
217
class TestErrorFormatting(TestCase):
219
def test_always_str(self):
220
e = PassThroughError(u'\xb5', 'bar')
221
self.assertIsInstance(e.__str__(), str)
222
# In Python str(foo) *must* return a real byte string
223
# not a Unicode string. The following line would raise a
224
# Unicode error, because it tries to call str() on the string
225
# returned from e.__str__(), and it has non ascii characters
227
self.assertEqual('Pass through \xc2\xb5 and bar', s)
229
def test_missing_format_string(self):
230
e = ErrorWithNoFormat(param='randomvalue')
231
s = self.callDeprecated(
232
['ErrorWithNoFormat uses its docstring as a format, it should use _fmt instead'],
236
"This class has a docstring but no format string.")
238
def test_mismatched_format_args(self):
239
# Even though ErrorWithBadFormat's format string does not match the
240
# arguments we constructing it with, we can still stringify an instance
241
# of this exception. The resulting string will say its unprintable.
242
e = ErrorWithBadFormat(not_thing='x')
243
self.assertStartsWith(
244
str(e), 'Unprintable exception ErrorWithBadFormat')
added
removed
bzrlib/tests/test_errors.py
